url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
β | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
β | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/11090 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11090/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11090/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11090/events | https://github.com/NVIDIA/NeMo/pull/11090 | 2,622,402,811 | PR_kwDOC_bI7s6ATQ1i | 11,090 | [WIP] porting speechllm_tts_2410 to NeMo 2.0 | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-29T21:54:11 | 2024-11-13T00:57:42 | 2024-11-13T00:57:42 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11090",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11090",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11090.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11090.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11090/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11090/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11089 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11089/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11089/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11089/events | https://github.com/NVIDIA/NeMo/pull/11089 | 2,622,105,779 | PR_kwDOC_bI7s6ASWbk | 11,089 | [NeMo-UX] Add option to drop optimizer states | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"[π€]: Hi @ashors1 π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12590114264) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @ashors1 π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12681743129) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.io.pl\nnemo/lightning/io/pl.py:86:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/io/pl.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/pl.py:68:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:77:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:304:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:309:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:312:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.callbacks.model_checkpoint\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:671:0: C0301: Line too long (146/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:112:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:175:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:252:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:259:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:263:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:22:0: W0611: Unused import lightning.pytorch (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.74/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.io.pl\nnemo/lightning/io/pl.py:86:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/io/pl.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/pl.py:68:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:77:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:304:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:309:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:312:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.callbacks.model_checkpoint\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:671:0: C0301: Line too long (146/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:112:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:175:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:252:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:259:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:263:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:22:0: W0611: Unused import lightning.pytorch (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.74/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.io.pl\nnemo/lightning/io/pl.py:86:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/io/pl.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/pl.py:68:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:77:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:304:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:309:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:312:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.callbacks.model_checkpoint\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:671:0: C0301: Line too long (146/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:112:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:175:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:252:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:259:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:263:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:22:0: W0611: Unused import lightning.pytorch (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.74/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.io.pl\nnemo/lightning/io/pl.py:86:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/io/pl.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/pl.py:68:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:77:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:304:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:309:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:312:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.callbacks.model_checkpoint\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:671:0: C0301: Line too long (146/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:112:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:175:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:252:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:259:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:263:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:22:0: W0611: Unused import lightning.pytorch (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.74/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning.io.pl\nnemo/lightning/io/pl.py:86:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/io/pl.py:62:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/pl.py:68:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:77:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:304:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:309:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:312:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.callbacks.model_checkpoint\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:671:0: C0301: Line too long (146/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:112:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:175:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:252:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:259:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:263:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/model_checkpoint.py:22:0: W0611: Unused import lightning.pytorch (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.74/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2024-10-29T19:07:21 | 2025-01-16T17:02:33 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11089",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11089",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11089.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11089.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11089/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11089/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11088 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11088/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11088/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11088/events | https://github.com/NVIDIA/NeMo/pull/11088 | 2,622,048,623 | PR_kwDOC_bI7s6ASLVj | 11,088 | Make nemo.collections.llm PreTrainingDataModule num samples configurable | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @hemildesai π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11625066114) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-29T18:37:31 | 2024-11-01T16:31:39 | 2024-11-01T16:31:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11088",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11088",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11088.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11088.patch",
"merged_at": "2024-11-01T16:31:37"
} | This is so that users can build a larger cache and reuse it across different runs. | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11088/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11088/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11087 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11087/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11087/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11087/events | https://github.com/NVIDIA/NeMo/pull/11087 | 2,621,989,782 | PR_kwDOC_bI7s6AR-mD | 11,087 | Disable CUDA graphs in DDP (ASR). Improve toggle messages | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @artbataev π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11579885212) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.parts.submodules.rnnt_greedy_decoding\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:37:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:38:0: C0301: Line too long (109/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:40:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:44:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:100:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:102:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:104:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:107:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:109:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:117:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:121:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:149:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:175:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:200:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:249:0: C0301: Line too long (108/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:292:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:294:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:296:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:299:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:301:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:309:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:313:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:390:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:391:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:404:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:410:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:420:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:451:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:467:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:530:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:532:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:534:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:537:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:539:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:547:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:551:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:571:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:572:0: C0301: Line too long (119/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:574:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:575:0: C0301: Line too long (116/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:578:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:581:0: C0301: Line too long (120/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:632:0: C0301: Line too long (115/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:636:0: C0301: Line too long (108/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:644:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:648:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:649:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:691:0: C0301: Line too long (119/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:759:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:782:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:803:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:823:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:835:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:840:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:852:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:867:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:873:0: C0301: Line too long (109/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:879:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:880:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:896:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:899:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:902:0: C0301: Line too long (119/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:904:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:926:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:937:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:944:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:981:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1003:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1026:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1039:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1040:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1042:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1047:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1048:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1052:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1064:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1077:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1084:0: C0301: Line too long (109/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1090:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1091:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1107:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1110:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1113:0: C0301: Line too long (119/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1115:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1138:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1149:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1156:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1178:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1200:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1212:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1236:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1265:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1290:0: C0301: Line too long (108/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1316:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1319:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1363:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1374:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1384:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1442:0: C0301: Line too long (121/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1562:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1572:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1573:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1599:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1624:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1626:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1628:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1630:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1632:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1640:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1644:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1691:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1697:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1707:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1717:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1746:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1760:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1767:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1775:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1828:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1830:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1832:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1834:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1836:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1844:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1848:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1918:0: C0301: Line too long (118/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1938:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1946:0: C0301: Line too long (119/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1947:0: C0301: Line too long (119/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1948:0: C0301: Line too long (116/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1950:0: C0301: Line too long (109/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1954:0: C0301: Line too long (108/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1975:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1988:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1993:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2005:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2010:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2011:0: C0301: Line too long (109/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2034:0: C0301: Line too long (109/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2041:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2055:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2058:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2061:0: C0301: Line too long (119/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2063:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2094:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2105:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2112:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2154:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2176:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2198:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2210:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2211:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2213:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2218:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2219:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2223:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2235:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2252:0: C0301: Line too long (109/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2259:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2273:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2276:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2279:0: C0301: Line too long (119/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2281:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2304:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2315:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2322:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2350:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2368:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2399:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2401:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2403:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2405:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2409:0: C0301: Line too long (118/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2411:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2412:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2420:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2424:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2505:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2506:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2519:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2526:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2537:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2593:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2598:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2671:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2673:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2675:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2677:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2681:0: C0301: Line too long (118/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2683:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2684:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2692:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2696:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2717:0: C0301: Line too long (120/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2836:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1:0: C0302: Too many lines in module (2851/1000) (too-many-lines)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1:0: C0114: Missing module docstring (missing-module-docstring)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:32:0: E0401: Unable to import 'numpy' (import-error)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:33:0: E0401: Unable to import 'torch' (import-error)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:34:0: E0401: Unable to import 'omegaconf' (import-error)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:48:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:172:8: C0103: Attribute name \"_SOS\" doesn't conform to snake_case naming style (invalid-name)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:157:4: R0913: Too many arguments (8/5) (too-many-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:157:4: R0917: Too many positional arguments (8/5) (too-many-positional-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:184:15: E1101: Instance of '_GreedyRNNTInfer' has no 'forward' member (no-member)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:335:4: R0913: Too many arguments (8/5) (too-many-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:335:4: R0917: Too many positional arguments (8/5) (too-many-positional-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:403:4: R0912: Too many branches (19/12) (too-many-branches)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:403:4: R0915: Too many statements (51/50) (too-many-statements)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:584:4: R0913: Too many arguments (10/5) (too-many-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:584:4: R0917: Too many positional arguments (10/5) (too-many-positional-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:644:28: C0415: Import outside toplevel (nemo.collections.asr.parts.submodules.cuda_graph_rnnt_greedy_decoding.RNNTGreedyDecodeCudaGraph) (import-outside-toplevel)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:668:8: R1705: Unnecessary \"else\" after \"return\", remove the \"else\" and de-indent the code inside it (no-else-return)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:687:8: R1705: Unnecessary \"else\" after \"return\", remove the \"else\" and de-indent the code inside it (no-else-return)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:691:12: C0415: Import outside toplevel (nemo.collections.asr.parts.submodules.cuda_graph_rnnt_greedy_decoding.RNNTGreedyDecodeCudaGraph) (import-outside-toplevel)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:747:8: W0613: Unused argument 'device' (unused-argument)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:764:4: R0914: Too many local variables (31/15) (too-many-locals)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:764:4: R0912: Too many branches (35/12) (too-many-branches)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:764:4: R0915: Too many statements (74/50) (too-many-statements)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:964:4: R0914: Too many local variables (34/15) (too-many-locals)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:964:4: R0912: Too many branches (36/12) (too-many-branches)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:964:4: R0915: Too many statements (79/50) (too-many-statements)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:993:12: W0612: Unused variable 'alignments' (unused-variable)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1177:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1213:12: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1221:4: R0914: Too many local variables (27/15) (too-many-locals)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1238:57: E1101: Instance of 'ExportedModelGreedyBatchedRNNTInfer' has no 'device' member (no-member)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1315:24: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1322:24: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1221:4: R0912: Too many branches (23/12) (too-many-branches)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1221:4: R0915: Too many statements (60/50) (too-many-statements)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1280:22: W0612: Unused variable 'pred_lengths' (unused-variable)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1285:20: W0612: Unused variable 'v' (unused-variable)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1352:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1355:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1362:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1362:0: R0902: Too many instance attributes (10/7) (too-many-instance-attributes)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1371:12: C0415: Import outside toplevel (onnx) (import-outside-toplevel)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1372:12: C0415: Import outside toplevel (onnxruntime) (import-outside-toplevel)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1374:12: W0707: Consider explicitly re-raising using 'except (ModuleNotFoundError, ImportError) as exc' and 'raise ImportError(f'`onnx` or `onnxruntime` could not be imported, please install the libraries.\\n') from exc' (raise-missing-from)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1374:30: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1429:20: W0612: Unused variable 'encoded_length' (unused-variable)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1438:19: W0612: Unused variable 'lengths' (unused-variable)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1481:16: W0612: Unused variable 'idx' (unused-variable)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1498:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1509:16: W0612: Unused variable 'shape_idx' (unused-variable)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1520:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1520:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1521:4: R0913: Too many arguments (6/5) (too-many-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1521:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1553:30: R1721: Unnecessary use of a comprehension, use list(arguments) instead. (unnecessary-comprehension)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1557:36: R1721: Unnecessary use of a comprehension, use list(arguments) instead. (unnecessary-comprehension)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1590:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1598:12: W0612: Unused variable 'state_id' (unused-variable)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1666:4: R0913: Too many arguments (9/5) (too-many-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1666:4: R0917: Too many positional arguments (9/5) (too-many-positional-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1690:4: R0914: Too many local variables (16/15) (too-many-locals)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1762:19: R1716: Simplify chained comparison between the operands (chained-comparison)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1690:4: R0912: Too many branches (21/12) (too-many-branches)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1690:4: R0915: Too many statements (57/50) (too-many-statements)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1870:4: R0913: Too many arguments (9/5) (too-many-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1870:4: R0917: Too many positional arguments (9/5) (too-many-positional-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1900:4: R0914: Too many local variables (33/15) (too-many-locals)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1970:16: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1977:16: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2009:20: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1900:4: R0912: Too many branches (41/12) (too-many-branches)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:1900:4: R0915: Too many statements (84/50) (too-many-statements)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2132:4: R0914: Too many local variables (31/15) (too-many-locals)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2132:4: R0912: Too many branches (37/12) (too-many-branches)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2132:4: R0915: Too many statements (78/50) (too-many-statements)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2344:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2350:84: W0108: Lambda may not be necessary (unnecessary-lambda)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2362:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2362:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2368:84: W0108: Lambda may not be necessary (unnecessary-lambda)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2446:4: R0913: Too many arguments (11/5) (too-many-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2446:4: R0917: Too many positional arguments (11/5) (too-many-positional-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2518:4: R0914: Too many local variables (21/15) (too-many-locals)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2518:4: R0912: Too many branches (23/12) (too-many-branches)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2518:4: R0915: Too many statements (68/50) (too-many-statements)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2554:12: W0612: Unused variable 'not_blank' (unused-variable)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2586:16: W0612: Unused variable 'd_v' (unused-variable)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2720:4: R0913: Too many arguments (12/5) (too-many-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2720:4: R0917: Too many positional arguments (12/5) (too-many-positional-arguments)\nnemo/collections/asr/parts/submodules/rnnt_greedy_decoding.py:2824:8: W0613: Unused argument 'device' (unused-argument)\n************* Module nemo.collections.asr.parts.submodules.rnnt_loop_labels_computer\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:54:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:63:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:64:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:65:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:67:0: C0301: Line too long (119/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:68:0: C0301: Line too long (118/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:70:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:74:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:75:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:119:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:195:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:246:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:263:0: C0301: Line too long (119/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:280:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:325:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:329:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:345:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:364:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:379:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:389:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:396:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:404:0: C0301: Line too long (115/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:406:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:430:0: C0301: Line too long (108/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:472:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:473:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:520:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:521:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:555:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:574:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:612:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:628:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:636:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:645:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:655:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:664:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:671:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:677:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:682:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:687:0: C0301: Line too long (108/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:696:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:702:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:703:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:712:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:734:0: C0301: Line too long (108/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:750:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:752:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:753:0: C0301: Line too long (116/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:757:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:763:0: C0301: Line too long (118/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:775:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:794:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:796:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:797:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:798:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:806:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:816:0: C0301: Line too long (118/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:851:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:852:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:853:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:861:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:876:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:877:0: C0301: Line too long (109/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:890:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:892:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:902:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:1:0: C0114: Missing module docstring (missing-module-docstring)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:18:0: E0401: Unable to import 'numpy' (import-error)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:19:0: E0401: Unable to import 'torch' (import-error)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:20:0: E0401: Unable to import 'torch.nn.functional' (import-error)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:21:0: E0401: Unable to import 'omegaconf' (import-error)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:43:0: R0902: Too many instance attributes (25/7) (too-many-instance-attributes)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:84:4: R0913: Too many arguments (10/5) (too-many-arguments)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:84:4: R0917: Too many positional arguments (10/5) (too-many-positional-arguments)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:43:0: R0903: Too few public methods (1/2) (too-few-public-methods)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:232:8: C0103: Attribute name \"_SOS\" doesn't conform to snake_case naming style (invalid-name)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:179:0: R0902: Too many instance attributes (12/7) (too-many-instance-attributes)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:192:4: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:202:4: R0913: Too many arguments (9/5) (too-many-arguments)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:202:4: R0917: Too many positional arguments (9/5) (too-many-positional-arguments)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:294:4: R0914: Too many local variables (31/15) (too-many-locals)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:294:4: R0915: Too many statements (57/50) (too-many-statements)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:593:8: W0613: Unused argument 'encoder_output_length' (unused-argument)\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:902:28: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)\n************* Module nemo.collections.asr.parts.submodules.tdt_loop_labels_computer\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:57:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:66:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:67:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:68:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:70:0: C0301: Line too long (119/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:71:0: C0301: Line too long (118/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:73:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:77:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:78:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:112:0: C0301: Line too long (109/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:124:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:201:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:232:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:233:0: C0301: Line too long (109/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:274:0: C0301: Line too long (119/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:291:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:308:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:344:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:348:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:369:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:388:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:405:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:419:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:422:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:430:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:440:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:448:0: C0301: Line too long (115/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:450:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:478:0: C0301: Line too long (118/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:481:0: C0301: Line too long (118/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:489:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:539:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:540:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:587:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:588:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:622:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:641:0: C0301: Line too long (110/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:681:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:697:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:705:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:714:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:724:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:733:0: C0301: Line too long (113/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:740:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:747:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:752:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:756:0: C0301: Line too long (108/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:767:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:772:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:773:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:784:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:806:0: C0301: Line too long (108/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:822:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:824:0: C0301: Line too long (104/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:825:0: C0301: Line too long (116/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:829:0: C0301: Line too long (111/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:835:0: C0301: Line too long (118/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:844:0: C0301: Line too long (118/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:849:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:867:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:870:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:887:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:889:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:890:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:891:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:899:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:909:0: C0301: Line too long (118/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:938:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:941:0: C0301: Line too long (102/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:969:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:970:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:971:0: C0301: Line too long (101/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:979:0: C0301: Line too long (106/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:994:0: C0301: Line too long (103/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:995:0: C0301: Line too long (109/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:1008:0: C0301: Line too long (107/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:1010:0: C0301: Line too long (105/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:1020:0: C0301: Line too long (114/100) (line-too-long)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:1:0: C0302: Too many lines in module (1026/1000) (too-many-lines)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:1:0: C0114: Missing module docstring (missing-module-docstring)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:19:0: E0401: Unable to import 'numpy' (import-error)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:20:0: E0401: Unable to import 'torch' (import-error)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:21:0: E0401: Unable to import 'torch.nn.functional' (import-error)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:22:0: E0401: Unable to import 'omegaconf' (import-error)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:44:0: R0902: Too many instance attributes (26/7) (too-many-instance-attributes)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:87:4: R0913: Too many arguments (11/5) (too-many-arguments)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:87:4: R0917: Too many positional arguments (11/5) (too-many-positional-arguments)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:44:0: R0903: Too few public methods (1/2) (too-few-public-methods)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:248:8: C0103: Attribute name \"_SOS\" doesn't conform to snake_case naming style (invalid-name)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:185:0: R0902: Too many instance attributes (15/7) (too-many-instance-attributes)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:198:4: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:208:4: R0913: Too many arguments (12/5) (too-many-arguments)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:208:4: R0917: Too many positional arguments (12/5) (too-many-positional-arguments)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:313:4: R0914: Too many local variables (35/15) (too-many-locals)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:313:4: R0915: Too many statements (65/50) (too-many-statements)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:660:8: W0613: Unused argument 'encoder_output_length' (unused-argument)\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:1020:28: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)\n************* Module nemo.collections.common.parts.optional_cuda_graphs\nnemo/collections/common/parts/optional_cuda_graphs.py:53:0: C0301: Line too long (118/100) (line-too-long)\nnemo/collections/common/parts/optional_cuda_graphs.py:79:0: C0301: Line too long (117/100) (line-too-long)\nnemo/collections/common/parts/optional_cuda_graphs.py:83:0: C0301: Line too long (112/100) (line-too-long)\nnemo/collections/common/parts/optional_cuda_graphs.py:88:0: C0301: Line too long (115/100) (line-too-long)\nnemo/collections/common/parts/optional_cuda_graphs.py:1:0: C0114: Missing module docstring (missing-module-docstring)\nnemo/collections/common/parts/optional_cuda_graphs.py:18:0: R0402: Use 'from torch import nn' instead (consider-using-from-import)\nnemo/collections/common/parts/optional_cuda_graphs.py:18:0: E0401: Unable to import 'torch.nn' (import-error)\n************* Module tests.collections.common.test_optional_cuda_graphs\ntests/collections/common/test_optional_cuda_graphs.py:1:0: C0114: Missing module docstring (missing-module-docstring)\ntests/collections/common/test_optional_cuda_graphs.py:16:0: R0402: Use 'from torch import nn' instead (consider-using-from-import)\ntests/collections/common/test_optional_cuda_graphs.py:16:0: E0401: Unable to import 'torch.nn' (import-error)\ntests/collections/common/test_optional_cuda_graphs.py:21:0: C0115: Missing class docstring (missing-class-docstring)\ntests/collections/common/test_optional_cuda_graphs.py:35:0: C0115: Missing class docstring (missing-class-docstring)\ntests/collections/common/test_optional_cuda_graphs.py:40:4: C0116: Missing function or method docstring (missing-function-docstring)\ntests/collections/common/test_optional_cuda_graphs.py:44:0: C0115: Missing class docstring (missing-class-docstring)\ntests/collections/common/test_optional_cuda_graphs.py:50:4: C0116: Missing function or method docstring (missing-function-docstring)\ntests/collections/common/test_optional_cuda_graphs.py:44:0: R0903: Too few public methods (1/2) (too-few-public-methods)\ntests/collections/common/test_optional_cuda_graphs.py:54:0: C0115: Missing class docstring (missing-class-docstring)\ntests/collections/common/test_optional_cuda_graphs.py:55:4: C0116: Missing function or method docstring (missing-function-docstring)\ntests/collections/common/test_optional_cuda_graphs.py:63:4: C0116: Missing function or method docstring (missing-function-docstring)\ntests/collections/common/test_optional_cuda_graphs.py:1:0: R0801: Similar lines in 2 files\n==nemo.collections.asr.parts.submodules.rnnt_loop_labels_computer:[467:606]\n==nemo.collections.asr.parts.submodules.tdt_loop_labels_computer:[534:673]\n )\n\n # stage 4: to avoid looping, go to next frame after max_symbols emission\n if self.max_symbols is not None:\n # if labels are non-blank (not end-of-utterance), check that last observed timestep with label:\n # if it is equal to the current time index, and number of observations is >= max_symbols, force blank\n force_blank_mask = torch.logical_and(\n active_mask,\n torch.logical_and(\n torch.logical_and(\n labels != self._blank_index,\n batched_hyps.last_timestep_lasts >= self.max_symbols,\n ),\n batched_hyps.last_timestep == time_indices,\n ),\n )\n time_indices += force_blank_mask # emit blank => advance time indices\n # update safe_time_indices, non-blocking\n torch.minimum(time_indices, last_timesteps, out=safe_time_indices)\n # same as: active_mask = time_indices < encoder_output_length\n torch.less(time_indices, encoder_output_length, out=active_mask)\n if use_alignments:\n return batched_hyps, alignments, last_decoder_state\n return batched_hyps, None, last_decoder_state\n\n def loop_labels_cuda_graphs(\n self,\n encoder_output: torch.Tensor,\n encoder_output_length: torch.Tensor,\n ) -> Tuple[rnnt_utils.BatchedHyps, Optional[rnnt_utils.BatchedAlignments], Any]:\n \"\"\"\n Implementation with CUDA graphs.\n\n Args:\n encoder_output: output from the encoder\n encoder_output_length: lengths of the utterances in `encoder_output`\n \"\"\"\n assert self.cuda_graphs_mode is not None\n\n # do not recalculate joint projection, project only once\n encoder_output = self.joint.project_encoder(encoder_output)\n current_batch_size = encoder_output.shape[0]\n current_max_time = encoder_output.shape[1]\n\n if torch.is_autocast_enabled():\n encoder_output = encoder_output.to(torch.get_autocast_gpu_dtype())\n\n # init or reinit graph\n if self.state is None or self.state.need_reinit(encoder_output):\n self._graph_reinitialize(encoder_output, encoder_output_length)\n\n # copy (projected) encoder output and lenghts\n self.state.encoder_output_projected[:current_batch_size, :current_max_time, ...].copy_(encoder_output)\n self.state.encoder_output_length[: encoder_output_length.shape[0]].copy_(encoder_output_length)\n # set length to zero for elements outside the current batch\n self.state.encoder_output_length[current_batch_size:].fill_(0)\n if self.cuda_graphs_mode is self.CudaGraphsMode.FULL_GRAPH:\n self.full_graph.replay()\n elif self.cuda_graphs_mode is self.CudaGraphsMode.NO_WHILE_LOOPS:\n self.separate_graphs.before_outer_loop.replay()\n while self.state.active_mask_any.item():\n self.separate_graphs.before_inner_loop.replay()\n while self.state.advance_mask_any.item():\n self.separate_graphs.inner_loop_code.replay()\n self.separate_graphs.after_inner_loop.replay()\n elif self.cuda_graphs_mode is self.CudaGraphsMode.NO_GRAPHS:\n # this mode is only for testing purposes\n # manual loop instead of using graphs\n self._before_outer_loop()\n while self.state.active_mask_any.item():\n self._before_inner_loop_get_decoder_output()\n self._before_inner_loop_get_joint_output()\n while self.state.advance_mask_any.item():\n self._inner_loop_code()\n self._after_inner_loop()\n else:\n raise NotImplementedError(f\"Unknown graph mode: {self.cuda_graphs_mode}\")\n\n return (\n self.state.batched_hyps,\n self.state.alignments,\n self.state.last_decoder_state,\n )\n\n @classmethod\n def _create_outer_while_loop_kernel(cls):\n \"\"\"\n Creates a kernel that evaluates whether to enter the outer loop body (not all hypotheses are decoded).\n Condition: while(active_mask_any).\n \"\"\"\n kernel_string = r\"\"\"\\\n typedef ...*[Comment body truncated]*",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-10-29T18:05:15 | 2024-12-06T02:04:46 | 2024-12-06T02:04:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11087",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11087",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11087.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11087.patch",
"merged_at": null
} | # What does this PR do ?
- disable CUDA graphs in label-looping algorithm in DDP mode
- improve CUDA graphs toggle message (log only if something changed)
Potentially fixes https://github.com/NVIDIA/NeMo/issues/10299
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11087/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11087/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11086 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11086/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11086/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11086/events | https://github.com/NVIDIA/NeMo/pull/11086 | 2,621,813,295 | PR_kwDOC_bI7s6ARbDm | 11,086 | Feature/conversations tarred | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"nice! \r\n1. can u add an example jsonl manifest in the PR description to show the idea after tarring?\r\n2. can this PR get rid of pre-creating lhotse shar in speech-to-speech training example since now we have codec on the fly extraction on audio? \r\n+@subhankar-ghosh "
] | 2024-10-29T16:45:55 | 2024-11-01T15:17:30 | 2024-11-01T15:17:28 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11086",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11086",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11086.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11086.patch",
"merged_at": "2024-11-01T15:17:28"
} | # What does this PR do ?
Support for multimodal conversation tar format writing and reading.
Script usage:
```bash
python scripts/speech_llm/export_conversations_to_tar.py --shard-size 100 \
in_manifest_conversations.jsonl \
out_tarred_conversations
```
Example output:
```
$ out_tarred_conversations
audio_0.tar audio_1.tar audio_2.tar manifest_0.jsonl manifest_1.jsonl manifest_2.jsonl
```
Example input_cfg for dataloader initialization:
```yaml
- input_cfg:
- type: multimodal_conversation
manifest_filepath: out_tarred_conversations/manifest_{0..2}.jsonl
tarred_audio_filepaths: out_tarred_conversations/audio_{0..2}.tar
audio_locator_tag: "[audio]"
```
Manifest JSONL format. One conversation per line. Mixed audio and text turns in user and assistant roles, supports {text,audio}-to-{text,audio}.
```
{"id":"page_0026_120644_conversation2","conversations":[{"value":"/data/conversations/mydataset/audio/user_turn0.wav","from":"User","type":"audio","duration":5.31},{"value":"Automatic speech recognition is a technology that allows computers to recognize and transcribe spoken language. In the NeMo Framework, ASR is used for tasks such as speech-to-text and voice recognition.","from":"Assistant","type":"text"},{"value":"/data/conversations/mydataset/audio/user_turn1.wav","from":"User","type":"audio","duration":5.61},{"value":"The NeMo Framework provides a range of tools and features for training and deploying ASR models, including model parallelism, data parallelism, and distributed checkpointing. This allows for faster training and inference times, as well as improved model accuracy and reliability.","from":"Assistant","type":"text"}]}
```
Unrolled for readability:
```
{
"id": "page_0026_120644_conversation2",
"conversations": [
{
"value": "/data/conversations/mydataset/audio/user_turn0.wav",
"from": "User",
"type": "audio",
"duration": 5.31
},
{
"value": "Automatic speech recognition is a technology that allows computers to recognize and transcribe spoken language. In the NeMo Framework, ASR is used for tasks such as speech-to-text and voice recognition.",
"from": "Assistant",
"type": "text"
},
{
"value": "/data/conversations/mydataset/audio/user_turn1.wav",
"from": "User",
"type": "audio",
"duration": 5.61
},
{
"value": "The NeMo Framework provides a range of tools and features for training and deploying ASR models, including model parallelism, data parallelism, and distributed checkpointing. This allows for faster training and inference times, as well as improved model accuracy and reliability.",
"from": "Assistant",
"type": "text"
}
]
}
```
The format stays the same after being exported to tarfile, but the audio turns are filled with the contents of the corresponding tar files on the fly.
JSONL manifest after tar export:
```
{
"id": "page_0026_120644_conversation2",
"conversations": [
{
"type": "audio",
"from": "User",
"duration": 5.3058125,
"value": "user_turn0.flac"
},
{
"type": "text",
"from": "Assistant",
"value": "Automatic speech recognition is a technology that allows computers to recognize and transcribe spoken language. In the NeMo Framework, ASR is used for tasks such as speech-to-text and voice recognition."
},
{
"type": "audio",
"from": "User",
"duration": 5.607625,
"value": "user_turn1.flac"
},
{
"type": "text",
"from": "Assistant",
"value": "The NeMo Framework provides a range of tools and features for training and deploying ASR models, including model parallelism, data parallelism, and distributed checkpointing. This allows for faster training and inference times, as well as improved model accuracy and reliability."
}
]
}
```
**Collection**: multimodal
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11086/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11086/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11085 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11085/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11085/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11085/events | https://github.com/NVIDIA/NeMo/pull/11085 | 2,621,733,326 | PR_kwDOC_bI7s6ARJwu | 11,085 | Add copyright notice | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-10-29T16:12:11 | 2024-10-29T16:14:28 | 2024-10-29T16:14:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11085",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11085",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11085.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11085.patch",
"merged_at": "2024-10-29T16:14:26"
} | Add copyright notice | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11085/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11085/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11084 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11084/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11084/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11084/events | https://github.com/NVIDIA/NeMo/pull/11084 | 2,621,694,504 | PR_kwDOC_bI7s6ARBqe | 11,084 | Cherry pick `Fix finalize model grad for PEFT (11065)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-29T15:56:47 | 2024-10-29T20:52:42 | 2024-10-29T20:52:42 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11084",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11084",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11084.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11084.patch",
"merged_at": "2024-10-29T20:52:41"
} | [π€]: Hi @cuichenx π,<br><br>we've cherry picked #11065 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11084/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11084/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11083 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11083/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11083/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11083/events | https://github.com/NVIDIA/NeMo/pull/11083 | 2,621,676,004 | PR_kwDOC_bI7s6AQ98e | 11,083 | Add copyright notice | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-10-29T15:50:04 | 2024-10-29T15:50:23 | 2024-10-29T15:50:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11083",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11083",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11083.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11083.patch",
"merged_at": "2024-10-29T15:50:21"
} | Add copyright notice | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11083/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11083/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11082 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11082/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11082/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11082/events | https://github.com/NVIDIA/NeMo/pull/11082 | 2,621,173,182 | PR_kwDOC_bI7s6APT6h | 11,082 | add deprecation note | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-29T12:58:18 | 2024-10-30T15:40:54 | 2024-10-30T15:40:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11082",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11082",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11082.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11082.patch",
"merged_at": "2024-10-30T15:40:53"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11082/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11082/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11081 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11081/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11081/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11081/events | https://github.com/NVIDIA/NeMo/pull/11081 | 2,620,858,601 | PR_kwDOC_bI7s6AOR7l | 11,081 | NeMo-UX: fix nemo-ux export path | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11587985387) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-29T10:45:34 | 2024-10-30T12:55:13 | 2024-10-30T12:55:12 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11081",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11081",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11081.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11081.patch",
"merged_at": "2024-10-30T12:55:12"
} | # What does this PR do ?
Fixes https://github.com/NVIDIA/NeMo/issues/10939
In particular changes include:
1) when using nemo_load setting setup_optimizers to False
2) load_context will try to load from /context or parent if it fails
3) when exporting to HF will prune padding from input and output layers to restore original vocab size.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11081/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11081/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11080 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11080/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11080/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11080/events | https://github.com/NVIDIA/NeMo/pull/11080 | 2,620,822,173 | PR_kwDOC_bI7s6AOKlg | 11,080 | ci: Less verbose infra alerts | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-29T10:30:45 | 2024-10-29T15:58:00 | 2024-10-29T15:57:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11080",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11080",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11080.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11080.patch",
"merged_at": "2024-10-29T15:57:58"
} | # What does this PR do ?
Previously we matched for substrings. Now for full words. Also remove 'GPU' and 'CUDA' as this appears too often
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11080/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11080/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11079 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11079/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11079/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11079/events | https://github.com/NVIDIA/NeMo/pull/11079 | 2,620,799,288 | PR_kwDOC_bI7s6AOFia | 11,079 | Minor fixes for NeMo 2.0 PTQ | {
"login": "Laplasjan107",
"id": 67481570,
"node_id": "MDQ6VXNlcjY3NDgxNTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/67481570?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Laplasjan107",
"html_url": "https://github.com/Laplasjan107",
"followers_url": "https://api.github.com/users/Laplasjan107/followers",
"following_url": "https://api.github.com/users/Laplasjan107/following{/other_user}",
"gists_url": "https://api.github.com/users/Laplasjan107/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Laplasjan107/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Laplasjan107/subscriptions",
"organizations_url": "https://api.github.com/users/Laplasjan107/orgs",
"repos_url": "https://api.github.com/users/Laplasjan107/repos",
"events_url": "https://api.github.com/users/Laplasjan107/events{/privacy}",
"received_events_url": "https://api.github.com/users/Laplasjan107/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @Laplasjan107 π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11572858412) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-29T10:20:27 | 2024-10-29T14:06:40 | 2024-10-29T14:06:38 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11079",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11079",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11079.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11079.patch",
"merged_at": "2024-10-29T14:06:37"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: llm
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Laplasjan107",
"id": 67481570,
"node_id": "MDQ6VXNlcjY3NDgxNTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/67481570?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Laplasjan107",
"html_url": "https://github.com/Laplasjan107",
"followers_url": "https://api.github.com/users/Laplasjan107/followers",
"following_url": "https://api.github.com/users/Laplasjan107/following{/other_user}",
"gists_url": "https://api.github.com/users/Laplasjan107/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Laplasjan107/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Laplasjan107/subscriptions",
"organizations_url": "https://api.github.com/users/Laplasjan107/orgs",
"repos_url": "https://api.github.com/users/Laplasjan107/repos",
"events_url": "https://api.github.com/users/Laplasjan107/events{/privacy}",
"received_events_url": "https://api.github.com/users/Laplasjan107/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11079/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11079/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11078 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11078/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11078/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11078/events | https://github.com/NVIDIA/NeMo/pull/11078 | 2,620,769,573 | PR_kwDOC_bI7s6AN-5w | 11,078 | Add doc-strings to import & export + improve logging | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @marcromeyn π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11575884737) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-29T10:08:47 | 2024-10-29T19:29:14 | 2024-10-29T19:29:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11078",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11078",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11078.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11078.patch",
"merged_at": "2024-10-29T19:29:13"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11078/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11078/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11077 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11077/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11077/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11077/events | https://github.com/NVIDIA/NeMo/pull/11077 | 2,620,732,379 | PR_kwDOC_bI7s6AN3Qi | 11,077 | ci: Switch to FW templates for build | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @ko3n1g π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11571708769) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @ko3n1g π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11617941308) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @ko3n1g π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11661837177) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @ko3n1g π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11680863549) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @ko3n1g π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11695924424) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-29T09:54:05 | 2024-11-06T08:39:34 | 2024-11-06T08:39:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11077",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11077",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11077.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11077.patch",
"merged_at": "2024-11-06T08:39:32"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11077/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11077/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11076 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11076/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11076/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11076/events | https://github.com/NVIDIA/NeMo/pull/11076 | 2,620,709,098 | PR_kwDOC_bI7s6ANyrn | 11,076 | ci: Fix cron schedule | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-29T09:45:04 | 2024-10-29T16:42:29 | 2024-10-29T16:42:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11076",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11076",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11076.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11076.patch",
"merged_at": "2024-10-29T16:42:29"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11076/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11076/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11075 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11075/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11075/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11075/events | https://github.com/NVIDIA/NeMo/pull/11075 | 2,620,679,620 | PR_kwDOC_bI7s6ANsTL | 11,075 | Version bump to `2.1.0rc1` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-10-29T09:35:38 | 2024-10-29T09:38:12 | 2024-10-29T09:38:09 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11075",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11075",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11075.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11075.patch",
"merged_at": null
} | π Version bump NeMo-Toolkit to `2.1.0rc1` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11075/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11075/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11074 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11074/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11074/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11074/events | https://github.com/NVIDIA/NeMo/issues/11074 | 2,620,676,842 | I_kwDOC_bI7s6cNFrq | 11,074 | Code adoptability for other pretrained ASR | {
"login": "Amg9794",
"id": 113574563,
"node_id": "U_kgDOBsUCow",
"avatar_url": "https://avatars.githubusercontent.com/u/113574563?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Amg9794",
"html_url": "https://github.com/Amg9794",
"followers_url": "https://api.github.com/users/Amg9794/followers",
"following_url": "https://api.github.com/users/Amg9794/following{/other_user}",
"gists_url": "https://api.github.com/users/Amg9794/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Amg9794/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Amg9794/subscriptions",
"organizations_url": "https://api.github.com/users/Amg9794/orgs",
"repos_url": "https://api.github.com/users/Amg9794/repos",
"events_url": "https://api.github.com/users/Amg9794/events{/privacy}",
"received_events_url": "https://api.github.com/users/Amg9794/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-10-29T09:34:40 | 2024-12-06T02:04:48 | 2024-12-06T02:04:47 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | can we adopt this confidence estimation method for other pretrained ASR model like whisper or any LLM based ASR ? As these model have more tendency to produce hallucination as compared to model used in this code ?
if yes so what things i need to take care ? | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11074/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 1
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11074/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11073 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11073/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11073/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11073/events | https://github.com/NVIDIA/NeMo/pull/11073 | 2,620,592,249 | PR_kwDOC_bI7s6ANZW2 | 11,073 | ci: Use code-freeze via Nemo-FW-Templates | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-29T09:05:59 | 2024-10-29T21:34:15 | 2024-10-29T21:34:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11073",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11073",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11073.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11073.patch",
"merged_at": "2024-10-29T21:34:13"
} | # What does this PR do ?
Here's the definition of the called workflow: https://github.com/NVIDIA/NeMo-FW-CI-templates/pull/2
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11073/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11073/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11072 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11072/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11072/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11072/events | https://github.com/NVIDIA/NeMo/pull/11072 | 2,620,494,589 | PR_kwDOC_bI7s6ANFZ7 | 11,072 | ci: Cherry pick CPU tests | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-29T08:21:12 | 2024-10-29T11:25:33 | 2024-10-29T11:25:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11072",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11072",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11072.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11072.patch",
"merged_at": "2024-10-29T11:25:32"
} | * ci: Switch to CPU only runner
* runner
* Raise EnvironmentError when CUDA is unavailable to prevent cuda-python failure
* Fix error message
* update
* fix
* finalize
---------
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11072/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11072/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11071 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11071/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11071/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11071/events | https://github.com/NVIDIA/NeMo/pull/11071 | 2,620,426,849 | PR_kwDOC_bI7s6AM32y | 11,071 | Akoumparouli/mixtral recipe fix r2.0.0 (#10994) | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-29T07:46:26 | 2024-10-29T18:46:37 | 2024-10-29T18:46:36 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11071",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11071",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11071.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11071.patch",
"merged_at": "2024-10-29T18:46:36"
} | * Mixtral TP8 EP1
* Apply isort and black reformatting
---------
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11071/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11071/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11070 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11070/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11070/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11070/events | https://github.com/NVIDIA/NeMo/pull/11070 | 2,620,052,573 | PR_kwDOC_bI7s6ALtLg | 11,070 | PEFT perf and TE spec fixes | {
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | {
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"[π€]: Hi @JimmyZhang12 π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11567567394) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @JimmyZhang12 π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11580196209) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-29T03:53:20 | 2024-10-30T06:17:19 | 2024-10-30T06:17:18 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11070",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11070",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11070.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11070.patch",
"merged_at": "2024-10-30T06:17:18"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11070/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11070/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11068 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11068/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11068/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11068/events | https://github.com/NVIDIA/NeMo/pull/11068 | 2,620,028,144 | PR_kwDOC_bI7s6ALow0 | 11,068 | Cherry pick `Performance fine-tuning recipes for llama3 8b + 70b (11046)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-29T03:30:10 | 2024-10-29T15:37:48 | 2024-10-29T15:37:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11068",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11068",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11068.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11068.patch",
"merged_at": "2024-10-29T15:37:47"
} | [π€]: Hi @vysarge π,<br><br>we've cherry picked #11046 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11068/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11068/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11067 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11067/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11067/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11067/events | https://github.com/NVIDIA/NeMo/pull/11067 | 2,619,837,179 | PR_kwDOC_bI7s6ALCKn | 11,067 | Bump `Dockerfile.ci` (2024-10-29) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-29T00:22:55 | 2024-11-04T09:21:31 | 2024-11-04T09:21:31 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11067",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11067",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11067.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11067.patch",
"merged_at": null
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11067/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11067/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11066 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11066/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11066/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11066/events | https://github.com/NVIDIA/NeMo/pull/11066 | 2,619,824,567 | PR_kwDOC_bI7s6AK_iT | 11,066 | Add copyright notice | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Copyright / documentation change"
] | 2024-10-29T00:10:26 | 2024-10-29T00:14:09 | 2024-10-29T00:14:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11066",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11066",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11066.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11066.patch",
"merged_at": "2024-10-29T00:14:08"
} | Add copyright notice | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11066/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11066/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11065 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11065/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11065/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11065/events | https://github.com/NVIDIA/NeMo/pull/11065 | 2,619,727,464 | PR_kwDOC_bI7s6AKt2w | 11,065 | Fix finalize model grad for PEFT | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @cuichenx π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11567032943) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-28T22:51:38 | 2024-10-29T15:56:19 | 2024-10-29T15:56:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11065",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11065",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11065.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11065.patch",
"merged_at": "2024-10-29T15:56:16"
} | # What does this PR do ?
Fix gradient reduction for PEFT
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11065/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11065/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11064 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11064/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11064/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11064/events | https://github.com/NVIDIA/NeMo/issues/11064 | 2,619,335,178 | I_kwDOC_bI7s6cH-IK | 11,064 | activate subscription: Not able to find the Promotional Code, Serial Number, or Token to run the inference script? | {
"login": "Alla-Abdella",
"id": 19640509,
"node_id": "MDQ6VXNlcjE5NjQwNTA5",
"avatar_url": "https://avatars.githubusercontent.com/u/19640509?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Alla-Abdella",
"html_url": "https://github.com/Alla-Abdella",
"followers_url": "https://api.github.com/users/Alla-Abdella/followers",
"following_url": "https://api.github.com/users/Alla-Abdella/following{/other_user}",
"gists_url": "https://api.github.com/users/Alla-Abdella/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Alla-Abdella/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Alla-Abdella/subscriptions",
"organizations_url": "https://api.github.com/users/Alla-Abdella/orgs",
"repos_url": "https://api.github.com/users/Alla-Abdella/repos",
"events_url": "https://api.github.com/users/Alla-Abdella/events{/privacy}",
"received_events_url": "https://api.github.com/users/Alla-Abdella/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-10-28T19:22:37 | 2024-12-05T02:05:36 | 2024-12-05T02:05:36 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Please activate your subscription:
Serial Numbers:
Serial numbers can be added in bulk, please comma separate them or line break all serial numbers
Submit serial numbers in bulk only if they are of the same hardware-software bundle type (e.g. RTX6000 or H100)
Tokens:
Tokens obtained from CSP-hosted virtual machine images must be submitted separately
Promotional Code, Serial Number, or Token
Enter promotional code, serial number, or token
Code is here:
``` # Choose a container name for bookkeeping
export CONTAINER_NAME=llama3-8b-instruct
# Define the vendor name for the LLM
export VENDOR_NAME=meta
# Choose a LLM NIM Image from NGC
export IMG_NAME="nvcr.io/nim/{VENDOR_NAME}/${CONTAINER_NAME}:1.0.0"
# Choose a path on your system to cache the downloaded models
export LOCAL_NIM_CACHE="~/.cache/nim"
mkdir -p "$LOCAL_NIM_CACHE"
# Start the LLM NIM
docker run -it --rm --name=$CONTAINER_NAME \
--runtime=nvidia \
--gpus all \
-e NGC_API_KEY \
-v "$LOCAL_NIM_CACHE:/opt/nim/.cache" \
-u $(id -u) \
-p 8000:8000 \
$IMG_NAME
```
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11064/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11064/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11063 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11063/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11063/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11063/events | https://github.com/NVIDIA/NeMo/pull/11063 | 2,619,074,989 | PR_kwDOC_bI7s6AInus | 11,063 | Add vlm generation function | {
"login": "meatybobby",
"id": 9738259,
"node_id": "MDQ6VXNlcjk3MzgyNTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/meatybobby",
"html_url": "https://github.com/meatybobby",
"followers_url": "https://api.github.com/users/meatybobby/followers",
"following_url": "https://api.github.com/users/meatybobby/following{/other_user}",
"gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions",
"organizations_url": "https://api.github.com/users/meatybobby/orgs",
"repos_url": "https://api.github.com/users/meatybobby/repos",
"events_url": "https://api.github.com/users/meatybobby/events{/privacy}",
"received_events_url": "https://api.github.com/users/meatybobby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"@yaoyu-33 Do we need to modify [mllama_generate.py](https://github.com/NVIDIA/NeMo/blob/main/scripts/vlm/mllama_generate.py) to use new generate function?",
"[π€]: Hi @meatybobby π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12399225063) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-28T17:35:45 | 2024-12-19T06:08:16 | 2024-12-19T06:08:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11063",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11063",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11063.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11063.patch",
"merged_at": "2024-12-19T06:08:15"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "meatybobby",
"id": 9738259,
"node_id": "MDQ6VXNlcjk3MzgyNTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/meatybobby",
"html_url": "https://github.com/meatybobby",
"followers_url": "https://api.github.com/users/meatybobby/followers",
"following_url": "https://api.github.com/users/meatybobby/following{/other_user}",
"gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions",
"organizations_url": "https://api.github.com/users/meatybobby/orgs",
"repos_url": "https://api.github.com/users/meatybobby/repos",
"events_url": "https://api.github.com/users/meatybobby/events{/privacy}",
"received_events_url": "https://api.github.com/users/meatybobby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11063/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11063/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11062 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11062/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11062/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11062/events | https://github.com/NVIDIA/NeMo/pull/11062 | 2,619,040,582 | PR_kwDOC_bI7s6AIgPA | 11,062 | Fix TRTLLM nemo2 activation parsing | {
"login": "meatybobby",
"id": 9738259,
"node_id": "MDQ6VXNlcjk3MzgyNTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/meatybobby",
"html_url": "https://github.com/meatybobby",
"followers_url": "https://api.github.com/users/meatybobby/followers",
"following_url": "https://api.github.com/users/meatybobby/following{/other_user}",
"gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions",
"organizations_url": "https://api.github.com/users/meatybobby/orgs",
"repos_url": "https://api.github.com/users/meatybobby/repos",
"events_url": "https://api.github.com/users/meatybobby/events{/privacy}",
"received_events_url": "https://api.github.com/users/meatybobby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @meatybobby π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11582040735) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-28T17:21:56 | 2024-10-30T18:26:05 | 2024-10-30T18:26:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11062",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11062",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11062.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11062.patch",
"merged_at": "2024-10-30T18:26:04"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11062/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11062/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11061 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11061/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11061/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11061/events | https://github.com/NVIDIA/NeMo/pull/11061 | 2,618,816,933 | PR_kwDOC_bI7s6AHw2n | 11,061 | fix: Resolve mutable default issue in MultiModalSampleConfig dataclass | {
"login": "michal2409",
"id": 14821051,
"node_id": "MDQ6VXNlcjE0ODIxMDUx",
"avatar_url": "https://avatars.githubusercontent.com/u/14821051?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michal2409",
"html_url": "https://github.com/michal2409",
"followers_url": "https://api.github.com/users/michal2409/followers",
"following_url": "https://api.github.com/users/michal2409/following{/other_user}",
"gists_url": "https://api.github.com/users/michal2409/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michal2409/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michal2409/subscriptions",
"organizations_url": "https://api.github.com/users/michal2409/orgs",
"repos_url": "https://api.github.com/users/michal2409/repos",
"events_url": "https://api.github.com/users/michal2409/events{/privacy}",
"received_events_url": "https://api.github.com/users/michal2409/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @michal2409 π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11557645177) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-28T15:47:43 | 2024-10-28T21:34:34 | 2024-10-28T21:34:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11061",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11061",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11061.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11061.patch",
"merged_at": "2024-10-28T21:34:32"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "michal2409",
"id": 14821051,
"node_id": "MDQ6VXNlcjE0ODIxMDUx",
"avatar_url": "https://avatars.githubusercontent.com/u/14821051?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michal2409",
"html_url": "https://github.com/michal2409",
"followers_url": "https://api.github.com/users/michal2409/followers",
"following_url": "https://api.github.com/users/michal2409/following{/other_user}",
"gists_url": "https://api.github.com/users/michal2409/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michal2409/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michal2409/subscriptions",
"organizations_url": "https://api.github.com/users/michal2409/orgs",
"repos_url": "https://api.github.com/users/michal2409/repos",
"events_url": "https://api.github.com/users/michal2409/events{/privacy}",
"received_events_url": "https://api.github.com/users/michal2409/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11061/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11061/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11060 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11060/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11060/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11060/events | https://github.com/NVIDIA/NeMo/pull/11060 | 2,618,760,765 | PR_kwDOC_bI7s6AHlsS | 11,060 | Breakout get_checkpoint from AutoResume | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-10-28T15:27:11 | 2024-11-20T02:01:23 | 2024-11-20T02:01:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11060",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11060",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11060.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11060.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11060/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11060/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11059 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11059/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11059/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11059/events | https://github.com/NVIDIA/NeMo/pull/11059 | 2,618,703,415 | PR_kwDOC_bI7s6AHZDb | 11,059 | Update T5 attention-mask shapes to be compatible with all attention-backend in new TE versions | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @huvunvidia π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11859622450) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @huvunvidia π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11873631626) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.t5.data.mock\nnemo/collections/llm/t5/data/mock.py:33:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/data/mock.py:71:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:82:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:87:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:92:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.t5.model.t5\nnemo/collections/llm/t5/model/t5.py:45:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:98:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:111:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:123:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:135:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:143:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:172:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:227:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:236:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:244:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:262:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:266:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:289:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:292:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:295:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:304:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:325:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:332:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:37:4: W0611: Unused import transformer_engine (unused-import)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_lm_encoder_decoder_model\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:102:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:138:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:231:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:253:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:261:0: C0301: Line too long (180/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:263:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:537:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:562:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:563:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:579:0: C0301: Line too long (180/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:619:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:647:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:648:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:800:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:924:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:992:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:993:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1162:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1228:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1235:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1248:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1351:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1353:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1355:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1356:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1358:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1359:0: C0301: Line too long (130/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1396:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1422:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1715:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1743:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:258:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:349:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:512:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:519:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:560:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:661:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:904:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1045:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1172:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1202:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.36/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.t5.data.mock\nnemo/collections/llm/t5/data/mock.py:33:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/data/mock.py:71:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:82:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:87:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/data/mock.py:92:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.t5.model.t5\nnemo/collections/llm/t5/model/t5.py:45:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:98:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:111:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:123:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:135:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:143:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:172:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:227:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:236:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:244:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/t5/model/t5.py:262:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:266:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:289:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:292:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:295:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:304:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:325:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:332:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/t5/model/t5.py:37:4: W0611: Unused import transformer_engine (unused-import)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_lm_encoder_decoder_model\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:102:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:138:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:231:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:253:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:261:0: C0301: Line too long (180/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:263:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:537:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:562:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:563:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:579:0: C0301: Line too long (180/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:619:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:647:0: C0301: Line too long (150/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:648:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:800:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:924:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:992:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:993:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1162:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1228:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1235:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1248:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1351:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1353:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1355:0: C0301: Line too long (166/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1356:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1358:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1359:0: C0301: Line too long (130/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1396:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1422:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1715:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1743:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:258:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:349:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:512:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:519:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:560:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:661:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:904:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1045:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1172:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_lm_encoder_decoder_model.py:1202:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.36/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[π€]: Hi @huvunvidia π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11898874484) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-28T15:04:26 | 2024-11-19T03:24:01 | 2024-11-19T03:23:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11059",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11059",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11059.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11059.patch",
"merged_at": "2024-11-19T03:23:59"
} | # What does this PR do ?
Update T5 attention-mask shapes (from b1ss to b11s) to be compatible with all attention-backend in new TE versions.
Along with that, the existing checkpoints used for CICD also need to be updated.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11059/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11059/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11058 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11058/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11058/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11058/events | https://github.com/NVIDIA/NeMo/pull/11058 | 2,618,446,589 | PR_kwDOC_bI7s6AGjnU | 11,058 | New extended prompt format for Canary, short utterances inference fix, and training micro-optimizations | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.common.prompts.canary2\nnemo/collections/common/prompts/canary2.py:37:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/common/prompts/canary2.py:30:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/prompts/canary2.py:121:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module scripts.speech_recognition.canary.build_canary_1b_special_tokenizer\nscripts/speech_recognition/canary/build_canary_1b_special_tokenizer.py:15:0: W0611: Unused Path imported from pathlib (unused-import)\n************* Module scripts.speech_recognition.canary.build_canary_2_special_tokenizer\nscripts/speech_recognition/canary/build_canary_2_special_tokenizer.py:86:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/speech_recognition/canary/build_canary_2_special_tokenizer.py:15:0: W0611: Unused import math (unused-import)\n************* Module nemo.collections.asr.data.audio_to_text_lhotse_prompted\nnemo/collections/asr/data/audio_to_text_lhotse_prompted.py:60:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/asr/data/audio_to_text_lhotse_prompted.py:27:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/data/audio_to_text_lhotse_prompted.py:113:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.models.aed_multitask_models\nnemo/collections/asr/models/aed_multitask_models.py:695:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:737:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:788:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:796:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:1070:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/models/aed_multitask_models.py:1136:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.asr.modules.transformer.transformer_modules\nnemo/collections/asr/modules/transformer/transformer_modules.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/transformer/transformer_modules.py:104:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/transformer/transformer_modules.py:163:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/transformer/transformer_modules.py:168:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/transformer/transformer_modules.py:219:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/modules/transformer/transformer_modules.py:25:0: W0611: Unused logging imported from nemo.utils (unused-import)\n************* Module nemo.collections.common.data.lhotse.dataloader\nnemo/collections/common/data/lhotse/dataloader.py:110:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:126:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:134:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:231:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:232:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:233:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:577:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:717:0: C0301: Line too long (213/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:724:0: C0301: Line too long (143/119) (line-too-long)\nnemo/collections/common/data/lhotse/dataloader.py:169:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:426:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:477:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:504:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:510:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:513:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:516:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:519:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:528:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:530:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:533:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:539:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:567:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:582:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:589:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/data/lhotse/dataloader.py:604:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.common.tokenizers.canary_tokenizer\nnemo/collections/common/tokenizers/canary_tokenizer.py:83:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/common/tokenizers/canary_tokenizer.py:56:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/canary_tokenizer.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/canary_tokenizer.py:64:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/canary_tokenizer.py:68:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/canary_tokenizer.py:108:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/common/tokenizers/canary_tokenizer.py:114:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.utils.exp_manager\nnemo/utils/exp_manager.py:353:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:378:0: C0301: Line too long (124/119) (line-too-long)\nnemo/utils/exp_manager.py:382:0: C0301: Line too long (122/119) (line-too-long)\nnemo/utils/exp_manager.py:387:0: C0301: Line too long (127/119) (line-too-long)\nnemo/utils/exp_manager.py:401:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:408:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:409:0: C0301: Line too long (126/119) (line-too-long)\nnemo/utils/exp_manager.py:411:0: C0301: Line too long (136/119) (line-too-long)\nnemo/utils/exp_manager.py:413:0: C0301: Line too long (139/119) (line-too-long)\nnemo/utils/exp_manager.py:423:0: C0301: Line too long (123/119) (line-too-long)\nnemo/utils/exp_manager.py:424:0: C0301: Line too long (128/119) (line-too-long)\nnemo/utils/exp_manager.py:425:0: C0301: Line too long (132/119) (line-too-long)\nnemo/utils/exp_manager.py:426:0: C0301: Line too long (127/119) (line-too-long)\nnemo/utils/exp_manager.py:514:0: C0301: Line too long (122/119) (line-too-long)\nnemo/utils/exp_manager.py:602:0: C0301: Line too long (208/119) (line-too-long)\nnemo/utils/exp_manager.py:603:0: C0301: Line too long (230/119) (line-too-long)\nnemo/utils/exp_manager.py:605:0: C0301: Line too long (178/119) (line-too-long)\nnemo/utils/exp_manager.py:642:0: C0301: Line too long (136/119) (line-too-long)\nnemo/utils/exp_manager.py:777:0: C0301: Line too long (121/119) (line-too-long)\nnemo/utils/exp_manager.py:785:0: C0301: Line too long (156/119) (line-too-long)\nnemo/utils/exp_manager.py:832:0: C0301: Line too long (141/119) (line-too-long)\nnemo/utils/exp_manager.py:840:0: C0301: Line too long (152/119) (line-too-long)\nnemo/utils/exp_manager.py:1110:0: C0301: Line too long (142/119) (line-too-long)\nnemo/utils/exp_manager.py:1134:0: C0301: Line too long (154/119) (line-too-long)\nnemo/utils/exp_manager.py:1200:0: C0301: Line too long (120/119) (line-too-long)\nnemo/utils/exp_manager.py:1219:0: C0301: Line too long (123/119) (line-too-long)\nnemo/utils/exp_manager.py:1245:0: C0301: Line too long (121/119) (line-too-long)\nnemo/utils/exp_manager.py:91:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:106:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:132:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:141:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:150:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:161:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/utils/exp_manager.py:274:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:277:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:280:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:283:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:286:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:289:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:292:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:295:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:333:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:336:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:339:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:342:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1126:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1227:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1246:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1249:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/utils/exp_manager.py:1265:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.41/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[π€]: Hi @pzelasko π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12167255600) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-28T13:34:38 | 2024-12-05T01:00:25 | 2024-12-05T01:00:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11058",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11058",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11058.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11058.patch",
"merged_at": "2024-12-05T01:00:24"
} | # What does this PR do ?
* New prompt format
* Prompt formatter definition
* Special tokenizer build script
* Unit tests for the new Canary prompt format.
* Micro-optimizations (16% faster training step)
* Option to enable loss mask on prompt tokens
* Fix for inference of very short utterances
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11058/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11058/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11057 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11057/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11057/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11057/events | https://github.com/NVIDIA/NeMo/pull/11057 | 2,617,624,707 | PR_kwDOC_bI7s6AD2L- | 11,057 | fix model_checkpoint.py | {
"login": "ethanhe42",
"id": 10027339,
"node_id": "MDQ6VXNlcjEwMDI3MzM5",
"avatar_url": "https://avatars.githubusercontent.com/u/10027339?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ethanhe42",
"html_url": "https://github.com/ethanhe42",
"followers_url": "https://api.github.com/users/ethanhe42/followers",
"following_url": "https://api.github.com/users/ethanhe42/following{/other_user}",
"gists_url": "https://api.github.com/users/ethanhe42/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ethanhe42/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ethanhe42/subscriptions",
"organizations_url": "https://api.github.com/users/ethanhe42/orgs",
"repos_url": "https://api.github.com/users/ethanhe42/repos",
"events_url": "https://api.github.com/users/ethanhe42/events{/privacy}",
"received_events_url": "https://api.github.com/users/ethanhe42/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @ethanhe42 π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11587584218) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-28T08:02:33 | 2024-10-30T16:42:25 | 2024-10-30T16:42:23 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11057",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11057",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11057.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11057.patch",
"merged_at": "2024-10-30T16:42:23"
} | # What does this PR do ?
support the case where monitor is the last metric in checkpoint name. for example 'global_step=1000'
# Usage
* You can potentially add a usage example below
```python
run.Config(
ModelCheckpoint,
monitor='global_step',
filename='{global_step}',
every_n_train_steps=1000,
save_top_k=3,
mode='max',
)
```
after fix:
```
0: [NeMo I 2024-10-28 01:06:24 model_checkpoint:310] Removed distributed checkpoint: nemo_experiments/default/checkpoints/global_step=70999.0
0: [NeMo I 2024-10-28 01:06:24 model_checkpoint:310] Removed distributed checkpoint: nemo_experiments/default/checkpoints/global_step=71999.0
0: [NeMo I 2024-10-28 01:06:24 model_checkpoint:310] Removed distributed checkpoint: nemo_experiments/default/checkpoints/global_step=72999.0
0: [NeMo I 2024-10-28 01:06:24 model_checkpoint:310] Removed distributed checkpoint: nemo_experiments/default/checkpoints/global_step=73999.0
0: [NeMo I 2024-10-28 01:06:24 model_checkpoint:310] Removed distributed checkpoint: nemo_experiments/default/checkpoints/global_step=74999.0
```
| {
"login": "ethanhe42",
"id": 10027339,
"node_id": "MDQ6VXNlcjEwMDI3MzM5",
"avatar_url": "https://avatars.githubusercontent.com/u/10027339?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ethanhe42",
"html_url": "https://github.com/ethanhe42",
"followers_url": "https://api.github.com/users/ethanhe42/followers",
"following_url": "https://api.github.com/users/ethanhe42/following{/other_user}",
"gists_url": "https://api.github.com/users/ethanhe42/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ethanhe42/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ethanhe42/subscriptions",
"organizations_url": "https://api.github.com/users/ethanhe42/orgs",
"repos_url": "https://api.github.com/users/ethanhe42/repos",
"events_url": "https://api.github.com/users/ethanhe42/events{/privacy}",
"received_events_url": "https://api.github.com/users/ethanhe42/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11057/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11057/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11056 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11056/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11056/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11056/events | https://github.com/NVIDIA/NeMo/pull/11056 | 2,617,081,093 | PR_kwDOC_bI7s6ACGkE | 11,056 | PEFT perf fixes (cherrypick 11070) | {
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-28T01:56:54 | 2024-10-30T21:31:57 | 2024-10-30T21:31:55 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11056",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11056",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11056.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11056.patch",
"merged_at": "2024-10-30T21:31:55"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11056/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11056/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11055 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11055/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11055/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11055/events | https://github.com/NVIDIA/NeMo/pull/11055 | 2,617,057,840 | PR_kwDOC_bI7s6ACBvr | 11,055 | lora perf fixes | {
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-28T01:35:55 | 2024-10-28T01:36:40 | 2024-10-28T01:36:18 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11055",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11055",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11055.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11055.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11055/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11055/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11054 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11054/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11054/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11054/events | https://github.com/NVIDIA/NeMo/pull/11054 | 2,616,988,978 | PR_kwDOC_bI7s6ABysT | 11,054 | Bump `Dockerfile.ci` (2024-10-28) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @ko3n1g π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11545084645) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-28T00:23:56 | 2024-10-28T08:12:25 | 2024-10-28T08:12:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11054",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11054",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11054.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11054.patch",
"merged_at": "2024-10-28T08:12:23"
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11054/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11054/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11053 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11053/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11053/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11053/events | https://github.com/NVIDIA/NeMo/pull/11053 | 2,616,691,071 | PR_kwDOC_bI7s6ABHOj | 11,053 | Fix timestamps tests | {
"login": "monica-sekoyan",
"id": 166123533,
"node_id": "U_kgDOCebYDQ",
"avatar_url": "https://avatars.githubusercontent.com/u/166123533?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/monica-sekoyan",
"html_url": "https://github.com/monica-sekoyan",
"followers_url": "https://api.github.com/users/monica-sekoyan/followers",
"following_url": "https://api.github.com/users/monica-sekoyan/following{/other_user}",
"gists_url": "https://api.github.com/users/monica-sekoyan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/monica-sekoyan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/monica-sekoyan/subscriptions",
"organizations_url": "https://api.github.com/users/monica-sekoyan/orgs",
"repos_url": "https://api.github.com/users/monica-sekoyan/repos",
"events_url": "https://api.github.com/users/monica-sekoyan/events{/privacy}",
"received_events_url": "https://api.github.com/users/monica-sekoyan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @monica-sekoyan π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11542150005) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-27T15:50:43 | 2024-10-27T17:51:33 | 2024-10-27T17:51:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11053",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11053",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11053.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11053.patch",
"merged_at": "2024-10-27T17:51:32"
} | # What does this PR do ?
Fix CTC and RNNT decoding timestamps tests to take into account empty texts that can predicted by dummy decoder during the test.
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11053/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11053/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11052 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11052/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11052/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11052/events | https://github.com/NVIDIA/NeMo/pull/11052 | 2,616,512,531 | PR_kwDOC_bI7s6AAsB_ | 11,052 | ci: Fix cron | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-27T10:58:53 | 2024-10-29T09:46:12 | 2024-10-29T09:46:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11052",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11052",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11052.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11052.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11052/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11052/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11051 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11051/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11051/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11051/events | https://github.com/NVIDIA/NeMo/pull/11051 | 2,616,229,726 | PR_kwDOC_bI7s6AAAkE | 11,051 | Bump `Dockerfile.ci` (2024-10-27) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @ko3n1g π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11536068991) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-27T00:24:27 | 2024-10-27T07:02:43 | 2024-10-27T07:02:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11051",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11051",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11051.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11051.patch",
"merged_at": "2024-10-27T07:02:41"
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11051/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11051/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11050 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11050/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11050/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11050/events | https://github.com/NVIDIA/NeMo/pull/11050 | 2,615,998,346 | PR_kwDOC_bI7s5__hWZ | 11,050 | Add copyright notice | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @pablo-garay π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11542977670) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-26T16:50:27 | 2024-10-28T00:49:42 | 2024-10-28T00:49:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11050",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11050",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11050.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11050.patch",
"merged_at": "2024-10-28T00:49:41"
} | Add copyright notices | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11050/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11050/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11049 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11049/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11049/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11049/events | https://github.com/NVIDIA/NeMo/pull/11049 | 2,615,784,869 | PR_kwDOC_bI7s5_--0P | 11,049 | fix: properly use enhanced_count_thres and max_num_speakers in diariz⦠| {
"login": "dvianisoho",
"id": 108027299,
"node_id": "U_kgDOBnBdow",
"avatar_url": "https://avatars.githubusercontent.com/u/108027299?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dvianisoho",
"html_url": "https://github.com/dvianisoho",
"followers_url": "https://api.github.com/users/dvianisoho/followers",
"following_url": "https://api.github.com/users/dvianisoho/following{/other_user}",
"gists_url": "https://api.github.com/users/dvianisoho/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dvianisoho/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dvianisoho/subscriptions",
"organizations_url": "https://api.github.com/users/dvianisoho/orgs",
"repos_url": "https://api.github.com/users/dvianisoho/repos",
"events_url": "https://api.github.com/users/dvianisoho/events{/privacy}",
"received_events_url": "https://api.github.com/users/dvianisoho/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"Can someone help me remove the stale label from this PR? ",
"@titu1994 @redoctopus, @jbalam-nv @okuchaiev please review",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.parts.utils.offline_clustering\nnemo/collections/asr/parts/utils/offline_clustering.py:716:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/parts/utils/offline_clustering.py:716:0: C0301: Line too long (156/119) (line-too-long)\nnemo/collections/asr/parts/utils/offline_clustering.py:1206:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/asr/parts/utils/offline_clustering.py:1215:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/asr/parts/utils/offline_clustering.py:1265:0: C0301: Line too long (154/119) (line-too-long)\nnemo/collections/asr/parts/utils/offline_clustering.py:1349:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/asr/parts/utils/offline_clustering.py:1350:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/asr/parts/utils/offline_clustering.py:1354:0: C0301: Line too long (158/119) (line-too-long)\nnemo/collections/asr/parts/utils/offline_clustering.py:1360:0: C0301: Line too long (148/119) (line-too-long)\nnemo/collections/asr/parts/utils/offline_clustering.py:1134:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.parts.utils.speaker_utils\nnemo/collections/asr/parts/utils/speaker_utils.py:84:0: C0301: Line too long (138/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:87:0: C0301: Line too long (130/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:117:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:250:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:447:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:618:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:890:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:942:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1294:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1302:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1324:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1325:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1326:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1333:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1335:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1351:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1352:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1353:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1364:0: C0301: Line too long (129/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1367:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1377:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1434:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1463:0: C0301: Line too long (127/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:1467:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/asr/parts/utils/speaker_utils.py:32:0: W0611: Unused SpeakerClustering imported from nemo.collections.asr.parts.utils.offline_clustering (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.66/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"@titu1994 @redoctopus, @jbalam-nv @okuchaiev please let me know if I am missing something here or doing something wrong. Apologies if so - this is my first contribution. I also opened issue for this here: https://github.com/NVIDIA/NeMo/issues/11440 but no response.\r\n\r\nThank you.",
"@titu1994 @redoctopus, @jbalam-nv @okuchaiev please let me know if I am missing something here or doing something wrong. Apologies if so - this is my first contribution. I also opened issue for this here: https://github.com/NVIDIA/NeMo/issues/11440 but no response yet.\r\n\r\nThank you.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"How can I reopen this PR?"
] | 2024-10-26T11:23:15 | 2025-01-12T11:55:26 | 2025-01-09T02:13:22 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11049",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11049",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11049.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11049.patch",
"merged_at": null
} | β¦ation
# What does this PR do ?
Fixes diarization so that it properly uses enhanced_count_thres and max_num_speakers from the config.
**Collection**: [Note which collection this PR will affect]
ASR
# Changelog
Bug fix to properly read configs
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [X ] Did you write any new necessary tests?
- [ X] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11049/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11049/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11048 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11048/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11048/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11048/events | https://github.com/NVIDIA/NeMo/pull/11048 | 2,615,458,327 | PR_kwDOC_bI7s5_-MeI | 11,048 | Add copyright check | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Sample execution:\r\nhttps://github.com/NVIDIA/NeMo/actions/runs/11563980809/job/32188323290?pr=11048\r\n",
"Sample execution (with more files with issues prior to change): https://github.com/NVIDIA/NeMo/actions/runs/11528195110/job/32094993197?pr=11048",
"After copyright notices were added, the copyright check rightfully passes\r\nhttps://github.com/NVIDIA/NeMo/actions/runs/11564887593/job/32190934995?pr=11048",
"Changes do not affect CI , so wont run CI"
] | 2024-10-26T02:11:26 | 2024-10-29T15:54:49 | 2024-10-29T15:54:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11048",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11048",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11048.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11048.patch",
"merged_at": "2024-10-29T15:54:47"
} | Add copyright check
Sample execution #1 (expected to fail):
https://github.com/NVIDIA/NeMo/actions/runs/11563980809/job/32188323290?pr=11048
Sample execution (with more files with issues prior to change) #2 (expected to fail): https://github.com/NVIDIA/NeMo/actions/runs/11528195110/job/32094993197?pr=11048
After copyright notices were added, the copyright check rightfully passes
https://github.com/NVIDIA/NeMo/actions/runs/11564887593/job/32190934995?pr=11048 | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11048/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11048/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11047 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11047/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11047/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11047/events | https://github.com/NVIDIA/NeMo/pull/11047 | 2,615,393,524 | PR_kwDOC_bI7s5_9-iU | 11,047 | Bump `Dockerfile.ci` (2024-10-26) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-26T00:21:50 | 2024-10-27T12:16:17 | 2024-10-27T12:16:17 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11047",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11047",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11047.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11047.patch",
"merged_at": null
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11047/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11047/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11046 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11046/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11046/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11046/events | https://github.com/NVIDIA/NeMo/pull/11046 | 2,615,277,882 | PR_kwDOC_bI7s5_9ohW | 11,046 | Performance fine-tuning recipes for llama3 8b + 70b | {
"login": "vysarge",
"id": 10239441,
"node_id": "MDQ6VXNlcjEwMjM5NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/10239441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vysarge",
"html_url": "https://github.com/vysarge",
"followers_url": "https://api.github.com/users/vysarge/followers",
"following_url": "https://api.github.com/users/vysarge/following{/other_user}",
"gists_url": "https://api.github.com/users/vysarge/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vysarge/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vysarge/subscriptions",
"organizations_url": "https://api.github.com/users/vysarge/orgs",
"repos_url": "https://api.github.com/users/vysarge/repos",
"events_url": "https://api.github.com/users/vysarge/events{/privacy}",
"received_events_url": "https://api.github.com/users/vysarge/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-25T22:36:41 | 2024-10-29T03:29:41 | 2024-10-29T03:29:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11046",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11046",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11046.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11046.patch",
"merged_at": "2024-10-29T03:29:41"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: llm
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11046/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11046/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11045 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11045/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11045/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11045/events | https://github.com/NVIDIA/NeMo/pull/11045 | 2,615,224,113 | PR_kwDOC_bI7s5_9cwx | 11,045 | [Doc fixes] update file names, installation instructions, bad links | {
"login": "erastorgueva-nv",
"id": 80532067,
"node_id": "MDQ6VXNlcjgwNTMyMDY3",
"avatar_url": "https://avatars.githubusercontent.com/u/80532067?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erastorgueva-nv",
"html_url": "https://github.com/erastorgueva-nv",
"followers_url": "https://api.github.com/users/erastorgueva-nv/followers",
"following_url": "https://api.github.com/users/erastorgueva-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/erastorgueva-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erastorgueva-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erastorgueva-nv/subscriptions",
"organizations_url": "https://api.github.com/users/erastorgueva-nv/orgs",
"repos_url": "https://api.github.com/users/erastorgueva-nv/repos",
"events_url": "https://api.github.com/users/erastorgueva-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/erastorgueva-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-10-25T22:07:14 | 2024-11-12T19:55:53 | 2024-11-12T19:55:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11045",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11045",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11045.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11045.patch",
"merged_at": "2024-11-12T19:55:51"
} | # What does this PR do ?
Small docs fixes
**Collection**: Docs
# Changelog
- update name of file referenced in `docs/source/asr/asr_language_modeling_and_customization.rst`
- replace out of date NeMo installation instrucitons with pointer to Installation page in user guide
- fix bad links
# Usage
N/A
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ N/A ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ N/A ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11045/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11045/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11044 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11044/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11044/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11044/events | https://github.com/NVIDIA/NeMo/pull/11044 | 2,615,139,432 | PR_kwDOC_bI7s5_9L-V | 11,044 | Cherry pick `PEFT Inference (11030)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-25T21:11:26 | 2024-10-25T23:48:25 | 2024-10-25T23:48:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11044",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11044",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11044.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11044.patch",
"merged_at": "2024-10-25T23:48:24"
} | [π€]: Hi @cuichenx π,<br><br>we've cherry picked #11030 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11044/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 1,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11044/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11043 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11043/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11043/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11043/events | https://github.com/NVIDIA/NeMo/pull/11043 | 2,615,066,071 | PR_kwDOC_bI7s5_88tw | 11,043 | [Cherrypick #10957 #11006] Packed seq recipes | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-25T20:40:41 | 2024-10-26T00:58:37 | 2024-10-26T00:58:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11043",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11043",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11043.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11043.patch",
"merged_at": "2024-10-26T00:58:36"
} | * add packed seq recipes
* Apply isort and black reformatting
* extraneous prefix
* Apply isort and black reformatting
---------
(cherry picked from commit 26ba6bd8d92f3bdff2343b7986e41dc5902089bf)
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11043/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11043/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11042 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11042/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11042/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11042/events | https://github.com/NVIDIA/NeMo/pull/11042 | 2,614,947,777 | PR_kwDOC_bI7s5_8lRw | 11,042 | Fix CPU ASR tests | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Merged in https://github.com/NVIDIA/NeMo/pull/11035"
] | 2024-10-25T19:30:58 | 2024-10-26T10:55:04 | 2024-10-26T10:54:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11042",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11042",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11042.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11042.patch",
"merged_at": null
} | # What does this PR do ?
Fix ASR tests on CPU when GPU driver is unavailable.
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11042/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11042/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11041 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11041/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11041/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11041/events | https://github.com/NVIDIA/NeMo/pull/11041 | 2,614,648,127 | PR_kwDOC_bI7s5_7nU1 | 11,041 | [Bug fix] In energon MultiModalSampleConfig use default_factory in dataclass | {
"login": "guyueh1",
"id": 140554423,
"node_id": "U_kgDOCGCwtw",
"avatar_url": "https://avatars.githubusercontent.com/u/140554423?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/guyueh1",
"html_url": "https://github.com/guyueh1",
"followers_url": "https://api.github.com/users/guyueh1/followers",
"following_url": "https://api.github.com/users/guyueh1/following{/other_user}",
"gists_url": "https://api.github.com/users/guyueh1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/guyueh1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/guyueh1/subscriptions",
"organizations_url": "https://api.github.com/users/guyueh1/orgs",
"repos_url": "https://api.github.com/users/guyueh1/repos",
"events_url": "https://api.github.com/users/guyueh1/events{/privacy}",
"received_events_url": "https://api.github.com/users/guyueh1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-25T16:56:22 | 2024-10-28T17:56:17 | 2024-10-28T17:56:17 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11041",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11041",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11041.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11041.patch",
"merged_at": "2024-10-28T17:56:17"
} | # What does this PR do ?
Use default_factory to provide default value in dataclass in energon MultiModalSampleConfig.
Because python3.12 dataclass type doesn't allow using mutable values as default of dataclass fields.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "thomasdhc",
"id": 9426164,
"node_id": "MDQ6VXNlcjk0MjYxNjQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/9426164?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/thomasdhc",
"html_url": "https://github.com/thomasdhc",
"followers_url": "https://api.github.com/users/thomasdhc/followers",
"following_url": "https://api.github.com/users/thomasdhc/following{/other_user}",
"gists_url": "https://api.github.com/users/thomasdhc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/thomasdhc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thomasdhc/subscriptions",
"organizations_url": "https://api.github.com/users/thomasdhc/orgs",
"repos_url": "https://api.github.com/users/thomasdhc/repos",
"events_url": "https://api.github.com/users/thomasdhc/events{/privacy}",
"received_events_url": "https://api.github.com/users/thomasdhc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11041/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11041/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11040 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11040/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11040/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11040/events | https://github.com/NVIDIA/NeMo/pull/11040 | 2,614,461,851 | PR_kwDOC_bI7s5_7BrD | 11,040 | NeMorun for NeMo 2.0 T5 finetuning | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @huvunvidia π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11578583956) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-25T15:41:37 | 2024-10-30T13:45:46 | 2024-10-30T13:45:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11040",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11040",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11040.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11040.patch",
"merged_at": "2024-10-30T13:45:44"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11040/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11040/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11039 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11039/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11039/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11039/events | https://github.com/NVIDIA/NeMo/pull/11039 | 2,614,312,796 | PR_kwDOC_bI7s5_6iqJ | 11,039 | Cherrypick Fix _strategy_lib tests (#11033) | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"CI passed: https://github.com/NVIDIA/NeMo/actions/runs/11520384080"
] | 2024-10-25T14:43:28 | 2024-10-25T16:16:19 | 2024-10-25T16:16:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11039",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11039",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11039.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11039.patch",
"merged_at": "2024-10-25T16:16:16"
} | * fix world size and don't mock
* cleanup global state
* check app state instead
* fix syntax nemo logger test
---------
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11039/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11039/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11038 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11038/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11038/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11038/events | https://github.com/NVIDIA/NeMo/pull/11038 | 2,614,125,451 | PR_kwDOC_bI7s5_57sA | 11,038 | ci: Re-add secrets detector | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-25T13:33:32 | 2024-10-29T07:16:37 | 2024-10-29T07:16:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11038",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11038",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11038.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11038.patch",
"merged_at": "2024-10-29T07:16:34"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11038/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11038/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11037 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11037/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11037/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11037/events | https://github.com/NVIDIA/NeMo/pull/11037 | 2,614,111,160 | PR_kwDOC_bI7s5_54la | 11,037 | Gemma2 in Nemo2 with Recipes | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @suiyoubi π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11580574510) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-25T13:27:25 | 2024-10-30T05:42:40 | 2024-10-30T05:42:40 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11037",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11037",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11037.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11037.patch",
"merged_at": "2024-10-30T05:42:40"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11037/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11037/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11036 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11036/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11036/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11036/events | https://github.com/NVIDIA/NeMo/pull/11036 | 2,613,978,970 | PR_kwDOC_bI7s5_5b_F | 11,036 | Set TE spec name for NeMo to HF checkpoint converters | {
"login": "kevalmorabia97",
"id": 28916987,
"node_id": "MDQ6VXNlcjI4OTE2OTg3",
"avatar_url": "https://avatars.githubusercontent.com/u/28916987?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kevalmorabia97",
"html_url": "https://github.com/kevalmorabia97",
"followers_url": "https://api.github.com/users/kevalmorabia97/followers",
"following_url": "https://api.github.com/users/kevalmorabia97/following{/other_user}",
"gists_url": "https://api.github.com/users/kevalmorabia97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kevalmorabia97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevalmorabia97/subscriptions",
"organizations_url": "https://api.github.com/users/kevalmorabia97/orgs",
"repos_url": "https://api.github.com/users/kevalmorabia97/repos",
"events_url": "https://api.github.com/users/kevalmorabia97/events{/privacy}",
"received_events_url": "https://api.github.com/users/kevalmorabia97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @kevalmorabia97 π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11564918866) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-25T12:31:17 | 2024-10-29T04:22:59 | 2024-10-29T04:22:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11036",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11036",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11036.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11036.patch",
"merged_at": "2024-10-29T04:22:58"
} | # What does this PR do ?
Currently the NeMo to HF Checkpoint converters assume the gpt model is restored with Transformer engine spec but it is possible `model_config.name` is set to something else. For example for pruning, distillation, quantization the spec used is `modelopt`. In such cases the script will fail. Hence setting spec name as `te_gpt` when loading the model in the checkpoint converters.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11036/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11036/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11035 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11035/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11035/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11035/events | https://github.com/NVIDIA/NeMo/pull/11035 | 2,613,642,554 | PR_kwDOC_bI7s5_4VxV | 11,035 | ci: Switch to CPU only runner | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @ko3n1g π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11516069796) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"[π€]: Hi @ko3n1g π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11525091191) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-25T09:55:51 | 2024-10-25T22:22:10 | 2024-10-25T22:22:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11035",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11035",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11035.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11035.patch",
"merged_at": "2024-10-25T22:22:09"
} | # What does this PR do ?
To do's:
- [ ] Rename `test-cpu-runner` to `azure-self-hosted-cpu`
- [ ] Merge
- [ ] Rename runner label
- [ ] Remove cpu label from gpu runners
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11035/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11035/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11034 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11034/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11034/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11034/events | https://github.com/NVIDIA/NeMo/pull/11034 | 2,613,583,819 | PR_kwDOC_bI7s5_4KID | 11,034 | Cherry pick `Update `BaseMegatronSampler` for compatibility with PTL's `_BatchProgress` (11016)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-25T09:31:23 | 2024-10-25T16:22:06 | 2024-10-25T16:22:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11034",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11034",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11034.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11034.patch",
"merged_at": "2024-10-25T16:22:04"
} | [π€]: Hi @ashors1 π,<br><br>we've cherry picked #11016 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11034/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11034/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11033 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11033/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11033/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11033/events | https://github.com/NVIDIA/NeMo/pull/11033 | 2,613,148,918 | PR_kwDOC_bI7s5_2tWu | 11,033 | Fix _strategy_lib tests | {
"login": "maanug-nv",
"id": 109391026,
"node_id": "U_kgDOBoUssg",
"avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maanug-nv",
"html_url": "https://github.com/maanug-nv",
"followers_url": "https://api.github.com/users/maanug-nv/followers",
"following_url": "https://api.github.com/users/maanug-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions",
"organizations_url": "https://api.github.com/users/maanug-nv/orgs",
"repos_url": "https://api.github.com/users/maanug-nv/repos",
"events_url": "https://api.github.com/users/maanug-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/maanug-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @maanug-nv π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11512952468) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-25T05:52:46 | 2024-10-25T08:08:42 | 2024-10-25T08:08:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11033",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11033",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11033.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11033.patch",
"merged_at": "2024-10-25T08:08:39"
} | # What does this PR do ?
Fixes model parallel init tests.
**Collection**: [Note which collection this PR will affect]
# Changelog
- run nemo model parallel init in test instead of mocking
- make assertions on app state
- destroy MCore global state and nemo app state
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11033/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11033/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11032 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11032/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11032/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11032/events | https://github.com/NVIDIA/NeMo/pull/11032 | 2,612,789,691 | PR_kwDOC_bI7s5_1hG8 | 11,032 | Bump `Dockerfile.ci` (2024-10-25) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-25T00:22:38 | 2024-10-26T08:56:03 | 2024-10-26T08:56:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11032",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11032",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11032.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11032.patch",
"merged_at": null
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11032/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11032/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11031 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11031/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11031/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11031/events | https://github.com/NVIDIA/NeMo/pull/11031 | 2,612,588,384 | PR_kwDOC_bI7s5_03Zb | 11,031 | Change dist ckpt defaults (#10913) | {
"login": "ShriyaPalsamudram",
"id": 69161273,
"node_id": "MDQ6VXNlcjY5MTYxMjcz",
"avatar_url": "https://avatars.githubusercontent.com/u/69161273?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ShriyaPalsamudram",
"html_url": "https://github.com/ShriyaPalsamudram",
"followers_url": "https://api.github.com/users/ShriyaPalsamudram/followers",
"following_url": "https://api.github.com/users/ShriyaPalsamudram/following{/other_user}",
"gists_url": "https://api.github.com/users/ShriyaPalsamudram/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ShriyaPalsamudram/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ShriyaPalsamudram/subscriptions",
"organizations_url": "https://api.github.com/users/ShriyaPalsamudram/orgs",
"repos_url": "https://api.github.com/users/ShriyaPalsamudram/repos",
"events_url": "https://api.github.com/users/ShriyaPalsamudram/events{/privacy}",
"received_events_url": "https://api.github.com/users/ShriyaPalsamudram/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-24T21:27:50 | 2024-10-25T17:36:04 | 2024-10-25T17:36:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11031",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11031",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11031.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11031.patch",
"merged_at": "2024-10-25T17:36:03"
} | Cherrypick #10913
---------
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11031/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11031/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11030 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11030/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11030/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11030/events | https://github.com/NVIDIA/NeMo/pull/11030 | 2,612,517,372 | PR_kwDOC_bI7s5_0oR4 | 11,030 | PEFT Inference | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @cuichenx π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11521949088) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-24T20:38:28 | 2024-11-13T13:18:22 | 2024-10-25T21:11:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11030",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11030",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11030.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11030.patch",
"merged_at": "2024-10-25T21:11:01"
} | # What does this PR do ?
Add adapter support to llm.generate
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# In llm.generate, simply replace base model checkpoint with adapter checkpoint
# The adapter checkpoint contains a reference to the base model it is trained on, so
# there is no need to specify the base model checkpoint
api.generate(
path="/path/to/peft/checkpoint",
...
)
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11030/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11030/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11029 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11029/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11029/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11029/events | https://github.com/NVIDIA/NeMo/pull/11029 | 2,612,444,698 | PR_kwDOC_bI7s5_0Yvi | 11,029 | Configure no restart validation loop in nl.Trainer | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7699956064,
"node_id": "LA_kwDOC_bI7s8AAAAByvQBYA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/skip-docs",
"name": "skip-docs",
"color": "796AF1",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @hemildesai π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11824030234) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-24T19:53:13 | 2024-11-13T22:21:42 | 2024-11-13T22:21:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11029",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11029",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11029.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11029.patch",
"merged_at": "2024-11-13T22:21:41"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11029/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11029/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11028 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11028/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11028/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11028/events | https://github.com/NVIDIA/NeMo/pull/11028 | 2,612,405,149 | PR_kwDOC_bI7s5_0QsM | 11,028 | Cherrypick Fix pip install (#11026) | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"CI passed: https://github.com/NVIDIA/NeMo/actions/runs/11521807470"
] | 2024-10-24T19:30:34 | 2024-10-25T18:49:08 | 2024-10-25T18:49:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11028",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11028",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11028.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11028.patch",
"merged_at": "2024-10-25T18:49:06"
} | * Move AutoTokenizer inline
* Move einops to common requirements
* Move AutoTokenizer import to top-level again in fine_tuning
* Move megatron init inside nemo.lightning
* Make megatron_lazy_init_context work when transformer-engine is not installed
* Only import get_nmt_tokenizer when needed
* Apply isort and black reformatting
---------
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11028/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11028/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11027 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11027/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11027/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11027/events | https://github.com/NVIDIA/NeMo/pull/11027 | 2,612,289,329 | PR_kwDOC_bI7s5_z4DP | 11,027 | Pip install | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-10-24T18:25:03 | 2024-11-15T02:02:26 | 2024-11-15T02:02:25 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11027",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11027",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11027.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11027.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11027/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11027/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11026 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11026/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11026/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11026/events | https://github.com/NVIDIA/NeMo/pull/11026 | 2,611,756,238 | PR_kwDOC_bI7s5_yGh4 | 11,026 | Fix pip install | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @marcromeyn π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11501299879) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"CI passed: https://github.com/NVIDIA/NeMo/actions/runs/11501299879"
] | 2024-10-24T14:20:04 | 2024-10-24T23:57:05 | 2024-10-24T18:16:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11026",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11026",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11026.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11026.patch",
"merged_at": "2024-10-24T18:16:36"
} | # What does this PR do ?
This PR makes sure that we can import nemo.collections.common when nemo-toolkit[lightning,common] is installed.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11026/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11026/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11025 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11025/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11025/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11025/events | https://github.com/NVIDIA/NeMo/issues/11025 | 2,611,659,217 | I_kwDOC_bI7s6bqsHR | 11,025 | RuntimeError: Function 'AcosBackward0' returned nan values in its 0th output. | {
"login": "gor2000",
"id": 89537093,
"node_id": "MDQ6VXNlcjg5NTM3MDkz",
"avatar_url": "https://avatars.githubusercontent.com/u/89537093?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gor2000",
"html_url": "https://github.com/gor2000",
"followers_url": "https://api.github.com/users/gor2000/followers",
"following_url": "https://api.github.com/users/gor2000/following{/other_user}",
"gists_url": "https://api.github.com/users/gor2000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gor2000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gor2000/subscriptions",
"organizations_url": "https://api.github.com/users/gor2000/orgs",
"repos_url": "https://api.github.com/users/gor2000/repos",
"events_url": "https://api.github.com/users/gor2000/events{/privacy}",
"received_events_url": "https://api.github.com/users/gor2000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-10-24T13:42:37 | 2024-12-01T02:12:11 | 2024-12-01T02:12:10 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I have this error:
**RuntimeError: Function 'AcosBackward0' returned nan values in its 0th output.**
I'm doing finetuning for verification.
I've tried with different datasets of different size but I always get the same error.
The only time I got this to work was by reducing the learning rate to 0.001, but it resulted in a significant drop in performance.
This is my config file:
name: &name "TitaNet-Finetune"
sample_rate: &sample_rate 16000
init_from_pretrained_model:
speaker_tasks:
name: 'titanet_large'
include: ["preprocessor","encoder"]
exclude: ["decoder.final"] # Add specific layer names here to exlude or just ["decoder"] if to exclude all of decoder pretrained weights
model:
train_ds:
manifest_filepath: ???
sample_rate: 16000
labels: null
batch_size: 16
shuffle: True
is_tarred: False
tarred_audio_filepaths: null
tarred_shard_strategy: "scatter"
augmentor:
speed:
prob: 0.3
sr: *sample_rate
resample_type: 'kaiser_fast'
min_speed_rate: 0.95
max_speed_rate: 1.05
validation_ds:
manifest_filepath: ???
sample_rate: 16000
labels: null
batch_size: 32
shuffle: False
model_defaults:
filters: 1024
repeat: 3
dropout: 0.1
separable: true
se: true
se_context_size: -1
kernel_size_factor: 1.0
preprocessor:
_target_: nemo.collections.asr.modules.AudioToMelSpectrogramPreprocessor
normalize: "per_feature"
window_size: 0.025
sample_rate: *sample_rate
window_stride: 0.01
window: "hann"
features: &n_mels 80
n_fft: 512
frame_splicing: 1
dither: 0.00001
encoder:
_target_: nemo.collections.asr.modules.ConvASREncoder
feat_in: *n_mels
activation: relu
conv_mask: true
jasper:
- filters: ${model.model_defaults.filters}
repeat: 1
kernel: [3]
stride: [1]
dilation: [1]
dropout: 0.0
residual: false
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
- filters: ${model.model_defaults.filters}
repeat: ${model.model_defaults.repeat}
kernel: [7]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
- filters: ${model.model_defaults.filters}
repeat: ${model.model_defaults.repeat}
kernel: [11]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
- filters: ${model.model_defaults.filters}
repeat: ${model.model_defaults.repeat}
kernel: [15]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
- filters: &enc_feat_out 3072
repeat: 1
kernel: [1]
stride: [1]
dilation: [1]
dropout: 0.0
residual: false
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
decoder:
_target_: nemo.collections.asr.modules.SpeakerDecoder
feat_in: *enc_feat_out
num_classes: ???
pool_mode: 'attention'
emb_sizes: 192
angular: True
loss:
_target_: nemo.collections.asr.losses.angularloss.AngularSoftmaxLoss # you could also use cross-entrophy loss
scale: 30
margin: 0.2
optim_param_groups:
encoder:
lr: .001
optim:
name: adamw
lr: .0001 #(original titanet-large was trained with 0.08 lr)
weight_decay: 0.0002
# scheduler setup
sched:
name: CosineAnnealing
warmup_ratio: 0.1
min_lr: 0.0
trainer:
devices: 1 # number of gpus (original titanet-large was trained on 4 nodes with 8 gpus each)
max_epochs: 100
max_steps: -1 # computed at runtime if not set
num_nodes: 1
accelerator: gpu
strategy: ddp
deterministic: True
enable_checkpointing: False
logger: False
log_every_n_steps: 1 # Interval of logging.
val_check_interval: 1.0 # Set to 0.25 to check 4 times per epoch, or an int for number of iterations
gradient_clip_val: 1.0
detect_anomaly: True
exp_manager:
exp_dir: null
name: *name
create_tensorboard_logger: True
create_checkpoint_callback: True
create_early_stopping_callback: True
early_stopping_callback_params:
monitor: "val_loss" # The metric that early stopping should consider.
mode: "min" # inform early stopping whether to look for increase or decrease in monitor.
min_delta: 0.001 # smallest change to consider as improvement.
patience: 20 # how many (continuous) validation cycles to wait with no improvement and stopping training.
verbose: True
strict: True
check_finite: True
log_rank_zero_only: False
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11025/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11025/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11024 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11024/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11024/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11024/events | https://github.com/NVIDIA/NeMo/pull/11024 | 2,611,643,214 | PR_kwDOC_bI7s5_xuK8 | 11,024 | add deprecation note | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @dimapihtar π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11500504272) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-24T13:36:34 | 2024-10-28T14:19:43 | 2024-10-28T14:19:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11024",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11024",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11024.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11024.patch",
"merged_at": "2024-10-28T14:19:41"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11024/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11024/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11023 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11023/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11023/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11023/events | https://github.com/NVIDIA/NeMo/pull/11023 | 2,611,234,343 | PR_kwDOC_bI7s5_wT4q | 11,023 | Cherry pick `Add a build option to load_context (10713)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-24T11:07:56 | 2024-10-24T13:48:09 | 2024-10-24T13:48:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11023",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11023",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11023.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11023.patch",
"merged_at": "2024-10-24T13:48:08"
} | [π€]: Hi @marcromeyn π,<br><br>we've cherry picked #10713 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11023/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11023/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11022 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11022/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11022/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11022/events | https://github.com/NVIDIA/NeMo/pull/11022 | 2,611,183,612 | PR_kwDOC_bI7s5_wIh3 | 11,022 | Akoumparouli/hf lit module peft ckpt bugfix | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11577250638) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-24T10:45:16 | 2024-10-30T01:40:03 | 2024-10-30T01:40:02 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11022",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11022",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11022.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11022.patch",
"merged_at": "2024-10-30T01:40:02"
} | # What does this PR do ?
Handle ckpt saving for `LinearAdapter` which does not have `sharded_state_dict`
Need to confirm both save & restore work correctly wrt to all saving options.
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11022/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11022/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11021 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11021/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11021/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11021/events | https://github.com/NVIDIA/NeMo/pull/11021 | 2,611,158,454 | PR_kwDOC_bI7s5_wC6y | 11,021 | Performance mode (#10926) and gpt3 175b cli (#10985) | {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-24T10:32:58 | 2024-10-24T17:31:33 | 2024-10-24T17:31:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11021",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11021",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11021.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11021.patch",
"merged_at": "2024-10-24T17:31:33"
} | * llama3 performance mode
* llama3 performance mode tests
* mixtral performance mode
* remove unused
* nemotron perf mode
* 405b, 174b perf mode
* perf mode comment
* Apply isort and black reformatting
---------
# What does this PR do ?
cheery-pick Performance mode (#10926) and gpt3 175b cli (#10985)
**Collection**: [llm]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11021/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11021/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11020 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11020/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11020/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11020/events | https://github.com/NVIDIA/NeMo/pull/11020 | 2,611,054,191 | PR_kwDOC_bI7s5_vrfO | 11,020 | Cherry pick `Change default for always_save_context to True (11014)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-24T09:53:01 | 2024-10-24T13:51:07 | 2024-10-24T13:51:05 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11020",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11020",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11020.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11020.patch",
"merged_at": "2024-10-24T13:51:05"
} | [π€]: Hi @athitten π,<br><br>we've cherry picked #11014 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11020/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11020/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11019 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11019/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11019/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11019/events | https://github.com/NVIDIA/NeMo/issues/11019 | 2,610,920,350 | I_kwDOC_bI7s6bn3ue | 11,019 | Deploy ASR STT Streaming model | {
"login": "rkchamp25",
"id": 43476979,
"node_id": "MDQ6VXNlcjQzNDc2OTc5",
"avatar_url": "https://avatars.githubusercontent.com/u/43476979?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rkchamp25",
"html_url": "https://github.com/rkchamp25",
"followers_url": "https://api.github.com/users/rkchamp25/followers",
"following_url": "https://api.github.com/users/rkchamp25/following{/other_user}",
"gists_url": "https://api.github.com/users/rkchamp25/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rkchamp25/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rkchamp25/subscriptions",
"organizations_url": "https://api.github.com/users/rkchamp25/orgs",
"repos_url": "https://api.github.com/users/rkchamp25/repos",
"events_url": "https://api.github.com/users/rkchamp25/events{/privacy}",
"received_events_url": "https://api.github.com/users/rkchamp25/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "vsl9",
"id": 4344862,
"node_id": "MDQ6VXNlcjQzNDQ4NjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4344862?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vsl9",
"html_url": "https://github.com/vsl9",
"followers_url": "https://api.github.com/users/vsl9/followers",
"following_url": "https://api.github.com/users/vsl9/following{/other_user}",
"gists_url": "https://api.github.com/users/vsl9/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vsl9/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vsl9/subscriptions",
"organizations_url": "https://api.github.com/users/vsl9/orgs",
"repos_url": "https://api.github.com/users/vsl9/repos",
"events_url": "https://api.github.com/users/vsl9/events{/privacy}",
"received_events_url": "https://api.github.com/users/vsl9/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "vsl9",
"id": 4344862,
"node_id": "MDQ6VXNlcjQzNDQ4NjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4344862?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vsl9",
"html_url": "https://github.com/vsl9",
"followers_url": "https://api.github.com/users/vsl9/followers",
"following_url": "https://api.github.com/users/vsl9/following{/other_user}",
"gists_url": "https://api.github.com/users/vsl9/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vsl9/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vsl9/subscriptions",
"organizations_url": "https://api.github.com/users/vsl9/orgs",
"repos_url": "https://api.github.com/users/vsl9/repos",
"events_url": "https://api.github.com/users/vsl9/events{/privacy}",
"received_events_url": "https://api.github.com/users/vsl9/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"@vsl9 can we deploy ASR Nemo checkpoints on Triton ? ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-10-24T08:59:21 | 2025-01-03T01:58:43 | 2025-01-03T01:58:43 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi
Any suggestions on how to deploy and scale the STT En FastConformer Hybrid Transducer-CTC Large Streaming Multi model. We have finetuned this model and need to handle 100 users (to start with) using this model.
We will receive the chunks of audio data through a websocket connection from our application. How do we tackle multiple users? Do we create multiple instances of the model? Do we connect multiple users to same model? We are using the following tutorial for doing the inference through the model. (https://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/Online_ASR_Microphone_Demo_Cache_Aware_Streaming.ipynb)
This notebook has a transcribe chunk function which takes an audio chunk and processes it. Can we do batch transcription here for multiple users?
Thank You | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11019/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11019/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11018 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11018/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11018/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11018/events | https://github.com/NVIDIA/NeMo/pull/11018 | 2,610,852,153 | PR_kwDOC_bI7s5_u-tl | 11,018 | Cleanup MegatronStep inside MegatronParallel | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-10-24T08:28:44 | 2024-11-15T02:02:27 | 2024-11-15T02:02:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11018",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11018",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11018.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11018.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11018/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11018/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11017 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11017/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11017/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11017/events | https://github.com/NVIDIA/NeMo/pull/11017 | 2,610,508,101 | PR_kwDOC_bI7s5_ty88 | 11,017 | nemo2 peft merge | {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.peft.api\nnemo/collections/llm/peft/api.py:36:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.llm.peft.lora\nnemo/collections/llm/peft/lora.py:50:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/peft/lora.py:56:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/llm/peft/lora.py:87:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/llm/peft/lora.py:99:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.73/10\n```\n\n---\n\nThank you for improving NeMo's documentation!",
"[π€]: Hi @HuiyingLi π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11948840175) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-24T05:26:59 | 2024-11-21T20:02:58 | 2024-11-21T20:02:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11017",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11017",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11017.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11017.patch",
"merged_at": "2024-11-21T20:02:57"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11017/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11017/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11016 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11016/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11016/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11016/events | https://github.com/NVIDIA/NeMo/pull/11016 | 2,610,492,901 | PR_kwDOC_bI7s5_tvlB | 11,016 | Update `BaseMegatronSampler` for compatibility with PTL's `_BatchProgress` | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @ashors1 π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11514387963) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-24T05:17:39 | 2024-10-25T09:31:00 | 2024-10-25T09:30:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11016",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11016",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11016.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11016.patch",
"merged_at": "2024-10-25T09:30:57"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11016/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11016/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11015 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11015/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11015/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11015/events | https://github.com/NVIDIA/NeMo/pull/11015 | 2,610,259,257 | PR_kwDOC_bI7s5_s7_U | 11,015 | Support exporting Nemotron-340B for TensorRT-LLM | {
"login": "jinyangyuan-nvidia",
"id": 154768711,
"node_id": "U_kgDOCTmVRw",
"avatar_url": "https://avatars.githubusercontent.com/u/154768711?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jinyangyuan-nvidia",
"html_url": "https://github.com/jinyangyuan-nvidia",
"followers_url": "https://api.github.com/users/jinyangyuan-nvidia/followers",
"following_url": "https://api.github.com/users/jinyangyuan-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/jinyangyuan-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jinyangyuan-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jinyangyuan-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/jinyangyuan-nvidia/orgs",
"repos_url": "https://api.github.com/users/jinyangyuan-nvidia/repos",
"events_url": "https://api.github.com/users/jinyangyuan-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/jinyangyuan-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@oyilmaz-nvidia Hi Onur, can you help review this PR?\r\nIn TRT-LLM 0.14 release, we are working to prepare documentation for multi-node deployment and we want to use Nemotron as an example. Without this fix, we cannot run through Nemotron on multi-node.",
"It seems the changes in [nemo/export/trt_llm/converter/model_converter.py](https://github.com/NVIDIA/NeMo/pull/11015/files/83299cc74d63a9f9868f94a6990c30c3e25ba546#diff-4a09132034fd9a231315e092fa057c1ad7a7db379985c97d776a8dd1ea995b25) is not necessary. I tested parallel_embedding still works without the changes. Could we remove the change on this file?"
] | 2024-10-24T02:46:45 | 2024-10-31T20:18:11 | 2024-10-31T20:18:11 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11015",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11015",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11015.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11015.patch",
"merged_at": "2024-10-31T20:18:11"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11015/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11015/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11014 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11014/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11014/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11014/events | https://github.com/NVIDIA/NeMo/pull/11014 | 2,610,216,861 | PR_kwDOC_bI7s5_szLV | 11,014 | Change default for always_save_context to True | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @athitten π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11492462758) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-24T02:08:35 | 2024-10-24T09:52:33 | 2024-10-24T09:52:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11014",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11014",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11014.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11014.patch",
"merged_at": "2024-10-24T09:52:32"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11014/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11014/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11013 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11013/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11013/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11013/events | https://github.com/NVIDIA/NeMo/pull/11013 | 2,610,096,058 | PR_kwDOC_bI7s5_sZAZ | 11,013 | Bump `Dockerfile.ci` (2024-10-24) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-24T00:22:23 | 2024-10-25T10:09:12 | 2024-10-25T10:09:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11013",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11013",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11013.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11013.patch",
"merged_at": null
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11013/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11013/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11012 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11012/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11012/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11012/events | https://github.com/NVIDIA/NeMo/pull/11012 | 2,610,083,372 | PR_kwDOC_bI7s5_sWVG | 11,012 | use __dict__ in check | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11490764197) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g",
"CI passed https://github.com/NVIDIA/NeMo/actions/runs/11490764197 "
] | 2024-10-24T00:08:38 | 2024-10-24T03:52:43 | 2024-10-24T03:52:42 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11012",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11012",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11012.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11012.patch",
"merged_at": "2024-10-24T03:52:42"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11012/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11012/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11011 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11011/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11011/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11011/events | https://github.com/NVIDIA/NeMo/pull/11011 | 2,609,938,459 | PR_kwDOC_bI7s5_r4AD | 11,011 | Add new args from mcore to Gemma 2 dot product attention | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"absorbed in #10959"
] | 2024-10-23T22:07:20 | 2024-10-23T22:12:24 | 2024-10-23T22:12:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11011",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11011",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11011.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11011.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11011/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11011/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11010 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11010/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11010/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11010/events | https://github.com/NVIDIA/NeMo/pull/11010 | 2,609,789,138 | PR_kwDOC_bI7s5_rWoL | 11,010 | Ashors/peft async ckpt | {
"login": "ShriyaPalsamudram",
"id": 69161273,
"node_id": "MDQ6VXNlcjY5MTYxMjcz",
"avatar_url": "https://avatars.githubusercontent.com/u/69161273?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ShriyaPalsamudram",
"html_url": "https://github.com/ShriyaPalsamudram",
"followers_url": "https://api.github.com/users/ShriyaPalsamudram/followers",
"following_url": "https://api.github.com/users/ShriyaPalsamudram/following{/other_user}",
"gists_url": "https://api.github.com/users/ShriyaPalsamudram/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ShriyaPalsamudram/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ShriyaPalsamudram/subscriptions",
"organizations_url": "https://api.github.com/users/ShriyaPalsamudram/orgs",
"repos_url": "https://api.github.com/users/ShriyaPalsamudram/repos",
"events_url": "https://api.github.com/users/ShriyaPalsamudram/events{/privacy}",
"received_events_url": "https://api.github.com/users/ShriyaPalsamudram/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-10-23T20:38:55 | 2024-10-23T20:40:25 | 2024-10-23T20:40:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11010",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11010",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11010.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11010.patch",
"merged_at": "2024-10-23T20:40:24"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ShriyaPalsamudram",
"id": 69161273,
"node_id": "MDQ6VXNlcjY5MTYxMjcz",
"avatar_url": "https://avatars.githubusercontent.com/u/69161273?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ShriyaPalsamudram",
"html_url": "https://github.com/ShriyaPalsamudram",
"followers_url": "https://api.github.com/users/ShriyaPalsamudram/followers",
"following_url": "https://api.github.com/users/ShriyaPalsamudram/following{/other_user}",
"gists_url": "https://api.github.com/users/ShriyaPalsamudram/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ShriyaPalsamudram/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ShriyaPalsamudram/subscriptions",
"organizations_url": "https://api.github.com/users/ShriyaPalsamudram/orgs",
"repos_url": "https://api.github.com/users/ShriyaPalsamudram/repos",
"events_url": "https://api.github.com/users/ShriyaPalsamudram/events{/privacy}",
"received_events_url": "https://api.github.com/users/ShriyaPalsamudram/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11010/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11010/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11009 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11009/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11009/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11009/events | https://github.com/NVIDIA/NeMo/pull/11009 | 2,609,694,810 | PR_kwDOC_bI7s5_rBt_ | 11,009 | Log_props output in TRT-LLM | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@athitten If this PR works for you, I'll do some cleanup and start the CI.",
"> @athitten If this PR works for you, I'll do some cleanup and start the CI.\r\n\r\n@oyilmaz-nvidia sorry I dint get a chance to test it out yet. I will test it tomorrow. But the PR looks good otherwise. Thank you!",
"Closing this since it'll be included here: https://github.com/NVIDIA/NeMo/pull/11233 "
] | 2024-10-23T19:48:38 | 2024-11-08T16:48:28 | 2024-11-08T16:48:28 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11009",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11009",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11009.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11009.patch",
"merged_at": null
} | # What does this PR do ?
Adds the functionality to return log_props from TRT-LLM using PyTriton. | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11009/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11009/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11007 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11007/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11007/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11007/events | https://github.com/NVIDIA/NeMo/pull/11007 | 2,609,275,148 | PR_kwDOC_bI7s5_pkC1 | 11,007 | Cherry pick `llm.generate fixes (10983)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-23T17:03:11 | 2024-10-23T19:02:54 | 2024-10-23T19:02:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11007",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11007",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11007.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11007.patch",
"merged_at": "2024-10-23T19:02:53"
} | [π€]: Hi @HuiyingLi π,<br><br>we've cherry picked #10983 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11007/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11007/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11006 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11006/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11006/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11006/events | https://github.com/NVIDIA/NeMo/pull/11006 | 2,609,260,003 | PR_kwDOC_bI7s5_pgsP | 11,006 | Expose packed seq in finetuning recipes | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @cuichenx π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11521928915) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-23T16:55:51 | 2024-10-25T19:58:05 | 2024-10-25T19:58:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11006",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11006",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11006.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11006.patch",
"merged_at": "2024-10-25T19:58:04"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11006/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11006/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11005 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11005/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11005/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11005/events | https://github.com/NVIDIA/NeMo/pull/11005 | 2,608,999,923 | PR_kwDOC_bI7s5_osQp | 11,005 | Cherry pick `Fix for crash with LoRA + tp_overlap_comm=false + sequence_parallel=true (10920)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-23T15:20:25 | 2024-10-23T16:45:02 | 2024-10-23T16:45:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11005",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11005",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11005.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11005.patch",
"merged_at": "2024-10-23T16:45:01"
} | [π€]: Hi @vysarge π,<br><br>we've cherry picked #10920 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11005/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11005/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11004 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11004/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11004/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11004/events | https://github.com/NVIDIA/NeMo/issues/11004 | 2,608,921,326 | I_kwDOC_bI7s6bgPru | 11,004 | canary-1b is not exportable | {
"login": "pdufour",
"id": 1239145,
"node_id": "MDQ6VXNlcjEyMzkxNDU=",
"avatar_url": "https://avatars.githubusercontent.com/u/1239145?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pdufour",
"html_url": "https://github.com/pdufour",
"followers_url": "https://api.github.com/users/pdufour/followers",
"following_url": "https://api.github.com/users/pdufour/following{/other_user}",
"gists_url": "https://api.github.com/users/pdufour/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pdufour/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pdufour/subscriptions",
"organizations_url": "https://api.github.com/users/pdufour/orgs",
"repos_url": "https://api.github.com/users/pdufour/repos",
"events_url": "https://api.github.com/users/pdufour/events{/privacy}",
"received_events_url": "https://api.github.com/users/pdufour/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"Hi just commenting since GH marked this as stale.",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-10-23T14:56:16 | 2025-01-01T02:03:43 | 2025-01-01T02:03:42 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
The Canary model is not exportable to onnx. It seems like it was not configured to be exportable.
**Steps/Code to reproduce bug**
```
import nemo.collections.asr as nemo_asr
def main():
# Load Canary model
model_name = "nvidia/canary-1b"
print(f"Loading model: {model_name}")
model = nemo_asr.models.ASRModel.from_pretrained(model_name=model_name)
# Prepare for export
model.eval()
# Try to export - this will raise the error
output_path = "canary.onnx"
print("Attempting ONNX export...")
model.export(
output_path,
onnx_opset_version=17,
verbose=True
)
if __name__ == "__main__":
main()
```
This gives the error:
```
AttributeError: 'EncDecMultiTaskModel' object has no attribute 'output_names'
Traceback:
File "venv/lib/python3.11/site-packages/streamlit/runtime/scriptrunner/exec_code.py", line 88, in exec_func_with_error_handling
result = func()
^^^^^^
File "venv/lib/python3.11/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 579, in code_to_exec
exec(code, module.__dict__)
File "app.py", line 22, in <module>
main()
File "app.py", line 15, in main
model.export(
File "nemo/core/classes/exportable.py", line 117, in export
out, descr, out_example = model._export(
^^^^^^^^^^^^^^
File "nemo/core/classes/exportable.py", line 196, in _export
output_names = self.output_names
^^^^^^^^^^^^^^^^^
File "venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1931, in __getattr__
raise AttributeError(
```
**Expected behavior**
I would expect to be able to export this model.
**Environment overview (please complete the following information)**
- Environment location: Mac
- Method of NeMo install: pip install | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11004/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11004/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/11003 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11003/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11003/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11003/events | https://github.com/NVIDIA/NeMo/pull/11003 | 2,607,889,295 | PR_kwDOC_bI7s5_lK76 | 11,003 | Cherry pick 51e9b7c 2.0.0 | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-23T09:23:31 | 2024-10-23T13:01:23 | 2024-10-23T13:01:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11003",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11003",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11003.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11003.patch",
"merged_at": "2024-10-23T13:01:21"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11003/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11003/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11002 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11002/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11002/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11002/events | https://github.com/NVIDIA/NeMo/pull/11002 | 2,607,434,293 | PR_kwDOC_bI7s5_jvs2 | 11,002 | NeMo 1.0: upcycle dense to moe | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11578189409) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-23T06:28:52 | 2024-10-30T01:40:17 | 2024-10-30T01:40:15 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11002",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11002",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11002.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11002.patch",
"merged_at": "2024-10-30T01:40:15"
} | # What does this PR do ?
```
python3 upcycle_dense_to_moe.py --model ../mistral_2l_extracted/ --num-experts 8 --output-path what-moe
```
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11002/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11002/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11001 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11001/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11001/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11001/events | https://github.com/NVIDIA/NeMo/pull/11001 | 2,606,806,178 | PR_kwDOC_bI7s5_hw6R | 11,001 | Bump `Dockerfile.ci` (2024-10-23) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @ko3n1g π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11470661097) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-23T00:22:28 | 2024-10-23T09:20:56 | 2024-10-23T09:20:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11001",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11001",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11001.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11001.patch",
"merged_at": "2024-10-23T09:20:54"
} | π PR to Bump `Dockerfile.ci`.
π Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
π Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11001/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11001/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/11000 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/11000/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/11000/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/11000/events | https://github.com/NVIDIA/NeMo/pull/11000 | 2,606,604,779 | PR_kwDOC_bI7s5_hNRz | 11,000 | Cherrypick Change recipes #10915 | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-10-22T21:54:34 | 2024-10-23T00:30:55 | 2024-10-23T00:30:55 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/11000",
"html_url": "https://github.com/NVIDIA/NeMo/pull/11000",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/11000.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/11000.patch",
"merged_at": "2024-10-23T00:30:55"
} | # What does this PR do ?
Cherrypick #10915 into r2.0.0
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/11000/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/11000/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10999 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10999/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10999/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10999/events | https://github.com/NVIDIA/NeMo/issues/10999 | 2,606,561,762 | I_kwDOC_bI7s6bXPni | 10,999 | Unable to export MSDD model to pt or ONNX | {
"login": "jingzhaoo",
"id": 44785835,
"node_id": "MDQ6VXNlcjQ0Nzg1ODM1",
"avatar_url": "https://avatars.githubusercontent.com/u/44785835?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jingzhaoo",
"html_url": "https://github.com/jingzhaoo",
"followers_url": "https://api.github.com/users/jingzhaoo/followers",
"following_url": "https://api.github.com/users/jingzhaoo/following{/other_user}",
"gists_url": "https://api.github.com/users/jingzhaoo/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jingzhaoo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jingzhaoo/subscriptions",
"organizations_url": "https://api.github.com/users/jingzhaoo/orgs",
"repos_url": "https://api.github.com/users/jingzhaoo/repos",
"events_url": "https://api.github.com/users/jingzhaoo/events{/privacy}",
"received_events_url": "https://api.github.com/users/jingzhaoo/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Hi. MSDD is not an end-to-end model that performs speaker diarization from audio to label and it does not support ONNX export.\nWe are less than a month ahead of releasing end-to-end speaker diarizer, so please try using the new model once it gets released. ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-10-22T21:32:02 | 2024-12-01T02:12:12 | 2024-12-01T02:12:12 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
`EncDecDiarLabelModel` inherits `ExportableEncDecModel` which inherits `Exportable`. That means it should be exported to pt or ONNX file. When I ran the following code to export it,
```
model = EncDecDiarLabelModel(cfg=modelConfig)
msdd_model.export(output="msdd_model.pt", input_example=input_example)
```
I ran into errors:
```
AttributeError: 'EncDecDiarLabelModel' object has no attribute 'input_names'
```
The `input_names` attribute is defined in`Exportable`at [here](https://github.com/NVIDIA/NeMo/blob/1ba8bb1c623c2b7e938549002f5b77ab02fbe4bc/nemo/core/classes/exportable.py#L320). Is this an issue related to Python MRO (method resolution order)?
**Steps/Code to reproduce bug**
I added some lines after [here](https://github.com/NVIDIA/NeMo/blob/1ba8bb1c623c2b7e938549002f5b77ab02fbe4bc/tests/collections/asr/test_diar_label_models.py#L155).
```
input_example = (input_signal, input_signal_length, emb_vectors, targets)
msdd_model.msdd._speaker_model.export(output="speaker_model.onnx")
msdd_model.export(output="msdd_model.pt", input_example=input_example)
```
**Expected behavior**
Both`speaker_model.py`and`msdd_model.pt` are generated.
**Environment overview (please complete the following information)**
- Environment location: Bare-metal
- Method of NeMo install: check out the latest NeMo (commit 9a66eeeac2aa62541476bb4b66ae375b70d2db83) and run `pip install -e ".[asr]"` under the root folder.
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version: Ubuntu 24.04
- PyTorch version: 2.4.1+cu124
- Python version: 3.11.10
**Additional context**
Add any other context about the problem here.
GPU model: Nvidia L4
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10999/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10999/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/10998 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10998/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10998/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10998/events | https://github.com/NVIDIA/NeMo/pull/10998 | 2,606,260,182 | PR_kwDOC_bI7s5_gK1H | 10,998 | Cherry pick llm.generate | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Related : https://github.com/NVIDIA/NeMo/pull/10471"
] | 2024-10-22T19:09:28 | 2024-10-22T23:33:36 | 2024-10-22T23:33:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10998",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10998",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10998.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10998.patch",
"merged_at": "2024-10-22T23:33:34"
} | * Add llm.generate
* Remove comment
* Apply isort and black reformatting
* Fix launching with python
* PR feedback
* PR feedback
* Apply isort and black reformatting
* Add assert cp
* Add example script
* Fix
---------
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10998/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10998/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10997 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10997/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10997/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10997/events | https://github.com/NVIDIA/NeMo/issues/10997 | 2,606,222,492 | I_kwDOC_bI7s6bV8yc | 10,997 | srun issue with nemorun | {
"login": "RachitBansal",
"id": 18123052,
"node_id": "MDQ6VXNlcjE4MTIzMDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/18123052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/RachitBansal",
"html_url": "https://github.com/RachitBansal",
"followers_url": "https://api.github.com/users/RachitBansal/followers",
"following_url": "https://api.github.com/users/RachitBansal/following{/other_user}",
"gists_url": "https://api.github.com/users/RachitBansal/gists{/gist_id}",
"starred_url": "https://api.github.com/users/RachitBansal/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RachitBansal/subscriptions",
"organizations_url": "https://api.github.com/users/RachitBansal/orgs",
"repos_url": "https://api.github.com/users/RachitBansal/repos",
"events_url": "https://api.github.com/users/RachitBansal/events{/privacy}",
"received_events_url": "https://api.github.com/users/RachitBansal/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Can you try adding `executor.srun_args = [\"--mpi=pmix\"]` and see if that works?",
"@hemildesai \nHow do I set that argument? I don't see it in the listed arguments with the command `nemorun llm pretrain --help`:\n\n\n",
"In the current version of the repo, the `srun_args` ([here](https://github.com/NVIDIA/NeMo/blob/f27a982ed192f8039d5a30b51208847c9c1b0fc3/nemo/collections/common/parts/run_utils.py#L496)) seem to have the `--mpi=pmix` command by default? However, I still see the same error as before.",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-10-22T18:51:53 | 2024-12-05T02:05:38 | 2024-12-05T02:05:38 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I am trying to run a simple pretraining job with nemorun: `nemorun llm pretrain --factory llama3_8b`
However, I see the following error before the training starts:
```
The application appears to have been direct launched using "srun",
but OMPI was not built with SLURM's PMI support and therefore cannot
execute. There are several options for building PMI support under
SLURM, depending upon the SLURM version you are using:
version 16.05 or later: you can use SLURM's PMIx support. This
requires that you configure and build SLURM --with-pmix.
Versions earlier than 16.05: you must use either SLURM's PMI-1 or
PMI-2 support. SLURM builds PMI-1 by default, or you can manually
install PMI-2. You must then build Open MPI using --with-pmi pointing
to the SLURM PMI library location.
Please configure as appropriate and try again.
```
I understand that this is a problem with the way openmpi is configured on my cluster but I can't change it.
An alternate solution that I have been told is to replace the `srun` command with something like `mpirun -np`. I want to try this but I am unable to locate where the `srun` command is being run in the first place? I dug into the [slurm.py file in NeMo-run](https://github.com/NVIDIA/NeMo-Run/blob/main/src/nemo_run/core/execution/slurm.py), but changing the commands there did not yield any difference.
Are there any other potential alternatives to this? | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10997/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10997/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/10996 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10996/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10996/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10996/events | https://github.com/NVIDIA/NeMo/pull/10996 | 2,606,217,858 | PR_kwDOC_bI7s5_gCgo | 10,996 | Cherry pick `Fix TRTLLM parallel_embedding (10975)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-22T18:49:20 | 2024-10-22T22:13:38 | 2024-10-22T22:13:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10996",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10996",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10996.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10996.patch",
"merged_at": "2024-10-22T22:13:37"
} | [π€]: Hi @meatybobby π,<br><br>we've cherry picked #10975 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10996/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10996/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10995 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10995/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10995/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10995/events | https://github.com/NVIDIA/NeMo/pull/10995 | 2,606,157,647 | PR_kwDOC_bI7s5_f2Zk | 10,995 | Fix export of configuration parameters to Weights and Biases | {
"login": "soluwalana",
"id": 558812,
"node_id": "MDQ6VXNlcjU1ODgxMg==",
"avatar_url": "https://avatars.githubusercontent.com/u/558812?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/soluwalana",
"html_url": "https://github.com/soluwalana",
"followers_url": "https://api.github.com/users/soluwalana/followers",
"following_url": "https://api.github.com/users/soluwalana/following{/other_user}",
"gists_url": "https://api.github.com/users/soluwalana/gists{/gist_id}",
"starred_url": "https://api.github.com/users/soluwalana/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/soluwalana/subscriptions",
"organizations_url": "https://api.github.com/users/soluwalana/orgs",
"repos_url": "https://api.github.com/users/soluwalana/repos",
"events_url": "https://api.github.com/users/soluwalana/events{/privacy}",
"received_events_url": "https://api.github.com/users/soluwalana/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@ericharper @titu1994 can you trigger the Nemo_CICD_Test, cicd-test-container-setup, and gpu-test actions?"
] | 2024-10-22T18:18:52 | 2024-11-05T18:56:09 | 2024-11-05T18:56:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10995",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10995",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10995.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10995.patch",
"merged_at": "2024-11-05T18:56:09"
} | # What does this PR do ?
This PR corrects an error in ModelPT.py that only partially converts the _hparams_initial from an OmegaConf object to a dictionary before exporting to the various loggers.
This was particularly an issue with search functionality based on metadata in Weights and Biases due to the cfg object being a string representation of the OmegaConf object.
**Collection**: Core
# Changelog
- Adds an additional check and conversion of the OmegaConf self._cfg to ensure that Logger.log_hyperparameters from Pytorch Lightning is guaranteed to find a JSON compatible structure at L1650 of core/classes/ModelPT.py
## Reference Images
### Prior to fix
cfg is recorded as a str(OmegaConf.DictConfig) in Weights and Biases

### After fix
cfg is correctly searchable in Weights and Biases

# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue) LLM-5007
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10995/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10995/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10994 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10994/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10994/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10994/events | https://github.com/NVIDIA/NeMo/pull/10994 | 2,606,072,090 | PR_kwDOC_bI7s5_flud | 10,994 | Akoumparouli/mixtral recipe fix r2.0.0 | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"[π€]: Hi @akoumpa π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11492357029) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-22T17:34:27 | 2024-10-24T20:59:53 | 2024-10-24T20:59:51 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10994",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10994",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10994.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10994.patch",
"merged_at": "2024-10-24T20:59:51"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10994/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10994/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10993 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10993/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10993/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10993/events | https://github.com/NVIDIA/NeMo/pull/10993 | 2,605,881,901 | PR_kwDOC_bI7s5_e-9X | 10,993 | Cherry pick `minor fix (10990)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-22T16:02:58 | 2024-10-22T20:29:16 | 2024-10-22T20:29:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10993",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10993",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10993.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10993.patch",
"merged_at": "2024-10-22T20:29:13"
} | [π€]: Hi @JRD971000 π,<br><br>we've cherry picked #10990 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10993/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10993/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10992 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10992/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10992/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10992/events | https://github.com/NVIDIA/NeMo/pull/10992 | 2,605,873,018 | PR_kwDOC_bI7s5_e9I- | 10,992 | Cherry pick `Reflect CLI change nemorun -> nemo (10443)` into `r2.0.0` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-10-22T15:58:50 | 2024-10-22T16:00:16 | 2024-10-22T16:00:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10992",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10992",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10992.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10992.patch",
"merged_at": "2024-10-22T16:00:14"
} | [π€]: Hi @marcromeyn π,<br><br>we've cherry picked #10443 into `r2.0.0` for you! π<br><br>Please review and approve this cherry pick by your convenience\! | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10992/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10992/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10991 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10991/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10991/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10991/events | https://github.com/NVIDIA/NeMo/pull/10991 | 2,605,711,718 | PR_kwDOC_bI7s5_eci7 | 10,991 | add lora recipt for 405b | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"[π€]: Hi @JRD971000 π,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11687451847) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g"
] | 2024-10-22T14:56:21 | 2024-11-05T19:08:57 | 2024-11-05T19:08:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10991",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10991",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10991.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10991.patch",
"merged_at": "2024-11-05T19:08:56"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10991/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10991/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10990 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10990/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10990/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10990/events | https://github.com/NVIDIA/NeMo/pull/10990 | 2,605,441,669 | PR_kwDOC_bI7s5_dl_D | 10,990 | minor fix | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815558,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU4",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/documentation",
"name": "documentation",
"color": "0075ca",
"default": true,
"description": "Improvements or additions to documentation"
},
{
"id": 7436254803,
"node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0",
"name": "r2.0.0",
"color": "4E083D",
"default": false,
"description": ""
}
] | closed | false | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Documentation only change. No need to run CI"
] | 2024-10-22T13:19:28 | 2024-10-22T16:02:34 | 2024-10-22T16:02:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10990",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10990",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10990.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10990.patch",
"merged_at": "2024-10-22T16:02:32"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10990/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10990/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10989 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10989/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10989/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10989/events | https://github.com/NVIDIA/NeMo/pull/10989 | 2,605,375,644 | PR_kwDOC_bI7s5_dYbt | 10,989 | Fast N-Gram LM on GPU + greedy decoding (RNN-T, TDT, CTC) | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | open | false | null | [] | null | [
"<!-- pylint-output-strict-mode-true -->\n\nbeep boop π€: π¨ The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.parts.submodules.ngram_lm\nnemo/collections/asr/parts/submodules/ngram_lm.py:85:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ngram_lm.py:94:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ngram_lm.py:97:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ngram_lm.py:147:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ngram_lm.py:168:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/ngram_lm.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ngram_lm.py:350:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ngram_lm.py:474:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ngram_lm.py:671:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.83/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop π€: π The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.parts.submodules.ctc_decoding\nnemo/collections/asr/parts/submodules/ctc_decoding.py:370:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:764:0: C0301: Line too long (151/119) (line-too-long)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:921:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:33:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:995:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:1006:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:1017:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:1477:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/asr/parts/submodules/ctc_decoding.py:1524:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.parts.submodules.ctc_greedy_decoding\nnemo/collections/asr/parts/submodules/ctc_greedy_decoding.py:63:0: C0301: Line too long (247/119) (line-too-long)\nnemo/collections/asr/parts/submodules/ctc_greedy_decoding.py:162:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/asr/parts/submodules/ctc_greedy_decoding.py:171:0: C0301: Line too long (205/119) (line-too-long)\nnemo/collections/asr/parts/submodules/ctc_greedy_decoding.py:399:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/asr/parts/submodules/ctc_greedy_decoding.py:30:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/asr/parts/submodules/ctc_greedy_decoding.py:643:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.parts.submodules.rnnt_loop_labels_computer\nnemo/collections/asr/parts/submodules/rnnt_loop_labels_computer.py:198:4: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.collections.asr.parts.submodules.tdt_loop_labels_computer\nnemo/collections/asr/parts/submodules/tdt_loop_labels_computer.py:204:4: C0115: Missing class docstring (missing-class-docstring)\n************* Module scripts.asr_language_modeling.ngram_lm.train_kenlm\nscripts/asr_language_modeling/ngram_lm/train_kenlm.py:66:0: C0301: Line too long (169/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/train_kenlm.py:77:0: C0301: Line too long (128/119) (line-too-long)\nscripts/asr_language_modeling/ngram_lm/train_kenlm.py:83:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.93/10\n```\n\n---\n\nMitigation guide:\n\n* Add sensible and useful docstrings to functions and methods\n* For trivial methods like getter/setters, consider adding `# pylint: disable=C0116` inside the function itself\n* To disable multiple functions/methods at once, put a `# pylint: disable=C0116` before the first and a `# pylint: enable=C0116` after the last.\n\nBy applying these rules, we reduce the occurance of this message in future.\n\nThank you for improving NeMo's documentation!"
] | 2024-10-22T12:54:08 | 2025-01-13T22:03:49 | null | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10989",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10989",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10989.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10989.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10989/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10989/timeline | null | null | true |
Subsets and Splits