url
stringlengths
52
53
repository_url
stringclasses
1 value
labels_url
stringlengths
66
67
comments_url
stringlengths
61
62
events_url
stringlengths
59
60
html_url
stringlengths
40
43
id
int64
719M
2.8B
node_id
stringlengths
18
32
number
int64
1.28k
11.9k
title
stringlengths
1
350
user
dict
labels
listlengths
0
10
state
stringclasses
2 values
locked
bool
2 classes
assignee
dict
assignees
listlengths
0
3
milestone
null
comments
sequencelengths
0
30
created_at
timestamp[s]
updated_at
timestamp[s]
closed_at
timestamp[s]
author_association
stringclasses
4 values
sub_issues_summary
dict
active_lock_reason
stringclasses
1 value
draft
bool
2 classes
pull_request
dict
body
stringlengths
0
73.4k
closed_by
dict
reactions
dict
timeline_url
stringlengths
61
62
performed_via_github_app
null
state_reason
stringclasses
3 values
is_pull_request
bool
2 classes
https://api.github.com/repos/NVIDIA/NeMo/issues/10683
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10683/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10683/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10683/events
https://github.com/NVIDIA/NeMo/pull/10683
2,557,261,345
PR_kwDOC_bI7s59JpBF
10,683
Multimodal conversation format dataloading
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "> 1. what do we still need in dataset code?\r\n\r\nRoughly the following:\r\n\r\n```python\r\ndef __getitem__(self, cuts):\r\n\r\n # existing audio / text processing code\r\n\r\n multimodal_convo_examples = cuts.filter(lambda c: isinstance(c, NeMoMultimodalConversation))\r\n if multimodal_convo_examples:\r\n audio_turn_cuts = []\r\n formatted_chats = []\r\n for example in multimodal_convo_examples:\r\n # input_ids / context_ids / etc. will be pre-populated when you specify train_ds.prompt_format\r\n formatted_chats.append({\"input_ids\": example.input_ids, \"context_ids\": example.context_ids, ...})\r\n audio_turn_cuts.extend([turn.cut for turn in example.turns])\r\n audio, audio_lens = self.load_audio(audio_turn_cuts)\r\n batch[\"multimodal_conversation\"] = {\"audio\": audio, \"audio_lens\": audio_lens, \"input_ids\": collate([c[\"input_ids\"] for c in formatted_chats), ...}\r\n```\r\n\r\n> 2. we need to add model code for i) fprop multiple audios ii) replacing audio_locator_tag with audios\r\n\r\nYes. \r\n\r\n> 3. Tar the audios\r\n\r\nYes." ]
2024-09-30T17:25:26
2024-10-01T20:29:38
2024-10-01T20:29:36
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10683", "html_url": "https://github.com/NVIDIA/NeMo/pull/10683", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10683.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10683.patch", "merged_at": "2024-10-01T20:29:36" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "zhehuaichen", "id": 139396994, "node_id": "U_kgDOCE8Hgg", "avatar_url": "https://avatars.githubusercontent.com/u/139396994?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zhehuaichen", "html_url": "https://github.com/zhehuaichen", "followers_url": "https://api.github.com/users/zhehuaichen/followers", "following_url": "https://api.github.com/users/zhehuaichen/following{/other_user}", "gists_url": "https://api.github.com/users/zhehuaichen/gists{/gist_id}", "starred_url": "https://api.github.com/users/zhehuaichen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zhehuaichen/subscriptions", "organizations_url": "https://api.github.com/users/zhehuaichen/orgs", "repos_url": "https://api.github.com/users/zhehuaichen/repos", "events_url": "https://api.github.com/users/zhehuaichen/events{/privacy}", "received_events_url": "https://api.github.com/users/zhehuaichen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10683/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10683/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10682
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10682/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10682/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10682/events
https://github.com/NVIDIA/NeMo/pull/10682
2,556,984,462
PR_kwDOC_bI7s59IriJ
10,682
vLLM NemoTokenizerGroup bugfix
{ "login": "janekl", "id": 5582967, "node_id": "MDQ6VXNlcjU1ODI5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janekl", "html_url": "https://github.com/janekl", "followers_url": "https://api.github.com/users/janekl/followers", "following_url": "https://api.github.com/users/janekl/following{/other_user}", "gists_url": "https://api.github.com/users/janekl/gists{/gist_id}", "starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janekl/subscriptions", "organizations_url": "https://api.github.com/users/janekl/orgs", "repos_url": "https://api.github.com/users/janekl/repos", "events_url": "https://api.github.com/users/janekl/events{/privacy}", "received_events_url": "https://api.github.com/users/janekl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "FYI @HuiyingLi ", "I'm closing this as it's covered by https://github.com/NVIDIA/NeMo/pull/10697" ]
2024-09-30T15:17:23
2024-10-02T15:09:13
2024-10-02T15:09:12
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10682", "html_url": "https://github.com/NVIDIA/NeMo/pull/10682", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10682.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10682.patch", "merged_at": null }
# What does this PR do ? For `NemoTokenizerGroup` in the base class [BaseTokenizerGroup](https://github.com/vllm-project/vllm/blob/v0.5.3/vllm/transformers_utils/tokenizer_group/base_tokenizer_group.py#L13-L17) from vLLM there is an abstract `from_config` method that needs to be implemented. This change mocks the implementation to make `scripts/deploy/nlp/deploy_vllm_triton.py` functional. There error fixed here is: ``` INFO 09-27 15:02:31 llm_engine.py:176] Initializing an LLM engine (v0.5.3) with config: model='/tmp/tmpioclfxxh', speculative_config=None, tokenizer=None, skip_tokenizer_init=False, tokenizer_mode=auto, revision=None, rope_scaling=None, rope_theta=None, tokenizer_revision=None, trust_remote_code=False, dtype=torch.bfloat16, max_seq_len=512, download_dir=None, load_format=<class 'nemo.export.vllm.model_loader.NemoModelLoader'>, tensor_parallel_size=1, pipeline_parallel_size=1, disable_custom_all_reduce=False, quantization=None, enforce_eager=False, kv_cache_dtype=auto, quantization_param_path=None, device_config=cuda, decoding_config=None, observability_config=None, seed=0, served_model_name=/data/export/LLAMA2-7B-fp8-sft.nemo, use_v2_block_manager=False, enable_prefix_caching=False) ERROR 09-27 15:02:31 deploy_vllm_triton.py:169] An error has occurred while setting up or serving the model. Error message: An error has occurred during the model export. Error message: Can't instantiate abstract class NemoTokenizerGroup with abstract method from_config ``` CC @apanteleev **Collection**: NLP # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to https://github.com/NVIDIA/NeMo/pull/9381
{ "login": "janekl", "id": 5582967, "node_id": "MDQ6VXNlcjU1ODI5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janekl", "html_url": "https://github.com/janekl", "followers_url": "https://api.github.com/users/janekl/followers", "following_url": "https://api.github.com/users/janekl/following{/other_user}", "gists_url": "https://api.github.com/users/janekl/gists{/gist_id}", "starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janekl/subscriptions", "organizations_url": "https://api.github.com/users/janekl/orgs", "repos_url": "https://api.github.com/users/janekl/repos", "events_url": "https://api.github.com/users/janekl/events{/privacy}", "received_events_url": "https://api.github.com/users/janekl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10682/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10682/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10681
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10681/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10681/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10681/events
https://github.com/NVIDIA/NeMo/issues/10681
2,556,079,777
I_kwDOC_bI7s6YWq6h
10,681
Using MSDD model with a different speaker embedding model
{ "login": "MahmoudAshraf97", "id": 32404268, "node_id": "MDQ6VXNlcjMyNDA0MjY4", "avatar_url": "https://avatars.githubusercontent.com/u/32404268?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MahmoudAshraf97", "html_url": "https://github.com/MahmoudAshraf97", "followers_url": "https://api.github.com/users/MahmoudAshraf97/followers", "following_url": "https://api.github.com/users/MahmoudAshraf97/following{/other_user}", "gists_url": "https://api.github.com/users/MahmoudAshraf97/gists{/gist_id}", "starred_url": "https://api.github.com/users/MahmoudAshraf97/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MahmoudAshraf97/subscriptions", "organizations_url": "https://api.github.com/users/MahmoudAshraf97/orgs", "repos_url": "https://api.github.com/users/MahmoudAshraf97/repos", "events_url": "https://api.github.com/users/MahmoudAshraf97/events{/privacy}", "received_events_url": "https://api.github.com/users/MahmoudAshraf97/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "It would still work to a certain degree without re-training, but you will get much better result if you retrain a new model.\nNot only MSDD model, optimizing the clustering algorithm on the scale length and scale weights on the new embedding would also affect a lot on the performance.", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days." ]
2024-09-30T09:27:00
2024-11-11T08:46:00
2024-11-11T08:46:00
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hello, is it possible to replace the TitaNet embedding model that is used along with MSDD? and if yes, does that require retraining? I want to construct a pipeline with a different VAD and embedding model but still use the MSDD model
{ "login": "MahmoudAshraf97", "id": 32404268, "node_id": "MDQ6VXNlcjMyNDA0MjY4", "avatar_url": "https://avatars.githubusercontent.com/u/32404268?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MahmoudAshraf97", "html_url": "https://github.com/MahmoudAshraf97", "followers_url": "https://api.github.com/users/MahmoudAshraf97/followers", "following_url": "https://api.github.com/users/MahmoudAshraf97/following{/other_user}", "gists_url": "https://api.github.com/users/MahmoudAshraf97/gists{/gist_id}", "starred_url": "https://api.github.com/users/MahmoudAshraf97/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MahmoudAshraf97/subscriptions", "organizations_url": "https://api.github.com/users/MahmoudAshraf97/orgs", "repos_url": "https://api.github.com/users/MahmoudAshraf97/repos", "events_url": "https://api.github.com/users/MahmoudAshraf97/events{/privacy}", "received_events_url": "https://api.github.com/users/MahmoudAshraf97/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10681/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10681/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10680
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10680/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10680/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10680/events
https://github.com/NVIDIA/NeMo/issues/10680
2,555,733,121
I_kwDOC_bI7s6YVWSB
10,680
Unable to decode using canary 1b model
{ "login": "uni-saurabh-vyas", "id": 123355905, "node_id": "U_kgDOB1pDAQ", "avatar_url": "https://avatars.githubusercontent.com/u/123355905?v=4", "gravatar_id": "", "url": "https://api.github.com/users/uni-saurabh-vyas", "html_url": "https://github.com/uni-saurabh-vyas", "followers_url": "https://api.github.com/users/uni-saurabh-vyas/followers", "following_url": "https://api.github.com/users/uni-saurabh-vyas/following{/other_user}", "gists_url": "https://api.github.com/users/uni-saurabh-vyas/gists{/gist_id}", "starred_url": "https://api.github.com/users/uni-saurabh-vyas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/uni-saurabh-vyas/subscriptions", "organizations_url": "https://api.github.com/users/uni-saurabh-vyas/orgs", "repos_url": "https://api.github.com/users/uni-saurabh-vyas/repos", "events_url": "https://api.github.com/users/uni-saurabh-vyas/events{/privacy}", "received_events_url": "https://api.github.com/users/uni-saurabh-vyas/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "Which NeMo version is this? Greedy decoding for Canary should work if you install the latest 2.0 pre-release, or the latest `main` branch.", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-30T06:55:04
2024-11-15T02:02:38
2024-11-15T02:02:38
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** A clear and concise description of what the bug is. I am using nemo inside docker environment, with single GPU, unable to get the ASR ouput using canary 1b model ``` Error executing job with overrides: ['pretrained_name=nvidia/canary-1b', 'audio_dir=/opt/workspace/es_test', 'output_filename=canary_output.txt', 'clean_groundtruth_text=True', 'langid=es', 'batch_size=1', 'compute_timestamps=False', 'compute_langs=False', 'cuda=0', 'amp=True', 'append_pred=False', 'pred_name_postfix=canary'] Traceback (most recent call last): File "/opt/asr_ensemble/repo/nemo/examples/asr/transcribe_speech.py", line 290, in main asr_model.change_decoding_strategy(cfg.ctc_decoding) File "/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/models/aed_multitask_models.py", line 203, in change_decoding_strategy self.decoding = MultiTaskDecoding( File "/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/parts/submodules/multitask_decoding.py", line 377, in __init__ super().__init__( File "/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/parts/submodules/multitask_decoding.py", line 124, in __init__ raise NotImplementedError("Greedy decoding is not implemented yet.") NotImplementedError: Greedy decoding is not implemented yet. ``` **Steps/Code to reproduce bug** python3 nemo/examples/asr/transcribe_speech.py \ pretrained_name="nvidia/canary-1b" \ audio_dir="/opt/workspace/es_test" \ output_filename="canary_output.txt" \ clean_groundtruth_text=True \ langid='es' \ batch_size=1 \ compute_timestamps=False \ compute_langs=False \ cuda=0 \ amp=True \ append_pred=False \ pred_name_postfix="canary" **Expected behavior** A clear and concise description of what you expected to happen. **Environment overview (please complete the following information)** - Environment location: [Bare-metal, Docker, Cloud(specify cloud provider - AWS, Azure, GCP, Collab)] - Method of NeMo install: [pip install or from source]. Please specify exact commands you used to install. - If method of install is [Docker], provide `docker pull` & `docker run` commands used **Environment details** If NVIDIA docker image is used you don't need to specify these. Otherwise, please provide: - OS version Ubuntu 20 - PyTorch version - Python version 3.10 **Additional context** Add any other context about the problem here. Example: GPU model
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10680/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10680/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10679
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10679/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10679/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10679/events
https://github.com/NVIDIA/NeMo/issues/10679
2,555,608,486
I_kwDOC_bI7s6YU32m
10,679
When converting a checkpoint from Hugging Face, the checkpoint format conversion keeps getting CUDA out of memory
{ "login": "changg10", "id": 110156977, "node_id": "U_kgDOBpDcsQ", "avatar_url": "https://avatars.githubusercontent.com/u/110156977?v=4", "gravatar_id": "", "url": "https://api.github.com/users/changg10", "html_url": "https://github.com/changg10", "followers_url": "https://api.github.com/users/changg10/followers", "following_url": "https://api.github.com/users/changg10/following{/other_user}", "gists_url": "https://api.github.com/users/changg10/gists{/gist_id}", "starred_url": "https://api.github.com/users/changg10/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/changg10/subscriptions", "organizations_url": "https://api.github.com/users/changg10/orgs", "repos_url": "https://api.github.com/users/changg10/repos", "events_url": "https://api.github.com/users/changg10/events{/privacy}", "received_events_url": "https://api.github.com/users/changg10/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "And I often have this warning, please how to solve it \n`zarr distributed checkpoint backend is deprecated. Please switch to PyTorch Distributed format (`torch_dist`).\n`", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-30T05:36:02
2024-11-08T01:57:54
2024-11-08T01:57:53
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
``` python3 /opt/NeMo/scripts/checkpoint_converters/convert_llava_hf_to_nemo.py \ --input_name_or_path llava-hf/llava-1.5-7b-hf \ --output_path /workspace/checkpoints/llava-7b.nemo \ --tokenizer_path /workspace/checkpoints/vicuna-7b-v1.5/tokenizer_neva.model ``` Keep reporting errors ``` [NeMo I 2024-09-30 05:28:51 convert_llava_hf_to_nemo:288] Running verifications ['query: how much protein should a female eat'] ... [rank0]: Traceback (most recent call last): [rank0]: File "/opt/NeMo/scripts/checkpoint_converters/convert_llava_hf_to_nemo.py", line 331, in <module> [rank0]: convert(args) [rank0]: File "/opt/NeMo/scripts/checkpoint_converters/convert_llava_hf_to_nemo.py", line 295, in convert [rank0]: model = model.cuda().eval() [rank0]: File "/opt/NeMo/nemo/core/classes/modelPT.py", line 1963, in cuda [rank0]: return super().cuda(device=device) [rank0]: File "/usr/local/lib/python3.10/dist-packages/lightning_fabric/utilities/device_dtype_mixin.py", line 76, in cuda [rank0]: return super().cuda(device=device) [rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 911, in cuda [rank0]: return self._apply(lambda t: t.cuda(device)) [rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 802, in _apply [rank0]: module._apply(fn) [rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 802, in _apply [rank0]: module._apply(fn) [rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 802, in _apply [rank0]: module._apply(fn) [rank0]: [Previous line repeated 3 more times] [rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 825, in _apply [rank0]: param_applied = fn(param) [rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 911, in <lambda> [rank0]: return self._apply(lambda t: t.cuda(device)) [rank0]: torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 192.00 MiB. GPU 0 has a total capacity of 47.29 GiB of which 169.00 MiB is free. Process 573844 has 46.78 GiB memory in use. Of the allocated memory 46.42 GiB is allocated by PyTorch, and 17.42 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True to avoid fragmentation. See documentation for Memory Management (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables) ``` I am using two NVIDIA RTX 5880 48G GPUs, each with 32GB of memory. When I use only one GPU, the memory is fully utilized. However, when I use both GPUs, only one GPU's memory is fully utilized, while the other GPU seems to be underutilized. Why is this happening? Additionally, why does data type conversion consume so much GPU memory?
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10679/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10679/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10678
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10678/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10678/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10678/events
https://github.com/NVIDIA/NeMo/pull/10678
2,555,253,938
PR_kwDOC_bI7s59CxQ5
10,678
Bump `Dockerfile.ci` (2024-09-30)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-30T00:23:15
2024-10-03T13:33:27
2024-10-03T13:33:27
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10678", "html_url": "https://github.com/NVIDIA/NeMo/pull/10678", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10678.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10678.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10678/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10678/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10677
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10677/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10677/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10677/events
https://github.com/NVIDIA/NeMo/issues/10677
2,554,974,914
I_kwDOC_bI7s6YSdLC
10,677
Punctuation and Capitalization Model: how to add custom Punctuation marks to prepare data script?
{ "login": "ican24", "id": 19214100, "node_id": "MDQ6VXNlcjE5MjE0MTAw", "avatar_url": "https://avatars.githubusercontent.com/u/19214100?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ican24", "html_url": "https://github.com/ican24", "followers_url": "https://api.github.com/users/ican24/followers", "following_url": "https://api.github.com/users/ican24/following{/other_user}", "gists_url": "https://api.github.com/users/ican24/gists{/gist_id}", "starred_url": "https://api.github.com/users/ican24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ican24/subscriptions", "organizations_url": "https://api.github.com/users/ican24/orgs", "repos_url": "https://api.github.com/users/ican24/repos", "events_url": "https://api.github.com/users/ican24/events{/privacy}", "received_events_url": "https://api.github.com/users/ican24/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "It seems there is a bug in create_text_and_labels function of \n.local/lib/python3.10/site-packages/nemo/collections/nlp/data/token_classification\n\nI had tried to run it directly \n`\ncreate_text_and_labels(\"/tmp\", \"/punct/src/test.txt\", \"՞,․՜՝«»՛․։…\")\n`\nBut no any result!\n", "The reason is an absent of punctuation marks (punct_marks) in \"remove_punctuation\" function\n`\ndef remove_punctuation(word: str):\n`\n\nThe software developer forgot to use them\n\n```\nRemoves all punctuation marks from a word except for '\nthat is often a part of word: don't, it's, and so on\n\nall_punct_marks = string.punctuation.replace(\"'\", '')\n\n```", "Finally my troubles with this product ended successfully after 10 days of struggling and I am ready to close this issue, but many questions remain open.\nFirstly it is hard and long to install this modul which demands NVIDIA's Transformer Engine.\nIt requires CUDA and CUDNN, but how can we intall them on the usage machines without GPU? \nIt is a serious trouble, because we are not always ready to buy machine with expensive GPU-s to use this function/utility, which is not a core.\nI remind you that we are able to use NEMO ASR in none-GPU environment.\n ", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-29T14:55:11
2024-11-09T01:55:50
2024-11-09T01:55:49
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Dear Team, Please help me to add custom Punctuation marks to following script. python examples/nlp/token_classification/data/prepare_data_for_punctuation_capitalization.py \ -s <PATH/TO/THE/SOURCE/FILE> \ -o <PATH/TO/THE/OUTPUT/DIRECTORY> -p ? --marks ? I can not add. Thank you in advance!
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10677/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10677/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10676
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10676/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10676/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10676/events
https://github.com/NVIDIA/NeMo/pull/10676
2,554,896,890
PR_kwDOC_bI7s59Bnxk
10,676
Fix typo in rnnt_bpe_models.py: tokenier -> tokenizer
{ "login": "somniumism", "id": 44434599, "node_id": "MDQ6VXNlcjQ0NDM0NTk5", "avatar_url": "https://avatars.githubusercontent.com/u/44434599?v=4", "gravatar_id": "", "url": "https://api.github.com/users/somniumism", "html_url": "https://github.com/somniumism", "followers_url": "https://api.github.com/users/somniumism/followers", "following_url": "https://api.github.com/users/somniumism/following{/other_user}", "gists_url": "https://api.github.com/users/somniumism/gists{/gist_id}", "starred_url": "https://api.github.com/users/somniumism/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/somniumism/subscriptions", "organizations_url": "https://api.github.com/users/somniumism/orgs", "repos_url": "https://api.github.com/users/somniumism/repos", "events_url": "https://api.github.com/users/somniumism/events{/privacy}", "received_events_url": "https://api.github.com/users/somniumism/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "@pzelasko Could you check the content of this PR? It's been a week since I created the PR, and no one has reviewed it. ", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-29T12:00:15
2024-10-29T01:59:56
2024-10-29T01:59:55
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10676", "html_url": "https://github.com/NVIDIA/NeMo/pull/10676", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10676.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10676.patch", "merged_at": null }
# What does this PR do ? Fix a typo in the `nemo/collections/asr/models/rnnt_bpe_models.py` file. **Collection**: ASR # Changelog - Fixed typo `tokenier` to `tokenizer` in `rnnt_bpe_models.py`. # Usage N/A # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10676/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10676/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10675
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10675/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10675/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10675/events
https://github.com/NVIDIA/NeMo/issues/10675
2,554,804,699
I_kwDOC_bI7s6YRznb
10,675
NeMo 2.0 llm sharded_state_dict error
{ "login": "lifeiteng", "id": 3107839, "node_id": "MDQ6VXNlcjMxMDc4Mzk=", "avatar_url": "https://avatars.githubusercontent.com/u/3107839?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lifeiteng", "html_url": "https://github.com/lifeiteng", "followers_url": "https://api.github.com/users/lifeiteng/followers", "following_url": "https://api.github.com/users/lifeiteng/following{/other_user}", "gists_url": "https://api.github.com/users/lifeiteng/gists{/gist_id}", "starred_url": "https://api.github.com/users/lifeiteng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lifeiteng/subscriptions", "organizations_url": "https://api.github.com/users/lifeiteng/orgs", "repos_url": "https://api.github.com/users/lifeiteng/repos", "events_url": "https://api.github.com/users/lifeiteng/events{/privacy}", "received_events_url": "https://api.github.com/users/lifeiteng/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[ "install TE from source\n\nhttps://github.com/NVIDIA/TransformerEngine/pull/1130" ]
2024-09-29T08:20:47
2024-09-30T00:26:18
2024-09-30T00:26:16
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** ``` Training epoch 0, iteration 196/3999 | lr: 2.954e-05 | consumed_samples: 4728 | global_batch_size: 24 | global_step: 196 | reduced_train_loss: 10.84 | train_step_timing in s: 0.9765 Training epoch 0, iteration 197/3999 | lr: 2.969e-05 | consumed_samples: 4752 | global_batch_size: 24 | global_step: 197 | reduced_train_loss: 10.84 | train_step_timing in s: 0.9826 Training epoch 0, iteration 198/3999 | lr: 2.984e-05 | consumed_samples: 4776 | global_batch_size: 24 | global_step: 198 | reduced_train_loss: 10.84 | train_step_timing in s: 0.9742 Training epoch 0, iteration 199/3999 | lr: 2.999e-05 | consumed_samples: 4800 | global_batch_size: 24 | global_step: 199 | reduced_train_loss: 10.85 | train_step_timing in s: 1.085 [NeMo W 2024-09-29 08:11:31 nemo_logging:349] /home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/callbacks/model_checkpoint.py:384: `ModelCheckpoint(monitor='val_loss')` could not find the monitored key in the returned metrics: ['lr', 'consumed_samples', 'global_batch_size', 'global_step', 'step', 'reduced_train_loss', 'grad_norm', 'train_step_timing in s', 'epoch']. HINT: Did you call `log('val_loss', value)` in the `LightningModule`? Epoch 0, global step 199: 'val_loss' was not in top 10 [rank0]: Traceback (most recent call last): [rank0]: File "/home/usr/.local/bin/nemorun", line 8, in <module> [rank0]: sys.exit(app()) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/typer/main.py", line 338, in __call__ [rank0]: raise e [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/typer/main.py", line 321, in __call__ [rank0]: return get_command(self)(*args, **kwargs) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/click/core.py", line 1157, in __call__ [rank0]: return self.main(*args, **kwargs) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/typer/core.py", line 728, in main [rank0]: return _main( [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/typer/core.py", line 197, in _main [rank0]: rv = self.invoke(ctx) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/click/core.py", line 1688, in invoke [rank0]: return _process_result(sub_ctx.command.invoke(sub_ctx)) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/click/core.py", line 1688, in invoke [rank0]: return _process_result(sub_ctx.command.invoke(sub_ctx)) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/click/core.py", line 1434, in invoke [rank0]: return ctx.invoke(self.callback, **ctx.params) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/click/core.py", line 783, in invoke [rank0]: return __callback(*args, **kwargs) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/typer/main.py", line 703, in wrapper [rank0]: return callback(**use_params) [rank0]: File "/home/usr/code/NeMo-Run/src/nemo_run/cli/api.py", line 790, in command [rank0]: self.cli_execute(fn, ctx.args, type) [rank0]: File "/home/usr/code/NeMo-Run/src/nemo_run/cli/api.py", line 842, in cli_execute [rank0]: self._execute_task(fn, filtered_args) [rank0]: File "/home/usr/code/NeMo-Run/src/nemo_run/cli/api.py", line 892, in _execute_task [rank0]: run_task() [rank0]: File "/home/usr/code/NeMo-Run/src/nemo_run/cli/api.py", line 871, in run_task [rank0]: run.run( [rank0]: File "/home/usr/code/NeMo-Run/src/nemo_run/run/api.py", line 65, in run [rank0]: direct_run_fn(fn_or_script, dryrun=dryrun) [rank0]: File "/home/usr/code/NeMo-Run/src/nemo_run/run/task.py", line 77, in direct_run_fn [rank0]: built_fn() [rank0]: File "/home/usr/code/NeMo/nemo/collections/llm/api.py", line 127, in pretrain [rank0]: return train( [rank0]: File "/home/usr/code/NeMo/nemo/collections/llm/api.py", line 85, in train [rank0]: trainer.fit(model, data) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 538, in fit [rank0]: call._call_and_handle_interrupt( [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 46, in _call_and_handle_interrupt [rank0]: return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/strategies/launchers/subprocess_script.py", line 105, in launch [rank0]: return function(*args, **kwargs) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 574, in _fit_impl [rank0]: self._run(model, ckpt_path=ckpt_path) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 981, in _run [rank0]: results = self._run_stage() [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1025, in _run_stage [rank0]: self.fit_loop.run() [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/loops/fit_loop.py", line 205, in run [rank0]: self.advance() [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/loops/fit_loop.py", line 363, in advance [rank0]: self.epoch_loop.run(self._data_fetcher) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/loops/training_epoch_loop.py", line 140, in run [rank0]: self.advance(data_fetcher) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/loops/training_epoch_loop.py", line 269, in advance [rank0]: call._call_callback_hooks(trainer, "on_train_batch_end", batch_output, batch, batch_idx) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 218, in _call_callback_hooks [rank0]: fn(trainer, trainer.lightning_module, *args, **kwargs) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 317, in on_train_batch_end [rank0]: self._save_last_checkpoint(trainer, monitor_candidates) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 696, in _save_last_checkpoint [rank0]: self._save_checkpoint(trainer, filepath) [rank0]: File "/home/usr/code/NeMo/nemo/lightning/pytorch/callbacks/model_checkpoint.py", line 449, in _save_checkpoint [rank0]: trainer.save_checkpoint(ckpt_filepath, save_weights_only, storage_options=storage_options) [rank0]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1365, in save_checkpoint [rank0]: self.strategy.save_checkpoint(checkpoint, filepath, storage_options=storage_options) [rank0]: File "/home/usr/code/NeMo/nemo/lightning/pytorch/strategies/megatron_strategy.py", line 660, in save_checkpoint [rank0]: checkpoint["optimizer"] = [self.optimizer_sharded_state_dict()] [rank0]: File "/home/usr/code/NeMo/nemo/lightning/pytorch/strategies/megatron_strategy.py", line 638, in optimizer_sharded_state_dict [rank0]: return _strategy_lib.optimizer_sharded_state_dict( [rank0]: File "/home/usr/code/NeMo/nemo/lightning/_strategy_lib.py", line 455, in optimizer_sharded_state_dict [rank0]: return optimizer.sharded_state_dict( [rank0]: File "/home/usr/code/NeMo/nemo/lightning/pytorch/optim/megatron.py", line 114, in sharded_state_dict [rank0]: state_dict = self.mcore_optimizer.sharded_state_dict( [rank0]: File "/home/usr/code/Megatron-LM/megatron/core/optimizer/distrib_optimizer.py", line 950, in sharded_state_dict [rank0]: param_state = self.sharded_param_state_fs_model_space( [rank0]: File "/home/usr/code/Megatron-LM/megatron/core/optimizer/distrib_optimizer.py", line 1161, in sharded_param_state_fs_model_space [rank0]: dtype=state_ten.dtype, [rank0]: AttributeError: 'NoneType' object has no attribute 'dtype' [rank1]: Traceback (most recent call last): [rank1]: File "/home/usr/.local/bin/nemorun", line 8, in <module> [rank1]: sys.exit(app()) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/typer/main.py", line 338, in __call__ [rank1]: raise e [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/typer/main.py", line 321, in __call__ [rank1]: return get_command(self)(*args, **kwargs) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/click/core.py", line 1157, in __call__ [rank1]: return self.main(*args, **kwargs) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/typer/core.py", line 728, in main [rank1]: return _main( [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/typer/core.py", line 197, in _main [rank1]: rv = self.invoke(ctx) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/click/core.py", line 1688, in invoke [rank1]: return _process_result(sub_ctx.command.invoke(sub_ctx)) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/click/core.py", line 1688, in invoke [rank1]: return _process_result(sub_ctx.command.invoke(sub_ctx)) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/click/core.py", line 1434, in invoke [rank1]: return ctx.invoke(self.callback, **ctx.params) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/click/core.py", line 783, in invoke [rank1]: return __callback(*args, **kwargs) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/typer/main.py", line 703, in wrapper [rank1]: return callback(**use_params) [rank1]: File "/home/usr/code/NeMo-Run/src/nemo_run/cli/api.py", line 790, in command [rank1]: self.cli_execute(fn, ctx.args, type) [rank1]: File "/home/usr/code/NeMo-Run/src/nemo_run/cli/api.py", line 842, in cli_execute [rank1]: self._execute_task(fn, filtered_args) [rank1]: File "/home/usr/code/NeMo-Run/src/nemo_run/cli/api.py", line 892, in _execute_task [rank1]: run_task() [rank1]: File "/home/usr/code/NeMo-Run/src/nemo_run/cli/api.py", line 871, in run_task [rank1]: run.run( [rank1]: File "/home/usr/code/NeMo-Run/src/nemo_run/run/api.py", line 65, in run [rank1]: direct_run_fn(fn_or_script, dryrun=dryrun) [rank1]: File "/home/usr/code/NeMo-Run/src/nemo_run/run/task.py", line 77, in direct_run_fn [rank1]: built_fn() [rank1]: File "/home/usr/code/NeMo/nemo/collections/llm/api.py", line 127, in pretrain [rank1]: return train( [rank1]: File "/home/usr/code/NeMo/nemo/collections/llm/api.py", line 85, in train [rank1]: trainer.fit(model, data) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 538, in fit [rank1]: call._call_and_handle_interrupt( [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 46, in _call_and_handle_interrupt [rank1]: return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/strategies/launchers/subprocess_script.py", line 105, in launch [rank1]: return function(*args, **kwargs) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 574, in _fit_impl [rank1]: self._run(model, ckpt_path=ckpt_path) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 981, in _run [rank1]: results = self._run_stage() [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1025, in _run_stage [rank1]: self.fit_loop.run() [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/loops/fit_loop.py", line 205, in run [rank1]: self.advance() [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/loops/fit_loop.py", line 363, in advance [rank1]: self.epoch_loop.run(self._data_fetcher) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/loops/training_epoch_loop.py", line 140, in run [rank1]: self.advance(data_fetcher) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/loops/training_epoch_loop.py", line 269, in advance [rank1]: call._call_callback_hooks(trainer, "on_train_batch_end", batch_output, batch, batch_idx) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 218, in _call_callback_hooks [rank1]: fn(trainer, trainer.lightning_module, *args, **kwargs) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 317, in on_train_batch_end [rank1]: self._save_last_checkpoint(trainer, monitor_candidates) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 696, in _save_last_checkpoint [rank1]: self._save_checkpoint(trainer, filepath) [rank1]: File "/home/usr/code/NeMo/nemo/lightning/pytorch/callbacks/model_checkpoint.py", line 449, in _save_checkpoint [rank1]: trainer.save_checkpoint(ckpt_filepath, save_weights_only, storage_options=storage_options) [rank1]: File "/home/usr/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1365, in save_checkpoint [rank1]: self.strategy.save_checkpoint(checkpoint, filepath, storage_options=storage_options) [rank1]: File "/home/usr/code/NeMo/nemo/lightning/pytorch/strategies/megatron_strategy.py", line 660, in save_checkpoint [rank1]: checkpoint["optimizer"] = [self.optimizer_sharded_state_dict()] [rank1]: File "/home/usr/code/NeMo/nemo/lightning/pytorch/strategies/megatron_strategy.py", line 638, in optimizer_sharded_state_dict [rank1]: return _strategy_lib.optimizer_sharded_state_dict( [rank1]: File "/home/usr/code/NeMo/nemo/lightning/_strategy_lib.py", line 455, in optimizer_sharded_state_dict [rank1]: return optimizer.sharded_state_dict( [rank1]: File "/home/usr/code/NeMo/nemo/lightning/pytorch/optim/megatron.py", line 114, in sharded_state_dict [rank1]: state_dict = self.mcore_optimizer.sharded_state_dict( [rank1]: File "/home/usr/code/Megatron-LM/megatron/core/optimizer/distrib_optimizer.py", line 950, in sharded_state_dict [rank1]: param_state = self.sharded_param_state_fs_model_space( [rank1]: File "/home/usr/code/Megatron-LM/megatron/core/optimizer/distrib_optimizer.py", line 1161, in sharded_param_state_fs_model_space [rank1]: dtype=state_ten.dtype, [rank1]: AttributeError: 'NoneType' object has no attribute 'dtype' ``` **Steps/Code to reproduce bug** ``` nemorun llm pretrain --factory llama3_8b trainer.max_steps=4000 trainer.num_nodes=1 trainer.devices=2 data.seq_length=128 data.global_batch_size=24 model.config.seq_length=128 model.config.num_layers=4 model.config.hidden_size=256 model.config.ffn_hidden_size=1024 log.log_dir=exp_0929_n1d2_mini_fixckptsave trainer.strategy.save_ckpt_format=torch -y ``` DEBUG: master_param, dict_keys(['fp32_param', 'exp_avg', 'exp_avg_sq', 'master_param']) DEBUG: master_param, dict_keys(['fp32_param', 'exp_avg', 'exp_avg_sq', 'master_param'])
{ "login": "lifeiteng", "id": 3107839, "node_id": "MDQ6VXNlcjMxMDc4Mzk=", "avatar_url": "https://avatars.githubusercontent.com/u/3107839?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lifeiteng", "html_url": "https://github.com/lifeiteng", "followers_url": "https://api.github.com/users/lifeiteng/followers", "following_url": "https://api.github.com/users/lifeiteng/following{/other_user}", "gists_url": "https://api.github.com/users/lifeiteng/gists{/gist_id}", "starred_url": "https://api.github.com/users/lifeiteng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lifeiteng/subscriptions", "organizations_url": "https://api.github.com/users/lifeiteng/orgs", "repos_url": "https://api.github.com/users/lifeiteng/repos", "events_url": "https://api.github.com/users/lifeiteng/events{/privacy}", "received_events_url": "https://api.github.com/users/lifeiteng/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10675/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10675/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10674
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10674/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10674/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10674/events
https://github.com/NVIDIA/NeMo/pull/10674
2,554,572,657
PR_kwDOC_bI7s59AjGV
10,674
Bump `Dockerfile.ci` (2024-09-29)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-29T00:24:49
2024-10-03T13:33:24
2024-10-03T13:33:24
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10674", "html_url": "https://github.com/NVIDIA/NeMo/pull/10674", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10674.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10674.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10674/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10674/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10673
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10673/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10673/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10673/events
https://github.com/NVIDIA/NeMo/pull/10673
2,554,072,577
PR_kwDOC_bI7s58-5XE
10,673
integration fixes for vllm 0.5.5
{ "login": "HuiyingLi", "id": 1331543, "node_id": "MDQ6VXNlcjEzMzE1NDM=", "avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4", "gravatar_id": "", "url": "https://api.github.com/users/HuiyingLi", "html_url": "https://github.com/HuiyingLi", "followers_url": "https://api.github.com/users/HuiyingLi/followers", "following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}", "gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}", "starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions", "organizations_url": "https://api.github.com/users/HuiyingLi/orgs", "repos_url": "https://api.github.com/users/HuiyingLi/repos", "events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}", "received_events_url": "https://api.github.com/users/HuiyingLi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-09-28T07:10:21
2024-10-01T16:36:43
2024-10-01T16:36:42
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10673", "html_url": "https://github.com/NVIDIA/NeMo/pull/10673", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10673.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10673.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "HuiyingLi", "id": 1331543, "node_id": "MDQ6VXNlcjEzMzE1NDM=", "avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4", "gravatar_id": "", "url": "https://api.github.com/users/HuiyingLi", "html_url": "https://github.com/HuiyingLi", "followers_url": "https://api.github.com/users/HuiyingLi/followers", "following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}", "gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}", "starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions", "organizations_url": "https://api.github.com/users/HuiyingLi/orgs", "repos_url": "https://api.github.com/users/HuiyingLi/repos", "events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}", "received_events_url": "https://api.github.com/users/HuiyingLi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10673/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10673/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10672
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10672/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10672/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10672/events
https://github.com/NVIDIA/NeMo/pull/10672
2,553,911,635
PR_kwDOC_bI7s58-YOb
10,672
Bump `Dockerfile.ci` (2024-09-28)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-28T00:21:47
2024-10-03T13:33:20
2024-10-03T13:33:20
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10672", "html_url": "https://github.com/NVIDIA/NeMo/pull/10672", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10672.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10672.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10672/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10672/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10671
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10671/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10671/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10671/events
https://github.com/NVIDIA/NeMo/pull/10671
2,553,899,649
PR_kwDOC_bI7s58-Vr0
10,671
Add slimpajama example
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "Let's move notebooks to ./tutorials", "> I completed the technical edit of the tutorials/llm/slimpajama/data_pipeline.ipynb and tutorials/llm/slimpajama/pretraining.ipynb files and left comments. Please review the copyedits, make the changes to the source files, and resolve all open threads in the Reply field.\r\n\r\nI have made all the changes and resolved the threads, PTAL.", "[🤖]: Hi @hemildesai 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11902069897) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g", "Can we move this into the llama-3 folder, and add a README there with\r\n* Pre-requisites / Requirements \r\n* Instructions to use the container \r\n* Start jupyter notebook. \r\n \r\nReference: https://github.com/NVIDIA/NeMo/tree/main/tutorials/llm/llama-3/biomedical-qa\r\n\r\nDoes not have to be very comprehensive, just what the user needs to know/do to be able to run this.\r\n\r\n", "@shashank3959 Addressed the comments in https://github.com/NVIDIA/NeMo/pull/10671/commits/dc304df6e3cc2974045cfa745581fbb57a19fe1b", "@HuiyingLi addressed your comments, could you reapprove?", "[🤖]: Hi @hemildesai 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12399331055) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g" ]
2024-09-28T00:01:14
2024-12-19T19:40:01
2024-12-19T19:39:59
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10671", "html_url": "https://github.com/NVIDIA/NeMo/pull/10671", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10671.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10671.patch", "merged_at": "2024-12-19T19:39:59" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10671/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10671/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10669
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10669/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10669/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10669/events
https://github.com/NVIDIA/NeMo/pull/10669
2,553,770,873
PR_kwDOC_bI7s58953s
10,669
Update NeVA Mixtral Tutorial
{ "login": "paul-gibbons", "id": 87940629, "node_id": "MDQ6VXNlcjg3OTQwNjI5", "avatar_url": "https://avatars.githubusercontent.com/u/87940629?v=4", "gravatar_id": "", "url": "https://api.github.com/users/paul-gibbons", "html_url": "https://github.com/paul-gibbons", "followers_url": "https://api.github.com/users/paul-gibbons/followers", "following_url": "https://api.github.com/users/paul-gibbons/following{/other_user}", "gists_url": "https://api.github.com/users/paul-gibbons/gists{/gist_id}", "starred_url": "https://api.github.com/users/paul-gibbons/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/paul-gibbons/subscriptions", "organizations_url": "https://api.github.com/users/paul-gibbons/orgs", "repos_url": "https://api.github.com/users/paul-gibbons/repos", "events_url": "https://api.github.com/users/paul-gibbons/events{/privacy}", "received_events_url": "https://api.github.com/users/paul-gibbons/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
{ "login": "paul-gibbons", "id": 87940629, "node_id": "MDQ6VXNlcjg3OTQwNjI5", "avatar_url": "https://avatars.githubusercontent.com/u/87940629?v=4", "gravatar_id": "", "url": "https://api.github.com/users/paul-gibbons", "html_url": "https://github.com/paul-gibbons", "followers_url": "https://api.github.com/users/paul-gibbons/followers", "following_url": "https://api.github.com/users/paul-gibbons/following{/other_user}", "gists_url": "https://api.github.com/users/paul-gibbons/gists{/gist_id}", "starred_url": "https://api.github.com/users/paul-gibbons/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/paul-gibbons/subscriptions", "organizations_url": "https://api.github.com/users/paul-gibbons/orgs", "repos_url": "https://api.github.com/users/paul-gibbons/repos", "events_url": "https://api.github.com/users/paul-gibbons/events{/privacy}", "received_events_url": "https://api.github.com/users/paul-gibbons/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "paul-gibbons", "id": 87940629, "node_id": "MDQ6VXNlcjg3OTQwNjI5", "avatar_url": "https://avatars.githubusercontent.com/u/87940629?v=4", "gravatar_id": "", "url": "https://api.github.com/users/paul-gibbons", "html_url": "https://github.com/paul-gibbons", "followers_url": "https://api.github.com/users/paul-gibbons/followers", "following_url": "https://api.github.com/users/paul-gibbons/following{/other_user}", "gists_url": "https://api.github.com/users/paul-gibbons/gists{/gist_id}", "starred_url": "https://api.github.com/users/paul-gibbons/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/paul-gibbons/subscriptions", "organizations_url": "https://api.github.com/users/paul-gibbons/orgs", "repos_url": "https://api.github.com/users/paul-gibbons/repos", "events_url": "https://api.github.com/users/paul-gibbons/events{/privacy}", "received_events_url": "https://api.github.com/users/paul-gibbons/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-09-27T21:39:34
2024-10-01T23:05:41
2024-10-01T23:05:41
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10669", "html_url": "https://github.com/NVIDIA/NeMo/pull/10669", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10669.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10669.patch", "merged_at": "2024-10-01T23:05:41" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10669/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10669/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10668
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10668/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10668/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10668/events
https://github.com/NVIDIA/NeMo/pull/10668
2,553,763,625
PR_kwDOC_bI7s5894MZ
10,668
enable ucc interface for cp
{ "login": "youngeunkwon0405", "id": 169120659, "node_id": "U_kgDOChSTkw", "avatar_url": "https://avatars.githubusercontent.com/u/169120659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/youngeunkwon0405", "html_url": "https://github.com/youngeunkwon0405", "followers_url": "https://api.github.com/users/youngeunkwon0405/followers", "following_url": "https://api.github.com/users/youngeunkwon0405/following{/other_user}", "gists_url": "https://api.github.com/users/youngeunkwon0405/gists{/gist_id}", "starred_url": "https://api.github.com/users/youngeunkwon0405/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/youngeunkwon0405/subscriptions", "organizations_url": "https://api.github.com/users/youngeunkwon0405/orgs", "repos_url": "https://api.github.com/users/youngeunkwon0405/repos", "events_url": "https://api.github.com/users/youngeunkwon0405/events{/privacy}", "received_events_url": "https://api.github.com/users/youngeunkwon0405/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-27T21:34:08
2024-10-19T01:57:56
2024-10-19T01:57:55
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10668", "html_url": "https://github.com/NVIDIA/NeMo/pull/10668", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10668.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10668.patch", "merged_at": null }
# What does this PR do ? +training.model.context_parallel_comm_backend=ucc You also need to disable the CUDA_DEVICE_MAX_CONNECTIONS=1 restriction. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10668/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10668/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10667
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10667/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10667/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10667/events
https://github.com/NVIDIA/NeMo/pull/10667
2,553,665,650
PR_kwDOC_bI7s589jgV
10,667
Revert always_save_context to False
{ "login": "athitten", "id": 47577437, "node_id": "MDQ6VXNlcjQ3NTc3NDM3", "avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4", "gravatar_id": "", "url": "https://api.github.com/users/athitten", "html_url": "https://github.com/athitten", "followers_url": "https://api.github.com/users/athitten/followers", "following_url": "https://api.github.com/users/athitten/following{/other_user}", "gists_url": "https://api.github.com/users/athitten/gists{/gist_id}", "starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/athitten/subscriptions", "organizations_url": "https://api.github.com/users/athitten/orgs", "repos_url": "https://api.github.com/users/athitten/repos", "events_url": "https://api.github.com/users/athitten/events{/privacy}", "received_events_url": "https://api.github.com/users/athitten/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @athitten 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11077381389) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-27T20:14:04
2024-10-04T16:11:40
2024-10-04T16:11:38
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10667", "html_url": "https://github.com/NVIDIA/NeMo/pull/10667", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10667.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10667.patch", "merged_at": "2024-10-04T16:11:38" }
# What does this PR do ? Reverts [PR 10547](https://github.com/NVIDIA/NeMo/pull/10547) **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "athitten", "id": 47577437, "node_id": "MDQ6VXNlcjQ3NTc3NDM3", "avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4", "gravatar_id": "", "url": "https://api.github.com/users/athitten", "html_url": "https://github.com/athitten", "followers_url": "https://api.github.com/users/athitten/followers", "following_url": "https://api.github.com/users/athitten/following{/other_user}", "gists_url": "https://api.github.com/users/athitten/gists{/gist_id}", "starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/athitten/subscriptions", "organizations_url": "https://api.github.com/users/athitten/orgs", "repos_url": "https://api.github.com/users/athitten/repos", "events_url": "https://api.github.com/users/athitten/events{/privacy}", "received_events_url": "https://api.github.com/users/athitten/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10667/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10667/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10666
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10666/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10666/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10666/events
https://github.com/NVIDIA/NeMo/pull/10666
2,553,659,801
PR_kwDOC_bI7s589iNo
10,666
enabling data parallel comm backend arg
{ "login": "youngeunkwon0405", "id": 169120659, "node_id": "U_kgDOChSTkw", "avatar_url": "https://avatars.githubusercontent.com/u/169120659?v=4", "gravatar_id": "", "url": "https://api.github.com/users/youngeunkwon0405", "html_url": "https://github.com/youngeunkwon0405", "followers_url": "https://api.github.com/users/youngeunkwon0405/followers", "following_url": "https://api.github.com/users/youngeunkwon0405/following{/other_user}", "gists_url": "https://api.github.com/users/youngeunkwon0405/gists{/gist_id}", "starred_url": "https://api.github.com/users/youngeunkwon0405/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/youngeunkwon0405/subscriptions", "organizations_url": "https://api.github.com/users/youngeunkwon0405/orgs", "repos_url": "https://api.github.com/users/youngeunkwon0405/repos", "events_url": "https://api.github.com/users/youngeunkwon0405/events{/privacy}", "received_events_url": "https://api.github.com/users/youngeunkwon0405/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-27T20:09:50
2024-10-19T01:57:57
2024-10-19T01:57:57
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10666", "html_url": "https://github.com/NVIDIA/NeMo/pull/10666", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10666.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10666.patch", "merged_at": null }
# What does this PR do ? +training.model.data_parallel_comm_backend=ucc set CUDA_DEVICE_MAX_CONNECTIONS=8 which is in NeMo-Launcher `launcher/launcher_scripts/nemo_launcher/core/stages.py:_cuda_device_max_connections()` **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10666/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10666/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10665
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10665/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10665/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10665/events
https://github.com/NVIDIA/NeMo/pull/10665
2,553,464,419
PR_kwDOC_bI7s5883jk
10,665
Respect load strictness when calling load_state_dict
{ "login": "mikolajblaz", "id": 9979479, "node_id": "MDQ6VXNlcjk5Nzk0Nzk=", "avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mikolajblaz", "html_url": "https://github.com/mikolajblaz", "followers_url": "https://api.github.com/users/mikolajblaz/followers", "following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}", "gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions", "organizations_url": "https://api.github.com/users/mikolajblaz/orgs", "repos_url": "https://api.github.com/users/mikolajblaz/repos", "events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}", "received_events_url": "https://api.github.com/users/mikolajblaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "According to @ashors1 this type of change is not needed for NeMo 2.0, so should be ready to go, @dimapihtar can you review?", "> According to @ashors1 this type of change is not needed for NeMo 2.0, so should be ready to go, @dimapihtar can you review?\r\n\r\nI think there was a miscommunication here. This change is needed for NeMo 2.0, but I think we can handle that in a separate PR.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-27T18:03:45
2024-11-13T01:58:16
2024-11-13T01:58:15
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10665", "html_url": "https://github.com/NVIDIA/NeMo/pull/10665", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10665.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10665.patch", "merged_at": null }
# What does this PR do ? `model.dist_ckpt_load_strictness` allows to ignore mismatches during checkpoint loading. Still, loading a state dict can yield errors. This PR ensures this flag is respected also during load_state_dict. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10665/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10665/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10664
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10664/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10664/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10664/events
https://github.com/NVIDIA/NeMo/pull/10664
2,553,440,012
PR_kwDOC_bI7s588yJP
10,664
Cherry pick `Updating modelopt spec for Mixtral (10660)` into `r2.0.0`
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Thanks @ko3n1g, I'll merge that" ]
2024-09-27T17:47:58
2024-09-30T13:29:37
2024-09-30T13:29:35
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10664", "html_url": "https://github.com/NVIDIA/NeMo/pull/10664", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10664.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10664.patch", "merged_at": "2024-09-30T13:29:35" }
[🤖]: Hi @janekl 👋,<br><br>we've cherry picked #10660 into `r2.0.0` for you! 🚀<br><br>Please review and approve this cherry pick by your convenience\!
{ "login": "janekl", "id": 5582967, "node_id": "MDQ6VXNlcjU1ODI5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janekl", "html_url": "https://github.com/janekl", "followers_url": "https://api.github.com/users/janekl/followers", "following_url": "https://api.github.com/users/janekl/following{/other_user}", "gists_url": "https://api.github.com/users/janekl/gists{/gist_id}", "starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janekl/subscriptions", "organizations_url": "https://api.github.com/users/janekl/orgs", "repos_url": "https://api.github.com/users/janekl/repos", "events_url": "https://api.github.com/users/janekl/events{/privacy}", "received_events_url": "https://api.github.com/users/janekl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10664/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10664/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10663
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10663/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10663/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10663/events
https://github.com/NVIDIA/NeMo/pull/10663
2,553,353,778
PR_kwDOC_bI7s588fEa
10,663
[r2.0.0] Change default for always_save_context to True
{ "login": "athitten", "id": 47577437, "node_id": "MDQ6VXNlcjQ3NTc3NDM3", "avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4", "gravatar_id": "", "url": "https://api.github.com/users/athitten", "html_url": "https://github.com/athitten", "followers_url": "https://api.github.com/users/athitten/followers", "following_url": "https://api.github.com/users/athitten/following{/other_user}", "gists_url": "https://api.github.com/users/athitten/gists{/gist_id}", "starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/athitten/subscriptions", "organizations_url": "https://api.github.com/users/athitten/orgs", "repos_url": "https://api.github.com/users/athitten/repos", "events_url": "https://api.github.com/users/athitten/events{/privacy}", "received_events_url": "https://api.github.com/users/athitten/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-27T16:52:38
2024-10-19T01:57:59
2024-10-19T01:57:58
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10663", "html_url": "https://github.com/NVIDIA/NeMo/pull/10663", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10663.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10663.patch", "merged_at": null }
# What does this PR do ? Set the default value of always_save_context to True as its required to have the context for evaluating NeMo 2.0 ckpt as of now since we are converting it to 1.0 ckpt using this script: [convert_nemo2_for_export.py](https://github.com/NVIDIA/NeMo/blob/main/scripts/export/convert_nemo2_for_export.py) to export to TRTLLM for evaluation. Replicate of [PR 10547](https://github.com/NVIDIA/NeMo/pull/10547) which has been merged to main. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10663/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10663/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10662
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10662/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10662/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10662/events
https://github.com/NVIDIA/NeMo/pull/10662
2,553,351,541
PR_kwDOC_bI7s588elP
10,662
DB tutorial ckpt path update
{ "login": "Victor49152", "id": 111467530, "node_id": "U_kgDOBqTcCg", "avatar_url": "https://avatars.githubusercontent.com/u/111467530?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Victor49152", "html_url": "https://github.com/Victor49152", "followers_url": "https://api.github.com/users/Victor49152/followers", "following_url": "https://api.github.com/users/Victor49152/following{/other_user}", "gists_url": "https://api.github.com/users/Victor49152/gists{/gist_id}", "starred_url": "https://api.github.com/users/Victor49152/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Victor49152/subscriptions", "organizations_url": "https://api.github.com/users/Victor49152/orgs", "repos_url": "https://api.github.com/users/Victor49152/repos", "events_url": "https://api.github.com/users/Victor49152/events{/privacy}", "received_events_url": "https://api.github.com/users/Victor49152/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @Victor49152 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11074608210) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-27T16:51:09
2024-09-30T18:08:36
2024-09-30T18:08:34
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10662", "html_url": "https://github.com/NVIDIA/NeMo/pull/10662", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10662.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10662.patch", "merged_at": "2024-09-30T18:08:34" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10662/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10662/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10661
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10661/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10661/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10661/events
https://github.com/NVIDIA/NeMo/pull/10661
2,553,330,543
PR_kwDOC_bI7s588Z-k
10,661
Check for meta tensors in checkpoint
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11409469039) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-27T16:37:03
2024-11-11T01:58:46
2024-11-11T01:58:46
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10661", "html_url": "https://github.com/NVIDIA/NeMo/pull/10661", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10661.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10661.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10661/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10661/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10660
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10660/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10660/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10660/events
https://github.com/NVIDIA/NeMo/pull/10660
2,553,098,165
PR_kwDOC_bI7s587m1h
10,660
Updating modelopt spec for Mixtral
{ "login": "janekl", "id": 5582967, "node_id": "MDQ6VXNlcjU1ODI5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janekl", "html_url": "https://github.com/janekl", "followers_url": "https://api.github.com/users/janekl/followers", "following_url": "https://api.github.com/users/janekl/following{/other_user}", "gists_url": "https://api.github.com/users/janekl/gists{/gist_id}", "starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janekl/subscriptions", "organizations_url": "https://api.github.com/users/janekl/orgs", "repos_url": "https://api.github.com/users/janekl/repos", "events_url": "https://api.github.com/users/janekl/events{/privacy}", "received_events_url": "https://api.github.com/users/janekl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @janekl 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11072591119) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-27T14:34:51
2024-09-27T17:47:34
2024-09-27T17:47:32
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10660", "html_url": "https://github.com/NVIDIA/NeMo/pull/10660", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10660.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10660.patch", "merged_at": "2024-09-27T17:47:32" }
# What does this PR do ? Updating modelopt layer specification to extend PTQ support for Mixtral, see also https://github.com/NVIDIA/Megatron-LM/blob/main/megatron/core/models/gpt/gpt_layer_specs.py. **Collection**: NLP # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10660/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10660/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10659
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10659/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10659/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10659/events
https://github.com/NVIDIA/NeMo/pull/10659
2,553,039,110
PR_kwDOC_bI7s587Zsg
10,659
Require setuptools>=70 and update deprecated api
{ "login": "thomasdhc", "id": 9426164, "node_id": "MDQ6VXNlcjk0MjYxNjQ=", "avatar_url": "https://avatars.githubusercontent.com/u/9426164?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thomasdhc", "html_url": "https://github.com/thomasdhc", "followers_url": "https://api.github.com/users/thomasdhc/followers", "following_url": "https://api.github.com/users/thomasdhc/following{/other_user}", "gists_url": "https://api.github.com/users/thomasdhc/gists{/gist_id}", "starred_url": "https://api.github.com/users/thomasdhc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thomasdhc/subscriptions", "organizations_url": "https://api.github.com/users/thomasdhc/orgs", "repos_url": "https://api.github.com/users/thomasdhc/repos", "events_url": "https://api.github.com/users/thomasdhc/events{/privacy}", "received_events_url": "https://api.github.com/users/thomasdhc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @thomasdhc 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11072237404) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @thomasdhc 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11072237404) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @thomasdhc 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11072237404) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @thomasdhc 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11072237404) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-27T14:07:43
2024-09-30T16:43:43
2024-09-30T16:43:41
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10659", "html_url": "https://github.com/NVIDIA/NeMo/pull/10659", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10659.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10659.patch", "merged_at": "2024-09-30T16:43:41" }
# What does this PR do ? Require setuptools>=70 and update deprecated api **Collection**: [nlp, multimodal] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "thomasdhc", "id": 9426164, "node_id": "MDQ6VXNlcjk0MjYxNjQ=", "avatar_url": "https://avatars.githubusercontent.com/u/9426164?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thomasdhc", "html_url": "https://github.com/thomasdhc", "followers_url": "https://api.github.com/users/thomasdhc/followers", "following_url": "https://api.github.com/users/thomasdhc/following{/other_user}", "gists_url": "https://api.github.com/users/thomasdhc/gists{/gist_id}", "starred_url": "https://api.github.com/users/thomasdhc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thomasdhc/subscriptions", "organizations_url": "https://api.github.com/users/thomasdhc/orgs", "repos_url": "https://api.github.com/users/thomasdhc/repos", "events_url": "https://api.github.com/users/thomasdhc/events{/privacy}", "received_events_url": "https://api.github.com/users/thomasdhc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10659/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10659/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10657
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10657/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10657/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10657/events
https://github.com/NVIDIA/NeMo/pull/10657
2,552,349,680
PR_kwDOC_bI7s585BHK
10,657
ci: Switch to reusable workflows
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @ko3n1g 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11067376938) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @ko3n1g 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11067376938) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @ko3n1g 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11067516863) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @ko3n1g 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11067566857) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @ko3n1g 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11067584856) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-27T08:36:01
2024-10-27T02:02:43
2024-10-27T02:02:43
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10657", "html_url": "https://github.com/NVIDIA/NeMo/pull/10657", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10657.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10657.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10657/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10657/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10656
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10656/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10656/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10656/events
https://github.com/NVIDIA/NeMo/pull/10656
2,552,311,463
PR_kwDOC_bI7s5844po
10,656
chore(ci): Increase shm to 64gb
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @ko3n1g 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11067068654) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-27T08:17:05
2024-09-27T10:07:55
2024-09-27T10:07:53
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10656", "html_url": "https://github.com/NVIDIA/NeMo/pull/10656", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10656.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10656.patch", "merged_at": "2024-09-27T10:07:53" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10656/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10656/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10655
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10655/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10655/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10655/events
https://github.com/NVIDIA/NeMo/pull/10655
2,552,167,135
PR_kwDOC_bI7s584Y0i
10,655
NeMo 2.0 mixtral ci test
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @akoumpa 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11076011308) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @akoumpa 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11139100590) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-27T07:03:19
2024-10-02T21:05:42
2024-10-02T21:02:24
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10655", "html_url": "https://github.com/NVIDIA/NeMo/pull/10655", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10655.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10655.patch", "merged_at": "2024-10-02T21:02:24" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10655/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10655/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10654
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10654/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10654/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10654/events
https://github.com/NVIDIA/NeMo/pull/10654
2,552,109,543
PR_kwDOC_bI7s584Mpb
10,654
feat: Migrate GPTSession refit path in Nemo export to ModelRunner for Aligner
{ "login": "terrykong", "id": 7576060, "node_id": "MDQ6VXNlcjc1NzYwNjA=", "avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4", "gravatar_id": "", "url": "https://api.github.com/users/terrykong", "html_url": "https://github.com/terrykong", "followers_url": "https://api.github.com/users/terrykong/followers", "following_url": "https://api.github.com/users/terrykong/following{/other_user}", "gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}", "starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/terrykong/subscriptions", "organizations_url": "https://api.github.com/users/terrykong/orgs", "repos_url": "https://api.github.com/users/terrykong/repos", "events_url": "https://api.github.com/users/terrykong/events{/privacy}", "received_events_url": "https://api.github.com/users/terrykong/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @terrykong 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11135920199) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-27T06:28:04
2024-10-02T17:43:29
2024-10-02T17:43:27
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10654", "html_url": "https://github.com/NVIDIA/NeMo/pull/10654", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10654.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10654.patch", "merged_at": "2024-10-02T17:43:27" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10654/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10654/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10653
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10653/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10653/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10653/events
https://github.com/NVIDIA/NeMo/pull/10653
2,552,107,899
PR_kwDOC_bI7s584MSd
10,653
fix: MegatronGPTModel get_forward_output_only_func position_ids=None
{ "login": "terrykong", "id": 7576060, "node_id": "MDQ6VXNlcjc1NzYwNjA=", "avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4", "gravatar_id": "", "url": "https://api.github.com/users/terrykong", "html_url": "https://github.com/terrykong", "followers_url": "https://api.github.com/users/terrykong/followers", "following_url": "https://api.github.com/users/terrykong/following{/other_user}", "gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}", "starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/terrykong/subscriptions", "organizations_url": "https://api.github.com/users/terrykong/orgs", "repos_url": "https://api.github.com/users/terrykong/repos", "events_url": "https://api.github.com/users/terrykong/events{/privacy}", "received_events_url": "https://api.github.com/users/terrykong/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @terrykong 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11135925291) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-27T06:26:52
2024-10-08T21:53:41
2024-10-08T21:53:31
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10653", "html_url": "https://github.com/NVIDIA/NeMo/pull/10653", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10653.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10653.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "terrykong", "id": 7576060, "node_id": "MDQ6VXNlcjc1NzYwNjA=", "avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4", "gravatar_id": "", "url": "https://api.github.com/users/terrykong", "html_url": "https://github.com/terrykong", "followers_url": "https://api.github.com/users/terrykong/followers", "following_url": "https://api.github.com/users/terrykong/following{/other_user}", "gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}", "starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/terrykong/subscriptions", "organizations_url": "https://api.github.com/users/terrykong/orgs", "repos_url": "https://api.github.com/users/terrykong/repos", "events_url": "https://api.github.com/users/terrykong/events{/privacy}", "received_events_url": "https://api.github.com/users/terrykong/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10653/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10653/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10652
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10652/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10652/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10652/events
https://github.com/NVIDIA/NeMo/pull/10652
2,552,107,353
PR_kwDOC_bI7s584MK7
10,652
[feat] Update get_model_parallel_src_rank to support tp-pp-dp ordering
{ "login": "terrykong", "id": 7576060, "node_id": "MDQ6VXNlcjc1NzYwNjA=", "avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4", "gravatar_id": "", "url": "https://api.github.com/users/terrykong", "html_url": "https://github.com/terrykong", "followers_url": "https://api.github.com/users/terrykong/followers", "following_url": "https://api.github.com/users/terrykong/following{/other_user}", "gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}", "starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/terrykong/subscriptions", "organizations_url": "https://api.github.com/users/terrykong/orgs", "repos_url": "https://api.github.com/users/terrykong/repos", "events_url": "https://api.github.com/users/terrykong/events{/privacy}", "received_events_url": "https://api.github.com/users/terrykong/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @terrykong 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11135924122) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-27T06:26:28
2024-10-02T16:34:00
2024-10-02T16:33:58
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10652", "html_url": "https://github.com/NVIDIA/NeMo/pull/10652", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10652.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10652.patch", "merged_at": "2024-10-02T16:33:58" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10652/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10652/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10651
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10651/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10651/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10651/events
https://github.com/NVIDIA/NeMo/pull/10651
2,552,105,704
PR_kwDOC_bI7s584Lzt
10,651
[fix] Ensures disabling exp_manager with exp_manager=null does not error
{ "login": "terrykong", "id": 7576060, "node_id": "MDQ6VXNlcjc1NzYwNjA=", "avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4", "gravatar_id": "", "url": "https://api.github.com/users/terrykong", "html_url": "https://github.com/terrykong", "followers_url": "https://api.github.com/users/terrykong/followers", "following_url": "https://api.github.com/users/terrykong/following{/other_user}", "gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}", "starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/terrykong/subscriptions", "organizations_url": "https://api.github.com/users/terrykong/orgs", "repos_url": "https://api.github.com/users/terrykong/repos", "events_url": "https://api.github.com/users/terrykong/events{/privacy}", "received_events_url": "https://api.github.com/users/terrykong/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @terrykong 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11135922883) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-27T06:25:19
2024-10-02T16:32:24
2024-10-02T16:32:22
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10651", "html_url": "https://github.com/NVIDIA/NeMo/pull/10651", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10651.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10651.patch", "merged_at": "2024-10-02T16:32:22" }
For context, None is supposed to be supported by exp_manager: https://github.com/NVIDIA/NeMo/blob/5bd2b899964057efb2ab72fd040b5b386c5b557d/nemo/utils/exp_manager.py#L387-L389 # What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10651/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10651/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10650
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10650/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10650/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10650/events
https://github.com/NVIDIA/NeMo/pull/10650
2,551,753,540
PR_kwDOC_bI7s583AG8
10,650
Bump `Dockerfile.ci` (2024-09-27)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-27T00:22:06
2024-10-03T13:33:17
2024-10-03T13:33:17
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10650", "html_url": "https://github.com/NVIDIA/NeMo/pull/10650", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10650.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10650.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10650/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10650/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10649
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10649/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10649/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10649/events
https://github.com/NVIDIA/NeMo/pull/10649
2,551,701,929
PR_kwDOC_bI7s5820fL
10,649
Update llm recipe README to add a note about handling multi-process jobs
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-09-26T23:43:46
2024-09-27T19:33:29
2024-09-27T19:33:27
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10649", "html_url": "https://github.com/NVIDIA/NeMo/pull/10649", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10649.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10649.patch", "merged_at": "2024-09-27T19:33:27" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10649/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10649/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10648
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10648/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10648/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10648/events
https://github.com/NVIDIA/NeMo/pull/10648
2,551,683,235
PR_kwDOC_bI7s582wYB
10,648
Add support for limit_train_batches to megatron sampler classes
{ "login": "trias702", "id": 25867060, "node_id": "MDQ6VXNlcjI1ODY3MDYw", "avatar_url": "https://avatars.githubusercontent.com/u/25867060?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trias702", "html_url": "https://github.com/trias702", "followers_url": "https://api.github.com/users/trias702/followers", "following_url": "https://api.github.com/users/trias702/following{/other_user}", "gists_url": "https://api.github.com/users/trias702/gists{/gist_id}", "starred_url": "https://api.github.com/users/trias702/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trias702/subscriptions", "organizations_url": "https://api.github.com/users/trias702/orgs", "repos_url": "https://api.github.com/users/trias702/repos", "events_url": "https://api.github.com/users/trias702/events{/privacy}", "received_events_url": "https://api.github.com/users/trias702/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @trias702 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11061715798) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "jenkins", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "jenkins\r\n\r\nOn Mon, Oct 28, 2024, 19:00 github-actions[bot] ***@***.***>\r\nwrote:\r\n\r\n> This PR is stale because it has been open for 14 days with no activity.\r\n> Remove stale label or comment or update or this will be closed in 7 days.\r\n>\r\n> —\r\n> Reply to this email directly, view it on GitHub\r\n> <https://github.com/NVIDIA/NeMo/pull/10648#issuecomment-2443007799>, or\r\n> unsubscribe\r\n> <https://github.com/notifications/unsubscribe-auth/AGFLGND56EFTP65AIVAI4PTZ53T3HAVCNFSM6AAAAABO6AYA72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBTGAYDONZZHE>\r\n> .\r\n> You are receiving this because you were mentioned.Message ID:\r\n> ***@***.***>\r\n>\r\n", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "Jenkins\r\n\r\nOn Fri, Nov 15, 2024, 18:01 github-actions[bot] ***@***.***>\r\nwrote:\r\n\r\n> This PR is stale because it has been open for 14 days with no activity.\r\n> Remove stale label or comment or update or this will be closed in 7 days.\r\n>\r\n> —\r\n> Reply to this email directly, view it on GitHub\r\n> <https://github.com/NVIDIA/NeMo/pull/10648#issuecomment-2480308782>, or\r\n> unsubscribe\r\n> <https://github.com/notifications/unsubscribe-auth/AGFLGNBIXM2W3FQ2QGNSDCD2A2RO3AVCNFSM6AAAAABO6AYA72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGMYDQNZYGI>\r\n> .\r\n> You are receiving this because you were mentioned.Message ID:\r\n> ***@***.***>\r\n>\r\n", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "> At first sight it seems to me that this parameter doesn't belong to the sampler, and it should be up to the caller to provide the correct value for `total_samples`. Why do you think we need it in the sampler?\r\n\r\nWe spoke about this before in a meeting, and I told you we can either hack it in via the algorithm class, or put it inside the Sampler, and you said inside the Sampler was the correct place for it.", "> > At first sight it seems to me that this parameter doesn't belong to the sampler, and it should be up to the caller to provide the correct value for `total_samples`. Why do you think we need it in the sampler?\r\n> \r\n> We spoke about this before in a meeting, and I told you we can either hack it in via the algorithm class, or put it inside the Sampler, and you said inside the Sampler was the correct place for it.\r\n\r\nAh, my memory is failing me, though as discussed in https://github.com/NVIDIA/NeMo-Aligner/pull/321#discussion_r1868633286 there's a way to do it without it being a hack -- I assume we hadn't thought of this option when we spoke about it (really can't remember, sorry).", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-26T23:20:24
2024-12-28T01:57:06
2024-12-28T01:57:06
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10648", "html_url": "https://github.com/NVIDIA/NeMo/pull/10648", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10648.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10648.patch", "merged_at": null }
# What does this PR do ? Adds support for limit_train_batches (as used in PTL) to work correctly. Without this PR, use of limit_train_batches less than 1.0 or num_samples will not work correctly when doing multi-epoch training in downstream libraries such as Nemo-Aligner. **Collection**: NLP # Changelog - nemo/collections/nlp/data/language_modeling/megatron/data_samplers.py: alters constructor parameters for limit_train_batches and adds additional constructor logic to limit total_samples as necessary - nemo/collections/nlp/data/language_modeling/megatron/megatron_batch_samplers.py: alters constructor parameters for limit_train_batches and adds additional constructor logic to limit total_samples as necessary # Usage You can now pass an additional parameter, `limit_train_batches` to all 4 Sampler classes # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [X] New Feature - [X] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10648/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10648/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10647
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10647/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10647/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10647/events
https://github.com/NVIDIA/NeMo/pull/10647
2,551,666,351
PR_kwDOC_bI7s582stE
10,647
Checkpoint connector bugfixes
{ "login": "jstjohn", "id": 459014, "node_id": "MDQ6VXNlcjQ1OTAxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/459014?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jstjohn", "html_url": "https://github.com/jstjohn", "followers_url": "https://api.github.com/users/jstjohn/followers", "following_url": "https://api.github.com/users/jstjohn/following{/other_user}", "gists_url": "https://api.github.com/users/jstjohn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jstjohn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jstjohn/subscriptions", "organizations_url": "https://api.github.com/users/jstjohn/orgs", "repos_url": "https://api.github.com/users/jstjohn/repos", "events_url": "https://api.github.com/users/jstjohn/events{/privacy}", "received_events_url": "https://api.github.com/users/jstjohn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
{ "login": "jstjohn", "id": 459014, "node_id": "MDQ6VXNlcjQ1OTAxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/459014?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jstjohn", "html_url": "https://github.com/jstjohn", "followers_url": "https://api.github.com/users/jstjohn/followers", "following_url": "https://api.github.com/users/jstjohn/following{/other_user}", "gists_url": "https://api.github.com/users/jstjohn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jstjohn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jstjohn/subscriptions", "organizations_url": "https://api.github.com/users/jstjohn/orgs", "repos_url": "https://api.github.com/users/jstjohn/repos", "events_url": "https://api.github.com/users/jstjohn/events{/privacy}", "received_events_url": "https://api.github.com/users/jstjohn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "jstjohn", "id": 459014, "node_id": "MDQ6VXNlcjQ1OTAxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/459014?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jstjohn", "html_url": "https://github.com/jstjohn", "followers_url": "https://api.github.com/users/jstjohn/followers", "following_url": "https://api.github.com/users/jstjohn/following{/other_user}", "gists_url": "https://api.github.com/users/jstjohn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jstjohn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jstjohn/subscriptions", "organizations_url": "https://api.github.com/users/jstjohn/orgs", "repos_url": "https://api.github.com/users/jstjohn/repos", "events_url": "https://api.github.com/users/jstjohn/events{/privacy}", "received_events_url": "https://api.github.com/users/jstjohn/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "[🤖]: Hi @jstjohn 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11110721974) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "CI seems to have an issue with CI assets; will retry it later.", "[🤖]: Hi @jstjohn 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/$REPOSITORY/actions/runs/$RUN_ID) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g", "This needs https://github.com/NVIDIA/NeMo/pull/10786" ]
2024-09-26T23:00:17
2024-10-07T18:58:44
2024-10-05T04:28:02
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10647", "html_url": "https://github.com/NVIDIA/NeMo/pull/10647", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10647.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10647.patch", "merged_at": "2024-10-05T04:28:02" }
# What does this PR do ? Get checkpoint connector working for bionemo (see https://github.com/NVIDIA/bionemo-fw-ea/pull/180) # Changelog - Use new nemo2 standard `/weights` and `/context` subdirectory scheme so checkpoint loaders work properly with checkpoints created by this method. - dedup [ckpt_to_dir](https://github.com/NVIDIA/NeMo/pull/10647/files#diff-8b8117bc8b07d1fa52030c25e6a7c7920aafa31780e2665ec5fe63939c11a622L272) - Other changes necessary to allow checkpoint transformation outside of training resumption.
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10647/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10647/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10646
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10646/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10646/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10646/events
https://github.com/NVIDIA/NeMo/pull/10646
2,551,665,598
PR_kwDOC_bI7s582sib
10,646
Add NeMo 2.0 section to the readme
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "Completed technical edit of NeMo 2.0 updates to ReadMe. LGTM." ]
2024-09-26T22:59:19
2024-10-02T05:53:52
2024-10-02T05:53:50
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10646", "html_url": "https://github.com/NVIDIA/NeMo/pull/10646", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10646.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10646.patch", "merged_at": "2024-10-02T05:53:50" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10646/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10646/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10645
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10645/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10645/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10645/events
https://github.com/NVIDIA/NeMo/pull/10645
2,551,654,308
PR_kwDOC_bI7s582qFT
10,645
Disable checkpoint conversion inside AutoResume
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "@hemildesai this is great, have you run a two node job to test resuming from an HF checkpoint? What's the process for the user? I imagine this will be a frequent request so I want to make sure it's as frictionless as possible.\r\n\r\nI did a quick pass but will revisit later today. Thanks.", "> @hemildesai this is great, have you run a two node job to test resuming from an HF checkpoint? What's the process for the user? I imagine this will be a frequent request so I want to make sure it's as frictionless as possible.\r\n> \r\n> I did a quick pass but will revisit later today. Thanks.\r\n\r\nYes we will be updating the docs soon to have this information there.", "[🤖]: Hi @hemildesai 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/$REPOSITORY/actions/runs/$RUN_ID) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g", "[🤖]: Hi @hemildesai 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/$REPOSITORY/actions/runs/$RUN_ID) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g", "> > @hemildesai this is great, have you run a two node job to test resuming from an HF checkpoint? What's the process for the user? I imagine this will be a frequent request so I want to make sure it's as frictionless as possible.\r\n> > I did a quick pass but will revisit later today. Thanks.\r\n> \r\n> Yes we will be updating the docs soon to have this information there.\r\n\r\nwhen will the docs release in roadmap? The \"import\" command-line seems to be introduce in feature, however, the converted model could not be partitioned by such as tensor partition or other method because the training strategy config is not recognized in `io.import_ckpt` function, how should I fix the problem?" ]
2024-09-26T22:46:05
2024-10-17T04:31:09
2024-10-08T18:31:13
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10645", "html_url": "https://github.com/NVIDIA/NeMo/pull/10645", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10645.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10645.patch", "merged_at": "2024-10-08T18:31:12" }
# What does this PR do ? Checkpoint conversion is not feasible inside AutoResume as it is not reliable in multi process/multi node scenarios. This update disables checkpoint conversion inside AutoResume and forces users to use a NeMo based checkpoint. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10645/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10645/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10644
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10644/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10644/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10644/events
https://github.com/NVIDIA/NeMo/pull/10644
2,551,643,356
PR_kwDOC_bI7s582n7i
10,644
fix codec/asr/mos model loading for validation
{ "login": "ehsanvidia", "id": 183026390, "node_id": "U_kgDOCujC1g", "avatar_url": "https://avatars.githubusercontent.com/u/183026390?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ehsanvidia", "html_url": "https://github.com/ehsanvidia", "followers_url": "https://api.github.com/users/ehsanvidia/followers", "following_url": "https://api.github.com/users/ehsanvidia/following{/other_user}", "gists_url": "https://api.github.com/users/ehsanvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/ehsanvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ehsanvidia/subscriptions", "organizations_url": "https://api.github.com/users/ehsanvidia/orgs", "repos_url": "https://api.github.com/users/ehsanvidia/repos", "events_url": "https://api.github.com/users/ehsanvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/ehsanvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "for using MOS model, a container with torchaudio should be used. otherwise, comment MOS model loading and inference " ]
2024-09-26T22:37:34
2024-09-27T16:29:49
2024-09-27T16:29:49
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10644", "html_url": "https://github.com/NVIDIA/NeMo/pull/10644", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10644.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10644.patch", "merged_at": "2024-09-27T16:29:49" }
# What does this PR do ? When using tensor parallelism, model assumes Nemo codec/ASR/MOS checkpoints are parallelized. This PR will fix loading checkpoints when tp is enabled ## Who can review? @zhehuaichen
{ "login": "zhehuaichen", "id": 139396994, "node_id": "U_kgDOCE8Hgg", "avatar_url": "https://avatars.githubusercontent.com/u/139396994?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zhehuaichen", "html_url": "https://github.com/zhehuaichen", "followers_url": "https://api.github.com/users/zhehuaichen/followers", "following_url": "https://api.github.com/users/zhehuaichen/following{/other_user}", "gists_url": "https://api.github.com/users/zhehuaichen/gists{/gist_id}", "starred_url": "https://api.github.com/users/zhehuaichen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zhehuaichen/subscriptions", "organizations_url": "https://api.github.com/users/zhehuaichen/orgs", "repos_url": "https://api.github.com/users/zhehuaichen/repos", "events_url": "https://api.github.com/users/zhehuaichen/events{/privacy}", "received_events_url": "https://api.github.com/users/zhehuaichen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10644/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10644/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10643
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10643/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10643/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10643/events
https://github.com/NVIDIA/NeMo/pull/10643
2,551,481,036
PR_kwDOC_bI7s582E9D
10,643
Update mcore parallelism initialization in nemo2
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "[🤖]: Hi @yaoyu-33 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11564275376) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g", "[🤖]: Hi @yaoyu-33 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11579902548) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g" ]
2024-09-26T20:30:53
2024-10-30T03:30:36
2024-10-30T03:30:36
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10643", "html_url": "https://github.com/NVIDIA/NeMo/pull/10643", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10643.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10643.patch", "merged_at": "2024-10-30T03:30:36" }
# What does this PR do ? Update to use encoder_tp_size and encoder_pp_size in MCore API. This enables more flexible parallelism in encoder-decoder models and VLMs. **Collection**: [common] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10643/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10643/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10642
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10642/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10642/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10642/events
https://github.com/NVIDIA/NeMo/pull/10642
2,551,375,026
PR_kwDOC_bI7s581txM
10,642
PTQ example for NeMo 2.0
{ "login": "Laplasjan107", "id": 67481570, "node_id": "MDQ6VXNlcjY3NDgxNTcw", "avatar_url": "https://avatars.githubusercontent.com/u/67481570?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Laplasjan107", "html_url": "https://github.com/Laplasjan107", "followers_url": "https://api.github.com/users/Laplasjan107/followers", "following_url": "https://api.github.com/users/Laplasjan107/following{/other_user}", "gists_url": "https://api.github.com/users/Laplasjan107/gists{/gist_id}", "starred_url": "https://api.github.com/users/Laplasjan107/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Laplasjan107/subscriptions", "organizations_url": "https://api.github.com/users/Laplasjan107/orgs", "repos_url": "https://api.github.com/users/Laplasjan107/repos", "events_url": "https://api.github.com/users/Laplasjan107/events{/privacy}", "received_events_url": "https://api.github.com/users/Laplasjan107/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "oyilmaz-nvidia", "id": 35306097, "node_id": "MDQ6VXNlcjM1MzA2MDk3", "avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oyilmaz-nvidia", "html_url": "https://github.com/oyilmaz-nvidia", "followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers", "following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}", "gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions", "organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs", "repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos", "events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "oyilmaz-nvidia", "id": 35306097, "node_id": "MDQ6VXNlcjM1MzA2MDk3", "avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oyilmaz-nvidia", "html_url": "https://github.com/oyilmaz-nvidia", "followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers", "following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}", "gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions", "organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs", "repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos", "events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-09-26T19:26:23
2024-10-25T10:37:15
2024-10-25T10:37:15
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10642", "html_url": "https://github.com/NVIDIA/NeMo/pull/10642", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10642.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10642.patch", "merged_at": "2024-10-25T10:37:15" }
# What does this PR do ? Example workflow for quantizing NeMo 2.0 checkpoint. **Collection**: llm # Known Issues * Observed accuracy regression on MMLU when exporting a non-quantized LLAMA3-7B: `0.654 -> 0.638` * Half-precision with PP>1 does not work # Usage * You can potentially add a usage example below ```python from nemo.collections.llm import quantization quantization_config = quantization.QuantizationConfig() export_config = quantization.ExportConfig('/tmp/trt_llama_engine') quantizer = quantization.Quantizer(quantization_config, export_config) model = quantization.load_with_modelopt_layer_spec('/path/to/nemo/checkpoint') model = quantizer.quantize(model) quantizer.export(model) ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "janekl", "id": 5582967, "node_id": "MDQ6VXNlcjU1ODI5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janekl", "html_url": "https://github.com/janekl", "followers_url": "https://api.github.com/users/janekl/followers", "following_url": "https://api.github.com/users/janekl/following{/other_user}", "gists_url": "https://api.github.com/users/janekl/gists{/gist_id}", "starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janekl/subscriptions", "organizations_url": "https://api.github.com/users/janekl/orgs", "repos_url": "https://api.github.com/users/janekl/repos", "events_url": "https://api.github.com/users/janekl/events{/privacy}", "received_events_url": "https://api.github.com/users/janekl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10642/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10642/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10641
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10641/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10641/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10641/events
https://github.com/NVIDIA/NeMo/pull/10641
2,551,288,483
PR_kwDOC_bI7s581bEC
10,641
Akoumparouli/nemo ux test fixes
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @akoumpa 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/$REPOSITORY/actions/runs/$RUN_ID) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-26T18:38:08
2024-10-04T14:31:56
2024-10-04T14:31:55
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10641", "html_url": "https://github.com/NVIDIA/NeMo/pull/10641", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10641.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10641.patch", "merged_at": "2024-10-04T14:31:55" }
# What does this PR do ? 1. environ variables 2. Microbatch config Are both stateful when multiple tests are run in the same process. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10641/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10641/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10640
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10640/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10640/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10640/events
https://github.com/NVIDIA/NeMo/pull/10640
2,551,216,242
PR_kwDOC_bI7s581LSn
10,640
Adding Resume pretraining for NeMo 2.0 T5 CICD
{ "login": "huvunvidia", "id": 86480512, "node_id": "MDQ6VXNlcjg2NDgwNTEy", "avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4", "gravatar_id": "", "url": "https://api.github.com/users/huvunvidia", "html_url": "https://github.com/huvunvidia", "followers_url": "https://api.github.com/users/huvunvidia/followers", "following_url": "https://api.github.com/users/huvunvidia/following{/other_user}", "gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions", "organizations_url": "https://api.github.com/users/huvunvidia/orgs", "repos_url": "https://api.github.com/users/huvunvidia/repos", "events_url": "https://api.github.com/users/huvunvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/huvunvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @huvunvidia 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11064119499) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-26T17:57:24
2024-09-27T22:24:55
2024-09-27T22:24:53
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10640", "html_url": "https://github.com/NVIDIA/NeMo/pull/10640", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10640.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10640.patch", "merged_at": "2024-09-27T22:24:53" }
# What does this PR do ? Adding Resume pretraining for NeMo 2.0 T5 CICD **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "huvunvidia", "id": 86480512, "node_id": "MDQ6VXNlcjg2NDgwNTEy", "avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4", "gravatar_id": "", "url": "https://api.github.com/users/huvunvidia", "html_url": "https://github.com/huvunvidia", "followers_url": "https://api.github.com/users/huvunvidia/followers", "following_url": "https://api.github.com/users/huvunvidia/following{/other_user}", "gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions", "organizations_url": "https://api.github.com/users/huvunvidia/orgs", "repos_url": "https://api.github.com/users/huvunvidia/repos", "events_url": "https://api.github.com/users/huvunvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/huvunvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10640/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10640/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10639
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10639/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10639/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10639/events
https://github.com/NVIDIA/NeMo/pull/10639
2,551,202,342
PR_kwDOC_bI7s581IOZ
10,639
[speechllm] Replace TextProcessing with PromptFormatter
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "Please check the following two new commits:\r\n* New test for `token_to_generate` https://github.com/NVIDIA/NeMo/pull/10639/commits/2b24283b93fcf52a2e461a7b1aa95ef197be665f\r\n* Added padding optimization (which changes the test outcome as seen in diff): https://github.com/NVIDIA/NeMo/pull/10639/commits/1946d71e8691356107709e97a828f50d52750e26\r\n\r\nWe'll leave audio_locator thing for follow up work as discussed offline." ]
2024-09-26T17:49:40
2024-09-27T20:29:11
2024-09-27T20:29:09
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10639", "html_url": "https://github.com/NVIDIA/NeMo/pull/10639", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10639.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10639.patch", "merged_at": "2024-09-27T20:29:09" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "zhehuaichen", "id": 139396994, "node_id": "U_kgDOCE8Hgg", "avatar_url": "https://avatars.githubusercontent.com/u/139396994?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zhehuaichen", "html_url": "https://github.com/zhehuaichen", "followers_url": "https://api.github.com/users/zhehuaichen/followers", "following_url": "https://api.github.com/users/zhehuaichen/following{/other_user}", "gists_url": "https://api.github.com/users/zhehuaichen/gists{/gist_id}", "starred_url": "https://api.github.com/users/zhehuaichen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zhehuaichen/subscriptions", "organizations_url": "https://api.github.com/users/zhehuaichen/orgs", "repos_url": "https://api.github.com/users/zhehuaichen/repos", "events_url": "https://api.github.com/users/zhehuaichen/events{/privacy}", "received_events_url": "https://api.github.com/users/zhehuaichen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10639/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10639/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10638
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10638/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10638/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10638/events
https://github.com/NVIDIA/NeMo/pull/10638
2,551,124,530
PR_kwDOC_bI7s5803AO
10,638
Cherrypick #10466 #10611 #10632 without the ci test
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-26T17:07:24
2024-09-30T17:39:05
2024-09-30T17:39:03
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10638", "html_url": "https://github.com/NVIDIA/NeMo/pull/10638", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10638.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10638.patch", "merged_at": "2024-09-30T17:39:03" }
# What does this PR do ? Cherry pick a few related PRs: #10466 #10611 #10632 **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10638/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10638/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10637
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10637/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10637/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10637/events
https://github.com/NVIDIA/NeMo/pull/10637
2,551,119,399
PR_kwDOC_bI7s580135
10,637
ci: Fix hyperlink for feedback
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-26T17:04:12
2024-09-26T17:04:29
2024-09-26T17:04:27
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10637", "html_url": "https://github.com/NVIDIA/NeMo/pull/10637", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10637.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10637.patch", "merged_at": "2024-09-26T17:04:27" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10637/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10637/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10636
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10636/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10636/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10636/events
https://github.com/NVIDIA/NeMo/pull/10636
2,551,067,609
PR_kwDOC_bI7s580qkM
10,636
Cherry pick `Fix asr warnings (10469)` into `r2.0.0`
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4418253970, "node_id": "LA_kwDOC_bI7s8AAAABB1k0kg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS", "name": "TTS", "color": "49AF28", "default": false, "description": "" }, { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7079591682, "node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio", "name": "audio", "color": "0DAAC3", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-26T16:35:44
2024-09-30T10:43:25
2024-09-30T10:43:23
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10636", "html_url": "https://github.com/NVIDIA/NeMo/pull/10636", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10636.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10636.patch", "merged_at": "2024-09-30T10:43:23" }
[🤖]: Hi @nithinraok 👋,<br><br>we've cherry picked #10469 into `r2.0.0` for you! 🚀<br><br>Please review and approve this cherry pick by your convenience\!
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10636/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10636/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10635
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10635/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10635/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10635/events
https://github.com/NVIDIA/NeMo/pull/10635
2,551,006,463
PR_kwDOC_bI7s580dBS
10,635
ci: Fix mention
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-26T16:05:29
2024-09-26T16:27:01
2024-09-26T16:27:00
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10635", "html_url": "https://github.com/NVIDIA/NeMo/pull/10635", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10635.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10635.patch", "merged_at": "2024-09-26T16:26:59" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10635/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10635/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10634
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10634/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10634/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10634/events
https://github.com/NVIDIA/NeMo/pull/10634
2,550,898,529
PR_kwDOC_bI7s580FIp
10,634
Unit test for existing speechllm dataset with llama2 prompt format
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[]
2024-09-26T15:16:50
2024-09-26T15:22:08
2024-09-26T15:22:06
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10634", "html_url": "https://github.com/NVIDIA/NeMo/pull/10634", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10634.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10634.patch", "merged_at": "2024-09-26T15:22:06" }
# What does this PR do ? To prevent breaking backward compatibility when moving to PromptFormatter API. **Collection**: multimodal # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10634/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10634/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10633
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10633/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10633/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10633/events
https://github.com/NVIDIA/NeMo/pull/10633
2,550,868,465
PR_kwDOC_bI7s58z-e9
10,633
Cherry pick `Fix Clip initializing issue in r2.0.0 (10585)` into `r2.0.0`
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-26T15:03:29
2024-09-30T10:43:12
2024-09-30T10:43:09
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10633", "html_url": "https://github.com/NVIDIA/NeMo/pull/10633", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10633.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10633.patch", "merged_at": "2024-09-30T10:43:09" }
[🤖]: Hi @yaoyu-33 👋,<br><br>we've cherry picked #10585 into `r2.0.0` for you! 🚀<br><br>Please review and approve this cherry pick by your convenience\!
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10633/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10633/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10632
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10632/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10632/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10632/events
https://github.com/NVIDIA/NeMo/pull/10632
2,550,791,568
PR_kwDOC_bI7s58ztkM
10,632
Add CI tests for SFT/PEFT
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "CI issue should be resolved once #10358 is merged", "New tests passed https://github.com/NVIDIA/NeMo/actions/runs/11223752196/", "[🤖]: Hi @cuichenx 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11296908276) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g", "CI passed: https://github.com/NVIDIA/NeMo/actions/runs/11296908276/job/31427200519?pr=10632", "Needed to resolve conflict which had same change in conflicting branches. @akoumpa @pablo-garay had already approved & CI passed. Merging..." ]
2024-09-26T14:36:44
2024-10-11T21:39:36
2024-10-11T21:24:23
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10632", "html_url": "https://github.com/NVIDIA/NeMo/pull/10632", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10632.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10632.patch", "merged_at": "2024-10-11T21:24:23" }
# What does this PR do ? Add GitHub actions tests for SFT/PEFT workloads in NeMo 2 **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10632/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10632/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10631
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10631/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10631/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10631/events
https://github.com/NVIDIA/NeMo/pull/10631
2,550,724,891
PR_kwDOC_bI7s58zeiQ
10,631
Speechllm dataset basic unit test
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[]
2024-09-26T14:13:19
2024-09-26T14:19:23
2024-09-26T14:19:20
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10631", "html_url": "https://github.com/NVIDIA/NeMo/pull/10631", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10631.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10631.patch", "merged_at": "2024-09-26T14:19:20" }
# What does this PR do ? Will help me ensure I don't break anything in follow up PRs. **Collection**: multimodal # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10631/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10631/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10630
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10630/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10630/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10630/events
https://github.com/NVIDIA/NeMo/pull/10630
2,550,639,219
PR_kwDOC_bI7s58zLPO
10,630
Adding "github.run_id" to NeMo_2 run
{ "login": "huvunvidia", "id": 86480512, "node_id": "MDQ6VXNlcjg2NDgwNTEy", "avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4", "gravatar_id": "", "url": "https://api.github.com/users/huvunvidia", "html_url": "https://github.com/huvunvidia", "followers_url": "https://api.github.com/users/huvunvidia/followers", "following_url": "https://api.github.com/users/huvunvidia/following{/other_user}", "gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions", "organizations_url": "https://api.github.com/users/huvunvidia/orgs", "repos_url": "https://api.github.com/users/huvunvidia/repos", "events_url": "https://api.github.com/users/huvunvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/huvunvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-26T13:44:45
2024-11-19T17:11:43
2024-10-18T01:59:03
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10630", "html_url": "https://github.com/NVIDIA/NeMo/pull/10630", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10630.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10630.patch", "merged_at": null }
# What does this PR do ? Adding "github.run_id" to NeMo_2 run, following suggestion by Oliver in PR: https://github.com/NVIDIA/NeMo/pull/10263 **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10630/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10630/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10629
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10629/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10629/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10629/events
https://github.com/NVIDIA/NeMo/pull/10629
2,550,166,960
PR_kwDOC_bI7s58ximm
10,629
ci: Add CICD result feedback
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @ko3n1g 👋,\n\nI just wanted to let you know that, you know, the CICD pipeline for this PR\njust finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-26T10:22:44
2024-09-26T15:25:57
2024-09-26T15:25:54
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10629", "html_url": "https://github.com/NVIDIA/NeMo/pull/10629", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10629.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10629.patch", "merged_at": "2024-09-26T15:25:54" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10629/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10629/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10628
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10628/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10628/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10628/events
https://github.com/NVIDIA/NeMo/pull/10628
2,549,277,421
PR_kwDOC_bI7s58uf3j
10,628
Cherry pick `Fix mb_calculator import in lora tutorial (10624)` into `r2.0.0`
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-26T01:27:42
2024-09-26T01:32:48
2024-09-26T01:32:47
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10628", "html_url": "https://github.com/NVIDIA/NeMo/pull/10628", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10628.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10628.patch", "merged_at": "2024-09-26T01:32:47" }
[🤖]: Hi @BoxiangW 👋,<br><br>we've cherry picked #10624 into `r2.0.0` for you! 🚀<br><br>Please review and approve this cherry pick by your convenience\!
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10628/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10628/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10627
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10627/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10627/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10627/events
https://github.com/NVIDIA/NeMo/pull/10627
2,549,217,966
PR_kwDOC_bI7s58uTEM
10,627
Bump `Dockerfile.ci` (2024-09-26)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-26T00:21:45
2024-10-03T13:33:13
2024-10-03T13:33:13
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10627", "html_url": "https://github.com/NVIDIA/NeMo/pull/10627", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10627.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10627.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10627/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10627/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10626
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10626/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10626/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10626/events
https://github.com/NVIDIA/NeMo/pull/10626
2,549,142,430
PR_kwDOC_bI7s58uCer
10,626
Fix lora tutorial import issue
{ "login": "BoxiangW", "id": 45734921, "node_id": "MDQ6VXNlcjQ1NzM0OTIx", "avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BoxiangW", "html_url": "https://github.com/BoxiangW", "followers_url": "https://api.github.com/users/BoxiangW/followers", "following_url": "https://api.github.com/users/BoxiangW/following{/other_user}", "gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}", "starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions", "organizations_url": "https://api.github.com/users/BoxiangW/orgs", "repos_url": "https://api.github.com/users/BoxiangW/repos", "events_url": "https://api.github.com/users/BoxiangW/events{/privacy}", "received_events_url": "https://api.github.com/users/BoxiangW/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "BoxiangW", "id": 45734921, "node_id": "MDQ6VXNlcjQ1NzM0OTIx", "avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BoxiangW", "html_url": "https://github.com/BoxiangW", "followers_url": "https://api.github.com/users/BoxiangW/followers", "following_url": "https://api.github.com/users/BoxiangW/following{/other_user}", "gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}", "starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions", "organizations_url": "https://api.github.com/users/BoxiangW/orgs", "repos_url": "https://api.github.com/users/BoxiangW/repos", "events_url": "https://api.github.com/users/BoxiangW/events{/privacy}", "received_events_url": "https://api.github.com/users/BoxiangW/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "BoxiangW", "id": 45734921, "node_id": "MDQ6VXNlcjQ1NzM0OTIx", "avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BoxiangW", "html_url": "https://github.com/BoxiangW", "followers_url": "https://api.github.com/users/BoxiangW/followers", "following_url": "https://api.github.com/users/BoxiangW/following{/other_user}", "gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}", "starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions", "organizations_url": "https://api.github.com/users/BoxiangW/orgs", "repos_url": "https://api.github.com/users/BoxiangW/repos", "events_url": "https://api.github.com/users/BoxiangW/events{/privacy}", "received_events_url": "https://api.github.com/users/BoxiangW/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "Closed in favor of the automatic cherry-pick: #10628 " ]
2024-09-25T23:04:37
2024-09-26T01:32:24
2024-09-26T01:32:24
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10626", "html_url": "https://github.com/NVIDIA/NeMo/pull/10626", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10626.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10626.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10626/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10626/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10625
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10625/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10625/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10625/events
https://github.com/NVIDIA/NeMo/pull/10625
2,549,069,674
PR_kwDOC_bI7s58tyeg
10,625
Downgrading the 'datasets' package from 3.0.0 to 2.21.0 in some notebooks of tutorials
{ "login": "weiqingw4ng", "id": 164252040, "node_id": "U_kgDOCcpJiA", "avatar_url": "https://avatars.githubusercontent.com/u/164252040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/weiqingw4ng", "html_url": "https://github.com/weiqingw4ng", "followers_url": "https://api.github.com/users/weiqingw4ng/followers", "following_url": "https://api.github.com/users/weiqingw4ng/following{/other_user}", "gists_url": "https://api.github.com/users/weiqingw4ng/gists{/gist_id}", "starred_url": "https://api.github.com/users/weiqingw4ng/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/weiqingw4ng/subscriptions", "organizations_url": "https://api.github.com/users/weiqingw4ng/orgs", "repos_url": "https://api.github.com/users/weiqingw4ng/repos", "events_url": "https://api.github.com/users/weiqingw4ng/events{/privacy}", "received_events_url": "https://api.github.com/users/weiqingw4ng/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-25T21:59:41
2024-09-26T02:49:00
2024-09-26T02:48:59
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10625", "html_url": "https://github.com/NVIDIA/NeMo/pull/10625", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10625.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10625.patch", "merged_at": "2024-09-26T02:48:59" }
# What does this PR do ? '[datasets](https://pypi.org/project/datasets/#history)' recently released the latest version 3.0.0 on Sep 11th, but some HF datasets (e.g., [MCV 3.0](https://huggingface.co/datasets/mozilla-foundation/common_voice_3_0), [MCV 6.1](https://huggingface.co/datasets/mozilla-foundation/common_voice_6_1)) do not update their code for the latest version. If we try to download these MCV with the latest 'datasets', it will raise an error: _TypeError: DownloadConfig.__init__() got an unexpected keyword argument 'ignore_url_params'._ Hence, we need to downgrade the 'datasets' package to the last version 2.21.0 in some tutorial notebooks. Please check the first block of each notebook. **Collection**: [Note which collection this PR will affect] NeMo/tutorial/asr # Changelog - Add specific line by line info of high level changes in this PR. Updated requirements file # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10625/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10625/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10624
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10624/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10624/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10624/events
https://github.com/NVIDIA/NeMo/pull/10624
2,549,066,607
PR_kwDOC_bI7s58txzx
10,624
Fix mb_calculator import in lora tutorial
{ "login": "BoxiangW", "id": 45734921, "node_id": "MDQ6VXNlcjQ1NzM0OTIx", "avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BoxiangW", "html_url": "https://github.com/BoxiangW", "followers_url": "https://api.github.com/users/BoxiangW/followers", "following_url": "https://api.github.com/users/BoxiangW/following{/other_user}", "gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}", "starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions", "organizations_url": "https://api.github.com/users/BoxiangW/orgs", "repos_url": "https://api.github.com/users/BoxiangW/repos", "events_url": "https://api.github.com/users/BoxiangW/events{/privacy}", "received_events_url": "https://api.github.com/users/BoxiangW/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
{ "login": "BoxiangW", "id": 45734921, "node_id": "MDQ6VXNlcjQ1NzM0OTIx", "avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BoxiangW", "html_url": "https://github.com/BoxiangW", "followers_url": "https://api.github.com/users/BoxiangW/followers", "following_url": "https://api.github.com/users/BoxiangW/following{/other_user}", "gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}", "starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions", "organizations_url": "https://api.github.com/users/BoxiangW/orgs", "repos_url": "https://api.github.com/users/BoxiangW/repos", "events_url": "https://api.github.com/users/BoxiangW/events{/privacy}", "received_events_url": "https://api.github.com/users/BoxiangW/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "BoxiangW", "id": 45734921, "node_id": "MDQ6VXNlcjQ1NzM0OTIx", "avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BoxiangW", "html_url": "https://github.com/BoxiangW", "followers_url": "https://api.github.com/users/BoxiangW/followers", "following_url": "https://api.github.com/users/BoxiangW/following{/other_user}", "gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}", "starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions", "organizations_url": "https://api.github.com/users/BoxiangW/orgs", "repos_url": "https://api.github.com/users/BoxiangW/repos", "events_url": "https://api.github.com/users/BoxiangW/events{/privacy}", "received_events_url": "https://api.github.com/users/BoxiangW/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-09-25T21:56:46
2024-09-26T01:27:14
2024-09-26T01:27:13
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10624", "html_url": "https://github.com/NVIDIA/NeMo/pull/10624", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10624.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10624.patch", "merged_at": "2024-09-26T01:27:13" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10624/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10624/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10623
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10623/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10623/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10623/events
https://github.com/NVIDIA/NeMo/pull/10623
2,548,881,307
PR_kwDOC_bI7s58tI78
10,623
Add inference optimization blog post announcement to README
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-09-25T19:54:25
2024-09-25T20:02:49
2024-09-25T20:02:47
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10623", "html_url": "https://github.com/NVIDIA/NeMo/pull/10623", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10623.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10623.patch", "merged_at": "2024-09-25T20:02:47" }
# What does this PR do ? Add ASR inference optimization blog post announcement to README **Collection**: ASR # Changelog - Add ASR inference optimization blog post announcement to README # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [x] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10623/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10623/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10622
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10622/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10622/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10622/events
https://github.com/NVIDIA/NeMo/pull/10622
2,548,769,259
PR_kwDOC_bI7s58swM1
10,622
Use NCCL bootsrap backend for TP communication overlaps
{ "login": "erhoo82", "id": 15861259, "node_id": "MDQ6VXNlcjE1ODYxMjU5", "avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/erhoo82", "html_url": "https://github.com/erhoo82", "followers_url": "https://api.github.com/users/erhoo82/followers", "following_url": "https://api.github.com/users/erhoo82/following{/other_user}", "gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}", "starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions", "organizations_url": "https://api.github.com/users/erhoo82/orgs", "repos_url": "https://api.github.com/users/erhoo82/repos", "events_url": "https://api.github.com/users/erhoo82/events{/privacy}", "received_events_url": "https://api.github.com/users/erhoo82/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.nlp.models.language_modeling.megatron_base_model\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:103:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:111:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:253:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:271:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:346:0: C0301: Line too long (133/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:606:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:661:0: C0301: Line too long (153/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:833:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:961:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:980:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1097:0: C0301: Line too long (195/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1154:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1203:0: C0301: Line too long (120/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1286:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:330:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:461:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:466:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:699:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:751:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:922:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1026:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1261:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1292:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1296:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_base_model.py:1300:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.collections.nlp.models.language_modeling.megatron_gpt_model\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:327:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:367:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:413:0: C0301: Line too long (126/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:460:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:791:0: C0301: Line too long (131/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1106:0: C0301: Line too long (146/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1127:0: C0301: Line too long (168/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1335:0: C0301: Line too long (122/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1392:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1573:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1574:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1576:0: C0301: Line too long (159/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1747:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1767:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1775:0: C0301: Line too long (155/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1796:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1866:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1893:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:140:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:153:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:179:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:198:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:245:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:283:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:287:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:299:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:307:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:469:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:472:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:701:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:705:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:787:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1104:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1177:12: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1226:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1254:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1405:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1540:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1548:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1557:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1841:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:1994:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2001:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:2007:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:20:0: W0611: Unused fields imported from dataclasses (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:27:0: W0611: Unused OmegaConf imported from omegaconf (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:30:0: W0611: Unused _DataFetcherWrapper imported from pytorch_lightning.loops.fetchers (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:72:0: W0611: Unused activation_to_func imported from nemo.collections.nlp.parts.utils_funcs (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:81:4: W0611: Unused megatron.core imported as core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:82:4: W0611: Unused tensor_parallel imported from megatron.core (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:101:4: W0611: Unused init_method_normal imported from megatron.core.utils (unused-import)\nnemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:101:4: W0611: Unused scaled_init_method_normal imported from megatron.core.utils (unused-import)\n************* Module nemo.collections.nlp.parts.nlp_overrides\nnemo/collections/nlp/parts/nlp_overrides.py:211:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:216:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:232:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:424:0: C0301: Line too long (136/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:510:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:730:0: C0301: Line too long (140/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:735:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1001:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1005:0: C0301: Line too long (141/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1009:0: C0301: Line too long (149/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1066:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1193:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:1771:0: C0301: Line too long (152/119) (line-too-long)\nnemo/collections/nlp/parts/nlp_overrides.py:247:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:380:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:425:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:602:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:618:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:637:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:878:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:997:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:1682:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:1770:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/collections/nlp/parts/nlp_overrides.py:18:0: W0611: Unused import re (unused-import)\nnemo/collections/nlp/parts/nlp_overrides.py:106:4: W0611: Unused tensorstore imported from megatron.core.dist_checkpointing.strategies (unused-import)\n************* Module nemo.lightning._strategy_lib\nnemo/lightning/_strategy_lib.py:563:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/_strategy_lib.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/_strategy_lib.py:36:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:140:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:167:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:203:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:516:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:588:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:601:4: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.lightning.pytorch.callbacks.megatron_comm_overlap\nnemo/lightning/pytorch/callbacks/megatron_comm_overlap.py:81:0: C0301: Line too long (121/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/megatron_comm_overlap.py:245:0: C0301: Line too long (124/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/megatron_comm_overlap.py:212:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/megatron_comm_overlap.py:276:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/megatron_comm_overlap.py:280:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/megatron_comm_overlap.py:284:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/megatron_comm_overlap.py:288:4: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.59/10\n```\n\n---\n\nThank you for improving NeMo's documentation!", "@erhoo82 CI is ready; you can merge this." ]
2024-09-25T19:03:42
2024-11-20T18:32:43
2024-11-20T18:32:43
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10622", "html_url": "https://github.com/NVIDIA/NeMo/pull/10622", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10622.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10622.patch", "merged_at": "2024-11-20T18:32:43" }
# What does this PR do ? Use NCCL bootsrap backend and skip creating mpi process group. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage - The default backend is `nccl`, where no need to create mpi proc group # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10622/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10622/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10621
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10621/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10621/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10621/events
https://github.com/NVIDIA/NeMo/pull/10621
2,548,704,880
PR_kwDOC_bI7s58sioU
10,621
Integrate lm-eval-harness for evaluations in NeMo
{ "login": "athitten", "id": 47577437, "node_id": "MDQ6VXNlcjQ3NTc3NDM3", "avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4", "gravatar_id": "", "url": "https://api.github.com/users/athitten", "html_url": "https://github.com/athitten", "followers_url": "https://api.github.com/users/athitten/followers", "following_url": "https://api.github.com/users/athitten/following{/other_user}", "gists_url": "https://api.github.com/users/athitten/gists{/gist_id}", "starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/athitten/subscriptions", "organizations_url": "https://api.github.com/users/athitten/orgs", "repos_url": "https://api.github.com/users/athitten/repos", "events_url": "https://api.github.com/users/athitten/events{/privacy}", "received_events_url": "https://api.github.com/users/athitten/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "[🤖]: Hi @athitten 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11735874189) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g", "[🤖]: Hi @athitten 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11751799322) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g", "> Can you please check this PR #11233 and make sure the export and deploy updates don't overlap with it?\r\n\r\n@oyilmaz-nvidia there is no overlap between this PR and PR #11233. This PR exposes `output_generation_logits` which is required for evaluation and PR #11233 is exposing logProbs. It should be okay to have both, but we might have some minor conflicts merging the other after one of them is in.", "<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!", "<!-- pylint-output-strict-mode-true -->\n\nbeep boop 🤖: 🚨 The following files must be fixed before merge!\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n\n------------------------------------\nYour code has been rated at 10.00/10\n```\n\n---\n\nThank you for improving NeMo's documentation!", "<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:70:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/llm/api.py:226:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/llm/api.py:538:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.deploy.nlp.query_llm\nnemo/deploy/nlp/query_llm.py:278:0: C0301: Line too long (120/119) (line-too-long)\nnemo/deploy/nlp/query_llm.py:29:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/deploy/nlp/query_llm.py:16:0: W0611: Unused abstractmethod imported from abc (unused-import)\n************* Module nemo.deploy.service.rest_model_api\nnemo/deploy/service/rest_model_api.py:91:0: C0301: Line too long (155/119) (line-too-long)\nnemo/deploy/service/rest_model_api.py:92:0: C0301: Line too long (152/119) (line-too-long)\nnemo/deploy/service/rest_model_api.py:23:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/deploy/service/rest_model_api.py:41:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/service/rest_model_api.py:45:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/service/rest_model_api.py:49:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/service/rest_model_api.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/deploy/service/rest_model_api.py:84:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/service/rest_model_api.py:109:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/service/rest_model_api.py:12:0: W0611: Unused Path imported from pathlib (unused-import)\n************* Module nemo.export.tensorrt_llm\nnemo/export/tensorrt_llm.py:118:0: C0301: Line too long (148/119) (line-too-long)\nnemo/export/tensorrt_llm.py:221:0: C0301: Line too long (123/119) (line-too-long)\nnemo/export/tensorrt_llm.py:223:0: C0301: Line too long (135/119) (line-too-long)\nnemo/export/tensorrt_llm.py:224:0: C0301: Line too long (141/119) (line-too-long)\nnemo/export/tensorrt_llm.py:387:0: C0301: Line too long (186/119) (line-too-long)\nnemo/export/tensorrt_llm.py:998:0: C0301: Line too long (184/119) (line-too-long)\nnemo/export/tensorrt_llm.py:1032:0: C0301: Line too long (131/119) (line-too-long)\nnemo/export/tensorrt_llm.py:1036:0: C0301: Line too long (135/119) (line-too-long)\nnemo/export/tensorrt_llm.py:1094:0: C0301: Line too long (121/119) (line-too-long)\nnemo/export/tensorrt_llm.py:67:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/tensorrt_llm.py:527:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/tensorrt_llm.py:817:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/tensorrt_llm.py:838:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/tensorrt_llm.py:849:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/tensorrt_llm.py:854:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/tensorrt_llm.py:931:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/tensorrt_llm.py:1140:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.trt_llm.tensorrt_llm_build\nnemo/export/trt_llm/tensorrt_llm_build.py:31:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_build.py:19:0: W0611: Unused Builder imported from tensorrt_llm.builder (unused-import)\nnemo/export/trt_llm/tensorrt_llm_build.py:23:0: W0611: Unused add_lora imported from tensorrt_llm.models.modeling_utils (unused-import)\n************* Module nemo.export.trt_llm.tensorrt_llm_run\nnemo/export/trt_llm/tensorrt_llm_run.py:506:0: C0301: Line too long (125/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:510:0: C0301: Line too long (136/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:514:0: C0301: Line too long (123/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:557:0: C0301: Line too long (181/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:841:0: C0301: Line too long (153/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:524:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:533:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:591:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:33:0: W0611: Unused Mapping imported from tensorrt_llm.mapping (unused-import)\n************* Module scripts.deploy.nlp.deploy_triton\nscripts/deploy/nlp/deploy_triton.py:394:0: C0301: Line too long (121/119) (line-too-long)\nscripts/deploy/nlp/deploy_triton.py:30:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/deploy/nlp/deploy_triton.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:259:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:371:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:378:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.65/10\n```\n\n---\n\nThank you for improving NeMo's documentation!", "<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.llm.api\nnemo/collections/llm/api.py:70:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/llm/api.py:226:0: C0301: Line too long (135/119) (line-too-long)\nnemo/collections/llm/api.py:538:0: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.deploy.nlp.query_llm\nnemo/deploy/nlp/query_llm.py:278:0: C0301: Line too long (120/119) (line-too-long)\nnemo/deploy/nlp/query_llm.py:29:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/deploy/nlp/query_llm.py:16:0: W0611: Unused abstractmethod imported from abc (unused-import)\n************* Module nemo.deploy.service.rest_model_api\nnemo/deploy/service/rest_model_api.py:91:0: C0301: Line too long (155/119) (line-too-long)\nnemo/deploy/service/rest_model_api.py:92:0: C0301: Line too long (152/119) (line-too-long)\nnemo/deploy/service/rest_model_api.py:23:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/deploy/service/rest_model_api.py:41:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/service/rest_model_api.py:45:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/service/rest_model_api.py:49:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/service/rest_model_api.py:71:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/deploy/service/rest_model_api.py:84:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/service/rest_model_api.py:109:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/deploy/service/rest_model_api.py:12:0: W0611: Unused Path imported from pathlib (unused-import)\n************* Module nemo.export.tensorrt_llm\nnemo/export/tensorrt_llm.py:118:0: C0301: Line too long (148/119) (line-too-long)\nnemo/export/tensorrt_llm.py:221:0: C0301: Line too long (123/119) (line-too-long)\nnemo/export/tensorrt_llm.py:223:0: C0301: Line too long (135/119) (line-too-long)\nnemo/export/tensorrt_llm.py:224:0: C0301: Line too long (141/119) (line-too-long)\nnemo/export/tensorrt_llm.py:387:0: C0301: Line too long (186/119) (line-too-long)\nnemo/export/tensorrt_llm.py:998:0: C0301: Line too long (184/119) (line-too-long)\nnemo/export/tensorrt_llm.py:1032:0: C0301: Line too long (131/119) (line-too-long)\nnemo/export/tensorrt_llm.py:1036:0: C0301: Line too long (135/119) (line-too-long)\nnemo/export/tensorrt_llm.py:1094:0: C0301: Line too long (121/119) (line-too-long)\nnemo/export/tensorrt_llm.py:67:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/tensorrt_llm.py:527:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/tensorrt_llm.py:817:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/tensorrt_llm.py:838:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/tensorrt_llm.py:849:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/tensorrt_llm.py:854:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/tensorrt_llm.py:931:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/tensorrt_llm.py:1140:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.export.trt_llm.tensorrt_llm_build\nnemo/export/trt_llm/tensorrt_llm_build.py:31:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_build.py:19:0: W0611: Unused Builder imported from tensorrt_llm.builder (unused-import)\nnemo/export/trt_llm/tensorrt_llm_build.py:23:0: W0611: Unused add_lora imported from tensorrt_llm.models.modeling_utils (unused-import)\n************* Module nemo.export.trt_llm.tensorrt_llm_run\nnemo/export/trt_llm/tensorrt_llm_run.py:506:0: C0301: Line too long (125/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:510:0: C0301: Line too long (136/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:514:0: C0301: Line too long (123/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:557:0: C0301: Line too long (181/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:841:0: C0301: Line too long (153/119) (line-too-long)\nnemo/export/trt_llm/tensorrt_llm_run.py:524:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:533:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:591:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/export/trt_llm/tensorrt_llm_run.py:33:0: W0611: Unused Mapping imported from tensorrt_llm.mapping (unused-import)\n************* Module scripts.deploy.nlp.deploy_triton\nscripts/deploy/nlp/deploy_triton.py:394:0: C0301: Line too long (121/119) (line-too-long)\nscripts/deploy/nlp/deploy_triton.py:30:0: C0115: Missing class docstring (missing-class-docstring)\nscripts/deploy/nlp/deploy_triton.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:259:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:371:0: C0116: Missing function or method docstring (missing-function-docstring)\nscripts/deploy/nlp/deploy_triton.py:378:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.65/10\n```\n\n---\n\nThank you for improving NeMo's documentation!", "[🤖]: Hi @athitten 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11851906868) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g" ]
2024-09-25T18:28:31
2024-11-16T20:07:50
2024-11-16T20:07:49
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10621", "html_url": "https://github.com/NVIDIA/NeMo/pull/10621", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10621.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10621.patch", "merged_at": "2024-11-16T20:07:49" }
# What does this PR do ? Integrates [lm-evaluation-harness](https://github.com/EleutherAI/lm-evaluation-harness/tree/main) into NeMo to run evaluations on standard academic benchmarks. Evaluations can be run by first deploying the model on PyTriton server via deploy method followed by running the evaluate method to do the actual evaluation. **Collection**: This is an independent module and does not affect any collection. # Changelog - Refactor `deploy` method in `nemo/collections/llm/api.py` by moving utility funcs to `nemo/collections/llm/evaluation/eval_utils.py`. Deploy method takes care of exporting nemo model to trtllm and deploying it on PyTriton server. - Deploy method also [starts rest service](https://github.com/NVIDIA/NeMo/pull/10621/files#diff-1afe0432f8c676bf15b5ebbc6628d0f1e9757ea6d3eb73a458c905080e77d50bR365-R369) using uvicorn that runs a FastAPI application which exposes OpenAI end point [/v1/completions](https://github.com/NVIDIA/NeMo/pull/10621/files#diff-5a9ea7d8a543abe1c43aba0c89551c8e661bedbdcbbdf7107750a7ea25870166R107). - The FastAPI application is defined in `nemo/deploy/service/rest_model_api.py` which contains the code to interact with the PyTriton Server to perform the actual model inference via `/v1/completions` endpoint. - [Evaluate method](https://github.com/NVIDIA/NeMo/pull/10621/files#diff-1afe0432f8c676bf15b5ebbc6628d0f1e9757ea6d3eb73a458c905080e77d50bR382) is added to `nemo/collections/llm/api.py` to evaluate nemo model deployed on PyTriton server (via trtllm) using lm-evaluation-harness. Evaluate method takes in as input the rest service url "http://rest_service_http_address:rest_service_port/v1" and other evaluation params like eval task, num_fewshot, limit etc., and inference params like temperature, top_p, top_k, max_tokens_to_generate - Evaluate method instantiates [NeMoFWLMEval class](https://github.com/NVIDIA/NeMo/pull/10621/files#diff-1afe0432f8c676bf15b5ebbc6628d0f1e9757ea6d3eb73a458c905080e77d50bR440) defined in `nemo/collections/llm/evaluation/eval_utils.py` that creates a wrapper to interface eval prompts from lm-eval-harness with the model deployed on PyTriton. - [NeMoFWLMEval class ](https://github.com/NVIDIA/NeMo/pull/10621/files#diff-90b33cee942c51b274d1ded51e97e270442254275630ba88614867d5bd6296f4R18) defines two types of tasks: [generate_until](https://github.com/NVIDIA/NeMo/pull/10621/files#diff-90b33cee942c51b274d1ded51e97e270442254275630ba88614867d5bd6296f4R120) (for ex: gsm8k) and [loglikelihood](https://github.com/NVIDIA/NeMo/pull/10621/files#diff-90b33cee942c51b274d1ded51e97e270442254275630ba88614867d5bd6296f4R63) tasks (for ex: mmlu). - The PR also exposes [gather_context_logits, gather_generation_logits](https://github.com/NVIDIA/NeMo/pull/10621/files#diff-73ace52ae1e5be664174e2ce71267c14118d0476fbd42d8be60842c0311b1334R57-R58) flag to build the trtllm engine with logits. Eval code needs the generation logits to compute the logProb of the actual output token or label, hence its enabled (False by default). # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "athitten", "id": 47577437, "node_id": "MDQ6VXNlcjQ3NTc3NDM3", "avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4", "gravatar_id": "", "url": "https://api.github.com/users/athitten", "html_url": "https://github.com/athitten", "followers_url": "https://api.github.com/users/athitten/followers", "following_url": "https://api.github.com/users/athitten/following{/other_user}", "gists_url": "https://api.github.com/users/athitten/gists{/gist_id}", "starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/athitten/subscriptions", "organizations_url": "https://api.github.com/users/athitten/orgs", "repos_url": "https://api.github.com/users/athitten/repos", "events_url": "https://api.github.com/users/athitten/events{/privacy}", "received_events_url": "https://api.github.com/users/athitten/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10621/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10621/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10618
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10618/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10618/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10618/events
https://github.com/NVIDIA/NeMo/pull/10618
2,547,752,897
PR_kwDOC_bI7s58pRKH
10,618
Cherry pick `Extending modelopt spec for TEDotProductAttention (10523)` into `r2.0.0`
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-25T11:41:46
2024-09-26T06:30:54
2024-09-26T06:30:52
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10618", "html_url": "https://github.com/NVIDIA/NeMo/pull/10618", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10618.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10618.patch", "merged_at": "2024-09-26T06:30:52" }
[🤖]: Hi @janekl 👋,<br><br>we've cherry picked #10523 into `r2.0.0` for you! 🚀<br><br>Please review and approve this cherry pick by your convenience\!
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10618/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10618/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10617
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10617/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10617/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10617/events
https://github.com/NVIDIA/NeMo/pull/10617
2,547,750,251
PR_kwDOC_bI7s58pQlH
10,617
Cherry pick `Move update_config_with_dtype_overrides logging to debug (10602)` into `r2.0.0`
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "duplicate of #10609 " ]
2024-09-25T11:40:28
2024-09-25T11:43:50
2024-09-25T11:43:49
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10617", "html_url": "https://github.com/NVIDIA/NeMo/pull/10617", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10617.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10617.patch", "merged_at": null }
[🤖]: Hi @akoumpa 👋,<br><br>we've cherry picked #10602 into `r2.0.0` for you! 🚀<br><br>Please review and approve this cherry pick by your convenience\!
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10617/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10617/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10616
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10616/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10616/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10616/events
https://github.com/NVIDIA/NeMo/pull/10616
2,547,746,800
PR_kwDOC_bI7s58pP06
10,616
ci: Wrap into quotes
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-25T11:38:45
2024-09-25T11:38:56
2024-09-25T11:38:51
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10616", "html_url": "https://github.com/NVIDIA/NeMo/pull/10616", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10616.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10616.patch", "merged_at": "2024-09-25T11:38:51" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10616/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10616/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10615
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10615/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10615/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10615/events
https://github.com/NVIDIA/NeMo/issues/10615
2,547,049,794
I_kwDOC_bI7s6X0OVC
10,615
Punctuation and Capitalization Model not working
{ "login": "ican24", "id": 19214100, "node_id": "MDQ6VXNlcjE5MjE0MTAw", "avatar_url": "https://avatars.githubusercontent.com/u/19214100?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ican24", "html_url": "https://github.com/ican24", "followers_url": "https://api.github.com/users/ican24/followers", "following_url": "https://api.github.com/users/ican24/following{/other_user}", "gists_url": "https://api.github.com/users/ican24/gists{/gist_id}", "starred_url": "https://api.github.com/users/ican24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ican24/subscriptions", "organizations_url": "https://api.github.com/users/ican24/orgs", "repos_url": "https://api.github.com/users/ican24/repos", "events_url": "https://api.github.com/users/ican24/events{/privacy}", "received_events_url": "https://api.github.com/users/ican24/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
{ "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "ekmb", "id": 10428420, "node_id": "MDQ6VXNlcjEwNDI4NDIw", "avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekmb", "html_url": "https://github.com/ekmb", "followers_url": "https://api.github.com/users/ekmb/followers", "following_url": "https://api.github.com/users/ekmb/following{/other_user}", "gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekmb/subscriptions", "organizations_url": "https://api.github.com/users/ekmb/orgs", "repos_url": "https://api.github.com/users/ekmb/repos", "events_url": "https://api.github.com/users/ekmb/events{/privacy}", "received_events_url": "https://api.github.com/users/ekmb/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "I am wasting time on reinstallation ans re-configuration of all software components.\nUnfortunately yet there is no result.\nOnly the error was changed:\n```\n\nTraceback (most recent call last):\n File \"/maroc/nemoasr/pc.py\", line 1, in <module>\n from nemo.collections.nlp.models import PunctuationCapitalizationModel\n File \"/maroc/NeMo/nemo/collections/nlp/__init__.py\", line 15, in <module>\n from nemo.collections.nlp import data, losses, models, modules\n File \"/maroc/NeMo/nemo/collections/nlp/data/__init__.py\", line 16, in <module>\n from nemo.collections.nlp.data.entity_linking.entity_linking_dataset import EntityLinkingDataset\n File \"/maroc/NeMo/nemo/collections/nlp/data/entity_linking/__init__.py\", line 15, in <module>\n from nemo.collections.nlp.data.entity_linking.entity_linking_dataset import EntityLinkingDataset\n File \"/maroc/NeMo/nemo/collections/nlp/data/entity_linking/entity_linking_dataset.py\", line 22, in <module>\n from nemo.core.classes import Dataset\n File \"/maroc/NeMo/nemo/core/__init__.py\", line 16, in <module>\n from nemo.core.classes import *\n File \"/maroc/NeMo/nemo/core/classes/__init__.py\", line 33, in <module>\n from nemo.core.classes.modelPT import ModelPT\n File \"/maroc/NeMo/nemo/core/classes/modelPT.py\", line 29, in <module>\n from megatron.core.optimizer import OptimizerConfig, get_megatron_optimizer\n File \"/home/deep/.local/lib/python3.10/site-packages/megatron/core/optimizer/__init__.py\", line 8, in <module>\n from transformer_engine.pytorch.optimizers import FusedAdam as Adam\n File \"/home/deep/.local/lib/python3.10/site-packages/transformer_engine/__init__.py\", line 10, in <module>\n import transformer_engine.common\n File \"/home/deep/.local/lib/python3.10/site-packages/transformer_engine/common/__init__.py\", line 118, in <module>\n _TE_LIB_CTYPES = _load_library()\n File \"/home/deep/.local/lib/python3.10/site-packages/transformer_engine/common/__init__.py\", line 89, in _load_library\n return ctypes.CDLL(so_path, mode=ctypes.RTLD_GLOBAL)\n File \"/usr/local/lib/python3.10/ctypes/__init__.py\", line 374, in __init__\n self._handle = _dlopen(self._name, mode)\nOSError: /home/deep/.local/lib/python3.10/site-packages/transformer_engine/libtransformer_engine.so: undefined symbol: cudnnBackendExecute\n\n``` ", "I had re-installed all CUDx and pip packages.\nIt is hard to tell all details.\nI can say that It is a horrible difficult and long history.\nHowever, it is working now." ]
2024-09-25T06:25:26
2024-09-29T14:09:08
2024-09-29T14:09:07
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Dear Team, I am trying to test "Punctuation and Capitalization Model" Quick Start Guide from https://docs.nvidia.com/nemo-framework/user-guide/latest/nemotoolkit/nlp/punctuation_and_capitalization.html ``` from nemo.collections.nlp.models import PunctuationCapitalizationModel # to get the list of pre-trained models PunctuationCapitalizationModel.list_available_models() # Download and load the pre-trained BERT-based model model = PunctuationCapitalizationModel.from_pretrained("punctuation_en_bert") # try the model on a few examples model.add_punctuation_capitalization(['how are you', 'great how about you']) ``` Each time I am receiving error ``` ImportError: cannot import name 'MMapIndexedDataset' from 'megatron.core.datasets.indexed_dataset' (/home/deep/.local/lib/python3.10/site-packages/megatron/core/datasets/indexed_dataset.py) ``` My attempts to change megatron-core version ended resultness. The environment configuration shows blow: NVIDIA-SMI 550.54.14 Driver Version: 550.54.14 CUDA Version: 12.4 nvcc -V : nvcc: NVIDIA (R) Cuda compiler driver Copyright (c) 2005-2024 NVIDIA Corporation Built on Tue_Feb_27_16:19:38_PST_2024 Cuda compilation tools, release 12.4, V12.4.99 Build cuda_12.4.r12.4/compiler.33961263_0 cuDNN: 8.9.6 torch 2.4.1 torchvision 0.19.1
{ "login": "ican24", "id": 19214100, "node_id": "MDQ6VXNlcjE5MjE0MTAw", "avatar_url": "https://avatars.githubusercontent.com/u/19214100?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ican24", "html_url": "https://github.com/ican24", "followers_url": "https://api.github.com/users/ican24/followers", "following_url": "https://api.github.com/users/ican24/following{/other_user}", "gists_url": "https://api.github.com/users/ican24/gists{/gist_id}", "starred_url": "https://api.github.com/users/ican24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ican24/subscriptions", "organizations_url": "https://api.github.com/users/ican24/orgs", "repos_url": "https://api.github.com/users/ican24/repos", "events_url": "https://api.github.com/users/ican24/events{/privacy}", "received_events_url": "https://api.github.com/users/ican24/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10615/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10615/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10614
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10614/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10614/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10614/events
https://github.com/NVIDIA/NeMo/pull/10614
2,547,044,038
PR_kwDOC_bI7s58m0yk
10,614
Add pad_seq_to_mult to sample_sequence_batch
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "@akoumpa , Ideally can we also start updating mcore generate, because going forward, nemo will be using mcore generate\r\n", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-25T06:21:38
2024-10-25T01:59:26
2024-10-25T01:59:25
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10614", "html_url": "https://github.com/NVIDIA/NeMo/pull/10614", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10614.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10614.patch", "merged_at": null }
# What does this PR do ? Ensures proper padding during generation; proper= sequence length is dividable by TP/SP. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10614/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10614/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10613
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10613/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10613/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10613/events
https://github.com/NVIDIA/NeMo/pull/10613
2,546,905,549
PR_kwDOC_bI7s58mWT6
10,613
Add lazy init for export
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "@cuichenx it skips the random initialization of weights, since those will be overwritten anyway with the ones from checkpoint. Random initialization can be a a bottleneck/time-consuming if it happens on CPU and have a large model.\r\n", "> @cuichenx it skips the random initialization of weights, since those will be overwritten anyway with the ones from checkpoint. Random initialization can be a a bottleneck/time-consuming if it happens on CPU and have a large model.\r\n\r\nI see, this is the export code. That makes sense" ]
2024-09-25T04:48:32
2024-09-27T13:57:58
2024-09-27T13:57:56
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10613", "html_url": "https://github.com/NVIDIA/NeMo/pull/10613", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10613.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10613.patch", "merged_at": "2024-09-27T13:57:55" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10613/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10613/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10612
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10612/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10612/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10612/events
https://github.com/NVIDIA/NeMo/pull/10612
2,546,891,078
PR_kwDOC_bI7s58mS8M
10,612
[NeMo-UX] Support `load_strictness`
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "> PL does this like [this](https://github.com/Lightning-AI/pytorch-lightning/pull/19404/files#diff-72f5c7707bc8f4033f0e5f644a8b2eda5d333084e91dfeaaa1368dcbdf24df02). So I feel like we should adopt the same design and not add a custom arg to our strategy.\r\n\r\nIf only we can propagate this flag to dist_checkpointing.load then using this flag would be ideal", "> > PL does this like [this](https://github.com/Lightning-AI/pytorch-lightning/pull/19404/files#diff-72f5c7707bc8f4033f0e5f644a8b2eda5d333084e91dfeaaa1368dcbdf24df02). So I feel like we should adopt the same design and not add a custom arg to our strategy.\r\n> \r\n> If only we can propagate this flag to dist_checkpointing.load then using this flag would be ideal\r\n\r\nYeah, an example of how PL does that can be found [here](https://github.com/Lightning-AI/pytorch-lightning/blob/b35f303561e0de06d559c9ec5322ffaa1a9017c0/src/lightning/pytorch/strategies/fsdp.py#L609).", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "> > If only we can propagate this flag to dist_checkpointing.load then using this flag would be ideal\r\n> \r\n> Yeah, an example of how PL does that can be found [here](https://github.com/Lightning-AI/pytorch-lightning/blob/b35f303561e0de06d559c9ec5322ffaa1a9017c0/src/lightning/pytorch/strategies/fsdp.py#L609).\r\n\r\nRevisiting this PR. I don't think this is quite what we want. It looks like PTL's `strict` is just passed to `load_model_state_dict`, which is called after the checkpoint is loaded using `dist_checkpointing.load`, so we're not able to propagate the value of `strict` to `dist_checkpointing.load`", "<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning._strategy_lib\nnemo/lightning/_strategy_lib.py:573:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/_strategy_lib.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/_strategy_lib.py:36:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:139:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:166:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:202:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:515:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:598:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:611:4: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.lightning.io.pl\nnemo/lightning/io/pl.py:82:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/io/pl.py:58:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/pl.py:64:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:303:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:308:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.callbacks.peft\nnemo/lightning/pytorch/callbacks/peft.py:381:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/peft.py:207:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/peft.py:324:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:315:0: C0301: Line too long (159/119) (line-too-long)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:90:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:272:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:305:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:386:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:396:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:402:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:445:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:449:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:481:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:491:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:558:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:577:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:604:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:612:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:620:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:624:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:663:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:684:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:719:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:742:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:751:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:759:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:771:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:801:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:826:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:842:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:60:0: W0611: Unused _ModuleStepFunction imported from nemo.lightning.megatron_parallel (unused-import)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:76:0: W0611: Unused AdapterPath imported from nemo.lightning.resume (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.52/10\n```\n\n---\n\nThank you for improving NeMo's documentation!", "<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.lightning._strategy_lib\nnemo/lightning/_strategy_lib.py:573:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/_strategy_lib.py:35:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/_strategy_lib.py:36:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:139:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:166:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:202:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:515:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:598:0: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/_strategy_lib.py:611:4: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.lightning.io.pl\nnemo/lightning/io/pl.py:82:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/io/pl.py:58:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/io/pl.py:64:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:303:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/io/pl.py:308:4: C0116: Missing function or method docstring (missing-function-docstring)\n************* Module nemo.lightning.pytorch.callbacks.peft\nnemo/lightning/pytorch/callbacks/peft.py:381:0: C0301: Line too long (130/119) (line-too-long)\nnemo/lightning/pytorch/callbacks/peft.py:207:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/callbacks/peft.py:324:0: C0115: Missing class docstring (missing-class-docstring)\n************* Module nemo.lightning.pytorch.strategies.megatron_strategy\nnemo/lightning/pytorch/strategies/megatron_strategy.py:315:0: C0301: Line too long (159/119) (line-too-long)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:90:0: C0115: Missing class docstring (missing-class-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:272:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:305:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:386:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:396:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:402:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:445:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:449:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:481:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:491:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:558:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:577:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:604:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:612:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:620:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:624:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:663:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:684:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:719:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:742:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:751:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:759:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:771:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:801:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:826:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:842:4: C0116: Missing function or method docstring (missing-function-docstring)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:60:0: W0611: Unused _ModuleStepFunction imported from nemo.lightning.megatron_parallel (unused-import)\nnemo/lightning/pytorch/strategies/megatron_strategy.py:76:0: W0611: Unused AdapterPath imported from nemo.lightning.resume (unused-import)\n\n-----------------------------------\nYour code has been rated at 9.52/10\n```\n\n---\n\nThank you for improving NeMo's documentation!", "[🤖]: Hi @ashors1 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/12032526801) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g" ]
2024-09-25T04:42:27
2024-11-26T17:54:28
2024-11-26T17:54:26
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10612", "html_url": "https://github.com/NVIDIA/NeMo/pull/10612", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10612.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10612.patch", "merged_at": "2024-11-26T17:54:26" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: llm # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10612/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10612/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10611
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10611/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10611/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10611/events
https://github.com/NVIDIA/NeMo/pull/10611
2,546,663,187
PR_kwDOC_bI7s58ljYA
10,611
Fix LoRA contiguous tensor
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "These are not related to the PR so let's discuss elsewhere.", "adding CI tests in separate PR: https://github.com/NVIDIA/NeMo/pull/10632" ]
2024-09-25T00:57:32
2024-09-26T14:37:06
2024-09-26T14:33:06
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10611", "html_url": "https://github.com/NVIDIA/NeMo/pull/10611", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10611.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10611.patch", "merged_at": "2024-09-26T14:33:06" }
# What does this PR do ? Fix contiguous tensor issue in LoRA with mbs>1 **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10611/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10611/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10610
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10610/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10610/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10610/events
https://github.com/NVIDIA/NeMo/pull/10610
2,546,634,574
PR_kwDOC_bI7s58ldWj
10,610
Bump `Dockerfile.ci` (2024-09-25)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-25T00:22:09
2024-10-03T13:33:09
2024-10-03T13:33:09
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10610", "html_url": "https://github.com/NVIDIA/NeMo/pull/10610", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10610.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10610.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10610/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10610/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10609
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10609/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10609/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10609/events
https://github.com/NVIDIA/NeMo/pull/10609
2,546,339,548
PR_kwDOC_bI7s58kcQq
10,609
Akoumparouli/cherry pick main 10602
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-24T20:29:55
2024-09-26T08:42:23
2024-09-26T08:42:21
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10609", "html_url": "https://github.com/NVIDIA/NeMo/pull/10609", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10609.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10609.patch", "merged_at": "2024-09-26T08:42:21" }
# What does this PR do ? src https://github.com/NVIDIA/NeMo/pull/10602 **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10609/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10609/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10608
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10608/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10608/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10608/events
https://github.com/NVIDIA/NeMo/pull/10608
2,546,308,656
PR_kwDOC_bI7s58kVuz
10,608
use _get_extra_te_kwargs_meta in fabric (call mcore's _get_extra_te_k…
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "https://github.com/NVIDIA/NeMo/pull/10558 related", "I see repeatedly a timeout for this test: [L2_Megatron_GPT_Pretraining_and_Resume_Training_TP2 / main](https://github.com/NVIDIA/NeMo/actions/runs/11250797032/job/31286669499)", "[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11350185891) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g" ]
2024-09-24T20:17:25
2024-10-16T00:57:05
2024-10-16T00:57:04
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10608", "html_url": "https://github.com/NVIDIA/NeMo/pull/10608", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10608.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10608.patch", "merged_at": "2024-10-16T00:57:04" }
…wargs & overwrite device) # What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10608/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10608/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10607
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10607/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10607/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10607/events
https://github.com/NVIDIA/NeMo/pull/10607
2,546,131,618
PR_kwDOC_bI7s58jvAg
10,607
Mistral-NeMo-12B recipe
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @akoumpa 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11409300540) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g" ]
2024-09-24T18:54:22
2024-10-21T11:20:59
2024-10-21T11:20:58
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10607", "html_url": "https://github.com/NVIDIA/NeMo/pull/10607", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10607.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10607.patch", "merged_at": "2024-10-21T11:20:58" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10607/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10607/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10606
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10606/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10606/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10606/events
https://github.com/NVIDIA/NeMo/pull/10606
2,546,063,615
PR_kwDOC_bI7s58jg5g
10,606
add import gaurd for megatron energon
{ "login": "pstjohn", "id": 2576846, "node_id": "MDQ6VXNlcjI1NzY4NDY=", "avatar_url": "https://avatars.githubusercontent.com/u/2576846?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pstjohn", "html_url": "https://github.com/pstjohn", "followers_url": "https://api.github.com/users/pstjohn/followers", "following_url": "https://api.github.com/users/pstjohn/following{/other_user}", "gists_url": "https://api.github.com/users/pstjohn/gists{/gist_id}", "starred_url": "https://api.github.com/users/pstjohn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pstjohn/subscriptions", "organizations_url": "https://api.github.com/users/pstjohn/orgs", "repos_url": "https://api.github.com/users/pstjohn/repos", "events_url": "https://api.github.com/users/pstjohn/events{/privacy}", "received_events_url": "https://api.github.com/users/pstjohn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "duplicate of #10592 " ]
2024-09-24T18:20:24
2024-09-24T18:42:41
2024-09-24T18:41:39
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10606", "html_url": "https://github.com/NVIDIA/NeMo/pull/10606", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10606.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10606.patch", "merged_at": null }
# What does this PR do ? Adds an import guard for `megatron.energon`. Currently, NeMo doesn't specify `megatron.energon` as a package dependency, so our bionemo builds are failing with this module not being found. Adding this as an explicit dependency to NeMo would be possible, but in the meantime it's likely easier just wrap this in an import guard so that we don't fail on import-time if this package isn't installed. **Collection**: `nemo.multimodal.data`. # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pstjohn", "id": 2576846, "node_id": "MDQ6VXNlcjI1NzY4NDY=", "avatar_url": "https://avatars.githubusercontent.com/u/2576846?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pstjohn", "html_url": "https://github.com/pstjohn", "followers_url": "https://api.github.com/users/pstjohn/followers", "following_url": "https://api.github.com/users/pstjohn/following{/other_user}", "gists_url": "https://api.github.com/users/pstjohn/gists{/gist_id}", "starred_url": "https://api.github.com/users/pstjohn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pstjohn/subscriptions", "organizations_url": "https://api.github.com/users/pstjohn/orgs", "repos_url": "https://api.github.com/users/pstjohn/repos", "events_url": "https://api.github.com/users/pstjohn/events{/privacy}", "received_events_url": "https://api.github.com/users/pstjohn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10606/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10606/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10605
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10605/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10605/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10605/events
https://github.com/NVIDIA/NeMo/pull/10605
2,546,028,443
PR_kwDOC_bI7s58jZBv
10,605
cherry picking 10460
{ "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "@ko3n1g @pablo-garay This MR is the same as [MR10460](https://github.com/NVIDIA/NeMo/pull/10460), and Oliver mentioned it couldn't be automatically cherry-picked into r2.0.0. ", "@ko3n1g @pablo-garay Fixed the naming mismatch of the variable \"log_dir\" to \"dir\". " ]
2024-09-24T18:03:55
2024-09-29T05:48:06
2024-09-29T05:48:05
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10605", "html_url": "https://github.com/NVIDIA/NeMo/pull/10605", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10605.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10605.patch", "merged_at": "2024-09-29T05:48:05" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10605/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10605/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10604
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10604/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10604/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10604/events
https://github.com/NVIDIA/NeMo/pull/10604
2,546,024,127
PR_kwDOC_bI7s58jYGE
10,604
RETRO TEv.1.10 fix
{ "login": "huvunvidia", "id": 86480512, "node_id": "MDQ6VXNlcjg2NDgwNTEy", "avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4", "gravatar_id": "", "url": "https://api.github.com/users/huvunvidia", "html_url": "https://github.com/huvunvidia", "followers_url": "https://api.github.com/users/huvunvidia/followers", "following_url": "https://api.github.com/users/huvunvidia/following{/other_user}", "gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions", "organizations_url": "https://api.github.com/users/huvunvidia/orgs", "repos_url": "https://api.github.com/users/huvunvidia/repos", "events_url": "https://api.github.com/users/huvunvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/huvunvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-24T18:01:22
2024-11-19T17:11:48
2024-10-16T01:59:28
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10604", "html_url": "https://github.com/NVIDIA/NeMo/pull/10604", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10604.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10604.patch", "merged_at": null }
# What does this PR do ? Current implementation of transformer-engine-based mcore RETRO (implemented by @Lawrence McAfee) doesn't support TEv.1.0. Hence if TE>v1.10, we fall back to local implementation of mcore RETRO. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10604/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10604/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10603
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10603/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10603/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10603/events
https://github.com/NVIDIA/NeMo/pull/10603
2,545,950,886
PR_kwDOC_bI7s58jH75
10,603
Cherry pick from main to r2.0.0 (Removing validate after finetuning finished)
{ "login": "huvunvidia", "id": 86480512, "node_id": "MDQ6VXNlcjg2NDgwNTEy", "avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4", "gravatar_id": "", "url": "https://api.github.com/users/huvunvidia", "html_url": "https://github.com/huvunvidia", "followers_url": "https://api.github.com/users/huvunvidia/followers", "following_url": "https://api.github.com/users/huvunvidia/following{/other_user}", "gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions", "organizations_url": "https://api.github.com/users/huvunvidia/orgs", "repos_url": "https://api.github.com/users/huvunvidia/repos", "events_url": "https://api.github.com/users/huvunvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/huvunvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-24T17:19:21
2024-09-24T19:49:38
2024-09-24T19:49:36
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10603", "html_url": "https://github.com/NVIDIA/NeMo/pull/10603", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10603.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10603.patch", "merged_at": "2024-09-24T19:49:36" }
# What does this PR do ? Cherry pick from: https://github.com/NVIDIA/NeMo/pull/10560 (Removing validate after finetuning finished) **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10603/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10603/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10602
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10602/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10602/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10602/events
https://github.com/NVIDIA/NeMo/pull/10602
2,545,910,046
PR_kwDOC_bI7s58i-54
10,602
Move update_config_with_dtype_overrides logging to debug
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-24T16:57:07
2024-09-24T20:28:25
2024-09-24T20:28:23
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10602", "html_url": "https://github.com/NVIDIA/NeMo/pull/10602", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10602.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10602.patch", "merged_at": "2024-09-24T20:28:23" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10602/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10602/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10601
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10601/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10601/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10601/events
https://github.com/NVIDIA/NeMo/pull/10601
2,545,649,830
PR_kwDOC_bI7s58iFv7
10,601
minor change in dataloader
{ "login": "zhehuaichen", "id": 139396994, "node_id": "U_kgDOCE8Hgg", "avatar_url": "https://avatars.githubusercontent.com/u/139396994?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zhehuaichen", "html_url": "https://github.com/zhehuaichen", "followers_url": "https://api.github.com/users/zhehuaichen/followers", "following_url": "https://api.github.com/users/zhehuaichen/following{/other_user}", "gists_url": "https://api.github.com/users/zhehuaichen/gists{/gist_id}", "starred_url": "https://api.github.com/users/zhehuaichen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zhehuaichen/subscriptions", "organizations_url": "https://api.github.com/users/zhehuaichen/orgs", "repos_url": "https://api.github.com/users/zhehuaichen/repos", "events_url": "https://api.github.com/users/zhehuaichen/events{/privacy}", "received_events_url": "https://api.github.com/users/zhehuaichen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[]
2024-09-24T14:56:18
2024-09-24T14:57:04
2024-09-24T14:57:03
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10601", "html_url": "https://github.com/NVIDIA/NeMo/pull/10601", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10601.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10601.patch", "merged_at": "2024-09-24T14:57:03" }
https://github.com/NVIDIA/NeMo/pull/10599#discussion_r1773513974
{ "login": "zhehuaichen", "id": 139396994, "node_id": "U_kgDOCE8Hgg", "avatar_url": "https://avatars.githubusercontent.com/u/139396994?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zhehuaichen", "html_url": "https://github.com/zhehuaichen", "followers_url": "https://api.github.com/users/zhehuaichen/followers", "following_url": "https://api.github.com/users/zhehuaichen/following{/other_user}", "gists_url": "https://api.github.com/users/zhehuaichen/gists{/gist_id}", "starred_url": "https://api.github.com/users/zhehuaichen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zhehuaichen/subscriptions", "organizations_url": "https://api.github.com/users/zhehuaichen/orgs", "repos_url": "https://api.github.com/users/zhehuaichen/repos", "events_url": "https://api.github.com/users/zhehuaichen/events{/privacy}", "received_events_url": "https://api.github.com/users/zhehuaichen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10601/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10601/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10600
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10600/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10600/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10600/events
https://github.com/NVIDIA/NeMo/pull/10600
2,545,602,304
PR_kwDOC_bI7s58h7Mo
10,600
Update Multi_Task_Adapters.ipynb
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-24T14:37:50
2024-11-05T13:45:40
2024-09-24T15:25:40
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10600", "html_url": "https://github.com/NVIDIA/NeMo/pull/10600", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10600.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10600.patch", "merged_at": "2024-09-24T15:25:39" }
# What does this PR do ? Fixes import issue in a tutorial notebook **Collection**: ASR # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10600/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10600/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10599
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10599/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10599/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10599/events
https://github.com/NVIDIA/NeMo/pull/10599
2,545,563,820
PR_kwDOC_bI7s58hyhj
10,599
support megatron_amp_O2 and tp
{ "login": "zhehuaichen", "id": 139396994, "node_id": "U_kgDOCE8Hgg", "avatar_url": "https://avatars.githubusercontent.com/u/139396994?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zhehuaichen", "html_url": "https://github.com/zhehuaichen", "followers_url": "https://api.github.com/users/zhehuaichen/followers", "following_url": "https://api.github.com/users/zhehuaichen/following{/other_user}", "gists_url": "https://api.github.com/users/zhehuaichen/gists{/gist_id}", "starred_url": "https://api.github.com/users/zhehuaichen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zhehuaichen/subscriptions", "organizations_url": "https://api.github.com/users/zhehuaichen/orgs", "repos_url": "https://api.github.com/users/zhehuaichen/repos", "events_url": "https://api.github.com/users/zhehuaichen/events{/privacy}", "received_events_url": "https://api.github.com/users/zhehuaichen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[]
2024-09-24T14:24:46
2024-09-24T14:43:18
2024-09-24T14:27:07
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10599", "html_url": "https://github.com/NVIDIA/NeMo/pull/10599", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10599.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10599.patch", "merged_at": "2024-09-24T14:27:07" }
## Add the support * megatron_amp_O2 on salm-gpt, bestow-gpt, salm-t5. Follow this doc for example recipe https://docs.google.com/document/d/1VKP9j574B_BYwkUHcyZYsQUQDbwMmFEhu5p0uH-ns6o/edit#heading=h.f646we4te4u8 * tp>1 support on salm-gpt, bestow-gpt. Follow this doc for example recipe https://docs.google.com/document/d/1fr2UlqThlzqvqL_lpc_HIyrh0yCzL27A-QX1eCI_ojg/edit#heading=h.sccv9we30nts ## Container /lustre/fsw/portfolios/llmservice/users/zhehuaic/containers/nemo-main-aug24.sqsh or gitlab-master.nvidia.com/zhehuaic/nemo_containers:nemo-main-aug24
{ "login": "zhehuaichen", "id": 139396994, "node_id": "U_kgDOCE8Hgg", "avatar_url": "https://avatars.githubusercontent.com/u/139396994?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zhehuaichen", "html_url": "https://github.com/zhehuaichen", "followers_url": "https://api.github.com/users/zhehuaichen/followers", "following_url": "https://api.github.com/users/zhehuaichen/following{/other_user}", "gists_url": "https://api.github.com/users/zhehuaichen/gists{/gist_id}", "starred_url": "https://api.github.com/users/zhehuaichen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zhehuaichen/subscriptions", "organizations_url": "https://api.github.com/users/zhehuaichen/orgs", "repos_url": "https://api.github.com/users/zhehuaichen/repos", "events_url": "https://api.github.com/users/zhehuaichen/events{/privacy}", "received_events_url": "https://api.github.com/users/zhehuaichen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10599/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10599/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10598
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10598/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10598/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10598/events
https://github.com/NVIDIA/NeMo/pull/10598
2,545,050,732
PR_kwDOC_bI7s58gA2R
10,598
.nemo conversion bug fix
{ "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-24T10:51:21
2024-09-26T16:06:52
2024-09-26T16:06:50
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10598", "html_url": "https://github.com/NVIDIA/NeMo/pull/10598", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10598.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10598.patch", "merged_at": "2024-09-26T16:06:50" }
# What does this PR do ? Minor fix for ckpt conversion to .nemo when cp size > 1. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10598/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10598/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10597
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10597/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10597/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10597/events
https://github.com/NVIDIA/NeMo/pull/10597
2,544,879,845
PR_kwDOC_bI7s58fbF6
10,597
ci: Add missing test specs
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-24T09:36:20
2024-09-24T09:36:38
2024-09-24T09:36:36
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10597", "html_url": "https://github.com/NVIDIA/NeMo/pull/10597", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10597.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10597.patch", "merged_at": "2024-09-24T09:36:36" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10597/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10597/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10596
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10596/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10596/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10596/events
https://github.com/NVIDIA/NeMo/pull/10596
2,544,602,739
PR_kwDOC_bI7s58ed1L
10,596
Akoumparouli/fix get tokenizer list
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "once merged need to cherrypick to 24.09/r2.0.0", "[🤖]: Hi @akoumpa 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11074779355) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @akoumpa 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11075764848) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-24T07:38:54
2024-09-30T17:32:57
2024-09-30T17:32:55
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10596", "html_url": "https://github.com/NVIDIA/NeMo/pull/10596", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10596.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10596.patch", "merged_at": "2024-09-30T17:32:55" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10596/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10596/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10595
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10595/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10595/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10595/events
https://github.com/NVIDIA/NeMo/pull/10595
2,544,367,851
PR_kwDOC_bI7s58dqWz
10,595
ci: Safer sequence escaping
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-24T05:30:08
2024-09-24T05:31:39
2024-09-24T05:31:38
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10595", "html_url": "https://github.com/NVIDIA/NeMo/pull/10595", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10595.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10595.patch", "merged_at": "2024-09-24T05:31:37" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10595/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10595/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10594
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10594/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10594/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10594/events
https://github.com/NVIDIA/NeMo/pull/10594
2,544,361,230
PR_kwDOC_bI7s58do_M
10,594
Cherry pick `Fix pps issue on nemo export (10544)` into `r2.0.0`
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-24T05:27:41
2024-09-26T08:40:50
2024-09-26T08:40:47
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10594", "html_url": "https://github.com/NVIDIA/NeMo/pull/10594", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10594.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10594.patch", "merged_at": "2024-09-26T08:40:47" }
[🤖]: Hi @oyilmaz-nvidia 👋,<br><br>we've cherry picked #10544 into `r2.0.0` for you! 🚀<br><br>Please review and approve this cherry pick by your convenience\!
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10594/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10594/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10593
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10593/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10593/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10593/events
https://github.com/NVIDIA/NeMo/pull/10593
2,543,995,509
PR_kwDOC_bI7s58cY_C
10,593
Bump `Dockerfile.ci` (2024-09-24)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-24T00:22:01
2024-10-03T13:33:06
2024-10-03T13:33:06
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10593", "html_url": "https://github.com/NVIDIA/NeMo/pull/10593", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10593.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10593.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10593/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10593/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10592
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10592/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10592/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10592/events
https://github.com/NVIDIA/NeMo/pull/10592
2,543,836,402
PR_kwDOC_bI7s58b0w5
10,592
Import guard for SimpleMultiModalDataModule
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "lgtm" ]
2024-09-23T22:37:47
2024-09-24T18:27:59
2024-09-24T18:27:58
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10592", "html_url": "https://github.com/NVIDIA/NeMo/pull/10592", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10592.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10592.patch", "merged_at": "2024-09-24T18:27:58" }
# What does this PR do ? Import guard for SimpleMultiModalDataModule (energon) my usecase: if I have an older container and I want to debug something and part of the debugging requires me to use a newer version of NeMo then I want to do that without having to install dependencies of other collections (I'm mainly interested in llm). **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10592/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10592/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10591
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10591/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10591/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10591/events
https://github.com/NVIDIA/NeMo/pull/10591
2,543,778,130
PR_kwDOC_bI7s58bnur
10,591
Cherry pick Fix pps issue on nemo export (#10544)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-09-23T21:56:35
2024-09-24T05:27:36
2024-09-24T05:27:36
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10591", "html_url": "https://github.com/NVIDIA/NeMo/pull/10591", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10591.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10591.patch", "merged_at": null }
* fix minor import bug * fix pps bug * remove config file --------- # What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10591/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10591/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10590
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10590/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10590/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10590/events
https://github.com/NVIDIA/NeMo/pull/10590
2,543,676,637
PR_kwDOC_bI7s58bQIz
10,590
Change dist ckpt defaults
{ "login": "ShriyaPalsamudram", "id": 69161273, "node_id": "MDQ6VXNlcjY5MTYxMjcz", "avatar_url": "https://avatars.githubusercontent.com/u/69161273?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ShriyaPalsamudram", "html_url": "https://github.com/ShriyaPalsamudram", "followers_url": "https://api.github.com/users/ShriyaPalsamudram/followers", "following_url": "https://api.github.com/users/ShriyaPalsamudram/following{/other_user}", "gists_url": "https://api.github.com/users/ShriyaPalsamudram/gists{/gist_id}", "starred_url": "https://api.github.com/users/ShriyaPalsamudram/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ShriyaPalsamudram/subscriptions", "organizations_url": "https://api.github.com/users/ShriyaPalsamudram/orgs", "repos_url": "https://api.github.com/users/ShriyaPalsamudram/repos", "events_url": "https://api.github.com/users/ShriyaPalsamudram/events{/privacy}", "received_events_url": "https://api.github.com/users/ShriyaPalsamudram/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4556669155, "node_id": "LA_kwDOC_bI7s8AAAABD5lA4w", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick", "name": "cherry-pick", "color": "ededed", "default": false, "description": null }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-23T21:15:57
2024-10-18T18:29:20
2024-10-18T18:29:14
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10590", "html_url": "https://github.com/NVIDIA/NeMo/pull/10590", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10590.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10590.patch", "merged_at": null }
Enable async ckpt, ckpt every 15mins and reduce preemption time from 5mins to 1min # What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ShriyaPalsamudram", "id": 69161273, "node_id": "MDQ6VXNlcjY5MTYxMjcz", "avatar_url": "https://avatars.githubusercontent.com/u/69161273?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ShriyaPalsamudram", "html_url": "https://github.com/ShriyaPalsamudram", "followers_url": "https://api.github.com/users/ShriyaPalsamudram/followers", "following_url": "https://api.github.com/users/ShriyaPalsamudram/following{/other_user}", "gists_url": "https://api.github.com/users/ShriyaPalsamudram/gists{/gist_id}", "starred_url": "https://api.github.com/users/ShriyaPalsamudram/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ShriyaPalsamudram/subscriptions", "organizations_url": "https://api.github.com/users/ShriyaPalsamudram/orgs", "repos_url": "https://api.github.com/users/ShriyaPalsamudram/repos", "events_url": "https://api.github.com/users/ShriyaPalsamudram/events{/privacy}", "received_events_url": "https://api.github.com/users/ShriyaPalsamudram/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10590/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10590/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10589
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10589/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10589/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10589/events
https://github.com/NVIDIA/NeMo/pull/10589
2,543,427,185
PR_kwDOC_bI7s58aYbG
10,589
make /home/TestData readonly
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-23T19:04:46
2024-10-31T02:00:01
2024-10-31T02:00:00
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10589", "html_url": "https://github.com/NVIDIA/NeMo/pull/10589", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10589.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10589.patch", "merged_at": null }
# What does this PR do ? TORCHDYNAMO_DISABLE=1 did not fix the timeouts; Converted this to a PR to make /home/TestData readonly. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10589/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10589/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10588
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10588/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10588/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10588/events
https://github.com/NVIDIA/NeMo/pull/10588
2,543,347,666
PR_kwDOC_bI7s58aHGE
10,588
ci: Send direct alert on failed cherry-pick
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-23T18:25:04
2024-09-23T18:28:26
2024-09-23T18:28:25
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10588", "html_url": "https://github.com/NVIDIA/NeMo/pull/10588", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10588.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10588.patch", "merged_at": "2024-09-23T18:28:25" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10588/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10588/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10587
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10587/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10587/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10587/events
https://github.com/NVIDIA/NeMo/pull/10587
2,543,327,946
PR_kwDOC_bI7s58aC0B
10,587
Akoumparouli/nemo ux cherrypick 10363
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-23T18:13:46
2024-10-03T19:54:55
2024-10-03T19:54:53
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10587", "html_url": "https://github.com/NVIDIA/NeMo/pull/10587", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10587.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10587.patch", "merged_at": "2024-10-03T19:54:53" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10587/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10587/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10586
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10586/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10586/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10586/events
https://github.com/NVIDIA/NeMo/pull/10586
2,543,293,662
PR_kwDOC_bI7s58Z7Sw
10,586
Akoumparouli/nemo ux cherrypick fix 10423
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7079591682, "node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio", "name": "audio", "color": "0DAAC3", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-23T17:55:11
2024-09-24T05:48:21
2024-09-24T05:48:20
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10586", "html_url": "https://github.com/NVIDIA/NeMo/pull/10586", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10586.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10586.patch", "merged_at": "2024-09-24T05:48:20" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10586/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10586/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10585
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10585/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10585/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10585/events
https://github.com/NVIDIA/NeMo/pull/10585
2,543,091,899
PR_kwDOC_bI7s58ZOyI
10,585
Fix Clip initializing issue in r2.0.0
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-23T16:07:38
2024-09-26T15:03:03
2024-09-26T15:03:00
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10585", "html_url": "https://github.com/NVIDIA/NeMo/pull/10585", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10585.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10585.patch", "merged_at": "2024-09-26T15:03:00" }
# What does this PR do ? Fix Clip initializing issue in r2.0.0 **Collection**: [multimodal] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10585/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10585/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10584
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10584/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10584/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10584/events
https://github.com/NVIDIA/NeMo/pull/10584
2,543,043,797
PR_kwDOC_bI7s58ZEMh
10,584
Make nemo text processing optional in TTS
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4418253970, "node_id": "LA_kwDOC_bI7s8AAAABB1k0kg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS", "name": "TTS", "color": "49AF28", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days." ]
2024-09-23T15:44:30
2024-10-21T14:37:14
2024-10-21T14:37:10
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10584", "html_url": "https://github.com/NVIDIA/NeMo/pull/10584", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10584.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10584.patch", "merged_at": "2024-10-21T14:37:10" }
# What does this PR do ? Moves common normalizer code into base class. Makes error soft rather than throwing hard ImportError **Collection**: tts # Changelog - NeMo TN no longer throws errors in TTS collection # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10584/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10584/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10583
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10583/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10583/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10583/events
https://github.com/NVIDIA/NeMo/issues/10583
2,543,031,226
I_kwDOC_bI7s6Xk5O6
10,583
Unable to connect to network no Internet connection
{ "login": "Savage0725", "id": 145235656, "node_id": "U_kgDOCKgeyA", "avatar_url": "https://avatars.githubusercontent.com/u/145235656?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Savage0725", "html_url": "https://github.com/Savage0725", "followers_url": "https://api.github.com/users/Savage0725/followers", "following_url": "https://api.github.com/users/Savage0725/following{/other_user}", "gists_url": "https://api.github.com/users/Savage0725/gists{/gist_id}", "starred_url": "https://api.github.com/users/Savage0725/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Savage0725/subscriptions", "organizations_url": "https://api.github.com/users/Savage0725/orgs", "repos_url": "https://api.github.com/users/Savage0725/repos", "events_url": "https://api.github.com/users/Savage0725/events{/privacy}", "received_events_url": "https://api.github.com/users/Savage0725/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[ "Please fill out the template and reopen. Thank you!" ]
2024-09-23T15:38:31
2024-09-25T18:14:39
2024-09-25T18:14:38
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** A clear and concise description of what the bug is. **Steps/Code to reproduce bug** Please list *minimal* steps or code snippet for us to be able to reproduce the bug. A helpful guide on on how to craft a minimal bug report http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports. **Expected behavior** A clear and concise description of what you expected to happen. **Environment overview (please complete the following information)** - Environment location: Docker - Method of install: Please specify exact commands you used to install. - If method of install is [Docker], provide `docker pull` & `docker run` commands used **Additional context** Add any other context about the problem here. Example: GPU model
{ "login": "elliottnv", "id": 159969975, "node_id": "U_kgDOCYjytw", "avatar_url": "https://avatars.githubusercontent.com/u/159969975?v=4", "gravatar_id": "", "url": "https://api.github.com/users/elliottnv", "html_url": "https://github.com/elliottnv", "followers_url": "https://api.github.com/users/elliottnv/followers", "following_url": "https://api.github.com/users/elliottnv/following{/other_user}", "gists_url": "https://api.github.com/users/elliottnv/gists{/gist_id}", "starred_url": "https://api.github.com/users/elliottnv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/elliottnv/subscriptions", "organizations_url": "https://api.github.com/users/elliottnv/orgs", "repos_url": "https://api.github.com/users/elliottnv/repos", "events_url": "https://api.github.com/users/elliottnv/events{/privacy}", "received_events_url": "https://api.github.com/users/elliottnv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10583/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10583/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10582
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10582/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10582/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10582/events
https://github.com/NVIDIA/NeMo/issues/10582
2,542,964,180
I_kwDOC_bI7s6Xko3U
10,582
cosine annealing linear warmup lr=0 on first step
{ "login": "clumsy", "id": 379115, "node_id": "MDQ6VXNlcjM3OTExNQ==", "avatar_url": "https://avatars.githubusercontent.com/u/379115?v=4", "gravatar_id": "", "url": "https://api.github.com/users/clumsy", "html_url": "https://github.com/clumsy", "followers_url": "https://api.github.com/users/clumsy/followers", "following_url": "https://api.github.com/users/clumsy/following{/other_user}", "gists_url": "https://api.github.com/users/clumsy/gists{/gist_id}", "starred_url": "https://api.github.com/users/clumsy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/clumsy/subscriptions", "organizations_url": "https://api.github.com/users/clumsy/orgs", "repos_url": "https://api.github.com/users/clumsy/repos", "events_url": "https://api.github.com/users/clumsy/events{/privacy}", "received_events_url": "https://api.github.com/users/clumsy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[ "I'm not sure we want to modify that lr schedule as it's been used as-is for so long. Can you use your own implementation? NeMo supports users to use their own lr schedules.\n\nhttps://docs.nvidia.com/nemo-framework/user-guide/latest/nemotoolkit/core/core.html?highlight=learning%2520rate#learning-rate-schedulers\n" ]
2024-09-23T15:10:46
2024-09-27T12:57:18
2024-09-27T12:57:18
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** Please see https://github.com/NVIDIA/NeMo/pull/10530 **Steps/Code to reproduce bug** Please see https://github.com/NVIDIA/NeMo/pull/10530 **Expected behavior** LR != 0 on a first step **Environment overview (please complete the following information)** - Environment location: [Bare-metal, Docker, Cloud(specify cloud provider - AWS, Azure, GCP, Collab)]: Any - Method of NeMo install: [pip install or from source]. Please specify exact commands you used to install: Any - If method of install is [Docker], provide `docker pull` & `docker run` commands used: N/A **Environment details** If NVIDIA docker image is used you don't need to specify these. Otherwise, please provide: - OS version: Any - PyTorch version: Any - Python version: Any **Additional context** Add any other context about the problem here. Example: GPU model: Any
{ "login": "clumsy", "id": 379115, "node_id": "MDQ6VXNlcjM3OTExNQ==", "avatar_url": "https://avatars.githubusercontent.com/u/379115?v=4", "gravatar_id": "", "url": "https://api.github.com/users/clumsy", "html_url": "https://github.com/clumsy", "followers_url": "https://api.github.com/users/clumsy/followers", "following_url": "https://api.github.com/users/clumsy/following{/other_user}", "gists_url": "https://api.github.com/users/clumsy/gists{/gist_id}", "starred_url": "https://api.github.com/users/clumsy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/clumsy/subscriptions", "organizations_url": "https://api.github.com/users/clumsy/orgs", "repos_url": "https://api.github.com/users/clumsy/repos", "events_url": "https://api.github.com/users/clumsy/events{/privacy}", "received_events_url": "https://api.github.com/users/clumsy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10582/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10582/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10581
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10581/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10581/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10581/events
https://github.com/NVIDIA/NeMo/pull/10581
2,542,860,081
PR_kwDOC_bI7s58Ybmq
10,581
fix chunked infer
{ "login": "stevehuang52", "id": 105218074, "node_id": "U_kgDOBkWAGg", "avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevehuang52", "html_url": "https://github.com/stevehuang52", "followers_url": "https://api.github.com/users/stevehuang52/followers", "following_url": "https://api.github.com/users/stevehuang52/following{/other_user}", "gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions", "organizations_url": "https://api.github.com/users/stevehuang52/orgs", "repos_url": "https://api.github.com/users/stevehuang52/repos", "events_url": "https://api.github.com/users/stevehuang52/events{/privacy}", "received_events_url": "https://api.github.com/users/stevehuang52/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "[🤖]: Hi @stevehuang52 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/$REPOSITORY/actions/runs/$RUN_ID) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g" ]
2024-09-23T14:33:37
2024-10-08T15:51:29
2024-10-08T15:51:28
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10581", "html_url": "https://github.com/NVIDIA/NeMo/pull/10581", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10581.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10581.patch", "merged_at": "2024-10-08T15:51:28" }
# What does this PR do ? fix chunked infer **Collection**: [asr]
{ "login": "stevehuang52", "id": 105218074, "node_id": "U_kgDOBkWAGg", "avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevehuang52", "html_url": "https://github.com/stevehuang52", "followers_url": "https://api.github.com/users/stevehuang52/followers", "following_url": "https://api.github.com/users/stevehuang52/following{/other_user}", "gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions", "organizations_url": "https://api.github.com/users/stevehuang52/orgs", "repos_url": "https://api.github.com/users/stevehuang52/repos", "events_url": "https://api.github.com/users/stevehuang52/events{/privacy}", "received_events_url": "https://api.github.com/users/stevehuang52/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10581/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10581/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10580
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10580/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10580/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10580/events
https://github.com/NVIDIA/NeMo/issues/10580
2,542,286,409
I_kwDOC_bI7s6XiDZJ
10,580
Unable to export parakeet-ctc-0.6b.nemo to ONNX file
{ "login": "sjpritchard", "id": 1045715, "node_id": "MDQ6VXNlcjEwNDU3MTU=", "avatar_url": "https://avatars.githubusercontent.com/u/1045715?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sjpritchard", "html_url": "https://github.com/sjpritchard", "followers_url": "https://api.github.com/users/sjpritchard/followers", "following_url": "https://api.github.com/users/sjpritchard/following{/other_user}", "gists_url": "https://api.github.com/users/sjpritchard/gists{/gist_id}", "starred_url": "https://api.github.com/users/sjpritchard/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sjpritchard/subscriptions", "organizations_url": "https://api.github.com/users/sjpritchard/orgs", "repos_url": "https://api.github.com/users/sjpritchard/repos", "events_url": "https://api.github.com/users/sjpritchard/events{/privacy}", "received_events_url": "https://api.github.com/users/sjpritchard/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[ "Same error for us:\n\n\n```\nmodel = EncDecCTCModelBPE.restore_from(\"model_lt_ctc.nemo\")\nie = model.input_module.input_example(max_batch=1, max_dim=256)\nmodel.export(output=\"model_lt_ctc_exp.onnx\", input_example=ie, verbose=True)\n```\n\n\nError:\n\n```\nTraceback (most recent call last):\n File \"<stdin>\", line 1, in <module>\n File \"/usr/local/lib/python3.10/dist-packages/nemo/core/classes/exportable.py\", line 117, in export\n out, descr, out_example = model._export(\n File \"/usr/local/lib/python3.10/dist-packages/nemo/core/classes/exportable.py\", line 197, in _export\n output_example = self.forward(*input_list, **input_dict)\n File \"/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/models/asr_model.py\", line 288, in forward_for_export\n encoder_output = enc_fun(audio_signal=audio_signal, length=length)\n File \"/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/modules/conformer_encoder.py\", line 461, in forward_for_export\n rets = self.forward_internal(\n File \"/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/modules/conformer_encoder.py\", line 583, in forward_internal\n audio_signal = layer(\n File \"/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py\", line 1510, in _wrapped_call_impl\n return self._call_impl(*args, **kwargs)\n File \"/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py\", line 1519, in _call_impl\n return forward_call(*args, **kwargs)\n File \"/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/parts/submodules/conformer_modules.py\", line 171, in forward\n x = self.self_attn(query=x, key=x, value=x, mask=att_mask, pos_emb=pos_emb, cache=cache_last_channel)\n File \"/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py\", line 1510, in _wrapped_call_impl\n return self._call_impl(*args, **kwargs)\n File \"/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py\", line 1519, in _call_impl\n return forward_call(*args, **kwargs)\n File \"/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/parts/submodules/multi_head_attention.py\", line 252, in forward\n scores = (matrix_ac + matrix_bd) / self.s_d_k # (batch, head, time1, time2)\nRuntimeError: The size of tensor a (12500) must match the size of tensor b (7500) at non-singleton dimension 3\n```\n", "I found out after I raised the initial issue that this is normal behaviour for models > 2GB. See https://onnxruntime.ai/docs/tutorials/web/large-models.html" ]
2024-09-23T10:58:17
2024-10-16T08:07:24
2024-09-23T11:00:15
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** When exporting the parakeet-ctc-0.6b.nemo to an ONNX file via the export() method, it creates a 2.7MB ONNX file, and dumps the rest of the ONNX files into the same folder, instead of in the ONNX file. **Steps/Code to reproduce bug** `import nemo.collections.asr as nemo_asr asr_model = nemo_asr.models.EncDecCTCModelBPE.from_pretrained(model_name="nvidia/parakeet-ctc-0.6b") asr_model.export("parakeet.onnx") ` **Expected behavior** A single ONNX file ~ 2.3GB **Environment overview (please complete the following information)** - Environment location: Ubuntu 24.04 WSL2 - Method of NeMo install: pip install nemo_toolkit - If method of install is [Docker], provide `docker pull` & `docker run` commands used **Environment details** If NVIDIA docker image is used you don't need to specify these. Otherwise, please provide: - Nemo 1.23.0 and 2.0.0rc1 (neither works) - Ubuntu 24.04 - PyTorch version 2.4.1 - Python version 3.10.12 **Additional context** Add any other context about the problem here. Example: GPU model
{ "login": "sjpritchard", "id": 1045715, "node_id": "MDQ6VXNlcjEwNDU3MTU=", "avatar_url": "https://avatars.githubusercontent.com/u/1045715?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sjpritchard", "html_url": "https://github.com/sjpritchard", "followers_url": "https://api.github.com/users/sjpritchard/followers", "following_url": "https://api.github.com/users/sjpritchard/following{/other_user}", "gists_url": "https://api.github.com/users/sjpritchard/gists{/gist_id}", "starred_url": "https://api.github.com/users/sjpritchard/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sjpritchard/subscriptions", "organizations_url": "https://api.github.com/users/sjpritchard/orgs", "repos_url": "https://api.github.com/users/sjpritchard/repos", "events_url": "https://api.github.com/users/sjpritchard/events{/privacy}", "received_events_url": "https://api.github.com/users/sjpritchard/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10580/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10580/timeline
null
not_planned
false