url
stringlengths
52
53
repository_url
stringclasses
1 value
labels_url
stringlengths
66
67
comments_url
stringlengths
61
62
events_url
stringlengths
59
60
html_url
stringlengths
40
43
id
int64
719M
2.8B
node_id
stringlengths
18
32
number
int64
1.28k
11.9k
title
stringlengths
1
350
user
dict
labels
listlengths
0
10
state
stringclasses
2 values
locked
bool
2 classes
assignee
dict
assignees
listlengths
0
3
milestone
null
comments
sequencelengths
0
30
created_at
timestamp[s]
updated_at
timestamp[s]
closed_at
timestamp[s]
author_association
stringclasses
4 values
sub_issues_summary
dict
active_lock_reason
stringclasses
1 value
draft
bool
2 classes
pull_request
dict
body
stringlengths
0
73.4k
closed_by
dict
reactions
dict
timeline_url
stringlengths
61
62
performed_via_github_app
null
state_reason
stringclasses
3 values
is_pull_request
bool
2 classes
https://api.github.com/repos/NVIDIA/NeMo/issues/10475
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10475/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10475/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10475/events
https://github.com/NVIDIA/NeMo/pull/10475
2,521,079,378
PR_kwDOC_bI7s57O9xh
10,475
[Nemo CICD] Optional test needs optional field set true
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-12T00:49:35
2024-09-12T00:49:45
2024-09-12T00:49:44
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10475", "html_url": "https://github.com/NVIDIA/NeMo/pull/10475", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10475.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10475.patch", "merged_at": "2024-09-12T00:49:44" }
[Nemo CICD] Optional test needs optional field set true
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10475/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10475/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10474
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10474/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10474/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10474/events
https://github.com/NVIDIA/NeMo/pull/10474
2,521,061,280
PR_kwDOC_bI7s57O5zt
10,474
ci: Fix Mcore ref
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
[ { "id": 4556669155, "node_id": "LA_kwDOC_bI7s8AAAABD5lA4w", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick", "name": "cherry-pick", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-12T00:29:06
2024-09-12T01:02:55
2024-09-12T01:02:55
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10474", "html_url": "https://github.com/NVIDIA/NeMo/pull/10474", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10474.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10474.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10474/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10474/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10473
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10473/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10473/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10473/events
https://github.com/NVIDIA/NeMo/pull/10473
2,521,053,936
PR_kwDOC_bI7s57O4MK
10,473
Bump `Dockerfile.ci` (2024-09-12)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-12T00:21:17
2024-09-18T02:19:10
2024-09-18T02:19:10
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10473", "html_url": "https://github.com/NVIDIA/NeMo/pull/10473", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10473.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10473.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10473/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10473/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10472
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10472/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10472/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10472/events
https://github.com/NVIDIA/NeMo/pull/10472
2,521,012,999
PR_kwDOC_bI7s57OvNU
10,472
Adds Llama 3.1 405b configurations
{ "login": "Elnifio", "id": 46603306, "node_id": "MDQ6VXNlcjQ2NjAzMzA2", "avatar_url": "https://avatars.githubusercontent.com/u/46603306?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Elnifio", "html_url": "https://github.com/Elnifio", "followers_url": "https://api.github.com/users/Elnifio/followers", "following_url": "https://api.github.com/users/Elnifio/following{/other_user}", "gists_url": "https://api.github.com/users/Elnifio/gists{/gist_id}", "starred_url": "https://api.github.com/users/Elnifio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Elnifio/subscriptions", "organizations_url": "https://api.github.com/users/Elnifio/orgs", "repos_url": "https://api.github.com/users/Elnifio/repos", "events_url": "https://api.github.com/users/Elnifio/events{/privacy}", "received_events_url": "https://api.github.com/users/Elnifio/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-11T23:44:56
2024-09-19T13:48:10
2024-09-19T13:48:09
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10472", "html_url": "https://github.com/NVIDIA/NeMo/pull/10472", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10472.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10472.patch", "merged_at": "2024-09-19T13:48:09" }
# What does this PR do ? Adds a recipe for Llama 3.1 405B that uses the pre-existing Llama 3.1 405B configurations. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ShriyaPalsamudram", "id": 69161273, "node_id": "MDQ6VXNlcjY5MTYxMjcz", "avatar_url": "https://avatars.githubusercontent.com/u/69161273?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ShriyaPalsamudram", "html_url": "https://github.com/ShriyaPalsamudram", "followers_url": "https://api.github.com/users/ShriyaPalsamudram/followers", "following_url": "https://api.github.com/users/ShriyaPalsamudram/following{/other_user}", "gists_url": "https://api.github.com/users/ShriyaPalsamudram/gists{/gist_id}", "starred_url": "https://api.github.com/users/ShriyaPalsamudram/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ShriyaPalsamudram/subscriptions", "organizations_url": "https://api.github.com/users/ShriyaPalsamudram/orgs", "repos_url": "https://api.github.com/users/ShriyaPalsamudram/repos", "events_url": "https://api.github.com/users/ShriyaPalsamudram/events{/privacy}", "received_events_url": "https://api.github.com/users/ShriyaPalsamudram/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10472/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10472/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10471
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10471/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10471/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10471/events
https://github.com/NVIDIA/NeMo/pull/10471
2,520,954,727
PR_kwDOC_bI7s57OjQX
10,471
[NeMo-UX] Add llm.generate to nemo.collections.llm
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Adding @oyilmaz-nvidia for viz.", "@hemildesai would you please add some code snippet in your MR description to demonstrate how to use generation implemented? I mean how to use it with a container like `nvcr.io/nvidia/nemo:dev` for some basic case like Llama with, say, TP=4 (PP > 1 example would also be great if that is already supported).\r\n\r\nThis is to have some basic example that users can immediately try out - generation is quite a common use-case.", "> @hemildesai would you please add some code snippet in your MR description to demonstrate how to use generation implemented? I mean how to use it with a container like `nvcr.io/nvidia/nemo:dev` for some basic case like Llama with, say, TP=4 (PP > 1 example would also be great if that is already supported).\r\n> \r\n> This is to have some basic example that users can immediately try out - generation is quite a common use-case.\r\n\r\nHi @janekl yes we will be adding an example for using llm.generate to this PR soon", "@janekl I've added an example script in https://github.com/NVIDIA/NeMo/pull/10471/commits/6ad3d9425a1287cdc914e104f9bd93430e605227", "[🤖]: Hi @hemildesai 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11333699450) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g" ]
2024-09-11T23:14:19
2024-10-15T01:17:37
2024-10-15T01:17:36
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10471", "html_url": "https://github.com/NVIDIA/NeMo/pull/10471", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10471.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10471.patch", "merged_at": "2024-10-15T01:17:36" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10471/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10471/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10470
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10470/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10470/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10470/events
https://github.com/NVIDIA/NeMo/pull/10470
2,520,861,761
PR_kwDOC_bI7s57OPKf
10,470
Call reload_model_params only if there's no optimizer state
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-09-11T21:57:59
2024-09-17T03:42:22
2024-09-17T03:42:20
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10470", "html_url": "https://github.com/NVIDIA/NeMo/pull/10470", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10470.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10470.patch", "merged_at": "2024-09-17T03:42:20" }
# What does this PR do ? Checkpoint restoration process (roughly): 1. generate a state dict that contains model's state dict and optimizer's state dict. 2. load the two state dicts from the file checkpoint 3. restore model's state from the state contained in the checkpoint 4. reload optimizer params from the model's state. 5. restore optimizer's state from the state contained in the checkpoint. The bug was in (1) and (4), the optimizer state does not contain cloned tensors but rather references. As a result, when the parameters were reloaded in (4) they were actually overwriting what was restored in (2) (in particular the fp32_from_fp16_params). **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10470/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10470/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10469
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10469/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10469/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10469/events
https://github.com/NVIDIA/NeMo/pull/10469
2,520,805,762
PR_kwDOC_bI7s57OCdb
10,469
Fix asr warnings
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4418253970, "node_id": "LA_kwDOC_bI7s8AAAABB1k0kg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS", "name": "TTS", "color": "49AF28", "default": false, "description": "" }, { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7079591682, "node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio", "name": "audio", "color": "0DAAC3", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "[🤖]: Hi @nithinraok 👋,\r\n\r\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11056453334) for this PR just finished successfully ✨\r\n\r\nSo it might be time to merge this PR or like to get some approvals 🚀\r\n\r\nBut I'm just a 🤖 so I'll leave it you what to do next.\r\n\r\nHave a great day! \r\n\r\n//cc @ko3n1g", "In CI-CD stage for more than a week. Merging as it was failing for LLM issues unrelated to this PR. " ]
2024-09-11T21:26:12
2024-09-26T17:02:01
2024-09-26T16:35:20
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10469", "html_url": "https://github.com/NVIDIA/NeMo/pull/10469", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10469.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10469.patch", "merged_at": "2024-09-26T16:35:20" }
# What does this PR do ? Replaces deprecated cuda.amp.autocast with amp.autocast(**Args) **Collection**: All (majorly ASR, TTS, Audio) # Changelog - replace cuda.amp.autocast with amp.autocast(**Args) # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10469/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10469/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10468
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10468/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10468/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10468/events
https://github.com/NVIDIA/NeMo/pull/10468
2,520,741,232
PR_kwDOC_bI7s57N0P6
10,468
Remove Apex dependency if not using MixedFusedLayerNorm
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-11T20:49:17
2024-09-16T14:33:05
2024-09-16T14:33:03
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10468", "html_url": "https://github.com/NVIDIA/NeMo/pull/10468", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10468.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10468.patch", "merged_at": "2024-09-16T14:33:02" }
# What does this PR do ? Remove Apex dependency if not using MixedFusedLayerNorm **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10468/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10468/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10467
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10467/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10467/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10467/events
https://github.com/NVIDIA/NeMo/pull/10467
2,520,605,906
PR_kwDOC_bI7s57NWxo
10,467
ci: Fix issues with version bump
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-11T19:32:18
2024-09-24T09:16:32
2024-09-24T09:16:31
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10467", "html_url": "https://github.com/NVIDIA/NeMo/pull/10467", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10467.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10467.patch", "merged_at": "2024-09-24T09:16:30" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10467/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10467/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10466
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10466/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10466/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10466/events
https://github.com/NVIDIA/NeMo/pull/10466
2,520,579,502
PR_kwDOC_bI7s57NQ4T
10,466
Update adapter saving logic to be compatible with `save_weights_only`
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-11T19:18:55
2024-09-16T14:33:24
2024-09-16T14:33:22
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10466", "html_url": "https://github.com/NVIDIA/NeMo/pull/10466", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10466.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10466.patch", "merged_at": "2024-09-16T14:33:22" }
# What does this PR do ? #10241 introduced the `save_weights_only` arg, which had an unexpected consequence on PEFT checkpoint saving. Setting `save_weights_only=True` will bypass the `PEFT.on_save_checkpoint` function, since PEFT is a callback. (See [here](https://github.com/Lightning-AI/pytorch-lightning/blob/bc3c9c536dc88bfa9a46f63fbce22b382a86a9cb/src/lightning/pytorch/trainer/connectors/checkpoint_connector.py#L487-L492)) This PR removes `PEFT.on_save_checkpoint` and moves the checkpoint saving logic in `WrappedAdapterIO.save_checkpoint` **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10466/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10466/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10465
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10465/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10465/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10465/events
https://github.com/NVIDIA/NeMo/pull/10465
2,520,510,125
PR_kwDOC_bI7s57NBOE
10,465
ci: Fix Mcore ref
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-11T18:52:59
2024-09-12T00:28:41
2024-09-12T00:28:39
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10465", "html_url": "https://github.com/NVIDIA/NeMo/pull/10465", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10465.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10465.patch", "merged_at": "2024-09-12T00:28:39" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10465/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10465/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10464
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10464/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10464/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10464/events
https://github.com/NVIDIA/NeMo/pull/10464
2,520,464,680
PR_kwDOC_bI7s57M28g
10,464
Fix nemo run entrypoints
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "related https://github.com/NVIDIA/NeMo/pull/10350" ]
2024-09-11T18:36:05
2024-09-12T05:28:34
2024-09-12T05:28:33
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10464", "html_url": "https://github.com/NVIDIA/NeMo/pull/10464", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10464.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10464.patch", "merged_at": "2024-09-12T05:28:33" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10464/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10464/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10463
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10463/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10463/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10463/events
https://github.com/NVIDIA/NeMo/pull/10463
2,520,404,739
PR_kwDOC_bI7s57Mp3R
10,463
Flexible model outputs and callback addition
{ "login": "sichu2023", "id": 152360507, "node_id": "U_kgDOCRTWOw", "avatar_url": "https://avatars.githubusercontent.com/u/152360507?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sichu2023", "html_url": "https://github.com/sichu2023", "followers_url": "https://api.github.com/users/sichu2023/followers", "following_url": "https://api.github.com/users/sichu2023/following{/other_user}", "gists_url": "https://api.github.com/users/sichu2023/gists{/gist_id}", "starred_url": "https://api.github.com/users/sichu2023/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sichu2023/subscriptions", "organizations_url": "https://api.github.com/users/sichu2023/orgs", "repos_url": "https://api.github.com/users/sichu2023/repos", "events_url": "https://api.github.com/users/sichu2023/events{/privacy}", "received_events_url": "https://api.github.com/users/sichu2023/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-11T18:02:40
2024-10-03T01:58:36
2024-10-03T01:58:35
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10463", "html_url": "https://github.com/NVIDIA/NeMo/pull/10463", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10463.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10463.patch", "merged_at": null }
# What does this PR do ? Allow model outputs to be dictionary instead of just tensor. This allows more flexible metric logging through megatron hooks. **Collection**: all # Changelog - update `setup_megatron_parallel` to fix callback addition - update `training_step` and `validation_step` to allow dictionary as model outputs # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". **PR Type**: - [1] New Feature - [1] Bugfix If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10463/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10463/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10462
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10462/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10462/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10462/events
https://github.com/NVIDIA/NeMo/issues/10462
2,520,388,637
I_kwDOC_bI7s6WOhQd
10,462
Add a checkpoint averaging script for the new .distcp checkpoint format
{ "login": "Kipok", "id": 2354422, "node_id": "MDQ6VXNlcjIzNTQ0MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/2354422?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Kipok", "html_url": "https://github.com/Kipok", "followers_url": "https://api.github.com/users/Kipok/followers", "following_url": "https://api.github.com/users/Kipok/following{/other_user}", "gists_url": "https://api.github.com/users/Kipok/gists{/gist_id}", "starred_url": "https://api.github.com/users/Kipok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Kipok/subscriptions", "organizations_url": "https://api.github.com/users/Kipok/orgs", "repos_url": "https://api.github.com/users/Kipok/repos", "events_url": "https://api.github.com/users/Kipok/events{/privacy}", "received_events_url": "https://api.github.com/users/Kipok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale.", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "would be great to address this" ]
2024-09-11T17:53:04
2024-12-23T01:59:47
null
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Is your feature request related to a problem? Please describe.** We found checkpoint averaging to be very helpful, but the current scripts in https://github.com/NVIDIA/NeMo/tree/main/scripts/checkpoint_averaging don't work with the new format. **Describe the solution you'd like** Please provide an example of the averaging script that works.
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10462/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10462/timeline
null
reopened
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10461
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10461/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10461/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10461/events
https://github.com/NVIDIA/NeMo/pull/10461
2,520,240,553
PR_kwDOC_bI7s57MF_U
10,461
add parakeet-tdt_ctc-110m model
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Need to cheery pick to rc2 " ]
2024-09-11T16:47:34
2024-09-11T17:32:35
2024-09-11T17:32:11
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10461", "html_url": "https://github.com/NVIDIA/NeMo/pull/10461", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10461.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10461.patch", "merged_at": "2024-09-11T17:32:11" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10461/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10461/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10460
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10460/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10460/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10460/events
https://github.com/NVIDIA/NeMo/pull/10460
2,520,166,950
PR_kwDOC_bI7s57L2JK
10,460
remove exp dir
{ "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
{ "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "> Thanks a lot! Would be awesome if you could help inform other team colleagues too about this, it can prevent these infra-issues we've had before. Approving now\r\n\r\n@ko3n1g of course, will let them know. Could you please approve this again? I needed to update some parameter naming." ]
2024-09-11T16:11:10
2024-09-23T14:51:45
2024-09-23T14:51:43
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10460", "html_url": "https://github.com/NVIDIA/NeMo/pull/10460", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10460.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10460.patch", "merged_at": "2024-09-23T14:51:43" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10460/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10460/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10459
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10459/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10459/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10459/events
https://github.com/NVIDIA/NeMo/pull/10459
2,520,100,038
PR_kwDOC_bI7s57LnkJ
10,459
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-11T15:41:28
2024-09-11T15:41:52
2024-09-11T15:41:50
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10459", "html_url": "https://github.com/NVIDIA/NeMo/pull/10459", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10459.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10459.patch", "merged_at": "2024-09-11T15:41:50" }
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10459/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10459/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10458
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10458/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10458/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10458/events
https://github.com/NVIDIA/NeMo/pull/10458
2,520,095,490
PR_kwDOC_bI7s57Lmkj
10,458
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-11T15:39:22
2024-09-17T20:23:50
2024-09-17T20:23:50
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10458", "html_url": "https://github.com/NVIDIA/NeMo/pull/10458", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10458.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10458.patch", "merged_at": null }
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10458/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10458/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10457
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10457/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10457/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10457/events
https://github.com/NVIDIA/NeMo/pull/10457
2,518,778,351
PR_kwDOC_bI7s57HCWO
10,457
handle logging case where grad_norm is None
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-11T07:17:10
2024-09-19T01:14:08
2024-09-19T01:14:06
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10457", "html_url": "https://github.com/NVIDIA/NeMo/pull/10457", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10457.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10457.patch", "merged_at": "2024-09-19T01:14:06" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10457/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10457/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10456
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10456/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10456/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10456/events
https://github.com/NVIDIA/NeMo/pull/10456
2,518,422,148
PR_kwDOC_bI7s57FzJt
10,456
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-11T04:19:39
2024-09-11T04:20:29
2024-09-11T04:20:27
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10456", "html_url": "https://github.com/NVIDIA/NeMo/pull/10456", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10456.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10456.patch", "merged_at": "2024-09-11T04:20:26" }
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10456/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10456/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10455
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10455/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10455/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10455/events
https://github.com/NVIDIA/NeMo/pull/10455
2,518,419,554
PR_kwDOC_bI7s57FylX
10,455
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-11T04:16:55
2024-09-11T04:18:57
2024-09-11T04:18:57
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10455", "html_url": "https://github.com/NVIDIA/NeMo/pull/10455", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10455.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10455.patch", "merged_at": null }
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10455/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10455/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10454
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10454/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10454/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10454/events
https://github.com/NVIDIA/NeMo/pull/10454
2,518,201,476
PR_kwDOC_bI7s57FDz-
10,454
Bump `Dockerfile.ci` (2024-09-11)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-11T00:20:49
2024-09-12T01:01:18
2024-09-12T01:01:18
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10454", "html_url": "https://github.com/NVIDIA/NeMo/pull/10454", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10454.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10454.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10454/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10454/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10453
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10453/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10453/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10453/events
https://github.com/NVIDIA/NeMo/pull/10453
2,517,902,470
PR_kwDOC_bI7s57EA0D
10,453
Make nemo_run dependency optional (llm/__init__ )
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-10T21:33:30
2024-09-19T01:14:16
2024-09-19T01:14:15
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10453", "html_url": "https://github.com/NVIDIA/NeMo/pull/10453", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10453.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10453.patch", "merged_at": "2024-09-19T01:14:15" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10453/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10453/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10452
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10452/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10452/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10452/events
https://github.com/NVIDIA/NeMo/pull/10452
2,517,895,429
PR_kwDOC_bI7s57D_KY
10,452
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-10T21:31:27
2024-09-10T21:32:22
2024-09-10T21:32:20
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10452", "html_url": "https://github.com/NVIDIA/NeMo/pull/10452", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10452.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10452.patch", "merged_at": "2024-09-10T21:32:20" }
https://github.com/NVIDIA/NeMo/pull/10450
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10452/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10452/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10451
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10451/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10451/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10451/events
https://github.com/NVIDIA/NeMo/pull/10451
2,517,683,548
PR_kwDOC_bI7s57DOgH
10,451
added energon dataloader for neva training
{ "login": "yashaswikarnati", "id": 144376261, "node_id": "U_kgDOCJsBxQ", "avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yashaswikarnati", "html_url": "https://github.com/yashaswikarnati", "followers_url": "https://api.github.com/users/yashaswikarnati/followers", "following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}", "gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}", "starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions", "organizations_url": "https://api.github.com/users/yashaswikarnati/orgs", "repos_url": "https://api.github.com/users/yashaswikarnati/repos", "events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}", "received_events_url": "https://api.github.com/users/yashaswikarnati/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "yashaswikarnati", "id": 144376261, "node_id": "U_kgDOCJsBxQ", "avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yashaswikarnati", "html_url": "https://github.com/yashaswikarnati", "followers_url": "https://api.github.com/users/yashaswikarnati/followers", "following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}", "gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}", "starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions", "organizations_url": "https://api.github.com/users/yashaswikarnati/orgs", "repos_url": "https://api.github.com/users/yashaswikarnati/repos", "events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}", "received_events_url": "https://api.github.com/users/yashaswikarnati/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "yashaswikarnati", "id": 144376261, "node_id": "U_kgDOCJsBxQ", "avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yashaswikarnati", "html_url": "https://github.com/yashaswikarnati", "followers_url": "https://api.github.com/users/yashaswikarnati/followers", "following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}", "gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}", "starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions", "organizations_url": "https://api.github.com/users/yashaswikarnati/orgs", "repos_url": "https://api.github.com/users/yashaswikarnati/repos", "events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}", "received_events_url": "https://api.github.com/users/yashaswikarnati/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-09-10T20:19:54
2024-09-19T17:22:20
2024-09-19T17:22:17
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10451", "html_url": "https://github.com/NVIDIA/NeMo/pull/10451", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10451.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10451.patch", "merged_at": "2024-09-19T17:22:17" }
# What does this PR do ? added megatron-energon based datamodule for neva training **Collection**: [Note which collection this PR will affect] Multimodal # Changelog - Energon based ```python from nemo.collections.multimodal.data.energon import ( ImageToken, MultiModalSampleConfig, SimpleMultiModalDataModule, ) processor = AutoProcessor.from_pretrained("llava-hf/llava-1.5-7b-hf") tokenizer = processor.tokenizer image_processor = processor.image_processor config = MultiModalSampleConfig( image_token=ImageToken(token_str="<image>", token_id=-200), ignore_place_holder=-100 ) data_module = SimpleMultiModalDataModule( path=dataset_path, tokenizer=tokenizer, image_processor=image_processor, num_workers=0, micro_batch_size=1, multimodal_sample_config=config, ) ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [x] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "yashaswikarnati", "id": 144376261, "node_id": "U_kgDOCJsBxQ", "avatar_url": "https://avatars.githubusercontent.com/u/144376261?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yashaswikarnati", "html_url": "https://github.com/yashaswikarnati", "followers_url": "https://api.github.com/users/yashaswikarnati/followers", "following_url": "https://api.github.com/users/yashaswikarnati/following{/other_user}", "gists_url": "https://api.github.com/users/yashaswikarnati/gists{/gist_id}", "starred_url": "https://api.github.com/users/yashaswikarnati/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yashaswikarnati/subscriptions", "organizations_url": "https://api.github.com/users/yashaswikarnati/orgs", "repos_url": "https://api.github.com/users/yashaswikarnati/repos", "events_url": "https://api.github.com/users/yashaswikarnati/events{/privacy}", "received_events_url": "https://api.github.com/users/yashaswikarnati/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10451/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10451/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10450
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10450/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10450/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10450/events
https://github.com/NVIDIA/NeMo/pull/10450
2,517,601,565
PR_kwDOC_bI7s57C7wc
10,450
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-10T19:53:34
2024-09-10T19:53:47
2024-09-10T19:53:41
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10450", "html_url": "https://github.com/NVIDIA/NeMo/pull/10450", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10450.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10450.patch", "merged_at": "2024-09-10T19:53:41" }
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10450/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10450/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10449
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10449/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10449/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10449/events
https://github.com/NVIDIA/NeMo/pull/10449
2,517,534,178
PR_kwDOC_bI7s57CsOV
10,449
Add support for lazy imports
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-10T19:32:12
2024-10-03T01:58:38
2024-10-03T01:58:37
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10449", "html_url": "https://github.com/NVIDIA/NeMo/pull/10449", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10449.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10449.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10449/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10449/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10448
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10448/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10448/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10448/events
https://github.com/NVIDIA/NeMo/pull/10448
2,517,439,230
PR_kwDOC_bI7s57CXOS
10,448
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-10T19:03:45
2024-09-10T19:03:58
2024-09-10T19:03:55
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10448", "html_url": "https://github.com/NVIDIA/NeMo/pull/10448", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10448.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10448.patch", "merged_at": "2024-09-10T19:03:55" }
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10448/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10448/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10447
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10447/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10447/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10447/events
https://github.com/NVIDIA/NeMo/pull/10447
2,517,312,452
PR_kwDOC_bI7s57B6az
10,447
move mamba installation
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Thanks @ko3n1g , I've reverted the git clone changes for megatron." ]
2024-09-10T18:30:49
2024-09-19T01:14:25
2024-09-19T01:14:24
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10447", "html_url": "https://github.com/NVIDIA/NeMo/pull/10447", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10447.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10447.patch", "merged_at": "2024-09-19T01:14:24" }
# What does this PR do ? Should save 20-30mins in CI docker image builds. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10447/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10447/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10446
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10446/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10446/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10446/events
https://github.com/NVIDIA/NeMo/pull/10446
2,516,999,494
PR_kwDOC_bI7s57AzRo
10,446
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-10T16:58:24
2024-09-10T17:22:11
2024-09-10T17:22:09
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10446", "html_url": "https://github.com/NVIDIA/NeMo/pull/10446", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10446.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10446.patch", "merged_at": "2024-09-10T17:22:09" }
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10446/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10446/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10445
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10445/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10445/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10445/events
https://github.com/NVIDIA/NeMo/pull/10445
2,516,950,700
PR_kwDOC_bI7s57Aoob
10,445
Packed Sequence [NeMo 2]
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "[🤖]: Hi @cuichenx 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/$REPOSITORY/actions/runs/$RUN_ID) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-09-10T16:39:16
2024-10-04T19:16:28
2024-10-04T19:16:26
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10445", "html_url": "https://github.com/NVIDIA/NeMo/pull/10445", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10445.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10445.patch", "merged_at": "2024-10-04T19:16:26" }
# What does this PR do ? Enable sequence packing in SFT/PEFT training in NeMo 2. Compared to NeMo 1, sequence packing now supports - Online packing -- No need to run the data preparation script off line. Simply specify packed sequence size and the packed sequence will be prepared in the training run. - mbs > 1 -- NeMo 2 will automatically convert data to mbs=1 by concatenating the input sequences. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10445/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10445/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10444
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10444/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10444/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10444/events
https://github.com/NVIDIA/NeMo/pull/10444
2,516,754,686
PR_kwDOC_bI7s56_9zh
10,444
Update doc for fp8 trt-llm export
{ "login": "Laplasjan107", "id": 67481570, "node_id": "MDQ6VXNlcjY3NDgxNTcw", "avatar_url": "https://avatars.githubusercontent.com/u/67481570?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Laplasjan107", "html_url": "https://github.com/Laplasjan107", "followers_url": "https://api.github.com/users/Laplasjan107/followers", "following_url": "https://api.github.com/users/Laplasjan107/following{/other_user}", "gists_url": "https://api.github.com/users/Laplasjan107/gists{/gist_id}", "starred_url": "https://api.github.com/users/Laplasjan107/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Laplasjan107/subscriptions", "organizations_url": "https://api.github.com/users/Laplasjan107/orgs", "repos_url": "https://api.github.com/users/Laplasjan107/repos", "events_url": "https://api.github.com/users/Laplasjan107/events{/privacy}", "received_events_url": "https://api.github.com/users/Laplasjan107/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
{ "login": "janekl", "id": 5582967, "node_id": "MDQ6VXNlcjU1ODI5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janekl", "html_url": "https://github.com/janekl", "followers_url": "https://api.github.com/users/janekl/followers", "following_url": "https://api.github.com/users/janekl/following{/other_user}", "gists_url": "https://api.github.com/users/janekl/gists{/gist_id}", "starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janekl/subscriptions", "organizations_url": "https://api.github.com/users/janekl/orgs", "repos_url": "https://api.github.com/users/janekl/repos", "events_url": "https://api.github.com/users/janekl/events{/privacy}", "received_events_url": "https://api.github.com/users/janekl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "janekl", "id": 5582967, "node_id": "MDQ6VXNlcjU1ODI5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janekl", "html_url": "https://github.com/janekl", "followers_url": "https://api.github.com/users/janekl/followers", "following_url": "https://api.github.com/users/janekl/following{/other_user}", "gists_url": "https://api.github.com/users/janekl/gists{/gist_id}", "starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janekl/subscriptions", "organizations_url": "https://api.github.com/users/janekl/orgs", "repos_url": "https://api.github.com/users/janekl/repos", "events_url": "https://api.github.com/users/janekl/events{/privacy}", "received_events_url": "https://api.github.com/users/janekl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, { "login": "oyilmaz-nvidia", "id": 35306097, "node_id": "MDQ6VXNlcjM1MzA2MDk3", "avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oyilmaz-nvidia", "html_url": "https://github.com/oyilmaz-nvidia", "followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers", "following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}", "gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions", "organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs", "repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos", "events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-09-10T15:14:30
2024-09-17T10:24:03
2024-09-17T10:24:03
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10444", "html_url": "https://github.com/NVIDIA/NeMo/pull/10444", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10444.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10444.patch", "merged_at": "2024-09-17T10:24:03" }
# What does this PR do ? Update documentation for fp8 trt-llm export **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [X] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "janekl", "id": 5582967, "node_id": "MDQ6VXNlcjU1ODI5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janekl", "html_url": "https://github.com/janekl", "followers_url": "https://api.github.com/users/janekl/followers", "following_url": "https://api.github.com/users/janekl/following{/other_user}", "gists_url": "https://api.github.com/users/janekl/gists{/gist_id}", "starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janekl/subscriptions", "organizations_url": "https://api.github.com/users/janekl/orgs", "repos_url": "https://api.github.com/users/janekl/repos", "events_url": "https://api.github.com/users/janekl/events{/privacy}", "received_events_url": "https://api.github.com/users/janekl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10444/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10444/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10443
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10443/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10443/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10443/events
https://github.com/NVIDIA/NeMo/pull/10443
2,516,218,313
PR_kwDOC_bI7s56-JE9
10,443
Reflect CLI change nemorun -> nemo
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "@marcromeyn said to merge this" ]
2024-09-10T11:49:03
2024-10-22T15:58:24
2024-10-22T15:58:22
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10443", "html_url": "https://github.com/NVIDIA/NeMo/pull/10443", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10443.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10443.patch", "merged_at": "2024-10-22T15:58:22" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10443/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10443/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10442
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10442/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10442/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10442/events
https://github.com/NVIDIA/NeMo/pull/10442
2,515,358,354
PR_kwDOC_bI7s567QAf
10,442
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-10T04:16:04
2024-09-10T04:16:15
2024-09-10T04:16:14
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10442", "html_url": "https://github.com/NVIDIA/NeMo/pull/10442", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10442.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10442.patch", "merged_at": "2024-09-10T04:16:14" }
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10442/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10442/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10441
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10441/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10441/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10441/events
https://github.com/NVIDIA/NeMo/pull/10441
2,515,340,717
PR_kwDOC_bI7s567MSA
10,441
Akoumparouli/nemo ux update param name
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-09-10T03:57:27
2024-09-16T16:42:16
2024-09-16T16:42:15
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10441", "html_url": "https://github.com/NVIDIA/NeMo/pull/10441", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10441.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10441.patch", "merged_at": "2024-09-16T16:42:15" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10441/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10441/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10440
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10440/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10440/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10440/events
https://github.com/NVIDIA/NeMo/pull/10440
2,515,180,662
PR_kwDOC_bI7s566qaD
10,440
Neva / Energon cherry pick from main
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-10T00:53:36
2024-09-16T23:13:58
2024-09-16T23:13:56
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10440", "html_url": "https://github.com/NVIDIA/NeMo/pull/10440", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10440.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10440.patch", "merged_at": "2024-09-16T23:13:56" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10440/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10440/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10439
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10439/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10439/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10439/events
https://github.com/NVIDIA/NeMo/pull/10439
2,515,153,490
PR_kwDOC_bI7s566ksE
10,439
Bump `Dockerfile.ci` (2024-09-10)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-10T00:21:34
2024-09-12T01:01:15
2024-09-12T01:01:15
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10439", "html_url": "https://github.com/NVIDIA/NeMo/pull/10439", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10439.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10439.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10439/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10439/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10438
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10438/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10438/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10438/events
https://github.com/NVIDIA/NeMo/pull/10438
2,515,102,271
PR_kwDOC_bI7s566Z8f
10,438
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-09T23:29:51
2024-09-09T23:30:13
2024-09-09T23:30:12
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10438", "html_url": "https://github.com/NVIDIA/NeMo/pull/10438", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10438.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10438.patch", "merged_at": "2024-09-09T23:30:12" }
[Nemo CICD] Make flaky test optional
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10438/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10438/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10437
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10437/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10437/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10437/events
https://github.com/NVIDIA/NeMo/pull/10437
2,514,660,851
PR_kwDOC_bI7s56460d
10,437
MCORE interface for TP-only FP8 AMAX reduction
{ "login": "erhoo82", "id": 15861259, "node_id": "MDQ6VXNlcjE1ODYxMjU5", "avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/erhoo82", "html_url": "https://github.com/erhoo82", "followers_url": "https://api.github.com/users/erhoo82/followers", "following_url": "https://api.github.com/users/erhoo82/following{/other_user}", "gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}", "starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions", "organizations_url": "https://api.github.com/users/erhoo82/orgs", "repos_url": "https://api.github.com/users/erhoo82/repos", "events_url": "https://api.github.com/users/erhoo82/events{/privacy}", "received_events_url": "https://api.github.com/users/erhoo82/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Talked with @erhoo82 offline [8307fcda5fff57ab0e77131b09bf37da997ec1f2](https://github.com/NVIDIA/NeMo/pull/10423/files) is sufficient for this PR." ]
2024-09-09T18:41:29
2024-09-23T17:43:26
2024-09-11T21:32:50
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10437", "html_url": "https://github.com/NVIDIA/NeMo/pull/10437", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10437.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10437.patch", "merged_at": "2024-09-11T21:32:50" }
# What does this PR do ? Performance FP8 AMAX reduction in TP (+CP) domain only compared to the default domain of TP+DP (+CP). TP-only FP8 reduction would only work with training from scratch at the moment. # Changelog - Add `model.tp_only_amax_red` to TransformerConfig interface # Usage - Set `model.tp_only_amax_red=True` to reduce FP8 AMAX only in TP (+CP) domain # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10437/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10437/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10436
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10436/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10436/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10436/events
https://github.com/NVIDIA/NeMo/pull/10436
2,514,575,481
PR_kwDOC_bI7s564ogX
10,436
CICD: Attempt fix for False positive (not all tests have run)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-09T17:58:17
2024-09-09T17:58:47
2024-09-09T17:58:46
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10436", "html_url": "https://github.com/NVIDIA/NeMo/pull/10436", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10436.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10436.patch", "merged_at": "2024-09-09T17:58:46" }
CICD: Attempt fix for False positive (not all tests have run)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10436/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10436/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10435
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10435/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10435/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10435/events
https://github.com/NVIDIA/NeMo/pull/10435
2,514,566,882
PR_kwDOC_bI7s564myk
10,435
set mock in GPTDatasetConfig
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-09-09T17:54:14
2024-09-19T16:25:25
2024-09-19T16:25:23
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10435", "html_url": "https://github.com/NVIDIA/NeMo/pull/10435", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10435.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10435.patch", "merged_at": "2024-09-19T16:25:23" }
# What does this PR do ? Previously, the `GPTDatasetConfig.mock` attribute was not set correctly, as a result, training scripts were passing a `MockGPTDataset` class to MCore, but the `.mock` was still set to default value (`False`), thus instead of `MockGPTDataset` it was instantiating a `GPTDataset`. The fix is to set the `.mock` to have the correct value. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10435/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10435/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10434
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10434/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10434/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10434/events
https://github.com/NVIDIA/NeMo/pull/10434
2,514,468,872
PR_kwDOC_bI7s564RoT
10,434
Cherry-pick 10427 into r2.0.0
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-09T17:04:55
2024-09-24T10:18:55
2024-09-24T10:18:53
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10434", "html_url": "https://github.com/NVIDIA/NeMo/pull/10434", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10434.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10434.patch", "merged_at": "2024-09-24T10:18:53" }
null
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10434/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10434/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10433
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10433/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10433/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10433/events
https://github.com/NVIDIA/NeMo/pull/10433
2,514,407,500
PR_kwDOC_bI7s564ECd
10,433
Bump Mcore commit to 90cd925ed0842afd709b4bf63c56ee889f03323e
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Hey @akoumpa , it’s not necessary to do this manually, we have a nightly job that attempt this bump too. If it failed, it means that NeMo isn’t compatible to Mcore ToT and someone needs to look into it", "https://github.com/NVIDIA/NeMo/pull/10423", "@ko3n1g thanks I was not aware; I'll close this in favor of 10423 and look into fixing any issues remaining." ]
2024-09-09T16:32:58
2024-09-09T16:40:53
2024-09-09T16:40:53
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10433", "html_url": "https://github.com/NVIDIA/NeMo/pull/10433", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10433.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10433.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10433/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10433/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10432
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10432/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10432/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10432/events
https://github.com/NVIDIA/NeMo/pull/10432
2,514,389,350
PR_kwDOC_bI7s563__8
10,432
[nemo-ux] Added nemotron recipes and tests
{ "login": "ahmadki", "id": 8809320, "node_id": "MDQ6VXNlcjg4MDkzMjA=", "avatar_url": "https://avatars.githubusercontent.com/u/8809320?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ahmadki", "html_url": "https://github.com/ahmadki", "followers_url": "https://api.github.com/users/ahmadki/followers", "following_url": "https://api.github.com/users/ahmadki/following{/other_user}", "gists_url": "https://api.github.com/users/ahmadki/gists{/gist_id}", "starred_url": "https://api.github.com/users/ahmadki/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ahmadki/subscriptions", "organizations_url": "https://api.github.com/users/ahmadki/orgs", "repos_url": "https://api.github.com/users/ahmadki/repos", "events_url": "https://api.github.com/users/ahmadki/events{/privacy}", "received_events_url": "https://api.github.com/users/ahmadki/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Added long context recipes for 15B and 22B models." ]
2024-09-09T16:23:08
2024-09-19T16:15:42
2024-09-19T16:15:40
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10432", "html_url": "https://github.com/NVIDIA/NeMo/pull/10432", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10432.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10432.patch", "merged_at": "2024-09-19T16:15:40" }
# What does this PR do ? Adds example recipes and tests for nemotron **Collection**: LLM # Changelog - Added recipes for nemotron 3_4b, 3_8b, 4_15b, 5_22b, 4_340b - Updated `distributed_fused_adam_with_cosine_annealing` function in the recipes to support different precessions and expose lr parameters # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ x] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10432/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10432/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10431
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10431/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10431/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10431/events
https://github.com/NVIDIA/NeMo/issues/10431
2,514,080,331
I_kwDOC_bI7s6V2dJL
10,431
Cosine Similarity to Probability
{ "login": "gor2000", "id": 89537093, "node_id": "MDQ6VXNlcjg5NTM3MDkz", "avatar_url": "https://avatars.githubusercontent.com/u/89537093?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gor2000", "html_url": "https://github.com/gor2000", "followers_url": "https://api.github.com/users/gor2000/followers", "following_url": "https://api.github.com/users/gor2000/following{/other_user}", "gists_url": "https://api.github.com/users/gor2000/gists{/gist_id}", "starred_url": "https://api.github.com/users/gor2000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gor2000/subscriptions", "organizations_url": "https://api.github.com/users/gor2000/orgs", "repos_url": "https://api.github.com/users/gor2000/repos", "events_url": "https://api.github.com/users/gor2000/events{/privacy}", "received_events_url": "https://api.github.com/users/gor2000/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[ "Depends on optimal similarity for the model. \n\nYou could first convert all similarity scores to postive value and within range of [0,1] by (1+cs)/2 and observe the values for a know trial set. \n\nBased on my analysis for titanet, optimal value for same speaker was found to be 0.7 (which you could consider as 50% case). However its not a 1:1 matching. " ]
2024-09-09T14:07:24
2024-09-22T21:30:20
2024-09-22T21:29:51
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hi I'm trying to understand in this model how should I convert in some way the cosine Similarity to a probability. I'm working for my company in a project where we need to detect if 2 audios have the same speaker or not. Basically, trying to detect if an audio has been cloned or it's original. The client has required the output of the application that detects audios to be a percentage. That is, 100% should be max similarity and 0% it's not the same speaker at all. My question is: Is it possible to do that?. Does it make sense? Because what I understant is that cosine similarity = 0 does not mean 50% right? I would really appreciate any help here as I have not found anything on the internet. Thank you in advance!!
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10431/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10431/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10429
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10429/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10429/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10429/events
https://github.com/NVIDIA/NeMo/pull/10429
2,513,702,845
PR_kwDOC_bI7s561oda
10,429
Add missing import guards for causal_conv1d and mamba_ssm dependencies
{ "login": "janekl", "id": 5582967, "node_id": "MDQ6VXNlcjU1ODI5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janekl", "html_url": "https://github.com/janekl", "followers_url": "https://api.github.com/users/janekl/followers", "following_url": "https://api.github.com/users/janekl/following{/other_user}", "gists_url": "https://api.github.com/users/janekl/gists{/gist_id}", "starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janekl/subscriptions", "organizations_url": "https://api.github.com/users/janekl/orgs", "repos_url": "https://api.github.com/users/janekl/repos", "events_url": "https://api.github.com/users/janekl/events{/privacy}", "received_events_url": "https://api.github.com/users/janekl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-09T11:32:45
2024-09-17T10:00:20
2024-09-17T10:00:17
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10429", "html_url": "https://github.com/NVIDIA/NeMo/pull/10429", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10429.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10429.patch", "merged_at": "2024-09-17T10:00:17" }
# What does this PR do ? Currently `causal_conv1d` and `mamba_ssm` are in fact required to use NeMo but are not included in [requirements](https://github.com/NVIDIA/NeMo/blob/main/requirements/requirements_nlp.txt). This MR introduces the "import guard" mechanism for these two packages so that users that setup NeMo using `pip install nemo-toolkit` are not immediately hit by missing dependency problems if their use case is not related to Griffin or Mamba models. **Collection**: NLP # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "janekl", "id": 5582967, "node_id": "MDQ6VXNlcjU1ODI5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janekl", "html_url": "https://github.com/janekl", "followers_url": "https://api.github.com/users/janekl/followers", "following_url": "https://api.github.com/users/janekl/following{/other_user}", "gists_url": "https://api.github.com/users/janekl/gists{/gist_id}", "starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janekl/subscriptions", "organizations_url": "https://api.github.com/users/janekl/orgs", "repos_url": "https://api.github.com/users/janekl/repos", "events_url": "https://api.github.com/users/janekl/events{/privacy}", "received_events_url": "https://api.github.com/users/janekl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10429/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10429/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10428
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10428/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10428/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10428/events
https://github.com/NVIDIA/NeMo/issues/10428
2,513,620,656
I_kwDOC_bI7s6V0s6w
10,428
Problem running LoRA PEFT on Llama 3 8B Instruct using NeMo docker container
{ "login": "anagigoncalves", "id": 85490532, "node_id": "MDQ6VXNlcjg1NDkwNTMy", "avatar_url": "https://avatars.githubusercontent.com/u/85490532?v=4", "gravatar_id": "", "url": "https://api.github.com/users/anagigoncalves", "html_url": "https://github.com/anagigoncalves", "followers_url": "https://api.github.com/users/anagigoncalves/followers", "following_url": "https://api.github.com/users/anagigoncalves/following{/other_user}", "gists_url": "https://api.github.com/users/anagigoncalves/gists{/gist_id}", "starred_url": "https://api.github.com/users/anagigoncalves/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/anagigoncalves/subscriptions", "organizations_url": "https://api.github.com/users/anagigoncalves/orgs", "repos_url": "https://api.github.com/users/anagigoncalves/repos", "events_url": "https://api.github.com/users/anagigoncalves/events{/privacy}", "received_events_url": "https://api.github.com/users/anagigoncalves/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-09T10:54:05
2024-10-17T01:58:49
2024-10-17T01:58:48
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
I am trying to run the tutorial on [LoRA PEFT on Llama 3 8B Instruct using PubMedQA with NeMo](https://github.com/NVIDIA/NeMo/tree/main/tutorials/llm/llama-3/biomedical-qa) . I am running the notebook through the provided docker container, but I'm encountering some errors right at the early start of the code. Both the model and datasets seem to be properly loaded into the container. When running: %%bash # Set paths to the model, train, validation and test sets. MODEL="./workspace/llama-3-8b-instruct-nemo_v1.0/8b_instruct_nemo_bf16.nemo" TRAIN_DS="[./pubmedqa/data/pubmedqa_train.jsonl]" VALID_DS="[./pubmedqa/data/pubmedqa_val.jsonl]" TEST_DS="[./pubmedqa/data/pubmedqa_test.jsonl]" TEST_NAMES="[pubmedqa]" SCHEME="lora" TP_SIZE=1 PP_SIZE=1 OUTPUT_DIR="./results/Meta-Llama-3-8B-Instruct/" rm -r $OUTPUT_DIR torchrun --nproc_per_node=1 \ /opt/NeMo/examples/nlp/language_modeling/tuning/megatron_gpt_finetuning.py \ exp_manager.exp_dir=${OUTPUT_DIR} \ exp_manager.explicit_log_dir=${OUTPUT_DIR} \ trainer.devices=1 \ trainer.num_nodes=1 \ trainer.precision=bf16-mixed \ trainer.val_check_interval=20 \ trainer.max_steps=500 \ model.megatron_amp_O2=True \ ++model.mcore_gpt=True \ model.tensor_model_parallel_size=${TP_SIZE} \ model.pipeline_model_parallel_size=${PP_SIZE} \ model.micro_batch_size=1 \ model.global_batch_size=8 \ model.restore_from_path=${MODEL} \ model.data.train_ds.num_workers=0 \ model.data.validation_ds.num_workers=0 \ model.data.train_ds.file_names=${TRAIN_DS} \ model.data.train_ds.concat_sampling_probabilities=[1.0] \ model.data.validation_ds.file_names=${VALID_DS} \ model.peft.peft_scheme=${SCHEME} I get the following error: [NeMo W 2024-09-09 10:39:45 exp_manager:966] The checkpoint callback was told to monitor a validation value and trainer's max_steps was set to 500. Please ensure that max_steps will run for at least 1 epochs to ensure that checkpointing will not error out. Error executing job with overrides: ['exp_manager.exp_dir=./results/Meta-Llama-3-8B-Instruct/', 'exp_manager.explicit_log_dir=./results/Meta-Llama-3-8B-Instruct/', 'trainer.devices=1', 'trainer.num_nodes=1', 'trainer.precision=bf16-mixed', 'trainer.val_check_interval=20', 'trainer.max_steps=500', 'model.megatron_amp_O2=True', '++model.mcore_gpt=True', 'model.tensor_model_parallel_size=1', 'model.pipeline_model_parallel_size=1', 'model.micro_batch_size=1', 'model.global_batch_size=8', 'model.restore_from_path=./workspace/llama-3-8b-instruct-nemo_v1.0/8b_instruct_nemo_bf16.nemo', 'model.data.train_ds.num_workers=0', 'model.data.validation_ds.num_workers=0', 'model.data.train_ds.file_names=[./pubmedqa/data/pubmedqa_train.jsonl]', 'model.data.train_ds.concat_sampling_probabilities=[1.0]', 'model.data.validation_ds.file_names=[./pubmedqa/data/pubmedqa_val.jsonl]', 'model.peft.peft_scheme=lora'] Traceback (most recent call last): File "/opt/NeMo/examples/nlp/language_modeling/tuning/megatron_gpt_finetuning.py", line 62, in main model_cfg = MegatronGPTSFTModel.merge_cfg_with(cfg.model.restore_from_path, cfg) File "/opt/NeMo/nemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py", line 469, in merge_cfg_with base_cfg = cls.restore_from(path, return_config=True) File "/opt/NeMo/nemo/collections/nlp/models/nlp_model.py", line 465, in restore_from return super().restore_from( File "/opt/NeMo/nemo/core/classes/modelPT.py", line 464, in restore_from instance = cls._save_restore_connector.restore_from( File "/opt/NeMo/nemo/collections/nlp/parts/nlp_overrides.py", line 1122, in restore_from loaded_params = super().load_config_and_state_dict( File "/opt/NeMo/nemo/core/connectors/save_restore_connector.py", line 143, in load_config_and_state_dict self._unpack_nemo_file( File "/opt/NeMo/nemo/core/connectors/save_restore_connector.py", line 597, in _unpack_nemo_file members = [x for x in tar.getmembers() if ".yaml" in x.name] File "/usr/lib/python3.10/tarfile.py", line 1987, in getmembers self._load() # all members, we first have to File "/usr/lib/python3.10/tarfile.py", line 2682, in _load tarinfo = self.next() File "/usr/lib/python3.10/tarfile.py", line 2589, in next raise ReadError("unexpected end of data") tarfile.ReadError: unexpected end of data Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace. [2024-09-09 10:39:48,947] torch.distributed.elastic.multiprocessing.api: [ERROR] failed (exitcode: 1) local_rank: 0 (pid: 74718) of binary: /usr/bin/python Traceback (most recent call last): File "/usr/local/bin/torchrun", line 8, in <module> sys.exit(main()) File "/usr/local/lib/python3.10/dist-packages/torch/distributed/elastic/multiprocessing/errors/__init__.py", line 347, in wrapper return f(*args, **kwargs) File "/usr/local/lib/python3.10/dist-packages/torch/distributed/run.py", line 812, in main run(args) File "/usr/local/lib/python3.10/dist-packages/torch/distributed/run.py", line 803, in run elastic_launch( File "/usr/local/lib/python3.10/dist-packages/torch/distributed/launcher/api.py", line 135, in __call__ return launch_agent(self._config, self._entrypoint, list(args)) File "/usr/local/lib/python3.10/dist-packages/torch/distributed/launcher/api.py", line 268, in launch_agent raise ChildFailedError( torch.distributed.elastic.multiprocessing.errors.ChildFailedError: ============================================================ /opt/NeMo/examples/nlp/language_modeling/tuning/megatron_gpt_finetuning.py FAILED ------------------------------------------------------------ Failures: <NO_OTHER_FAILURES> ------------------------------------------------------------ Root Cause (first observed failure): [0]: time : 2024-09-09_10:39:48 host : ip-172-32-0-242.eu-west-1.compute.internal rank : 0 (local_rank: 0) exitcode : 1 (pid: 74718) error_file: <N/A> traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html ============================================================
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10428/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10428/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10427
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10427/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10427/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10427/events
https://github.com/NVIDIA/NeMo/pull/10427
2,512,752,218
PR_kwDOC_bI7s56yXlG
10,427
remove scripts
{ "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
{ "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "These scripts are moved to [here](https://github.com/NVIDIA/NeMo/tree/main/tests/collections/llm/gpt/model) instead for CICD [here](https://github.com/NVIDIA/NeMo/blob/d12fbbd3db952ea60d48cc567cbc632c02040bba/.github/workflows/cicd-main.yml#L4977)" ]
2024-09-09T02:19:40
2024-09-09T17:04:34
2024-09-09T17:04:31
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10427", "html_url": "https://github.com/NVIDIA/NeMo/pull/10427", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10427.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10427.patch", "merged_at": "2024-09-09T17:04:31" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10427/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10427/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10426
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10426/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10426/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10426/events
https://github.com/NVIDIA/NeMo/pull/10426
2,512,722,171
PR_kwDOC_bI7s56yRJy
10,426
ci: Fix secrets detector on forks
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-09T01:45:46
2024-09-10T16:51:01
2024-09-10T16:51:01
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10426", "html_url": "https://github.com/NVIDIA/NeMo/pull/10426", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10426.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10426.patch", "merged_at": "2024-09-10T16:51:01" }
# What does this PR do ? FYI the bug has nothing to do with forks but rather with checking out the branch explicitly. Checking out the branch means that we’re not running on the merge commit between branch and main anymore. So if the checked out branch is older than main, it misses or has an outdated baseline **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10426/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10426/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10425
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10425/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10425/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10425/events
https://github.com/NVIDIA/NeMo/pull/10425
2,512,663,746
PR_kwDOC_bI7s56yEfp
10,425
Meister/nfa
{ "login": "ssh-meister", "id": 117230141, "node_id": "U_kgDOBvzKPQ", "avatar_url": "https://avatars.githubusercontent.com/u/117230141?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ssh-meister", "html_url": "https://github.com/ssh-meister", "followers_url": "https://api.github.com/users/ssh-meister/followers", "following_url": "https://api.github.com/users/ssh-meister/following{/other_user}", "gists_url": "https://api.github.com/users/ssh-meister/gists{/gist_id}", "starred_url": "https://api.github.com/users/ssh-meister/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ssh-meister/subscriptions", "organizations_url": "https://api.github.com/users/ssh-meister/orgs", "repos_url": "https://api.github.com/users/ssh-meister/repos", "events_url": "https://api.github.com/users/ssh-meister/events{/privacy}", "received_events_url": "https://api.github.com/users/ssh-meister/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-09T00:38:42
2024-10-19T01:58:08
2024-10-19T01:58:07
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10425", "html_url": "https://github.com/NVIDIA/NeMo/pull/10425", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10425.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10425.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10425/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10425/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10424
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10424/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10424/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10424/events
https://github.com/NVIDIA/NeMo/pull/10424
2,512,662,316
PR_kwDOC_bI7s56yEL1
10,424
NFA branch update
{ "login": "ssh-meister", "id": 117230141, "node_id": "U_kgDOBvzKPQ", "avatar_url": "https://avatars.githubusercontent.com/u/117230141?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ssh-meister", "html_url": "https://github.com/ssh-meister", "followers_url": "https://api.github.com/users/ssh-meister/followers", "following_url": "https://api.github.com/users/ssh-meister/following{/other_user}", "gists_url": "https://api.github.com/users/ssh-meister/gists{/gist_id}", "starred_url": "https://api.github.com/users/ssh-meister/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ssh-meister/subscriptions", "organizations_url": "https://api.github.com/users/ssh-meister/orgs", "repos_url": "https://api.github.com/users/ssh-meister/repos", "events_url": "https://api.github.com/users/ssh-meister/events{/privacy}", "received_events_url": "https://api.github.com/users/ssh-meister/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-09T00:36:50
2024-09-09T00:37:57
2024-09-09T00:37:57
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10424", "html_url": "https://github.com/NVIDIA/NeMo/pull/10424", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10424.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10424.patch", "merged_at": "2024-09-09T00:37:57" }
# What does this PR do ? NFA branch update
{ "login": "ssh-meister", "id": 117230141, "node_id": "U_kgDOBvzKPQ", "avatar_url": "https://avatars.githubusercontent.com/u/117230141?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ssh-meister", "html_url": "https://github.com/ssh-meister", "followers_url": "https://api.github.com/users/ssh-meister/followers", "following_url": "https://api.github.com/users/ssh-meister/following{/other_user}", "gists_url": "https://api.github.com/users/ssh-meister/gists{/gist_id}", "starred_url": "https://api.github.com/users/ssh-meister/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ssh-meister/subscriptions", "organizations_url": "https://api.github.com/users/ssh-meister/orgs", "repos_url": "https://api.github.com/users/ssh-meister/repos", "events_url": "https://api.github.com/users/ssh-meister/events{/privacy}", "received_events_url": "https://api.github.com/users/ssh-meister/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10424/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10424/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10423
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10423/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10423/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10423/events
https://github.com/NVIDIA/NeMo/pull/10423
2,512,651,357
PR_kwDOC_bI7s56yBzy
10,423
Bump `Dockerfile.ci` (2024-09-09)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "CI passed: https://github.com/NVIDIA/NeMo/actions/runs/10815035809", "hey @akoumpa, some of these changes are definitely missing in the release branch `r2.0.0` (specifically, adding the attribute `fp8` to `ExampleConfig` of `tests/collections/llm/test_mnist_model_nemo2.py`\r\n\r\nCan you help me figure out if this is the only change that we should cherry-pick, of its safer to cherry-pick the whole PR?" ]
2024-09-09T00:22:31
2024-09-23T17:43:34
2024-09-11T19:07:40
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10423", "html_url": "https://github.com/NVIDIA/NeMo/pull/10423", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10423.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10423.patch", "merged_at": "2024-09-11T19:07:40" }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10423/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10423/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10422
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10422/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10422/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10422/events
https://github.com/NVIDIA/NeMo/pull/10422
2,512,628,230
PR_kwDOC_bI7s56x89k
10,422
cherry pick `ci: Update baseline (#10400)`
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-09-08T23:41:07
2024-09-08T23:41:21
2024-09-08T23:41:19
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10422", "html_url": "https://github.com/NVIDIA/NeMo/pull/10422", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10422.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10422.patch", "merged_at": "2024-09-08T23:41:19" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10422/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10422/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10421
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10421/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10421/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10421/events
https://github.com/NVIDIA/NeMo/pull/10421
2,512,609,173
PR_kwDOC_bI7s56x5HT
10,421
ci: Fix mcore tag
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T22:46:57
2024-09-12T01:00:57
2024-09-12T01:00:57
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10421", "html_url": "https://github.com/NVIDIA/NeMo/pull/10421", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10421.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10421.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10421/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10421/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10420
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10420/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10420/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10420/events
https://github.com/NVIDIA/NeMo/pull/10420
2,512,605,938
PR_kwDOC_bI7s56x4ev
10,420
ci: Small fix
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T22:37:38
2024-09-08T22:37:49
2024-09-08T22:37:45
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10420", "html_url": "https://github.com/NVIDIA/NeMo/pull/10420", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10420.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10420.patch", "merged_at": "2024-09-08T22:37:45" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10420/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10420/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10419
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10419/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10419/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10419/events
https://github.com/NVIDIA/NeMo/pull/10419
2,512,605,091
PR_kwDOC_bI7s56x4T2
10,419
ci: Small test
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T22:35:00
2024-09-08T22:35:10
2024-09-08T22:35:06
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10419", "html_url": "https://github.com/NVIDIA/NeMo/pull/10419", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10419.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10419.patch", "merged_at": "2024-09-08T22:35:06" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10419/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10419/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10418
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10418/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10418/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10418/events
https://github.com/NVIDIA/NeMo/pull/10418
2,512,604,832
PR_kwDOC_bI7s56x4Qs
10,418
Cherry pick `Alit/mamba ux cicd (#10370)`
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
[ { "id": 4556669155, "node_id": "LA_kwDOC_bI7s8AAAABD5lA4w", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick", "name": "cherry-pick", "color": "ededed", "default": false, "description": null }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T22:34:10
2024-09-08T22:42:34
2024-09-08T22:42:34
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10418", "html_url": "https://github.com/NVIDIA/NeMo/pull/10418", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10418.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10418.patch", "merged_at": null }
* add mamba init * more ssm * add 370m * add hybrid * fix issue * integrate model and tokenizer config for ssm * add all mamba configs * modify state re pattern * revert gpt stuff * remove SSM class and training script * Apply isort and black reformatting * remove faulty export * add script to test * Apply isort and black reformatting * some recent fixes * Apply isort and black reformatting * test script tp/pp1 * Apply isort and black reformatting * add cicd * include MLM mamba dist ckpt commit * add license head and address more comments * Apply isort and black reformatting * add guard * remove guard from TransformerConfig * update scripts * Apply isort and black reformatting --------- # What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10418/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10418/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10417
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10417/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10417/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10417/events
https://github.com/NVIDIA/NeMo/pull/10417
2,512,603,374
PR_kwDOC_bI7s56x396
10,417
Ko3n1g/ci/test cherry picking 2
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T22:30:28
2024-09-08T22:30:40
2024-09-08T22:30:35
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10417", "html_url": "https://github.com/NVIDIA/NeMo/pull/10417", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10417.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10417.patch", "merged_at": "2024-09-08T22:30:35" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10417/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10417/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10416
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10416/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10416/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10416/events
https://github.com/NVIDIA/NeMo/pull/10416
2,512,602,070
PR_kwDOC_bI7s56x3tC
10,416
ci: Remove dead code
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T22:26:56
2024-09-08T22:27:09
2024-09-08T22:27:05
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10416", "html_url": "https://github.com/NVIDIA/NeMo/pull/10416", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10416.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10416.patch", "merged_at": "2024-09-08T22:27:05" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10416/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10416/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10415
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10415/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10415/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10415/events
https://github.com/NVIDIA/NeMo/pull/10415
2,512,600,947
PR_kwDOC_bI7s56x3eh
10,415
ci: Minor change
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T22:23:48
2024-09-08T22:23:57
2024-09-08T22:23:54
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10415", "html_url": "https://github.com/NVIDIA/NeMo/pull/10415", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10415.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10415.patch", "merged_at": "2024-09-08T22:23:54" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10415/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10415/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10414
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10414/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10414/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10414/events
https://github.com/NVIDIA/NeMo/pull/10414
2,512,600,408
PR_kwDOC_bI7s56x3XP
10,414
ci: Minor change
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T22:22:31
2024-09-08T22:22:42
2024-09-08T22:22:40
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10414", "html_url": "https://github.com/NVIDIA/NeMo/pull/10414", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10414.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10414.patch", "merged_at": "2024-09-08T22:22:40" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10414/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10414/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10413
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10413/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10413/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10413/events
https://github.com/NVIDIA/NeMo/pull/10413
2,512,600,037
PR_kwDOC_bI7s56x3SM
10,413
ci: Fix cherry-pick config
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T22:21:38
2024-09-08T22:21:48
2024-09-08T22:21:44
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10413", "html_url": "https://github.com/NVIDIA/NeMo/pull/10413", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10413.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10413.patch", "merged_at": "2024-09-08T22:21:44" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10413/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10413/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10412
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10412/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10412/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10412/events
https://github.com/NVIDIA/NeMo/pull/10412
2,512,599,055
PR_kwDOC_bI7s56x3FK
10,412
Ko3n1g/ci/test cherry picking
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T22:19:03
2024-09-08T22:19:55
2024-09-08T22:19:54
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10412", "html_url": "https://github.com/NVIDIA/NeMo/pull/10412", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10412.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10412.patch", "merged_at": "2024-09-08T22:19:54" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10412/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10412/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10411
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10411/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10411/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10411/events
https://github.com/NVIDIA/NeMo/pull/10411
2,512,598,553
PR_kwDOC_bI7s56x2-s
10,411
ci: Ignore failures on cherry-picking
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T22:17:40
2024-09-08T22:17:54
2024-09-08T22:17:53
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10411", "html_url": "https://github.com/NVIDIA/NeMo/pull/10411", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10411.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10411.patch", "merged_at": "2024-09-08T22:17:53" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10411/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10411/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10410
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10410/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10410/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10410/events
https://github.com/NVIDIA/NeMo/pull/10410
2,512,597,798
PR_kwDOC_bI7s56x21N
10,410
ci: Overhaul cherry-pick workflow
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T22:15:28
2024-09-08T22:15:42
2024-09-08T22:15:39
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10410", "html_url": "https://github.com/NVIDIA/NeMo/pull/10410", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10410.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10410.patch", "merged_at": "2024-09-08T22:15:39" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10410/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10410/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10409
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10409/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10409/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10409/events
https://github.com/NVIDIA/NeMo/pull/10409
2,512,589,625
PR_kwDOC_bI7s56x1M7
10,409
ci: More permissions for cherry-pick automation
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T21:51:16
2024-09-08T21:51:26
2024-09-08T21:51:25
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10409", "html_url": "https://github.com/NVIDIA/NeMo/pull/10409", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10409.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10409.patch", "merged_at": "2024-09-08T21:51:25" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10409/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10409/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10408
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10408/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10408/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10408/events
https://github.com/NVIDIA/NeMo/pull/10408
2,512,588,706
PR_kwDOC_bI7s56x1Bs
10,408
Cherry pick `Alit/mamba ux cicd (#10370)`
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "hey @JRD971000, this PR got a bit delayed. Shall we still cherry-pick it? Can you help resolving the conflict? Otherwise feel free to close it", "@ko3n1g thanks for the reminder, I actually added the CIs in another PR. I don't know why I had two PRs for this :) \r\n\r\nHowever, I have a PR for removing optional flag from SSM test, given the rm -rf issue is hopefully gone:\r\nhttps://github.com/NVIDIA/NeMo/pull/10460", "closing this one" ]
2024-09-08T21:48:20
2024-09-22T03:36:43
2024-09-22T03:36:42
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10408", "html_url": "https://github.com/NVIDIA/NeMo/pull/10408", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10408.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10408.patch", "merged_at": null }
* add mamba init * more ssm * add 370m * add hybrid * fix issue * integrate model and tokenizer config for ssm * add all mamba configs * modify state re pattern * revert gpt stuff * remove SSM class and training script * Apply isort and black reformatting * remove faulty export * add script to test * Apply isort and black reformatting * some recent fixes * Apply isort and black reformatting * test script tp/pp1 * Apply isort and black reformatting * add cicd * include MLM mamba dist ckpt commit * add license head and address more comments * Apply isort and black reformatting * add guard * remove guard from TransformerConfig * update scripts * Apply isort and black reformatting --------- # What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10408/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10408/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10407
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10407/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10407/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10407/events
https://github.com/NVIDIA/NeMo/pull/10407
2,512,587,609
PR_kwDOC_bI7s56x0z2
10,407
ci: Allow default token to write workflows
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T21:45:02
2024-09-08T21:45:15
2024-09-08T21:45:13
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10407", "html_url": "https://github.com/NVIDIA/NeMo/pull/10407", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10407.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10407.patch", "merged_at": "2024-09-08T21:45:13" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10407/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10407/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10406
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10406/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10406/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10406/events
https://github.com/NVIDIA/NeMo/pull/10406
2,512,550,038
PR_kwDOC_bI7s56xtzC
10,406
ci: Use PAT for cherry-picking
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T19:59:56
2024-09-08T20:00:07
2024-09-08T20:00:02
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10406", "html_url": "https://github.com/NVIDIA/NeMo/pull/10406", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10406.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10406.patch", "merged_at": "2024-09-08T20:00:02" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10406/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10406/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10405
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10405/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10405/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10405/events
https://github.com/NVIDIA/NeMo/pull/10405
2,512,549,099
PR_kwDOC_bI7s56xtpz
10,405
ci: Allow concurrent docker system prune
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T19:57:56
2024-09-08T19:58:06
2024-09-08T19:58:05
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10405", "html_url": "https://github.com/NVIDIA/NeMo/pull/10405", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10405.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10405.patch", "merged_at": "2024-09-08T19:58:05" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10405/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10405/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10404
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10404/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10404/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10404/events
https://github.com/NVIDIA/NeMo/pull/10404
2,512,545,921
PR_kwDOC_bI7s56xtF-
10,404
ci: Send Slack alert on failed cherry pick
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T19:49:41
2024-09-08T19:49:53
2024-09-08T19:49:49
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10404", "html_url": "https://github.com/NVIDIA/NeMo/pull/10404", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10404.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10404.patch", "merged_at": "2024-09-08T19:49:49" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10404/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10404/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10403
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10403/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10403/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10403/events
https://github.com/NVIDIA/NeMo/pull/10403
2,512,544,003
PR_kwDOC_bI7s56xstr
10,403
Ko3n1g/ci/fix release workflow 2
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T19:44:17
2024-09-08T19:44:34
2024-09-08T19:44:33
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10403", "html_url": "https://github.com/NVIDIA/NeMo/pull/10403", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10403.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10403.patch", "merged_at": "2024-09-08T19:44:33" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10403/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10403/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10402
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10402/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10402/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10402/events
https://github.com/NVIDIA/NeMo/pull/10402
2,512,543,014
PR_kwDOC_bI7s56xsgd
10,402
ci: Fix release tag
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T19:41:31
2024-09-08T19:43:27
2024-09-08T19:41:50
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10402", "html_url": "https://github.com/NVIDIA/NeMo/pull/10402", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10402.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10402.patch", "merged_at": "2024-09-08T19:41:50" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10402/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10402/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10401
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10401/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10401/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10401/events
https://github.com/NVIDIA/NeMo/pull/10401
2,512,540,345
PR_kwDOC_bI7s56xr_v
10,401
ci(chore): Minor change
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T19:34:28
2024-09-08T19:35:00
2024-09-08T19:34:59
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10401", "html_url": "https://github.com/NVIDIA/NeMo/pull/10401", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10401.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10401.patch", "merged_at": "2024-09-08T19:34:59" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10401/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10401/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10400
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10400/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10400/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10400/events
https://github.com/NVIDIA/NeMo/pull/10400
2,512,531,896
PR_kwDOC_bI7s56xqYH
10,400
ci: Update baseline
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-09-08T19:13:25
2024-09-08T19:13:40
2024-09-08T19:13:39
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10400", "html_url": "https://github.com/NVIDIA/NeMo/pull/10400", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10400.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10400.patch", "merged_at": "2024-09-08T19:13:39" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10400/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10400/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10399
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10399/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10399/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10399/events
https://github.com/NVIDIA/NeMo/pull/10399
2,512,509,841
PR_kwDOC_bI7s56xmN1
10,399
Version bump to `2.1.0rc0`
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T18:17:00
2024-09-08T19:08:03
2024-09-08T19:08:01
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10399", "html_url": "https://github.com/NVIDIA/NeMo/pull/10399", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10399.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10399.patch", "merged_at": "2024-09-08T19:08:01" }
🚀 Version bump NeMo toolkit to `2.1.0rc0`
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10399/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10399/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10398
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10398/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10398/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10398/events
https://github.com/NVIDIA/NeMo/pull/10398
2,512,509,683
PR_kwDOC_bI7s56xmL0
10,398
Release `2.0.0`
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "# Highlights\n_<here-goes-the-summary...>_", "# Detailed Changelogs" ]
2024-09-08T18:16:31
2024-09-08T19:49:57
2024-09-08T19:49:57
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10398", "html_url": "https://github.com/NVIDIA/NeMo/pull/10398", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10398.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10398.patch", "merged_at": null }
🚀 PR to release NeMo `2.0.0`. 📝 Please remember the following to-do's before merge: - [ ] Fill-in the comment `Highlights` - [ ] Review the comment `Detailed Changelogs` 🚨 Please also keep in mind to _not_ delete the headings of the task commits. They are required by the post-merge automation. 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10398/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10398/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10397
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10397/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10397/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10397/events
https://github.com/NVIDIA/NeMo/pull/10397
2,512,509,311
PR_kwDOC_bI7s56xmHI
10,397
Ko3n1g/ci/release freeze
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T18:15:33
2024-09-08T18:15:59
2024-09-08T18:15:57
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10397", "html_url": "https://github.com/NVIDIA/NeMo/pull/10397", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10397.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10397.patch", "merged_at": "2024-09-08T18:15:57" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10397/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10397/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10396
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10396/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10396/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10396/events
https://github.com/NVIDIA/NeMo/pull/10396
2,512,507,745
PR_kwDOC_bI7s56xlz3
10,396
ci: Toggle pre-release
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T18:11:30
2024-09-08T18:11:44
2024-09-08T18:11:42
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10396", "html_url": "https://github.com/NVIDIA/NeMo/pull/10396", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10396.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10396.patch", "merged_at": "2024-09-08T18:11:42" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10396/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10396/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10395
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10395/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10395/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10395/events
https://github.com/NVIDIA/NeMo/pull/10395
2,512,506,383
PR_kwDOC_bI7s56xljU
10,395
ci: Toggle pre-release
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T18:08:12
2024-09-08T18:08:23
2024-09-08T18:08:21
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10395", "html_url": "https://github.com/NVIDIA/NeMo/pull/10395", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10395.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10395.patch", "merged_at": "2024-09-08T18:08:21" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10395/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10395/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10394
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10394/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10394/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10394/events
https://github.com/NVIDIA/NeMo/pull/10394
2,512,504,562
PR_kwDOC_bI7s56xlL3
10,394
ci: Toggle pre-release
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T18:03:16
2024-09-08T18:03:44
2024-09-08T18:03:43
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10394", "html_url": "https://github.com/NVIDIA/NeMo/pull/10394", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10394.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10394.patch", "merged_at": "2024-09-08T18:03:43" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10394/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10394/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10393
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10393/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10393/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10393/events
https://github.com/NVIDIA/NeMo/pull/10393
2,512,503,210
PR_kwDOC_bI7s56xk7Q
10,393
Release `2.0.0rc2`
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "# Highlights\n_<here-goes-the-summary...>_", "# Detailed Changelogs", "wrong, it's not supposed to be a pre-release" ]
2024-09-08T17:59:47
2024-09-16T17:48:34
2024-09-08T18:01:54
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10393", "html_url": "https://github.com/NVIDIA/NeMo/pull/10393", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10393.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10393.patch", "merged_at": null }
🚀 PR to release NeMo `2.0.0rc2`. 📝 Please remember the following to-do's before merge: - [ ] Fill-in the comment `Highlights` - [ ] Review the comment `Detailed Changelogs` 🚨 Please also keep in mind to _not_ delete the headings of the task commits. They are required by the post-merge automation. 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10393/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10393/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10392
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10392/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10392/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10392/events
https://github.com/NVIDIA/NeMo/pull/10392
2,512,494,445
PR_kwDOC_bI7s56xjP3
10,392
ci: Cleanup of release-freeze automation
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T17:35:31
2024-09-08T17:59:09
2024-09-08T17:59:08
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10392", "html_url": "https://github.com/NVIDIA/NeMo/pull/10392", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10392.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10392.patch", "merged_at": "2024-09-08T17:59:08" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10392/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10392/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10391
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10391/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10391/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10391/events
https://github.com/NVIDIA/NeMo/pull/10391
2,512,482,013
PR_kwDOC_bI7s56xhHu
10,391
[NeMo-UX] Rename weights path during resume
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T17:05:52
2024-09-15T01:18:33
2024-09-15T01:18:32
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10391", "html_url": "https://github.com/NVIDIA/NeMo/pull/10391", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10391.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10391.patch", "merged_at": "2024-09-15T01:18:32" }
# What does this PR do ? Minor improvements to `AutoResume` class to improve readability **Collection**: llm # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10391/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10391/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10390
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10390/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10390/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10390/events
https://github.com/NVIDIA/NeMo/pull/10390
2,512,338,067
PR_kwDOC_bI7s56xEw4
10,390
add ci tests for Auto Configurator
{ "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T11:22:55
2024-09-12T15:24:17
2024-09-12T15:24:15
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10390", "html_url": "https://github.com/NVIDIA/NeMo/pull/10390", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10390.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10390.patch", "merged_at": "2024-09-12T15:24:15" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10390/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10390/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10389
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10389/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10389/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10389/events
https://github.com/NVIDIA/NeMo/pull/10389
2,512,193,874
PR_kwDOC_bI7s56wnvw
10,389
ci: Swap merge and cherry-pick order
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T04:42:32
2024-09-08T19:35:52
2024-09-08T19:35:51
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10389", "html_url": "https://github.com/NVIDIA/NeMo/pull/10389", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10389.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10389.patch", "merged_at": "2024-09-08T19:35:51" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10389/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10389/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10387
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10387/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10387/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10387/events
https://github.com/NVIDIA/NeMo/pull/10387
2,512,129,881
PR_kwDOC_bI7s56wbWS
10,387
Bump `Dockerfile.ci` (2024-09-08)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-08T00:23:30
2024-09-12T01:01:12
2024-09-12T01:01:12
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10387", "html_url": "https://github.com/NVIDIA/NeMo/pull/10387", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10387.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10387.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10387/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10387/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10386
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10386/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10386/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10386/events
https://github.com/NVIDIA/NeMo/issues/10386
2,512,028,971
I_kwDOC_bI7s6VuoUr
10,386
megatron.core.dist_checkpointing.core.CheckpointingException: Object shard /ckpt/model_weights/model.decoder.layers.self_attention.core_attention._extra_state/shard_0_80.pt not found
{ "login": "OrenLeung", "id": 47992694, "node_id": "MDQ6VXNlcjQ3OTkyNjk0", "avatar_url": "https://avatars.githubusercontent.com/u/47992694?v=4", "gravatar_id": "", "url": "https://api.github.com/users/OrenLeung", "html_url": "https://github.com/OrenLeung", "followers_url": "https://api.github.com/users/OrenLeung/followers", "following_url": "https://api.github.com/users/OrenLeung/following{/other_user}", "gists_url": "https://api.github.com/users/OrenLeung/gists{/gist_id}", "starred_url": "https://api.github.com/users/OrenLeung/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/OrenLeung/subscriptions", "organizations_url": "https://api.github.com/users/OrenLeung/orgs", "repos_url": "https://api.github.com/users/OrenLeung/repos", "events_url": "https://api.github.com/users/OrenLeung/events{/privacy}", "received_events_url": "https://api.github.com/users/OrenLeung/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale.", "@OrenLeung Hello Have you fixed this problem im stuck with the same..!\n" ]
2024-09-07T19:14:18
2024-11-27T12:02:36
2024-10-15T01:59:30
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** I got MLPerf LLama2 LoRA working with 24.04-py3 pytorch image with the [same modifications](https://github.com/mlcommons/training_results_v4.0/blob/main/NVIDIA/benchmarks/llama2_70b_lora/implementations/nemo/Dockerfile) with NVIDIA's submission. The model weights are converted using the following [checkpoints conversion script](https://github.com/mlcommons/training_results_v4.0/blob/main/NVIDIA/benchmarks/llama2_70b_lora/implementations/nemo/scripts/convert_model.py#L182-L258) While trying to update to the latest Nemo, Megatron and Pytorch image (24.08), i ran into the following issue saying that NeMo checkpoint restore `self_attention.core_attention._extra_state` but we don't have that as for llama2 lora, core attention does not have any weights. I have checked that our self attention already have qkv projection and output projection weights. What is the resolution towards fixing this? is there a certain thing I should put to stop restore from trying to get core attention even tho it doesnt have it? This is my config file https://github.com/mlcommons/training_results_v4.0/blob/main/NVIDIA/benchmarks/llama2_70b_lora/implementations/nemo/conf/base/model_config.yaml ``` 6: [rank6]: instance = cls._save_restore_connector.restore_from( 6: [rank6]: File "/workspace/ft-llm/NeMo/nemo/collections/nlp/parts/nlp_overrides.py", line 1333, in restore_from 6: [rank6]: checkpoint = checkpoint_io.load_checkpoint( 6: [rank6]: File "/usr/lib/python3.10/contextlib.py", line 79, in inner 6: [rank6]: return func(*args, **kwds) 6: [rank6]: File "/workspace/ft-llm/NeMo/nemo/utils/callbacks/dist_ckpt_io.py", line 340, in load_checkpoint 6: [rank6]: return dist_checkpointing.load( 6: [rank6]: File "/usr/local/lib/python3.10/dist-packages/megatron/core/dist_checkpointing/serialization.py", line 155, in load 6: [rank6]: sharded_objects = common_strategy.load_sharded_objects( 6: [rank6]: File "/usr/local/lib/python3.10/dist-packages/megatron/core/dist_checkpointing/strategies/common.py", line 107, in load_sharded_objects 6: [rank6]: return dict_list_map_inplace(load_sharded_object, sharded_objects_state_dict) 6: [rank6]: File "/usr/local/lib/python3.10/dist-packages/megatron/core/dist_checkpointing/dict_utils.py", line 180, in dict_list_map_inplace 6: [rank6]: x[k] = dict_list_map_inplace(f, v) 7: [rank7]: File "/usr/local/lib/python3.10/dist-packages/megatron/core/dist_checkpointing/dict_utils.py", line 180, in dict_list_map_inplace 7: [rank7]: x[k] = dict_list_map_inplace(f, v) 7: [rank7]: File "/usr/local/lib/python3.10/dist-packages/megatron/core/dist_checkpointing/dict_utils.py", line 184, in dict_list_map_inplace 7: [rank7]: return f(x) 7: [rank7]: File "/usr/local/lib/python3.10/dist-packages/megatron/core/dist_checkpointing/strategies/common.py", line 104, in load_sharded_object 7: [rank7]: raise CheckpointingException(err_msg) from e 7: [rank7]: megatron.core.dist_checkpointing.core.CheckpointingException: Object shard /ckpt/model_weights/model.decoder.layers.self_attention.core_attention._extra_state/shard_0_80.pt not found ``` **Expected behavior** checkpoints should work between versions **Environment overview (please complete the following information)** - Environment location: [Bare-metal, Docker, Cloud(specify cloud provider - AWS, Azure, GCP, Collab)] - Method of NeMo install: [pip install or from source]. Please specify exact commands you used to install. - If method of install is [Docker], provide `docker pull` & `docker run` commands used **Environment details** Nvidia pytorch 24.08 Docker With the following package updates ``` ARG NEMO_REVISION=r2.0.0rc1 RUN git clone https://github.com/NVIDIA/NeMo.git && \ cd NeMo && \ echo NEMO_REVISION=${NEMO_REVISION} && \ git checkout ${NEMO_REVISION} && \ echo NEMO_COMMIT_HASH=$(git rev-parse HEAD) && \ pip install --no-build-isolation -e ".[nlp]" ## Megatron-core ARG MEGATRON_REVISION=core_r0.8.0 RUN pip uninstall -y megatron-core && \ git clone https://github.com/NVIDIA/Megatron-LM.git && \ cd Megatron-LM && \ echo MEGATRON_REVISION=${MEGATRON_REVISION} && \ git checkout ${MEGATRON_REVISION} && \ echo MEGATRON_COMMIT_HASH=$(git rev-parse HEAD) && \ pip install . && \ cd megatron/core/datasets && \ make ``` ``` $ ls /mnt/nvme/llama2/model/model_weights/ common.pt model.decoder.layers.self_attention.linear_proj._extra_state metadata.json model.decoder.layers.self_attention.linear_proj.weight model.decoder.final_layernorm.weight model.decoder.layers.self_attention.linear_qkv._extra_state model.decoder.layers.mlp.linear_fc1._extra_state model.decoder.layers.self_attention.linear_qkv.layer_norm_weight model.decoder.layers.mlp.linear_fc1.layer_norm_weight model.decoder.layers.self_attention.linear_qkv.weight model.decoder.layers.mlp.linear_fc1.weight model.embedding.word_embeddings.weight model.decoder.layers.mlp.linear_fc2._extra_state model.output_layer.weight model.decoder.layers.mlp.linear_fc2.weight ```
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10386/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10386/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10385
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10385/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10385/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10385/events
https://github.com/NVIDIA/NeMo/pull/10385
2,511,339,315
PR_kwDOC_bI7s56tw0b
10,385
Bump `Dockerfile.ci` (2024-09-07)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-07T00:20:17
2024-09-08T23:39:15
2024-09-08T23:39:15
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10385", "html_url": "https://github.com/NVIDIA/NeMo/pull/10385", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10385.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10385.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10385/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10385/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10384
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10384/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10384/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10384/events
https://github.com/NVIDIA/NeMo/pull/10384
2,511,317,429
PR_kwDOC_bI7s56tsL9
10,384
Bump up Mcore
{ "login": "huvunvidia", "id": 86480512, "node_id": "MDQ6VXNlcjg2NDgwNTEy", "avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4", "gravatar_id": "", "url": "https://api.github.com/users/huvunvidia", "html_url": "https://github.com/huvunvidia", "followers_url": "https://api.github.com/users/huvunvidia/followers", "following_url": "https://api.github.com/users/huvunvidia/following{/other_user}", "gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions", "organizations_url": "https://api.github.com/users/huvunvidia/orgs", "repos_url": "https://api.github.com/users/huvunvidia/repos", "events_url": "https://api.github.com/users/huvunvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/huvunvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-06T23:35:02
2024-11-19T17:11:04
2024-09-29T02:02:53
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10384", "html_url": "https://github.com/NVIDIA/NeMo/pull/10384", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10384.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10384.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10384/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10384/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10383
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10383/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10383/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10383/events
https://github.com/NVIDIA/NeMo/pull/10383
2,511,300,483
PR_kwDOC_bI7s56tokN
10,383
[NeMo-UX] Use custom `BatchProgress` class which does not restore states
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-06T23:06:20
2024-09-15T01:19:25
2024-09-15T01:19:23
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10383", "html_url": "https://github.com/NVIDIA/NeMo/pull/10383", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10383.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10383.patch", "merged_at": "2024-09-15T01:19:23" }
# What does this PR do ? When using a Megatron-based dataloader, the length of the dataset changes when we restore from a checkpoint. We do not want the `BatchProgress` class to reflect the samples that were processed before saving the checkpoint. **Collection**: llm # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10383/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10383/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10382
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10382/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10382/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10382/events
https://github.com/NVIDIA/NeMo/issues/10382
2,511,274,296
I_kwDOC_bI7s6VrwE4
10,382
RuntimeError: stack expects each tensor to be equal size (when using lhotse shar data sets)
{ "login": "riqiang-dp", "id": 58701255, "node_id": "MDQ6VXNlcjU4NzAxMjU1", "avatar_url": "https://avatars.githubusercontent.com/u/58701255?v=4", "gravatar_id": "", "url": "https://api.github.com/users/riqiang-dp", "html_url": "https://github.com/riqiang-dp", "followers_url": "https://api.github.com/users/riqiang-dp/followers", "following_url": "https://api.github.com/users/riqiang-dp/following{/other_user}", "gists_url": "https://api.github.com/users/riqiang-dp/gists{/gist_id}", "starred_url": "https://api.github.com/users/riqiang-dp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/riqiang-dp/subscriptions", "organizations_url": "https://api.github.com/users/riqiang-dp/orgs", "repos_url": "https://api.github.com/users/riqiang-dp/repos", "events_url": "https://api.github.com/users/riqiang-dp/events{/privacy}", "received_events_url": "https://api.github.com/users/riqiang-dp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[ "Fixed, found stereo audio marked as single channel" ]
2024-09-06T22:28:44
2024-09-23T15:57:14
2024-09-23T15:57:12
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** Hi @pzelasko, I got the following error using lhotse shar dataset settings to train a hybrid CTC transducer model. What does this error suggest? What are the entries in this stack in this case? I'm not sure if this is a bug or something wrong with my dataset. I'm guessing if it can be due to audio having two channels? Although I think it's also unlikely that I have that in my data. Thank you! ``` File "***lib/python3.11/site-packages/torch/utils/data/_utils/worker.py", line 308, in _wor ker_loop data = fetcher.fetch(index) ^^^^^^^^^^^^^^^^^^^^ File "/***lib/python3.11/site-packages/torch/utils/data/_utils/fetch.py", line 41, in fetch data = next(self.dataset_iter) ^^^^^^^^^^^^^^^^^^^^^^^ File "***lib/python3.11/site-packages/lhotse/dataset/iterable_dataset.py", line 100, in __n ext__ return self.dataset[sampled] ~~~~~~~~~~~~^^^^^^^^^ File "***lib/python3.11/site-packages/nemo/collections/asr/data/audio_to_text_lhotse.py", l ine 52, in __getitem__ audio, audio_lens, cuts = self.load_audio(cuts) ^^^^^^^^^^^^^^^^^^^^^ File "***lib/python3.11/site-packages/lhotse/dataset/input_strategies.py", line 224, in __c all__ return collate_audio( ^^^^^^^^^^^^^^ File "***lib/python3.11/site-packages/lhotse/dataset/collation.py", line 202, in collate_au dio audios = torch.stack(audios) ^^^^^^^^^^^^^^^^^^^ RuntimeError: stack expects each tensor to be equal size, but got [203680] at entry 0 and [2, 203680] at entry 28 ``` **Steps/Code to reproduce bug** As described above. **Expected behavior** Tensors should all just have one dimension? **Environment overview (please complete the following information)** N/A **Environment details** N/A **Additional context** N/A
{ "login": "riqiang-dp", "id": 58701255, "node_id": "MDQ6VXNlcjU4NzAxMjU1", "avatar_url": "https://avatars.githubusercontent.com/u/58701255?v=4", "gravatar_id": "", "url": "https://api.github.com/users/riqiang-dp", "html_url": "https://github.com/riqiang-dp", "followers_url": "https://api.github.com/users/riqiang-dp/followers", "following_url": "https://api.github.com/users/riqiang-dp/following{/other_user}", "gists_url": "https://api.github.com/users/riqiang-dp/gists{/gist_id}", "starred_url": "https://api.github.com/users/riqiang-dp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/riqiang-dp/subscriptions", "organizations_url": "https://api.github.com/users/riqiang-dp/orgs", "repos_url": "https://api.github.com/users/riqiang-dp/repos", "events_url": "https://api.github.com/users/riqiang-dp/events{/privacy}", "received_events_url": "https://api.github.com/users/riqiang-dp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10382/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10382/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10381
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10381/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10381/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10381/events
https://github.com/NVIDIA/NeMo/pull/10381
2,511,237,073
PR_kwDOC_bI7s56taqZ
10,381
ci: Fix checkout of secrets detector
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-09-06T21:50:18
2024-09-06T21:52:57
2024-09-06T21:52:55
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10381", "html_url": "https://github.com/NVIDIA/NeMo/pull/10381", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10381.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10381.patch", "merged_at": "2024-09-06T21:52:55" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10381/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10381/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10380
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10380/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10380/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10380/events
https://github.com/NVIDIA/NeMo/pull/10380
2,511,222,746
PR_kwDOC_bI7s56tXgY
10,380
[Nemo Unit Tests] Split GPU unit tests
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7436254803, "node_id": "LA_kwDOC_bI7s8AAAABuzw-Uw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/r2.0.0", "name": "r2.0.0", "color": "4E083D", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "CI passed: https://github.com/NVIDIA/NeMo/actions/runs/10767988941/job/29883535146 [SSM test flaky]" ]
2024-09-06T21:34:08
2024-09-12T15:42:40
2024-09-09T15:48:50
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10380", "html_url": "https://github.com/NVIDIA/NeMo/pull/10380", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10380.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10380.patch", "merged_at": "2024-09-09T15:48:50" }
Split GPU unit tests
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10380/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10380/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10379
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10379/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10379/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10379/events
https://github.com/NVIDIA/NeMo/pull/10379
2,511,141,445
PR_kwDOC_bI7s56tFsZ
10,379
fix partial audio transcription order:
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "wouldn't it be better to enable pre-sorting for partial audio instead (if possible)?", "Thanks for the suggestion @pzelasko, that needs a whole revamp and done that. \r\nBut now I notice we can unify partial audio.\r\n1. ~Canary can perform partial audio transcription when offset provided through manifest (previous assumption was no I believe looking at the code)~ -> Fixed to allow partial transcribe to be done using transcribe by default \r\n2. ~If 1, then we can add additional support for .transcribe() for ASR Models to support reading from manifest. Currently TranscriptioMixin supports audio, list of audio, dataloader.~ Added support for manifest file reading to TranscribeMixIn high level " ]
2024-09-06T20:21:37
2024-09-16T17:01:52
2024-09-16T17:01:50
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10379", "html_url": "https://github.com/NVIDIA/NeMo/pull/10379", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10379.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10379.patch", "merged_at": "2024-09-16T17:01:50" }
# What does this PR do ? * Removes special case of sorting for EncDecMultiTaskModels * Removes partial audio transcription for all Model Types * Now transcribe_speech.py transcribes as per presence of offset and duration in manifest automatically without special conditions * Adds support to transcriptionmixin to read manifest for transcribing on high level rather than subclasses to deal with it * Merges NeMo 2.0 transcription usage for all Model Types **Collection**: ASR # Usage ```bash python transcribe_speech.py model_path=<.nemo file> dataset_manifest=<manifest_file> ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10379/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10379/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10378
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10378/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10378/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10378/events
https://github.com/NVIDIA/NeMo/pull/10378
2,511,133,718
PR_kwDOC_bI7s56tD_t
10,378
Add dummy optimizer_states key in checkpoint to bypass PTL validation.
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "closing in favor of https://github.com/NVIDIA/NeMo/pull/10376" ]
2024-09-06T20:16:19
2024-09-06T22:10:53
2024-09-06T22:10:52
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10378", "html_url": "https://github.com/NVIDIA/NeMo/pull/10378", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10378.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10378.patch", "merged_at": null }
# What does this PR do ? During ckpt restoration PTL [requires](https://github.com/Lightning-AI/pytorch-lightning/blob/9624aae07e3e2dca18f87f35ae2a8a32cf903b39/src/lightning/pytorch/trainer/connectors/checkpoint_connector.py#L363) key `optimizer_states` to be contained in the checkpoint. This PR adds a dummy key to the saved ckpt to bypass the check. We use the key `optimizer` to save the optimizer's state. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10378/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10378/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10377
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10377/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10377/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10377/events
https://github.com/NVIDIA/NeMo/pull/10377
2,511,124,859
PR_kwDOC_bI7s56tCEc
10,377
Fix partial audio transcription
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "reopening another PR" ]
2024-09-06T20:09:47
2024-09-06T20:20:47
2024-09-06T20:18:20
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10377", "html_url": "https://github.com/NVIDIA/NeMo/pull/10377", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10377.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10377.patch", "merged_at": null }
# What does this PR do ? Temp fix. Removes reording for partial audio, as it was not enabled for it. But need to understand why presorting of manifest is only enabled for EncDecMultiTask @pzelasko **Collection**: ASR # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```bash python transcribe_speech.py model_path=<.nemo file> dataset_manifest=<manifest_file> allow_partial_transcribe=True ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10377/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10377/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10376
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10376/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10376/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10376/events
https://github.com/NVIDIA/NeMo/pull/10376
2,511,064,407
PR_kwDOC_bI7s56s0yo
10,376
[NeMo-UX] Checkpointing fixes
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "FYI discussed with @ashors1 offline that this PR might land in 24.09 via cherry-pick. It's definitely the type and size of a fix, so given that our merge-queue is quite chunked up right now it's unclear whether this PR can land in `main` before the cut-off. If not, it can definitely get cherry-picked afterwards" ]
2024-09-06T19:22:56
2024-09-07T16:38:39
2024-09-07T16:38:38
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10376", "html_url": "https://github.com/NVIDIA/NeMo/pull/10376", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10376.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10376.patch", "merged_at": "2024-09-07T16:38:38" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10376/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10376/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10375
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10375/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10375/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10375/events
https://github.com/NVIDIA/NeMo/pull/10375
2,510,991,187
PR_kwDOC_bI7s56sksB
10,375
Add nemo2 conversion scripts for export
{ "login": "meatybobby", "id": 9738259, "node_id": "MDQ6VXNlcjk3MzgyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meatybobby", "html_url": "https://github.com/meatybobby", "followers_url": "https://api.github.com/users/meatybobby/followers", "following_url": "https://api.github.com/users/meatybobby/following{/other_user}", "gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}", "starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions", "organizations_url": "https://api.github.com/users/meatybobby/orgs", "repos_url": "https://api.github.com/users/meatybobby/repos", "events_url": "https://api.github.com/users/meatybobby/events{/privacy}", "received_events_url": "https://api.github.com/users/meatybobby/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "meatybobby", "id": 9738259, "node_id": "MDQ6VXNlcjk3MzgyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meatybobby", "html_url": "https://github.com/meatybobby", "followers_url": "https://api.github.com/users/meatybobby/followers", "following_url": "https://api.github.com/users/meatybobby/following{/other_user}", "gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}", "starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions", "organizations_url": "https://api.github.com/users/meatybobby/orgs", "repos_url": "https://api.github.com/users/meatybobby/repos", "events_url": "https://api.github.com/users/meatybobby/events{/privacy}", "received_events_url": "https://api.github.com/users/meatybobby/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "meatybobby", "id": 9738259, "node_id": "MDQ6VXNlcjk3MzgyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meatybobby", "html_url": "https://github.com/meatybobby", "followers_url": "https://api.github.com/users/meatybobby/followers", "following_url": "https://api.github.com/users/meatybobby/following{/other_user}", "gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}", "starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions", "organizations_url": "https://api.github.com/users/meatybobby/orgs", "repos_url": "https://api.github.com/users/meatybobby/repos", "events_url": "https://api.github.com/users/meatybobby/events{/privacy}", "received_events_url": "https://api.github.com/users/meatybobby/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "Let's add some docs and ci test then we can merge.", "If possible we'd like to keep the number of scripts to a minimum and instead add things like this to our CLI. You can look at [api.py](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/llm/api.py) as examples for things like train, finetune, etc. There are some usage docs [here](https://github.com/NVIDIA/NeMo/tree/main/examples/llm/pretrain). We have some docs around creating CLI-entrypoints [here](https://github.com/NVIDIA/NeMo-Run/tree/main/examples/entrypoint).", "This is a temporary solution for exporting nemo2 ckpt. Eventually we will integrate this into megatron, so we won't add this into api.", "This script has been tested by llama3-8b nemo2 checkpoint." ]
2024-09-06T18:32:49
2024-09-17T17:37:19
2024-09-17T17:37:17
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10375", "html_url": "https://github.com/NVIDIA/NeMo/pull/10375", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10375.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10375.patch", "merged_at": "2024-09-17T17:37:17" }
# What does this PR do ? Add nemo2 conversion scripts for export **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "meatybobby", "id": 9738259, "node_id": "MDQ6VXNlcjk3MzgyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meatybobby", "html_url": "https://github.com/meatybobby", "followers_url": "https://api.github.com/users/meatybobby/followers", "following_url": "https://api.github.com/users/meatybobby/following{/other_user}", "gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}", "starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions", "organizations_url": "https://api.github.com/users/meatybobby/orgs", "repos_url": "https://api.github.com/users/meatybobby/repos", "events_url": "https://api.github.com/users/meatybobby/events{/privacy}", "received_events_url": "https://api.github.com/users/meatybobby/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10375/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10375/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10374
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10374/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10374/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10374/events
https://github.com/NVIDIA/NeMo/pull/10374
2,510,989,414
PR_kwDOC_bI7s56skTW
10,374
Remove factory from llm.utils
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "Depends on #10300 ", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-09-06T18:31:29
2024-10-16T01:59:35
2024-10-16T01:59:34
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10374", "html_url": "https://github.com/NVIDIA/NeMo/pull/10374", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10374.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10374.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10374/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10374/timeline
null
null
true