url
stringlengths
52
53
repository_url
stringclasses
1 value
labels_url
stringlengths
66
67
comments_url
stringlengths
61
62
events_url
stringlengths
59
60
html_url
stringlengths
40
43
id
int64
719M
2.8B
node_id
stringlengths
18
32
number
int64
1.28k
11.9k
title
stringlengths
1
350
user
dict
labels
listlengths
0
10
state
stringclasses
2 values
locked
bool
2 classes
assignee
dict
assignees
listlengths
0
3
milestone
null
comments
sequencelengths
0
30
created_at
timestamp[s]
updated_at
timestamp[s]
closed_at
timestamp[s]
author_association
stringclasses
4 values
sub_issues_summary
dict
active_lock_reason
stringclasses
1 value
draft
bool
2 classes
pull_request
dict
body
stringlengths
0
73.4k
closed_by
dict
reactions
dict
timeline_url
stringlengths
61
62
performed_via_github_app
null
state_reason
stringclasses
3 values
is_pull_request
bool
2 classes
https://api.github.com/repos/NVIDIA/NeMo/issues/10271
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10271/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10271/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10271/events
https://github.com/NVIDIA/NeMo/pull/10271
2,489,795,989
PR_kwDOC_bI7s55mNTx
10,271
Memory saving for Dropout in LoRA adapters via thunder jit compilation
{ "login": "guyueh1", "id": 140554423, "node_id": "U_kgDOCGCwtw", "avatar_url": "https://avatars.githubusercontent.com/u/140554423?v=4", "gravatar_id": "", "url": "https://api.github.com/users/guyueh1", "html_url": "https://github.com/guyueh1", "followers_url": "https://api.github.com/users/guyueh1/followers", "following_url": "https://api.github.com/users/guyueh1/following{/other_user}", "gists_url": "https://api.github.com/users/guyueh1/gists{/gist_id}", "starred_url": "https://api.github.com/users/guyueh1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guyueh1/subscriptions", "organizations_url": "https://api.github.com/users/guyueh1/orgs", "repos_url": "https://api.github.com/users/guyueh1/repos", "events_url": "https://api.github.com/users/guyueh1/events{/privacy}", "received_events_url": "https://api.github.com/users/guyueh1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-08-27T16:01:11
2024-09-19T01:57:13
2024-09-19T01:57:12
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10271", "html_url": "https://github.com/NVIDIA/NeMo/pull/10271", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10271.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10271.patch", "merged_at": null }
# What does this PR do ? **Making it a option to use thunder to jit-compile the dropout in LoRA adapters; thunder can reduce the memory footprint of this layer by recomputing the dropout mask in backprop.** **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10271/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10271/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10270
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10270/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10270/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10270/events
https://github.com/NVIDIA/NeMo/pull/10270
2,489,318,679
PR_kwDOC_bI7s55kkc-
10,270
add auto configurator to NeMo
{ "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1719393562, "node_id": "MDU6TGFiZWwxNzE5MzkzNTYy", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature", "name": "feature", "color": "68F3F0", "default": false, "description": "request/PR for a new feature" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-08-27T13:08:46
2024-09-07T21:10:17
2024-09-07T21:10:15
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10270", "html_url": "https://github.com/NVIDIA/NeMo/pull/10270", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10270.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10270.patch", "merged_at": "2024-09-07T21:10:15" }
# What does this PR do ? Adds Auto Configurator to NeMo github (based on NeMo 2,0) **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10270/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10270/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10268
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10268/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10268/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10268/events
https://github.com/NVIDIA/NeMo/issues/10268
2,488,931,802
I_kwDOC_bI7s6UWhXa
10,268
Converting Script for Mamba2 Hybrid to HF/Pytorch
{ "login": "SkanderBS2024", "id": 174276700, "node_id": "U_kgDOCmNAXA", "avatar_url": "https://avatars.githubusercontent.com/u/174276700?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SkanderBS2024", "html_url": "https://github.com/SkanderBS2024", "followers_url": "https://api.github.com/users/SkanderBS2024/followers", "following_url": "https://api.github.com/users/SkanderBS2024/following{/other_user}", "gists_url": "https://api.github.com/users/SkanderBS2024/gists{/gist_id}", "starred_url": "https://api.github.com/users/SkanderBS2024/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SkanderBS2024/subscriptions", "organizations_url": "https://api.github.com/users/SkanderBS2024/orgs", "repos_url": "https://api.github.com/users/SkanderBS2024/repos", "events_url": "https://api.github.com/users/SkanderBS2024/events{/privacy}", "received_events_url": "https://api.github.com/users/SkanderBS2024/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-08-27T10:28:49
2024-10-04T01:58:55
2024-10-04T01:58:54
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Is your feature request related to a problem? Please describe.** When fine-tuning for a mamba2 hybrid model we can convert it to a .nemo format but we cannot convert back to HF/Pytorch. **Describe the solution you'd like** Converting script for a nemo mamba2 Hybrid model to HF / Pytorch format. **Describe alternatives you've considered** -None **Additional context** -None
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10268/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10268/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10267
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10267/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10267/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10267/events
https://github.com/NVIDIA/NeMo/pull/10267
2,488,839,519
PR_kwDOC_bI7s55i8Ke
10,267
Load model in the target export precision by default in PTQ
{ "login": "janekl", "id": 5582967, "node_id": "MDQ6VXNlcjU1ODI5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janekl", "html_url": "https://github.com/janekl", "followers_url": "https://api.github.com/users/janekl/followers", "following_url": "https://api.github.com/users/janekl/following{/other_user}", "gists_url": "https://api.github.com/users/janekl/gists{/gist_id}", "starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janekl/subscriptions", "organizations_url": "https://api.github.com/users/janekl/orgs", "repos_url": "https://api.github.com/users/janekl/repos", "events_url": "https://api.github.com/users/janekl/events{/privacy}", "received_events_url": "https://api.github.com/users/janekl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-27T09:51:40
2024-08-27T14:31:20
2024-08-27T14:31:18
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10267", "html_url": "https://github.com/NVIDIA/NeMo/pull/10267", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10267.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10267.patch", "merged_at": "2024-08-27T14:31:18" }
# What does this PR do ? Configuring PTQ to use the same precision to load a model as `export.dtype` by default. This is to avoid possible OOM errors when casting weights on the model export step. This is for use cases with less device memory available, for example, PTQ for Llama3-8b on L4 24GB GPU. **Collection**: NLP # Changelog - Add specific line by line info of high level changes in this PR. # Usage * In order to use FP16 / BF16 weights precision enabling `model.megatron_amp_O2` is necessary * Disabling `model.dist_ckpt_load_on_device` avoid GPU memory spikes on model loading * Using a lower `inference.batch_size` (compared to default 64) might also be needed. Example PTQ command is: ``` python megatron_gpt_ptq.py \ model.restore_from_path=Llama3-8b \ +model.dist_ckpt_load_on_device=false \ export.dtype=bf16 \ inference.batch_size=16 ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [x] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to https://github.com/NVIDIA/NeMo/issues/9981
{ "login": "oyilmaz-nvidia", "id": 35306097, "node_id": "MDQ6VXNlcjM1MzA2MDk3", "avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oyilmaz-nvidia", "html_url": "https://github.com/oyilmaz-nvidia", "followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers", "following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}", "gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions", "organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs", "repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos", "events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10267/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10267/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10266
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10266/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10266/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10266/events
https://github.com/NVIDIA/NeMo/pull/10266
2,488,013,991
PR_kwDOC_bI7s55gIUw
10,266
Bump `Dockerfile.ci` (2024-08-27)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-27T00:20:24
2024-08-27T05:45:50
2024-08-27T05:45:49
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10266", "html_url": "https://github.com/NVIDIA/NeMo/pull/10266", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10266.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10266.patch", "merged_at": "2024-08-27T05:45:49" }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10266/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10266/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10265
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10265/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10265/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10265/events
https://github.com/NVIDIA/NeMo/pull/10265
2,487,986,708
PR_kwDOC_bI7s55gCd6
10,265
Do not overwrite wandb name in NeMo Logger
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-26T23:53:42
2024-08-28T19:55:14
2024-08-28T19:55:12
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10265", "html_url": "https://github.com/NVIDIA/NeMo/pull/10265", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10265.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10265.patch", "merged_at": "2024-08-28T19:55:12" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10265/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10265/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10264
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10264/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10264/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10264/events
https://github.com/NVIDIA/NeMo/issues/10264
2,487,971,701
I_kwDOC_bI7s6US291
10,264
Converting HF model to Nemo gets an error
{ "login": "PurvangL", "id": 104454645, "node_id": "U_kgDOBjnZ9Q", "avatar_url": "https://avatars.githubusercontent.com/u/104454645?v=4", "gravatar_id": "", "url": "https://api.github.com/users/PurvangL", "html_url": "https://github.com/PurvangL", "followers_url": "https://api.github.com/users/PurvangL/followers", "following_url": "https://api.github.com/users/PurvangL/following{/other_user}", "gists_url": "https://api.github.com/users/PurvangL/gists{/gist_id}", "starred_url": "https://api.github.com/users/PurvangL/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/PurvangL/subscriptions", "organizations_url": "https://api.github.com/users/PurvangL/orgs", "repos_url": "https://api.github.com/users/PurvangL/repos", "events_url": "https://api.github.com/users/PurvangL/events{/privacy}", "received_events_url": "https://api.github.com/users/PurvangL/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "Following up regarding issue. Please let me know if any more information is needed.", "According to this [HF implementation](https://github.com/huggingface/transformers/blob/v4.44.2/src/transformers/models/opt/modeling_opt.py):\n* `project_out` should be the final output layer, so it should be mapped to `model.output_layer.weight`\n* `project_in` seems to be a linear layer projecting from embedding dim down to hidden size. Not sure if NeMo supports it.", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "@qijiaxing \nisn't the 'lm_head.weight' key should be mapped to model.output_layer.weight?\nTo give more understanding, I mapped lm_head.weight to model.output_layer.weight, which seems to be working fine. \nnow I am left with mapping\nHF keys : ['model.decoder.project_out.weight', 'model.decoder.project_in.weight'] to\nNemo Keys.\n\nSurprising it complains ['model.decoder.final_layernorm.weight', 'model.decoder.final_layernorm.bias'] from Nemo side, even though I made sure it doesn't include final layer norm explicitly.\n\nPlease let me know if needed any more explaination.", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-08-26T23:37:29
2024-11-15T02:02:42
2024-11-15T02:02:41
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** I am trying to convert the [OPT-350m](https://huggingface.co/facebook/opt-350m) hugging face model to Nemo format. How can I map the following keys? ``` - model.decoder.project_out.weight - model.decoder.project_in.weight ``` for other weight names, I can successfully map to Nemo format. A clear and concise description of what the bug is. **Steps/Code to reproduce bug** Please list *minimal* steps or code snippet for us to be able to reproduce the bug. A helpful guide on on how to craft a minimal bug report http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports. **Expected behavior** A clear and concise description of what you expected to happen. **Environment overview (please complete the following information)** - Environment location: [Bare-metal, Docker, Cloud(specify cloud provider - AWS, Azure, GCP, Collab)] Docker - Method of NeMo install: [pip install or from source]. Please specify exact commands you used to install. nemo:24.03.01.framework - If method of install is [Docker], provide `docker pull` & `docker run` commands used **Environment details** If NVIDIA docker image is used you don't need to specify these. Otherwise, please provide: - OS version : Ubuntu 20.04 - PyTorch version : nemo:24.03.01.framework - Python version : nemo:24.03.01.framework **Additional context** Add any other context about the problem here. Example: GPU model : H100
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10264/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10264/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10263
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10263/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10263/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10263/events
https://github.com/NVIDIA/NeMo/pull/10263
2,487,959,496
PR_kwDOC_bI7s55f8vC
10,263
Adding T5 to NeMo 2.0
{ "login": "huvunvidia", "id": 86480512, "node_id": "MDQ6VXNlcjg2NDgwNTEy", "avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4", "gravatar_id": "", "url": "https://api.github.com/users/huvunvidia", "html_url": "https://github.com/huvunvidia", "followers_url": "https://api.github.com/users/huvunvidia/followers", "following_url": "https://api.github.com/users/huvunvidia/following{/other_user}", "gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions", "organizations_url": "https://api.github.com/users/huvunvidia/orgs", "repos_url": "https://api.github.com/users/huvunvidia/repos", "events_url": "https://api.github.com/users/huvunvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/huvunvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "> There are some unwanted changed in `cicd-main.yml`. Can you please revert these?\r\n\r\nDone.", "Does the commit support the encoder and decoder are put into different devices? Could the encoder and decoder be model parallelized with their own parallism config?" ]
2024-08-26T23:24:17
2024-10-08T03:00:52
2024-09-26T15:17:41
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10263", "html_url": "https://github.com/NVIDIA/NeMo/pull/10263", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10263.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10263.patch", "merged_at": "2024-09-26T15:17:41" }
# What does this PR do ? Adding support for T5 in NeMo 2.0. Main files working on: + T5 specific: - megatron_t5_pretraining.py - pre_training.py (using T5Dataset from mcore) - t5.py + Others: - auto_tokenizer.py: adding inv_vocab() to tokenizer to be compatible with mcore's T5Dataset - lr_scheduler.py: adding missing warmup support **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10263/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10263/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10262
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10262/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10262/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10262/events
https://github.com/NVIDIA/NeMo/pull/10262
2,487,848,371
PR_kwDOC_bI7s55fkxj
10,262
Fix Llama3 and Mixtral Long Context Recipe
{ "login": "BoxiangW", "id": 45734921, "node_id": "MDQ6VXNlcjQ1NzM0OTIx", "avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BoxiangW", "html_url": "https://github.com/BoxiangW", "followers_url": "https://api.github.com/users/BoxiangW/followers", "following_url": "https://api.github.com/users/BoxiangW/following{/other_user}", "gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}", "starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions", "organizations_url": "https://api.github.com/users/BoxiangW/orgs", "repos_url": "https://api.github.com/users/BoxiangW/repos", "events_url": "https://api.github.com/users/BoxiangW/events{/privacy}", "received_events_url": "https://api.github.com/users/BoxiangW/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "BoxiangW", "id": 45734921, "node_id": "MDQ6VXNlcjQ1NzM0OTIx", "avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BoxiangW", "html_url": "https://github.com/BoxiangW", "followers_url": "https://api.github.com/users/BoxiangW/followers", "following_url": "https://api.github.com/users/BoxiangW/following{/other_user}", "gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}", "starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions", "organizations_url": "https://api.github.com/users/BoxiangW/orgs", "repos_url": "https://api.github.com/users/BoxiangW/repos", "events_url": "https://api.github.com/users/BoxiangW/events{/privacy}", "received_events_url": "https://api.github.com/users/BoxiangW/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "BoxiangW", "id": 45734921, "node_id": "MDQ6VXNlcjQ1NzM0OTIx", "avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BoxiangW", "html_url": "https://github.com/BoxiangW", "followers_url": "https://api.github.com/users/BoxiangW/followers", "following_url": "https://api.github.com/users/BoxiangW/following{/other_user}", "gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}", "starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions", "organizations_url": "https://api.github.com/users/BoxiangW/orgs", "repos_url": "https://api.github.com/users/BoxiangW/repos", "events_url": "https://api.github.com/users/BoxiangW/events{/privacy}", "received_events_url": "https://api.github.com/users/BoxiangW/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-08-26T21:51:24
2024-09-04T18:07:44
2024-09-04T17:56:07
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10262", "html_url": "https://github.com/NVIDIA/NeMo/pull/10262", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10262.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10262.patch", "merged_at": "2024-09-04T17:56:07" }
# What does this PR do ? Add Nemoron4 15b and 22b model 8k configs and Long Context Recipes for 16k and 64k along with it. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10262/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10262/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10261
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10261/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10261/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10261/events
https://github.com/NVIDIA/NeMo/pull/10261
2,487,806,688
PR_kwDOC_bI7s55fbes
10,261
Adding a Garbage-collection callback for a synchronized garbage-collection across ALL processes
{ "login": "gautham-kollu", "id": 12534085, "node_id": "MDQ6VXNlcjEyNTM0MDg1", "avatar_url": "https://avatars.githubusercontent.com/u/12534085?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gautham-kollu", "html_url": "https://github.com/gautham-kollu", "followers_url": "https://api.github.com/users/gautham-kollu/followers", "following_url": "https://api.github.com/users/gautham-kollu/following{/other_user}", "gists_url": "https://api.github.com/users/gautham-kollu/gists{/gist_id}", "starred_url": "https://api.github.com/users/gautham-kollu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gautham-kollu/subscriptions", "organizations_url": "https://api.github.com/users/gautham-kollu/orgs", "repos_url": "https://api.github.com/users/gautham-kollu/repos", "events_url": "https://api.github.com/users/gautham-kollu/events{/privacy}", "received_events_url": "https://api.github.com/users/gautham-kollu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "How do we enable the collection callback?", "> How do we enable the collection callback?\r\n\r\nRefer to the usage in the PR description." ]
2024-08-26T21:20:12
2024-08-28T18:34:29
2024-08-28T18:34:28
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10261", "html_url": "https://github.com/NVIDIA/NeMo/pull/10261", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10261.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10261.patch", "merged_at": "2024-08-28T18:34:28" }
# What does this PR do ? Adding a Garbage-collection callback for a synchronized garbage-collection across ALL processes **Collection**: [Note which collection this PR will affect] Potentially affects all of them. # Changelog - Garbage Collection callback for NeMo 2.0 # Usage ``` trainer = nl.Trainer( strategy = strategy, devices=8, num_nodes=1, accelerator='gpu', logger=False, enable_checkpointing=False, use_distributed_sampler=False, #max_epochs=100, max_steps=200, log_every_n_steps=1, val_check_interval=10, limit_val_batches=10, limit_test_batches=200, accumulate_grad_batches=1, gradient_clip_val=1.0, benchmark=False, enable_model_summary=False, limit_train_batches=200, enable_progress_bar=False, num_sanity_val_steps=0, **callbacks = [GarbageCollectionCallback(gc_interval_train=20, gc_interval_val=40)],** plugins=nl.MegatronMixedPrecision(precision='bf16-mixed',) ) ``` # Testing Log excerpt ``` self.communication_handle = torch.distributed._reduce_scatter_base( [NeMo I 2024-08-26 14:07:29 garbage_collection:54] Running garbage collection at train global_step: 20 [NeMo I 2024-08-26 14:07:33 garbage_collection:54] Running garbage collection at train global_step: 40 [NeMo I 2024-08-26 14:07:34 garbage_collection:67] Running garbage collection at validation step: 40 [NeMo I 2024-08-26 14:07:37 garbage_collection:54] Running garbage collection at train global_step: 60 [NeMo I 2024-08-26 14:07:41 garbage_collection:54] Running garbage collection at train global_step: 80 [NeMo I 2024-08-26 14:07:42 garbage_collection:67] Running garbage collection at validation step: 80 [NeMo I 2024-08-26 14:07:45 garbage_collection:54] Running garbage collection at train global_step: 100 [NeMo I 2024-08-26 14:07:48 garbage_collection:54] Running garbage collection at train global_step: 120 [NeMo I 2024-08-26 14:07:49 garbage_collection:67] Running garbage collection at validation step: 120 [NeMo I 2024-08-26 14:07:52 garbage_collection:54] Running garbage collection at train global_step: 140 [NeMo I 2024-08-26 14:07:56 garbage_collection:54] Running garbage collection at train global_step: 160 [NeMo I 2024-08-26 14:07:56 garbage_collection:67] Running garbage collection at validation step: 160 [NeMo I 2024-08-26 14:07:59 garbage_collection:54] Running garbage collection at train global_step: 180 [NeMo I 2024-08-26 14:08:03 garbage_collection:54] Running garbage collection at train global_step: 200 [NeMo I 2024-08-26 14:08:04 garbage_collection:67] Running garbage collection at validation step: 200 `Trainer.fit` stopped: `max_steps=200` reached. ENDING TIMING RUN AT 2024-08-26 02:08:12 PM RESULT,large language model,1,79,root,2024-08-26 02:06:53 PM ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [x] Did you add or update any necessary documentation? - [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [x] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "gautham-kollu", "id": 12534085, "node_id": "MDQ6VXNlcjEyNTM0MDg1", "avatar_url": "https://avatars.githubusercontent.com/u/12534085?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gautham-kollu", "html_url": "https://github.com/gautham-kollu", "followers_url": "https://api.github.com/users/gautham-kollu/followers", "following_url": "https://api.github.com/users/gautham-kollu/following{/other_user}", "gists_url": "https://api.github.com/users/gautham-kollu/gists{/gist_id}", "starred_url": "https://api.github.com/users/gautham-kollu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gautham-kollu/subscriptions", "organizations_url": "https://api.github.com/users/gautham-kollu/orgs", "repos_url": "https://api.github.com/users/gautham-kollu/repos", "events_url": "https://api.github.com/users/gautham-kollu/events{/privacy}", "received_events_url": "https://api.github.com/users/gautham-kollu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10261/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10261/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10260
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10260/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10260/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10260/events
https://github.com/NVIDIA/NeMo/pull/10260
2,487,688,141
PR_kwDOC_bI7s55fA9I
10,260
Add Llama31 Config
{ "login": "suiyoubi", "id": 22045332, "node_id": "MDQ6VXNlcjIyMDQ1MzMy", "avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4", "gravatar_id": "", "url": "https://api.github.com/users/suiyoubi", "html_url": "https://github.com/suiyoubi", "followers_url": "https://api.github.com/users/suiyoubi/followers", "following_url": "https://api.github.com/users/suiyoubi/following{/other_user}", "gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}", "starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions", "organizations_url": "https://api.github.com/users/suiyoubi/orgs", "repos_url": "https://api.github.com/users/suiyoubi/repos", "events_url": "https://api.github.com/users/suiyoubi/events{/privacy}", "received_events_url": "https://api.github.com/users/suiyoubi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-26T20:13:00
2024-08-27T22:41:36
2024-08-27T22:41:35
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10260", "html_url": "https://github.com/NVIDIA/NeMo/pull/10260", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10260.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10260.patch", "merged_at": "2024-08-27T22:41:35" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "suiyoubi", "id": 22045332, "node_id": "MDQ6VXNlcjIyMDQ1MzMy", "avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4", "gravatar_id": "", "url": "https://api.github.com/users/suiyoubi", "html_url": "https://github.com/suiyoubi", "followers_url": "https://api.github.com/users/suiyoubi/followers", "following_url": "https://api.github.com/users/suiyoubi/following{/other_user}", "gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}", "starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions", "organizations_url": "https://api.github.com/users/suiyoubi/orgs", "repos_url": "https://api.github.com/users/suiyoubi/repos", "events_url": "https://api.github.com/users/suiyoubi/events{/privacy}", "received_events_url": "https://api.github.com/users/suiyoubi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10260/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10260/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10259
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10259/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10259/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10259/events
https://github.com/NVIDIA/NeMo/pull/10259
2,487,572,972
PR_kwDOC_bI7s55endG
10,259
[NeMo-UX] Handle absolute logger directories in nemo_logger
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-26T19:11:40
2024-08-27T21:51:21
2024-08-27T21:51:20
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10259", "html_url": "https://github.com/NVIDIA/NeMo/pull/10259", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10259.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10259.patch", "merged_at": "2024-08-27T21:51:20" }
# What does this PR do ? This fixes a bug with nemo_logger that arises when the trainer's `logger.save_dir` is absolute, which happens by default. The fix is to convert the absolute path to a relative one before overwriting the logger directory. **Collection**: LLM # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10259/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10259/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10258
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10258/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10258/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10258/events
https://github.com/NVIDIA/NeMo/pull/10258
2,487,264,007
PR_kwDOC_bI7s55dicR
10,258
Add Qwen2 to Nemo 2
{ "login": "suiyoubi", "id": 22045332, "node_id": "MDQ6VXNlcjIyMDQ1MzMy", "avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4", "gravatar_id": "", "url": "https://api.github.com/users/suiyoubi", "html_url": "https://github.com/suiyoubi", "followers_url": "https://api.github.com/users/suiyoubi/followers", "following_url": "https://api.github.com/users/suiyoubi/following{/other_user}", "gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}", "starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions", "organizations_url": "https://api.github.com/users/suiyoubi/orgs", "repos_url": "https://api.github.com/users/suiyoubi/repos", "events_url": "https://api.github.com/users/suiyoubi/events{/privacy}", "received_events_url": "https://api.github.com/users/suiyoubi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-26T16:30:08
2024-08-27T23:35:14
2024-08-27T23:35:13
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10258", "html_url": "https://github.com/NVIDIA/NeMo/pull/10258", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10258.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10258.patch", "merged_at": "2024-08-27T23:35:13" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10258/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10258/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10257
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10257/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10257/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10257/events
https://github.com/NVIDIA/NeMo/pull/10257
2,487,212,322
PR_kwDOC_bI7s55dW8g
10,257
setting sync_dist to true for validation metrics
{ "login": "krishnacpuvvada", "id": 93558329, "node_id": "U_kgDOBZOWOQ", "avatar_url": "https://avatars.githubusercontent.com/u/93558329?v=4", "gravatar_id": "", "url": "https://api.github.com/users/krishnacpuvvada", "html_url": "https://github.com/krishnacpuvvada", "followers_url": "https://api.github.com/users/krishnacpuvvada/followers", "following_url": "https://api.github.com/users/krishnacpuvvada/following{/other_user}", "gists_url": "https://api.github.com/users/krishnacpuvvada/gists{/gist_id}", "starred_url": "https://api.github.com/users/krishnacpuvvada/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/krishnacpuvvada/subscriptions", "organizations_url": "https://api.github.com/users/krishnacpuvvada/orgs", "repos_url": "https://api.github.com/users/krishnacpuvvada/repos", "events_url": "https://api.github.com/users/krishnacpuvvada/events{/privacy}", "received_events_url": "https://api.github.com/users/krishnacpuvvada/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Looks good. \r\n\r\n> This can cause hands, but for now let's try it.\r\n\r\n@titu1994 can you elaborate? do you expect an uneven number of validation batches per node (why), or something else?", "Yes, the reason to avoid sync is two fold - I think I remember random hangs years ago due to a similar flag, dunno if it's still an issue now. Second one is it causes a global sync across all ranks every single step - which causes a large slowdown once you scale up nodes ", "This is on validation epoch end so only a single sync per validation loop. That should be OK both hang-wise and speed-wise. ", "Makes sense ", "Another note, from my experience, `sync_dist=True` is tricky with parallelisms, especially pipeline parallelisms. If some metrics are non-existent on some ranks (eg val_loss is only on last pp stage, so we have to sync it), this could cause a hang. If the metric is 0.0 on some ranks, the mean reduction over ranks could be wrong or not produce intended value. ", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "@krishnacpuvvada @titu1994 what's the verdict on this one? Do we need a Canary-specific mechanism to synchronize the validation metrics if it can't be done at the modelPT level? ", "(1) Don't push this to modelPT. \r\n(2) If Canary needs it, it can override this function specifically and copy paste the code (for now). \r\n\r\nDo note - @nithinraok plans to remove modelpt level support for multi validation and test data loader, which basically would mean every model has to handle this stuff manually anyway. " ]
2024-08-26T16:04:48
2024-10-22T17:01:14
2024-09-18T01:55:43
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10257", "html_url": "https://github.com/NVIDIA/NeMo/pull/10257", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10257.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10257.patch", "merged_at": null }
# What does this PR do ? setting sync_dist=True for `on_validation_epoch_end` in `ModelPT.py` This is in response to the recent slack discussion on "wiping out of checkpoints mid training and starting from scratch" in Canary training. **Collection**: [all] - The change is in ModelPT.py # Changelog - setting sync_dist=true in `on_validation_epoch_end` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [X] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10257/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10257/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10255
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10255/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10255/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10255/events
https://github.com/NVIDIA/NeMo/pull/10255
2,486,739,257
PR_kwDOC_bI7s55bvPt
10,255
[NeMo-UX[ Move nemotron imports inline
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-26T12:25:45
2024-08-26T16:27:02
2024-08-26T16:27:00
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10255", "html_url": "https://github.com/NVIDIA/NeMo/pull/10255", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10255.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10255.patch", "merged_at": "2024-08-26T16:27:00" }
# What does this PR do ? This PR moves the imports for nemotron of transformers & tokenizer inline. This is needed for pip-installs where we don't want to throw an import error when someone doesn't have transformers installed. # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10255/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10255/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10254
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10254/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10254/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10254/events
https://github.com/NVIDIA/NeMo/issues/10254
2,486,211,280
I_kwDOC_bI7s6UMJLQ
10,254
How to train a spectrol-codec needed for AR TTS model?
{ "login": "JohnHerry", "id": 8011802, "node_id": "MDQ6VXNlcjgwMTE4MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/8011802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JohnHerry", "html_url": "https://github.com/JohnHerry", "followers_url": "https://api.github.com/users/JohnHerry/followers", "following_url": "https://api.github.com/users/JohnHerry/following{/other_user}", "gists_url": "https://api.github.com/users/JohnHerry/gists{/gist_id}", "starred_url": "https://api.github.com/users/JohnHerry/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JohnHerry/subscriptions", "organizations_url": "https://api.github.com/users/JohnHerry/orgs", "repos_url": "https://api.github.com/users/JohnHerry/repos", "events_url": "https://api.github.com/users/JohnHerry/events{/privacy}", "received_events_url": "https://api.github.com/users/JohnHerry/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
{ "login": "rlangman", "id": 9942053, "node_id": "MDQ6VXNlcjk5NDIwNTM=", "avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rlangman", "html_url": "https://github.com/rlangman", "followers_url": "https://api.github.com/users/rlangman/followers", "following_url": "https://api.github.com/users/rlangman/following{/other_user}", "gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}", "starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rlangman/subscriptions", "organizations_url": "https://api.github.com/users/rlangman/orgs", "repos_url": "https://api.github.com/users/rlangman/repos", "events_url": "https://api.github.com/users/rlangman/events{/privacy}", "received_events_url": "https://api.github.com/users/rlangman/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "rlangman", "id": 9942053, "node_id": "MDQ6VXNlcjk5NDIwNTM=", "avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rlangman", "html_url": "https://github.com/rlangman", "followers_url": "https://api.github.com/users/rlangman/followers", "following_url": "https://api.github.com/users/rlangman/following{/other_user}", "gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}", "starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rlangman/subscriptions", "organizations_url": "https://api.github.com/users/rlangman/orgs", "repos_url": "https://api.github.com/users/rlangman/repos", "events_url": "https://api.github.com/users/rlangman/events{/privacy}", "received_events_url": "https://api.github.com/users/rlangman/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, { "login": "anteju", "id": 108555623, "node_id": "U_kgDOBnhtZw", "avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4", "gravatar_id": "", "url": "https://api.github.com/users/anteju", "html_url": "https://github.com/anteju", "followers_url": "https://api.github.com/users/anteju/followers", "following_url": "https://api.github.com/users/anteju/following{/other_user}", "gists_url": "https://api.github.com/users/anteju/gists{/gist_id}", "starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/anteju/subscriptions", "organizations_url": "https://api.github.com/users/anteju/orgs", "repos_url": "https://api.github.com/users/anteju/repos", "events_url": "https://api.github.com/users/anteju/events{/privacy}", "received_events_url": "https://api.github.com/users/anteju/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "Hey, sorry for the slow response. If I understand your question, you can have 1 AR model predict all 8 codebooks at the same time (eg. input the final output of your network into 8 independent softmax functions). You do not need 8 separate AR models.", "> Hey, sorry for the slow response. If I understand your question, you can have 1 AR model predict all 8 codebooks at the same time (eg. input the final output of your network into 8 independent softmax functions). You do not need 8 separate AR models.\n\nYes, We can make a 8 prediction-layer AR model to predict the 8 codes at a single step, but it is not convenient sometimes. Nearly all AR LLM TTS are suffering from some Inherent defects like repetition, deletion, or some other problems on sampling. some work like [VALL-E2](https://arxiv.org/abs/2406.05370) take check on synthensize repetition. When there is only one prediction output sequence, that is feasible, but when there are 8 output sequence, things become trouble some. \nAnd, AR LLM use a special token to label the sequence ends of prediction in one sequence mode. What is the sequence end token when there are 8 output sequence? When all 8 sequence 'next token's are all the 'end token'? or just any of the 8 'next token's is a `sequence end token`?", "We have a few other works (and code/PRs in NeMo) that cover how exactly to do AR LLM TTS with different codecs:\n\n[https://arxiv.org/abs/2406.17957](https://arxiv.org/abs/2406.17957)\n[https://arxiv.org/abs/2409.12117](https://arxiv.org/abs/2409.12117)\n\nTo be clear, there are not 8 output sequences. There is 1 output sequence, where each element in the sequence has 8 values.\n\nSo far as I am aware, every audio codec today has more than 1 codebook/output sequence. What may be confusing is that most LLMs, given an audio codec with N codebooks, typically treat codebook 1 as special and predict it using one inference stream (where they might inject an end of speech token), while predicting codebooks 2 through N using different inference streams. Any algorithm you use with other codecs would work with the spectral codec (or with any of our other audio codecs in NeMo).\n\nThe only difference is that other codecs, which use RVQ codebooks, have the requirement that predicting codebook M at timestep T requires conditioning on the predictions for codebooks 1 through (M - 1). With our FSQ codebooks, you no longer need to condition on codebooks 1 through (M - 1), simplifying the inference.\n\nIn other words, RVQ based codecs typically require up to N inferences per timestep while FSQ codec only requires 1 inference per timestep. Though I guess this does mean where you choose to inject the end of speech token is arbitrary.\n\nDoes that make sense, or am I misunderstanding part of the question?", "Thank you for the kindly help!\nAs I know there are mainly two types AR LLMs for TTS, The first is VALL-E like, which takes many codebooks in codec, and predict only one of them in AR LLM. the VALL-E predict the first codebook sequence with an AR Transformer and the rest code sequences with another NAR transformer model; the second type is TorToise-TTS like, which takes a single-codebook VQVAE codec to code the audio, and a GPT like LLM to predict the single code sequence. What I asked above is based on the second type. The spect-codec equiped AR LLM can make Parallel prediction to all 8 codes in each step VS RVQ-codec codes may be time-dependent, it is really a progress. \nWe do like the single codebook codec in production, not only because of the `end of sequence token` prediction problem, one sequence in, one sequence out, that is the most natural NLP LLM mode, so some experience in NLP can be directly introduced into TTS AR LLM. say, if we want to evaluate the proformance of AR LLM, we can directly use the `top 5 hit-rate`; `top 10 hit-rate` like estimates used in NLP, in the single-codebook TTS AR LLM. but when the output is a sequence that each timestep contains 8 values, things may be different. To make sure equal of all the 8 pair of values from label and prediction is harder, while single-codebook only need to compare a single pair. Intuitively the two AR LLMs are not stands at a fair starting line. Here I only suggested a model estimation problem, I thinks there may be other kinds of things that single-value token sequence works better. \nThere is also some RVQ codec paper argue that we can prefer the codebook of the last layer to train the LLM, because the residual structure helps the last VQ layer learns more while keeps infomation from all former RVQ layers. I am not sure about it. \nsingle-codebook codecs may be too compressed to recover the speech (or spec) signal, Yes, it is really a hard problem. \nThank you for the good job and for your your kindly help." ]
2024-08-26T07:59:58
2024-09-24T02:30:26
2024-09-24T02:30:25
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hi, I have read the paper "[SPECTRAL CODECS: SPECTROGRAM-BASED AUDIO CODECS FOR HIGH QUALITY SPEECH SYNTHESIS](https://arxiv.org/abs/2406.05298)" and the paper take HiFiGAN + FSQ as the mel-spec-codec, it takes 8 codebooks and each with 1000 codebook_size, and I think it can not be directly used as codec in AutoRegressive LLM based TTS, We do not like to make 8 AR models to fit that codec. so is there any imporoved design for AR LLM based TTS? what is the better config?
{ "login": "JohnHerry", "id": 8011802, "node_id": "MDQ6VXNlcjgwMTE4MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/8011802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JohnHerry", "html_url": "https://github.com/JohnHerry", "followers_url": "https://api.github.com/users/JohnHerry/followers", "following_url": "https://api.github.com/users/JohnHerry/following{/other_user}", "gists_url": "https://api.github.com/users/JohnHerry/gists{/gist_id}", "starred_url": "https://api.github.com/users/JohnHerry/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JohnHerry/subscriptions", "organizations_url": "https://api.github.com/users/JohnHerry/orgs", "repos_url": "https://api.github.com/users/JohnHerry/repos", "events_url": "https://api.github.com/users/JohnHerry/events{/privacy}", "received_events_url": "https://api.github.com/users/JohnHerry/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10254/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10254/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10253
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10253/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10253/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10253/events
https://github.com/NVIDIA/NeMo/pull/10253
2,486,051,333
PR_kwDOC_bI7s55ZXW1
10,253
24.07 perf numbers
{ "login": "malay-nagda", "id": 164242706, "node_id": "U_kgDOCcolEg", "avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4", "gravatar_id": "", "url": "https://api.github.com/users/malay-nagda", "html_url": "https://github.com/malay-nagda", "followers_url": "https://api.github.com/users/malay-nagda/followers", "following_url": "https://api.github.com/users/malay-nagda/following{/other_user}", "gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}", "starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions", "organizations_url": "https://api.github.com/users/malay-nagda/orgs", "repos_url": "https://api.github.com/users/malay-nagda/repos", "events_url": "https://api.github.com/users/malay-nagda/events{/privacy}", "received_events_url": "https://api.github.com/users/malay-nagda/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-26T06:37:11
2024-09-09T17:01:02
2024-09-09T17:01:01
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10253", "html_url": "https://github.com/NVIDIA/NeMo/pull/10253", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10253.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10253.patch", "merged_at": "2024-09-09T17:01:01" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [x] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10253/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10253/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10252
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10252/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10252/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10252/events
https://github.com/NVIDIA/NeMo/pull/10252
2,485,858,464
PR_kwDOC_bI7s55YsJg
10,252
Akoumparouli/nemo ux llama sft and peft examples
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-08-26T04:30:21
2024-09-05T07:30:28
2024-09-05T07:30:28
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10252", "html_url": "https://github.com/NVIDIA/NeMo/pull/10252", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10252.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10252.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10252/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10252/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10251
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10251/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10251/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10251/events
https://github.com/NVIDIA/NeMo/pull/10251
2,485,828,276
PR_kwDOC_bI7s55Ylau
10,251
Revert torchrun fix for model import
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-08-26T04:08:11
2024-08-26T07:10:58
2024-08-26T07:10:56
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10251", "html_url": "https://github.com/NVIDIA/NeMo/pull/10251", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10251.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10251.patch", "merged_at": "2024-08-26T07:10:56" }
# What does this PR do ? torchrun fix was broken; when making the model-import trainer, it was using the env-vars. Reverting this as it's breaking other things. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10251/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10251/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10250
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10250/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10250/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10250/events
https://github.com/NVIDIA/NeMo/pull/10250
2,485,562,789
PR_kwDOC_bI7s55XrWC
10,250
Bump `Dockerfile.ci` (2024-08-26)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-26T00:20:28
2024-08-27T03:45:57
2024-08-27T03:45:55
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10250", "html_url": "https://github.com/NVIDIA/NeMo/pull/10250", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10250.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10250.patch", "merged_at": "2024-08-27T03:45:55" }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10250/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10250/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10249
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10249/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10249/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10249/events
https://github.com/NVIDIA/NeMo/pull/10249
2,484,948,653
PR_kwDOC_bI7s55V0t3
10,249
Bump `Dockerfile.ci` (2024-08-25)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-25T00:22:13
2024-08-26T22:15:29
2024-08-26T22:15:29
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10249", "html_url": "https://github.com/NVIDIA/NeMo/pull/10249", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10249.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10249.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10249/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10249/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10247
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10247/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10247/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10247/events
https://github.com/NVIDIA/NeMo/issues/10247
2,484,571,057
I_kwDOC_bI7s6UF4ux
10,247
ASR models with transcription steering prompt (canary, parakeet)
{ "login": "kunibald413", "id": 142683794, "node_id": "U_kgDOCIEukg", "avatar_url": "https://avatars.githubusercontent.com/u/142683794?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kunibald413", "html_url": "https://github.com/kunibald413", "followers_url": "https://api.github.com/users/kunibald413/followers", "following_url": "https://api.github.com/users/kunibald413/following{/other_user}", "gists_url": "https://api.github.com/users/kunibald413/gists{/gist_id}", "starred_url": "https://api.github.com/users/kunibald413/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kunibald413/subscriptions", "organizations_url": "https://api.github.com/users/kunibald413/orgs", "repos_url": "https://api.github.com/users/kunibald413/repos", "events_url": "https://api.github.com/users/kunibald413/events{/privacy}", "received_events_url": "https://api.github.com/users/kunibald413/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1719393562, "node_id": "MDU6TGFiZWwxNzE5MzkzNTYy", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature", "name": "feature", "color": "68F3F0", "default": false, "description": "request/PR for a new feature" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]
closed
false
{ "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "Thanks for the request. We don't offer exact functionality now. However you could use [this script ](https://github.com/NVIDIA/NeMo/blob/main/scripts/asr_context_biasing/eval_greedy_decoding_with_context_biasing.py)for CTC or hybrid RNNT-CTC models to boost such words while transcribing. " ]
2024-08-24T12:57:05
2024-09-24T17:16:30
2024-09-24T17:16:30
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Is your feature request related to a problem? Please describe.** is there a way for the canary and parakeet models (https://huggingface.co/nvidia/canary-1b) to steer transcription like whisper in order to have correct name spellings for example or adapt a certain style? goal is to have better, more accurate subtitles **Describe the solution you'd like** pass string to the inference methods for these models to have more accurate resulting transcriptions. for example to fix spelling of names or titles **additional context** see whisper prompting here https://cookbook.openai.com/examples/whisper_prompting_guide
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10247/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10247/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10246
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10246/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10246/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10246/events
https://github.com/NVIDIA/NeMo/issues/10246
2,484,545,411
I_kwDOC_bI7s6UFyeD
10,246
`speech_to_text_aed_chunked_infer.py` throws `TypeError: 'TranscriptionConfig' object is not iterable`
{ "login": "kunibald413", "id": 142683794, "node_id": "U_kgDOCIEukg", "avatar_url": "https://avatars.githubusercontent.com/u/142683794?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kunibald413", "html_url": "https://github.com/kunibald413", "followers_url": "https://api.github.com/users/kunibald413/followers", "following_url": "https://api.github.com/users/kunibald413/following{/other_user}", "gists_url": "https://api.github.com/users/kunibald413/gists{/gist_id}", "starred_url": "https://api.github.com/users/kunibald413/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kunibald413/subscriptions", "organizations_url": "https://api.github.com/users/kunibald413/orgs", "repos_url": "https://api.github.com/users/kunibald413/repos", "events_url": "https://api.github.com/users/kunibald413/events{/privacy}", "received_events_url": "https://api.github.com/users/kunibald413/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "stevehuang52", "id": 105218074, "node_id": "U_kgDOBkWAGg", "avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevehuang52", "html_url": "https://github.com/stevehuang52", "followers_url": "https://api.github.com/users/stevehuang52/followers", "following_url": "https://api.github.com/users/stevehuang52/following{/other_user}", "gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions", "organizations_url": "https://api.github.com/users/stevehuang52/orgs", "repos_url": "https://api.github.com/users/stevehuang52/repos", "events_url": "https://api.github.com/users/stevehuang52/events{/privacy}", "received_events_url": "https://api.github.com/users/stevehuang52/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "stevehuang52", "id": 105218074, "node_id": "U_kgDOBkWAGg", "avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevehuang52", "html_url": "https://github.com/stevehuang52", "followers_url": "https://api.github.com/users/stevehuang52/followers", "following_url": "https://api.github.com/users/stevehuang52/following{/other_user}", "gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions", "organizations_url": "https://api.github.com/users/stevehuang52/orgs", "repos_url": "https://api.github.com/users/stevehuang52/repos", "events_url": "https://api.github.com/users/stevehuang52/events{/privacy}", "received_events_url": "https://api.github.com/users/stevehuang52/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "@stevehuang52 pls have a look at this. ", "Thanks for pointing out the issue, it will be fixed in https://github.com/NVIDIA/NeMo/pull/10581", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-08-24T12:13:07
2024-10-31T02:00:06
2024-10-31T02:00:06
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** canary model chunked infer with `speech_to_text_aed_chunked_infer.py` throws this error: `TypeError: 'TranscriptionConfig' object is not iterable` **Steps/Code to reproduce bug** run this `main` function: https://github.com/NVIDIA/NeMo/blob/7cc99e95fa753f46dffffc47a19e3c1fa375159c/examples/asr/asr_chunked_inference/aed/speech_to_text_aed_chunked_infer.py#L118 throws at this line https://github.com/NVIDIA/NeMo/blob/7cc99e95fa753f46dffffc47a19e3c1fa375159c/examples/asr/asr_chunked_inference/aed/speech_to_text_aed_chunked_infer.py#L122 **misc** might be legacy code? might be that it will also throw here: https://github.com/NVIDIA/NeMo/blob/7cc99e95fa753f46dffffc47a19e3c1fa375159c/examples/asr/asr_chunked_inference/rnnt/speech_to_text_buffered_infer_rnnt.py#L149
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10246/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10246/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10245
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10245/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10245/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10245/events
https://github.com/NVIDIA/NeMo/pull/10245
2,484,443,778
PR_kwDOC_bI7s55UKiV
10,245
salm export trtllm
{ "login": "Slyne", "id": 6286804, "node_id": "MDQ6VXNlcjYyODY4MDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/6286804?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Slyne", "html_url": "https://github.com/Slyne", "followers_url": "https://api.github.com/users/Slyne/followers", "following_url": "https://api.github.com/users/Slyne/following{/other_user}", "gists_url": "https://api.github.com/users/Slyne/gists{/gist_id}", "starred_url": "https://api.github.com/users/Slyne/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Slyne/subscriptions", "organizations_url": "https://api.github.com/users/Slyne/orgs", "repos_url": "https://api.github.com/users/Slyne/repos", "events_url": "https://api.github.com/users/Slyne/events{/privacy}", "received_events_url": "https://api.github.com/users/Slyne/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "@meatybobby " ]
2024-08-24T09:43:05
2024-08-26T23:35:43
2024-08-26T23:35:43
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10245", "html_url": "https://github.com/NVIDIA/NeMo/pull/10245", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10245.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10245.patch", "merged_at": "2024-08-26T23:35:42" }
# What does this PR do ? Add SALM export **Collection**: [NA] (nemo multimodal export) # Changelog - Add specific line by line info of high level changes in this PR. # Usage Run export: Please refer to `https://github.com/Slyne/NeMo/blob/salm_trtllm_llm/examples/multimodal/speech_llm/export/README.md` Run deploy: ```bash python3 NeMo/scripts/deploy/multimodal/deploy_triton.py \ --modality="audio" \ --visual_checkpoint=NeMo/examples/multimodal/speech_llm/export/output/speechllm_fc_llama2_7b_perception \ --llm_checkpoint=NeMo/examples/multimodal/speech_llm/export/speechllm_fc_llama2_7b_llm_merged.nemo \ --llm_model_type="llama" \ --model_type="salm" \ --triton_model_name="salm" \ --max_input_len=4096 \ --max_output_len=256 \ --max_multimodal_len=3072 \ --triton_model_repository=/tmp/trt_model_dir/ ``` Run query: ``` python3 NeMo/scripts/deploy/multimodal/query.py \ --model_name="salm" \ --model_type="salm" \ --input_text="Q: what's the transcription of the audio? A:" \ --input_media=/ws/data/test-clean-processed/7729-102255-0009.wav ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [x] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [x] Documentation If you haven't finished some of the above items you can still open "Draft" PR.
{ "login": "meatybobby", "id": 9738259, "node_id": "MDQ6VXNlcjk3MzgyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meatybobby", "html_url": "https://github.com/meatybobby", "followers_url": "https://api.github.com/users/meatybobby/followers", "following_url": "https://api.github.com/users/meatybobby/following{/other_user}", "gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}", "starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions", "organizations_url": "https://api.github.com/users/meatybobby/orgs", "repos_url": "https://api.github.com/users/meatybobby/repos", "events_url": "https://api.github.com/users/meatybobby/events{/privacy}", "received_events_url": "https://api.github.com/users/meatybobby/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10245/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10245/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10244
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10244/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10244/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10244/events
https://github.com/NVIDIA/NeMo/pull/10244
2,484,070,559
PR_kwDOC_bI7s55S9b7
10,244
Log Gradient Norms
{ "login": "maanug-nv", "id": 109391026, "node_id": "U_kgDOBoUssg", "avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maanug-nv", "html_url": "https://github.com/maanug-nv", "followers_url": "https://api.github.com/users/maanug-nv/followers", "following_url": "https://api.github.com/users/maanug-nv/following{/other_user}", "gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}", "starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions", "organizations_url": "https://api.github.com/users/maanug-nv/orgs", "repos_url": "https://api.github.com/users/maanug-nv/repos", "events_url": "https://api.github.com/users/maanug-nv/events{/privacy}", "received_events_url": "https://api.github.com/users/maanug-nv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-24T00:24:54
2024-08-30T07:07:18
2024-08-30T07:07:16
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10244", "html_url": "https://github.com/NVIDIA/NeMo/pull/10244", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10244.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10244.patch", "merged_at": "2024-08-30T07:07:16" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10244/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10244/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10243
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10243/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10243/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10243/events
https://github.com/NVIDIA/NeMo/pull/10243
2,484,067,812
PR_kwDOC_bI7s55S825
10,243
Bump `Dockerfile.ci` (2024-08-24)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-24T00:19:19
2024-08-26T22:15:19
2024-08-26T22:15:19
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10243", "html_url": "https://github.com/NVIDIA/NeMo/pull/10243", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10243.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10243.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10243/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10243/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10242
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10242/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10242/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10242/events
https://github.com/NVIDIA/NeMo/pull/10242
2,483,849,961
PR_kwDOC_bI7s55SO_m
10,242
[NeMo-UX] Don't create attention mask for GPTs
{ "login": "JimmyZhang12", "id": 67203904, "node_id": "MDQ6VXNlcjY3MjAzOTA0", "avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JimmyZhang12", "html_url": "https://github.com/JimmyZhang12", "followers_url": "https://api.github.com/users/JimmyZhang12/followers", "following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}", "gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}", "starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions", "organizations_url": "https://api.github.com/users/JimmyZhang12/orgs", "repos_url": "https://api.github.com/users/JimmyZhang12/repos", "events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}", "received_events_url": "https://api.github.com/users/JimmyZhang12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "JimmyZhang12", "id": 67203904, "node_id": "MDQ6VXNlcjY3MjAzOTA0", "avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JimmyZhang12", "html_url": "https://github.com/JimmyZhang12", "followers_url": "https://api.github.com/users/JimmyZhang12/followers", "following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}", "gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}", "starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions", "organizations_url": "https://api.github.com/users/JimmyZhang12/orgs", "repos_url": "https://api.github.com/users/JimmyZhang12/repos", "events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}", "received_events_url": "https://api.github.com/users/JimmyZhang12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "JimmyZhang12", "id": 67203904, "node_id": "MDQ6VXNlcjY3MjAzOTA0", "avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JimmyZhang12", "html_url": "https://github.com/JimmyZhang12", "followers_url": "https://api.github.com/users/JimmyZhang12/followers", "following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}", "gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}", "starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions", "organizations_url": "https://api.github.com/users/JimmyZhang12/orgs", "repos_url": "https://api.github.com/users/JimmyZhang12/repos", "events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}", "received_events_url": "https://api.github.com/users/JimmyZhang12/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-08-23T20:34:14
2024-08-30T23:04:41
2024-08-30T23:04:40
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10242", "html_url": "https://github.com/NVIDIA/NeMo/pull/10242", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10242.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10242.patch", "merged_at": "2024-08-30T23:04:40" }
# What does this PR do ? For flash and fused attention kernels, the attention mask is implicitly generated by the kernel, so no need to generate the mask from the dataloader. This saves memory, especially for causal masks of long sequence lengths. Flash attention and fused attention are well supported and should cover all the models supported by NeMo, and are already turned on by default, so turning this on by default as well. This also removes a HtoD at the start of the first layer, since the attention mask is on CPU for GPTDataset. This gives a ~5% speedup on the first pipeline parallel stage: ![image](https://github.com/user-attachments/assets/fd239482-deb9-4d3c-a8e5-b9796e4ce581) Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ShriyaPalsamudram", "id": 69161273, "node_id": "MDQ6VXNlcjY5MTYxMjcz", "avatar_url": "https://avatars.githubusercontent.com/u/69161273?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ShriyaPalsamudram", "html_url": "https://github.com/ShriyaPalsamudram", "followers_url": "https://api.github.com/users/ShriyaPalsamudram/followers", "following_url": "https://api.github.com/users/ShriyaPalsamudram/following{/other_user}", "gists_url": "https://api.github.com/users/ShriyaPalsamudram/gists{/gist_id}", "starred_url": "https://api.github.com/users/ShriyaPalsamudram/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ShriyaPalsamudram/subscriptions", "organizations_url": "https://api.github.com/users/ShriyaPalsamudram/orgs", "repos_url": "https://api.github.com/users/ShriyaPalsamudram/repos", "events_url": "https://api.github.com/users/ShriyaPalsamudram/events{/privacy}", "received_events_url": "https://api.github.com/users/ShriyaPalsamudram/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10242/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10242/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10241
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10241/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10241/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10241/events
https://github.com/NVIDIA/NeMo/pull/10241
2,483,627,264
PR_kwDOC_bI7s55Reai
10,241
[NeMo-UX] checkpointing improvements
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-23T18:05:58
2024-09-06T18:01:28
2024-09-06T07:26:10
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10241", "html_url": "https://github.com/NVIDIA/NeMo/pull/10241", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10241.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10241.patch", "merged_at": "2024-09-06T07:26:10" }
# What does this PR do ? - saves weights and artifacts to separate directories - provides the option to skip saving optimizer states on train end Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10241/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10241/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10240
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10240/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10240/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10240/events
https://github.com/NVIDIA/NeMo/pull/10240
2,483,505,297
PR_kwDOC_bI7s55RDcQ
10,240
Lower bound transformers to support Nemotron
{ "login": "thomasdhc", "id": 9426164, "node_id": "MDQ6VXNlcjk0MjYxNjQ=", "avatar_url": "https://avatars.githubusercontent.com/u/9426164?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thomasdhc", "html_url": "https://github.com/thomasdhc", "followers_url": "https://api.github.com/users/thomasdhc/followers", "following_url": "https://api.github.com/users/thomasdhc/following{/other_user}", "gists_url": "https://api.github.com/users/thomasdhc/gists{/gist_id}", "starred_url": "https://api.github.com/users/thomasdhc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thomasdhc/subscriptions", "organizations_url": "https://api.github.com/users/thomasdhc/orgs", "repos_url": "https://api.github.com/users/thomasdhc/repos", "events_url": "https://api.github.com/users/thomasdhc/events{/privacy}", "received_events_url": "https://api.github.com/users/thomasdhc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-23T16:46:12
2024-08-23T18:47:02
2024-08-23T18:47:01
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10240", "html_url": "https://github.com/NVIDIA/NeMo/pull/10240", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10240.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10240.patch", "merged_at": "2024-08-23T18:47:01" }
# What does this PR do ? transformers support Nemotron start 4.44.0 **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "thomasdhc", "id": 9426164, "node_id": "MDQ6VXNlcjk0MjYxNjQ=", "avatar_url": "https://avatars.githubusercontent.com/u/9426164?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thomasdhc", "html_url": "https://github.com/thomasdhc", "followers_url": "https://api.github.com/users/thomasdhc/followers", "following_url": "https://api.github.com/users/thomasdhc/following{/other_user}", "gists_url": "https://api.github.com/users/thomasdhc/gists{/gist_id}", "starred_url": "https://api.github.com/users/thomasdhc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thomasdhc/subscriptions", "organizations_url": "https://api.github.com/users/thomasdhc/orgs", "repos_url": "https://api.github.com/users/thomasdhc/repos", "events_url": "https://api.github.com/users/thomasdhc/events{/privacy}", "received_events_url": "https://api.github.com/users/thomasdhc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10240/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10240/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10239
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10239/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10239/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10239/events
https://github.com/NVIDIA/NeMo/pull/10239
2,483,427,045
PR_kwDOC_bI7s55QyOg
10,239
Abstract IOMixin and ability to mutate init parameters.
{ "login": "jstjohn", "id": 459014, "node_id": "MDQ6VXNlcjQ1OTAxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/459014?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jstjohn", "html_url": "https://github.com/jstjohn", "followers_url": "https://api.github.com/users/jstjohn/followers", "following_url": "https://api.github.com/users/jstjohn/following{/other_user}", "gists_url": "https://api.github.com/users/jstjohn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jstjohn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jstjohn/subscriptions", "organizations_url": "https://api.github.com/users/jstjohn/orgs", "repos_url": "https://api.github.com/users/jstjohn/repos", "events_url": "https://api.github.com/users/jstjohn/events{/privacy}", "received_events_url": "https://api.github.com/users/jstjohn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "jstjohn", "id": 459014, "node_id": "MDQ6VXNlcjQ1OTAxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/459014?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jstjohn", "html_url": "https://github.com/jstjohn", "followers_url": "https://api.github.com/users/jstjohn/followers", "following_url": "https://api.github.com/users/jstjohn/following{/other_user}", "gists_url": "https://api.github.com/users/jstjohn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jstjohn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jstjohn/subscriptions", "organizations_url": "https://api.github.com/users/jstjohn/orgs", "repos_url": "https://api.github.com/users/jstjohn/repos", "events_url": "https://api.github.com/users/jstjohn/events{/privacy}", "received_events_url": "https://api.github.com/users/jstjohn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "jstjohn", "id": 459014, "node_id": "MDQ6VXNlcjQ1OTAxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/459014?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jstjohn", "html_url": "https://github.com/jstjohn", "followers_url": "https://api.github.com/users/jstjohn/followers", "following_url": "https://api.github.com/users/jstjohn/following{/other_user}", "gists_url": "https://api.github.com/users/jstjohn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jstjohn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jstjohn/subscriptions", "organizations_url": "https://api.github.com/users/jstjohn/orgs", "repos_url": "https://api.github.com/users/jstjohn/repos", "events_url": "https://api.github.com/users/jstjohn/events{/privacy}", "received_events_url": "https://api.github.com/users/jstjohn/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "Closing this for now. Sounds like this conflicts with another plan. To summarize that discussion with @marcromeyn:\r\n\r\n1. if I can call a function to get access to old checkpoint settings `old_ckpt = io.load(self.ckpt_init_path).model.checkpoint` which does not impact global state for the current context/run (that's important)\r\n2. Additionally if I can access global state for the checkpoint associated with self to mutate it (along with in parallel mutating self). Maybe something like `setattr(io.ckpt_ctx.trainer.model.checkpoint, key, var)` along with `setattr(self, key, var)` which would happen in parallel in the same way on every execution process.\r\n3. Additionally if I don't touch any parallelism/cluster settings in the checkpoint which would mutate the global environment\r\n\r\nThese features are key in https://github.com/NVIDIA/bionemo-fw-ea/pull/97" ]
2024-08-23T15:53:16
2024-08-31T00:12:11
2024-08-31T00:12:11
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10239", "html_url": "https://github.com/NVIDIA/NeMo/pull/10239", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10239.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10239.patch", "merged_at": null }
# What does this PR do ? Adds two helpful items for working with ABCs that eventually get IOMixin: 1. A parent `NeedsIOMixin` ABC that lets you inform a parent class that it will eventually be an IOMixin, and also catches cases where you use it before subclassing and inheriting from iomixin. This has been useful for making parent config types that children implement and extend. 2. A mutate_hparam function that allows you to change the init args that are saved in an iomixin object. This is useful for users who either want to initialize and lazily load configuration, or change configuration based on some other configuration in a way that you want to have saved for later as modified init args. This gives users a path to change a config object in code and save it, as well as have a config set some of it's parameters based on the contents of another config that it loads from a checkpoint, while also being savable itself into a new checkpoint with those modified parameters. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "jstjohn", "id": 459014, "node_id": "MDQ6VXNlcjQ1OTAxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/459014?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jstjohn", "html_url": "https://github.com/jstjohn", "followers_url": "https://api.github.com/users/jstjohn/followers", "following_url": "https://api.github.com/users/jstjohn/following{/other_user}", "gists_url": "https://api.github.com/users/jstjohn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jstjohn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jstjohn/subscriptions", "organizations_url": "https://api.github.com/users/jstjohn/orgs", "repos_url": "https://api.github.com/users/jstjohn/repos", "events_url": "https://api.github.com/users/jstjohn/events{/privacy}", "received_events_url": "https://api.github.com/users/jstjohn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10239/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10239/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10238
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10238/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10238/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10238/events
https://github.com/NVIDIA/NeMo/pull/10238
2,482,479,004
PR_kwDOC_bI7s55NhMW
10,238
Integrating mcore export
{ "login": "shanmugamr1992", "id": 111910568, "node_id": "U_kgDOBqueqA", "avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shanmugamr1992", "html_url": "https://github.com/shanmugamr1992", "followers_url": "https://api.github.com/users/shanmugamr1992/followers", "following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}", "gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}", "starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions", "organizations_url": "https://api.github.com/users/shanmugamr1992/orgs", "repos_url": "https://api.github.com/users/shanmugamr1992/repos", "events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}", "received_events_url": "https://api.github.com/users/shanmugamr1992/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "jenkins", "jenkins", "jenkins", "We might also want to bump MCore commit [here](https://github.com/NVIDIA/NeMo/blob/5b88aaa82781d32b0e88b2a9b9976c6cf60d9bd2/Dockerfile.ci#L61C15-L61C55) to [45bf4c1821c2a87ca02e8a0377d61097bac92d07 ](https://github.com/NVIDIA/Megatron-LM/commit/45bf4c1821c2a87ca02e8a0377d61097bac92d07) so that it's clear how to use newly integrated code", "[🤖]: Hi @shanmugamr1992 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11075304842) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @shanmugamr1992 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11076645801) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @shanmugamr1992 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11112712532) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @shanmugamr1992 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11112712532) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @shanmugamr1992 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11131756579) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[oyilmaz-nvidia](https://github.com/oyilmaz-nvidia) previously approved these changes [4 days ago](https://github.com/NVIDIA/NeMo/pull/10238#pullrequestreview-2338400329)", "[🤖]: Hi @shanmugamr1992 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/$REPOSITORY/actions/runs/$RUN_ID) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g" ]
2024-08-23T07:13:48
2024-10-17T19:02:55
2024-10-17T19:02:52
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10238", "html_url": "https://github.com/NVIDIA/NeMo/pull/10238", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10238.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10238.patch", "merged_at": "2024-10-17T19:02:52" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "oyilmaz-nvidia", "id": 35306097, "node_id": "MDQ6VXNlcjM1MzA2MDk3", "avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oyilmaz-nvidia", "html_url": "https://github.com/oyilmaz-nvidia", "followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers", "following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}", "gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions", "organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs", "repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos", "events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10238/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10238/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10237
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10237/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10237/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10237/events
https://github.com/NVIDIA/NeMo/pull/10237
2,482,301,776
PR_kwDOC_bI7s55M6ga
10,237
Added offloading support for LoRA adapters
{ "login": "sanandaraj5597", "id": 55270934, "node_id": "MDQ6VXNlcjU1MjcwOTM0", "avatar_url": "https://avatars.githubusercontent.com/u/55270934?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sanandaraj5597", "html_url": "https://github.com/sanandaraj5597", "followers_url": "https://api.github.com/users/sanandaraj5597/followers", "following_url": "https://api.github.com/users/sanandaraj5597/following{/other_user}", "gists_url": "https://api.github.com/users/sanandaraj5597/gists{/gist_id}", "starred_url": "https://api.github.com/users/sanandaraj5597/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sanandaraj5597/subscriptions", "organizations_url": "https://api.github.com/users/sanandaraj5597/orgs", "repos_url": "https://api.github.com/users/sanandaraj5597/repos", "events_url": "https://api.github.com/users/sanandaraj5597/events{/privacy}", "received_events_url": "https://api.github.com/users/sanandaraj5597/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-23T04:48:02
2024-08-27T23:30:11
2024-08-27T23:30:09
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10237", "html_url": "https://github.com/NVIDIA/NeMo/pull/10237", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10237.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10237.patch", "merged_at": "2024-08-27T23:30:09" }
# What does this PR do ? This PR adds support for offloading activations for the ParallelLinearAdapter.
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10237/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10237/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10236
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10236/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10236/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10236/events
https://github.com/NVIDIA/NeMo/pull/10236
2,482,043,657
PR_kwDOC_bI7s55MLGM
10,236
Param and Grad Debug Logger
{ "login": "maanug-nv", "id": 109391026, "node_id": "U_kgDOBoUssg", "avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maanug-nv", "html_url": "https://github.com/maanug-nv", "followers_url": "https://api.github.com/users/maanug-nv/followers", "following_url": "https://api.github.com/users/maanug-nv/following{/other_user}", "gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}", "starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions", "organizations_url": "https://api.github.com/users/maanug-nv/orgs", "repos_url": "https://api.github.com/users/maanug-nv/repos", "events_url": "https://api.github.com/users/maanug-nv/events{/privacy}", "received_events_url": "https://api.github.com/users/maanug-nv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "Add option to assert some value for attributes instead of just logging", "TODO: add some tests on a dummy model with asserts on precision", "Don't we need to enable the megatron_gpt_pretraining test in CI?", "@hemildesai I thought it is already being used in the L2 tests: https://github.com/NVIDIA/NeMo/blob/maanug/param-debugger/.github/workflows/cicd-main.yml#L5142", "> @hemildesai I thought it is already being used in the L2 tests: https://github.com/NVIDIA/NeMo/blob/maanug/param-debugger/.github/workflows/cicd-main.yml#L5142\r\n\r\nAh I see. Sorry my bad.", "[🤖]: Hi @maanug-nv 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11077400886) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @maanug-nv 👋,\n\nWe wanted to let you know that a [CICD pipeline](https://github.com/$REPOSITORY/actions/runs/$RUN_ID) for this PR just finished successfully\n\nSo it might be time to merge this PR or get some approvals\n\nI'm just a bot so I'll leave it you what to do next.\n\n//cc @pablo-garay @ko3n1g" ]
2024-08-23T01:00:14
2024-10-09T11:12:37
2024-10-09T11:12:36
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10236", "html_url": "https://github.com/NVIDIA/NeMo/pull/10236", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10236.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10236.patch", "merged_at": "2024-10-09T11:12:36" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "maanug-nv", "id": 109391026, "node_id": "U_kgDOBoUssg", "avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maanug-nv", "html_url": "https://github.com/maanug-nv", "followers_url": "https://api.github.com/users/maanug-nv/followers", "following_url": "https://api.github.com/users/maanug-nv/following{/other_user}", "gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}", "starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions", "organizations_url": "https://api.github.com/users/maanug-nv/orgs", "repos_url": "https://api.github.com/users/maanug-nv/repos", "events_url": "https://api.github.com/users/maanug-nv/events{/privacy}", "received_events_url": "https://api.github.com/users/maanug-nv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10236/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10236/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10235
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10235/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10235/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10235/events
https://github.com/NVIDIA/NeMo/pull/10235
2,482,012,303
PR_kwDOC_bI7s55MEYa
10,235
Bump `Dockerfile.ci` (2024-08-23)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-23T00:19:51
2024-08-26T22:15:16
2024-08-26T22:15:16
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10235", "html_url": "https://github.com/NVIDIA/NeMo/pull/10235", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10235.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10235.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10235/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10235/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10234
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10234/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10234/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10234/events
https://github.com/NVIDIA/NeMo/pull/10234
2,481,565,837
PR_kwDOC_bI7s55Ko-a
10,234
Move trt imports in nemo.collections.llm inside respective functions
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-22T19:34:42
2024-08-23T03:11:32
2024-08-23T03:11:30
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10234", "html_url": "https://github.com/NVIDIA/NeMo/pull/10234", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10234.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10234.patch", "merged_at": "2024-08-23T03:11:30" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10234/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10234/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10233
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10233/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10233/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10233/events
https://github.com/NVIDIA/NeMo/pull/10233
2,481,448,756
PR_kwDOC_bI7s55KO9x
10,233
mcore distributed optimizer interface
{ "login": "erhoo82", "id": 15861259, "node_id": "MDQ6VXNlcjE1ODYxMjU5", "avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/erhoo82", "html_url": "https://github.com/erhoo82", "followers_url": "https://api.github.com/users/erhoo82/followers", "following_url": "https://api.github.com/users/erhoo82/following{/other_user}", "gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}", "starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions", "organizations_url": "https://api.github.com/users/erhoo82/orgs", "repos_url": "https://api.github.com/users/erhoo82/repos", "events_url": "https://api.github.com/users/erhoo82/events{/privacy}", "received_events_url": "https://api.github.com/users/erhoo82/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-22T18:21:29
2024-09-09T15:43:12
2024-09-09T15:43:12
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10233", "html_url": "https://github.com/NVIDIA/NeMo/pull/10233", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10233.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10233.patch", "merged_at": null }
# What does this PR do ? The interface for megatron core distributed optimizer # Changelog - Support native fp8; fp8-param optimizer - Support the overlap of param allgather with optimizer.step - Support the alignment of param AllGather and grad ReduceScatter # Usage - Set `fp8_params` to enable fp8-param optimizer - Set `optim.overlap_param_gather_with_optimizer_step` to enable the overlap of param AllGather with optim.step - Set `optim align_grad_reduce` and `optim. align_param_gather` to align the data-parallel collectives across pipeline-parallel ranks # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "erhoo82", "id": 15861259, "node_id": "MDQ6VXNlcjE1ODYxMjU5", "avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/erhoo82", "html_url": "https://github.com/erhoo82", "followers_url": "https://api.github.com/users/erhoo82/followers", "following_url": "https://api.github.com/users/erhoo82/following{/other_user}", "gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}", "starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions", "organizations_url": "https://api.github.com/users/erhoo82/orgs", "repos_url": "https://api.github.com/users/erhoo82/repos", "events_url": "https://api.github.com/users/erhoo82/events{/privacy}", "received_events_url": "https://api.github.com/users/erhoo82/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10233/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10233/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10232
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10232/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10232/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10232/events
https://github.com/NVIDIA/NeMo/pull/10232
2,481,403,849
PR_kwDOC_bI7s55KE6k
10,232
refactor: Deprecate `async_grad_allreduce`
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-22T17:57:10
2024-08-28T21:52:15
2024-08-28T21:52:15
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10232", "html_url": "https://github.com/NVIDIA/NeMo/pull/10232", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10232.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10232.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10232/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10232/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10231
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10231/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10231/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10231/events
https://github.com/NVIDIA/NeMo/pull/10231
2,481,333,075
PR_kwDOC_bI7s55J1XH
10,231
McoreDistributedOptimizer wrapper
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-08-22T17:13:44
2024-10-23T01:58:38
2024-10-23T01:58:38
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10231", "html_url": "https://github.com/NVIDIA/NeMo/pull/10231", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10231.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10231.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10231/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10231/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10230
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10230/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10230/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10230/events
https://github.com/NVIDIA/NeMo/pull/10230
2,480,896,561
PR_kwDOC_bI7s55IccG
10,230
Add Starcoder to Nemo 2
{ "login": "suiyoubi", "id": 22045332, "node_id": "MDQ6VXNlcjIyMDQ1MzMy", "avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4", "gravatar_id": "", "url": "https://api.github.com/users/suiyoubi", "html_url": "https://github.com/suiyoubi", "followers_url": "https://api.github.com/users/suiyoubi/followers", "following_url": "https://api.github.com/users/suiyoubi/following{/other_user}", "gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}", "starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions", "organizations_url": "https://api.github.com/users/suiyoubi/orgs", "repos_url": "https://api.github.com/users/suiyoubi/repos", "events_url": "https://api.github.com/users/suiyoubi/events{/privacy}", "received_events_url": "https://api.github.com/users/suiyoubi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-22T14:10:15
2024-08-28T17:04:31
2024-08-28T17:04:29
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10230", "html_url": "https://github.com/NVIDIA/NeMo/pull/10230", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10230.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10230.patch", "merged_at": "2024-08-28T17:04:29" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10230/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10230/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10229
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10229/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10229/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10229/events
https://github.com/NVIDIA/NeMo/issues/10229
2,479,624,642
I_kwDOC_bI7s6TzBHC
10,229
slurm Multi-machine and multi-GPU training
{ "login": "yangzhipeng1108", "id": 33448441, "node_id": "MDQ6VXNlcjMzNDQ4NDQx", "avatar_url": "https://avatars.githubusercontent.com/u/33448441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yangzhipeng1108", "html_url": "https://github.com/yangzhipeng1108", "followers_url": "https://api.github.com/users/yangzhipeng1108/followers", "following_url": "https://api.github.com/users/yangzhipeng1108/following{/other_user}", "gists_url": "https://api.github.com/users/yangzhipeng1108/gists{/gist_id}", "starred_url": "https://api.github.com/users/yangzhipeng1108/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yangzhipeng1108/subscriptions", "organizations_url": "https://api.github.com/users/yangzhipeng1108/orgs", "repos_url": "https://api.github.com/users/yangzhipeng1108/repos", "events_url": "https://api.github.com/users/yangzhipeng1108/events{/privacy}", "received_events_url": "https://api.github.com/users/yangzhipeng1108/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "maanug-nv", "id": 109391026, "node_id": "U_kgDOBoUssg", "avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maanug-nv", "html_url": "https://github.com/maanug-nv", "followers_url": "https://api.github.com/users/maanug-nv/followers", "following_url": "https://api.github.com/users/maanug-nv/following{/other_user}", "gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}", "starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions", "organizations_url": "https://api.github.com/users/maanug-nv/orgs", "repos_url": "https://api.github.com/users/maanug-nv/repos", "events_url": "https://api.github.com/users/maanug-nv/events{/privacy}", "received_events_url": "https://api.github.com/users/maanug-nv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "maanug-nv", "id": 109391026, "node_id": "U_kgDOBoUssg", "avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maanug-nv", "html_url": "https://github.com/maanug-nv", "followers_url": "https://api.github.com/users/maanug-nv/followers", "following_url": "https://api.github.com/users/maanug-nv/following{/other_user}", "gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}", "starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions", "organizations_url": "https://api.github.com/users/maanug-nv/orgs", "repos_url": "https://api.github.com/users/maanug-nv/repos", "events_url": "https://api.github.com/users/maanug-nv/events{/privacy}", "received_events_url": "https://api.github.com/users/maanug-nv/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "Hi @yangzhipeng1108, looking at the error, \r\n\r\n> ```\r\n> 2: File \"/usr/local/lib/python3.10/dist-packages/lightning_fabric/plugins/environments/torchelastic.py\", line 63, in world_size\r\n> 2: return int(os.environ[\"WORLD_SIZE\"])\r\n> 2: File \"/usr/lib/python3.10/os.py\", line 680, in getitem\r\n> 2: raise KeyError(key) from None\r\n> 2: KeyError: 'WORLD_SIZE'\r\n> ```\r\n\r\nIt looks like the TorchElasticEnvironment is being used, which would be caused by setting \"cluster_type=BCP\" ([code](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/nlp/parts/megatron_trainer_builder.py#L143-L144)). But it looks like you are running via Slurm. So, I don't think you should be using \"++cluster_type=BCP\" in a Slurm environment? Did you add that yourself, or was this script generated via the NeMo Framework Launcher?", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-08-22T02:16:30
2024-10-04T01:58:56
2024-10-04T01:58:56
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
2: Traceback (most recent call last): 2: File "/workspace/NeMo/examples/nlp/language_modeling/tuning/megatron_gpt_finetuning.py", line 64, in main 2: model = MegatronGPTSFTModel.restore_from(cfg.model.restore_from_path, model_cfg, trainer=trainer) 2: File "/opt/NeMo/nemo/collections/nlp/models/nlp_model.py", line 465, in restore_from 2: return super().restore_from( 2: File "/opt/NeMo/nemo/core/classes/modelPT.py", line 464, in restore_from 2: instance = cls._save_restore_connector.restore_from( 2: File "/opt/NeMo/nemo/collections/nlp/parts/nlp_overrides.py", line 1122, in restore_from 2: loaded_params = super().load_config_and_state_dict( 2: File "/opt/NeMo/nemo/core/connectors/save_restore_connector.py", line 178, in load_config_and_state_dict 2: instance = calling_cls.from_config_dict(config=conf, trainer=trainer) 2: File "/opt/NeMo/nemo/core/classes/common.py", line 524, in from_config_dict 2: raise e 2: File "/opt/NeMo/nemo/core/classes/common.py", line 516, in from_config_dict 2: instance = cls(cfg=config, trainer=trainer) 2: File "/opt/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_sft_model.py", line 77, in init 2: super().init(cfg, trainer=trainer) 2: File "/opt/NeMo/nemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py", line 79, in init 2: super().init(*args, **kwargs) 2: File "/opt/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py", line 287, in init 2: super().init(cfg, trainer=trainer, no_lm_init=True) 2: File "/opt/NeMo/nemo/collections/nlp/models/language_modeling/megatron_base_model.py", line 175, in init 2: init_world_size = trainer.world_size 2: File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/trainer.py", line 1161, in world_size 2: return getattr(self.strategy, "world_size", 1) 2: File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/strategies/parallel.py", line 66, in world_size 2: return self.cluster_environment.world_size() if self.cluster_environment is not None else 1 2: File "/usr/local/lib/python3.10/dist-packages/lightning_fabric/plugins/environments/torchelastic.py", line 63, in world_size 2: return int(os.environ["WORLD_SIZE"]) 2: File "/usr/lib/python3.10/os.py", line 680, in getitem 2: raise KeyError(key) from None 2: KeyError: 'WORLD_SIZE' use slurm #!/bin/bash #SBATCH --exclusive --nodes=2 --mem=0 --overcommit --ntasks-per-node=8 --time=4:30:00 --job-name=multinode_sft_example #Load necessary modules and set environment variables export CUDA_DEVICE_MAX_CONNECTIONS=1 #Set model and training parameters TRAIN_DS="[/workspace/data/databricks-dolly-15k/training.jsonl]" VALID_DS="[/workspace/data/databricks-dolly-15k/validation.jsonl]" TEST_DS="[/workspace/data/databricks-dolly-15k/test.jsonl]" CKPT="/workspace/model_ckpts/llama2-7b.nemo" TS=$(date +%s) OUTPUT_PATH="/workspace/" RESULTS_DIR="$OUTPUT_PATH/results_${TS}" CONCAT_SAMPLING_PROBS="[1]" TP_SIZE=1 PP_SIZE=1 BS=128 MAX_LEN=2048 #The NeMo command to run on each node. run_cmd="python3 /workspace/NeMo/examples/nlp/language_modeling/tuning/megatron_gpt_finetuning.py trainer.precision=bf16 trainer.devices=$SLURM_NTASKS_PER_NODE trainer.num_nodes=$SLURM_JOB_NUM_NODES trainer.val_check_interval=0.1 trainer.max_steps=50 model.restore_from_path=${CKPT} model.micro_batch_size=1 model.global_batch_size=128 model.tensor_model_parallel_size=${TP_SIZE} model.pipeline_model_parallel_size=${PP_SIZE} model.megatron_amp_O2=True model.activations_checkpoint_granularity=selective model.activations_checkpoint_method=uniform model.optim.name=distributed_fused_adam model.optim.lr=5e-6 model.answer_only_loss=True model.peft.peft_scheme=none model.data.train_ds.file_names=${TRAIN_DS} model.data.validation_ds.file_names=${VALID_DS} model.data.test_ds.file_names=${TEST_DS} model.data.train_ds.concat_sampling_probabilities=${CONCAT_SAMPLING_PROBS} model.data.train_ds.max_seq_length=2048 model.data.validation_ds.max_seq_length=2048 model.data.train_ds.micro_batch_size=1 model.data.train_ds.global_batch_size=128 model.data.validation_ds.micro_batch_size=1 model.data.validation_ds.global_batch_size=128 model.data.test_ds.micro_batch_size=1 model.data.test_ds.global_batch_size=256 model.data.train_ds.num_workers=0 model.data.validation_ds.num_workers=0 model.data.test_ds.num_workers=0 model.data.validation_ds.metric.name=loss model.data.test_ds.metric.name=loss exp_manager.create_wandb_logger=False exp_manager.explicit_log_dir=/workspace/results exp_manager.resume_if_exists=True exp_manager.resume_ignore_no_checkpoint=True exp_manager.create_checkpoint_callback=True exp_manager.checkpoint_callback_params.monitor=validation_loss exp_manager.checkpoint_callback_params.save_best_model=False exp_manager.checkpoint_callback_params.save_nemo_on_train_end=True ++cluster_type=BCP" #Container CONT=/root/nvcr.io+nvidia+nemo+24.06.sqsh CONT_NAME=nemofw-training CONT_MOUNT=/root/yovole:/workspace,/dev/infiniband:/dev/infiniband #run on SLURM srun -l --ntasks-per-node=8 --container-name="${CONT_NAME}" --container-image="${CONT}" --container-mounts="${CONT_MOUNT}" --container-entrypoint --no-container-mount-home bash -c "${run_cmd}"
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10229/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10229/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10228
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10228/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10228/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10228/events
https://github.com/NVIDIA/NeMo/pull/10228
2,479,462,014
PR_kwDOC_bI7s55DyaD
10,228
Sanity checks for unfinished checkpoints removal
{ "login": "jbieniusiewi", "id": 152396322, "node_id": "U_kgDOCRViIg", "avatar_url": "https://avatars.githubusercontent.com/u/152396322?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jbieniusiewi", "html_url": "https://github.com/jbieniusiewi", "followers_url": "https://api.github.com/users/jbieniusiewi/followers", "following_url": "https://api.github.com/users/jbieniusiewi/following{/other_user}", "gists_url": "https://api.github.com/users/jbieniusiewi/gists{/gist_id}", "starred_url": "https://api.github.com/users/jbieniusiewi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jbieniusiewi/subscriptions", "organizations_url": "https://api.github.com/users/jbieniusiewi/orgs", "repos_url": "https://api.github.com/users/jbieniusiewi/repos", "events_url": "https://api.github.com/users/jbieniusiewi/events{/privacy}", "received_events_url": "https://api.github.com/users/jbieniusiewi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "jbieniusiewi", "id": 152396322, "node_id": "U_kgDOCRViIg", "avatar_url": "https://avatars.githubusercontent.com/u/152396322?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jbieniusiewi", "html_url": "https://github.com/jbieniusiewi", "followers_url": "https://api.github.com/users/jbieniusiewi/followers", "following_url": "https://api.github.com/users/jbieniusiewi/following{/other_user}", "gists_url": "https://api.github.com/users/jbieniusiewi/gists{/gist_id}", "starred_url": "https://api.github.com/users/jbieniusiewi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jbieniusiewi/subscriptions", "organizations_url": "https://api.github.com/users/jbieniusiewi/orgs", "repos_url": "https://api.github.com/users/jbieniusiewi/repos", "events_url": "https://api.github.com/users/jbieniusiewi/events{/privacy}", "received_events_url": "https://api.github.com/users/jbieniusiewi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "jbieniusiewi", "id": 152396322, "node_id": "U_kgDOCRViIg", "avatar_url": "https://avatars.githubusercontent.com/u/152396322?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jbieniusiewi", "html_url": "https://github.com/jbieniusiewi", "followers_url": "https://api.github.com/users/jbieniusiewi/followers", "following_url": "https://api.github.com/users/jbieniusiewi/following{/other_user}", "gists_url": "https://api.github.com/users/jbieniusiewi/gists{/gist_id}", "starred_url": "https://api.github.com/users/jbieniusiewi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jbieniusiewi/subscriptions", "organizations_url": "https://api.github.com/users/jbieniusiewi/orgs", "repos_url": "https://api.github.com/users/jbieniusiewi/repos", "events_url": "https://api.github.com/users/jbieniusiewi/events{/privacy}", "received_events_url": "https://api.github.com/users/jbieniusiewi/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "@jbieniusiewi could you also add the same check for 2.0. The unfinished checkpoint filtering is [here](https://github.com/NVIDIA/NeMo/blob/main/nemo/lightning/resume.py#L112-L113) in 2.0.", "Thank you for the review @maanug-nv. \r\nI've added checks for NeMo 2.0. One more approval is needed to merge it, so I re-requested a review.", "~~-@ashors1 Do we have/plan to have tests for AutoResume?~~ Looks like they are in `tests/lightning/test_nemo_logger.py`. @jbieniusiewi final request, can we include the same test you added for exp manager to NeMoLogger/AutoResume as well?", "@maanug-nv Sure, I've added tests to ``tests/lightning/test_nemo_logger.py``.\r\n" ]
2024-08-22T00:22:30
2024-08-29T17:58:40
2024-08-29T17:58:38
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10228", "html_url": "https://github.com/NVIDIA/NeMo/pull/10228", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10228.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10228.patch", "merged_at": "2024-08-29T17:58:38" }
# What does this PR do ? The following scenario was recently observed: - Last checkpoint writing was interrupted due to an irrelevant issue - Hence last checkpoint was marked as "unfinished" (and there was no other last checkpoint) - Hence the following training silently skipped the last checkpoint and started from scratch - As a result, training was not making expected progress despite many training runs This PR adds some sanity checks to ensure that when the last/end checkpoint is unfinished, it wont get silently skipped and deleted. Instead, user is supposed to remove them manually. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "jbieniusiewi", "id": 152396322, "node_id": "U_kgDOCRViIg", "avatar_url": "https://avatars.githubusercontent.com/u/152396322?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jbieniusiewi", "html_url": "https://github.com/jbieniusiewi", "followers_url": "https://api.github.com/users/jbieniusiewi/followers", "following_url": "https://api.github.com/users/jbieniusiewi/following{/other_user}", "gists_url": "https://api.github.com/users/jbieniusiewi/gists{/gist_id}", "starred_url": "https://api.github.com/users/jbieniusiewi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jbieniusiewi/subscriptions", "organizations_url": "https://api.github.com/users/jbieniusiewi/orgs", "repos_url": "https://api.github.com/users/jbieniusiewi/repos", "events_url": "https://api.github.com/users/jbieniusiewi/events{/privacy}", "received_events_url": "https://api.github.com/users/jbieniusiewi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10228/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10228/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10227
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10227/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10227/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10227/events
https://github.com/NVIDIA/NeMo/pull/10227
2,479,460,143
PR_kwDOC_bI7s55DyAP
10,227
Bump `Dockerfile.ci` (2024-08-22)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-22T00:19:56
2024-08-26T22:14:15
2024-08-26T22:14:13
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10227", "html_url": "https://github.com/NVIDIA/NeMo/pull/10227", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10227.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10227.patch", "merged_at": "2024-08-26T22:14:13" }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10227/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10227/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10226
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10226/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10226/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10226/events
https://github.com/NVIDIA/NeMo/pull/10226
2,479,399,554
PR_kwDOC_bI7s55Dk53
10,226
Add example script to run NeMo 2.0 llama pretraining with NeMo-Run
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "I feel like we should hold off on this until we merge the new entrypoint-API in NeMo-Run, see [docs](https://github.com/NVIDIA/NeMo-Run/blob/c284dcc7005ac5a2183dac661173eee46e05df87/examples/entrypoint/README.md). This will simplify this example considerably while adding more flexibility.", "> I feel like we should hold off on this until we merge the new entrypoint-API in NeMo-Run, see [docs](https://github.com/NVIDIA/NeMo-Run/blob/c284dcc7005ac5a2183dac661173eee46e05df87/examples/entrypoint/README.md). This will simplify this example considerably while adding more flexibility.\r\n\r\n@marcromeyn But what if we don't want the extra flexibility. The aim of this example is to be able to reproduce exactly what we have been doing. Users can then use CLI or the script itself for personalization. ", "Yeah I think we can create a separate CLI folder to host the CLI examples, but would be nice to have both so the users get a clear picture. It will also help show the benefits via a 1:1 comparison.", "@ShriyaPalsamudram if the script would only show how to do one thing, so let's say llama3-8b I would agree. But this script offers some form of parameterization using argparse + the `MODEL_SIZE_MAPPING` dict . I believe when we showcase scripts with a form of parameterization we should be showcasing the functionality inside NeMo-Run that is designed for that." ]
2024-08-21T23:06:30
2024-08-28T23:19:59
2024-08-28T23:19:57
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10226", "html_url": "https://github.com/NVIDIA/NeMo/pull/10226", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10226.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10226.patch", "merged_at": "2024-08-28T23:19:57" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10226/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10226/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10225
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10225/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10225/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10225/events
https://github.com/NVIDIA/NeMo/pull/10225
2,479,390,334
PR_kwDOC_bI7s55Di4-
10,225
Force `optimizer.param_groups` to match `mcore_optimizer.param_groups`
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "FYI @gdengk " ]
2024-08-21T22:55:43
2024-08-22T17:22:19
2024-08-22T17:06:02
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10225", "html_url": "https://github.com/NVIDIA/NeMo/pull/10225", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10225.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10225.patch", "merged_at": "2024-08-22T17:06:02" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10225/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10225/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10224
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10224/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10224/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10224/events
https://github.com/NVIDIA/NeMo/pull/10224
2,478,645,033
PR_kwDOC_bI7s55BFmb
10,224
fix mamba convert/ add test
{ "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-08-21T17:52:06
2024-08-21T23:30:16
2024-08-21T23:30:14
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10224", "html_url": "https://github.com/NVIDIA/NeMo/pull/10224", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10224.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10224.patch", "merged_at": "2024-08-21T23:30:14" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10224/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10224/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10223
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10223/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10223/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10223/events
https://github.com/NVIDIA/NeMo/pull/10223
2,478,616,823
PR_kwDOC_bI7s55A_Hh
10,223
Add WandbPlugin, NsysPlugin and PreemptionPlugin to nemo.lightning.run.plugins
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "can you include some example of how this would be used (at least in PR description)" ]
2024-08-21T17:40:36
2024-08-27T16:53:10
2024-08-27T16:53:08
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10223", "html_url": "https://github.com/NVIDIA/NeMo/pull/10223", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10223.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10223.patch", "merged_at": "2024-08-27T16:53:08" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10223/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10223/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10221
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10221/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10221/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10221/events
https://github.com/NVIDIA/NeMo/pull/10221
2,477,062,742
PR_kwDOC_bI7s547rnY
10,221
24.07 vboost numbers
{ "login": "malay-nagda", "id": 164242706, "node_id": "U_kgDOCcolEg", "avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4", "gravatar_id": "", "url": "https://api.github.com/users/malay-nagda", "html_url": "https://github.com/malay-nagda", "followers_url": "https://api.github.com/users/malay-nagda/followers", "following_url": "https://api.github.com/users/malay-nagda/following{/other_user}", "gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}", "starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions", "organizations_url": "https://api.github.com/users/malay-nagda/orgs", "repos_url": "https://api.github.com/users/malay-nagda/repos", "events_url": "https://api.github.com/users/malay-nagda/events{/privacy}", "received_events_url": "https://api.github.com/users/malay-nagda/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "erhoo82", "id": 15861259, "node_id": "MDQ6VXNlcjE1ODYxMjU5", "avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/erhoo82", "html_url": "https://github.com/erhoo82", "followers_url": "https://api.github.com/users/erhoo82/followers", "following_url": "https://api.github.com/users/erhoo82/following{/other_user}", "gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}", "starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions", "organizations_url": "https://api.github.com/users/erhoo82/orgs", "repos_url": "https://api.github.com/users/erhoo82/repos", "events_url": "https://api.github.com/users/erhoo82/events{/privacy}", "received_events_url": "https://api.github.com/users/erhoo82/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "erhoo82", "id": 15861259, "node_id": "MDQ6VXNlcjE1ODYxMjU5", "avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/erhoo82", "html_url": "https://github.com/erhoo82", "followers_url": "https://api.github.com/users/erhoo82/followers", "following_url": "https://api.github.com/users/erhoo82/following{/other_user}", "gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}", "starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions", "organizations_url": "https://api.github.com/users/erhoo82/orgs", "repos_url": "https://api.github.com/users/erhoo82/repos", "events_url": "https://api.github.com/users/erhoo82/events{/privacy}", "received_events_url": "https://api.github.com/users/erhoo82/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-08-21T05:01:37
2024-08-21T18:50:41
2024-08-21T18:50:41
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10221", "html_url": "https://github.com/NVIDIA/NeMo/pull/10221", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10221.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10221.patch", "merged_at": "2024-08-21T18:50:41" }
# What does this PR do ? 24.07 perf numbers for experiments using vboost **Collection**: [nlp] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [x] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [x] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "erhoo82", "id": 15861259, "node_id": "MDQ6VXNlcjE1ODYxMjU5", "avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/erhoo82", "html_url": "https://github.com/erhoo82", "followers_url": "https://api.github.com/users/erhoo82/followers", "following_url": "https://api.github.com/users/erhoo82/following{/other_user}", "gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}", "starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions", "organizations_url": "https://api.github.com/users/erhoo82/orgs", "repos_url": "https://api.github.com/users/erhoo82/repos", "events_url": "https://api.github.com/users/erhoo82/events{/privacy}", "received_events_url": "https://api.github.com/users/erhoo82/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10221/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10221/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10220
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10220/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10220/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10220/events
https://github.com/NVIDIA/NeMo/issues/10220
2,476,976,068
I_kwDOC_bI7s6To6fE
10,220
training resume is not working in 24.07 container
{ "login": "switiz", "id": 12544231, "node_id": "MDQ6VXNlcjEyNTQ0MjMx", "avatar_url": "https://avatars.githubusercontent.com/u/12544231?v=4", "gravatar_id": "", "url": "https://api.github.com/users/switiz", "html_url": "https://github.com/switiz", "followers_url": "https://api.github.com/users/switiz/followers", "following_url": "https://api.github.com/users/switiz/following{/other_user}", "gists_url": "https://api.github.com/users/switiz/gists{/gist_id}", "starred_url": "https://api.github.com/users/switiz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/switiz/subscriptions", "organizations_url": "https://api.github.com/users/switiz/orgs", "repos_url": "https://api.github.com/users/switiz/repos", "events_url": "https://api.github.com/users/switiz/events{/privacy}", "received_events_url": "https://api.github.com/users/switiz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
{ "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "Thank you for the bug report. We're still working on a patch.", "Hi,\r\n\r\nthis issue is fixed in our dev nightly container:\r\n[nvcr.io/nvidian/nemo:nightly](http://nvcr.io/nvidian/nemo:nightly)" ]
2024-08-21T03:41:58
2024-08-23T12:45:45
2024-08-23T12:45:45
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** In version 24.05, the training continuation process was working smoothly. However, after upgrading to version 24.07, when resuming after a pause, the loss value spikes significantly. This seems to be a highly critical issue that needs investigation. The problem occurs consistently, regardless of the model size or data, and resuming training is failing 100% of the time. **Steps/Code to reproduce bug** 1. Perform llama 7b **pretraining** with a mock dataset 2. Save some checkpoints 3. Resume from the saved checkpoint 4. Loss spikes **Expected behavior** working normally **Environment overview (please complete the following information)** - using 24.07 docker container - H100
{ "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10220/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10220/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10219
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10219/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10219/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10219/events
https://github.com/NVIDIA/NeMo/pull/10219
2,476,909,966
PR_kwDOC_bI7s547J8o
10,219
Wrap CPU model init with megatron_lazy_init_context
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-08-21T02:39:10
2024-08-26T16:36:35
2024-08-26T16:36:33
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10219", "html_url": "https://github.com/NVIDIA/NeMo/pull/10219", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10219.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10219.patch", "merged_at": "2024-08-26T16:36:33" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10219/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10219/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10218
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10218/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10218/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10218/events
https://github.com/NVIDIA/NeMo/pull/10218
2,476,746,994
PR_kwDOC_bI7s546q4Q
10,218
Bump `Dockerfile.ci` (2024-08-21)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-21T00:19:48
2024-08-26T22:15:14
2024-08-26T22:15:14
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10218", "html_url": "https://github.com/NVIDIA/NeMo/pull/10218", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10218.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10218.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10218/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10218/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10216
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10216/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10216/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10216/events
https://github.com/NVIDIA/NeMo/pull/10216
2,476,661,408
PR_kwDOC_bI7s546ZI9
10,216
Set apply_query_key_layer_scaling=False in Llama3Config
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-20T22:47:41
2024-08-22T04:17:54
2024-08-22T04:17:52
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10216", "html_url": "https://github.com/NVIDIA/NeMo/pull/10216", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10216.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10216.patch", "merged_at": "2024-08-22T04:17:52" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10216/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10216/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10215
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10215/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10215/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10215/events
https://github.com/NVIDIA/NeMo/pull/10215
2,476,636,797
PR_kwDOC_bI7s546Tjx
10,215
Update TRTLLM 0.12
{ "login": "meatybobby", "id": 9738259, "node_id": "MDQ6VXNlcjk3MzgyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meatybobby", "html_url": "https://github.com/meatybobby", "followers_url": "https://api.github.com/users/meatybobby/followers", "following_url": "https://api.github.com/users/meatybobby/following{/other_user}", "gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}", "starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions", "organizations_url": "https://api.github.com/users/meatybobby/orgs", "repos_url": "https://api.github.com/users/meatybobby/repos", "events_url": "https://api.github.com/users/meatybobby/events{/privacy}", "received_events_url": "https://api.github.com/users/meatybobby/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "meatybobby", "id": 9738259, "node_id": "MDQ6VXNlcjk3MzgyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meatybobby", "html_url": "https://github.com/meatybobby", "followers_url": "https://api.github.com/users/meatybobby/followers", "following_url": "https://api.github.com/users/meatybobby/following{/other_user}", "gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}", "starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions", "organizations_url": "https://api.github.com/users/meatybobby/orgs", "repos_url": "https://api.github.com/users/meatybobby/repos", "events_url": "https://api.github.com/users/meatybobby/events{/privacy}", "received_events_url": "https://api.github.com/users/meatybobby/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "meatybobby", "id": 9738259, "node_id": "MDQ6VXNlcjk3MzgyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meatybobby", "html_url": "https://github.com/meatybobby", "followers_url": "https://api.github.com/users/meatybobby/followers", "following_url": "https://api.github.com/users/meatybobby/following{/other_user}", "gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}", "starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions", "organizations_url": "https://api.github.com/users/meatybobby/orgs", "repos_url": "https://api.github.com/users/meatybobby/repos", "events_url": "https://api.github.com/users/meatybobby/events{/privacy}", "received_events_url": "https://api.github.com/users/meatybobby/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "I know this is still in draft but I did a quick test and llama and nemotron seem working. Got some error with gemma. Looks like there is a API change for gemma. We also need update for the scripts/deploy/nlp/deploy_triton.py." ]
2024-08-20T22:27:03
2024-08-22T17:28:32
2024-08-22T17:28:31
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10215", "html_url": "https://github.com/NVIDIA/NeMo/pull/10215", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10215.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10215.patch", "merged_at": "2024-08-22T17:28:31" }
# What does this PR do ? Update TRTLLM 0.12 **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "meatybobby", "id": 9738259, "node_id": "MDQ6VXNlcjk3MzgyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meatybobby", "html_url": "https://github.com/meatybobby", "followers_url": "https://api.github.com/users/meatybobby/followers", "following_url": "https://api.github.com/users/meatybobby/following{/other_user}", "gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}", "starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions", "organizations_url": "https://api.github.com/users/meatybobby/orgs", "repos_url": "https://api.github.com/users/meatybobby/repos", "events_url": "https://api.github.com/users/meatybobby/events{/privacy}", "received_events_url": "https://api.github.com/users/meatybobby/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10215/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10215/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10214
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10214/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10214/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10214/events
https://github.com/NVIDIA/NeMo/pull/10214
2,476,260,108
PR_kwDOC_bI7s545AuW
10,214
Enable DDP memory optimization by default
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-20T18:20:58
2024-08-21T19:02:06
2024-08-21T19:02:04
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10214", "html_url": "https://github.com/NVIDIA/NeMo/pull/10214", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10214.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10214.patch", "merged_at": "2024-08-21T19:02:04" }
# What does this PR do ? Enable DDP memory optimization by default for most ASR setups. **Collection**: ASR # Changelog - Enable DDP memory optimization by default for most ASR setups. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10214/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10214/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10213
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10213/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10213/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10213/events
https://github.com/NVIDIA/NeMo/pull/10213
2,476,158,679
PR_kwDOC_bI7s544qU7
10,213
Lazy import tokenizers
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-08-20T17:19:17
2024-08-28T01:24:33
2024-08-28T01:24:31
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10213", "html_url": "https://github.com/NVIDIA/NeMo/pull/10213", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10213.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10213.patch", "merged_at": "2024-08-28T01:24:31" }
# What does this PR do ? Had this on my local disk and wanted to push it here as well. The goal is to avoid importing all tokenization libraries when the user will only use one. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10213/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10213/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10212
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10212/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10212/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10212/events
https://github.com/NVIDIA/NeMo/pull/10212
2,474,602,267
PR_kwDOC_bI7s54zUnn
10,212
Fix train loss broadcasting
{ "login": "maanug-nv", "id": 109391026, "node_id": "U_kgDOBoUssg", "avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maanug-nv", "html_url": "https://github.com/maanug-nv", "followers_url": "https://api.github.com/users/maanug-nv/followers", "following_url": "https://api.github.com/users/maanug-nv/following{/other_user}", "gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}", "starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions", "organizations_url": "https://api.github.com/users/maanug-nv/orgs", "repos_url": "https://api.github.com/users/maanug-nv/repos", "events_url": "https://api.github.com/users/maanug-nv/events{/privacy}", "received_events_url": "https://api.github.com/users/maanug-nv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-20T02:44:07
2024-08-21T00:14:28
2024-08-21T00:14:27
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10212", "html_url": "https://github.com/NVIDIA/NeMo/pull/10212", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10212.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10212.patch", "merged_at": "2024-08-21T00:14:27" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10212/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10212/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10211
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10211/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10211/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10211/events
https://github.com/NVIDIA/NeMo/pull/10211
2,474,484,754
PR_kwDOC_bI7s54y7mh
10,211
Bump `Dockerfile.ci` (2024-08-20)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-20T00:19:54
2024-08-26T22:15:11
2024-08-26T22:15:11
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10211", "html_url": "https://github.com/NVIDIA/NeMo/pull/10211", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10211.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10211.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10211/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10211/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10210
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10210/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10210/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10210/events
https://github.com/NVIDIA/NeMo/pull/10210
2,474,415,824
PR_kwDOC_bI7s54yscX
10,210
<SFT> <Long Sequence Length> Remove Attention Mask in SFT Chat Dataset
{ "login": "tomlifu", "id": 22651648, "node_id": "MDQ6VXNlcjIyNjUxNjQ4", "avatar_url": "https://avatars.githubusercontent.com/u/22651648?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tomlifu", "html_url": "https://github.com/tomlifu", "followers_url": "https://api.github.com/users/tomlifu/followers", "following_url": "https://api.github.com/users/tomlifu/following{/other_user}", "gists_url": "https://api.github.com/users/tomlifu/gists{/gist_id}", "starred_url": "https://api.github.com/users/tomlifu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tomlifu/subscriptions", "organizations_url": "https://api.github.com/users/tomlifu/orgs", "repos_url": "https://api.github.com/users/tomlifu/repos", "events_url": "https://api.github.com/users/tomlifu/events{/privacy}", "received_events_url": "https://api.github.com/users/tomlifu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-19T23:15:22
2024-08-21T05:24:40
2024-08-21T05:24:40
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10210", "html_url": "https://github.com/NVIDIA/NeMo/pull/10210", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10210.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10210.patch", "merged_at": "2024-08-21T05:24:40" }
# What does this PR do ? This PR removes the attention mask generation to prevent CPU from running out of memory issue when using SFT chat dataset. # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10210/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10210/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10209
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10209/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10209/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10209/events
https://github.com/NVIDIA/NeMo/pull/10209
2,474,402,719
PR_kwDOC_bI7s54ypjr
10,209
[NeMo-UX] Turn on mcore performance optimizations
{ "login": "JimmyZhang12", "id": 67203904, "node_id": "MDQ6VXNlcjY3MjAzOTA0", "avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JimmyZhang12", "html_url": "https://github.com/JimmyZhang12", "followers_url": "https://api.github.com/users/JimmyZhang12/followers", "following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}", "gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}", "starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions", "organizations_url": "https://api.github.com/users/JimmyZhang12/orgs", "repos_url": "https://api.github.com/users/JimmyZhang12/repos", "events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}", "received_events_url": "https://api.github.com/users/JimmyZhang12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7079591682, "node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio", "name": "audio", "color": "0DAAC3", "default": false, "description": "" } ]
closed
false
{ "login": "JimmyZhang12", "id": 67203904, "node_id": "MDQ6VXNlcjY3MjAzOTA0", "avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JimmyZhang12", "html_url": "https://github.com/JimmyZhang12", "followers_url": "https://api.github.com/users/JimmyZhang12/followers", "following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}", "gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}", "starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions", "organizations_url": "https://api.github.com/users/JimmyZhang12/orgs", "repos_url": "https://api.github.com/users/JimmyZhang12/repos", "events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}", "received_events_url": "https://api.github.com/users/JimmyZhang12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "JimmyZhang12", "id": 67203904, "node_id": "MDQ6VXNlcjY3MjAzOTA0", "avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JimmyZhang12", "html_url": "https://github.com/JimmyZhang12", "followers_url": "https://api.github.com/users/JimmyZhang12/followers", "following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}", "gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}", "starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions", "organizations_url": "https://api.github.com/users/JimmyZhang12/orgs", "repos_url": "https://api.github.com/users/JimmyZhang12/repos", "events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}", "received_events_url": "https://api.github.com/users/JimmyZhang12/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "LGTM! Besides a few docstrings and getter apis. Approving." ]
2024-08-19T23:02:00
2024-09-06T05:14:40
2024-09-06T05:14:38
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10209", "html_url": "https://github.com/NVIDIA/NeMo/pull/10209", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10209.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10209.patch", "merged_at": "2024-09-06T05:14:38" }
# What does this PR do ? Turns on various communication/compute overlap optimizations: - Pipeline parallel overlap, data parallel overlap is well supported and this PR turns it on by default when available - Tensor parallel overlap is not officially productized in TE, so its not guaranteed to work on all clusters. So it is disabled by default. It can be turned on by setting the `NEMO_ENABLE_TP_COMM_OVERLAP` environment variable. Currently TP overlap only supports dense models, so Ive only added a TP overlap config for LLAMA70B, and can add more as more model recipes are added. - Wgrad deferral, which overlaps wgrads over the pipeline bubble, has to be tuned per model, so this defaults false. I tested the full 70b, 8b performance recipes using NeMo-Run as saw no differences to the loss, but a ~10% improvement in performance. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10209/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10209/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10208
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10208/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10208/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10208/events
https://github.com/NVIDIA/NeMo/pull/10208
2,474,214,339
PR_kwDOC_bI7s54yDju
10,208
FP8 plugin recipes
{ "login": "maanug-nv", "id": 109391026, "node_id": "U_kgDOBoUssg", "avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maanug-nv", "html_url": "https://github.com/maanug-nv", "followers_url": "https://api.github.com/users/maanug-nv/followers", "following_url": "https://api.github.com/users/maanug-nv/following{/other_user}", "gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}", "starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions", "organizations_url": "https://api.github.com/users/maanug-nv/orgs", "repos_url": "https://api.github.com/users/maanug-nv/repos", "events_url": "https://api.github.com/users/maanug-nv/events{/privacy}", "received_events_url": "https://api.github.com/users/maanug-nv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Should wait to merge until after FP8 is verified.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days." ]
2024-08-19T21:11:41
2024-09-19T14:30:41
2024-09-19T14:30:38
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10208", "html_url": "https://github.com/NVIDIA/NeMo/pull/10208", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10208.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10208.patch", "merged_at": "2024-09-19T14:30:38" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ShriyaPalsamudram", "id": 69161273, "node_id": "MDQ6VXNlcjY5MTYxMjcz", "avatar_url": "https://avatars.githubusercontent.com/u/69161273?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ShriyaPalsamudram", "html_url": "https://github.com/ShriyaPalsamudram", "followers_url": "https://api.github.com/users/ShriyaPalsamudram/followers", "following_url": "https://api.github.com/users/ShriyaPalsamudram/following{/other_user}", "gists_url": "https://api.github.com/users/ShriyaPalsamudram/gists{/gist_id}", "starred_url": "https://api.github.com/users/ShriyaPalsamudram/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ShriyaPalsamudram/subscriptions", "organizations_url": "https://api.github.com/users/ShriyaPalsamudram/orgs", "repos_url": "https://api.github.com/users/ShriyaPalsamudram/repos", "events_url": "https://api.github.com/users/ShriyaPalsamudram/events{/privacy}", "received_events_url": "https://api.github.com/users/ShriyaPalsamudram/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10208/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10208/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10207
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10207/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10207/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10207/events
https://github.com/NVIDIA/NeMo/pull/10207
2,474,098,650
PR_kwDOC_bI7s54xp_W
10,207
Chchien s2st
{ "login": "zhehuaichen", "id": 139396994, "node_id": "U_kgDOCE8Hgg", "avatar_url": "https://avatars.githubusercontent.com/u/139396994?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zhehuaichen", "html_url": "https://github.com/zhehuaichen", "followers_url": "https://api.github.com/users/zhehuaichen/followers", "following_url": "https://api.github.com/users/zhehuaichen/following{/other_user}", "gists_url": "https://api.github.com/users/zhehuaichen/gists{/gist_id}", "starred_url": "https://api.github.com/users/zhehuaichen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zhehuaichen/subscriptions", "organizations_url": "https://api.github.com/users/zhehuaichen/orgs", "repos_url": "https://api.github.com/users/zhehuaichen/repos", "events_url": "https://api.github.com/users/zhehuaichen/events{/privacy}", "received_events_url": "https://api.github.com/users/zhehuaichen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[]
2024-08-19T19:58:17
2024-08-27T20:16:04
2024-08-27T20:16:04
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10207", "html_url": "https://github.com/NVIDIA/NeMo/pull/10207", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10207.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10207.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "zhehuaichen", "id": 139396994, "node_id": "U_kgDOCE8Hgg", "avatar_url": "https://avatars.githubusercontent.com/u/139396994?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zhehuaichen", "html_url": "https://github.com/zhehuaichen", "followers_url": "https://api.github.com/users/zhehuaichen/followers", "following_url": "https://api.github.com/users/zhehuaichen/following{/other_user}", "gists_url": "https://api.github.com/users/zhehuaichen/gists{/gist_id}", "starred_url": "https://api.github.com/users/zhehuaichen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zhehuaichen/subscriptions", "organizations_url": "https://api.github.com/users/zhehuaichen/orgs", "repos_url": "https://api.github.com/users/zhehuaichen/repos", "events_url": "https://api.github.com/users/zhehuaichen/events{/privacy}", "received_events_url": "https://api.github.com/users/zhehuaichen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10207/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10207/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10206
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10206/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10206/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10206/events
https://github.com/NVIDIA/NeMo/pull/10206
2,474,036,114
PR_kwDOC_bI7s54xcDs
10,206
Removing Attention Mask in SFT Chat Dataset
{ "login": "tomlifu", "id": 22651648, "node_id": "MDQ6VXNlcjIyNjUxNjQ4", "avatar_url": "https://avatars.githubusercontent.com/u/22651648?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tomlifu", "html_url": "https://github.com/tomlifu", "followers_url": "https://api.github.com/users/tomlifu/followers", "following_url": "https://api.github.com/users/tomlifu/following{/other_user}", "gists_url": "https://api.github.com/users/tomlifu/gists{/gist_id}", "starred_url": "https://api.github.com/users/tomlifu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tomlifu/subscriptions", "organizations_url": "https://api.github.com/users/tomlifu/orgs", "repos_url": "https://api.github.com/users/tomlifu/repos", "events_url": "https://api.github.com/users/tomlifu/events{/privacy}", "received_events_url": "https://api.github.com/users/tomlifu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-19T19:21:46
2024-08-19T21:56:31
2024-08-19T21:56:06
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10206", "html_url": "https://github.com/NVIDIA/NeMo/pull/10206", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10206.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10206.patch", "merged_at": null }
# What does this PR do ? This PR removes the attention mask in SFT chat dataset which revolved the CPU OOM issue when attention mask was turned on for SFT. # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
{ "login": "tomlifu", "id": 22651648, "node_id": "MDQ6VXNlcjIyNjUxNjQ4", "avatar_url": "https://avatars.githubusercontent.com/u/22651648?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tomlifu", "html_url": "https://github.com/tomlifu", "followers_url": "https://api.github.com/users/tomlifu/followers", "following_url": "https://api.github.com/users/tomlifu/following{/other_user}", "gists_url": "https://api.github.com/users/tomlifu/gists{/gist_id}", "starred_url": "https://api.github.com/users/tomlifu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tomlifu/subscriptions", "organizations_url": "https://api.github.com/users/tomlifu/orgs", "repos_url": "https://api.github.com/users/tomlifu/repos", "events_url": "https://api.github.com/users/tomlifu/events{/privacy}", "received_events_url": "https://api.github.com/users/tomlifu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10206/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10206/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10205
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10205/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10205/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10205/events
https://github.com/NVIDIA/NeMo/pull/10205
2,473,972,501
PR_kwDOC_bI7s54xN_O
10,205
[NeMo UX] Disable softmax fusion for non-te/non-apex test
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-19T18:44:15
2024-08-19T20:51:44
2024-08-19T20:51:43
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10205", "html_url": "https://github.com/NVIDIA/NeMo/pull/10205", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10205.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10205.patch", "merged_at": "2024-08-19T20:51:43" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "thomasdhc", "id": 9426164, "node_id": "MDQ6VXNlcjk0MjYxNjQ=", "avatar_url": "https://avatars.githubusercontent.com/u/9426164?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thomasdhc", "html_url": "https://github.com/thomasdhc", "followers_url": "https://api.github.com/users/thomasdhc/followers", "following_url": "https://api.github.com/users/thomasdhc/following{/other_user}", "gists_url": "https://api.github.com/users/thomasdhc/gists{/gist_id}", "starred_url": "https://api.github.com/users/thomasdhc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thomasdhc/subscriptions", "organizations_url": "https://api.github.com/users/thomasdhc/orgs", "repos_url": "https://api.github.com/users/thomasdhc/repos", "events_url": "https://api.github.com/users/thomasdhc/events{/privacy}", "received_events_url": "https://api.github.com/users/thomasdhc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10205/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10205/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10204
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10204/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10204/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10204/events
https://github.com/NVIDIA/NeMo/pull/10204
2,473,848,532
PR_kwDOC_bI7s54wytM
10,204
[NeMo-UX] Set parallelism correctly when using VPP
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "@marcromeyn I see that the set parallelism call is missing, here's the commit we have been using https://github.com/NVIDIA/NeMo/commit/e6d34effeea37e0def50dbfc3907ee2505165b50 \r\n\r\nIs that something you can add to this PR?", "@ShriyaPalsamudram It seems a recent commit has changed that implementation, this PR should do the same thing", "@marcromeyn great thanks, that addresses my concern. LGTM" ]
2024-08-19T17:30:59
2024-08-20T05:57:36
2024-08-20T05:57:34
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10204", "html_url": "https://github.com/NVIDIA/NeMo/pull/10204", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10204.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10204.patch", "merged_at": "2024-08-20T05:57:34" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10204/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10204/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10203
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10203/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10203/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10203/events
https://github.com/NVIDIA/NeMo/pull/10203
2,473,822,137
PR_kwDOC_bI7s54ws4h
10,203
Fix llama3 8b long context recipes
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-08-19T17:14:40
2024-08-26T16:42:38
2024-08-26T16:42:38
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10203", "html_url": "https://github.com/NVIDIA/NeMo/pull/10203", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10203.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10203.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "hemildesai", "id": 8195444, "node_id": "MDQ6VXNlcjgxOTU0NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hemildesai", "html_url": "https://github.com/hemildesai", "followers_url": "https://api.github.com/users/hemildesai/followers", "following_url": "https://api.github.com/users/hemildesai/following{/other_user}", "gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}", "starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions", "organizations_url": "https://api.github.com/users/hemildesai/orgs", "repos_url": "https://api.github.com/users/hemildesai/repos", "events_url": "https://api.github.com/users/hemildesai/events{/privacy}", "received_events_url": "https://api.github.com/users/hemildesai/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10203/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10203/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10202
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10202/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10202/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10202/events
https://github.com/NVIDIA/NeMo/pull/10202
2,473,805,635
PR_kwDOC_bI7s54wpPh
10,202
calculate step time batch end-batch end
{ "login": "malay-nagda", "id": 164242706, "node_id": "U_kgDOCcolEg", "avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4", "gravatar_id": "", "url": "https://api.github.com/users/malay-nagda", "html_url": "https://github.com/malay-nagda", "followers_url": "https://api.github.com/users/malay-nagda/followers", "following_url": "https://api.github.com/users/malay-nagda/following{/other_user}", "gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}", "starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions", "organizations_url": "https://api.github.com/users/malay-nagda/orgs", "repos_url": "https://api.github.com/users/malay-nagda/repos", "events_url": "https://api.github.com/users/malay-nagda/events{/privacy}", "received_events_url": "https://api.github.com/users/malay-nagda/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days." ]
2024-08-19T17:04:00
2024-10-17T06:32:56
2024-10-17T06:32:56
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10202", "html_url": "https://github.com/NVIDIA/NeMo/pull/10202", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10202.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10202.patch", "merged_at": "2024-10-17T06:32:56" }
# What does this PR do ? A new Callback to calculate and log (using nemo logger) step time from batch end to batch end. **Collection**: [llm] # Changelog ``` class DeltaTimingCallback(Callback): ``` # Usage ```python import nemo_run as run from nemo.utils.exp_manager import DeltaTimingCallback from nemo.collections.llm.recipes.llama3_8b import pretrain_recipe pretrain_recipe.trainer.callbacks.append(run.Config(DeltaTimingCallback)) ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10202/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10202/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10201
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10201/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10201/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10201/events
https://github.com/NVIDIA/NeMo/pull/10201
2,473,774,721
PR_kwDOC_bI7s54wiZT
10,201
Updated KL-Div calculation
{ "login": "Davood-M", "id": 3964285, "node_id": "MDQ6VXNlcjM5NjQyODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3964285?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Davood-M", "html_url": "https://github.com/Davood-M", "followers_url": "https://api.github.com/users/Davood-M/followers", "following_url": "https://api.github.com/users/Davood-M/following{/other_user}", "gists_url": "https://api.github.com/users/Davood-M/gists{/gist_id}", "starred_url": "https://api.github.com/users/Davood-M/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Davood-M/subscriptions", "organizations_url": "https://api.github.com/users/Davood-M/orgs", "repos_url": "https://api.github.com/users/Davood-M/repos", "events_url": "https://api.github.com/users/Davood-M/events{/privacy}", "received_events_url": "https://api.github.com/users/Davood-M/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-19T16:45:23
2024-08-19T18:17:46
2024-08-19T18:17:45
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10201", "html_url": "https://github.com/NVIDIA/NeMo/pull/10201", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10201.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10201.patch", "merged_at": "2024-08-19T18:17:45" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "khcs", "id": 5403167, "node_id": "MDQ6VXNlcjU0MDMxNjc=", "avatar_url": "https://avatars.githubusercontent.com/u/5403167?v=4", "gravatar_id": "", "url": "https://api.github.com/users/khcs", "html_url": "https://github.com/khcs", "followers_url": "https://api.github.com/users/khcs/followers", "following_url": "https://api.github.com/users/khcs/following{/other_user}", "gists_url": "https://api.github.com/users/khcs/gists{/gist_id}", "starred_url": "https://api.github.com/users/khcs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/khcs/subscriptions", "organizations_url": "https://api.github.com/users/khcs/orgs", "repos_url": "https://api.github.com/users/khcs/repos", "events_url": "https://api.github.com/users/khcs/events{/privacy}", "received_events_url": "https://api.github.com/users/khcs/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10201/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10201/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10200
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10200/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10200/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10200/events
https://github.com/NVIDIA/NeMo/pull/10200
2,473,766,631
PR_kwDOC_bI7s54wgmt
10,200
add a feature to drop checkpoint layers
{ "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "Looks good to me. ", "Approving MR as review from Marcin is complete." ]
2024-08-19T16:40:16
2024-09-18T19:52:38
2024-09-18T19:52:37
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10200", "html_url": "https://github.com/NVIDIA/NeMo/pull/10200", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10200.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10200.patch", "merged_at": "2024-09-18T19:52:37" }
# What does this PR do ? 1. Adds a feature similar to mcore's --skip-train flag. 3. Adds drop-layers feature support. 4. Adds script which loads the ckpt, trims needed layers, and saves trimmed checkpoint. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * Trim the model. Please, note that layer indices start from 1. Llama3 8b model example: ```ubuntu python -m torch.distributed.launch --nproc_per_node=8 \ NeMo/examples/nlp/language_modeling/megatron_gpt_drop_layers.py \ --path_to_nemo /path/to/model.nemo \ --path_to_save /path/to/save/trimmed_model.nemo \ --tensor_model_parallel_size 8 \ --pipeline_model_parallel_size 1 \ --gpus_per_node 8 \ --drop_layers 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 ``` If you want to save trimmed model in zarr ckpt format (deprecated), add this flag to the command: ```ubuntu --zarr ``` * Validate the model: ```ubuntu python NeMo/examples/nlp/language_modeling/megatron_gpt_pretraining.py \ --config-path=/path/to/folder/with/model/config \ --config-name=llama3_8b.yaml \ trainer.limit_val_batches=number_of_batches_in_validation_step \ model.restore_from_path=/path/to/trimmed_model.nemo \ model.skip_train=True \ model.data.data_impl=mock \ model.data.data_prefix=[] ``` To use specific dataset instead of mock dataset: ```ubuntu model.data.data_impl=mmap \ model.data.data_prefix=["path/to/datafile1", "path/to/datafile2"] ``` * Validate Original Model To validate the original model without specific layers, use the following script: ```ubuntu python /NeMo/examples/nlp/language_modeling/megatron_gpt_pretraining.py \ --config-path=/path/to/folder/with/model/config \ --config-name=llama3_8b.yaml \ trainer.limit_val_batches=<limit_val_batches> \ model.restore_from_path=/path/to/original_model.nemo \ model.skip_train=True \ model.data.data_impl=mock \ model.data.data_prefix=[] \ model.drop_layers=[16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31] ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10200/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10200/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10199
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10199/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10199/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10199/events
https://github.com/NVIDIA/NeMo/pull/10199
2,473,643,131
PR_kwDOC_bI7s54wFS4
10,199
Log step time
{ "login": "malay-nagda", "id": 164242706, "node_id": "U_kgDOCcolEg", "avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4", "gravatar_id": "", "url": "https://api.github.com/users/malay-nagda", "html_url": "https://github.com/malay-nagda", "followers_url": "https://api.github.com/users/malay-nagda/followers", "following_url": "https://api.github.com/users/malay-nagda/following{/other_user}", "gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}", "starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions", "organizations_url": "https://api.github.com/users/malay-nagda/orgs", "repos_url": "https://api.github.com/users/malay-nagda/repos", "events_url": "https://api.github.com/users/malay-nagda/events{/privacy}", "received_events_url": "https://api.github.com/users/malay-nagda/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-08-19T15:31:04
2024-08-19T17:04:41
2024-08-19T17:04:41
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10199", "html_url": "https://github.com/NVIDIA/NeMo/pull/10199", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10199.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10199.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "malay-nagda", "id": 164242706, "node_id": "U_kgDOCcolEg", "avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4", "gravatar_id": "", "url": "https://api.github.com/users/malay-nagda", "html_url": "https://github.com/malay-nagda", "followers_url": "https://api.github.com/users/malay-nagda/followers", "following_url": "https://api.github.com/users/malay-nagda/following{/other_user}", "gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}", "starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions", "organizations_url": "https://api.github.com/users/malay-nagda/orgs", "repos_url": "https://api.github.com/users/malay-nagda/repos", "events_url": "https://api.github.com/users/malay-nagda/events{/privacy}", "received_events_url": "https://api.github.com/users/malay-nagda/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10199/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10199/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10198
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10198/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10198/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10198/events
https://github.com/NVIDIA/NeMo/pull/10198
2,473,543,503
PR_kwDOC_bI7s54vvK_
10,198
Add tests for LazyNeMoIterator and fix case with metadata_only=True and offsets in manifest
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-19T14:45:05
2024-08-23T13:56:31
2024-08-23T13:56:30
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10198", "html_url": "https://github.com/NVIDIA/NeMo/pull/10198", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10198.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10198.patch", "merged_at": "2024-08-23T13:56:30" }
# What does this PR do ? Fix https://github.com/NVIDIA/NeMo/issues/10060 **Collection**: ASR # Changelog - Improved test coverage for LazyNeMoIterator and fix for a case with `metadata_only=True` and offsets in manifest # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10198/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10198/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10197
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10197/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10197/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10197/events
https://github.com/NVIDIA/NeMo/pull/10197
2,473,345,010
PR_kwDOC_bI7s54vDDS
10,197
tests: Fix L2_Community_vita_Checkpoints_tests_Llama3
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-19T13:17:36
2024-08-19T14:17:54
2024-08-19T14:17:52
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10197", "html_url": "https://github.com/NVIDIA/NeMo/pull/10197", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10197.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10197.patch", "merged_at": "2024-08-19T14:17:52" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10197/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10197/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10196
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10196/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10196/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10196/events
https://github.com/NVIDIA/NeMo/pull/10196
2,473,283,211
PR_kwDOC_bI7s54u1cj
10,196
Minor formatting fix
{ "login": "AAnoosheh", "id": 5615503, "node_id": "MDQ6VXNlcjU2MTU1MDM=", "avatar_url": "https://avatars.githubusercontent.com/u/5615503?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AAnoosheh", "html_url": "https://github.com/AAnoosheh", "followers_url": "https://api.github.com/users/AAnoosheh/followers", "following_url": "https://api.github.com/users/AAnoosheh/following{/other_user}", "gists_url": "https://api.github.com/users/AAnoosheh/gists{/gist_id}", "starred_url": "https://api.github.com/users/AAnoosheh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AAnoosheh/subscriptions", "organizations_url": "https://api.github.com/users/AAnoosheh/orgs", "repos_url": "https://api.github.com/users/AAnoosheh/repos", "events_url": "https://api.github.com/users/AAnoosheh/events{/privacy}", "received_events_url": "https://api.github.com/users/AAnoosheh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-19T12:49:36
2024-12-29T16:20:25
2024-08-19T12:56:18
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10196", "html_url": "https://github.com/NVIDIA/NeMo/pull/10196", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10196.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10196.patch", "merged_at": "2024-08-19T12:56:18" }
# What does this PR do ? Fix formatting mistake in the ModelOpt Distillation documentation **Collection**: NLP # Changelog - Indent code block in `docs/source/nlp/distillation.rst` # Usage N/A # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [x] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [x] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10196/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10196/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10195
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10195/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10195/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10195/events
https://github.com/NVIDIA/NeMo/pull/10195
2,473,148,463
PR_kwDOC_bI7s54uXtw
10,195
ci: Selective triggering
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Example of triggering a single test: https://github.com/NVIDIA/NeMo/actions/runs/10618944819/job/29435552797\r\nExample of triggering all: https://github.com/NVIDIA/NeMo/actions/runs/10619071709/job/29435808466" ]
2024-08-19T11:39:11
2024-08-29T23:10:25
2024-08-29T23:10:23
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10195", "html_url": "https://github.com/NVIDIA/NeMo/pull/10195", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10195.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10195.patch", "merged_at": "2024-08-29T23:10:23" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10195/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10195/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10194
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10194/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10194/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10194/events
https://github.com/NVIDIA/NeMo/pull/10194
2,472,571,501
PR_kwDOC_bI7s54sZej
10,194
Per step tflops
{ "login": "malay-nagda", "id": 164242706, "node_id": "U_kgDOCcolEg", "avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4", "gravatar_id": "", "url": "https://api.github.com/users/malay-nagda", "html_url": "https://github.com/malay-nagda", "followers_url": "https://api.github.com/users/malay-nagda/followers", "following_url": "https://api.github.com/users/malay-nagda/following{/other_user}", "gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}", "starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions", "organizations_url": "https://api.github.com/users/malay-nagda/orgs", "repos_url": "https://api.github.com/users/malay-nagda/repos", "events_url": "https://api.github.com/users/malay-nagda/events{/privacy}", "received_events_url": "https://api.github.com/users/malay-nagda/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-08-19T06:36:27
2024-09-10T01:56:02
2024-09-10T01:56:01
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10194", "html_url": "https://github.com/NVIDIA/NeMo/pull/10194", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10194.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10194.patch", "merged_at": null }
# What does this PR do ? Log (TFLOPs / sec) per gpu per step **Collection**: [nlp, llm] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10194/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10194/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10193
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10193/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10193/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10193/events
https://github.com/NVIDIA/NeMo/pull/10193
2,472,218,213
PR_kwDOC_bI7s54rM_q
10,193
Bump `Dockerfile.ci` (2024-08-19)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-19T00:20:34
2024-08-26T22:14:51
2024-08-26T22:14:51
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10193", "html_url": "https://github.com/NVIDIA/NeMo/pull/10193", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10193.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10193.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10193/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10193/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10192
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10192/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10192/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10192/events
https://github.com/NVIDIA/NeMo/issues/10192
2,471,867,673
I_kwDOC_bI7s6TVbUZ
10,192
Out of RAM using 24.07 container
{ "login": "aimarz", "id": 82966040, "node_id": "MDQ6VXNlcjgyOTY2MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/82966040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aimarz", "html_url": "https://github.com/aimarz", "followers_url": "https://api.github.com/users/aimarz/followers", "following_url": "https://api.github.com/users/aimarz/following{/other_user}", "gists_url": "https://api.github.com/users/aimarz/gists{/gist_id}", "starred_url": "https://api.github.com/users/aimarz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aimarz/subscriptions", "organizations_url": "https://api.github.com/users/aimarz/orgs", "repos_url": "https://api.github.com/users/aimarz/repos", "events_url": "https://api.github.com/users/aimarz/events{/privacy}", "received_events_url": "https://api.github.com/users/aimarz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "mikolajblaz", "id": 9979479, "node_id": "MDQ6VXNlcjk5Nzk0Nzk=", "avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mikolajblaz", "html_url": "https://github.com/mikolajblaz", "followers_url": "https://api.github.com/users/mikolajblaz/followers", "following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}", "gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions", "organizations_url": "https://api.github.com/users/mikolajblaz/orgs", "repos_url": "https://api.github.com/users/mikolajblaz/repos", "events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}", "received_events_url": "https://api.github.com/users/mikolajblaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "mikolajblaz", "id": 9979479, "node_id": "MDQ6VXNlcjk5Nzk0Nzk=", "avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mikolajblaz", "html_url": "https://github.com/mikolajblaz", "followers_url": "https://api.github.com/users/mikolajblaz/followers", "following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}", "gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions", "organizations_url": "https://api.github.com/users/mikolajblaz/orgs", "repos_url": "https://api.github.com/users/mikolajblaz/repos", "events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}", "received_events_url": "https://api.github.com/users/mikolajblaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "@aimarz can you post a reproducer and the whole log?", "Yes, this seems similar to what I've observed on 15B / 24.07. I've noticed that locally, a 15B/TP4 checkpointing (checkpoint size is 205GB) reserves 70GB of process memory and 290GB of CPU/buffered disk IO memory (360GB total). And when the run continues, sometimes I see OOM/sigkill.\r\n\r\nAfter running (outside docker) most of that memory gets released:\r\n`free && sync && echo 3 > /proc/sys/vm/drop_caches && free`", "In my case it happens even when TP_size=1 and PP_size=1, that is, using only DP. \r\n\r\n@mikolajblaz here I attach the full logs as well as the configuration file used in the experiment (llama 2 7B continual pretraining using `NeMo/examples/nlp/language_modeling/megatron_gpt_pretraining.py`).\r\n\r\n[issue_config.yaml.txt](https://github.com/user-attachments/files/16696024/issue_config.yaml.txt)\r\n[issue_log_ERR.txt](https://github.com/user-attachments/files/16696026/issue_log_ERR.txt)\r\n[issue_log_OUT.txt](https://github.com/user-attachments/files/16696027/issue_log_OUT.txt)\r\n", "So far, no more OOMs/sigkill, when free memory target is set to 64GB. But I was only seeing the crash sporadically.\r\n\r\n`sysctl -w vm.min_free_kbytes=$((64 * 1024 * 1024))`\r\n\r\n", "Hello, I'm facing a similar issue. @dchichkov would you mind sharing the output of:\n```bash\nscontrol show node <node-name> | grep CfgTRES\n```\n\nIn our case it's:\n```\nCfgTRES=cpu=192,mem=1000000M,billing=192,gres/gpu=8\n```\n\nHowever when I check the amount of memory available on that node, it's `1056270564 kB`:\n```\ncat /proc/meminfo | grep MemTotal\n```\n\nis showing:\n```\nMemTotal: 1056270564 kB \n```\n\nI suspect this could be simply a mismatch between what's configured in Slurm and the total amount of memory on the node. And that by setting free memory target to 64GB you simply force the OS to keep the allocated memory below what's configured in Slurm.\n\nI'm also using `2407` NeMo image.\n\nAfter setting target memory to 64GB it also solved the problem for me.", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-08-18T09:00:49
2024-10-15T01:59:37
2024-10-15T01:59:36
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
I have tried training Llama 2, Llama 3.1 and Mistral models using the new 24.07 container but the process errors out after 200 or 300 steps. It always happens when a checkpoint is being created. I have ensured to set `cpu_offloading: false` and `use_cpu_initialization: false`. The training works well when using the 24.05 version and the exact same configuration. So I don't understand why this is happening. I would appreciate some help on this matter. These are the system specifications (I use 8 nodes for training): - 2x Intel Xeon Platinum 8460Y+ 40C 2.3GHz (80 cores per node) - 4x NVIDIA Hopper H100 64GB HBM2 - 16x DIMM 32GB 4800MHz DDR5 (512GB main memory per node) And this is the error I get in SLURM: srun: error: as01r3b17: task 3: Out Of Memory srun: Terminating StepId=4777403.0 slurmstepd: error: *** STEP 4777403.0 ON as01r3b17 CANCELLED AT 2024-08-16T19:36:54 *** slurmstepd: error: Detected 1 oom_kill event in StepId=4777403.0. Some of the step tasks have been OOM Killed. /usr/lib/python3.10/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 23 leaked semaphore objects to clean up at shutdown warnings.warn('resource_tracker: There appear to be %d ' /usr/lib/python3.10/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 23 leaked semaphore objects to clean up at shutdown warnings.warn('resource_tracker: There appear to be %d ' slurmstepd: error: Detected 1 oom_kill event in StepId=4777403.0. Some of the step tasks have been OOM Killed.
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10192/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10192/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10191
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10191/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10191/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10191/events
https://github.com/NVIDIA/NeMo/pull/10191
2,471,721,190
PR_kwDOC_bI7s54pn6Z
10,191
Bump `Dockerfile.ci` (2024-08-18)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-18T00:21:40
2024-08-26T22:14:54
2024-08-26T22:14:54
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10191", "html_url": "https://github.com/NVIDIA/NeMo/pull/10191", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10191.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10191.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10191/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10191/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10190
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10190/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10190/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10190/events
https://github.com/NVIDIA/NeMo/pull/10190
2,471,343,507
PR_kwDOC_bI7s54odBt
10,190
override __io__ too in set_model_parallel_attributes
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "closing since already addressed in https://github.com/NVIDIA/NeMo/pull/10204 " ]
2024-08-17T05:09:49
2024-08-20T18:48:03
2024-08-20T18:48:02
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10190", "html_url": "https://github.com/NVIDIA/NeMo/pull/10190", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10190.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10190.patch", "merged_at": null }
# What does this PR do ? related https://github.com/NVIDIA/NeMo/commit/98a0a53ca656e5ceb26ebb224c009fe8b6d4d95c#diff-5b6e58d7bd57dd9253e0fcc5cc1fe788cbb560e021b4d5b9240af46404fed61eR138 **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10190/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10190/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10189
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10189/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10189/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10189/events
https://github.com/NVIDIA/NeMo/pull/10189
2,471,223,794
PR_kwDOC_bI7s54oE9I
10,189
Bump `Dockerfile.ci` (2024-08-17)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-17T00:19:02
2024-08-26T22:14:57
2024-08-26T22:14:57
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10189", "html_url": "https://github.com/NVIDIA/NeMo/pull/10189", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10189.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10189.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10189/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10189/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10188
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10188/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10188/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10188/events
https://github.com/NVIDIA/NeMo/pull/10188
2,471,199,913
PR_kwDOC_bI7s54oAdS
10,188
Parallelism bug
{ "login": "maanug-nv", "id": 109391026, "node_id": "U_kgDOBoUssg", "avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maanug-nv", "html_url": "https://github.com/maanug-nv", "followers_url": "https://api.github.com/users/maanug-nv/followers", "following_url": "https://api.github.com/users/maanug-nv/following{/other_user}", "gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}", "starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions", "organizations_url": "https://api.github.com/users/maanug-nv/orgs", "repos_url": "https://api.github.com/users/maanug-nv/repos", "events_url": "https://api.github.com/users/maanug-nv/events{/privacy}", "received_events_url": "https://api.github.com/users/maanug-nv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4418253970, "node_id": "LA_kwDOC_bI7s8AAAABB1k0kg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS", "name": "TTS", "color": "49AF28", "default": false, "description": "" }, { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 4811888028, "node_id": "LA_kwDOC_bI7s8AAAABHs-VnA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks", "name": "Speaker Tasks", "color": "871AD4", "default": false, "description": "" }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 7079591682, "node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio", "name": "audio", "color": "0DAAC3", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-17T00:00:31
2024-08-19T19:08:02
2024-08-19T19:08:02
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10188", "html_url": "https://github.com/NVIDIA/NeMo/pull/10188", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10188.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10188.patch", "merged_at": null }
# What does this PR do ? Fix parallelism reset bug with reinit in VP. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "maanug-nv", "id": 109391026, "node_id": "U_kgDOBoUssg", "avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maanug-nv", "html_url": "https://github.com/maanug-nv", "followers_url": "https://api.github.com/users/maanug-nv/followers", "following_url": "https://api.github.com/users/maanug-nv/following{/other_user}", "gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}", "starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions", "organizations_url": "https://api.github.com/users/maanug-nv/orgs", "repos_url": "https://api.github.com/users/maanug-nv/repos", "events_url": "https://api.github.com/users/maanug-nv/events{/privacy}", "received_events_url": "https://api.github.com/users/maanug-nv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10188/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10188/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10187
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10187/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10187/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10187/events
https://github.com/NVIDIA/NeMo/pull/10187
2,471,108,955
PR_kwDOC_bI7s54ntVG
10,187
Precision plugin recipes
{ "login": "maanug-nv", "id": 109391026, "node_id": "U_kgDOBoUssg", "avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4", "gravatar_id": "", "url": "https://api.github.com/users/maanug-nv", "html_url": "https://github.com/maanug-nv", "followers_url": "https://api.github.com/users/maanug-nv/followers", "following_url": "https://api.github.com/users/maanug-nv/following{/other_user}", "gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}", "starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions", "organizations_url": "https://api.github.com/users/maanug-nv/orgs", "repos_url": "https://api.github.com/users/maanug-nv/repos", "events_url": "https://api.github.com/users/maanug-nv/events{/privacy}", "received_events_url": "https://api.github.com/users/maanug-nv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Defaults are taken from [this](https://github.com/NVIDIA/Megatron-LM/blob/main/megatron/training/arguments.py#L300-L321) setup in Megatron-LM, and common NeMo 1.0 defaults.", "depends on https://github.com/NVIDIA/NeMo/pull/10129" ]
2024-08-16T22:13:57
2024-08-21T00:14:47
2024-08-21T00:14:45
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10187", "html_url": "https://github.com/NVIDIA/NeMo/pull/10187", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10187.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10187.patch", "merged_at": "2024-08-21T00:14:45" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10187/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10187/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10186
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10186/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10186/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10186/events
https://github.com/NVIDIA/NeMo/pull/10186
2,471,080,977
PR_kwDOC_bI7s54nnQw
10,186
[Tutorial] Audio codec inference
{ "login": "anteju", "id": 108555623, "node_id": "U_kgDOBnhtZw", "avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4", "gravatar_id": "", "url": "https://api.github.com/users/anteju", "html_url": "https://github.com/anteju", "followers_url": "https://api.github.com/users/anteju/followers", "following_url": "https://api.github.com/users/anteju/following{/other_user}", "gists_url": "https://api.github.com/users/anteju/gists{/gist_id}", "starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/anteju/subscriptions", "organizations_url": "https://api.github.com/users/anteju/orgs", "repos_url": "https://api.github.com/users/anteju/repos", "events_url": "https://api.github.com/users/anteju/events{/privacy}", "received_events_url": "https://api.github.com/users/anteju/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4418253970, "node_id": "LA_kwDOC_bI7s8AAAABB1k0kg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS", "name": "TTS", "color": "49AF28", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-16T21:41:17
2024-08-22T21:22:17
2024-08-22T21:22:17
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10186", "html_url": "https://github.com/NVIDIA/NeMo/pull/10186", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10186.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10186.patch", "merged_at": "2024-08-22T21:22:17" }
# What does this PR do ? Adding a tutorial with examples of using audio codec for inference: generating reconstructed audio, computing discrete tokens, and computing latent representation. **Collection**: TTS # Changelog - Added a tutorial notebook - Tested locally and on Google Collab # Usage N/A # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "anteju", "id": 108555623, "node_id": "U_kgDOBnhtZw", "avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4", "gravatar_id": "", "url": "https://api.github.com/users/anteju", "html_url": "https://github.com/anteju", "followers_url": "https://api.github.com/users/anteju/followers", "following_url": "https://api.github.com/users/anteju/following{/other_user}", "gists_url": "https://api.github.com/users/anteju/gists{/gist_id}", "starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/anteju/subscriptions", "organizations_url": "https://api.github.com/users/anteju/orgs", "repos_url": "https://api.github.com/users/anteju/repos", "events_url": "https://api.github.com/users/anteju/events{/privacy}", "received_events_url": "https://api.github.com/users/anteju/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10186/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10186/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10185
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10185/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10185/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10185/events
https://github.com/NVIDIA/NeMo/pull/10185
2,470,846,271
PR_kwDOC_bI7s54m_6s
10,185
fix: cosine annealing linear warmup lr
{ "login": "clumsy", "id": 379115, "node_id": "MDQ6VXNlcjM3OTExNQ==", "avatar_url": "https://avatars.githubusercontent.com/u/379115?v=4", "gravatar_id": "", "url": "https://api.github.com/users/clumsy", "html_url": "https://github.com/clumsy", "followers_url": "https://api.github.com/users/clumsy/followers", "following_url": "https://api.github.com/users/clumsy/following{/other_user}", "gists_url": "https://api.github.com/users/clumsy/gists{/gist_id}", "starred_url": "https://api.github.com/users/clumsy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/clumsy/subscriptions", "organizations_url": "https://api.github.com/users/clumsy/orgs", "repos_url": "https://api.github.com/users/clumsy/repos", "events_url": "https://api.github.com/users/clumsy/events{/privacy}", "received_events_url": "https://api.github.com/users/clumsy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-08-16T19:26:33
2024-09-08T01:58:41
2024-09-08T01:58:40
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10185", "html_url": "https://github.com/NVIDIA/NeMo/pull/10185", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10185.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10185.patch", "merged_at": null }
# What does this PR do ? `CosineAnnealing` LR with linear warmup and `constant_steps` is `0` on the first step. This causes issues for AdamW optimizer which uses LR for `step_size` in the denominator. This is due to the fact on first step when this method is called `step=0` before the first optimizer step is complete. Using the same protection as in: * https://github.com/NVIDIA/NeMo/blob/d2f3f49aea7b282816063dad5ff2f2c3eedfc6cf/nemo/core/optim/lr_scheduler.py#L81 * https://github.com/NVIDIA/NeMo/blob/d2f3f49aea7b282816063dad5ff2f2c3eedfc6cf/nemo/core/optim/lr_scheduler.py#L315 * https://github.com/NVIDIA/NeMo/blob/d2f3f49aea7b282816063dad5ff2f2c3eedfc6cf/nemo/core/optim/lr_scheduler.py#L611 Updated unit tests not to tolerate LR=0. **Collection**: [Note which collection this PR will affect] Core # Changelog - fix cosine annealing linear warmup LR # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [x] Did you write any new necessary tests? - [x] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10185/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10185/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10184
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10184/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10184/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10184/events
https://github.com/NVIDIA/NeMo/pull/10184
2,470,715,802
PR_kwDOC_bI7s54mlDK
10,184
Add Mistral-NeMo 2407 configs
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-08-16T17:57:10
2024-08-19T17:40:11
2024-08-19T17:40:09
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10184", "html_url": "https://github.com/NVIDIA/NeMo/pull/10184", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10184.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10184.patch", "merged_at": "2024-08-19T17:40:09" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10184/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10184/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10183
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10183/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10183/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10183/events
https://github.com/NVIDIA/NeMo/pull/10183
2,470,281,944
PR_kwDOC_bI7s54lF1R
10,183
Drop update_metrics Since It Doesn't Invoke Sync Anymore
{ "login": "alpha0422", "id": 4337967, "node_id": "MDQ6VXNlcjQzMzc5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/4337967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alpha0422", "html_url": "https://github.com/alpha0422", "followers_url": "https://api.github.com/users/alpha0422/followers", "following_url": "https://api.github.com/users/alpha0422/following{/other_user}", "gists_url": "https://api.github.com/users/alpha0422/gists{/gist_id}", "starred_url": "https://api.github.com/users/alpha0422/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alpha0422/subscriptions", "organizations_url": "https://api.github.com/users/alpha0422/orgs", "repos_url": "https://api.github.com/users/alpha0422/repos", "events_url": "https://api.github.com/users/alpha0422/events{/privacy}", "received_events_url": "https://api.github.com/users/alpha0422/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-16T13:29:26
2024-08-16T17:27:28
2024-08-16T17:27:27
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10183", "html_url": "https://github.com/NVIDIA/NeMo/pull/10183", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10183.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10183.patch", "merged_at": "2024-08-16T17:27:27" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "thomasdhc", "id": 9426164, "node_id": "MDQ6VXNlcjk0MjYxNjQ=", "avatar_url": "https://avatars.githubusercontent.com/u/9426164?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thomasdhc", "html_url": "https://github.com/thomasdhc", "followers_url": "https://api.github.com/users/thomasdhc/followers", "following_url": "https://api.github.com/users/thomasdhc/following{/other_user}", "gists_url": "https://api.github.com/users/thomasdhc/gists{/gist_id}", "starred_url": "https://api.github.com/users/thomasdhc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thomasdhc/subscriptions", "organizations_url": "https://api.github.com/users/thomasdhc/orgs", "repos_url": "https://api.github.com/users/thomasdhc/repos", "events_url": "https://api.github.com/users/thomasdhc/events{/privacy}", "received_events_url": "https://api.github.com/users/thomasdhc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10183/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10183/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10182
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10182/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10182/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10182/events
https://github.com/NVIDIA/NeMo/issues/10182
2,470,261,825
I_kwDOC_bI7s6TPTRB
10,182
" ValueError: max() arg is an empty sequence " while converting mamba 2 hybrid checkpoint to nemo
{ "login": "SkanderBS2024", "id": 174276700, "node_id": "U_kgDOCmNAXA", "avatar_url": "https://avatars.githubusercontent.com/u/174276700?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SkanderBS2024", "html_url": "https://github.com/SkanderBS2024", "followers_url": "https://api.github.com/users/SkanderBS2024/followers", "following_url": "https://api.github.com/users/SkanderBS2024/following{/other_user}", "gists_url": "https://api.github.com/users/SkanderBS2024/gists{/gist_id}", "starred_url": "https://api.github.com/users/SkanderBS2024/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SkanderBS2024/subscriptions", "organizations_url": "https://api.github.com/users/SkanderBS2024/orgs", "repos_url": "https://api.github.com/users/SkanderBS2024/repos", "events_url": "https://api.github.com/users/SkanderBS2024/events{/privacy}", "received_events_url": "https://api.github.com/users/SkanderBS2024/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "Hi @SkanderBS2024, I see you are mounting. You are not using the NeMo container `nvcr.io/nvidia/nemo:24.07`, and you are mounting the NeMo. I tested the conversion script in the `nvcr.io/nvidia/nemo:24.07`, and it works fine. However, there is an update needed for the latest main, for which I have raised a PR. https://github.com/NVIDIA/NeMo/pull/10224. You can either checkout this PR or use the 24.07 nemo container. Thanks for reporting the issue!", "hello @JRD971000 , yep i worked with the nvcr.io/nvidia/nemo:24.07 container and everything worked fine thank you for your response. ", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-08-16T13:17:42
2024-09-28T01:57:59
2024-09-28T01:57:58
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** As described in the title, after finishing all of the installs and building nemo and megatron-lm from source, assuming that the model has been trained with megatron-lm. **Steps/Code to reproduce bug** ```python [NeMo W 2024-08-16 12:43:58 nemo_logging:349] /workspace/megatron/Megatron-LM/megatron/core/tensor_parallel/layers.py:280: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead. def forward(ctx, input, weight, bias, allreduce_dgrad): [NeMo W 2024-08-16 12:43:58 nemo_logging:349] /workspace/megatron/Megatron-LM/megatron/core/tensor_parallel/layers.py:290: FutureWarning: `torch.cuda.amp.custom_bwd(args...)` is deprecated. Please use `torch.amp.custom_bwd(args..., device_type='cuda')` instead. def backward(ctx, grad_output): [NeMo W 2024-08-16 12:43:58 nemo_logging:349] /workspace/megatron/Megatron-LM/megatron/core/tensor_parallel/layers.py:380: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead. def forward( [NeMo W 2024-08-16 12:43:58 nemo_logging:349] /workspace/megatron/Megatron-LM/megatron/core/tensor_parallel/layers.py:419: FutureWarning: `torch.cuda.amp.custom_bwd(args...)` is deprecated. Please use `torch.amp.custom_bwd(args..., device_type='cuda')` instead. def backward(ctx, grad_output): [WARNING | megatron.core.dist_checkpointing.strategies.zarr]: `zarr` distributed checkpoint backend is deprecated. Please switch to PyTorch Distributed format (`torch_dist`). [NeMo W 2024-08-16 12:43:59 nemo_logging:349] /workspace/megatron/Megatron-LM/megatron/core/dist_checkpointing/strategies/torch.py:22: DeprecationWarning: `torch.distributed._sharded_tensor` will be deprecated, use `torch.distributed._shard.sharded_tensor` instead from torch.distributed._sharded_tensor import ShardedTensor as TorchShardedTensor [NeMo W 2024-08-16 12:43:59 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/modelopt/torch/quantization/tensor_quant.py:84: FutureWarning: `torch.library.impl_abstract` was renamed to `torch.library.register_fake`. Please use that instead; we will remove `torch.library.impl_abstract` in a future version of PyTorch. scaled_e4m3_abstract = torch.library.impl_abstract("trt::quantize_fp8")( [NeMo W 2024-08-16 12:44:02 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/mamba_ssm/ops/selective_scan_interface.py:164: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead. def forward(ctx, xz, conv1d_weight, conv1d_bias, x_proj_weight, delta_proj_weight, [NeMo W 2024-08-16 12:44:02 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/mamba_ssm/ops/selective_scan_interface.py:240: FutureWarning: `torch.cuda.amp.custom_bwd(args...)` is deprecated. Please use `torch.amp.custom_bwd(args..., device_type='cuda')` instead. def backward(ctx, dout): [NeMo W 2024-08-16 12:44:02 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/mamba_ssm/ops/triton/layer_norm.py:959: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead. def forward( [NeMo W 2024-08-16 12:44:02 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/mamba_ssm/ops/triton/layer_norm.py:1018: FutureWarning: `torch.cuda.amp.custom_bwd(args...)` is deprecated. Please use `torch.amp.custom_bwd(args..., device_type='cuda')` instead. def backward(ctx, dout, *args): [NeMo W 2024-08-16 12:44:02 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/mamba_ssm/distributed/tensor_parallel.py:26: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead. def forward(ctx, x, weight, bias, process_group=None, sequence_parallel=True): [NeMo W 2024-08-16 12:44:02 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/mamba_ssm/distributed/tensor_parallel.py:62: FutureWarning: `torch.cuda.amp.custom_bwd(args...)` is deprecated. Please use `torch.amp.custom_bwd(args..., device_type='cuda')` instead. def backward(ctx, grad_output): [NeMo W 2024-08-16 12:44:03 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/mamba_ssm/ops/triton/ssd_combined.py:736: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead. def forward(ctx, zxbcdt, conv1d_weight, conv1d_bias, dt_bias, A, D, chunk_size, initial_states=None, seq_idx=None, dt_limit=(0.0, float("inf")), return_final_states=False, activation="silu", [NeMo W 2024-08-16 12:44:03 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/mamba_ssm/ops/triton/ssd_combined.py:814: FutureWarning: `torch.cuda.amp.custom_bwd(args...)` is deprecated. Please use `torch.amp.custom_bwd(args..., device_type='cuda')` instead. def backward(ctx, dout, *args): Traceback (most recent call last): File "/workspace/nemo/NeMo/scripts/checkpoint_converters/convert_mamba2_pyt_to_nemo.py", line 190, in <module> convert(args) File "/workspace/nemo/NeMo/scripts/checkpoint_converters/convert_mamba2_pyt_to_nemo.py", line 115, in convert num_layers = max(layer_numbers) + 1' ``` **Expected behavior** Expected to convert the mamba trained model to a .nemo format for fine-tuning. **Environment overview (please complete the following information)** - Environment location: ubuntu, Docker, fluidstack VM 2 * A100 80. - Method of NeMo install: Installed from source and integrated megatron from source. - If method of install is [Docker], provide `docker pull` & `docker run` commands used : Docker pull command : ```bash sudo docker pull nvcr.io/nvidia/pytorch:24.07-py3 ``` Docker Run command : ```bash docker run --gpus all -it --rm --ipc=host \ --shm-size=40g \ -v /ephemeral/megatron:/workspace/megatron \ -v /ephemeral/data:/workspace/dataset/data \ -v /ephemeral/outfix:/workspace/dataset/outfix \ -v /ephemeral/tok:/workspace/dataset/tok \ -v /ephemeral/checkpoints:/workspace/checkpoints \ -v /ephemeral/nemo:/workspace/nemo \ nvcr.io/nvidia/pytorch:24.07-py3 ``` **Environment details** If NVIDIA docker image is used you don't need to specify these. Otherwise, please provide: - OS version : Ubuntu 22.04.3 LTS - PyTorch version : 2.4 - Python version : 3.10.12 **Additional context** Nvidia pytorch container : 24.07 (assmuming training was made with 24.03) GPUS : 2 * GPU A100 80 Followed steps here : tutorials/llm/mamba/mamba.rst
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10182/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10182/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10181
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10181/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10181/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10181/events
https://github.com/NVIDIA/NeMo/pull/10181
2,470,072,015
PR_kwDOC_bI7s54kXuW
10,181
ci: Selective triggering
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-16T11:22:39
2024-08-16T11:22:51
2024-08-16T11:22:45
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10181", "html_url": "https://github.com/NVIDIA/NeMo/pull/10181", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10181.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10181.patch", "merged_at": "2024-08-16T11:22:45" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10181/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10181/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10180
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10180/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10180/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10180/events
https://github.com/NVIDIA/NeMo/pull/10180
2,470,064,088
PR_kwDOC_bI7s54kV8z
10,180
Replace usage of np.sctypes with np.issubdtype
{ "login": "scarecrow1123", "id": 3162105, "node_id": "MDQ6VXNlcjMxNjIxMDU=", "avatar_url": "https://avatars.githubusercontent.com/u/3162105?v=4", "gravatar_id": "", "url": "https://api.github.com/users/scarecrow1123", "html_url": "https://github.com/scarecrow1123", "followers_url": "https://api.github.com/users/scarecrow1123/followers", "following_url": "https://api.github.com/users/scarecrow1123/following{/other_user}", "gists_url": "https://api.github.com/users/scarecrow1123/gists{/gist_id}", "starred_url": "https://api.github.com/users/scarecrow1123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/scarecrow1123/subscriptions", "organizations_url": "https://api.github.com/users/scarecrow1123/orgs", "repos_url": "https://api.github.com/users/scarecrow1123/repos", "events_url": "https://api.github.com/users/scarecrow1123/events{/privacy}", "received_events_url": "https://api.github.com/users/scarecrow1123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-08-16T11:18:10
2024-09-08T01:58:42
2024-09-08T01:58:41
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10180", "html_url": "https://github.com/NVIDIA/NeMo/pull/10180", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10180.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10180.patch", "merged_at": null }
# What does this PR do ? Remove usage of `np.sctypes` that is not supported anymore with Numpy 2.x. ASR inference from scripts such as `transcribe_speech.py` was broken because of this. **Collection**: ASR # Changelog - Replace usage of `np.sctypes` with `np.issubdtype` to fix this. # Usage NA # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? @titu1994 # Additional Information NA
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10180/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10180/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10179
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10179/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10179/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10179/events
https://github.com/NVIDIA/NeMo/pull/10179
2,470,063,445
PR_kwDOC_bI7s54kVzX
10,179
ci: Dispatch single jobs
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-16T11:17:52
2024-08-16T11:21:33
2024-08-16T11:21:32
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10179", "html_url": "https://github.com/NVIDIA/NeMo/pull/10179", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10179.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10179.patch", "merged_at": "2024-08-16T11:21:32" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10179/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10179/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10178
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10178/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10178/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10178/events
https://github.com/NVIDIA/NeMo/issues/10178
2,469,815,325
I_kwDOC_bI7s6TNmQd
10,178
FSDP is not integrated across code base
{ "login": "janEbert", "id": 12694897, "node_id": "MDQ6VXNlcjEyNjk0ODk3", "avatar_url": "https://avatars.githubusercontent.com/u/12694897?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janEbert", "html_url": "https://github.com/janEbert", "followers_url": "https://api.github.com/users/janEbert/followers", "following_url": "https://api.github.com/users/janEbert/following{/other_user}", "gists_url": "https://api.github.com/users/janEbert/gists{/gist_id}", "starred_url": "https://api.github.com/users/janEbert/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janEbert/subscriptions", "organizations_url": "https://api.github.com/users/janEbert/orgs", "repos_url": "https://api.github.com/users/janEbert/repos", "events_url": "https://api.github.com/users/janEbert/events{/privacy}", "received_events_url": "https://api.github.com/users/janEbert/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[ "Sorry, we didn't reply to your comment, but we did read it.\r\n\r\nWe don't plan to make updates to FSDP for NeMo 1.0 but NeMo 2.0 FSDP support will continue to be maintained.\r\n\r\nI'm going to go close this issue, if there's a specific bug or feature request with NeMo 2.0 + FSDP please file a new issue with details. \r\n\r\n", "Thank you for the honest answer! I know it's a separate issue bit I wish you could address the PR reviewing issue as well. What are ways to actually get PRs looked at as a non-NVIDIA employee?" ]
2024-08-16T08:49:16
2024-08-22T07:07:59
2024-08-21T17:30:40
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Since it seems like [my comment in the FSDP PR for NeMo 2.0](https://github.com/NVIDIA/NeMo/pull/9748#issuecomment-2268403302) was missed in the activities of code reviews, I wrote this issue to raise visibility for the current problems with FSDP integration in NeMo. To summarize the original comment, FSDP support is really not well-integrated across the code base. Many scripts do not work with it because they only implement `NLPDDPStrategy`, checkpoint conversion was a huge undertaking to get working (PR pending), and some feature flags straight-up [don't work](https://github.com/NVIDIA/NeMo/issues/9531) or [had bugs](https://github.com/NVIDIA/NeMo/pull/9335). The original reason for the comment was desiring a better integration in NeMo 2.X since FSDP actually achieves better performance with default settings compared to 4D parallelism. There is also desire to help with this; however, because of past/current experiences with PRs getting ignored, my motivation to fix things in this public code without prior discussion is highly limited. I don't want to have to post redundant comments to even more PRs to prevent them from getting closed as "stale due to no activity".
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10178/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10178/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10177
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10177/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10177/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10177/events
https://github.com/NVIDIA/NeMo/pull/10177
2,469,667,774
PR_kwDOC_bI7s54i_ek
10,177
Support to use te-dpa for sd model.
{ "login": "Dido0o0", "id": 16295526, "node_id": "MDQ6VXNlcjE2Mjk1NTI2", "avatar_url": "https://avatars.githubusercontent.com/u/16295526?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Dido0o0", "html_url": "https://github.com/Dido0o0", "followers_url": "https://api.github.com/users/Dido0o0/followers", "following_url": "https://api.github.com/users/Dido0o0/following{/other_user}", "gists_url": "https://api.github.com/users/Dido0o0/gists{/gist_id}", "starred_url": "https://api.github.com/users/Dido0o0/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Dido0o0/subscriptions", "organizations_url": "https://api.github.com/users/Dido0o0/orgs", "repos_url": "https://api.github.com/users/Dido0o0/repos", "events_url": "https://api.github.com/users/Dido0o0/events{/privacy}", "received_events_url": "https://api.github.com/users/Dido0o0/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "Please rebase against upstream/main to allow us running the CI", "Could you please rebase the branch to remove irrelevant changes first? ", "Dido is busy with other stuff, I made some modification on top of her changes.\r\nHere is the new PR: https://github.com/NVIDIA/NeMo/pull/10288, please review there, thanks!\r\nClosing this one." ]
2024-08-16T07:19:42
2024-08-29T01:25:14
2024-08-29T01:25:14
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10177", "html_url": "https://github.com/NVIDIA/NeMo/pull/10177", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10177.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10177.patch", "merged_at": null }
# What does this PR do ? This PR is to enable the Stable Diffusion model can take use of DotProductAttention in addition to FlashAttention. To enable TE-DotProductAttention, users can set config use_te_dpa to be True. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "Dido0o0", "id": 16295526, "node_id": "MDQ6VXNlcjE2Mjk1NTI2", "avatar_url": "https://avatars.githubusercontent.com/u/16295526?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Dido0o0", "html_url": "https://github.com/Dido0o0", "followers_url": "https://api.github.com/users/Dido0o0/followers", "following_url": "https://api.github.com/users/Dido0o0/following{/other_user}", "gists_url": "https://api.github.com/users/Dido0o0/gists{/gist_id}", "starred_url": "https://api.github.com/users/Dido0o0/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Dido0o0/subscriptions", "organizations_url": "https://api.github.com/users/Dido0o0/orgs", "repos_url": "https://api.github.com/users/Dido0o0/repos", "events_url": "https://api.github.com/users/Dido0o0/events{/privacy}", "received_events_url": "https://api.github.com/users/Dido0o0/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10177/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10177/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10176
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10176/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10176/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10176/events
https://github.com/NVIDIA/NeMo/pull/10176
2,469,630,642
PR_kwDOC_bI7s54i3WY
10,176
Akoumparouli/te lora gemm fork
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "Can we rebase this to the TOT?", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-08-16T06:56:46
2024-10-12T01:57:13
2024-10-12T01:57:12
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10176", "html_url": "https://github.com/NVIDIA/NeMo/pull/10176", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10176.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10176.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10176/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10176/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10175
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10175/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10175/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10175/events
https://github.com/NVIDIA/NeMo/issues/10175
2,469,298,906
I_kwDOC_bI7s6TLoLa
10,175
Eval_beamsearch_ngram_ctc throws got an unexpected keyword argument 'logprobs'
{ "login": "carlfm01", "id": 32177100, "node_id": "MDQ6VXNlcjMyMTc3MTAw", "avatar_url": "https://avatars.githubusercontent.com/u/32177100?v=4", "gravatar_id": "", "url": "https://api.github.com/users/carlfm01", "html_url": "https://github.com/carlfm01", "followers_url": "https://api.github.com/users/carlfm01/followers", "following_url": "https://api.github.com/users/carlfm01/following{/other_user}", "gists_url": "https://api.github.com/users/carlfm01/gists{/gist_id}", "starred_url": "https://api.github.com/users/carlfm01/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/carlfm01/subscriptions", "organizations_url": "https://api.github.com/users/carlfm01/orgs", "repos_url": "https://api.github.com/users/carlfm01/repos", "events_url": "https://api.github.com/users/carlfm01/events{/privacy}", "received_events_url": "https://api.github.com/users/carlfm01/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "karpnv", "id": 1645775, "node_id": "MDQ6VXNlcjE2NDU3NzU=", "avatar_url": "https://avatars.githubusercontent.com/u/1645775?v=4", "gravatar_id": "", "url": "https://api.github.com/users/karpnv", "html_url": "https://github.com/karpnv", "followers_url": "https://api.github.com/users/karpnv/followers", "following_url": "https://api.github.com/users/karpnv/following{/other_user}", "gists_url": "https://api.github.com/users/karpnv/gists{/gist_id}", "starred_url": "https://api.github.com/users/karpnv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/karpnv/subscriptions", "organizations_url": "https://api.github.com/users/karpnv/orgs", "repos_url": "https://api.github.com/users/karpnv/repos", "events_url": "https://api.github.com/users/karpnv/events{/privacy}", "received_events_url": "https://api.github.com/users/karpnv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "karpnv", "id": 1645775, "node_id": "MDQ6VXNlcjE2NDU3NzU=", "avatar_url": "https://avatars.githubusercontent.com/u/1645775?v=4", "gravatar_id": "", "url": "https://api.github.com/users/karpnv", "html_url": "https://github.com/karpnv", "followers_url": "https://api.github.com/users/karpnv/followers", "following_url": "https://api.github.com/users/karpnv/following{/other_user}", "gists_url": "https://api.github.com/users/karpnv/gists{/gist_id}", "starred_url": "https://api.github.com/users/karpnv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/karpnv/subscriptions", "organizations_url": "https://api.github.com/users/karpnv/orgs", "repos_url": "https://api.github.com/users/karpnv/repos", "events_url": "https://api.github.com/users/karpnv/events{/privacy}", "received_events_url": "https://api.github.com/users/karpnv/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "The fix from #8884 worked for me. See [this commit](https://github.com/aklemen/NeMo/commit/69fa4bb7cd42d135d1925ea632cc4745840013e3).\r\n\r\nBut I am using `decoding_strategy=\"beam\"` and without KenLM.", "> The fix from #8884 worked for me. See [this commit](https://github.com/aklemen/NeMo/commit/69fa4bb7cd42d135d1925ea632cc4745840013e3).\r\n\r\nIt works only without using KenLM. I need KenLM to find the optimal alpha and beta values to deploy it to RIVA.", "@karpnv can you review this ?", "¿Any updates? Still blocked and unable to deploy to RIVA.", "I'm having the same issue. What worked for me was implementing the same changes mentioned by @aklemen and changing `_wer` in this [line](https://github.com/NVIDIA/NeMo/blob/265bd739c77c86ac423942d650eed6fc232e4fc6/scripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_ctc.py#L353) to `wer`. I'm using KenLM with default parameters.", "> I'm having the same issue. What worked for me was implementing the same changes mentioned by [@aklemen](https://github.com/aklemen) and changing `_wer` in this [line](https://github.com/NVIDIA/NeMo/blob/265bd739c77c86ac423942d650eed6fc232e4fc6/scripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_ctc.py#L353) to `wer`. I'm using KenLM with default parameters.\n\nThanks for the suggestion, but I’ve already tried those changes before, and I’m still facing the same issue. It works perfectly in Riva, but I can't get it to work in NeMo.", "Hi, @karpnv. any update regarding this? I'm facing the same issue.", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-08-16T02:18:11
2024-11-20T02:01:34
2024-11-20T02:01:29
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Unable to use KenLM rescore due to missing logprobs on transcribe. **Steps/Code to reproduce the bug** 1. Cloned the repo [7916269](https://github.com/NVIDIA/NeMo/commit/79162696ea8c48734a260dd2dfd6e60602d73a22). 2. Used script `scripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_ctc.py`. It throws the following error: `TypeError: EncDecCTCModel.transcribe() got an unexpected keyword argument 'logprobs'`. 3. Applied the change suggested on https://github.com/NVIDIA/NeMo/issues/8884#issuecomment-2049063944. ```python Logits_hyps = asr_model.transcribe( self.audio_file_list, batch_size=self.asr_batch_size, return_hypotheses=True ) # type: List[nemo_asr.parts.Hypothesis] Logits = [hyp.alignments for hyp in Logits_hyps] ``` With this change, a new error occurs: ``` [NeMo I 2024-08-13 19:24:30 ctc_decoding:359] Beam search requires that consecutive CTC tokens are not folded. Overriding provided value of `fold_consecutive` = True to False Segmentation fault (core dumped) ``` 4. I thought it was KenLM failing, so I applied this fix: https://github.com/flashlight/wav2letter/issues/875, but it did not work. I've searched more in the docs, PR, and comments and discovered the karpnv/beamsearch branch from https://github.com/NVIDIA/NeMo/pull/8428. Using the beamsearch branch, I'm still unable to search for alpha and beta values. The command: ```bash python eval_beamsearch_ngram_ctc.py \ model_path=/media/carlos/asr/Conformer-CTC-BPE.nemo \ dataset_manifest=/media/carlos/asr/asr/supervised/test-files/test-all.json \ preds_output_folder=preds/ \ cache_file=null \ ctc_decoding.beam.kenlm_path=/media/carlos/asr/conformerlm3.binary \ ctc_decoding.beam.flashlight_cfg.lexicon_path=/media/carlos/asr/conformerlm3.binary.tmp.lexicon \ ctc_decoding.beam.beam_size=[100,200,500] \ ctc_decoding.beam.beam_alpha=[1,2,3,4] \ ctc_decoding.beam.beam_beta=[1,2,3,4] \ ctc_decoding.strategy=flashlight ``` Shows this error: ``` raise NotImplementedError("Wrong parameter combination") NotImplementedError: Wrong parameter combination ``` ¿Any updated guide or help? It will be greatly appreciated. I can provide any extra details if needed. **Expected behavior** Being able to search alpha and beta using the generated KenLM. We need those values to use RIVA. **Environment overview (please complete the following information)** - **Environment location**: Bare-metal - **Method of NeMo install**: From source using `./reinstall.sh` **Environment details** - **OS version**: Ubuntu 22.04.3 LTS - **PyTorch version**: 2.4.0+cu121 - **Python version**: 3.10.12 **Additional context** - **GPU model**: Nvidia A100
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10175/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10175/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/10174
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10174/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10174/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10174/events
https://github.com/NVIDIA/NeMo/pull/10174
2,469,192,871
PR_kwDOC_bI7s54hW_5
10,174
Bump `Dockerfile.ci` (2024-08-16)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-16T00:19:41
2024-08-26T22:15:00
2024-08-26T22:15:00
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10174", "html_url": "https://github.com/NVIDIA/NeMo/pull/10174", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10174.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10174.patch", "merged_at": null }
🚀 PR to Bump `Dockerfile.ci`. 📝 Please remember the following to-do's before merge: - [ ] Verify the presubmit CI 🙏 Please merge this PR only if the CI workflow completed successfully.
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10174/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10174/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10173
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10173/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10173/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10173/events
https://github.com/NVIDIA/NeMo/pull/10173
2,469,117,773
PR_kwDOC_bI7s54hGi1
10,173
Update CHANGELOG.md
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-08-15T22:55:07
2024-08-15T22:55:16
2024-08-15T22:55:14
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10173", "html_url": "https://github.com/NVIDIA/NeMo/pull/10173", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10173.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10173.patch", "merged_at": "2024-08-15T22:55:14" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10173/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10173/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10172
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10172/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10172/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10172/events
https://github.com/NVIDIA/NeMo/pull/10172
2,469,106,971
PR_kwDOC_bI7s54hENu
10,172
docs: Update changelog
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-08-15T22:41:34
2024-08-15T22:42:01
2024-08-15T22:41:59
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10172", "html_url": "https://github.com/NVIDIA/NeMo/pull/10172", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10172.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10172.patch", "merged_at": "2024-08-15T22:41:59" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10172/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10172/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10171
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10171/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10171/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10171/events
https://github.com/NVIDIA/NeMo/pull/10171
2,469,064,277
PR_kwDOC_bI7s54g9IK
10,171
[Docs] Fix doc warnings, focus on feature and multimodal sections
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Copyedits for docs/source/features/optimizations/activation_recomputation.rst.\r\n\r\nLines 4-6. fix punctuation and revise.\r\n\r\nThe input activations of network layers are stored in device memory and are used to compute gradients during back-propagation. When training a LLM with a long sequence length or a large micro-batch size, these input activations can quickly saturate device memory. Checkpointing a few activations and recomputing the rest is a common technique to reduce device memory usage.\r\n\r\nLines 11 -13. fix capitalization, fix punctutation, and revise.\r\n\r\nNeMo supports transformer layer recomputation, which checkpoints the input of each transformer layer and recomputes the activations for the remaining layers. This technique significantly reduces activation memory usage. However, it increases the per-transformer layer computation cost by 30% due to re-executing the entire layer’s forward computation. \r\n\r\nLines 14-15. verify this sentence the sentence; it appears to be missing text. suggested revision.\r\n\r\nNeMo also supports partial transformer layer recomputation, which is beneficial when recomputing a few transformer layers to fit the training workload on GPU memory. This approach avoids the need to recompute the rest of the layers.\r\n\r\nLines 18 fix capitalization and use a second-person pronoun.\r\n\r\nYou can set the number of transformer layers to recompute using ``activations_checkpoint_num_layers`` along with ``activations_checkpoint_method=block``.\r\n\r\nLine 19 fix capitalization, fix punctuation, use a second-person pronoun.\r\n\r\nIf you set ``activations_checkpoint_num_layers`` as the total number of layers, the inputs of all transformer layers are checkpointed and recomputed.\r\n\r\nLine 21. revise.\r\n\r\nWhen using virtual pipelining, activations_checkpoint_num_layers specifies the number of layers per virtual pipeline stage.\r\n\r\nLines 23-25. fix capitalization, fix punctuation, and revise.\r\n\r\nNeMo also supports checkpointing the input to a block of multiple consecutive transformer layers, meaning that a block of transformer layers becomes the recomputation granularity. This approach can save activation memory but increases the recomputation buffer memory. Thus, it is only beneficial for memory savings when the model has many transformer layers or when the intermediate layers of a transformer layer hold relatively small activation stores.\r\n\r\nLine 26. fix capitalization and revise.\r\n\r\nThis recomputation mode can be enabled by setting ``activations_checkpoint_method=uniform``, with the number of transformer layers per recomputation block set using ``activations_checkpoint_num_layers``.\r\n\r\nLine 32. fix punctuation and revise.\r\n\r\nThis cost-efficient method achieves high memory savings with minimal recomputation cost.\r\n\r\nLine 33. revise.\r\n\r\nThe intermediate layers of the self-attention block accounts for the majority of the activation memory.\r\n\r\nLine 38. use second-person pronoun.\r\n\r\nAlso, you can use the self-attention recomputation without FlashAttention by setting ``activations_checkpoint_granularity=selective``.\r\n\r\n", "Copyedits for asr_language_modeling_and_customization.rst.\r\n\r\nLines 22 -23. revise.\r\n\r\nThe beam search decoders and KenLM library are not installed by default in NeMo. You need to install them to be able to use beam search decoding and N-gram LM.\r\n\r\nLines 37 - 40. revise.\r\n\r\nThe parameter 'beam_alpha' determines the weight given to the N-gram language model, while 'beam_beta' is a penalty term that accounts for sequence length in the scores. A larger 'beam_alpha' places more emphasis on the language model and less on the acoustic model. Negative values for 'beam_beta' penalize longer sequences, encouraging the decoder to prefer shorter predictions. Conversely, positive values for 'beam_beta' favor longer candidates.\r\n\r\nLine 47. fix punctuation.\r\n\r\nThe script to train an N-gram language model with KenLM can be found at:\r\n\r\nLines 50 - 52. revise.\r\n\r\nThis script trains an N-gram language model with the KenLM library which can then be used with the beam search decoders on top of the ASR models. This script also supports both character-level and BPE-level encodings and models which are detected automatically from the model type.\r\n\r\nLine 55. revise.\r\n\r\nYou can train the N-gram model using the following:\r\n\r\nLine 68. fix capitalization, fix punctuation, and revise.\r\n\r\nFor the JSON manifests, the file must contain JSON-formatted samples per each line like this:\r\n\r\nLine 74 - 75. revise.\r\n\r\nThis code extracts the `text` field from each line to create the training text file. After the N-gram model is trained, it is stored at the path specified by `kenlm_model_file`.\r\n\r\nLine 101. revise note in rst format.\r\n\r\n..note:: \r\n It is recommended that you use 6 as the order of the N-gram model for BPE-based models. Higher orders may require re-compiling KenLM to support them.\r\n\r\nLine 110. fix punctuation.\r\n\r\nThis script has a large number of possible argument overrides; therefore, it is recommended that you use ``python eval_beamsearch_ngram.py --help`` to see the full list of arguments.\r\n\r\nLine 112. revise.\r\n\r\nYou can evaluate an ASR model using the following:\r\n\r\nLine 127. revise.\r\n\r\nIt can evaluate a model in the following three modes by setting the argument `--decoding_mode`:\r\n\r\nLine 129. fix punctuation.\r\n\r\ngreedy: Just greedy decoding is done and no beam search decoding is performed.\r\n\r\nLine 130. fix punctuation and revise.\r\n\r\nbeamsearch: The beam search decoding is done, but without using the N-gram language model. Final results are equivalent to setting the weight of LM (beam_beta) to zero.\r\n\r\nLines 133 - 136. revise.\r\n\r\nIn `beamsearch` mode, the evaluation is performed using beam search decoding without any language model. The performance is reported in terms of Word Error Rate (WER) and Character Error Rate (CER). Moreover, when the best candidate is selected among the candidates, it is also reported as the best WER/CER. This can serve as an indicator of the quality of the predicted candidates.\r\n\r\nLine 138 - 144. revise.\r\n\r\nThe script initially loads the ASR model and predicts the outputs of the model's encoder as log probabilities. This part is computed in batches on a device specified by --device, which can be either a CPU (--device=cpu) or a single GPU (--device=cuda:0). \r\n\r\nThe batch size for this part is specified by --acoustic_batch_size. Using the largest feasible batch size can speed up the calculation of log probabilities. Additionally, you can use --use_amp to accelerate the calculation and allow for larger --acoustic_batch_size values.\r\n\r\nCurrently, multi-GPU support is not available for calculating log probabilities. However, using --probs_cache_file can help. This option stores the log probabilities produced by the model’s encoder in a pickle file, allowing you to skip the first step in future runs.\r\n\r\nLine 194. revise.\r\n\r\nThe width of the beam search (--beam_width) specifies the number of top candidates or predictions the beam search decoder will consider. Larger beam widths result in more accurate but slower predictions.\r\n\r\nLines 198 - 201. Fix note formatting. Delete line 198. The text should appear on the next line after ..note::\r\n\r\n.. note::\r\n The ``eval_beamsearch_ngram.py`` script contains the entire subconfig used for CTC Beam Decoding.\r\n Therefore it is possible to forward arguments for various beam search libraries such as ``flashlight``\r\n and ``pyctcdecode`` via the ``decoding`` subconfig.\r\n\r\nLines 203 - 204 revise and fix punctuation.\r\n\r\nTo learn more about evaluating the ASR models with N-gram LM, refer to the tutorial here: Offline ASR Inference with Beam Search and External Language Model Rescoring <https://colab.research.google.com/github/NVIDIA/NeMo/blob/stable/tutorials/asr/Offline_ASR.ipynb>`_.\r\n\r\nLine 209. fix punctuation.\r\n\r\nNeMo ASR CTC supports multiple beam search engines for decoding. The default engine is beam, which is the OpenSeq2Seq decoding library.\r\n\r\nLine 215. revise.\r\n\r\nOpenSeq2Seq is a CPU-based beam search engine that is quite efficient and supports char and subword models. It requires a character/subword KenLM model to be provided.\r\n\r\nLine 223. fix punctuation.\r\n\r\nFlashlight is a C++ library for ASR decoding provided at `https://github.com/flashlight/flashlight <https://github.com/flashlight/flashlight>`_. It is a CPU- and CUDA-based beam search engine that is quite efficient and supports char and subword models. It requires an ARPA KenLM file.\r\n\r\nLine 226. fix punctuation.\r\n\r\nIt supports several advanced features, such as lexicon-based decoding, lexicon-free decoding, beam pruning threshold, and more.\r\n\r\nLine 257. fix capitalization.\r\n\r\nPyCTCDecode is a Python library for ASR decoding provided at `https://github.com/kensho-technologies/pyctcdecode <https://github.com/kensho-technologies/pyctcdecode>`_. It is a CPU-based beam search engine that is somewhat efficient for a pure Python library, and supports char and subword models. It requires a character/subword KenLM ARPA / BINARY model to be provided.\r\n\r\nLine 259. fix punctuation.\r\n\r\nIt has advanced features, such as word boosting, which can be useful for transcript customization.\r\n\r\nLines 286 - 289. revise.\r\n\r\nThe accuracy of the model is dependent on the values of these parameters, specifically, beam_alpha and beam_beta. To perform grid search, you can specify a single value or a list of values for each of these parameters. In this case, it would perform the beam search decoding on all combinations of the three hyperparameters.\r\nFor example, the following set of parameters would result in 2*1*2=4 beam search decodings:\r\n\r\nLine 299. fix capitalization.\r\n\r\nBeam Search ngram Decoding for Transducer Models (RNNT and HAT)\r\n\r\nLines 202 - 302. fix punctuation and revise.\r\n\r\nYou can also find a similar script to evaluate an RNNT/HAT model with beam search decoding and N-gram models at: `scripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py <https://github.com/NVIDIA/NeMo/blob/stable/scripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py>`_.\r\n\r\nLines 328 - 331. revise.\r\n\r\nWhen using the neural rescoring approach, a neural network is used to score candidates. A candidate is the text transcript predicted by the ASR model’s decoder. The top K candidates produced by beam search decoding (with a beam width of K) are given to a neural language model for ranking. The language model assigns a score to each candidate, which is usually combined with the scores from beam search decoding to produce the final scores and rankings.\r\n\r\nLine 341. revise.\r\n\r\nYou can also use a pretrained language model from the Hugging Face library, such as Transformer-XL and GPT, instead of training your model.\r\n\r\nLine 342. revise.\r\n\r\nModels like BERT and RoBERTa are not supported by this script because they are trained as Masked Language Models. As a result, they are not efficient or effective for scoring sentences out of the box.\r\n\r\nLine 352. revise.\r\n\r\nsearch decoding or the result of fusion with an N-gram LM. You can generate this file by specifying `--preds_output_folder` for\r\n\r\nLine 355. revise.\r\n\r\nThe neural rescorer would rescore the beams/candidates by using two parameters of `rescorer_alpha` and `rescorer_beta`, as follows:\r\n\r\nLines 361 - 363. revise.\r\n\r\nThe parameter `rescorer_alpha` specifies the importance placed on the neural rescorer model, while `rescorer_beta` is a penalty term that accounts for sequence length in the scores. These parameters have similar effects to `beam_alpha` and `beam_beta` in the beam search decoder and N-gram language model.\r\n\r\nLine 365. revise.\r\n\r\nUse the following steps to evaluate a neural LM:\r\n\r\nLine 386. fix punctuation.\r\n\r\nThe candidates, along with their new scores, are stored at the file specified by `--scores_output_file`.\r\n\r\nLines 393 - 394 fix punctuation and name.\r\n\r\nThe path of the '.nemo' file of an ASR model or the name of a Hugging Face pretrained model, such as 'transfo-xl-wt103' or 'gpt2'.\r\n\r\nLine 396. fix punctuation.\r\n\r\nPath to the evaluation manifest file (.json manifest file).\r\n\r\nLine 397. fix capitalization.\r\n\r\nPath to beams file (.tsv) containing the candidates and their scores.\r\n\r\nLines 398, 400, 402, 403, 405, 406, 408, 410, 412, 4414, 416. and 417. Add a period at the end of the sentences in the Description column.\r\n\r\nLines 424 - 429. revise.\r\n\r\nThe hyperparameter linear search script also supports linear search for parameters `alpha` and `beta`. If any of the two is not\r\nprovided, a linear search is performed to find the best value for that parameter. When linear search is used, initially\r\n`beta` is set to zero and the best value for `alpha` is found, then `alpha` is fixed with\r\nthat value and another linear search is done to find the best value for `beta`.\r\nIf any of the of these two parameters is already specified, then search for that one is skipped. After each search for a\r\nparameter, the plot of WER% for different values of the parameter is also shown.\r\n\r\nLines 438 - 441. fix punctuation and revise.\r\n\r\nThe Flashlight decoder supports word boosting during CTC decoding using a KenLM binary and corresponding lexicon. Word boosting only works in lexicon-decoding mode and does not function in lexicon-free mode. It allows you to bias the decoder for certain words by manually increasing or decreasing the probability of emitting specific words. This can be very helpful if you have uncommon or industry-specific terms that you want to ensure are transcribed correctly.\r\n\r\nLine 443 revise.\r\n\r\nFor more information, go to `word boosting <https://docs.nvidia.com/deeplearning/riva/user-guide/docs/asr/asr-customizing.html#word-boosting>`__.\r\n\r\nLines 445 - 446. fix capitalization, fix punctuation, and revise.\r\n\r\nTo use word boosting in NeMo, create a simple tab-separated text file. Each line should contain a word to be boosted, followed by a tab, and then the boosted score for that word.\r\n\r\nLine 463. fix capitalization.\r\n\r\nYou can then pass this file to your Flashlight config object during decoding:\r\n\r\nLines 479 - 480. revise.\r\n\r\nBefore combining N-gram LMs, install the required OpenGrm NGram library using `scripts/installers/install_opengrm.sh <https://github.com/NVIDIA/NeMo/blob/stable/scripts/installers/install_opengrm.sh>`__.\r\n\r\nAlternatively, you can use the Docker image at: `scripts/installers/Dockerfile.ngramtools <https://github.com/NVIDIA/NeMo/blob/stable/scripts/installers/Dockerfile.ngramtools>`__, which includes all the necessary dependencies.\r\n\r\nLine 485. revise.\r\n\r\nThis script interpolates two ARPA N-gram language models and creates a KenLM binary file that can be used with the beam search decoders on top of ASR models.\r\n\r\nLine 487. fix punctuation.\r\n\r\nThis script supports both character-level and BPE-level encodings and models, which are detected automatically based on the type of the model.\r\n\r\nLine 504. revise.\r\n\r\nNote that the result of each step during the process is cached in a temporary file in the --out_path to speed up future runs.\r\n\r\nLines 531, 533, 535, 537, and 547. Add a period at the end of the sentences in the Description column.\r\n\r\nLine 552. fix capitalization.\r\n\r\nContext-biasing (Word Boosting) without External LM\r\n\r\nLines 602 -604. add periods at end of sentence.\r\n\r\n* ``beam_threshold`` - threshold for CTC-WS beam pruning.\r\n* ``context_score`` - per token weight for context biasing.\r\n* ``ctc_ali_token_weight`` - per token weight for CTC alignment (prevents false acceptances of context-biasing words).\r\n\r\nLine 626. revise.\r\n\r\nTo use Transducer head of the Hybrid Transducer-CTC model, set ``decoder_type=rnnt``.", "copyedits for docs/source/multimodal/text2img/insp2p.rst.\r\n\r\nLine 16. revise link.\r\n\r\nFor instructions on downloading and preparing the custom dataset for training InstructPix2Pix, refer to the official `Instruct-Pix2Pix Repository <https://github.com/timothybrooks/instruct-pix2pix#generated-dataset>`_.\r\n\r\nLines 49 - 52. revise nested bullet formatting for - ``unet_config``. Add a blank line after Line 49 and before Line 50 (where the nest starts).\r\n\r\n- ``unet_config``: Configuration parameters for the UNet model within the NeMo collection.\r\n\r\n - ``_target_``: Designates the target module for the UNet model in the NeMo collection.\r\n - ``from_pretrained``: (Value not provided) Generally indicates the path or identifier of a pretrained model.\r\n - ``in_channels``: Specifies the number of input channels for the UNet model. Here, the value is set to 8, with the initial 4 channels dedicated to image guidance.\r\n Additional model configurations align with Stable Diffusion (refer to :doc:`Stable Diffusion <./sd>`).\r\n\r\nLine 56. fix capitalization.\r\n\r\nOptimization-Related Configurations", "copyedits for docs/source/multimodal/text2img/sdxl_quantization.rst.\r\n\r\nLine 4. suggested revision.\r\n\r\nThe example in this section shows how to use ModelOpt to calibrate and quantize the UNet part of the SDXL. The UNet part typically consumes over 95% of the e2e Stable Diffusion latency.\r\n\r\nLine 7. revise.\r\n\r\nWe also provide instructions on deploying and running the E2E SDXL pipeline\r\n\r\nLines 10 - 11. revise link.\r\n\r\nTo get started, you need a pretrained SDXL checkpoint in NeMo format. Example training configurations are available here: `Stable Diffusion Examples <https://github.com/NVIDIA/NeMo/tree/main/examples/multimodal/text_to_image/stable_diffusion>`_.\r\n\r\nLine 15. revise.\r\n\r\nThe first step is to run the quantization script with the default config. The script will export the quantized unet to the onnx file.\r\n\r\nLine 16. revise link.\r\n\r\nHere is the default config for `SDXL Quantize Script <https://github.com/NVIDIA/NeMo/blob/main/examples/multimodal/text_to_image/stable_diffusion/sd_xl_quantize.py>`_.\r\n\r\nLine 35. revise.\r\n\r\n- percentile: Controls the range for collecting quantization scaling factors (amax). This means we will collect the minimum amax over a range of (n_steps * percentile) steps. We recommend 1.0.\r\n\r\nLine 36. revise.\r\n\r\n- alpha: A parameter in SmoothQuant, used exclusively for linear layers only. We recommend 0.8 for SDXL and 1.0 for SD 1.5.\r\n\r\nLine 38. fix punctuation.\r\n\r\ncalib-size: For SDXL, we recommend 32, 64 or 128, for SD 1.5 and set to 512 or 1024.\r\n\r\n\r\nLine 51. suggested revision.\r\n\r\nWhen building the TRT engine, you must provide the input shape as follows:\r\n\r\nLines 52 - 53. the bullets don't seem to be rendering properly. Try using the * character for the bullet instead of -. Also, fix the spelling for \"dimension\".\r\n \r\n* x: Input image latent shape (B * C * H * W)\r\n* context: Input text conditioning (B * S * hidden_dimension)\r\n* y: Additional embedding (B * adm_in_channels)\r\n\r\n\r\nLine 59. fix punctuation and revise link.\r\n\r\nWe provide a script to build an end-to-end TRT inference pipeline with the NeMo backend here: `SDXL Export Script <https://github.com/NVIDIA/NeMo/blob/main/examples/multimodal/text_to_image/stable_diffusion/sd_xl_export.py>`_.\r\n\r\n\r\nLines 76 - 79. fix punctuation. add a period at the end of each item.\r\n\r\n- out_path: Directory to save onnx file and TRT engine files.\r\n- width and height: Image resolution of inference output.\r\n- batch_size: Only used for dummy input generation and onnx sanity check.\r\n- {min,max}_batch_size: The input batch size of TRT engine along its dynamic axis.\r\n\r\nLine 82. fix capitalization.\r\n\r\nRun End-to-End Stable Diffusion XL TRT Pipeline\r\n\r\nLine 85. fix link.\r\n\r\nThe inference script can be found here: `SDXL TRT Inference Script <https://github.com/NVIDIA/NeMo/blob/main/examples/multimodal/text_to_image/stable_diffusion/sd_xl_trt_inference.py>`_.\r\n", "copyedits for docs/source/multimodal/nerf/dreamfusion.rst.\r\n\r\nLine 24. fix capitalization.\r\n\r\nImage Guidance\r\n\r\nLine 32. fix capitalization.\r\n\r\nNeRF (Foreground) Network\r\n\r\nLine 34. NERF previously defined. Can remove it here.\r\n\r\nThe Neural Radiance Fields network is at the heart of DreamFusion's 3D rendering capabilities.\r\n\r\nLine 39. fix capitalization.\r\n\r\nBackground Layer\r\n\r\nLine 51. fix capitalization.\r\n\r\nMaterials Network\r\n\r\nLine 53. make plural \"material\" so it is consistent with title.\r\n\r\nThe materials network in DreamFusion is responsible for adding realism to the 3D models by accurately simulating the physical properties of different materials.\r\n\r\nLine 58 fix capitalization\r\n\r\nRenderer Layer\r\n\r\nLine 117. revise.\r\n\r\nPath to a checkpoint file for initializing the model.\r\n\r\nLine 130 fix capitalization.\r\n\r\nImage Guidance\r\n\r\nLine 145. fix capitalization\r\n\r\nNeRF (Foreground) Network\r\n\r\nLine 179. fix capitalization.\r\n\r\nBackground Layer\r\n\r\nLine 206. fix capitalization.\r\n\r\nMaterials Network\r\n\r\nLine 238. fix punctuation and spelling.\r\n\r\nDMTet fine-tuning disentangles the learning of geometry and appearance models, such that both a fine surface and a rich\r\n\r\nLines 242 - 244. No copyedits here. Just admiring the wizardry of this sentence!\r\n\r\nLine 297. fix punctuation and revise.\r\n\r\nThe rendering module was updated from a volumetric-based approach to a rasterization-based one using nvdiffrast.\r\n\r\nLine 299. fix punctuation.\r\n\r\n3. DreamFusion-DMTet fine-tunes a pretrained DreamFusion model, the pretrained checkpoint is provided using ``resume_from_checkpoint``.\r\n\r\nLine 300. fix spelling.\r\n\r\n4. The training shape is increased to 512x512.", "copyedits for docs/source/nlp/nemo_megatron/gpt/gpt_training.rst.\r\n\r\nLine 1. fix capitalization.\r\n\r\nGPT Model Training\r\n------------------------\r\n\r\nLine 4. add introductory text for this topic, define acronym on first use, and revise.\r\n\r\nThe Generative Pre-trained Transformer (GPT) is a decoder-only Transformer model. This section demonstrates how to train a GPT-style model with NeMo.\r\n\r\nLines 7 - 8. Delete \"Quick start\" and remove heading.\r\n\r\nLine 9. Delete this line. We already added it to Line 4.\r\n\r\nLine 12. revise this note by icluding a link.\r\n\r\nThis example is best completed using the latest `NeMo Framework Training container <https://catalog.ngc.nvidia.com/orgs/nvidia/containers/nemo>`__.\r\n\r\nLine 14. change this heading to imperative verb, remove the ampersand, and use capitalization.\r\n\r\nDownload and Pre-process Data\r\n\r\nLine 18. remove the \"note\" format and change the sentence to active voice.\r\n\r\nThe example below will take approximately 3 hours to download data, pre-process it, and train the tokenizer.\r\n\r\nLine 20. replace **Step 1: Download data** with a step number. The recommended style for procedures is to use sequential numbering without the word \"Step\", avoid bolded text, and write the step as a complete sentence. Like this:\r\n\r\n1. Download the data.\r\n\r\nLine 22. revise.\r\n\r\nThe following step will download approximately 20GB of Wikipedia data, which can take several hours to complete.\r\n\r\nLine 28. replace **Step 2: Extract raw data** with a step number.\r\n\r\n2. Extract the raw data.\r\n\r\nLine 36. fix capitalization and revise.\r\n\r\nNow, train_data.jsonl will contain our training data in JSON line format. We are particularly interested in the data within the \"text\" field.\r\n\r\nLine 39. replace **Step 3: Train tokenizer** with a step number.\r\n\r\n3. Train the tokenizer.\r\n\r\nLine 41. fix HF name (two words) and revise.\r\n\r\nBelow, we will consider two options for training data tokenizers: using the pre-built Hugging Face BPE or training and using your own Google Sentencepiece tokenizer.\r\n\r\n\r\nLine 45. fix HF name and replace gerund (\"ing\") with imperative verb.\r\n\r\n*Option 1:* Use Hugging Face GPT2 tokenizer files.\r\n\r\nLine 55. replace gerund with imperative verb\r\n\r\n*Option 2:* Use `Google Sentencepiece <https://github.com/google/sentencepiece>`_ tokenizer library. \r\n\r\nLines 57 - 58. revise.\r\n\r\nGoogle Sentencepiece is included as a dependency with NeMo, so if you have installed NeMo, it should already be installed. Please note that training the tokenizer model will also take some time.\r\n\r\nLine 73. revise.\r\n\r\nCompleting this step can take some time. After it is done, you'll have two files: ``spm_32k_wiki.model`` and ``spm_32k_wiki.vocab`` corresponding to the model and vocabulary.\r\n\r\nLine 75. replace **Step 4: Convert training data into memory map format** with a step number.\r\n\r\n4. Convert the training data into memory map format.\r\n\r\nLine 77. revise.\r\n\r\nThe memory map format makes training more efficient, especially with many nodes and GPUs. This step will also tokenize data using the tokenizer model from Step 3.\r\n\r\nLine 79. fix HF name and use imperative verb.\r\n\r\n*Option 1:* Use Hugging Face GPT2 tokenizer files.\r\n\r\nLine 95. Use imperative verb.\r\n\r\n*Option 2:* Use `Google Sentencepiece <https://github.com/google/sentencepiece>`_ tokenizer library.\r\n\r\nLine 109. revise title and use capitalization.\r\n\r\nTrain a GPT-Style Model\r\n\r\nLine 116. fix HF name and use imperative verb.\r\n\r\n*Option 1:* Use Hugging Face GPT2 tokenizer files.\r\n\r\nLine 169. Use imperative verb.\r\n\r\n*Option 2:* Use `Google Sentencepiece <https://github.com/google/sentencepiece>`_ tokenizer library.\r\n\r\nLine 222. revise.\r\n\r\nNext, you can launch Tensorboard to monitor training, as follows:\r\n\r\nLine 228. use capitalization for heading.\r\n\r\nNext Steps\r\n\r\nLine 231. revise.\r\n\r\nFor more information, please refer to:\r\n", "copyedits for docs/source/nlp/token_classification.rst.\r\n\r\nLine 3. suggest topic title revision. This helps SEO searches.\r\n\r\nToken Classification Model with Named Entity Recognition (NER)\r\n===============================================================\r\n\r\nLine 6. revise.\r\n\r\nThe token classification model supports NER and other token-level classification tasks, as long as the data follows the format specified below.\r\n\r\nLines 9 - 12 revise.\r\n\r\nWe're going to use NER task throughout this section. NER, also referred to as entity chunking, identification, or extraction, is the task of detecting and classifying key information (entities) in text. In other words, a NER model takes a piece of text as input and then determines the category for each word within it. For example, in the sentence “Mary lives in Santa Clara and works at NVIDIA,” the model should detect that “Mary” is a person, “Santa Clara” is a location, and “NVIDIA” is a company.\r\n\r\nLine 14. Revise heading (delete \"Guide\") and fix capitalization.\r\n\r\nQuick Start\r\n-----------\r\n\r\nLine 16 - 28. revise this section and add steps for the Quick Start procedure. For example:\r\n\r\n1. To run token-level classification, use the following Python script:\r\n\r\n .. code-block:: python\r\n\r\n from nemo.collections.nlp.models import TokenClassificationModel\r\n\r\n # to get the list of pre-trained models\r\n\r\n TokenClassificationModel.list_available_models()\r\n\r\n # Download and load the pre-trained BERT-based model\r\n model = TokenClassificationModel.from_pretrained(\"ner_en_bert\")\r\n\r\n # try the model on a few examples\r\n model.add_predictions(['we bought four shirts from the nvidia gear store in santa clara.', 'NVIDIA is a company.'])\r\n\r\n\r\n2. Try this model in a Jupyter notebook, which you can run on `Google Colab <https://colab.research.google.com/notebooks/intro.ipynb>`_. \r\n\r\n You can find this script in the `NeMo tutorial <https://github.com/NVIDIA/NeMo/blob/stable/tutorials/nlp/Token_Classification_Named_Entity_Recognition.ipynb>`_.\r\n\r\n3. Connect to an instance with a GPU (**Runtime** -> **Change runtime type** -> select **GPU** for the hardware accelerator).\r\n\r\nLines 30 - 33. Delete all of these lines, including the note.\r\n\r\nLines 37 - 41. revise into bullets and shorten the links. Like this:\r\n\r\nYou can find example scripts and configuration files for the token classification model at the following locations:\r\n\r\n* An example script on how to train the model can be found at `NeMo training script <https://github.com/NVIDIA/NeMo/blob/stable/examples/nlp/token_classification/token_classification_train.py>`_.\r\n\r\n* An example script on how to run evaluation and inference can be found at `NeMo evaluation script <https://github.com/NVIDIA/NeMo/blob/stable/examples/nlp/token_classification/token_classification_evaluate.py>`_.\r\n\r\n* The default configuration file for the model can be found at `NeMo configuration file <https://github.com/NVIDIA/NeMo/blob/stable/examples/nlp/token_classification/conf/token_classification_config.yaml>`_.\r\n\r\nLine 43. Please verify this line. it appears to be out of place (?):\r\n\r\n.. _dataset_token_classification:\r\n\r\nLine 45. revise the heading as imperative verb.\r\n\r\nProvide Data Input for the Token Classification Model\r\n-------------------------------------------------------\r\n\r\nLine 48. change to active voice.\r\n\r\nTo pre-train or fine-tune the model, split the data into the following two files:\r\n\r\nLine 55. revise.\r\n\r\nThe following is an example of a ``text.txt`` file:\r\n\r\nLine 61. revise.\r\n\r\nThe following is an example of the corresponding ``labels.txt`` file:\r\n\r\nLine 67. revise heading to an imperative verb.\r\n\r\nConvert the Dataset\r\n-------------------\r\n\r\nLines 70 - 71 shorten the link and revise.\r\n\r\nTo convert the `IOB tagging format <https://en.wikipedia.org/wiki/Inside%E2%80%93outside%E2%80%93beginning_(tagging)>`__ (short for inside, outside, beginning) into the format required for training, use the `NeMo import script <https://github.com/NVIDIA/NeMo/blob/stable/examples/nlp/token_classification/data/import_from_iob_format.py>`_.\r\n\r\nLine 78, revise heading so it is consistent with the others.\r\n\r\nRequired Arguments for Dataset Conversion\r\n^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n\r\nLine 83. revise.\r\n\r\nAfter running the previous command, the data directory containing the :code:`--data_file` should include the :code:`text_*.txt` and :code:`labels_*.txt` files.\r\n\r\nLine 296 revise heading to imperative verb and fix capitalization.\r\n\r\nTrain the Token Classification Model\r\n------------------------------------\r\n\r\nLine 99. fix capitalization.\r\n\r\nIn the token classification model, we are jointly training a classifier on top of a pre-trained language model, such as \r\n\r\nLine 102. fix HF name (two words).\r\n\r\nfrom `Hugging Face Transformers <https://github.com/huggingface/transformers>`__.\r\n\r\nLine 104. revise and shorten link.\r\n\r\nAn example of model configuration file for training the model can be found at `NeMo configuration file <https://github.com/NVIDIA/NeMo/blob/stable/examples/nlp/token_classification/conf/token_classification_config.yaml>`_.\r\n\r\nLine 112. revise.\r\n\r\nYou can find more details about the spec file parameters in table below.\r\n\r\nLine 142. revise.\r\n\r\nHere is an example command for training the model:\r\n\r\nLine 155. add lead-in sentence.\r\n\r\nThe following argument is required for training:\r\n\r\nLines 160 - 164. fix note punctuation (command line) and revise.\r\n\r\nWhile the arguments are defined in the spec file, you can override these parameter definitions and experiment with them using the command line. For example, the sample spec file mentioned above has :code:`validation_ds.batch_size` set to ``64``. However, if GPU utilization can be optimized further by using a larger batch size, you can override it to the desired value by adding the field :code:`validation_ds.batch_size=128` from the command line. You can repeat this process with any of the parameters defined in the sample spec file.\r\n\r\nLine 169. shorten the link.\r\n\r\nAn example script on how to run inference can be found at `NeMo evaluation script <https://github.com/NVIDIA/NeMo/blob/stable/examples/nlp/token_classification/token_classification_evaluate.py>`_.\r\n\r\nLine 180. add lead-in sentence.\r\n\r\nThe following argument is required for inference:\r\n\r\nLine 183. change heading to imperative verb.\r\n\r\nEvaluate the Token Classification Model\r\n----------------------------------------\r\n\r\nLine 186. shorten the link.\r\n\r\nAn example script on how to evaluate the pre-trained model can be found at `NeMo evaluation script <https://github.com/NVIDIA/NeMo/blob/stable/examples/nlp/token_classification/token_classification_evaluate.py>`_.\r\n\r\n\r\nLine 188. revise.\r\n\r\nTo start the evaluation of the pre-trained mode, run:\r\n\r\nLine 200. revise heading so it is consistent with the others.\r\n\r\nRequired Arguments for Evaluation\r\n^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n\r\nLine 202. add lead-in sentence.\r\n\r\nThe following arguments are required for evaluation:\r\n\r\nLine 212. revise link.\r\n\r\nFor more information, see `Wikipedia <https://en.wikipedia.org/wiki/Precision_and_recall>`__.\r\n", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "Documentation only changes: documentation only changes , doc-string only changes for Python files. We think we can safely skip CI" ]
2024-08-15T22:11:59
2024-10-17T06:13:24
2024-10-17T06:13:22
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10171", "html_url": "https://github.com/NVIDIA/NeMo/pull/10171", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10171.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10171.patch", "merged_at": "2024-10-17T06:13:22" }
# What does this PR do ? Fix doc feature section warnings **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10171/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10171/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10170
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10170/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10170/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10170/events
https://github.com/NVIDIA/NeMo/pull/10170
2,469,061,466
PR_kwDOC_bI7s54g8gL
10,170
ci: Fix curl request for release creation
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-08-15T22:09:23
2024-08-15T22:09:36
2024-08-15T22:09:32
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10170", "html_url": "https://github.com/NVIDIA/NeMo/pull/10170", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10170.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10170.patch", "merged_at": "2024-08-15T22:09:32" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10170/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10170/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10169
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10169/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10169/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10169/events
https://github.com/NVIDIA/NeMo/pull/10169
2,469,056,918
PR_kwDOC_bI7s54g7hZ
10,169
refactor: README (#9712)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
[ { "id": 4556669155, "node_id": "LA_kwDOC_bI7s8AAAABD5lA4w", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick", "name": "cherry-pick", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[]
2024-08-15T22:04:49
2024-08-21T17:15:39
2024-08-21T17:15:39
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10169", "html_url": "https://github.com/NVIDIA/NeMo/pull/10169", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10169.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10169.patch", "merged_at": null }
* refactor: README * refactor: Use new README in `setup.py` # What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10169/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10169/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10168
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10168/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10168/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10168/events
https://github.com/NVIDIA/NeMo/pull/10168
2,469,056,348
PR_kwDOC_bI7s54g7ZS
10,168
refactor: README (#9712)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-08-15T22:04:12
2024-08-15T22:04:28
2024-08-15T22:04:27
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10168", "html_url": "https://github.com/NVIDIA/NeMo/pull/10168", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10168.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10168.patch", "merged_at": "2024-08-15T22:04:27" }
* refactor: README * refactor: Use new README in `setup.py` # What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10168/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10168/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/10167
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/10167/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/10167/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/10167/events
https://github.com/NVIDIA/NeMo/pull/10167
2,469,045,357
PR_kwDOC_bI7s54g4-p
10,167
Update mixtral rope defaults
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-08-15T21:53:09
2024-08-16T04:38:18
2024-08-16T04:38:16
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10167", "html_url": "https://github.com/NVIDIA/NeMo/pull/10167", "diff_url": "https://github.com/NVIDIA/NeMo/pull/10167.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/10167.patch", "merged_at": "2024-08-16T04:38:16" }
# What does this PR do ? Fixing rope config defaults. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10167/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/10167/timeline
null
null
true