url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/10064 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10064/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10064/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10064/events | https://github.com/NVIDIA/NeMo/pull/10064 | 2,451,863,166 | PR_kwDOC_bI7s53n8OM | 10,064 | [NeMo-UX] LoRA bug fix + frozen param printout | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-06T23:51:59 | 2024-08-15T15:57:59 | 2024-08-15T15:57:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10064",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10064",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10064.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10064.patch",
"merged_at": "2024-08-15T15:57:57"
} | # What does this PR do ?
Fix LoRA convergence bug, and add a parameter count print out after freezing base model, similar to NeMo 1.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10064/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10064/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10063 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10063/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10063/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10063/events | https://github.com/NVIDIA/NeMo/pull/10063 | 2,451,844,223 | PR_kwDOC_bI7s53n4Lf | 10,063 | [NeMo-UX] log learning rate before train step | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-06T23:27:53 | 2024-08-07T19:18:23 | 2024-08-07T19:18:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10063",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10063",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10063.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10063.patch",
"merged_at": "2024-08-07T19:18:21"
} | Previously, we were logging the learning rate after the train step was completed, which was causing a mismatch between the learning rate and the step count. This updates the logging of the learning rate to fix that.
**Collection**: LLM
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10063/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10063/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10062 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10062/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10062/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10062/events | https://github.com/NVIDIA/NeMo/pull/10062 | 2,451,721,242 | PR_kwDOC_bI7s53ndRG | 10,062 | FSDP support of SALM and BESTOW | {
"login": "zhehuaichen",
"id": 139396994,
"node_id": "U_kgDOCE8Hgg",
"avatar_url": "https://avatars.githubusercontent.com/u/139396994?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zhehuaichen",
"html_url": "https://github.com/zhehuaichen",
"followers_url": "https://api.github.com/users/zhehuaichen/followers",
"following_url": "https://api.github.com/users/zhehuaichen/following{/other_user}",
"gists_url": "https://api.github.com/users/zhehuaichen/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zhehuaichen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zhehuaichen/subscriptions",
"organizations_url": "https://api.github.com/users/zhehuaichen/orgs",
"repos_url": "https://api.github.com/users/zhehuaichen/repos",
"events_url": "https://api.github.com/users/zhehuaichen/events{/privacy}",
"received_events_url": "https://api.github.com/users/zhehuaichen/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"A few notes:\r\n- You might need to adapt this class to support additional modules: https://github.com/zhehuaichen/NeMo/blob/speechllm-develop/nemo/collections/nlp/parts/nlp_overrides.py#L626\r\n - E.g., adding new modules here: https://github.com/zhehuaichen/NeMo/blob/speechllm-develop/nemo/collections/nlp/parts/nlp_overrides.py#L668\r\n- The above class has several methods related to \"state dict\". Not sure if those are correct for speech LM.\r\n- I excluded the embedding layer of LLM to avoid errors when using it elsewhere. We'd better fix it since the embedding layer can be very large. https://github.com/zhehuaichen/NeMo/commit/44056f2d1f69261c47829181e7d8e4c0c1c077de#diff-e3fcc68c97812462e588465942b917f381808fc65501b32a431b8b311fab6fd3R1691",
"> A few notes:\r\n> \r\n> * You might need to adapt this class to support additional modules: https://github.com/zhehuaichen/NeMo/blob/speechllm-develop/nemo/collections/nlp/parts/nlp_overrides.py#L626\r\n> \r\n> * E.g., adding new modules here: https://github.com/zhehuaichen/NeMo/blob/speechllm-develop/nemo/collections/nlp/parts/nlp_overrides.py#L668\r\n> * The above class has several methods related to \"state dict\". Not sure if those are correct for speech LM.\r\n> * I excluded the embedding layer of LLM to avoid errors when using it elsewhere. We'd better fix it since the embedding layer can be very large. [zhehuaichen@44056f2#diff-e3fcc68c97812462e588465942b917f381808fc65501b32a431b8b311fab6fd3R1691](https://github.com/zhehuaichen/NeMo/commit/44056f2d1f69261c47829181e7d8e4c0c1c077de#diff-e3fcc68c97812462e588465942b917f381808fc65501b32a431b8b311fab6fd3R1691)\r\n\r\nThanks for the note.\r\nSpeechLLM does not add extra nlp modules but only reusing them if that is what you mean. Locally I found the ckpt restore seems working. Will confirm with a cluster run"
] | 2024-08-06T21:27:15 | 2024-08-09T18:58:09 | 2024-08-09T18:58:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10062",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10062",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10062.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10062.patch",
"merged_at": "2024-08-09T18:58:09"
} | # What does this PR do ?
Support FSDP in SALM and BESTOW. Thank @pyf98 for early trying
# Usage
Elaborated and tested here https://docs.google.com/document/d/1fr2UlqThlzqvqL_lpc_HIyrh0yCzL27A-QX1eCI_ojg/edit#heading=h.9o9g0iu9eu69
| {
"login": "zhehuaichen",
"id": 139396994,
"node_id": "U_kgDOCE8Hgg",
"avatar_url": "https://avatars.githubusercontent.com/u/139396994?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zhehuaichen",
"html_url": "https://github.com/zhehuaichen",
"followers_url": "https://api.github.com/users/zhehuaichen/followers",
"following_url": "https://api.github.com/users/zhehuaichen/following{/other_user}",
"gists_url": "https://api.github.com/users/zhehuaichen/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zhehuaichen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zhehuaichen/subscriptions",
"organizations_url": "https://api.github.com/users/zhehuaichen/orgs",
"repos_url": "https://api.github.com/users/zhehuaichen/repos",
"events_url": "https://api.github.com/users/zhehuaichen/events{/privacy}",
"received_events_url": "https://api.github.com/users/zhehuaichen/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10062/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10062/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10061 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10061/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10061/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10061/events | https://github.com/NVIDIA/NeMo/pull/10061 | 2,451,683,530 | PR_kwDOC_bI7s53nVA2 | 10,061 | Copy data from GPU to CPU only once in batched_hyps_to_hypotheses for each tensor of interest. | {
"login": "galv",
"id": 4767568,
"node_id": "MDQ6VXNlcjQ3Njc1Njg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4767568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/galv",
"html_url": "https://github.com/galv",
"followers_url": "https://api.github.com/users/galv/followers",
"following_url": "https://api.github.com/users/galv/following{/other_user}",
"gists_url": "https://api.github.com/users/galv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/galv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/galv/subscriptions",
"organizations_url": "https://api.github.com/users/galv/orgs",
"repos_url": "https://api.github.com/users/galv/repos",
"events_url": "https://api.github.com/users/galv/events{/privacy}",
"received_events_url": "https://api.github.com/users/galv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-08-06T20:58:16 | 2024-08-29T01:54:18 | 2024-08-29T01:54:17 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10061",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10061",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10061.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10061.patch",
"merged_at": null
} | Previously, several small GPU->CPU copies were used, which caused excess latency linearly proportional to the batch size. For small copies, it is much more efficient to do a single memory copy.
There is still a remaining issue. pack_hypotheses() appears to be copying data from GPU to CPU for the dec_state tensor, one at a time. I would like to remove that, but that is an intrusive change that affects interfaces, so I will not do it for now.
RTFx before this change on librispeech test other: 1766.645297158031
RTFx after this change on librispeech test other: 1795.3508087085368 | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10061/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 1,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10061/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10060 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10060/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10060/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10060/events | https://github.com/NVIDIA/NeMo/issues/10060 | 2,451,426,305 | I_kwDOC_bI7s6SHcwB | 10,060 | LazyNeMoIterator improperly duration handling for non-zero offset in nemo manifest file | {
"login": "FredSRichardson",
"id": 2016161,
"node_id": "MDQ6VXNlcjIwMTYxNjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/2016161?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/FredSRichardson",
"html_url": "https://github.com/FredSRichardson",
"followers_url": "https://api.github.com/users/FredSRichardson/followers",
"following_url": "https://api.github.com/users/FredSRichardson/following{/other_user}",
"gists_url": "https://api.github.com/users/FredSRichardson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/FredSRichardson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/FredSRichardson/subscriptions",
"organizations_url": "https://api.github.com/users/FredSRichardson/orgs",
"repos_url": "https://api.github.com/users/FredSRichardson/repos",
"events_url": "https://api.github.com/users/FredSRichardson/events{/privacy}",
"received_events_url": "https://api.github.com/users/FredSRichardson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"My fix for this was to use `soundfile.info()` (as you did in other parts of the same code) to extract all the meta data needed to create a `Recording` object (after confirming the audio file exists, the above example won't work). I cached the meta data by path string to ease up on file I/O (so it should be called only once per a unique audio file).",
"@neehhaa06 The current code in `nemo/collections/common/data/lhotse/nemo_adapters.py` uses `soundfile` to avoid I/O overhead of loading the whole file. The related comment is here for the `LazyNeMoTarredIterator` class:\r\n```\r\n raw_audio = tar.extractfile(tar_info).read()\r\n # Note: Lhotse has a Recording.from_bytes() utility that we won't use here because\r\n # the profiling indicated significant overhead in torchaudio ffmpeg integration\r\n # that parses full audio instead of just reading the header for WAV files.\r\n # recording = lhotse.Recording.from_bytes(raw_audio, recording_id=tar_info.path)\r\n meta = soundfile.info(BytesIO(raw_audio))\r\n```\r\nThe `meta` variable above returned by `soundfile.info()` is very useful. It includes the sample rate, number of samples, number of channels, etc. I think this is the best thing to use to address this bug report in addition to caching the meta data using the file path string using a dict.",
"Thanks, it looks like there's indeed an issue. Do you mind submitting a PR with your fix?",
"I was asking @FredSRichardson since he mentioned he managed to fix it locally. That said you're also welcome to contribute @neehhaa06 :)",
"I can't contribute directly unfortunately, but I did leave a fairly detailed spec of the change and it's fairly minor. Let me know if you have any questions.",
"Thanks, appreciate it. I added tests and a fix here https://github.com/NVIDIA/NeMo/pull/10198"
] | 2024-08-06T18:04:16 | 2024-08-23T13:56:31 | 2024-08-23T13:56:31 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
These lines of code do not handle a cut's duration correctly when the offset is not zero:
From `nemo/collections/common/data/lhotse/nemo_adapters.py` for the class `LazyNeMoIterator`:
```
def __iter__(self) -> Generator[Cut, None, None]:
for data in self.source:
audio_path = get_full_path(str(data.pop("audio_filepath")), str(self.path))
duration = data.pop("duration")
offset = data.pop("offset", None)
recording = self._create_recording(audio_path, duration, data.pop("sampling_rate", None))
cut = recording.to_cut()
if offset is not None:
cut = cut.truncate(offset=offset, duration=duration, preserve_id=True)
cut.id = f"{cut.id}-{round(offset * 1e2):06d}-{round(duration * 1e2):06d}"
```
The issue is that the function `_create_recording()` in the same file uses the `duration` parameter to compute the number of samples for the whole recording in the returned lhotse `Recording` instance. The duration in the nemo manifest is for the cut starting at the `offset` value within the recording. The duration of the whole recording has to be obtained from somewhere else (possibly the recording itself).
**Steps/Code to reproduce bug**
Run `scripts/speech_recognition/estimate_duration_bins.py -b 30 manifest.json` using a manifest file containing non-zero offsets for example:
```
{"duration": 0.5, "audio_filepath": "/path/to/some/file.wav", "text": "hello world", "offset": 123.4}
{"duration": 1.0, "audio_filepath": "/path/to/some/file.wav", "text": "hello world", "offset": 124.4}
{"duration": 1.0, "audio_filepath": "/path/to/some/file.wav", "text": "hello world", "offset": 125.4}
{"duration": 1.0, "audio_filepath": "/path/to/some/file.wav", "text": "hello world", "offset": 126.4}
{"duration": 1.0, "audio_filepath": "/path/to/some/file.wav", "text": "hello world", "offset": 127.4}
{"duration": 1.0, "audio_filepath": "/path/to/some/file.wav", "text": "hello world", "offset": 128.4}
{"duration": 1.0, "audio_filepath": "/path/to/some/file.wav", "text": "hello world", "offset": 129.4}
{"duration": 1.0, "audio_filepath": "/path/to/some/file.wav", "text": "hello world", "offset": 130.4}
{"duration": 1.0, "audio_filepath": "/path/to/some/file.wav", "text": "hello world", "offset": 131.4}
{"duration": 1.0, "audio_filepath": "/path/to/some/file.wav", "text": "hello world", "offset": 132.4}
{"duration": 5.0, "audio_filepath": "/path/to/some/other-file.wav", "text": "hello world", "offset": 4.0}
{"duration": 4.0, "audio_filepath": "/path/to/some/other-file.wav", "text": "hello world", "offset": 5.0}
{"duration": 4.0, "audio_filepath": "/path/to/some/other-file.wav", "text": "hello world", "offset": 4.0}
```
You'll notice that the `mean` duration in the output is a negative number.
**Expected behavior**
The duration of the whole audio file should be using when creating the `Recording` object in the method `_create_recording()` in `nemo/collections/common/data/lhotse/nemo_adapters.py`. The reported mean duration should not be negative.
**Environment overview (please complete the following information)**
- Environment location: Bare-metal
- Method of NeMo install:
```
git clone https://github.com/NVIDIA/NeMo.git
git checkout r2.0.0rc0
conda install -y -c conda-forge numba==0.57.1
pip install --editable ".[all]"
pip install huggingface-hub==0.23.2 # this fixes a bug with newer versions...
```
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version: Linux Ubuntu 20.04
- PyTorch version: pytorch-lightning-2.3.3
- Python version: 3.10.12
**Additional context**
Add any other context about the problem here.
Example: GPU model
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10060/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10060/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/10059 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10059/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10059/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10059/events | https://github.com/NVIDIA/NeMo/pull/10059 | 2,451,275,538 | PR_kwDOC_bI7s53l8Fe | 10,059 | Simplified key-names mapping from NeMo to TRT LLM | {
"login": "Laplasjan107",
"id": 67481570,
"node_id": "MDQ6VXNlcjY3NDgxNTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/67481570?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Laplasjan107",
"html_url": "https://github.com/Laplasjan107",
"followers_url": "https://api.github.com/users/Laplasjan107/followers",
"following_url": "https://api.github.com/users/Laplasjan107/following{/other_user}",
"gists_url": "https://api.github.com/users/Laplasjan107/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Laplasjan107/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Laplasjan107/subscriptions",
"organizations_url": "https://api.github.com/users/Laplasjan107/orgs",
"repos_url": "https://api.github.com/users/Laplasjan107/repos",
"events_url": "https://api.github.com/users/Laplasjan107/events{/privacy}",
"received_events_url": "https://api.github.com/users/Laplasjan107/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-08-06T16:28:35 | 2024-08-09T11:58:33 | 2024-08-09T11:58:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10059",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10059",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10059.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10059.patch",
"merged_at": null
} | # What does this PR do ?
Simplified key-names mapping in NeMo to TRT LLM export.
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Laplasjan107",
"id": 67481570,
"node_id": "MDQ6VXNlcjY3NDgxNTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/67481570?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Laplasjan107",
"html_url": "https://github.com/Laplasjan107",
"followers_url": "https://api.github.com/users/Laplasjan107/followers",
"following_url": "https://api.github.com/users/Laplasjan107/following{/other_user}",
"gists_url": "https://api.github.com/users/Laplasjan107/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Laplasjan107/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Laplasjan107/subscriptions",
"organizations_url": "https://api.github.com/users/Laplasjan107/orgs",
"repos_url": "https://api.github.com/users/Laplasjan107/repos",
"events_url": "https://api.github.com/users/Laplasjan107/events{/privacy}",
"received_events_url": "https://api.github.com/users/Laplasjan107/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10059/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10059/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10058 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10058/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10058/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10058/events | https://github.com/NVIDIA/NeMo/pull/10058 | 2,451,105,130 | PR_kwDOC_bI7s53lWw0 | 10,058 | rebase main | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-08-06T14:59:09 | 2024-08-28T01:53:40 | 2024-08-28T01:53:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10058",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10058",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10058.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10058.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10058/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10058/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10057 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10057/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10057/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10057/events | https://github.com/NVIDIA/NeMo/pull/10057 | 2,451,091,974 | PR_kwDOC_bI7s53lT4Z | 10,057 | Alit/roberta convert | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-06T14:53:07 | 2024-08-06T14:58:19 | 2024-08-06T14:58:14 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10057",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10057",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10057.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10057.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10057/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10057/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10056 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10056/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10056/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10056/events | https://github.com/NVIDIA/NeMo/pull/10056 | 2,450,996,700 | PR_kwDOC_bI7s53k-1z | 10,056 | Fixed loading packed distributed nemo checkpoints | {
"login": "Laplasjan107",
"id": 67481570,
"node_id": "MDQ6VXNlcjY3NDgxNTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/67481570?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Laplasjan107",
"html_url": "https://github.com/Laplasjan107",
"followers_url": "https://api.github.com/users/Laplasjan107/followers",
"following_url": "https://api.github.com/users/Laplasjan107/following{/other_user}",
"gists_url": "https://api.github.com/users/Laplasjan107/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Laplasjan107/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Laplasjan107/subscriptions",
"organizations_url": "https://api.github.com/users/Laplasjan107/orgs",
"repos_url": "https://api.github.com/users/Laplasjan107/repos",
"events_url": "https://api.github.com/users/Laplasjan107/events{/privacy}",
"received_events_url": "https://api.github.com/users/Laplasjan107/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This should be covered by https://github.com/NVIDIA/NeMo/pull/9826, so please include it for your purposes"
] | 2024-08-06T14:11:35 | 2024-08-07T15:39:22 | 2024-08-07T15:39:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10056",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10056",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10056.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10056.patch",
"merged_at": null
} | # What does this PR do ?
Fix imports and loading of the packed, distributed NeMo checkpoints during conversion to TRT LLM.
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10056/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10056/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10055 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10055/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10055/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10055/events | https://github.com/NVIDIA/NeMo/issues/10055 | 2,450,937,481 | I_kwDOC_bI7s6SFlaJ | 10,055 | AttributeError: 'dict' object has no attribute '_get_node_flag' | {
"login": "syx11237744",
"id": 108730633,
"node_id": "U_kgDOBnsZCQ",
"avatar_url": "https://avatars.githubusercontent.com/u/108730633?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/syx11237744",
"html_url": "https://github.com/syx11237744",
"followers_url": "https://api.github.com/users/syx11237744/followers",
"following_url": "https://api.github.com/users/syx11237744/following{/other_user}",
"gists_url": "https://api.github.com/users/syx11237744/gists{/gist_id}",
"starred_url": "https://api.github.com/users/syx11237744/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/syx11237744/subscriptions",
"organizations_url": "https://api.github.com/users/syx11237744/orgs",
"repos_url": "https://api.github.com/users/syx11237744/repos",
"events_url": "https://api.github.com/users/syx11237744/events{/privacy}",
"received_events_url": "https://api.github.com/users/syx11237744/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"Could you add more details on how to reproduce this? We have a bug template which can be followed when creating the issue.",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-08-06T13:46:06 | 2024-09-28T01:58:01 | 2024-09-28T01:58:00 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | File "/share//code//NeMo/examples/nlp/language_modeling/megatron_ckpt_to_nemo.py", line 245, in <module>
convert(local_rank, rank, world_size, args)
File "/share//code//NeMo/examples/nlp/language_modeling/megatron_ckpt_to_nemo.py", line 198, in convert
model = MegatronGPTModel.load_from_checkpoint(checkpoint_path, hparams_file=args.hparams_file, trainer=trainer)
File "/usr/local/lib/python3.10/dist-packages/nemo/collections/nlp/models/nlp_model.py", line 380, in load_from_checkpoint
model = ptl_load_state(cls, checkpoint, strict=strict, cfg=cfg, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/core/saving.py", line 144, in _load_state
obj = cls(**_cls_kwargs)
File "/usr/local/lib/python3.10/dist-packages/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py", line 243, in __init__
super().__init__(cfg, trainer=trainer, no_lm_init=True)
File "/usr/local/lib/python3.10/dist-packages/nemo/collections/nlp/models/language_modeling/megatron_base_model.py", line 118, in __init__
with open_dict(cfg):
File "/usr/lib/python3.10/contextlib.py", line 135, in __enter__
return next(self.gen)
File "/usr/local/lib/python3.10/dist-packages/omegaconf/omegaconf.py", line 983, in open_dict
prev_state = config._get_node_flag("struct")
AttributeError: 'dict' object has no attribute '_get_node_flag'
Thanks. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10055/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10055/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/10054 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10054/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10054/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10054/events | https://github.com/NVIDIA/NeMo/pull/10054 | 2,450,934,391 | PR_kwDOC_bI7s53kxIB | 10,054 | Fix Canary's transcribe(): move to device and prompt feeding | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-06T13:44:47 | 2024-08-07T12:32:01 | 2024-08-07T12:31:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10054",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10054",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10054.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10054.patch",
"merged_at": "2024-08-07T12:31:59"
} | # What does this PR do ?
* Fixes an issue after introducing dataclass as a mini-batch type.
* Fixes Canary's transcribe() which for certain cases incorrectly used the contents of the "text" field in addition to the prompt (and if it was not available, it still used a default text value).
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10054/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10054/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10053 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10053/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10053/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10053/events | https://github.com/NVIDIA/NeMo/pull/10053 | 2,450,884,046 | PR_kwDOC_bI7s53kl96 | 10,053 | bugfix for packed distributed checkpoints | {
"login": "Laplasjan107",
"id": 67481570,
"node_id": "MDQ6VXNlcjY3NDgxNTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/67481570?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Laplasjan107",
"html_url": "https://github.com/Laplasjan107",
"followers_url": "https://api.github.com/users/Laplasjan107/followers",
"following_url": "https://api.github.com/users/Laplasjan107/following{/other_user}",
"gists_url": "https://api.github.com/users/Laplasjan107/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Laplasjan107/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Laplasjan107/subscriptions",
"organizations_url": "https://api.github.com/users/Laplasjan107/orgs",
"repos_url": "https://api.github.com/users/Laplasjan107/repos",
"events_url": "https://api.github.com/users/Laplasjan107/events{/privacy}",
"received_events_url": "https://api.github.com/users/Laplasjan107/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-08-06T13:22:56 | 2024-08-06T14:08:28 | 2024-08-06T14:08:28 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10053",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10053",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10053.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10053.patch",
"merged_at": null
} | # What does this PR do ?
Fix imports and loading of the packed distributed checkpoints.
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Laplasjan107",
"id": 67481570,
"node_id": "MDQ6VXNlcjY3NDgxNTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/67481570?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Laplasjan107",
"html_url": "https://github.com/Laplasjan107",
"followers_url": "https://api.github.com/users/Laplasjan107/followers",
"following_url": "https://api.github.com/users/Laplasjan107/following{/other_user}",
"gists_url": "https://api.github.com/users/Laplasjan107/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Laplasjan107/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Laplasjan107/subscriptions",
"organizations_url": "https://api.github.com/users/Laplasjan107/orgs",
"repos_url": "https://api.github.com/users/Laplasjan107/repos",
"events_url": "https://api.github.com/users/Laplasjan107/events{/privacy}",
"received_events_url": "https://api.github.com/users/Laplasjan107/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10053/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10053/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10052 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10052/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10052/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10052/events | https://github.com/NVIDIA/NeMo/pull/10052 | 2,449,696,462 | PR_kwDOC_bI7s53gg2D | 10,052 | [Audio] SSL Pretraining framework for flow-matching model for audio processing | {
"login": "Kuray107",
"id": 29725649,
"node_id": "MDQ6VXNlcjI5NzI1NjQ5",
"avatar_url": "https://avatars.githubusercontent.com/u/29725649?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kuray107",
"html_url": "https://github.com/Kuray107",
"followers_url": "https://api.github.com/users/Kuray107/followers",
"following_url": "https://api.github.com/users/Kuray107/following{/other_user}",
"gists_url": "https://api.github.com/users/Kuray107/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kuray107/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kuray107/subscriptions",
"organizations_url": "https://api.github.com/users/Kuray107/orgs",
"repos_url": "https://api.github.com/users/Kuray107/repos",
"events_url": "https://api.github.com/users/Kuray107/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kuray107/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-06T00:30:53 | 2024-08-24T04:38:56 | 2024-08-24T04:38:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10052",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10052",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10052.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10052.patch",
"merged_at": "2024-08-24T04:38:56"
} | # What does this PR do ?
This PR adds a ssl-pretraining framework and a flow matching AudioToAudio model
**Collection**: audio
# Changelog
- Add a flow matching generative model in `audio/models/enhancement.py`
- Create `audio/modules/ssl_pretrain_masking` to partially-masked out input in the ssl pre-training stage.
- Create `audio/parts/submodules/transformerunet.py` to implement a Transformer U-Net structure.
- Create `audio/parts/submodules/flow.py` for training/inferencing with the flow matching generative model
- Create `audio/parts/utils/callbacks.py` to add processed audio in the training logger.
# Usage
Model can be first be pre-trained using
```python
python examples/audio/audio_to_audio_train.py --config-name flow_matching_generative_ssl_pretraining.yaml
```
- Please update the `train_ds.manifest_filepath` and `validation_ds.manifest_filepath` with the correct filepaths
After the ssl-pretraining stage is completed, the pretrained model could be finetuned using
```python
python examples/audio/audio_to_audio_train.py --config-name flow_matching_generative_finetuning.yaml
```
- Remember to update the `init_from_nemo_model` with the pretrained checkpoint path in the config file.
Alternatively, one can also just train a flow matching generative from scratch:
```python
python examples/audio/audio_to_audio_train.py --config-name flow_matching_generative.yaml
```
Model can be evaluated using
```python
python examples/audio/audio_to_audio_eval.py \
model_path=${PATH_TO_NEMO_FILE} \
dataset_manifest=${PATH_TO_DATASET_MANIFEST} \
output_dir=${PATH_TO_OUTPUT_DIR} \
input_key=noisy_filepath \
target_key=clean_filepath \
metrics=[sdr,estoi]
```
Sampler setting can be easily overridden, e.g., to change the number of sampling steps as
```python
python examples/audio/audio_to_audio_eval.py ... ++sampler.num_steps=${NUM_STEPS}
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "anteju",
"id": 108555623,
"node_id": "U_kgDOBnhtZw",
"avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anteju",
"html_url": "https://github.com/anteju",
"followers_url": "https://api.github.com/users/anteju/followers",
"following_url": "https://api.github.com/users/anteju/following{/other_user}",
"gists_url": "https://api.github.com/users/anteju/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anteju/subscriptions",
"organizations_url": "https://api.github.com/users/anteju/orgs",
"repos_url": "https://api.github.com/users/anteju/repos",
"events_url": "https://api.github.com/users/anteju/events{/privacy}",
"received_events_url": "https://api.github.com/users/anteju/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10052/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10052/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10051 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10051/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10051/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10051/events | https://github.com/NVIDIA/NeMo/pull/10051 | 2,449,687,376 | PR_kwDOC_bI7s53ge76 | 10,051 | Bump `Dockerfile.ci` (2024-08-06) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-06T00:19:40 | 2024-08-06T07:23:21 | 2024-08-06T07:23:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10051",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10051",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10051.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10051.patch",
"merged_at": null
} | 🚀 PR to Bump `Dockerfile.ci`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10051/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10051/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10050 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10050/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10050/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10050/events | https://github.com/NVIDIA/NeMo/pull/10050 | 2,449,523,085 | PR_kwDOC_bI7s53f8E2 | 10,050 | Add moe_router_pre_softmax=True to checkpoint converters & nemo-ux | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-08-05T21:36:45 | 2024-08-06T16:29:42 | 2024-08-06T16:29:40 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10050",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10050",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10050.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10050.patch",
"merged_at": "2024-08-06T16:29:40"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10050/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10050/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10049 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10049/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10049/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10049/events | https://github.com/NVIDIA/NeMo/pull/10049 | 2,449,468,720 | PR_kwDOC_bI7s53fwcO | 10,049 | Update dev doc for features | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-05T20:57:38 | 2024-08-08T23:36:47 | 2024-08-07T21:25:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10049",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10049",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10049.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10049.patch",
"merged_at": "2024-08-07T21:25:18"
} | # What does this PR do ?
Update dev doc for features section
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10049/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10049/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10048 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10048/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10048/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10048/events | https://github.com/NVIDIA/NeMo/issues/10048 | 2,449,467,462 | I_kwDOC_bI7s6R_-hG | 10,048 | Support LLAMA 3.1 in NeMo | {
"login": "zhouku92",
"id": 144086204,
"node_id": "U_kgDOCJaUvA",
"avatar_url": "https://avatars.githubusercontent.com/u/144086204?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zhouku92",
"html_url": "https://github.com/zhouku92",
"followers_url": "https://api.github.com/users/zhouku92/followers",
"following_url": "https://api.github.com/users/zhouku92/following{/other_user}",
"gists_url": "https://api.github.com/users/zhouku92/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zhouku92/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zhouku92/subscriptions",
"organizations_url": "https://api.github.com/users/zhouku92/orgs",
"repos_url": "https://api.github.com/users/zhouku92/repos",
"events_url": "https://api.github.com/users/zhouku92/events{/privacy}",
"received_events_url": "https://api.github.com/users/zhouku92/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This has been added here: https://github.com/NVIDIA/NeMo/pull/9815\r\n\r\nPlease re-open or create a new issue if needed."
] | 2024-08-05T20:56:46 | 2024-08-21T17:57:54 | 2024-08-21T17:57:54 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Is your feature request related to a problem? Please describe.**
LLAMA3.1 introduces a new ROPE implementation, while NeMo hasn't supported it.
https://github.com/huggingface/transformers/blob/51ab25e2932da15511ced35bcbdfa92d25c4794c/src/transformers/modeling_rope_utils.py#L298
**Describe the solution you'd like**
Support the new ROPE implementation and LLAMA 3.1. | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10048/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10048/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/10047 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10047/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10047/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10047/events | https://github.com/NVIDIA/NeMo/pull/10047 | 2,449,385,045 | PR_kwDOC_bI7s53fefF | 10,047 | fix FLOPsMeasurementCallback on_train_end when experiment is None | {
"login": "arnowaczynski",
"id": 17100570,
"node_id": "MDQ6VXNlcjE3MTAwNTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/17100570?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arnowaczynski",
"html_url": "https://github.com/arnowaczynski",
"followers_url": "https://api.github.com/users/arnowaczynski/followers",
"following_url": "https://api.github.com/users/arnowaczynski/following{/other_user}",
"gists_url": "https://api.github.com/users/arnowaczynski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arnowaczynski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arnowaczynski/subscriptions",
"organizations_url": "https://api.github.com/users/arnowaczynski/orgs",
"repos_url": "https://api.github.com/users/arnowaczynski/repos",
"events_url": "https://api.github.com/users/arnowaczynski/events{/privacy}",
"received_events_url": "https://api.github.com/users/arnowaczynski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@ar-nowaczynski Can you check if https://github.com/NVIDIA/NeMo/pull/10125 fixes this issue."
] | 2024-08-05T20:04:38 | 2024-08-20T18:50:50 | 2024-08-20T18:50:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10047",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10047",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10047.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10047.patch",
"merged_at": null
} | # What does this PR do ?
Fixes basic error in recently introduced #9932 FLOPsMeasurementCallback on_train_end method when `pl_module.logger.experiment` is None.
**Collection**: common
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "arnowaczynski",
"id": 17100570,
"node_id": "MDQ6VXNlcjE3MTAwNTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/17100570?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arnowaczynski",
"html_url": "https://github.com/arnowaczynski",
"followers_url": "https://api.github.com/users/arnowaczynski/followers",
"following_url": "https://api.github.com/users/arnowaczynski/following{/other_user}",
"gists_url": "https://api.github.com/users/arnowaczynski/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arnowaczynski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arnowaczynski/subscriptions",
"organizations_url": "https://api.github.com/users/arnowaczynski/orgs",
"repos_url": "https://api.github.com/users/arnowaczynski/repos",
"events_url": "https://api.github.com/users/arnowaczynski/events{/privacy}",
"received_events_url": "https://api.github.com/users/arnowaczynski/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10047/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10047/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10046 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10046/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10046/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10046/events | https://github.com/NVIDIA/NeMo/pull/10046 | 2,449,373,046 | PR_kwDOC_bI7s53fbzF | 10,046 | Enable specifying kwargs to DDPStrategy via config for most models | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"> LGTM, thanks! I like this approach and the possibility of using an explicitly instantiated strategy. Also, learned about `Mapping`, thanks :)\r\n\r\nThanks! I added a test and one fix, should be OK to merge now."
] | 2024-08-05T19:58:59 | 2024-08-19T21:47:52 | 2024-08-19T21:47:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10046",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10046",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10046.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10046.patch",
"merged_at": "2024-08-19T21:47:51"
} | # What does this PR do ?
This change allows, amongst other things, to specify options for DDP such as `gradient_as_bucket_view=True` which saves a considerable amount of memory for 1B+ models.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10046/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10046/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10045 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10045/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10045/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10045/events | https://github.com/NVIDIA/NeMo/pull/10045 | 2,449,187,175 | PR_kwDOC_bI7s53ey2J | 10,045 | Bump `Dockerfile.ci` (2024-08-05) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-05T18:14:25 | 2024-08-06T07:23:04 | 2024-08-06T07:23:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10045",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10045",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10045.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10045.patch",
"merged_at": "2024-08-06T07:23:02"
} | 🚀 PR to Bump `Dockerfile.ci`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10045/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10045/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10044 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10044/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10044/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10044/events | https://github.com/NVIDIA/NeMo/pull/10044 | 2,449,148,750 | PR_kwDOC_bI7s53eqSM | 10,044 | [Nemo CICD] Update to PT24.05 | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-08-05T17:52:44 | 2024-08-27T01:53:03 | 2024-08-27T01:53:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10044",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10044",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10044.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10044.patch",
"merged_at": null
} | [Nemo CICD] Update to PT24.05 | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10044/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10044/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10043 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10043/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10043/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10043/events | https://github.com/NVIDIA/NeMo/pull/10043 | 2,448,997,296 | PR_kwDOC_bI7s53eIHP | 10,043 | [NeMo-UX] Fix a serialization bug affecting fsdp | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-05T16:40:22 | 2024-08-15T06:01:06 | 2024-08-15T06:01:05 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10043",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10043",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10043.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10043.patch",
"merged_at": "2024-08-15T06:01:05"
} | # What does this PR do ?
This PR recursively finds the leaves of the trainer config and calls `track_io` on the leaves. This handles the case of adding io functionality to plugins which are dictionaries.
**Collection**: llm
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10043/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10043/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10042 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10042/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10042/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10042/events | https://github.com/NVIDIA/NeMo/pull/10042 | 2,448,956,682 | PR_kwDOC_bI7s53d-_F | 10,042 | remove assertation for models with unknown chat template | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-08-05T16:18:48 | 2024-08-07T16:10:42 | 2024-08-07T16:10:39 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10042",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10042",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10042.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10042.patch",
"merged_at": "2024-08-07T16:10:39"
} | # What does this PR do ?
Use hard-coded chat-template for known models only, need a better strategy.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10042/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10042/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10041 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10041/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10041/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10041/events | https://github.com/NVIDIA/NeMo/pull/10041 | 2,448,529,032 | PR_kwDOC_bI7s53cgg9 | 10,041 | Add support for overlapped gradient and parameter synchronization for GPT SFT model | {
"login": "michal2409",
"id": 14821051,
"node_id": "MDQ6VXNlcjE0ODIxMDUx",
"avatar_url": "https://avatars.githubusercontent.com/u/14821051?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michal2409",
"html_url": "https://github.com/michal2409",
"followers_url": "https://api.github.com/users/michal2409/followers",
"following_url": "https://api.github.com/users/michal2409/following{/other_user}",
"gists_url": "https://api.github.com/users/michal2409/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michal2409/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michal2409/subscriptions",
"organizations_url": "https://api.github.com/users/michal2409/orgs",
"repos_url": "https://api.github.com/users/michal2409/repos",
"events_url": "https://api.github.com/users/michal2409/events{/privacy}",
"received_events_url": "https://api.github.com/users/michal2409/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-05T13:11:52 | 2024-08-06T17:03:42 | 2024-08-06T17:03:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10041",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10041",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10041.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10041.patch",
"merged_at": "2024-08-06T17:03:41"
} | Add support for overlapped gradient and parameter synchronization for GPT SFT model
# What does this PR do ?
Add support for overlapped gradient and parameter synchronization
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10041/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10041/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10040 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10040/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10040/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10040/events | https://github.com/NVIDIA/NeMo/issues/10040 | 2,448,452,994 | I_kwDOC_bI7s6R8G2C | 10,040 | Tips for training Ecapa-TDNN speaker recognition model as fast as possible? | {
"login": "gabitza-tech",
"id": 53811655,
"node_id": "MDQ6VXNlcjUzODExNjU1",
"avatar_url": "https://avatars.githubusercontent.com/u/53811655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gabitza-tech",
"html_url": "https://github.com/gabitza-tech",
"followers_url": "https://api.github.com/users/gabitza-tech/followers",
"following_url": "https://api.github.com/users/gabitza-tech/following{/other_user}",
"gists_url": "https://api.github.com/users/gabitza-tech/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gabitza-tech/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gabitza-tech/subscriptions",
"organizations_url": "https://api.github.com/users/gabitza-tech/orgs",
"repos_url": "https://api.github.com/users/gabitza-tech/repos",
"events_url": "https://api.github.com/users/gabitza-tech/events{/privacy}",
"received_events_url": "https://api.github.com/users/gabitza-tech/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-08-05T12:37:40 | 2024-09-12T01:55:27 | 2024-09-12T01:55:27 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello everybody,
I would like to train an Ecapa-TDNN model on Voxceleb2 and Voxceleb2+Cnceleb2 for speaker verification/identification. I don't want it to be SOA (ex: complicated pretraining and then large margin finetuning), but I want it to be moderately performant as fast as possible, as the model performance is not the primary focus.
I can train on an A100 gpu. I was thinking of randomly cropping audios in train-set to 3s and then applying RIR+musan+(0.95-1.05) speed perturbation+ spec. augment on the fly (with 0.3 probability for each one). I would also use the AAM Softmax with s=30, m=0.2 loss. How many epochs would I need to train this model and what is the expected time for training such a model? (on Voxceleb2 for example) Is it possible to obtain good performances with such a simple configuration? (under 1% EER on VoxCeleb1-O for example)
I saw that some people apply offline augmentation to create more speakers, or do 2-stage training with pretraining and then fine-tuning, etc. But I would like to train both models in just a couple of days (as an A100 is a pretty big GPU), and I don't want to achieve peak performances, such as the more complicated pipelines, but decent performances.
Any other tips would be greatly appreciated! I would mostly like to know if I could achieve these performances in a reasonable time and any other tips for fast convergence in as few epochs as possible. :D
Thank you in advance! | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10040/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10040/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/10038 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10038/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10038/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10038/events | https://github.com/NVIDIA/NeMo/issues/10038 | 2,447,746,764 | I_kwDOC_bI7s6R5abM | 10,038 | [FEA] Improve score_document (NumberOfLinesOfCodeFilter) and _line_statistics (PerExtensionFilter) | {
"login": "miguelusque",
"id": 26169771,
"node_id": "MDQ6VXNlcjI2MTY5Nzcx",
"avatar_url": "https://avatars.githubusercontent.com/u/26169771?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/miguelusque",
"html_url": "https://github.com/miguelusque",
"followers_url": "https://api.github.com/users/miguelusque/followers",
"following_url": "https://api.github.com/users/miguelusque/following{/other_user}",
"gists_url": "https://api.github.com/users/miguelusque/gists{/gist_id}",
"starred_url": "https://api.github.com/users/miguelusque/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/miguelusque/subscriptions",
"organizations_url": "https://api.github.com/users/miguelusque/orgs",
"repos_url": "https://api.github.com/users/miguelusque/repos",
"events_url": "https://api.github.com/users/miguelusque/events{/privacy}",
"received_events_url": "https://api.github.com/users/miguelusque/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Update:\r\n\r\nApologies. I opened it in the wrong repository. My bad."
] | 2024-08-05T06:46:47 | 2024-08-05T06:55:28 | 2024-08-05T06:55:28 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi!
I have noticed a couple of small changes in the code that can improve its performance:
By refactoring `score_document` as suggested, it will run between 2x and 3x faster, and will reduce by half the memory footprint.
By refactoring '_line_statistics' as suggested, it can run about 21% faster.
I will submit a PR in a few minutes with the changes.
Regards,
Miguel | {
"login": "miguelusque",
"id": 26169771,
"node_id": "MDQ6VXNlcjI2MTY5Nzcx",
"avatar_url": "https://avatars.githubusercontent.com/u/26169771?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/miguelusque",
"html_url": "https://github.com/miguelusque",
"followers_url": "https://api.github.com/users/miguelusque/followers",
"following_url": "https://api.github.com/users/miguelusque/following{/other_user}",
"gists_url": "https://api.github.com/users/miguelusque/gists{/gist_id}",
"starred_url": "https://api.github.com/users/miguelusque/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/miguelusque/subscriptions",
"organizations_url": "https://api.github.com/users/miguelusque/orgs",
"repos_url": "https://api.github.com/users/miguelusque/repos",
"events_url": "https://api.github.com/users/miguelusque/events{/privacy}",
"received_events_url": "https://api.github.com/users/miguelusque/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10038/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10038/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/10037 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10037/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10037/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10037/events | https://github.com/NVIDIA/NeMo/pull/10037 | 2,446,402,147 | PR_kwDOC_bI7s53VUF_ | 10,037 | Disable gradients in `swap_tensors()` within `ema.py` | {
"login": "amorehead",
"id": 7051982,
"node_id": "MDQ6VXNlcjcwNTE5ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/7051982?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amorehead",
"html_url": "https://github.com/amorehead",
"followers_url": "https://api.github.com/users/amorehead/followers",
"following_url": "https://api.github.com/users/amorehead/following{/other_user}",
"gists_url": "https://api.github.com/users/amorehead/gists{/gist_id}",
"starred_url": "https://api.github.com/users/amorehead/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/amorehead/subscriptions",
"organizations_url": "https://api.github.com/users/amorehead/orgs",
"repos_url": "https://api.github.com/users/amorehead/repos",
"events_url": "https://api.github.com/users/amorehead/events{/privacy}",
"received_events_url": "https://api.github.com/users/amorehead/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-08-03T15:14:23 | 2024-08-25T01:56:08 | 2024-08-25T01:56:07 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10037",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10037",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10037.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10037.patch",
"merged_at": null
} | # What does this PR do ?
Disables gradients in `swap_tensors()` within `ema.py` to prevent unintended leaf variable gradient modifications (should they arise). This was found to be necessary in certain projects that use PyTorch Lightning 2+ such as [AlphaFold3-Lightning-Hydra](https://github.com/amorehead/alphafold3-pytorch-lightning-hydra).
**Collection**: [Note which collection this PR will affect]
N/A.
# Changelog
- Disables gradients in `swap_tensors()` within `ema.py` to prevent unintended leaf variable gradient modifications (should they arise).
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10037/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10037/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10036 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10036/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10036/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10036/events | https://github.com/NVIDIA/NeMo/issues/10036 | 2,446,087,117 | I_kwDOC_bI7s6RzFPN | 10,036 | Feature Extraction with NeMo ASR Pipeline without Conformer Training | {
"login": "csetanmayjain",
"id": 37631570,
"node_id": "MDQ6VXNlcjM3NjMxNTcw",
"avatar_url": "https://avatars.githubusercontent.com/u/37631570?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/csetanmayjain",
"html_url": "https://github.com/csetanmayjain",
"followers_url": "https://api.github.com/users/csetanmayjain/followers",
"following_url": "https://api.github.com/users/csetanmayjain/following{/other_user}",
"gists_url": "https://api.github.com/users/csetanmayjain/gists{/gist_id}",
"starred_url": "https://api.github.com/users/csetanmayjain/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/csetanmayjain/subscriptions",
"organizations_url": "https://api.github.com/users/csetanmayjain/orgs",
"repos_url": "https://api.github.com/users/csetanmayjain/repos",
"events_url": "https://api.github.com/users/csetanmayjain/events{/privacy}",
"received_events_url": "https://api.github.com/users/csetanmayjain/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Hi, since you want to run only inference, you could modify the prediction_step in [model code](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/asr/models/ctc_models.py#L572) and run .predict on any model (that uses the feature extractor you are looking for) \nReference: https://lightning.ai/docs/pytorch/stable/deploy/production_basic.html ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-08-03T04:42:14 | 2024-10-30T01:59:27 | 2024-10-30T01:59:26 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Issue:**
I want to run the NeMo ASR pipeline to analyze the features using different parameters, datasets, and strategies. However, I do not want to run the conformer training. Instead, I only want to extract the features from the input JSON files and store them.
**Current Understanding:**
From my understanding, the current pipeline flow is as follows:
```
For each batch:
extract features -> apply augmentation (if required) -> train -> validation
```
**Requirement:**
I need to comment out or disable the training & further parts so that the pipeline loops back to the next batch to continue feature extraction. Despite reviewing various parts of the internal code pipeline, I am unable to pinpoint where and how to make these changes.
**Version:**
NeMo version: 1.12.0rc0 (I know it's pretty old, but I have already performed a few experiments using it, so I don't want to change anything.)
Pytorch Lightning: 1.7.4
**Request for Help:**
Could you please guide me on how to disable the training & further portion while ensuring that the feature extraction continues to function as required?
Thank you. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10036/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10036/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/10035 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10035/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10035/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10035/events | https://github.com/NVIDIA/NeMo/pull/10035 | 2,445,963,352 | PR_kwDOC_bI7s53T5Gi | 10,035 | [lhotse] Support for NeMo tarred manifests with offset field | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@pzelasko I checked, caching `TarInfo`s with a single linear scan lets then extract in O(1):\r\n```python\r\ndef taropen_build(tar_path):\r\n import tarfile\r\n tar = tarfile.open(tar_path)\r\n tarinfo_index = {tarinfo.name : tarinfo for tarinfo in tar.getmembers()}\r\n return lambda member_path, mode: tar.extractfile(tarinfo_index[member_path]) if mode == 'rb' else None\r\n\r\n # instead for uncompressed tars (which makes sense for audio files) can do without caching the TarInfo structure and just cache two ints per string file name, this makes it more amenable to sharing between DataLoader threads and easier to sync in tensors\r\n #import io\r\n #tarinfo_index = {tarinfo.name : (tarinfo.offset_data, tarinfo.size) for tarinfo in tar.getmembers()}\r\n #return lambda member_path, mode: [io.BytesIO(f.seek(e[0]) and f.read(e[1])) for f in [open(tar_path, mode)] for e in [tarinfo_index[member_path]]][0] if mode == 'rb' else None\r\n\r\nif __name__ == '__main__':\r\n taropen = taropen_build('myfile.tar')\r\n print(taropen('mymember.txt', 'rb').read())\r\n```\r\n\r\nSupporting `.tar`s with wav/opus files inside would be very nice, as these small audio files can be in 10s or 100s of thousands which is always a pressure on the file system and adds time to unpacking",
"We already support tars with wav/opus. Linear scan is not feasible for URL data sources (cloud storage, AIStore). "
] | 2024-08-03T02:28:21 | 2024-08-30T19:54:52 | 2024-08-07T15:59:35 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10035",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10035",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10035.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10035.patch",
"merged_at": "2024-08-07T15:59:35"
} | # What does this PR do ?
Support for NeMo tarred manifests with offset field in lhotse dataloading.
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10035/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10035/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10034 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10034/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10034/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10034/events | https://github.com/NVIDIA/NeMo/issues/10034 | 2,445,935,275 | I_kwDOC_bI7s6RygKr | 10,034 | AttributeError: 'MegatronGPTModel' object has no attribute 'decoder' | {
"login": "lianghsun",
"id": 25081193,
"node_id": "MDQ6VXNlcjI1MDgxMTkz",
"avatar_url": "https://avatars.githubusercontent.com/u/25081193?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lianghsun",
"html_url": "https://github.com/lianghsun",
"followers_url": "https://api.github.com/users/lianghsun/followers",
"following_url": "https://api.github.com/users/lianghsun/following{/other_user}",
"gists_url": "https://api.github.com/users/lianghsun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lianghsun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lianghsun/subscriptions",
"organizations_url": "https://api.github.com/users/lianghsun/orgs",
"repos_url": "https://api.github.com/users/lianghsun/repos",
"events_url": "https://api.github.com/users/lianghsun/events{/privacy}",
"received_events_url": "https://api.github.com/users/lianghsun/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"I'm curious if by retraining you might mean continued training? https://docs.nvidia.com/nemo-framework/user-guide/latest/llms/allmodels/continuetraining.html?highlight=continued%2520training#configure-continual-learning\r\n\r\nRegarding your error, the decoder module will be `MegatronGPTModel.model.decoder` I believe. But you can check by inspecting the `MegatronGPTModel` ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-08-03T01:28:47 | 2024-09-30T02:00:32 | 2024-09-30T02:00:32 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | #### Description
I am retraining a LLaMA3 model. Due to the limited size of my dataset, I attempted to use `freeze_updates` as referenced in the [NVIDIA NeMo documentation](https://docs.nvidia.com/nemo-framework/user-guide/latest/nemotoolkit/core/neural_modules.html#dynamic-layer-freezing). My configuration is as follows:
```yaml
freeze_updates:
enabled: true # set to false if you want to disable freezing
modules: # list all of the modules you want to have freezing logic for
decoder: 100
```
However, I encountered the following error:
```
AttributeError: 'MegatronGPTModel' object has no attribute 'decoder'
```
I also tried changing decoder to `encoder` or `joint`, but I still faced errors. I would like to ask how to properly configure this setting?
Additionally, within the NeMo framework, is it possible to freeze specific layers, such as only the attention layer? If so, how can I achieve this? Thanks! | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10034/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10034/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/10033 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10033/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10033/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10033/events | https://github.com/NVIDIA/NeMo/pull/10033 | 2,445,922,085 | PR_kwDOC_bI7s53TwG9 | 10,033 | [NeMo-UX] Change default interval to step and add lr in prog_bar in nemo.lightning | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-03T00:54:07 | 2024-08-06T18:21:35 | 2024-08-06T18:21:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10033",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10033",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10033.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10033.patch",
"merged_at": "2024-08-06T18:21:33"
} | # What does this PR do ?
Default interval for lr_schedulers was `epoch` which means the lr was never getting updated for nemo.collections.llm examples.
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10033/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10033/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10032 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10032/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10032/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10032/events | https://github.com/NVIDIA/NeMo/pull/10032 | 2,445,868,290 | PR_kwDOC_bI7s53Tkbc | 10,032 | Fix metric logging | {
"login": "maanug-nv",
"id": 109391026,
"node_id": "U_kgDOBoUssg",
"avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maanug-nv",
"html_url": "https://github.com/maanug-nv",
"followers_url": "https://api.github.com/users/maanug-nv/followers",
"following_url": "https://api.github.com/users/maanug-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions",
"organizations_url": "https://api.github.com/users/maanug-nv/orgs",
"repos_url": "https://api.github.com/users/maanug-nv/repos",
"events_url": "https://api.github.com/users/maanug-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/maanug-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Please update base branch to `main`.",
"stopping this until NeMo CI is out of maintenance mode"
] | 2024-08-02T23:12:31 | 2024-08-16T19:39:49 | 2024-08-16T19:39:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10032",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10032",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10032.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10032.patch",
"merged_at": "2024-08-16T19:39:47"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Remove `rank_zero_only=True` flag, unless used as [documented](https://lightning.ai/docs/pytorch/stable/visualize/logging_advanced.html#rank-zero-only)
- Refactor train and val loss logging
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10032/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10032/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10031 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10031/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10031/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10031/events | https://github.com/NVIDIA/NeMo/pull/10031 | 2,445,665,266 | PR_kwDOC_bI7s53S3Zp | 10,031 | Nemotron Conversion script | {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-02T19:47:41 | 2024-08-06T17:15:01 | 2024-08-06T17:14:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10031",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10031",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10031.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10031.patch",
"merged_at": "2024-08-06T17:14:59"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "suiyoubi",
"id": 22045332,
"node_id": "MDQ6VXNlcjIyMDQ1MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/suiyoubi",
"html_url": "https://github.com/suiyoubi",
"followers_url": "https://api.github.com/users/suiyoubi/followers",
"following_url": "https://api.github.com/users/suiyoubi/following{/other_user}",
"gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions",
"organizations_url": "https://api.github.com/users/suiyoubi/orgs",
"repos_url": "https://api.github.com/users/suiyoubi/repos",
"events_url": "https://api.github.com/users/suiyoubi/events{/privacy}",
"received_events_url": "https://api.github.com/users/suiyoubi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10031/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10031/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10030 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10030/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10030/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10030/events | https://github.com/NVIDIA/NeMo/pull/10030 | 2,445,655,608 | PR_kwDOC_bI7s53S1Uv | 10,030 | remove prepare_youmakeup.py | {
"login": "Slyne",
"id": 6286804,
"node_id": "MDQ6VXNlcjYyODY4MDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6286804?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Slyne",
"html_url": "https://github.com/Slyne",
"followers_url": "https://api.github.com/users/Slyne/followers",
"following_url": "https://api.github.com/users/Slyne/following{/other_user}",
"gists_url": "https://api.github.com/users/Slyne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Slyne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Slyne/subscriptions",
"organizations_url": "https://api.github.com/users/Slyne/orgs",
"repos_url": "https://api.github.com/users/Slyne/repos",
"events_url": "https://api.github.com/users/Slyne/events{/privacy}",
"received_events_url": "https://api.github.com/users/Slyne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"The `Isort and Black Formatting / reformat_with_isort_and_black` test is not passed.\r\nNot sure about the reason."
] | 2024-08-02T19:41:08 | 2024-08-06T15:24:11 | 2024-08-06T15:24:04 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10030",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10030",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10030.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10030.patch",
"merged_at": null
} |
# What does this PR do ?
Hi, sorry to bother.
There might be some dataset license issues. So need to remove the dataset downloading and preprocessing script.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Slyne",
"id": 6286804,
"node_id": "MDQ6VXNlcjYyODY4MDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6286804?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Slyne",
"html_url": "https://github.com/Slyne",
"followers_url": "https://api.github.com/users/Slyne/followers",
"following_url": "https://api.github.com/users/Slyne/following{/other_user}",
"gists_url": "https://api.github.com/users/Slyne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Slyne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Slyne/subscriptions",
"organizations_url": "https://api.github.com/users/Slyne/orgs",
"repos_url": "https://api.github.com/users/Slyne/repos",
"events_url": "https://api.github.com/users/Slyne/events{/privacy}",
"received_events_url": "https://api.github.com/users/Slyne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10030/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10030/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10029 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10029/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10029/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10029/events | https://github.com/NVIDIA/NeMo/issues/10029 | 2,445,599,654 | I_kwDOC_bI7s6RxOOm | 10,029 | Model / Checkpoints mismatch | {
"login": "moutasemalakkad",
"id": 39648266,
"node_id": "MDQ6VXNlcjM5NjQ4MjY2",
"avatar_url": "https://avatars.githubusercontent.com/u/39648266?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/moutasemalakkad",
"html_url": "https://github.com/moutasemalakkad",
"followers_url": "https://api.github.com/users/moutasemalakkad/followers",
"following_url": "https://api.github.com/users/moutasemalakkad/following{/other_user}",
"gists_url": "https://api.github.com/users/moutasemalakkad/gists{/gist_id}",
"starred_url": "https://api.github.com/users/moutasemalakkad/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/moutasemalakkad/subscriptions",
"organizations_url": "https://api.github.com/users/moutasemalakkad/orgs",
"repos_url": "https://api.github.com/users/moutasemalakkad/repos",
"events_url": "https://api.github.com/users/moutasemalakkad/events{/privacy}",
"received_events_url": "https://api.github.com/users/moutasemalakkad/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"Which version of nemo are you using? The model card: https://huggingface.co/nvidia/nemo-megatron-gpt-5B is using v1.11.0. \r\n\r\nI would recommend using a newer model if possible. This model is quite out of date and likely won't perform as well as more recent models.",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days."
] | 2024-08-02T19:06:06 | 2024-09-25T18:11:59 | 2024-09-25T18:11:59 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
When attempting to launch training using the specified configuration files and code snippet, a key mismatch error occurs between the model and the dictionary. How to proceed?
**Model:**
https://huggingface.co/nvidia/nemo-megatron-gpt-5B/resolve/main/nemo_gpt5B_fp16_tp1.nemo
**Steps/Code to reproduce bug**
1. Load the original configuration file:
```python
ori_conf = OmegaConf.load('models/extracted_model/model_config.yaml')
```
2. Load the new configuration file:
```python
conf = OmegaConf.load('config/megatron_gpt_config.yaml')
```
3. Update the model configuration with keys from the original configuration:
```python
for key in ori_conf.keys():
conf['model'][key] = ori_conf[key]
```
4. Set the global batch size based on the micro batch size:
```python
conf['model']["global_batch_size"] = conf['model']["micro_batch_size"] * conf.get('data_model_parallel_size', 1) * conf.get('gradient_accumulation_steps', 1)
```
5. Update the data prefix:
```python
conf['model']['data']['data_prefix'] = 'data_ready_for_training/validation'
```
6. Update tokenizer configuration:
```python
NEW_TOKENIZER_PATH = "tokenizers/final_merged_arabic_english_gpt2base"
conf['model']['tokenizer']['vocab_file'] = f"{NEW_TOKENIZER_PATH}/vocab.json"
conf['model']['tokenizer']['merge_file'] = f"{NEW_TOKENIZER_PATH}/merges.txt"
conf['model']['vocab_file'] = f"{NEW_TOKENIZER_PATH}/vocab.json"
conf['model']['merges_file'] = f"{NEW_TOKENIZER_PATH}/merges.txt"
```
7. Save the modified configuration:
```python
OmegaConf.save(config=conf, f='config/modifiedmegatron_gpt_config.yaml')
```
8. Launch the training process and observe the key mismatch error.
**Expected behavior**
The training process should launch successfully without any key mismatch errors. The configuration should be correctly applied, and the model should start training using the specified settings.
**Environment overview (please complete the following information)**
- **Environment location:** Bare-metal
- **Method of NeMo install:** pip install
```bash
pip install nemo_toolkit[all]
```
**Environment details**
- **OS version:** Ubuntu 20.04
- **PyTorch version:** 1.11.0
- **Python version:** 3.8.10
**Additional context**
- **GPU model:** NVIDIA A100
The key mismatch error likely arises due to differences between the keys expected by the model and those present in the configuration files. Ensure that all necessary keys are correctly mapped and that there are no discrepancies between the configuration files.
**Log (Sample - not full)**
`Exception has occurred: RuntimeError
Error(s) in loading state_dict for MegatronGPTModel:
Missing key(s) in state_dict: "model.embedding.word_embeddings.weight", "model.embedding.position_embeddings.weight", "model.decoder.layers.0.input_layernorm.weight", "model.decoder.layers.0.input_layernorm.bias", "model.decoder.layers.0.self_attention.linear_proj.weight", "model.decoder.layers.0.self_attention.linear_proj.bias", "model.decoder.layers.0.self_attention.linear_qkv.weight", "model.decoder.layers.0.self_attention.linear_qkv.bias", "model.decoder.layers.0.pre_mlp_layernorm.weight", "model.decoder.layers.0.pre_mlp_layernorm.bias", "model.decoder.layers.0.mlp.linear_fc1.weight", "model.decoder.layers.0.mlp.linear_fc1.bias", "model.decoder.layers.0.mlp.linear_fc2.weight", "model.decoder.layers.0.mlp.linear_fc2.bias", "model.decoder.layers.1.input_layernorm.weight", "model.decoder.layers.1.input_layernorm.bias", "model.decoder.layers.1.self_attention.linear_proj.weight", "model.decoder.layers.1.self_attention.linear_proj.bias", "model.decoder.layers.1.self_attention.linear_qkv.weight",
Unexpected key(s) in state_dict: "model.language_model.embedding.word_embeddings.weight", "model.language_model.embedding.position_embeddings.weight", "model.language_model.encoder.layers.0.input_layernorm.weight", "model.language_model.encoder.layers.0.input_layernorm.bias", "model.language_model.encoder.layers.0.self_attention.query_key_value.weight", "model.language_model.encoder.layers.0.self_attention.query_key_value.bias", "model.language_model.encoder.layers.0.self_attention.query_key_value._extra_state", "model.language_model.encoder.layers.0.self_attention.dense.weight", "model.language_model.encoder.layers.0.self_attention.dense.bias", "model.language_model.encoder.layers.0.self_attention.dense._extra_state", "model.language_model.encoder.layers.0.post_attention_layernorm.weight",
**Config file used**
[megatron_gpt_config.yaml](https://github.com/NVIDIA/NeMo/blob/7cf703c576d7d8d1a55c602353c23ead88b92bb5/examples/nlp/language_modeling/conf/megatron_gpt_config.yaml#L4) | {
"login": "elliottnv",
"id": 159969975,
"node_id": "U_kgDOCYjytw",
"avatar_url": "https://avatars.githubusercontent.com/u/159969975?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/elliottnv",
"html_url": "https://github.com/elliottnv",
"followers_url": "https://api.github.com/users/elliottnv/followers",
"following_url": "https://api.github.com/users/elliottnv/following{/other_user}",
"gists_url": "https://api.github.com/users/elliottnv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/elliottnv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/elliottnv/subscriptions",
"organizations_url": "https://api.github.com/users/elliottnv/orgs",
"repos_url": "https://api.github.com/users/elliottnv/repos",
"events_url": "https://api.github.com/users/elliottnv/events{/privacy}",
"received_events_url": "https://api.github.com/users/elliottnv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10029/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10029/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/10028 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10028/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10028/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10028/events | https://github.com/NVIDIA/NeMo/pull/10028 | 2,445,580,382 | PR_kwDOC_bI7s53Skln | 10,028 | remove prepare_youmakeup.py | {
"login": "Slyne",
"id": 6286804,
"node_id": "MDQ6VXNlcjYyODY4MDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6286804?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Slyne",
"html_url": "https://github.com/Slyne",
"followers_url": "https://api.github.com/users/Slyne/followers",
"following_url": "https://api.github.com/users/Slyne/following{/other_user}",
"gists_url": "https://api.github.com/users/Slyne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Slyne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Slyne/subscriptions",
"organizations_url": "https://api.github.com/users/Slyne/orgs",
"repos_url": "https://api.github.com/users/Slyne/repos",
"events_url": "https://api.github.com/users/Slyne/events{/privacy}",
"received_events_url": "https://api.github.com/users/Slyne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [] | 2024-08-02T18:53:50 | 2024-08-05T21:41:17 | 2024-08-05T21:41:17 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10028",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10028",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10028.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10028.patch",
"merged_at": "2024-08-05T21:41:17"
} | # What does this PR do ?
Due to license issue, we need to remove the data downloading and preprocessing script.
**Collection**: [Note which collection this PR will affect]
None of the collection will be affected;
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10028/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10028/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10027 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10027/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10027/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10027/events | https://github.com/NVIDIA/NeMo/pull/10027 | 2,445,567,727 | PR_kwDOC_bI7s53ShzZ | 10,027 | Update continual pre-training argument override strategy | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-02T18:45:18 | 2024-08-05T20:55:11 | 2024-08-05T20:55:10 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10027",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10027",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10027.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10027.patch",
"merged_at": "2024-08-05T20:55:10"
} | # What does this PR do ?
Update continual pre-training argument override strategy. Input args are going to be merged with existing ones inside the checkpoint.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10027/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10027/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10026 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10026/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10026/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10026/events | https://github.com/NVIDIA/NeMo/pull/10026 | 2,445,446,507 | PR_kwDOC_bI7s53SHYq | 10,026 | Integrate mcore TRT-LLM export | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-08-02T17:21:30 | 2024-08-30T01:54:47 | 2024-08-30T01:54:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10026",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10026",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10026.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10026.patch",
"merged_at": null
} | # What does this PR do ?
Replacing export functions with the mcore ones.
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10026/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10026/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10025 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10025/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10025/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10025/events | https://github.com/NVIDIA/NeMo/pull/10025 | 2,445,175,453 | PR_kwDOC_bI7s53RKnJ | 10,025 | Disable barriers leading to deadlocks in checkpointing with multi-node training | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-08-02T15:07:49 | 2024-08-24T01:50:34 | 2024-08-24T01:50:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10025",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10025",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10025.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10025.patch",
"merged_at": null
} | # What does this PR do ?
Per internal slack conversation, some multi-node trainings suffered from checkpoints being randomly removed between resumed jobs. After disabling `save_top_k` checkpointing option, the training is then running into deadlocks related to unfinished/last checkpoint logic. I traced down the deadlocks to a number of barriers, that when removed, seem to unblock the training.
**Collection**: All
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10025/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10025/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10024 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10024/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10024/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10024/events | https://github.com/NVIDIA/NeMo/pull/10024 | 2,445,146,203 | PR_kwDOC_bI7s53REHF | 10,024 | clean up asr finetune | {
"login": "stevehuang52",
"id": 105218074,
"node_id": "U_kgDOBkWAGg",
"avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stevehuang52",
"html_url": "https://github.com/stevehuang52",
"followers_url": "https://api.github.com/users/stevehuang52/followers",
"following_url": "https://api.github.com/users/stevehuang52/following{/other_user}",
"gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}",
"starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions",
"organizations_url": "https://api.github.com/users/stevehuang52/orgs",
"repos_url": "https://api.github.com/users/stevehuang52/repos",
"events_url": "https://api.github.com/users/stevehuang52/events{/privacy}",
"received_events_url": "https://api.github.com/users/stevehuang52/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-02T14:55:10 | 2024-08-02T14:58:24 | 2024-08-02T14:58:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10024",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10024",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10024.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10024.patch",
"merged_at": "2024-08-02T14:58:23"
} | # What does this PR do ?
clean up asr finetune script to avoid confusion
**Collection**: [asr]
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10024/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10024/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10023 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10023/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10023/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10023/events | https://github.com/NVIDIA/NeMo/pull/10023 | 2,444,590,199 | PR_kwDOC_bI7s53PIyv | 10,023 | add feature to drop checkpoint layers | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-02T09:58:55 | 2024-08-07T09:39:40 | 2024-08-07T09:39:40 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10023",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10023",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10023.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10023.patch",
"merged_at": null
} | # What does this PR do ?
1. Adds a feature similar to mcore's --skip-train flag.
2. Adds drop-layers feature support.
3. Adds script which loads the ckpt, trims needed layers, and saves trimmed checkpoint.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10023/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10023/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10021 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10021/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10021/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10021/events | https://github.com/NVIDIA/NeMo/pull/10021 | 2,444,213,243 | PR_kwDOC_bI7s53N0_h | 10,021 | mistral ckpt converter tokenizer fix | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-08-02T06:54:17 | 2024-08-13T23:30:54 | 2024-08-13T23:30:53 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10021",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10021",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10021.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10021.patch",
"merged_at": "2024-08-13T23:30:53"
} | # What does this PR do ?
For instruct models fallback to HF tokenizer.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10021/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10021/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10020 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10020/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10020/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10020/events | https://github.com/NVIDIA/NeMo/pull/10020 | 2,443,920,046 | PR_kwDOC_bI7s53MzmG | 10,020 | Upcycling support for GPT based model to a MoE model | {
"login": "adityavavre",
"id": 43115743,
"node_id": "MDQ6VXNlcjQzMTE1NzQz",
"avatar_url": "https://avatars.githubusercontent.com/u/43115743?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adityavavre",
"html_url": "https://github.com/adityavavre",
"followers_url": "https://api.github.com/users/adityavavre/followers",
"following_url": "https://api.github.com/users/adityavavre/following{/other_user}",
"gists_url": "https://api.github.com/users/adityavavre/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adityavavre/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adityavavre/subscriptions",
"organizations_url": "https://api.github.com/users/adityavavre/orgs",
"repos_url": "https://api.github.com/users/adityavavre/repos",
"events_url": "https://api.github.com/users/adityavavre/events{/privacy}",
"received_events_url": "https://api.github.com/users/adityavavre/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"could you also provide the instruction to run the script?",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-08-02T03:26:13 | 2024-10-20T23:41:56 | 2024-09-15T02:12:50 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10020",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10020",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10020.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10020.patch",
"merged_at": null
} | # What does this PR do ?
This is closed. New PR here: https://github.com/NVIDIA/NeMo/pull/10485
Adds support for upcycling pretrained weights to a MoE model. This follows the paper: SPARSE UPCYCLING: TRAINING MIXTURE-OF-EXPERTS FROM DENSE CHECKPOINTS ([https://arxiv.org/pdf/2212.05055](https://arxiv.org/pdf/2212.05055))
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
```python
python NeMo/examples/nlp/language_modeling/megatron_gpt_upcycling.py \
--config-path=/path/to/MoE/config/ \
--config-name=MoE/config/name.yaml \
+restore_from_path=/path/to/base/model
```
Where you MoE config should contain the target MoE model you want to train. The base model you want to upcycle can also be directly added to this config under the argument `restore_from_path`.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "adityavavre",
"id": 43115743,
"node_id": "MDQ6VXNlcjQzMTE1NzQz",
"avatar_url": "https://avatars.githubusercontent.com/u/43115743?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adityavavre",
"html_url": "https://github.com/adityavavre",
"followers_url": "https://api.github.com/users/adityavavre/followers",
"following_url": "https://api.github.com/users/adityavavre/following{/other_user}",
"gists_url": "https://api.github.com/users/adityavavre/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adityavavre/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adityavavre/subscriptions",
"organizations_url": "https://api.github.com/users/adityavavre/orgs",
"repos_url": "https://api.github.com/users/adityavavre/repos",
"events_url": "https://api.github.com/users/adityavavre/events{/privacy}",
"received_events_url": "https://api.github.com/users/adityavavre/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10020/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10020/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10019 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10019/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10019/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10019/events | https://github.com/NVIDIA/NeMo/pull/10019 | 2,443,890,118 | PR_kwDOC_bI7s53MtFz | 10,019 | Support multiple hard negatives in GPT embedding model | {
"login": "adityavavre",
"id": 43115743,
"node_id": "MDQ6VXNlcjQzMTE1NzQz",
"avatar_url": "https://avatars.githubusercontent.com/u/43115743?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adityavavre",
"html_url": "https://github.com/adityavavre",
"followers_url": "https://api.github.com/users/adityavavre/followers",
"following_url": "https://api.github.com/users/adityavavre/following{/other_user}",
"gists_url": "https://api.github.com/users/adityavavre/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adityavavre/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adityavavre/subscriptions",
"organizations_url": "https://api.github.com/users/adityavavre/orgs",
"repos_url": "https://api.github.com/users/adityavavre/repos",
"events_url": "https://api.github.com/users/adityavavre/events{/privacy}",
"received_events_url": "https://api.github.com/users/adityavavre/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | {
"login": "adityavavre",
"id": 43115743,
"node_id": "MDQ6VXNlcjQzMTE1NzQz",
"avatar_url": "https://avatars.githubusercontent.com/u/43115743?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adityavavre",
"html_url": "https://github.com/adityavavre",
"followers_url": "https://api.github.com/users/adityavavre/followers",
"following_url": "https://api.github.com/users/adityavavre/following{/other_user}",
"gists_url": "https://api.github.com/users/adityavavre/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adityavavre/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adityavavre/subscriptions",
"organizations_url": "https://api.github.com/users/adityavavre/orgs",
"repos_url": "https://api.github.com/users/adityavavre/repos",
"events_url": "https://api.github.com/users/adityavavre/events{/privacy}",
"received_events_url": "https://api.github.com/users/adityavavre/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "adityavavre",
"id": 43115743,
"node_id": "MDQ6VXNlcjQzMTE1NzQz",
"avatar_url": "https://avatars.githubusercontent.com/u/43115743?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/adityavavre",
"html_url": "https://github.com/adityavavre",
"followers_url": "https://api.github.com/users/adityavavre/followers",
"following_url": "https://api.github.com/users/adityavavre/following{/other_user}",
"gists_url": "https://api.github.com/users/adityavavre/gists{/gist_id}",
"starred_url": "https://api.github.com/users/adityavavre/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adityavavre/subscriptions",
"organizations_url": "https://api.github.com/users/adityavavre/orgs",
"repos_url": "https://api.github.com/users/adityavavre/repos",
"events_url": "https://api.github.com/users/adityavavre/events{/privacy}",
"received_events_url": "https://api.github.com/users/adityavavre/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-08-02T02:54:52 | 2024-09-26T01:58:16 | 2024-09-26T01:58:15 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10019",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10019",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10019.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10019.patch",
"merged_at": null
} | # What does this PR do ?
Adds support for multiple hard negatives in GPT Embedding model during training
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10019/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10019/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10018 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10018/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10018/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10018/events | https://github.com/NVIDIA/NeMo/pull/10018 | 2,443,863,887 | PR_kwDOC_bI7s53MncL | 10,018 | [NeMo-UX] Fix logging of consumed samples in MegatronDataSampler | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-02T02:27:39 | 2024-08-06T20:07:47 | 2024-08-06T20:07:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10018",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10018",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10018.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10018.patch",
"merged_at": "2024-08-06T20:07:45"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10018/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10018/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10017 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10017/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10017/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10017/events | https://github.com/NVIDIA/NeMo/pull/10017 | 2,443,731,024 | PR_kwDOC_bI7s53MK3x | 10,017 | Bump `Dockerfile.ci` (2024-08-02) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-02T00:19:26 | 2024-08-02T23:37:42 | 2024-08-02T23:37:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10017",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10017",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10017.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10017.patch",
"merged_at": "2024-08-02T23:37:41"
} | 🚀 PR to Bump `Dockerfile.ci`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10017/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10017/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10016 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10016/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10016/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10016/events | https://github.com/NVIDIA/NeMo/pull/10016 | 2,443,702,171 | PR_kwDOC_bI7s53MEkK | 10,016 | Bug fix for pooler causing dist checkpointing exception | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-08-01T23:53:25 | 2024-09-11T01:55:15 | 2024-09-11T01:55:15 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10016",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10016",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10016.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10016.patch",
"merged_at": null
} | # What does this PR do ?
Move pooler into the flag of post processing so that it doesn't get built on all the pp ranks.
Add a one line overview of what this PR aims to accomplish.
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10016/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10016/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10015 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10015/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10015/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10015/events | https://github.com/NVIDIA/NeMo/pull/10015 | 2,443,640,355 | PR_kwDOC_bI7s53L2yh | 10,015 | test main | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-01T23:06:05 | 2024-08-02T23:38:41 | 2024-08-02T23:38:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10015",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10015",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10015.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10015.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10015/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10015/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10014 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10014/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10014/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10014/events | https://github.com/NVIDIA/NeMo/pull/10014 | 2,443,502,222 | PR_kwDOC_bI7s53LXwT | 10,014 | [NeMo-UX] Wait for async checkpoint calls to complete in preemption callback | {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-01T21:29:43 | 2024-08-02T22:04:48 | 2024-08-02T22:04:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10014",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10014",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10014.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10014.patch",
"merged_at": "2024-08-02T22:04:47"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hemildesai",
"id": 8195444,
"node_id": "MDQ6VXNlcjgxOTU0NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8195444?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hemildesai",
"html_url": "https://github.com/hemildesai",
"followers_url": "https://api.github.com/users/hemildesai/followers",
"following_url": "https://api.github.com/users/hemildesai/following{/other_user}",
"gists_url": "https://api.github.com/users/hemildesai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hemildesai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hemildesai/subscriptions",
"organizations_url": "https://api.github.com/users/hemildesai/orgs",
"repos_url": "https://api.github.com/users/hemildesai/repos",
"events_url": "https://api.github.com/users/hemildesai/events{/privacy}",
"received_events_url": "https://api.github.com/users/hemildesai/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10014/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10014/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10013 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10013/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10013/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10013/events | https://github.com/NVIDIA/NeMo/issues/10013 | 2,443,456,267 | I_kwDOC_bI7s6RpC8L | 10,013 | Error in converting convert Huggingface LLaMA3.1 checkpoints into nemo checkpoint | {
"login": "RadhaGulhane13",
"id": 68048778,
"node_id": "MDQ6VXNlcjY4MDQ4Nzc4",
"avatar_url": "https://avatars.githubusercontent.com/u/68048778?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/RadhaGulhane13",
"html_url": "https://github.com/RadhaGulhane13",
"followers_url": "https://api.github.com/users/RadhaGulhane13/followers",
"following_url": "https://api.github.com/users/RadhaGulhane13/following{/other_user}",
"gists_url": "https://api.github.com/users/RadhaGulhane13/gists{/gist_id}",
"starred_url": "https://api.github.com/users/RadhaGulhane13/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RadhaGulhane13/subscriptions",
"organizations_url": "https://api.github.com/users/RadhaGulhane13/orgs",
"repos_url": "https://api.github.com/users/RadhaGulhane13/repos",
"events_url": "https://api.github.com/users/RadhaGulhane13/events{/privacy}",
"received_events_url": "https://api.github.com/users/RadhaGulhane13/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"I have the same issue...",
"I have the same issue...",
"@XugZhao @Luxur @RadhaGulhane13 The issue is the current Llama 3.1 model on HF (which you fetch when running the conversion script) is built with the new version of the Transformers library, which was released after our `nvcr.io/nvidia/nemo:24.05.llama3.1`, and has some naming differences compared to the version of the Transformer library installed in the `nvcr.io/nvidia/nemo:24.05.llama3.1` container. To resolve the issue you can use the our dev container `nvcr.io/nvidia/nemo:dev`, and run the same command but add `--llama31 True`"
] | 2024-08-01T21:12:17 | 2024-08-24T14:39:55 | 2024-08-24T14:39:55 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I'm trying to convert **LLama3.1-8b huggingface** checkpoint into **nemo** checkpoint using `convert_llama_hf_to_nemo.py` script. It's giving `ValueError: `rope_scaling` must be a dictionary with two fields, `type` and `factor`, got {'factor': 8.0, 'low_freq_factor': 1.0, 'high_freq_factor': 4.0, 'original_max_position_embeddings': 8192, 'rope_type': 'llama3'}`
Find the complete trace below :
```
File "/opt/NeMo/scripts/checkpoint_converters/convert_llama_hf_to_nemo.py", line 327, in <module>
convert(args)
File "/opt/NeMo/scripts/checkpoint_converters/convert_llama_hf_to_nemo.py", line 126, in convert
model = LlamaForCausalLM.from_pretrained(args.input_name_or_path)
File "/usr/local/lib/python3.10/dist-packages/transformers/modeling_utils.py", line 3122, in from_pretrained
config, model_kwargs = cls.config_class.from_pretrained(
File "/usr/local/lib/python3.10/dist-packages/transformers/configuration_utils.py", line 609, in from_pretrained
return cls.from_dict(config_dict, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/transformers/configuration_utils.py", line 761, in from_dict
config = cls(**config_dict)
File "/usr/local/lib/python3.10/dist-packages/transformers/models/llama/configuration_llama.py", line 161, in __init__
self._rope_scaling_validation()
File "/usr/local/lib/python3.10/dist-packages/transformers/models/llama/configuration_llama.py", line 181, in _rope_scaling_validation
raise ValueError(
ValueError: `rope_scaling` must be a dictionary with two fields, `type` and `factor`, got {'factor': 8.0, 'low_freq_factor': 1.0, 'high_freq_factor': 4.0, 'original_max_position_embeddings': 8192, 'rope_type': 'llama3'}
```
**Steps/Code to reproduce bug**
```
python <path_to_NeMo>/scripts/checkpoint_converters/convert_llama_hf_to_nemo.py --input_name_or_path Meta-Llama-3.1-8B-Instruct/ --output_path Meta-Llama-3.1-8B-Instruct.nemo
```
**Expected behavior**
Successful conversion of llama3.1-8b hf checkpoints into nemo checkpoint.
**Environment overview (please complete the following information)**
- I'm using `nvcr.io/nvidia/nemo:24.05.llama3.1`
- `doker pull nvcr.io/nvidia/nemo:24.05.llama3.1` & `docker run -it --name nemo nvcr.io/nvidia/nemo:24.05.llama3.1`
**Additional context**
NeMo frameworks currently support only **linear** RoPE scaling for LLaMA models. I'm wondering if there are any ongoing efforts for **dynamic** or **yarn** RoPE scaling to support large context windows with LLaMA 3.1.
| {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10013/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10013/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/10012 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10012/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10012/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10012/events | https://github.com/NVIDIA/NeMo/pull/10012 | 2,443,440,921 | PR_kwDOC_bI7s53LJxN | 10,012 | Make MegatronStrategy.parallelism return ParallelismConfig | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-08-01T21:05:32 | 2024-08-07T19:01:18 | 2024-08-07T19:01:16 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10012",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10012",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10012.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10012.patch",
"merged_at": "2024-08-07T19:01:16"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10012/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10012/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10011 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10011/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10011/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10011/events | https://github.com/NVIDIA/NeMo/pull/10011 | 2,443,182,639 | PR_kwDOC_bI7s53KP5H | 10,011 | TRT-LLM checkpoint in safetensors | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-01T18:55:39 | 2024-08-02T17:23:08 | 2024-08-02T17:23:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10011",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10011",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10011.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10011.patch",
"merged_at": "2024-08-02T17:23:08"
} | # What does this PR do ?
Adding a function to allow users to get trt-llm checkpoint in safetensor format. | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10011/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10011/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10010 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10010/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10010/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10010/events | https://github.com/NVIDIA/NeMo/pull/10010 | 2,443,129,991 | PR_kwDOC_bI7s53KEV4 | 10,010 | add the mcore interface for optim arg; average_in_collective | {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-01T18:32:06 | 2024-08-07T17:11:51 | 2024-08-07T17:11:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10010",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10010",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10010.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10010.patch",
"merged_at": "2024-08-07T17:11:51"
} | # What does this PR do ?
Add the interface to pass the argument for gradient average reduction to MegatronCore
# Changelog
- Add `average_in_collective`
# Usage
- Set by `model.optim.average_in_collective` to enable
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10010/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10010/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10009 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10009/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10009/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10009/events | https://github.com/NVIDIA/NeMo/pull/10009 | 2,443,101,383 | PR_kwDOC_bI7s53J92P | 10,009 | Add support for LoRA on vLLM | {
"login": "apanteleev",
"id": 11079788,
"node_id": "MDQ6VXNlcjExMDc5Nzg4",
"avatar_url": "https://avatars.githubusercontent.com/u/11079788?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/apanteleev",
"html_url": "https://github.com/apanteleev",
"followers_url": "https://api.github.com/users/apanteleev/followers",
"following_url": "https://api.github.com/users/apanteleev/following{/other_user}",
"gists_url": "https://api.github.com/users/apanteleev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/apanteleev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/apanteleev/subscriptions",
"organizations_url": "https://api.github.com/users/apanteleev/orgs",
"repos_url": "https://api.github.com/users/apanteleev/repos",
"events_url": "https://api.github.com/users/apanteleev/events{/privacy}",
"received_events_url": "https://api.github.com/users/apanteleev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-08-01T18:20:31 | 2024-09-19T00:15:06 | 2024-08-30T10:02:36 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10009",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10009",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10009.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10009.patch",
"merged_at": "2024-08-30T10:02:36"
} | # What does this PR do ?
Adds support for using LoRA adapters on checkpoints exported to vLLM.
**Collection**: NLP
# Changelog
- Moved the LoRA conversion logic from the `convert_nemo_to_canonical.py` script to a reusable module
- Implemented on-load conversion of Nemo format LoRA checkpoints into HF format for vLLM
- Added support for enabling LoRAs on vLLM with automatic max rank detection
- Fixed the logger initialization in the vLLM deployment script
# Usage
```bash
python deploy_vllm_triton.py -nc /path/to/checkpoint.nemo -lc /path/to/lora.nemo -tmn TEST ...
python query.py -mn TEST -p "Prompt text" -lt 0
```
**PR Type**:
- [X] New Feature
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10009/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10009/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10008 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10008/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10008/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10008/events | https://github.com/NVIDIA/NeMo/pull/10008 | 2,443,032,152 | PR_kwDOC_bI7s53Jua3 | 10,008 | Bug fix for pooler causing dist checkpointing exception | {
"login": "shanmugamr1992",
"id": 111910568,
"node_id": "U_kgDOBqueqA",
"avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shanmugamr1992",
"html_url": "https://github.com/shanmugamr1992",
"followers_url": "https://api.github.com/users/shanmugamr1992/followers",
"following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}",
"gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions",
"organizations_url": "https://api.github.com/users/shanmugamr1992/orgs",
"repos_url": "https://api.github.com/users/shanmugamr1992/repos",
"events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}",
"received_events_url": "https://api.github.com/users/shanmugamr1992/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-01T17:48:41 | 2024-08-01T23:53:01 | 2024-08-01T23:52:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10008",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10008",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10008.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10008.patch",
"merged_at": "2024-08-01T23:52:59"
} | # What does this PR do ?
Move pooler into the flag of post processing so that it doesn't get built on all the pp ranks.
Add a one line overview of what this PR aims to accomplish.
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "shanmugamr1992",
"id": 111910568,
"node_id": "U_kgDOBqueqA",
"avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shanmugamr1992",
"html_url": "https://github.com/shanmugamr1992",
"followers_url": "https://api.github.com/users/shanmugamr1992/followers",
"following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}",
"gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions",
"organizations_url": "https://api.github.com/users/shanmugamr1992/orgs",
"repos_url": "https://api.github.com/users/shanmugamr1992/repos",
"events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}",
"received_events_url": "https://api.github.com/users/shanmugamr1992/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10008/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10008/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10007 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10007/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10007/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10007/events | https://github.com/NVIDIA/NeMo/issues/10007 | 2,442,828,877 | I_kwDOC_bI7s6RmpxN | 10,007 | Interaction between sampler len and trainer on restarts. | {
"login": "jstjohn",
"id": 459014,
"node_id": "MDQ6VXNlcjQ1OTAxNA==",
"avatar_url": "https://avatars.githubusercontent.com/u/459014?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jstjohn",
"html_url": "https://github.com/jstjohn",
"followers_url": "https://api.github.com/users/jstjohn/followers",
"following_url": "https://api.github.com/users/jstjohn/following{/other_user}",
"gists_url": "https://api.github.com/users/jstjohn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jstjohn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jstjohn/subscriptions",
"organizations_url": "https://api.github.com/users/jstjohn/orgs",
"repos_url": "https://api.github.com/users/jstjohn/repos",
"events_url": "https://api.github.com/users/jstjohn/events{/privacy}",
"received_events_url": "https://api.github.com/users/jstjohn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"This has been resolved, can be closed."
] | 2024-08-01T16:00:54 | 2024-08-23T23:01:35 | 2024-08-23T23:01:35 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | https://github.com/NVIDIA/NeMo/blob/adcc72bfbb0344a9c2cbcd1ece9897b1c846f6dd/nemo/lightning/data.py#L192-L203
When you restart a job, you typically set consumed_samples to a non-zero value. This has the side effect of changing the length returned of the sampler. If the trainer current step is restored to some value N < total, and the trainer uses `len(loader)` to re-compute remaining steps, then when you restart a job the current step is properly restored, but the length of your progress bar (total) shrinks by N so it's then `total - N`. Can you verify that on restart this does not happen? Ideally adding a stop/go test where a trainer job is artificially stopped at some step less than total and resumed, then the total number of steps and all relevant parameters are checked to ensure that resumption worked properly.
This was definitely an issue for us in BioNeMo1 that we "fixed" by changing the length calculation to not be dependent on `consumed_samples`, since it seemed that at the time at least the lightning Trainer used `len(dataloader)` at init time (even when restarting) to determine the length of the progress bar. | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10007/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10007/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/10006 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10006/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10006/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10006/events | https://github.com/NVIDIA/NeMo/issues/10006 | 2,442,784,925 | I_kwDOC_bI7s6RmfCd | 10,006 | Model name query | {
"login": "dnhkng",
"id": 2691732,
"node_id": "MDQ6VXNlcjI2OTE3MzI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2691732?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dnhkng",
"html_url": "https://github.com/dnhkng",
"followers_url": "https://api.github.com/users/dnhkng/followers",
"following_url": "https://api.github.com/users/dnhkng/following{/other_user}",
"gists_url": "https://api.github.com/users/dnhkng/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dnhkng/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dnhkng/subscriptions",
"organizations_url": "https://api.github.com/users/dnhkng/orgs",
"repos_url": "https://api.github.com/users/dnhkng/repos",
"events_url": "https://api.github.com/users/dnhkng/events{/privacy}",
"received_events_url": "https://api.github.com/users/dnhkng/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Hi, thank you for your question and investigating the root cause.\r\nThere is a typo in the model card (cc @nithinraok) but this will work:\r\n`asr_model = nemo_asr.models.EncDecCTCModelBPE.from_pretrained(model_name=\"nvidia/parakeet-ctc-0.6b\")`\r\nor even this:\r\n`asr_model = nemo_asr.models.ASRModel.from_pretrained(model_name=\"nvidia/parakeet-ctc-0.6b\")`\r\n\r\nYes, there is no parakeet model listed that can be loaded from NGC, but if there is a \"/\" in the model name, we will look for that model on Hugging Face (relevant source code in [here](https://github.com/NVIDIA/NeMo/blob/b88b662c8753e51629fce3245b8ad1a4d126e03f/nemo/core/classes/common.py#L746)).\r\n\r\nApologies for the confusion. We should update the docs with this information, probably [here](https://docs.nvidia.com/nemo-framework/user-guide/latest/nemotoolkit/core/core.html#pretrained). \r\n",
"sorry for the typo, fixed it on the ModelCard"
] | 2024-08-01T15:38:50 | 2024-08-22T21:03:13 | 2024-08-22T21:03:13 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I want to install the https://huggingface.co/nvidia/parakeet-ctc-0.6b model.
I installed nemo with:
`pip install nemo_toolkit['asr']`
According to the Huggingface repo, I use this following command to load the model:
```
import nemo.collections.asr as nemo_asr
asr_model = nemo_asr.models.EncDecCTCBPEModel.from_pretrained(model_name="nvidia/parakeet-ctc-0.6b")
```
However, I see this:
```
>nemo_asr.__version__
'1.23.0'
>dir(nemo_asr.models)
['ASRModel',
'AudioToAudioModel',
'ClusteringDiarizer',
'EncDecCTCModel',
'EncDecCTCModelBPE',
'EncDecClassificationModel',
'EncDecDiarLabelModel',
'EncDecFrameClassificationModel',
'EncDecHybridRNNTCTCBPEModel',
'EncDecHybridRNNTCTCModel',
'EncDecK2RnntSeqModel',
'EncDecK2RnntSeqModelBPE',
'EncDecK2SeqModel',
'EncDecK2SeqModelBPE',
'EncDecMultiTaskModel',
'EncDecRNNTBPEModel',
'EncDecRNNTModel',
'EncDecSpeakerLabelModel',
'EncDecTransfModelBPE',
'EncMaskDecAudioToAudioModel',
'NeuralDiarizer',
'SLUIntentSlotBPEModel',
'SpeechEncDecSelfSupervisedModel',
'__builtins__',
...
```
i.e. "EncDecCTCBPEModel" is not in the list!
I assumed there was a renaming, from EncDecCTCBPEModel -> EncDecCTCModelBPE?
Looking in EncDecCTCModelBPE, I see:
```
>nemo_asr.models.EncDecCTCModelBPE.list_available_models()
[PretrainedModelInfo(
pretrained_model_name=stt_en_citrinet_256,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_citrinet_256,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_citrinet_256/versions/1.0.0rc1/files/stt_en_citrinet_256.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_citrinet_512,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_citrinet_512,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_citrinet_512/versions/1.0.0rc1/files/stt_en_citrinet_512.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_citrinet_1024,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_citrinet_1024,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_citrinet_1024/versions/1.0.0rc1/files/stt_en_citrinet_1024.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_citrinet_256_gamma_0_25,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_citrinet_256_gamma_0_25,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_citrinet_256_gamma_0_25/versions/1.0.0/files/stt_en_citrinet_256_gamma_0_25.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_citrinet_512_gamma_0_25,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_citrinet_512_gamma_0_25,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_citrinet_512_gamma_0_25/versions/1.0.0/files/stt_en_citrinet_512_gamma_0_25.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_citrinet_1024_gamma_0_25,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_citrinet_1024_gamma_0_25,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_citrinet_1024_gamma_0_25/versions/1.0.0/files/stt_en_citrinet_1024_gamma_0_25.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_es_citrinet_512,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_es_citrinet_512,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_es_citrinet_512/versions/1.0.0/files/stt_es_citrinet_512.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_de_citrinet_1024,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_de_citrinet_1024,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_de_citrinet_1024/versions/1.5.0/files/stt_de_citrinet_1024.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_fr_citrinet_1024_gamma_0_25,
description=For details about this model, please visit https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_fr_citrinet_1024_gamma_0_25,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_fr_citrinet_1024_gamma_0_25/versions/1.5/files/stt_fr_citrinet_1024_gamma_0_25.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_fr_no_hyphen_citrinet_1024_gamma_0_25,
description=For details about this model, please visit https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_fr_citrinet_1024_gamma_0_25,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_fr_citrinet_1024_gamma_0_25/versions/1.5/files/stt_fr_no_hyphen_citrinet_1024_gamma_0_25.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_es_citrinet_1024_gamma_0_25,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_es_citrinet_1024_gamma_0_25,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_es_citrinet_1024_gamma_0_25/versions/1.8.0/files/stt_es_citrinet_1024_gamma_0_25.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_conformer_ctc_small,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_conformer_ctc_small,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_conformer_ctc_small/versions/1.6.0/files/stt_en_conformer_ctc_small.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_conformer_ctc_medium,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_conformer_ctc_medium,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_conformer_ctc_medium/versions/1.6.0/files/stt_en_conformer_ctc_medium.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_conformer_ctc_large,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_conformer_ctc_large,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_conformer_ctc_large/versions/1.10.0/files/stt_en_conformer_ctc_large.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_conformer_ctc_xlarge,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_conformer_ctc_xlarge,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_conformer_ctc_xlarge/versions/1.10.0/files/stt_en_conformer_ctc_xlarge.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_squeezeformer_ctc_xsmall_ls,
description=For details about this model, please visit https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_en_squeezeformer_ctc_xsmall_ls,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_squeezeformer_ctc_xsmall_ls/versions/1.13.0/files/stt_en_squeezeformer_ctc_xsmall_ls.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_squeezeformer_ctc_small_ls,
description=For details about this model, please visit https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_en_squeezeformer_ctc_small_ls,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_squeezeformer_ctc_small_ls/versions/1.13.0/files/stt_en_squeezeformer_ctc_small_ls.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_squeezeformer_ctc_small_medium_ls,
description=For details about this model, please visit https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_en_squeezeformer_ctc_small_medium_ls,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_squeezeformer_ctc_small_medium_ls/versions/1.13.0/files/stt_en_squeezeformer_ctc_small_medium_ls.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_squeezeformer_ctc_medium_ls,
description=For details about this model, please visit https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_en_squeezeformer_ctc_medium_ls,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_squeezeformer_ctc_medium_ls/versions/1.13.0/files/stt_en_squeezeformer_ctc_medium_ls.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_squeezeformer_ctc_medium_large_ls,
description=For details about this model, please visit https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_en_squeezeformer_ctc_medium_large_ls,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_squeezeformer_ctc_medium_large_ls/versions/1.13.0/files/stt_en_squeezeformer_ctc_medium_large_ls.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_squeezeformer_ctc_large_ls,
description=For details about this model, please visit https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_en_squeezeformer_ctc_large_ls,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_squeezeformer_ctc_large_ls/versions/1.13.0/files/stt_en_squeezeformer_ctc_large_ls.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_conformer_ctc_small_ls,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_conformer_ctc_small_ls,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_conformer_ctc_small_ls/versions/1.0.0/files/stt_en_conformer_ctc_small_ls.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_conformer_ctc_medium_ls,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_conformer_ctc_medium_ls,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_conformer_ctc_medium_ls/versions/1.0.0/files/stt_en_conformer_ctc_medium_ls.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_conformer_ctc_large_ls,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_conformer_ctc_large_ls,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_conformer_ctc_large_ls/versions/1.0.0/files/stt_en_conformer_ctc_large_ls.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_fr_conformer_ctc_large,
description=For details about this model, please visit https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_fr_conformer_ctc_large,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_fr_conformer_ctc_large/versions/1.5.1/files/stt_fr_conformer_ctc_large.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_fr_no_hyphen_conformer_ctc_large,
description=For details about this model, please visit https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_fr_conformer_ctc_large,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_fr_conformer_ctc_large/versions/1.5.1/files/stt_fr_no_hyphen_conformer_ctc_large.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_de_conformer_ctc_large,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_de_conformer_ctc_large,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_de_conformer_ctc_large/versions/1.5.0/files/stt_de_conformer_ctc_large.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_es_conformer_ctc_large,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_es_conformer_ctc_large,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_es_conformer_ctc_large/versions/1.8.0/files/stt_es_conformer_ctc_large.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_hi_conformer_ctc_medium,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_hi_conformer_ctc_medium,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_hi_conformer_ctc_medium/versions/1.6.0/files/stt_hi_conformer_ctc_medium.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_mr_conformer_ctc_medium,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_mr_conformer_ctc_medium,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_mr_conformer_ctc_medium/versions/1.6.0/files/stt_mr_conformer_ctc_medium.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_enes_conformer_ctc_large,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_enes_conformer_ctc_large,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_enes_conformer_ctc_large/versions/1.0.0/files/stt_enes_conformer_ctc_large.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_ca_conformer_ctc_large,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_ca_conformer_ctc_large,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_ca_conformer_ctc_large/versions/1.11.0/files/stt_ca_conformer_ctc_large.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_rw_conformer_ctc_large,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_rw_conformer_ctc_large,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_rw_conformer_ctc_large/versions/1.11.0/files/stt_rw_conformer_ctc_large.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_enes_conformer_ctc_large_codesw,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_enes_conformer_ctc_large_codesw,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_enes_conformer_ctc_large_codesw/versions/1.0.0/files/stt_enes_conformer_ctc_large_codesw.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_be_conformer_ctc_large,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_be_conformer_ctc_large,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_be_conformer_ctc_large/versions/1.12.0/files/stt_be_conformer_ctc_large.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_hr_conformer_ctc_large,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_hr_conformer_ctc_large,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_hr_conformer_ctc_large/versions/1.11.0/files/stt_hr_conformer_ctc_large.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_it_conformer_ctc_large,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_it_conformer_ctc_large,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_it_conformer_ctc_large/versions/1.13.0/files/stt_it_conformer_ctc_large.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_ru_conformer_ctc_large,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_ru_conformer_ctc_large,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_ru_conformer_ctc_large/versions/1.13.0/files/stt_ru_conformer_ctc_large.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_eo_conformer_ctc_large,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_eo_conformer_ctc_large,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_eo_conformer_ctc_large/versions/1.14.0/files/stt_eo_conformer_ctc_large.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_fastconformer_ctc_large,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_fastconformer_ctc_large,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_fastconformer_ctc_large/versions/1.0.0/files/stt_en_fastconformer_ctc_large.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_fastconformer_ctc_large_ls,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_fastconformer_ctc_large_ls,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_fastconformer_ctc_large_ls/versions/1.0.0/files/stt_en_fastconformer_ctc_large_ls.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_fastconformer_ctc_xlarge,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_fastconformer_ctc_xlarge,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_fastconformer_ctc_xlarge/versions/1.20.0/files/stt_en_fastconformer_ctc_xlarge.nemo
),
PretrainedModelInfo(
pretrained_model_name=stt_en_fastconformer_ctc_xxlarge,
description=For details about this model, please visit https://ngc.nvidia.com/catalog/models/nvidia:nemo:stt_en_fastconformer_ctc_xxlarge,
location=https://api.ngc.nvidia.com/v2/models/nvidia/nemo/stt_en_fastconformer_ctc_xxlarge/versions/1.20.1/files/stt_en_fastconformer_ctc_xxlarge.nemo
)]
```
There is no parakeet model listed here!
```[tasklist]
### Tasks
```
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10006/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10006/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/10004 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10004/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10004/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10004/events | https://github.com/NVIDIA/NeMo/pull/10004 | 2,442,757,362 | PR_kwDOC_bI7s53Ix0v | 10,004 | Re-tarring script | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@zhehuaichen Glad you asked, as it turns out I forgot to push a commit that does it (see https://github.com/NVIDIA/NeMo/pull/10004/commits/8017db4a1d9d5a3db8a9c63a7aaff77061e0a261). \r\n\r\nNow it's all good and ready to merge. "
] | 2024-08-01T15:25:38 | 2024-08-03T13:38:03 | 2024-08-03T13:38:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10004",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10004",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10004.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10004.patch",
"merged_at": "2024-08-03T13:38:02"
} | # What does this PR do ?
Utility to help people re-build tarred datasets when they want only a small subset of them, based on a filtered manifest.
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10004/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10004/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10003 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10003/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10003/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10003/events | https://github.com/NVIDIA/NeMo/issues/10003 | 2,442,675,054 | I_kwDOC_bI7s6RmENu | 10,003 | ERROR: Docker build | {
"login": "popiemon",
"id": 85440427,
"node_id": "MDQ6VXNlcjg1NDQwNDI3",
"avatar_url": "https://avatars.githubusercontent.com/u/85440427?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/popiemon",
"html_url": "https://github.com/popiemon",
"followers_url": "https://api.github.com/users/popiemon/followers",
"following_url": "https://api.github.com/users/popiemon/following{/other_user}",
"gists_url": "https://api.github.com/users/popiemon/gists{/gist_id}",
"starred_url": "https://api.github.com/users/popiemon/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/popiemon/subscriptions",
"organizations_url": "https://api.github.com/users/popiemon/orgs",
"repos_url": "https://api.github.com/users/popiemon/repos",
"events_url": "https://api.github.com/users/popiemon/events{/privacy}",
"received_events_url": "https://api.github.com/users/popiemon/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-08-01T14:48:54 | 2024-09-09T01:56:55 | 2024-09-09T01:56:54 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
The Docker build command in the README does not build.
**Steps/Code to reproduce bug**
```sh
DOCKER_BUILDKIT=1 docker build -f Dockerfile -t nemo:latest
```
**Expected behavior**
You will get the following error message
```sh
ERROR: "docker buildx build" requires exactly 1 argument.
See 'docker buildx build --help'.
Usage: docker buildx build [OPTIONS] PATH | URL | -
Start a build
````
**Environment overview (please complete the following information)**
- Ubuntu 22.04
- Docker version 27.1.1
**Additional context**
The following command would have built.
```sh
DOCKER_BUILDKIT=1 docker build -f Dockerfile.ci -t nemo:latest .
```
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10003/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10003/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/10002 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10002/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10002/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10002/events | https://github.com/NVIDIA/NeMo/pull/10002 | 2,442,556,716 | PR_kwDOC_bI7s53IFvo | 10,002 | Add deploy and REST API support to NeMo 2.0 | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-01T13:58:48 | 2024-08-17T00:49:08 | 2024-08-17T00:49:06 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10002",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10002",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10002.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10002.patch",
"merged_at": "2024-08-17T00:49:06"
} | # What does this PR do ?
1. Adds `deploy` method from NeMo 1.0 as a `task` to NeMo 2.0
2. This PR aims at minimum viable product to deploy and expose REST API with NeMo 2.0 and hence only adds `TRTLLM` backend route of deploy module to NeMo 2.0. Also, it only supports the basic arguments for the export method. More optimizations like `paged_kv_cache`, `parallel_embedding`, `lora_plugin`, `multi_block_mode` etc., and other backends (like `in-framework`) will be supported in a subsequent PR.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10002/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10002/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10001 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10001/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10001/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10001/events | https://github.com/NVIDIA/NeMo/pull/10001 | 2,442,540,677 | PR_kwDOC_bI7s53ICIR | 10,001 | add feature to drop checkpoint layers | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-01T13:53:13 | 2024-09-02T15:48:55 | 2024-09-02T15:48:55 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10001",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10001",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10001.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10001.patch",
"merged_at": null
} | # What does this PR do ?
1. Adds a feature similar to mcore's --skip-train flag.
3. Adds drop-layers feature support.
4. Adds script which loads the ckpt, trims needed layers, and saves trimmed checkpoint.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* Trim the model. Please, note that layer indices start from 1. Llama3 8b model example:
```ubuntu
python -m torch.distributed.launch --nproc_per_node=8 \
NeMo/examples/nlp/language_modeling/megatron_gpt_drop_layers.py \
--path_to_nemo /path/to/model.nemo \
--path_to_save /path/to/save/trimmed_model.nemo \
--tensor_model_parallel_size 8 \
--pipeline_model_parallel_size 1 \
--gpus_per_node 8 \
--drop_layers 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31
```
If you want to save trimmed model in zarr ckpt format (deprecated), add this flag to the command:
```ubuntu
--zarr
```
* Validate the model:
```ubuntu
python NeMo/examples/nlp/language_modeling/megatron_gpt_pretraining.py \
--config-path=/path/to/folder/with/model/config \
--config-name=llama3_8b.yaml \
trainer.limit_val_batches=number_of_batches_in_validation_step \
model.restore_from_path=/path/to/trimmed_model.nemo \
model.skip_train=True \
model.data.data_impl=mock \
model.data.data_prefix=[]
```
To use specific dataset instead of mock dataset:
```ubuntu
model.data.data_impl=mmap \
model.data.data_prefix=["path/to/datafile1", "path/to/datafile2"]
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10001/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10001/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/10000 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/10000/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/10000/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/10000/events | https://github.com/NVIDIA/NeMo/pull/10000 | 2,441,177,518 | PR_kwDOC_bI7s53DUjj | 10,000 | Add blend dataset in NeVA | {
"login": "xuanzic",
"id": 140748220,
"node_id": "U_kgDOCGOlvA",
"avatar_url": "https://avatars.githubusercontent.com/u/140748220?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/xuanzic",
"html_url": "https://github.com/xuanzic",
"followers_url": "https://api.github.com/users/xuanzic/followers",
"following_url": "https://api.github.com/users/xuanzic/following{/other_user}",
"gists_url": "https://api.github.com/users/xuanzic/gists{/gist_id}",
"starred_url": "https://api.github.com/users/xuanzic/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xuanzic/subscriptions",
"organizations_url": "https://api.github.com/users/xuanzic/orgs",
"repos_url": "https://api.github.com/users/xuanzic/repos",
"events_url": "https://api.github.com/users/xuanzic/events{/privacy}",
"received_events_url": "https://api.github.com/users/xuanzic/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@yaoyu-33 could we merge this [fix on sig/clip](https://github.com/NVIDIA/NeMo/pull/9842) pr to main? so that I could rebase and remove the similar fix in this PR. Thanks!"
] | 2024-08-01T00:27:34 | 2024-08-20T19:49:47 | 2024-08-20T19:49:47 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/10000",
"html_url": "https://github.com/NVIDIA/NeMo/pull/10000",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/10000.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/10000.patch",
"merged_at": "2024-08-20T19:49:47"
} | # What does this PR do ?
Add blend dataset in NeVA for both unpacked and packed sequence.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/10000/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/10000/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9999 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9999/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9999/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9999/events | https://github.com/NVIDIA/NeMo/pull/9999 | 2,441,172,254 | PR_kwDOC_bI7s53DTat | 9,999 | Bump `Dockerfile.ci` (2024-08-01) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-08-01T00:22:02 | 2024-08-02T23:38:50 | 2024-08-02T23:38:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9999",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9999",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9999.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9999.patch",
"merged_at": null
} | 🚀 PR to Bump `Dockerfile.ci`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9999/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9999/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9998 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9998/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9998/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9998/events | https://github.com/NVIDIA/NeMo/pull/9998 | 2,441,124,586 | PR_kwDOC_bI7s53DJPb | 9,998 | [Multimodal] Support data blending in NeVA | {
"login": "xuanzic",
"id": 140748220,
"node_id": "U_kgDOCGOlvA",
"avatar_url": "https://avatars.githubusercontent.com/u/140748220?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/xuanzic",
"html_url": "https://github.com/xuanzic",
"followers_url": "https://api.github.com/users/xuanzic/followers",
"following_url": "https://api.github.com/users/xuanzic/following{/other_user}",
"gists_url": "https://api.github.com/users/xuanzic/gists{/gist_id}",
"starred_url": "https://api.github.com/users/xuanzic/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xuanzic/subscriptions",
"organizations_url": "https://api.github.com/users/xuanzic/orgs",
"repos_url": "https://api.github.com/users/xuanzic/repos",
"events_url": "https://api.github.com/users/xuanzic/events{/privacy}",
"received_events_url": "https://api.github.com/users/xuanzic/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-31T23:26:53 | 2024-08-01T00:14:06 | 2024-08-01T00:14:06 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9998",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9998",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9998.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9998.patch",
"merged_at": null
} | # What does this PR do ?
added support for data blending in NeVA.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "xuanzic",
"id": 140748220,
"node_id": "U_kgDOCGOlvA",
"avatar_url": "https://avatars.githubusercontent.com/u/140748220?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/xuanzic",
"html_url": "https://github.com/xuanzic",
"followers_url": "https://api.github.com/users/xuanzic/followers",
"following_url": "https://api.github.com/users/xuanzic/following{/other_user}",
"gists_url": "https://api.github.com/users/xuanzic/gists{/gist_id}",
"starred_url": "https://api.github.com/users/xuanzic/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xuanzic/subscriptions",
"organizations_url": "https://api.github.com/users/xuanzic/orgs",
"repos_url": "https://api.github.com/users/xuanzic/repos",
"events_url": "https://api.github.com/users/xuanzic/events{/privacy}",
"received_events_url": "https://api.github.com/users/xuanzic/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9998/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9998/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9997 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9997/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9997/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9997/events | https://github.com/NVIDIA/NeMo/pull/9997 | 2,441,117,075 | PR_kwDOC_bI7s53DHnl | 9,997 | [NeMo-UX] proposal for updated 2.0 progress logger | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-31T23:17:03 | 2024-08-16T18:01:04 | 2024-08-16T18:01:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9997",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9997",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9997.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9997.patch",
"merged_at": "2024-08-16T18:01:03"
} | # What does this PR do ?
This introduces a new `MegatronProgressPrinter` class which simply prints the metrics to stdout in a similar style to Megatron. This implementation is more robust as the TQDM progress bar is not well-suited for non-interactive settings.
The train step logging looks like this:
```
Epoch 0, iteration 1/100: | global_step: 0 | reduced_train_loss: 10.93 | train_step_timing in s: 1.352
Epoch 0, iteration 2/100: | global_step: 1 | reduced_train_loss: 9.409 | train_step_timing in s: 1.016
Epoch 0, iteration 3/100: | global_step: 2 | reduced_train_loss: 9.619 | train_step_timing in s: 1.018
Epoch 0, iteration 4/100: | global_step: 3 | reduced_train_loss: 8.796 | train_step_timing in s: 1.014
```
And the validation step logging looks like this:
```
Validation: batch 1 / 32
Validation: batch 2 / 32
Validation: batch 3 / 32
Validation: batch 4 / 32
```
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9997/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9997/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9996 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9996/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9996/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9996/events | https://github.com/NVIDIA/NeMo/pull/9996 | 2,441,043,475 | PR_kwDOC_bI7s53C68q | 9,996 | Build pooler only in the last pp rank | {
"login": "shanmugamr1992",
"id": 111910568,
"node_id": "U_kgDOBqueqA",
"avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shanmugamr1992",
"html_url": "https://github.com/shanmugamr1992",
"followers_url": "https://api.github.com/users/shanmugamr1992/followers",
"following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}",
"gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions",
"organizations_url": "https://api.github.com/users/shanmugamr1992/orgs",
"repos_url": "https://api.github.com/users/shanmugamr1992/repos",
"events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}",
"received_events_url": "https://api.github.com/users/shanmugamr1992/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-31T22:22:43 | 2024-08-01T17:52:48 | 2024-08-01T17:49:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9996",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9996",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9996.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9996.patch",
"merged_at": null
} | # What does this PR do ?
Build pooler only in the last pp rank (Dist checkpoint will fail if you build in more than one rank)
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "shanmugamr1992",
"id": 111910568,
"node_id": "U_kgDOBqueqA",
"avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shanmugamr1992",
"html_url": "https://github.com/shanmugamr1992",
"followers_url": "https://api.github.com/users/shanmugamr1992/followers",
"following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}",
"gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions",
"organizations_url": "https://api.github.com/users/shanmugamr1992/orgs",
"repos_url": "https://api.github.com/users/shanmugamr1992/repos",
"events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}",
"received_events_url": "https://api.github.com/users/shanmugamr1992/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9996/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9996/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9995 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9995/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9995/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9995/events | https://github.com/NVIDIA/NeMo/pull/9995 | 2,441,033,633 | PR_kwDOC_bI7s53C41M | 9,995 | Fix sdxl inference and add compatible changes for launcher support | {
"login": "Victor49152",
"id": 111467530,
"node_id": "U_kgDOBqTcCg",
"avatar_url": "https://avatars.githubusercontent.com/u/111467530?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Victor49152",
"html_url": "https://github.com/Victor49152",
"followers_url": "https://api.github.com/users/Victor49152/followers",
"following_url": "https://api.github.com/users/Victor49152/following{/other_user}",
"gists_url": "https://api.github.com/users/Victor49152/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Victor49152/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Victor49152/subscriptions",
"organizations_url": "https://api.github.com/users/Victor49152/orgs",
"repos_url": "https://api.github.com/users/Victor49152/repos",
"events_url": "https://api.github.com/users/Victor49152/events{/privacy}",
"received_events_url": "https://api.github.com/users/Victor49152/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "Victor49152",
"id": 111467530,
"node_id": "U_kgDOBqTcCg",
"avatar_url": "https://avatars.githubusercontent.com/u/111467530?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Victor49152",
"html_url": "https://github.com/Victor49152",
"followers_url": "https://api.github.com/users/Victor49152/followers",
"following_url": "https://api.github.com/users/Victor49152/following{/other_user}",
"gists_url": "https://api.github.com/users/Victor49152/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Victor49152/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Victor49152/subscriptions",
"organizations_url": "https://api.github.com/users/Victor49152/orgs",
"repos_url": "https://api.github.com/users/Victor49152/repos",
"events_url": "https://api.github.com/users/Victor49152/events{/privacy}",
"received_events_url": "https://api.github.com/users/Victor49152/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "Victor49152",
"id": 111467530,
"node_id": "U_kgDOBqTcCg",
"avatar_url": "https://avatars.githubusercontent.com/u/111467530?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Victor49152",
"html_url": "https://github.com/Victor49152",
"followers_url": "https://api.github.com/users/Victor49152/followers",
"following_url": "https://api.github.com/users/Victor49152/following{/other_user}",
"gists_url": "https://api.github.com/users/Victor49152/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Victor49152/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Victor49152/subscriptions",
"organizations_url": "https://api.github.com/users/Victor49152/orgs",
"repos_url": "https://api.github.com/users/Victor49152/repos",
"events_url": "https://api.github.com/users/Victor49152/events{/privacy}",
"received_events_url": "https://api.github.com/users/Victor49152/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"@yaoyu-33 Could you please review"
] | 2024-07-31T22:13:11 | 2024-08-01T21:15:38 | 2024-08-01T21:15:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9995",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9995",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9995.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9995.patch",
"merged_at": "2024-08-01T21:15:36"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9995/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9995/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9994 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9994/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9994/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9994/events | https://github.com/NVIDIA/NeMo/pull/9994 | 2,440,990,030 | PR_kwDOC_bI7s53CvNb | 9,994 | nemo-ux: Use kv_channels to enable cases where head_dim != hidden_size // head… | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-31T21:34:55 | 2024-08-07T13:32:42 | 2024-08-07T13:32:40 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9994",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9994",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9994.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9994.patch",
"merged_at": "2024-08-07T13:32:40"
} | Use kv_channels to enable cases where head_dim != hidden_size // head_num
for example as is the case with the 2407 modes: https://huggingface.co/mistralai/Mistral-Large-Instruct-2407
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9994/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9994/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9993 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9993/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9993/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9993/events | https://github.com/NVIDIA/NeMo/pull/9993 | 2,440,826,003 | PR_kwDOC_bI7s53CM7P | 9,993 | NeMo's Mixtral-8x3B config | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-31T19:48:06 | 2024-08-16T22:08:33 | 2024-08-16T22:08:31 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9993",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9993",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9993.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9993.patch",
"merged_at": "2024-08-16T22:08:31"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9993/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9993/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9988 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9988/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9988/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9988/events | https://github.com/NVIDIA/NeMo/pull/9988 | 2,440,541,353 | PR_kwDOC_bI7s53BXz- | 9,988 | Fix lita tutorial | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [] | 2024-07-31T17:25:26 | 2024-08-07T16:18:52 | 2024-08-07T16:18:52 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9988",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9988",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9988.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9988.patch",
"merged_at": null
} | # What does this PR do ?
To add fix for r2.0.0rc1.
ORG PR: https://github.com/NVIDIA/NeMo/pull/9973
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9988/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9988/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9987 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9987/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9987/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9987/events | https://github.com/NVIDIA/NeMo/pull/9987 | 2,440,538,197 | PR_kwDOC_bI7s53BXHs | 9,987 | Fix Canary not stripping prompt from reference + more test coverage | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"> One name change, fix import flags from the CI.\r\n\r\nOK\r\n\r\n> Btw, how are you feeding temperature to the MLP now?\r\n\r\nIt's applied directly in `Categorical` "
] | 2024-07-31T17:23:15 | 2024-08-01T02:03:21 | 2024-08-01T02:03:19 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9987",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9987",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9987.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9987.patch",
"merged_at": "2024-08-01T02:03:19"
} | # What does this PR do ?
TL;DR: fix for a bug I accidentally introduced in #9901
Context:
* #9901 changed multi-task beam search decoding module to strip the prompt and EOS away form recognitions; it removed "remove_special_tokens" sprinkled in various places in our codebase (transcribe, wer, bleu, etc.)
* That fix was actually porting a part of my changes in an old closed PR #8833. However, I forgot that we also have to handle the dataset part properly - return GT transcripts with stripped prompts and EOS (which was done there). So I ended up introduced a bug that reference has the prompt, but recognition doesn't in scoring.
* I ported the necessary additional changes from #8833 and adapted them to the current codebase.
* Since I wanted to improve the test coverage of the affected parts, I also pulled the changes from #8885 (another PR I forgot to merge) where I already wrote these tests, and extended them.
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9987/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9987/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9986 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9986/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9986/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9986/events | https://github.com/NVIDIA/NeMo/pull/9986 | 2,440,460,827 | PR_kwDOC_bI7s53BGPr | 9,986 | copy of #9576 | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"CI passed https://github.com/NVIDIA/NeMo/actions/runs/10184138965"
] | 2024-07-31T16:35:10 | 2024-07-31T19:48:11 | 2024-07-31T19:48:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9986",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9986",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9986.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9986.patch",
"merged_at": "2024-07-31T19:48:09"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9986/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9986/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9985 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9985/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9985/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9985/events | https://github.com/NVIDIA/NeMo/pull/9985 | 2,440,385,959 | PR_kwDOC_bI7s53A2C_ | 9,985 | [NeMo-UX] Update default PTL logging `save_dir` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-31T15:53:26 | 2024-08-06T22:08:46 | 2024-08-06T22:08:44 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9985",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9985",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9985.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9985.patch",
"merged_at": "2024-08-06T22:08:44"
} | # What does this PR do ?
If a user passes a `save_dir` to a PTL logger, by default we write the logs to `<log_dir> / save_dir`, where `<log_dir>` is determined by NeMoLogger. Previously, `save_dir` was ignored, and the logs would be written to `<log_dir>`.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9985/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9985/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9984 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9984/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9984/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9984/events | https://github.com/NVIDIA/NeMo/pull/9984 | 2,440,384,761 | PR_kwDOC_bI7s53A1yK | 9,984 | [NeMo-UX] Wrap task config save in a try/except | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-31T15:52:49 | 2024-08-06T22:09:36 | 2024-08-06T22:09:34 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9984",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9984",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9984.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9984.patch",
"merged_at": "2024-08-06T22:09:34"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9984/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9984/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9983 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9983/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9983/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9983/events | https://github.com/NVIDIA/NeMo/pull/9983 | 2,440,347,454 | PR_kwDOC_bI7s53AtoZ | 9,983 | Beam search algorithm implementation for TDT models | {
"login": "lilithgrigoryan",
"id": 38436437,
"node_id": "MDQ6VXNlcjM4NDM2NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/38436437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lilithgrigoryan",
"html_url": "https://github.com/lilithgrigoryan",
"followers_url": "https://api.github.com/users/lilithgrigoryan/followers",
"following_url": "https://api.github.com/users/lilithgrigoryan/following{/other_user}",
"gists_url": "https://api.github.com/users/lilithgrigoryan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lilithgrigoryan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lilithgrigoryan/subscriptions",
"organizations_url": "https://api.github.com/users/lilithgrigoryan/orgs",
"repos_url": "https://api.github.com/users/lilithgrigoryan/repos",
"events_url": "https://api.github.com/users/lilithgrigoryan/events{/privacy}",
"received_events_url": "https://api.github.com/users/lilithgrigoryan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-31T15:33:43 | 2024-09-14T01:54:56 | 2024-09-14T01:54:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9983",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9983",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9983.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9983.patch",
"merged_at": null
} | # What does this PR do ?
PR introduces default beam search and mAES (with Ngram LM fusion) decoding implementations for TDT models.
**Collection**: ASR
# Changelog
- [nemo/collections/asr/parts/submodules/tdt_beam_decoding.py]: Default Beam Search and mAES implementations for TDT.
# Usage
```python
python examples/asr/speech_to_text_eval.py \
model_path="$NEMO_MODEL_PATH" \
dataset_manifest="$DATASET_MANIFEST_PATH" \
rnnt_decoding.strategy=maes \
rnnt_decoding.beam.beam_size=8 \
rnnt_decoding.beam.ngram_lm_model="$KENLM_NGRAM_MODEL_PATH" \
rnnt_decoding.beam.ngram_lm_blank_alpha=5.0 \
rnnt_decoding.beam.durations_beam_size=2
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9983/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9983/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9982 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9982/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9982/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9982/events | https://github.com/NVIDIA/NeMo/pull/9982 | 2,440,249,525 | PR_kwDOC_bI7s53AYhH | 9,982 | Use directly trtllm-build command for quantized checkpoints | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-31T14:47:57 | 2024-08-07T09:43:48 | 2024-08-07T09:43:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9982",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9982",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9982.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9982.patch",
"merged_at": "2024-08-07T09:43:47"
} | # What does this PR do ?
Summary of changes:
* using directly `trtllm-build` for quantized checkpoints
* removing dependency on `nvidia-modelopt` for this
* updating export code to TensorRT-LLM v0.11.0
* bumping ModelOpt 0.15.0
* several other minor updates
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9982/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9982/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9981 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9981/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9981/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9981/events | https://github.com/NVIDIA/NeMo/issues/9981 | 2,440,179,194 | I_kwDOC_bI7s6Rci36 | 9,981 | Llama3-8b FP8 PTQ OOM | {
"login": "JeevanBhoot",
"id": 64039772,
"node_id": "MDQ6VXNlcjY0MDM5Nzcy",
"avatar_url": "https://avatars.githubusercontent.com/u/64039772?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JeevanBhoot",
"html_url": "https://github.com/JeevanBhoot",
"followers_url": "https://api.github.com/users/JeevanBhoot/followers",
"following_url": "https://api.github.com/users/JeevanBhoot/following{/other_user}",
"gists_url": "https://api.github.com/users/JeevanBhoot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JeevanBhoot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JeevanBhoot/subscriptions",
"organizations_url": "https://api.github.com/users/JeevanBhoot/orgs",
"repos_url": "https://api.github.com/users/JeevanBhoot/repos",
"events_url": "https://api.github.com/users/JeevanBhoot/events{/privacy}",
"received_events_url": "https://api.github.com/users/JeevanBhoot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Thanks for reporting this. This workload -- [examples/nlp/language_modeling/megatron_gpt_ptq.py](https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/language_modeling/megatron_gpt_ptq.py) -- was tested on 1xH100 80GB GPU but I agree that it looks excessive, we'll take a look. For completeness: could you perhaps share the full log for your issue?\r\n\r\nPlease also note that currently this memory requirements would apply only for the calibration step (i.e. the script linked above). For TensorRT-LLM engine the memory consumption is as expected: ca. ~9GB for FP8 Llama3-8B model (you can create engines using [tests/export/nemo_export.py](https://github.com/NVIDIA/NeMo/blob/main/tests/export/nemo_export.py), for example).",
"To successfully calibrate and export the Llama3-8b model on, for example, L4 24GB GPU you can use:\r\n```\r\npython megatron_gpt_ptq.py \\\r\n model.restore_from_path=Llama-8b \\\r\n +model.dist_ckpt_load_on_device=False \\\r\n +model.megatron_amp_O2=true \\\r\n +model.precision=bf16 \\\r\n trainer.precision=bf16 \\\r\n quantization.algorithm=fp8 \\\r\n export.dtype=bf16 \\\r\n inference.batch_size=16\r\n```\r\n\r\nExplanations:\r\n1. The knobs below correctly setup the model for evaluation in `bf16`. Disabling `dist_ckpt_load_on_device` avoids memory spikes on model loading:\r\n```\r\n +model.dist_ckpt_load_on_device=False \\\r\n +model.megatron_amp_O2=true \\\r\n +model.precision=bf16 \\\r\n trainer.precision=bf16 \\\r\n```\r\n2. Parameter `export.dtype=bf16` should be the same as model precision -- either `16` or `bf16` -- to avoid data cast on the export step that may also cause OOM.\r\n3. I had to use slightly lower `inference.batch_size=16`.\r\n\r\nThis should do it. Let me know if you have any other issues/questions."
] | 2024-07-31T14:17:17 | 2024-09-09T08:04:56 | 2024-09-09T08:04:56 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Running FP8 PTQ of Llama3-8b on 1x 4090 (24GB) goes OOM? Is this expected? vLLM FP8 quantization works on the same GPU.
What are the minimum requirements to run this quantization?
I have even tried setting batch size to 1 and it still goes OOM.
**Steps/Code to reproduce bug**
```bash
python scripts/checkpoint_converters/convert_llama_hf_to_nemo.py --input_name_or_path meta-llama/Meta-Llama-3-8B-Instruct --output_path ./llama3_8b_instruct.nemo --precision bf16
python examples/nlp/language_modeling/megatron_gpt_ptq.py model.restore_from_path=llama3_8b_instruct.nemo quantization.algorithm=fp8 export.decoder_type=llama export.save_path=llama3_8b_instruct_fp8 export.inference_tensor_parallel=1 trainer.num_nodes=1 trainer.devices=1
```
**Environment overview (please complete the following information)**
- Environment location: Docker
- Method of NeMo install: source
- If method of install is [Docker], provide `docker pull` & `docker run` commands used:
```bash
docker run --gpus all -it --rm -v ./NeMo:/NeMo --shm-size=8g \-p 8888:8888 -p 6006:6006 --ulimit memlock=-1 --ulimit \stack=67108864 --device=/dev/snd nvcr.io/nvidia/pytorch:23.10-py3
```
| {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9981/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9981/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9980 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9980/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9980/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9980/events | https://github.com/NVIDIA/NeMo/pull/9980 | 2,440,127,669 | PR_kwDOC_bI7s52_98x | 9,980 | Fix lita tutorial | {
"login": "Slyne",
"id": 6286804,
"node_id": "MDQ6VXNlcjYyODY4MDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6286804?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Slyne",
"html_url": "https://github.com/Slyne",
"followers_url": "https://api.github.com/users/Slyne/followers",
"following_url": "https://api.github.com/users/Slyne/following{/other_user}",
"gists_url": "https://api.github.com/users/Slyne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Slyne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Slyne/subscriptions",
"organizations_url": "https://api.github.com/users/Slyne/orgs",
"repos_url": "https://api.github.com/users/Slyne/repos",
"events_url": "https://api.github.com/users/Slyne/events{/privacy}",
"received_events_url": "https://api.github.com/users/Slyne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"@yaoyu-33 "
] | 2024-07-31T13:55:31 | 2024-07-31T17:25:00 | 2024-07-31T17:25:00 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9980",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9980",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9980.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9980.patch",
"merged_at": "2024-07-31T17:25:00"
} | # What does this PR do ?
To add fix for r2.0.0rc1.
ORG PR: https://github.com/NVIDIA/NeMo/pull/9973
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9980/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9980/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9979 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9979/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9979/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9979/events | https://github.com/NVIDIA/NeMo/pull/9979 | 2,439,590,857 | PR_kwDOC_bI7s52-GmA | 9,979 | Resiliency features update | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-31T09:35:14 | 2024-07-31T12:49:17 | 2024-07-31T12:49:15 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9979",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9979",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9979.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9979.patch",
"merged_at": "2024-07-31T12:49:15"
} | # What does this PR do ?
Changes for the updated version of resiliency features:
- Fault Tolerance
- Straggler Detection
**Collection**: [Note which collection this PR will affect]
# Changelog
- Updated/clarified documentation
- Removed duplicated "straggler detection" section from the documentation
- Updated straggler detection unit test
- Do not pass logger instance to the straggler det. callback
- Exposed `safety_factor` FT param
- Pass `exp_dir` to the FT callback
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "jbieniusiewi",
"id": 152396322,
"node_id": "U_kgDOCRViIg",
"avatar_url": "https://avatars.githubusercontent.com/u/152396322?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jbieniusiewi",
"html_url": "https://github.com/jbieniusiewi",
"followers_url": "https://api.github.com/users/jbieniusiewi/followers",
"following_url": "https://api.github.com/users/jbieniusiewi/following{/other_user}",
"gists_url": "https://api.github.com/users/jbieniusiewi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jbieniusiewi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jbieniusiewi/subscriptions",
"organizations_url": "https://api.github.com/users/jbieniusiewi/orgs",
"repos_url": "https://api.github.com/users/jbieniusiewi/repos",
"events_url": "https://api.github.com/users/jbieniusiewi/events{/privacy}",
"received_events_url": "https://api.github.com/users/jbieniusiewi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9979/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9979/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9978 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9978/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9978/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9978/events | https://github.com/NVIDIA/NeMo/pull/9978 | 2,439,491,895 | PR_kwDOC_bI7s529wpb | 9,978 | Allow users to pass HF via local-path: model_cls.import_ckpt("hf:///p… | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-31T08:49:41 | 2024-08-02T00:50:07 | 2024-08-02T00:50:05 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9978",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9978",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9978.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9978.patch",
"merged_at": "2024-08-02T00:50:05"
} | Want to enable the following
`
model = llm.MixtralModel(llm.MixtralConfig8x22B())
hf_ckpt_path = "hf://mistralai/Mixtral-8x22B-v0.1"
hf_ckpt_path = 'hf:///mnt/4tb/mixtral_8x22b/mixtral-8x22B-hf/'
ckpt_path = model.import_ckpt(hf_ckpt_path)
`
- pass via hf identifier, ie: `hf_ckpt_path = "hf://mistralai/Mixtral-8x22B-v0.1"`
- pass via local path, ie: `hf_ckpt_path = 'hf:///mnt/4tb/mixtral_8x22b/mixtral-8x22B-hf/"`
This is mainly useful when the user has already downloaded to their local disk a large checkpoint (e.g. > 200B parameters).
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9978/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9978/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9977 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9977/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9977/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9977/events | https://github.com/NVIDIA/NeMo/pull/9977 | 2,439,389,572 | PR_kwDOC_bI7s529aEn | 9,977 | nemo ux mixtral 8x22b config | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-31T07:56:36 | 2024-08-06T18:52:45 | 2024-08-06T18:52:43 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9977",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9977",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9977.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9977.patch",
"merged_at": "2024-08-06T18:52:43"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9977/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9977/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9976 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9976/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9976/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9976/events | https://github.com/NVIDIA/NeMo/pull/9976 | 2,439,379,054 | PR_kwDOC_bI7s529XxP | 9,976 | hypen -> hyphen | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-31T07:50:50 | 2024-07-31T17:02:07 | 2024-07-31T17:02:05 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9976",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9976",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9976.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9976.patch",
"merged_at": "2024-07-31T17:02:05"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9976/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9976/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9975 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9975/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9975/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9975/events | https://github.com/NVIDIA/NeMo/pull/9975 | 2,439,378,891 | PR_kwDOC_bI7s529Xu- | 9,975 | mixtral recipe | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-31T07:50:44 | 2024-08-07T18:59:51 | 2024-08-07T18:59:49 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9975",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9975",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9975.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9975.patch",
"merged_at": "2024-08-07T18:59:49"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9975/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9975/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9974 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9974/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9974/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9974/events | https://github.com/NVIDIA/NeMo/pull/9974 | 2,439,159,532 | PR_kwDOC_bI7s528nnd | 9,974 | Support hf tokenizer in packed seq preparation script | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-31T05:27:16 | 2024-08-01T17:26:30 | 2024-08-01T17:26:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9974",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9974",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9974.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9974.patch",
"merged_at": "2024-08-01T17:26:27"
} | # What does this PR do ?
Add support for HF tokenizer (e.g. Llama 3 models)
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9974/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9974/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9973 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9973/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9973/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9973/events | https://github.com/NVIDIA/NeMo/pull/9973 | 2,439,145,548 | PR_kwDOC_bI7s528kjR | 9,973 | fix typo | {
"login": "Slyne",
"id": 6286804,
"node_id": "MDQ6VXNlcjYyODY4MDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6286804?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Slyne",
"html_url": "https://github.com/Slyne",
"followers_url": "https://api.github.com/users/Slyne/followers",
"following_url": "https://api.github.com/users/Slyne/following{/other_user}",
"gists_url": "https://api.github.com/users/Slyne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Slyne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Slyne/subscriptions",
"organizations_url": "https://api.github.com/users/Slyne/orgs",
"repos_url": "https://api.github.com/users/Slyne/repos",
"events_url": "https://api.github.com/users/Slyne/events{/privacy}",
"received_events_url": "https://api.github.com/users/Slyne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-31T05:14:03 | 2024-08-22T01:52:47 | 2024-08-22T01:52:46 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9973",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9973",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9973.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9973.patch",
"merged_at": null
} | # What does this PR do ?
Fix lita tutorial typo.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9973/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9973/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9972 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9972/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9972/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9972/events | https://github.com/NVIDIA/NeMo/pull/9972 | 2,438,953,028 | PR_kwDOC_bI7s5277bV | 9,972 | Make Mistral HF to NeMo checkpoint converter iterable to allow for lo… | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-31T01:55:32 | 2024-08-05T17:19:38 | 2024-08-05T17:19:37 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9972",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9972",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9972.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9972.patch",
"merged_at": "2024-08-05T17:19:37"
} | Makes the `convert` function of the checkpoint converter an iterator. This allows for reduced memory usage during conversion, in fact less memory usage than the total RAM requirements of a full checkpoint.
If the `--low-mem` CLI option is used, the converter will load only the requested layers from the HF checkpoint and upon conversion of a full layer (e.g. transformer) it will save it to disk. Next, it will load those partially converted checkpoints via mmap, thus only copying to ram layers that are being used.
During the model initialization stage the converter may need the full checkpoint ram, but due to memory mapping it can do with less ram also, thus reducing the ram requirements significantly.
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9972/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9972/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9970 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9970/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9970/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9970/events | https://github.com/NVIDIA/NeMo/pull/9970 | 2,438,870,688 | PR_kwDOC_bI7s527qAt | 9,970 | Bump `Dockerfile.ci` (2024-07-31) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-31T00:16:20 | 2024-08-02T23:39:02 | 2024-08-02T23:39:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9970",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9970",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9970.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9970.patch",
"merged_at": null
} | 🚀 PR to Bump `Dockerfile.ci`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9970/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9970/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9969 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9969/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9969/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9969/events | https://github.com/NVIDIA/NeMo/issues/9969 | 2,438,673,376 | I_kwDOC_bI7s6RWzPg | 9,969 | Support for per-dataset metrics | {
"login": "zxiu2049",
"id": 161376511,
"node_id": "U_kgDOCZ5o_w",
"avatar_url": "https://avatars.githubusercontent.com/u/161376511?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zxiu2049",
"html_url": "https://github.com/zxiu2049",
"followers_url": "https://api.github.com/users/zxiu2049/followers",
"following_url": "https://api.github.com/users/zxiu2049/following{/other_user}",
"gists_url": "https://api.github.com/users/zxiu2049/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zxiu2049/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zxiu2049/subscriptions",
"organizations_url": "https://api.github.com/users/zxiu2049/orgs",
"repos_url": "https://api.github.com/users/zxiu2049/repos",
"events_url": "https://api.github.com/users/zxiu2049/events{/privacy}",
"received_events_url": "https://api.github.com/users/zxiu2049/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-30T21:02:24 | 2024-09-07T01:53:32 | 2024-09-07T01:53:32 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Is your feature request related to a problem? Please describe.**
I'd like to be able to get per-dataset metrics during training & eval(testing).
Currently even if I configure the `model.data` with multiple datasets, the val_loss still only shows the total loss not the per-dataset losses. See attached.
Looking at the code, it looks like this is due to NeMo blending the datasets before feeding to the PL trainer (to be confirmed by NeMo engineers). [Code reference](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py).
**Describe the solution you'd like**
I would like that NeMo would have the option to enable per-dataset metrics. So that for each val loop, a set of losses (each corresponding to an input dataset) would be logged.
This is hardly a technical proposal but my intuition is that we could either make it so that one dataloader is created per dataset (this might require not blending the datasets in the first place) and pass a map/list of dataloaders to the PL trainer so that the default behavior of the trainer can be leveraged. Or we could take advantage of the `dataset_id` [field](https://github.com/NVIDIA/Megatron-LM/blob/main/megatron/core/datasets/blended_dataset.py#L96) from each datum and have some sort of breakdown mechanism in the metrics calculation stage.
**Describe alternatives you've considered**
N/A
**Additional context**
N/A
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9969/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9969/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9968 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9968/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9968/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9968/events | https://github.com/NVIDIA/NeMo/pull/9968 | 2,438,447,807 | PR_kwDOC_bI7s526OQ7 | 9,968 | Add Mcore microbatches calculator supports | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "BoxiangW",
"id": 45734921,
"node_id": "MDQ6VXNlcjQ1NzM0OTIx",
"avatar_url": "https://avatars.githubusercontent.com/u/45734921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BoxiangW",
"html_url": "https://github.com/BoxiangW",
"followers_url": "https://api.github.com/users/BoxiangW/followers",
"following_url": "https://api.github.com/users/BoxiangW/following{/other_user}",
"gists_url": "https://api.github.com/users/BoxiangW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BoxiangW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BoxiangW/subscriptions",
"organizations_url": "https://api.github.com/users/BoxiangW/orgs",
"repos_url": "https://api.github.com/users/BoxiangW/repos",
"events_url": "https://api.github.com/users/BoxiangW/events{/privacy}",
"received_events_url": "https://api.github.com/users/BoxiangW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This PR is an replacement of https://github.com/NVIDIA/NeMo/pull/9838 due to signoff issue.",
"Adding decreasing related support in separate PR later ",
"Besides the comment about the in-line imports, LGTM",
"@terrykong This is actually an legacy setting inherited from previous version. They use try except to avoid import error and use \r\n```\r\nif not HAVE_MEGATRON_CORE:\r\n logging.warning(\r\n \"megatron-core was not found. Please see the NeMo README for installation instructions: https://github.com/NVIDIA/NeMo#megatron-gpt.\"\r\n )\r\n```\r\nto log warnings. I am thinking try to avoid this part and log a version warning for not able to use mcore mb calculator like:\r\n```\r\ntry:\r\n from megatron.core.num_microbatches_calculator import get_num_microbatches\r\n\r\nexcept (ImportError, ModuleNotFoundError):\r\n logging.warning(\"megatron-core num_microbatches_calculator not found, using Apex version.\")\r\n from apex.transformer.pipeline_parallel.utils import get_num_microbatches\r\n```"
] | 2024-07-30T18:36:34 | 2024-09-04T18:10:32 | 2024-08-01T22:37:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9968",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9968",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9968.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9968.patch",
"merged_at": "2024-08-01T22:37:15"
} | # What does this PR do ?
Add Mcore microbatches calculator supports. Added backward compatibility. Merged `init_num_mb_calculator` and `reconfigure_num_mb_calculator`
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9968/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9968/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9967 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9967/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9967/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9967/events | https://github.com/NVIDIA/NeMo/issues/9967 | 2,438,288,493 | I_kwDOC_bI7s6RVVRt | 9,967 | Adding an option to only retain optimizer states for the last N checkpoints | {
"login": "Kipok",
"id": 2354422,
"node_id": "MDQ6VXNlcjIzNTQ0MjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2354422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kipok",
"html_url": "https://github.com/Kipok",
"followers_url": "https://api.github.com/users/Kipok/followers",
"following_url": "https://api.github.com/users/Kipok/following{/other_user}",
"gists_url": "https://api.github.com/users/Kipok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kipok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kipok/subscriptions",
"organizations_url": "https://api.github.com/users/Kipok/orgs",
"repos_url": "https://api.github.com/users/Kipok/repos",
"events_url": "https://api.github.com/users/Kipok/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kipok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale.",
"PR is merged: https://github.com/NVIDIA/NeMo/pull/10098"
] | 2024-07-30T17:01:20 | 2024-09-23T11:00:15 | 2024-09-23T11:00:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Is your feature request related to a problem? Please describe.**
Currently when training LLMs, the checkpoints are saved with all of the optimizer states, which generally increases the checkpoint size about 6 times. When the LLM itself is very large (e.g. > 30B parameters) and we are running many training jobs at the same time, this requires having a very large storage on the cluster. In case of SFT experiments where we almost never need to restart training from the middle of the job, saving optimizer states for intermediate checkpoints is really wasteful and it would be great to have some control over this.
**Describe the solution you'd like**
Have a config parameter "save_optimizer_states_for_last_checkpoints" (probably a less verbose name is needed). I'd default it to 2 since we always need a last checkpoint state in case job fails or is preempted and it's good to keep another one in case the last state is corrupted for some reason. Then we can set it to -1 to keep the current behavior of saving all optimizer states, set it to 0 in case we don't want to save any, or anything in between.
The way I'd implement it is by modifying PTL/megatron logic in checkpoint saving and whenever we save a new checkpoint, we would then simply remove the optimizer states from one of the old checkpoints based on the config parameter.
**Describe alternatives you've considered**
A current alternative that we have to use is basically to manually remove the optimizer states when we run out of space, which is of course very inconvenient. Another potential way to solve this is by having a script that runs alongside the training jobs and monitors the training folder and whenever a new checkpoint is saved, it does the cleaning. This way we don't have to modify nemo code, but it does not feel like a good solution.
**Additional context**
n/a | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9967/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9967/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9966 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9966/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9966/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9966/events | https://github.com/NVIDIA/NeMo/pull/9966 | 2,438,214,797 | PR_kwDOC_bI7s525bgz | 9,966 | add bert conversion and cicd | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-30T16:19:40 | 2024-08-01T14:25:16 | 2024-08-01T14:25:13 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9966",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9966",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9966.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9966.patch",
"merged_at": "2024-08-01T14:25:13"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9966/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9966/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9965 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9965/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9965/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9965/events | https://github.com/NVIDIA/NeMo/pull/9965 | 2,437,985,670 | PR_kwDOC_bI7s524pRK | 9,965 | Run a sample query for a quantized model conditionally | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-30T14:28:02 | 2024-07-30T16:27:14 | 2024-07-30T16:27:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9965",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9965",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9965.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9965.patch",
"merged_at": "2024-07-30T16:27:12"
} | # What does this PR do ?
Change equivalent to https://github.com/NVIDIA/NeMo/pull/9717 but targeted to **r2.0.0rc1** branch.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9965/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9965/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9964 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9964/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9964/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9964/events | https://github.com/NVIDIA/NeMo/pull/9964 | 2,437,104,253 | PR_kwDOC_bI7s521l-J | 9,964 | fix mem | {
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"CI passed https://github.com/NVIDIA/NeMo/actions/runs/10157985014"
] | 2024-07-30T07:24:10 | 2024-07-30T15:19:55 | 2024-07-30T15:19:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9964",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9964",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9964.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9964.patch",
"merged_at": "2024-07-30T15:19:53"
} | Same as #9957 but to RC branch | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9964/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9964/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9963 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9963/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9963/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9963/events | https://github.com/NVIDIA/NeMo/pull/9963 | 2,437,012,927 | PR_kwDOC_bI7s521R3n | 9,963 | Applying @conver334 global_sample_mapping patch | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-30T06:31:40 | 2024-07-30T06:52:28 | 2024-07-30T06:52:23 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9963",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9963",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9963.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9963.patch",
"merged_at": null
} | # What does this PR do ?
This is @conver334 work to implement a knob to disable global_sample_mapping by default.\
Since @conver334's branch was not on github.com/NVIDIA/NeMo and black/isort had trouble running. As a result I made this PR to unblock this work, but the code is not mine.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9963/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9963/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9962 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9962/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9962/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9962/events | https://github.com/NVIDIA/NeMo/pull/9962 | 2,436,923,602 | PR_kwDOC_bI7s520-al | 9,962 | _build_num_microbatches_calculator arg & namefix | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"closing in favor of 9968"
] | 2024-07-30T05:22:41 | 2024-08-01T16:36:15 | 2024-07-31T01:40:16 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9962",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9962",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9962.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9962.patch",
"merged_at": null
} | # What does this PR do ?
Call `_build_num_microbatches_calculator` instead of `build_num_microbatches_calculator` & pass False to `decrease_batch_size_if_needed`
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9962/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9962/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9961 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9961/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9961/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9961/events | https://github.com/NVIDIA/NeMo/pull/9961 | 2,436,872,418 | PR_kwDOC_bI7s520zW9 | 9,961 | Add pydantic-settings | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"ci passed: https://github.com/NVIDIA/NeMo/actions/runs/10156209912"
] | 2024-07-30T04:34:00 | 2024-07-30T19:54:07 | 2024-07-30T19:54:05 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9961",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9961",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9961.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9961.patch",
"merged_at": "2024-07-30T19:54:05"
} | # What does this PR do ?
Adds pydantic-settings to the service | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9961/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9961/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9960 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9960/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9960/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9960/events | https://github.com/NVIDIA/NeMo/pull/9960 | 2,436,858,740 | PR_kwDOC_bI7s520wUx | 9,960 | Add pydantic settings | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-30T04:22:11 | 2024-07-30T04:31:42 | 2024-07-30T04:31:42 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9960",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9960",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9960.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9960.patch",
"merged_at": null
} | # What does this PR do ?
Adding pydantic settings to the service requirements. | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9960/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9960/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9959 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9959/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9959/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9959/events | https://github.com/NVIDIA/NeMo/pull/9959 | 2,436,635,667 | PR_kwDOC_bI7s52z__F | 9,959 | Bump `Dockerfile.ci` (2024-07-30) | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-30T00:19:46 | 2024-08-02T23:39:09 | 2024-08-02T23:39:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9959",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9959",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9959.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9959.patch",
"merged_at": null
} | 🚀 PR to Bump `Dockerfile.ci`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9959/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9959/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9958 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9958/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9958/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9958/events | https://github.com/NVIDIA/NeMo/pull/9958 | 2,436,617,425 | PR_kwDOC_bI7s52z8Dt | 9,958 | Use packaging & remove pkg_resources | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-07-30T00:00:08 | 2024-08-19T16:39:56 | 2024-08-19T16:39:54 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9958",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9958",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9958.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9958.patch",
"merged_at": "2024-08-19T16:39:54"
} | # What does this PR do ?
Import `packaging` instead of `pkg_resources`;
In later versions of `pkg_resources`, `packaging` is removed from the module and in Python 3.12 `pkg_resources` itself is deprecated.
Sol: use the `packaging` package.
Note: this is mostly needed to query TE's version which is a suboptimal way of doing it since you can alter via PYTHONPATH ( & appropriate .so links), so might be better to make a function to check whether __version__ is available and if not fall-back to `packaging` logic.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "thomasdhc",
"id": 9426164,
"node_id": "MDQ6VXNlcjk0MjYxNjQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/9426164?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/thomasdhc",
"html_url": "https://github.com/thomasdhc",
"followers_url": "https://api.github.com/users/thomasdhc/followers",
"following_url": "https://api.github.com/users/thomasdhc/following{/other_user}",
"gists_url": "https://api.github.com/users/thomasdhc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/thomasdhc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thomasdhc/subscriptions",
"organizations_url": "https://api.github.com/users/thomasdhc/orgs",
"repos_url": "https://api.github.com/users/thomasdhc/repos",
"events_url": "https://api.github.com/users/thomasdhc/events{/privacy}",
"received_events_url": "https://api.github.com/users/thomasdhc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9958/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9958/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9957 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9957/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9957/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9957/events | https://github.com/NVIDIA/NeMo/pull/9957 | 2,436,492,233 | PR_kwDOC_bI7s52zfrl | 9,957 | fix mem | {
"login": "gshennvm",
"id": 119401249,
"node_id": "U_kgDOBx3rIQ",
"avatar_url": "https://avatars.githubusercontent.com/u/119401249?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gshennvm",
"html_url": "https://github.com/gshennvm",
"followers_url": "https://api.github.com/users/gshennvm/followers",
"following_url": "https://api.github.com/users/gshennvm/following{/other_user}",
"gists_url": "https://api.github.com/users/gshennvm/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gshennvm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gshennvm/subscriptions",
"organizations_url": "https://api.github.com/users/gshennvm/orgs",
"repos_url": "https://api.github.com/users/gshennvm/repos",
"events_url": "https://api.github.com/users/gshennvm/events{/privacy}",
"received_events_url": "https://api.github.com/users/gshennvm/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-29T22:25:05 | 2024-07-30T07:24:42 | 2024-07-30T07:24:40 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9957",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9957",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9957.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9957.patch",
"merged_at": "2024-07-30T07:24:40"
} | # What does this PR do ?
fix mem in refit | {
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9957/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9957/timeline | null | null | true |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.