url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/9751 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9751/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9751/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9751/events | https://github.com/NVIDIA/NeMo/pull/9751 | 2,410,267,930 | PR_kwDOC_bI7s51d7G6 | 9,751 | [Audio] Metric with Squim objective and MOS | {
"login": "anteju",
"id": 108555623,
"node_id": "U_kgDOBnhtZw",
"avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anteju",
"html_url": "https://github.com/anteju",
"followers_url": "https://api.github.com/users/anteju/followers",
"following_url": "https://api.github.com/users/anteju/following{/other_user}",
"gists_url": "https://api.github.com/users/anteju/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anteju/subscriptions",
"organizations_url": "https://api.github.com/users/anteju/orgs",
"repos_url": "https://api.github.com/users/anteju/repos",
"events_url": "https://api.github.com/users/anteju/events{/privacy}",
"received_events_url": "https://api.github.com/users/anteju/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-16T05:48:30 | 2024-07-23T20:06:58 | 2024-07-23T20:06:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9751",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9751",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9751.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9751.patch",
"merged_at": "2024-07-23T20:06:58"
} | # What does this PR do ?
Add a `Metric` object for calculating Squim MOS.
**Collection**: audio
# Changelog
- Added a metric wrapper for Squim objective and MOS models
- Added unit tests
- Fixed a bug in `transcribe_utils`
# Usage
For example, in model config:
```python
...
model:
...
metrics:
val:
squim_mos: # Squim MOS
_target_: nemo.collections.audio.metrics.SquimMOSMetric
fs: ${model.sample_rate}
squim_stoi: # Squim STOI
_target_: nemo.collections.audio.metrics.SquimObjectiveMetric
metric: stoi
fs: ${model.sample_rate}
...
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "anteju",
"id": 108555623,
"node_id": "U_kgDOBnhtZw",
"avatar_url": "https://avatars.githubusercontent.com/u/108555623?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anteju",
"html_url": "https://github.com/anteju",
"followers_url": "https://api.github.com/users/anteju/followers",
"following_url": "https://api.github.com/users/anteju/following{/other_user}",
"gists_url": "https://api.github.com/users/anteju/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anteju/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anteju/subscriptions",
"organizations_url": "https://api.github.com/users/anteju/orgs",
"repos_url": "https://api.github.com/users/anteju/repos",
"events_url": "https://api.github.com/users/anteju/events{/privacy}",
"received_events_url": "https://api.github.com/users/anteju/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9751/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9751/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9750 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9750/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9750/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9750/events | https://github.com/NVIDIA/NeMo/pull/9750 | 2,409,867,803 | PR_kwDOC_bI7s51cpth | 9,750 | TorchAudio installation workaround for incorrect `PYTORCH_VERSION` variable | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-16T00:14:39 | 2024-07-16T13:55:10 | 2024-07-16T13:55:08 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9750",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9750",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9750.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9750.patch",
"merged_at": "2024-07-16T13:55:08"
} | # What does this PR do ?
Fixed TorchAudio installation for `nvcr.io/nvidia/pytorch:24.03-py3` container and other environments, where `PYTORCH_VERSION` env variable contains incorrect PyTorch version (real PyTorch version differs).
Should fix https://nvbugs/4738248
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9750/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9750/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9749 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9749/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9749/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9749/events | https://github.com/NVIDIA/NeMo/pull/9749 | 2,409,827,731 | PR_kwDOC_bI7s51chzm | 9,749 | [NeMo-UX] Minor bug fix when TE/Apex not installed | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-15T23:48:40 | 2024-07-16T02:15:29 | 2024-07-16T02:15:28 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9749",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9749",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9749.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9749.patch",
"merged_at": "2024-07-16T02:15:28"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9749/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9749/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9748 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9748/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9748/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9748/events | https://github.com/NVIDIA/NeMo/pull/9748 | 2,409,786,640 | PR_kwDOC_bI7s51cY4W | 9,748 | Add FSDP for NeMo 2.0 | {
"login": "blahBlahhhJ",
"id": 25292161,
"node_id": "MDQ6VXNlcjI1MjkyMTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/25292161?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blahBlahhhJ",
"html_url": "https://github.com/blahBlahhhJ",
"followers_url": "https://api.github.com/users/blahBlahhhJ/followers",
"following_url": "https://api.github.com/users/blahBlahhhJ/following{/other_user}",
"gists_url": "https://api.github.com/users/blahBlahhhJ/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blahBlahhhJ/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blahBlahhhJ/subscriptions",
"organizations_url": "https://api.github.com/users/blahBlahhhJ/orgs",
"repos_url": "https://api.github.com/users/blahBlahhhJ/repos",
"events_url": "https://api.github.com/users/blahBlahhhJ/events{/privacy}",
"received_events_url": "https://api.github.com/users/blahBlahhhJ/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "blahBlahhhJ",
"id": 25292161,
"node_id": "MDQ6VXNlcjI1MjkyMTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/25292161?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blahBlahhhJ",
"html_url": "https://github.com/blahBlahhhJ",
"followers_url": "https://api.github.com/users/blahBlahhhJ/followers",
"following_url": "https://api.github.com/users/blahBlahhhJ/following{/other_user}",
"gists_url": "https://api.github.com/users/blahBlahhhJ/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blahBlahhhJ/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blahBlahhhJ/subscriptions",
"organizations_url": "https://api.github.com/users/blahBlahhhJ/orgs",
"repos_url": "https://api.github.com/users/blahBlahhhJ/repos",
"events_url": "https://api.github.com/users/blahBlahhhJ/events{/privacy}",
"received_events_url": "https://api.github.com/users/blahBlahhhJ/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "blahBlahhhJ",
"id": 25292161,
"node_id": "MDQ6VXNlcjI1MjkyMTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/25292161?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blahBlahhhJ",
"html_url": "https://github.com/blahBlahhhJ",
"followers_url": "https://api.github.com/users/blahBlahhhJ/followers",
"following_url": "https://api.github.com/users/blahBlahhhJ/following{/other_user}",
"gists_url": "https://api.github.com/users/blahBlahhhJ/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blahBlahhhJ/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blahBlahhhJ/subscriptions",
"organizations_url": "https://api.github.com/users/blahBlahhhJ/orgs",
"repos_url": "https://api.github.com/users/blahBlahhhJ/repos",
"events_url": "https://api.github.com/users/blahBlahhhJ/events{/privacy}",
"received_events_url": "https://api.github.com/users/blahBlahhhJ/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Hey, I noticed that in NeMo 1.X, FSDP support is really not well-integrated across the code base. Many scripts do not work with it because they only implement `NLPDDPStrategy`, checkpoint conversion was a huge undertaking to get working (PR pending), and some feature flags straight-up [don't work](https://github.com/NVIDIA/NeMo/issues/9531) or [had bugs](https://github.com/NVIDIA/NeMo/pull/9335).\r\n\r\nI'm super happy that FSDP is supported at all, having it integrated is really nice and for 7B models, performance with default settings was surprisingly higher than Megatron's 4D parallelism. However, I would really wish for and encourage more proper support in NeMo 2.X; it would be amazing if all NeMo workflows – not just training – just worked out of the box. :)\r\n\r\nLet me know how to properly help in this endeavor, too, please. I've had the disheartening experience that PRs randomly get ignored, so I don't want to spend time improving the code base if it'll go wasted in the end."
] | 2024-07-15T23:02:47 | 2024-08-29T03:17:58 | 2024-08-29T03:17:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9748",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9748",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9748.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9748.patch",
"merged_at": "2024-08-29T03:17:57"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Made a strategies/ direcotory to hold all strategies (e.g. MegatronStrategy & FSDPStrategy)
- Extracted common logic shared by different strategies into helper functions (utils.py)
- Wrote FSDPStrategy which uses FSDP1 to replace MegatronStrategy if users want to run FSDP
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9748/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9748/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9747 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9747/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9747/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9747/events | https://github.com/NVIDIA/NeMo/pull/9747 | 2,409,738,488 | PR_kwDOC_bI7s51cOFa | 9,747 | Skip quantization if model is already quantized (QAT resuming) | {
"login": "kevalmorabia97",
"id": 28916987,
"node_id": "MDQ6VXNlcjI4OTE2OTg3",
"avatar_url": "https://avatars.githubusercontent.com/u/28916987?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kevalmorabia97",
"html_url": "https://github.com/kevalmorabia97",
"followers_url": "https://api.github.com/users/kevalmorabia97/followers",
"following_url": "https://api.github.com/users/kevalmorabia97/following{/other_user}",
"gists_url": "https://api.github.com/users/kevalmorabia97/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kevalmorabia97/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevalmorabia97/subscriptions",
"organizations_url": "https://api.github.com/users/kevalmorabia97/orgs",
"repos_url": "https://api.github.com/users/kevalmorabia97/repos",
"events_url": "https://api.github.com/users/kevalmorabia97/events{/privacy}",
"received_events_url": "https://api.github.com/users/kevalmorabia97/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-15T22:19:28 | 2024-08-06T01:50:53 | 2024-08-06T01:50:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9747",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9747",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9747.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9747.patch",
"merged_at": null
} | # What does this PR do ?
When doing QAT for a big model, we often need to resume training. This PR adds a check if model restored from the resume checkpoint is already quantized or not, and if quantized, it skips this step.
**Collection**: N/A
# Changelog
- Skip quantization if model is already quantized (QAT resuming)
# Usage
- N/A
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
- [x] Minor improvement
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9747/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9747/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9746 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9746/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9746/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9746/events | https://github.com/NVIDIA/NeMo/pull/9746 | 2,409,731,512 | PR_kwDOC_bI7s51cMhj | 9,746 | Update path to Llama model in fine-tuning notebook | {
"login": "roclark",
"id": 12703406,
"node_id": "MDQ6VXNlcjEyNzAzNDA2",
"avatar_url": "https://avatars.githubusercontent.com/u/12703406?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/roclark",
"html_url": "https://github.com/roclark",
"followers_url": "https://api.github.com/users/roclark/followers",
"following_url": "https://api.github.com/users/roclark/following{/other_user}",
"gists_url": "https://api.github.com/users/roclark/gists{/gist_id}",
"starred_url": "https://api.github.com/users/roclark/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/roclark/subscriptions",
"organizations_url": "https://api.github.com/users/roclark/orgs",
"repos_url": "https://api.github.com/users/roclark/repos",
"events_url": "https://api.github.com/users/roclark/events{/privacy}",
"received_events_url": "https://api.github.com/users/roclark/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-15T22:12:55 | 2024-08-06T01:50:55 | 2024-08-06T01:50:54 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9746",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9746",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9746.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9746.patch",
"merged_at": null
} | # What does this PR do ?
The path to the model used during the evaluation stage should be updated to reflect the new NGC model registry download location.
**Collection**: LLMs
# Changelog
- The original path was leftover from the previous code where the model was downloaded from HuggingFace and converted to `.nemo`.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9746/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9746/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9745 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9745/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9745/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9745/events | https://github.com/NVIDIA/NeMo/pull/9745 | 2,409,715,562 | PR_kwDOC_bI7s51cJBI | 9,745 | Update starthere docs text | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [] | 2024-07-15T21:58:28 | 2024-07-15T22:01:43 | 2024-07-15T22:01:41 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9745",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9745",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9745.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9745.patch",
"merged_at": "2024-07-15T22:01:41"
} | # What does this PR do ?
1-line update to docs
**Collection**: Docs
# Changelog
- 1-line update to docs
# Usage
N/A
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [N/A] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [N/A] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9745/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9745/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9744 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9744/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9744/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9744/events | https://github.com/NVIDIA/NeMo/pull/9744 | 2,409,715,251 | PR_kwDOC_bI7s51cI8i | 9,744 | ci: Bump MCore tag | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-15T21:58:12 | 2024-07-17T16:57:28 | 2024-07-17T16:57:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9744",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9744",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9744.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9744.patch",
"merged_at": "2024-07-17T16:57:27"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9744/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9744/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9743 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9743/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9743/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9743/events | https://github.com/NVIDIA/NeMo/pull/9743 | 2,409,711,541 | PR_kwDOC_bI7s51cIFI | 9,743 | Bump `Dockerfile.ci` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-15T21:55:57 | 2024-07-17T11:41:31 | 2024-07-17T11:41:29 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9743",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9743",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9743.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9743.patch",
"merged_at": null
} | 🚀 PR to Bump `Dockerfile.ci`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9743/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9743/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9742 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9742/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9742/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9742/events | https://github.com/NVIDIA/NeMo/pull/9742 | 2,409,710,418 | PR_kwDOC_bI7s51cH00 | 9,742 | Bump `Dockerfile.ci` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-15T21:55:04 | 2024-07-17T11:41:32 | 2024-07-15T21:56:32 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9742",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9742",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9742.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9742.patch",
"merged_at": null
} | 🚀 PR to Bump `Dockerfile.ci`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9742/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9742/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9741 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9741/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9741/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9741/events | https://github.com/NVIDIA/NeMo/pull/9741 | 2,409,701,818 | PR_kwDOC_bI7s51cF4T | 9,741 | Bump `Dockerfile.ci` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-15T21:47:44 | 2024-07-15T21:53:35 | 2024-07-15T21:53:33 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9741",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9741",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9741.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9741.patch",
"merged_at": null
} | 🚀 PR to Bump `Dockerfile.ci`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9741/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9741/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9740 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9740/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9740/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9740/events | https://github.com/NVIDIA/NeMo/pull/9740 | 2,409,695,060 | PR_kwDOC_bI7s51cEVr | 9,740 | Bump `Dockerfile.ci` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-15T21:43:06 | 2024-07-15T21:45:58 | 2024-07-15T21:45:56 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9740",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9740",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9740.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9740.patch",
"merged_at": null
} | 🚀 PR to Bump `Dockerfile.ci`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9740/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9740/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9739 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9739/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9739/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9739/events | https://github.com/NVIDIA/NeMo/pull/9739 | 2,409,694,443 | PR_kwDOC_bI7s51cEM1 | 9,739 | Update to Pytorch 24.03 | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-15T21:42:33 | 2024-08-25T01:56:13 | 2024-08-25T01:56:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9739",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9739",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9739.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9739.patch",
"merged_at": null
} | Update to Pytorch 24.03 | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9739/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9739/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9738 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9738/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9738/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9738/events | https://github.com/NVIDIA/NeMo/pull/9738 | 2,409,687,020 | PR_kwDOC_bI7s51cCiE | 9,738 | Bump `Dockerfile.ci` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-15T21:36:27 | 2024-07-15T21:42:29 | 2024-07-15T21:42:27 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9738",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9738",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9738.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9738.patch",
"merged_at": null
} | 🚀 PR to Bump `Dockerfile.ci`.
📝 Please remember the following to-do's before merge:
- [ ] Verify the presubmit CI
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9738/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9738/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9737 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9737/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9737/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9737/events | https://github.com/NVIDIA/NeMo/pull/9737 | 2,409,633,823 | PR_kwDOC_bI7s51b2fY | 9,737 | Manually cherry-pick from PR 9679 (PR to main - Support SFT/Eval/PEFT for mcore T5) | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-15T21:05:36 | 2024-07-16T16:45:42 | 2024-07-16T16:45:40 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9737",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9737",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9737.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9737.patch",
"merged_at": "2024-07-16T16:45:40"
} | # What does this PR do ?
Manually copy changes from: https://github.com/NVIDIA/NeMo/pull/9679/files
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9737/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9737/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9736 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9736/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9736/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9736/events | https://github.com/NVIDIA/NeMo/pull/9736 | 2,409,586,110 | PR_kwDOC_bI7s51brmp | 9,736 | TorchAudio installation workaround for incorrect `PYTORCH_VERSION` variable | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-07-15T20:40:44 | 2024-07-16T00:14:16 | 2024-07-16T00:14:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9736",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9736",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9736.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9736.patch",
"merged_at": "2024-07-16T00:14:15"
} | # What does this PR do ?
Fixed TorchAudio installation for `nvcr.io/nvidia/pytorch:24.03-py3` container and other environments, where `PYTORCH_VERSION` env variable contains incorrect PyTorch version (real PyTorch version differs).
Should fix https://nvbugs/4738248
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9736/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9736/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9735 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9735/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9735/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9735/events | https://github.com/NVIDIA/NeMo/pull/9735 | 2,409,563,467 | PR_kwDOC_bI7s51bme_ | 9,735 | Log TFLOPs per sec per GPU | {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-15T20:27:29 | 2024-07-26T18:18:31 | 2024-07-26T18:18:31 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9735",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9735",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9735.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9735.patch",
"merged_at": null
} | # What does this PR do ?
Log TFLOPs per sec per GPU (logs to stdout and tensorboard logger)
**Collection**: 'common'
# Changelog
Supported models- Nemotron, GPT3, Llama2, Llama3, Mixtral
Supported GPUs- H200, H100, A100
** Tested on H100 for supported models
** Llama2 PEFT (LoRA and SFT) support coming soon
# Usage
```python
flops_measurement_callback = FLOPsMeasurementCallback(cfg)
lightning_trainer.callbacks.append(flops_measurement_callback)
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to
| {
"login": "malay-nagda",
"id": 164242706,
"node_id": "U_kgDOCcolEg",
"avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/malay-nagda",
"html_url": "https://github.com/malay-nagda",
"followers_url": "https://api.github.com/users/malay-nagda/followers",
"following_url": "https://api.github.com/users/malay-nagda/following{/other_user}",
"gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}",
"starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions",
"organizations_url": "https://api.github.com/users/malay-nagda/orgs",
"repos_url": "https://api.github.com/users/malay-nagda/repos",
"events_url": "https://api.github.com/users/malay-nagda/events{/privacy}",
"received_events_url": "https://api.github.com/users/malay-nagda/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9735/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9735/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9734 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9734/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9734/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9734/events | https://github.com/NVIDIA/NeMo/pull/9734 | 2,409,242,951 | PR_kwDOC_bI7s51af1W | 9,734 | Add Lita, Vila and Vita TRTLLM export | {
"login": "xuanzic",
"id": 140748220,
"node_id": "U_kgDOCGOlvA",
"avatar_url": "https://avatars.githubusercontent.com/u/140748220?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/xuanzic",
"html_url": "https://github.com/xuanzic",
"followers_url": "https://api.github.com/users/xuanzic/followers",
"following_url": "https://api.github.com/users/xuanzic/following{/other_user}",
"gists_url": "https://api.github.com/users/xuanzic/gists{/gist_id}",
"starred_url": "https://api.github.com/users/xuanzic/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xuanzic/subscriptions",
"organizations_url": "https://api.github.com/users/xuanzic/orgs",
"repos_url": "https://api.github.com/users/xuanzic/repos",
"events_url": "https://api.github.com/users/xuanzic/events{/privacy}",
"received_events_url": "https://api.github.com/users/xuanzic/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-15T17:19:25 | 2024-07-19T12:30:37 | 2024-07-19T12:30:37 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9734",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9734",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9734.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9734.patch",
"merged_at": "2024-07-19T12:30:37"
} | # What does this PR do ?
1) modify the neva_model to remove hardcoded 'vision_encoder" name.
2) add trtllm export support for lita, vila and vita .nemo model.
3) add run example for running lita, vila and vita inference.
4) add triton deployment for these models.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "meatybobby",
"id": 9738259,
"node_id": "MDQ6VXNlcjk3MzgyNTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/meatybobby",
"html_url": "https://github.com/meatybobby",
"followers_url": "https://api.github.com/users/meatybobby/followers",
"following_url": "https://api.github.com/users/meatybobby/following{/other_user}",
"gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions",
"organizations_url": "https://api.github.com/users/meatybobby/orgs",
"repos_url": "https://api.github.com/users/meatybobby/repos",
"events_url": "https://api.github.com/users/meatybobby/events{/privacy}",
"received_events_url": "https://api.github.com/users/meatybobby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9734/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9734/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9733 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9733/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9733/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9733/events | https://github.com/NVIDIA/NeMo/pull/9733 | 2,409,203,026 | PR_kwDOC_bI7s51aXBs | 9,733 | Alit/r2.0.0 | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-15T16:57:25 | 2024-08-06T01:50:56 | 2024-08-06T01:50:56 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9733",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9733",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9733.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9733.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9733/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9733/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9732 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9732/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9732/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9732/events | https://github.com/NVIDIA/NeMo/pull/9732 | 2,409,075,566 | PR_kwDOC_bI7s51Z7V- | 9,732 | [NeMo-UX] Make TE and Apex dependencies optional | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-15T15:50:43 | 2024-07-15T23:42:27 | 2024-07-15T23:42:25 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9732",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9732",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9732.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9732.patch",
"merged_at": "2024-07-15T23:42:25"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9732/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9732/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9731 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9731/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9731/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9731/events | https://github.com/NVIDIA/NeMo/pull/9731 | 2,408,723,446 | PR_kwDOC_bI7s51Yts2 | 9,731 | add contianer | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815558,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU4",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/documentation",
"name": "documentation",
"color": "0075ca",
"default": true,
"description": "Improvements or additions to documentation"
}
] | closed | false | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-15T13:16:36 | 2024-07-15T17:33:53 | 2024-07-15T17:33:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9731",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9731",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9731.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9731.patch",
"merged_at": "2024-07-15T17:33:51"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9731/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9731/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9730 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9730/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9730/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9730/events | https://github.com/NVIDIA/NeMo/issues/9730 | 2,408,024,141 | I_kwDOC_bI7s6Ph4hN | 9,730 | I wanted to train a multitask model, like canary. needed more information on how to build the tokenizer, and data manifest file. | {
"login": "mujhenahiata",
"id": 94825377,
"node_id": "U_kgDOBabroQ",
"avatar_url": "https://avatars.githubusercontent.com/u/94825377?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mujhenahiata",
"html_url": "https://github.com/mujhenahiata",
"followers_url": "https://api.github.com/users/mujhenahiata/followers",
"following_url": "https://api.github.com/users/mujhenahiata/following{/other_user}",
"gists_url": "https://api.github.com/users/mujhenahiata/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mujhenahiata/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mujhenahiata/subscriptions",
"organizations_url": "https://api.github.com/users/mujhenahiata/orgs",
"repos_url": "https://api.github.com/users/mujhenahiata/repos",
"events_url": "https://api.github.com/users/mujhenahiata/events{/privacy}",
"received_events_url": "https://api.github.com/users/mujhenahiata/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"@pzelasko @krishnacpuvvada provide necessary documentation for the same. ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-15T07:10:42 | 2024-09-09T01:57:02 | 2024-09-09T01:57:02 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **I wanted to train a multitask model, like canary. needed more information on how to build the tokenizer, and data manifest file.**
**A clear and concise description of what the problem is.**
Due to lack of information on how to build a canary like model, a tutorial, some refrence to build the tokenizer and manifest file, inorder to train such model.
**Describe alternatives you've considered**
I followed the information available at huggingface model card. but its insufficient.
@titu1994 @nithinraok @VahidooX please guide me | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9730/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9730/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9729 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9729/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9729/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9729/events | https://github.com/NVIDIA/NeMo/issues/9729 | 2,408,016,490 | I_kwDOC_bI7s6Ph2pq | 9,729 | Unable to reproduce cache aware streaming results for Conformer that were there for Fastconformer. | {
"login": "mujhenahiata",
"id": 94825377,
"node_id": "U_kgDOBabroQ",
"avatar_url": "https://avatars.githubusercontent.com/u/94825377?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mujhenahiata",
"html_url": "https://github.com/mujhenahiata",
"followers_url": "https://api.github.com/users/mujhenahiata/followers",
"following_url": "https://api.github.com/users/mujhenahiata/following{/other_user}",
"gists_url": "https://api.github.com/users/mujhenahiata/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mujhenahiata/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mujhenahiata/subscriptions",
"organizations_url": "https://api.github.com/users/mujhenahiata/orgs",
"repos_url": "https://api.github.com/users/mujhenahiata/repos",
"events_url": "https://api.github.com/users/mujhenahiata/events{/privacy}",
"received_events_url": "https://api.github.com/users/mujhenahiata/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"duplicate of https://github.com/NVIDIA/NeMo/issues/9521 "
] | 2024-07-15T07:06:18 | 2024-08-01T13:21:35 | 2024-08-01T13:21:35 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I trained Conformer-CTC using cache aware method. but unable to reproduce the results that were there with "Fastconformer cache aware streaming". By using Conformer-CTC cache aware method i get partial sub-words, words combined together like ("hello world" ==> herld) , in streaming output.
the same was the case when i deployed it in a RIVA pipeline.
but when i use the "transcribe" function i get proper transcription for the audio file.
@titu1994 @VahidooX
can you please enlighten on this.
When to use and how to use streaming models in .nemo format and in RIVA pipeline.
My question has some relevance with these issues
[https://github.com/https://github.com/NVIDIA/NeMo/discussions/7010]
[https://github.com/https://github.com/NVIDIA/NeMo/discussions/5284] | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9729/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9729/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9727 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9727/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9727/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9727/events | https://github.com/NVIDIA/NeMo/issues/9727 | 2,407,713,735 | I_kwDOC_bI7s6PgsvH | 9,727 | CPU memory keeps increasing in every step during training LLM with Nemo framework? | {
"login": "cuonglp1713",
"id": 77870418,
"node_id": "MDQ6VXNlcjc3ODcwNDE4",
"avatar_url": "https://avatars.githubusercontent.com/u/77870418?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuonglp1713",
"html_url": "https://github.com/cuonglp1713",
"followers_url": "https://api.github.com/users/cuonglp1713/followers",
"following_url": "https://api.github.com/users/cuonglp1713/following{/other_user}",
"gists_url": "https://api.github.com/users/cuonglp1713/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuonglp1713/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuonglp1713/subscriptions",
"organizations_url": "https://api.github.com/users/cuonglp1713/orgs",
"repos_url": "https://api.github.com/users/cuonglp1713/repos",
"events_url": "https://api.github.com/users/cuonglp1713/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuonglp1713/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"I realize that CPU memory leaked in every training step but I don't know why. I tried to change batch_size, num_workker, log_every_n_steps but nothing works. Anyone has an idea? @dimapihtar ",
"Hi, could you try to include these params to your run?\r\n`model.use_cpu_initialization=False`\r\n`model.cpu_offloading=False`",
"I added those 2 params to my script but the behavior is still the same @dimapihtar ",
"> I added those 2 params to my script but the behavior is still the same @dimapihtar\r\n\r\nI tried to run job with exactly the same config as you attached but I don't have this issue. Could you try to use newer 24.05 container? `nvcr.io/nvidia/nemo:24.05`\r\n",
"> I tried to run job with exactly the same config as you attached but I don't have this issue. Could you try to use newer 24.05 container? `nvcr.io/nvidia/nemo:24.05`\r\n\r\nThat's weird! I tried on 2 nemo version: nvcr.io/nvidia/nemo:24.03.framework and nvcr.io/nvidia/nemo:24.05.01 but the issue remains the same. I will try nvcr.io/nvidia/nemo:24.05 but I don't think it will be different",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale.",
"Did you run with `torchrun`? try to comment `mp.set_start_method(\"spawn\", force=True)` in the megatron_gpt_finetuning.py"
] | 2024-07-15T01:41:18 | 2024-09-06T07:25:25 | 2024-08-26T01:52:46 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Im training Llama3-8b with Nemo framework on 4 A100 80GB GPU. During training, my CPU RAM keeps increasing in every step and it consumed in buff/cache memory. My server has 2TB CPU RAM and it reached 100% with just 20 steps (my epoch has total 900 steps).
Edit: Both my shared and cache memory increase continuously.

Soon my training task will collap.
**Steps/Code to reproduce bug**
Here is my training script (https://docs.nvidia.com/nemo-framework/user-guide/latest/playbooks/llama2sft.html):
```
torchrun --nproc_per_node=4 \
/opt/NeMo/examples/nlp/language_modeling/tuning/megatron_gpt_finetuning.py \
trainer.devices=4 \
trainer.num_nodes=1 \
trainer.val_check_interval=50 \
trainer.max_epochs=1 \
trainer.max_steps=900 \
model.restore_from_path="my_model.nemo" \
model.micro_batch_size=1 \
model.global_batch_size=256 \
model.tensor_model_parallel_size=4 \
model.pipeline_model_parallel_size=1 \
model.megatron_amp_O2=True \
model.sequence_parallel=True \
model.activations_checkpoint_granularity=selective \
model.activations_checkpoint_method=uniform \
model.optim.name=distributed_fused_adam \
model.optim.lr=5e-6 \
model.answer_only_loss=True \
model.peft.peft_scheme=none \
model.data.train_ds.file_names="my_train_data.jsonl" \
model.data.validation_ds.file_names="my_val_data.jsonl" \
model.data.test_ds.file_names="my_test_data.jsonl" \
model.data.train_ds.concat_sampling_probabilities="[1]" \
model.data.train_ds.max_seq_length=8192 \
model.data.validation_ds.max_seq_length=8192 \
model.data.train_ds.micro_batch_size=1 \
model.data.train_ds.global_batch_size=256 \
model.data.validation_ds.micro_batch_size=1 \
model.data.validation_ds.global_batch_size=32 \
model.data.test_ds.micro_batch_size=1 \
model.data.test_ds.global_batch_size=32 \
+model.data.num_workers=4 \
model.data.validation_ds.metric.name=loss \
model.data.test_ds.metric.name=loss \
exp_manager.create_wandb_logger=False \
exp_manager.explicit_log_dir=results_v2 \
exp_manager.resume_if_exists=False \
exp_manager.resume_ignore_no_checkpoint=True \
exp_manager.create_checkpoint_callback=True \
exp_manager.checkpoint_callback_params.monitor=step \
exp_manager.checkpoint_callback_params.mode='max' \
exp_manager.checkpoint_callback_params.save_top_k=4 \
exp_manager.checkpoint_callback_params.save_best_model=True \
exp_manager.checkpoint_callback_params.save_nemo_on_train_end=True
```
**Environment overview**
Environment location: Nemo framework: nvcr.io/nvidia/nemo:24.03.01.framework
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9727/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9727/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9726 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9726/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9726/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9726/events | https://github.com/NVIDIA/NeMo/pull/9726 | 2,407,212,796 | PR_kwDOC_bI7s51Tq4f | 9,726 | Add option to convert PyTriton response to OpenAI format | {
"login": "athitten",
"id": 47577437,
"node_id": "MDQ6VXNlcjQ3NTc3NDM3",
"avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/athitten",
"html_url": "https://github.com/athitten",
"followers_url": "https://api.github.com/users/athitten/followers",
"following_url": "https://api.github.com/users/athitten/following{/other_user}",
"gists_url": "https://api.github.com/users/athitten/gists{/gist_id}",
"starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athitten/subscriptions",
"organizations_url": "https://api.github.com/users/athitten/orgs",
"repos_url": "https://api.github.com/users/athitten/repos",
"events_url": "https://api.github.com/users/athitten/events{/privacy}",
"received_events_url": "https://api.github.com/users/athitten/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-14T00:39:18 | 2024-07-18T15:57:48 | 2024-07-18T15:57:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9726",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9726",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9726.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9726.patch",
"merged_at": "2024-07-18T15:57:46"
} | # What does this PR do ?
1. Adds option to convert responses from PyTriton server to OpenAI compatible format.
2. Also adds `triton_request_timeout` and `openai_format_response` as user defined args which are then written to a json file along with `triton IP` and `triton port` to be accessed by `rest_model_api.py` (Deletes the existing `nemo/deploy/service/config.json` favor of these changes)
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9726/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9726/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9725 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9725/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9725/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9725/events | https://github.com/NVIDIA/NeMo/pull/9725 | 2,406,714,828 | PR_kwDOC_bI7s51SCdG | 9,725 | Fix missing parallelisms | {
"login": "maanug-nv",
"id": 109391026,
"node_id": "U_kgDOBoUssg",
"avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maanug-nv",
"html_url": "https://github.com/maanug-nv",
"followers_url": "https://api.github.com/users/maanug-nv/followers",
"following_url": "https://api.github.com/users/maanug-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions",
"organizations_url": "https://api.github.com/users/maanug-nv/orgs",
"repos_url": "https://api.github.com/users/maanug-nv/repos",
"events_url": "https://api.github.com/users/maanug-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/maanug-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"fixed base branch and target branch",
"I'd like to add this to main, but instead of manual copy use a function to copy all config attributes that end with _paralle_size. Made https://github.com/NVIDIA/NeMo/compare/main...akoumparouli/copy_parallel_size for this purpose. "
] | 2024-07-13T05:30:35 | 2024-07-23T17:56:05 | 2024-07-17T00:45:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9725",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9725",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9725.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9725.patch",
"merged_at": "2024-07-17T00:45:46"
} | # What does this PR do ?
CP and EP config values were not being passed to model parallel initialization methods.
**Collection**: [llm]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9725/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9725/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9724 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9724/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9724/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9724/events | https://github.com/NVIDIA/NeMo/pull/9724 | 2,406,379,746 | PR_kwDOC_bI7s51Q5bb | 9,724 | Update starthere docs text | {
"login": "erastorgueva-nv",
"id": 80532067,
"node_id": "MDQ6VXNlcjgwNTMyMDY3",
"avatar_url": "https://avatars.githubusercontent.com/u/80532067?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erastorgueva-nv",
"html_url": "https://github.com/erastorgueva-nv",
"followers_url": "https://api.github.com/users/erastorgueva-nv/followers",
"following_url": "https://api.github.com/users/erastorgueva-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/erastorgueva-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erastorgueva-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erastorgueva-nv/subscriptions",
"organizations_url": "https://api.github.com/users/erastorgueva-nv/orgs",
"repos_url": "https://api.github.com/users/erastorgueva-nv/repos",
"events_url": "https://api.github.com/users/erastorgueva-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/erastorgueva-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-07-12T21:36:20 | 2024-07-15T21:58:06 | 2024-07-15T21:58:05 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9724",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9724",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9724.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9724.patch",
"merged_at": "2024-07-15T21:58:05"
} | # What does this PR do ?
1-line update to docs
**Collection**: Docs
# Changelog
- 1-line update to docs
# Usage
N/A
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [N/A] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [N/A] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9724/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9724/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9723 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9723/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9723/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9723/events | https://github.com/NVIDIA/NeMo/pull/9723 | 2,406,331,930 | PR_kwDOC_bI7s51Qu50 | 9,723 | Remove mask if use fusion mask | {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"I don't want to set default to `False` since there are models not using FA or mask fusion. "
] | 2024-07-12T20:52:27 | 2024-07-15T16:28:03 | 2024-07-15T16:28:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9723",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9723",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9723.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9723.patch",
"merged_at": "2024-07-15T16:28:01"
} | # What does this PR do ?
Set create_attention_mask=False when we have mask in built-in modules like FlashAttention.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9723/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9723/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9722 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9722/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9722/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9722/events | https://github.com/NVIDIA/NeMo/pull/9722 | 2,405,997,171 | PR_kwDOC_bI7s51Pmd2 | 9,722 | Set TE flag in legacy -> mcore conversion script | {
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"#9585 was merged to the main branch two weeks ago so the release branch should already have the commit?",
"@cuichenx You're right, I'm actually surprised github said we could make this MR. When I look at the `0ec7e90` commit history for that conversion script it actually doesn't even show this commit. So the git history on the conversion script looks okay:\r\n\r\n\r\n"
] | 2024-07-12T16:59:54 | 2024-07-16T22:32:48 | 2024-07-12T17:05:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9722",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9722",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9722.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9722.patch",
"merged_at": "2024-07-12T17:05:01"
} | Same as #9585, but into release branch | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9722/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9722/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9721 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9721/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9721/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9721/events | https://github.com/NVIDIA/NeMo/pull/9721 | 2,405,947,323 | PR_kwDOC_bI7s51Pbig | 9,721 | refactor: notebook branch release | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-12T16:22:23 | 2024-08-03T01:49:19 | 2024-08-03T01:49:19 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9721",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9721",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9721.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9721.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9721/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9721/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9720 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9720/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9720/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9720/events | https://github.com/NVIDIA/NeMo/pull/9720 | 2,405,662,816 | PR_kwDOC_bI7s51OdLM | 9,720 | [NeMo-UX] Adding recipes | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"> Can we rename the directory `models` to `recipes`?\r\n> \r\n> Otherwise it's confusing why there's a mistral.py under both `collections/llm/gpt/model` and `collections/llm/models`. I don't have any strong preference as long as one of the two directories changes name.\r\n\r\nDone"
] | 2024-07-12T13:50:22 | 2024-07-23T16:14:03 | 2024-07-23T16:14:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9720",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9720",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9720.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9720.patch",
"merged_at": "2024-07-23T16:14:01"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9720/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9720/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9719 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9719/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9719/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9719/events | https://github.com/NVIDIA/NeMo/pull/9719 | 2,405,653,402 | PR_kwDOC_bI7s51ObG3 | 9,719 | [NeMo-UX] Adding recipies | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [] | 2024-07-12T13:45:34 | 2024-07-12T13:49:48 | 2024-07-12T13:49:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9719",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9719",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9719.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9719.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9719/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9719/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9718 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9718/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9718/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9718/events | https://github.com/NVIDIA/NeMo/pull/9718 | 2,405,644,605 | PR_kwDOC_bI7s51OZNR | 9,718 | Alit/r2.0.0 | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"PR that was merged to main: https://github.com/NVIDIA/NeMo/pull/9696/files"
] | 2024-07-12T13:40:53 | 2024-07-15T16:57:01 | 2024-07-15T16:56:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9718",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9718",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9718.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9718.patch",
"merged_at": "2024-07-15T16:56:59"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9718/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9718/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9717 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9717/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9717/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9717/events | https://github.com/NVIDIA/NeMo/pull/9717 | 2,405,605,724 | PR_kwDOC_bI7s51OQiJ | 9,717 | Run a sample query for a quantized model conditionally | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"CICD passed: https://github.com/NVIDIA/NeMo/actions/runs/10143611183\r\n\r\ncan merge once the review comments have been addressed (no need to re-run CI after that)"
] | 2024-07-12T13:22:19 | 2024-07-30T15:16:05 | 2024-07-30T15:16:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9717",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9717",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9717.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9717.patch",
"merged_at": "2024-07-30T15:16:03"
} | # What does this PR do ?
Adding a flag to run `_sample_output` in `Quantizer` on demand (defaults to `True`) as this step often hangs for a few minutes at (see [here](https://github.com/NVIDIA/NeMo/actions/runs/9895230553/job/27334855354)):
```
[NeMo I 2024-07-11 17:03:57 quantizer:182] Generating sample output for the model...
Loading extension modelopt_cuda_ext...
```
and this is to disable sample query in Github CI.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9717/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9717/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9716 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9716/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9716/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9716/events | https://github.com/NVIDIA/NeMo/pull/9716 | 2,405,589,827 | PR_kwDOC_bI7s51OM4I | 9,716 | fix legacy ds padding bug | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-12T13:16:35 | 2024-07-15T10:13:59 | 2024-07-15T10:13:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9716",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9716",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9716.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9716.patch",
"merged_at": "2024-07-15T10:13:57"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9716/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9716/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9715 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9715/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9715/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9715/events | https://github.com/NVIDIA/NeMo/pull/9715 | 2,405,575,543 | PR_kwDOC_bI7s51OJiw | 9,715 | Allows non-strict load with distributed checkpoints | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-12T13:12:50 | 2024-07-12T14:56:45 | 2024-07-12T14:56:43 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9715",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9715",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9715.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9715.patch",
"merged_at": "2024-07-12T14:56:43"
} | # What does this PR do ?
With distributed checkpoints, the mismatches between the runtime model and checkpoint model manifest during `dist_checkpoint.load` (not during `model.load_state_dict` as with regular checkpoints).
This PR adds a flag that allows to adjust load strictness (e.g. ignore unexpected keys).
This PR relies on MCore feature that is not merged yet (merge ETA 5th July): https://gitlab-master.nvidia.com/ADLR/megatron-lm/-/merge_requests/1628
**Collection**: NLP
# Changelog
- Add `model.dist_ckpt_load_strictness` flag to control dist ckpt load strictness. The most useful value is `log_all` which warns about all mismatches but performs the checkpoint load for a matching state dict subset.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9715/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9715/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9714 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9714/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9714/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9714/events | https://github.com/NVIDIA/NeMo/pull/9714 | 2,405,561,443 | PR_kwDOC_bI7s51OGSy | 9,714 | Resiliency features update | {
"login": "jbieniusiewi",
"id": 152396322,
"node_id": "U_kgDOCRViIg",
"avatar_url": "https://avatars.githubusercontent.com/u/152396322?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jbieniusiewi",
"html_url": "https://github.com/jbieniusiewi",
"followers_url": "https://api.github.com/users/jbieniusiewi/followers",
"following_url": "https://api.github.com/users/jbieniusiewi/following{/other_user}",
"gists_url": "https://api.github.com/users/jbieniusiewi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jbieniusiewi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jbieniusiewi/subscriptions",
"organizations_url": "https://api.github.com/users/jbieniusiewi/orgs",
"repos_url": "https://api.github.com/users/jbieniusiewi/repos",
"events_url": "https://api.github.com/users/jbieniusiewi/events{/privacy}",
"received_events_url": "https://api.github.com/users/jbieniusiewi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins"
] | 2024-07-12T13:08:31 | 2024-07-31T09:34:55 | 2024-07-31T09:34:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9714",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9714",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9714.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9714.patch",
"merged_at": "2024-07-31T09:34:53"
} | # What does this PR do ?
Changes for the updated version of resiliency features:
- Fault Tolerance
- Straggler Detection
**Collection**: [Note which collection this PR will affect]
# Changelog
- Updated/clarified documentation
- Removed duplicated "straggler detection" section from the documentation
- Updated straggler detection unit test
- Do not pass logger instance to the straggler det. callback
- Exposed `safety_factor` FT param
- Pass `exp_dir` to the FT callback
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "jbieniusiewi",
"id": 152396322,
"node_id": "U_kgDOCRViIg",
"avatar_url": "https://avatars.githubusercontent.com/u/152396322?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jbieniusiewi",
"html_url": "https://github.com/jbieniusiewi",
"followers_url": "https://api.github.com/users/jbieniusiewi/followers",
"following_url": "https://api.github.com/users/jbieniusiewi/following{/other_user}",
"gists_url": "https://api.github.com/users/jbieniusiewi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jbieniusiewi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jbieniusiewi/subscriptions",
"organizations_url": "https://api.github.com/users/jbieniusiewi/orgs",
"repos_url": "https://api.github.com/users/jbieniusiewi/repos",
"events_url": "https://api.github.com/users/jbieniusiewi/events{/privacy}",
"received_events_url": "https://api.github.com/users/jbieniusiewi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9714/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9714/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9713 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9713/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9713/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9713/events | https://github.com/NVIDIA/NeMo/pull/9713 | 2,405,315,313 | PR_kwDOC_bI7s51NQJy | 9,713 | [DRAFT] Lita refactor | {
"login": "Slyne",
"id": 6286804,
"node_id": "MDQ6VXNlcjYyODY4MDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6286804?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Slyne",
"html_url": "https://github.com/Slyne",
"followers_url": "https://api.github.com/users/Slyne/followers",
"following_url": "https://api.github.com/users/Slyne/following{/other_user}",
"gists_url": "https://api.github.com/users/Slyne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Slyne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Slyne/subscriptions",
"organizations_url": "https://api.github.com/users/Slyne/orgs",
"repos_url": "https://api.github.com/users/Slyne/repos",
"events_url": "https://api.github.com/users/Slyne/events{/privacy}",
"received_events_url": "https://api.github.com/users/Slyne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-12T11:02:51 | 2024-08-03T01:49:21 | 2024-08-03T01:49:20 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9713",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9713",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9713.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9713.patch",
"merged_at": null
} | # What does this PR do ?
Refactor LITA part
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9713/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9713/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9712 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9712/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9712/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9712/events | https://github.com/NVIDIA/NeMo/pull/9712 | 2,405,280,788 | PR_kwDOC_bI7s51NIiS | 9,712 | refactor: README | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-07-12T10:41:52 | 2024-07-15T16:26:20 | 2024-07-15T16:26:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9712",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9712",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9712.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9712.patch",
"merged_at": "2024-07-15T16:26:18"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9712/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9712/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9711 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9711/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9711/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9711/events | https://github.com/NVIDIA/NeMo/pull/9711 | 2,405,231,337 | PR_kwDOC_bI7s51M9hl | 9,711 | refactor: notebook branch release | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [] | 2024-07-12T10:13:39 | 2024-07-12T16:22:01 | 2024-07-12T16:21:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9711",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9711",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9711.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9711.patch",
"merged_at": "2024-07-12T16:21:58"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9711/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9711/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9710 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9710/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9710/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9710/events | https://github.com/NVIDIA/NeMo/pull/9710 | 2,405,227,950 | PR_kwDOC_bI7s51M8xo | 9,710 | refactor: Uniform BRANCH for notebooks | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-12T10:11:48 | 2024-07-12T16:21:19 | 2024-07-12T16:21:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9710",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9710",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9710.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9710.patch",
"merged_at": "2024-07-12T16:21:18"
} | # What does this PR do ?
Refactor Notebook `BRANCH = 'main'` to be uniformly the same across all notebooks
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9710/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9710/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9709 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9709/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9709/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9709/events | https://github.com/NVIDIA/NeMo/issues/9709 | 2,405,213,354 | I_kwDOC_bI7s6PXKSq | 9,709 | Not work even use the official docker when multiple GPU training LLM | {
"login": "hellangleZ",
"id": 15274284,
"node_id": "MDQ6VXNlcjE1Mjc0Mjg0",
"avatar_url": "https://avatars.githubusercontent.com/u/15274284?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hellangleZ",
"html_url": "https://github.com/hellangleZ",
"followers_url": "https://api.github.com/users/hellangleZ/followers",
"following_url": "https://api.github.com/users/hellangleZ/following{/other_user}",
"gists_url": "https://api.github.com/users/hellangleZ/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hellangleZ/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hellangleZ/subscriptions",
"organizations_url": "https://api.github.com/users/hellangleZ/orgs",
"repos_url": "https://api.github.com/users/hellangleZ/repos",
"events_url": "https://api.github.com/users/hellangleZ/events{/privacy}",
"received_events_url": "https://api.github.com/users/hellangleZ/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Same Error here",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-12T10:04:26 | 2024-09-05T01:55:11 | 2024-09-05T01:55:11 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | even I use 24.05.01, still stuck in this status

use another sft script which refer by official document is also not work by this error
https://docs.nvidia.com/nemo-framework/user-guide/latest/modelalignment/sft.html#step-2-sft-training
Traceback (most recent call last):
File "/opt/NeMo-Aligner/examples/nlp/gpt/train_gpt_sft.py", line 243, in
main()
File "/opt/NeMo/nemo/core/config/hydra_runner.py", line 129, in wrapper
_run_hydra(
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 394, in _run_hydra
_run_app(
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 457, in _run_app
run_and_report(
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 223, in run_and_report
raise ex
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 220, in run_and_report
return func()
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/utils.py", line 458, in
lambda: hydra.run(
File "/usr/local/lib/python3.10/dist-packages/hydra/_internal/hydra.py", line 132, in run
_ = ret.return_value
File "/usr/local/lib/python3.10/dist-packages/hydra/core/utils.py", line 260, in return_value
raise self._return_value
File "/usr/local/lib/python3.10/dist-packages/hydra/core/utils.py", line 186, in run_job
ret.return_value = task_function(task_cfg)
File "/opt/NeMo-Aligner/examples/nlp/gpt/train_gpt_sft.py", line 129, in main
ptl_model, updated_cfg = load_from_nemo(
File "/opt/NeMo-Aligner/nemo_aligner/utils/utils.py", line 98, in load_from_nemo
model = cls.restore_from(
File "/opt/NeMo/nemo/collections/nlp/models/nlp_model.py", line 465, in restore_from
return super().restore_from(
File "/opt/NeMo/nemo/core/classes/modelPT.py", line 464, in restore_from
instance = cls._save_restore_connector.restore_from(
File "/opt/NeMo-Aligner/nemo_aligner/utils/utils.py", line 51, in restore_from
return super().restore_from(*args, **kwargs)
File "/opt/NeMo/nemo/collections/nlp/parts/nlp_overrides.py", line 1172, in restore_from
checkpoint = checkpoint_io.load_checkpoint(tmp_model_weights_dir, sharded_state_dict=checkpoint)
File "/opt/NeMo/nemo/utils/callbacks/dist_ckpt_io.py", line 78, in load_checkpoint
return dist_checkpointing.load(
File "/opt/megatron-lm/megatron/core/dist_checkpointing/serialization.py", line 133, in load
validate_sharding_integrity(nested_values(sharded_state_dict))
File "/opt/megatron-lm/megatron/core/dist_checkpointing/serialization.py", line 425, in validate_sharding_integrity
torch.distributed.all_gather_object(all_sharding, sharding)
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/c10d_logger.py", line 75, in wrapper
return func(*args, *kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/distributed_c10d.py", line 2310, in all_gather_object
all_gather(object_size_list, local_size, group=group)
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/c10d_logger.py", line 75, in wrapper
return func(args, kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/distributed_c10d.py", line 2724, in all_gather
work = default_pg.allgather([tensor_list], [tensor])
torch.distributed.DistBackendError: NCCL error in: /opt/pytorch/pytorch/torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp:1961, internal error - please report this issue to the NCCL developers, NCCL version 2.19.3
ncclInternalError: Internal check failed.
Last error:
Attribute busid of node nic not found | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9709/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9709/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9708 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9708/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9708/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9708/events | https://github.com/NVIDIA/NeMo/pull/9708 | 2,404,813,547 | PR_kwDOC_bI7s51LiO6 | 9,708 | Gemma 2 | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-07-12T05:54:50 | 2024-08-19T16:39:14 | 2024-08-19T16:39:12 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9708",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9708",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9708.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9708.patch",
"merged_at": "2024-08-19T16:39:12"
} | # What does this PR do ?
Duplicate of #9587 for release branch
Also includes transformers version update from #9606
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [X] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9708/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9708/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9707 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9707/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9707/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9707/events | https://github.com/NVIDIA/NeMo/pull/9707 | 2,404,441,417 | PR_kwDOC_bI7s51KaIP | 9,707 | [NeMo-UX] Match nemo 1's default behavior for drop_last and pad_samples_to_global_batch_size | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-12T00:44:13 | 2024-07-16T16:27:07 | 2024-07-16T16:27:05 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9707",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9707",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9707.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9707.patch",
"merged_at": "2024-07-16T16:27:05"
} | This PR updates the default behavior of NeMo-UX's dataloader to match NeMo 1's. See https://github.com/NVIDIA/NeMo/blob/d4d03857f432a9248e6d58ecea12b17870e112eb/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py#L1552-L1579.
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9707/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9707/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9706 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9706/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9706/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9706/events | https://github.com/NVIDIA/NeMo/pull/9706 | 2,404,210,392 | PR_kwDOC_bI7s51JqVr | 9,706 | chore: Pin branch in notebooks | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-07-11T22:02:26 | 2024-07-26T08:40:49 | 2024-07-26T08:40:49 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9706",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9706",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9706.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9706.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9706/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9706/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9705 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9705/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9705/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9705/events | https://github.com/NVIDIA/NeMo/pull/9705 | 2,404,144,790 | PR_kwDOC_bI7s51Jbi8 | 9,705 | Integrate TRT-LLM v0.11 | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-11T21:19:13 | 2024-07-26T13:46:30 | 2024-07-26T13:46:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9705",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9705",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9705.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9705.patch",
"merged_at": "2024-07-26T13:46:30"
} | # What does this PR do ?
Integrates TRT-LLM v0.11 to nemo export module. | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9705/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9705/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9704 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9704/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9704/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9704/events | https://github.com/NVIDIA/NeMo/pull/9704 | 2,404,123,907 | PR_kwDOC_bI7s51JW9w | 9,704 | [TTS] Add fullband mel codec checkpoints | {
"login": "rlangman",
"id": 9942053,
"node_id": "MDQ6VXNlcjk5NDIwNTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rlangman",
"html_url": "https://github.com/rlangman",
"followers_url": "https://api.github.com/users/rlangman/followers",
"following_url": "https://api.github.com/users/rlangman/following{/other_user}",
"gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rlangman/subscriptions",
"organizations_url": "https://api.github.com/users/rlangman/orgs",
"repos_url": "https://api.github.com/users/rlangman/repos",
"events_url": "https://api.github.com/users/rlangman/events{/privacy}",
"received_events_url": "https://api.github.com/users/rlangman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-11T21:04:03 | 2024-07-11T21:32:40 | 2024-07-11T21:32:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9704",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9704",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9704.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9704.patch",
"merged_at": "2024-07-11T21:32:38"
} | # What does this PR do ?
Add fullband mel codec checkpoints to pretrained model list and documentation.
**Collection**: [TTS]
# Changelog
- Add documentation for fullband mel codec
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [] New Feature
- [ ] Bugfix
- [x] Documentation | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9704/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9704/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9703 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9703/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9703/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9703/events | https://github.com/NVIDIA/NeMo/pull/9703 | 2,403,909,658 | PR_kwDOC_bI7s51IrD4 | 9,703 | [NeMo-UX] Fix non-distributed optimizer save | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-11T19:12:25 | 2024-07-23T04:23:48 | 2024-07-15T16:03:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9703",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9703",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9703.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9703.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9703/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9703/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9702 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9702/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9702/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9702/events | https://github.com/NVIDIA/NeMo/pull/9702 | 2,403,883,594 | PR_kwDOC_bI7s51IlWF | 9,702 | [Nemo CICD] Add a bit more for timeout | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-11T18:55:43 | 2024-07-11T19:04:33 | 2024-07-11T19:04:31 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9702",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9702",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9702.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9702.patch",
"merged_at": "2024-07-11T19:04:31"
} | [Nemo CICD] Add a bit more for timeout | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9702/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9702/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9700 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9700/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9700/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9700/events | https://github.com/NVIDIA/NeMo/pull/9700 | 2,403,865,985 | PR_kwDOC_bI7s51Ihf- | 9,700 | add documentation for reset_lr feature | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-11T18:44:31 | 2024-08-02T01:50:31 | 2024-08-02T01:50:31 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9700",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9700",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9700.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9700.patch",
"merged_at": null
} | # What does this PR do ?
Adds a doc file for reset_lr feature.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9700/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9700/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9699 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9699/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9699/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9699/events | https://github.com/NVIDIA/NeMo/pull/9699 | 2,403,842,715 | PR_kwDOC_bI7s51IcTg | 9,699 | add dummy vision and text transformer config (assumed mcore to be false) | {
"login": "rohitrango",
"id": 15312514,
"node_id": "MDQ6VXNlcjE1MzEyNTE0",
"avatar_url": "https://avatars.githubusercontent.com/u/15312514?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rohitrango",
"html_url": "https://github.com/rohitrango",
"followers_url": "https://api.github.com/users/rohitrango/followers",
"following_url": "https://api.github.com/users/rohitrango/following{/other_user}",
"gists_url": "https://api.github.com/users/rohitrango/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rohitrango/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rohitrango/subscriptions",
"organizations_url": "https://api.github.com/users/rohitrango/orgs",
"repos_url": "https://api.github.com/users/rohitrango/repos",
"events_url": "https://api.github.com/users/rohitrango/events{/privacy}",
"received_events_url": "https://api.github.com/users/rohitrango/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@yaoyu-33 "
] | 2024-07-11T18:33:00 | 2024-07-22T16:29:33 | 2024-07-22T16:29:33 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9699",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9699",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9699.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9699.patch",
"merged_at": "2024-07-22T16:29:33"
} | # What does this PR do ?
Add parameters to CLIP model loading for SD training.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9699/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9699/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9698 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9698/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9698/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9698/events | https://github.com/NVIDIA/NeMo/pull/9698 | 2,403,816,725 | PR_kwDOC_bI7s51IWcW | 9,698 | Update the test checking for cooperative kernels in conditional nodes. | {
"login": "galv",
"id": 4767568,
"node_id": "MDQ6VXNlcjQ3Njc1Njg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4767568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/galv",
"html_url": "https://github.com/galv",
"followers_url": "https://api.github.com/users/galv/followers",
"following_url": "https://api.github.com/users/galv/following{/other_user}",
"gists_url": "https://api.github.com/users/galv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/galv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/galv/subscriptions",
"organizations_url": "https://api.github.com/users/galv/orgs",
"repos_url": "https://api.github.com/users/galv/repos",
"events_url": "https://api.github.com/users/galv/events{/privacy}",
"received_events_url": "https://api.github.com/users/galv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-11T18:21:08 | 2024-08-02T01:50:33 | 2024-08-02T01:50:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9698",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9698",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9698.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9698.patch",
"merged_at": null
} | Now we conditionally xfail only when a cuda driver version less than 12.5 is installed. CUDA 12.5 fixes this issue. Before it, cooperative kernels could not be used within the body of a conditional node.
Those internal can look at internal nvbug 4452698. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9698/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9698/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9697 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9697/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9697/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9697/events | https://github.com/NVIDIA/NeMo/pull/9697 | 2,403,703,882 | PR_kwDOC_bI7s51H8x0 | 9,697 | chore: Pin branch in notebooks | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-11T17:32:33 | 2024-07-11T22:02:05 | 2024-07-11T22:02:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9697",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9697",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9697.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9697.patch",
"merged_at": "2024-07-11T22:02:04"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9697/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9697/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9696 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9696/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9696/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9696/events | https://github.com/NVIDIA/NeMo/pull/9696 | 2,403,450,877 | PR_kwDOC_bI7s51HFC5 | 9,696 | Alit/mamba | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-11T15:14:03 | 2024-07-11T19:58:10 | 2024-07-11T19:58:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9696",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9696",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9696.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9696.patch",
"merged_at": "2024-07-11T19:58:08"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9696/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9696/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9695 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9695/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9695/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9695/events | https://github.com/NVIDIA/NeMo/issues/9695 | 2,403,416,388 | I_kwDOC_bI7s6PQTlE | 9,695 | Question: Which decoder are we supposed to use on parakeet-tdt_ctc-1.1b model? | {
"login": "anshulwadhawan",
"id": 25061477,
"node_id": "MDQ6VXNlcjI1MDYxNDc3",
"avatar_url": "https://avatars.githubusercontent.com/u/25061477?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/anshulwadhawan",
"html_url": "https://github.com/anshulwadhawan",
"followers_url": "https://api.github.com/users/anshulwadhawan/followers",
"following_url": "https://api.github.com/users/anshulwadhawan/following{/other_user}",
"gists_url": "https://api.github.com/users/anshulwadhawan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/anshulwadhawan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anshulwadhawan/subscriptions",
"organizations_url": "https://api.github.com/users/anshulwadhawan/orgs",
"repos_url": "https://api.github.com/users/anshulwadhawan/repos",
"events_url": "https://api.github.com/users/anshulwadhawan/events{/privacy}",
"received_events_url": "https://api.github.com/users/anshulwadhawan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"That is expected, currently we don't support getting timestamps from tdt/rnnt decoder, so if you are looking for timestamps you could get through CTC, however performance with CTC decoder is a bit degraded compared to tdt decoder but shouldn't be worse. \r\n\r\nI have created this space that gets timestamps from CTC and combines with output from TDT, It might help for your use case. https://huggingface.co/spaces/nvidia/parakeet-tdt_ctc-1.1b",
"Thanks for your answer, @nithinraok . Is getting timestamps from tdt decoding something that will be released later? ",
"Unfortunately, no plans for it yet! "
] | 2024-07-11T15:01:36 | 2024-08-01T15:01:23 | 2024-08-01T15:01:23 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | The default seems to be rnnt but it fails if we specify compute_timestamps=True in decoding config.
If I switch the decoder on this model to ctc, it works and also provides timestamps, but i see worse performace in terms of WERs. | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9695/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9695/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9694 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9694/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9694/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9694/events | https://github.com/NVIDIA/NeMo/pull/9694 | 2,403,384,599 | PR_kwDOC_bI7s51G2TT | 9,694 | [NeMo-UX] Fix imports so local configuration of runs works again | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-11T14:49:49 | 2024-07-15T16:32:17 | 2024-07-15T16:32:16 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9694",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9694",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9694.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9694.patch",
"merged_at": "2024-07-15T16:32:16"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9694/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9694/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9693 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9693/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9693/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9693/events | https://github.com/NVIDIA/NeMo/pull/9693 | 2,403,354,347 | PR_kwDOC_bI7s51Gvk4 | 9,693 | Updating num_weights check in unit_test of RETRO | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-11T14:38:18 | 2024-11-19T17:11:34 | 2024-08-02T01:50:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9693",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9693",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9693.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9693.patch",
"merged_at": null
} | Due to underlying changes in MLM mcore RETRO, the total number of parameters slightly changed.
We update the `assert num_weights ` accordingly in unit test for RETRO.
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9693/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9693/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9691 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9691/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9691/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9691/events | https://github.com/NVIDIA/NeMo/pull/9691 | 2,403,120,529 | PR_kwDOC_bI7s51F8S_ | 9,691 | [Nemo-UX] Including all trainable-params in a PEFT-checkpoint | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-11T12:56:30 | 2024-07-15T23:41:38 | 2024-07-15T23:41:36 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9691",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9691",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9691.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9691.patch",
"merged_at": "2024-07-15T23:41:36"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9691/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9691/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9690 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9690/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9690/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9690/events | https://github.com/NVIDIA/NeMo/pull/9690 | 2,403,115,008 | PR_kwDOC_bI7s51F7ET | 9,690 | [NeMo-UX] Fix imports so local configuration of runs works again | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-11T12:54:21 | 2024-07-11T14:49:23 | 2024-07-11T14:49:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9690",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9690",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9690.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9690.patch",
"merged_at": "2024-07-11T14:49:21"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9690/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9690/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9689 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9689/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9689/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9689/events | https://github.com/NVIDIA/NeMo/pull/9689 | 2,403,071,248 | PR_kwDOC_bI7s51Fxcr | 9,689 | NeVa::forward - remove device syncs (torch.where) and vectorize over batch dimensions | {
"login": "nikitaved",
"id": 1255244,
"node_id": "MDQ6VXNlcjEyNTUyNDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1255244?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nikitaved",
"html_url": "https://github.com/nikitaved",
"followers_url": "https://api.github.com/users/nikitaved/followers",
"following_url": "https://api.github.com/users/nikitaved/following{/other_user}",
"gists_url": "https://api.github.com/users/nikitaved/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nikitaved/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nikitaved/subscriptions",
"organizations_url": "https://api.github.com/users/nikitaved/orgs",
"repos_url": "https://api.github.com/users/nikitaved/repos",
"events_url": "https://api.github.com/users/nikitaved/events{/privacy}",
"received_events_url": "https://api.github.com/users/nikitaved/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@yaoyu-33 , could you please have another look and let the workflow be run?",
"FWIW, I ran our little test (a `neva_pretrain.py` invocation) with `NEMO_TESTING=1` and things ran fine there.",
"@yaoyu-33 , @ericharper , could you please run the workflow again? Thank you!",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"bump to kill 'stale'.\r\ni checked that i have access to an internal cluster today, will check convergence soon",
"Thanks you, @tfogal ! FWIW, the very last CI run turned out to be green",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"Is it possible to move it forward? Commenting to remove the current stale status.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"> Remove stale label or comment or update or this will be closed in 7 days.\r\n\r\ncomment",
"@yaoyu-33 , could you please enable the workflow so that we could merge it once the tests are green?",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"\"\r\nWait it out\r\nGonna wait it out\r\nWait it out (be patient)\r\n\" The Patient, Tool",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"Is there an interest in reviving this PR? I assume it is rather low impact with perf benefits assuming the tests are green. And green they were the last time CIs were run."
] | 2024-07-11T12:34:07 | 2024-11-30T08:52:30 | 2024-11-28T02:04:04 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9689",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9689",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9689.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9689.patch",
"merged_at": null
} | The following patch modifies the forward of the NeVa model (the `replace_media_embeddings` method) by introducing the following improvements:
- Elimination of `torch.where` with a single argument. That call introduces device synchronizations when run on GPUs.
- Media index selection manipulation in the construction of `padded_media_indices` can be done in a single vectorized call.
- Reduction in the overall number of kernel launches.
- Elimination of calls to `all`. This also causes device syncs. We can leave it, or run it in debug mode only. It is best to have a dedicated test instead of that assert, imho. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9689/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9689/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9688 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9688/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9688/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9688/events | https://github.com/NVIDIA/NeMo/pull/9688 | 2,403,002,440 | PR_kwDOC_bI7s51Figs | 9,688 | add auto configurator to NeMo | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 7079591682,
"node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio",
"name": "audio",
"color": "0DAAC3",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"General comment: NeMo uses google-style docstrings so please use that format.",
"This is already a big PR which in this particular case is OK I feel like since it's a port of functionality that exists in the launcher now. But it seems like it's not rebased correctly and therefore it contains many un-related changes. Can this be fixed @dimapihtar ?",
"> This is already a big PR which in this particular case is OK I feel like since it's a port of functionality that exists in the launcher now. But it seems like it's not rebased correctly and therefore it contains many un-related changes. Can this be fixed @dimapihtar ?\r\n\r\n@marcromeyn @ko3n1g \r\nno worries about that. It was my try to rebase PR to main branch but it still has a lot of conflicts so I've already created new one based on main branch. I keep this PR opened in order to not to miss @marcromeyn comments. I'll close this PR a bit later.\r\n\r\nNew PR:\r\nhttps://github.com/NVIDIA/NeMo/pull/10270"
] | 2024-07-11T11:59:34 | 2024-09-10T07:55:53 | 2024-09-10T07:55:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9688",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9688",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9688.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9688.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9688/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9688/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9687 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9687/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9687/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9687/events | https://github.com/NVIDIA/NeMo/pull/9687 | 2,402,834,960 | PR_kwDOC_bI7s51E9-Q | 9,687 | Release automation | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-11T10:29:12 | 2024-07-18T00:06:48 | 2024-07-18T00:06:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9687",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9687",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9687.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9687.patch",
"merged_at": "2024-07-18T00:06:48"
} | # What does this PR do ?
Adds two workflows:
* "NeMo Code freeze"
* "NeMo Code release"
# "NeMo Code freeze"
Started via workflow dispatch. Input is the next version number. Does the following:
* Reads $CURRENT_VERSION from main, check out new branch `r$CURRENT_VERSION` and pushes to origin and opens PR. Comments in that PR serve as platform for documenting changelog
* Bumps `package_info.py` with $NEXT_VERSION and pushes to `main`
# "NeMo Code release"
Started via comment to PR. Creates GH release/tag, builds and pushes the wheel, closes PR
# Additional Information
This automation requires a couple of secrets like Twine credentials or Personal Access Tokens. We an environment `main` and couple these secrets to it such that they are only exposed when running on that protected branch. Secrets are secure as only code-owners permit changes to `main` and on other branches the secrets are not interpolated. | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9687/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9687/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9686 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9686/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9686/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9686/events | https://github.com/NVIDIA/NeMo/issues/9686 | 2,402,831,506 | I_kwDOC_bI7s6POEyS | 9,686 | Add KV-Cache for MegatronLMEncoderDecoderModel | {
"login": "Kurokabe",
"id": 37635308,
"node_id": "MDQ6VXNlcjM3NjM1MzA4",
"avatar_url": "https://avatars.githubusercontent.com/u/37635308?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kurokabe",
"html_url": "https://github.com/Kurokabe",
"followers_url": "https://api.github.com/users/Kurokabe/followers",
"following_url": "https://api.github.com/users/Kurokabe/following{/other_user}",
"gists_url": "https://api.github.com/users/Kurokabe/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kurokabe/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kurokabe/subscriptions",
"organizations_url": "https://api.github.com/users/Kurokabe/orgs",
"repos_url": "https://api.github.com/users/Kurokabe/repos",
"events_url": "https://api.github.com/users/Kurokabe/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kurokabe/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale.",
"Hi @Kurokabe,\r\nThank you for pointing out. Indeed, T5 inference is not supporting KV_cache yet. \r\nWe have plans to support it in the future. However, as of now, we are having other priorities.\r\n \r\n"
] | 2024-07-11T10:27:21 | 2024-08-22T20:42:00 | 2024-08-22T01:52:52 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Is your feature request related to a problem? Please describe.**
I have been using the MegatronLMEncoderDecoderModel which seems to be the closest implementation for my need (encoder-decoder model), but when generating results (with the `decode` method), the generation becomes slower as it generates more tokens. My guess is that KV-Cache is not used for this model.
After a lot of digging, I found that the MegatronGPTModel uses for inference `set_inference_key_value_memory` and `inference_max_sequence_len`. I have tried to set `set_inference_key_value_memory=True` during the first decoding iteration, then to False, as well as providing only 1 token at a time, similar to `GPTModelTextGenerationStrategy` https://github.com/NVIDIA/NeMo/blob/900ca0b8bac3d038b9854bd498967b0525aaeb35/nemo/collections/nlp/modules/common/text_generation_strategy.py#L312-L327 , but I am faced with many issues, and the usage isn't straightforward.
To notice the generation speed decrease, you can wrap the for loop with tqdm:
```python
from tqdm.auto import tqdm
def decode(
self,
tokens_enc,
enc_mask,
num_tokens_to_generate,
encoder_input=None,
tokenizer=None,
enc_output=None,
enc_output_attn_mask=None,
ignore_ids=[],
bos_id=None, # If bos=None, will use tokenizer.bos_id unless explicitly set to something else.
predicted_tokens_dec=None,
batch_data=None,
sampling_method: str = "greedy-search",
sampling_kwargs: dict = {},
):
...
for i in tqdm(range(num_tokens_to_generate)):
```
**Describe the solution you'd like**
It would be nice if KV-Cache could be used for the MegatronLMEncoderDecoderModel, or provide a snippet of code to use the `decode` method without any slowdown during the generation.
**Describe alternatives you've considered**
`MegatronGPTModel` seems to uses the KV-Cache, but is a decoder only model. Since `MegatronGPTModel` uses internally (to the lower level) a `ParallelTransformer`, like the `MegatronTransformerEncoderModule` and `MegatronTransformerDecoderModule`, a parameter could be specified to `MegatronGPTModel` to enable cross attention inside it to be used like a decoder, with an encoder output specified
```python
def forward(
self,
input_ids,
position_ids,
attention_mask,
enc_output=None, # Add this input
loss_mask=None,
labels=None,
token_type_ids=None,
layer_past=None,
get_key_value=False,
forward_method_parallel_output=None,
encoder_input=None,
set_inference_key_value_memory=False,
inference_max_sequence_len=None,
checkpoint_activations_all_layers=None,
):
lm_output = self.language_model(
input_ids,
position_ids,
attention_mask,
encoder_output=encoder_output, # Add this
layer_past=layer_past,
get_key_value=get_key_value,
encoder_input=encoder_input,
set_inference_key_value_memory=set_inference_key_value_memory,
inference_max_sequence_len=inference_max_sequence_len,
checkpoint_activations_all_layers=checkpoint_activations_all_layers,
)
```
So that GPT model can be used with CrossAttention like [HuggingFace GPT2 model](https://github.com/huggingface/transformers/blob/6c1d0b069de22d7ed8aa83f733c25045eea0585d/src/transformers/models/gpt2/modeling_gpt2.py#L1091), because KV-Cache is implemented in `MegatronGPTModel.generate`
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9686/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9686/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9685 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9685/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9685/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9685/events | https://github.com/NVIDIA/NeMo/issues/9685 | 2,402,281,369 | I_kwDOC_bI7s6PL-eZ | 9,685 | RuntimeError: Error(s) in loading state_dict for MegaMolBARTModel after ANY fine tuning | {
"login": "nzsimonc",
"id": 6680265,
"node_id": "MDQ6VXNlcjY2ODAyNjU=",
"avatar_url": "https://avatars.githubusercontent.com/u/6680265?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nzsimonc",
"html_url": "https://github.com/nzsimonc",
"followers_url": "https://api.github.com/users/nzsimonc/followers",
"following_url": "https://api.github.com/users/nzsimonc/following{/other_user}",
"gists_url": "https://api.github.com/users/nzsimonc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nzsimonc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nzsimonc/subscriptions",
"organizations_url": "https://api.github.com/users/nzsimonc/orgs",
"repos_url": "https://api.github.com/users/nzsimonc/repos",
"events_url": "https://api.github.com/users/nzsimonc/events{/privacy}",
"received_events_url": "https://api.github.com/users/nzsimonc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"I have also run 'pytest test_megamolbart_triton.py' pointing that to my 'fine tuned' .nemo file and it gives me the same.\r\n\r\n======================================================================= short test summary info =======================================================================\r\nERROR test_megamolbart_triton.py::test_seq_to_embedding_triton - RuntimeError: Error(s) in loading state_dict for MegaMolBARTModel:\r\nERROR test_megamolbart_triton.py::test_seq_to_hidden_triton - RuntimeError: Error(s) in loading state_dict for MegaMolBARTModel:\r\nERROR test_megamolbart_triton.py::test_hidden_to_seqs_triton - RuntimeError: Error(s) in loading state_dict for MegaMolBARTModel:\r\nERROR test_megamolbart_triton.py::test_samplings_triton - RuntimeError: Error(s) in loading state_dict for MegaMolBARTModel:\r\nERROR test_megamolbart_triton.py::test_seq_to_embedding_direct - RuntimeError: Error(s) in loading state_dict for MegaMolBARTModel:\r\nERROR test_megamolbart_triton.py::test_seq_to_hidden_direct - RuntimeError: Error(s) in loading state_dict for MegaMolBARTModel:\r\nERROR test_megamolbart_triton.py::test_hidden_to_seqs_direct - RuntimeError: Error(s) in loading state_dict for MegaMolBARTModel:\r\nERROR test_megamolbart_triton.py::test_samplings_direct - RuntimeError: Error(s) in loading state_dict for MegaMolBARTModel:\r\n========================================================================= 8 errors in 27.01s ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-11T05:27:52 | 2024-08-19T01:52:43 | 2024-08-19T01:52:43 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
I can successfully run my inference code on the default megamolbart.nemo, but as soon as I run any kind of fine tuning on it then I get the error RuntimeError: Error(s) in loading state_dict for MegaMolBARTModel. I've attached code, config and output for both finetune and infer stages.
My desired outcome is to use the finetuning process to add in some of my own data, then call the inference code to get the SMILES string and the prediction.
**Steps/Code to reproduce bug**
**1. FineTune - code, config and output**
Actually I get the same issue if I take trainer.fit(model) out of the code as well. My Fine Tune Code (company1.6_finetune_donothing.py.txt) just loads the default megamolbart.nemo using finetune_config.yaml.txt (doesn't alter anything if restore_from_path is filled in or not).
The Result (company1.6_finetune_donothing_RESULT.txt) seems fine.
[company1.6_finetune_donothing.py.txt](https://github.com/user-attachments/files/16171757/company1.6_finetune_donothing.py.txt)
[finetune_config.yaml.txt](https://github.com/user-attachments/files/16171759/finetune_config.yaml.txt)
[company1.6_finetune_donothing_RESULT.txt](https://github.com/user-attachments/files/16171760/company1.6_finetune_donothing_RESULT.txt)
**2. Infer - code, config and output**
I then run my infer code (company1.6_infer.py.txt) with the default infer.yaml file (infer.yaml.txt) with just the restore_from_path pointing to the file created in Step 1. NOTE: as can be seen in the 'Expected behavior' section, if I use the default megamolbart.nemo file then it all works as expected.
[company1.6_infer.py.txt](https://github.com/user-attachments/files/16171785/company1.6_infer.py.txt)
[infer.yaml.txt](https://github.com/user-attachments/files/16171786/infer.yaml.txt)
[company1.6_infer_RESULT.txt](https://github.com/user-attachments/files/16171788/company1.6_infer_RESULT.txt)
**TLDR;**
This is my error:
[NeMo I 2024-07-11 01:57:35 regex_tokenizer:254] Loading regex from file = /workspace/bionemo/tokenizers/molecule/megamolbart/vocab/megamolbart.model
[NeMo I 2024-07-11 01:57:35 megatron_base_model:315] Padded vocab_size: 640, original vocab_size: 523, dummy tokens: 117.
[NeMo W 2024-07-11 01:57:35 megatron_lm_encoder_decoder_model:240] Could not find encoder or decoder in config. This is probably because of restoring an old checkpoint. Copying shared model configs to encoder and decoder configs.
[NeMo W 2024-07-11 01:57:35 megatron_lm_encoder_decoder_model:206] bias_gelu_fusion is deprecated. Please use bias_activation_fusion instead.
[NeMo W 2024-07-11 01:57:35 megatron_lm_encoder_decoder_model:206] bias_gelu_fusion is deprecated. Please use bias_activation_fusion instead.
Traceback (most recent call last):
File "/workspace/bionemo/examples/molecule/megamolbart/company1.6_infer.py", line 59, in <module>
inferer = load_model_for_inference(cfg, interactive=True)
File "/workspace/bionemo/bionemo/triton/utils.py", line 238, in load_model_for_inference
model = infer_class(cfg, interactive=interactive, **kwargs)
File "/workspace/bionemo/bionemo/model/molecule/infer.py", line 40, in __init__
super().__init__(
File "/workspace/bionemo/bionemo/model/core/infer.py", line 468, in __init__
super().__init__(
File "/workspace/bionemo/bionemo/model/core/infer.py", line 146, in __init__
self.model = self.load_model(cfg, model=model, restore_path=restore_path, strict=strict_restore_from_path)
File "/workspace/bionemo/bionemo/model/core/infer.py", line 206, in load_model
model = restore_model(
File "/workspace/bionemo/bionemo/model/utils.py", line 363, in restore_model
model = model_cls.restore_from(
File "/usr/local/lib/python3.10/dist-packages/nemo/collections/nlp/models/nlp_model.py", line 465, in restore_from
return super().restore_from(
File "/usr/local/lib/python3.10/dist-packages/nemo/core/classes/modelPT.py", line 442, in restore_from
instance = cls._save_restore_connector.restore_from(
File "/usr/local/lib/python3.10/dist-packages/nemo/collections/nlp/parts/nlp_overrides.py", line 751, in restore_from
super().load_instance_with_state_dict(instance, state_dict, strict)
File "/usr/local/lib/python3.10/dist-packages/nemo/core/connectors/save_restore_connector.py", line 203, in load_instance_with_state_dict
instance.load_state_dict(state_dict, strict=strict)
File "/usr/local/lib/python3.10/dist-packages/nemo/collections/nlp/models/nlp_model.py", line 447, in load_state_dict
results = super(NLPModel, self).load_state_dict(state_dict, strict=strict)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 2152, in load_state_dict
raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for MegaMolBARTModel:
Missing key(s) in state_dict: "enc_dec_model.encoder_embedding.word_embeddings.weight", "enc_dec_model.encoder_embedding.position_embeddings.weight", "enc_dec_model.decoder_embedding.word_embeddings.weight", "enc_dec_model.decoder_embedding.position_embeddings.weight", "enc_dec_model.enc_dec_model.encoder.model.layers.0.input_layernorm.weight", "enc_dec_model.enc_dec_model.encoder.model.layers.0.input_layernorm.bias", "enc_dec_model.enc_dec_model.encoder.model.layers.0.self_attention.query_key_value.weight", "enc_dec_model.enc_dec_model.encoder.model.layers.0.self_attention.query_key_value.bias", "enc_dec_model.enc_dec_model.encoder.model.layers.0.self_attention.dense.weight",
**Expected behavior**
Run the Inference code using the default downloadable megamolbart.nemo and it works fine as can be seen here:
[company1.6_infer_RESULT_DEFAULT_NEMO.txt](https://github.com/user-attachments/files/16171714/company1.6_infer_RESULT_DEFAULT_NEMO.txt)
aka we can get simple things like Reconstructed SMILES: from the system.
**Environment overview (please complete the following information)**
- Environment location: Azure
- Method of NeMo install: Docker
- If method of install is [Docker], provide `docker pull` & `docker run` commands used:
docker run -it --rm --gpus all -v /home/azureuser/company_info:/workspace/bionemo/company_info nvcr.io/nvidia/clara/bionemo-framework:1.3 bash
also tried
docker run -it --rm --gpus all -v /home/azureuser/company_info:/workspace/bionemo/company_info nvcr.io/nvidia/clara/bionemo-framework:1.6 bash
**Environment details**
NVIDIA docker image is used
**Additional context**
Azure T4 GPU | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9685/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9685/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9684 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9684/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9684/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9684/events | https://github.com/NVIDIA/NeMo/pull/9684 | 2,402,263,392 | PR_kwDOC_bI7s51DBtt | 9,684 | Cherry pick: LITA Integration | {
"login": "Slyne",
"id": 6286804,
"node_id": "MDQ6VXNlcjYyODY4MDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6286804?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Slyne",
"html_url": "https://github.com/Slyne",
"followers_url": "https://api.github.com/users/Slyne/followers",
"following_url": "https://api.github.com/users/Slyne/following{/other_user}",
"gists_url": "https://api.github.com/users/Slyne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Slyne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Slyne/subscriptions",
"organizations_url": "https://api.github.com/users/Slyne/orgs",
"repos_url": "https://api.github.com/users/Slyne/repos",
"events_url": "https://api.github.com/users/Slyne/events{/privacy}",
"received_events_url": "https://api.github.com/users/Slyne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"CI passed: https://github.com/NVIDIA/NeMo/actions/runs/9895230553",
"CI passed: https://github.com/NVIDIA/NeMo/actions/runs/9895230553\r\n\r\n"
] | 2024-07-11T05:10:57 | 2024-07-11T23:18:09 | 2024-07-11T23:18:08 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9684",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9684",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9684.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9684.patch",
"merged_at": "2024-07-11T23:18:08"
} | # What does this PR do ?
To cherry pick https://github.com/NVIDIA/NeMo/pull/9578 LITA integration into 2.0.0rc1. That PR was already merged. See details there.
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
NLP and multimodal
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [X] Did you write any new necessary tests?
- [X] Did you add or update any necessary documentation?
- [X] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [X] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9684/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9684/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9683 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9683/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9683/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9683/events | https://github.com/NVIDIA/NeMo/pull/9683 | 2,402,255,074 | PR_kwDOC_bI7s51C__w | 9,683 | [NeMo-UX] Added Megatron loss function and LR scheduler | {
"login": "ahmadki",
"id": 8809320,
"node_id": "MDQ6VXNlcjg4MDkzMjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/8809320?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ahmadki",
"html_url": "https://github.com/ahmadki",
"followers_url": "https://api.github.com/users/ahmadki/followers",
"following_url": "https://api.github.com/users/ahmadki/following{/other_user}",
"gists_url": "https://api.github.com/users/ahmadki/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ahmadki/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ahmadki/subscriptions",
"organizations_url": "https://api.github.com/users/ahmadki/orgs",
"repos_url": "https://api.github.com/users/ahmadki/repos",
"events_url": "https://api.github.com/users/ahmadki/events{/privacy}",
"received_events_url": "https://api.github.com/users/ahmadki/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-11T05:03:08 | 2024-08-13T01:52:46 | 2024-08-13T01:52:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9683",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9683",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9683.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9683.patch",
"merged_at": null
} | # What does this PR do ?
The PR adds Megatron loss function and LR scheduler for GPT pretrain.
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
LLM
# Changelog
- Parametrized GPT model loss function
- Added `MegatronAnnealing` learning rate and weight decay scheduler
- Added `MegatronMaskedTokenLossReduction` loss function
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ x] New Feature
- [ x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9683/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9683/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9682 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9682/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9682/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9682/events | https://github.com/NVIDIA/NeMo/pull/9682 | 2,402,143,630 | PR_kwDOC_bI7s51Cobl | 9,682 | Speeds up copying of necessary artifact files with SaveRestoreConnector | {
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"I'm looking into the test failures. Very bizarre since running the complete suite locally hangs and I cannot reproduce the failures by running the failed cases individually",
"I figured out the test failure issue. It turned out in my unit test I `os.chdir` into a temporary directory and don't `os.chdir` back into the CWD. This causes failures for tests in different scopes. So I wasn't seeing the issue when running just the failed tests by themselves, but instead saw it only when running the entire suite together."
] | 2024-07-11T03:13:08 | 2024-07-17T18:42:06 | 2024-07-17T18:42:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9682",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9682",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9682.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9682.patch",
"merged_at": "2024-07-17T18:42:04"
} | # What does this PR do ?
Previously, the SaveRestoreConnector would copy and untar entire
checkpoints just to copy out a tokenizer. For models in the >100GB, this
led to timeouts since only rank=0 did this work, while other ranks moved
on and waited at an all-gather barrier (observed NCCL timeout at 10min).
Revision of #9299 that keeps most of the core logic surrounding tempdir creation | {
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9682/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9682/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9681 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9681/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9681/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9681/events | https://github.com/NVIDIA/NeMo/pull/9681 | 2,401,873,541 | PR_kwDOC_bI7s51BtW0 | 9,681 | Fix few issues and docs for neva and clip in r2.0.0rc1 | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"LGTM. Thanks.\r\n"
] | 2024-07-10T22:55:49 | 2024-07-19T18:02:10 | 2024-07-19T18:02:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9681",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9681",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9681.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9681.patch",
"merged_at": "2024-07-19T18:02:08"
} | # What does this PR do ?
Fix few issues and docs for neva and clip in r2.0.0rc1
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9681/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9681/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9680 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9680/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9680/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9680/events | https://github.com/NVIDIA/NeMo/pull/9680 | 2,401,872,525 | PR_kwDOC_bI7s51BtIU | 9,680 | Fix few issues and docs for neva and clip in r2.0.0rc1 | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [] | 2024-07-10T22:54:32 | 2024-07-10T22:55:15 | 2024-07-10T22:55:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9680",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9680",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9680.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9680.patch",
"merged_at": null
} | # What does this PR do ?
Fix few issues and docs for neva and clip in r2.0.0rc1
**Collection**: [docs, multimodal]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9680/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9680/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9679 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9679/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9679/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9679/events | https://github.com/NVIDIA/NeMo/pull/9679 | 2,401,845,562 | PR_kwDOC_bI7s51BnHq | 9,679 | Adding support for mcore T5 Eval - SFT - PEFT | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-10T22:28:23 | 2024-07-12T04:59:51 | 2024-07-12T04:59:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9679",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9679",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9679.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9679.patch",
"merged_at": "2024-07-12T04:59:49"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9679/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9679/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9678 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9678/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9678/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9678/events | https://github.com/NVIDIA/NeMo/pull/9678 | 2,401,785,011 | PR_kwDOC_bI7s51BZnu | 9,678 | Fix for `train.controlnet.controlnet_v1_5_1node_100steps` | {
"login": "rohitrango",
"id": 15312514,
"node_id": "MDQ6VXNlcjE1MzEyNTE0",
"avatar_url": "https://avatars.githubusercontent.com/u/15312514?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rohitrango",
"html_url": "https://github.com/rohitrango",
"followers_url": "https://api.github.com/users/rohitrango/followers",
"following_url": "https://api.github.com/users/rohitrango/following{/other_user}",
"gists_url": "https://api.github.com/users/rohitrango/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rohitrango/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rohitrango/subscriptions",
"organizations_url": "https://api.github.com/users/rohitrango/orgs",
"repos_url": "https://api.github.com/users/rohitrango/repos",
"events_url": "https://api.github.com/users/rohitrango/events{/privacy}",
"received_events_url": "https://api.github.com/users/rohitrango/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-07-10T21:36:10 | 2024-07-31T22:12:04 | 2024-07-31T22:12:04 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9678",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9678",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9678.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9678.patch",
"merged_at": "2024-07-31T22:12:04"
} | # What does this PR do ?
Fixes `train.controlnet.controlnet_v1_5_1node_100steps` CI test.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Victor49152",
"id": 111467530,
"node_id": "U_kgDOBqTcCg",
"avatar_url": "https://avatars.githubusercontent.com/u/111467530?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Victor49152",
"html_url": "https://github.com/Victor49152",
"followers_url": "https://api.github.com/users/Victor49152/followers",
"following_url": "https://api.github.com/users/Victor49152/following{/other_user}",
"gists_url": "https://api.github.com/users/Victor49152/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Victor49152/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Victor49152/subscriptions",
"organizations_url": "https://api.github.com/users/Victor49152/orgs",
"repos_url": "https://api.github.com/users/Victor49152/repos",
"events_url": "https://api.github.com/users/Victor49152/events{/privacy}",
"received_events_url": "https://api.github.com/users/Victor49152/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9678/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9678/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9677 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9677/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9677/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9677/events | https://github.com/NVIDIA/NeMo/pull/9677 | 2,401,765,729 | PR_kwDOC_bI7s51BVhN | 9,677 | Huvu/mcore t5 | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-10T21:21:00 | 2024-07-11T16:15:43 | 2024-07-11T16:15:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9677",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9677",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9677.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9677.patch",
"merged_at": "2024-07-11T16:15:41"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9677/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9677/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9676 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9676/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9676/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9676/events | https://github.com/NVIDIA/NeMo/pull/9676 | 2,401,762,619 | PR_kwDOC_bI7s51BU9N | 9,676 | Enabling bias_dropout_add_fused with no bias term | {
"login": "ashvinnihalani",
"id": 20451958,
"node_id": "MDQ6VXNlcjIwNDUxOTU4",
"avatar_url": "https://avatars.githubusercontent.com/u/20451958?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashvinnihalani",
"html_url": "https://github.com/ashvinnihalani",
"followers_url": "https://api.github.com/users/ashvinnihalani/followers",
"following_url": "https://api.github.com/users/ashvinnihalani/following{/other_user}",
"gists_url": "https://api.github.com/users/ashvinnihalani/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashvinnihalani/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashvinnihalani/subscriptions",
"organizations_url": "https://api.github.com/users/ashvinnihalani/orgs",
"repos_url": "https://api.github.com/users/ashvinnihalani/repos",
"events_url": "https://api.github.com/users/ashvinnihalani/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashvinnihalani/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@yaoyu-33 ",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-10T21:18:49 | 2024-08-16T01:51:28 | 2024-08-16T01:51:27 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9676",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9676",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9676.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9676.patch",
"merged_at": null
} | # What does this PR do ?
Specific LLM/VLM hang when using specific PP settings and with the bias term is set to false hang. By enabling a fused dropout_add_fused we should fix this problem as well as speed up training of LLM/VLM that do not have the bias term
**Collection**: nlp
# Changelog
- Add specific line by line info of high level changes in this PR.
- nemo/collections/nlp/modules/common/megatron/transformer.py - Enabling the bias_dropout_add_fusion to be used for both bias and non bias enabled
- nemo/collections/nlp/modules/common/megatron/fused_bias_dropout_add.py - Check whether the bias term is there and choose relevant fused function
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [N/A] Did you write any new necessary tests?
- [ X] Did you add or update any necessary documentation?
- [N/A] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [N/A] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [N/A] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #6396
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9676/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9676/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9675 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9675/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9675/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9675/events | https://github.com/NVIDIA/NeMo/pull/9675 | 2,401,444,216 | PR_kwDOC_bI7s51AU8N | 9,675 | Release `2.0.0rc1` | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-10T18:54:12 | 2024-07-10T19:05:39 | 2024-07-10T19:05:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9675",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9675",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9675.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9675.patch",
"merged_at": null
} | 🚀 PR to release NeMo `2.0.0rc1`.
📝 Please remember the following to-do's before merge:
- [ ] Fill-in the comment `Highlights`
- [ ] Review the comment `Detailed Changelogs`
🚨 Please also keep in mind to _not_ delete the headings of the task commits. They are required by the post-merge automation.
🙏 Please merge this PR only if the CI workflow completed successfully. | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9675/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9675/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9674 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9674/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9674/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9674/events | https://github.com/NVIDIA/NeMo/pull/9674 | 2,401,434,729 | PR_kwDOC_bI7s51AS0m | 9,674 | [NeMo-UX] Make 'load_directly_on_device' configurable | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-10T18:48:22 | 2024-07-16T02:16:12 | 2024-07-16T02:16:10 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9674",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9674",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9674.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9674.patch",
"merged_at": "2024-07-16T02:16:10"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9674/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9674/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9673 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9673/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9673/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9673/events | https://github.com/NVIDIA/NeMo/issues/9673 | 2,401,434,006 | I_kwDOC_bI7s6PIvmW | 9,673 | Util for measuring MFU? | {
"login": "dementrock",
"id": 784063,
"node_id": "MDQ6VXNlcjc4NDA2Mw==",
"avatar_url": "https://avatars.githubusercontent.com/u/784063?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dementrock",
"html_url": "https://github.com/dementrock",
"followers_url": "https://api.github.com/users/dementrock/followers",
"following_url": "https://api.github.com/users/dementrock/following{/other_user}",
"gists_url": "https://api.github.com/users/dementrock/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dementrock/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dementrock/subscriptions",
"organizations_url": "https://api.github.com/users/dementrock/orgs",
"repos_url": "https://api.github.com/users/dementrock/repos",
"events_url": "https://api.github.com/users/dementrock/events{/privacy}",
"received_events_url": "https://api.github.com/users/dementrock/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"We will add support for this in this repo: computing Model Flops Utilization. \r\nOur team has this task in the backlog and will be working on it.",
"@dementrock I'll be adding this support this week. Any particular model(s) that you are looking at? \r\n@ericharper Could you assign this to me?",
"@ericharper can you help review and merge this PR- #9735?",
"@malay-nagda thanks a lot! Support for the common models like llama / mistral would be sufficient for us for now",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days."
] | 2024-07-10T18:48:02 | 2024-08-23T23:08:59 | 2024-08-23T23:08:59 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | We'd like to track model flops utilization (MFU) during training. Is there any pointers for how to do this or would it be possible to add support for this within NeMo? | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9673/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9673/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9672 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9672/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9672/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9672/events | https://github.com/NVIDIA/NeMo/pull/9672 | 2,401,416,015 | PR_kwDOC_bI7s51AOq1 | 9,672 | Gemma 2 | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Hi! Thank you for your work!\r\n\r\nWhen continue pretrain the model using your updated gemma-related code, I found that _**the initial loss is around 9.x**_, while _**hf was about 2.x**_. Are there still some differences that are not aligned?\r\n",
"> Hi! Thank you for your work!\r\n> \r\n> When continue pretrain the model using your updated gemma-related code, I found that _**the initial loss is around 9.x**_, while _**hf was about 2.x**_. Are there still some differences that are not aligned?\r\n\r\nHi @Emperorizzis, thanks for your interest! It should work the same as HF but there could be a bug somewhere. Do you mind sharing your config and/or run command? ",
"> > Hi! Thank you for your work!\r\n> > When continue pretrain the model using your updated gemma-related code, I found that _**the initial loss is around 9.x**_, while _**hf was about 2.x**_. Are there still some differences that are not aligned?\r\n> \r\n> Hi @Emperorizzis, thanks for your interest! It should work the same as HF but there could be a bug somewhere. Do you mind sharing your config and/or run command?\r\n\r\n Hi @cuichenx, I used your modeling file, as well as the native megatron (f3a3020031f384ddafd9b7e9f3a587798c0aea21) for training (with a few additional arguments). Below are my megatron arguments configuration during training:\r\n\r\n```\r\n------------------------ arguments ------------------------\r\n accumulate_allreduce_grads_in_fp32 .............. True\r\n adam_beta1 ...................................... 0.9\r\n adam_beta2 ...................................... 0.95\r\n adam_eps ........................................ 1e-08\r\n adaptive_seq_len ................................ False\r\n add_bias_attn_fc ................................ True\r\n add_bias_linear ................................. False\r\n add_bias_linear_fc .............................. True\r\n add_position_embedding .......................... True\r\n add_qkv_bias .................................... False\r\n adlr_autoresume ................................. False\r\n adlr_autoresume_interval ........................ 1000\r\n apply_layernorm_1p .............................. True\r\n apply_query_key_layer_scaling ................... False\r\n apply_residual_connection_post_layernorm ........ False\r\n apply_rope_fusion ............................... False\r\n async_tensor_model_parallel_allreduce ........... False\r\n attention_dropout ............................... 0.0\r\n attention_head_type ............................. None\r\n attention_softmax_in_fp32 ....................... False\r\n auto_detect_ckpt_format ......................... False\r\n barrier_with_L1_time ............................ True\r\n bert_binary_head ................................ True\r\n bert_embedder_type .............................. megatron\r\n bert_load ....................................... None\r\n bf16 ............................................ True\r\n bias_dropout_fusion ............................. True\r\n bias_gelu_fusion ................................ False\r\n bias_swiglu_fusion .............................. True\r\n biencoder_projection_dim ........................ 0\r\n biencoder_shared_query_context_model ............ False\r\n block_data_path ................................. None\r\n check_for_nan_in_loss_and_grad .................. True\r\n ckpt_fully_parallel_save ........................ False\r\n ckpt_step ....................................... None\r\n classes_fraction ................................ 1.0\r\n clip_grad ....................................... 1.0\r\n clone_scatter_output_in_embedding ............... True\r\n consumed_train_samples .......................... 0\r\n consumed_valid_samples .......................... 0\r\n context_parallel_size ........................... 1\r\n create_attention_mask_in_dataloader ............. True\r\n cvcuda_image_processing ......................... False\r\n data_cache_path ................................. None\r\n data_dir ........................................ None\r\n data_impl ....................................... mmap\r\n data_parallel_random_init ....................... False\r\n data_parallel_size .............................. 2\r\n data_path ....................................... ['/basedir/mcore_data/gemma2/testing/testing']\r\n data_per_class_fraction ......................... 1.0\r\n data_sharding ................................... True\r\n dataloader_type ................................. single\r\n dataset ......................................... None\r\n decoder_num_layers .............................. None\r\n decoder_seq_length .............................. None\r\n decoupled_lr .................................... None\r\n decoupled_min_lr ................................ None\r\n delay_grad_reduce ............................... True\r\n delay_param_gather .............................. False\r\n dino_bottleneck_size ............................ 256\r\n dino_freeze_last_layer .......................... 1\r\n dino_head_hidden_size ........................... 2048\r\n dino_local_crops_number ......................... 10\r\n dino_local_img_size ............................. 96\r\n dino_norm_last_layer ............................ False\r\n dino_teacher_temp ............................... 0.07\r\n dino_warmup_teacher_temp ........................ 0.04\r\n dino_warmup_teacher_temp_epochs ................. 30\r\n dist_ckpt_format ................................ torch_dist\r\n distribute_saved_activations .................... False\r\n distributed_backend ............................. nccl\r\n distributed_timeout_minutes ..................... 60\r\n dummy_load ...................................... \r\n embed_layernorm ................................. False\r\n embedding_path .................................. None\r\n empty_unused_memory_level ....................... 0\r\n enable_one_logger ............................... False\r\n enable_parallel_output .......................... True\r\n enable_shared_expert ............................ False\r\n encoder_num_layers .............................. 42\r\n encoder_seq_length .............................. 64\r\n end_weight_decay ................................ 0.1\r\n eod_mask_loss ................................... False\r\n epochs .......................................... None\r\n eval_dev ........................................ False\r\n eval_fp32 ....................................... False\r\n eval_interval ................................... 1000000000\r\n eval_iters ...................................... 1\r\n evidence_data_path .............................. None\r\n exit_duration_in_mins ........................... None\r\n exit_interval ................................... None\r\n exit_on_missing_checkpoint ...................... False\r\n exit_signal_handler ............................. False\r\n expert_interval ................................. 2\r\n expert_model_parallel_size ...................... 1\r\n expert_tensor_parallelism ....................... False\r\n extra_vocab_size ................................ 0\r\n ffn_hidden_size ................................. 14336\r\n finetune ........................................ False\r\n fp16 ............................................ False\r\n fp16_lm_cross_entropy ........................... False\r\n fp32_residual_connection ........................ False\r\n fp8 ............................................. None\r\n fp8_amax_compute_algo ........................... most_recent\r\n fp8_amax_history_len ............................ 1\r\n fp8_interval .................................... 1\r\n fp8_margin ...................................... 0\r\n fp8_wgrad ....................................... True\r\n freeze_clip_vision_tower ........................ False\r\n freeze_llm ...................................... False\r\n generation_length ............................... None\r\n global_batch_size ............................... 8\r\n glu_activation .................................. None\r\n gradient_accumulation_fusion .................... True\r\n group_query_attention ........................... True\r\n head_lr_mult .................................... 1.0\r\n hidden_dropout .................................. 0.0\r\n hidden_size ..................................... 3584\r\n hysteresis ...................................... 2\r\n ict_head_size ................................... None\r\n ict_load ........................................ None\r\n image_aspect_ratio .............................. square\r\n image_folder .................................... \r\n image_size ...................................... None\r\n img_h ........................................... 224\r\n img_w ........................................... 224\r\n indexer_batch_size .............................. 128\r\n indexer_log_interval ............................ 1000\r\n inference_batch_times_seqlen_threshold .......... 512\r\n init_method_std ................................. 0.02\r\n init_method_xavier_uniform ...................... False\r\n initial_loss_scale .............................. 4294967296\r\n input_len ....................................... 1\r\n intermediate_size ............................... None\r\n iter_per_epoch .................................. 1250\r\n keep_last ....................................... False\r\n kv_channels ..................................... 256\r\n lazy_mpu_init ................................... None\r\n load ............................................ /basedir/mcore_models/gemma-2-9b-to-mcore-tp4-pp1-te-nemo\r\n local_rank ...................................... None\r\n log_batch_size_to_tensorboard ................... False\r\n log_interval .................................... 1\r\n log_learning_rate_to_tensorboard ................ True\r\n log_loss_scale_to_tensorboard ................... True\r\n log_memory_to_tensorboard ....................... False\r\n log_num_zeros_in_grad ........................... False\r\n log_params_norm ................................. False\r\n log_progress .................................... False\r\n log_throughput .................................. True\r\n log_timers_to_tensorboard ....................... False\r\n log_validation_ppl_to_tensorboard ............... False\r\n log_world_size_to_tensorboard ................... False\r\n loss_scale ...................................... None\r\n loss_scale_window ............................... 1000\r\n lr .............................................. 3e-05\r\n lr_decay_iters .................................. 1953125\r\n lr_decay_samples ................................ None\r\n lr_decay_style .................................. cosine\r\n lr_warmup_fraction .............................. None\r\n lr_warmup_init .................................. 0.0\r\n lr_warmup_iters ................................. 0\r\n lr_warmup_samples ............................... 0\r\n make_vocab_size_divisible_by .................... 128\r\n manual_gc ....................................... False\r\n manual_gc_eval .................................. True\r\n manual_gc_interval .............................. 0\r\n mask_factor ..................................... 1.0\r\n mask_prob ....................................... 0.15\r\n mask_type ....................................... random\r\n masked_softmax_fusion ........................... False\r\n max_padding_length .............................. None\r\n max_position_embeddings ......................... 64\r\n max_tokens_to_oom ............................... 12000\r\n merge_file ...................................... None\r\n micro_batch_size ................................ 1\r\n min_loss_scale .................................. 1.0\r\n min_lr .......................................... 3e-06\r\n mm_projector_type ............................... None\r\n mm_use_im_patch_token ........................... False\r\n mm_use_im_start_end ............................. False\r\n mm_vision_select_layer .......................... None\r\n mmap_bin_files .................................. True\r\n mock_data ....................................... False\r\n moe ............................................. False\r\n moe_aux_loss_coeff .............................. 0.0\r\n moe_eval_capacity_factor ........................ 1.0\r\n moe_expert_parallel_size ........................ None\r\n moe_ffn_hidden_size ............................. None\r\n moe_grouped_gemm ................................ False\r\n moe_input_feature_slicing ....................... False\r\n moe_input_jitter_eps ............................ None\r\n moe_loss_coeff .................................. 0.01\r\n moe_min_capacity ................................ 4\r\n moe_per_layer_logging ........................... False\r\n moe_router_load_balancing_type .................. aux_loss\r\n moe_router_topk ................................. 2\r\n moe_token_dispatcher_type ....................... allgather\r\n moe_token_dropping .............................. False\r\n moe_topk ........................................ 1\r\n moe_train_capacity_factor ....................... 1.0\r\n moe_z_loss_coeff ................................ None\r\n n_head_kv ....................................... None\r\n nccl_communicator_config_path ................... None\r\n no_load_optim ................................... None\r\n no_load_rng ..................................... None\r\n no_persist_layer_norm ........................... False\r\n no_save_optim ................................... None\r\n no_save_rng ..................................... None\r\n norm_epsilon .................................... 1e-06\r\n normalization ................................... RMSNorm\r\n num_attention_heads ............................. 16\r\n num_channels .................................... 3\r\n num_classes ..................................... 1000\r\n num_experts ..................................... None\r\n num_fewshot ..................................... None\r\n num_layers ...................................... 42\r\n num_layers_per_virtual_pipeline_stage ........... None\r\n num_query_groups ................................ 8\r\n num_workers ..................................... 8\r\n one_logger_entity ............................... hwinf_dcm\r\n one_logger_project .............................. e2e-tracking\r\n one_logger_run_name ............................. None\r\n onnx_safe ....................................... None\r\n openai_gelu ..................................... False\r\n optimizer ....................................... adam\r\n out_seq_length .................................. 1024\r\n output_bert_embeddings .......................... False\r\n overlap_grad_reduce ............................. False\r\n overlap_p2p_comm ................................ False\r\n overlap_param_gather ............................ False\r\n override_opt_param_scheduler .................... False\r\n params_dtype .................................... torch.bfloat16\r\n patch_dim ....................................... 16\r\n patch_size ...................................... None\r\n patch_tokenizer_type ............................ Gemma2Tokenizer\r\n perform_initialization .......................... True\r\n pipeline_model_parallel_size .................... 1\r\n pipeline_model_parallel_split_rank .............. None\r\n position_embedding_type ......................... rope\r\n position_encoding_2d ............................ False\r\n pretrained_checkpoint ........................... None\r\n profile ......................................... False\r\n profile_ranks ................................... [0]\r\n profile_step_end ................................ 12\r\n profile_step_start .............................. 10\r\n qk_layernorm .................................... False\r\n query_in_block_prob ............................. 0.1\r\n rampup_batch_size ............................... None\r\n rank ............................................ 0\r\n recompute_granularity ........................... None\r\n recompute_method ................................ uniform\r\n recompute_num_layers ............................ None\r\n repetition_penalty .............................. 1.1\r\n reset_attention_mask ............................ False\r\n reset_position_ids .............................. False\r\n retriever_report_topk_accuracies ................ []\r\n retriever_score_scaling ......................... False\r\n retriever_seq_length ............................ 256\r\n retro_add_retriever ............................. False\r\n retro_attention_gate ............................ 1\r\n retro_cyclic_train_iters ........................ None\r\n retro_encoder_attention_dropout ................. 0.1\r\n retro_encoder_hidden_dropout .................... 0.1\r\n retro_encoder_layers ............................ 2\r\n retro_num_neighbors ............................. 2\r\n retro_num_retrieved_chunks ...................... 2\r\n retro_project_dir ............................... None\r\n retro_verify_neighbor_count ..................... True\r\n rotary_base ..................................... 10000\r\n rotary_interleaved .............................. False\r\n rotary_percent .................................. 1.0\r\n rotary_scale_factor ............................. 1\r\n rotary_seq_len_interpolation_factor ............. None\r\n router_type ..................................... topk\r\n sample_rate ..................................... 1.0\r\n save ............................................ /basedir/output_mcore_models/gemma-2-9b-tp4-pp1-for-test\r\n save_interval ................................... 1000000000\r\n scatter_gather_tensors_in_pipeline .............. True\r\n seed ............................................ 1234\r\n seq_length ...................................... 64\r\n sequence_parallel ............................... True\r\n sgd_momentum .................................... 0.9\r\n shared_moe_ffn_hidden_size ...................... None\r\n short_seq_prob .................................. 0.1\r\n skip_train ...................................... False\r\n sliding_window .................................. None\r\n source_seq_len .................................. None\r\n spec ............................................ None\r\n split ........................................... 100,0,0\r\n squared_relu .................................... False\r\n standalone_embedding_stage ...................... False\r\n start_weight_decay .............................. 0.1\r\n swiglu .......................................... False\r\n swin_backbone_type .............................. tiny\r\n target_seq_len .................................. None\r\n task_list ....................................... all\r\n temperature ..................................... 1.0\r\n tensor_model_parallel_size ...................... 4\r\n tensorboard_dir ................................. /basedir/testing/tensorboard\r\n tensorboard_log_interval ........................ 1\r\n tensorboard_queue_size .......................... 1000\r\n test_data_path .................................. None\r\n test_mode ....................................... False\r\n text_generate_gt_file ........................... \r\n text_generate_input_file ........................ \r\n text_generate_output_file ....................... \r\n time ............................................ False\r\n timing_log_level ................................ 0\r\n timing_log_option ............................... minmax\r\n titles_data_path ................................ None\r\n tokenizer_model ................................. /basedir/hf_models/gemma-2-9b\r\n tokenizer_type .................................. NullTokenizer\r\n top_k ........................................... 0\r\n top_p ........................................... 0.0\r\n tp_comm_bulk_dgrad .............................. True\r\n tp_comm_bulk_wgrad .............................. True\r\n tp_comm_overlap ................................. False\r\n tp_comm_overlap_ag .............................. True\r\n tp_comm_overlap_cfg ............................. None\r\n tp_comm_overlap_rs .............................. True\r\n tp_comm_split_ag ................................ True\r\n tp_comm_split_rs ................................ True\r\n train_data ...................................... None\r\n train_data_path ................................. None\r\n train_iters ..................................... 1953125\r\n train_samples ................................... None\r\n transformer_impl ................................ transformer_engine\r\n transformer_pipeline_model_parallel_size ........ 1\r\n transformer_timers .............................. False\r\n transformer_type ................................ megatron\r\n tune_mm_mlp_adapter ............................. False\r\n untie_embeddings_and_output_weights ............. False\r\n use_alibi_mask .................................. False\r\n use_checkpoint_args ............................. False\r\n use_checkpoint_opt_param_scheduler .............. False\r\n use_cpu_initialization .......................... None\r\n use_dist_ckpt ................................... False\r\n use_distributed_optimizer ....................... True\r\n use_flash_attn .................................. False\r\n use_llama2_rotary_position_embeddings ........... False\r\n use_mcore_models ................................ True\r\n use_mistral_rotary_position_embeddings .......... False\r\n use_normhead .................................... False\r\n use_one_sent_docs ............................... False\r\n use_ring_exchange_p2p ........................... False\r\n use_rotary_position_embeddings .................. False\r\n use_tutel ....................................... False\r\n valid_data ...................................... None\r\n valid_data_path ................................. None\r\n variable_seq_lengths ............................ False\r\n verbosity ....................................... INFO\r\n version ......................................... plain\r\n virtual_pipeline_model_parallel_size ............ None\r\n vision_backbone_type ............................ vit\r\n vision_pretraining .............................. False\r\n vision_pretraining_type ......................... classify\r\n vision_tower .................................... \r\n vocab_extra_ids ................................. 0\r\n vocab_file ...................................... None\r\n vocab_size ...................................... -1\r\n wandb_exp_name .................................. \r\n wandb_project ................................... \r\n wandb_save_dir .................................. \r\n weight_decay .................................... 0.1\r\n weight_decay_incr_style ......................... constant\r\n world_size ...................................... 8\r\n yaml_cfg ........................................ None\r\n z_loss_weight ................................... 0.0\r\n-------------------- end of arguments ---------------------\r\n```\r\n\r\nAnd below are the losses of first 5 steps:\r\n```\r\n... lm loss: 8.237988E+00 | loss scale: 1.0 | grad norm: 354.350 ...\r\n... lm loss: 4.174296E+00 | loss scale: 1.0 | grad norm: 68.632 ...\r\n... lm loss: 4.116720E+00 | loss scale: 1.0 | grad norm: 43.852 ...\r\n... lm loss: 3.366329E+00 | loss scale: 1.0 | grad norm: 28.838 ...\r\n... lm loss: 3.328519E+00 | loss scale: 1.0 | grad norm: 26.727 ...\r\n```\r\n\r\nThe data should be fine; I sampled 1 million articles from enwiki and tokenized them using the tokenizer from gemma2-9b.\r\n",
"@Emperorizzis I verified inference and finetuning performance with the code in nemo framework, and the accuracy looked okay.\r\nMaybe you can double check the new components are included in your implementation? These are 1) logit soft capping, 2) alternating SWA, 3) post attn/mlp layernorm, 4) custom scale in attention",
"Hi! Thank you for your response! After our testing, we found that there **seems to be two bugs** :\r\n\r\n**1) Sliding Window**\r\n\r\n```python\r\ndef get_swa(seq_q, seq_kv, w):\r\n \"\"\"Create the equivalent attention mask fro SWA in [seq_q, seq_kv] shape\"\"\"\r\n m = torch.ones(seq_q, seq_kv, dtype=torch.bool, device=\"cuda\")\r\n ### original\r\n # mu = torch.triu(m, diagonal=seq_kv - seq_q - w[0])\r\n ### after modified\r\n mu = torch.triu(m, diagonal=seq_kv - seq_q - w[0] + 1)\r\n ml = torch.tril(mu, diagonal=seq_kv - seq_q + w[1])\r\n ml = ~ml\r\n return ml\r\n```\r\n\r\nFor example:\r\n\r\n```text\r\n【example】\r\nseq_len=4\r\nsliding_window=2\r\n\r\nget_swa(4, 4, (2, 0))\r\n\r\noriginal answer (×)\r\ntensor([[False, True, True, True],\r\n [False, False, True, True],\r\n [ False, False, False, True],\r\n [ True, False, False, False]])\r\n\r\nafter modified (aligned with hf, √):\r\ntensor([[False, True, True, True],\r\n [False, False, True, True],\r\n [ True, False, False, True],\r\n [ True, True, False, False]])\r\n```\r\n\r\n**2) The odd and even layers of the sliding window are reversed**\r\n\r\nhttps://github.com/huggingface/transformers/commit/a695c18649fc6ab4b1fb1d9c8cfa9258c5908e2a\r\n\r\n```text\r\n... ...\r\n\r\nself.layer_number = max(1, layer_number)\r\n\r\n# self.window_size = None\r\n# if self.layer_number % 2 == 0:\r\n# self.window_size = config.window_size\r\nself.sliding_window_size = None\r\n### original\r\n# if self.layer_number % 2 == 0:\r\n### after modified\r\nif self.layer_number % 2 != 0:\r\n self.sliding_window_size = (config.sliding_window_size, 0)\r\n\r\n... ...\r\n```\r\n\r\nAnd we also found that **adding or not adding \"\\<bos>\" token when continue pretraining Gemma Base model has a significant impact on the initial loss** (possibly a difference of **up to double**).\r\nAdditionally, we have discovered that the Gemma Base model is **highly sensitive** to the data and the length of the data.\r\n\r\n**Hope this finding can help other people.**\r\n\r\nThank you again for your work!",
"@Emperorizzis @cuichenx I meet the same problem (high initial loss) for continual pre-training gemma2-2B model.\r\nCould you share more details on how to correctly set up the pre-training? Many thanks for that :)\r\n\r\nSFT scripts works well (training loss < 3), but pertaining loss (training loss > 20) is extremely high. \r\n\r\n### Experiments\r\nThe following experiments are running with the same docker `nvcr.io/nvidia/nemo:24.05.llama3.1` and the same dataset `databricks-dolly-15k`.\r\n\r\n\r\n\r\n**SFT training:**\r\nFollowing the [official document](https://docs.nvidia.com/nemo-framework/user-guide/latest/llms/gemma/sft.html), I set up the SFT training.\r\n[A] gemma2_2b_sft_bos_rc2:\r\n-codebase: https://github.com/NVIDIA/NeMo/tree/r2.0.0rc1\r\n-data: databricks-dolly-15k/train.jsonl\r\n-add bos: Yes\r\n\r\n[B]gemma2_2b_sft_0830_main: \r\n-codebase: https://github.com/NVIDIA/NeMo/tree/1ce9089143b0136523cb08bb37941a35c9b08307\r\n-data: databricks-dolly-15k/train.jsonl\r\n-add bos: Yes\r\n\r\n**Continual pre-training**\r\nI didn't find the pre-training recipe for gemma. Thus I just preprocess the dataset with following cmd.\r\n```\r\npython ${NEMO_CODE_PATH}/scripts/nlp_language_modeling/preprocess_data_for_megatron.py \\\r\n --input ${DATASET_PATH}/sample.jsonl \\\r\n --json-keys text \\\r\n --tokenizer-library huggingface \\\r\n --dataset-impl mmap \\\r\n --tokenizer-type ${MODEL_PATH}/gemma2_2b \\\r\n --output-prefix ${DATASET_PATH}/sample_gemma2_preprocessed/sample \\\r\n --append-eod \\\r\n --workers=1\r\n```\r\n[C]gemma2_2b_sft_pretraining\r\n-codebase: https://github.com/NVIDIA/NeMo/tree/1ce9089143b0136523cb08bb37941a35c9b08307\r\n-data: databricks-dolly-15k/train.jsonl\r\n-add bos: No\r\n\r\n[D]gemma2_2b_sft_pretraining_bos\r\n-codebase: https://github.com/NVIDIA/NeMo/tree/1ce9089143b0136523cb08bb37941a35c9b08307\r\n-data: databricks-dolly-15k/train.jsonl\r\n-add bos: Yes\r\nI modify [preprocess_data_for_megatron.py](https://github.com/NVIDIA/NeMo/blob/1ce9089143b0136523cb08bb37941a35c9b08307/scripts/nlp_language_modeling/preprocess_data_for_megatron.py#L178) as following to append the BOS token.\r\n```\r\n for sentence in Encoder.splitter.tokenize(text):\r\n sentence_ids = Encoder.tokenizer.text_to_ids(sentence)\r\n sentence_ids = [Encoder.tokenizer.bos_id] + sentence_ids\r\n if len(sentence_ids) > 0:\r\n doc_ids.append(sentence_ids)\r\n if len(doc_ids) > 0 and self.args.append_eod:\r\n doc_ids[-1].append(Encoder.tokenizer.eos_id)\r\n ids[key] = doc_ids\r\n```\r\n\r\n### Observations\r\n(1) SFT tuning is normal, but also differs with the codebase changes. => [A] and [B] adopts the same data and docker, but receives different loss curve.\r\n(2) BOS matters a lot as @Emperorizzis said. It got further studied by [https://unsloth.ai/blog/gemma-bugs](https://unsloth.ai/blog/gemma-bugs).\r\n\r\n\r\n### Looking for help\r\nCould @cuichenx provide a stable codebase version tag and the necessary guidance on how to run the NeMo for Gemma2 model for both pre-training? Thanks for your great work! ",
"Thanks for reporting these issues! I will look into them this week."
] | 2024-07-10T18:36:34 | 2024-09-04T01:06:46 | 2024-07-12T05:54:25 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9672",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9672",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9672.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9672.patch",
"merged_at": "2024-07-12T05:54:25"
} | # What does this PR do ?
Duplicate of #9587 for release branch
Also includes transformers version update from #9606
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [X] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9672/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9672/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9671 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9671/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9671/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9671/events | https://github.com/NVIDIA/NeMo/pull/9671 | 2,401,306,151 | PR_kwDOC_bI7s50_2cD | 9,671 | enables default data step in megatron parallel to operate on a wider variety of tensors - second try | {
"login": "jomitchellnv",
"id": 148147880,
"node_id": "U_kgDOCNSOqA",
"avatar_url": "https://avatars.githubusercontent.com/u/148147880?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jomitchellnv",
"html_url": "https://github.com/jomitchellnv",
"followers_url": "https://api.github.com/users/jomitchellnv/followers",
"following_url": "https://api.github.com/users/jomitchellnv/following{/other_user}",
"gists_url": "https://api.github.com/users/jomitchellnv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jomitchellnv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jomitchellnv/subscriptions",
"organizations_url": "https://api.github.com/users/jomitchellnv/orgs",
"repos_url": "https://api.github.com/users/jomitchellnv/repos",
"events_url": "https://api.github.com/users/jomitchellnv/events{/privacy}",
"received_events_url": "https://api.github.com/users/jomitchellnv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@cuichenx , it sounded like @ashors1 wanted you to review and approve this PR? Let me know if someone else is better. While @marcromeyn is out, who should we have review and help us get things we need on the BioNeMo2 side into NeMo2 in general?",
"> @cuichenx , it sounded like @ashors1 wanted you to review and approve this PR? Let me know if someone else is better. While @marcromeyn is out, who should we have review and help us get things we need on the BioNeMo2 side into NeMo2 in general?\r\n\r\nI think it generally depends on the PR, but I can approve this one as well given that Marc approved the original attempt previously. We just need the CI to pass; then we should be able to merge"
] | 2024-07-10T17:25:22 | 2024-07-15T16:12:49 | 2024-07-15T16:12:49 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9671",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9671",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9671.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9671.patch",
"merged_at": "2024-07-15T16:12:49"
} | # What does this PR do ?
Add more flexibility to the default data step inside megatron parallel.
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9671/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9671/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9670 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9670/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9670/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9670/events | https://github.com/NVIDIA/NeMo/pull/9670 | 2,401,303,358 | PR_kwDOC_bI7s50_10j | 9,670 | Canary Adapters tutorial | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-10T17:23:29 | 2024-07-16T19:03:42 | 2024-07-16T19:03:40 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9670",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9670",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9670.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9670.patch",
"merged_at": "2024-07-16T19:03:40"
} | # What does this PR do ?
Adds a tutorial for Canary Adapters
**Collection**: [ASR]
# Changelog
- Add tutorial for canary adapters
- Adds Neural Module support for preserving freeze and unfreeze partially
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9670/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9670/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9669 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9669/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9669/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9669/events | https://github.com/NVIDIA/NeMo/pull/9669 | 2,401,016,990 | PR_kwDOC_bI7s50-2Sz | 9,669 | Parametrize FPS group | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-10T15:01:15 | 2024-07-11T13:34:18 | 2024-07-11T13:34:17 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9669",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9669",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9669.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9669.patch",
"merged_at": "2024-07-11T13:34:17"
} | # What does this PR do ?
When doing a parallel save, exchange metadata in a whole world instead of a DP group. For yet unknown reason `all_gather_object` crashes with `group != world`
**Collection**: NLP
# Changelog
- Parametrize metadata exchange group for parallel save
- Turn on parallel save by default
# Usage
* By default metadata will be exchanged within the whole world. Set `model.dist_ckpt_parallel_save_within_dp=True` to exchange within DP.
* Set `model.dist_ckpt_parallel_save=False` to turn off parallel save
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9669/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9669/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9668 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9668/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9668/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9668/events | https://github.com/NVIDIA/NeMo/pull/9668 | 2,400,917,669 | PR_kwDOC_bI7s50-gKU | 9,668 | Fix the serialization of partial functions in nemo 2.0 | {
"login": "sararb",
"id": 17721108,
"node_id": "MDQ6VXNlcjE3NzIxMTA4",
"avatar_url": "https://avatars.githubusercontent.com/u/17721108?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sararb",
"html_url": "https://github.com/sararb",
"followers_url": "https://api.github.com/users/sararb/followers",
"following_url": "https://api.github.com/users/sararb/following{/other_user}",
"gists_url": "https://api.github.com/users/sararb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sararb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sararb/subscriptions",
"organizations_url": "https://api.github.com/users/sararb/orgs",
"repos_url": "https://api.github.com/users/sararb/repos",
"events_url": "https://api.github.com/users/sararb/events{/privacy}",
"received_events_url": "https://api.github.com/users/sararb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-10T14:21:42 | 2024-07-17T18:28:10 | 2024-07-17T18:28:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9668",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9668",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9668.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9668.patch",
"merged_at": "2024-07-17T18:28:08"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "sararb",
"id": 17721108,
"node_id": "MDQ6VXNlcjE3NzIxMTA4",
"avatar_url": "https://avatars.githubusercontent.com/u/17721108?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sararb",
"html_url": "https://github.com/sararb",
"followers_url": "https://api.github.com/users/sararb/followers",
"following_url": "https://api.github.com/users/sararb/following{/other_user}",
"gists_url": "https://api.github.com/users/sararb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sararb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sararb/subscriptions",
"organizations_url": "https://api.github.com/users/sararb/orgs",
"repos_url": "https://api.github.com/users/sararb/repos",
"events_url": "https://api.github.com/users/sararb/events{/privacy}",
"received_events_url": "https://api.github.com/users/sararb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9668/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9668/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9667 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9667/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9667/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9667/events | https://github.com/NVIDIA/NeMo/pull/9667 | 2,400,145,143 | PR_kwDOC_bI7s507zbg | 9,667 | Update llama-3 PEFT notebook to download model from NGC | {
"login": "shashank3959",
"id": 20920371,
"node_id": "MDQ6VXNlcjIwOTIwMzcx",
"avatar_url": "https://avatars.githubusercontent.com/u/20920371?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shashank3959",
"html_url": "https://github.com/shashank3959",
"followers_url": "https://api.github.com/users/shashank3959/followers",
"following_url": "https://api.github.com/users/shashank3959/following{/other_user}",
"gists_url": "https://api.github.com/users/shashank3959/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shashank3959/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shashank3959/subscriptions",
"organizations_url": "https://api.github.com/users/shashank3959/orgs",
"repos_url": "https://api.github.com/users/shashank3959/repos",
"events_url": "https://api.github.com/users/shashank3959/events{/privacy}",
"received_events_url": "https://api.github.com/users/shashank3959/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"I am providing additional copyedits to the file, ReadMe.rst, herein. I was not able to provide inline edits because part of the file was read-only.\r\n\r\n**Line 4 fix punctuation**\r\n\r\n`Llama 3 <https://blogs.nvidia.com/blog/meta-llama3-inference-acceleration/>`_ is an open-source large language model by Meta that delivers state-of-the-art performance on popular industry benchmarks.\r\n\r\n**Line 6 fix punctuation**\r\n\r\n`Low-Rank Adaptation (LoRA) <https://arxiv.org/pdf/2106.09685>`__ has emerged as a popular Parameter-Efficient Fine-Tuning (PEFT) technique that tunes a very small number of additional parameters as compared to full fine-tuning, thereby reducing the compute required.\r\n\r\n**Line 19 revise for clarity**\r\n\r\nNIM enables seamless deployment of multiple LoRA adapters (referred to as ‘multi-LoRA’) on the same base model. It dynamically loads adapter weights based on incoming requests at runtime. This flexibility allows handling inputs from various tasks or use cases without requiring a unique model for each individual scenario. For further details, consult the NIM documentation for LLMs.\r\n\r\n**Line 24 delete the following sentence, it is sufficient to retain the bullets**\r\n\r\nIn order to proceed, ensure that you have met the following requirements:\r\n\r\n**Line 103/109 fix punctuation**\r\n\r\n2. Prepare the LoRA model store. \r\n\r\n**Line 110/116 fix grammar**\r\n\r\nTo ensure the model store is organized as expected, create a folder named llama3-8b-pubmed-qa and move your .nemo checkpoint there.\r\n\r\n**Line 122/128 revise for clarity**\r\n\r\nEnsure that the LoRA model store directory follows this structure: the model name should be a sub-folder containing the .nemo file.\r\n\r\n**Line 138/144 fix punctuation**\r\n\r\n3. Set up NIM. \r\n\r\n**Line 170/176 fix grammar**\r\n\r\nThe first time you run the command, it will download the model and cache it in $NIM_CACHE_PATH so subsequent deployments are even faster. There are several options to configure NIM other than the ones listed above. You can find a full list in the NIM configuration documentation.\r\n\r\n**Line 173/179 fix punctuation**\r\n\r\n4. Start the notebook.\r\n\r\n**Line 175/181 fix grammar**\r\n\r\nFrom another terminal, follow the same instructions as the previous notebook to launch Jupyter Lab, and then navigate to this notebook.\r\n\r\n**Line 178/185 revise for clarity**\r\n\r\nYou can use the same NeMo Framework docker container in which Jupyter Lab was previously installed."
] | 2024-07-10T08:49:58 | 2024-07-10T23:10:46 | 2024-07-10T23:10:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9667",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9667",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9667.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9667.patch",
"merged_at": "2024-07-10T23:10:46"
} | * Updates the llama-3 PEFT tutorial to download the model from NVIDIA NGC to skip conversion
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9667/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9667/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9666 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9666/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9666/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9666/events | https://github.com/NVIDIA/NeMo/pull/9666 | 2,400,129,842 | PR_kwDOC_bI7s507wGA | 9,666 | Revert "enables default data step in megatron parallel to operate on a wider variety of tensors" | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-10T08:42:49 | 2024-07-10T15:38:10 | 2024-07-10T15:38:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9666",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9666",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9666.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9666.patch",
"merged_at": "2024-07-10T15:38:07"
} | Reverts NVIDIA/NeMo#9641 | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9666/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9666/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9665 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9665/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9665/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9665/events | https://github.com/NVIDIA/NeMo/pull/9665 | 2,399,729,869 | PR_kwDOC_bI7s506YIa | 9,665 | [TTS] Add VietnameseCharsTokenizer | {
"login": "huutuongtu",
"id": 83907151,
"node_id": "MDQ6VXNlcjgzOTA3MTUx",
"avatar_url": "https://avatars.githubusercontent.com/u/83907151?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huutuongtu",
"html_url": "https://github.com/huutuongtu",
"followers_url": "https://api.github.com/users/huutuongtu/followers",
"following_url": "https://api.github.com/users/huutuongtu/following{/other_user}",
"gists_url": "https://api.github.com/users/huutuongtu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huutuongtu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huutuongtu/subscriptions",
"organizations_url": "https://api.github.com/users/huutuongtu/orgs",
"repos_url": "https://api.github.com/users/huutuongtu/repos",
"events_url": "https://api.github.com/users/huutuongtu/events{/privacy}",
"received_events_url": "https://api.github.com/users/huutuongtu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-10T04:40:03 | 2024-07-26T08:24:49 | 2024-07-26T08:24:49 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9665",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9665",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9665.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9665.patch",
"merged_at": "2024-07-26T08:24:49"
} | Signed-off-by: Tu [[email protected]](mailto:[email protected])
# What does this PR do ?
Add a Vietnamese language tokenizer for TTS training
**Collection**: [TTS]
# Changelog
- Add VietnameseCharsTokenizer
- Add unit tests for Vietnamese
# Usage
```python
from nemo.collections.common.tokenizers.text_to_speech.tts_tokenizers import VietnameseCharsTokenizer
text = "Xin chào các bạn."
tokenizer = VietnameseCharsTokenizer(
pad_with_space=True,
)
tokens = tokenizer(text)
graphemes = tokenizer.decode(tokens)
graphemes = graphemes.replace('|', '')
print(tokens)
# xin chào các bạn.
print(graphemes)
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9665/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9665/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9664 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9664/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9664/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9664/events | https://github.com/NVIDIA/NeMo/issues/9664 | 2,399,424,272 | I_kwDOC_bI7s6PBE8Q | 9,664 | Add sequence packing and proper attention masking support for LLM pretraining? | {
"login": "dementrock",
"id": 784063,
"node_id": "MDQ6VXNlcjc4NDA2Mw==",
"avatar_url": "https://avatars.githubusercontent.com/u/784063?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dementrock",
"html_url": "https://github.com/dementrock",
"followers_url": "https://api.github.com/users/dementrock/followers",
"following_url": "https://api.github.com/users/dementrock/following{/other_user}",
"gists_url": "https://api.github.com/users/dementrock/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dementrock/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dementrock/subscriptions",
"organizations_url": "https://api.github.com/users/dementrock/orgs",
"repos_url": "https://api.github.com/users/dementrock/repos",
"events_url": "https://api.github.com/users/dementrock/events{/privacy}",
"received_events_url": "https://api.github.com/users/dementrock/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Based on DM, this should be already supported in gpt dataset https://github.com/NVIDIA/Megatron-LM/blob/c7a1f82d761577e6ca0338d3521eac82f2aa0904/megatron/core/datasets/gpt_dataset.py#L189\r\nclosing"
] | 2024-07-09T23:44:22 | 2024-07-10T04:01:40 | 2024-07-10T04:01:40 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Right now when performing LLM pretraining, different documents are just naively concatenated without proper masking. This can become problematic for model training with longer context window, as noted in e.g. https://arxiv.org/abs/2402.08268. Llama 3 blog post also mentioned they applied proper masking e.g. see https://ai.meta.com/blog/meta-llama-3/.
Seems like https://github.com/NVIDIA/NeMo/pull/7945 added support for packed sequence with proper masking for SFT. Would it be possible to make pretraining support this too?
| {
"login": "dementrock",
"id": 784063,
"node_id": "MDQ6VXNlcjc4NDA2Mw==",
"avatar_url": "https://avatars.githubusercontent.com/u/784063?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dementrock",
"html_url": "https://github.com/dementrock",
"followers_url": "https://api.github.com/users/dementrock/followers",
"following_url": "https://api.github.com/users/dementrock/following{/other_user}",
"gists_url": "https://api.github.com/users/dementrock/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dementrock/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dementrock/subscriptions",
"organizations_url": "https://api.github.com/users/dementrock/orgs",
"repos_url": "https://api.github.com/users/dementrock/repos",
"events_url": "https://api.github.com/users/dementrock/events{/privacy}",
"received_events_url": "https://api.github.com/users/dementrock/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9664/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9664/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9663 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9663/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9663/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9663/events | https://github.com/NVIDIA/NeMo/pull/9663 | 2,399,270,865 | PR_kwDOC_bI7s5044qu | 9,663 | llama CI fix | {
"login": "rohitrango",
"id": 15312514,
"node_id": "MDQ6VXNlcjE1MzEyNTE0",
"avatar_url": "https://avatars.githubusercontent.com/u/15312514?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rohitrango",
"html_url": "https://github.com/rohitrango",
"followers_url": "https://api.github.com/users/rohitrango/followers",
"following_url": "https://api.github.com/users/rohitrango/following{/other_user}",
"gists_url": "https://api.github.com/users/rohitrango/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rohitrango/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rohitrango/subscriptions",
"organizations_url": "https://api.github.com/users/rohitrango/orgs",
"repos_url": "https://api.github.com/users/rohitrango/repos",
"events_url": "https://api.github.com/users/rohitrango/events{/privacy}",
"received_events_url": "https://api.github.com/users/rohitrango/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-09T21:43:17 | 2024-07-10T05:48:44 | 2024-07-10T05:48:44 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9663",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9663",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9663.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9663.patch",
"merged_at": "2024-07-10T05:48:44"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9663/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9663/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9662 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9662/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9662/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9662/events | https://github.com/NVIDIA/NeMo/pull/9662 | 2,399,227,996 | PR_kwDOC_bI7s504vNG | 9,662 | Fixing import error fior llama-index (RAG pipeline) | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-07-09T21:17:07 | 2024-07-09T21:17:19 | 2024-07-09T21:17:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9662",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9662",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9662.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9662.patch",
"merged_at": "2024-07-09T21:17:18"
} | null | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9662/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9662/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9661 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9661/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9661/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9661/events | https://github.com/NVIDIA/NeMo/pull/9661 | 2,399,168,346 | PR_kwDOC_bI7s504ilO | 9,661 | [NeMo-UX] Fix pipeline parallel bug | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-09T20:35:29 | 2024-07-10T23:21:48 | 2024-07-10T23:21:46 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9661",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9661",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9661.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9661.patch",
"merged_at": "2024-07-10T23:21:45"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9661/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9661/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9660 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9660/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9660/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9660/events | https://github.com/NVIDIA/NeMo/pull/9660 | 2,399,024,657 | PR_kwDOC_bI7s504KRb | 9,660 | CLIP and Neva Fix for NeMo 2.0.0rc | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-09T19:37:45 | 2024-07-10T22:38:30 | 2024-07-10T22:38:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9660",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9660",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9660.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9660.patch",
"merged_at": null
} | # What does this PR do ?
bug fix for neva and clip
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9660/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9660/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9659 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9659/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9659/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9659/events | https://github.com/NVIDIA/NeMo/issues/9659 | 2,398,866,182 | I_kwDOC_bI7s6O-8sG | 9,659 | When should mcore_gpt: True be used? | {
"login": "dementrock",
"id": 784063,
"node_id": "MDQ6VXNlcjc4NDA2Mw==",
"avatar_url": "https://avatars.githubusercontent.com/u/784063?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dementrock",
"html_url": "https://github.com/dementrock",
"followers_url": "https://api.github.com/users/dementrock/followers",
"following_url": "https://api.github.com/users/dementrock/following{/other_user}",
"gists_url": "https://api.github.com/users/dementrock/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dementrock/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dementrock/subscriptions",
"organizations_url": "https://api.github.com/users/dementrock/orgs",
"repos_url": "https://api.github.com/users/dementrock/repos",
"events_url": "https://api.github.com/users/dementrock/events{/privacy}",
"received_events_url": "https://api.github.com/users/dementrock/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | true | null | [] | null | [] | 2024-07-09T18:23:02 | 2024-07-15T04:14:24 | 2024-07-15T04:14:24 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | This flag is used in some of the launch files like https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/language_modeling/conf/megatron_gpt_config.yaml. I know this flag causes different implementation of the model to be used, but can their differences and recommendations for when to use one vs another be explained in more detail in the doc? | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9659/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9659/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9658 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9658/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9658/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9658/events | https://github.com/NVIDIA/NeMo/pull/9658 | 2,398,795,821 | PR_kwDOC_bI7s503YCu | 9,658 | In framework export | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-09T17:43:04 | 2024-07-16T17:35:53 | 2024-07-16T17:35:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9658",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9658",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9658.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9658.patch",
"merged_at": "2024-07-16T17:35:53"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9658/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9658/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9657 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9657/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9657/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9657/events | https://github.com/NVIDIA/NeMo/pull/9657 | 2,398,792,651 | PR_kwDOC_bI7s503XV_ | 9,657 | [NeMo-UX] Make 'load_directly_on_device' configurable | {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-09T17:40:48 | 2024-07-10T18:47:58 | 2024-07-10T18:47:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9657",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9657",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9657.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9657.patch",
"merged_at": "2024-07-10T18:47:57"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ashors1",
"id": 71393111,
"node_id": "MDQ6VXNlcjcxMzkzMTEx",
"avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ashors1",
"html_url": "https://github.com/ashors1",
"followers_url": "https://api.github.com/users/ashors1/followers",
"following_url": "https://api.github.com/users/ashors1/following{/other_user}",
"gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashors1/subscriptions",
"organizations_url": "https://api.github.com/users/ashors1/orgs",
"repos_url": "https://api.github.com/users/ashors1/repos",
"events_url": "https://api.github.com/users/ashors1/events{/privacy}",
"received_events_url": "https://api.github.com/users/ashors1/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9657/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9657/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9656 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9656/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9656/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9656/events | https://github.com/NVIDIA/NeMo/pull/9656 | 2,398,709,305 | PR_kwDOC_bI7s503FC4 | 9,656 | Making TDT models support all-positive durations (previously duration must contain 0) | {
"login": "hainan-xv",
"id": 5440014,
"node_id": "MDQ6VXNlcjU0NDAwMTQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/5440014?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hainan-xv",
"html_url": "https://github.com/hainan-xv",
"followers_url": "https://api.github.com/users/hainan-xv/followers",
"following_url": "https://api.github.com/users/hainan-xv/following{/other_user}",
"gists_url": "https://api.github.com/users/hainan-xv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hainan-xv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hainan-xv/subscriptions",
"organizations_url": "https://api.github.com/users/hainan-xv/orgs",
"repos_url": "https://api.github.com/users/hainan-xv/repos",
"events_url": "https://api.github.com/users/hainan-xv/events{/privacy}",
"received_events_url": "https://api.github.com/users/hainan-xv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "hainan-xv",
"id": 5440014,
"node_id": "MDQ6VXNlcjU0NDAwMTQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/5440014?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hainan-xv",
"html_url": "https://github.com/hainan-xv",
"followers_url": "https://api.github.com/users/hainan-xv/followers",
"following_url": "https://api.github.com/users/hainan-xv/following{/other_user}",
"gists_url": "https://api.github.com/users/hainan-xv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hainan-xv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hainan-xv/subscriptions",
"organizations_url": "https://api.github.com/users/hainan-xv/orgs",
"repos_url": "https://api.github.com/users/hainan-xv/repos",
"events_url": "https://api.github.com/users/hainan-xv/events{/privacy}",
"received_events_url": "https://api.github.com/users/hainan-xv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "hainan-xv",
"id": 5440014,
"node_id": "MDQ6VXNlcjU0NDAwMTQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/5440014?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hainan-xv",
"html_url": "https://github.com/hainan-xv",
"followers_url": "https://api.github.com/users/hainan-xv/followers",
"following_url": "https://api.github.com/users/hainan-xv/following{/other_user}",
"gists_url": "https://api.github.com/users/hainan-xv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hainan-xv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hainan-xv/subscriptions",
"organizations_url": "https://api.github.com/users/hainan-xv/orgs",
"repos_url": "https://api.github.com/users/hainan-xv/repos",
"events_url": "https://api.github.com/users/hainan-xv/events{/privacy}",
"received_events_url": "https://api.github.com/users/hainan-xv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"@hainan-xv Something is wrong with tests in this branch (not related to TDT). Please, update to main and toggle `Run CICD` label",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"@hainan-xv This still an IP?",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"Addressed review comments. @artbataev @tbartley94 ",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"@hainan-xv let's get this merged if there's nothing you want to add",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"<!-- pylint-output-strict-mode-false -->\n\nbeep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.\n\n---\n\nYour code was analyzed with PyLint. The following annotations have been identified:\n\n```\n************* Module nemo.collections.asr.parts.numba.rnnt_loss.utils.cuda_utils.gpu_rnnt_kernel\nnemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt_kernel.py:745:0: C0301: Line too long (121/119) (line-too-long)\nnemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt_kernel.py:856:0: C0301: Line too long (134/119) (line-too-long)\nnemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt_kernel.py:913:0: C0301: Line too long (124/119) (line-too-long)\nnemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt_kernel.py:980:0: C0301: Line too long (125/119) (line-too-long)\nnemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt_kernel.py:995:0: C0301: Line too long (123/119) (line-too-long)\nnemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt_kernel.py:1183:0: C0301: Line too long (128/119) (line-too-long)\nnemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt_kernel.py:1189:0: C0301: Line too long (145/119) (line-too-long)\nnemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt_kernel.py:1194:0: C0301: Line too long (132/119) (line-too-long)\nnemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt_kernel.py:1208:0: C0301: Line too long (142/119) (line-too-long)\nnemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt_kernel.py:1383:0: C0301: Line too long (144/119) (line-too-long)\nnemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt_kernel.py:1394:0: C0301: Line too long (162/119) (line-too-long)\nnemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt_kernel.py:1410:0: C0301: Line too long (167/119) (line-too-long)\nnemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt_kernel.py:68:0: C0116: Missing function or method docstring (missing-function-docstring)\n\n-----------------------------------\nYour code has been rated at 9.64/10\n```\n\n---\n\nThank you for improving NeMo's documentation!"
] | 2024-07-09T16:50:32 | 2024-11-20T19:56:45 | 2024-11-20T19:56:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9656",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9656",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9656.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9656.patch",
"merged_at": "2024-11-20T19:56:45"
} | # What does this PR do ?
This PR makes TDT models support all-positive durations (previously duration must contain 0).
**Collection**: [ASR]
# Changelog
- the kernal code for computing TDT loss is changed.
- tests are added to test the correctness of new code and also ensures it's back-compatible.
# Usage
N/A
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hainan-xv",
"id": 5440014,
"node_id": "MDQ6VXNlcjU0NDAwMTQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/5440014?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hainan-xv",
"html_url": "https://github.com/hainan-xv",
"followers_url": "https://api.github.com/users/hainan-xv/followers",
"following_url": "https://api.github.com/users/hainan-xv/following{/other_user}",
"gists_url": "https://api.github.com/users/hainan-xv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hainan-xv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hainan-xv/subscriptions",
"organizations_url": "https://api.github.com/users/hainan-xv/orgs",
"repos_url": "https://api.github.com/users/hainan-xv/repos",
"events_url": "https://api.github.com/users/hainan-xv/events{/privacy}",
"received_events_url": "https://api.github.com/users/hainan-xv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9656/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9656/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9654 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9654/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9654/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9654/events | https://github.com/NVIDIA/NeMo/pull/9654 | 2,398,646,094 | PR_kwDOC_bI7s5025X7 | 9,654 | SDXL improvements (and support for Draft+) | {
"login": "rohitrango",
"id": 15312514,
"node_id": "MDQ6VXNlcjE1MzEyNTE0",
"avatar_url": "https://avatars.githubusercontent.com/u/15312514?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rohitrango",
"html_url": "https://github.com/rohitrango",
"followers_url": "https://api.github.com/users/rohitrango/followers",
"following_url": "https://api.github.com/users/rohitrango/following{/other_user}",
"gists_url": "https://api.github.com/users/rohitrango/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rohitrango/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rohitrango/subscriptions",
"organizations_url": "https://api.github.com/users/rohitrango/orgs",
"repos_url": "https://api.github.com/users/rohitrango/repos",
"events_url": "https://api.github.com/users/rohitrango/events{/privacy}",
"received_events_url": "https://api.github.com/users/rohitrango/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@ericharper @yaoyu-33 @pablo-garay this is good to go? "
] | 2024-07-09T16:21:57 | 2024-07-11T23:19:11 | 2024-07-11T23:19:11 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9654",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9654",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9654.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9654.patch",
"merged_at": "2024-07-11T23:19:11"
} | * add slurm files to .gitignore
* add differentiable decode to SDXL VAE
* Optionally return predicted noise during the single step sampling process
* also change `get_gamma` as a new function to use inside other functions which may interact with sampling (e.g. draft+)
* debugging sdunet converter script
* Added SD/SDXL conversion script from HF to NeMo
* added 'from_nemo' config for VAE
* tmp commit, please make changes (oci is super slow, cannot even run vim)
* new inference yaml works
* add logging to autoencoder
* !(dont squash) Added enabling support for LinearWrapper for SDLoRA
* added samples_per_batch and fsdp arguments to SDXL inference
* added extra optionally wrapper to FSDP
* remove unncessary comments
* remove unnecessary comments
* Apply isort and black reformatting
---------
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9654/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9654/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9653 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9653/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9653/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9653/events | https://github.com/NVIDIA/NeMo/pull/9653 | 2,398,623,664 | PR_kwDOC_bI7s5020YG | 9,653 | SDXL improvements (and support for Draft+) | {
"login": "rohitrango",
"id": 15312514,
"node_id": "MDQ6VXNlcjE1MzEyNTE0",
"avatar_url": "https://avatars.githubusercontent.com/u/15312514?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rohitrango",
"html_url": "https://github.com/rohitrango",
"followers_url": "https://api.github.com/users/rohitrango/followers",
"following_url": "https://api.github.com/users/rohitrango/following{/other_user}",
"gists_url": "https://api.github.com/users/rohitrango/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rohitrango/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rohitrango/subscriptions",
"organizations_url": "https://api.github.com/users/rohitrango/orgs",
"repos_url": "https://api.github.com/users/rohitrango/repos",
"events_url": "https://api.github.com/users/rohitrango/events{/privacy}",
"received_events_url": "https://api.github.com/users/rohitrango/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [] | 2024-07-09T16:10:28 | 2024-07-09T16:13:22 | 2024-07-09T16:13:22 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9653",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9653",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9653.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9653.patch",
"merged_at": null
} | # What does this PR do ?
This PR adds additional functionality to SDXL class of models to support Draft+, and:
bug fix for adapter control in LoRA (LinearParallelAdapter)
conversion script for SDXL from huggingface weights to nemo (existing converter script doesnt work)
additional inference config file to load converted hf weights
added FSDP strategy for multimodal models
function to return adapter config, similar to function that returns the adapter itself
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "rohitrango",
"id": 15312514,
"node_id": "MDQ6VXNlcjE1MzEyNTE0",
"avatar_url": "https://avatars.githubusercontent.com/u/15312514?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rohitrango",
"html_url": "https://github.com/rohitrango",
"followers_url": "https://api.github.com/users/rohitrango/followers",
"following_url": "https://api.github.com/users/rohitrango/following{/other_user}",
"gists_url": "https://api.github.com/users/rohitrango/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rohitrango/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rohitrango/subscriptions",
"organizations_url": "https://api.github.com/users/rohitrango/orgs",
"repos_url": "https://api.github.com/users/rohitrango/repos",
"events_url": "https://api.github.com/users/rohitrango/events{/privacy}",
"received_events_url": "https://api.github.com/users/rohitrango/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9653/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9653/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9652 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9652/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9652/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9652/events | https://github.com/NVIDIA/NeMo/pull/9652 | 2,398,352,911 | PR_kwDOC_bI7s50133a | 9,652 | Huvu/rag import fix | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-09T14:16:13 | 2024-11-19T17:11:29 | 2024-08-01T01:55:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9652",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9652",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9652.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9652.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9652/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9652/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9651 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9651/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9651/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9651/events | https://github.com/NVIDIA/NeMo/pull/9651 | 2,398,320,850 | PR_kwDOC_bI7s501wws | 9,651 | Fixing import error fior llama-index (RAG pipeline) | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-09T14:02:18 | 2024-07-09T21:03:16 | 2024-07-09T15:24:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9651",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9651",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9651.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9651.patch",
"merged_at": "2024-07-09T15:24:46"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9651/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9651/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9650 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9650/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9650/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9650/events | https://github.com/NVIDIA/NeMo/pull/9650 | 2,398,079,605 | PR_kwDOC_bI7s5006h0 | 9,650 | [Nemo-UX] Including all trainable-params in a PEFT-checkpoint | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-07-09T12:29:51 | 2024-07-11T12:56:08 | 2024-07-11T12:56:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9650",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9650",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9650.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9650.patch",
"merged_at": "2024-07-11T12:56:06"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9650/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9650/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9649 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9649/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9649/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9649/events | https://github.com/NVIDIA/NeMo/issues/9649 | 2,397,992,298 | I_kwDOC_bI7s6O7nVq | 9,649 | Object shard /models/Nemotron-4-340B-Reward/model_weights/model.rm_head._extra_state/shard_0_1.pt not found | {
"login": "codybum",
"id": 6785316,
"node_id": "MDQ6VXNlcjY3ODUzMTY=",
"avatar_url": "https://avatars.githubusercontent.com/u/6785316?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/codybum",
"html_url": "https://github.com/codybum",
"followers_url": "https://api.github.com/users/codybum/followers",
"following_url": "https://api.github.com/users/codybum/following{/other_user}",
"gists_url": "https://api.github.com/users/codybum/gists{/gist_id}",
"starred_url": "https://api.github.com/users/codybum/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/codybum/subscriptions",
"organizations_url": "https://api.github.com/users/codybum/orgs",
"repos_url": "https://api.github.com/users/codybum/repos",
"events_url": "https://api.github.com/users/codybum/events{/privacy}",
"received_events_url": "https://api.github.com/users/codybum/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "terrykong",
"id": 7576060,
"node_id": "MDQ6VXNlcjc1NzYwNjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/7576060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/terrykong",
"html_url": "https://github.com/terrykong",
"followers_url": "https://api.github.com/users/terrykong/followers",
"following_url": "https://api.github.com/users/terrykong/following{/other_user}",
"gists_url": "https://api.github.com/users/terrykong/gists{/gist_id}",
"starred_url": "https://api.github.com/users/terrykong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/terrykong/subscriptions",
"organizations_url": "https://api.github.com/users/terrykong/orgs",
"repos_url": "https://api.github.com/users/terrykong/repos",
"events_url": "https://api.github.com/users/terrykong/events{/privacy}",
"received_events_url": "https://api.github.com/users/terrykong/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"I am seeing the same issue, please help! \r\ncc @terrykong ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-07-09T11:52:08 | 2024-08-23T01:51:58 | 2024-08-23T01:51:58 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Instruct model seems to work as expected, but I am experiencing issues with the Reward model. https://huggingface.co/nvidia/Nemotron-4-340B-Reward/discussions/3
Tested containers: nemo_24_01_framework and nemo_24_03_01_framework
Resource config: #SBATCH --nodes=2 #SBATCH --ntasks-per-node=8 #SBATCH --gpus-per-node=8
Attempted resolution: Repeated downloading of the Nemotron-4-340B-Reward model
Related error: https://github.com/NVIDIA/NeMo/issues/8785
A clear and concise description of what the bug is.
NeMo reports that files are missing from the Nemotron-4-340B-Reward model.
**Steps/Code to reproduce bug**
Run the example code (https://huggingface.co/nvidia/Nemotron-4-340B-Reward) with one of the following containers: nemo_24_01_framework and nemo_24_03_01_framework
**Expected behavior**
A clear and concise description of what you expected to happen.
I expect the job to complete and not produce an error.
**Environment overview (please complete the following information)**
Local H100 DGX cluster, using NGC containers,
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9649/reactions",
"total_count": 3,
"+1": 3,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9649/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9648 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9648/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9648/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9648/events | https://github.com/NVIDIA/NeMo/pull/9648 | 2,397,942,763 | PR_kwDOC_bI7s500cQC | 9,648 | Parametrize FPS group | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-07-09T11:27:59 | 2024-07-10T15:00:51 | 2024-07-10T15:00:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9648",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9648",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9648.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9648.patch",
"merged_at": "2024-07-10T15:00:49"
} | # What does this PR do ?
When doing a parallel save, exchange metadata in a whole world instead of a DP group. For yet unknown reason `all_gather_object` crashes with `group != world`
**Collection**: NLP
# Changelog
- Parametrize metadata exchange group for parallel save
- Turn on parallel save by default
# Usage
* By default metadata will be exchanged within the whole world. Set `model.dist_ckpt_parallel_save_within_dp=True` to exchange within DP.
* Set `model.dist_ckpt_parallel_save=False` to turn off parallel save
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "mikolajblaz",
"id": 9979479,
"node_id": "MDQ6VXNlcjk5Nzk0Nzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mikolajblaz",
"html_url": "https://github.com/mikolajblaz",
"followers_url": "https://api.github.com/users/mikolajblaz/followers",
"following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}",
"gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions",
"organizations_url": "https://api.github.com/users/mikolajblaz/orgs",
"repos_url": "https://api.github.com/users/mikolajblaz/repos",
"events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/mikolajblaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9648/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9648/timeline | null | null | true |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.