url
stringlengths
52
53
repository_url
stringclasses
1 value
labels_url
stringlengths
66
67
comments_url
stringlengths
61
62
events_url
stringlengths
59
60
html_url
stringlengths
40
43
id
int64
719M
2.8B
node_id
stringlengths
18
32
number
int64
1.28k
11.9k
title
stringlengths
1
350
user
dict
labels
listlengths
0
10
state
stringclasses
2 values
locked
bool
2 classes
assignee
dict
assignees
listlengths
0
3
milestone
null
comments
sequencelengths
0
30
created_at
timestamp[s]
updated_at
timestamp[s]
closed_at
timestamp[s]
author_association
stringclasses
4 values
sub_issues_summary
dict
active_lock_reason
stringclasses
1 value
draft
bool
2 classes
pull_request
dict
body
stringlengths
0
73.4k
closed_by
dict
reactions
dict
timeline_url
stringlengths
61
62
performed_via_github_app
null
state_reason
stringclasses
3 values
is_pull_request
bool
2 classes
https://api.github.com/repos/NVIDIA/NeMo/issues/9543
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9543/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9543/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9543/events
https://github.com/NVIDIA/NeMo/pull/9543
2,373,902,089
PR_kwDOC_bI7s5zj8Yz
9,543
SDXL improvements (and support for Draft+) [DRAFT PR]
{ "login": "rohitrango", "id": 15312514, "node_id": "MDQ6VXNlcjE1MzEyNTE0", "avatar_url": "https://avatars.githubusercontent.com/u/15312514?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rohitrango", "html_url": "https://github.com/rohitrango", "followers_url": "https://api.github.com/users/rohitrango/followers", "following_url": "https://api.github.com/users/rohitrango/following{/other_user}", "gists_url": "https://api.github.com/users/rohitrango/gists{/gist_id}", "starred_url": "https://api.github.com/users/rohitrango/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rohitrango/subscriptions", "organizations_url": "https://api.github.com/users/rohitrango/orgs", "repos_url": "https://api.github.com/users/rohitrango/repos", "events_url": "https://api.github.com/users/rohitrango/events{/privacy}", "received_events_url": "https://api.github.com/users/rohitrango/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-26T00:21:58
2024-07-09T15:55:33
2024-07-09T15:55:33
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9543", "html_url": "https://github.com/NVIDIA/NeMo/pull/9543", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9543.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9543.patch", "merged_at": "2024-07-09T15:55:33" }
# What does this PR do ? This PR adds additional functionality to SDXL class of models to support Draft+, and: * bug fix for adapter control in LoRA (LinearParallelAdapter) * conversion script for SDXL from huggingface weights to nemo (existing converter script doesnt work) * additional inference config file to load converted hf weights * added FSDP strategy for multimodal models * function to return adapter config, similar to function that returns the adapter itself Code definitely needs cleanup. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9543/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9543/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9542
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9542/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9542/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9542/events
https://github.com/NVIDIA/NeMo/pull/9542
2,373,821,020
PR_kwDOC_bI7s5zjsMd
9,542
Add support to change Multi task model prompt
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-25T23:05:16
2024-06-28T23:01:30
2024-06-28T23:01:28
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9542", "html_url": "https://github.com/NVIDIA/NeMo/pull/9542", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9542.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9542.patch", "merged_at": "2024-06-28T23:01:28" }
# What does this PR do ? Adds the ability to change prompt format for multi task models **Collection**: [ASR] # Changelog - Add function change_prompt(). - Add tests for changing prompt format of function # Usage ```python from nemo.collections.asr.models import ASRModel from nemo.collections.common.prompts.canary import CanaryPromptFormatter model = ASRModel.from_pretrained("nvidia/canary-1b") class CanaryPromptFormatterSubclass(CanaryPromptFormatter): NAME = "canary2" prompt_defaults = asr_model.prompt.get_default_dialog_slots() user_prompt = prompt_defaults[0] slots = user_prompt['slots'] slots['source_lang'] = 'en' slots['target_lang'] = 'en' slots['task'] = 'asr' slots['pnc'] = 'no' model.change_prompt(prompt_format='canary2', prompt_defaults=prompt_defaults) ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [x] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9542/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9542/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9541
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9541/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9541/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9541/events
https://github.com/NVIDIA/NeMo/pull/9541
2,373,812,519
PR_kwDOC_bI7s5zjqZn
9,541
[NeMo-UX] Switch to torch_dist as default distributed checkpointing backend
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-25T23:00:08
2024-06-28T14:56:19
2024-06-28T14:56:17
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9541", "html_url": "https://github.com/NVIDIA/NeMo/pull/9541", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9541.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9541.patch", "merged_at": "2024-06-28T14:56:17" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9541/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9541/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9540
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9540/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9540/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9540/events
https://github.com/NVIDIA/NeMo/pull/9540
2,373,808,332
PR_kwDOC_bI7s5zjpjS
9,540
[PyTorch] Add context parallel support for packed dataset in THD format
{ "login": "tomlifu", "id": 22651648, "node_id": "MDQ6VXNlcjIyNjUxNjQ4", "avatar_url": "https://avatars.githubusercontent.com/u/22651648?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tomlifu", "html_url": "https://github.com/tomlifu", "followers_url": "https://api.github.com/users/tomlifu/followers", "following_url": "https://api.github.com/users/tomlifu/following{/other_user}", "gists_url": "https://api.github.com/users/tomlifu/gists{/gist_id}", "starred_url": "https://api.github.com/users/tomlifu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tomlifu/subscriptions", "organizations_url": "https://api.github.com/users/tomlifu/orgs", "repos_url": "https://api.github.com/users/tomlifu/repos", "events_url": "https://api.github.com/users/tomlifu/events{/privacy}", "received_events_url": "https://api.github.com/users/tomlifu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "You code indentation is not consistent, some places have 4 spaces, and other places have 2 spaces.\r\nNeMo code has 4 spaces always, so please make sure all your code have 4-space indentation.", "Thanks for fixing the comments, it looks much better now.\r\nThe total sequence length (size of t in THD format) is a constant, right? If so, we should have some padded tokens at the end? how those padded tokens are split across different CP ranks?", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "> # What does this PR do ?\r\n> This PR adds context parallel support for packed dataset in THD format in NeMo in response to this TE PR: [NVIDIA/TransformerEngine#641](https://github.com/NVIDIA/TransformerEngine/pull/641). Currently, the TE PR requires each individual sequence length is divisible by (2*context_parallel_size).\r\n> \r\n> # Changes\r\n> * Add support to split packed dataset across different CP ranks in a load balanced way\r\n> * Add necessary paddings to dataset during packing stage to make sure the individual sequence length is a multiple of 2*cp_size\r\n> \r\n> **PR Type**:\r\n> \r\n> * [x] New Feature\r\n> * [ ] Bugfix\r\n> * [ ] Documentation\r\n\r\nHello, I have some problems with cp need seqlen divisibility world_size * 2. I see that you are padding data in the code, but this will cause the pad token id to enter the flash attention calculation. I don't know if this is correct.\r\n" ]
2024-06-25T22:56:43
2024-10-12T02:35:43
2024-08-17T01:49:23
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9540", "html_url": "https://github.com/NVIDIA/NeMo/pull/9540", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9540.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9540.patch", "merged_at": null }
# What does this PR do ? This PR adds context parallel support for packed dataset in THD format in NeMo in response to this TE PR: https://github.com/NVIDIA/TransformerEngine/pull/641. Currently, the TE PR requires each individual sequence length is divisible by (2*context_parallel_size). # Changes - Add support to split packed dataset across different CP ranks in a load balanced way - Add necessary paddings to dataset during packing stage to make sure the individual sequence length is a multiple of 2*cp_size **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9540/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 1 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9540/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9539
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9539/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9539/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9539/events
https://github.com/NVIDIA/NeMo/pull/9539
2,373,679,361
PR_kwDOC_bI7s5zjOGo
9,539
Add REST API to deploy module
{ "login": "athitten", "id": 47577437, "node_id": "MDQ6VXNlcjQ3NTc3NDM3", "avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4", "gravatar_id": "", "url": "https://api.github.com/users/athitten", "html_url": "https://github.com/athitten", "followers_url": "https://api.github.com/users/athitten/followers", "following_url": "https://api.github.com/users/athitten/following{/other_user}", "gists_url": "https://api.github.com/users/athitten/gists{/gist_id}", "starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/athitten/subscriptions", "organizations_url": "https://api.github.com/users/athitten/orgs", "repos_url": "https://api.github.com/users/athitten/repos", "events_url": "https://api.github.com/users/athitten/events{/privacy}", "received_events_url": "https://api.github.com/users/athitten/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "> Were you able to run this code successfully?\r\n\r\nTesting that currently, the rest API end points are visible and `get` method works successfully. However, `post` method with /v1/completions/ end point is failing and I am debugging that.", "\r\n\r\n\r\n> > Were you able to run this code successfully?\r\n> \r\n> Testing that currently, the rest API end points are visible and `get` method works successfully. However, `post` method with /v1/completions/ end point is failing and I am debugging that.\r\n\r\nWas able to run the code successfully with the /v1/completions/ endpoint. Here's the curl request sent and the output received.\r\n```python\r\ncurl -X POST http://localhost:8080/v1/completions/ \\\r\n-H \"Content-Type: application/json\" \\\r\n-d '{\r\n \"model\": \"LLama2-7B\",\r\n \"prompt\": \"Say this is a test\",\r\n \"max_tokens\": 512,\r\n \"temperature\": 1.0,\r\n \"top_p\": 0.0,\r\n \"n\": 1,\r\n \"stream\": false,\r\n \"frequency_penalty\": 1.0\r\n}'\r\n```\r\n```python\r\n{\"output\":\".\\nSay this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test. Say this is a test\"}\r\n```" ]
2024-06-25T21:19:32
2024-07-08T16:23:30
2024-07-08T16:23:29
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9539", "html_url": "https://github.com/NVIDIA/NeMo/pull/9539", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9539.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9539.patch", "merged_at": "2024-07-08T16:23:29" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "athitten", "id": 47577437, "node_id": "MDQ6VXNlcjQ3NTc3NDM3", "avatar_url": "https://avatars.githubusercontent.com/u/47577437?v=4", "gravatar_id": "", "url": "https://api.github.com/users/athitten", "html_url": "https://github.com/athitten", "followers_url": "https://api.github.com/users/athitten/followers", "following_url": "https://api.github.com/users/athitten/following{/other_user}", "gists_url": "https://api.github.com/users/athitten/gists{/gist_id}", "starred_url": "https://api.github.com/users/athitten/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/athitten/subscriptions", "organizations_url": "https://api.github.com/users/athitten/orgs", "repos_url": "https://api.github.com/users/athitten/repos", "events_url": "https://api.github.com/users/athitten/events{/privacy}", "received_events_url": "https://api.github.com/users/athitten/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9539/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9539/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9538
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9538/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9538/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9538/events
https://github.com/NVIDIA/NeMo/pull/9538
2,373,455,429
PR_kwDOC_bI7s5zidEu
9,538
[TTS][ja-JP] add g2p, dict, tokenizer.
{ "login": "BuyuanCui", "id": 69030297, "node_id": "MDQ6VXNlcjY5MDMwMjk3", "avatar_url": "https://avatars.githubusercontent.com/u/69030297?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BuyuanCui", "html_url": "https://github.com/BuyuanCui", "followers_url": "https://api.github.com/users/BuyuanCui/followers", "following_url": "https://api.github.com/users/BuyuanCui/following{/other_user}", "gists_url": "https://api.github.com/users/BuyuanCui/gists{/gist_id}", "starred_url": "https://api.github.com/users/BuyuanCui/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BuyuanCui/subscriptions", "organizations_url": "https://api.github.com/users/BuyuanCui/orgs", "repos_url": "https://api.github.com/users/BuyuanCui/repos", "events_url": "https://api.github.com/users/BuyuanCui/events{/privacy}", "received_events_url": "https://api.github.com/users/BuyuanCui/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4418253970, "node_id": "LA_kwDOC_bI7s8AAAABB1k0kg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS", "name": "TTS", "color": "49AF28", "default": false, "description": "" }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" }, { "id": 7079591682, "node_id": "LA_kwDOC_bI7s8AAAABpfn_Ag", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/audio", "name": "audio", "color": "0DAAC3", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "The files that had updates are:\r\nnemo/collections/common/tokenizers/text_to_speech/ipa_lexicon.py\r\nnemo/collections/common/tokenizers/text_to_speech/tokenizer_utils.py\r\nnemo/collections/common/tokenizers/text_to_speech/tts_tokenizers.py\r\nnemo/collections/tts/g2p/models/i18n_ipa.py\r\ntests/collections/common/tokenizers/text_to_speech/test_tokenizer_utils.py\r\ntests/collections/common/tokenizers/text_to_speech/test_tts_tokenizers.py\r\nnemo/collections/tts/g2p/models/ja_jp_g2p.py\r\nscripts/tts_dataset_files/ja_JP/ja_JP_wordtoipa.txt\r\n\r\n" ]
2024-06-25T19:12:24
2024-07-24T00:33:03
2024-07-24T00:31:25
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9538", "html_url": "https://github.com/NVIDIA/NeMo/pull/9538", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9538.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9538.patch", "merged_at": "2024-07-24T00:31:25" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "XuesongYang", "id": 1646669, "node_id": "MDQ6VXNlcjE2NDY2Njk=", "avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4", "gravatar_id": "", "url": "https://api.github.com/users/XuesongYang", "html_url": "https://github.com/XuesongYang", "followers_url": "https://api.github.com/users/XuesongYang/followers", "following_url": "https://api.github.com/users/XuesongYang/following{/other_user}", "gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}", "starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions", "organizations_url": "https://api.github.com/users/XuesongYang/orgs", "repos_url": "https://api.github.com/users/XuesongYang/repos", "events_url": "https://api.github.com/users/XuesongYang/events{/privacy}", "received_events_url": "https://api.github.com/users/XuesongYang/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9538/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9538/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9537
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9537/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9537/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9537/events
https://github.com/NVIDIA/NeMo/pull/9537
2,373,426,636
PR_kwDOC_bI7s5ziXRf
9,537
Add Python AIStore SDK to container and bump min Lhotse version
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-25T18:59:39
2024-06-27T15:15:18
2024-06-27T15:15:16
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9537", "html_url": "https://github.com/NVIDIA/NeMo/pull/9537", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9537.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9537.patch", "merged_at": "2024-06-27T15:15:16" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9537/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9537/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9536
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9536/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9536/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9536/events
https://github.com/NVIDIA/NeMo/pull/9536
2,373,381,975
PR_kwDOC_bI7s5ziOlJ
9,536
Update TransformerEngine initialize_ub parameters
{ "login": "thomasdhc", "id": 9426164, "node_id": "MDQ6VXNlcjk0MjYxNjQ=", "avatar_url": "https://avatars.githubusercontent.com/u/9426164?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thomasdhc", "html_url": "https://github.com/thomasdhc", "followers_url": "https://api.github.com/users/thomasdhc/followers", "following_url": "https://api.github.com/users/thomasdhc/following{/other_user}", "gists_url": "https://api.github.com/users/thomasdhc/gists{/gist_id}", "starred_url": "https://api.github.com/users/thomasdhc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thomasdhc/subscriptions", "organizations_url": "https://api.github.com/users/thomasdhc/orgs", "repos_url": "https://api.github.com/users/thomasdhc/repos", "events_url": "https://api.github.com/users/thomasdhc/events{/privacy}", "received_events_url": "https://api.github.com/users/thomasdhc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "TE PR that updated the parameters: https://github.com/NVIDIA/TransformerEngine/pull/901", "CI passed (test that failed flaky & is now fixed): https://github.com/NVIDIA/NeMo/actions/runs/9702489435", "This change is no longer needed with new TE changes: https://github.com/NVIDIA/TransformerEngine/pull/986" ]
2024-06-25T18:36:43
2024-07-03T17:09:11
2024-07-03T17:09:11
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9536", "html_url": "https://github.com/NVIDIA/NeMo/pull/9536", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9536.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9536.patch", "merged_at": null }
# What does this PR do ? Update TransformerEngine and update paramters of initialize_ub function **Collection**: [nlp] # Changelog - Update parameter tp_size to tp_group in initialize_ub # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "thomasdhc", "id": 9426164, "node_id": "MDQ6VXNlcjk0MjYxNjQ=", "avatar_url": "https://avatars.githubusercontent.com/u/9426164?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thomasdhc", "html_url": "https://github.com/thomasdhc", "followers_url": "https://api.github.com/users/thomasdhc/followers", "following_url": "https://api.github.com/users/thomasdhc/following{/other_user}", "gists_url": "https://api.github.com/users/thomasdhc/gists{/gist_id}", "starred_url": "https://api.github.com/users/thomasdhc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thomasdhc/subscriptions", "organizations_url": "https://api.github.com/users/thomasdhc/orgs", "repos_url": "https://api.github.com/users/thomasdhc/repos", "events_url": "https://api.github.com/users/thomasdhc/events{/privacy}", "received_events_url": "https://api.github.com/users/thomasdhc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9536/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9536/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9535
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9535/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9535/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9535/events
https://github.com/NVIDIA/NeMo/pull/9535
2,373,091,855
PR_kwDOC_bI7s5zhSrb
9,535
PL: Delete precision if using plugin. TODO switch to MegatronTrainerB…
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-06-25T16:14:39
2024-06-25T19:03:55
2024-06-25T19:03:54
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9535", "html_url": "https://github.com/NVIDIA/NeMo/pull/9535", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9535.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9535.patch", "merged_at": "2024-06-25T19:03:54" }
Remove precision if using a plugin to the parameters of PL trainer. Need to switch to MegatronTrainerBuilder, but this week is tough. # What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9535/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9535/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9534
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9534/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9534/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9534/events
https://github.com/NVIDIA/NeMo/pull/9534
2,373,003,677
PR_kwDOC_bI7s5zhAEt
9,534
Fix SDXL incorrect name in Docs
{ "login": "suiyoubi", "id": 22045332, "node_id": "MDQ6VXNlcjIyMDQ1MzMy", "avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4", "gravatar_id": "", "url": "https://api.github.com/users/suiyoubi", "html_url": "https://github.com/suiyoubi", "followers_url": "https://api.github.com/users/suiyoubi/followers", "following_url": "https://api.github.com/users/suiyoubi/following{/other_user}", "gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}", "starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions", "organizations_url": "https://api.github.com/users/suiyoubi/orgs", "repos_url": "https://api.github.com/users/suiyoubi/repos", "events_url": "https://api.github.com/users/suiyoubi/events{/privacy}", "received_events_url": "https://api.github.com/users/suiyoubi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-25T15:35:47
2024-06-27T22:44:24
2024-06-27T22:44:23
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9534", "html_url": "https://github.com/NVIDIA/NeMo/pull/9534", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9534.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9534.patch", "merged_at": "2024-06-27T22:44:23" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9534/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9534/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9533
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9533/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9533/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9533/events
https://github.com/NVIDIA/NeMo/issues/9533
2,372,716,339
I_kwDOC_bI7s6NbMcz
9,533
Getting empty results from online streaming asr. Please help me!!!!! thanks a lot.
{ "login": "Enkar-Bolat", "id": 117615359, "node_id": "U_kgDOBwKq_w", "avatar_url": "https://avatars.githubusercontent.com/u/117615359?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Enkar-Bolat", "html_url": "https://github.com/Enkar-Bolat", "followers_url": "https://api.github.com/users/Enkar-Bolat/followers", "following_url": "https://api.github.com/users/Enkar-Bolat/following{/other_user}", "gists_url": "https://api.github.com/users/Enkar-Bolat/gists{/gist_id}", "starred_url": "https://api.github.com/users/Enkar-Bolat/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Enkar-Bolat/subscriptions", "organizations_url": "https://api.github.com/users/Enkar-Bolat/orgs", "repos_url": "https://api.github.com/users/Enkar-Bolat/repos", "events_url": "https://api.github.com/users/Enkar-Bolat/events{/privacy}", "received_events_url": "https://api.github.com/users/Enkar-Bolat/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, { "login": "erastorgueva-nv", "id": 80532067, "node_id": "MDQ6VXNlcjgwNTMyMDY3", "avatar_url": "https://avatars.githubusercontent.com/u/80532067?v=4", "gravatar_id": "", "url": "https://api.github.com/users/erastorgueva-nv", "html_url": "https://github.com/erastorgueva-nv", "followers_url": "https://api.github.com/users/erastorgueva-nv/followers", "following_url": "https://api.github.com/users/erastorgueva-nv/following{/other_user}", "gists_url": "https://api.github.com/users/erastorgueva-nv/gists{/gist_id}", "starred_url": "https://api.github.com/users/erastorgueva-nv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/erastorgueva-nv/subscriptions", "organizations_url": "https://api.github.com/users/erastorgueva-nv/orgs", "repos_url": "https://api.github.com/users/erastorgueva-nv/repos", "events_url": "https://api.github.com/users/erastorgueva-nv/events{/privacy}", "received_events_url": "https://api.github.com/users/erastorgueva-nv/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "@erastorgueva-nv pls have a look at this bug", "Hi, I see 2 issues here.\r\n1. The code in `transcribe` is meant to be applied to short chunks of audio, but in `run` you feed in `audio_bytes` which is the audio samples for the whole audio of a single utterance. Instead, you should be splitting up `audio_bytes` into chunks, and then feeding those into `transcribe`.\r\n2. I don't think the beginning of `preprocess_audio` is correct. I haven't tested gigaspeech, but when I tried with some other samples on MCV and MLS, they were already in the range [-1, 1], so dividing by `32768.0` would have been unhelpful.\r\n\r\n\r\nalso @Enkar-Bolat please remove your HF token from the code snippet", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-25T13:32:11
2024-09-28T01:58:02
2024-09-28T01:58:02
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Following is my code. I am running in colab, and i copied some of the code from online streaming asr using microphone.(https://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/Online_ASR_Microphone_Demo_Cache_Aware_Streaming.ipynb). And i am getting empty text from the model. i used https://huggingface.co/datasets/speechcolab/gigaspeech/viewer/xl this dataset to fake as streaming dataset. import time import torch import copy import numpy as np from datetime import datetime from logging import Logger from omegaconf import OmegaConf, open_dict import nemo.collections.asr as nemo_asr from nemo.collections.asr.models.ctc_bpe_models import EncDecCTCModelBPE class Listener: def __init__(self, ): self.init_model() self.init_preprocessor() self.run() def init_model(self): self.asr_model = nemo_asr.models.ASRModel.from_pretrained(model_name='stt_en_fastconformer_hybrid_large_streaming_multi') self.lookahead_size = 80 self.encoder_step_length = 80 self.left_context_size = self.asr_model.encoder.att_context_size[0] self.asr_model.encoder.set_default_att_context_size([self.left_context_size, int(self.lookahead_size / self.encoder_step_length)]) self.asr_model.change_decoding_strategy(decoder_type='rnnt') self.decoding_cfg = self.asr_model.cfg.decoding self.set_decoding_strategy() self.asr_model.eval() self.cache_last_channel, self.cache_last_time, self.cache_last_channel_len = self.asr_model.encoder.get_initial_cache_state(batch_size=1) self.previous_hypotheses = None self.pred_out_stream = None self.step_num = 0 self.pre_encode_cache_size = self.asr_model.encoder.streaming_cfg.pre_encode_cache_size[1] self.num_channels = self.asr_model.cfg.preprocessor.features self.cache_pre_encode = torch.zeros((1, self.num_channels, self.pre_encode_cache_size), device=self.asr_model.device) def init_preprocessor(self): cfg = copy.deepcopy(self.asr_model._cfg) OmegaConf.set_struct(cfg.preprocessor, False) # some changes for streaming scenario cfg.preprocessor.dither = 0.0 cfg.preprocessor.pad_to = 0 cfg.preprocessor.normalize = "None" self.preprocessor = EncDecCTCModelBPE.from_config_dict(cfg.preprocessor) self.preprocessor.to(self.asr_model.device) def set_decoding_strategy(self): with open_dict(self.decoding_cfg): self.decoding_cfg.strategy = "greedy" self.decoding_cfg.preserve_alignments = False if hasattr(self.asr_model, 'joint'): # if an RNNT model self.decoding_cfg.greedy.max_symbols = 10 self.decoding_cfg.fused_batch_size = -1 self.asr_model.change_decoding_strategy(self.decoding_cfg) def preprocess_audio(self, audio): audio = np.frombuffer(audio, dtype=np.int16) audio = audio.astype(np.float32) / 32768.0 audio = np.clip(audio, -1.0, 1.0) device = self.asr_model.device audio_signal = torch.from_numpy(audio).unsqueeze_(0).to(device) audio_signal_len = torch.Tensor([audio.shape[0]]).to(device) processed_signal, processed_signal_length = self.preprocessor( input_signal=audio_signal, length=audio_signal_len ) return processed_signal, processed_signal_length def transcribe(self, audio): processed_signal, processed_signal_length = self.preprocess_audio(audio) processed_signal = torch.cat([self.cache_pre_encode, processed_signal], dim=-1) processed_signal_length += self.cache_pre_encode.shape[1] self.cache_pre_encode = processed_signal[:, :, -self.pre_encode_cache_size:] with torch.no_grad(): ( self.pred_out_stream, transcribed_texts, self.cache_last_channel, self.cache_last_time, self.cache_last_channel_len, self.previous_hypotheses, ) = self.asr_model.conformer_stream_step( processed_signal=processed_signal, processed_signal_length=processed_signal_length, cache_last_channel=self.cache_last_channel, cache_last_time=self.cache_last_time, cache_last_channel_len=self.cache_last_channel_len, keep_all_outputs=False, previous_hypotheses=self.previous_hypotheses, previous_pred_out=self.pred_out_stream, drop_extra_pre_encoded=None, return_transcription=True, ) print(transcribed_texts[0].text) print(len(transcribed_texts)) self.step_num += 1 def run(self): from huggingface_hub import notebook_login notebook_login() gigaspeech = load_dataset("speechcolab/gigaspeech", "xs", use_auth_token=True,token="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",streaming=True) i=0 while True: audio_bytes = next(iter(gigaspeech["test"]))['audio']['array'] self.transcribe(audio_bytes) i+=1 if i==10: break # time.sleep(1) Listener().run() resullt is 1 and empty line.
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9533/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9533/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9532
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9532/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9532/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9532/events
https://github.com/NVIDIA/NeMo/pull/9532
2,372,612,318
PR_kwDOC_bI7s5zfp2K
9,532
extend get_gpt_layer_modelopt_spec to support MoE
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-06-25T12:47:59
2024-06-26T10:32:03
2024-06-26T10:32:02
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9532", "html_url": "https://github.com/NVIDIA/NeMo/pull/9532", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9532.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9532.patch", "merged_at": "2024-06-26T10:32:02" }
# What does this PR do ? Extends modelopt spec to support MoE/Dense. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9532/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9532/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9531
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9531/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9531/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9531/events
https://github.com/NVIDIA/NeMo/issues/9531
2,372,235,078
I_kwDOC_bI7s6NZW9G
9,531
FSDP CPU offloading errors out due to device placements
{ "login": "janEbert", "id": 12694897, "node_id": "MDQ6VXNlcjEyNjk0ODk3", "avatar_url": "https://avatars.githubusercontent.com/u/12694897?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janEbert", "html_url": "https://github.com/janEbert", "followers_url": "https://api.github.com/users/janEbert/followers", "following_url": "https://api.github.com/users/janEbert/following{/other_user}", "gists_url": "https://api.github.com/users/janEbert/gists{/gist_id}", "starred_url": "https://api.github.com/users/janEbert/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janEbert/subscriptions", "organizations_url": "https://api.github.com/users/janEbert/orgs", "repos_url": "https://api.github.com/users/janEbert/repos", "events_url": "https://api.github.com/users/janEbert/events{/privacy}", "received_events_url": "https://api.github.com/users/janEbert/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "blahBlahhhJ", "id": 25292161, "node_id": "MDQ6VXNlcjI1MjkyMTYx", "avatar_url": "https://avatars.githubusercontent.com/u/25292161?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blahBlahhhJ", "html_url": "https://github.com/blahBlahhhJ", "followers_url": "https://api.github.com/users/blahBlahhhJ/followers", "following_url": "https://api.github.com/users/blahBlahhhJ/following{/other_user}", "gists_url": "https://api.github.com/users/blahBlahhhJ/gists{/gist_id}", "starred_url": "https://api.github.com/users/blahBlahhhJ/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blahBlahhhJ/subscriptions", "organizations_url": "https://api.github.com/users/blahBlahhhJ/orgs", "repos_url": "https://api.github.com/users/blahBlahhhJ/repos", "events_url": "https://api.github.com/users/blahBlahhhJ/events{/privacy}", "received_events_url": "https://api.github.com/users/blahBlahhhJ/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "blahBlahhhJ", "id": 25292161, "node_id": "MDQ6VXNlcjI1MjkyMTYx", "avatar_url": "https://avatars.githubusercontent.com/u/25292161?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blahBlahhhJ", "html_url": "https://github.com/blahBlahhhJ", "followers_url": "https://api.github.com/users/blahBlahhhJ/followers", "following_url": "https://api.github.com/users/blahBlahhhJ/following{/other_user}", "gists_url": "https://api.github.com/users/blahBlahhhJ/gists{/gist_id}", "starred_url": "https://api.github.com/users/blahBlahhhJ/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blahBlahhhJ/subscriptions", "organizations_url": "https://api.github.com/users/blahBlahhhJ/orgs", "repos_url": "https://api.github.com/users/blahBlahhhJ/repos", "events_url": "https://api.github.com/users/blahBlahhhJ/events{/privacy}", "received_events_url": "https://api.github.com/users/blahBlahhhJ/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "I'm running into the same issue, is there any solution to this?", "https://github.com/NVIDIA/NeMo/blob/8dbe1daa267fa7182035c8d3c568efc416a636f9/nemo/collections/nlp/models/language_modeling/megatron_base_model.py#L1283\r\n\r\nCould be related to this line. Don't have time to check right now, but randomly stumbled upon this while trying to fix other FSDP errors across the codebase.", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-25T09:56:51
2024-09-14T01:55:01
2024-09-14T01:55:01
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** FSDP CPU offloading (`model.fsdp=True` and `model.fsdp_cpu_offload=True`) raises errors due to disallowed device placements (see error and full traceback below). This behavior is observed with both True and False values for `model.use_cpu_initialization`. ``` RuntimeError: An FSDP-managed module with parameter CPU offloading enabled has parameters on cuda:0. Make sure to not move the module from CPU when offloading parameters. ``` (On other processes, a different CUDA device index (e.g., `cuda:1` is complained about.) <details><summary>Traceback</summary> ``` Traceback (most recent call last): File "/nemo/repos/NeMo/examples/nlp/language_modeling/megatron_gpt_pretraining.py", line 42, in main trainer.fit(model) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 543, in fit call._call_and_handle_interrupt( File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 44, in _call_and_handle_interrupt return trainer_fn(*args, **kwargs) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 579, in _fit_impl self._run(model, ckpt_path=ckpt_path) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 986, in _run results = self._run_stage() File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1030, in _run_stage self.fit_loop.run() File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/loops/fit_loop.py", line 205, in run self.advance() File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/loops/fit_loop.py", line 363, in advance self.epoch_loop.run(self._data_fetcher) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/loops/training_epoch_loop.py", line 140, in run self.advance(data_fetcher) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/loops/training_epoch_loop.py", line 250, in advance batch_output = self.automatic_optimization.run(trainer.optimizers[0], batch_idx, kwargs) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/loops/optimization/automatic.py", line 190, in run self._optimizer_step(batch_idx, closure) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/loops/optimization/automatic.py", line 268, in _optimizer_step call._call_lightning_module_hook( File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 159, in _call_lightning_module_hook output = fn(*args, **kwargs) File "/nemo/repos/NeMo/nemo/collections/nlp/models/language_modeling/megatron_base_model.py", line 1263, in optimizer_step super().optimizer_step(*args, **kwargs) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/core/module.py", line 1308, in optimizer_step optimizer.step(closure=optimizer_closure) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/core/optimizer.py", line 153, in step step_output = self._strategy.optimizer_step(self._optimizer, closure, **kwargs) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/strategies/strategy.py", line 238, in optimizer_step return self.precision_plugin.optimizer_step(optimizer, model=model, closure=closure, **kwargs) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/plugins/precision/fsdp.py", line 149, in optimizer_step return super().optimizer_step(optimizer, model=model, closure=closure, **kwargs) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/plugins/precision/precision.py", line 122, in optimizer_step return optimizer.step(closure=closure, **kwargs) File "/usr/local/lib/python3.10/dist-packages/torch/optim/lr_scheduler.py", line 75, in wrapper return wrapped(*args, **kwargs) File "/usr/local/lib/python3.10/dist-packages/torch/optim/optimizer.py", line 391, in wrapper out = func(*args, **kwargs) File "/usr/local/lib/python3.10/dist-packages/apex/optimizers/fused_adam.py", line 140, in step loss = closure() File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/plugins/precision/precision.py", line 108, in _wrap_closure closure_result = closure() File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/loops/optimization/automatic.py", line 144, in __call__ self._result = self.closure(*args, **kwargs) File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context return func(*args, **kwargs) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/loops/optimization/automatic.py", line 129, in closure step_output = self._step_fn() File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/loops/optimization/automatic.py", line 317, in _training_step training_step_output = call._call_strategy_hook(trainer, "training_step", *kwargs.values()) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 311, in _call_strategy_hook output = fn(*args, **kwargs) File "/nemo/env/lib/python3.10/site-packages/pytorch_lightning/strategies/strategy.py", line 390, in training_step return self.lightning_module.training_step(*args, **kwargs) File "/nemo/repos/NeMo/nemo/utils/model_utils.py", line 434, in wrap_training_step output_dict = wrapped(*args, **kwargs) File "/nemo/repos/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py", line 834, in training_step loss_mean = self.training_step_fwd_bwd_step_call(dataloader_iter, forward_only=False) File "/nemo/repos/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py", line 770, in training_step_fwd_bwd_step_call loss_mean = self.fwd_bwd_step(dataloader_iter, forward_only) File "/nemo/repos/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py", line 703, in fwd_bwd_step losses_reduced_per_micro_batch = fwd_bwd_function( File "/nemo/repos/Megatron-LM/megatron/core/pipeline_parallel/schedules.py", line 399, in forward_backward_no_pipelining output_tensor, num_tokens = forward_step( File "/nemo/repos/Megatron-LM/megatron/core/pipeline_parallel/schedules.py", line 206, in forward_step output_tensor, loss_func = forward_step_func(data_iterator, model) File "/nemo/repos/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py", line 1251, in fwd_output_and_loss_func output_tensor = model(**forward_args) File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1541, in _call_impl return forward_call(*args, **kwargs) File "/usr/local/lib/python3.10/dist-packages/torch/distributed/fsdp/fully_sharded_data_parallel.py", line 821, in forward args, kwargs = _root_pre_forward(self, self, args, kwargs) File "/usr/local/lib/python3.10/dist-packages/torch/distributed/fsdp/_runtime_utils.py", line 510, in _root_pre_forward _lazy_init(state, module) File "/usr/local/lib/python3.10/dist-packages/torch/distributed/fsdp/_runtime_utils.py", line 132, in _lazy_init _check_flat_params_on_expected_device(state, root_module) File "/usr/local/lib/python3.10/dist-packages/torch/distributed/fsdp/_runtime_utils.py", line 159, in _check_flat_params_on_expected_device raise RuntimeError( RuntimeError: An FSDP-managed module with parameter CPU offloading enabled has parameters on cuda:0. Make sure to not move the module from CPU when offloading parameters. ``` (On other processes, a different CUDA device index (e.g., `cuda:1` is complained about.) </details> **Steps/Code to reproduce bug** ```shell use_cpu_initialization=True # True or False PER_SPLIT_NUM_WORKERS=5 TRAIN_DATA_PREFIX=my-tiny-c4-gpt2-tok/train_text_document EVAL_DATA_PREFIX=my-tiny-c4-gpt2-tok/val_text_document TEST_DATA_PREFIX="$EVAL_DATA_PREFIX" TOKENIZER_VOCAB_FILE=gpt2-vocab.json TOKENIZER_MERGE_FILE=gpt2-merges.txt python -u \ "$nemo_repo_dir"/examples/nlp/language_modeling/megatron_gpt_pretraining.py \ --config-path="$TRAIN_CONFIG_YAML_DIR" \ --config-name="$TRAIN_CONFIG_YAML_NAME" \ trainer.devices=4 \ trainer.num_nodes=2 \ trainer.max_steps=100 \ trainer.log_every_n_steps=1 \ trainer.val_check_interval=100 \ +trainer.num_sanity_val_steps=0 \ trainer.precision=bf16-mixed \ model.micro_batch_size=1 \ model.global_batch_size=8 \ model.mcore_gpt=True \ +model.fsdp=True \ +model.fsdp_use_orig_params=True \ +model.fsdp_sharding_strategy=full \ +model.fsdp_grad_reduce_dtype=32 \ +model.fsdp_sharded_checkpoint=True \ +model.fsdp_cpu_offload=True \ model.use_cpu_initialization="$use_cpu_initialization" \ model.tensor_model_parallel_size=1 \ model.pipeline_model_parallel_size=1 \ model.sequence_parallel=False \ +model.use_flash_attention=True \ model.tokenizer.library=megatron \ model.tokenizer.type=GPT2BPETokenizer \ model.tokenizer.model=null \ model.tokenizer.vocab_file="$TOKENIZER_VOCAB_FILE" \ model.tokenizer.merge_file="$TOKENIZER_MERGE_FILE" \ +model.data.data_prefix=\{train:\[1.0,"$TRAIN_DATA_PREFIX"\],validation:\[1.0,"$EVAL_DATA_PREFIX"\],test:\[1.0,"$TEST_DATA_PREFIX"\]\} \ model.data.num_workers="$PER_SPLIT_NUM_WORKERS" \ exp_manager.name="megatron_llama_my-tiny-c4-gpt2-tok_cpu-offloading" ``` **Expected behavior** No error should be raised or the config should be removed if it is not going to be supported. If usage of CPU offloading requires `use_cpu_initialization=True` for a fix, an error should be raised if it is not set correctly. **Environment overview** - Environment location: [Apptainer, using NVIDIA PyTorch 24.05 Docker container with no modifications inside the container, but a `venv` outside the container] - Method of NeMo install: [pip install from source]. `git clone https://github.com/NVIDIA/NeMo.git && cd NeMo && git checkout dda92f00de2785de46983d7aa4ac77cbb1b353ec && python -m pip install .[all]` - Method of Megatron-LM install: [pip install from source]. `git clone https://github.com/NVIDIA/Megatron-LM.git && cd Megatron-LM && git checkout a645f89671be698612170539f2089dc15db66a80 && python -m pip install .`
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9531/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9531/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9530
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9530/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9530/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9530/events
https://github.com/NVIDIA/NeMo/pull/9530
2,372,149,049
PR_kwDOC_bI7s5zeDvs
9,530
fix mock data generation for legacy dataset
{ "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-25T09:17:28
2024-06-26T11:11:30
2024-06-26T11:11:30
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9530", "html_url": "https://github.com/NVIDIA/NeMo/pull/9530", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9530.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9530.patch", "merged_at": "2024-06-26T11:11:30" }
# What does this PR do ? Fixes mock data generation for legacy dataset. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9530/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9530/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9529
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9529/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9529/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9529/events
https://github.com/NVIDIA/NeMo/pull/9529
2,371,357,458
PR_kwDOC_bI7s5zbYAi
9,529
[NeMo-UX] minor logging bug fixes
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-25T00:31:20
2024-06-25T12:27:42
2024-06-25T12:27:42
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9529", "html_url": "https://github.com/NVIDIA/NeMo/pull/9529", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9529.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9529.patch", "merged_at": "2024-06-25T12:27:42" }
# What does this PR do ? Makes two small improvements to the refactored exp_manager code - Computes `files_to_move` within nemo logger setup to avoid erroneously moving files belonging to the existing run - Fixes logger version to match that of the experiment so everything gets written to the same directory **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9529/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9529/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9528
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9528/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9528/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9528/events
https://github.com/NVIDIA/NeMo/pull/9528
2,371,102,653
PR_kwDOC_bI7s5zafRw
9,528
[NeMo-UX] Llama and Gemma
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-24T21:12:16
2024-06-25T10:04:38
2024-06-25T10:04:38
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9528", "html_url": "https://github.com/NVIDIA/NeMo/pull/9528", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9528.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9528.patch", "merged_at": "2024-06-25T10:04:37" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9528/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9528/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9527
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9527/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9527/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9527/events
https://github.com/NVIDIA/NeMo/pull/9527
2,371,031,600
PR_kwDOC_bI7s5zaPc5
9,527
Inflight nemo model export support
{ "login": "JimmyZhang12", "id": 67203904, "node_id": "MDQ6VXNlcjY3MjAzOTA0", "avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JimmyZhang12", "html_url": "https://github.com/JimmyZhang12", "followers_url": "https://api.github.com/users/JimmyZhang12/followers", "following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}", "gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}", "starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions", "organizations_url": "https://api.github.com/users/JimmyZhang12/orgs", "repos_url": "https://api.github.com/users/JimmyZhang12/repos", "events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}", "received_events_url": "https://api.github.com/users/JimmyZhang12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1719393562, "node_id": "MDU6TGFiZWwxNzE5MzkzNTYy", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature", "name": "feature", "color": "68F3F0", "default": false, "description": "request/PR for a new feature" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-24T20:25:31
2024-07-03T05:37:17
2024-07-03T05:37:15
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9527", "html_url": "https://github.com/NVIDIA/NeMo/pull/9527", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9527.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9527.patch", "merged_at": "2024-07-03T05:37:15" }
# What does this PR do ? Adds inflight NeMo to TRTLLM v10 model conversion and engine refitting using device weights **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "JimmyZhang12", "id": 67203904, "node_id": "MDQ6VXNlcjY3MjAzOTA0", "avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JimmyZhang12", "html_url": "https://github.com/JimmyZhang12", "followers_url": "https://api.github.com/users/JimmyZhang12/followers", "following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}", "gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}", "starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions", "organizations_url": "https://api.github.com/users/JimmyZhang12/orgs", "repos_url": "https://api.github.com/users/JimmyZhang12/repos", "events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}", "received_events_url": "https://api.github.com/users/JimmyZhang12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9527/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9527/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9526
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9526/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9526/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9526/events
https://github.com/NVIDIA/NeMo/pull/9526
2,370,751,205
PR_kwDOC_bI7s5zZRw_
9,526
Add page context fmha option in TensorRTLLM export
{ "login": "meatybobby", "id": 9738259, "node_id": "MDQ6VXNlcjk3MzgyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meatybobby", "html_url": "https://github.com/meatybobby", "followers_url": "https://api.github.com/users/meatybobby/followers", "following_url": "https://api.github.com/users/meatybobby/following{/other_user}", "gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}", "starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions", "organizations_url": "https://api.github.com/users/meatybobby/orgs", "repos_url": "https://api.github.com/users/meatybobby/repos", "events_url": "https://api.github.com/users/meatybobby/events{/privacy}", "received_events_url": "https://api.github.com/users/meatybobby/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "meatybobby", "id": 9738259, "node_id": "MDQ6VXNlcjk3MzgyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meatybobby", "html_url": "https://github.com/meatybobby", "followers_url": "https://api.github.com/users/meatybobby/followers", "following_url": "https://api.github.com/users/meatybobby/following{/other_user}", "gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}", "starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions", "organizations_url": "https://api.github.com/users/meatybobby/orgs", "repos_url": "https://api.github.com/users/meatybobby/repos", "events_url": "https://api.github.com/users/meatybobby/events{/privacy}", "received_events_url": "https://api.github.com/users/meatybobby/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "meatybobby", "id": 9738259, "node_id": "MDQ6VXNlcjk3MzgyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meatybobby", "html_url": "https://github.com/meatybobby", "followers_url": "https://api.github.com/users/meatybobby/followers", "following_url": "https://api.github.com/users/meatybobby/following{/other_user}", "gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}", "starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions", "organizations_url": "https://api.github.com/users/meatybobby/orgs", "repos_url": "https://api.github.com/users/meatybobby/repos", "events_url": "https://api.github.com/users/meatybobby/events{/privacy}", "received_events_url": "https://api.github.com/users/meatybobby/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-06-24T17:29:41
2024-06-25T20:15:28
2024-06-25T20:15:27
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9526", "html_url": "https://github.com/NVIDIA/NeMo/pull/9526", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9526.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9526.patch", "merged_at": "2024-06-25T20:15:27" }
# What does this PR do ? Add page context fmha option in TensorRTLLM export **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "meatybobby", "id": 9738259, "node_id": "MDQ6VXNlcjk3MzgyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/meatybobby", "html_url": "https://github.com/meatybobby", "followers_url": "https://api.github.com/users/meatybobby/followers", "following_url": "https://api.github.com/users/meatybobby/following{/other_user}", "gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}", "starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions", "organizations_url": "https://api.github.com/users/meatybobby/orgs", "repos_url": "https://api.github.com/users/meatybobby/repos", "events_url": "https://api.github.com/users/meatybobby/events{/privacy}", "received_events_url": "https://api.github.com/users/meatybobby/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9526/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9526/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9525
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9525/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9525/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9525/events
https://github.com/NVIDIA/NeMo/pull/9525
2,370,463,332
PR_kwDOC_bI7s5zYSH4
9,525
[NeMo-UX] Adding context- & expert-parallelism to MegatronStrategy
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-24T14:54:19
2024-06-24T16:09:47
2024-06-24T16:09:46
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9525", "html_url": "https://github.com/NVIDIA/NeMo/pull/9525", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9525.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9525.patch", "merged_at": "2024-06-24T16:09:46" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9525/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9525/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9524
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9524/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9524/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9524/events
https://github.com/NVIDIA/NeMo/issues/9524
2,370,004,847
I_kwDOC_bI7s6NQ2dv
9,524
MCore slower than NeMo native implementation
{ "login": "janEbert", "id": 12694897, "node_id": "MDQ6VXNlcjEyNjk0ODk3", "avatar_url": "https://avatars.githubusercontent.com/u/12694897?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janEbert", "html_url": "https://github.com/janEbert", "followers_url": "https://api.github.com/users/janEbert/followers", "following_url": "https://api.github.com/users/janEbert/following{/other_user}", "gists_url": "https://api.github.com/users/janEbert/gists{/gist_id}", "starred_url": "https://api.github.com/users/janEbert/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janEbert/subscriptions", "organizations_url": "https://api.github.com/users/janEbert/orgs", "repos_url": "https://api.github.com/users/janEbert/repos", "events_url": "https://api.github.com/users/janEbert/events{/privacy}", "received_events_url": "https://api.github.com/users/janEbert/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "blahBlahhhJ", "id": 25292161, "node_id": "MDQ6VXNlcjI1MjkyMTYx", "avatar_url": "https://avatars.githubusercontent.com/u/25292161?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blahBlahhhJ", "html_url": "https://github.com/blahBlahhhJ", "followers_url": "https://api.github.com/users/blahBlahhhJ/followers", "following_url": "https://api.github.com/users/blahBlahhhJ/following{/other_user}", "gists_url": "https://api.github.com/users/blahBlahhhJ/gists{/gist_id}", "starred_url": "https://api.github.com/users/blahBlahhhJ/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blahBlahhhJ/subscriptions", "organizations_url": "https://api.github.com/users/blahBlahhhJ/orgs", "repos_url": "https://api.github.com/users/blahBlahhhJ/repos", "events_url": "https://api.github.com/users/blahBlahhhJ/events{/privacy}", "received_events_url": "https://api.github.com/users/blahBlahhhJ/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "blahBlahhhJ", "id": 25292161, "node_id": "MDQ6VXNlcjI1MjkyMTYx", "avatar_url": "https://avatars.githubusercontent.com/u/25292161?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blahBlahhhJ", "html_url": "https://github.com/blahBlahhhJ", "followers_url": "https://api.github.com/users/blahBlahhhJ/followers", "following_url": "https://api.github.com/users/blahBlahhhJ/following{/other_user}", "gists_url": "https://api.github.com/users/blahBlahhhJ/gists{/gist_id}", "starred_url": "https://api.github.com/users/blahBlahhhJ/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blahBlahhhJ/subscriptions", "organizations_url": "https://api.github.com/users/blahBlahhhJ/orgs", "repos_url": "https://api.github.com/users/blahBlahhhJ/repos", "events_url": "https://api.github.com/users/blahBlahhhJ/events{/privacy}", "received_events_url": "https://api.github.com/users/blahBlahhhJ/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "Please take a look.", "Could you try using NeMo 2.0 + FSDP and comparing? We're not planning to support NeMo 1.0 + FSDP.", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-24T11:32:56
2024-09-30T02:00:36
2024-09-30T02:00:35
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** I've benchmarked both settings of `model.mcore_gpt` in an FSDP setting on the two most recent NVIDIA GPU architectures and found `model.mcore_gpt=False` to be consistently faster (although only slightly on the H100). Note that the A100 vs. H100 numbers are not meant to be comparable; they are run on different systems using a different number of CPU workers, but they do use the same software environment. ``` | mcore | GPU | avg secs per iter | |-------+------+-------------------| | True | H100 | 0.898143 | | False | H100 | 0.868319 | | True | A100 | 2.6544 | | False | A100 | 1.71934 | ``` **Steps/Code to reproduce bug** Please list *minimal* steps or code snippet for us to be able to reproduce the bug. ```shell mcore_val=True # True or False PER_SPLIT_NUM_WORKERS=5 # 5 for A100, 9 for H100 TRAIN_DATA_PREFIX=my-tiny-c4-gpt2-tok/train_text_document EVAL_DATA_PREFIX=my-tiny-c4-gpt2-tok/val_text_document TEST_DATA_PREFIX="$EVAL_DATA_PREFIX" TOKENIZER_VOCAB_FILE=gpt2-vocab.json TOKENIZER_MERGE_FILE=gpt2-merges.txt python -u \ examples/nlp/language_modeling/megatron_gpt_pretraining.py \ --config-path=examples/nlp/language_modeling/conf \ --config-name=megatron_llama_config \ trainer.devices=4 \ trainer.num_nodes=2 \ trainer.max_steps=100 \ trainer.log_every_n_steps=1 \ trainer.val_check_interval=100 \ +trainer.num_sanity_val_steps=0 \ trainer.precision=bf16-mixed \ model.micro_batch_size=1 \ model.global_batch_size=8 \ model.mcore_gpt="$mcore_val" \ +model.fsdp=True \ +model.fsdp_sharding_strategy=full \ +model.fsdp_grad_reduce_dtype=32 \ +model.fsdp_sharded_checkpoint=True \ model.tensor_model_parallel_size=1 \ model.pipeline_model_parallel_size=1 \ model.sequence_parallel=False \ +model.use_flash_attention=True \ model.tokenizer.library=megatron \ model.tokenizer.type=GPT2BPETokenizer \ model.tokenizer.model=null \ model.tokenizer.vocab_file="$TOKENIZER_VOCAB_FILE" \ model.tokenizer.merge_file="$TOKENIZER_MERGE_FILE" \ +model.data.data_prefix=\{train:\[1.0,"$TRAIN_DATA_PREFIX"\],validation:\[1.0,"$EVAL_DATA_PREFIX"\],test:\[1.0,"$TEST_DATA_PREFIX"\]\} \ model.data.num_workers="$PER_SPLIT_NUM_WORKERS" \ exp_manager.name="megatron_llama_my-tiny-c4-gpt2-tok_mcore-\${model.mcore_gpt}" ``` **Expected behavior** Since the `model.mcore_gpt=False` version has been deprecated, I would expect the `model.mcore_gpt=True` version to be at least on par with performance. The numbers on the A100 are _substantially_ worse for the `model.mcore_gpt=True` version. **Environment overview (please complete the following information)** - Environment location: [Apptainer, using NVIDIA PyTorch 24.05 Docker container with no modifications inside the container, but a `venv` outside the container] - Method of NeMo install: [pip install from source]. `git clone https://github.com/NVIDIA/NeMo.git && cd NeMo && git checkout dda92f00de2785de46983d7aa4ac77cbb1b353ec && python -m pip install .[all]` - Method of Megatron-LM install: [pip install from source]. `git clone https://github.com/NVIDIA/Megatron-LM.git && cd Megatron-LM && git checkout a645f89671be698612170539f2089dc15db66a80 && python -m pip install .` **Additional context** - The A100 is the 40 GB version. - The H100 is the 64 GB version. - Throughput benchmarking used 10 warmup steps and the average of 91 samples.
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9524/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9524/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9523
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9523/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9523/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9523/events
https://github.com/NVIDIA/NeMo/issues/9523
2,369,759,985
I_kwDOC_bI7s6NP6rx
9,523
Speaker Diarization goes haywire due to small segments of audio
{ "login": "AatikaNazneen", "id": 102875581, "node_id": "U_kgDOBiHBvQ", "avatar_url": "https://avatars.githubusercontent.com/u/102875581?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AatikaNazneen", "html_url": "https://github.com/AatikaNazneen", "followers_url": "https://api.github.com/users/AatikaNazneen/followers", "following_url": "https://api.github.com/users/AatikaNazneen/following{/other_user}", "gists_url": "https://api.github.com/users/AatikaNazneen/gists{/gist_id}", "starred_url": "https://api.github.com/users/AatikaNazneen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AatikaNazneen/subscriptions", "organizations_url": "https://api.github.com/users/AatikaNazneen/orgs", "repos_url": "https://api.github.com/users/AatikaNazneen/repos", "events_url": "https://api.github.com/users/AatikaNazneen/events{/privacy}", "received_events_url": "https://api.github.com/users/AatikaNazneen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
{ "login": "tango4j", "id": 13211483, "node_id": "MDQ6VXNlcjEzMjExNDgz", "avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tango4j", "html_url": "https://github.com/tango4j", "followers_url": "https://api.github.com/users/tango4j/followers", "following_url": "https://api.github.com/users/tango4j/following{/other_user}", "gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}", "starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tango4j/subscriptions", "organizations_url": "https://api.github.com/users/tango4j/orgs", "repos_url": "https://api.github.com/users/tango4j/repos", "events_url": "https://api.github.com/users/tango4j/events{/privacy}", "received_events_url": "https://api.github.com/users/tango4j/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "tango4j", "id": 13211483, "node_id": "MDQ6VXNlcjEzMjExNDgz", "avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tango4j", "html_url": "https://github.com/tango4j", "followers_url": "https://api.github.com/users/tango4j/followers", "following_url": "https://api.github.com/users/tango4j/following{/other_user}", "gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}", "starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tango4j/subscriptions", "organizations_url": "https://api.github.com/users/tango4j/orgs", "repos_url": "https://api.github.com/users/tango4j/repos", "events_url": "https://api.github.com/users/tango4j/events{/privacy}", "received_events_url": "https://api.github.com/users/tango4j/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, { "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "Please note that clustering based speaker diarization is a type of self-supervised machine learning system, not a rule-based software. Thus, speaker diarization can generate incorrect results and such behavior should be regarded as the limitation in accuracy, not a type of bug.\r\n\r\nEspecially, there is no guarantee that the speaker diarization system would generate the same speaker assignment to the truncated shorter audio clips from the original audio clips.\r\n\r\nClosing since there is no clear ways to avoid this case." ]
2024-06-24T09:45:42
2024-08-15T00:15:49
2024-08-15T00:15:08
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** I have a long audio of around 3 hours that spans multiple speakers. The speaker diarization label a single speaker when this audio is passed. When I break down into this audio in parts and pass each part separately, some of the parts get assigned speakers correctly but the rest of the portion has the same bug. I identified some 1 min chunks that when added in this audio cause the model to behave this way. I'm seeking possible explanations or solutions to this behavior since I believe that the model should be resilient enough. I think this might be related to having lots of overlap and a good number of speakers resulting in exceeding Nemo's limit of 20 max speakers. **Steps/Code to reproduce bug** Test Speaker Diarization on the [audio]( https://21133.mc.tritondigital.com/OMNY_DAVECHUCKTHEFREAKFULLSHOW_P/media-session/ba27cae7-9871-409f-b206-2183ad4628fe/d/clips/58a22c8d-1810-4cd1-bce2-a849004eeede/f545c88c-6f30-414d-b85a-aff10125b149/17c6c4c0-70cb-4c39-b16b-b18000f52f46/audio/direct/t1717081258/Thursday,_May_30th_2024_Dave_Chuck_the_Freak_Full_Show.mp3?t=1717081258&utm_source=Podcast%26in_playlist%3D9857b359-5905-4672-a201-aff10125b173) **Expected behavior** A clear and concise description of what you expected to happen. **Environment overview (please complete the following information)** - Environment location: AWS - Method of NeMo install: pip install **Environment details** - AWS Linux 2 - PyTorch version: 2.3.1 - Python version: 3.10 **Additional context** GPU model
{ "login": "tango4j", "id": 13211483, "node_id": "MDQ6VXNlcjEzMjExNDgz", "avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tango4j", "html_url": "https://github.com/tango4j", "followers_url": "https://api.github.com/users/tango4j/followers", "following_url": "https://api.github.com/users/tango4j/following{/other_user}", "gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}", "starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tango4j/subscriptions", "organizations_url": "https://api.github.com/users/tango4j/orgs", "repos_url": "https://api.github.com/users/tango4j/repos", "events_url": "https://api.github.com/users/tango4j/events{/privacy}", "received_events_url": "https://api.github.com/users/tango4j/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9523/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9523/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9522
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9522/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9522/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9522/events
https://github.com/NVIDIA/NeMo/issues/9522
2,369,282,556
I_kwDOC_bI7s6NOGH8
9,522
Issue: TimeError Occurring During Training on node 16 or more
{ "login": "liveseongho", "id": 11289261, "node_id": "MDQ6VXNlcjExMjg5MjYx", "avatar_url": "https://avatars.githubusercontent.com/u/11289261?v=4", "gravatar_id": "", "url": "https://api.github.com/users/liveseongho", "html_url": "https://github.com/liveseongho", "followers_url": "https://api.github.com/users/liveseongho/followers", "following_url": "https://api.github.com/users/liveseongho/following{/other_user}", "gists_url": "https://api.github.com/users/liveseongho/gists{/gist_id}", "starred_url": "https://api.github.com/users/liveseongho/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/liveseongho/subscriptions", "organizations_url": "https://api.github.com/users/liveseongho/orgs", "repos_url": "https://api.github.com/users/liveseongho/repos", "events_url": "https://api.github.com/users/liveseongho/events{/privacy}", "received_events_url": "https://api.github.com/users/liveseongho/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-06-24T05:51:44
2024-07-16T17:56:19
2024-07-16T17:56:19
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
When training on node 16 and 64, the following TimeError occurs. This issue does not arise when using Node 4 and 8. ``` Traceback (most recent call last): File "/opt/NeMo/examples/multimodal/multimodal_llm/neva/neva_pretrain.py", line 19, in <module> from nemo.collections.multimodal.models.multimodal_llm.neva.neva_model import MegatronNevaModel File "/opt/NeMo/nemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py", line 25, in <module> from pytorch_lightning.trainer.trainer import Trainer File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/__init__.py", line 27, in <module> from pytorch_lightning.callbacks import Callback # noqa: E402 File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/callbacks/__init__.py", line 14, in <module> from pytorch_lightning.callbacks.batch_size_finder import BatchSizeFinder File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/callbacks/batch_size_finder.py", line 26, in <module> from pytorch_lightning.callbacks.callback import Callback File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/callbacks/callback.py", line 22, in <module> from pytorch_lightning.utilities.types import STEP_OUTPUT File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/utilities/types.py", line 41, in <module> from torchmetrics import Metric File "/usr/local/lib/python3.10/dist-packages/torchmetrics/__init__.py", line 26, in <module> from torchmetrics import functional # noqa: E402 File "/usr/local/lib/python3.10/dist-packages/torchmetrics/functional/__init__.py", line 14, in <module> from torchmetrics.functional.audio._deprecated import _permutation_invariant_training as permutation_invariant_training File "/usr/local/lib/python3.10/dist-packages/torchmetrics/functional/audio/__init__.py", line 14, in <module> from torchmetrics.functional.audio.pit import permutation_invariant_training, pit_permutate File "/usr/local/lib/python3.10/dist-packages/torchmetrics/functional/audio/pit.py", line 22, in <module> from torchmetrics.utilities import rank_zero_warn File "/usr/local/lib/python3.10/dist-packages/torchmetrics/utilities/__init__.py", line 14, in <module> from torchmetrics.utilities.checks import check_forward_full_state_property File "/usr/local/lib/python3.10/dist-packages/torchmetrics/utilities/checks.py", line 25, in <module> from torchmetrics.metric import Metric File "/usr/local/lib/python3.10/dist-packages/torchmetrics/metric.py", line 42, in <module> from torchmetrics.utilities.plot import _AX_TYPE, _PLOT_OUT_TYPE, plot_single_or_multi_val File "/usr/local/lib/python3.10/dist-packages/torchmetrics/utilities/plot.py", line 26, in <module> import matplotlib.axes File "/usr/local/lib/python3.10/dist-packages/matplotlib/axes/__init__.py", line 1, in <module> from . import _base File "/usr/local/lib/python3.10/dist-packages/matplotlib/axes/_base.py", line 13, in <module> from matplotlib import _api, cbook, _docstring, offsetbox File "/usr/local/lib/python3.10/dist-packages/matplotlib/offsetbox.py", line 33, in <module> import matplotlib.text as mtext File "/usr/local/lib/python3.10/dist-packages/matplotlib/text.py", line 16, in <module> from .font_manager import FontProperties File "/usr/local/lib/python3.10/dist-packages/matplotlib/font_manager.py", line 1582, in <module> fontManager = _load_fontmanager() File "/usr/local/lib/python3.10/dist-packages/matplotlib/font_manager.py", line 1577, in _load_fontmanager json_dump(fm, fm_path) File "/usr/local/lib/python3.10/dist-packages/matplotlib/font_manager.py", line 963, in json_dump with cbook._lock_path(filename), open(filename, 'w') as fh: File "/usr/lib/python3.10/contextlib.py", line 135, in __enter__ return next(self.gen) File "/usr/local/lib/python3.10/dist-packages/matplotlib/cbook.py", line 1826, in _lock_path raise TimeoutError("""\ TimeoutError: Lock error: Matplotlib failed to acquire the following lock file: /root/.cache/matplotlib/fontlist-v330.json.matplotlib-lock This maybe due to another process holding this lock file. If you are sure no other Matplotlib process is running, remove this file and try again. ``` My code is running with - Megatron-LM: from `/opt/megatron-lm` in NeMo Framework Container dev version (nvcr.io/nvidia/nemo:dev) - NeMo: NeMo main branch (501f0dfc76886fda7f95e934de39fd8275628e2a)
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9522/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9522/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9521
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9521/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9521/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9521/events
https://github.com/NVIDIA/NeMo/issues/9521
2,368,584,725
I_kwDOC_bI7s6NLbwV
9,521
Unable to reproduce cache aware streaming results for Conformer that were there for Fastconformer.
{ "login": "mujhenahiata", "id": 94825377, "node_id": "U_kgDOBabroQ", "avatar_url": "https://avatars.githubusercontent.com/u/94825377?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mujhenahiata", "html_url": "https://github.com/mujhenahiata", "followers_url": "https://api.github.com/users/mujhenahiata/followers", "following_url": "https://api.github.com/users/mujhenahiata/following{/other_user}", "gists_url": "https://api.github.com/users/mujhenahiata/gists{/gist_id}", "starred_url": "https://api.github.com/users/mujhenahiata/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mujhenahiata/subscriptions", "organizations_url": "https://api.github.com/users/mujhenahiata/orgs", "repos_url": "https://api.github.com/users/mujhenahiata/repos", "events_url": "https://api.github.com/users/mujhenahiata/events{/privacy}", "received_events_url": "https://api.github.com/users/mujhenahiata/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "I will try to look into this issue next week. It can be due to something broken in the cache-aware streaming script. Have you tried some of the already pretrained cache-aware models? Do they work properly?\r\n\r\nYou may use cache-aware with nemo but as far as I know, they are not supported in Riva yet. It is a work in progress. For now, you may use nemo for streaming cache-aware models.\r\n\r\nYou may take a look at this tutorial on how to use cache-aware models:\r\nhttps://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/Online_ASR_Microphone_Demo_Cache_Aware_Streaming.ipynb\r\n\r\nWould you please try this tutorial and let me know if it works properly or not for your model?\r\n\r\n", "@VahidooX , I went through the tutorial already. I fine-tuned a model using the streaming config. When I infer the model offline it works, but when I put that model in a streaming setup I get the above results. I will attach videos in a moment", "Is it a confirmer or fastconformer?\nHave you tried this script?\n\nhttps://github.com/NVIDIA/NeMo/blob/main/examples/asr/asr_cache_aware_streaming/speech_to_text_cache_aware_streaming_infer.py", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-23T14:15:46
2024-09-09T01:57:10
2024-09-09T01:57:10
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
I trained Conformer-CTC using cache aware method. but unable to reproduce the results that were there with "Fastconformer cache aware streaming". By using Conformer-CTC cache aware method i get partial sub-words, words combined together like ("hello world" ==> herld) , in streaming output. the same was the case when i deployed it in a RIVA pipeline. but when i use the "transcribe" function i get proper transcription for the audio file. @titu1994 @VahidooX can you please enlighten on this. When to use and how to use streaming models in .nemo format and in RIVA pipeline. My question has some relevance with these issues [https://github.com/https://github.com/NVIDIA/NeMo/discussions/7010] [https://github.com/https://github.com/NVIDIA/NeMo/discussions/5284]
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9521/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9521/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9520
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9520/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9520/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9520/events
https://github.com/NVIDIA/NeMo/issues/9520
2,368,452,170
I_kwDOC_bI7s6NK7ZK
9,520
Can you support DoRA?
{ "login": "SJmdy", "id": 45581317, "node_id": "MDQ6VXNlcjQ1NTgxMzE3", "avatar_url": "https://avatars.githubusercontent.com/u/45581317?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SJmdy", "html_url": "https://github.com/SJmdy", "followers_url": "https://api.github.com/users/SJmdy/followers", "following_url": "https://api.github.com/users/SJmdy/following{/other_user}", "gists_url": "https://api.github.com/users/SJmdy/gists{/gist_id}", "starred_url": "https://api.github.com/users/SJmdy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SJmdy/subscriptions", "organizations_url": "https://api.github.com/users/SJmdy/orgs", "repos_url": "https://api.github.com/users/SJmdy/repos", "events_url": "https://api.github.com/users/SJmdy/events{/privacy}", "received_events_url": "https://api.github.com/users/SJmdy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1719393562, "node_id": "MDU6TGFiZWwxNzE5MzkzNTYy", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature", "name": "feature", "color": "68F3F0", "default": false, "description": "request/PR for a new feature" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "Hi @SJmdy \r\nDora is a planned feature in the near future. We plan on supporting it once to transition to NeMo 2.0 is mature.", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-23T08:51:05
2024-08-12T16:26:15
2024-08-12T01:53:12
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hi Team, Do you have any plans to support DoRA? Paper: https://arxiv.org/abs/2402.09353 peft: https://github.com/huggingface/peft/pull/1474 Thank you
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9520/reactions", "total_count": 3, "+1": 3, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9520/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9519
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9519/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9519/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9519/events
https://github.com/NVIDIA/NeMo/pull/9519
2,368,418,829
PR_kwDOC_bI7s5zRrrY
9,519
Alit/jamba
{ "login": "JRD971000", "id": 71892896, "node_id": "MDQ6VXNlcjcxODkyODk2", "avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JRD971000", "html_url": "https://github.com/JRD971000", "followers_url": "https://api.github.com/users/JRD971000/followers", "following_url": "https://api.github.com/users/JRD971000/following{/other_user}", "gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}", "starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions", "organizations_url": "https://api.github.com/users/JRD971000/orgs", "repos_url": "https://api.github.com/users/JRD971000/repos", "events_url": "https://api.github.com/users/JRD971000/events{/privacy}", "received_events_url": "https://api.github.com/users/JRD971000/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4418253970, "node_id": "LA_kwDOC_bI7s8AAAABB1k0kg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS", "name": "TTS", "color": "49AF28", "default": false, "description": "" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-23T08:10:15
2024-07-24T01:50:36
2024-07-24T01:50:35
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9519", "html_url": "https://github.com/NVIDIA/NeMo/pull/9519", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9519.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9519.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9519/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9519/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9518
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9518/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9518/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9518/events
https://github.com/NVIDIA/NeMo/issues/9518
2,367,987,226
I_kwDOC_bI7s6NJJ4a
9,518
Nemo container for Nemotron 340B inference fails pytorch_lightning import
{ "login": "Lauler", "id": 7157234, "node_id": "MDQ6VXNlcjcxNTcyMzQ=", "avatar_url": "https://avatars.githubusercontent.com/u/7157234?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Lauler", "html_url": "https://github.com/Lauler", "followers_url": "https://api.github.com/users/Lauler/followers", "following_url": "https://api.github.com/users/Lauler/following{/other_user}", "gists_url": "https://api.github.com/users/Lauler/gists{/gist_id}", "starred_url": "https://api.github.com/users/Lauler/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lauler/subscriptions", "organizations_url": "https://api.github.com/users/Lauler/orgs", "repos_url": "https://api.github.com/users/Lauler/repos", "events_url": "https://api.github.com/users/Lauler/events{/privacy}", "received_events_url": "https://api.github.com/users/Lauler/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[ "The error was due to a different pytorch version being installed outside of the container in `~/.local/lib/python3.10/site-packages`. Since my home directory was mounted the container prioritized this version over the one in the container and thus there was a mismatch between `torch` and `torchvision`. \r\n\r\nThe local Pytorch version was installed by mistake... So make sure to delete or unmount any python installations that might interfere with packages installed in the container. " ]
2024-06-22T19:27:10
2024-06-22T22:02:42
2024-06-22T21:59:40
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** Nvidia recently released Nemotron 340B. The [README on Huggingface provides a guide](https://huggingface.co/nvidia/Nemotron-4-340B-Instruct) for performing inference with this model. I followed the guide using the recommended container `nvcr.io/nvidia/nemo:24.01.framework`. However, this container is unable to import `pytorch_lightning` without errors. The inference script tries to import `pytorch_lightning`, which in turn attempts to verify it can import `torchvision` (which it fails to do). I suspect the error is due to the version of `torchvision` installed not being compatible with the `torch` version (`RuntimeError: operator torchvision::nms does not exist`). I have encountered similar errors related to importing `pytorch_lightning` in your older containers previously as well. It happens more frequently when alpha/nightly versions of python packages are installed. A lot of containers tend to have alpha/nightly versions of either `torch`, `torchtext` or `torchvision` installed.
{ "login": "Lauler", "id": 7157234, "node_id": "MDQ6VXNlcjcxNTcyMzQ=", "avatar_url": "https://avatars.githubusercontent.com/u/7157234?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Lauler", "html_url": "https://github.com/Lauler", "followers_url": "https://api.github.com/users/Lauler/followers", "following_url": "https://api.github.com/users/Lauler/following{/other_user}", "gists_url": "https://api.github.com/users/Lauler/gists{/gist_id}", "starred_url": "https://api.github.com/users/Lauler/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lauler/subscriptions", "organizations_url": "https://api.github.com/users/Lauler/orgs", "repos_url": "https://api.github.com/users/Lauler/repos", "events_url": "https://api.github.com/users/Lauler/events{/privacy}", "received_events_url": "https://api.github.com/users/Lauler/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9518/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9518/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9517
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9517/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9517/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9517/events
https://github.com/NVIDIA/NeMo/pull/9517
2,366,552,608
PR_kwDOC_bI7s5zL4oa
9,517
Support Canary parallel inference
{ "login": "karpnv", "id": 1645775, "node_id": "MDQ6VXNlcjE2NDU3NzU=", "avatar_url": "https://avatars.githubusercontent.com/u/1645775?v=4", "gravatar_id": "", "url": "https://api.github.com/users/karpnv", "html_url": "https://github.com/karpnv", "followers_url": "https://api.github.com/users/karpnv/followers", "following_url": "https://api.github.com/users/karpnv/following{/other_user}", "gists_url": "https://api.github.com/users/karpnv/gists{/gist_id}", "starred_url": "https://api.github.com/users/karpnv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/karpnv/subscriptions", "organizations_url": "https://api.github.com/users/karpnv/orgs", "repos_url": "https://api.github.com/users/karpnv/repos", "events_url": "https://api.github.com/users/karpnv/events{/privacy}", "received_events_url": "https://api.github.com/users/karpnv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "`+` like we talked offline, we have to work around global_rank being set incorrectly before `trainer.predict()` is called - the dataloader has to be initialized with the correct global_rank (and world_size) in order for lhotse's distributed sampler to work correctly", "trainer.global_rank is apriori set by PTL in slurm environment. It does not require model to be built or it's functions to be called c\r\n\r\nIs this a case where PTL cannot apriori detect global rank ?", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "Jenkins", "[🤖]: Hi @karpnv 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11073753509) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @karpnv 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11073753509) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g", "[🤖]: Hi @karpnv 👋,\n\nI just wanted to let you know that, you know, a [CICD pipeline](https://github.com/NVIDIA/NeMo/actions/runs/11073753509) for this PR just finished successfully ✨\n\nSo it might be time to merge this PR or like to get some approvals 🚀\n\nBut I'm just a 🤖 so I'll leave it you what to do next.\n\nHave a great day! \n\n//cc @ko3n1g" ]
2024-06-21T13:27:34
2024-09-27T22:19:04
2024-09-27T22:19:01
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9517", "html_url": "https://github.com/NVIDIA/NeMo/pull/9517", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9517.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9517.patch", "merged_at": "2024-09-27T22:19:01" }
# What does this PR do ? Support Canary at transcribe_speech_parallel.py script **Collection**: ASR ```python #python3 ./examples/asr/transcribe_speech_parallel.py model=./canary-1b.nemo predict_ds.manifest_filepath=./manifest.json output_path=/tmp trainer.devices=-1 ``` **PR Type**: - [ V] New Feature - [ ] Bugfix - [ ] Documentation ## Who can review? @pzelasko
{ "login": "karpnv", "id": 1645775, "node_id": "MDQ6VXNlcjE2NDU3NzU=", "avatar_url": "https://avatars.githubusercontent.com/u/1645775?v=4", "gravatar_id": "", "url": "https://api.github.com/users/karpnv", "html_url": "https://github.com/karpnv", "followers_url": "https://api.github.com/users/karpnv/followers", "following_url": "https://api.github.com/users/karpnv/following{/other_user}", "gists_url": "https://api.github.com/users/karpnv/gists{/gist_id}", "starred_url": "https://api.github.com/users/karpnv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/karpnv/subscriptions", "organizations_url": "https://api.github.com/users/karpnv/orgs", "repos_url": "https://api.github.com/users/karpnv/repos", "events_url": "https://api.github.com/users/karpnv/events{/privacy}", "received_events_url": "https://api.github.com/users/karpnv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9517/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9517/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9516
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9516/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9516/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9516/events
https://github.com/NVIDIA/NeMo/issues/9516
2,365,977,462
I_kwDOC_bI7s6NBfN2
9,516
Converting megatron checkpoint to .nemo without the same environment
{ "login": "dachenlian", "id": 21274267, "node_id": "MDQ6VXNlcjIxMjc0MjY3", "avatar_url": "https://avatars.githubusercontent.com/u/21274267?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dachenlian", "html_url": "https://github.com/dachenlian", "followers_url": "https://api.github.com/users/dachenlian/followers", "following_url": "https://api.github.com/users/dachenlian/following{/other_user}", "gists_url": "https://api.github.com/users/dachenlian/gists{/gist_id}", "starred_url": "https://api.github.com/users/dachenlian/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dachenlian/subscriptions", "organizations_url": "https://api.github.com/users/dachenlian/orgs", "repos_url": "https://api.github.com/users/dachenlian/repos", "events_url": "https://api.github.com/users/dachenlian/events{/privacy}", "received_events_url": "https://api.github.com/users/dachenlian/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "dimapihtar", "id": 37850217, "node_id": "MDQ6VXNlcjM3ODUwMjE3", "avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimapihtar", "html_url": "https://github.com/dimapihtar", "followers_url": "https://api.github.com/users/dimapihtar/followers", "following_url": "https://api.github.com/users/dimapihtar/following{/other_user}", "gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions", "organizations_url": "https://api.github.com/users/dimapihtar/orgs", "repos_url": "https://api.github.com/users/dimapihtar/repos", "events_url": "https://api.github.com/users/dimapihtar/events{/privacy}", "received_events_url": "https://api.github.com/users/dimapihtar/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "Hi @dachenlian,\r\nCould you try to specify --hparams_yaml param? You can find `hparams.yaml` file in train results folder. It should be in \"version_0\" or \"run_0\" folder.", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-21T08:08:42
2024-08-25T01:56:17
2024-08-25T01:56:16
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
I have multiple checkpoints produced after running `examples/nlp/language_modeling/megatron_gpt_continue_training.py`. However, I am unable to use `examples/nlp/language_modeling/megatron_ckpt_to_nemo.py` to convert it to a `.nemo` object. It's probably because the environment in which I want to do the conversion is the not the same as the one used for training. Is there some way to do the conversion only on CPU or just 1 GPU? I have tried using two different sets of parameters: --- Input: ```bash srun -p ${PARTITION} -G 1 \ --container-image /mnt/nemo_dev.sqsh \ --container-mounts ${LAUNCHER_SCRIPT_PATH}:${LAUNCHER_SCRIPT_PATH},${NEMO_PATH}:${NEMO_PATH} \ --container-writable \ --no-container-mount-home \ --pty bash -c \ "python ${NEMO_PATH}/examples/nlp/language_modeling/megatron_ckpt_to_nemo.py --checkpoint_folder ${CKPT_FOLDER} --checkpoint_name ${CKPT_NAME} --nemo_file_path ${NEMO_FILE_PATH} --model_type gpt --gpus_per_node 1 --tensor_model_parallel_size 1 --pipeline_model_parallel_size 1 --precision bf16-mixed" ``` Output: ```bash megatron_ckpt_to_nemo.py 243 <module> convert(local_rank, rank, world_size, args) megatron_ckpt_to_nemo.py 196 convert model = MegatronGPTModel.load_from_checkpoint(checkpoint_path, hparams_file=args.hparams_file, trainer=trainer) nlp_model.py 397 load_from_checkpoint checkpoint = dist_checkpointing.load(sharded_state_dict=checkpoint, checkpoint_dir=checkpoint_dir) serialization.py 131 load validate_sharding_integrity(nested_values(sharded_state_dict)) serialization.py 404 validate_sharding_integrity _validate_sharding_for_key(shardings) serialization.py 442 _validate_sharding_for_key raise CheckpointingException(f'Invalid access pattern for {rank_sharding[0][1]}') megatron.core.dist_checkpointing.core.CheckpointingException: Invalid access pattern for ShardedTensor(key='model.embedding.word_embeddings.weight') ``` --- Input: ```bash srun -p ${PARTITION} -G 1 \ --container-image /mnt/nemo_dev.sqsh \ --container-mounts ${LAUNCHER_SCRIPT_PATH}:${LAUNCHER_SCRIPT_PATH},${NEMO_PATH}:${NEMO_PATH} \ --container-writable \ --no-container-mount-home \ --pty bash -c \ "python ${NEMO_PATH}/examples/nlp/language_modeling/megatron_ckpt_to_nemo.py --checkpoint_folder ${CKPT_FOLDER} --checkpoint_name ${CKPT_NAME} --nemo_file_path ${NEMO_FILE_PATH} --model_type gpt --gpus_per_node 8 --tensor_model_parallel_size 2 --pipeline_model_parallel_size 1 --precision bf16-mixed" ``` Output: ```bash megatron_ckpt_to_nemo.py 243 <module> convert(local_rank, rank, world_size, args) megatron_ckpt_to_nemo.py 153 convert trainer = Trainer(plugins=plugins, strategy=strategy, **cfg.trainer) argparse.py 70 insert_env_defaults return fn(self, **kwargs) trainer.py 401 __init__ self._accelerator_connector = _AcceleratorConnector( accelerator_connector.py 149 __init__ self._check_device_config_and_set_final_flags(devices=devices, num_nodes=num_nodes) accelerator_connector.py 325 _check_device_config_and_set_final_flags raise ValueError(f"`num_nodes` must be a positive integer, but got {num_nodes}.") ValueError: `num_nodes` must be a positive integer, but got 0. ```
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9516/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9516/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9515
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9515/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9515/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9515/events
https://github.com/NVIDIA/NeMo/issues/9515
2,365,968,897
I_kwDOC_bI7s6NBdIB
9,515
issue about self attention with mask
{ "login": "cwghnu", "id": 32759047, "node_id": "MDQ6VXNlcjMyNzU5MDQ3", "avatar_url": "https://avatars.githubusercontent.com/u/32759047?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cwghnu", "html_url": "https://github.com/cwghnu", "followers_url": "https://api.github.com/users/cwghnu/followers", "following_url": "https://api.github.com/users/cwghnu/following{/other_user}", "gists_url": "https://api.github.com/users/cwghnu/gists{/gist_id}", "starred_url": "https://api.github.com/users/cwghnu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cwghnu/subscriptions", "organizations_url": "https://api.github.com/users/cwghnu/orgs", "repos_url": "https://api.github.com/users/cwghnu/repos", "events_url": "https://api.github.com/users/cwghnu/events{/privacy}", "received_events_url": "https://api.github.com/users/cwghnu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[]
2024-06-21T08:03:56
2024-06-21T08:23:50
2024-06-21T08:23:50
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** When I tried to use the self-attention module, I encountered an issue with the mask. In the file 'multi_head_attention.py', the code appears to handle the mask as follows when it is not None: ```python if mask is not None: mask = mask.unsqueeze(1) # (batch, 1, time1, time2) scores = scores.masked_fill(mask, -10000.0) attn = torch.softmax(scores, dim=-1).masked_fill(mask, 0.0) # (batch, head, time1, time2) else: attn = torch.softmax(scores, dim=-1) # (batch, head, time1, time2) ``` I was wondering if the code should be adjusted, or if we should convert the mask before using it: ```python ... mask = mask.unsqueeze(1).eq(0) # (batch, 1, time1, time2) ... ``` Appreciate your response.
{ "login": "cwghnu", "id": 32759047, "node_id": "MDQ6VXNlcjMyNzU5MDQ3", "avatar_url": "https://avatars.githubusercontent.com/u/32759047?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cwghnu", "html_url": "https://github.com/cwghnu", "followers_url": "https://api.github.com/users/cwghnu/followers", "following_url": "https://api.github.com/users/cwghnu/following{/other_user}", "gists_url": "https://api.github.com/users/cwghnu/gists{/gist_id}", "starred_url": "https://api.github.com/users/cwghnu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cwghnu/subscriptions", "organizations_url": "https://api.github.com/users/cwghnu/orgs", "repos_url": "https://api.github.com/users/cwghnu/repos", "events_url": "https://api.github.com/users/cwghnu/events{/privacy}", "received_events_url": "https://api.github.com/users/cwghnu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9515/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9515/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9514
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9514/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9514/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9514/events
https://github.com/NVIDIA/NeMo/issues/9514
2,365,245,389
I_kwDOC_bI7s6M-sfN
9,514
How to export SLUIntentSlotBPEModel to ONNX
{ "login": "Khanh-lt269", "id": 80638197, "node_id": "MDQ6VXNlcjgwNjM4MTk3", "avatar_url": "https://avatars.githubusercontent.com/u/80638197?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Khanh-lt269", "html_url": "https://github.com/Khanh-lt269", "followers_url": "https://api.github.com/users/Khanh-lt269/followers", "following_url": "https://api.github.com/users/Khanh-lt269/following{/other_user}", "gists_url": "https://api.github.com/users/Khanh-lt269/gists{/gist_id}", "starred_url": "https://api.github.com/users/Khanh-lt269/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Khanh-lt269/subscriptions", "organizations_url": "https://api.github.com/users/Khanh-lt269/orgs", "repos_url": "https://api.github.com/users/Khanh-lt269/repos", "events_url": "https://api.github.com/users/Khanh-lt269/events{/privacy}", "received_events_url": "https://api.github.com/users/Khanh-lt269/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "We don't support export of the SLU model ", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-20T20:49:13
2024-08-10T01:51:33
2024-08-10T01:51:33
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hello guys, I'm dealing with this issue for days but still unable to find the key. I have followed export steps as this [link](https://docs.nvidia.com/nemo-framework/user-guide/latest/nemotoolkit/core/export.html). It works for ASR models, but when I need to export SLUIntentSlotBPEModel model, it shows this following error. Have anyone tried to export this model? ```jupyter-notebook slu_model.export('/home4/khanhlt/nemo_api/onnx/nemo_slu.onnx') ``` ``` { "name": "AttributeError", "message": "'SLUIntentSlotBPEModel' object has no attribute 'output_names'", "stack": "--------------------------------------------------------------------------- AttributeError Traceback (most recent call last) Cell In[3], line 1 ----> 1 slu_model.export('/home4/khanhlt/nemo_api/onnx/nemo_slu.onnx') File //home4/khanhlt/slu/Nemo_SLU_2/NeMo/nemo/core/classes/exportable.py:114, in Exportable.export(self, output, input_example, verbose, do_constant_folding, onnx_opset_version, check_trace, dynamic_axes, check_tolerance, export_modules_as_functions, keep_initializers_as_inputs) 112 model = self.get_export_subnet(subnet_name) 113 out_name = augment_filename(output, subnet_name) --> 114 out, descr, out_example = model._export( 115 out_name, 116 input_example=input_example, 117 verbose=verbose, 118 do_constant_folding=do_constant_folding, 119 onnx_opset_version=onnx_opset_version, 120 check_trace=check_trace, 121 dynamic_axes=dynamic_axes, 122 check_tolerance=check_tolerance, 123 export_modules_as_functions=export_modules_as_functions, 124 keep_initializers_as_inputs=keep_initializers_as_inputs, 125 ) 126 # Propagate input example (default scenario, may need to be overriden) 127 if input_example is not None: File //home4/khanhlt/slu/Nemo_SLU_2/NeMo/nemo/core/classes/exportable.py:191, in Exportable._export(self, output, input_example, verbose, do_constant_folding, onnx_opset_version, check_trace, dynamic_axes, check_tolerance, export_modules_as_functions, keep_initializers_as_inputs) 189 input_list, input_dict = parse_input_example(input_example) 190 input_names = self.input_names --> 191 output_names = self.output_names 192 output_example = tuple(self.forward(*input_list, **input_dict)) 194 if check_trace: File ~/miniconda3/envs/nemo/lib/python3.10/site-packages/torch/nn/modules/module.py:1709, in Module.__getattr__(self, name) 1707 if name in modules: 1708 return modules[name] -> 1709 raise AttributeError(f\"'{type(self).__name__}' object has no attribute '{name}'\") AttributeError: 'SLUIntentSlotBPEModel' object has no attribute 'output_names'" } ```
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9514/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9514/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9512
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9512/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9512/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9512/events
https://github.com/NVIDIA/NeMo/pull/9512
2,364,651,813
PR_kwDOC_bI7s5zFby8
9,512
[Nemo-UX] IO fixes
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-20T14:51:43
2024-06-26T14:19:25
2024-06-26T14:19:23
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9512", "html_url": "https://github.com/NVIDIA/NeMo/pull/9512", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9512.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9512.patch", "merged_at": "2024-06-26T14:19:23" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9512/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9512/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9510
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9510/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9510/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9510/events
https://github.com/NVIDIA/NeMo/pull/9510
2,363,174,637
PR_kwDOC_bI7s5zAalL
9,510
Add nemotron news
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-06-19T21:52:16
2024-06-19T21:57:31
2024-06-19T21:57:31
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9510", "html_url": "https://github.com/NVIDIA/NeMo/pull/9510", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9510.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9510.patch", "merged_at": "2024-06-19T21:57:31" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9510/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9510/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9509
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9509/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9509/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9509/events
https://github.com/NVIDIA/NeMo/issues/9509
2,362,587,188
I_kwDOC_bI7s6M0jg0
9,509
When Trying to import nlp collections in the Nemo Primer getting error "No Module named megatron"
{ "login": "evodata123", "id": 168087860, "node_id": "U_kgDOCgTRNA", "avatar_url": "https://avatars.githubusercontent.com/u/168087860?v=4", "gravatar_id": "", "url": "https://api.github.com/users/evodata123", "html_url": "https://github.com/evodata123", "followers_url": "https://api.github.com/users/evodata123/followers", "following_url": "https://api.github.com/users/evodata123/following{/other_user}", "gists_url": "https://api.github.com/users/evodata123/gists{/gist_id}", "starred_url": "https://api.github.com/users/evodata123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/evodata123/subscriptions", "organizations_url": "https://api.github.com/users/evodata123/orgs", "repos_url": "https://api.github.com/users/evodata123/repos", "events_url": "https://api.github.com/users/evodata123/events{/privacy}", "received_events_url": "https://api.github.com/users/evodata123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "Hi @evodata123, the specific `'ApexGuardDefaults' is not defined` error you are seeing should be fixed by [this PR](https://github.com/NVIDIA/NeMo/pull/9732). But note that Megatron core is a required dependency of NeMo, so if Megatron core is not installed, you may see some orthogonal issues. ", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-19T14:55:35
2024-08-23T01:52:03
2024-08-23T01:52:02
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
This is being done in google colab environment. with Nemo version 2.0.0rc0 ![image](https://github.com/NVIDIA/NeMo/assets/168087860/9b4114f7-e12d-4cc7-8b33-dbf903257b34)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9509/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9509/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9508
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9508/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9508/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9508/events
https://github.com/NVIDIA/NeMo/pull/9508
2,362,578,435
PR_kwDOC_bI7s5y-YZt
9,508
Expose num processes in PyT Dist
{ "login": "mikolajblaz", "id": 9979479, "node_id": "MDQ6VXNlcjk5Nzk0Nzk=", "avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mikolajblaz", "html_url": "https://github.com/mikolajblaz", "followers_url": "https://api.github.com/users/mikolajblaz/followers", "following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}", "gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions", "organizations_url": "https://api.github.com/users/mikolajblaz/orgs", "repos_url": "https://api.github.com/users/mikolajblaz/repos", "events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}", "received_events_url": "https://api.github.com/users/mikolajblaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-19T14:51:49
2024-07-11T01:49:54
2024-07-11T01:49:53
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9508", "html_url": "https://github.com/NVIDIA/NeMo/pull/9508", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9508.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9508.patch", "merged_at": null }
# What does this PR do ? Expose multiprocessing setting for PyT Distributed checkpoint format. **Collection**: NLP # Changelog - Add `model.dist_ckpt_torch_dist_multiproc` flag controlling intra-rank parallelism for PyT Distributed checkpoint saving # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9508/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9508/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9507
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9507/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9507/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9507/events
https://github.com/NVIDIA/NeMo/pull/9507
2,362,577,920
PR_kwDOC_bI7s5y-YSO
9,507
Expose num processes in PyT Dist for NeMo 24.05
{ "login": "mikolajblaz", "id": 9979479, "node_id": "MDQ6VXNlcjk5Nzk0Nzk=", "avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mikolajblaz", "html_url": "https://github.com/mikolajblaz", "followers_url": "https://api.github.com/users/mikolajblaz/followers", "following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}", "gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions", "organizations_url": "https://api.github.com/users/mikolajblaz/orgs", "repos_url": "https://api.github.com/users/mikolajblaz/repos", "events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}", "received_events_url": "https://api.github.com/users/mikolajblaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-19T14:51:34
2024-07-11T01:49:56
2024-07-11T01:49:55
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9507", "html_url": "https://github.com/NVIDIA/NeMo/pull/9507", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9507.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9507.patch", "merged_at": null }
# What does this PR do ? Expose multiprocessing setting for PyT Distributed checkpoint format. **Collection**: NLP # Changelog - Add `model.dist_ckpt_torch_dist_multiproc` flag controlling intra-rank parallelism for PyT Distributed checkpoint saving # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9507/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9507/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9505
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9505/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9505/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9505/events
https://github.com/NVIDIA/NeMo/pull/9505
2,362,214,113
PR_kwDOC_bI7s5y9Hkg
9,505
Enable MCore checkpointing optimizations
{ "login": "mikolajblaz", "id": 9979479, "node_id": "MDQ6VXNlcjk5Nzk0Nzk=", "avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mikolajblaz", "html_url": "https://github.com/mikolajblaz", "followers_url": "https://api.github.com/users/mikolajblaz/followers", "following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}", "gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions", "organizations_url": "https://api.github.com/users/mikolajblaz/orgs", "repos_url": "https://api.github.com/users/mikolajblaz/repos", "events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}", "received_events_url": "https://api.github.com/users/mikolajblaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "mikolajblaz", "id": 9979479, "node_id": "MDQ6VXNlcjk5Nzk0Nzk=", "avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mikolajblaz", "html_url": "https://github.com/mikolajblaz", "followers_url": "https://api.github.com/users/mikolajblaz/followers", "following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}", "gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions", "organizations_url": "https://api.github.com/users/mikolajblaz/orgs", "repos_url": "https://api.github.com/users/mikolajblaz/repos", "events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}", "received_events_url": "https://api.github.com/users/mikolajblaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "mikolajblaz", "id": 9979479, "node_id": "MDQ6VXNlcjk5Nzk0Nzk=", "avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mikolajblaz", "html_url": "https://github.com/mikolajblaz", "followers_url": "https://api.github.com/users/mikolajblaz/followers", "following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}", "gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions", "organizations_url": "https://api.github.com/users/mikolajblaz/orgs", "repos_url": "https://api.github.com/users/mikolajblaz/repos", "events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}", "received_events_url": "https://api.github.com/users/mikolajblaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-06-19T12:14:09
2024-07-05T19:52:22
2024-07-05T19:52:15
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9505", "html_url": "https://github.com/NVIDIA/NeMo/pull/9505", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9505.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9505.patch", "merged_at": "2024-07-05T19:52:15" }
# What does this PR do ? Enables existing MCore optimizations, mainly for parallelizing the checkpoint save and load. These are a lot of small changes, but it made sense to group them into a single MR because they are all somehow interconnected. **Collection**: NLP # Changelog - Enable MCoreDistOpt parallel R/W (controlled with `model.dist_ckpt_parallel_save` flag, loading is parallelized based on save) - Enable model weight save parallelization (controlled with `model.dist_ckpt_parallel_save` flag) - Set `model.dist_ckpt_parallel_save` flag to True by default (increases performance and allows DistOpt ckpt resharding; the only caveat is potentially larger number of files in the checkpoint: `O(ranks * model.dist_ckpt_torch_dist_multiproc`) - Enable model weight load parallelization (controlled with `model.dist_ckpt_parallel_load` flag) - Allow increasing intra-rank save parallelization with multiprocessing (controlled with `model.dist_ckpt_torch_dist_multiproc` flag) - Skip state dict validation in subsequent saves (controlled with `model.dist_ckpt_assume_constant_structure` flag) - Remove some async-related code that was moved to MCore (whole `nemo/utils/callbacks/torch_dist_async.py` file) # Usage Use by enabling the flags mentioned in the changelog. ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "mikolajblaz", "id": 9979479, "node_id": "MDQ6VXNlcjk5Nzk0Nzk=", "avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mikolajblaz", "html_url": "https://github.com/mikolajblaz", "followers_url": "https://api.github.com/users/mikolajblaz/followers", "following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}", "gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions", "organizations_url": "https://api.github.com/users/mikolajblaz/orgs", "repos_url": "https://api.github.com/users/mikolajblaz/repos", "events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}", "received_events_url": "https://api.github.com/users/mikolajblaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9505/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9505/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9503
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9503/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9503/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9503/events
https://github.com/NVIDIA/NeMo/pull/9503
2,362,038,595
PR_kwDOC_bI7s5y8gov
9,503
Add section on ".qnemo" checkpoints
{ "login": "janekl", "id": 5582967, "node_id": "MDQ6VXNlcjU1ODI5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janekl", "html_url": "https://github.com/janekl", "followers_url": "https://api.github.com/users/janekl/followers", "following_url": "https://api.github.com/users/janekl/following{/other_user}", "gists_url": "https://api.github.com/users/janekl/gists{/gist_id}", "starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janekl/subscriptions", "organizations_url": "https://api.github.com/users/janekl/orgs", "repos_url": "https://api.github.com/users/janekl/repos", "events_url": "https://api.github.com/users/janekl/events{/privacy}", "received_events_url": "https://api.github.com/users/janekl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-06-19T10:52:40
2024-06-27T16:32:33
2024-06-27T16:32:31
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9503", "html_url": "https://github.com/NVIDIA/NeMo/pull/9503", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9503.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9503.patch", "merged_at": "2024-06-27T16:32:31" }
# What does this PR do ? Add section on ".qnemo" checkpoints to https://github.com/NVIDIA/NeMo/pull/9329. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [x] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9503/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9503/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9502
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9502/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9502/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9502/events
https://github.com/NVIDIA/NeMo/issues/9502
2,361,743,041
I_kwDOC_bI7s6MxVbB
9,502
How to use a pre-trained model for cache-aware FastConformer-Hybrid model?
{ "login": "sangeet2020", "id": 33633418, "node_id": "MDQ6VXNlcjMzNjMzNDE4", "avatar_url": "https://avatars.githubusercontent.com/u/33633418?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sangeet2020", "html_url": "https://github.com/sangeet2020", "followers_url": "https://api.github.com/users/sangeet2020/followers", "following_url": "https://api.github.com/users/sangeet2020/following{/other_user}", "gists_url": "https://api.github.com/users/sangeet2020/gists{/gist_id}", "starred_url": "https://api.github.com/users/sangeet2020/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sangeet2020/subscriptions", "organizations_url": "https://api.github.com/users/sangeet2020/orgs", "repos_url": "https://api.github.com/users/sangeet2020/repos", "events_url": "https://api.github.com/users/sangeet2020/events{/privacy}", "received_events_url": "https://api.github.com/users/sangeet2020/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "You can use this model, which is a chunk aware model - https://huggingface.co/nvidia/stt_en_fastconformer_hybrid_large_streaming_multi", "Thank You @titu1994. I will try it.\r\nBut this has been trained on labeled English dataset. I want to understand the logic, how would it adapt to any other language?", "It's a practical limitation. You can either get a ordinary fast conformer in German or a chunk aware Conformer in English. Depends on what your priority is - streaming or transcript accuracy. We have tutorial showing language transfer " ]
2024-06-19T08:39:00
2024-07-31T18:18:49
2024-07-31T18:18:49
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hi @titu1994, Following our discussion in [this thread](https://github.com/NVIDIA/NeMo/discussions/7010#discussioncomment-9736124), I’m training a cache-aware FastConformer hybrid CTC-RNNT model for German using 1.2K hours of audio data. Despite training for 150 epochs, my validation WER is still around 0.28. I suspect the dataset quality might be an issue. I reviewed the paper "Stateful Conformer with Cache-Based Inference for Streaming ASR" and noted the significant performance achieved even with training from scratch on LibriSpeech. Since you recommended using a pre-trained model, I tried using [this model](https://huggingface.co/nvidia/stt_de_fastconformer_hybrid_large_pc/tree/main) from Hugging Face, but it's not a streaming model. Is it still viable as a pre-trained model for my use case, or are there other German models available that you would recommend? Thank you for your guidance!
null
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9502/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9502/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9501
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9501/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9501/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9501/events
https://github.com/NVIDIA/NeMo/issues/9501
2,361,641,480
I_kwDOC_bI7s6Mw8oI
9,501
to support deepseekv2
{ "login": "panjianfei", "id": 147695352, "node_id": "U_kgDOCM2m-A", "avatar_url": "https://avatars.githubusercontent.com/u/147695352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/panjianfei", "html_url": "https://github.com/panjianfei", "followers_url": "https://api.github.com/users/panjianfei/followers", "following_url": "https://api.github.com/users/panjianfei/following{/other_user}", "gists_url": "https://api.github.com/users/panjianfei/gists{/gist_id}", "starred_url": "https://api.github.com/users/panjianfei/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/panjianfei/subscriptions", "organizations_url": "https://api.github.com/users/panjianfei/orgs", "repos_url": "https://api.github.com/users/panjianfei/repos", "events_url": "https://api.github.com/users/panjianfei/events{/privacy}", "received_events_url": "https://api.github.com/users/panjianfei/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "ntajbakhsh", "id": 12647849, "node_id": "MDQ6VXNlcjEyNjQ3ODQ5", "avatar_url": "https://avatars.githubusercontent.com/u/12647849?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ntajbakhsh", "html_url": "https://github.com/ntajbakhsh", "followers_url": "https://api.github.com/users/ntajbakhsh/followers", "following_url": "https://api.github.com/users/ntajbakhsh/following{/other_user}", "gists_url": "https://api.github.com/users/ntajbakhsh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ntajbakhsh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ntajbakhsh/subscriptions", "organizations_url": "https://api.github.com/users/ntajbakhsh/orgs", "repos_url": "https://api.github.com/users/ntajbakhsh/repos", "events_url": "https://api.github.com/users/ntajbakhsh/events{/privacy}", "received_events_url": "https://api.github.com/users/ntajbakhsh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "ntajbakhsh", "id": 12647849, "node_id": "MDQ6VXNlcjEyNjQ3ODQ5", "avatar_url": "https://avatars.githubusercontent.com/u/12647849?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ntajbakhsh", "html_url": "https://github.com/ntajbakhsh", "followers_url": "https://api.github.com/users/ntajbakhsh/followers", "following_url": "https://api.github.com/users/ntajbakhsh/following{/other_user}", "gists_url": "https://api.github.com/users/ntajbakhsh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ntajbakhsh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ntajbakhsh/subscriptions", "organizations_url": "https://api.github.com/users/ntajbakhsh/orgs", "repos_url": "https://api.github.com/users/ntajbakhsh/repos", "events_url": "https://api.github.com/users/ntajbakhsh/events{/privacy}", "received_events_url": "https://api.github.com/users/ntajbakhsh/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "Thanks for your inquiry. DeepSeek was in our roadmap but it has now been deprioritized. Here is a list of currently supported LLMs: https://docs.nvidia.com/nemo-framework/user-guide/latest/llms/index.html", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-19T08:01:00
2024-08-10T01:51:35
2024-08-10T01:51:34
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
hi, do you have plan to support deepseekv2 model?
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9501/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9501/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9500
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9500/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9500/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9500/events
https://github.com/NVIDIA/NeMo/issues/9500
2,361,530,387
I_kwDOC_bI7s6MwhgT
9,500
LM on Parakeet models
{ "login": "jinmingteo", "id": 28519525, "node_id": "MDQ6VXNlcjI4NTE5NTI1", "avatar_url": "https://avatars.githubusercontent.com/u/28519525?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jinmingteo", "html_url": "https://github.com/jinmingteo", "followers_url": "https://api.github.com/users/jinmingteo/followers", "following_url": "https://api.github.com/users/jinmingteo/following{/other_user}", "gists_url": "https://api.github.com/users/jinmingteo/gists{/gist_id}", "starred_url": "https://api.github.com/users/jinmingteo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jinmingteo/subscriptions", "organizations_url": "https://api.github.com/users/jinmingteo/orgs", "repos_url": "https://api.github.com/users/jinmingteo/repos", "events_url": "https://api.github.com/users/jinmingteo/events{/privacy}", "received_events_url": "https://api.github.com/users/jinmingteo/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "For transducer, there were always 3 outputs in forward because it's just end encoder forward. During decoding we take those encoder outputs and pass them auto regressively to the decoder and joint. \r\n\r\nFor beam search support, @karpnv ", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-19T07:18:13
2024-08-10T01:51:36
2024-08-10T01:51:35
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hi team, I am trying to add LM into parakeet models and i think this is the script related to it. [eval_beamsearch_ngram_transducer.py](https://github.com/NVIDIA/NeMo/blob/main/scripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py) I have tried using it and encountered a couple of issues with EncDecRNNTBPEModel. For example, there are 3 outputs in [forward](https://github.com/NVIDIA/NeMo/blob/main/scripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_transducer.py#L336) function now. Is there other scripts that i should be looking into? Thanks
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9500/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9500/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9499
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9499/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9499/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9499/events
https://github.com/NVIDIA/NeMo/pull/9499
2,360,944,537
PR_kwDOC_bI7s5y4uZc
9,499
Export online model conversion and refit
{ "login": "JimmyZhang12", "id": 67203904, "node_id": "MDQ6VXNlcjY3MjAzOTA0", "avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JimmyZhang12", "html_url": "https://github.com/JimmyZhang12", "followers_url": "https://api.github.com/users/JimmyZhang12/followers", "following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}", "gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}", "starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions", "organizations_url": "https://api.github.com/users/JimmyZhang12/orgs", "repos_url": "https://api.github.com/users/JimmyZhang12/repos", "events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}", "received_events_url": "https://api.github.com/users/JimmyZhang12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-06-19T00:08:49
2024-06-19T01:36:37
2024-06-19T01:36:37
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9499", "html_url": "https://github.com/NVIDIA/NeMo/pull/9499", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9499.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9499.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "JimmyZhang12", "id": 67203904, "node_id": "MDQ6VXNlcjY3MjAzOTA0", "avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JimmyZhang12", "html_url": "https://github.com/JimmyZhang12", "followers_url": "https://api.github.com/users/JimmyZhang12/followers", "following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}", "gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}", "starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions", "organizations_url": "https://api.github.com/users/JimmyZhang12/orgs", "repos_url": "https://api.github.com/users/JimmyZhang12/repos", "events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}", "received_events_url": "https://api.github.com/users/JimmyZhang12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9499/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9499/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9498
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9498/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9498/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9498/events
https://github.com/NVIDIA/NeMo/issues/9498
2,360,419,956
I_kwDOC_bI7s6MsSZ0
9,498
Can we add emotions to the produced audio?
{ "login": "shivgit07", "id": 106404626, "node_id": "U_kgDOBlebEg", "avatar_url": "https://avatars.githubusercontent.com/u/106404626?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shivgit07", "html_url": "https://github.com/shivgit07", "followers_url": "https://api.github.com/users/shivgit07/followers", "following_url": "https://api.github.com/users/shivgit07/following{/other_user}", "gists_url": "https://api.github.com/users/shivgit07/gists{/gist_id}", "starred_url": "https://api.github.com/users/shivgit07/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shivgit07/subscriptions", "organizations_url": "https://api.github.com/users/shivgit07/orgs", "repos_url": "https://api.github.com/users/shivgit07/repos", "events_url": "https://api.github.com/users/shivgit07/events{/privacy}", "received_events_url": "https://api.github.com/users/shivgit07/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "You will need to train your spectrogram generator / acoustic model with emotional data. Tag the emotional data as a new speaker and do inference with the emotional-speaker tag." ]
2024-06-18T18:06:19
2024-07-08T23:42:58
2024-07-08T23:42:58
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Hello, I was just trying some combinations of Mel-Spectogram-Generators and Vocoders to produce different audio samples. I was thinking if it was possible to make the produced audio sound more naturally by adding some kind of emotional embeddings in the Mel spectogram generator models. Or any other suitable approach to do this. I am new to TTS so not sure if such thing is possible. I would be highly grateful if somebody could help me out. Thanks.
{ "login": "blisc", "id": 4763352, "node_id": "MDQ6VXNlcjQ3NjMzNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blisc", "html_url": "https://github.com/blisc", "followers_url": "https://api.github.com/users/blisc/followers", "following_url": "https://api.github.com/users/blisc/following{/other_user}", "gists_url": "https://api.github.com/users/blisc/gists{/gist_id}", "starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blisc/subscriptions", "organizations_url": "https://api.github.com/users/blisc/orgs", "repos_url": "https://api.github.com/users/blisc/repos", "events_url": "https://api.github.com/users/blisc/events{/privacy}", "received_events_url": "https://api.github.com/users/blisc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9498/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9498/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9497
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9497/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9497/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9497/events
https://github.com/NVIDIA/NeMo/pull/9497
2,360,377,165
PR_kwDOC_bI7s5y2xb8
9,497
fix NameError: name 'ApexGuardDefaults' is not defined
{ "login": "raybellwaves", "id": 17162724, "node_id": "MDQ6VXNlcjE3MTYyNzI0", "avatar_url": "https://avatars.githubusercontent.com/u/17162724?v=4", "gravatar_id": "", "url": "https://api.github.com/users/raybellwaves", "html_url": "https://github.com/raybellwaves", "followers_url": "https://api.github.com/users/raybellwaves/followers", "following_url": "https://api.github.com/users/raybellwaves/following{/other_user}", "gists_url": "https://api.github.com/users/raybellwaves/gists{/gist_id}", "starred_url": "https://api.github.com/users/raybellwaves/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/raybellwaves/subscriptions", "organizations_url": "https://api.github.com/users/raybellwaves/orgs", "repos_url": "https://api.github.com/users/raybellwaves/repos", "events_url": "https://api.github.com/users/raybellwaves/events{/privacy}", "received_events_url": "https://api.github.com/users/raybellwaves/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Please someone help me merge this PR pls, its only one line and blocking me from doing the work :)", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "Thank you for reporting the issue. The suggested change is already in main https://github.com/NVIDIA/NeMo/blob/3e2bb2157fd99b963ae4c4da2464be754370c1c4/nemo/collections/nlp/models/language_modeling/megatron/gpt_layer_modelopt_spec.py#L15 so I'll close the MR" ]
2024-06-18T17:40:20
2024-07-12T12:48:25
2024-07-12T12:48:24
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9497", "html_url": "https://github.com/NVIDIA/NeMo/pull/9497", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9497.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9497.patch", "merged_at": null }
# What does this PR do ? I believe this should fix https://github.com/NVIDIA/NeMo/issues/9320 **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "janekl", "id": 5582967, "node_id": "MDQ6VXNlcjU1ODI5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janekl", "html_url": "https://github.com/janekl", "followers_url": "https://api.github.com/users/janekl/followers", "following_url": "https://api.github.com/users/janekl/following{/other_user}", "gists_url": "https://api.github.com/users/janekl/gists{/gist_id}", "starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janekl/subscriptions", "organizations_url": "https://api.github.com/users/janekl/orgs", "repos_url": "https://api.github.com/users/janekl/repos", "events_url": "https://api.github.com/users/janekl/events{/privacy}", "received_events_url": "https://api.github.com/users/janekl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9497/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9497/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9496
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9496/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9496/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9496/events
https://github.com/NVIDIA/NeMo/pull/9496
2,360,346,526
PR_kwDOC_bI7s5y2qsd
9,496
Update NeMo to hf convertion for Llama 3
{ "login": "JesusPaz", "id": 27715376, "node_id": "MDQ6VXNlcjI3NzE1Mzc2", "avatar_url": "https://avatars.githubusercontent.com/u/27715376?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JesusPaz", "html_url": "https://github.com/JesusPaz", "followers_url": "https://api.github.com/users/JesusPaz/followers", "following_url": "https://api.github.com/users/JesusPaz/following{/other_user}", "gists_url": "https://api.github.com/users/JesusPaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/JesusPaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JesusPaz/subscriptions", "organizations_url": "https://api.github.com/users/JesusPaz/orgs", "repos_url": "https://api.github.com/users/JesusPaz/repos", "events_url": "https://api.github.com/users/JesusPaz/events{/privacy}", "received_events_url": "https://api.github.com/users/JesusPaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-18T17:20:37
2024-07-10T01:49:54
2024-07-10T01:49:53
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9496", "html_url": "https://github.com/NVIDIA/NeMo/pull/9496", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9496.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9496.patch", "merged_at": null }
# What does this PR do ? Fix the script to convert Llama 3 from NeMo to hf format. ![image](https://github.com/NVIDIA/NeMo/assets/27715376/ab24e8b4-95cf-4e31-bb56-c60a6516cf6d) # Changelog - Stop using LlamaTokenizer and start using AutoTokenizer from Transformers. # Usage ```python python3 NeMo/scripts/checkpoint_converters/convert_llama_nemo_to_hf.py \ --input_name_or_path llama3-8b.nemo \ --output_path llama3-8b-hf/pytorch_model.bin \ --hf_input_path Meta-Llama-3-8B \ --hf_output_path llama3-8b-hf \ --input_tokenizer Meta-Llama-3-8B \ --hf_output_tokenizer llama3-8b-hf ``` you must except something like this when the script finishes: ![image](https://github.com/NVIDIA/NeMo/assets/27715376/1093b660-4b8a-460e-b6b2-9065c55ba2de) # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * there is an issue in hf related but is not the same script https://huggingface.co/meta-llama/Meta-Llama-3-8B-Instruct/discussions/37
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9496/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9496/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9495
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9495/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9495/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9495/events
https://github.com/NVIDIA/NeMo/issues/9495
2,359,853,628
I_kwDOC_bI7s6MqII8
9,495
Unable to reproduce cache aware streaming results for Conformer that were there for Fastconformer.
{ "login": "mujhenahiata", "id": 94825377, "node_id": "U_kgDOBabroQ", "avatar_url": "https://avatars.githubusercontent.com/u/94825377?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mujhenahiata", "html_url": "https://github.com/mujhenahiata", "followers_url": "https://api.github.com/users/mujhenahiata/followers", "following_url": "https://api.github.com/users/mujhenahiata/following{/other_user}", "gists_url": "https://api.github.com/users/mujhenahiata/gists{/gist_id}", "starred_url": "https://api.github.com/users/mujhenahiata/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mujhenahiata/subscriptions", "organizations_url": "https://api.github.com/users/mujhenahiata/orgs", "repos_url": "https://api.github.com/users/mujhenahiata/repos", "events_url": "https://api.github.com/users/mujhenahiata/events{/privacy}", "received_events_url": "https://api.github.com/users/mujhenahiata/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[]
2024-06-18T13:20:11
2024-06-23T14:16:17
2024-06-23T14:15:50
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
I trained Conformer-CTC using cache aware method. but unable to reproduce the results that were there with "Fastconformer cache aware streaming". By using Conformer-CTC cache aware method i get partial sub-words, words combined together like ("hello world" ==> herld) , in streaming output. the same was the case when i deployed it in a RIVA pipeline. but when i use the "transcribe" function i get proper transcription for the audio file. @titu1994 @VahidooX can you please enlighten on this. When to use and how to use streaming models in .nemo format and in RIVA pipeline. My question has some relevance with these issues [https://github.com/NVIDIA/NeMo/discussions/7010] [https://github.com/NVIDIA/NeMo/discussions/5284]
{ "login": "mujhenahiata", "id": 94825377, "node_id": "U_kgDOBabroQ", "avatar_url": "https://avatars.githubusercontent.com/u/94825377?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mujhenahiata", "html_url": "https://github.com/mujhenahiata", "followers_url": "https://api.github.com/users/mujhenahiata/followers", "following_url": "https://api.github.com/users/mujhenahiata/following{/other_user}", "gists_url": "https://api.github.com/users/mujhenahiata/gists{/gist_id}", "starred_url": "https://api.github.com/users/mujhenahiata/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mujhenahiata/subscriptions", "organizations_url": "https://api.github.com/users/mujhenahiata/orgs", "repos_url": "https://api.github.com/users/mujhenahiata/repos", "events_url": "https://api.github.com/users/mujhenahiata/events{/privacy}", "received_events_url": "https://api.github.com/users/mujhenahiata/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9495/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9495/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9494
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9494/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9494/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9494/events
https://github.com/NVIDIA/NeMo/pull/9494
2,359,811,347
PR_kwDOC_bI7s5y02C7
9,494
Distributed checkpointing user guide
{ "login": "mikolajblaz", "id": 9979479, "node_id": "MDQ6VXNlcjk5Nzk0Nzk=", "avatar_url": "https://avatars.githubusercontent.com/u/9979479?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mikolajblaz", "html_url": "https://github.com/mikolajblaz", "followers_url": "https://api.github.com/users/mikolajblaz/followers", "following_url": "https://api.github.com/users/mikolajblaz/following{/other_user}", "gists_url": "https://api.github.com/users/mikolajblaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/mikolajblaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mikolajblaz/subscriptions", "organizations_url": "https://api.github.com/users/mikolajblaz/orgs", "repos_url": "https://api.github.com/users/mikolajblaz/repos", "events_url": "https://api.github.com/users/mikolajblaz/events{/privacy}", "received_events_url": "https://api.github.com/users/mikolajblaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-06-18T13:00:28
2024-07-11T16:01:10
2024-07-11T16:01:08
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9494", "html_url": "https://github.com/NVIDIA/NeMo/pull/9494", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9494.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9494.patch", "merged_at": "2024-07-11T16:01:08" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9494/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9494/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9492
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9492/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9492/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9492/events
https://github.com/NVIDIA/NeMo/pull/9492
2,359,125,989
PR_kwDOC_bI7s5yygxR
9,492
[NeMo-UX] Fix bug in import_ckpt
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-18T07:18:44
2024-06-19T16:40:42
2024-06-19T16:40:41
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9492", "html_url": "https://github.com/NVIDIA/NeMo/pull/9492", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9492.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9492.patch", "merged_at": "2024-06-19T16:40:41" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9492/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9492/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9491
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9491/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9491/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9491/events
https://github.com/NVIDIA/NeMo/pull/9491
2,358,606,074
PR_kwDOC_bI7s5ywwHJ
9,491
draft: bert cp support
{ "login": "JimmyZhang12", "id": 67203904, "node_id": "MDQ6VXNlcjY3MjAzOTA0", "avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JimmyZhang12", "html_url": "https://github.com/JimmyZhang12", "followers_url": "https://api.github.com/users/JimmyZhang12/followers", "following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}", "gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}", "starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions", "organizations_url": "https://api.github.com/users/JimmyZhang12/orgs", "repos_url": "https://api.github.com/users/JimmyZhang12/repos", "events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}", "received_events_url": "https://api.github.com/users/JimmyZhang12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-18T01:15:58
2024-07-27T01:49:07
2024-07-27T01:49:06
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9491", "html_url": "https://github.com/NVIDIA/NeMo/pull/9491", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9491.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9491.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9491/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9491/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9490
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9490/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9490/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9490/events
https://github.com/NVIDIA/NeMo/pull/9490
2,358,577,694
PR_kwDOC_bI7s5ywp7W
9,490
[NeMo-UX] Add PEFT
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-18T00:52:47
2024-07-05T01:30:18
2024-07-05T01:30:16
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9490", "html_url": "https://github.com/NVIDIA/NeMo/pull/9490", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9490.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9490.patch", "merged_at": "2024-07-05T01:30:16" }
# What does this PR do ? Initial PR for PEFT in nemo 2.0 **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "sararb", "id": 17721108, "node_id": "MDQ6VXNlcjE3NzIxMTA4", "avatar_url": "https://avatars.githubusercontent.com/u/17721108?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sararb", "html_url": "https://github.com/sararb", "followers_url": "https://api.github.com/users/sararb/followers", "following_url": "https://api.github.com/users/sararb/following{/other_user}", "gists_url": "https://api.github.com/users/sararb/gists{/gist_id}", "starred_url": "https://api.github.com/users/sararb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sararb/subscriptions", "organizations_url": "https://api.github.com/users/sararb/orgs", "repos_url": "https://api.github.com/users/sararb/repos", "events_url": "https://api.github.com/users/sararb/events{/privacy}", "received_events_url": "https://api.github.com/users/sararb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9490/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9490/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9489
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9489/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9489/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9489/events
https://github.com/NVIDIA/NeMo/pull/9489
2,358,550,261
PR_kwDOC_bI7s5ywj52
9,489
TE guard to avoid MPI dependency
{ "login": "erhoo82", "id": 15861259, "node_id": "MDQ6VXNlcjE1ODYxMjU5", "avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/erhoo82", "html_url": "https://github.com/erhoo82", "followers_url": "https://api.github.com/users/erhoo82/followers", "following_url": "https://api.github.com/users/erhoo82/following{/other_user}", "gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}", "starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions", "organizations_url": "https://api.github.com/users/erhoo82/orgs", "repos_url": "https://api.github.com/users/erhoo82/repos", "events_url": "https://api.github.com/users/erhoo82/events{/privacy}", "received_events_url": "https://api.github.com/users/erhoo82/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-18T00:25:15
2024-07-19T01:49:56
2024-07-19T01:49:55
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9489", "html_url": "https://github.com/NVIDIA/NeMo/pull/9489", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9489.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9489.patch", "merged_at": null }
# What does this PR do ? TE version guard to support with and without MPI dependencies. # Changelog - Added TE version guard for userbuffer communication initialization # Usage N/A # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9489/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9489/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9488
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9488/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9488/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9488/events
https://github.com/NVIDIA/NeMo/pull/9488
2,358,503,752
PR_kwDOC_bI7s5ywZ3U
9,488
Make QLoRA more model-agnostic
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days." ]
2024-06-17T23:44:16
2024-07-02T16:45:45
2024-07-02T16:45:43
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9488", "html_url": "https://github.com/NVIDIA/NeMo/pull/9488", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9488.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9488.patch", "merged_at": "2024-07-02T16:45:43" }
# What does this PR do ? Support QLoRA for more models **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "arendu", "id": 108822655, "node_id": "U_kgDOBnyAfw", "avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arendu", "html_url": "https://github.com/arendu", "followers_url": "https://api.github.com/users/arendu/followers", "following_url": "https://api.github.com/users/arendu/following{/other_user}", "gists_url": "https://api.github.com/users/arendu/gists{/gist_id}", "starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arendu/subscriptions", "organizations_url": "https://api.github.com/users/arendu/orgs", "repos_url": "https://api.github.com/users/arendu/repos", "events_url": "https://api.github.com/users/arendu/events{/privacy}", "received_events_url": "https://api.github.com/users/arendu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9488/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9488/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9487
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9487/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9487/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9487/events
https://github.com/NVIDIA/NeMo/pull/9487
2,357,353,382
PR_kwDOC_bI7s5ysb7z
9,487
Use Mcore's Modelopt Spec When Exporting
{ "login": "suiyoubi", "id": 22045332, "node_id": "MDQ6VXNlcjIyMDQ1MzMy", "avatar_url": "https://avatars.githubusercontent.com/u/22045332?v=4", "gravatar_id": "", "url": "https://api.github.com/users/suiyoubi", "html_url": "https://github.com/suiyoubi", "followers_url": "https://api.github.com/users/suiyoubi/followers", "following_url": "https://api.github.com/users/suiyoubi/following{/other_user}", "gists_url": "https://api.github.com/users/suiyoubi/gists{/gist_id}", "starred_url": "https://api.github.com/users/suiyoubi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/suiyoubi/subscriptions", "organizations_url": "https://api.github.com/users/suiyoubi/orgs", "repos_url": "https://api.github.com/users/suiyoubi/repos", "events_url": "https://api.github.com/users/suiyoubi/events{/privacy}", "received_events_url": "https://api.github.com/users/suiyoubi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Thanks, approved. Just please make sure that CI pipeline passes", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "Hi @suiyoubi, do you think we could get this in? It just needs conflict resolution", "Hmm I think that @akoumpa extended https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/nlp/models/language_modeling/megatron/gpt_layer_modelopt_spec.py to cover MoE.\r\n\r\nSo we can't really replace the spec unless we also enable MoE layer spec in https://github.com/NVIDIA/Megatron-LM/blob/main/megatron/core/inference/gpt/model_specs.py", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-17T13:27:02
2024-08-17T01:49:27
2024-08-17T01:49:26
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9487", "html_url": "https://github.com/NVIDIA/NeMo/pull/9487", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9487.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9487.patch", "merged_at": null }
# What does this PR do ? Unified to use mcore's modelopt specs instead of the NeMo one
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9487/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9487/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9486
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9486/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9486/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9486/events
https://github.com/NVIDIA/NeMo/pull/9486
2,356,984,572
PR_kwDOC_bI7s5yrLJY
9,486
[NeMo-UX] Fixing defaults in llm.train & Mistral7BModel
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-17T10:26:23
2024-06-17T15:38:52
2024-06-17T15:38:51
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9486", "html_url": "https://github.com/NVIDIA/NeMo/pull/9486", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9486.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9486.patch", "merged_at": "2024-06-17T15:38:51" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9486/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9486/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9485
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9485/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9485/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9485/events
https://github.com/NVIDIA/NeMo/pull/9485
2,356,831,000
PR_kwDOC_bI7s5yqpQZ
9,485
[NeMo-UX] Integrate tokenizer import into model.import_ckpt
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "we will fix the mcore DDP prefix problem in a subsequent PR" ]
2024-06-17T09:14:49
2024-06-17T23:00:53
2024-06-17T22:59:47
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9485", "html_url": "https://github.com/NVIDIA/NeMo/pull/9485", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9485.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9485.patch", "merged_at": "2024-06-17T22:59:47" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9485/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9485/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9484
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9484/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9484/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9484/events
https://github.com/NVIDIA/NeMo/pull/9484
2,355,383,476
PR_kwDOC_bI7s5ylvbl
9,484
Add return type hint to from_pretrained method
{ "login": "hoel-bagard", "id": 34478245, "node_id": "MDQ6VXNlcjM0NDc4MjQ1", "avatar_url": "https://avatars.githubusercontent.com/u/34478245?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hoel-bagard", "html_url": "https://github.com/hoel-bagard", "followers_url": "https://api.github.com/users/hoel-bagard/followers", "following_url": "https://api.github.com/users/hoel-bagard/following{/other_user}", "gists_url": "https://api.github.com/users/hoel-bagard/gists{/gist_id}", "starred_url": "https://api.github.com/users/hoel-bagard/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hoel-bagard/subscriptions", "organizations_url": "https://api.github.com/users/hoel-bagard/orgs", "repos_url": "https://api.github.com/users/hoel-bagard/repos", "events_url": "https://api.github.com/users/hoel-bagard/events{/privacy}", "received_events_url": "https://api.github.com/users/hoel-bagard/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-16T02:24:29
2024-07-09T01:49:40
2024-07-09T01:49:39
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9484", "html_url": "https://github.com/NVIDIA/NeMo/pull/9484", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9484.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9484.patch", "merged_at": null }
# What does this PR do ? Add a type hint. **Collection**: [core] # Changelog Add return type hint to the `Model`'s `from_pretrained` method. # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [x] Did you write any new necessary tests? - [x] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9484/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9484/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9483
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9483/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9483/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9483/events
https://github.com/NVIDIA/NeMo/pull/9483
2,354,369,103
PR_kwDOC_bI7s5yiUIQ
9,483
append to file
{ "login": "malay-nagda", "id": 164242706, "node_id": "U_kgDOCcolEg", "avatar_url": "https://avatars.githubusercontent.com/u/164242706?v=4", "gravatar_id": "", "url": "https://api.github.com/users/malay-nagda", "html_url": "https://github.com/malay-nagda", "followers_url": "https://api.github.com/users/malay-nagda/followers", "following_url": "https://api.github.com/users/malay-nagda/following{/other_user}", "gists_url": "https://api.github.com/users/malay-nagda/gists{/gist_id}", "starred_url": "https://api.github.com/users/malay-nagda/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/malay-nagda/subscriptions", "organizations_url": "https://api.github.com/users/malay-nagda/orgs", "repos_url": "https://api.github.com/users/malay-nagda/repos", "events_url": "https://api.github.com/users/malay-nagda/events{/privacy}", "received_events_url": "https://api.github.com/users/malay-nagda/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-15T01:16:55
2024-06-18T00:05:00
2024-06-18T00:05:00
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9483", "html_url": "https://github.com/NVIDIA/NeMo/pull/9483", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9483.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9483.patch", "merged_at": "2024-06-18T00:05:00" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9483/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9483/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9482
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9482/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9482/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9482/events
https://github.com/NVIDIA/NeMo/pull/9482
2,354,326,045
PR_kwDOC_bI7s5yiKJ-
9,482
NeMo performance feature documentation
{ "login": "erhoo82", "id": 15861259, "node_id": "MDQ6VXNlcjE1ODYxMjU5", "avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/erhoo82", "html_url": "https://github.com/erhoo82", "followers_url": "https://api.github.com/users/erhoo82/followers", "following_url": "https://api.github.com/users/erhoo82/following{/other_user}", "gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}", "starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions", "organizations_url": "https://api.github.com/users/erhoo82/orgs", "repos_url": "https://api.github.com/users/erhoo82/repos", "events_url": "https://api.github.com/users/erhoo82/events{/privacy}", "received_events_url": "https://api.github.com/users/erhoo82/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "Thanks, @jgerh for the suggestions.\r\nThere seem to be too many rephrases. If the changes are mainly about rewording, can you push the changes to my branch?", "I appreciate the feedback. I can update my edits and focus on copyediting only, rather than rephrasing. " ]
2024-06-15T00:48:25
2024-07-11T20:51:38
2024-07-11T20:51:38
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9482", "html_url": "https://github.com/NVIDIA/NeMo/pull/9482", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9482.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9482.patch", "merged_at": "2024-07-11T20:51:38" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9482/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9482/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9481
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9481/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9481/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9481/events
https://github.com/NVIDIA/NeMo/pull/9481
2,354,285,419
PR_kwDOC_bI7s5yiA63
9,481
Distributed optimizer aligns FP8 transposes over pipeline-parallel group
{ "login": "timmoon10", "id": 4406448, "node_id": "MDQ6VXNlcjQ0MDY0NDg=", "avatar_url": "https://avatars.githubusercontent.com/u/4406448?v=4", "gravatar_id": "", "url": "https://api.github.com/users/timmoon10", "html_url": "https://github.com/timmoon10", "followers_url": "https://api.github.com/users/timmoon10/followers", "following_url": "https://api.github.com/users/timmoon10/following{/other_user}", "gists_url": "https://api.github.com/users/timmoon10/gists{/gist_id}", "starred_url": "https://api.github.com/users/timmoon10/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/timmoon10/subscriptions", "organizations_url": "https://api.github.com/users/timmoon10/orgs", "repos_url": "https://api.github.com/users/timmoon10/repos", "events_url": "https://api.github.com/users/timmoon10/events{/privacy}", "received_events_url": "https://api.github.com/users/timmoon10/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-15T00:17:02
2024-08-22T01:52:58
2024-08-22T01:52:57
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9481", "html_url": "https://github.com/NVIDIA/NeMo/pull/9481", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9481.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9481.patch", "merged_at": null }
# What does this PR do ? When training GPT in FP8 with interleaved pipeline parallelism, we have experienced some GPU idling due to load imbalances across the pipeline parallel group. The first microbatch in a training step requires computing an FP8 weight transpose, which is reused in later microbatches. The fix is to align the FP8 weight transposes across the pipeline parallel group, similar to how we align param all-gathers and grad reduce-scatters (see https://github.com/NVIDIA/apex/pull/1611 and https://github.com/NVIDIA/NeMo/pull/6183). **Collection**: NLP # Changelog - Distributed optimizer aligns FP8 transposes over pipeline-parallel group # Usage Run GPT, e.g. with the config at https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/language_modeling/conf/megatron_gpt_config.yaml. The following settings are required for this optimization: - `model.virtual_pipeline_model_parallel_size=<layers per virtual pipeline stage>` - `model.transformer_engine=True` - `model.fp8=True` - `model.fp8_params=True` - `model.optim.name=distributed_fused_adam` - `model.optim.overlap_param_sync=True` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9481/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9481/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9480
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9480/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9480/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9480/events
https://github.com/NVIDIA/NeMo/pull/9480
2,354,227,631
PR_kwDOC_bI7s5yhz3v
9,480
Fix unwrap model
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-14T23:23:58
2024-06-17T23:47:34
2024-06-17T23:47:33
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9480", "html_url": "https://github.com/NVIDIA/NeMo/pull/9480", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9480.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9480.patch", "merged_at": "2024-06-17T23:47:33" }
# What does this PR do ? Fixes a bug from #9392. State dict key names accessed after `_unwrap_model()` should contain a `model` prefix to be equivalent to before. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "arendu", "id": 108822655, "node_id": "U_kgDOBnyAfw", "avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arendu", "html_url": "https://github.com/arendu", "followers_url": "https://api.github.com/users/arendu/followers", "following_url": "https://api.github.com/users/arendu/following{/other_user}", "gists_url": "https://api.github.com/users/arendu/gists{/gist_id}", "starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arendu/subscriptions", "organizations_url": "https://api.github.com/users/arendu/orgs", "repos_url": "https://api.github.com/users/arendu/repos", "events_url": "https://api.github.com/users/arendu/events{/privacy}", "received_events_url": "https://api.github.com/users/arendu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9480/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9480/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9479
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9479/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9479/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9479/events
https://github.com/NVIDIA/NeMo/pull/9479
2,354,182,493
PR_kwDOC_bI7s5yhqOd
9,479
Added CPU offloading docs
{ "login": "sanandaraj5597", "id": 55270934, "node_id": "MDQ6VXNlcjU1MjcwOTM0", "avatar_url": "https://avatars.githubusercontent.com/u/55270934?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sanandaraj5597", "html_url": "https://github.com/sanandaraj5597", "followers_url": "https://api.github.com/users/sanandaraj5597/followers", "following_url": "https://api.github.com/users/sanandaraj5597/following{/other_user}", "gists_url": "https://api.github.com/users/sanandaraj5597/gists{/gist_id}", "starred_url": "https://api.github.com/users/sanandaraj5597/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sanandaraj5597/subscriptions", "organizations_url": "https://api.github.com/users/sanandaraj5597/orgs", "repos_url": "https://api.github.com/users/sanandaraj5597/repos", "events_url": "https://api.github.com/users/sanandaraj5597/events{/privacy}", "received_events_url": "https://api.github.com/users/sanandaraj5597/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "Completed Tech Pubs review and provided copyedits and suggested paragraph revisions." ]
2024-06-14T22:18:57
2024-07-10T17:56:42
2024-07-10T17:56:40
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9479", "html_url": "https://github.com/NVIDIA/NeMo/pull/9479", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9479.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9479.patch", "merged_at": "2024-07-10T17:56:40" }
null
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9479/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9479/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9478
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9478/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9478/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9478/events
https://github.com/NVIDIA/NeMo/pull/9478
2,354,173,644
PR_kwDOC_bI7s5yhoXZ
9,478
Enable user to optionally upgrade Megatron
{ "login": "jstjohn", "id": 459014, "node_id": "MDQ6VXNlcjQ1OTAxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/459014?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jstjohn", "html_url": "https://github.com/jstjohn", "followers_url": "https://api.github.com/users/jstjohn/followers", "following_url": "https://api.github.com/users/jstjohn/following{/other_user}", "gists_url": "https://api.github.com/users/jstjohn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jstjohn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jstjohn/subscriptions", "organizations_url": "https://api.github.com/users/jstjohn/orgs", "repos_url": "https://api.github.com/users/jstjohn/repos", "events_url": "https://api.github.com/users/jstjohn/events{/privacy}", "received_events_url": "https://api.github.com/users/jstjohn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-14T22:07:22
2024-06-17T09:13:43
2024-06-17T09:13:42
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9478", "html_url": "https://github.com/NVIDIA/NeMo/pull/9478", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9478.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9478.patch", "merged_at": "2024-06-17T09:13:42" }
# What does this PR do ? Support both the old and new version of megatron DDP with a wrapper that checks for valid kwargs. **Collection**: lightning # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9478/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9478/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9477
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9477/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9477/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9477/events
https://github.com/NVIDIA/NeMo/pull/9477
2,354,163,625
PR_kwDOC_bI7s5yhmN7
9,477
set maxlen based on stage and obey max_seq_length settings
{ "login": "arendu", "id": 108822655, "node_id": "U_kgDOBnyAfw", "avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arendu", "html_url": "https://github.com/arendu", "followers_url": "https://api.github.com/users/arendu/followers", "following_url": "https://api.github.com/users/arendu/following{/other_user}", "gists_url": "https://api.github.com/users/arendu/gists{/gist_id}", "starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arendu/subscriptions", "organizations_url": "https://api.github.com/users/arendu/orgs", "repos_url": "https://api.github.com/users/arendu/repos", "events_url": "https://api.github.com/users/arendu/events{/privacy}", "received_events_url": "https://api.github.com/users/arendu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-14T21:55:27
2024-07-09T01:49:41
2024-07-09T01:49:41
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9477", "html_url": "https://github.com/NVIDIA/NeMo/pull/9477", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9477.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9477.patch", "merged_at": null }
# What does this PR do ? memory/tokens for generation is pre-assigned with size `min(context_lenght + tokens_to_generate, max_seq_length)` This causes a crash if `context_length + tokens_to_generate` > `max_seq_length` because the clipping strategy was not doing any clipping of the maxlen. This PR adds the clipping strategy for models that don't use learned position embeddings. **Collection**: [NLP] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9477/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9477/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9476
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9476/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9476/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9476/events
https://github.com/NVIDIA/NeMo/pull/9476
2,354,157,766
PR_kwDOC_bI7s5yhk-8
9,476
[NeMo-UX] Fixing imports of NeMoLogging, AutoResume & ModelCheckpoint
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-14T21:48:35
2024-06-17T10:10:16
2024-06-17T10:10:15
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9476", "html_url": "https://github.com/NVIDIA/NeMo/pull/9476", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9476.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9476.patch", "merged_at": "2024-06-17T10:10:15" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9476/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9476/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9475
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9475/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9475/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9475/events
https://github.com/NVIDIA/NeMo/pull/9475
2,353,735,131
PR_kwDOC_bI7s5ygHsx
9,475
bionemo: bn2/add pipelineparallel dtype
{ "login": "skothenhill-nv", "id": 148821680, "node_id": "U_kgDOCN7WsA", "avatar_url": "https://avatars.githubusercontent.com/u/148821680?v=4", "gravatar_id": "", "url": "https://api.github.com/users/skothenhill-nv", "html_url": "https://github.com/skothenhill-nv", "followers_url": "https://api.github.com/users/skothenhill-nv/followers", "following_url": "https://api.github.com/users/skothenhill-nv/following{/other_user}", "gists_url": "https://api.github.com/users/skothenhill-nv/gists{/gist_id}", "starred_url": "https://api.github.com/users/skothenhill-nv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/skothenhill-nv/subscriptions", "organizations_url": "https://api.github.com/users/skothenhill-nv/orgs", "repos_url": "https://api.github.com/users/skothenhill-nv/repos", "events_url": "https://api.github.com/users/skothenhill-nv/events{/privacy}", "received_events_url": "https://api.github.com/users/skothenhill-nv/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-14T16:42:01
2024-06-14T18:04:53
2024-06-14T18:04:53
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9475", "html_url": "https://github.com/NVIDIA/NeMo/pull/9475", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9475.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9475.patch", "merged_at": "2024-06-14T18:04:53" }
Fixes a bug from `parallel_dtype` not being correctly passed in the `parallelism` method.
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9475/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9475/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9474
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9474/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9474/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9474/events
https://github.com/NVIDIA/NeMo/pull/9474
2,353,668,268
PR_kwDOC_bI7s5yf46r
9,474
[do-not-merge] SpeechLLM dev branch
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-14T16:01:00
2024-07-07T01:52:57
2024-07-07T01:52:56
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9474", "html_url": "https://github.com/NVIDIA/NeMo/pull/9474", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9474.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9474.patch", "merged_at": null }
# What does this PR do ? This PR is for tracking the changes in speech-llm main development branch w.r.t. main. **Collection**: multimodal # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9474/reactions", "total_count": 2, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 1 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9474/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9473
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9473/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9473/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9473/events
https://github.com/NVIDIA/NeMo/pull/9473
2,353,470,674
PR_kwDOC_bI7s5yfNfK
9,473
[Resiliency] Straggler detection
{ "login": "jbieniusiewi", "id": 152396322, "node_id": "U_kgDOCRViIg", "avatar_url": "https://avatars.githubusercontent.com/u/152396322?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jbieniusiewi", "html_url": "https://github.com/jbieniusiewi", "followers_url": "https://api.github.com/users/jbieniusiewi/followers", "following_url": "https://api.github.com/users/jbieniusiewi/following{/other_user}", "gists_url": "https://api.github.com/users/jbieniusiewi/gists{/gist_id}", "starred_url": "https://api.github.com/users/jbieniusiewi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jbieniusiewi/subscriptions", "organizations_url": "https://api.github.com/users/jbieniusiewi/orgs", "repos_url": "https://api.github.com/users/jbieniusiewi/repos", "events_url": "https://api.github.com/users/jbieniusiewi/events{/privacy}", "received_events_url": "https://api.github.com/users/jbieniusiewi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1719393562, "node_id": "MDU6TGFiZWwxNzE5MzkzNTYy", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature", "name": "feature", "color": "68F3F0", "default": false, "description": "request/PR for a new feature" }, { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-14T14:10:37
2024-06-28T06:04:46
2024-06-28T06:04:45
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9473", "html_url": "https://github.com/NVIDIA/NeMo/pull/9473", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9473.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9473.patch", "merged_at": "2024-06-28T06:04:45" }
# What does this PR do ? Detects slower GPUs ("stragglers") participating in a distributed training. **Collection**: [Note which collection this PR will affect] # Changelog - The PLT callback is implemented in a separate, optional package. It has no dependencies on NeMo. # Usage Configure and enable the callback: ``` ++training.exp_manager.create_straggler_detection_callback=True \ ++training.exp_manager.straggler_detection_params.report_time_interval=300 \ ++training.exp_manager.straggler_detection_params.num_gpu_perf_scores_to_log=3 \ ``` In the example above, it will perform the stragglers check every 5 minutes. For more details, please refer to "Stragglers Detection" section in the exp manager documentation. # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9473/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9473/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9472
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9472/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9472/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9472/events
https://github.com/NVIDIA/NeMo/pull/9472
2,352,601,728
PR_kwDOC_bI7s5ycQjQ
9,472
Fix table in FP8 args docs
{ "login": "ksivaman", "id": 36168853, "node_id": "MDQ6VXNlcjM2MTY4ODUz", "avatar_url": "https://avatars.githubusercontent.com/u/36168853?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ksivaman", "html_url": "https://github.com/ksivaman", "followers_url": "https://api.github.com/users/ksivaman/followers", "following_url": "https://api.github.com/users/ksivaman/following{/other_user}", "gists_url": "https://api.github.com/users/ksivaman/gists{/gist_id}", "starred_url": "https://api.github.com/users/ksivaman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ksivaman/subscriptions", "organizations_url": "https://api.github.com/users/ksivaman/orgs", "repos_url": "https://api.github.com/users/ksivaman/repos", "events_url": "https://api.github.com/users/ksivaman/events{/privacy}", "received_events_url": "https://api.github.com/users/ksivaman/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "ksivaman", "id": 36168853, "node_id": "MDQ6VXNlcjM2MTY4ODUz", "avatar_url": "https://avatars.githubusercontent.com/u/36168853?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ksivaman", "html_url": "https://github.com/ksivaman", "followers_url": "https://api.github.com/users/ksivaman/followers", "following_url": "https://api.github.com/users/ksivaman/following{/other_user}", "gists_url": "https://api.github.com/users/ksivaman/gists{/gist_id}", "starred_url": "https://api.github.com/users/ksivaman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ksivaman/subscriptions", "organizations_url": "https://api.github.com/users/ksivaman/orgs", "repos_url": "https://api.github.com/users/ksivaman/repos", "events_url": "https://api.github.com/users/ksivaman/events{/privacy}", "received_events_url": "https://api.github.com/users/ksivaman/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "ksivaman", "id": 36168853, "node_id": "MDQ6VXNlcjM2MTY4ODUz", "avatar_url": "https://avatars.githubusercontent.com/u/36168853?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ksivaman", "html_url": "https://github.com/ksivaman", "followers_url": "https://api.github.com/users/ksivaman/followers", "following_url": "https://api.github.com/users/ksivaman/following{/other_user}", "gists_url": "https://api.github.com/users/ksivaman/gists{/gist_id}", "starred_url": "https://api.github.com/users/ksivaman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ksivaman/subscriptions", "organizations_url": "https://api.github.com/users/ksivaman/orgs", "repos_url": "https://api.github.com/users/ksivaman/repos", "events_url": "https://api.github.com/users/ksivaman/events{/privacy}", "received_events_url": "https://api.github.com/users/ksivaman/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-14T06:16:14
2024-07-07T01:52:58
2024-07-07T01:52:57
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9472", "html_url": "https://github.com/NVIDIA/NeMo/pull/9472", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9472.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9472.patch", "merged_at": null }
# What does this PR do ? Fixes the incorrectly rendered table in FP8 args documention. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [x] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9472/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9472/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9471
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9471/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9471/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9471/events
https://github.com/NVIDIA/NeMo/issues/9471
2,352,413,897
I_kwDOC_bI7s6MNvzJ
9,471
How to config a locally model?
{ "login": "DUZHUJUN", "id": 34333140, "node_id": "MDQ6VXNlcjM0MzMzMTQw", "avatar_url": "https://avatars.githubusercontent.com/u/34333140?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DUZHUJUN", "html_url": "https://github.com/DUZHUJUN", "followers_url": "https://api.github.com/users/DUZHUJUN/followers", "following_url": "https://api.github.com/users/DUZHUJUN/following{/other_user}", "gists_url": "https://api.github.com/users/DUZHUJUN/gists{/gist_id}", "starred_url": "https://api.github.com/users/DUZHUJUN/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DUZHUJUN/subscriptions", "organizations_url": "https://api.github.com/users/DUZHUJUN/orgs", "repos_url": "https://api.github.com/users/DUZHUJUN/repos", "events_url": "https://api.github.com/users/DUZHUJUN/events{/privacy}", "received_events_url": "https://api.github.com/users/DUZHUJUN/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 5105389764, "node_id": "LA_kwDOC_bI7s8AAAABME4QxA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/discussion", "name": "discussion", "color": "88C8B9", "default": false, "description": "" } ]
closed
false
{ "login": "oyilmaz-nvidia", "id": 35306097, "node_id": "MDQ6VXNlcjM1MzA2MDk3", "avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oyilmaz-nvidia", "html_url": "https://github.com/oyilmaz-nvidia", "followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers", "following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}", "gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions", "organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs", "repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos", "events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "oyilmaz-nvidia", "id": 35306097, "node_id": "MDQ6VXNlcjM1MzA2MDk3", "avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oyilmaz-nvidia", "html_url": "https://github.com/oyilmaz-nvidia", "followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers", "following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}", "gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions", "organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs", "repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos", "events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-06-14T03:30:09
2024-07-03T18:25:18
2024-07-03T18:25:18
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
Does this project support the use of locally deployed models? How should it be written in the configuration? There are no detailed examples in the documentation please help me,THX!
null
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9471/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9471/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9470
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9470/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9470/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9470/events
https://github.com/NVIDIA/NeMo/pull/9470
2,352,115,655
PR_kwDOC_bI7s5yanYk
9,470
Fix redirects of old links to new links
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-06-13T21:43:26
2024-06-13T21:44:21
2024-06-13T21:44:20
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9470", "html_url": "https://github.com/NVIDIA/NeMo/pull/9470", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9470.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9470.patch", "merged_at": "2024-06-13T21:44:20" }
# What does this PR do ? Adds explicit link to the correct new website **Collection**: [ASR] # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR.
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9470/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9470/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9469
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9469/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9469/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9469/events
https://github.com/NVIDIA/NeMo/pull/9469
2,352,100,841
PR_kwDOC_bI7s5yakJu
9,469
Fix logging message for ASR
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-13T21:31:58
2024-06-13T21:52:16
2024-06-13T21:42:27
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9469", "html_url": "https://github.com/NVIDIA/NeMo/pull/9469", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9469.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9469.patch", "merged_at": "2024-06-13T21:42:27" }
# What does this PR do ? Fix logging.warn to warning for ASR **Collection**: [ASR] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9469/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9469/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9468
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9468/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9468/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9468/events
https://github.com/NVIDIA/NeMo/pull/9468
2,351,957,832
PR_kwDOC_bI7s5yaESZ
9,468
In framework deploy using deploy script
{ "login": "oyilmaz-nvidia", "id": 35306097, "node_id": "MDQ6VXNlcjM1MzA2MDk3", "avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oyilmaz-nvidia", "html_url": "https://github.com/oyilmaz-nvidia", "followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers", "following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}", "gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions", "organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs", "repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos", "events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-13T20:02:18
2024-06-17T18:10:52
2024-06-17T18:10:52
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9468", "html_url": "https://github.com/NVIDIA/NeMo/pull/9468", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9468.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9468.patch", "merged_at": "2024-06-17T18:10:52" }
# What does this PR do ? In framework deploy using deploy script
{ "login": "oyilmaz-nvidia", "id": 35306097, "node_id": "MDQ6VXNlcjM1MzA2MDk3", "avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oyilmaz-nvidia", "html_url": "https://github.com/oyilmaz-nvidia", "followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers", "following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}", "gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions", "organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs", "repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos", "events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9468/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9468/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9467
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9467/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9467/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9467/events
https://github.com/NVIDIA/NeMo/pull/9467
2,351,890,504
PR_kwDOC_bI7s5yZ1hw
9,467
Update build_dataset.py
{ "login": "stevehuang52", "id": 105218074, "node_id": "U_kgDOBkWAGg", "avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevehuang52", "html_url": "https://github.com/stevehuang52", "followers_url": "https://api.github.com/users/stevehuang52/followers", "following_url": "https://api.github.com/users/stevehuang52/following{/other_user}", "gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions", "organizations_url": "https://api.github.com/users/stevehuang52/orgs", "repos_url": "https://api.github.com/users/stevehuang52/repos", "events_url": "https://api.github.com/users/stevehuang52/events{/privacy}", "received_events_url": "https://api.github.com/users/stevehuang52/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[]
2024-06-13T19:18:33
2024-06-13T19:25:38
2024-06-13T19:25:38
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9467", "html_url": "https://github.com/NVIDIA/NeMo/pull/9467", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9467.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9467.patch", "merged_at": "2024-06-13T19:25:38" }
fix bug during eval
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9467/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9467/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9466
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9466/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9466/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9466/events
https://github.com/NVIDIA/NeMo/pull/9466
2,351,776,535
PR_kwDOC_bI7s5yZcgH
9,466
[NeMo-UX] async checkpointing support
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days." ]
2024-06-13T18:13:51
2024-07-08T00:25:12
2024-07-08T00:25:09
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9466", "html_url": "https://github.com/NVIDIA/NeMo/pull/9466", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9466.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9466.patch", "merged_at": "2024-07-08T00:25:09" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9466/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9466/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9465
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9465/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9465/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9465/events
https://github.com/NVIDIA/NeMo/pull/9465
2,351,745,896
PR_kwDOC_bI7s5yZV3r
9,465
ci(notifications): Fetch all jobs
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-13T17:55:54
2024-06-13T18:49:31
2024-06-13T18:49:30
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9465", "html_url": "https://github.com/NVIDIA/NeMo/pull/9465", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9465.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9465.patch", "merged_at": "2024-06-13T18:49:30" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9465/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9465/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9464
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9464/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9464/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9464/events
https://github.com/NVIDIA/NeMo/pull/9464
2,351,476,420
PR_kwDOC_bI7s5yYbEP
9,464
Add CICD test for Stable Diffusion
{ "login": "michal2409", "id": 14821051, "node_id": "MDQ6VXNlcjE0ODIxMDUx", "avatar_url": "https://avatars.githubusercontent.com/u/14821051?v=4", "gravatar_id": "", "url": "https://api.github.com/users/michal2409", "html_url": "https://github.com/michal2409", "followers_url": "https://api.github.com/users/michal2409/followers", "following_url": "https://api.github.com/users/michal2409/following{/other_user}", "gists_url": "https://api.github.com/users/michal2409/gists{/gist_id}", "starred_url": "https://api.github.com/users/michal2409/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/michal2409/subscriptions", "organizations_url": "https://api.github.com/users/michal2409/orgs", "repos_url": "https://api.github.com/users/michal2409/repos", "events_url": "https://api.github.com/users/michal2409/events{/privacy}", "received_events_url": "https://api.github.com/users/michal2409/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-13T15:43:08
2024-06-24T16:27:47
2024-06-24T16:27:46
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9464", "html_url": "https://github.com/NVIDIA/NeMo/pull/9464", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9464.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9464.patch", "merged_at": "2024-06-24T16:27:46" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "michal2409", "id": 14821051, "node_id": "MDQ6VXNlcjE0ODIxMDUx", "avatar_url": "https://avatars.githubusercontent.com/u/14821051?v=4", "gravatar_id": "", "url": "https://api.github.com/users/michal2409", "html_url": "https://github.com/michal2409", "followers_url": "https://api.github.com/users/michal2409/followers", "following_url": "https://api.github.com/users/michal2409/following{/other_user}", "gists_url": "https://api.github.com/users/michal2409/gists{/gist_id}", "starred_url": "https://api.github.com/users/michal2409/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/michal2409/subscriptions", "organizations_url": "https://api.github.com/users/michal2409/orgs", "repos_url": "https://api.github.com/users/michal2409/repos", "events_url": "https://api.github.com/users/michal2409/events{/privacy}", "received_events_url": "https://api.github.com/users/michal2409/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9464/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9464/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9463
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9463/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9463/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9463/events
https://github.com/NVIDIA/NeMo/pull/9463
2,351,271,710
PR_kwDOC_bI7s5yXuL0
9,463
Fix minor import bug in deploy module
{ "login": "oyilmaz-nvidia", "id": 35306097, "node_id": "MDQ6VXNlcjM1MzA2MDk3", "avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oyilmaz-nvidia", "html_url": "https://github.com/oyilmaz-nvidia", "followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers", "following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}", "gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions", "organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs", "repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos", "events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "CI passed https://github.com/NVIDIA/NeMo/actions/runs/9501290253\r\n" ]
2024-06-13T14:14:34
2024-06-13T16:34:41
2024-06-13T16:34:41
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9463", "html_url": "https://github.com/NVIDIA/NeMo/pull/9463", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9463.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9463.patch", "merged_at": "2024-06-13T16:34:41" }
# What does this PR do ? bugfix in deploy module
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9463/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9463/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9462
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9462/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9462/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9462/events
https://github.com/NVIDIA/NeMo/issues/9462
2,350,521,321
I_kwDOC_bI7s6MGhvp
9,462
Using lhotse when training a hybrid fast conformer model fails
{ "login": "dhoore123", "id": 172583247, "node_id": "U_kgDOCklpTw", "avatar_url": "https://avatars.githubusercontent.com/u/172583247?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dhoore123", "html_url": "https://github.com/dhoore123", "followers_url": "https://api.github.com/users/dhoore123/followers", "following_url": "https://api.github.com/users/dhoore123/following{/other_user}", "gists_url": "https://api.github.com/users/dhoore123/gists{/gist_id}", "starred_url": "https://api.github.com/users/dhoore123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dhoore123/subscriptions", "organizations_url": "https://api.github.com/users/dhoore123/orgs", "repos_url": "https://api.github.com/users/dhoore123/repos", "events_url": "https://api.github.com/users/dhoore123/events{/privacy}", "received_events_url": "https://api.github.com/users/dhoore123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[ "I have the same problem.", "Can you also set `max_steps` to something else than `-1`? E.g. `100000`. Let us know if this helps.", "Setting max_steps as suggested seems to do the trick. Training now runs. Thanks!\r\nI'll close the ticket once I see some epochs completing successfully.", "I finally got a training running for a few (pseudo-)epochs now. Even though I am running on 2 80GB GPUs, I had to tune down the batch_duration to 750, with batch_size removed from the configuration. The GPU ran out of RAM with higher values. I did not expect this as the example in the nvidia docs suggests using a batch_duration of 1100 for a 32GB GPU. ", "> I had to tune down the batch_duration to 750, with batch_size removed from the configuration.\r\n\r\nIt seems that your actual batch sizes became larger after removing batch_size constraint, leading to this outcome. This is a net benefit - despite decreasing batch_duration, you are still enjoying larger batch sizes.\r\n\r\n> I did not expect this as the example in the nvidia docs suggests using a batch_duration of 1100 for a 32GB GPU.\r\n\r\nThe maximum possible batch_duration setting is determined by several factors:\r\n* available GPU RAM\r\n* model size\r\n* objective function\r\n* data duration distribution / max_duration / number of buckets / optional quadratic_duration penalty\r\n\r\nThe setting of 1100s was specific to FastConformer-L CTC+RNN-T trained on ASRSet 3. It is expected that with a different model, data, objective function, etc. you may need to tune it again. I am hoping to simplify the tuning process in the future.", "Thanks for your reply, pzelasko. It reassures me that this batch_duration value does not seem odd to you, and does not point to something I did wrong. \r\nOn a different note: the effective batch size is normally defined by batch_size x accumulate_grad_batches (or fused_batch_size in case of hybrid training?) x nr_of_gpus. This causes the number of steps per epoch to be a function of the number of GPUs.\r\nWhen using lhotse, the number of steps in a \"pseudo\" epoch looks to be the same, independent of the number of GPUs. Does this mean that the amount of data seen in one \"pseudo\" epoch depends on the number of GPUs one uses, or is lhotse spreading the same amount of data over fewer effective batches when running on more GPUs with each step?", "It means that if you keep the “pseudoepoch” size constant, the amount of data seen during a “pseudoepoch” is proportional to the number of GPUs. Generally I don’t encourage thinking in epochs in this flavor of data loading, the only thing that counts is the number of updates. And yeah the total batch duration is the product of num GPUs, batch duration, and grad accumulation factor. ", "I figured out why I had to set batch_duration to a much lower value than expected. The parameter \"use_bucketing\" was not defined and defaults to false. After setting it to true, it looks like I am getting the behavior I was aiming for. Note that this parameter is not mentioned in the documentation page about lhotse. I found it by inspecting the code itself.\r\nIn any case, thanks for the tips and suggestions, Piotr. Nemo and the tools it builds from can be complex at times, but it is amazing in what it can do.", "Closing as the reported problem is solved. Parameter max_steps should be set to some big value.\r\nAs a side remark: use_bucketing parameter should be set to true (if you want to do dynamic bucketing with lhotse).", "Thanks for your feedback. I’ll try to improve the documentation to be clearer about this. The option is there if you keep scrolling down, but its indeed missing in the code snippet." ]
2024-06-13T08:27:15
2024-07-02T17:33:42
2024-07-02T13:39:51
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
I am trying to use lhotse when training a hybrid fast conformer model. The error is: File "/usr/local/lib/python3.10/dist-packages/nemo/core/optim/lr_scheduler.py", line 870, in prepare_lr_scheduler num_samples = len(train_dataloader.dataset) TypeError: object of type 'LhotseSpeechToTextBpeDataset' has no len() The motivation is that I want to make use of the dynamic batching and capability to equally weigh several languages for the training of my multilingual hybrid fast conformer model, which the lhotse integration is advertised to provide. I am using a singularity container, built from the nemo-24.01 docker container of nvidia. I also tried nemo-24.05 with the same result. This all runs in a slurm environment using multiple GPUs on a single node, on an on-premises grid. I zipped and attached my yaml configuration file. When not using lhotse, the config works. "not using lhotse" means setting use_lhotse to false and commenting out the following three lhotse related lines in the trainer use_distributed_sampler: false limit_train_batches: 20000 val_check_interval: 20000 The error suggests that there could be something missing in the code somewhere (method len not implemented for class LhotseSpeechToTextBpeDataset?), which would suggest some incomplete integration of lhotse for my use case. If you would find something missing or incorrect in my config, I would be happy to learn. I am not in a position to share the data itself nor parts of it though, hoping the error message rings a bell what could be wrong here. ======================= [FastConformer-Hybrid-Transducer-CTC-BPE-Streaming-multi-60-lhotse.zip](https://github.com/user-attachments/files/15816746/FastConformer-Hybrid-Transducer-CTC-BPE-Streaming-multi-60-lhotse.zip)
{ "login": "dhoore123", "id": 172583247, "node_id": "U_kgDOCklpTw", "avatar_url": "https://avatars.githubusercontent.com/u/172583247?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dhoore123", "html_url": "https://github.com/dhoore123", "followers_url": "https://api.github.com/users/dhoore123/followers", "following_url": "https://api.github.com/users/dhoore123/following{/other_user}", "gists_url": "https://api.github.com/users/dhoore123/gists{/gist_id}", "starred_url": "https://api.github.com/users/dhoore123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dhoore123/subscriptions", "organizations_url": "https://api.github.com/users/dhoore123/orgs", "repos_url": "https://api.github.com/users/dhoore123/repos", "events_url": "https://api.github.com/users/dhoore123/events{/privacy}", "received_events_url": "https://api.github.com/users/dhoore123/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9462/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9462/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9461
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9461/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9461/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9461/events
https://github.com/NVIDIA/NeMo/pull/9461
2,350,182,529
PR_kwDOC_bI7s5yUAU5
9,461
[NeMo-UX] Add nsys callback
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-13T05:24:10
2024-06-13T08:38:01
2024-06-13T08:38:00
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9461", "html_url": "https://github.com/NVIDIA/NeMo/pull/9461", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9461.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9461.patch", "merged_at": "2024-06-13T08:38:00" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9461/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9461/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9460
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9460/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9460/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9460/events
https://github.com/NVIDIA/NeMo/pull/9460
2,350,179,521
PR_kwDOC_bI7s5yT_p6
9,460
[NeMo-UX] Integrate experiment manager features with NeMo-UX APIs
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-13T05:21:59
2024-06-14T21:10:45
2024-06-14T21:10:44
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9460", "html_url": "https://github.com/NVIDIA/NeMo/pull/9460", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9460.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9460.patch", "merged_at": "2024-06-14T21:10:44" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9460/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9460/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9459
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9459/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9459/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9459/events
https://github.com/NVIDIA/NeMo/pull/9459
2,350,175,209
PR_kwDOC_bI7s5yT-tY
9,459
Mistral + Mixtral Support for NeVa
{ "login": "paul-gibbons", "id": 87940629, "node_id": "MDQ6VXNlcjg3OTQwNjI5", "avatar_url": "https://avatars.githubusercontent.com/u/87940629?v=4", "gravatar_id": "", "url": "https://api.github.com/users/paul-gibbons", "html_url": "https://github.com/paul-gibbons", "followers_url": "https://api.github.com/users/paul-gibbons/followers", "following_url": "https://api.github.com/users/paul-gibbons/following{/other_user}", "gists_url": "https://api.github.com/users/paul-gibbons/gists{/gist_id}", "starred_url": "https://api.github.com/users/paul-gibbons/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/paul-gibbons/subscriptions", "organizations_url": "https://api.github.com/users/paul-gibbons/orgs", "repos_url": "https://api.github.com/users/paul-gibbons/repos", "events_url": "https://api.github.com/users/paul-gibbons/events{/privacy}", "received_events_url": "https://api.github.com/users/paul-gibbons/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-13T05:19:00
2024-07-08T16:37:46
2024-07-08T16:37:46
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9459", "html_url": "https://github.com/NVIDIA/NeMo/pull/9459", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9459.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9459.patch", "merged_at": "2024-07-08T16:37:46" }
# What does this PR do ? Adds support for Mistral7B-Instruct and Mixtral8x7B-Instruct models in NeVa. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9459/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9459/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9458
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9458/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9458/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9458/events
https://github.com/NVIDIA/NeMo/pull/9458
2,349,793,564
PR_kwDOC_bI7s5yStMF
9,458
Bugfix missing variables and argument changes to MegatronPretrainingRandomSampler
{ "login": "jstjohn", "id": 459014, "node_id": "MDQ6VXNlcjQ1OTAxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/459014?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jstjohn", "html_url": "https://github.com/jstjohn", "followers_url": "https://api.github.com/users/jstjohn/followers", "following_url": "https://api.github.com/users/jstjohn/following{/other_user}", "gists_url": "https://api.github.com/users/jstjohn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jstjohn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jstjohn/subscriptions", "organizations_url": "https://api.github.com/users/jstjohn/orgs", "repos_url": "https://api.github.com/users/jstjohn/repos", "events_url": "https://api.github.com/users/jstjohn/events{/privacy}", "received_events_url": "https://api.github.com/users/jstjohn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "jstjohn", "id": 459014, "node_id": "MDQ6VXNlcjQ1OTAxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/459014?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jstjohn", "html_url": "https://github.com/jstjohn", "followers_url": "https://api.github.com/users/jstjohn/followers", "following_url": "https://api.github.com/users/jstjohn/following{/other_user}", "gists_url": "https://api.github.com/users/jstjohn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jstjohn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jstjohn/subscriptions", "organizations_url": "https://api.github.com/users/jstjohn/orgs", "repos_url": "https://api.github.com/users/jstjohn/repos", "events_url": "https://api.github.com/users/jstjohn/events{/privacy}", "received_events_url": "https://api.github.com/users/jstjohn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "jstjohn", "id": 459014, "node_id": "MDQ6VXNlcjQ1OTAxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/459014?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jstjohn", "html_url": "https://github.com/jstjohn", "followers_url": "https://api.github.com/users/jstjohn/followers", "following_url": "https://api.github.com/users/jstjohn/following{/other_user}", "gists_url": "https://api.github.com/users/jstjohn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jstjohn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jstjohn/subscriptions", "organizations_url": "https://api.github.com/users/jstjohn/orgs", "repos_url": "https://api.github.com/users/jstjohn/repos", "events_url": "https://api.github.com/users/jstjohn/events{/privacy}", "received_events_url": "https://api.github.com/users/jstjohn/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-06-12T22:43:18
2024-06-13T14:14:25
2024-06-13T14:14:24
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9458", "html_url": "https://github.com/NVIDIA/NeMo/pull/9458", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9458.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9458.patch", "merged_at": "2024-06-13T14:14:24" }
# What does this PR do ? Argument changes and non-existent variables are referenced inside of the `MegatronPretrainingRandomSampler` are addressed. **Collection**: lightning # Changelog - Remove the `dataset` input that was erroneously being passed to `MegatronPretrainingRandomSampler` init. - Since `self.data_parallel_size` doesn't actually exist inside of `MegatronPretrainingRandomSampler`, infer it from other variables that do exist. # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
{ "login": "jstjohn", "id": 459014, "node_id": "MDQ6VXNlcjQ1OTAxNA==", "avatar_url": "https://avatars.githubusercontent.com/u/459014?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jstjohn", "html_url": "https://github.com/jstjohn", "followers_url": "https://api.github.com/users/jstjohn/followers", "following_url": "https://api.github.com/users/jstjohn/following{/other_user}", "gists_url": "https://api.github.com/users/jstjohn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jstjohn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jstjohn/subscriptions", "organizations_url": "https://api.github.com/users/jstjohn/orgs", "repos_url": "https://api.github.com/users/jstjohn/repos", "events_url": "https://api.github.com/users/jstjohn/events{/privacy}", "received_events_url": "https://api.github.com/users/jstjohn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9458/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9458/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9457
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9457/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9457/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9457/events
https://github.com/NVIDIA/NeMo/pull/9457
2,349,769,955
PR_kwDOC_bI7s5ySoEc
9,457
Update readme with mlperf news
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2024-06-12T22:18:27
2024-06-12T23:01:34
2024-06-12T23:01:33
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9457", "html_url": "https://github.com/NVIDIA/NeMo/pull/9457", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9457.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9457.patch", "merged_at": "2024-06-12T23:01:33" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9457/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9457/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9456
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9456/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9456/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9456/events
https://github.com/NVIDIA/NeMo/pull/9456
2,349,475,583
PR_kwDOC_bI7s5yRn6A
9,456
[DO NOT MERGE] Prototype to show LLM with ModelPT as Base Class
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days." ]
2024-06-12T18:50:23
2024-06-28T22:01:25
2024-06-28T22:01:25
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9456", "html_url": "https://github.com/NVIDIA/NeMo/pull/9456", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9456.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9456.patch", "merged_at": null }
# What does this PR do ? Prototype code to try using ModelPT as base class for LLM. Enables path to backward compatibility with NeMo 1.x mcore models. **Collection**: [LLM] # Changelog - [NOTE] For simplicity, the LLMSaveRestoreConnector is duplicated. It will me moved out of final version # Usage There are two scripts in `examples/temp/` which show how to load a new model and train it on dummy data and use modelpt functions in it, and other is to restore that model fully with modelpt API. A third script is available which loads a NeMo 1.x mcore llm model and uses the 2.x class to instantiate it and do inference on it. # Dependency - Mcore requires update to its data class to make it yaml serializable with OmegaConf # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9456/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9456/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9455
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9455/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9455/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9455/events
https://github.com/NVIDIA/NeMo/pull/9455
2,349,414,727
PR_kwDOC_bI7s5yRalh
9,455
Add offline quantization script for QLoRA deployment
{ "login": "cuichenx", "id": 43478052, "node_id": "MDQ6VXNlcjQzNDc4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cuichenx", "html_url": "https://github.com/cuichenx", "followers_url": "https://api.github.com/users/cuichenx/followers", "following_url": "https://api.github.com/users/cuichenx/following{/other_user}", "gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}", "starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions", "organizations_url": "https://api.github.com/users/cuichenx/orgs", "repos_url": "https://api.github.com/users/cuichenx/repos", "events_url": "https://api.github.com/users/cuichenx/events{/privacy}", "received_events_url": "https://api.github.com/users/cuichenx/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days." ]
2024-06-12T18:11:48
2024-07-02T14:51:56
2024-07-02T14:51:55
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9455", "html_url": "https://github.com/NVIDIA/NeMo/pull/9455", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9455.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9455.patch", "merged_at": "2024-07-02T14:51:55" }
# What does this PR do ? Add an offline quantization script to convert a base model to NF4 (but cast back to BF16 for storage) Enables deployment of QLoRA checkpoint without downstream modifications **Collection**: [Note which collection this PR will affect] # Changelog - Add offline quantization script - Tiny refactor to pull out a `nf4_quantize` method. # Usage See instructions in script. ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [x] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "arendu", "id": 108822655, "node_id": "U_kgDOBnyAfw", "avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arendu", "html_url": "https://github.com/arendu", "followers_url": "https://api.github.com/users/arendu/followers", "following_url": "https://api.github.com/users/arendu/following{/other_user}", "gists_url": "https://api.github.com/users/arendu/gists{/gist_id}", "starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arendu/subscriptions", "organizations_url": "https://api.github.com/users/arendu/orgs", "repos_url": "https://api.github.com/users/arendu/repos", "events_url": "https://api.github.com/users/arendu/events{/privacy}", "received_events_url": "https://api.github.com/users/arendu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9455/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9455/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9454
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9454/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9454/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9454/events
https://github.com/NVIDIA/NeMo/pull/9454
2,349,181,183
PR_kwDOC_bI7s5yQmOX
9,454
[NeMo UX] Introducing optimizer module
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-12T16:23:00
2024-06-13T14:22:35
2024-06-13T14:22:35
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9454", "html_url": "https://github.com/NVIDIA/NeMo/pull/9454", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9454.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9454.patch", "merged_at": "2024-06-13T14:22:35" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9454/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9454/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9453
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9453/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9453/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9453/events
https://github.com/NVIDIA/NeMo/pull/9453
2,348,629,218
PR_kwDOC_bI7s5yOsxg
9,453
ci: Automate release of NeMo Toolkit
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days." ]
2024-06-12T12:18:17
2024-07-11T09:05:11
2024-07-11T09:05:10
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9453", "html_url": "https://github.com/NVIDIA/NeMo/pull/9453", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9453.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9453.patch", "merged_at": null }
# What does this PR do ? Automates releases of NeMo Toolkit. The automation starts with a manual workflow that can be dispatched via GitHubs Workflow UI. After selecting the type of version bump (`MAJOR`, `MINOR`, `PATCH`, `PRE_RELEASE`) it creates a release pull request. That PR contains two comments that are to be filled in by the release author (`SUMMARY`, `DETAILED CHANGELOG`). After merging this PR, a GitHub release (and tag) is created, a wheel is built and tested and on success published to Pypi. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9453/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9453/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9452
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9452/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9452/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9452/events
https://github.com/NVIDIA/NeMo/pull/9452
2,348,623,970
PR_kwDOC_bI7s5yOroj
9,452
Use ModelOpt build_tensorrt_llm for building engines for qnemo checkpoints
{ "login": "janekl", "id": 5582967, "node_id": "MDQ6VXNlcjU1ODI5Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4", "gravatar_id": "", "url": "https://api.github.com/users/janekl", "html_url": "https://github.com/janekl", "followers_url": "https://api.github.com/users/janekl/followers", "following_url": "https://api.github.com/users/janekl/following{/other_user}", "gists_url": "https://api.github.com/users/janekl/gists{/gist_id}", "starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/janekl/subscriptions", "organizations_url": "https://api.github.com/users/janekl/orgs", "repos_url": "https://api.github.com/users/janekl/repos", "events_url": "https://api.github.com/users/janekl/events{/privacy}", "received_events_url": "https://api.github.com/users/janekl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-12T12:15:46
2024-06-12T15:37:45
2024-06-12T15:37:44
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9452", "html_url": "https://github.com/NVIDIA/NeMo/pull/9452", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9452.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9452.patch", "merged_at": "2024-06-12T15:37:44" }
# What does this PR do ? Use ModelOpt's `build_tensorrt_llm` utility for accuracy and performance alignment for engines build. This introduces modelopt as an extra dependency in `nemo.export` module and it is a temporal solution. In long term engines for qnemo should be built directly using tensorrt_llm. **Collection**: NLP # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "oyilmaz-nvidia", "id": 35306097, "node_id": "MDQ6VXNlcjM1MzA2MDk3", "avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oyilmaz-nvidia", "html_url": "https://github.com/oyilmaz-nvidia", "followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers", "following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}", "gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions", "organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs", "repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos", "events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9452/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9452/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9451
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9451/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9451/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9451/events
https://github.com/NVIDIA/NeMo/pull/9451
2,348,575,772
PR_kwDOC_bI7s5yOhEj
9,451
Use FP8 in GPT TP2 test
{ "login": "jbaczek", "id": 45043825, "node_id": "MDQ6VXNlcjQ1MDQzODI1", "avatar_url": "https://avatars.githubusercontent.com/u/45043825?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jbaczek", "html_url": "https://github.com/jbaczek", "followers_url": "https://api.github.com/users/jbaczek/followers", "following_url": "https://api.github.com/users/jbaczek/following{/other_user}", "gists_url": "https://api.github.com/users/jbaczek/gists{/gist_id}", "starred_url": "https://api.github.com/users/jbaczek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jbaczek/subscriptions", "organizations_url": "https://api.github.com/users/jbaczek/orgs", "repos_url": "https://api.github.com/users/jbaczek/repos", "events_url": "https://api.github.com/users/jbaczek/events{/privacy}", "received_events_url": "https://api.github.com/users/jbaczek/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days." ]
2024-06-12T11:52:05
2024-07-09T21:26:06
2024-07-09T21:26:04
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9451", "html_url": "https://github.com/NVIDIA/NeMo/pull/9451", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9451.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9451.patch", "merged_at": "2024-07-09T21:26:04" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "layalir", "id": 31741533, "node_id": "MDQ6VXNlcjMxNzQxNTMz", "avatar_url": "https://avatars.githubusercontent.com/u/31741533?v=4", "gravatar_id": "", "url": "https://api.github.com/users/layalir", "html_url": "https://github.com/layalir", "followers_url": "https://api.github.com/users/layalir/followers", "following_url": "https://api.github.com/users/layalir/following{/other_user}", "gists_url": "https://api.github.com/users/layalir/gists{/gist_id}", "starred_url": "https://api.github.com/users/layalir/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/layalir/subscriptions", "organizations_url": "https://api.github.com/users/layalir/orgs", "repos_url": "https://api.github.com/users/layalir/repos", "events_url": "https://api.github.com/users/layalir/events{/privacy}", "received_events_url": "https://api.github.com/users/layalir/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9451/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9451/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9450
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9450/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9450/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9450/events
https://github.com/NVIDIA/NeMo/pull/9450
2,348,180,591
PR_kwDOC_bI7s5yNJhB
9,450
ci(notifications): Fix extraction of last 2K chars
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-12T08:43:54
2024-06-12T16:36:16
2024-06-12T16:36:15
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9450", "html_url": "https://github.com/NVIDIA/NeMo/pull/9450", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9450.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9450.patch", "merged_at": "2024-06-12T16:36:15" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "ko3n1g", "id": 16716991, "node_id": "MDQ6VXNlcjE2NzE2OTkx", "avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ko3n1g", "html_url": "https://github.com/ko3n1g", "followers_url": "https://api.github.com/users/ko3n1g/followers", "following_url": "https://api.github.com/users/ko3n1g/following{/other_user}", "gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}", "starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions", "organizations_url": "https://api.github.com/users/ko3n1g/orgs", "repos_url": "https://api.github.com/users/ko3n1g/repos", "events_url": "https://api.github.com/users/ko3n1g/events{/privacy}", "received_events_url": "https://api.github.com/users/ko3n1g/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9450/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9450/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9449
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9449/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9449/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9449/events
https://github.com/NVIDIA/NeMo/issues/9449
2,348,164,047
I_kwDOC_bI7s6L9iPP
9,449
Job specific environment variables can't be set in Hydra multi-run
{ "login": "domenVres", "id": 56541137, "node_id": "MDQ6VXNlcjU2NTQxMTM3", "avatar_url": "https://avatars.githubusercontent.com/u/56541137?v=4", "gravatar_id": "", "url": "https://api.github.com/users/domenVres", "html_url": "https://github.com/domenVres", "followers_url": "https://api.github.com/users/domenVres/followers", "following_url": "https://api.github.com/users/domenVres/following{/other_user}", "gists_url": "https://api.github.com/users/domenVres/gists{/gist_id}", "starred_url": "https://api.github.com/users/domenVres/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/domenVres/subscriptions", "organizations_url": "https://api.github.com/users/domenVres/orgs", "repos_url": "https://api.github.com/users/domenVres/repos", "events_url": "https://api.github.com/users/domenVres/events{/privacy}", "received_events_url": "https://api.github.com/users/domenVres/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "We don't use process launcher unless you use hydra sweep config. Can you try removing that ? If not, we'll have to see how to implement your request. Ofc, if you have a solution you're encouraged to send a pr ", "Is there a way to perform a hyperparameter search without the hydra sweep?", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-12T08:35:38
2024-08-10T01:51:37
2024-08-10T01:51:37
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Is your feature request related to a problem? Please describe.** Hydra offers a way to set the environment variables, that are specific for each job - section hydra.job.env_set [here](https://hydra.cc/docs/1.0/configure_hydra/job/#hydrajobenv_set). However, when I added this to the configuration for my multi-run hyperparameter search, the environment variable was not changed. I suspect that the reason for that is that NeMo has a custom [launcher](https://github.com/NVIDIA/NeMo/blob/main/nemo/core/utils/process_launcher/launcher.py), through which hydra executes the job. I did not find that these environment variables would be handled anywhere in there. **Describe the solution you'd like** I would like to be able to set job-specific environment variables in the same way that Hydra documentation describes it. This means I should be able to add field job.env_set in Hydra config for multi-runs (screenshot below). ![Screenshot 2024-06-12 at 10 20 03](https://github.com/NVIDIA/NeMo/assets/56541137/cde4b394-fc57-4dcf-b2b7-78f7791557b6) **Describe alternatives you've considered** The only alternative that I found so far and that works is to manually set the environment variables inside the training script (each job is a training script). However, inside these scripts, I don't have access to the job ID, and hence, I had to infer it from the values of hyperparameters. This is far from ideal, and it would be much nicer to have a config-level solution. **Additional context** The main reason that I went into trouble with the environment variables is a problem with ports when training multiple models at once. The process is initialized on the master port, and consequently, the following error happens: `torch.distributed.DistNetworkError: The server socket has failed to listen on any local network address. The server socket has failed to bind to [::]:53394 (errno: 98 - Address already in use). The server socket has failed to bind to 0.0.0.0:53394 (errno: 98 - Address already in use).` The solution to avoid this error is to set the environment variable MASTER_PORT to a different value for each job. Without this option, running multiple training processes in parallel is impossible due to port collisions.
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9449/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9449/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9448
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9448/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9448/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9448/events
https://github.com/NVIDIA/NeMo/issues/9448
2,348,048,404
I_kwDOC_bI7s6L9GAU
9,448
NLP isn't getting imported due to ApexGuardDefaults
{ "login": "adi7820", "id": 25850136, "node_id": "MDQ6VXNlcjI1ODUwMTM2", "avatar_url": "https://avatars.githubusercontent.com/u/25850136?v=4", "gravatar_id": "", "url": "https://api.github.com/users/adi7820", "html_url": "https://github.com/adi7820", "followers_url": "https://api.github.com/users/adi7820/followers", "following_url": "https://api.github.com/users/adi7820/following{/other_user}", "gists_url": "https://api.github.com/users/adi7820/gists{/gist_id}", "starred_url": "https://api.github.com/users/adi7820/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/adi7820/subscriptions", "organizations_url": "https://api.github.com/users/adi7820/orgs", "repos_url": "https://api.github.com/users/adi7820/repos", "events_url": "https://api.github.com/users/adi7820/events{/privacy}", "received_events_url": "https://api.github.com/users/adi7820/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]
closed
false
{ "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "ashors1", "id": 71393111, "node_id": "MDQ6VXNlcjcxMzkzMTEx", "avatar_url": "https://avatars.githubusercontent.com/u/71393111?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashors1", "html_url": "https://github.com/ashors1", "followers_url": "https://api.github.com/users/ashors1/followers", "following_url": "https://api.github.com/users/ashors1/following{/other_user}", "gists_url": "https://api.github.com/users/ashors1/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashors1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashors1/subscriptions", "organizations_url": "https://api.github.com/users/ashors1/orgs", "repos_url": "https://api.github.com/users/ashors1/repos", "events_url": "https://api.github.com/users/ashors1/events{/privacy}", "received_events_url": "https://api.github.com/users/ashors1/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "Nlp domain requires a lot of external dependencies such as Apex, Transformer Engine and Megatron Core which are not easily pip installable. Please use the container instructions for them, or follow instructions on the readme to build those libraries for a local installation ", "Hi @adi7820, the issue you are seeing should be resolved by [this PR](https://github.com/NVIDIA/NeMo/commit/f2e32320035ed59b597b2d76e35fd30028674dc6). Are you able to verify that this is the case with your setup? ", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-12T07:38:34
2024-08-23T01:52:04
2024-08-23T01:52:04
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** I've installed Nemo using below commands in my aws sagemaker **!sudo yum update -y && yum install -y libsndfile1 ffmpeg !pip install Cython packaging BRANCH='main' !python -m pip install git+https://github.com/NVIDIA/NeMo.git@{BRANCH}#egg=nemo_toolkit[all]** but getting error while I was trying anything related to NLP **from nemo.collections import nlp** Error: ModuleNotFoundError Traceback (most recent call last) File ~/SageMaker/nemo_nlp/NeMo/nemo/collections/nlp/models/language_modeling/megatron/gpt_layer_modelopt_spec.py:16 15 try: ---> 16 from megatron.core.fusions.fused_bias_dropout import get_bias_dropout_add 17 from megatron.core.tensor_parallel.layers import ColumnParallelLinear, RowParallelLinear ModuleNotFoundError: No module named 'megatron' During handling of the above exception, another exception occurred: NameError Traceback (most recent call last) Cell In[8], line 1 ----> 1 import nemo.collections.nlp File ~/SageMaker/nemo_nlp/NeMo/nemo/collections/nlp/__init__.py:15 1 # Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved. 2 # 3 # Licensed under the Apache License, Version 2.0 (the "License"); (...) 12 # See the License for the specific language governing permissions and 13 # limitations under the License. ---> 15 from nemo.collections.nlp import data, losses, models, modules 16 from nemo.package_info import __version__ 18 # Set collection version equal to NeMo version. File ~/SageMaker/nemo_nlp/NeMo/nemo/collections/nlp/models/__init__.py:28 23 from nemo.collections.nlp.models.information_retrieval import BertDPRModel, BertJointIRModel 24 from nemo.collections.nlp.models.intent_slot_classification import ( 25 IntentSlotClassificationModel, 26 MultiLabelIntentSlotClassificationModel, 27 ) ---> 28 from nemo.collections.nlp.models.language_modeling import MegatronGPTPromptLearningModel 29 from nemo.collections.nlp.models.language_modeling.bert_lm_model import BERTLMModel 30 from nemo.collections.nlp.models.language_modeling.transformer_lm_model import TransformerLMModel File ~/SageMaker/nemo_nlp/NeMo/nemo/collections/nlp/models/language_modeling/__init__.py:16 1 # Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved. 2 # 3 # Licensed under the Apache License, Version 2.0 (the "License"); (...) 12 # See the License for the specific language governing permissions and 13 # limitations under the License. 15 from nemo.collections.nlp.models.language_modeling.bert_lm_model import BERTLMModel ---> 16 from nemo.collections.nlp.models.language_modeling.megatron_gpt_prompt_learning_model import ( 17 MegatronGPTPromptLearningModel, 18 ) 19 from nemo.collections.nlp.models.language_modeling.megatron_retrieval_model import MegatronRetrievalModel 20 from nemo.collections.nlp.models.language_modeling.megatron_retro_model import MegatronRetroModel File ~/SageMaker/nemo_nlp/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_prompt_learning_model.py:31 27 from nemo.collections.nlp.metrics.prompt_learning_metrics import AccuracyScore, BLEUScore, ROUGEScores 28 from nemo.collections.nlp.models.language_modeling.megatron_base_prompt_learning_model import ( 29 MegatronBasePromptLearningModel, 30 ) ---> 31 from nemo.collections.nlp.models.language_modeling.megatron_gpt_model import MegatronGPTModel 32 from nemo.collections.nlp.modules.common import VirtualPromptPlaceholderToken, VirtualPromptSource, VirtualPromptStyle 33 from nemo.collections.nlp.modules.common.megatron.utils import ( 34 ApexGuardDefaults, 35 average_losses_across_data_parallel_group, 36 get_iterator_k_split, 37 ) File ~/SageMaker/nemo_nlp/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py:44 40 from nemo.collections.nlp.models.language_modeling.megatron.falcon.falcon_spec import get_falcon_layer_spec 41 from nemo.collections.nlp.models.language_modeling.megatron.gpt_full_te_layer_autocast_spec import ( 42 get_gpt_full_te_layer_autocast_spec, 43 ) ---> 44 from nemo.collections.nlp.models.language_modeling.megatron.gpt_layer_modelopt_spec import get_gpt_layer_modelopt_spec 45 from nemo.collections.nlp.models.language_modeling.megatron.gpt_model import GPTModel 46 from nemo.collections.nlp.models.language_modeling.megatron_base_model import MegatronBaseModel File ~/SageMaker/nemo_nlp/NeMo/nemo/collections/nlp/models/language_modeling/megatron/gpt_layer_modelopt_spec.py:31 27 HAVE_MEGATRON_CORE = True 29 except (ImportError, ModuleNotFoundError) as e: ---> 31 TransformerLayer = TransformerLayerSubmodules = ApexGuardDefaults 32 MLP = MLPSubmodules = ModuleSpec = IdentityOp = ApexGuardDefaults 33 AttnMaskType = DotProductAttention = TENorm = ApexGuardDefaults NameError: name 'ApexGuardDefaults' is not defined
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9448/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9448/timeline
null
not_planned
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9447
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9447/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9447/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9447/events
https://github.com/NVIDIA/NeMo/issues/9447
2,347,869,433
I_kwDOC_bI7s6L8aT5
9,447
Latest release version 1.23.0 missing the AudioCodecModel checkpoint list.
{ "login": "shreeshailgan", "id": 160709115, "node_id": "U_kgDOCZQ5-w", "avatar_url": "https://avatars.githubusercontent.com/u/160709115?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shreeshailgan", "html_url": "https://github.com/shreeshailgan", "followers_url": "https://api.github.com/users/shreeshailgan/followers", "following_url": "https://api.github.com/users/shreeshailgan/following{/other_user}", "gists_url": "https://api.github.com/users/shreeshailgan/gists{/gist_id}", "starred_url": "https://api.github.com/users/shreeshailgan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shreeshailgan/subscriptions", "organizations_url": "https://api.github.com/users/shreeshailgan/orgs", "repos_url": "https://api.github.com/users/shreeshailgan/repos", "events_url": "https://api.github.com/users/shreeshailgan/events{/privacy}", "received_events_url": "https://api.github.com/users/shreeshailgan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
closed
false
null
[]
null
[ "Audio codec is in NeMo 2.0.0rc0. You can get it by using pip install nemo_toolkit[asr,tts] --pre" ]
2024-06-12T05:53:18
2024-06-12T13:38:00
2024-06-12T13:38:00
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Describe the bug** Latest release version `1.23.0` is missing the `AudioCodecModel` checkpoint list. **Steps/Code to reproduce bug** As instructed [here](https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/audio_codec_16khz_small), run the following code ``` from nemo.collections.tts.models import AudioCodecModel nemo_codec_model = AudioCodecModel.from_pretrained('audio_codec_16khz_small') ``` **Expected behavior** I expect to load the 16kHz checkpoint of `AudioCodecModel`. However, on running the above code, I get the following error ``` FileNotFoundError: Model audio_codec_16khz_small was not found. Check cls.list_available_models() for the list of all available models. ``` On checking the function in the latest release version `==1.23.0`, https://github.com/NVIDIA/NeMo/blob/e772dbf53145a7b45f13440cf6e0ef51035f80dc/nemo/collections/tts/models/audio_codec.py#L646 we see that the function returns an empty list. \ This problem is resolved on the latest commit on the `main` branch https://github.com/NVIDIA/NeMo/blob/3c29fefe9ac442e594f1c35c0f8ecc09b5ef5015/nemo/collections/tts/models/audio_codec.py#L652 but installing `nemo_toolkit` using `pip` as instructed installs the latest release version. **Environment overview** - Environment location: Linux Cloud Server - Method of NeMo install: `pip install nemo_toolkit['all']` **Environment details** - OS version: Ubuntu 22.04.3 LTS - PyTorch version: 2.3.0 - Python version: 3.10.12
{ "login": "shreeshailgan", "id": 160709115, "node_id": "U_kgDOCZQ5-w", "avatar_url": "https://avatars.githubusercontent.com/u/160709115?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shreeshailgan", "html_url": "https://github.com/shreeshailgan", "followers_url": "https://api.github.com/users/shreeshailgan/followers", "following_url": "https://api.github.com/users/shreeshailgan/following{/other_user}", "gists_url": "https://api.github.com/users/shreeshailgan/gists{/gist_id}", "starred_url": "https://api.github.com/users/shreeshailgan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shreeshailgan/subscriptions", "organizations_url": "https://api.github.com/users/shreeshailgan/orgs", "repos_url": "https://api.github.com/users/shreeshailgan/repos", "events_url": "https://api.github.com/users/shreeshailgan/events{/privacy}", "received_events_url": "https://api.github.com/users/shreeshailgan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9447/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9447/timeline
null
completed
false
https://api.github.com/repos/NVIDIA/NeMo/issues/9446
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9446/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9446/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9446/events
https://github.com/NVIDIA/NeMo/pull/9446
2,347,807,791
PR_kwDOC_bI7s5yL36c
9,446
Akoumparouli/nemo ux mixtral
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "akoumpa", "id": 153118171, "node_id": "U_kgDOCSBl2w", "avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akoumpa", "html_url": "https://github.com/akoumpa", "followers_url": "https://api.github.com/users/akoumpa/followers", "following_url": "https://api.github.com/users/akoumpa/following{/other_user}", "gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}", "starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions", "organizations_url": "https://api.github.com/users/akoumpa/orgs", "repos_url": "https://api.github.com/users/akoumpa/repos", "events_url": "https://api.github.com/users/akoumpa/events{/privacy}", "received_events_url": "https://api.github.com/users/akoumpa/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-06-12T04:56:13
2024-06-24T18:54:20
2024-06-24T18:54:19
MEMBER
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9446", "html_url": "https://github.com/NVIDIA/NeMo/pull/9446", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9446.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9446.patch", "merged_at": "2024-06-24T18:54:19" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "marcromeyn", "id": 3015785, "node_id": "MDQ6VXNlcjMwMTU3ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/marcromeyn", "html_url": "https://github.com/marcromeyn", "followers_url": "https://api.github.com/users/marcromeyn/followers", "following_url": "https://api.github.com/users/marcromeyn/following{/other_user}", "gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}", "starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions", "organizations_url": "https://api.github.com/users/marcromeyn/orgs", "repos_url": "https://api.github.com/users/marcromeyn/repos", "events_url": "https://api.github.com/users/marcromeyn/events{/privacy}", "received_events_url": "https://api.github.com/users/marcromeyn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9446/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9446/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9445
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9445/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9445/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9445/events
https://github.com/NVIDIA/NeMo/pull/9445
2,347,165,179
PR_kwDOC_bI7s5yJtt5
9,445
Multimodal projection layer adapter fix for PP>1
{ "login": "paul-gibbons", "id": 87940629, "node_id": "MDQ6VXNlcjg3OTQwNjI5", "avatar_url": "https://avatars.githubusercontent.com/u/87940629?v=4", "gravatar_id": "", "url": "https://api.github.com/users/paul-gibbons", "html_url": "https://github.com/paul-gibbons", "followers_url": "https://api.github.com/users/paul-gibbons/followers", "following_url": "https://api.github.com/users/paul-gibbons/following{/other_user}", "gists_url": "https://api.github.com/users/paul-gibbons/gists{/gist_id}", "starred_url": "https://api.github.com/users/paul-gibbons/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/paul-gibbons/subscriptions", "organizations_url": "https://api.github.com/users/paul-gibbons/orgs", "repos_url": "https://api.github.com/users/paul-gibbons/repos", "events_url": "https://api.github.com/users/paul-gibbons/events{/privacy}", "received_events_url": "https://api.github.com/users/paul-gibbons/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-11T19:47:53
2024-07-02T14:31:36
2024-07-02T14:31:36
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9445", "html_url": "https://github.com/NVIDIA/NeMo/pull/9445", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9445.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9445.patch", "merged_at": "2024-07-02T14:31:36" }
# What does this PR do ? When loading a non-strict dist checkpoint in NeMo it hangs at https://github.com/NVIDIA/NeMo/blob/d7bb40364c17bf322004539f851cc83df4c4c2b7/nemo/utils/callbacks/dist_ckpt_io.py#L272 at PP_rank=0. When loading multimodal projection layer, there will be ranks loading nothing which leads to the hang because we only load weights for rank0. Setting **validate_access_integrity** resolves this hang. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "yaoyu-33", "id": 54727607, "node_id": "MDQ6VXNlcjU0NzI3NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaoyu-33", "html_url": "https://github.com/yaoyu-33", "followers_url": "https://api.github.com/users/yaoyu-33/followers", "following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}", "gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions", "organizations_url": "https://api.github.com/users/yaoyu-33/orgs", "repos_url": "https://api.github.com/users/yaoyu-33/repos", "events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}", "received_events_url": "https://api.github.com/users/yaoyu-33/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9445/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9445/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9444
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9444/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9444/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9444/events
https://github.com/NVIDIA/NeMo/pull/9444
2,347,164,902
PR_kwDOC_bI7s5yJtqC
9,444
Fix failing RIR unit test with lhotse 1.24+
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2024-06-11T19:47:41
2024-06-12T02:49:06
2024-06-12T02:49:06
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9444", "html_url": "https://github.com/NVIDIA/NeMo/pull/9444", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9444.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9444.patch", "merged_at": "2024-06-12T02:49:05" }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "titu1994", "id": 3048602, "node_id": "MDQ6VXNlcjMwNDg2MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/titu1994", "html_url": "https://github.com/titu1994", "followers_url": "https://api.github.com/users/titu1994/followers", "following_url": "https://api.github.com/users/titu1994/following{/other_user}", "gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}", "starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/titu1994/subscriptions", "organizations_url": "https://api.github.com/users/titu1994/orgs", "repos_url": "https://api.github.com/users/titu1994/repos", "events_url": "https://api.github.com/users/titu1994/events{/privacy}", "received_events_url": "https://api.github.com/users/titu1994/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9444/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9444/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9443
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9443/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9443/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9443/events
https://github.com/NVIDIA/NeMo/pull/9443
2,347,020,675
PR_kwDOC_bI7s5yJOQ2
9,443
Add pip installer for export module
{ "login": "oyilmaz-nvidia", "id": 35306097, "node_id": "MDQ6VXNlcjM1MzA2MDk3", "avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oyilmaz-nvidia", "html_url": "https://github.com/oyilmaz-nvidia", "followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers", "following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}", "gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions", "organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs", "repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos", "events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "pablo-garay", "id": 7166088, "node_id": "MDQ6VXNlcjcxNjYwODg=", "avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pablo-garay", "html_url": "https://github.com/pablo-garay", "followers_url": "https://api.github.com/users/pablo-garay/followers", "following_url": "https://api.github.com/users/pablo-garay/following{/other_user}", "gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}", "starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions", "organizations_url": "https://api.github.com/users/pablo-garay/orgs", "repos_url": "https://api.github.com/users/pablo-garay/repos", "events_url": "https://api.github.com/users/pablo-garay/events{/privacy}", "received_events_url": "https://api.github.com/users/pablo-garay/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2024-06-11T18:17:26
2024-06-11T18:44:30
2024-06-11T18:44:30
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9443", "html_url": "https://github.com/NVIDIA/NeMo/pull/9443", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9443.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9443.patch", "merged_at": null }
# What does this PR do ? pip installer for the export module. This is a requirement of the NIM team.
{ "login": "oyilmaz-nvidia", "id": 35306097, "node_id": "MDQ6VXNlcjM1MzA2MDk3", "avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oyilmaz-nvidia", "html_url": "https://github.com/oyilmaz-nvidia", "followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers", "following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}", "gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}", "starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions", "organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs", "repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos", "events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}", "received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9443/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9443/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9442
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9442/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9442/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9442/events
https://github.com/NVIDIA/NeMo/pull/9442
2,347,002,441
PR_kwDOC_bI7s5yJKPB
9,442
Remove configs not relevant to Fast Conformer-CTC
{ "login": "MedAymenF", "id": 33981698, "node_id": "MDQ6VXNlcjMzOTgxNjk4", "avatar_url": "https://avatars.githubusercontent.com/u/33981698?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MedAymenF", "html_url": "https://github.com/MedAymenF", "followers_url": "https://api.github.com/users/MedAymenF/followers", "following_url": "https://api.github.com/users/MedAymenF/following{/other_user}", "gists_url": "https://api.github.com/users/MedAymenF/gists{/gist_id}", "starred_url": "https://api.github.com/users/MedAymenF/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MedAymenF/subscriptions", "organizations_url": "https://api.github.com/users/MedAymenF/orgs", "repos_url": "https://api.github.com/users/MedAymenF/repos", "events_url": "https://api.github.com/users/MedAymenF/events{/privacy}", "received_events_url": "https://api.github.com/users/MedAymenF/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-11T18:06:37
2024-08-17T01:49:29
2024-08-17T01:49:28
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9442", "html_url": "https://github.com/NVIDIA/NeMo/pull/9442", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9442.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9442.patch", "merged_at": null }
# What does this PR do ? Removed "pred_hidden", "joint_hidden", and "pred_rnn_layers" because they are Fast Conformer-Transducer configs. **Collection**: [ASR] # Before your PR is "Ready for review" **Pre checks**: - [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [X] Documentation
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9442/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9442/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9441
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9441/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9441/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9441/events
https://github.com/NVIDIA/NeMo/pull/9441
2,346,995,968
PR_kwDOC_bI7s5yJI1o
9,441
Tiledsiglip
{ "login": "HuiyingLi", "id": 1331543, "node_id": "MDQ6VXNlcjEzMzE1NDM=", "avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4", "gravatar_id": "", "url": "https://api.github.com/users/HuiyingLi", "html_url": "https://github.com/HuiyingLi", "followers_url": "https://api.github.com/users/HuiyingLi/followers", "following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}", "gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}", "starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions", "organizations_url": "https://api.github.com/users/HuiyingLi/orgs", "repos_url": "https://api.github.com/users/HuiyingLi/repos", "events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}", "received_events_url": "https://api.github.com/users/HuiyingLi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null } ]
closed
false
null
[]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]
2024-06-11T18:02:45
2024-08-17T01:49:31
2024-08-17T01:49:30
COLLABORATOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
true
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9441", "html_url": "https://github.com/NVIDIA/NeMo/pull/9441", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9441.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9441.patch", "merged_at": null }
# What does this PR do ? Add a one line overview of what this PR aims to accomplish. **Collection**: [Note which collection this PR will affect] # Changelog - Add specific line by line info of high level changes in this PR. # Usage * You can potentially add a usage example below ```python # Add a code snippet demonstrating how to use this ``` # GitHub Actions CI The Jenkins CI system has been replaced by GitHub Actions self-hosted runners. The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR. To re-run CI remove and add the label again. To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run". # Before your PR is "Ready for review" **Pre checks**: - [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [ ] Bugfix - [ ] Documentation If you haven't finished some of the above items you can still open "Draft" PR. ## Who can review? Anyone in the community is free to review the PR once the checks have passed. [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. # Additional Information * Related to # (issue)
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9441/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9441/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9440
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9440/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9440/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9440/events
https://github.com/NVIDIA/NeMo/pull/9440
2,346,947,937
PR_kwDOC_bI7s5yI-U5
9,440
Fix py3.11 dataclasses issue
{ "login": "MedAymenF", "id": 33981698, "node_id": "MDQ6VXNlcjMzOTgxNjk4", "avatar_url": "https://avatars.githubusercontent.com/u/33981698?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MedAymenF", "html_url": "https://github.com/MedAymenF", "followers_url": "https://api.github.com/users/MedAymenF/followers", "following_url": "https://api.github.com/users/MedAymenF/following{/other_user}", "gists_url": "https://api.github.com/users/MedAymenF/gists{/gist_id}", "starred_url": "https://api.github.com/users/MedAymenF/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MedAymenF/subscriptions", "organizations_url": "https://api.github.com/users/MedAymenF/orgs", "repos_url": "https://api.github.com/users/MedAymenF/repos", "events_url": "https://api.github.com/users/MedAymenF/events{/privacy}", "received_events_url": "https://api.github.com/users/MedAymenF/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]
closed
false
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "Could you fix the formatting checks?", "> Could you fix the formatting checks?\r\n\r\nFormatting checks are passing now (after I synced my fork).", "We're seeing some CI instability so the tests are taking longer than ususal. I merged main and re-triggered the failing tests (they don't seem related to your changes). Will keep monitoring this PR until it's all green." ]
2024-06-11T17:34:32
2024-08-15T13:53:53
2024-08-15T13:20:26
CONTRIBUTOR
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
false
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9440", "html_url": "https://github.com/NVIDIA/NeMo/pull/9440", "diff_url": "https://github.com/NVIDIA/NeMo/pull/9440.diff", "patch_url": "https://github.com/NVIDIA/NeMo/pull/9440.patch", "merged_at": "2024-08-15T13:20:26" }
# What does this PR do ? Fixes #9419. **Collection**: [ASR] # Changelog - Fix dataclasses in examples/asr/transcribe_speech.py. - Fix dataclasses in examples/asr/speech_to_text_eval.py. # Before your PR is "Ready for review" **Pre checks**: - [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) - [ ] Did you write any new necessary tests? - [ ] Did you add or update any necessary documentation? - [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) - [ ] Reviewer: Does the PR have correct import guards for all optional libraries? **PR Type**: - [ ] New Feature - [x] Bugfix - [ ] Documentation # Additional Information * Related to #7166.
{ "login": "pzelasko", "id": 15930688, "node_id": "MDQ6VXNlcjE1OTMwNjg4", "avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pzelasko", "html_url": "https://github.com/pzelasko", "followers_url": "https://api.github.com/users/pzelasko/followers", "following_url": "https://api.github.com/users/pzelasko/following{/other_user}", "gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}", "starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions", "organizations_url": "https://api.github.com/users/pzelasko/orgs", "repos_url": "https://api.github.com/users/pzelasko/repos", "events_url": "https://api.github.com/users/pzelasko/events{/privacy}", "received_events_url": "https://api.github.com/users/pzelasko/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9440/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9440/timeline
null
null
true
https://api.github.com/repos/NVIDIA/NeMo/issues/9439
https://api.github.com/repos/NVIDIA/NeMo
https://api.github.com/repos/NVIDIA/NeMo/issues/9439/labels{/name}
https://api.github.com/repos/NVIDIA/NeMo/issues/9439/comments
https://api.github.com/repos/NVIDIA/NeMo/issues/9439/events
https://github.com/NVIDIA/NeMo/issues/9439
2,346,905,991
I_kwDOC_bI7s6L4vGH
9,439
Can we run NeMo MSDD Neural Diarizer model in realtime for realtime diarization?
{ "login": "ThiruRJST", "id": 60371933, "node_id": "MDQ6VXNlcjYwMzcxOTMz", "avatar_url": "https://avatars.githubusercontent.com/u/60371933?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ThiruRJST", "html_url": "https://github.com/ThiruRJST", "followers_url": "https://api.github.com/users/ThiruRJST/followers", "following_url": "https://api.github.com/users/ThiruRJST/following{/other_user}", "gists_url": "https://api.github.com/users/ThiruRJST/gists{/gist_id}", "starred_url": "https://api.github.com/users/ThiruRJST/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ThiruRJST/subscriptions", "organizations_url": "https://api.github.com/users/ThiruRJST/orgs", "repos_url": "https://api.github.com/users/ThiruRJST/repos", "events_url": "https://api.github.com/users/ThiruRJST/events{/privacy}", "received_events_url": "https://api.github.com/users/ThiruRJST/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
{ "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "nithinraok", "id": 19668129, "node_id": "MDQ6VXNlcjE5NjY4MTI5", "avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nithinraok", "html_url": "https://github.com/nithinraok", "followers_url": "https://api.github.com/users/nithinraok/followers", "following_url": "https://api.github.com/users/nithinraok/following{/other_user}", "gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}", "starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions", "organizations_url": "https://api.github.com/users/nithinraok/orgs", "repos_url": "https://api.github.com/users/nithinraok/repos", "events_url": "https://api.github.com/users/nithinraok/events{/privacy}", "received_events_url": "https://api.github.com/users/nithinraok/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[ "check these two PRs: https://github.com/NVIDIA/NeMo/pull/5609, https://github.com/NVIDIA/NeMo/pull/7896\r\nAlthough I couldn't get them to work", "Thanks for your interest, no we currently don;t support online speaker diarization using MSDD. ", "@nithinraok thank you nithin for the confirmation" ]
2024-06-11T17:08:57
2024-07-31T18:17:58
2024-07-31T18:17:58
NONE
{ "total": 0, "completed": 0, "percent_completed": 0 }
null
null
null
**Disclaimer** I just want some inputs in developing a below mentioned pipeline, if it's feasible. **Requirements** I'm currently working on a project where I need the diarization to work in a real-time manner. I tried using the PyAnnote Library but None of those could match the accuracy of MSDD but We weren't able to run MSDD in a real-time manner. Is there any example for how to do this. We need to run MSDD along with Whisper model for transcription.
null
{ "url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9439/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/NVIDIA/NeMo/issues/9439/timeline
null
completed
false