url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/9438 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9438/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9438/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9438/events | https://github.com/NVIDIA/NeMo/pull/9438 | 2,346,872,899 | PR_kwDOC_bI7s5yIt04 | 9,438 | In-framework deployment | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "meatybobby",
"id": 9738259,
"node_id": "MDQ6VXNlcjk3MzgyNTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9738259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/meatybobby",
"html_url": "https://github.com/meatybobby",
"followers_url": "https://api.github.com/users/meatybobby/followers",
"following_url": "https://api.github.com/users/meatybobby/following{/other_user}",
"gists_url": "https://api.github.com/users/meatybobby/gists{/gist_id}",
"starred_url": "https://api.github.com/users/meatybobby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/meatybobby/subscriptions",
"organizations_url": "https://api.github.com/users/meatybobby/orgs",
"repos_url": "https://api.github.com/users/meatybobby/repos",
"events_url": "https://api.github.com/users/meatybobby/events{/privacy}",
"received_events_url": "https://api.github.com/users/meatybobby/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-06-11T16:48:30 | 2024-06-13T02:22:55 | 2024-06-13T02:22:55 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9438",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9438",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9438.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9438.patch",
"merged_at": "2024-06-13T02:22:55"
} | # What does this PR do ?
PR for in framework deployment. Took the commits from this PR: https://github.com/NVIDIA/NeMo/pull/8958 and made a few changes. | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9438/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9438/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9436 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9436/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9436/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9436/events | https://github.com/NVIDIA/NeMo/issues/9436 | 2,346,366,652 | I_kwDOC_bI7s6L2ra8 | 9,436 | CTC Language Finetuning convergence | {
"login": "Jeevi10",
"id": 36677847,
"node_id": "MDQ6VXNlcjM2Njc3ODQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/36677847?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Jeevi10",
"html_url": "https://github.com/Jeevi10",
"followers_url": "https://api.github.com/users/Jeevi10/followers",
"following_url": "https://api.github.com/users/Jeevi10/following{/other_user}",
"gists_url": "https://api.github.com/users/Jeevi10/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Jeevi10/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Jeevi10/subscriptions",
"organizations_url": "https://api.github.com/users/Jeevi10/orgs",
"repos_url": "https://api.github.com/users/Jeevi10/repos",
"events_url": "https://api.github.com/users/Jeevi10/events{/privacy}",
"received_events_url": "https://api.github.com/users/Jeevi10/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Its a very old model, I would recommend you to try with Fast Conformer. \r\n@titu1994 Few notebooks are based on quartznet architecture, we need to update them to use FastConformer! ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-11T12:56:18 | 2024-08-10T01:51:39 | 2024-08-10T01:51:38 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
CTC finetuning is not converging I tried to change hyperparameters, but still there is no luck. During training the model started to output empty strings.
**Expected behavior**
expected to converge for new language (I was simply following the tutorial given).
https://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/ASR_CTC_Language_Finetuning.ipynb
**Environment overview **
- Environment location: conda environment
- Method of NeMo install: python -m pip install git+https://github.com/NVIDIA/NeMo.git@main #egg=nemo_toolkit[all]
**Environment details**
Package Version
----------------------------- --------------
absl-py 2.1.0
accelerated-scan 0.2.0
addict 2.4.0
aiohttp 3.9.5
aiosignal 1.3.1
alabaster 0.7.16
alembic 1.13.1
aniso8601 9.0.1
antlr4-python3-runtime 4.9.3
anyio 4.4.0
argon2-cffi 23.1.0
argon2-cffi-bindings 21.2.0
arrow 1.3.0
asciitree 0.3.3
asteroid-filterbanks 0.4.0
asttokens 2.4.1
async-lru 2.0.4
async-timeout 4.0.3
attrdict 2.0.1
attrs 23.2.0
audioread 3.0.1
Babel 2.15.0
beautifulsoup4 4.12.3
black 24.4.2
bleach 6.1.0
boto3 1.34.113
botocore 1.34.113
braceexpand 0.1.7
causal-conv1d 1.2.2.post1
cdifflib 1.2.6
certifi 2024.2.2
cffi 1.16.0
charset-normalizer 3.3.2
click 8.0.2
clip 0.2.0
cloudpickle 3.0.0
colorama 0.4.6
colorlog 6.8.2
comm 0.2.2
contourpy 1.2.1
cycler 0.12.1
Cython 3.0.10
cytoolz 0.12.3
datasets 2.19.1
debugpy 1.8.1
decorator 5.1.1
decord 0.6.0
defusedxml 0.7.1
diart 0.9.0
diffusers 0.28.0
dill 0.3.8
Distance 0.1.3
docker-pycreds 0.4.0
docopt 0.6.2
docutils 0.21.2
dtw-python 1.4.2
editdistance 0.8.1
einops 0.8.0
einops-exts 0.0.4
exceptiongroup 1.2.0
executing 2.0.1
faiss-cpu 1.8.0
fasteners 0.19
fastjsonschema 2.19.1
fasttext 0.9.2
fiddle 0.3.0
filelock 3.14.0
Flask 2.2.5
Flask-RESTful 0.3.10
fonttools 4.51.0
fqdn 1.5.1
frozenlist 1.4.1
fsspec 2024.3.1
ftfy 6.2.0
future 1.0.0
g2p-en 2.1.0
gdown 5.2.0
gitdb 4.0.11
GitPython 3.1.43
graphviz 0.20.3
greenlet 3.0.3
grpcio 1.64.0
h11 0.14.0
h5py 3.11.0
httpcore 1.0.5
httpx 0.27.0
huggingface-hub 0.23.3
hydra-core 1.3.2
HyperPyYAML 1.2.2
idna 3.7
ijson 3.2.3
imageio 2.34.1
imagesize 1.4.1
importlib_metadata 7.1.0
inflect 7.2.1
iniconfig 2.0.0
inquirerpy 0.3.4
intervaltree 3.1.0
ipykernel 6.29.3
ipython 8.24.0
ipython-genutils 0.2.0
ipywidgets 8.1.3
isoduration 20.11.0
isort 5.13.2
itsdangerous 2.2.0
jedi 0.19.1
jieba 0.42.1
Jinja2 3.1.3
jiwer 2.5.2
jmespath 1.0.1
joblib 1.4.2
json5 0.9.25
jsonpointer 2.4
jsonschema 4.22.0
jsonschema-specifications 2023.12.1
julius 0.2.7
jupyter_client 8.6.2
jupyter_core 5.7.2
jupyter-events 0.10.0
jupyter-lsp 2.2.5
jupyter_server 2.14.0
jupyter_server_terminals 0.5.3
jupyterlab 4.2.1
jupyterlab_pygments 0.3.0
jupyterlab_server 2.27.2
jupyterlab_widgets 3.0.11
kaldi-python-io 1.2.2
kaldiio 2.18.0
kiwisolver 1.4.5
kornia 0.7.2
kornia_rs 0.1.3
latexcodec 3.0.0
lazy_loader 0.4
Levenshtein 0.22.0
lhotse 1.23.0
libcst 1.4.0
librosa 0.10.2
lightning 2.2.4
lightning-utilities 0.11.2
lilcom 1.7
llvmlite 0.42.0
loguru 0.7.2
lxml 5.2.2
Mako 1.3.3
Markdown 3.6
markdown-it-py 3.0.0
markdown2 2.4.13
MarkupSafe 2.1.5
marshmallow 3.21.2
matplotlib 3.8.4
matplotlib-inline 0.1.7
mdurl 0.1.2
mistune 3.0.2
more-itertools 10.2.0
mpmath 1.3.0
msgpack 1.0.8
multidict 6.0.5
multiprocess 0.70.16
mypy-extensions 1.0.0
nbclient 0.10.0
nbconvert 7.16.4
nbformat 5.10.4
nemo_text_processing 1.0.2
nemo_toolkit 2.0.0rc1
nerfacc 0.5.3
nest_asyncio 1.6.0
networkx 3.3
ninja 1.11.1.1
nltk 3.8.1
notebook 6.4.12
notebook_shim 0.2.4
numba 0.59.1
numcodecs 0.12.1
numpy 1.26.4
nvidia-cublas-cu12 12.1.3.1
nvidia-cuda-cupti-cu12 12.1.105
nvidia-cuda-nvrtc-cu12 12.1.105
nvidia-cuda-runtime-cu12 12.1.105
nvidia-cudnn-cu12 8.9.2.26
nvidia-cufft-cu12 11.0.2.54
nvidia-curand-cu12 10.3.2.106
nvidia-cusolver-cu12 11.4.5.107
nvidia-cusparse-cu12 12.1.0.106
nvidia-nccl-cu12 2.20.5
nvidia-nvjitlink-cu12 12.4.127
nvidia-nvtx-cu12 12.1.105
omegaconf 2.3.0
onnx 1.16.1
open-clip-torch 2.24.0
openai-whisper 20231117
OpenCC 1.1.6
optuna 3.6.1
overrides 7.7.0
packaging 24.0
pandas 2.2.2
pandocfilters 1.5.1
pangu 4.0.6.1
parameterized 0.9.0
parso 0.8.4
pathspec 0.12.1
pexpect 4.9.0
pfzy 0.3.4
pickleshare 0.7.5
pillow 10.3.0
pip 24.0
plac 1.4.3
platformdirs 4.2.1
pluggy 1.5.0
pooch 1.8.1
portalocker 2.8.2
primePy 1.3
progress 1.6
prometheus_client 0.20.0
prompt-toolkit 3.0.42
protobuf 4.25.3
psutil 5.9.8
ptyprocess 0.7.0
pure-eval 0.2.2
pyannote.audio 3.1.1
pyannote.core 5.0.0
pyannote.database 5.1.0
pyannote.metrics 3.2.1
pyannote.pipeline 3.0.1
pyarrow 16.1.0
pyarrow-hotfix 0.6
pybind11 2.12.0
pybtex 0.24.0
pybtex-docutils 1.0.3
pycparser 2.22
pydub 0.25.1
Pygments 2.17.2
pyloudnorm 0.1.1
PyMCubes 0.1.4
pynini 2.1.5
pyparsing 3.1.2
pypinyin 0.51.0
pypinyin-dict 0.8.0
PySocks 1.7.1
pytest 8.2.1
pytest-mock 3.14.0
pytest-runner 6.0.1
python-dateutil 2.9.0
python-json-logger 2.0.7
pytorch-lightning 2.2.4
pytorch-metric-learning 2.5.0
pytz 2024.1
PyYAML 6.0.1
pyzmq 26.0.3
rapidfuzz 2.13.7
referencing 0.35.1
regex 2024.4.28
requests 2.31.0
resampy 0.4.3
rfc3339-validator 0.1.4
rfc3986-validator 0.1.1
rich 13.7.1
rouge_score 0.1.2
rpds-py 0.18.1
ruamel.yaml 0.18.6
ruamel.yaml.clib 0.2.8
Rx 3.2.0
s3transfer 0.10.1
sacrebleu 2.4.2
sacremoses 0.1.1
safetensors 0.4.3
scikit-learn 1.4.2
scipy 1.13.0
semver 3.0.2
Send2Trash 1.8.3
sentence-transformers 3.0.0
sentencepiece 0.2.0
sentry-sdk 2.3.1
setproctitle 1.3.3
setuptools 69.5.1
shellingham 1.5.4
six 1.16.0
smmap 5.0.1
sniffio 1.3.1
snowballstemmer 2.2.0
sortedcontainers 2.4.0
sounddevice 0.4.6
soundfile 0.12.1
soupsieve 2.5
sox 1.5.0
soxr 0.3.7
speechbrain 1.0.0
Sphinx 7.3.7
sphinxcontrib-applehelp 1.0.8
sphinxcontrib-bibtex 2.6.2
sphinxcontrib-devhelp 1.0.6
sphinxcontrib-htmlhelp 2.0.5
sphinxcontrib-jsmath 1.0.1
sphinxcontrib-qthelp 1.0.7
sphinxcontrib-serializinghtml 1.1.10
SQLAlchemy 2.0.29
stack-data 0.6.2
sympy 1.12
tabulate 0.9.0
taming-transformers 0.0.1
tensorboard 2.16.2
tensorboard-data-server 0.7.2
tensorboardX 2.6.2.2
tensorstore 0.1.45
termcolor 2.4.0
terminado 0.18.1
text-unidecode 1.3
textdistance 4.6.2
texterrors 0.4.4
threadpoolctl 3.5.0
tiktoken 0.6.0
timm 1.0.3
tinycss2 1.3.0
tokenizers 0.19.1
tomli 2.0.1
toolz 0.12.1
torch 2.3.0
torch-audiomentations 0.11.1
torch-pitch-shift 1.2.4
torchaudio 2.3.0
torchdiffeq 0.2.3
torchmetrics 1.3.2
torchsde 0.2.6
torchvision 0.18.0
tornado 6.4
tqdm 4.66.2
traitlets 5.14.3
trampoline 0.1.2
transformers 4.40.2
trimesh 4.4.0
triton 2.3.0
typeguard 4.3.0
typer 0.12.3
types-python-dateutil 2.9.0.20240316
typing_extensions 4.11.0
tzdata 2024.1
uri-template 1.3.0
urllib3 2.2.1
wandb 0.17.0
wcwidth 0.2.13
webcolors 1.13
webdataset 0.2.86
webencodings 0.5.1
websocket-client 1.8.0
websocket-server 0.6.4
Werkzeug 3.0.3
wget 3.2
wheel 0.43.0
whisper-timestamped 1.15.4
widgetsnbextension 4.0.11
wrapt 1.16.0
xxhash 3.4.1
yarl 1.9.4
zarr 2.18.2
zipp 3.17.0
GPU: Tesla V100
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9436/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9436/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9435 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9435/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9435/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9435/events | https://github.com/NVIDIA/NeMo/pull/9435 | 2,346,072,942 | PR_kwDOC_bI7s5yF-BI | 9,435 | [NeMo-UX] Adding support for mcore distributed optimizer | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@marcromeyn can you fix the DCO? thanks."
] | 2024-06-11T10:37:55 | 2024-06-12T15:21:30 | 2024-06-12T15:21:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9435",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9435",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9435.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9435.patch",
"merged_at": "2024-06-12T15:21:29"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9435/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9435/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9434 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9434/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9434/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9434/events | https://github.com/NVIDIA/NeMo/issues/9434 | 2,345,658,333 | I_kwDOC_bI7s6Lz-fd | 9,434 | FastConformer-Longformer | {
"login": "GrigorKirakosyan",
"id": 98385298,
"node_id": "U_kgDOBd09kg",
"avatar_url": "https://avatars.githubusercontent.com/u/98385298?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/GrigorKirakosyan",
"html_url": "https://github.com/GrigorKirakosyan",
"followers_url": "https://api.github.com/users/GrigorKirakosyan/followers",
"following_url": "https://api.github.com/users/GrigorKirakosyan/following{/other_user}",
"gists_url": "https://api.github.com/users/GrigorKirakosyan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/GrigorKirakosyan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GrigorKirakosyan/subscriptions",
"organizations_url": "https://api.github.com/users/GrigorKirakosyan/orgs",
"repos_url": "https://api.github.com/users/GrigorKirakosyan/repos",
"events_url": "https://api.github.com/users/GrigorKirakosyan/events{/privacy}",
"received_events_url": "https://api.github.com/users/GrigorKirakosyan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"we released 1B model but not the large model here: https://huggingface.co/spaces/nvidia/parakeet-tdt_ctc-1.1b ",
"Thanks, I have seen this. I was interested to know about Large-FastConformer(~120M) model trained with this config:\r\nhttps://github.com/NVIDIA/NeMo/blob/main/examples/asr/conf/fastconformer/long_fastconformer/fast-conformer-long_ctc_bpe.yaml"
] | 2024-06-11T07:48:11 | 2024-07-31T18:19:27 | 2024-07-31T18:19:27 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi NeMo team,
Do you plan to release En Large FastConformer-Long-CTC-BPE model trained with Local Attention and Global token? | null | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9434/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9434/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9433 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9433/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9433/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9433/events | https://github.com/NVIDIA/NeMo/pull/9433 | 2,344,874,698 | PR_kwDOC_bI7s5yB4CK | 9,433 | Draft: Add LoRA test with sequence parallelism | {
"login": "michal2409",
"id": 14821051,
"node_id": "MDQ6VXNlcjE0ODIxMDUx",
"avatar_url": "https://avatars.githubusercontent.com/u/14821051?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michal2409",
"html_url": "https://github.com/michal2409",
"followers_url": "https://api.github.com/users/michal2409/followers",
"following_url": "https://api.github.com/users/michal2409/following{/other_user}",
"gists_url": "https://api.github.com/users/michal2409/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michal2409/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michal2409/subscriptions",
"organizations_url": "https://api.github.com/users/michal2409/orgs",
"repos_url": "https://api.github.com/users/michal2409/repos",
"events_url": "https://api.github.com/users/michal2409/events{/privacy}",
"received_events_url": "https://api.github.com/users/michal2409/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-06-10T21:39:24 | 2024-07-29T18:40:55 | 2024-07-29T18:40:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9433",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9433",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9433.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9433.patch",
"merged_at": "2024-07-29T18:40:53"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9433/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9433/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9432 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9432/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9432/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9432/events | https://github.com/NVIDIA/NeMo/pull/9432 | 2,344,841,613 | PR_kwDOC_bI7s5yBwtR | 9,432 | MCore T5 support for NeMo - Training | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-06-10T21:16:17 | 2024-07-08T13:06:34 | 2024-07-08T13:06:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9432",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9432",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9432.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9432.patch",
"merged_at": "2024-07-08T13:06:32"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9432/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9432/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9431 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9431/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9431/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9431/events | https://github.com/NVIDIA/NeMo/pull/9431 | 2,344,841,347 | PR_kwDOC_bI7s5yBwqy | 9,431 | Add python_requires | {
"login": "galv",
"id": 4767568,
"node_id": "MDQ6VXNlcjQ3Njc1Njg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4767568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/galv",
"html_url": "https://github.com/galv",
"followers_url": "https://api.github.com/users/galv/followers",
"following_url": "https://api.github.com/users/galv/following{/other_user}",
"gists_url": "https://api.github.com/users/galv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/galv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/galv/subscriptions",
"organizations_url": "https://api.github.com/users/galv/orgs",
"repos_url": "https://api.github.com/users/galv/repos",
"events_url": "https://api.github.com/users/galv/events{/privacy}",
"received_events_url": "https://api.github.com/users/galv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-06-10T21:16:08 | 2024-06-16T20:15:25 | 2024-06-16T20:15:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9431",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9431",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9431.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9431.patch",
"merged_at": "2024-06-16T20:15:24"
} | Prevents people from getting unexpected syntax errors when they install on a python version too old. | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9431/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9431/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9430 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9430/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9430/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9430/events | https://github.com/NVIDIA/NeMo/pull/9430 | 2,344,723,324 | PR_kwDOC_bI7s5yBW3K | 9,430 | Add Dev Container Bug Report | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-10T19:58:27 | 2024-06-10T22:36:18 | 2024-06-10T22:36:17 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9430",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9430",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9430.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9430.patch",
"merged_at": "2024-06-10T22:36:17"
} | Add Dev Container Bug Report | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9430/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9430/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9429 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9429/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9429/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9429/events | https://github.com/NVIDIA/NeMo/issues/9429 | 2,344,535,955 | I_kwDOC_bI7s6LvseT | 9,429 | Conflict between bf16-mixed Precision Setting and MegatronHalfPrecisionPlugin in MegatronGPT Training | {
"login": "moutasemalakkad",
"id": 39648266,
"node_id": "MDQ6VXNlcjM5NjQ4MjY2",
"avatar_url": "https://avatars.githubusercontent.com/u/39648266?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/moutasemalakkad",
"html_url": "https://github.com/moutasemalakkad",
"followers_url": "https://api.github.com/users/moutasemalakkad/followers",
"following_url": "https://api.github.com/users/moutasemalakkad/following{/other_user}",
"gists_url": "https://api.github.com/users/moutasemalakkad/gists{/gist_id}",
"starred_url": "https://api.github.com/users/moutasemalakkad/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/moutasemalakkad/subscriptions",
"organizations_url": "https://api.github.com/users/moutasemalakkad/orgs",
"repos_url": "https://api.github.com/users/moutasemalakkad/repos",
"events_url": "https://api.github.com/users/moutasemalakkad/events{/privacy}",
"received_events_url": "https://api.github.com/users/moutasemalakkad/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"@moutasemalakkad \r\n\r\nHi, I've just faced same issue.\r\n- work on Docker image ; nvcr.io/nvidia/nemo:24.03.framework\r\n\r\nHere is my solution : insert `cfg.trainer.precision = None` above this line.\r\nhttps://github.com/NVIDIA/NeMo/blob/ebba8b14263ca513c4453fcde0472785c19f46c1/examples/nlp/language_modeling/megatron_gpt_continue_training.py#L167\r\n\r\nThis solution is inspired from this PR https://github.com/NVIDIA/NeMo/pull/8908/\r\n\r\nIt should solve the conflict.\r\n\r\n",
"Thanks! That also did not work, the work around was to set the plugins to an empty list\r\n \r\ntrainer = Trainer(plugins=[], strategy=strategy, **cfg.trainer, callbacks=callbacks) \r\n",
"Hi, the contrinue_pretraining script was [consolidated](https://github.com/NVIDIA/NeMo/pull/9413) with the pretraining one [megatron_gpt_pretraining.py](https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/language_modeling/megatron_gpt_pretraining.py), so you may want to try this. I think you should not face the issue any more.\r\n\r\nThanks."
] | 2024-06-10T18:08:26 | 2024-07-25T22:50:52 | 2024-07-25T22:50:52 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Title: Conflict between precision settings and MegatronHalfPrecisionPlugin in MegatronGPT training**
**Describe the bug**
When attempting to continue training the MegatronGPT model, I encountered a conflict between `precision=bf16-mixed` and the `MegatronHalfPrecisionPlugin`. This results in a `ValueError` indicating that both `precision=bf16-mixed` and the `MegatronHalfPrecisionPlugin` were received and only one should be chosen.
**Steps/Code to reproduce bug**
1. Set up the environment as described below.
2. Use the following configuration and code snippet to initiate training.
**Configuration:**
```
DATA='{train:[1.0,training_data_indexed/train_text_document], validation:[training_data_indexed/val_text_document], test:[training_data_indexed/test_text_document]}'
!torchrun --nproc_per_node=1 /opt/NeMo/examples/nlp/language_modeling/megatron_gpt_continue_training.py \
model.data.data_prefix="$DATA" \
name=megatron_gpt_ \
exp_manager.name=megatron_gpt_1 \
restore_from_path='/workspace/new_nemo_out/new_megatron_gpt_model.nemo' \
trainer.devices=1 \
trainer.num_nodes=1 \
trainer.precision=16-mixed \
trainer.val_check_interval=300 \
trainer.max_steps=1200 \
model.megatron_amp_O2=False \
model.tensor_model_parallel_size=1 \
model.pipeline_model_parallel_size=1 \
model.micro_batch_size=1 \
model.global_batch_size=1 \
++model.use_flash_attention=False \
++model.seq_len_interpolation_factor=null
```
**Error Message:**
```
[NeMo W 2024-06-09 00:24:29 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/pytorch_lightning/_graveyard/precision.py:49: The `MixedPrecisionPlugin` is deprecated. Use `pytorch_lightning.plugins.precision.MixedPrecision` instead.
[NeMo W 2024-06-09 00:24:29 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/lightning_fabric/connector.py:563: `precision=bf16` is supported for historical reasons but its usage is discouraged. Please set your precision to bf16-mixed instead!
Error executing job with overrides: []
Traceback (most recent call last):
File "/opt/NeMo/examples/nlp/language_modeling/megatron_gpt_continue_training.py", line 167, in main
trainer = Trainer(plugins=plugins, strategy=strategy, **cfg.trainer, callbacks=callbacks)
File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/utilities/argparse.py", line 70, in insert_env_defaults
return fn(self, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/trainer.py", line 401, in __init__
self._accelerator_connector = _AcceleratorConnector(
File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/connectors/accelerator_connector.py", line 134, in __init__
self._check_config_and_set_final_flags(
File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/connectors/accelerator_connector.py", line 271, in _check_config_and_set_final_flags
raise ValueError(
ValueError: Received both `precision=bf16-mixed` and `plugins=<nemo.collections.nlp.parts.nlp_overrides.MegatronHalfPrecisionPlugin object at 0x7fed4a8568c0>`. Choose one.
Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.
```
**Expected behavior**
The training should proceed without conflicts between precision settings and plugins.
**Environment overview (please complete the following information)**
- **Environment location:** Docker
**Environment details**
- **OS version:** Ubuntu 20.04
- **PyTorch version:** 1.13.1
- **Python version:** 3.10
**Additional context**
- **GPU model:** NVIDIA A100
- **NVIDIA Driver version:** 470.57.02
- **CUDA version:** 11.4
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9429/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9429/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9428 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9428/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9428/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9428/events | https://github.com/NVIDIA/NeMo/issues/9428 | 2,344,431,821 | I_kwDOC_bI7s6LvTDN | 9,428 | RAM memory leaks for EncDecCTCModelBPE at inference | {
"login": "vikcost",
"id": 152401927,
"node_id": "U_kgDOCRV4Bw",
"avatar_url": "https://avatars.githubusercontent.com/u/152401927?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vikcost",
"html_url": "https://github.com/vikcost",
"followers_url": "https://api.github.com/users/vikcost/followers",
"following_url": "https://api.github.com/users/vikcost/following{/other_user}",
"gists_url": "https://api.github.com/users/vikcost/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vikcost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vikcost/subscriptions",
"organizations_url": "https://api.github.com/users/vikcost/orgs",
"repos_url": "https://api.github.com/users/vikcost/repos",
"events_url": "https://api.github.com/users/vikcost/events{/privacy}",
"received_events_url": "https://api.github.com/users/vikcost/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale.",
"Try to run the model undel \n```\nwith torch.no_grad()\n```\n"
] | 2024-06-10T17:09:07 | 2024-10-26T20:45:01 | 2024-08-22T01:52:59 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Numbers suggests that `EncDecCTCModelBPE` has RAM memory leaks.
I'm running inference with `batch_size=1` on a directory with 10k small audio files with total duration of around 9.5 hours.
Does any body know where this excessive RAM usage comes from?
Here is a sample script:
```
import time
from pathlib import Path
import psutil
import torch
from nemo.collections.asr.models import EncDecCTCModelBPE
torch.set_num_threads(1)
proc_usage = psutil.Process()
cur_usage_rss = proc_usage.memory_info().rss / 1024 / 1024
print(f"Initial rss usage:{cur_usage_rss}")
dir_name = "/mnt/data/subset_10k"
audio_paths = Path(dir_name)
def find_leaks():
model = EncDecCTCModelBPE.from_pretrained(model_name="stt_en_conformer_ctc_medium")
res_file_path = f"memory_usage3_start_{time.time()}.txt"
fd = open(res_file_path, "w")
files = audio_paths.glob("*.wav")
for idx, a_path in enumerate(files):
res = model.transcribe(str(a_path), verbose=False)
if idx % 100 == 0:
cur_usage_rss = proc_usage.memory_info().rss / 1024 / 1024
msg = f"{idx: <10} rss usage:{cur_usage_rss}"
print(msg)
print(msg, file=fd)
fd.close()
if __name__ == "__main__":
find_leaks()
```
And a sample output:
```
0 rss usage:1433.66796875
100 rss usage:1561.16796875
200 rss usage:1584.16796875
300 rss usage:1596.66796875
400 rss usage:1607.16796875
500 rss usage:1629.9375
600 rss usage:1636.4375
700 rss usage:1660.2890625
800 rss usage:1660.2890625
900 rss usage:1661.2890625
1000 rss usage:1672.7890625
1100 rss usage:1680.7890625
1200 rss usage:1688.7890625
1300 rss usage:1695.7890625
1400 rss usage:1697.2890625
1500 rss usage:1706.2890625
1600 rss usage:1718.09765625
1700 rss usage:1718.09765625
1800 rss usage:1721.09765625
1900 rss usage:1725.09765625
2000 rss usage:1738.59765625
```
**Expected behavior**
Constant memory consumption over time.
**Environment overview (please complete the following information)**
- Environment location: Bare-metal
- Method of NeMo install: `python -m pip install git+https://github.com/NVIDIA/NeMo.git@{2.0.0rc0}#egg=nemo_toolkit[all]`
**Environment details**
- OS version: Ubuntu 22.04, kernel 6.5.0-35-generic
- PyTorch version: 2.2.2
- Python version: 3.10.12
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9428/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9428/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9427 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9427/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9427/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9427/events | https://github.com/NVIDIA/NeMo/pull/9427 | 2,344,421,011 | PR_kwDOC_bI7s5yAUh5 | 9,427 | query tp_comm_disable_qkv via getattr | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"will add this to mcore."
] | 2024-06-10T17:03:56 | 2024-08-01T16:36:28 | 2024-06-12T01:03:01 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9427",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9427",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9427.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9427.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9427/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9427/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9424 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9424/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9424/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9424/events | https://github.com/NVIDIA/NeMo/pull/9424 | 2,343,927,046 | PR_kwDOC_bI7s5x-nEj | 9,424 | Use TensorRT-LLM native parameter names in nemo.export module | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-10T13:26:26 | 2024-06-10T17:45:34 | 2024-06-10T17:45:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9424",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9424",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9424.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9424.patch",
"merged_at": "2024-06-10T17:45:33"
} | # What does this PR do ?
A small renaming PR to use native TensorRT-LLM parameter names:
* `max_input_len` instead of `max_input_token`
* `max_output_len` instead of `max_output_token`
For `export` and `forward` methods in `TensorRTLLM` class it is still possible to use old names but a deprecation warning is issued.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] Refactor
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9424/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9424/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9423 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9423/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9423/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9423/events | https://github.com/NVIDIA/NeMo/pull/9423 | 2,343,576,471 | PR_kwDOC_bI7s5x9aWK | 9,423 | Enable specifying alpha for PTQ INT8 SmoothQuant method | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-10T10:47:37 | 2024-06-11T14:27:10 | 2024-06-11T14:27:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9423",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9423",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9423.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9423.patch",
"merged_at": "2024-06-11T14:27:09"
} | # What does this PR do ?
Allow users to specifying **alpha** for INT8 SmoothQuant method. For example, setting it to 0.8 improves Llama3 (8b, 70b) MMLU accuracy results compared to default alpha=1.0.
```
| MODEL | ALPHA | MMLU |
|------------|---------|--------|
| LLAMA3-70B | 0 | 0.004 |
| LLAMA3-70B | 0.25 | 0.116 |
| LLAMA3-70B | 0.5 | 0.516 |
| LLAMA3-70B | 0.7 | 0.765 |
| LLAMA3-70B | 0.75 | 0.77 |
| LLAMA3-70B | 0.8 | 0.772 |
| LLAMA3-70B | 0.85 | 0.766 |
| LLAMA3-70B | 0.9 | 0.75 |
| LLAMA3-70B | 1 | 0.728 |
| LLAMA3-8B | 0 | 0.062 |
| LLAMA3-8B | 0.25 | 0.227 |
| LLAMA3-8B | 0.5 | 0.379 |
| LLAMA3-8B | 0.7 | 0.617 |
| LLAMA3-8B | 0.75 | 0.624 |
| LLAMA3-8B | 0.8 | 0.625 |
| LLAMA3-8B | 0.85 | 0.62 |
| LLAMA3-8B | 0.9 | 0.619 |
| LLAMA3-8B | 0.95 | 0.612 |
| LLAMA3-8B | 1 | 0.594 |
```
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
python megatron_quantization.py \
...
quantization.algorithm=int8_sq \
quantization.alpha=0.5 \
....
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9423/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9423/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9422 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9422/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9422/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9422/events | https://github.com/NVIDIA/NeMo/pull/9422 | 2,343,388,107 | PR_kwDOC_bI7s5x8wv8 | 9,422 | Wrap all fp8 extra states in LocalNonpersistentObject | {
"login": "jbaczek",
"id": 45043825,
"node_id": "MDQ6VXNlcjQ1MDQzODI1",
"avatar_url": "https://avatars.githubusercontent.com/u/45043825?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jbaczek",
"html_url": "https://github.com/jbaczek",
"followers_url": "https://api.github.com/users/jbaczek/followers",
"following_url": "https://api.github.com/users/jbaczek/following{/other_user}",
"gists_url": "https://api.github.com/users/jbaczek/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jbaczek/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jbaczek/subscriptions",
"organizations_url": "https://api.github.com/users/jbaczek/orgs",
"repos_url": "https://api.github.com/users/jbaczek/repos",
"events_url": "https://api.github.com/users/jbaczek/events{/privacy}",
"received_events_url": "https://api.github.com/users/jbaczek/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-10T09:25:11 | 2024-07-30T01:50:43 | 2024-07-30T01:50:42 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9422",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9422",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9422.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9422.patch",
"merged_at": null
} | # What does this PR do ?
This PR generalizes FP8 extra state wrapping for all tensors.
**Collection**: nlp
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9422/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9422/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9421 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9421/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9421/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9421/events | https://github.com/NVIDIA/NeMo/pull/9421 | 2,342,719,481 | PR_kwDOC_bI7s5x6eqr | 9,421 | mcore distOpt restore fix | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-06-10T02:46:58 | 2024-06-25T15:32:54 | 2024-06-25T15:32:54 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9421",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9421",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9421.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9421.patch",
"merged_at": "2024-06-25T15:32:54"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9421/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9421/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9420 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9420/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9420/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9420/events | https://github.com/NVIDIA/NeMo/pull/9420 | 2,342,536,015 | PR_kwDOC_bI7s5x54E5 | 9,420 | Akoumparouli/profiling docs | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815558,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU4",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/documentation",
"name": "documentation",
"color": "0075ca",
"default": true,
"description": "Improvements or additions to documentation"
},
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"CI passed: https://github.com/NVIDIA/NeMo/actions/runs/9440118885"
] | 2024-06-09T23:05:12 | 2024-06-11T17:54:15 | 2024-06-11T17:54:14 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9420",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9420",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9420.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9420.patch",
"merged_at": "2024-06-11T17:54:14"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9420/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9420/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9419 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9419/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9419/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9419/events | https://github.com/NVIDIA/NeMo/issues/9419 | 2,342,315,614 | I_kwDOC_bI7s6LnOZe | 9,419 | Python 3.11 dataclasses ValueError | {
"login": "MedAymenF",
"id": 33981698,
"node_id": "MDQ6VXNlcjMzOTgxNjk4",
"avatar_url": "https://avatars.githubusercontent.com/u/33981698?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MedAymenF",
"html_url": "https://github.com/MedAymenF",
"followers_url": "https://api.github.com/users/MedAymenF/followers",
"following_url": "https://api.github.com/users/MedAymenF/following{/other_user}",
"gists_url": "https://api.github.com/users/MedAymenF/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MedAymenF/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MedAymenF/subscriptions",
"organizations_url": "https://api.github.com/users/MedAymenF/orgs",
"repos_url": "https://api.github.com/users/MedAymenF/repos",
"events_url": "https://api.github.com/users/MedAymenF/events{/privacy}",
"received_events_url": "https://api.github.com/users/MedAymenF/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days."
] | 2024-06-09T14:39:38 | 2024-08-15T13:20:27 | 2024-08-15T13:20:27 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Some scripts still throw errors similar to #7166:
```
transcribe_speech.py 104 <module>
@dataclass
dataclasses.py 1232 dataclass
return wrap(cls)
dataclasses.py 1222 wrap
return _process_class(cls, init, repr, eq, order, unsafe_hash,
dataclasses.py 958 _process_class
cls_fields.append(_get_field(cls, name, type, kw_only))
dataclasses.py 815 _get_field
raise ValueError(f'mutable default {type(f.default)} for field '
ValueError:
mutable default <class 'nemo.collections.asr.modules.conformer_encoder.ConformerChangeConfig'> for field conformer is not allowed: use default_factory
```
**Steps/Code to reproduce bug**
`python NeMo-1.23.0/examples/asr/transcribe_speech.py`
**Expected behavior**
Run without error.
**Environment overview (please complete the following information)**
- Environment location: Bare-metal.
- Method of NeMo install: `pip install nemo_toolkit['asr']`.
**Environment details**
- OS version: Linux DESKTOP-4S0973M 5.15.146.1-microsoft-standard-WSL2
- PyTorch version: 2.3.0
- Python version: 3.11.9 | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9419/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9419/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9417 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9417/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9417/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9417/events | https://github.com/NVIDIA/NeMo/pull/9417 | 2,341,702,463 | PR_kwDOC_bI7s5x3Rsj | 9,417 | Fix: Ensure start_index is converted to a CPU-based NumPy array | {
"login": "yonas-g",
"id": 23583963,
"node_id": "MDQ6VXNlcjIzNTgzOTYz",
"avatar_url": "https://avatars.githubusercontent.com/u/23583963?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yonas-g",
"html_url": "https://github.com/yonas-g",
"followers_url": "https://api.github.com/users/yonas-g/followers",
"following_url": "https://api.github.com/users/yonas-g/following{/other_user}",
"gists_url": "https://api.github.com/users/yonas-g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yonas-g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yonas-g/subscriptions",
"organizations_url": "https://api.github.com/users/yonas-g/orgs",
"repos_url": "https://api.github.com/users/yonas-g/repos",
"events_url": "https://api.github.com/users/yonas-g/events{/privacy}",
"received_events_url": "https://api.github.com/users/yonas-g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-08T15:24:17 | 2024-06-30T01:52:15 | 2024-06-30T01:52:14 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9417",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9417",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9417.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9417.patch",
"merged_at": null
} | # What does this PR do ?
Ensures the `start_index` is correctly converted to a CPU-based NumPy array to maintain compatibility with operations requiring NumPy arrays.
**Collection**: `RNNT Decoding`
# Changelog
- Updated the calculation of `start_index` to include `.cpu().numpy()` conversion in the `AbstractRNNTDecoding` class.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9417/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9417/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9416 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9416/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9416/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9416/events | https://github.com/NVIDIA/NeMo/issues/9416 | 2,341,676,948 | I_kwDOC_bI7s6LkyeU | 9,416 | Getting `TypeError: can't convert cuda:0 device type tensor to numpy. Use Tensor.cpu() to copy the tensor to host memory first.` | {
"login": "yonas-g",
"id": 23583963,
"node_id": "MDQ6VXNlcjIzNTgzOTYz",
"avatar_url": "https://avatars.githubusercontent.com/u/23583963?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yonas-g",
"html_url": "https://github.com/yonas-g",
"followers_url": "https://api.github.com/users/yonas-g/followers",
"following_url": "https://api.github.com/users/yonas-g/following{/other_user}",
"gists_url": "https://api.github.com/users/yonas-g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yonas-g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yonas-g/subscriptions",
"organizations_url": "https://api.github.com/users/yonas-g/orgs",
"repos_url": "https://api.github.com/users/yonas-g/repos",
"events_url": "https://api.github.com/users/yonas-g/events{/privacy}",
"received_events_url": "https://api.github.com/users/yonas-g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | [] | 2024-06-08T14:14:32 | 2024-06-08T14:50:05 | 2024-06-08T14:49:52 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I am getting `TypeError: can't convert cuda:0 device type tensor to numpy. Use Tensor.cpu() to copy the tensor to host memory first.` when transcribing using a transducer model by setting `return_hypotheses=True` and `compute_timestamps=True` in decoding config. If I remove `compute_timestamps=True`, I don't get this error but the char and word level timestamp information won't be included.
**Steps/Code to reproduce bug**
```python
config = nemo_asr.models.ASRModel.restore_from(model_path, return_config=True)
decoding_config = config.decoding
decoding_config.strategy = "greedy_batch"
with open_dict(decoding_config):
decoding_config.preserve_alignments = True
decoding_config.fused_batch_size = -1 # temporarily stop fused batch during inference.
decoding_config.compute_timestamps = True
model.change_decoding_strategy(decoding_config)
hypothesis = model.transcribe(audio=sample_audio, batch_size=1, return_hypotheses=True)[0][0]
```
**Error**
```bash
File [~/NeMo/nemo/collections/asr/parts/submodules/rnnt_decoding.py:851], in AbstractRNNTDecoding._compute_offsets(hypothesis, token_repetitions, rnnt_token)
849 # Construct the start and end indices brackets
850 end_indices = np.asarray(token_repetitions).cumsum()
--> 851 start_indices = np.concatenate(([start_index], end_indices[:-1]))
.
.
.
File [~/miniconda3/envs/base/lib/python3.11/site-packages/torch/_tensor.py:1062], in Tensor.__array__(self, dtype)
1060 return handle_torch_function(Tensor.__array__, (self,), self, dtype=dtype)
1061 if dtype is None:
-> 1062 return self.numpy()
1063 else:
1064 return self.numpy().astype(dtype, copy=False)
TypeError: can't convert cuda:0 device type tensor to numpy. Use Tensor.cpu() to copy the tensor to host memory first.
```
**Environment overview (please complete the following information)**
- Environment location: AWS
- Method of NeMo install: from source
**Environment details**
- OS version: Ubuntu 22.04
- PyTorch version: 2.2.1
- Python version: 3.11
| {
"login": "yonas-g",
"id": 23583963,
"node_id": "MDQ6VXNlcjIzNTgzOTYz",
"avatar_url": "https://avatars.githubusercontent.com/u/23583963?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yonas-g",
"html_url": "https://github.com/yonas-g",
"followers_url": "https://api.github.com/users/yonas-g/followers",
"following_url": "https://api.github.com/users/yonas-g/following{/other_user}",
"gists_url": "https://api.github.com/users/yonas-g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yonas-g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yonas-g/subscriptions",
"organizations_url": "https://api.github.com/users/yonas-g/orgs",
"repos_url": "https://api.github.com/users/yonas-g/repos",
"events_url": "https://api.github.com/users/yonas-g/events{/privacy}",
"received_events_url": "https://api.github.com/users/yonas-g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9416/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9416/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9415 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9415/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9415/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9415/events | https://github.com/NVIDIA/NeMo/pull/9415 | 2,341,506,164 | PR_kwDOC_bI7s5x2skW | 9,415 | Fix README | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-06-08T06:29:15 | 2024-06-08T07:20:13 | 2024-06-08T07:20:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9415",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9415",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9415.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9415.patch",
"merged_at": "2024-06-08T07:20:12"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9415/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9415/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9414 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9414/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9414/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9414/events | https://github.com/NVIDIA/NeMo/pull/9414 | 2,341,288,503 | PR_kwDOC_bI7s5x19tT | 9,414 | Add option to merge distributed optimizer buckets | {
"login": "timmoon10",
"id": 4406448,
"node_id": "MDQ6VXNlcjQ0MDY0NDg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4406448?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/timmoon10",
"html_url": "https://github.com/timmoon10",
"followers_url": "https://api.github.com/users/timmoon10/followers",
"following_url": "https://api.github.com/users/timmoon10/following{/other_user}",
"gists_url": "https://api.github.com/users/timmoon10/gists{/gist_id}",
"starred_url": "https://api.github.com/users/timmoon10/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/timmoon10/subscriptions",
"organizations_url": "https://api.github.com/users/timmoon10/orgs",
"repos_url": "https://api.github.com/users/timmoon10/repos",
"events_url": "https://api.github.com/users/timmoon10/events{/privacy}",
"received_events_url": "https://api.github.com/users/timmoon10/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@ericharper \r\nCan you please review and merge?"
] | 2024-06-07T23:38:42 | 2024-06-12T21:26:09 | 2024-06-12T21:26:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9414",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9414",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9414.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9414.patch",
"merged_at": "2024-06-12T21:26:09"
} | # What does this PR do ?
Adds an option to merge distributed optimizer buckets with GPT. By default each bucket corresponds to a Transformer layer (without interleaved pipeline parallelism) or to virtual pipeline parallel stage (with interleaved pipeline parallelism)
**Collection**: NLP
# Changelog
- Add option to merge distributed optimizer buckets
# Usage
Run GPT, e.g. with the config at https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/language_modeling/conf/megatron_gpt_config.yaml.
Enable the distributed optimizer with `model.optim.name=distributed_fused_adam` and merge buckets with `model.distributed_adam_bucket_merge_size=<N>`.
For example, if training GPT without pipeline parallelism, `model.distributed_adam_bucket_merge_size=2` will cause each distopt bucket to contain the weights of two Transformer layers.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
Pinging @erhoo82.
# Additional Information
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9414/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9414/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9413 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9413/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9413/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9413/events | https://github.com/NVIDIA/NeMo/pull/9413 | 2,341,096,743 | PR_kwDOC_bI7s5x1UkM | 9,413 | Consolidate gpt continue training script into pretraining script | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Can we add github CI test for this and then also test the regular GPT pretraining, with resuming, is the same before and after this PR?",
"We should also add docs for this, the readme here is a good start.",
"sure i will add some tests. the gpt resume behavior is not changed in my local tests",
"@ericharper as I work on CI. I did some local tests \r\n\r\n"
] | 2024-06-07T20:12:56 | 2024-06-28T18:50:00 | 2024-06-28T18:49:59 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9413",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9413",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9413.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9413.patch",
"merged_at": "2024-06-28T18:49:59"
} | # What does this PR do ?
## Continual Learning with Pretrained Checkpoints
Continual learning enables large language models (LLMs) to acquire new skills and remain current with the swiftly advancing landscape of human knowledge. This guide details how to engage in continual learning using existing pretrained checkpoints with the `examples/nlp/language_modeling/megatron_gpt_pretraining.py` script. This process is applicable to various models including Llama 1/2/3, Gemma, Mistral, Mixtral, and others.
### Configuration for Continual Learning
To enable continual learning, modify the `model` configuration in your script as follows:
```yaml
model:
# Use the following settings to specify the source for continual learning:
restore_from_path: null # Set this to a .nemo file path to restore only the model weights.
restore_from_ckpt: null # Set this to a checkpoint path to restore both model weights and optimizer states.
```
- **restore_from_path**: Use this when you want to restore only the model weights from a `.nemo` file.
- **restore_from_ckpt**: Use this to restore both model weights and optimizer states from a PyTorch checkpoint.
### Adjusting Training Configurations
Upon engaging in continual learning, it is possible and often beneficial to modify various training configurations:
- **Model Parallelism**: Depending on the computational resources available, you may adjust the model's parallelism settings.
- **Data Blend**: You can change the dataset or modify how data is blended during training to better suit the new training objectives.
- **Learning Rate Scheduler**: Adjusting the learning rate schedule can help optimize training for the new conditions.
Refer to the *pretrain* section of the documentation for details on configuring these parameters.
### Important Notes on Continual Learning
- **State Reset**: When engaging in continual learning, all states including model parallelism configuration, dataset, learning rate scheduler, and randomness are reset, except for the states loaded from the checkpoint.
- **Resuming Training**: If training is interrupted (e.g., due to a system failure) and you wish to resume the continual learning process, ensure that the restore flags (`restore_from_path` or `restore_from_ckpt`) are set back to `null`. This prevents the system from resetting the states again, which could lead to incorrect results.
**Collection**: [nlp]
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9413/reactions",
"total_count": 2,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 1,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9413/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9412 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9412/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9412/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9412/events | https://github.com/NVIDIA/NeMo/pull/9412 | 2,340,370,801 | PR_kwDOC_bI7s5xy0pq | 9,412 | ci: Enrich notifications | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-07T12:44:57 | 2024-06-11T20:16:43 | 2024-06-11T20:16:43 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9412",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9412",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9412.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9412.patch",
"merged_at": "2024-06-11T20:16:42"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9412/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9412/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9411 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9411/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9411/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9411/events | https://github.com/NVIDIA/NeMo/pull/9411 | 2,340,197,851 | PR_kwDOC_bI7s5xyOrQ | 9,411 | cherry pick of #9266 | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-07T11:04:49 | 2024-06-10T22:02:27 | 2024-06-10T22:02:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9411",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9411",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9411.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9411.patch",
"merged_at": "2024-06-10T22:02:26"
} | # What does this PR do ?
cherry pick of #9266 PR.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9411/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9411/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9410 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9410/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9410/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9410/events | https://github.com/NVIDIA/NeMo/issues/9410 | 2,339,780,104 | I_kwDOC_bI7s6LdjYI | 9,410 | FSDP reduce_scatter can not overlap with compute | {
"login": "kuangdao",
"id": 25609661,
"node_id": "MDQ6VXNlcjI1NjA5NjYx",
"avatar_url": "https://avatars.githubusercontent.com/u/25609661?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kuangdao",
"html_url": "https://github.com/kuangdao",
"followers_url": "https://api.github.com/users/kuangdao/followers",
"following_url": "https://api.github.com/users/kuangdao/following{/other_user}",
"gists_url": "https://api.github.com/users/kuangdao/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kuangdao/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kuangdao/subscriptions",
"organizations_url": "https://api.github.com/users/kuangdao/orgs",
"repos_url": "https://api.github.com/users/kuangdao/repos",
"events_url": "https://api.github.com/users/kuangdao/events{/privacy}",
"received_events_url": "https://api.github.com/users/kuangdao/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"no one concerned about this issue?\r\n",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-07T07:25:59 | 2024-08-10T01:51:40 | 2024-08-10T01:51:39 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I use nemo 24.03 and i find FSDP reduce_scatter can not overlap with compute
<img width="838" alt="截屏2024-06-07 15 24 28" src="https://github.com/NVIDIA/NeMo/assets/25609661/0aa82472-88a5-4445-aa0c-0c8d8d41bb32">
```[tasklist]
### Tasks
```
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9410/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9410/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9409 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9409/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9409/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9409/events | https://github.com/NVIDIA/NeMo/pull/9409 | 2,339,464,779 | PR_kwDOC_bI7s5xvu65 | 9,409 | Enable encoder adapters for Canary and MultiTaskAED models | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-07T02:34:30 | 2024-06-29T00:46:04 | 2024-06-29T00:46:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9409",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9409",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9409.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9409.patch",
"merged_at": "2024-06-29T00:46:02"
} | # What does this PR do ?
Enable multi task AED models to add adapter support to its encoders (speech encoder and transformer encoder) and decoder (transformer decoder). Also add new API to automatically swap out original modules with adapter compatible modules.
**Collection**: [ASR]
# Changelog
- Add support for adapter module mixin to AED multitask model
- [CORE] Add support for `replace_adapter_compatible_modules()` which automatically swaps out registered original module class with the adapter class. It also updates config so save_to() and restore_from() will automatically pick current class.
- Support mha adapter and linear adapter for both speech encoder and transformer encoder + decoder modules
- Refactor AdapterModuleMixin to separate adapter type assertion from `add_adapter`
- Refactor ASRAdapterModelMixin to separate the logic of what model is parsed - now its determined by a simple string list of module names
- Add tests for aed multi task model with adapter support
# Usage
```python
from nemo.collections.asr.models import ASRModel
from nemo.collections.asr.parts.submodules.adapters import TransformerEncoderMultiHeadAttentionAdapterConfig
from nemo.collections.common.parts.adapter_modules import LinearAdapterConfig
model = ASRModel.from_pretrained("nvidia/canary-1b")
# New API to automatically swap out all original modules in model with adapter compatible modules via registry
model.replace_adapter_compatible_modules()
# Tiny Attention Adapters
adapter_cfg = TransformerEncoderMultiHeadAttentionAdapterConfig(
hidden_size=1024,
num_attention_heads=1,
proj_dim=8,
)
# OR
# Linear Adapters
adapter_cfg = LinearAdapterConfig(
in_features=1024,
dim=8,
)
# Load adapter weights and freeze all other weights
# Adapter targets can be "", "encoder", "transf_encoder" and "transf_decoder". "" refers to encoder by default.
# Verify supported adapter target modules using `model.adapter_module_names`.
model.add_adapter("encoder:my_adapter", adapter_cfg)
model.freeze()
model.unfreeze_enabled_adapters()
# Train model ...
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
| {
"login": "krishnacpuvvada",
"id": 93558329,
"node_id": "U_kgDOBZOWOQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93558329?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/krishnacpuvvada",
"html_url": "https://github.com/krishnacpuvvada",
"followers_url": "https://api.github.com/users/krishnacpuvvada/followers",
"following_url": "https://api.github.com/users/krishnacpuvvada/following{/other_user}",
"gists_url": "https://api.github.com/users/krishnacpuvvada/gists{/gist_id}",
"starred_url": "https://api.github.com/users/krishnacpuvvada/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/krishnacpuvvada/subscriptions",
"organizations_url": "https://api.github.com/users/krishnacpuvvada/orgs",
"repos_url": "https://api.github.com/users/krishnacpuvvada/repos",
"events_url": "https://api.github.com/users/krishnacpuvvada/events{/privacy}",
"received_events_url": "https://api.github.com/users/krishnacpuvvada/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9409/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9409/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9408 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9408/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9408/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9408/events | https://github.com/NVIDIA/NeMo/pull/9408 | 2,339,364,478 | PR_kwDOC_bI7s5xva9D | 9,408 | Fix bug with GPT distopt buckets when interleaved pipelining is enabled | {
"login": "timmoon10",
"id": 4406448,
"node_id": "MDQ6VXNlcjQ0MDY0NDg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4406448?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/timmoon10",
"html_url": "https://github.com/timmoon10",
"followers_url": "https://api.github.com/users/timmoon10/followers",
"following_url": "https://api.github.com/users/timmoon10/following{/other_user}",
"gists_url": "https://api.github.com/users/timmoon10/gists{/gist_id}",
"starred_url": "https://api.github.com/users/timmoon10/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/timmoon10/subscriptions",
"organizations_url": "https://api.github.com/users/timmoon10/orgs",
"repos_url": "https://api.github.com/users/timmoon10/repos",
"events_url": "https://api.github.com/users/timmoon10/events{/privacy}",
"received_events_url": "https://api.github.com/users/timmoon10/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-07T00:36:48 | 2024-08-02T17:12:24 | 2024-08-02T17:12:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9408",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9408",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9408.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9408.patch",
"merged_at": "2024-08-02T17:12:24"
} | # What does this PR do ?
When training GPT with interleaved pipelining and the distributed optimizer, we want each distopt bucket to correspond to a pipeline stage to get the best communication overlapping. However, https://github.com/NVIDIA/NeMo/pull/8221 has a bug where each distopt bucket corresponds to a Transformer layer.
**Collection**: NLP
# Changelog
- GPT configures distopt buckets to correspond to pipeline stages when interleaved pipelining are enabled
# Usage
Run GPT, e.g. with the config at https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/language_modeling/conf/megatron_gpt_config.yaml.
Enable the distributed optimizer with `model.optim.name=distributed_fused_adam`.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Bug introduced in https://github.com/NVIDIA/NeMo/pull/8221.
| {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9408/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9408/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9407 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9407/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9407/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9407/events | https://github.com/NVIDIA/NeMo/pull/9407 | 2,339,254,732 | PR_kwDOC_bI7s5xvD0E | 9,407 | [Nemo CICD] timeouts fix | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-06T22:38:19 | 2024-06-06T22:40:50 | 2024-06-06T22:40:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9407",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9407",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9407.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9407.patch",
"merged_at": "2024-06-06T22:40:49"
} | [Nemo CICD] timeouts fix | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9407/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9407/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9406 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9406/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9406/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9406/events | https://github.com/NVIDIA/NeMo/pull/9406 | 2,339,013,324 | PR_kwDOC_bI7s5xuOp7 | 9,406 | Add T5TTS | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-06T19:30:17 | 2024-08-17T01:49:32 | 2024-08-17T01:49:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9406",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9406",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9406.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9406.patch",
"merged_at": null
} | # What does this PR do ?
Adds T5 TTS model
**Collection**: tts, nlp
# Changelog
- Adds T5 TTS model
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
``` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9406/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9406/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9405 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9405/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9405/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9405/events | https://github.com/NVIDIA/NeMo/pull/9405 | 2,338,999,209 | PR_kwDOC_bI7s5xuLhI | 9,405 | Add T5 TTS | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-06T19:21:06 | 2024-06-06T19:30:23 | 2024-06-06T19:30:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9405",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9405",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9405.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9405.patch",
"merged_at": null
} | # What does this PR do ?
Adds T5 TTS model
**Collection**: tts, nlp
# Changelog
- Adds T5 TTS model
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
``` | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9405/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9405/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9404 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9404/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9404/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9404/events | https://github.com/NVIDIA/NeMo/pull/9404 | 2,338,885,962 | PR_kwDOC_bI7s5xtzJi | 9,404 | Update to work using Llama 3 | {
"login": "JesusPaz",
"id": 27715376,
"node_id": "MDQ6VXNlcjI3NzE1Mzc2",
"avatar_url": "https://avatars.githubusercontent.com/u/27715376?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JesusPaz",
"html_url": "https://github.com/JesusPaz",
"followers_url": "https://api.github.com/users/JesusPaz/followers",
"following_url": "https://api.github.com/users/JesusPaz/following{/other_user}",
"gists_url": "https://api.github.com/users/JesusPaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JesusPaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JesusPaz/subscriptions",
"organizations_url": "https://api.github.com/users/JesusPaz/orgs",
"repos_url": "https://api.github.com/users/JesusPaz/repos",
"events_url": "https://api.github.com/users/JesusPaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/JesusPaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-06-06T18:14:40 | 2024-06-18T17:10:43 | 2024-06-18T17:10:43 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9404",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9404",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9404.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9404.patch",
"merged_at": null
} | # What does this PR do ?
fix the script to convert llama3 from nemo to hf format.

# Changelog
- Stop using LlamaTokenizer and start using AutoTokenizer from Transformers.
# Usage
```python
python3 NeMo/scripts/checkpoint_converters/convert_llama_nemo_to_hf.py \
--input_name_or_path llama3-8b.nemo \
--output_path llama3-8b-hf/pytorch_model.bin \
--hf_input_path Meta-Llama-3-8B \
--hf_output_path llama3-8b-hf \
--input_tokenizer Meta-Llama-3-8B \
--hf_output_tokenizer llama3-8b-hf
```
you must except something like this when the script finishes:

# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* there is an issue in hf related but is not the same script https://huggingface.co/meta-llama/Meta-Llama-3-8B-Instruct/discussions/37
| {
"login": "JesusPaz",
"id": 27715376,
"node_id": "MDQ6VXNlcjI3NzE1Mzc2",
"avatar_url": "https://avatars.githubusercontent.com/u/27715376?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JesusPaz",
"html_url": "https://github.com/JesusPaz",
"followers_url": "https://api.github.com/users/JesusPaz/followers",
"following_url": "https://api.github.com/users/JesusPaz/following{/other_user}",
"gists_url": "https://api.github.com/users/JesusPaz/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JesusPaz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JesusPaz/subscriptions",
"organizations_url": "https://api.github.com/users/JesusPaz/orgs",
"repos_url": "https://api.github.com/users/JesusPaz/repos",
"events_url": "https://api.github.com/users/JesusPaz/events{/privacy}",
"received_events_url": "https://api.github.com/users/JesusPaz/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9404/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9404/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9403 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9403/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9403/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9403/events | https://github.com/NVIDIA/NeMo/pull/9403 | 2,338,693,120 | PR_kwDOC_bI7s5xtIOm | 9,403 | fix operator precedence | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-06-06T16:32:51 | 2024-06-24T14:00:16 | 2024-06-24T14:00:15 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9403",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9403",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9403.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9403.patch",
"merged_at": "2024-06-24T14:00:15"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9403/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9403/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9402 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9402/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9402/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9402/events | https://github.com/NVIDIA/NeMo/pull/9402 | 2,338,603,022 | PR_kwDOC_bI7s5xsz-R | 9,402 | TRT-LLM 0.10 Update | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@oyilmaz-nvidia could you please tell how to install the NeMo in a way that doesn't bring up all the dependencies? I don't see `requirements_export.txt` anymore.",
"I cannot find `use_inflight_batching`, `enable_context_fmha` parameters of the `export()` method. What is the new way of setting them?",
"@PeganovAnton I'll create a release branch for you.\r\n\r\nSo for the `use_inflight_batching`, `enable_context_fmha`, we no longer get those parameters since trt-llm also changed it. So, as long as the gemm plugin is enabled, remove padding is also true, inflight batching is enabled underneath. Basically, the default parameters should enable the IFB automatically."
] | 2024-06-06T15:54:23 | 2024-06-13T02:22:34 | 2024-06-13T02:22:33 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9402",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9402",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9402.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9402.patch",
"merged_at": "2024-06-13T02:22:33"
} | # What does this PR do ?
Update the trt-llm export code to the version 0.10 | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9402/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9402/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9401 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9401/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9401/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9401/events | https://github.com/NVIDIA/NeMo/pull/9401 | 2,338,522,507 | PR_kwDOC_bI7s5xsh7C | 9,401 | [NeMo-UX] Removing default_path from ModelConnector | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-06T15:21:56 | 2024-06-08T03:31:16 | 2024-06-08T03:31:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9401",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9401",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9401.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9401.patch",
"merged_at": "2024-06-08T03:31:16"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9401/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9401/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9400 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9400/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9400/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9400/events | https://github.com/NVIDIA/NeMo/pull/9400 | 2,338,512,222 | PR_kwDOC_bI7s5xsfrI | 9,400 | [NeMo-UX] Adding file-lock to Connector | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-06T15:16:53 | 2024-06-10T14:37:22 | 2024-06-10T14:37:22 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9400",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9400",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9400.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9400.patch",
"merged_at": "2024-06-10T14:37:22"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9400/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9400/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9399 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9399/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9399/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9399/events | https://github.com/NVIDIA/NeMo/pull/9399 | 2,338,476,252 | PR_kwDOC_bI7s5xsXyL | 9,399 | ci: Fix `L2_Segmentation_Tool_Parallel_ctc_segmentation_test_L2_Eng_C… | {
"login": "ko3n1g",
"id": 16716991,
"node_id": "MDQ6VXNlcjE2NzE2OTkx",
"avatar_url": "https://avatars.githubusercontent.com/u/16716991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ko3n1g",
"html_url": "https://github.com/ko3n1g",
"followers_url": "https://api.github.com/users/ko3n1g/followers",
"following_url": "https://api.github.com/users/ko3n1g/following{/other_user}",
"gists_url": "https://api.github.com/users/ko3n1g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ko3n1g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ko3n1g/subscriptions",
"organizations_url": "https://api.github.com/users/ko3n1g/orgs",
"repos_url": "https://api.github.com/users/ko3n1g/repos",
"events_url": "https://api.github.com/users/ko3n1g/events{/privacy}",
"received_events_url": "https://api.github.com/users/ko3n1g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-06T14:59:21 | 2024-06-06T17:27:13 | 2024-06-06T17:27:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9399",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9399",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9399.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9399.patch",
"merged_at": "2024-06-06T17:27:12"
} | …itriNet_with_wav`
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9399/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9399/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9397 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9397/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9397/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9397/events | https://github.com/NVIDIA/NeMo/issues/9397 | 2,337,858,956 | I_kwDOC_bI7s6LWOWM | 9,397 | Nemo_toolkit 2.0.0.rc0 installation failure | {
"login": "Subbu-ssr",
"id": 171925033,
"node_id": "U_kgDOCj9eKQ",
"avatar_url": "https://avatars.githubusercontent.com/u/171925033?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Subbu-ssr",
"html_url": "https://github.com/Subbu-ssr",
"followers_url": "https://api.github.com/users/Subbu-ssr/followers",
"following_url": "https://api.github.com/users/Subbu-ssr/following{/other_user}",
"gists_url": "https://api.github.com/users/Subbu-ssr/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Subbu-ssr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Subbu-ssr/subscriptions",
"organizations_url": "https://api.github.com/users/Subbu-ssr/orgs",
"repos_url": "https://api.github.com/users/Subbu-ssr/repos",
"events_url": "https://api.github.com/users/Subbu-ssr/events{/privacy}",
"received_events_url": "https://api.github.com/users/Subbu-ssr/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Thanks for the information, we're taking a look at whether we can make it an optional dependency. ",
"I just tried installing in a clean conda env and it worked for me: \r\n```\r\nconda create env --name test_r2.0.0rc0 python==3.10.12\r\nconda activate test_r2.0.0rc0\r\nconda install pytorch torchvision torchaudio pytorch-cuda=12.1 -c pytorch -c nvidia\r\npip install Cython\r\npip install packaging\r\npip install --pre nemo_toolkit[all]\r\n```\r\nCould you try it?\r\n\r\nOr if you use the container `nvcr.io/nvidia/pytorch:24.02-py3` just \r\n```\r\npip install --pre nemo_toolkit[all]\r\n```\r\nshould work.",
"Thank you so much for your help\r\n\r\nOn Fri, 7 Jun, 2024, 11:31 Eric Harper, ***@***.***> wrote:\r\n\r\n> I just tried installing in a clean conda env and it worked for me:\r\n>\r\n> conda create env --name test_r2.0.0rc0 python==3.10.12\r\n> conda activate test_r2.0.0rc0\r\n> conda install pytorch torchvision torchaudio pytorch-cuda=12.1 -c pytorch -c nvidia\r\n> pip install Cython\r\n> pip install packaging\r\n> pip install --pre nemo_toolkit[all]\r\n>\r\n> Could you try it?\r\n>\r\n> Or if you use the container nvcr.io/nvidia/pytorch:24.02-py3 just\r\n>\r\n> pip install --pre nemo_toolkit[all]\r\n>\r\n> should work.\r\n>\r\n> —\r\n> Reply to this email directly, view it on GitHub\r\n> <https://github.com/NVIDIA/NeMo/issues/9397#issuecomment-2154140932>, or\r\n> unsubscribe\r\n> <https://github.com/notifications/unsubscribe-auth/BI7V4KOCJ4NR4FU2HARAF43ZGFEFHAVCNFSM6AAAAABI4MMH36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJUGE2DAOJTGI>\r\n> .\r\n> You are receiving this because you authored the thread.Message ID:\r\n> ***@***.***>\r\n>\r\n\r\n-- \r\nThe information in this message may be proprietary and/or confidential and \r\nprotected from disclosure. If the reader of this message is not the \r\nintended recipient, you are hereby notified that any dissemination, \r\ndistribution, or copying of this communication is strictly prohibited. If \r\nyou have received this communication in error, please notify ATMECS and \r\ndelete it from your computer.\r\n\r\n",
"Please let us know if this resolves your issue.",
"ollecting nemo_toolkit[all]\r\n Downloading https://files.pythonhosted.org/packages/cd/94/1031a231453146b5ec302a6c2282dc90c2e18844deeee2ff867900b90368/nemo_toolkit-2.0.0rc0-py3-none-any.whl (3.6MB)\r\n 100% |████████████████████████████████| 3.6MB 5.4MB/s eta 0:00:01\r\nCollecting ruamel.yaml (from nemo_toolkit[all])\r\n Downloading https://files.pythonhosted.org/packages/4b/5d/678d7d15071816cb9a5e015fcd090ddc59a6a195ce8965363313e2044595/ruamel.yaml-0.18.3-py3-none-any.whl (114kB)\r\n 100% |████████████████████████████████| 122kB 12.2MB/s ta 0:00:01\r\nCollecting numpy>=1.22 (from nemo_toolkit[all])\r\n Could not find a version that satisfies the requirement numpy>=1.22 (from nemo_toolkit[all]) (from versions: 1.3.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2, 1.9.0, 1.9.1, 1.9.2, 1.9.3, 1.10.0.post2, 1.10.1, 1.10.2, 1.10.4, 1.11.0, 1.11.1, 1.11.2, 1.11.3, 1.12.0, 1.12.1, 1.13.0, 1.13.1, 1.13.3, 1.14.0, 1.14.1, 1.14.2, 1.14.3, 1.14.4, 1.14.5, 1.14.6, 1.15.0, 1.15.1, 1.15.2, 1.15.3, 1.15.4, 1.16.0, 1.16.1, 1.16.2, 1.16.3, 1.16.4, 1.16.5, 1.16.6, 1.17.0, 1.17.1, 1.17.2, 1.17.3, 1.17.4, 1.17.5, 1.18.0, 1.18.1, 1.18.2, 1.18.3, 1.18.4, 1.18.5, 1.19.0, 1.19.1, 1.19.2, 1.19.3, 1.19.4, 1.19.5)\r\nNo matching distribution found for numpy>=1.22 (from nemo_toolkit[all]\r\nThis is the error i got now after runnig the command \r\nThe numpy i installed in my system in 1.11.3 version .\r\ncan you please help me to resolve this issue\r\n",
"i tried installing nemo-toolkit with the command pip install nemo-toolkit[all]==2.0.0rc0. It shows the nemo version and only asr collections and tts collections are importing,nlp collections are not importing. This is the error i got \r\nImportError Traceback (most recent call last)\r\n/tmp/ipykernel_53908/447078856.py in <module>\r\n----> 1 import nemo.collections.nlp as nemo_nlp\r\n\r\n~/.local/lib/python3.10/site-packages/nemo/collections/nlp/__init__.py in <module>\r\n 13 # limitations under the License.\r\n 14 \r\n---> 15 from nemo.collections.nlp import data, losses, models, modules\r\n 16 from nemo.package_info import __version__\r\n 17 \r\n\r\n~/.local/lib/python3.10/site-packages/nemo/collections/nlp/data/__init__.py in <module>\r\n 40 BertTokenClassificationInferDataset,\r\n 41 )\r\n---> 42 from nemo.collections.nlp.data.zero_shot_intent_recognition.zero_shot_intent_dataset import (\r\n 43 ZeroShotIntentDataset,\r\n 44 ZeroShotIntentInferenceDataset,\r\n\r\n~/.local/lib/python3.10/site-packages/nemo/collections/nlp/data/zero_shot_intent_recognition/__init__.py in <module>\r\n 14 \r\n 15 \r\n---> 16 from nemo.collections.nlp.data.zero_shot_intent_recognition.zero_shot_intent_dataset import (\r\n 17 ZeroShotIntentInferenceDataset,\r\n 18 calc_class_weights_from_dataloader,\r\n\r\n~/.local/lib/python3.10/site-packages/nemo/collections/nlp/data/zero_shot_intent_recognition/zero_shot_intent_dataset.py in <module>\r\n 28 from nemo.collections.nlp.data.glue_benchmark.data_processors import InputExample\r\n 29 from nemo.collections.nlp.data.glue_benchmark.glue_benchmark_dataset import GLUEDataset\r\n---> 30 from nemo.collections.nlp.parts.utils_funcs import tensor2list\r\n 31 from nemo.core.neural_types import CategoricalValuesType, ChannelType, MaskType, NeuralType\r\n 32 from nemo.utils import logging\r\n\r\n~/.local/lib/python3.10/site-packages/nemo/collections/nlp/parts/__init__.py in <module>\r\n 15 \r\n 16 from nemo.collections.nlp.parts.megatron_lr_schedulers import CosineAnnealingExp\r\n---> 17 from nemo.collections.nlp.parts.utils_funcs import list2str, tensor2list\r\n\r\n~/.local/lib/python3.10/site-packages/nemo/collections/nlp/parts/utils_funcs.py in <module>\r\n 35 from torch import Tensor\r\n 36 \r\n---> 37 from nemo.collections.nlp.modules.common.megatron.utils import erf_gelu\r\n 38 from nemo.collections.nlp.modules.common.megatron.utils import openai_gelu as openai_gelu_func\r\n 39 from nemo.collections.nlp.modules.common.megatron.utils import squared_relu\r\n\r\n~/.local/lib/python3.10/site-packages/nemo/collections/nlp/modules/__init__.py in <module>\r\n 14 \r\n 15 \r\n---> 16 from nemo.collections.nlp.modules.common import (\r\n 17 AlbertEncoder,\r\n 18 BertEncoder,\r\n\r\n~/.local/lib/python3.10/site-packages/nemo/collections/nlp/modules/common/__init__.py in <module>\r\n 16 \r\n 17 from nemo.collections.nlp.modules.common.bert_module import BertModule\r\n---> 18 from nemo.collections.nlp.modules.common.huggingface import (\r\n 19 AlbertEncoder,\r\n 20 BertEncoder,\r\n\r\n~/.local/lib/python3.10/site-packages/nemo/collections/nlp/modules/common/huggingface/__init__.py in <module>\r\n 17 from nemo.collections.nlp.modules.common.huggingface.camembert import CamembertEncoder\r\n 18 from nemo.collections.nlp.modules.common.huggingface.distilbert import DistilBertEncoder\r\n---> 19 from nemo.collections.nlp.modules.common.huggingface.huggingface_utils import (\r\n 20 get_huggingface_lm_model,\r\n 21 get_huggingface_pretrained_lm_models_list,\r\n\r\n~/.local/lib/python3.10/site-packages/nemo/collections/nlp/modules/common/huggingface/huggingface_utils.py in <module>\r\n 16 from typing import List, Optional\r\n 17 \r\n---> 18 from transformers import (\r\n 19 ALBERT_PRETRAINED_MODEL_ARCHIVE_LIST,\r\n 20 BERT_PRETRAINED_MODEL_ARCHIVE_LIST,\r\n\r\nImportError: cannot import name 'ALBERT_PRETRAINED_MODEL_ARCHIVE_LIST' from 'transformers' (/home/subramanyam/.local/lib/python3.10/site-packages/transformers/__init__.py)\r\n\r\nI upgrade transformers version to 4.41.2 but it does not importing the nlp collections of nemo-toolkit.\r\nPlease help me to resolve this issue also\r\n\r\n\r\n",
"You need to reduce your HF transformers version, not increase it. 4.40.0 is the supported version for 2.0 rc0",
"ok i will try and install it\r\n",
"ImportError: cannot import name 'packaging' from 'pkg_resources' (/home/subramanyam/.local/lib/python3.10/site-packages/pkg_resources/__init__.py)\r\nnow i got this error i also updated the package version into 24.1 and setup tools version but iam getting the same error",
"Please see the readme - you need to install Cython and packaging before installing Nemo ",
"Please do not update random libraries, we do not support setup tools 70.x, you'll need to downgrade that first to 69 or lower ",
"ok i already installed cython and packaging before installing the nemo toolkit but if i run the command \r\nimport nemo.collections.nlp as nlp\r\nit shows this error\r\nImportError: cannot import name 'packaging' from 'pkg_resources' (/home/subramanyam/.local/lib/python3.10/site-packages/pkg_resources/__init__.py)\r\niam using jupyter notebook",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-06T10:00:36 | 2024-08-10T01:51:42 | 2024-08-10T01:51:41 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I have tried to install nemo_toolkit==2.0.0.rc0
but it shows error:
RuntimeError: causal_conv1d is only supported on CUDA 11.6 and above. Note: make sure nvcc has a supported version by running nvcc -V.
torch.__version__ = 2.3.0+cu121
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
can anyone help me to resolve this issue?? | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9397/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9397/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9396 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9396/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9396/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9396/events | https://github.com/NVIDIA/NeMo/pull/9396 | 2,337,206,334 | PR_kwDOC_bI7s5xoAez | 9,396 | LoRA for MoE Layer | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-06T02:53:32 | 2024-06-11T19:55:02 | 2024-06-11T19:55:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9396",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9396",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9396.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9396.patch",
"merged_at": "2024-06-11T19:55:01"
} | # What does this PR do ?
Add LoRA for MoE layer (e.g. Mixtral model).
This does not necessarily improve the convergence of LoRA on Mixtral. However, it is important for QLoRA to achieve the best memory savings
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* The following flag now works for MoE models:
```bash
model.peft.lora_tuning.target_modules=[all]
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9396/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9396/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9395 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9395/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9395/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9395/events | https://github.com/NVIDIA/NeMo/issues/9395 | 2,337,033,435 | I_kwDOC_bI7s6LTEzb | 9,395 | video input 'image_aspect_ratio=pad' not work | {
"login": "Slyne",
"id": 6286804,
"node_id": "MDQ6VXNlcjYyODY4MDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6286804?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Slyne",
"html_url": "https://github.com/Slyne",
"followers_url": "https://api.github.com/users/Slyne/followers",
"following_url": "https://api.github.com/users/Slyne/following{/other_user}",
"gists_url": "https://api.github.com/users/Slyne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Slyne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Slyne/subscriptions",
"organizations_url": "https://api.github.com/users/Slyne/orgs",
"repos_url": "https://api.github.com/users/Slyne/repos",
"events_url": "https://api.github.com/users/Slyne/events{/privacy}",
"received_events_url": "https://api.github.com/users/Slyne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days."
] | 2024-06-06T00:20:58 | 2024-07-06T05:30:41 | 2024-07-06T05:30:41 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Hi,
Please check the this [line](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/multimodal/data/neva/neva_dataset.py#L980) and this [line](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/multimodal/parts/utils.py#L527)
The input to the `expand2square` is expected to be an image object but now in the video preprocessing part, it's a list of images so it will raise issue.
| {
"login": "Slyne",
"id": 6286804,
"node_id": "MDQ6VXNlcjYyODY4MDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6286804?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Slyne",
"html_url": "https://github.com/Slyne",
"followers_url": "https://api.github.com/users/Slyne/followers",
"following_url": "https://api.github.com/users/Slyne/following{/other_user}",
"gists_url": "https://api.github.com/users/Slyne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Slyne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Slyne/subscriptions",
"organizations_url": "https://api.github.com/users/Slyne/orgs",
"repos_url": "https://api.github.com/users/Slyne/repos",
"events_url": "https://api.github.com/users/Slyne/events{/privacy}",
"received_events_url": "https://api.github.com/users/Slyne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9395/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9395/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9394 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9394/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9394/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9394/events | https://github.com/NVIDIA/NeMo/issues/9394 | 2,336,960,165 | I_kwDOC_bI7s6LSy6l | 9,394 | Why isn't FSDP supported by DistributedCheckpointIO? | {
"login": "crazyguitar",
"id": 3689606,
"node_id": "MDQ6VXNlcjM2ODk2MDY=",
"avatar_url": "https://avatars.githubusercontent.com/u/3689606?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/crazyguitar",
"html_url": "https://github.com/crazyguitar",
"followers_url": "https://api.github.com/users/crazyguitar/followers",
"following_url": "https://api.github.com/users/crazyguitar/following{/other_user}",
"gists_url": "https://api.github.com/users/crazyguitar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/crazyguitar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/crazyguitar/subscriptions",
"organizations_url": "https://api.github.com/users/crazyguitar/orgs",
"repos_url": "https://api.github.com/users/crazyguitar/repos",
"events_url": "https://api.github.com/users/crazyguitar/events{/privacy}",
"received_events_url": "https://api.github.com/users/crazyguitar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"I'm also interested in this.",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-05T22:56:05 | 2024-08-16T01:51:39 | 2024-08-16T01:51:38 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi team,
Thank you for your efforts in adding async_save support to DistributedCheckpointIO. I am currently testing async_save with DistributedCheckpointIO and found that it only supports [non-FSDP MCore models](https://github.com/NVIDIA/NeMo/blob/ae06138a5012375e39a93b512d76b5fbc4d8c229/nemo/collections/nlp/parts/megatron_trainer_builder.py#L145). I have reviewed the source code, including [Megatron-LM](https://github.com/NVIDIA/Megatron-LM), but I am unclear on why FSDP is not supported by DistributedCheckpointIO. Could the team provide more information regarding this limitation? Thank you. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9394/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9394/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9393 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9393/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9393/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9393/events | https://github.com/NVIDIA/NeMo/pull/9393 | 2,336,640,137 | PR_kwDOC_bI7s5xmDl0 | 9,393 | Update README.rst | {
"login": "jgerh",
"id": 163925524,
"node_id": "U_kgDOCcVOFA",
"avatar_url": "https://avatars.githubusercontent.com/u/163925524?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jgerh",
"html_url": "https://github.com/jgerh",
"followers_url": "https://api.github.com/users/jgerh/followers",
"following_url": "https://api.github.com/users/jgerh/following{/other_user}",
"gists_url": "https://api.github.com/users/jgerh/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jgerh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jgerh/subscriptions",
"organizations_url": "https://api.github.com/users/jgerh/orgs",
"repos_url": "https://api.github.com/users/jgerh/repos",
"events_url": "https://api.github.com/users/jgerh/events{/privacy}",
"received_events_url": "https://api.github.com/users/jgerh/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-06-05T19:09:01 | 2024-06-05T22:50:25 | 2024-06-05T22:13:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9393",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9393",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9393.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9393.patch",
"merged_at": "2024-06-05T22:13:17"
} | Revised content per https://gitlab-master.nvidia.com/nemo-framework-tme/documentation/-/issues/25. Also removed reference to NIMs in LLMs and MMs Deployment and Optimization. It should be NVIDIA NeMo Microservices and not NIM. Removed nemo:24.03.framework and nemo:24.01.speech in Docker Containers section and replaced with 24.05 . Please verify all changes.
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9393/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9393/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9392 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9392/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9392/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9392/events | https://github.com/NVIDIA/NeMo/pull/9392 | 2,336,615,187 | PR_kwDOC_bI7s5xl-DL | 9,392 | PeFT fix for distOpt | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This is now ready; Tested DDP, TP=2, PP=2 apex & distOpt.\r\nThere was a small bug in get_model_module_list that was also fixed.",
"CI passed: https://github.com/NVIDIA/NeMo/actions/runs/9422621053"
] | 2024-06-05T18:54:02 | 2024-06-10T01:47:22 | 2024-06-10T01:47:21 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9392",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9392",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9392.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9392.patch",
"merged_at": "2024-06-10T01:47:21"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9392/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9392/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9391 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9391/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9391/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9391/events | https://github.com/NVIDIA/NeMo/pull/9391 | 2,336,389,190 | PR_kwDOC_bI7s5xlLx2 | 9,391 | Riva and k2 ASR WFST decoding (2) | {
"login": "GNroy",
"id": 16904306,
"node_id": "MDQ6VXNlcjE2OTA0MzA2",
"avatar_url": "https://avatars.githubusercontent.com/u/16904306?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/GNroy",
"html_url": "https://github.com/GNroy",
"followers_url": "https://api.github.com/users/GNroy/followers",
"following_url": "https://api.github.com/users/GNroy/following{/other_user}",
"gists_url": "https://api.github.com/users/GNroy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/GNroy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GNroy/subscriptions",
"organizations_url": "https://api.github.com/users/GNroy/orgs",
"repos_url": "https://api.github.com/users/GNroy/repos",
"events_url": "https://api.github.com/users/GNroy/events{/privacy}",
"received_events_url": "https://api.github.com/users/GNroy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"@GNroy, can you please provide the instructions for testing this PR? \r\nA model + test set + LM/text to build LM with the sequence of required operations to build graphs/start decoding (both k2 and Riva).\r\nIt may also be worth providing such information for users (make a section in the documentation).",
"Please, also fix CodeQL suggestions - most of them seems to be valuable (e.g., `'except' clause does nothing but pass and there is no explanatory comment.`, `This 'lambda' is just a simple wrapper around a callable object. Use that object directly.`, `Variable wfst_path is not used.` etc.)"
] | 2024-06-05T16:51:17 | 2024-08-22T17:04:17 | 2024-08-21T12:46:20 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9391",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9391",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9391.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9391.patch",
"merged_at": "2024-08-21T12:46:20"
} | # What does this PR do ?
Adds Riva and k2 WFST decoding options for ASR inference.
**Collection**: [ASR]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9391/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9391/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9390 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9390/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9390/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9390/events | https://github.com/NVIDIA/NeMo/pull/9390 | 2,336,304,320 | PR_kwDOC_bI7s5xk5DX | 9,390 | Force diarizer to use CUDA if cuda is available and if device=None. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-05T16:05:39 | 2024-06-06T00:17:39 | 2024-06-06T00:17:38 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9390",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9390",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9390.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9390.patch",
"merged_at": "2024-06-06T00:17:38"
} | # What does this PR do ?
This PR changes clustering_diarizer.py code to use CUDA if cuda is available and if device=None.
**Collection**:
asr
# Changelog
` if speaker_model is not None:
if self._cfg.device is None and torch.cuda.is_available():
self._speaker_model = speaker_model.to(torch.device('cuda'))
else:
self._speaker_model = speaker_model
`
# Usage
Use diarizaiton examples
```
Run the entire speaker diarization pipeline: VAD, clustering diarizer for initializing clustering then Multi-scale Diarization Decoder (MSDD).
python multiscale_diar_decoder_infer.py --config-path='../conf/inference' --config-name='diar_infer_telephonic.yaml' \
diarizer.vad.model_path=<NeMo VAD model path> \
diarizer.msdd_model.model_path=<NeMo MSDD model path> \
diarizer.oracle_vad=False \
diarizer.manifest_filepath=<test_manifest> \
diarizer.out_dir=<test_temp_dir> \
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in NeMo ASR
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9390/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9390/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9389 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9389/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9389/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9389/events | https://github.com/NVIDIA/NeMo/pull/9389 | 2,336,105,092 | PR_kwDOC_bI7s5xkNBL | 9,389 | [NeMo-UX] Removing un-used ModelConfig class | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-05T14:37:24 | 2024-06-07T00:29:28 | 2024-06-07T00:29:28 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9389",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9389",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9389.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9389.patch",
"merged_at": "2024-06-07T00:29:28"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9389/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9389/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9388 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9388/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9388/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9388/events | https://github.com/NVIDIA/NeMo/pull/9388 | 2,336,049,541 | PR_kwDOC_bI7s5xkAsX | 9,388 | add support for new mcore ds features | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@dimapihtar - can you add\r\ndrop_last_partial_validation_sequence = True and add_extra_token_to_sequence = True to a github actions test?",
"> @dimapihtar - can you add drop_last_partial_validation_sequence = True and add_extra_token_to_sequence = True to a github actions test?\r\n\r\n@ShriyaPalsamudram we have these values as True by default so I think all the tests are running in this way.",
"One necessary consistency test will be to measure validation eval between legacy and mcore code paths, with all options turned on to eval on the entire validation dataset\r\n\r\nYou'll have to make sure that the loss and ppl computation is able to handle partial batches and partial sequences. NeMo already does this at least for the legacy code path, but you'll want to make sure there aren't any breaking changes."
] | 2024-06-05T14:15:14 | 2024-06-11T15:27:08 | 2024-06-11T15:27:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9388",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9388",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9388.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9388.patch",
"merged_at": "2024-06-11T15:27:07"
} | # What does this PR do ?
Adds new mcore dataset features to NeMo.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9388/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9388/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9387 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9387/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9387/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9387/events | https://github.com/NVIDIA/NeMo/pull/9387 | 2,336,005,149 | PR_kwDOC_bI7s5xj24G | 9,387 | [NeMo-UX] Integrating mcore's DistributedDataParallel into MegatronStrategy | {
"login": "marcromeyn",
"id": 3015785,
"node_id": "MDQ6VXNlcjMwMTU3ODU=",
"avatar_url": "https://avatars.githubusercontent.com/u/3015785?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/marcromeyn",
"html_url": "https://github.com/marcromeyn",
"followers_url": "https://api.github.com/users/marcromeyn/followers",
"following_url": "https://api.github.com/users/marcromeyn/following{/other_user}",
"gists_url": "https://api.github.com/users/marcromeyn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/marcromeyn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcromeyn/subscriptions",
"organizations_url": "https://api.github.com/users/marcromeyn/orgs",
"repos_url": "https://api.github.com/users/marcromeyn/repos",
"events_url": "https://api.github.com/users/marcromeyn/events{/privacy}",
"received_events_url": "https://api.github.com/users/marcromeyn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-05T13:57:11 | 2024-06-10T17:06:08 | 2024-06-10T17:06:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9387",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9387",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9387.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9387.patch",
"merged_at": "2024-06-10T17:06:08"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9387/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9387/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9386 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9386/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9386/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9386/events | https://github.com/NVIDIA/NeMo/pull/9386 | 2,335,783,297 | PR_kwDOC_bI7s5xjFYB | 9,386 | fix tts sample inputs order | {
"login": "mohnishparmar",
"id": 109233781,
"node_id": "U_kgDOBoLGdQ",
"avatar_url": "https://avatars.githubusercontent.com/u/109233781?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mohnishparmar",
"html_url": "https://github.com/mohnishparmar",
"followers_url": "https://api.github.com/users/mohnishparmar/followers",
"following_url": "https://api.github.com/users/mohnishparmar/following{/other_user}",
"gists_url": "https://api.github.com/users/mohnishparmar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mohnishparmar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mohnishparmar/subscriptions",
"organizations_url": "https://api.github.com/users/mohnishparmar/orgs",
"repos_url": "https://api.github.com/users/mohnishparmar/repos",
"events_url": "https://api.github.com/users/mohnishparmar/events{/privacy}",
"received_events_url": "https://api.github.com/users/mohnishparmar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-05T12:32:31 | 2024-06-28T01:48:51 | 2024-06-28T01:48:50 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9386",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9386",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9386.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9386.patch",
"merged_at": null
} | # What does this PR do ?
Fixes Sample input order needed for export via torchscript.
**Collection**: [TTS]
# Changelog
Fix sample rate order for torchscript export
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9386/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9386/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9385 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9385/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9385/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9385/events | https://github.com/NVIDIA/NeMo/issues/9385 | 2,335,317,276 | I_kwDOC_bI7s6LMh0c | 9,385 | Unable to disable validation | {
"login": "liyier90",
"id": 56420072,
"node_id": "MDQ6VXNlcjU2NDIwMDcy",
"avatar_url": "https://avatars.githubusercontent.com/u/56420072?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/liyier90",
"html_url": "https://github.com/liyier90",
"followers_url": "https://api.github.com/users/liyier90/followers",
"following_url": "https://api.github.com/users/liyier90/following{/other_user}",
"gists_url": "https://api.github.com/users/liyier90/gists{/gist_id}",
"starred_url": "https://api.github.com/users/liyier90/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/liyier90/subscriptions",
"organizations_url": "https://api.github.com/users/liyier90/orgs",
"repos_url": "https://api.github.com/users/liyier90/repos",
"events_url": "https://api.github.com/users/liyier90/events{/privacy}",
"received_events_url": "https://api.github.com/users/liyier90/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-05T09:04:29 | 2024-07-13T01:49:11 | 2024-07-13T01:49:11 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Setting `model.data.splits_string` to `1000,0,0` results in `TypeError: object of type 'NoneType' has no len()`
**Steps/Code to reproduce bug**
1. Follow the steps in the [GPT model training tutorial](https://docs.nvidia.com/nemo-framework/user-guide/latest/nemotoolkit/nlp/nemo_megatron/gpt/gpt_training.html)
2. Change `model.data.splits_string=\'1000,0,0\'`
3. Run
**Expected behavior**
I should be able to perform pretraining without having to:
1. Provide validation dataset
2. Provide test dataset
3. Run validation
**Environment overview (please complete the following information)**
N/A. I was able to run the tutorial when `splits_string=\'980,10,10\'`.
**Additional context**
Traceback:
```
Traceback (most recent call last):
File "/data/projects/11003281/multi-node/cache/source_files/nemo/NeMo/examples/nlp/language_modeling/megatron_gpt_pretraining.py", line 42, in main
trainer.fit(model)
File "/data/projects/11003281/multi-node/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 544, in fit
call._call_and_handle_interrupt(
File "/data/projects/11003281/multi-node/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 43, in _call_and_handle_interrupt
return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs)
File "/data/projects/11003281/multi-node/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/strategies/launchers/subprocess_script.py", line 105, in launch
return function(*args, **kwargs)
File "/data/projects/11003281/multi-node/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 580, in _fit_impl
self._run(model, ckpt_path=ckpt_path)
File "/data/projects/11003281/multi-node/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 949, in _run
call._call_setup_hook(self) # allow user to set up LightningModule in accelerator environment
File "/data/projects/11003281/multi-node/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 94, in _call_setup_hook
_call_lightning_module_hook(trainer, "setup", stage=fn)
File "/data/projects/11003281/multi-node/envs/nemo/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 157, in _call_lightning_module_hook
output = fn(*args, **kwargs)
File "/data/projects/11003281/multi-node/cache/source_files/nemo/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py", line 1619, in setup
self.setup_validation_data(self.cfg.data)
File "/data/projects/11003281/multi-node/cache/source_files/nemo/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py", line 1645, in setup_validation_data
f'Setting up validation dataloader with len(len(self._validation_ds)): {len(self._validation_ds)} and consumed samples: {consumed_samples}'
TypeError: object of type 'NoneType' has no len()
``` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9385/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9385/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9384 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9384/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9384/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9384/events | https://github.com/NVIDIA/NeMo/pull/9384 | 2,335,194,891 | PR_kwDOC_bI7s5xhDXm | 9,384 | Huvu/rag pipeline citest | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-05T08:06:15 | 2024-06-06T17:00:50 | 2024-06-06T17:00:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9384",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9384",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9384.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9384.patch",
"merged_at": "2024-06-06T17:00:49"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9384/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9384/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9382 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9382/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9382/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9382/events | https://github.com/NVIDIA/NeMo/pull/9382 | 2,334,674,271 | PR_kwDOC_bI7s5xfStA | 9,382 | move load state dict after initialize parallel state in nlp_model | {
"login": "ryxli",
"id": 15115526,
"node_id": "MDQ6VXNlcjE1MTE1NTI2",
"avatar_url": "https://avatars.githubusercontent.com/u/15115526?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ryxli",
"html_url": "https://github.com/ryxli",
"followers_url": "https://api.github.com/users/ryxli/followers",
"following_url": "https://api.github.com/users/ryxli/following{/other_user}",
"gists_url": "https://api.github.com/users/ryxli/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ryxli/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ryxli/subscriptions",
"organizations_url": "https://api.github.com/users/ryxli/orgs",
"repos_url": "https://api.github.com/users/ryxli/repos",
"events_url": "https://api.github.com/users/ryxli/events{/privacy}",
"received_events_url": "https://api.github.com/users/ryxli/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Look good to me :+1:\r\n\r\nCan you apply a similar `sharded_state_dict` delay here? https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/nlp/parts/nlp_overrides.py#L947",
"@mikolajblaz \r\n> Look good to me 👍\r\n> \r\n> Can you apply a similar `sharded_state_dict` delay here? https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/nlp/parts/nlp_overrides.py#L947\r\n\r\nDone, thanks for review.\r\n",
"@ericharper or @mikolajblaz\r\n\r\nCould you add the `run CICD` label?"
] | 2024-06-05T01:06:29 | 2024-06-15T03:46:57 | 2024-06-15T01:08:24 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9382",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9382",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9382.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9382.patch",
"merged_at": "2024-06-15T01:08:24"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Move loading sharded state dict after initialize parallel state.
Addresses https://github.com/NVIDIA/NeMo/issues/8460
Notes:
- see the original issue for more details
- unsure if this is the correct approach, or if there are downstream impacts for this change
- This fix also resolves issues when running SFT using NeMo-Aligner (https://github.com/NVIDIA/NeMo-Aligner/blob/main/examples/nlp/gpt/train_gpt_sft.py) loading from a distributed ckpt directly instead of legacy or .nemo
```
Traceback (most recent call last):
File "train_sft.py", line 64, in main
ptl_model, updated_cfg = load_megatron_model(GPTSFTModel, cfg, trainer, additional_keys=additional_keys)
File "/workspace/NeMo/nemo/collections/nlp/models/nlp_model.py", line 397, in load_from_checkpoint
checkpoint = dist_checkpointing.load(sharded_state_dict=checkpoint, checkpoint_dir=checkpoint_dir)
File "/workspace/Megatron-LM/megatron/core/dist_checkpointing/serialization.py", line 133, in load
validate_sharding_integrity(nested_values(sharded_state_dict))
File "/workspace/Megatron-LM/megatron/core/dist_checkpointing/serialization.py", line 437, in validate_sharding_integrity
_validate_sharding_for_key(shardings)
File "/workspace/Megatron-LM/megatron/core/dist_checkpointing/serialization.py", line 475, in _validate_sharding_for_key
raise CheckpointingException(f'Invalid access pattern for {rank_sharding[0][1]}')
megatron.core.dist_checkpointing.core.CheckpointingException: Invalid access pattern for ShardedTensor(key='model.embedding.word_embeddings.weight')
```
**Collection**: [Note which collection this PR will affect]
nlp/language_modeling
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
For the nemo aligner SFT use case:
1. change the implementation of nemo_aligner.models.nlp.gpt.gpt_sft_model.GPTSFTModel like so
```python
from omegaconf import DictConfig
from pytorch_lightning.trainer.trainer import Trainer
from nemo_aligner.models.nlp.gpt.gpt_sft_model import GPTSFTModel
from torch.nn.modules.module import Module
class _GPTSFTModel(GPTSFTModel):
"""
Megatron GPT Supervised Fine-Tuning, support load from mcore distributed ckpt.
"""
def __init__(self, cfg: DictConfig, trainer: Trainer):
super().__init__(cfg, trainer=trainer)
def load_state_dict(self, state_dict, strict: bool = True):
if self.use_peft and self.setup_complete:
super().load_state_dict(state_dict, strict=strict)
else:
if self.mcore_gpt and not self.use_fsdp:
# mcore distributed checkpoint
# we defer loading the state_dict until the class has been initialized
return Module.load_state_dict(self, state_dict, strict=False)
else:
super().load_state_dict(state_dict, strict=strict)
```
2. Load the checkpoint overriding the files like so
```python
from fsspec.implementations.local import LocalFileSystem
def load_from_checkpoint_dir(cfg, trainer, modify_confg_fn, checkpoint_logger=None):
cls = _GPTSFTModel # from above
app_state = AppState()
if cfg.model.tensor_model_parallel_size > 1 or cfg.model.pipeline_model_parallel_size > 1:
app_state.model_parallel_size = (
cfg.model.tensor_model_parallel_size * cfg.model.pipeline_model_parallel_size * cfg.get("expert_model_parallel_size", 1)
)
app_state.tensor_model_parallel_size = cfg.model.tensor_model_parallel_size
app_state.pipeline_model_parallel_size = cfg.model.pipeline_model_parallel_size
app_state.expert_model_parallel_size = cfg.get("expert_model_parallel_size", 1)
(
app_state.tensor_model_parallel_rank,
app_state.pipeline_model_parallel_rank,
app_state.expert_model_parallel_rank,
app_state.model_parallel_size,
app_state.data_parallel_size,
app_state.pipeline_model_parallel_split_rank,
app_state.virtual_pipeline_model_parallel_rank,
) = fake_initialize_model_parallel(
world_size=app_state.model_parallel_size,
rank=trainer.global_rank,
tensor_model_parallel_size_=cfg.model.tensor_model_parallel_size,
pipeline_model_parallel_size_=cfg.model.pipeline_model_parallel_size,
pipeline_model_parallel_split_rank_=cfg.model.get("pipeline_model_parallel_split_rank", None),
expert_model_parallel_size_=cfg.get("expert_model_parallel_size", 1),
)
checkpoint_path = os.path.join(
cfg.model.pretrained_checkpoint.checkpoint_dir,
cfg.model.pretrained_checkpoint.checkpoint_name,
)
if not os.path.isdir(checkpoint_path):
# legacy checkpoint needs model parallel rank injection
checkpoint_path = inject_model_parallel_rank(checkpoint_path)
fs = LocalFileSystem()
with fs.open(cfg.model.pretrained_checkpoint.hparams_file, "r") as fin:
hparams_file = OmegaConf.load(fin)
gpt_cfg = modify_confg_fn(hparams_file.cfg, cfg, add_cfg_to_tree=True)
with tempfile.NamedTemporaryFile(suffix=".yaml") as f:
OmegaConf.save(config=gpt_cfg, f=f.name)
model = cls.load_from_checkpoint(checkpoint_path=checkpoint_path, trainer=trainer, hparams_file=f.name)
return model, gpt_cfg
```
3. in the config, resume the training from a dist ckpt dir:
```
model:
pretrained_checkpoint:
checkpoint_dir: /experiments/example_gpt_model_A/checkpoints/
checkpoint_name: megatron_gpt--val_loss=1.23-step=5000-consumed_samples=100000.0
hparams_file: /hparams.yaml
```
* this hparams file, had to manually create as by default hparams.yaml is not saved with dist ckpt format last I checked. It seems like the behavior is to only create and store with .nemo or the legacy pp tp partition format with the PTL callback. Unrelated, but it might be nice to also save the hparams.yaml file when saving a distributed ckpt (not with .nemo)
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9382/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9382/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9381 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9381/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9381/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9381/events | https://github.com/NVIDIA/NeMo/pull/9381 | 2,334,666,717 | PR_kwDOC_bI7s5xfQ7W | 9,381 | vLLM Export Support | {
"login": "apanteleev",
"id": 11079788,
"node_id": "MDQ6VXNlcjExMDc5Nzg4",
"avatar_url": "https://avatars.githubusercontent.com/u/11079788?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/apanteleev",
"html_url": "https://github.com/apanteleev",
"followers_url": "https://api.github.com/users/apanteleev/followers",
"following_url": "https://api.github.com/users/apanteleev/following{/other_user}",
"gists_url": "https://api.github.com/users/apanteleev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/apanteleev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/apanteleev/subscriptions",
"organizations_url": "https://api.github.com/users/apanteleev/orgs",
"repos_url": "https://api.github.com/users/apanteleev/repos",
"events_url": "https://api.github.com/users/apanteleev/events{/privacy}",
"received_events_url": "https://api.github.com/users/apanteleev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-05T01:03:04 | 2024-07-01T15:43:23 | 2024-06-25T17:27:37 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9381",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9381",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9381.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9381.patch",
"merged_at": "2024-06-25T17:27:37"
} | # What does this PR do ?
Implements export of NeMo checkpoints to vLLM 0.5.0 and deployment of vLLM engines on the Triton server.
**Collection**: NLP
# Changelog
- Added `nemo.export.vllm` package that implements the export and deployment functionality, primarily with the `nemo.export.vllm.Exporter` class.
- Added script `scripts/deploy/nlp/deploy_triton_vllm.py` to use the new Exporter.
- Removed the shortcut `nemo.export.TensorRTLLM` to avoid initializing TRT-LLM when anything is accessed in the `nemo.export` package, use `nemo.export.tensorrt_llm.TensorRTLLM` instead.
- Moved the `sentencepiece_tokenizer.py` module from `nemo.export.tensorrt_llm.nemo` into `nemo.export` for the same reason.
# Supported Models
- LLAMA2
- Mistral
- Mixtral (should work but I couldn't test it due to GPU OOM)
- Gemma
- StarCoder2
# Usage
```sh
deploy_triton_vllm.py --nemo_checkpoint <path/to/checkpoint.nemo> --model_type llama --triton_model_name LLAMA --num_gpus 1
```
See `nemo/export/vllm/exporter.py` for inline documentation on the Exporter class.
# PR Type
- [X] New Feature
# Known issues
- Currently, vLLM and TRT-LLM cannot be installed in the same container because they require conflicting versions of various packages. Also, installing vLLM breaks something in the `transformer_engine` module, requiring it to be uninstalled.
- Fine-tuning is not supported currently, neither P-tuning nor LoRA | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9381/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9381/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9380 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9380/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9380/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9380/events | https://github.com/NVIDIA/NeMo/pull/9380 | 2,334,554,955 | PR_kwDOC_bI7s5xe3e4 | 9,380 | Force diarizer to use CUDA if cuda is available and if device=None. | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-04T23:40:45 | 2024-06-05T16:05:16 | 2024-06-05T16:05:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9380",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9380",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9380.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9380.patch",
"merged_at": "2024-06-05T16:05:15"
} | # What does this PR do ?
This PR changes clustering_diarizer.py code to use CUDA if cuda is available and if device=None.
**Collection**:
asr
# Changelog
` if speaker_model is not None:
if self._cfg.device is None and torch.cuda.is_available():
self._speaker_model = speaker_model.to(torch.device('cuda'))
else:
self._speaker_model = speaker_model
`
# Usage
Use diarizaiton examples
```
Run the entire speaker diarization pipeline: VAD, clustering diarizer for initializing clustering then Multi-scale Diarization Decoder (MSDD).
python multiscale_diar_decoder_infer.py --config-path='../conf/inference' --config-name='diar_infer_telephonic.yaml' \
diarizer.vad.model_path=<NeMo VAD model path> \
diarizer.msdd_model.model_path=<NeMo MSDD model path> \
diarizer.oracle_vad=False \
diarizer.manifest_filepath=<test_manifest> \
diarizer.out_dir=<test_temp_dir> \
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in NeMo ASR
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9380/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9380/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9379 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9379/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9379/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9379/events | https://github.com/NVIDIA/NeMo/pull/9379 | 2,334,514,043 | PR_kwDOC_bI7s5xeueA | 9,379 | Fix null/None truncation field with extra generating tokens | {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-06-04T22:55:51 | 2024-07-19T18:33:51 | 2024-07-19T18:33:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9379",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9379",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9379.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9379.patch",
"merged_at": "2024-07-19T18:33:49"
} | # What does this PR do ?
When truncation field is None, we will truncate our inputs from right or left. But we need to leave spaces for generating tokens.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hsiehjackson",
"id": 37269846,
"node_id": "MDQ6VXNlcjM3MjY5ODQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/37269846?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hsiehjackson",
"html_url": "https://github.com/hsiehjackson",
"followers_url": "https://api.github.com/users/hsiehjackson/followers",
"following_url": "https://api.github.com/users/hsiehjackson/following{/other_user}",
"gists_url": "https://api.github.com/users/hsiehjackson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hsiehjackson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hsiehjackson/subscriptions",
"organizations_url": "https://api.github.com/users/hsiehjackson/orgs",
"repos_url": "https://api.github.com/users/hsiehjackson/repos",
"events_url": "https://api.github.com/users/hsiehjackson/events{/privacy}",
"received_events_url": "https://api.github.com/users/hsiehjackson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9379/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9379/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9378 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9378/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9378/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9378/events | https://github.com/NVIDIA/NeMo/pull/9378 | 2,334,343,963 | PR_kwDOC_bI7s5xeIn2 | 9,378 | Make a backward compatibility for old MSDD configs in label models | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-04T20:48:23 | 2024-06-05T16:57:20 | 2024-06-05T16:57:19 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9378",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9378",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9378.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9378.patch",
"merged_at": "2024-06-05T16:57:19"
} | # What does this PR do ?
This PR is revision of the old PR https://github.com/NVIDIA/NeMo/pull/9182.
TitaNet model was updated but some previous configurations were not.
This PR provides support for prevevious msdd configuration versions.
**Collection**: SD
# Changelog
- Catch the `_target_` code in newer titanet versions, which is not available in previous versions.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9378/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9378/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9377 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9377/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9377/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9377/events | https://github.com/NVIDIA/NeMo/pull/9377 | 2,334,336,060 | PR_kwDOC_bI7s5xeG4N | 9,377 | Make a backward compatibility for old MSDD configs in label models | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-04T20:42:41 | 2024-06-04T20:48:02 | 2024-06-04T20:48:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9377",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9377",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9377.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9377.patch",
"merged_at": "2024-06-04T20:48:02"
} | # What does this PR do ?
This PR is revision of the old PR https://github.com/NVIDIA/NeMo/pull/9182.
TitaNet model was updated but some previous configurations were not.
This PR provides support for prevevious msdd configuration versions.
**Collection**: SD
# Changelog
- Catch the `_target_` code in newer titanet versions, which is not available in previous versions.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9377/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9377/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9376 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9376/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9376/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9376/events | https://github.com/NVIDIA/NeMo/pull/9376 | 2,334,163,710 | PR_kwDOC_bI7s5xdhPl | 9,376 | fix fp16 precision issue | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-04T18:48:16 | 2024-06-05T16:06:17 | 2024-06-05T16:06:17 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9376",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9376",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9376.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9376.patch",
"merged_at": "2024-06-05T16:06:17"
} | # What does this PR do ?
fp16 precision fix. Fixes this error when using mcore=True & precision is fp16:
`RuntimeError: expected scalar type Half but found Float`
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9376/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9376/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9375 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9375/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9375/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9375/events | https://github.com/NVIDIA/NeMo/pull/9375 | 2,333,982,442 | PR_kwDOC_bI7s5xc5iB | 9,375 | Github Action test for RAG Pipeline | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-04T16:58:27 | 2024-06-05T08:05:58 | 2024-06-05T08:05:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9375",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9375",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9375.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9375.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9375/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9375/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9372 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9372/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9372/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9372/events | https://github.com/NVIDIA/NeMo/pull/9372 | 2,333,246,781 | PR_kwDOC_bI7s5xaYeo | 9,372 | add reset learning rate functionality | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"- Use case 1: `reset_lr=True, reset_lr_steps=False`\r\nWe want to reset_lr to init_lr (0 or optim.lr) in order to train it on another data and don't care about learning rate's max number of steps.\r\n\r\n- Use case 2: `reset_lr=True, reset_lr_steps=False` \r\nWe want to reset_lr and we also want to reach min_lr by the end of the training by using the same trainer.max_steps as for previous run of this checkpoint. So in this case we want to update lr's max_steps and decay_steps in the next way:\r\n`max_steps = max_steps - consumed_steps,\r\ndecay_steps = decay_steps - consumed_steps`\r\nwhere `conusmed_steps` is the number of steps already completed at the checkpoint.\r\nExample:\r\n\r\n\r\n"
] | 2024-06-04T11:11:06 | 2024-06-27T09:58:04 | 2024-06-27T09:58:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9372",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9372",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9372.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9372.patch",
"merged_at": "2024-06-27T09:58:02"
} | # What does this PR do ?
Adds reset learning rate functionality.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9372/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9372/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9371 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9371/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9371/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9371/events | https://github.com/NVIDIA/NeMo/pull/9371 | 2,332,602,747 | PR_kwDOC_bI7s5xYMaG | 9,371 | Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer. (#9347) | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-04T05:43:54 | 2024-06-04T05:59:36 | 2024-06-04T05:59:35 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9371",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9371",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9371.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9371.patch",
"merged_at": "2024-06-04T05:59:35"
} | * Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer.
decoder_lengths is allowed to be on CPU even when decoder_output is on GPU. This matches the behavior of GreedyCTCInfer. Even though that behavior is unintentional, there is code depending on that behavior, including our jupyter notebooks.
Signed-off-by: Daniel Galvez <[email protected]>
* Apply isort and black reformatting
Signed-off-by: titu1994 <[email protected]>
---------
Signed-off-by: Daniel Galvez <[email protected]>
Signed-off-by: titu1994 <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: titu1994 <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
(cherry picked from commit aed9d071c700080b3eb024e8a5d7f091f20f0183)
# What does this PR do ?
Information is here - https://github.com/NVIDIA/NeMo/pull/9347
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9371/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9371/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9370 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9370/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9370/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9370/events | https://github.com/NVIDIA/NeMo/pull/9370 | 2,332,434,856 | PR_kwDOC_bI7s5xXnUp | 9,370 | fix typo infer_seq_lenght -> infer_seq_length | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-06-04T03:15:52 | 2024-06-05T16:17:30 | 2024-06-05T16:17:29 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9370",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9370",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9370.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9370.patch",
"merged_at": "2024-06-05T16:17:29"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9370/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9370/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9369 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9369/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9369/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9369/events | https://github.com/NVIDIA/NeMo/pull/9369 | 2,332,115,431 | PR_kwDOC_bI7s5xWhv3 | 9,369 | Fix conv1d package in r2.0.0rc0 | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [] | 2024-06-03T21:49:07 | 2024-06-03T23:06:24 | 2024-06-03T23:06:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9369",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9369",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9369.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9369.patch",
"merged_at": "2024-06-03T23:06:24"
} | Fix conv1d package in r2.0.0rc0 | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9369/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9369/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9368 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9368/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9368/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9368/events | https://github.com/NVIDIA/NeMo/pull/9368 | 2,331,905,705 | PR_kwDOC_bI7s5xVzCh | 9,368 | Edits for syntax, missing words in tutorials | {
"login": "smythp",
"id": 8249704,
"node_id": "MDQ6VXNlcjgyNDk3MDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/8249704?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/smythp",
"html_url": "https://github.com/smythp",
"followers_url": "https://api.github.com/users/smythp/followers",
"following_url": "https://api.github.com/users/smythp/following{/other_user}",
"gists_url": "https://api.github.com/users/smythp/gists{/gist_id}",
"starred_url": "https://api.github.com/users/smythp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/smythp/subscriptions",
"organizations_url": "https://api.github.com/users/smythp/orgs",
"repos_url": "https://api.github.com/users/smythp/repos",
"events_url": "https://api.github.com/users/smythp/events{/privacy}",
"received_events_url": "https://api.github.com/users/smythp/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"These are grammar, etc. fixes, this would be a pretty quick merge.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"Hey folks, think this wouldnt be much work to merge, just textual edits.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-03T19:43:07 | 2024-09-01T02:03:24 | 2024-09-01T02:03:24 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9368",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9368",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9368.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9368.patch",
"merged_at": null
} | # What does this PR do ?
This PR makes a few edits for syntax and missing words in the NeMo tutorials.
**tutorials**
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9368/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9368/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9367 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9367/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9367/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9367/events | https://github.com/NVIDIA/NeMo/pull/9367 | 2,331,769,913 | PR_kwDOC_bI7s5xVVVL | 9,367 | move AED chunked infer script | {
"login": "stevehuang52",
"id": 105218074,
"node_id": "U_kgDOBkWAGg",
"avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stevehuang52",
"html_url": "https://github.com/stevehuang52",
"followers_url": "https://api.github.com/users/stevehuang52/followers",
"following_url": "https://api.github.com/users/stevehuang52/following{/other_user}",
"gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}",
"starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions",
"organizations_url": "https://api.github.com/users/stevehuang52/orgs",
"repos_url": "https://api.github.com/users/stevehuang52/repos",
"events_url": "https://api.github.com/users/stevehuang52/events{/privacy}",
"received_events_url": "https://api.github.com/users/stevehuang52/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-03T18:17:59 | 2024-06-04T13:37:42 | 2024-06-04T13:37:42 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9367",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9367",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9367.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9367.patch",
"merged_at": "2024-06-04T13:37:41"
} | # What does this PR do ?
move AED chunked infer script
**Collection**: [asr]
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9367/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9367/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9366 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9366/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9366/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9366/events | https://github.com/NVIDIA/NeMo/pull/9366 | 2,331,753,643 | PR_kwDOC_bI7s5xVR0a | 9,366 | Fix prompt formatter's defaults=None case in multi-task model | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-03T18:08:02 | 2024-06-03T18:40:16 | 2024-06-03T18:40:16 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9366",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9366",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9366.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9366.patch",
"merged_at": "2024-06-03T18:40:16"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9366/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9366/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9365 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9365/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9365/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9365/events | https://github.com/NVIDIA/NeMo/pull/9365 | 2,331,660,014 | PR_kwDOC_bI7s5xU9a6 | 9,365 | Update Gemma conversion script | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-03T17:11:59 | 2024-06-03T22:28:10 | 2024-06-03T22:28:09 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9365",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9365",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9365.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9365.patch",
"merged_at": "2024-06-03T22:28:09"
} | # What does this PR do ?
Update and fix Gemma conversion script
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9365/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9365/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9364 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9364/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9364/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9364/events | https://github.com/NVIDIA/NeMo/pull/9364 | 2,331,626,131 | PR_kwDOC_bI7s5xU2AN | 9,364 | [Nemo CICD] Remove unnecessary commented out code | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-03T16:52:46 | 2024-06-03T16:53:40 | 2024-06-03T16:53:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9364",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9364",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9364.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9364.patch",
"merged_at": "2024-06-03T16:53:39"
} | Remove unnecessary commented out code | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9364/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9364/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9363 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9363/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9363/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9363/events | https://github.com/NVIDIA/NeMo/issues/9363 | 2,330,695,878 | I_kwDOC_bI7s6K65jG | 9,363 | Citrinet Training: Sentences are cut during prediction | {
"login": "huks0",
"id": 53513835,
"node_id": "MDQ6VXNlcjUzNTEzODM1",
"avatar_url": "https://avatars.githubusercontent.com/u/53513835?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huks0",
"html_url": "https://github.com/huks0",
"followers_url": "https://api.github.com/users/huks0/followers",
"following_url": "https://api.github.com/users/huks0/following{/other_user}",
"gists_url": "https://api.github.com/users/huks0/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huks0/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huks0/subscriptions",
"organizations_url": "https://api.github.com/users/huks0/orgs",
"repos_url": "https://api.github.com/users/huks0/repos",
"events_url": "https://api.github.com/users/huks0/events{/privacy}",
"received_events_url": "https://api.github.com/users/huks0/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | [
"Just saw this. Citrinet is a CTC model, did you check If your audio after 8x down sampling was shorter than the text transcript tokens in subword count ? That's often the reason for dropped words, especially because German transcripts are usually verbose and contain long words.\r\n\r\nId suggest trying a fast conformer transducer instead, 105M model should match the perf and memory of Citrinet 512 quite easily. "
] | 2024-06-03T09:55:25 | 2024-06-11T08:39:35 | 2024-06-11T08:35:52 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Currently I train a citrinet-512 Model. I copied the config from the example configs in here and didnt change them (https://github.com/NVIDIA/NeMo/tree/main/examples/asr/conf/citrinet). After detecting the issue, I also used another config of hugging face where someone finetuned a citrinet model (https://huggingface.co/neongeckocom/stt_de_citrinet_512_gamma_0_25). Both configs lead to the same problem. A lot of sentences are cut randomly during prediction like e.g.
```
[NeMo I 2024-06-02 22:59:01 wer_bpe:302] reference:so ließ es sich nicht ändern er blieb oberleutnant und um so lieber weil ihm herr bantes sein gewesener vormund längst den winzigen rest seines väterlichen erbteils ausgehändigt hatte und dieses längst schon zu allen heiden ausgewandert war
[NeMo I 2024-06-02 22:59:01 wer_bpe:303] predicted:so ließ es sich nicht ändern er blieb oberleutnant und um so lieber weil ihm herr bantes sein gewesener vormund längst winzigen rest seines väterlichen erbteils ausgehändigt hatte
[NeMo I 2024-06-02 22:59:03 wer_bpe:302] reference:nicht mehr seine was ist denn aus ihr geworden die war so alt und gebrechlich dass sie schließlich zusammenkrachte schon vor einer guten reihe von jahren
[NeMo I 2024-06-02 22:59:03 wer_bpe:303] predicted:nicht mehr seine was ist denn aus ihr geworden die war so alt und gebrechlich dass sie schließlich zu seinem
```
This happens right after a few epochs (2 epochs) and doesnt vanish even after 90 epochs. Its not a dataset specific issue, but occurs randomly for several datasets. It does not happen for every sample but for a relevant share of the data. It happens for training and evaluation. I tried to figure out what the problem relates to or if any parameter could solve it, but couldnt detect where this issue comes from.
**Steps/Code to reproduce bug**
Here is the config used:
```
name: &name "Citrinet-512 training"
model:
sample_rate: &sample_rate 16000
log_prediction: true
train_ds:
manifest_filepath: "/train_cleaned.json"
sample_rate: 16000
batch_size: 32
trim_silence: false
max_duration: 16.0
min_duration: 1.0
shuffle: true
use_start_end_token: false
num_workers: 8
pin_memory: true
is_tarred: false
tarred_audio_filepaths: null
shuffle_n: 2048
bucketing_strategy: 'synced_randomized'
bucketing_batch_size: null
validation_ds:
manifest_filepath: "/dev_cleaned.json"
sample_rate: 16000
batch_size: 32
shuffle: false
use_start_end_token: false
num_workers: 8
pin_memory: true
test_ds:
manifest_filepath: "/test_cleaned.json"
sample_rate: 16000
batch_size: 32
shuffle: false
use_start_end_token: false
num_workers: 8
pin_memory: true
model_defaults:
repeat: 5
dropout: 0.1
separable: true
se: true
se_context_size: -1
kernel_size_factor: 1
filters: 512
enc_final: 640
tokenizer:
dir: "tokenizer_spe_unigram_v1024" # path to directory which contains either tokenizer.model (bpe) or vocab.txt (for wpe)
type: "bpe" # Can be either bpe or wpe
preprocessor:
_target_: 'nemo.collections.asr.modules.AudioToMelSpectrogramPreprocessor'
sample_rate: 16000
normalize: 'per_feature'
window_size: 0.025
window_stride: 0.01
window: 'hann'
features: &n_mels 80
n_fft: 512
frame_splicing: 1
dither: 1e-05
pad_to: 16
stft_conv: false
spec_augment:
_target_: 'nemo.collections.asr.modules.SpectrogramAugmentation'
freq_masks: 2
time_masks: 5
freq_width: 27
time_width: 0.05
encoder:
_target_: nemo.collections.asr.modules.ConvASREncoder
feat_in: *n_mels
activation: relu
conv_mask: true
jasper:
- filters: 512
repeat: 1
kernel: [5]
stride: [1]
dilation: [1]
dropout: 0.0
residual: false
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [11]
stride: [2]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
stride_last: true
residual_mode: "stride_add"
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [13]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [15]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [17]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [19]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [21]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [13]
stride: [2] # *stride
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
stride_last: true
residual_mode: "stride_add"
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [15]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [17]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [19]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [21]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [23]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [25]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [25]
stride: [2] # stride
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
stride_last: true
residual_mode: "stride_add"
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [27]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [29]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [31]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [33]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [35]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [37]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: 512
repeat: ${model.model_defaults.repeat}
kernel: [39]
stride: [1]
dilation: [1]
dropout: ${model.model_defaults.dropout}
residual: true
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
- filters: ${model.model_defaults.enc_final}
repeat: 1
kernel: [41]
stride: [1]
dilation: [1]
dropout: 0.0
residual: false
separable: ${model.model_defaults.separable}
se: ${model.model_defaults.se}
se_context_size: ${model.model_defaults.se_context_size}
kernel_size_factor: ${model.model_defaults.kernel_size_factor}
decoder:
_target_: 'nemo.collections.asr.modules.ConvASRDecoder'
feat_in: 640
num_classes: 1024
vocabulary: []
optim:
name: 'novograd'
lr: 0.005
betas: [0.8, 0.25]
weight_decay: 0.0001
sched:
name: 'CosineAnnealing'
warmup_steps: null
warmup_ratio: 0.1
min_lr: 1e-05
last_epoch: -1
target: 'nemo.collections.asr.models.ctc_bpe_models.EncDecCTCModelBPE'
nemo_version: '1.12.0'
decoding:
strategy: 'greedy'
preserve_alignments: null
compute_timestamps: null
word_seperator: ' '
ctc_timestamp_type: 'all'
batch_dim_index: 0
greedy:
preserve_alignments: false
compute_timestamps: false
trainer:
devices: 2 # number of gpus
max_epochs: 100
max_steps: -1 # computed at runtime if not set
num_nodes: 1
accelerator: gpu
strategy: auto
accumulate_grad_batches: 1
enable_checkpointing: True # Provided by exp_manager
enable_progress_bar: True
logger: false # Provided by exp_manager
log_every_n_steps: 50 # Interval of logging.
val_check_interval: 1.0 # Set to 0.25 to check 4 times per epoch, or an int for number of iterations
check_val_every_n_epoch: 1
precision: 32
sync_batchnorm: false
benchmark: false # needs to be false for models with variable-length speech input as it slows down training
exp_manager:
exp_dir: null
name: *name
create_tensorboard_logger: false
create_checkpoint_callback: false
create_mlflow_logger: true
mlflow_logger_kwargs:
experiment_name: "training-citrinet-512"
tracking_uri: [removed, here would be the tracking uri]
checkpoint_callback_params:
monitor: "val_wer"
mode: "min"
save_top_k: 3
always_save_nemo: True #not tested yet, found this in a nemo repo
create_wandb_logger: false
wandb_logger_kwargs:
name: null
project: null
entity: null
resume_if_exists: false
resume_ignore_no_checkpoint: false
```
**Expected behavior**
I expect the training to predict the sentences correctly. For a lot of the sentences it works, for some the predictions are just cut even though the rest was welll detected. I believe this affects the loss and the WER and hence its hard to judge how good the model is actually.
**Environment overview (please complete the following information)**
On Azure I set up an environment and trained multi-gpu. NeMo is pip installed via nemo_toolkit==1.21.0
**Environment details**
tensorflow-2.8-cuda11
python=3.8
torch=2.3.0
**Additional context**
| {
"login": "huks0",
"id": 53513835,
"node_id": "MDQ6VXNlcjUzNTEzODM1",
"avatar_url": "https://avatars.githubusercontent.com/u/53513835?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huks0",
"html_url": "https://github.com/huks0",
"followers_url": "https://api.github.com/users/huks0/followers",
"following_url": "https://api.github.com/users/huks0/following{/other_user}",
"gists_url": "https://api.github.com/users/huks0/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huks0/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huks0/subscriptions",
"organizations_url": "https://api.github.com/users/huks0/orgs",
"repos_url": "https://api.github.com/users/huks0/repos",
"events_url": "https://api.github.com/users/huks0/events{/privacy}",
"received_events_url": "https://api.github.com/users/huks0/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9363/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9363/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9362 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9362/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9362/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9362/events | https://github.com/NVIDIA/NeMo/pull/9362 | 2,330,548,449 | PR_kwDOC_bI7s5xRIaD | 9,362 | Add MPU rank specifiers for EP & DDP | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-03T08:46:42 | 2024-08-01T16:36:27 | 2024-07-04T01:48:49 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9362",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9362",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9362.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9362.patch",
"merged_at": null
} | # What does this PR do ?
I introduced in mcore a config logger, which when enabled dumps to disk configuration options at entry points of mcore. The logger uses the rank as part of the logs filepath & as a result we need a way to specify these when the distributed environment has not yet been setup.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9362/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9362/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9361 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9361/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9361/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9361/events | https://github.com/NVIDIA/NeMo/pull/9361 | 2,330,544,944 | PR_kwDOC_bI7s5xRHpD | 9,361 | fix wpe tokenizer function | {
"login": "Ssofja",
"id": 78349198,
"node_id": "MDQ6VXNlcjc4MzQ5MTk4",
"avatar_url": "https://avatars.githubusercontent.com/u/78349198?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ssofja",
"html_url": "https://github.com/Ssofja",
"followers_url": "https://api.github.com/users/Ssofja/followers",
"following_url": "https://api.github.com/users/Ssofja/following{/other_user}",
"gists_url": "https://api.github.com/users/Ssofja/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ssofja/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ssofja/subscriptions",
"organizations_url": "https://api.github.com/users/Ssofja/orgs",
"repos_url": "https://api.github.com/users/Ssofja/repos",
"events_url": "https://api.github.com/users/Ssofja/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ssofja/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-03T08:45:03 | 2024-06-03T15:27:45 | 2024-06-03T15:27:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9361",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9361",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9361.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9361.patch",
"merged_at": null
} | # What does this PR do ?
Correcting WPE tokenizer ids_to_text function which now handles punctuation marks and spaces.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Ssofja",
"id": 78349198,
"node_id": "MDQ6VXNlcjc4MzQ5MTk4",
"avatar_url": "https://avatars.githubusercontent.com/u/78349198?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ssofja",
"html_url": "https://github.com/Ssofja",
"followers_url": "https://api.github.com/users/Ssofja/followers",
"following_url": "https://api.github.com/users/Ssofja/following{/other_user}",
"gists_url": "https://api.github.com/users/Ssofja/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Ssofja/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ssofja/subscriptions",
"organizations_url": "https://api.github.com/users/Ssofja/orgs",
"repos_url": "https://api.github.com/users/Ssofja/repos",
"events_url": "https://api.github.com/users/Ssofja/events{/privacy}",
"received_events_url": "https://api.github.com/users/Ssofja/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9361/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9361/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9360 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9360/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9360/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9360/events | https://github.com/NVIDIA/NeMo/issues/9360 | 2,330,356,945 | I_kwDOC_bI7s6K5mzR | 9,360 | ImportError: cannot import name '_library_root_logger' from 'apex' (unknown location) | {
"login": "BBALU1660",
"id": 116936023,
"node_id": "U_kgDOBvhNVw",
"avatar_url": "https://avatars.githubusercontent.com/u/116936023?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BBALU1660",
"html_url": "https://github.com/BBALU1660",
"followers_url": "https://api.github.com/users/BBALU1660/followers",
"following_url": "https://api.github.com/users/BBALU1660/following{/other_user}",
"gists_url": "https://api.github.com/users/BBALU1660/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BBALU1660/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BBALU1660/subscriptions",
"organizations_url": "https://api.github.com/users/BBALU1660/orgs",
"repos_url": "https://api.github.com/users/BBALU1660/repos",
"events_url": "https://api.github.com/users/BBALU1660/events{/privacy}",
"received_events_url": "https://api.github.com/users/BBALU1660/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-06-03T07:13:25 | 2024-06-03T19:35:30 | 2024-06-03T19:35:30 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Error : Traceback (most recent call last):
File "/opt/NeMo/scripts/checkpoint_converters/convert_llama_hf_to_nemo.py", line 312, in <module>
convert(args)
File "/opt/NeMo/scripts/checkpoint_converters/convert_llama_hf_to_nemo.py", line 288, in convert
model = load_state_dict_helper(MegatronGPTModel, nemo_config, trainer, checkpoint['state_dict'])
File "/opt/NeMo/nemo/collections/nlp/parts/utils_funcs.py", line 217, in load_state_dict_helper
model = cls(cfg, trainer)
File "/opt/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py", line 287, in __init__
super().__init__(cfg, trainer=trainer, no_lm_init=True)
File "/opt/NeMo/nemo/collections/nlp/models/language_modeling/megatron_base_model.py", line 191, in __init__
initialize_model_parallel_for_nemo(
File "/opt/NeMo/nemo/collections/nlp/modules/common/megatron/megatron_init.py", line 159, in initialize_model_parallel_for_nemo
set_logging_level(apex_transformer_log_level)
File "/opt/apex/apex/transformer/log_util.py", line 16, in set_logging_level
from apex import _library_root_logger
ImportError: cannot import name '_library_root_logger' from 'apex' (unknown location)
command : python /opt/NeMo/scripts/checkpoint_converters/convert_llama_hf_to_nemo.py --input_name_or_path=./llama2-7b-hf/ --output_path=llama2-7b.nemo
Can anyone help me solve this
| {
"login": "BBALU1660",
"id": 116936023,
"node_id": "U_kgDOBvhNVw",
"avatar_url": "https://avatars.githubusercontent.com/u/116936023?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BBALU1660",
"html_url": "https://github.com/BBALU1660",
"followers_url": "https://api.github.com/users/BBALU1660/followers",
"following_url": "https://api.github.com/users/BBALU1660/following{/other_user}",
"gists_url": "https://api.github.com/users/BBALU1660/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BBALU1660/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BBALU1660/subscriptions",
"organizations_url": "https://api.github.com/users/BBALU1660/orgs",
"repos_url": "https://api.github.com/users/BBALU1660/repos",
"events_url": "https://api.github.com/users/BBALU1660/events{/privacy}",
"received_events_url": "https://api.github.com/users/BBALU1660/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9360/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9360/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9359 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9359/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9359/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9359/events | https://github.com/NVIDIA/NeMo/pull/9359 | 2,330,151,976 | PR_kwDOC_bI7s5xPyEK | 9,359 | Add tutorial for Llama-3-8B lora training and deployment | {
"login": "shashank3959",
"id": 20920371,
"node_id": "MDQ6VXNlcjIwOTIwMzcx",
"avatar_url": "https://avatars.githubusercontent.com/u/20920371?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shashank3959",
"html_url": "https://github.com/shashank3959",
"followers_url": "https://api.github.com/users/shashank3959/followers",
"following_url": "https://api.github.com/users/shashank3959/following{/other_user}",
"gists_url": "https://api.github.com/users/shashank3959/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shashank3959/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shashank3959/subscriptions",
"organizations_url": "https://api.github.com/users/shashank3959/orgs",
"repos_url": "https://api.github.com/users/shashank3959/repos",
"events_url": "https://api.github.com/users/shashank3959/events{/privacy}",
"received_events_url": "https://api.github.com/users/shashank3959/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@chrisalexiuk-nvidia @vinhngx could you please review?",
"\r\n\r\nThere's some formatting mismatch here for the `Fig Text`.\r\n\r\n",
"Adding @nealvaidya for any review comments covering the NIM part",
"<img width=\"156\" alt=\"Screenshot 2024-06-05 at 5 02 21 PM\" src=\"https://github.com/NVIDIA/NeMo/assets/161380339/fe4af46d-6477-4249-870c-ffda6838c50c\">\r\n\r\nFirst notebook workin' like a charm.",
"Approved comments"
] | 2024-06-03T04:37:32 | 2024-06-07T17:35:57 | 2024-06-07T17:10:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9359",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9359",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9359.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9359.patch",
"merged_at": "2024-06-07T17:10:06"
} | * Adds a notebook for Llama-3-8b LoRA PEFT with NeMo FW
* Adds a notebook for sending multi-LoRA inference request to NVIDIA NIM
* Adds README that includes instructions fore context and set up
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9359/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9359/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9358 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9358/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9358/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9358/events | https://github.com/NVIDIA/NeMo/pull/9358 | 2,329,766,551 | PR_kwDOC_bI7s5xOhTg | 9,358 | CI test for RAG Pipeline | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-06-02T17:09:43 | 2024-06-04T16:57:58 | 2024-06-04T16:57:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9358",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9358",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9358.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9358.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9358/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9358/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9357 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9357/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9357/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9357/events | https://github.com/NVIDIA/NeMo/issues/9357 | 2,329,538,303 | I_kwDOC_bI7s6K2e7_ | 9,357 | Error(s): ConfidenceConfig.__init__() got an unexpected keyword argument 'measure_cfg' | {
"login": "SuperReem",
"id": 53432438,
"node_id": "MDQ6VXNlcjUzNDMyNDM4",
"avatar_url": "https://avatars.githubusercontent.com/u/53432438?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SuperReem",
"html_url": "https://github.com/SuperReem",
"followers_url": "https://api.github.com/users/SuperReem/followers",
"following_url": "https://api.github.com/users/SuperReem/following{/other_user}",
"gists_url": "https://api.github.com/users/SuperReem/gists{/gist_id}",
"starred_url": "https://api.github.com/users/SuperReem/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SuperReem/subscriptions",
"organizations_url": "https://api.github.com/users/SuperReem/orgs",
"repos_url": "https://api.github.com/users/SuperReem/repos",
"events_url": "https://api.github.com/users/SuperReem/events{/privacy}",
"received_events_url": "https://api.github.com/users/SuperReem/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"@nithinraok @titu1994 ",
"Please update to NeMo 1.23.0. ",
"> Please update to NeMo 1.23.0.\r\n@titu1994 \r\n\r\nTraceback (most recent call last):\r\n File \"/home/ma-user/work/exp/speech_to_text_eval.py\", line 71, in <module>\r\n import transcribe_speech\r\n File \"/home/ma-user/work/exp/transcribe_speech.py\", line 111, in <module>\r\n class TranscriptionConfig:\r\n File \"/home/ma-user/work/exp/transcribe_speech.py\", line 159, in TranscriptionConfig\r\n fused_batch_size=-1, greedy=GreedyBatchedRNNTInferConfig(use_cuda_graph_decoder=True)\r\nTypeError: GreedyBatchedRNNTInferConfig.__init__() got an unexpected keyword argument 'use_cuda_graph_decoder'\r\n\r\n\r\n**model_config:**\r\n\r\n```\r\ntarget: nemo.collections.asr.models.ctc_bpe_models.EncDecCTCModelBPE\r\nnemo_version: 1.21.0\r\ndecoding:\r\n strategy: greedy\r\n preserve_alignments: null\r\n compute_timestamps: null\r\n word_seperator: ' '\r\n ctc_timestamp_type: all\r\n batch_dim_index: 0\r\n greedy:\r\n preserve_alignments: false\r\n compute_timestamps: false\r\n preserve_frame_confidence: false\r\n confidence_measure_cfg:\r\n name: entropy\r\n entropy_type: tsallis\r\n alpha: 0.33\r\n entropy_norm: exp\r\n temperature: DEPRECATED\r\n confidence_method_cfg: DEPRECATED\r\n beam:\r\n beam_size: 4\r\n search_type: default\r\n preserve_alignments: false\r\n compute_timestamps: false\r\n return_best_hypothesis: true\r\n beam_alpha: 1.0\r\n beam_beta: 0.0\r\n kenlm_path: null\r\n flashlight_cfg:\r\n lexicon_path: null\r\n boost_path: null\r\n beam_size_token: 16\r\n beam_threshold: 20.0\r\n unk_weight: -.inf\r\n sil_weight: 0.0\r\n pyctcdecode_cfg:\r\n beam_prune_logp: -10.0\r\n token_min_logp: -5.0\r\n prune_history: false\r\n hotwords: null\r\n hotword_weight: 10.0\r\n confidence_cfg:\r\n preserve_frame_confidence: false\r\n preserve_token_confidence: false\r\n preserve_word_confidence: false\r\n exclude_blank: true\r\n aggregation: min\r\n measure_cfg:\r\n name: entropy\r\n entropy_type: tsallis\r\n alpha: 0.33\r\n entropy_norm: exp\r\n temperature: DEPRECATED\r\n method_cfg: DEPRECATED\r\n temperature: 1.0\r\n\r\n```",
"@titu1994 @nithinraok your help kindly ",
"You're using the script from main, that won't work. Switch branch to r1.23 and then use that script ",
"> You're using the script from main, that won't work. Switch branch to r1.23 and then use that script\r\n\r\n**Still facing this error:** TypeError: ConfidenceConfig.__init__() got an unexpected keyword argument 'measure_cfg'\r\n\r\nWhat I see is that, r1.23.0 is also using 'method_cfg', but my trained model using 'measure_cfg'\r\n\r\n@titu1994 ",
"Delete the entire \"confidence_cfg\" part using following \r\n\r\n```pythob\r\ncfg = ASRModel.restore_from(filepath, return_config=True)\r\n\r\ndel cfg.decoding.confidence_cfg\r\n\r\nModel = ASRModel.restore_from(filepath, override_config_path=cfg)\r\n\r\nModel.save_to(new_filepath)\r\n\r\n```",
"> Delete the entire \"confidence_cfg\" part using following\r\n> \r\n> ```\r\n> cfg = ASRModel.restore_from(filepath, return_config=True)\r\n> \r\n> del cfg.decoding.confidence_cfg\r\n> \r\n> Model = ASRModel.restore_from(filepath, override_config_path=cfg)\r\n> \r\n> Model.save_to(new_filepath)\r\n> ```\r\n\r\nThis error occurs:\r\n\r\nTarget class: nemo.collections.asr.models.ctc_bpe_models.EncDecCTCModelBPE\r\n Error(s): nemo.collections.asr.parts.utils.asr_confidence_utils.ConfidenceMethodConfig() argument after ** must be a mapping, not str\r\n Traceback (most recent call last):\r\n File \"/home/ma-user/work/exp/nemo/core/classes/common.py\", line 508, in from_config_dict\r\n instance = imported_cls(cfg=config, trainer=trainer)\r\n File \"/home/ma-user/work/exp/nemo/collections/asr/models/ctc_bpe_models.py\", line 75, in __init__\r\n super().__init__(cfg=cfg, trainer=trainer)\r\n File \"/home/ma-user/work/exp/nemo/collections/asr/models/ctc_models.py\", line 102, in __init__\r\n self.decoding = CTCDecoding(self.cfg.decoding, vocabulary=OmegaConf.to_container(self.decoder.vocabulary))\r\n File \"/home/ma-user/work/exp/nemo/collections/asr/parts/submodules/ctc_decoding.py\", line 1032, in __init__\r\n super().__init__(decoding_cfg=decoding_cfg, blank_id=blank_id)\r\n File \"/home/ma-user/work/exp/nemo/collections/asr/parts/submodules/ctc_decoding.py\", line 235, in __init__\r\n self._init_confidence(self.cfg.get('confidence_cfg', None))\r\n File \"/home/ma-user/work/exp/nemo/collections/asr/parts/utils/asr_confidence_utils.py\", line 384, in _init_confidence\r\n else OmegaConf.structured(ConfidenceMethodConfig(**confidence_method_cfg))\r\n TypeError: nemo.collections.asr.parts.utils.asr_confidence_utils.ConfidenceMethodConfig() argument after ** must be a mapping, not str\r\n \r\nCode:\r\n```\r\nimport nemo.collections.asr as nemo_asr\r\n\r\nfilepath= \"Conformer-CTC-BPE-multilang.nemo\"\r\n\r\nasr_model = nemo_asr.models.EncDecCTCModelBPE\r\ncfg = asr_model.restore_from(filepath, return_config=True)\r\n\r\ndel cfg.decoding.confidence_cfg\r\n\r\nModel = asr_model.restore_from(filepath, override_config_path=cfg)\r\n\r\nModel.save_to(\"./modified/Conformer-CTC-BPE-multilang.nemo\")\r\n```\r\n@titu1994 ",
"Oh I see, also delete in a similar way the cfg.decoding.greedy.confidence_measure_cfg",
"Still..\r\nTraceback (most recent call last):\r\n File \"/home/ma-user/work/exp/del.py\", line 11, in <module>\r\n Model = asr_model.restore_from(filepath, override_config_path=cfg)\r\n File \"/home/ma-user/work/exp/nemo/core/classes/modelPT.py\", line 449, in restore_from\r\n instance = cls._save_restore_connector.restore_from(\r\n File \"/home/ma-user/work/exp/nemo/core/connectors/save_restore_connector.py\", line 241, in restore_from\r\n loaded_params = self.load_config_and_state_dict(\r\n File \"/home/ma-user/work/exp/nemo/core/connectors/save_restore_connector.py\", line 164, in load_config_and_state_dict\r\n instance = calling_cls.from_config_dict(config=conf, trainer=trainer)\r\n File \"/home/ma-user/work/exp/nemo/core/classes/common.py\", line 518, in from_config_dict\r\n raise e\r\n File \"/home/ma-user/work/exp/nemo/core/classes/common.py\", line 510, in from_config_dict\r\n instance = cls(cfg=config, trainer=trainer)\r\n File \"/home/ma-user/work/exp/nemo/collections/asr/models/ctc_bpe_models.py\", line 73, in __init__\r\n super().__init__(cfg=cfg, trainer=trainer)\r\n File \"/home/ma-user/work/exp/nemo/collections/asr/models/ctc_models.py\", line 97, in __init__\r\n self.decoding = CTCDecoding(self.cfg.decoding, vocabulary=OmegaConf.to_container(self.decoder.vocabulary))\r\n File \"/home/ma-user/work/exp/nemo/collections/asr/parts/submodules/ctc_decoding.py\", line 935, in __init__\r\n super().__init__(decoding_cfg=decoding_cfg, blank_id=blank_id)\r\n File \"/home/ma-user/work/exp/nemo/collections/asr/parts/submodules/ctc_decoding.py\", line 193, in __init__\r\n self._init_confidence(self.cfg.get('confidence_cfg', None))\r\n File \"/home/ma-user/work/exp/nemo/collections/asr/parts/utils/asr_confidence_utils.py\", line 370, in _init_confidence\r\n else OmegaConf.structured(ConfidenceMethodConfig(**confidence_method_cfg))\r\nTypeError: nemo.collections.asr.parts.utils.asr_confidence_utils.ConfidenceMethodConfig() argument after ** must be a mapping, not str\r\n\r\nI think you’ve solved the issue here https://github.com/NVIDIA/NeMo/pull/6810, but in which branch?\r\n\r\n@titu1994 ",
"I had the same problem because I trained the model using nemo-toolkit[all]==1.21.0 and then load the models on latest version. I solved it by reinstall \"nemo-toolkit[all]==1.21.0\". It worked ",
"Can you print you full config after you delete the two items ? If that doesn't work there's not much to be done. Also share your script of how you're updating the config ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-06-02T08:39:14 | 2024-07-12T01:49:12 | 2024-07-12T01:49:11 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | How to solve the issue of 'measure_cfg' and 'method_cfg'?
When loading the model using the text_to_speech_eval.py script the model instantiation fails:
[NeMo E 2024-06-02 11:21:20 common:529] Model instantiation failed!
Target class: nemo.collections.asr.models.ctc_bpe_models.EncDecCTCModelBPE
Error(s): ConfidenceConfig.__init__() got an unexpected keyword argument 'measure_cfg'
Traceback (most recent call last):
File "/home/ma-user/work/exp/nemo/core/classes/common.py", line 508, in from_config_dict
instance = imported_cls(cfg=config, trainer=trainer)
File "/home/ma-user/work/exp/nemo/collections/asr/models/ctc_bpe_models.py", line 75, in __init__
super().__init__(cfg=cfg, trainer=trainer)
File "/home/ma-user/work/exp/nemo/collections/asr/models/ctc_models.py", line 102, in __init__
self.decoding = CTCDecoding(self.cfg.decoding, vocabulary=OmegaConf.to_container(self.decoder.vocabulary))
File "/home/ma-user/work/exp/nemo/collections/asr/parts/submodules/ctc_decoding.py", line 1032, in __init__
super().__init__(decoding_cfg=decoding_cfg, blank_id=blank_id)
File "/home/ma-user/work/exp/nemo/collections/asr/parts/submodules/ctc_decoding.py", line 235, in __init__
self._init_confidence(self.cfg.get('confidence_cfg', None))
File "/home/ma-user/work/exp/nemo/collections/asr/parts/utils/asr_confidence_utils.py", line 352, in _init_confidence
ConfidenceConfig() if confidence_cfg is None else ConfidenceConfig(**confidence_cfg)
TypeError: ConfidenceConfig.__init__() got an unexpected keyword argument 'measure_cfg'
Model trained with NeMo version 1.21.0
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9357/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9357/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9356 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9356/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9356/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9356/events | https://github.com/NVIDIA/NeMo/pull/9356 | 2,328,491,778 | PR_kwDOC_bI7s5xKXuP | 9,356 | bugfix if using mcore distOpt with sft | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-05-31T19:48:11 | 2024-06-05T16:17:12 | 2024-06-05T16:17:11 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9356",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9356",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9356.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9356.patch",
"merged_at": "2024-06-05T16:17:11"
} | # What does this PR do ?
skip entering if statement's block that's intended only for apex distOpt if using mcore distOpt.
if the mcore distOpt is used it will set self.with_distributed_adam to true. This is something we can refactor to improve readability/maintainability.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9356/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9356/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9355 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9355/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9355/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9355/events | https://github.com/NVIDIA/NeMo/pull/9355 | 2,328,240,998 | PR_kwDOC_bI7s5xJgzE | 9,355 | support null/None truncation field | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-05-31T16:56:53 | 2024-06-01T16:41:46 | 2024-06-01T16:41:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9355",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9355",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9355.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9355.patch",
"merged_at": "2024-06-01T16:41:45"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9355/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9355/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9354 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9354/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9354/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9354/events | https://github.com/NVIDIA/NeMo/pull/9354 | 2,326,895,070 | PR_kwDOC_bI7s5xE6mm | 9,354 | Chat template support for megatron_gpt_eval.py | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-05-31T03:33:30 | 2024-07-04T18:51:44 | 2024-07-04T18:51:42 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9354",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9354",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9354.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9354.patch",
"merged_at": "2024-07-04T18:51:42"
} | # What does this PR do ?
Adds support for chat-templated inputs (e.g. with -instruct models) to the eval script.
**Collection**: [Note which collection this PR will affect]
NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9354/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9354/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9353 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9353/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9353/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9353/events | https://github.com/NVIDIA/NeMo/pull/9353 | 2,326,886,773 | PR_kwDOC_bI7s5xE42Q | 9,353 | Re-org export code | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-05-31T03:22:17 | 2024-06-25T08:02:48 | 2024-06-06T17:05:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9353",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9353",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9353.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9353.patch",
"merged_at": "2024-06-06T17:05:34"
} | # What does this PR do ?
Re-org the export code to make it more step by step. In the new code, there will be 3 main parts including the reading the nemo ckpt, converting nemo ckpt to trt-llm ckpt, and building the trt-llm engine.
Once this PR is completed, then the converting nemo ckpt to trt-llm ckpt, and building the trt-llm engine parts will be moved to the mcore.
| {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9353/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9353/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9352 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9352/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9352/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9352/events | https://github.com/NVIDIA/NeMo/pull/9352 | 2,326,761,053 | PR_kwDOC_bI7s5xEeiT | 9,352 | [Fault tolerance] Heartbeat detection | {
"login": "maanug-nv",
"id": 109391026,
"node_id": "U_kgDOBoUssg",
"avatar_url": "https://avatars.githubusercontent.com/u/109391026?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maanug-nv",
"html_url": "https://github.com/maanug-nv",
"followers_url": "https://api.github.com/users/maanug-nv/followers",
"following_url": "https://api.github.com/users/maanug-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/maanug-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maanug-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maanug-nv/subscriptions",
"organizations_url": "https://api.github.com/users/maanug-nv/orgs",
"repos_url": "https://api.github.com/users/maanug-nv/repos",
"events_url": "https://api.github.com/users/maanug-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/maanug-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Hi @maanug-nv I was wondering how can I use the Heartbeat detection and Fault Tolerance features of nemo. Im using the latest NeMo image (`nvcr.io/nvidia/nemo:24.07`) and it's not included. Also I couldn't find any `ptl_resiliency ` nor `gwe_resiliency_pkg` package.\r\n\r\nAre there any installation instructions for this features? \r\n\r\nThanks,\r\n\r\nToni ",
"Hi @TJ-Solergibert , unfortunately the resiliency package has not made it into the container yet. I think we initially thought it would be a smoother process so this PR was already merged. I currently expect that the package will be in the 24.09 container. \r\n\r\nSorry for the confusion. "
] | 2024-05-31T00:29:09 | 2024-08-08T20:13:31 | 2024-07-01T21:24:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9352",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9352",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9352.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9352.patch",
"merged_at": "2024-07-01T21:24:03"
} | # What does this PR do ?
Enables heartbeat detection, terminate and restart of training.
**Collection**: [Note which collection this PR will affect]
# Changelog
- New PTL callback for sending heartbeats and calculating timeout interval
# Usage
See changes to `docs/source/exp_manager.rst`
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "jbieniusiewi",
"id": 152396322,
"node_id": "U_kgDOCRViIg",
"avatar_url": "https://avatars.githubusercontent.com/u/152396322?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jbieniusiewi",
"html_url": "https://github.com/jbieniusiewi",
"followers_url": "https://api.github.com/users/jbieniusiewi/followers",
"following_url": "https://api.github.com/users/jbieniusiewi/following{/other_user}",
"gists_url": "https://api.github.com/users/jbieniusiewi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jbieniusiewi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jbieniusiewi/subscriptions",
"organizations_url": "https://api.github.com/users/jbieniusiewi/orgs",
"repos_url": "https://api.github.com/users/jbieniusiewi/repos",
"events_url": "https://api.github.com/users/jbieniusiewi/events{/privacy}",
"received_events_url": "https://api.github.com/users/jbieniusiewi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9352/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9352/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9351 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9351/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9351/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9351/events | https://github.com/NVIDIA/NeMo/pull/9351 | 2,326,198,045 | PR_kwDOC_bI7s5xCjqd | 9,351 | Revert "Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer." | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-05-30T17:24:56 | 2024-05-30T17:25:09 | 2024-05-30T17:25:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9351",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9351",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9351.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9351.patch",
"merged_at": "2024-05-30T17:25:07"
} | Reverts NVIDIA/NeMo#9347 | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9351/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9351/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9350 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9350/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9350/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9350/events | https://github.com/NVIDIA/NeMo/pull/9350 | 2,326,182,896 | PR_kwDOC_bI7s5xCgKL | 9,350 | Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer. (#9347) | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-05-30T17:19:43 | 2024-06-04T05:43:30 | 2024-06-04T05:43:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9350",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9350",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9350.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9350.patch",
"merged_at": "2024-06-04T05:43:29"
} | * Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer.
decoder_lengths is allowed to be on CPU even when decoder_output is on GPU. This matches the behavior of GreedyCTCInfer. Even though that behavior is unintentional, there is code depending on that behavior, including our jupyter notebooks.
Signed-off-by: Daniel Galvez <[email protected]>
* Apply isort and black reformatting
Signed-off-by: titu1994 <[email protected]>
---------
Signed-off-by: Daniel Galvez <[email protected]>
Signed-off-by: titu1994 <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: titu1994 <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
(cherry picked from commit aed9d071c700080b3eb024e8a5d7f091f20f0183)
# What does this PR do ?
Information is here - https://github.com/NVIDIA/NeMo/pull/9347
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9350/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9350/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9349 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9349/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9349/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9349/events | https://github.com/NVIDIA/NeMo/pull/9349 | 2,326,120,362 | PR_kwDOC_bI7s5xCSQ0 | 9,349 | add deprecation note for nmt | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-05-30T16:49:00 | 2024-06-28T01:48:54 | 2024-06-28T01:48:53 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9349",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9349",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9349.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9349.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9349/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9349/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9348 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9348/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9348/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9348/events | https://github.com/NVIDIA/NeMo/pull/9348 | 2,326,037,949 | PR_kwDOC_bI7s5xCACM | 9,348 | add large model stable training fix and contrastive loss update for variable seq | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-05-30T16:03:32 | 2024-05-31T21:05:19 | 2024-05-31T21:05:18 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9348",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9348",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9348.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9348.patch",
"merged_at": "2024-05-31T21:05:18"
} | # What does this PR do ?
This PR brings two updates:
* Fix SSL contrastive loss to support loss computation for variable input length rather than computation based on subsampling factor
* Add an option to remove bias from Linear and Conv layers in Conformer layers to support scaling for multi billion parameter training [tested currently for 1B parameter using bf16]
**Collection**: ASR
# Changelog
- Updated ssl_loss
- Added argument for conformerlayer to optionally remove bias, default is False
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [x] Bugfix
- [ ] Documentation | {
"login": "krishnacpuvvada",
"id": 93558329,
"node_id": "U_kgDOBZOWOQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93558329?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/krishnacpuvvada",
"html_url": "https://github.com/krishnacpuvvada",
"followers_url": "https://api.github.com/users/krishnacpuvvada/followers",
"following_url": "https://api.github.com/users/krishnacpuvvada/following{/other_user}",
"gists_url": "https://api.github.com/users/krishnacpuvvada/gists{/gist_id}",
"starred_url": "https://api.github.com/users/krishnacpuvvada/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/krishnacpuvvada/subscriptions",
"organizations_url": "https://api.github.com/users/krishnacpuvvada/orgs",
"repos_url": "https://api.github.com/users/krishnacpuvvada/repos",
"events_url": "https://api.github.com/users/krishnacpuvvada/events{/privacy}",
"received_events_url": "https://api.github.com/users/krishnacpuvvada/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9348/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9348/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9347 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9347/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9347/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9347/events | https://github.com/NVIDIA/NeMo/pull/9347 | 2,324,866,161 | PR_kwDOC_bI7s5w97_t | 9,347 | Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer. | {
"login": "galv",
"id": 4767568,
"node_id": "MDQ6VXNlcjQ3Njc1Njg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4767568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/galv",
"html_url": "https://github.com/galv",
"followers_url": "https://api.github.com/users/galv/followers",
"following_url": "https://api.github.com/users/galv/following{/other_user}",
"gists_url": "https://api.github.com/users/galv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/galv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/galv/subscriptions",
"organizations_url": "https://api.github.com/users/galv/orgs",
"repos_url": "https://api.github.com/users/galv/repos",
"events_url": "https://api.github.com/users/galv/events{/privacy}",
"received_events_url": "https://api.github.com/users/galv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"~Fix not going to r2.0.0rc0?~\r\n"
] | 2024-05-30T07:00:13 | 2024-05-30T17:08:24 | 2024-05-30T17:08:24 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9347",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9347",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9347.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9347.patch",
"merged_at": "2024-05-30T17:08:24"
} | # What does this PR do ?
decoder_lengths is allowed to be on CPU even when decoder_output is on GPU. This matches the behavior of GreedyCTCInfer. Even though that behavior is unintentional, there is code depending on that behavior, including our jupyter notebooks.
# Testing
I tested in the following way. I ran:
```
pytest -k test_batched_decoding_ tests/collections/asr/decoding/test_ctc_decoding.py
CUDA_VISIBLE_DEVICES="" pytest -k test_batched_decoding_ tests/collections/asr/decoding/test_ctc_decoding.py
```
CUDA_VISIBLE_DEVICES="" ensures that the test runs when on CPU-only machines, as well as on machines with GPU. My previous PR related to this failed to test on GPU, which caused the crash we see today when we run with lengths on CPU but logprobs on GPU.
I also manually ran examples/notebooks/asr/ASR_with_Subword_Tokenization.ipynb and examples/notebooks/asr/ASR_with_NeMo.ipynb manually. These run to completion. I had to comment out the part that install NeMo from pypi, which would overwrite my local installation.
**Collection**: ASR
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to NVBug 4647443 and 4647231
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9347/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9347/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9346 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9346/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9346/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9346/events | https://github.com/NVIDIA/NeMo/issues/9346 | 2,324,678,796 | I_kwDOC_bI7s6Kj8iM | 9,346 | why we reverse the RGB channels in video processor | {
"login": "Slyne",
"id": 6286804,
"node_id": "MDQ6VXNlcjYyODY4MDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/6286804?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Slyne",
"html_url": "https://github.com/Slyne",
"followers_url": "https://api.github.com/users/Slyne/followers",
"following_url": "https://api.github.com/users/Slyne/following{/other_user}",
"gists_url": "https://api.github.com/users/Slyne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Slyne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Slyne/subscriptions",
"organizations_url": "https://api.github.com/users/Slyne/orgs",
"repos_url": "https://api.github.com/users/Slyne/repos",
"events_url": "https://api.github.com/users/Slyne/events{/privacy}",
"received_events_url": "https://api.github.com/users/Slyne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This has been fixed by https://github.com/NVIDIA/NeMo/pull/9245 "
] | 2024-05-30T04:34:21 | 2024-06-04T22:35:57 | 2024-06-04T22:35:57 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Hi developers,
I noticed we reverse the video frame channels [here](https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/multimodal/data/neva/neva_dataset.py#L103) and [here](https://github.com/NVIDIA/NeMo/blob/deb613adc7b7ad0a540f5cc1f0bc5032ddb345ff/nemo/collections/multimodal/parts/utils.py#L471).
```
frames = [Image.fromarray(vr[i].asnumpy()[:, :, ::-1]).convert('RGB') for i in indices]
```
Here are the images that without reversing vs reversing:
Normal image:

Reverse image:

In some other project like [LITA](https://github.com/NVlabs/LITA/blob/56a23db03197beab45b28f0971129eadc1a6db03/lita/utils.py#L58) and [video LLaVA](https://github.com/PKU-YuanGroup/Video-LLaVA/blob/c5d2b7250f0a082f733974cfa40d4b09b97b88f5/videollava/model/multimodal_encoder/languagebind/video/processing_video.py#L89)
They simply do the below:
```
decord.bridge.set_bridge("torch")
video_reader = VideoReader(uri=video_path)
idx = np.round(np.linspace(0, len(video_reader) - 1, num_frames)).astype(int)
frames = video_reader.get_batch(idx)
frames = processor.preprocess(frames, return_tensors='pt')['pixel_values']
```
If we use opencv, we probably need to convert BGR2RGB. But now we are using `decord`, not sure if it's still the case.
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9346/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9346/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9345 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9345/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9345/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9345/events | https://github.com/NVIDIA/NeMo/pull/9345 | 2,324,363,827 | PR_kwDOC_bI7s5w8QVK | 9,345 | update mcoreddp call | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Draft because it's pending mcore update on GH",
"Thank you @timmoon10 for the fast review, will update the PR."
] | 2024-05-29T22:53:18 | 2024-06-25T08:01:13 | 2024-06-25T08:01:12 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9345",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9345",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9345.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9345.patch",
"merged_at": "2024-06-25T08:01:12"
} | # What does this PR do ?
Updates Mcore DDP call to match https://github.com/NVIDIA/Megatron-LM/commit/02871b4df8c69fac687ab6676c4246e936ce92d0
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9345/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9345/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9344 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9344/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9344/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9344/events | https://github.com/NVIDIA/NeMo/pull/9344 | 2,324,336,537 | PR_kwDOC_bI7s5w8KeR | 9,344 | Skip sequence_parallel allreduce when using Mcore DistOpt | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-05-29T22:22:12 | 2024-05-30T03:03:33 | 2024-05-30T03:03:32 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9344",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9344",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9344.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9344.patch",
"merged_at": "2024-05-30T03:03:32"
} | # What does this PR do ?
Mcore distOpt handles layernorm all-reduce, so we need to skip it in NeMo side (MegatronGPTModel)
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9344/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9344/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9343 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9343/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9343/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9343/events | https://github.com/NVIDIA/NeMo/pull/9343 | 2,324,319,069 | PR_kwDOC_bI7s5w8Gux | 9,343 | Re-enable cuda graphs in training modes. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4556669155,
"node_id": "LA_kwDOC_bI7s8AAAABD5lA4w",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick",
"name": "cherry-pick",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-05-29T22:04:07 | 2024-06-05T01:02:39 | 2024-06-05T01:02:39 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9343",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9343",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9343.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9343.patch",
"merged_at": "2024-06-05T01:02:39"
} | "global" capture mode was sporadically crashing because of pinning host memory in other threads spawned by the data loader when num_workers > 0.
This would cause the ASR_dev_run_Speech_To_Text_HF_Finetuning CI/CD test to fail sporadically (maybe 1 out of 5 times).
# What does this PR do ?
Fixes the crash by using "thread_local" stream capture instead of "global" stream capture.
**Collection**: ASR
# Usage
Cuda graphs will now be used by default for inference in both training and inference scripts, following the previous behavior.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
**PR Type**:
- [ ] New Feature
- [ X ] Bugfix
- [ ] Documentation
Note that I tested this by applying the following diff:
```
modified examples/asr/conf/asr_finetune/speech_to_text_hf_finetune.yaml
@@ -134,6 +134,14 @@ model:
warmup_steps: 5000
warmup_ratio: null
min_lr: 5e-6
+ decoding:
+ strategy: "greedy_batch"
+
+ # greedy strategy config
+ greedy:
+ max_symbols: 5
+ loop_labels: false
+ use_cuda_graph_decoder: true
trainer:
devices: -1 # number of GPUs, -1 would use all available GPUs
modified examples/asr/speech_to_text_finetune.py
@@ -212,6 +212,12 @@ def main(cfg):
if hasattr(cfg.model, 'spec_augment') and cfg.model.spec_augment is not None:
asr_model.spec_augment = ASRModel.from_config_dict(cfg.model.spec_augment)
+ if hasattr(asr_model, 'change_decoding_strategy') and hasattr(asr_model, 'decoding'):
+ # This is not robust to all model types.
+ # import ipdb; ipdb.set_trace()
+ decoding_cfg = cfg.model.decoding
+ asr_model.change_decoding_strategy(decoding_cfg)
+
trainer.fit(asr_model)
```
Then I ran this script:
```
for i in $(seq 1 100); do
python examples/asr/speech_to_text_finetune.py \
--config-path="conf/asr_finetune" --config-name="speech_to_text_hf_finetune" \
~model.train_ds.hf_data_cfg \
model.train_ds.num_workers=1 \
model.train_ds.batch_size=2 model.validation_ds.batch_size=2 \
model.train_ds.streaming=true \
+model.train_ds.hf_data_cfg.path="librispeech_asr" \
+model.train_ds.hf_data_cfg.name=null \
+model.train_ds.hf_data_cfg.split="test.clean" \
+model.train_ds.hf_data_cfg.streaming=true \
~model.validation_ds.hf_data_cfg \
model.validation_ds.streaming=true \
+model.validation_ds.hf_data_cfg.path="librispeech_asr" \
+model.validation_ds.hf_data_cfg.name=null \
+model.validation_ds.hf_data_cfg.split="test.clean" \
+model.validation_ds.hf_data_cfg.streaming=true \
~model.test_ds \
init_from_pretrained_model="stt_en_fastconformer_transducer_large" \
model.tokenizer.update_tokenizer=False \
model.optim.sched.warmup_steps=0 \
+model.optim.sched.max_steps=3 \
trainer.max_epochs=null \
trainer.devices=1 \
trainer.accelerator="gpu" \
+trainer.fast_dev_run=True \
model.decoding.greedy.loop_labels=True \
exp_manager.exp_dir=examples/asr/speech_finetuning_results
done
for i in $(seq 1 100); do
python examples/asr/speech_to_text_finetune.py \
--config-path="conf/asr_finetune" --config-name="speech_to_text_hf_finetune" \
~model.train_ds.hf_data_cfg \
model.train_ds.num_workers=1 \
model.train_ds.batch_size=2 model.validation_ds.batch_size=2 \
model.train_ds.streaming=true \
+model.train_ds.hf_data_cfg.path="librispeech_asr" \
+model.train_ds.hf_data_cfg.name=null \
+model.train_ds.hf_data_cfg.split="test.clean" \
+model.train_ds.hf_data_cfg.streaming=true \
~model.validation_ds.hf_data_cfg \
model.validation_ds.streaming=true \
+model.validation_ds.hf_data_cfg.path="librispeech_asr" \
+model.validation_ds.hf_data_cfg.name=null \
+model.validation_ds.hf_data_cfg.split="test.clean" \
+model.validation_ds.hf_data_cfg.streaming=true \
~model.test_ds \
init_from_pretrained_model="stt_en_fastconformer_transducer_large" \
model.tokenizer.update_tokenizer=False \
model.optim.sched.warmup_steps=0 \
+model.optim.sched.max_steps=3 \
trainer.max_epochs=null \
trainer.devices=1 \
trainer.accelerator="gpu" \
+trainer.fast_dev_run=True \
model.decoding.greedy.loop_labels=False \
exp_manager.exp_dir=examples/asr/speech_finetuning_results
done
```
Basically, I needed to add a way for speech_to_text_finetune.py to be able to modify the decoding algorithm, so I could test both the loop frames and loop labels code paths. I do not include this code in the PR, since it is not robust to all model types (e.g., AED). Since I run 100 times for each algorithm, we can be pretty sure that this fixes the problem. | {
"login": "galv",
"id": 4767568,
"node_id": "MDQ6VXNlcjQ3Njc1Njg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4767568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/galv",
"html_url": "https://github.com/galv",
"followers_url": "https://api.github.com/users/galv/followers",
"following_url": "https://api.github.com/users/galv/following{/other_user}",
"gists_url": "https://api.github.com/users/galv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/galv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/galv/subscriptions",
"organizations_url": "https://api.github.com/users/galv/orgs",
"repos_url": "https://api.github.com/users/galv/repos",
"events_url": "https://api.github.com/users/galv/events{/privacy}",
"received_events_url": "https://api.github.com/users/galv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9343/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9343/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9342 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9342/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9342/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9342/events | https://github.com/NVIDIA/NeMo/pull/9342 | 2,324,104,018 | PR_kwDOC_bI7s5w7X_4 | 9,342 | add deprecation note for nmt | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-05-29T19:35:43 | 2024-05-30T16:48:35 | 2024-05-30T16:48:35 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9342",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9342",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9342.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9342.patch",
"merged_at": "2024-05-30T16:48:35"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9342/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9342/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9341 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9341/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9341/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9341/events | https://github.com/NVIDIA/NeMo/pull/9341 | 2,324,060,356 | PR_kwDOC_bI7s5w7OYJ | 9,341 | Fix Peft Weights Loading in NeVA | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-05-29T19:12:02 | 2024-05-29T21:08:51 | 2024-05-29T21:08:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9341",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9341",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9341.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9341.patch",
"merged_at": "2024-05-29T21:08:50"
} | # What does this PR do ?
For megatron amp o2, the assert needs to happen before the key name update.
**Collection**: [multimodal]
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9341/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9341/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9340 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9340/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9340/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9340/events | https://github.com/NVIDIA/NeMo/pull/9340 | 2,323,927,343 | PR_kwDOC_bI7s5w6xMB | 9,340 | QLoRA | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-05-29T18:01:41 | 2024-06-07T16:50:04 | 2024-06-07T16:50:03 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9340",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9340",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9340.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9340.patch",
"merged_at": "2024-06-07T16:50:03"
} | # What does this PR do ?
Add QLoRA
## Current Results
### Convergence
Llama 7b, Squad, packed seq 2k, LoRA on all layers
gbs4, 2e-4, 2k iterations
`exact_match 89.199 f1 94.791 rougeL 94.400 total 6064.000`
Normal LoRA (qkv only)
`exact_match 88.819 f1 94.415 rougeL 94.084 total 6064.000`
### Memory Usage
Llama 13b, Alpaca, seq len 512, LoRA on all layers, gbs256
Peak memory reserved (GB):
| Batch Size | LoRA | QLoRA | % Reduction |
|--------|--------|--------|--------|
| 2 | 37.5 | 18.3 | 51% |
| 4 | 46.7 | 27.4 | 41% |
| 8 | 65.4 | 46.4 | 29% |
### Performance
Llama 13b, Alpaca, seq len 512, LoRA on all layers, gbs256
Global batch step timing (s):
| Batch Size | LoRA | QLoRA | % Increase |
|--------|--------|--------|--------|
| 2 | 2.7 | 6.7 | 148% |
| 4 | 2.3 | 4.4 | 91% |
| 8 | 2.2 | 3.2 | 46% |
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
Set this flag in `megatron_gpt_finetuning_config.yaml` to enable QLoRA
```bash
model.peft.peft_scheme=qlora
```
To get the maximum memory savings, also set these flags
```bash
++model.dist_ckpt_load_on_device=False # load checkpoint on CPU
++model.use_cpu_initialization=True # initialize model on CPU
++model.peft.lora_tuning.target_modules=[all] # quantize all linear layers in the model
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9340/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9340/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9339 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9339/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9339/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9339/events | https://github.com/NVIDIA/NeMo/pull/9339 | 2,323,924,009 | PR_kwDOC_bI7s5w6weL | 9,339 | [Nemo CICD] update flaky test | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-05-29T17:59:52 | 2024-05-29T18:00:03 | 2024-05-29T18:00:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9339",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9339",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9339.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9339.patch",
"merged_at": "2024-05-29T18:00:01"
} | [Nemo CICD] update flaky test | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9339/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9339/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9338 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9338/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9338/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9338/events | https://github.com/NVIDIA/NeMo/pull/9338 | 2,323,650,279 | PR_kwDOC_bI7s5w5zWC | 9,338 | Re-enable cuda graphs in training modes. | {
"login": "galv",
"id": 4767568,
"node_id": "MDQ6VXNlcjQ3Njc1Njg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4767568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/galv",
"html_url": "https://github.com/galv",
"followers_url": "https://api.github.com/users/galv/followers",
"following_url": "https://api.github.com/users/galv/following{/other_user}",
"gists_url": "https://api.github.com/users/galv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/galv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/galv/subscriptions",
"organizations_url": "https://api.github.com/users/galv/orgs",
"repos_url": "https://api.github.com/users/galv/repos",
"events_url": "https://api.github.com/users/galv/events{/privacy}",
"received_events_url": "https://api.github.com/users/galv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@titu1994 yes, that is the only change, and I am very confident in it. I can elaborate if you want.",
"Well, I also had to undo Vladimir's previous commit that turns cuda graphs off by default, except in transcribe_speech.py and transcribe_speech_parallel.py. This commit's changes: [bb26e9846f](https://github.com/NVIDIA/NeMo/commit/bb26e9846f)",
"@artbataev good point. I completely missed TDT. Done. I'm not sure how to test that one, but I suspect that the change is low risk anyway."
] | 2024-05-29T15:47:29 | 2024-05-29T22:03:43 | 2024-05-29T22:03:43 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9338",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9338",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9338.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9338.patch",
"merged_at": "2024-05-29T22:03:43"
} | "global" capture mode was sporadically crashing because of pinning host memory in other threads spawned by the data loader when num_workers > 0.
This would cause the ASR_dev_run_Speech_To_Text_HF_Finetuning CI/CD test to fail sporadically (maybe 1 out of 5 times).
# What does this PR do ?
Fixes the crash by using "thread_local" stream capture instead of "global" stream capture.
**Collection**: ASR
# Usage
Cuda graphs will now be used by default for inference in both training and inference scripts, following the previous behavior.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
**PR Type**:
- [ ] New Feature
- [ X ] Bugfix
- [ ] Documentation
Note that I tested this by applying the following diff:
```
modified examples/asr/conf/asr_finetune/speech_to_text_hf_finetune.yaml
@@ -134,6 +134,14 @@ model:
warmup_steps: 5000
warmup_ratio: null
min_lr: 5e-6
+ decoding:
+ strategy: "greedy_batch"
+
+ # greedy strategy config
+ greedy:
+ max_symbols: 5
+ loop_labels: false
+ use_cuda_graph_decoder: true
trainer:
devices: -1 # number of GPUs, -1 would use all available GPUs
modified examples/asr/speech_to_text_finetune.py
@@ -212,6 +212,12 @@ def main(cfg):
if hasattr(cfg.model, 'spec_augment') and cfg.model.spec_augment is not None:
asr_model.spec_augment = ASRModel.from_config_dict(cfg.model.spec_augment)
+ if hasattr(asr_model, 'change_decoding_strategy') and hasattr(asr_model, 'decoding'):
+ # This is not robust to all model types.
+ # import ipdb; ipdb.set_trace()
+ decoding_cfg = cfg.model.decoding
+ asr_model.change_decoding_strategy(decoding_cfg)
+
trainer.fit(asr_model)
```
Then I ran this script:
```
for i in $(seq 1 100); do
python examples/asr/speech_to_text_finetune.py \
--config-path="conf/asr_finetune" --config-name="speech_to_text_hf_finetune" \
~model.train_ds.hf_data_cfg \
model.train_ds.num_workers=1 \
model.train_ds.batch_size=2 model.validation_ds.batch_size=2 \
model.train_ds.streaming=true \
+model.train_ds.hf_data_cfg.path="librispeech_asr" \
+model.train_ds.hf_data_cfg.name=null \
+model.train_ds.hf_data_cfg.split="test.clean" \
+model.train_ds.hf_data_cfg.streaming=true \
~model.validation_ds.hf_data_cfg \
model.validation_ds.streaming=true \
+model.validation_ds.hf_data_cfg.path="librispeech_asr" \
+model.validation_ds.hf_data_cfg.name=null \
+model.validation_ds.hf_data_cfg.split="test.clean" \
+model.validation_ds.hf_data_cfg.streaming=true \
~model.test_ds \
init_from_pretrained_model="stt_en_fastconformer_transducer_large" \
model.tokenizer.update_tokenizer=False \
model.optim.sched.warmup_steps=0 \
+model.optim.sched.max_steps=3 \
trainer.max_epochs=null \
trainer.devices=1 \
trainer.accelerator="gpu" \
+trainer.fast_dev_run=True \
model.decoding.greedy.loop_labels=True \
exp_manager.exp_dir=examples/asr/speech_finetuning_results
done
for i in $(seq 1 100); do
python examples/asr/speech_to_text_finetune.py \
--config-path="conf/asr_finetune" --config-name="speech_to_text_hf_finetune" \
~model.train_ds.hf_data_cfg \
model.train_ds.num_workers=1 \
model.train_ds.batch_size=2 model.validation_ds.batch_size=2 \
model.train_ds.streaming=true \
+model.train_ds.hf_data_cfg.path="librispeech_asr" \
+model.train_ds.hf_data_cfg.name=null \
+model.train_ds.hf_data_cfg.split="test.clean" \
+model.train_ds.hf_data_cfg.streaming=true \
~model.validation_ds.hf_data_cfg \
model.validation_ds.streaming=true \
+model.validation_ds.hf_data_cfg.path="librispeech_asr" \
+model.validation_ds.hf_data_cfg.name=null \
+model.validation_ds.hf_data_cfg.split="test.clean" \
+model.validation_ds.hf_data_cfg.streaming=true \
~model.test_ds \
init_from_pretrained_model="stt_en_fastconformer_transducer_large" \
model.tokenizer.update_tokenizer=False \
model.optim.sched.warmup_steps=0 \
+model.optim.sched.max_steps=3 \
trainer.max_epochs=null \
trainer.devices=1 \
trainer.accelerator="gpu" \
+trainer.fast_dev_run=True \
model.decoding.greedy.loop_labels=False \
exp_manager.exp_dir=examples/asr/speech_finetuning_results
done
```
Basically, I needed to add a way for speech_to_text_finetune.py to be able to modify the decoding algorithm, so I could test both the loop frames and loop labels code paths. I do not include this code in the PR, since it is not robust to all model types (e.g., AED). Since I run 100 times for each algorithm, we can be pretty sure that this fixes the problem. | {
"login": "galv",
"id": 4767568,
"node_id": "MDQ6VXNlcjQ3Njc1Njg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4767568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/galv",
"html_url": "https://github.com/galv",
"followers_url": "https://api.github.com/users/galv/followers",
"following_url": "https://api.github.com/users/galv/following{/other_user}",
"gists_url": "https://api.github.com/users/galv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/galv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/galv/subscriptions",
"organizations_url": "https://api.github.com/users/galv/orgs",
"repos_url": "https://api.github.com/users/galv/repos",
"events_url": "https://api.github.com/users/galv/events{/privacy}",
"received_events_url": "https://api.github.com/users/galv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9338/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 1,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9338/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9337 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9337/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9337/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9337/events | https://github.com/NVIDIA/NeMo/pull/9337 | 2,323,521,010 | PR_kwDOC_bI7s5w5W6a | 9,337 | TitaNet Batch Verify Speaker | {
"login": "monica-sekoyan",
"id": 166123533,
"node_id": "U_kgDOCebYDQ",
"avatar_url": "https://avatars.githubusercontent.com/u/166123533?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/monica-sekoyan",
"html_url": "https://github.com/monica-sekoyan",
"followers_url": "https://api.github.com/users/monica-sekoyan/followers",
"following_url": "https://api.github.com/users/monica-sekoyan/following{/other_user}",
"gists_url": "https://api.github.com/users/monica-sekoyan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/monica-sekoyan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/monica-sekoyan/subscriptions",
"organizations_url": "https://api.github.com/users/monica-sekoyan/orgs",
"repos_url": "https://api.github.com/users/monica-sekoyan/repos",
"events_url": "https://api.github.com/users/monica-sekoyan/events{/privacy}",
"received_events_url": "https://api.github.com/users/monica-sekoyan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"@monica-sekoyan pls fix conflicts, we can merge this once it passes CI",
"> @monica-sekoyan pls fix conflicts, we can merge this once it passes CI\r\n\r\ndone"
] | 2024-05-29T14:46:20 | 2024-07-05T19:39:57 | 2024-07-05T19:39:57 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9337",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9337",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9337.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9337.patch",
"merged_at": "2024-07-05T19:39:57"
} | # What does this PR do ?
Adds possibility to verify speakers via TitaNet with batch inference.
**Collection**: [ASR]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
import nemo.collections.asr as nemo_asr
speaker_model = nemo_asr.models.EncDecSpeakerLabelModel.from_pretrained(model_name='titanet_large')
audio_pairs = [
(/path/to/audio_0_0, /path/to/audio_0_1),
(/path/to/audio_1_0, /path/to/audio_1_1),
(/path/to/audio_2_0, /path/to/audio_2_1),
(/path/to/audio_3_0, /path/to/audio_3_1)
]
decision = speaker_model.verify_speakers_batch(audio_pairs, batch_size=16, device='cuda')
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9337/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9337/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9336 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9336/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9336/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9336/events | https://github.com/NVIDIA/NeMo/pull/9336 | 2,322,905,640 | PR_kwDOC_bI7s5w3PW0 | 9,336 | Unify code paths for building TRTLLM engines for nemo & qnemo checkpoints | {
"login": "janekl",
"id": 5582967,
"node_id": "MDQ6VXNlcjU1ODI5Njc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5582967?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janekl",
"html_url": "https://github.com/janekl",
"followers_url": "https://api.github.com/users/janekl/followers",
"following_url": "https://api.github.com/users/janekl/following{/other_user}",
"gists_url": "https://api.github.com/users/janekl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janekl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janekl/subscriptions",
"organizations_url": "https://api.github.com/users/janekl/orgs",
"repos_url": "https://api.github.com/users/janekl/repos",
"events_url": "https://api.github.com/users/janekl/events{/privacy}",
"received_events_url": "https://api.github.com/users/janekl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-05-29T09:59:55 | 2024-06-25T01:48:31 | 2024-06-25T01:48:31 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9336",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9336",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9336.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9336.patch",
"merged_at": null
} | # What does this PR do ?
Unify code paths for building TRTLLM engines for nemo & qnemo checkpoints.
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] Refactor
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9336/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9336/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9335 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9335/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9335/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9335/events | https://github.com/NVIDIA/NeMo/pull/9335 | 2,322,751,305 | PR_kwDOC_bI7s5w2tH- | 9,335 | Fix FSDP gradient calculation with orig params | {
"login": "janEbert",
"id": 12694897,
"node_id": "MDQ6VXNlcjEyNjk0ODk3",
"avatar_url": "https://avatars.githubusercontent.com/u/12694897?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/janEbert",
"html_url": "https://github.com/janEbert",
"followers_url": "https://api.github.com/users/janEbert/followers",
"following_url": "https://api.github.com/users/janEbert/following{/other_user}",
"gists_url": "https://api.github.com/users/janEbert/gists{/gist_id}",
"starred_url": "https://api.github.com/users/janEbert/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/janEbert/subscriptions",
"organizations_url": "https://api.github.com/users/janEbert/orgs",
"repos_url": "https://api.github.com/users/janEbert/repos",
"events_url": "https://api.github.com/users/janEbert/events{/privacy}",
"received_events_url": "https://api.github.com/users/janEbert/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Nice, can you fix the DCO?",
"Done thanks :)"
] | 2024-05-29T08:52:41 | 2024-05-30T05:45:56 | 2024-05-30T05:45:56 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9335",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9335",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9335.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9335.patch",
"merged_at": "2024-05-30T05:45:56"
} | As observed by some users in #8487, FSDP causes differences in loss. This is because gradients are not correctly calculated when `fsdp_use_orig_params=True`. Currently, any non-`FlatParameter` is treated as being unsharded, when in reality they may be sharded when `use_orig_params=True`. This leads to a double reduction of sharded gradients. We thus simply adjust the parameters that are reduced manually. This requires use of a private variable in the FSDP module. Alternatively, the value of `self.kwargs['ignored_states']` in `nlp_overrides.py` could be set as an attribute on the model to avoid this private variable access.
Thanks to @ofivite for suggesting that `use_orig_params=True` could be the cause of the issue, which greatly helped with analysis.
# What does this PR do ?
Fix FSDP gradient calculation when `fsdp_use_orig_params=True`.
**Collection**: nlp
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #8487 (issue) | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9335/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9335/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9334 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9334/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9334/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9334/events | https://github.com/NVIDIA/NeMo/issues/9334 | 2,322,604,204 | I_kwDOC_bI7s6KcCCs | 9,334 | Nvidia GPU is Not accessing in my Docker Container | {
"login": "BBALU1660",
"id": 116936023,
"node_id": "U_kgDOBvhNVw",
"avatar_url": "https://avatars.githubusercontent.com/u/116936023?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BBALU1660",
"html_url": "https://github.com/BBALU1660",
"followers_url": "https://api.github.com/users/BBALU1660/followers",
"following_url": "https://api.github.com/users/BBALU1660/following{/other_user}",
"gists_url": "https://api.github.com/users/BBALU1660/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BBALU1660/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BBALU1660/subscriptions",
"organizations_url": "https://api.github.com/users/BBALU1660/orgs",
"repos_url": "https://api.github.com/users/BBALU1660/repos",
"events_url": "https://api.github.com/users/BBALU1660/events{/privacy}",
"received_events_url": "https://api.github.com/users/BBALU1660/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"Similar issue: https://github.com/NVIDIA/NeMo/issues/9268 ",
"My issue got solved instead of pulling nvcr.io/nvidia/nemo:24.03.01.framework pull nvcr.io/nvidia/nemo:dev.framework"
] | 2024-05-29T07:41:13 | 2024-05-30T12:29:44 | 2024-05-30T12:28:36 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null |
Error:
```
ERROR: The NVIDIA Driver is present, but CUDA failed to initialize. GPU functionality will not be available.
[[ System has unsupported display driver / cuda driver combination (error 803) ]]
```
Command:
```
docker run --gpus device=0 --shm-size=2g --net=host --ulimit memlock=-1 --rm -it -v ${PWD}:/workspace -w /workspace -v ${PWD}/results:/results nvcr.io/nvidia/nemo:24.03.01.framework bash
```

My Docker version: Docker version 26.1.3, build b72abbb
My GPU: NVIDIA RTX A6000
Nvidia-smi (non docker)

Nvidia-smi(docker container)

---
| {
"login": "BBALU1660",
"id": 116936023,
"node_id": "U_kgDOBvhNVw",
"avatar_url": "https://avatars.githubusercontent.com/u/116936023?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BBALU1660",
"html_url": "https://github.com/BBALU1660",
"followers_url": "https://api.github.com/users/BBALU1660/followers",
"following_url": "https://api.github.com/users/BBALU1660/following{/other_user}",
"gists_url": "https://api.github.com/users/BBALU1660/gists{/gist_id}",
"starred_url": "https://api.github.com/users/BBALU1660/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/BBALU1660/subscriptions",
"organizations_url": "https://api.github.com/users/BBALU1660/orgs",
"repos_url": "https://api.github.com/users/BBALU1660/repos",
"events_url": "https://api.github.com/users/BBALU1660/events{/privacy}",
"received_events_url": "https://api.github.com/users/BBALU1660/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9334/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9334/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/9333 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9333/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9333/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9333/events | https://github.com/NVIDIA/NeMo/pull/9333 | 2,322,007,164 | PR_kwDOC_bI7s5w0M7z | 9,333 | [Nemo CICD] Comment out flaky tests | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-05-28T22:17:02 | 2024-05-28T22:17:44 | 2024-05-28T22:17:43 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9333",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9333",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9333.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9333.patch",
"merged_at": "2024-05-28T22:17:43"
} | [Nemo CICD] Comment out flaky tests | {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9333/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9333/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9332 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9332/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9332/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9332/events | https://github.com/NVIDIA/NeMo/pull/9332 | 2,321,849,440 | PR_kwDOC_bI7s5wzqfc | 9,332 | HF_TOKEN param for the scripts | {
"login": "oyilmaz-nvidia",
"id": 35306097,
"node_id": "MDQ6VXNlcjM1MzA2MDk3",
"avatar_url": "https://avatars.githubusercontent.com/u/35306097?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oyilmaz-nvidia",
"html_url": "https://github.com/oyilmaz-nvidia",
"followers_url": "https://api.github.com/users/oyilmaz-nvidia/followers",
"following_url": "https://api.github.com/users/oyilmaz-nvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/oyilmaz-nvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/oyilmaz-nvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oyilmaz-nvidia/subscriptions",
"organizations_url": "https://api.github.com/users/oyilmaz-nvidia/orgs",
"repos_url": "https://api.github.com/users/oyilmaz-nvidia/repos",
"events_url": "https://api.github.com/users/oyilmaz-nvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/oyilmaz-nvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Hi, I wonder why passing HF-TOKEN via CLI is required instead of passing it via an environment variable? Can you please clarify for future readers? Thank you.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-05-28T20:17:02 | 2024-06-21T01:47:22 | 2024-06-21T01:47:21 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9332",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9332",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9332.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9332.patch",
"merged_at": null
} | # What does this PR do ?
Adds HF TOKEN to the scripts | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9332/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9332/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/9331 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/9331/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/9331/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/9331/events | https://github.com/NVIDIA/NeMo/pull/9331 | 2,321,685,895 | PR_kwDOC_bI7s5wzGld | 9,331 | Call teardown even when something fails. | {
"login": "tfogal",
"id": 60981,
"node_id": "MDQ6VXNlcjYwOTgx",
"avatar_url": "https://avatars.githubusercontent.com/u/60981?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tfogal",
"html_url": "https://github.com/tfogal",
"followers_url": "https://api.github.com/users/tfogal/followers",
"following_url": "https://api.github.com/users/tfogal/following{/other_user}",
"gists_url": "https://api.github.com/users/tfogal/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tfogal/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tfogal/subscriptions",
"organizations_url": "https://api.github.com/users/tfogal/orgs",
"repos_url": "https://api.github.com/users/tfogal/repos",
"events_url": "https://api.github.com/users/tfogal/events{/privacy}",
"received_events_url": "https://api.github.com/users/tfogal/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"Commenting to kill the stale label.\r\n\r\nThis really just needs a reviewer. Would be great to know if this is the desired solution; I think I'm seeing the same thing in another model and would replicate this approach there, if so.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-05-28T18:32:28 | 2024-07-10T01:50:02 | 2024-07-10T01:50:01 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/9331",
"html_url": "https://github.com/NVIDIA/NeMo/pull/9331",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/9331.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/9331.patch",
"merged_at": null
} | # What does this PR do ?
Avoid tons of terminal spam such as:
```
[rank0]:[W528 18:14:19.086678488 ProcessGroupNCCL.cpp:1122] WARNING: process group has NOT been destroyed before it is being destructed. On normal program exit, the application should call destroy_process_group to ensure that any pending NCCL data transfers have finished in this process. In rare cases this process can exit before this point and block the progress of another member of the process group. This constraint has always been present, but this warning has only been added since PyTorch 2.4
```
when an error occurs, which can obscure the real error.
**Collection**: Stable diffusion
# Changelog
- stable diffusion: Clean up process groups after an error occurs.
# GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- - Are any necessary for this?
- [x] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] Bugfix
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/9331/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/9331/timeline | null | null | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.