url
stringlengths 52
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 66
67
| comments_url
stringlengths 61
62
| events_url
stringlengths 59
60
| html_url
stringlengths 40
43
| id
int64 719M
2.8B
| node_id
stringlengths 18
32
| number
int64 1.28k
11.9k
| title
stringlengths 1
350
| user
dict | labels
listlengths 0
10
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
3
| milestone
null | comments
sequencelengths 0
30
⌀ | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
stringclasses 4
values | sub_issues_summary
dict | active_lock_reason
stringclasses 1
value | draft
bool 2
classes | pull_request
dict | body
stringlengths 0
73.4k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 61
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | is_pull_request
bool 2
classes |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/NVIDIA/NeMo/issues/8279 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8279/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8279/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8279/events | https://github.com/NVIDIA/NeMo/pull/8279 | 2,108,990,904 | PR_kwDOC_bI7s5lgymh | 8,279 | add deallocate pipeline output optimization | {
"login": "JimmyZhang12",
"id": 67203904,
"node_id": "MDQ6VXNlcjY3MjAzOTA0",
"avatar_url": "https://avatars.githubusercontent.com/u/67203904?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JimmyZhang12",
"html_url": "https://github.com/JimmyZhang12",
"followers_url": "https://api.github.com/users/JimmyZhang12/followers",
"following_url": "https://api.github.com/users/JimmyZhang12/following{/other_user}",
"gists_url": "https://api.github.com/users/JimmyZhang12/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JimmyZhang12/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JimmyZhang12/subscriptions",
"organizations_url": "https://api.github.com/users/JimmyZhang12/orgs",
"repos_url": "https://api.github.com/users/JimmyZhang12/repos",
"events_url": "https://api.github.com/users/JimmyZhang12/events{/privacy}",
"received_events_url": "https://api.github.com/users/JimmyZhang12/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins"
] | 2024-01-30T23:32:59 | 2024-02-02T19:36:23 | 2024-02-02T19:36:22 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8279",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8279",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8279.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8279.patch",
"merged_at": "2024-02-02T19:36:22"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8279/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8279/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8278 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8278/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8278/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8278/events | https://github.com/NVIDIA/NeMo/issues/8278 | 2,107,797,592 | I_kwDOC_bI7s59onBY | 8,278 | Diarization | IndexError: shape mismatch: indexing tensors could not be broadcast together | {
"login": "Oscaarjs",
"id": 37636054,
"node_id": "MDQ6VXNlcjM3NjM2MDU0",
"avatar_url": "https://avatars.githubusercontent.com/u/37636054?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Oscaarjs",
"html_url": "https://github.com/Oscaarjs",
"followers_url": "https://api.github.com/users/Oscaarjs/followers",
"following_url": "https://api.github.com/users/Oscaarjs/following{/other_user}",
"gists_url": "https://api.github.com/users/Oscaarjs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Oscaarjs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Oscaarjs/subscriptions",
"organizations_url": "https://api.github.com/users/Oscaarjs/orgs",
"repos_url": "https://api.github.com/users/Oscaarjs/repos",
"events_url": "https://api.github.com/users/Oscaarjs/events{/privacy}",
"received_events_url": "https://api.github.com/users/Oscaarjs/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"Hi.\r\nLet us test on the wav file you provided.\r\nThis is a new type of error we have never encountered.\r\nIt apprears `p_value` value in [this line ](https://github.com/NVIDIA/NeMo/blob/0fb851c8ed91f181c5550dcdce1e39f5891ec3b2/nemo/collections/asr/parts/utils/offline_clustering.py#L332) is causing this error.\r\n\r\nI will follow your settings and check what is causing this error. ",
"@tango4j any updates on this issue?",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-30T12:53:27 | 2024-04-09T01:44:24 | 2024-04-09T01:44:23 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
When running diarization on a specific file I'm getting:
`IndexError: shape mismatch: indexing tensors could not be broadcast together with shapes [7557001], [7559750]`
The same pipeline/config/setup etc has worked for a couple of thousand other files but now on this (and a few more files) I'm getting this issue suddenly.
**Steps/Code to reproduce bug**
Shared a Google Colab of how one can reproduce the error, the steps are also listed below.
[Shared Google Colab](https://colab.research.google.com/drive/1e3RigN5Rg-lGhBhg7kfSunoT5nR8kMtp?usp=sharing)
[notebook ipynb](http://tinyurl.com/bdssr2r4)
Steps:
Pre-steps:
Upload `issue_file.wav`, `config.yaml` and `speech_timestamps.rttm` to runtime (e.g. Colab)
Above mentioned files can be obtained:
`issue_file.wav` : [Audio file](http://tinyurl.com/2eynkewf)
`config.yaml`: [diarization config](http://tinyurl.com/3enesyur)
`speech_timestamps.rttm`: [speech timestamps rttm](http://tinyurl.com/35jwuut5)
Let me know if anything's missing or unclear.
1.
```
!apt-get update && apt-get install -y libsndfile1 ffmpeg
!pip install nemo_toolkit['asr']
```
2.
```
import os
import torch
import yaml
import json
from omegaconf import OmegaConf
from nemo.collections.asr.models import ClusteringDiarizer
```
3.
```
def diarize(workdir: str, rttm_filepath):
manifest_path = os.path.join(workdir, "manifest.json")
output_dir = os.path.join(workdir, "output")
manifest = {
'audio_filepath': '/content/issue_file.wav',
'offset': 0,
'duration': None,
'label': 'infer',
'text': '-',
'num_speakers': None,
'rttm_filepath': rttm_filepath,
'uem_filepath': None,
}
with open('/content/config.yaml', "r") as config_file:
config_dict = yaml.load(config_file, Loader=yaml.FullLoader)
config = OmegaConf.create(config_dict['diarizer'])
config.device = "cuda:0" if torch.cuda.is_available() else "cpu"
config.diarizer.manifest_filepath = manifest_path
config.diarizer.oracle_vad = True
config.diarizer.speaker_embeddings.model_path = 'titanet_large'
config.diarizer.out_dir = output_dir
with open(manifest_path, "w") as manifest_file:
json.dump(manifest, manifest_file)
model = ClusteringDiarizer(cfg=config)
model.diarize()
```
4.
```
diarize('/content/', '/content/speech_timestamps.rttm')
```
This fails:
```
[<ipython-input-7-4afd3b7bf15c>](https://localhost:8080/#) in diarize(workdir, rttm_filepath)
30
31 model = ClusteringDiarizer(cfg=config)
---> 32 model.diarize()
[/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/models/clustering_diarizer.py](https://localhost:8080/#) in diarize(self, paths2audio_files, batch_size)
454
455 # Clustering
--> 456 all_reference, all_hypothesis = perform_clustering(
457 embs_and_timestamps=embs_and_timestamps,
458 AUDIO_RTTM_MAP=self.AUDIO_RTTM_MAP,
[/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/parts/utils/speaker_utils.py](https://localhost:8080/#) in perform_clustering(embs_and_timestamps, AUDIO_RTTM_MAP, out_rttm_dir, clustering_params, device, verbose)
483 base_scale_idx = uniq_embs_and_timestamps['multiscale_segment_counts'].shape[0] - 1
484
--> 485 cluster_labels = speaker_clustering.forward_infer(
486 embeddings_in_scales=uniq_embs_and_timestamps['embeddings'],
487 timestamps_in_scales=uniq_embs_and_timestamps['timestamps'],
[/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/parts/utils/longform_clustering.py](https://localhost:8080/#) in forward_infer(self, embeddings_in_scales, timestamps_in_scales, multiscale_segment_counts, multiscale_weights, oracle_num_speakers, max_rp_threshold, max_num_speakers, enhanced_count_thres, sparse_search_volume, fixed_thres, chunk_cluster_count, embeddings_per_chunk)
407 )
408 else:
--> 409 cluster_labels = self.speaker_clustering.forward_infer(
410 embeddings_in_scales=embeddings_in_scales,
411 timestamps_in_scales=timestamps_in_scales,
[/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/parts/utils/offline_clustering.py](https://localhost:8080/#) in forward_infer(self, embeddings_in_scales, timestamps_in_scales, multiscale_segment_counts, multiscale_weights, oracle_num_speakers, max_num_speakers, max_rp_threshold, enhanced_count_thres, sparse_search_volume, fixed_thres, kmeans_random_trials)
1376 )
1377
-> 1378 return self.forward_unit_infer(
1379 mat=mat,
1380 oracle_num_speakers=oracle_num_speakers,
[/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/parts/utils/offline_clustering.py](https://localhost:8080/#) in forward_unit_infer(self, mat, oracle_num_speakers, max_num_speakers, max_rp_threshold, sparse_search_volume, est_num_of_spk_enhanced, fixed_thres, kmeans_random_trials)
1225 if mat.shape[0] > self.min_samples_for_nmesc:
1226 est_num_of_spk, p_hat_value = nmesc.forward()
-> 1227 affinity_mat = getAffinityGraphMat(mat, p_hat_value)
1228 else:
1229 nmesc.fixed_thres = max_rp_threshold
[/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/parts/utils/offline_clustering.py](https://localhost:8080/#) in getAffinityGraphMat(affinity_mat_raw, p_value)
349 symmetrize the binarized graph matrix.
350 """
--> 351 X = affinity_mat_raw if p_value <= 0 else getKneighborsConnections(affinity_mat_raw, p_value)
352 symm_affinity_mat = 0.5 * (X + X.T)
353 return symm_affinity_mat
[/usr/local/lib/python3.10/dist-packages/nemo/collections/asr/parts/utils/offline_clustering.py](https://localhost:8080/#) in getKneighborsConnections(affinity_mat, p_value, mask_method)
332 indices_col = torch.arange(dim[1]).repeat(p_value, 1).T.flatten()
333 if mask_method == 'binary' or mask_method is None:
--> 334 binarized_affinity_mat[indices_row, indices_col] = (
335 torch.ones(indices_row.shape[0]).to(affinity_mat.device).half()
336 )
IndexError: shape mismatch: indexing tensors could not be broadcast together with shapes [7557001], [7559750]
```
**Expected behavior**
Diarization shouldn't fail on a seemingly non-corrupt audio-file. This config has been tested multiple times before on other files without any issues.
**Environment overview (please complete the following information)**
- Environment location: Google Colab ( Freshly created )
- Method of NeMo install:
```
!apt-get update && apt-get install -y libsndfile1 ffmpeg
!pip install nemo_toolkit['asr']
```
**Environment details**
```
PRETTY_NAME="Ubuntu 22.04.3 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.3 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy
=============
2.1.0+cu121
=============
Python 3.10.12
``` | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8278/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8278/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8277 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8277/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8277/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8277/events | https://github.com/NVIDIA/NeMo/pull/8277 | 2,107,699,227 | PR_kwDOC_bI7s5lcYCV | 8,277 | Refactor: multi-node save best model only when needed | {
"login": "itzsimpl",
"id": 4784070,
"node_id": "MDQ6VXNlcjQ3ODQwNzA=",
"avatar_url": "https://avatars.githubusercontent.com/u/4784070?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/itzsimpl",
"html_url": "https://github.com/itzsimpl",
"followers_url": "https://api.github.com/users/itzsimpl/followers",
"following_url": "https://api.github.com/users/itzsimpl/following{/other_user}",
"gists_url": "https://api.github.com/users/itzsimpl/gists{/gist_id}",
"starred_url": "https://api.github.com/users/itzsimpl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itzsimpl/subscriptions",
"organizations_url": "https://api.github.com/users/itzsimpl/orgs",
"repos_url": "https://api.github.com/users/itzsimpl/repos",
"events_url": "https://api.github.com/users/itzsimpl/events{/privacy}",
"received_events_url": "https://api.github.com/users/itzsimpl/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6876332615,
"node_id": "LA_kwDOC_bI7s8AAAABmdyCRw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD",
"name": "Run CICD",
"color": "fef2c0",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@athitten @aklife97 anything else that needs to be addressed here? ",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"@titu1994 anything else that needs to be resolved here?",
"jenkins",
"@athitten for final approval, it looks ok to me ",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"@athitten status?",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"ping",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"@itzsimpl sorry this completely fell through the cracks. My apologies. Since the feature branch is in your personal forked version of NeMo, can I rebase your feature branch to latest main? There's a minor conflict that needs to be addressed for merging this PR.",
"Fixed, let me know if you need anything else.",
"> Fixed, let me know if you need anything else.\r\n\r\nThank you, we need to wait for the CI to pass. I have started the CI",
"@titu1994 do you want to take another pass over the PR and approve it since its a nemo core PR ? Sorry this was opened few months ago, but fell through the cracks from my end.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"@athitten @titu1994 anything else that needs to be done here?",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-30T12:09:24 | 2024-10-25T01:59:37 | 2024-10-25T01:59:36 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8277",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8277",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8277.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8277.patch",
"merged_at": null
} | # What does this PR do ?
Slight refactor of save best model, which may resolve or alleviate #7938 and #7756.
**Collection**: core
# Changelog
- sets previous_best_path in init, to have it correct on resume training
- compare previous_best_path and best_model_path, reload and save only if necessary, also on tain end
- skip reloading checkpoint in on_save_checkpioint; with previous_best_path being set properly the change can come only from the current state
also
- fix check_slurm, trainer.accelerator_connector.is_slurm_managing_tasks was dropped in lightning 1.6.0, hence the check was always false
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
@titu1994 please review, also check with distributed training
# Additional Information
* Related to #7938 #7756
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8277/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8277/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8276 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8276/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8276/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8276/events | https://github.com/NVIDIA/NeMo/issues/8276 | 2,107,410,896 | I_kwDOC_bI7s59nInQ | 8,276 | Input shape mismatch occured for features in module EncDecDiarLabelModel | {
"login": "acampbellblack",
"id": 53172488,
"node_id": "MDQ6VXNlcjUzMTcyNDg4",
"avatar_url": "https://avatars.githubusercontent.com/u/53172488?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/acampbellblack",
"html_url": "https://github.com/acampbellblack",
"followers_url": "https://api.github.com/users/acampbellblack/followers",
"following_url": "https://api.github.com/users/acampbellblack/following{/other_user}",
"gists_url": "https://api.github.com/users/acampbellblack/gists{/gist_id}",
"starred_url": "https://api.github.com/users/acampbellblack/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/acampbellblack/subscriptions",
"organizations_url": "https://api.github.com/users/acampbellblack/orgs",
"repos_url": "https://api.github.com/users/acampbellblack/repos",
"events_url": "https://api.github.com/users/acampbellblack/events{/privacy}",
"received_events_url": "https://api.github.com/users/acampbellblack/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | [
"Audio was stereo, my mistake"
] | 2024-01-30T09:56:31 | 2024-01-30T10:11:37 | 2024-01-30T10:11:36 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Encountering this error when running the speaker diarization training tutorial notebook on my own data:
Input shape mismatch occured for features in module EncDecDiarLabelModel :
Input shape expected = (batch, time) |
Input shape found : torch.Size([2, 208000, 2])
**Steps/Code to reproduce bug**
I have run the data preparation scripts 'pathfiles_to_diarize_manifest.py' and 'create_msdd_train_dataset.py' on my own data.
My own data consists of a single .wav and .rttm file for each of 'train' and 'valid'.
The training rttm has 9 speakers.
The pairwise rttm files have been created successfully.
I am then loading the 'msdd_5scl_15_05_50Povl_256x3x32x2.yaml' config file and setting it up as follows:
name: MultiscaleDiarDecoder
sample_rate: 16000
num_workers: 20
batch_size: 5
model:
diarizer:
out_dir: null
oracle_vad: true
speaker_embeddings:
model_path: titanet_large
parameters:
window_length_in_sec:
- 1.5
- 1.25
- 1.0
- 0.75
- 0.5
shift_length_in_sec:
- 0.75
- 0.625
- 0.5
- 0.375
- 0.25
multiscale_weights:
- 1
- 1
- 1
- 1
- 1
save_embeddings: true
num_workers: 20
max_num_of_spks: 2
scale_n: 5
soft_label_thres: 0.5
emb_batch_size: 0
train_ds:
manifest_filepath: train/msdd_data.50step.json
emb_dir: train
sample_rate: ${sample_rate}
num_spks: ${model.max_num_of_spks}
soft_label_thres: ${model.soft_label_thres}
labels: null
batch_size: ${batch_size}
emb_batch_size: ${model.emb_batch_size}
shuffle: true
validation_ds:
manifest_filepath: valid/msdd_data.50step.json
emb_dir: valid
sample_rate: ${sample_rate}
num_spks: ${model.max_num_of_spks}
soft_label_thres: ${model.soft_label_thres}
labels: null
batch_size: 2
emb_batch_size: ${model.emb_batch_size}
shuffle: false
test_ds:
manifest_filepath: null
emb_dir: null
sample_rate: 16000
num_spks: ${model.max_num_of_spks}
soft_label_thres: ${model.soft_label_thres}
labels: null
batch_size: 2
shuffle: false
seq_eval_mode: false
preprocessor:
_target_: nemo.collections.asr.modules.AudioToMelSpectrogramPreprocessor
normalize: per_feature
window_size: 0.025
sample_rate: ${sample_rate}
window_stride: 0.01
window: hann
features: 80
n_fft: 512
frame_splicing: 1
dither: 1.0e-05
msdd_module:
_target_: nemo.collections.asr.modules.msdd_diarizer.MSDD_module
num_spks: ${model.max_num_of_spks}
hidden_size: 256
num_lstm_layers: 3
dropout_rate: 0.5
cnn_output_ch: 32
conv_repeat: 2
emb_dim: 192
scale_n: 5
weighting_scheme: conv_scale_weight
context_vector_type: cos_sim
loss:
_target_: nemo.collections.asr.losses.bce_loss.BCELoss
weight: null
optim:
name: adam
lr: 0.001
weight_decay: 0.001
sched:
name: CosineAnnealing
min_lr: 1.0e-05
speaker_model_cfg:
model_defaults:
filters: 1024
repeat: 3
dropout: 0.1
separable: true
se: true
se_context_size: -1
kernel_size_factor: 1.0
preprocessor:
_target_: nemo.collections.asr.modules.AudioToMelSpectrogramPreprocessor
normalize: per_feature
window_size: 0.025
sample_rate: 16000
window_stride: 0.01
window: hann
features: 80
n_fft: 512
frame_splicing: 1
dither: 1.0e-05
spec_augment:
_target_: nemo.collections.asr.modules.SpectrogramAugmentation
freq_masks: 3
freq_width: 4
time_masks: 5
time_width: 0.03
encoder:
_target_: nemo.collections.asr.modules.ConvASREncoder
feat_in: 80
activation: relu
conv_mask: true
jasper:
- filters: 1024
repeat: 1
kernel:
- 3
stride:
- 1
dilation:
- 1
dropout: 0.0
residual: false
separable: true
se: true
se_context_size: -1
- filters: 1024
repeat: 3
kernel:
- 7
stride:
- 1
dilation:
- 1
dropout: 0.1
residual: true
separable: true
se: true
se_context_size: -1
- filters: 1024
repeat: 3
kernel:
- 11
stride:
- 1
dilation:
- 1
dropout: 0.1
residual: true
separable: true
se: true
se_context_size: -1
- filters: 1024
repeat: 3
kernel:
- 15
stride:
- 1
dilation:
- 1
dropout: 0.1
residual: true
separable: true
se: true
se_context_size: -1
- filters: 3072
repeat: 1
kernel:
- 1
stride:
- 1
dilation:
- 1
dropout: 0.0
residual: false
separable: true
se: true
se_context_size: -1
decoder:
_target_: nemo.collections.asr.modules.SpeakerDecoder
feat_in: 3072
num_classes: 16681
pool_mode: attention
emb_sizes: 192
loss:
_target_: nemo.collections.asr.losses.angularloss.AngularSoftmaxLoss
scale: 30
margin: 0.2
optim:
name: sgd
lr: 0.08
weight_decay: 0.0002
sched:
name: CosineAnnealing
warmup_ratio: 0.1
min_lr: 0.0
momentum: 0.9
target: nemo.collections.asr.models.label_models.EncDecSpeakerLabelModel
nemo_version: 1.23.0rc0
trainer:
devices: 1
accelerator: gpu
max_epochs: 5
max_steps: -1
num_nodes: 1
strategy: auto
accumulate_grad_batches: 1
deterministic: true
enable_checkpointing: false
logger: false
log_every_n_steps: 1
val_check_interval: 1.0
exp_manager:
exp_dir: null
name: ${name}
create_tensorboard_logger: true
create_checkpoint_callback: true
create_wandb_logger: false
checkpoint_callback_params:
monitor: val_loss
mode: min
save_top_k: 30
every_n_epochs: 1
wandb_logger_kwargs:
name: null
project: null
emb_batch_size: 0
I am then attempting to run the trainer when encountering the above error.
**Environment overview (please complete the following information)**
- Environment location: Bare-metal
- Method of NeMo install: python -m pip install git+https://github.com/NVIDIA/NeMo.git@$BRANCH#egg=nemo_toolkit[all]
**Environment details**
- Windows 11 WSL2 Ubuntu 22.04.3
- torch=2.1.2+cu118
- Python 3.10.2
**Additional context**
GPU Model: Nvidia RTX 4080 Mobile
| {
"login": "acampbellblack",
"id": 53172488,
"node_id": "MDQ6VXNlcjUzMTcyNDg4",
"avatar_url": "https://avatars.githubusercontent.com/u/53172488?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/acampbellblack",
"html_url": "https://github.com/acampbellblack",
"followers_url": "https://api.github.com/users/acampbellblack/followers",
"following_url": "https://api.github.com/users/acampbellblack/following{/other_user}",
"gists_url": "https://api.github.com/users/acampbellblack/gists{/gist_id}",
"starred_url": "https://api.github.com/users/acampbellblack/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/acampbellblack/subscriptions",
"organizations_url": "https://api.github.com/users/acampbellblack/orgs",
"repos_url": "https://api.github.com/users/acampbellblack/repos",
"events_url": "https://api.github.com/users/acampbellblack/events{/privacy}",
"received_events_url": "https://api.github.com/users/acampbellblack/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8276/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8276/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8275 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8275/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8275/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8275/events | https://github.com/NVIDIA/NeMo/pull/8275 | 2,106,807,339 | PR_kwDOC_bI7s5lZXGD | 8,275 | fix peft mixin arguments to follow mcore 0.5 | {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"closing as this is now addressed in #7988"
] | 2024-01-30T02:08:07 | 2024-02-12T21:38:06 | 2024-02-12T21:38:05 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8275",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8275",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8275.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8275.patch",
"merged_at": null
} | # What does this PR do ?
- mcore TransformerLayer introduced packed_seq_params, adding it to `MCoreTransformerLayerMixin`
- mcore renamed `bias_gelu_fusion` to `bias_activation_fusion`, changing it in adapter mcore_mixins
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8275/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8275/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8274 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8274/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8274/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8274/events | https://github.com/NVIDIA/NeMo/pull/8274 | 2,106,620,945 | PR_kwDOC_bI7s5lYuxz | 8,274 | Pretraining + Instruction Tuning + Inference Config Recipes [Video-NeVA] | {
"login": "PannuMuthu",
"id": 30813477,
"node_id": "MDQ6VXNlcjMwODEzNDc3",
"avatar_url": "https://avatars.githubusercontent.com/u/30813477?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PannuMuthu",
"html_url": "https://github.com/PannuMuthu",
"followers_url": "https://api.github.com/users/PannuMuthu/followers",
"following_url": "https://api.github.com/users/PannuMuthu/following{/other_user}",
"gists_url": "https://api.github.com/users/PannuMuthu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PannuMuthu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PannuMuthu/subscriptions",
"organizations_url": "https://api.github.com/users/PannuMuthu/orgs",
"repos_url": "https://api.github.com/users/PannuMuthu/repos",
"events_url": "https://api.github.com/users/PannuMuthu/events{/privacy}",
"received_events_url": "https://api.github.com/users/PannuMuthu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-29T23:24:33 | 2024-02-23T01:43:46 | 2024-02-23T01:43:46 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8274",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8274",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8274.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8274.patch",
"merged_at": null
} | # What does this PR do ?
This PR adds config recipes for pretraining, instruction tuning, and inference for VideoNeVA derived from Video-LLaVA
**Collection**: Multimodal
# Changelog
- Adds `video_llava_config.yaml` config recipe derived from authors pretraining configuration in Video-LLaVA
- Adds `video_neva_config.yaml` config recipe adapted from `video_llava_config.yaml` for NeMo (similar to `neva_config.yaml` vs `video_neva_config.yaml`)
- Adds `video_neva_finetune.yaml` config recipe derived from authors finetuning configuration in Video-LLaVA
- Adds `video_neva_inference.yaml` config recipe derived from authors inference configuration in Video-LLaVA
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8274/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8274/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8273 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8273/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8273/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8273/events | https://github.com/NVIDIA/NeMo/pull/8273 | 2,106,354,764 | PR_kwDOC_bI7s5lX0dv | 8,273 | fused_adam + mcore fix | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins"
] | 2024-01-29T20:24:32 | 2024-01-30T20:05:39 | 2024-01-30T20:05:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8273",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8273",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8273.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8273.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8273/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8273/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8272 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8272/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8272/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8272/events | https://github.com/NVIDIA/NeMo/pull/8272 | 2,106,200,444 | PR_kwDOC_bI7s5lXSta | 8,272 | Converter script fixes for mixtral/mistral | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins"
] | 2024-01-29T18:51:33 | 2024-02-06T12:49:32 | 2024-02-06T12:49:32 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8272",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8272",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8272.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8272.patch",
"merged_at": "2024-02-06T12:49:32"
} | # What does this PR do ?
Fixes mistral & mixtral conversion scripts(renamed variable `num_experts` to `num_moe_experts` in mixtral converter).
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8272/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8272/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8271 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8271/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8271/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8271/events | https://github.com/NVIDIA/NeMo/pull/8271 | 2,106,170,896 | PR_kwDOC_bI7s5lXMPY | 8,271 | Multimodal r1.23.0 fixes | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-01-29T18:33:29 | 2024-02-01T21:12:52 | 2024-02-01T21:12:52 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8271",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8271",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8271.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8271.patch",
"merged_at": null
} | # What does this PR do ?
Fix r1.23.0 issues for multimodal collection
**Collection**: [Multimodal]
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8271/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8271/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8270 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8270/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8270/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8270/events | https://github.com/NVIDIA/NeMo/pull/8270 | 2,106,097,961 | PR_kwDOC_bI7s5lW8QT | 8,270 | training bug fix and adding launch script for speech_multitask | {
"login": "krishnacpuvvada",
"id": 93558329,
"node_id": "U_kgDOBZOWOQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93558329?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/krishnacpuvvada",
"html_url": "https://github.com/krishnacpuvvada",
"followers_url": "https://api.github.com/users/krishnacpuvvada/followers",
"following_url": "https://api.github.com/users/krishnacpuvvada/following{/other_user}",
"gists_url": "https://api.github.com/users/krishnacpuvvada/gists{/gist_id}",
"starred_url": "https://api.github.com/users/krishnacpuvvada/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/krishnacpuvvada/subscriptions",
"organizations_url": "https://api.github.com/users/krishnacpuvvada/orgs",
"repos_url": "https://api.github.com/users/krishnacpuvvada/repos",
"events_url": "https://api.github.com/users/krishnacpuvvada/events{/privacy}",
"received_events_url": "https://api.github.com/users/krishnacpuvvada/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-01-29T17:49:04 | 2024-01-29T23:36:50 | 2024-01-29T23:36:38 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8270",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8270",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8270.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8270.patch",
"merged_at": "2024-01-29T23:36:38"
} | # What does this PR do ?
Fixes some bugs related to training after canary-2 refactor
Adds a launch script for AED multitask models in `examples/asr/speech_multitask` folder
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "krishnacpuvvada",
"id": 93558329,
"node_id": "U_kgDOBZOWOQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93558329?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/krishnacpuvvada",
"html_url": "https://github.com/krishnacpuvvada",
"followers_url": "https://api.github.com/users/krishnacpuvvada/followers",
"following_url": "https://api.github.com/users/krishnacpuvvada/following{/other_user}",
"gists_url": "https://api.github.com/users/krishnacpuvvada/gists{/gist_id}",
"starred_url": "https://api.github.com/users/krishnacpuvvada/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/krishnacpuvvada/subscriptions",
"organizations_url": "https://api.github.com/users/krishnacpuvvada/orgs",
"repos_url": "https://api.github.com/users/krishnacpuvvada/repos",
"events_url": "https://api.github.com/users/krishnacpuvvada/events{/privacy}",
"received_events_url": "https://api.github.com/users/krishnacpuvvada/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8270/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8270/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8269 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8269/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8269/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8269/events | https://github.com/NVIDIA/NeMo/pull/8269 | 2,106,045,872 | PR_kwDOC_bI7s5lWwnN | 8,269 | blogpost for Parakeet-TDT model | {
"login": "hainan-xv",
"id": 5440014,
"node_id": "MDQ6VXNlcjU0NDAwMTQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/5440014?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hainan-xv",
"html_url": "https://github.com/hainan-xv",
"followers_url": "https://api.github.com/users/hainan-xv/followers",
"following_url": "https://api.github.com/users/hainan-xv/following{/other_user}",
"gists_url": "https://api.github.com/users/hainan-xv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hainan-xv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hainan-xv/subscriptions",
"organizations_url": "https://api.github.com/users/hainan-xv/orgs",
"repos_url": "https://api.github.com/users/hainan-xv/repos",
"events_url": "https://api.github.com/users/hainan-xv/events{/privacy}",
"received_events_url": "https://api.github.com/users/hainan-xv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-01-29T17:22:59 | 2024-01-31T14:30:50 | 2024-01-31T14:30:50 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8269",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8269",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8269.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8269.patch",
"merged_at": "2024-01-31T14:30:50"
} | # What does this PR do ?
blogpost for Parakeet-TDT model
**Collection**: [Note which collection this PR will affect]
# Changelog
blogpost for Parakeet-TDT model
# Usage
N/A
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8269/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8269/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8268 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8268/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8268/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8268/events | https://github.com/NVIDIA/NeMo/pull/8268 | 2,105,524,075 | PR_kwDOC_bI7s5lU9TO | 8,268 | Neftune | {
"login": "jubick1337",
"id": 16004982,
"node_id": "MDQ6VXNlcjE2MDA0OTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/16004982?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jubick1337",
"html_url": "https://github.com/jubick1337",
"followers_url": "https://api.github.com/users/jubick1337/followers",
"following_url": "https://api.github.com/users/jubick1337/following{/other_user}",
"gists_url": "https://api.github.com/users/jubick1337/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jubick1337/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jubick1337/subscriptions",
"organizations_url": "https://api.github.com/users/jubick1337/orgs",
"repos_url": "https://api.github.com/users/jubick1337/repos",
"events_url": "https://api.github.com/users/jubick1337/events{/privacy}",
"received_events_url": "https://api.github.com/users/jubick1337/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-29T13:38:44 | 2024-03-08T01:44:01 | 2024-03-08T01:44:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8268",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8268",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8268.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8268.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8268/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8268/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8267 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8267/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8267/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8267/events | https://github.com/NVIDIA/NeMo/issues/8267 | 2,105,474,728 | I_kwDOC_bI7s59fv6o | 8,267 | create_alignment_manifest.py conf ValueError | {
"login": "acampbellblack",
"id": 53172488,
"node_id": "MDQ6VXNlcjUzMTcyNDg4",
"avatar_url": "https://avatars.githubusercontent.com/u/53172488?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/acampbellblack",
"html_url": "https://github.com/acampbellblack",
"followers_url": "https://api.github.com/users/acampbellblack/followers",
"following_url": "https://api.github.com/users/acampbellblack/following{/other_user}",
"gists_url": "https://api.github.com/users/acampbellblack/gists{/gist_id}",
"starred_url": "https://api.github.com/users/acampbellblack/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/acampbellblack/subscriptions",
"organizations_url": "https://api.github.com/users/acampbellblack/orgs",
"repos_url": "https://api.github.com/users/acampbellblack/repos",
"events_url": "https://api.github.com/users/acampbellblack/events{/privacy}",
"received_events_url": "https://api.github.com/users/acampbellblack/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-29T13:13:48 | 2024-03-08T01:44:04 | 2024-03-08T01:44:03 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Run the Speaker_Diarization_Training.ipynb notebook.
Run this cell:
!python NeMo/scripts/speaker_tasks/create_alignment_manifest.py \
--input_manifest_filepath LibriSpeech/dev_clean.json \
--base_alignment_path LibriSpeech_Alignments \
--output_manifest_filepath ./dev-clean-align.json \
--ctm_output_directory ./ctm_out \
--libri_dataset_split dev-clean
This cell produces the following error:
File "/home/acampbellblack/dev/py/nemo-training/.venv/lib/python3.10/site-packages/nemo/collections/asr/parts/utils/manifest_utils.py", line 110, in get_ctm_line
raise ValueError(f"`conf` must be a float or str containing float, but got {type(conf)}")
ValueError: `conf` must be a float or str containing float, but got <class 'int'>
Running locally (bare-metal), installed NeMo via install script in the notebook:
! python -m pip install git+https://github.com/NVIDIA/NeMo.git@$BRANCH#egg=nemo_toolkit[all]
Running on WSL on Windows 11,
Ubuntu 22.04.3 LTS
Python 3.10.12
torch==2.1.2+cu118
GPU: NVidia RTX 4080 Laptop | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8267/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8267/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8265 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8265/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8265/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8265/events | https://github.com/NVIDIA/NeMo/pull/8265 | 2,104,551,275 | PR_kwDOC_bI7s5lRoAy | 8,265 | Llama2 tp overlap cfg | {
"login": "sanandaraj5597",
"id": 55270934,
"node_id": "MDQ6VXNlcjU1MjcwOTM0",
"avatar_url": "https://avatars.githubusercontent.com/u/55270934?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sanandaraj5597",
"html_url": "https://github.com/sanandaraj5597",
"followers_url": "https://api.github.com/users/sanandaraj5597/followers",
"following_url": "https://api.github.com/users/sanandaraj5597/following{/other_user}",
"gists_url": "https://api.github.com/users/sanandaraj5597/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sanandaraj5597/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sanandaraj5597/subscriptions",
"organizations_url": "https://api.github.com/users/sanandaraj5597/orgs",
"repos_url": "https://api.github.com/users/sanandaraj5597/repos",
"events_url": "https://api.github.com/users/sanandaraj5597/events{/privacy}",
"received_events_url": "https://api.github.com/users/sanandaraj5597/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-01-29T03:12:38 | 2024-02-07T00:18:15 | 2024-02-07T00:18:15 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8265",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8265",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8265.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8265.patch",
"merged_at": null
} | # What does this PR do ?
Added dummy tp_overlap_cfgs for LLAMA2 hidden size/TP size. | {
"login": "sanandaraj5597",
"id": 55270934,
"node_id": "MDQ6VXNlcjU1MjcwOTM0",
"avatar_url": "https://avatars.githubusercontent.com/u/55270934?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sanandaraj5597",
"html_url": "https://github.com/sanandaraj5597",
"followers_url": "https://api.github.com/users/sanandaraj5597/followers",
"following_url": "https://api.github.com/users/sanandaraj5597/following{/other_user}",
"gists_url": "https://api.github.com/users/sanandaraj5597/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sanandaraj5597/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sanandaraj5597/subscriptions",
"organizations_url": "https://api.github.com/users/sanandaraj5597/orgs",
"repos_url": "https://api.github.com/users/sanandaraj5597/repos",
"events_url": "https://api.github.com/users/sanandaraj5597/events{/privacy}",
"received_events_url": "https://api.github.com/users/sanandaraj5597/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8265/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8265/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8263 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8263/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8263/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8263/events | https://github.com/NVIDIA/NeMo/pull/8263 | 2,104,020,620 | PR_kwDOC_bI7s5lP59v | 8,263 | Support uploading NeMo models to HF via `push_to_hf_hub()` | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"jenkins"
] | 2024-01-28T07:48:45 | 2024-02-06T00:26:44 | 2024-02-06T00:26:43 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8263",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8263",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8263.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8263.patch",
"merged_at": "2024-02-06T00:26:43"
} | # What does this PR do ?
Adds the ability to upload NeMo models to Huggingface, and restore NeMo models from unpacked HF directory.
**Collection**: [Core]
# Changelog
- Support upload to HF via `push_to_hf_hub()` in Model/ModelPT
- Support uploading single .nemo file or full folder of unpacked nemo file. Full folder is useful for LLMs where the single nemo file is larger than HF upload limit of 10 GB per uploaded object.
- Support restoring unpacked NeMo file when downloading from Huggingface hub
# Usage
## Upload loaded model
```python
token = "<HF TOKEN>" or None
pack_nemo_file = True # False uploads multiple files that comprise the NeMo file onto HF Hub; Easier for LLMs
model.push_to_hf_hub(
repo_id=repo_id, pack_nemo_file=True, token=token,
)
```
## Supports most HF Upload arguments such as private upload
```python
model.push_to_hf_hub(
repo_id=repo_id, pack_nemo_file=False, token=token, private=True
)
```
## Modify model card with helpers
```python
template = """ <Your own custom template>
# {model_name}
"""
kwargs = {"model_name": "ABC", "repo_id": "nvidia/ABC_XYZ"}
model_card = model.generate_model_card(template=template, template_kwargs=kwargs, type="hf")
model.push_to_hf_hub(
repo_id=repo_id, token=token, model_card=model_card
)
```
## Modify model card with custom class
```python
class MyModelCard:
def __init__(self, model_name):
self.model_name = model_name
def __repr__(self):
template = """
This is the {model_name} model
""".format(model_name=self.model_name)
return template
model.push_to_hf_hub(
repo_id=repo_id, token=token, model_card=MyModelCard("ABC")
)
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8263/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8263/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8262 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8262/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8262/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8262/events | https://github.com/NVIDIA/NeMo/pull/8262 | 2,103,826,255 | PR_kwDOC_bI7s5lPThB | 8,262 | Update PEFT Doc | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-01-27T21:46:26 | 2024-02-03T00:06:50 | 2024-02-03T00:06:49 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8262",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8262",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8262.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8262.patch",
"merged_at": "2024-02-03T00:06:49"
} | # What does this PR do ?
Update models names in supported models
Remove old prompt learning doc and notebook
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8262/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8262/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8261 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8261/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8261/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8261/events | https://github.com/NVIDIA/NeMo/pull/8261 | 2,103,475,258 | PR_kwDOC_bI7s5lOQtT | 8,261 | fixes to accomendate mcore changes | {
"login": "HuiyingLi",
"id": 1331543,
"node_id": "MDQ6VXNlcjEzMzE1NDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1331543?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HuiyingLi",
"html_url": "https://github.com/HuiyingLi",
"followers_url": "https://api.github.com/users/HuiyingLi/followers",
"following_url": "https://api.github.com/users/HuiyingLi/following{/other_user}",
"gists_url": "https://api.github.com/users/HuiyingLi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/HuiyingLi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HuiyingLi/subscriptions",
"organizations_url": "https://api.github.com/users/HuiyingLi/orgs",
"repos_url": "https://api.github.com/users/HuiyingLi/repos",
"events_url": "https://api.github.com/users/HuiyingLi/events{/privacy}",
"received_events_url": "https://api.github.com/users/HuiyingLi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins"
] | 2024-01-27T09:38:22 | 2024-01-28T03:06:28 | 2024-01-27T23:54:18 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8261",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8261",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8261.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8261.patch",
"merged_at": "2024-01-27T23:54:18"
} | # What does this PR do ?
- Remove FalconTransformerLayer's sharded_state_dict() to use the mcore 0.5's TransformerLayer's sharded_state_dict() because it supports sharded_dict according to submodules now.
- add packed_seq_params (introduced in mcore 0.5) args for layer forward.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pablo-garay",
"id": 7166088,
"node_id": "MDQ6VXNlcjcxNjYwODg=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166088?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pablo-garay",
"html_url": "https://github.com/pablo-garay",
"followers_url": "https://api.github.com/users/pablo-garay/followers",
"following_url": "https://api.github.com/users/pablo-garay/following{/other_user}",
"gists_url": "https://api.github.com/users/pablo-garay/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pablo-garay/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pablo-garay/subscriptions",
"organizations_url": "https://api.github.com/users/pablo-garay/orgs",
"repos_url": "https://api.github.com/users/pablo-garay/repos",
"events_url": "https://api.github.com/users/pablo-garay/events{/privacy}",
"received_events_url": "https://api.github.com/users/pablo-garay/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8261/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8261/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8260 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8260/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8260/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8260/events | https://github.com/NVIDIA/NeMo/pull/8260 | 2,103,386,075 | PR_kwDOC_bI7s5lN9MA | 8,260 | Refactor Canary to follow schema of remaining ASR models | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-01-27T07:41:09 | 2024-01-27T22:27:34 | 2024-01-27T22:11:58 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8260",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8260",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8260.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8260.patch",
"merged_at": "2024-01-27T22:11:58"
} | # What does this PR do ?
Refactor Canary to follow Archetype pattern of rest of ASR. Add Decoding Strategy to disentangle decoding with model architecture.
**Collection**: [ASR]
# Changelog
- Refactors model class to conform to ASR's archetype pattern
- Add Decoding strategy as a middle layer between model logits and text to allow extending decoding algorithms in the future
- Update configs to new schema
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8260/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8260/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8259 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8259/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8259/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8259/events | https://github.com/NVIDIA/NeMo/pull/8259 | 2,103,155,870 | PR_kwDOC_bI7s5lNXf1 | 8,259 | update webdataset to latest version | {
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-27T03:04:23 | 2024-02-18T01:44:53 | 2024-02-18T01:44:53 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8259",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8259",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8259.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8259.patch",
"merged_at": null
} | Initial commit.
> Update version to 0.2.86
> Pipe functionality removed and has been replaced with DataPipeline.
Draft version, In works | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8259/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8259/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8258 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8258/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8258/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8258/events | https://github.com/NVIDIA/NeMo/pull/8258 | 2,103,102,821 | PR_kwDOC_bI7s5lNNZA | 8,258 | fix transcribe config | {
"login": "stevehuang52",
"id": 105218074,
"node_id": "U_kgDOBkWAGg",
"avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stevehuang52",
"html_url": "https://github.com/stevehuang52",
"followers_url": "https://api.github.com/users/stevehuang52/followers",
"following_url": "https://api.github.com/users/stevehuang52/following{/other_user}",
"gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}",
"starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions",
"organizations_url": "https://api.github.com/users/stevehuang52/orgs",
"repos_url": "https://api.github.com/users/stevehuang52/repos",
"events_url": "https://api.github.com/users/stevehuang52/events{/privacy}",
"received_events_url": "https://api.github.com/users/stevehuang52/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-01-27T00:43:05 | 2024-02-23T14:56:26 | 2024-01-27T15:41:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8258",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8258",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8258.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8258.patch",
"merged_at": null
} | Fix transcribe config to use model's config | {
"login": "stevehuang52",
"id": 105218074,
"node_id": "U_kgDOBkWAGg",
"avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stevehuang52",
"html_url": "https://github.com/stevehuang52",
"followers_url": "https://api.github.com/users/stevehuang52/followers",
"following_url": "https://api.github.com/users/stevehuang52/following{/other_user}",
"gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}",
"starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions",
"organizations_url": "https://api.github.com/users/stevehuang52/orgs",
"repos_url": "https://api.github.com/users/stevehuang52/repos",
"events_url": "https://api.github.com/users/stevehuang52/events{/privacy}",
"received_events_url": "https://api.github.com/users/stevehuang52/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8258/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8258/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8257 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8257/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8257/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8257/events | https://github.com/NVIDIA/NeMo/pull/8257 | 2,103,016,067 | PR_kwDOC_bI7s5lM7XW | 8,257 | [tutorial] fixed missing RIR scripts file. | {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins"
] | 2024-01-26T22:43:52 | 2024-01-29T23:46:29 | 2024-01-29T23:46:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8257",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8257",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8257.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8257.patch",
"merged_at": "2024-01-29T23:46:29"
} | # What does this PR do ?
missing get_openslr_rir_data.py file in RIR section.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "XuesongYang",
"id": 1646669,
"node_id": "MDQ6VXNlcjE2NDY2Njk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1646669?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuesongYang",
"html_url": "https://github.com/XuesongYang",
"followers_url": "https://api.github.com/users/XuesongYang/followers",
"following_url": "https://api.github.com/users/XuesongYang/following{/other_user}",
"gists_url": "https://api.github.com/users/XuesongYang/gists{/gist_id}",
"starred_url": "https://api.github.com/users/XuesongYang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/XuesongYang/subscriptions",
"organizations_url": "https://api.github.com/users/XuesongYang/orgs",
"repos_url": "https://api.github.com/users/XuesongYang/repos",
"events_url": "https://api.github.com/users/XuesongYang/events{/privacy}",
"received_events_url": "https://api.github.com/users/XuesongYang/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8257/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8257/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8256 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8256/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8256/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8256/events | https://github.com/NVIDIA/NeMo/issues/8256 | 2,102,782,199 | I_kwDOC_bI7s59Vej3 | 8,256 | Problem with fine tuning fastconformer_hybrid_large_streaming_multi model on another language | {
"login": "traidn",
"id": 130984174,
"node_id": "U_kgDOB86o7g",
"avatar_url": "https://avatars.githubusercontent.com/u/130984174?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/traidn",
"html_url": "https://github.com/traidn",
"followers_url": "https://api.github.com/users/traidn/followers",
"following_url": "https://api.github.com/users/traidn/following{/other_user}",
"gists_url": "https://api.github.com/users/traidn/gists{/gist_id}",
"starred_url": "https://api.github.com/users/traidn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/traidn/subscriptions",
"organizations_url": "https://api.github.com/users/traidn/orgs",
"repos_url": "https://api.github.com/users/traidn/repos",
"events_url": "https://api.github.com/users/traidn/events{/privacy}",
"received_events_url": "https://api.github.com/users/traidn/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "VahidooX",
"id": 23551647,
"node_id": "MDQ6VXNlcjIzNTUxNjQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/23551647?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VahidooX",
"html_url": "https://github.com/VahidooX",
"followers_url": "https://api.github.com/users/VahidooX/followers",
"following_url": "https://api.github.com/users/VahidooX/following{/other_user}",
"gists_url": "https://api.github.com/users/VahidooX/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VahidooX/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VahidooX/subscriptions",
"organizations_url": "https://api.github.com/users/VahidooX/orgs",
"repos_url": "https://api.github.com/users/VahidooX/repos",
"events_url": "https://api.github.com/users/VahidooX/events{/privacy}",
"received_events_url": "https://api.github.com/users/VahidooX/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"To confirm, you're using a fine-tuning script from NeMo right ? The one inside examples ?\r\n\r\n@VahidooX is there something up with the checkpoint ? The config seems ok. ",
"Plus that's not exactly the write command for extract - the key is one of the modules inside of the actual model not the model name. But anyway we don't support inference or training with bare pt ckpt, only with NeMo files usually ",
"Your model file looks like to be corrupted. Please download it and try again. Even training from scratch should work. In that issue, they used a very small batch size which is not easy to train an model with.",
"@VahidooX I've tried to use script for inference this model on audio file and it works fine. It makes a good transcription on english language, but when i try to use it in training it still throws the mistake.",
"@titu1994 I use script `speech_to_text_hybrid_rnnt_ctc_bpe.py` from your repo. It works fine for training from scratch (actually it doesn't converge but it at least does something), but it throws the mistake in case of fine tuning.\r\n\r\nFull code:\r\n```\r\nimport pytorch_lightning as pl\r\nfrom omegaconf import OmegaConf\r\n\r\nfrom nemo.collections.asr.models import EncDecHybridRNNTCTCBPEModel\r\nfrom nemo.core.config import hydra_runner\r\nfrom nemo.utils import logging\r\nfrom nemo.utils.exp_manager import exp_manager\r\n\r\n\r\n@hydra_runner(\r\n config_path=\"./conf\", config_name=\"fastconformer_hybrid_transducer_ctc_bpe_streaming.yaml\"\r\n)\r\ndef main(cfg):\r\n logging.info(f'Hydra config: {OmegaConf.to_yaml(cfg)}')\r\n\r\n trainer = pl.Trainer(**cfg.trainer)\r\n exp_manager(trainer, cfg.get(\"exp_manager\", None))\r\n asr_model = EncDecHybridRNNTCTCBPEModel(cfg=cfg.model, trainer=trainer)\r\n\r\n # Initialize the weights of the model from another model, if provided via config\r\n asr_model.maybe_init_from_pretrained_checkpoint(cfg)\r\n\r\n trainer.fit(asr_model)\r\n\r\n if hasattr(cfg.model, 'test_ds') and cfg.model.test_ds.manifest_filepath is not None:\r\n if asr_model.prepare_test(trainer):\r\n trainer.test(asr_model)\r\n\r\n\r\nif __name__ == '__main__':\r\n main() # noqa pylint: disable=no-value-for-parameter\r\n\r\n```\r\n\r\nMay be I should use something else?",
"@traidn, maybe this is not an official way, but you can try \r\n```\r\nstate_dict = torch.load(\"model_weights.ckpt\", map_location=device)\r\nasr_model.load_state_dict(state_dict)\r\n```\r\n\r\nyou can get `model_weights.ckpt` if you unpack the nemo checkpoint with `tar xvf`",
"@bene-ges Yeah, it allows to get weight, but unfortunately it gives me error \r\n```\r\nreturn checkpoint[\"pytorch-lightning_version\"]\r\nKeyError: 'pytorch-lightning_version'\r\n```\r\nin the start of trainng.\r\n",
"@traidn - maybe you can try to load weights and then train like you did from scratch? Without resuming from checkpoint",
"@bene-ges Thanks for idea, but it still gives keyerror with pytorch `pytorch-lightning_version` when I load state dict. Even if I leave field \"resume_from_checkpoint\" empty.",
"I am going to try this model next week to make sure it is not a bug. Have you tried the latest nemo release or one of the old releases to convert and train the model?",
"@VahidooX That will be appreciated. I use nemo-toolkit 1.21.0 and pytorch 2.1.1.\r\n",
"In the meantime, would you please try an older nemo version for both conversion and training?",
"I tried a previous version. And it still doesn't work properly. Unfortunately I can't install more older version right now in my environment due to i have troubles with building wheels.",
"@VahidooX I downgraded Nemo to version 1.20.0 (when the models STT En FastConformer Hybrid Large Streaming 1040ms (doesn't train too) and STT En FastConformer Hybrid Transducer-CTC Large Streaming Multi were presented). I download config file from branch r1.20.0. But it still throws the error with `KeyError: \"filename 'storages' not found\"` . And one more question. Does this two models (STT En FastConformer Hybrid Large Streaming 1040ms and STT En FastConformer Hybrid Transducer-CTC Large Streaming Multi) differ by only one line in the config - att_context_size? Because both modelcard link to the same [config](https://github.com/NVIDIA/NeMo/blob/r1.20.0/examples/asr/conf/fastconformer/hybrid_cache_aware_streaming/fastconformer_hybrid_transducer_ctc_bpe_streaming.yaml) file.",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-26T19:32:44 | 2024-03-21T01:44:20 | 2024-03-21T01:44:18 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello! I want to train hybrid model like [that](https://catalog.ngc.nvidia.com/orgs/nvidia/teams/nemo/models/stt_en_fastconformer_hybrid_large_streaming_multi) for russian language. First of all I tried to train it from scratch on Golos dataset (~1100 hours), but I encountered problem with bad converge (like in this [issue](https://github.com/NVIDIA/NeMo/issues/8185)). Even after 49 epoch WER was 1.0. After that I decided to try to use pretrained english model and fine tune it for new language.
I created new tokenizer for my dataset and insert path to it in config file. I used almost default config from model card:
```
name: "FastConformer-Hybrid-Transducer-CTC-BPE-Streaming-FineTuned-on-English"
model:
sample_rate: 16000
compute_eval_loss: false # eval samples can be very long and exhaust memory. Disable computation of transducer loss during validation/testing with this flag.
log_prediction: true # enables logging sample predictions in the output during training
skip_nan_grad: false
model_defaults:
enc_hidden: ${model.encoder.d_model}
pred_hidden: 640
joint_hidden: 640
train_ds:
manifest_filepath: "/home/user/Downloads/Golos_dataset/train/golos_manifest.jsonl"
sample_rate: ${model.sample_rate}
batch_size: 12 # you may increase batch_size if your memory allows
shuffle: true
num_workers: 8
pin_memory: true
max_duration: 20 # you may need to update it for your dataset
min_duration: 0.1
# tarred datasets
is_tarred: false
tarred_audio_filepaths: null
shuffle_n: 2048
# bucketing params
bucketing_strategy: "synced_randomized"
bucketing_batch_size: null
validation_ds:
manifest_filepath: "/home/user/Downloads/Golos_dataset/train/1hour.jsonl"
sample_rate: ${model.sample_rate}
batch_size: 12
shuffle: false
use_start_end_token: false
num_workers: 8
pin_memory: true
test_ds:
manifest_filepath: "/home/user/Downloads/Golos_dataset/train/1hour.jsonl"
sample_rate: ${model.sample_rate}
batch_size: 16
shuffle: false
use_start_end_token: false
num_workers: 8
pin_memory: true
tokenizer:
dir: "/home/user/PycharmProjects/NEMO_Project/fast_conformer/unigram_tokenizer/tokenizer_spe_unigram_v1024" # path to directory which contains either tokenizer.model (bpe) or vocab.txt (for wpe)
type: bpe # Can be either bpe (SentencePiece tokenizer) or wpe (WordPiece tokenizer)
preprocessor:
_target_: nemo.collections.asr.modules.AudioToMelSpectrogramPreprocessor
sample_rate: ${model.sample_rate}
normalize: "NA" # No normalization for mel-spectogram makes streaming easier
window_size: 0.025
window_stride: 0.01
window: "hann"
features: 80
n_fft: 512
frame_splicing: 1
dither: 0.00001
pad_to: 0
spec_augment:
_target_: nemo.collections.asr.modules.SpectrogramAugmentation
freq_masks: 2 # set to zero to disable it
time_masks: 10 # set to zero to disable it
freq_width: 27
time_width: 0.05
encoder:
_target_: nemo.collections.asr.modules.ConformerEncoder
feat_in: ${model.preprocessor.features}
feat_out: -1 # you may set it if you need different output size other than the default d_model
n_layers: 17
d_model: 512
# Sub-sampling parameters
subsampling: dw_striding # vggnet, striding, stacking or stacking_norm, dw_striding
subsampling_factor: 8 # must be power of 2 for striding and vggnet
subsampling_conv_channels: 256 # set to -1 to make it equal to the d_model
causal_downsampling: true
# Feed forward module's params
ff_expansion_factor: 4
# Multi-headed Attention Module's params
self_attention_model: rel_pos # rel_pos or abs_pos
n_heads: 8 # may need to be lower for smaller d_models
# [left, right] specifies the number of steps to be seen from left and right of each step in self-attention
# for att_context_style=regular, the right context is recommended to be a small number around 0 to 3 as multiple-layers may increase the effective right context too large
# for att_context_style=chunked_limited, the left context need to be dividable by the right context plus one
# look-ahead(secs) = att_context_size[1]*subsampling_factor*window_stride, example: 13*8*0.01=1.04s
# For multi-lookahead models, you may specify a list of context sizes. During the training, different context sizes would be used randomly with the distribution specified by att_context_probs.
# The first item in the list would be the default during test/validation/inference.
# An example of settings for multi-lookahead:
# att_context_size: [[70,13],[70,6],[70,1],[70,0]]
# att_context_probs: [0.25, 0.25, 0.25, 0.25, 0.25]
att_context_size: [70, 13] # -1 means unlimited context
att_context_style: chunked_limited # regular or chunked_limited
att_context_probs: null
xscaling: true # scales up the input embeddings by sqrt(d_model)
pos_emb_max_len: 5000
# Convolution module's params
conv_kernel_size: 9
conv_norm_type: 'layer_norm' # batch_norm or layer_norm or groupnormN (N specifies the number of groups)
# conv_context_size can be"causal" or a list of two integers while conv_context_size[0]+conv_context_size[1]+1==conv_kernel_size
# null means [(kernel_size-1)//2, (kernel_size-1)//2], and 'causal' means [(kernel_size-1), 0]
# Recommend to use causal convolutions as it would increase the effective right context and therefore the look-ahead significantly
conv_context_size: causal
### regularization
dropout: 0.1 # The dropout used in most of the Conformer Modules
dropout_pre_encoder: 0.1 # The dropout used before the encoder
dropout_emb: 0.0 # The dropout used for embeddings
dropout_att: 0.1 # The dropout for multi-headed attention modules
# set to non-zero to enable stochastic depth
stochastic_depth_drop_prob: 0.0
stochastic_depth_mode: linear # linear or uniform
stochastic_depth_start_layer: 1
decoder:
_target_: nemo.collections.asr.modules.RNNTDecoder
normalization_mode: null # Currently only null is supported for export.
random_state_sampling: false # Random state sampling: https://arxiv.org/pdf/1910.11455.pdf
blank_as_pad: true # This flag must be set in order to support exporting of RNNT models + efficient inference.
prednet:
pred_hidden: ${model.model_defaults.pred_hidden}
pred_rnn_layers: 1
t_max: null
dropout: 0.2
joint:
_target_: nemo.collections.asr.modules.RNNTJoint
log_softmax: null # 'null' would set it automatically according to CPU/GPU device
preserve_memory: false # dramatically slows down training, but might preserve some memory
# Fuses the computation of prediction net + joint net + loss + WER calculation
# to be run on sub-batches of size `fused_batch_size`.
# When this flag is set to true, consider the `batch_size` of *_ds to be just `encoder` batch size.
# `fused_batch_size` is the actual batch size of the prediction net, joint net and transducer loss.
# Using small values here will preserve a lot of memory during training, but will make training slower as well.
# An optimal ratio of fused_batch_size : *_ds.batch_size is 1:1.
# However, to preserve memory, this ratio can be 1:8 or even 1:16.
# Extreme case of 1:B (i.e. fused_batch_size=1) should be avoided as training speed would be very slow.
fuse_loss_wer: true
fused_batch_size: 4
jointnet:
joint_hidden: ${model.model_defaults.joint_hidden}
activation: "relu"
dropout: 0.2
decoding:
strategy: "greedy_batch" # can be greedy, greedy_batch, beam, tsd, alsd.
# greedy strategy config
greedy:
max_symbols: 10
# beam strategy config
beam:
beam_size: 2
return_best_hypothesis: False
score_norm: true
tsd_max_sym_exp: 50 # for Time Synchronous Decoding
alsd_max_target_len: 2.0 # for Alignment-Length Synchronous Decoding
aux_ctc:
ctc_loss_weight: 0.3 # the weight used to combine the CTC loss with the RNNT loss
use_cer: false
ctc_reduction: 'mean_batch'
decoder:
_target_: nemo.collections.asr.modules.ConvASRDecoder
feat_in: null
num_classes: -1
vocabulary: []
decoding:
strategy: "greedy"
interctc:
loss_weights: []
apply_at_layers: []
loss:
loss_name: "default"
warprnnt_numba_kwargs:
# FastEmit regularization: https://arxiv.org/abs/2010.11148
# You may enable FastEmit to increase the accuracy and reduce the latency of the model for streaming
# You may set it to lower values like 1e-3 for models with larger right context
fastemit_lambda: 5e-3 # Recommended values to be in range [1e-4, 1e-2], 0.001 is a good start.
clamp: -1.0 # if > 0, applies gradient clamping in range [-clamp, clamp] for the joint tensor only.
optim:
name: adamw
lr: 5.0
# optimizer arguments
betas: [0.9, 0.98]
weight_decay: 1e-3
# scheduler setup
sched:
name: NoamAnnealing
d_model: ${model.encoder.d_model}
# scheduler config override
warmup_steps: 10000
warmup_ratio: null
min_lr: 1e-6
trainer:
devices: -1 # number of GPUs, -1 would use all available GPUs
num_nodes: 1
max_epochs: 100
max_steps: -1 # computed at runtime if not set
val_check_interval: 1.0 # Set to 0.25 to check 4 times per epoch, or an int for number of iterations
accelerator: auto
strategy: ddp
accumulate_grad_batches: 1
gradient_clip_val: 1.0
precision: 32 # 16, 32, or bf16
log_every_n_steps: 40 # Interval of logging.
enable_progress_bar: True
num_sanity_val_steps: 0 # number of steps to perform validation steps for sanity check the validation process before starting the training, setting to 0 disables it
check_val_every_n_epoch: 1 # number of evaluations on validation every n epochs
sync_batchnorm: true
enable_checkpointing: false # Provided by exp_manager
logger: false # Provided by exp_manager
benchmark: false # needs to be false for models with variable-length speech input as it slows down training
exp_manager:
exp_dir: "/home/indeikin/PycharmProjects/NEMO_Project/fast_conformer/models"
name: ${name}
create_tensorboard_logger: true
create_checkpoint_callback: true
checkpoint_callback_params:
# in case of multiple validation sets, first one is used
monitor: "val_wer"
mode: "min"
save_top_k: 5
always_save_nemo: True # saves the checkpoints as nemo files instead of PTL checkpoints
resume_from_checkpoint: "/home/user/PycharmProjects/NEMO_Project/base_models/stt_en_fastconformer_hybrid_large_streaming_multi.nemo" # The path to a checkpoint file to continue the training, restores the whole state including the epoch, step, LR schedulers, apex, etc.
resume_if_exists: false
resume_ignore_no_checkpoint: false
create_wandb_logger: false
wandb_logger_kwargs:
name: null
project: null
```
But it gives me following error:
```
Restoring states from the checkpoint path at /home/user/PycharmProjects/NEMO_Project/base_models/stt_en_fastconformer_hybrid_large_streaming_multi.nemo
Error executing job with overrides: []
Error executing job with overrides: []
Error executing job with overrides: []
Traceback (most recent call last):
File "/home/user/PycharmProjects/NEMO_Project/fast_conformer/speech_to_text_hybrid_rnnt_ctc_bpe.py", line 83, in main
trainer.fit(asr_model)
File "/home/user/PycharmProjects/NEMO_Project/venv/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 532, in fit
call._call_and_handle_interrupt(
File "/home/user/PycharmProjects/NEMO_Project/venv/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 42, in _call_and_handle_interrupt
return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs)
File "/home/user/PycharmProjects/NEMO_Project/venv/lib/python3.10/site-packages/pytorch_lightning/strategies/launchers/subprocess_script.py", line 93, in launch
return function(*args, **kwargs)
File "/home/user/PycharmProjects/NEMO_Project/venv/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 571, in _fit_impl
self._run(model, ckpt_path=ckpt_path)
File "/home/user/PycharmProjects/NEMO_Project/venv/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 946, in _run
self._checkpoint_connector._restore_modules_and_callbacks(ckpt_path)
File "/home/user/PycharmProjects/NEMO_Project/venv/lib/python3.10/site-packages/pytorch_lightning/trainer/connectors/checkpoint_connector.py", line 399, in _restore_modules_and_callbacks
self.resume_start(checkpoint_path)
File "/home/user/PycharmProjects/NEMO_Project/venv/lib/python3.10/site-packages/pytorch_lightning/trainer/connectors/checkpoint_connector.py", line 83, in resume_start
loaded_checkpoint = self.trainer.strategy.load_checkpoint(checkpoint_path)
File "/home/user/PycharmProjects/NEMO_Project/venv/lib/python3.10/site-packages/pytorch_lightning/strategies/strategy.py", line 360, in load_checkpoint
return self.checkpoint_io.load_checkpoint(checkpoint_path)
File "/home/user/PycharmProjects/NEMO_Project/venv/lib/python3.10/site-packages/lightning_fabric/plugins/io/torch_io.py", line 91, in load_checkpoint
return pl_load(path, map_location=map_location)
File "/home/user/PycharmProjects/NEMO_Project/venv/lib/python3.10/site-packages/lightning_fabric/utilities/cloud_io.py", line 52, in _load
return torch.load(f, map_location=map_location) # type: ignore[arg-type]
File "/home/user/PycharmProjects/NEMO_Project/venv/lib/python3.10/site-packages/torch/serialization.py", line 1028, in load
return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
File "/home/user/PycharmProjects/NEMO_Project/venv/lib/python3.10/site-packages/torch/serialization.py", line 1231, in _legacy_load
return legacy_load(f)
File "/home/user/PycharmProjects/NEMO_Project/venv/lib/python3.10/site-packages/torch/serialization.py", line 1117, in legacy_load
tar.extract('storages', path=tmpdir)
File "/usr/local/lib/python3.10/tarfile.py", line 2288, in extract
tarinfo = self._get_extract_tarinfo(member, filter_function, path)
File "/usr/local/lib/python3.10/tarfile.py", line 2295, in _get_extract_tarinfo
tarinfo = self.getmember(member)
File "/usr/local/lib/python3.10/tarfile.py", line 1978, in getmember
raise KeyError("filename %r not found" % name)
KeyError: "filename 'storages' not found"
```
I tried convert .nemo file to .ckpt with code like that:
```
import nemo.collections.asr as nemo_asr
import torch
model = nemo_asr.models.EncDecHybridRNNTCTCBPEModel.restore_from(restore_path="base_models/stt_en_fastconformer_hybrid_large_streaming_multi.nemo")
model.summarize()
state_dict = model.extract_state_dict_from('base_models/stt_en_fastconformer_hybrid_large_streaming_multi.nemo', save_dir='base_models/pt_ckpt/')
```
But it still give me the error. But in that case error looks like:
```
return checkpoint["pytorch-lightning_version"]
KeyError: 'pytorch-lightning_version'
```
Any idea what I should change to fix that? Or may be I miss something?
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8256/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8256/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8255 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8255/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8255/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8255/events | https://github.com/NVIDIA/NeMo/pull/8255 | 2,102,689,788 | PR_kwDOC_bI7s5lLz64 | 8,255 | MoE parameter passing | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins"
] | 2024-01-26T18:23:10 | 2024-02-23T03:28:03 | 2024-02-23T03:28:02 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8255",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8255",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8255.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8255.patch",
"merged_at": "2024-02-23T03:28:02"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8255/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8255/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8254 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8254/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8254/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8254/events | https://github.com/NVIDIA/NeMo/pull/8254 | 2,102,656,485 | PR_kwDOC_bI7s5lLscr | 8,254 | Expert parallelism | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-01-26T18:03:22 | 2024-01-26T18:20:51 | 2024-01-26T18:20:50 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8254",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8254",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8254.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8254.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8254/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8254/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8253 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8253/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8253/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8253/events | https://github.com/NVIDIA/NeMo/pull/8253 | 2,102,483,153 | PR_kwDOC_bI7s5lLGuk | 8,253 | mcore ds fix | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
" Thanks Dmytro!",
"Was this able to start training megatron_gpt model successfully? If so, what version of Megatron-LM was used? \r\nI see the commit in the base Dockerfile is 27cbe46714a50c43ed290f1b1472db8d2780c55c, which is on the core_r0.4.0 branch. \r\n\r\nBut the addition of GPTDatasetConfig in megatron.core.datasets.gpt_dataset only exists on main, and for reset_position_ids and etc only after this commit: https://github.com/NVIDIA/Megatron-LM/commit/8d8241a9cfdf5ad6c511c5303a2623185ee18c3c\r\n\r\nI'm wondering where eod_id comes from since it's passed as part of all kwargs into GPTDatasetConfig.\r\nBut I don't see eod_id existing in gpt_dataset in Megatron-LM https://github.com/NVIDIA/Megatron-LM/blame/4bd4e7426c8def582eb80ae53f296a803643d2f5/megatron/core/datasets/gpt_dataset.py#L33\r\n\r\nCurrently I'm having issues launching the job:\r\n```\r\n File \"lib/python3.10/site-packages/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py\", line 1223, in build_train_valid_test_datasets\r\n dataset_config = GPTDatasetConfig(**kwargs)\r\nTypeError: GPTDatasetConfig.__init__() got an unexpected keyword argument 'eod_id'\r\n```",
"@ryxli I had a similar issue. My WAR was to disable warmup on synthetic data."
] | 2024-01-26T16:17:23 | 2024-02-08T09:40:31 | 2024-01-26T20:58:05 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8253",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8253",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8253.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8253.patch",
"merged_at": "2024-01-26T20:58:05"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8253/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8253/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8252 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8252/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8252/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8252/events | https://github.com/NVIDIA/NeMo/pull/8252 | 2,102,465,281 | PR_kwDOC_bI7s5lLC4C | 8,252 | [canary] Refactor: move changes in transformer_bpe_models.py to Canar… | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"After renaming/refactoring + converting old ckpt to use new target model definition it works - merging this to https://github.com/NVIDIA/NeMo/tree/canary-2-dataset-refactor where I'll next rename/refactor the dataset class"
] | 2024-01-26T16:05:29 | 2024-01-26T19:46:07 | 2024-01-26T19:46:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8252",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8252",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8252.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8252.patch",
"merged_at": "2024-01-26T19:46:06"
} | …yModel
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8252/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8252/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8251 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8251/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8251/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8251/events | https://github.com/NVIDIA/NeMo/issues/8251 | 2,102,153,626 | I_kwDOC_bI7s59TFGa | 8,251 | Problem with convert HifiGan nemo model to riva format | {
"login": "Bagzhan-hub",
"id": 67287847,
"node_id": "MDQ6VXNlcjY3Mjg3ODQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/67287847?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bagzhan-hub",
"html_url": "https://github.com/Bagzhan-hub",
"followers_url": "https://api.github.com/users/Bagzhan-hub/followers",
"following_url": "https://api.github.com/users/Bagzhan-hub/following{/other_user}",
"gists_url": "https://api.github.com/users/Bagzhan-hub/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Bagzhan-hub/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bagzhan-hub/subscriptions",
"organizations_url": "https://api.github.com/users/Bagzhan-hub/orgs",
"repos_url": "https://api.github.com/users/Bagzhan-hub/repos",
"events_url": "https://api.github.com/users/Bagzhan-hub/events{/privacy}",
"received_events_url": "https://api.github.com/users/Bagzhan-hub/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "borisfom",
"id": 14189615,
"node_id": "MDQ6VXNlcjE0MTg5NjE1",
"avatar_url": "https://avatars.githubusercontent.com/u/14189615?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/borisfom",
"html_url": "https://github.com/borisfom",
"followers_url": "https://api.github.com/users/borisfom/followers",
"following_url": "https://api.github.com/users/borisfom/following{/other_user}",
"gists_url": "https://api.github.com/users/borisfom/gists{/gist_id}",
"starred_url": "https://api.github.com/users/borisfom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/borisfom/subscriptions",
"organizations_url": "https://api.github.com/users/borisfom/orgs",
"repos_url": "https://api.github.com/users/borisfom/repos",
"events_url": "https://api.github.com/users/borisfom/events{/privacy}",
"received_events_url": "https://api.github.com/users/borisfom/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"I do not know what am I missing, but I have the same issue.\r\n\r\nExecuting this command: `nemo2riva --key None --out hifigan.riva hifigan.nemo`\r\nResults in an error: \r\n`[NeMo I 2024-02-15 21:43:09 exportable:130] Successfully exported HifiGanModel to /tmp/tmppe74nxmm/model_graph.onnx\r\nTraceback (most recent call last):\r\n File \"/home/silent/.local/bin/nemo2riva\", line 8, in <module>\r\n sys.exit(nemo2riva())\r\n File \"/home/silent/.local/lib/python3.10/site-packages/nemo2riva/cli/nemo2riva.py\", line 49, in nemo2riva\r\n Nemo2Riva(args)\r\n File \"/home/silent/.local/lib/python3.10/site-packages/nemo2riva/convert.py\", line 87, in Nemo2Riva\r\n export_model(\r\n File \"/home/silent/.local/lib/python3.10/site-packages/nemo2riva/cookbook.py\", line 141, in export_model\r\n create_artifact(\r\n File \"/home/silent/.local/lib/python3.10/site-packages/nemo2riva/artifacts.py\", line 92, in create_artifact\r\n af.encrypt()\r\n File \"<frozen eff.core.file>\", line 128, in encrypt\r\nPermissionError: Cannot encrypt the artifact without encryption`",
"Can you open an issue on https://github.com/nvidia-riva/nemo2riva? In the new issue, please provide the hifigan checkpoint that you're using."
] | 2024-01-26T12:40:13 | 2024-02-15T21:06:26 | 2024-02-15T21:06:26 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Problem with convert HifiGan nemo model to riva format
```
[NeMo I 2024-01-25 10:49:12 save_restore_connector:249] Model HifiGanModel was successfully restored from /home/PycharmProjects/tts_train_pipeline/models/HifiGan_v2.nemo.
[NeMo I 2024-01-25 10:49:13 schema:161] Loaded schema file /usr/local/lib/python3.10/dist-packages/nemo2riva/validation_schemas/nlp-mt-exported-megatronnmtmodel.yaml for nemo.collections.nlp.models.MegatronNMTModel
[NeMo I 2024-01-25 10:49:13 schema:161] Loaded schema file /usr/local/lib/python3.10/dist-packages/nemo2riva/validation_schemas/asr-stt-exported-encdecctcmodel.yaml for nemo.collections.asr.models.EncDecCTCModel
[NeMo I 2024-01-25 10:49:13 schema:161] Loaded schema file /usr/local/lib/python3.10/dist-packages/nemo2riva/validation_schemas/nlp-isc-exported-bert.yaml for nemo.collections.nlp.models.IntentSlotClassificationModel
[NeMo I 2024-01-25 10:49:13 schema:161] Loaded schema file /usr/local/lib/python3.10/dist-packages/nemo2riva/validation_schemas/nlp-pc-exported-bert.yaml for nemo.collections.nlp.models.PunctuationCapitalizationModel
[NeMo I 2024-01-25 10:49:13 schema:161] Loaded schema file /usr/local/lib/python3.10/dist-packages/nemo2riva/validation_schemas/asr-stt-exported-encdectcmodelbpe.yaml for nemo.collections.asr.models.EncDecCTCModelBPE
[NeMo I 2024-01-25 10:49:13 schema:161] Loaded schema file /usr/local/lib/python3.10/dist-packages/nemo2riva/validation_schemas/tts-exported-fastpitchmodel.yaml for nemo.collections.tts.models.FastPitchModel
[NeMo I 2024-01-25 10:49:13 schema:161] Loaded schema file /usr/local/lib/python3.10/dist-packages/nemo2riva/validation_schemas/nlp-tc-exported-bert.yaml for nemo.collections.nlp.models.TextClassificationModel
[NeMo I 2024-01-25 10:49:13 schema:161] Loaded schema file /usr/local/lib/python3.10/dist-packages/nemo2riva/validation_schemas/nlp-tkc-exported-bert.yaml for nemo.collections.nlp.models.TokenClassificationModel
[NeMo I 2024-01-25 10:49:13 schema:161] Loaded schema file /usr/local/lib/python3.10/dist-packages/nemo2riva/validation_schemas/nlp-mt-exported-encdecmtmodel.yaml for nemo.collections.nlp.models.MTEncDecModel
[NeMo I 2024-01-25 10:49:13 schema:161] Loaded schema file /usr/local/lib/python3.10/dist-packages/nemo2riva/validation_schemas/asr-scr-exported-encdecclsmodel.yaml for nemo.collections.asr.models.classification_models.EncDecClassificationModel
[NeMo I 2024-01-25 10:49:13 schema:161] Loaded schema file /usr/local/lib/python3.10/dist-packages/nemo2riva/validation_schemas/tts-exported-radttsmodel.yaml for nemo.collections.tts.models.RadTTSModel
[NeMo I 2024-01-25 10:49:13 schema:161] Loaded schema file /usr/local/lib/python3.10/dist-packages/nemo2riva/validation_schemas/tts-exported-hifiganmodel.yaml for nemo.collections.tts.models.HifiGanModel
[NeMo I 2024-01-25 10:49:13 schema:161] Loaded schema file /usr/local/lib/python3.10/dist-packages/nemo2riva/validation_schemas/nlp-qa-exported-bert.yaml for nemo.collections.nlp.models.QAModel
[NeMo I 2024-01-25 10:49:13 schema:200] Found validation schema for nemo.collections.tts.models.HifiGanModel at /usr/local/lib/python3.10/dist-packages/nemo2riva/validation_schemas/tts-exported-hifiganmodel.yaml
[NeMo I 2024-01-25 10:49:13 schema:229] Checking installed NeMo version ... 1.20.0 OK (>=1.1)
[NeMo I 2024-01-25 10:49:13 artifacts:59] Found model at ./model_weights.ckpt
[NeMo I 2024-01-25 10:49:13 artifacts:136] Retrieved artifacts: dict_keys(['model_config.yaml'])
[NeMo I 2024-01-25 10:49:13 cookbook:78] Exporting model HifiGanModel with config=ExportConfig(export_subnet=None, export_format='ONNX', export_file='model_graph.onnx', encryption=True, autocast=False, max_dim=None, export_args={})
Removing weight norm...
Removing weight norm...
=========== Diagnostic Run torch.onnx.export version 2.1.0a0+4136153 ===========
verbose: False, log level: Level.ERROR
======================= 0 NONE 0 NOTE 0 WARNING 0 ERROR ========================
[NeMo I 2024-01-25 10:49:15 exportable:130] Successfully exported HifiGanModel to /tmp/tmpydn8_nmj/model_graph.onnx
Traceback (most recent call last):
File "/usr/local/bin/nemo2riva", line 8, in <module>
sys.exit(nemo2riva())
File "/usr/local/lib/python3.10/dist-packages/nemo2riva/cli/nemo2riva.py", line 49, in nemo2riva
Nemo2Riva(args)
File "/usr/local/lib/python3.10/dist-packages/nemo2riva/convert.py", line 81, in Nemo2Riva
export_model(
File "/usr/local/lib/python3.10/dist-packages/nemo2riva/cookbook.py", line 141, in export_model
create_artifact(
File "/usr/local/lib/python3.10/dist-packages/nemo2riva/artifacts.py", line 92, in create_artifact
af.encrypt()
File "<frozen eff.core.file>", line 128, in encrypt
PermissionError: Cannot encrypt the artifact without encryption
```
**Steps/Code to reproduce bug**
Shell command
`nemo2riva --key tlt_encode --out models/HifiGan.riva models/HifiGan_v2.nemo
`
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version: ubuntu 20.04
- PyTorch version 2.1.0a0+4136153
- Python version 3.10.6
- NeMo version 1.20.0
| {
"login": "blisc",
"id": 4763352,
"node_id": "MDQ6VXNlcjQ3NjMzNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/4763352?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/blisc",
"html_url": "https://github.com/blisc",
"followers_url": "https://api.github.com/users/blisc/followers",
"following_url": "https://api.github.com/users/blisc/following{/other_user}",
"gists_url": "https://api.github.com/users/blisc/gists{/gist_id}",
"starred_url": "https://api.github.com/users/blisc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/blisc/subscriptions",
"organizations_url": "https://api.github.com/users/blisc/orgs",
"repos_url": "https://api.github.com/users/blisc/repos",
"events_url": "https://api.github.com/users/blisc/events{/privacy}",
"received_events_url": "https://api.github.com/users/blisc/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8251/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8251/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8250 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8250/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8250/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8250/events | https://github.com/NVIDIA/NeMo/pull/8250 | 2,102,027,193 | PR_kwDOC_bI7s5lJjda | 8,250 | Use Pytest with Coverage | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"jenkins",
"Closed since Jenkins will be replaced with Github actions in the near future"
] | 2024-01-26T11:01:26 | 2024-01-29T19:15:08 | 2024-01-29T19:15:07 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8250",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8250",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8250.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8250.patch",
"merged_at": null
} | # What does this PR do ?
- PyTest on Jenkins runs with coverage (you can see the coverage report in logs for unit tests GPU/CPU)
- Remove deprecated `pytest-runner` (plugin used earlier to run pytest via setup.py, now useless and unsupported)
- You can see now the failing/skipped/passed tests in Jenkins UI, e.g., http://10.110.40.131:8080/blue/organizations/jenkins/NeMo-multibranch/detail/PR-8250/3/tests
**Collection**: [CI]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```shell
pytest --cov=nemo --cov-report=html test_my_awesome_feature.py
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8250/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8250/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8249 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8249/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8249/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8249/events | https://github.com/NVIDIA/NeMo/pull/8249 | 2,101,405,633 | PR_kwDOC_bI7s5lHmYv | 8,249 | Refactor SFT Dataset Class for Video Support [Video-NeVA] | {
"login": "PannuMuthu",
"id": 30813477,
"node_id": "MDQ6VXNlcjMwODEzNDc3",
"avatar_url": "https://avatars.githubusercontent.com/u/30813477?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PannuMuthu",
"html_url": "https://github.com/PannuMuthu",
"followers_url": "https://api.github.com/users/PannuMuthu/followers",
"following_url": "https://api.github.com/users/PannuMuthu/following{/other_user}",
"gists_url": "https://api.github.com/users/PannuMuthu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PannuMuthu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PannuMuthu/subscriptions",
"organizations_url": "https://api.github.com/users/PannuMuthu/orgs",
"repos_url": "https://api.github.com/users/PannuMuthu/repos",
"events_url": "https://api.github.com/users/PannuMuthu/events{/privacy}",
"received_events_url": "https://api.github.com/users/PannuMuthu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-26T00:57:32 | 2024-03-10T01:44:54 | 2024-03-10T01:44:53 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8249",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8249",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8249.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8249.patch",
"merged_at": null
} | # What does this PR do ?
Adds video support for SFT dataset class in NeVA
**Collection**: Multimodal
# Changelog
- Adds `video_processor` option in config for processing video data for SFT dataset class (defaults to `LanguageBindVideoProcessor`)
- Adds logic for image-only, video-only, or image and video data loading / preprocessing in `LazySupervisedDataset.__getitem__`
# Usage
* You can potentially add a usage example below
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8249/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8249/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8248 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8248/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8248/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8248/events | https://github.com/NVIDIA/NeMo/pull/8248 | 2,101,266,041 | PR_kwDOC_bI7s5lHJGn | 8,248 | add alpha scaling to lora | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins\r\n",
"jenkins",
"jenkins",
"jenkins"
] | 2024-01-25T22:27:19 | 2024-02-25T09:47:52 | 2024-02-25T09:47:51 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8248",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8248",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8248.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8248.patch",
"merged_at": "2024-02-25T09:47:51"
} | # What does this PR do ?
step in line with the original lora and added alpha.
**Collection**: [NLP]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "michal2409",
"id": 14821051,
"node_id": "MDQ6VXNlcjE0ODIxMDUx",
"avatar_url": "https://avatars.githubusercontent.com/u/14821051?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michal2409",
"html_url": "https://github.com/michal2409",
"followers_url": "https://api.github.com/users/michal2409/followers",
"following_url": "https://api.github.com/users/michal2409/following{/other_user}",
"gists_url": "https://api.github.com/users/michal2409/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michal2409/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michal2409/subscriptions",
"organizations_url": "https://api.github.com/users/michal2409/orgs",
"repos_url": "https://api.github.com/users/michal2409/repos",
"events_url": "https://api.github.com/users/michal2409/events{/privacy}",
"received_events_url": "https://api.github.com/users/michal2409/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8248/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8248/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8247 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8247/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8247/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8247/events | https://github.com/NVIDIA/NeMo/pull/8247 | 2,101,160,590 | PR_kwDOC_bI7s5lGymi | 8,247 | [canary] Refactor: `PromptedAudioToTextLhotseDataset` and `EncDecMultiTaskModel` | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Merging to `canary-2` for further development to unblock others -- we should address the rest of comments there."
] | 2024-01-25T21:01:14 | 2024-01-27T02:10:27 | 2024-01-26T22:16:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8247",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8247",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8247.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8247.patch",
"merged_at": "2024-01-26T22:16:45"
} | This PR restores `transformer_bpe_models.py` and `audio_to_text_lhotse.py` to their previous shape and separates out two classes: `EncDecMultiTaskModel` and `PromptedAudioToTextLhotseDataset` that contain the modified code for Canary, generalized to support other model instances of this type.
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8247/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8247/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8246 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8246/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8246/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8246/events | https://github.com/NVIDIA/NeMo/pull/8246 | 2,101,004,406 | PR_kwDOC_bI7s5lGQlB | 8,246 | Incrementally update black formatter | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-25T19:09:23 | 2024-02-16T01:43:56 | 2024-02-16T01:43:55 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8246",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8246",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8246.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8246.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8246/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8246/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8245 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8245/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8245/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8245/events | https://github.com/NVIDIA/NeMo/pull/8245 | 2,100,949,146 | PR_kwDOC_bI7s5lGExx | 8,245 | Incremental black formatter update | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [] | 2024-01-25T18:31:38 | 2024-01-25T19:08:17 | 2024-01-25T19:08:12 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8245",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8245",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8245.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8245.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8245/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8245/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8244 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8244/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8244/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8244/events | https://github.com/NVIDIA/NeMo/issues/8244 | 2,100,946,380 | I_kwDOC_bI7s59OeXM | 8,244 | No such file or directory: 'megatron/core/requirements.txt' when installing nemo 1.22 | {
"login": "bene-ges",
"id": 61418381,
"node_id": "MDQ6VXNlcjYxNDE4Mzgx",
"avatar_url": "https://avatars.githubusercontent.com/u/61418381?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bene-ges",
"html_url": "https://github.com/bene-ges",
"followers_url": "https://api.github.com/users/bene-ges/followers",
"following_url": "https://api.github.com/users/bene-ges/following{/other_user}",
"gists_url": "https://api.github.com/users/bene-ges/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bene-ges/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bene-ges/subscriptions",
"organizations_url": "https://api.github.com/users/bene-ges/orgs",
"repos_url": "https://api.github.com/users/bene-ges/repos",
"events_url": "https://api.github.com/users/bene-ges/events{/privacy}",
"received_events_url": "https://api.github.com/users/bene-ges/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
}
] | closed | false | null | [] | null | [
"using the docker container is highly recommended https://github.com/NVIDIA/NeMo?tab=readme-ov-file#docker-containers",
"You are using the wrong version of python, you need to use python 3.10.12.",
"For some reasons, I need to stick to python3.8.\r\nPrevious Nemo version installed and worked ok (I do not use anything related to megatron). Is the reported error (missing file) related to Python version?",
"If you need just ASR, you can safely install nemo_toolkit[ASR]. However it may be time to update. 3.8 has been deprecated for over a year now, and ASR has also started using syntax from 3.10 for Lhotse datasets. So in the coming month or two even pip install nemo_toolkit[ASR] will no longer safely work on python ,3.8",
"As to docker, it's actually not the primary path we recommend for local 1 GPU development. \r\n\r\nNeMo ASR at least is designed to be a pip installable package. Ofc, docker is very convenient when you just want to start working on clusters, and we too only use docker containers in those cases ",
"This should be fixed with this PR: https://github.com/NVIDIA/NeMo/pull/8465\r\n\r\nPlease try again and close the bug if your issue is solved.",
"thanks"
] | 2024-01-25T18:29:38 | 2024-02-27T18:39:20 | 2024-02-27T18:39:20 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
No such file or directory: 'megatron/core/requirements.txt' when installing nemo 1.22
**Steps/Code to reproduce bug**
```
File "/tmp/pip-build-env-93j56cnr/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 311, in run_setup
exec(code, locals())
File "<string>", line 52, in <module>
File "<string>", line 45, in req_file
FileNotFoundError: [Errno 2] No such file or directory: 'megatron/core/requirements.txt'
```
A helpful guide on on how to craft a minimal bug report http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports.
**Expected behavior**
A clear and concise description of what you expected to happen.
**Environment overview (please complete the following information)**
- Environment location: [Bare-metal, Docker, Cloud(specify cloud provider - AWS, Azure, GCP, Collab)]
- Method of NeMo install: [pip install or from source]. Please specify exact commands you used to install.
- If method of install is [Docker], provide `docker pull` & `docker run` commands used
**Environment details**
If NVIDIA docker image is used you don't need to specify these.
Otherwise, please provide:
- OS version
- PyTorch version
- Python version
**Additional context**
Add any other context about the problem here.
Example: GPU model
| {
"login": "bene-ges",
"id": 61418381,
"node_id": "MDQ6VXNlcjYxNDE4Mzgx",
"avatar_url": "https://avatars.githubusercontent.com/u/61418381?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bene-ges",
"html_url": "https://github.com/bene-ges",
"followers_url": "https://api.github.com/users/bene-ges/followers",
"following_url": "https://api.github.com/users/bene-ges/following{/other_user}",
"gists_url": "https://api.github.com/users/bene-ges/gists{/gist_id}",
"starred_url": "https://api.github.com/users/bene-ges/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bene-ges/subscriptions",
"organizations_url": "https://api.github.com/users/bene-ges/orgs",
"repos_url": "https://api.github.com/users/bene-ges/repos",
"events_url": "https://api.github.com/users/bene-ges/events{/privacy}",
"received_events_url": "https://api.github.com/users/bene-ges/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8244/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8244/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8243 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8243/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8243/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8243/events | https://github.com/NVIDIA/NeMo/pull/8243 | 2,100,869,134 | PR_kwDOC_bI7s5lFznr | 8,243 | Huvu/mcore retro | {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-01-25T17:35:20 | 2024-01-31T15:26:49 | 2024-01-31T15:26:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8243",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8243",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8243.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8243.patch",
"merged_at": null
} | # What does this PR do ?
Implementing RETRO's mcore model, dataloader's wrapper, training script.
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "huvunvidia",
"id": 86480512,
"node_id": "MDQ6VXNlcjg2NDgwNTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/86480512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huvunvidia",
"html_url": "https://github.com/huvunvidia",
"followers_url": "https://api.github.com/users/huvunvidia/followers",
"following_url": "https://api.github.com/users/huvunvidia/following{/other_user}",
"gists_url": "https://api.github.com/users/huvunvidia/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huvunvidia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huvunvidia/subscriptions",
"organizations_url": "https://api.github.com/users/huvunvidia/orgs",
"repos_url": "https://api.github.com/users/huvunvidia/repos",
"events_url": "https://api.github.com/users/huvunvidia/events{/privacy}",
"received_events_url": "https://api.github.com/users/huvunvidia/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8243/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8243/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8242 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8242/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8242/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8242/events | https://github.com/NVIDIA/NeMo/pull/8242 | 2,100,855,958 | PR_kwDOC_bI7s5lFwxo | 8,242 | Attention encoder-decoder models for multiple speech-to-text tasks | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins"
] | 2024-01-25T17:26:45 | 2024-09-09T18:59:38 | 2024-02-03T05:35:29 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8242",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8242",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8242.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8242.patch",
"merged_at": "2024-02-03T05:35:29"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8242/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8242/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8241 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8241/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8241/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8241/events | https://github.com/NVIDIA/NeMo/pull/8241 | 2,100,680,303 | PR_kwDOC_bI7s5lFKng | 8,241 | Karpnv/beamsearch | {
"login": "karpnv",
"id": 1645775,
"node_id": "MDQ6VXNlcjE2NDU3NzU=",
"avatar_url": "https://avatars.githubusercontent.com/u/1645775?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/karpnv",
"html_url": "https://github.com/karpnv",
"followers_url": "https://api.github.com/users/karpnv/followers",
"following_url": "https://api.github.com/users/karpnv/following{/other_user}",
"gists_url": "https://api.github.com/users/karpnv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/karpnv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/karpnv/subscriptions",
"organizations_url": "https://api.github.com/users/karpnv/orgs",
"repos_url": "https://api.github.com/users/karpnv/repos",
"events_url": "https://api.github.com/users/karpnv/events{/privacy}",
"received_events_url": "https://api.github.com/users/karpnv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-01-25T15:52:07 | 2024-02-14T17:10:26 | 2024-02-14T17:10:26 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8241",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8241",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8241.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8241.patch",
"merged_at": null
} | # Preserve one Flashlight beamsearch with Ngram LM
Support Flashlight and Pyctcdecode decoding with pure KenLM and NeMo KenLM
Standardize API of CLI inference scripts
**Collection**: ASR
# Changelog
- Add specific line by line info of high level changes in this PR.
```python
python3 scripts/asr_language_modeling/ngram_lm/eval_beamsearch_ngram_ctc.py \
nemo_model_file=am_model.nemo \
input_manifest=manifest.json \
preds_output_folder=/tmp \
ctc_decoding.strategy=flashlight \
ctc_decoding.beam.kenlm_path=am_model.kenlm \
ctc_decoding.beam.beam_size=[4] \
ctc_decoding.beam.beam_alpha=[0.5] \
ctc_decoding.beam.beam_beta=[0.5] \
ctc_decoding.beam.flashlight_cfg.lexicon_path=am_model.flashlight_lexicon \ # DEFAULT_TOKEN_OFFSET
batch_size=32 \
beam_batch_size=1 \
device=cuda:1
python3 examples/asr/speech_to_text_eval.py \
nemo_model_file=am_model.nemo \
input_manifest=manifest.json \
decoder_type=ctc
ctc_decoding.strategy=flashlight \
ctc_decoding.beam.kenlm_path=am_model.bin \
ctc_decoding.beam.beam_size=4 \
ctc_decoding.beam.beam_alpha=0.5 \
ctc_decoding.beam.beam_beta=0.5 \
ctc_decoding.beam.flashlight_cfg.lexicon_path=am_model.flashlight_lexicon \ # DEFAULT_TOKEN_OFFSET
ctc_decoding.beam.return_best_hypothesis=true \
batch_size=32 \
output_manifest=/tmp/manifest_out.json
```
**PR Type**:
- [ V] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "karpnv",
"id": 1645775,
"node_id": "MDQ6VXNlcjE2NDU3NzU=",
"avatar_url": "https://avatars.githubusercontent.com/u/1645775?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/karpnv",
"html_url": "https://github.com/karpnv",
"followers_url": "https://api.github.com/users/karpnv/followers",
"following_url": "https://api.github.com/users/karpnv/following{/other_user}",
"gists_url": "https://api.github.com/users/karpnv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/karpnv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/karpnv/subscriptions",
"organizations_url": "https://api.github.com/users/karpnv/orgs",
"repos_url": "https://api.github.com/users/karpnv/repos",
"events_url": "https://api.github.com/users/karpnv/events{/privacy}",
"received_events_url": "https://api.github.com/users/karpnv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8241/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8241/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8240 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8240/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8240/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8240/events | https://github.com/NVIDIA/NeMo/pull/8240 | 2,099,638,529 | PR_kwDOC_bI7s5lBn-7 | 8,240 | Correct padding for SFT input data to account for sequence parallel + TE's fp8 op dimension requirements | {
"login": "vysarge",
"id": 10239441,
"node_id": "MDQ6VXNlcjEwMjM5NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/10239441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vysarge",
"html_url": "https://github.com/vysarge",
"followers_url": "https://api.github.com/users/vysarge/followers",
"following_url": "https://api.github.com/users/vysarge/following{/other_user}",
"gists_url": "https://api.github.com/users/vysarge/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vysarge/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vysarge/subscriptions",
"organizations_url": "https://api.github.com/users/vysarge/orgs",
"repos_url": "https://api.github.com/users/vysarge/repos",
"events_url": "https://api.github.com/users/vysarge/events{/privacy}",
"received_events_url": "https://api.github.com/users/vysarge/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@cuichenx / @ericharper can you review?",
"jenkins"
] | 2024-01-25T06:10:22 | 2024-03-12T22:36:38 | 2024-01-25T18:44:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8240",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8240",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8240.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8240.patch",
"merged_at": "2024-01-25T18:44:02"
} | # What does this PR do ?
Alters GPTSFTDataset and GPTSFTPackedDataset to pad to 8*TP when sequence parallel is enabled.
**Collection**: nlp/language_modeling
# Changelog
- Adds an argument to GPTSFTDataset and GPTSFTPackedDataset which allows setting what value sequence lengths will be padded to a multiple of (previously always 16)
- Sets this argument from MegatronGPTSFTModel to ensure that sequences will be padded to a multiple of 8*TP when sequence parallel is enabled so that the sequence dimension will remain divisible by 8 after being split (required by TE for the first dimension)
- Sequences will still be padded to a multiple of 16 when sequence parallel is not used (see [PR-7904](https://github.com/NVIDIA/NeMo/pull/7904))
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8240/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8240/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8239 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8239/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8239/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8239/events | https://github.com/NVIDIA/NeMo/pull/8239 | 2,099,398,978 | PR_kwDOC_bI7s5lA1XB | 8,239 | Allow MegatronPretrainingRandomSampler to do multi-epoch training | {
"login": "trias702",
"id": 25867060,
"node_id": "MDQ6VXNlcjI1ODY3MDYw",
"avatar_url": "https://avatars.githubusercontent.com/u/25867060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/trias702",
"html_url": "https://github.com/trias702",
"followers_url": "https://api.github.com/users/trias702/followers",
"following_url": "https://api.github.com/users/trias702/following{/other_user}",
"gists_url": "https://api.github.com/users/trias702/gists{/gist_id}",
"starred_url": "https://api.github.com/users/trias702/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/trias702/subscriptions",
"organizations_url": "https://api.github.com/users/trias702/orgs",
"repos_url": "https://api.github.com/users/trias702/repos",
"events_url": "https://api.github.com/users/trias702/events{/privacy}",
"received_events_url": "https://api.github.com/users/trias702/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins"
] | 2024-01-25T01:28:58 | 2024-01-29T22:36:28 | 2024-01-29T22:36:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8239",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8239",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8239.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8239.patch",
"merged_at": "2024-01-29T22:36:27"
} | # What does this PR do ?
Allows the MegatronPretrainingRandomSampler class to correctly handle multi-epoch training by calculating length correctly when consumed_samples > total_samples
**Collection**: NLP
# Changelog
- nemo/collections/nlp/data/language_modeling/megatron/data_samplers.py: modified MegatronPretrainingRandomSampler to correctly return length for multi-epoch training when consumed_samples > total_samples
- nemo/collections/nlp/data/language_modeling/megatron/megatron_batch_samplers.py: fixed len calculation to be correct when drop_last=False, and also cleaned up constructor logic caused by these fixes: https://github.com/NVIDIA/NeMo/pull/7728/files#diff-26575f60355f81991aef1f635e947a368b086afe220c5a81817e35b1c00b2e38
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [X] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [X] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8239/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8239/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8238 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8238/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8238/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8238/events | https://github.com/NVIDIA/NeMo/pull/8238 | 2,099,324,475 | PR_kwDOC_bI7s5lAlYy | 8,238 | [TTS] Add modules for mel spectrogram codec | {
"login": "rlangman",
"id": 9942053,
"node_id": "MDQ6VXNlcjk5NDIwNTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rlangman",
"html_url": "https://github.com/rlangman",
"followers_url": "https://api.github.com/users/rlangman/followers",
"following_url": "https://api.github.com/users/rlangman/following{/other_user}",
"gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rlangman/subscriptions",
"organizations_url": "https://api.github.com/users/rlangman/orgs",
"repos_url": "https://api.github.com/users/rlangman/repos",
"events_url": "https://api.github.com/users/rlangman/events{/privacy}",
"received_events_url": "https://api.github.com/users/rlangman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"jenkins",
"jenkins",
"jenkins",
"> What about model class file? Would it be added later?\r\n\r\nThis is trained using the same `audio_codec.py` model class.",
"jenkins"
] | 2024-01-25T00:00:42 | 2024-02-14T16:03:57 | 2024-02-14T16:03:56 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8238",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8238",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8238.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8238.patch",
"merged_at": "2024-02-14T16:03:56"
} | # What does this PR do ?
Add code and example for how to train audio codec while encoding mel spectrogram.
Note there is an extra "FullBandMelEncoder" definition which is not in the example config, but which I am adding to try to and keep inference working with some existing checkpoints.
**Collection**: [TTS]
# Changelog
- Add codec modules for encoding mel spectrogram.
- Add example config file.
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "rlangman",
"id": 9942053,
"node_id": "MDQ6VXNlcjk5NDIwNTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/9942053?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rlangman",
"html_url": "https://github.com/rlangman",
"followers_url": "https://api.github.com/users/rlangman/followers",
"following_url": "https://api.github.com/users/rlangman/following{/other_user}",
"gists_url": "https://api.github.com/users/rlangman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rlangman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rlangman/subscriptions",
"organizations_url": "https://api.github.com/users/rlangman/orgs",
"repos_url": "https://api.github.com/users/rlangman/repos",
"events_url": "https://api.github.com/users/rlangman/events{/privacy}",
"received_events_url": "https://api.github.com/users/rlangman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8238/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8238/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8237 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8237/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8237/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8237/events | https://github.com/NVIDIA/NeMo/pull/8237 | 2,099,046,492 | PR_kwDOC_bI7s5k_ogD | 8,237 | Script for estimating Lhotse dynamic duration buckets | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"jenkins",
"jenkins"
] | 2024-01-24T20:34:51 | 2024-02-13T18:43:42 | 2024-02-13T18:43:41 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8237",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8237",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8237.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8237.patch",
"merged_at": "2024-02-13T18:43:41"
} | # What does this PR do ?
The script provides the user with the optimal, data-driven value of `model.train_ds.bucket_duration_bins` to avoid computing it at the start of the training.
It requires tiny changes to enable dataset mixing with non-tarred manifests (as we don't want to actually load any data here) and triggered an opportunity for a small refactor of the `CutSet` initialization code. Another issue was that NeMo manifests do not have `sampling_rate` info but Lhotse must have it to create a Recording object -- I introduced a `dummy_mode` for use-cases like this where we only need to iterate the metadata.
**Collection**: All speech collections
# Changelog
- Script for estimating Lhotse dynamic duration buckets
# Usage
## Help message
```
$ python scripts/speech_recognition/estimate_duration_bins.py --help
usage: estimate_duration_bins.py [-h] [-b BUCKETS] [-n NUM_EXAMPLES]
[-l MIN_DURATION] [-u MAX_DURATION] [-q QUIET]
input
Estimate duration bins for Lhotse dynamic bucketing using a sample of the input
dataset. The dataset is read either from one or more manifest files and supports
data weighting.
positional arguments:
input Same input format as in model configs under
model.train_ds.manifest_filepath. Options: 1)
"path.json"; 2) "[path1.json,path2.json,...]"; 3)
"[[path1.json,weight1],[path2.json,weight2],...]"
options:
-h, --help show this help message and exit
-b BUCKETS, --buckets BUCKETS
The desired number of buckets.
-n NUM_EXAMPLES, --num_examples NUM_EXAMPLES
The number of examples (utterances) to estimate the
bins. -1 means use all data.
-l MIN_DURATION, --min_duration MIN_DURATION
If specified, we'll filter out utterances shorter than
this.
-u MAX_DURATION, --max_duration MAX_DURATION
If specified, we'll filter out utterances longer than
this.
-q QUIET, --quiet QUIET
When specified, only print the estimated duration bins.
```
## Example manifest and options
```
$ python scripts/speech_recognition/estimate_duration_bins.py -b 30 -l 2 -u 2.5 -n 10000 manifest.json
Note: we discarded 50168/60168 (83.38%) utterances due to min/max duration filtering.
Use the following options in your config:
num_buckets=30
bucket_duration_bins=[2.03,2.05419,2.08,2.11,2.13452,2.16,2.18,2.2,2.22,2.24,2.2531,2.27,2.285,2.3,2.3175,2.33,2.342,2.36,2.37,2.3896,2.4,2.41369,2.4295,2.44,2.45,2.46,2.47,2.48,2.491]
Computing utterance duration distribution...
Cut statistics:
╒═══════════════════════════╤══════════╕
│ Cuts count: │ 10000 │
├───────────────────────────┼──────────┤
│ Total duration (hh:mm:ss) │ 06:21:17 │
├───────────────────────────┼──────────┤
│ mean │ 2.3 │
├───────────────────────────┼──────────┤
│ std │ 0.1 │
├───────────────────────────┼──────────┤
│ min │ 2.0 │
├───────────────────────────┼──────────┤
│ 25% │ 2.2 │
├───────────────────────────┼──────────┤
│ 50% │ 2.3 │
├───────────────────────────┼──────────┤
│ 75% │ 2.4 │
├───────────────────────────┼──────────┤
│ 99% │ 2.5 │
├───────────────────────────┼──────────┤
│ 99.5% │ 2.5 │
├───────────────────────────┼──────────┤
│ 99.9% │ 2.5 │
├───────────────────────────┼──────────┤
│ max │ 2.5 │
├───────────────────────────┼──────────┤
│ Recordings available: │ 10000 │
├───────────────────────────┼──────────┤
│ Features available: │ 0 │
├───────────────────────────┼──────────┤
│ Supervisions available: │ 10000 │
╘═══════════════════════════╧══════════╛
CUT custom fields:
- shard_id (in 10000 cuts)
- text (in 10000 cuts)
- pcstrip_text (in 10000 cuts)
- source_lang (in 10000 cuts)
- target_lang (in 10000 cuts)
- taskname (in 10000 cuts)
- pnc (in 10000 cuts)
- answer (in 10000 cuts)
Speech duration statistics:
╒══════════════════════════════╤══════════╤══════════════════════╕
│ Total speech duration │ 06:21:17 │ 100.00% of recording │
├──────────────────────────────┼──────────┼──────────────────────┤
│ Total speaking time duration │ 06:21:17 │ 100.00% of recording │
├──────────────────────────────┼──────────┼──────────────────────┤
│ Total silence duration │ 00:00:01 │ 0.00% of recording │
╘══════════════════════════════╧══════════╧══════════════════════╛
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8237/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8237/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8236 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8236/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8236/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8236/events | https://github.com/NVIDIA/NeMo/issues/8236 | 2,098,725,693 | I_kwDOC_bI7s59GAM9 | 8,236 | TransformerLMModel loads tokenizer from the local file instead of .nemo trained file | {
"login": "yonas-g",
"id": 23583963,
"node_id": "MDQ6VXNlcjIzNTgzOTYz",
"avatar_url": "https://avatars.githubusercontent.com/u/23583963?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yonas-g",
"html_url": "https://github.com/yonas-g",
"followers_url": "https://api.github.com/users/yonas-g/followers",
"following_url": "https://api.github.com/users/yonas-g/following{/other_user}",
"gists_url": "https://api.github.com/users/yonas-g/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yonas-g/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yonas-g/subscriptions",
"organizations_url": "https://api.github.com/users/yonas-g/orgs",
"repos_url": "https://api.github.com/users/yonas-g/repos",
"events_url": "https://api.github.com/users/yonas-g/events{/privacy}",
"received_events_url": "https://api.github.com/users/yonas-g/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-24T17:11:47 | 2024-03-02T01:43:15 | 2024-03-02T01:43:15 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **TransformerLMModel loads tokenizer from the local file instead of .nemo trained file**
While using `TransformerLMModel.restore_from(<.nemo file>)`, the tokenizer is loaded from the local tokenizers file instead of the tokenizer found in the `.nemo` model file.
As shown in the snippet below from [nemo/collections/nlp/models/language_modeling/transformer_lm_model.py](https://github.com/NVIDIA/NeMo/blob/0b7467ebd158ef6876dd147189517b25ef626982/nemo/collections/nlp/models/language_modeling/transformer_lm_model.py#L57), the models uses `tokenizer_model` instead of `cfg.tokenizer.tokenizer_model` to load the tokenizer, which refers to the path to the local tokenizer.
This implementation is causing an issue when I try to load the model in another location other than where it's trained from.
```python
self.setup_tokenizer(
tokenizer_name=cfg.tokenizer.get("tokenizer_name", "yttm"),
tokenizer_model=cfg.tokenizer.get("tokenizer_model", None),
vocab_file=cfg.tokenizer.get("vocab_file", None),
bpe_dropout=cfg.tokenizer.get("bpe_dropout", 0.0),
special_tokens=OmegaConf.to_container(cfg.tokenizer.special_tokens)
if cfg.tokenizer.get("special_tokens", None)
else None,
)
```
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8236/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8236/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8235 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8235/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8235/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8235/events | https://github.com/NVIDIA/NeMo/issues/8235 | 2,098,558,782 | I_kwDOC_bI7s59FXc- | 8,235 | OOM killed when diarizing 4 hours recording | {
"login": "tttalshaul",
"id": 110480789,
"node_id": "U_kgDOBpXNlQ",
"avatar_url": "https://avatars.githubusercontent.com/u/110480789?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tttalshaul",
"html_url": "https://github.com/tttalshaul",
"followers_url": "https://api.github.com/users/tttalshaul/followers",
"following_url": "https://api.github.com/users/tttalshaul/following{/other_user}",
"gists_url": "https://api.github.com/users/tttalshaul/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tttalshaul/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tttalshaul/subscriptions",
"organizations_url": "https://api.github.com/users/tttalshaul/orgs",
"repos_url": "https://api.github.com/users/tttalshaul/repos",
"events_url": "https://api.github.com/users/tttalshaul/events{/privacy}",
"received_events_url": "https://api.github.com/users/tttalshaul/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "tango4j",
"id": 13211483,
"node_id": "MDQ6VXNlcjEzMjExNDgz",
"avatar_url": "https://avatars.githubusercontent.com/u/13211483?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tango4j",
"html_url": "https://github.com/tango4j",
"followers_url": "https://api.github.com/users/tango4j/followers",
"following_url": "https://api.github.com/users/tango4j/following{/other_user}",
"gists_url": "https://api.github.com/users/tango4j/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tango4j/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tango4j/subscriptions",
"organizations_url": "https://api.github.com/users/tango4j/orgs",
"repos_url": "https://api.github.com/users/tango4j/repos",
"events_url": "https://api.github.com/users/tango4j/events{/privacy}",
"received_events_url": "https://api.github.com/users/tango4j/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "nithinraok",
"id": 19668129,
"node_id": "MDQ6VXNlcjE5NjY4MTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/19668129?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nithinraok",
"html_url": "https://github.com/nithinraok",
"followers_url": "https://api.github.com/users/nithinraok/followers",
"following_url": "https://api.github.com/users/nithinraok/following{/other_user}",
"gists_url": "https://api.github.com/users/nithinraok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/nithinraok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nithinraok/subscriptions",
"organizations_url": "https://api.github.com/users/nithinraok/orgs",
"repos_url": "https://api.github.com/users/nithinraok/repos",
"events_url": "https://api.github.com/users/nithinraok/events{/privacy}",
"received_events_url": "https://api.github.com/users/nithinraok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"@tttalshaul can you share more info on length of audio and size of embeddings in pkl file you saved? ",
"Audio length is 3:43 hours after cutting silence (using VAD). \r\nembeddings:\r\nscale0 6.6M len 8920\r\nscale1 7.9M len 10704\r\nscale2 9.9M len 13385\r\nscale3 14M len 17846\r\nscale4 20M len 26772\r\nscale5 40M len 53548",
"@nithinraok \r\nWhat tests can I make to understand the cause of this problem?\r\n\r\nI'm moving ClusteringDiarizer(cfg=cfg).to(device), and I see that device is cuda:0. \r\nI understand that this only effects vad and embeddings extraction, but clustering occurs in cpu RAM anyway?\r\n\r\nThank you",
"@tango4j what is the maximum audio duration we currently support for single pass offline diarzation\r\n",
"@tttalshaul \r\n\r\nSorry for the late reply.\r\nIf you have visible cuda devices, both embedding extractions and clustering will be happening on GPU RAM.\r\n\r\n```\r\nclustering: \r\n parameters:\r\n....\r\n chunk_cluster_count: 50 # Number of forced clusters (overclustering) per unit chunk in long-form audio clustering.\r\n embeddings_per_chunk: 10000 # Number of embeddings in each chunk for long-form audio clustering. Adjust based on GPU memory capacity. (default: 10000, approximately 40 mins of audio) \r\n```\r\nYou should **increase** the `embeddings_per_chunk` value to consume less amount of memory.\r\nAlso note that even if you use long form audio clustering, there is a limit of audio length.\r\nThus, you need to make a compromise between performance and length. \r\nIncreasing `embeddings_per_chunk` will consume less memory but could lead to deteriorated performance.\r\n\r\n",
"tried now embeddings_per_chunk 50000, and also tried 500000. \r\ngpustat showed 0 GPU utilization after embedding, there was a small step of get_argmin_mat and then OOM.. (There wasn't enough time to see more steps). \r\n\r\nWhat can I do to debug it further (suppose I can't export the audio)?\r\nThank you. ",
"Also, what is the supported limit of audio length with long form audio clustering? (Is is less than 4 hours?)\r\nIncreasing embeddings_per_chunk will consume less memory in CPU RAM? or in GPU vRAM? \r\nIn \"deteriorated performance\" you mean less good results? or that it will take greater time?",
"@tango4j 🙏",
"> gpustat showed 0 GPU utilization after embedding, there was a small step of get_argmin_mat and then OOM.. (There wasn't enough time to see more steps).\r\n\r\nFirst check `torch.cuda.is_available()` in your pytorch env.\r\nSecond,\r\n[diarizer_model = NeuralDiarizer(cfg).to(device)](https://github.com/NVIDIA/NeMo/blob/4e7293a1011918fd90a073bb86bf3e54c7c766f4/examples/speaker_tasks/diarization/neural_diarizer/multiscale_diar_decoder_infer.py#L32)\r\ncheck if this model variable is assigned to the device you want.\r\n\r\n> Also, what is the supported limit of audio length with long form audio clustering? (Is is less than 4 hours?)\r\n\r\nThis depends on your GPU memory size, portion of detected silence in your audio file (3) `embeddings_per_chunk` variable you set. This cannot be answered without running the sample. \r\nHowever, your script is loading embedding vectors to CPU RAM, so GPU RAM size is not even an issue. Please make sure everything is loaded on GPU RAM.\r\n\r\n> you mean less good results? or that it will take greater time?\r\n\r\nThis means speaker counting can be wrong (wrong number of speakers) and diarization accuracy can be dropped.",
"@tango4j \r\ncuda.is_available() is True, device is cuda:0 (as I've mentioned). \r\nI'm using ClusteringDiarizer, is NeuralDiarizer more recommended? or might behave elsewise regarding doing all computations on GPU and not CPU?\r\n\r\nmy GPU is T4 with 14G vRAM. \r\nClusteringDiarizer model is moved to GPU, vad is running on GPU, embeddings are running on GPU. \r\nWhy would get_argmin_mat method use CPU RAM so highly? (or other steps of clustering?)\r\n\r\nWhat else can I do to make sure everything is loaded on GPU RAM?",
"@tango4j any idea?",
"@tttalshaul \r\nHi. Now I can see that the CPU-RAM that is piling up is speaker embedding vectors for clustering.\r\nThat speaker embedding vectors cannot be removed since it needs to be used for clustering process.\r\nThis can only fixed by saving the speaker embedding to your disk drive and load it again. (Since you are trying very long audio) - This feature should be implemented in the future.\r\n\r\nHowever, you have another quick solution:\r\nhttps://github.com/chimechallenge/C8DASR-Baseline-NeMo/tree/main/scripts/chime8\r\n\r\nNeMo team is supporting CHiME-8 Challenge and we are providing the baseline for everyone.\r\nThis version of diarization uses less amount of memory, so there is a chance that this version performs without OOM (although not guaranteed)\r\nIf you are urgent on this task, please try CHiME-8 baseline diarization.\r\n\r\n\r\n\r\n",
"Hello @tango4j! Are you talking about `msdd_v2_models` or `msdd_v3_models` module? Does the new MSDD model provide the same DER?",
"I have also faced a CUDA OOM on long audio samples. Maybe my solution might help you too? https://github.com/NVIDIA/NeMo/pull/8469\r\n\r\nSurprisingly, small changes in math helped not to hit the limit of GPU capacity.",
"@dkurt \r\nThere are two types of OOM issues:\r\n`CPU-RAM OOM`: After extracting speaker embeddings with GPU, it needs to load off the vectors to CPU-RAM, cause GPU-RAM is \r\n heavily limited. However, if an audio file is even longer than the amount that your CPU-RAM can hold, CPU-RAM will be maxed out. One way to solve this is that you can write speaker embedding files on your disk drive than load again to avoid this. We do not implement this because it will slow down the process a lot.\r\n`GPU-RAM OOM`: this happens affinity matrix grows too big since it has O(n^2). This can be mitigated by increasing the :\r\n`embeddings_per_chunk` to a bigger number to a certain degree. But this also has limit since GPU-RAM is not inifinite. Try increasing this parameter as I stated above. ",
"@khaykingleb The MSDD-v2 model for Chime8 baseline will give you a different DER number for the same audio file, since these chime8 models are tuned for chime7 train/dev datasets.",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"@tango4j Thank you, \r\nDo you have an example of how to use Chime8 diarization inference with custom input files? jupyter notebook or other example?\r\nI'll try that..",
"I believe it has the same interface. For example, you can see `examples/speaker_tasks/diarization/neural_diarizer/multiscale_diar_decoder_v2_infer.py`. \r\n\r\nBut the running doesn't work even if you download `MSDD_v2_PALO_100ms_intrpl_3scales.nemo` from HuggingFace Hub and try `examples/speaker_tasks/diarization/conf/inference/diar_infer_msdd_v2.yaml` instead. \r\n\r\nI get the following error:\r\n```\r\nFile ~/experiments/C8DASR-Baseline-NeMo/nemo/collections/asr/models/msdd_v2_models.py:1132, in EncDecDiarLabelModel.forward_vad(self, audio_signal, audio_signal_length)\r\n 1130 def forward_vad(self, audio_signal, audio_signal_length):\r\n 1131 log_probs = self.msdd._vad_model(input_signal=audio_signal, input_signal_length=audio_signal_length)\r\n-> 1132 vad_probs = torch.softmax(log_probs, dim=-1)[:,:,1]\r\n 1133 vad_probs_frame = torch.repeat_interleave(vad_probs, self.subsample_vad, dim=1)\r\n 1134 return vad_probs_frame\r\n\r\nIndexError: too many indices for tensor of dimension 2\r\n```\r\n\r\nAnd if I fix it, I get another error. @tango4j, can we really use MSDD V2? ",
"I've managed to run chime8 diarization somehow on a custom recording I've choosed but I've got not good results..\r\nI'm using currently the LongClusteringDiarizer from gabitza-tech fork.. it splits the file to small chunks and of course don't OOM, but I'm not sure that the speakers in each split match the other splits.. ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"Hey, I made a solution that worked for me. Previously the code never went to long form clustering because it was giving OOM at get_argmin_mat. Let me know if this works for you. I was able to process a 5 hour audio on g4.xlarge using this. [Merge-Request](https://github.com/NVIDIA/NeMo/pull/9114)",
"Thanks for creating the PR, @tango4j could you please help to review the PR. ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale.",
"The issue still exists\r\nPlease view the [PR](https://github.com/NVIDIA/NeMo/pull/9114)",
"@tango4j please add your comments/views for the PR. ",
"@nithinraok \r\nI was not able to get the 4hour long audio samples yet. Once I get access to it, I will work on this PR. ",
"@tango4j Have you got the 4hour audio samples? \r\nWhen do you think you will be available to approve the PR? \r\nIt's waiting for 3 months already.. \r\nThank you.",
"Hey @tango4j @nithinraok Please view the [PR](https://github.com/NVIDIA/NeMo/pull/9114). Its been waiting for quite a while now"
] | 2024-01-24T15:46:50 | 2024-09-21T01:55:56 | 2024-09-21T01:55:55 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I'm trying nemo_toolkit 1.22.0 on T4 (14G vRAM) with 40G cpu RAM to diarize with ClusteringDiarizer.
After completing speaker embeddings, tqdm shows "clustering: 0%" and then my script is getting killed by OS with error 137 OOM (out of memory) because of RAM consumption greater then 40G..
Installed nemo using pip install nemo_toolkit==1.22.0 (python 3.10 x64) on premise K8S.
I'm using diar_infer_meeting.yaml with max_num_speakers=20, chunk_cluster_count=50,
Tried to lower embeddings_per_chunk from default 10000 to 500 but it didn't help. | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8235/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8235/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8234 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8234/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8234/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8234/events | https://github.com/NVIDIA/NeMo/pull/8234 | 2,098,547,488 | PR_kwDOC_bI7s5k97V5 | 8,234 | add fsdp support for fine-tuning | {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days."
] | 2024-01-24T15:41:19 | 2024-02-19T14:59:33 | 2024-02-19T14:59:25 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8234",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8234",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8234.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8234.patch",
"merged_at": null
} | # What does this PR do ?
Adds FSDP support for NeMo fine-tuning.
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8234/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8234/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8233 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8233/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8233/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8233/events | https://github.com/NVIDIA/NeMo/issues/8233 | 2,097,503,604 | I_kwDOC_bI7s59BV10 | 8,233 | Typo in data preparation script | {
"login": "advaitvd",
"id": 54492085,
"node_id": "MDQ6VXNlcjU0NDkyMDg1",
"avatar_url": "https://avatars.githubusercontent.com/u/54492085?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/advaitvd",
"html_url": "https://github.com/advaitvd",
"followers_url": "https://api.github.com/users/advaitvd/followers",
"following_url": "https://api.github.com/users/advaitvd/following{/other_user}",
"gists_url": "https://api.github.com/users/advaitvd/gists{/gist_id}",
"starred_url": "https://api.github.com/users/advaitvd/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/advaitvd/subscriptions",
"organizations_url": "https://api.github.com/users/advaitvd/orgs",
"repos_url": "https://api.github.com/users/advaitvd/repos",
"events_url": "https://api.github.com/users/advaitvd/events{/privacy}",
"received_events_url": "https://api.github.com/users/advaitvd/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-24T06:16:51 | 2024-03-02T01:43:17 | 2024-03-02T01:43:16 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | https://github.com/NVIDIA/NeMo/blob/d275d68048049e3a231ebf1a9a31ef810a4adcc7/tools/nemo_forced_aligner/utils/data_prep.py#L155 | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8233/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8233/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8232 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8232/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8232/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8232/events | https://github.com/NVIDIA/NeMo/issues/8232 | 2,097,408,709 | I_kwDOC_bI7s59A-rF | 8,232 | use_flash_attention does not control NVTE_FLASH_ATTN flag for transformer engine | {
"login": "ethanhe42",
"id": 10027339,
"node_id": "MDQ6VXNlcjEwMDI3MzM5",
"avatar_url": "https://avatars.githubusercontent.com/u/10027339?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ethanhe42",
"html_url": "https://github.com/ethanhe42",
"followers_url": "https://api.github.com/users/ethanhe42/followers",
"following_url": "https://api.github.com/users/ethanhe42/following{/other_user}",
"gists_url": "https://api.github.com/users/ethanhe42/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ethanhe42/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ethanhe42/subscriptions",
"organizations_url": "https://api.github.com/users/ethanhe42/orgs",
"repos_url": "https://api.github.com/users/ethanhe42/repos",
"events_url": "https://api.github.com/users/ethanhe42/events{/privacy}",
"received_events_url": "https://api.github.com/users/ethanhe42/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-24T04:31:33 | 2024-03-02T01:43:19 | 2024-03-02T01:43:18 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | use_flash_attention=False should set NVTE_FLASH_ATTN=0 | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8232/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8232/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8231 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8231/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8231/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8231/events | https://github.com/NVIDIA/NeMo/pull/8231 | 2,097,172,010 | PR_kwDOC_bI7s5k5RLd | 8,231 | PEFT training of an LLM as an embedding model | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins\r\n\r\n",
"jenkins",
"jenkins",
"closed in favor of #8622 "
] | 2024-01-23T23:55:09 | 2024-03-14T18:26:49 | 2024-03-14T18:26:48 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8231",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8231",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8231.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8231.patch",
"merged_at": null
} | # What does this PR do ?
train a Lora model to perform sentence embedding tasks which can be used for IR.
**Collection**: [NLP]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8231/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8231/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8230 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8230/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8230/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8230/events | https://github.com/NVIDIA/NeMo/pull/8230 | 2,096,623,325 | PR_kwDOC_bI7s5k3ZDt | 8,230 | Syncing random seed between ranks in generate | {
"login": "Kipok",
"id": 2354422,
"node_id": "MDQ6VXNlcjIzNTQ0MjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2354422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kipok",
"html_url": "https://github.com/Kipok",
"followers_url": "https://api.github.com/users/Kipok/followers",
"following_url": "https://api.github.com/users/Kipok/following{/other_user}",
"gists_url": "https://api.github.com/users/Kipok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kipok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kipok/subscriptions",
"organizations_url": "https://api.github.com/users/Kipok/orgs",
"repos_url": "https://api.github.com/users/Kipok/repos",
"events_url": "https://api.github.com/users/Kipok/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kipok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins"
] | 2024-01-23T17:36:04 | 2024-01-25T17:29:36 | 2024-01-25T17:29:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8230",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8230",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8230.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8230.patch",
"merged_at": "2024-01-25T17:29:36"
} | # What does this PR do ?
While random_seed was added to generate, it was missing from the sync between ranks and so was not possible to use with MegatronServer. This PR fixes that.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Kipok",
"id": 2354422,
"node_id": "MDQ6VXNlcjIzNTQ0MjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2354422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kipok",
"html_url": "https://github.com/Kipok",
"followers_url": "https://api.github.com/users/Kipok/followers",
"following_url": "https://api.github.com/users/Kipok/following{/other_user}",
"gists_url": "https://api.github.com/users/Kipok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kipok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kipok/subscriptions",
"organizations_url": "https://api.github.com/users/Kipok/orgs",
"repos_url": "https://api.github.com/users/Kipok/repos",
"events_url": "https://api.github.com/users/Kipok/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kipok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8230/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8230/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8229 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8229/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8229/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8229/events | https://github.com/NVIDIA/NeMo/pull/8229 | 2,096,471,646 | PR_kwDOC_bI7s5k23eX | 8,229 | Fix preprocessing of data for Megatron when loading data files from a directory | {
"login": "tm1897",
"id": 32906377,
"node_id": "MDQ6VXNlcjMyOTA2Mzc3",
"avatar_url": "https://avatars.githubusercontent.com/u/32906377?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tm1897",
"html_url": "https://github.com/tm1897",
"followers_url": "https://api.github.com/users/tm1897/followers",
"following_url": "https://api.github.com/users/tm1897/following{/other_user}",
"gists_url": "https://api.github.com/users/tm1897/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tm1897/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tm1897/subscriptions",
"organizations_url": "https://api.github.com/users/tm1897/orgs",
"repos_url": "https://api.github.com/users/tm1897/repos",
"events_url": "https://api.github.com/users/tm1897/events{/privacy}",
"received_events_url": "https://api.github.com/users/tm1897/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"Anyone willing to review? It's really a small change.\r\n\r\n@MaximumEntropy, @ericharper, @ekmb, @yzhang123, @VahidooX, @vladgets, @okuchaiev",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-23T16:26:28 | 2024-02-22T01:43:41 | 2024-02-22T01:43:40 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8229",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8229",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8229.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8229.patch",
"merged_at": null
} | # What does this PR do ?
Fix preprocess data for megatron: loading files from a directory.
**Collection**: nlp
# Changelog
- Open a JSON file from the specified directory.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
NLP collection: @MaximumEntropy, @ericharper
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8229/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8229/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8228 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8228/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8228/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8228/events | https://github.com/NVIDIA/NeMo/issues/8228 | 2,096,447,859 | I_kwDOC_bI7s589UFz | 8,228 | Can't download vad_multilingual_frame_marlblenet | {
"login": "gabitza-tech",
"id": 53811655,
"node_id": "MDQ6VXNlcjUzODExNjU1",
"avatar_url": "https://avatars.githubusercontent.com/u/53811655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gabitza-tech",
"html_url": "https://github.com/gabitza-tech",
"followers_url": "https://api.github.com/users/gabitza-tech/followers",
"following_url": "https://api.github.com/users/gabitza-tech/following{/other_user}",
"gists_url": "https://api.github.com/users/gabitza-tech/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gabitza-tech/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gabitza-tech/subscriptions",
"organizations_url": "https://api.github.com/users/gabitza-tech/orgs",
"repos_url": "https://api.github.com/users/gabitza-tech/repos",
"events_url": "https://api.github.com/users/gabitza-tech/events{/privacy}",
"received_events_url": "https://api.github.com/users/gabitza-tech/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"Hi, any updates?",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-23T16:16:08 | 2024-03-14T01:44:10 | 2024-03-14T01:44:09 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi,
For the last couple of days I have tried to download the VAD frame-multilingual marblenet model and I receive an error:
```
wget --content-disposition https://api.ngc.nvidia.com/v2/models/nvidia/nemo/vad_multilingual_frame_marblenet/versions/1.20.0/zip -O vad_multilingual_frame_marblenet_1.20.0.zip
--2024-01-23 16:14:29-- https://api.ngc.nvidia.com/v2/models/nvidia/nemo/vad_multilingual_frame_marblenet/versions/1.20.0/zip
Resolving api.ngc.nvidia.com (api.ngc.nvidia.com)... 54.188.231.142, 34.223.159.108
Connecting to api.ngc.nvidia.com (api.ngc.nvidia.com)|54.188.231.142|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-01-23 16:14:30 ERROR 404: Not Found.
```
Could you please help? Also tried direct download.
Best regards,
Gabriel | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8228/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8228/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8227 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8227/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8227/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8227/events | https://github.com/NVIDIA/NeMo/pull/8227 | 2,096,439,990 | PR_kwDOC_bI7s5k2wfe | 8,227 | [docs] Add --force_codec to tarred dataset creation examples | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-01-23T16:11:49 | 2024-01-23T16:56:39 | 2024-01-23T16:56:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8227",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8227",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8227.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8227.patch",
"merged_at": "2024-01-23T16:56:39"
} | # What does this PR do ?
Add --force_codec to tarred dataset creation examples
**Collection**: All speech collections
# Changelog
- [docs] Add --force_codec to tarred dataset creation examples
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [x] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8227/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8227/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8226 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8226/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8226/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8226/events | https://github.com/NVIDIA/NeMo/pull/8226 | 2,096,406,530 | PR_kwDOC_bI7s5k2pOb | 8,226 | Temporarily use the previous RNN-T decoding algorithm as default | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"@GNroy, @andrusenkoau FYI"
] | 2024-01-23T15:55:17 | 2024-01-23T19:05:09 | 2024-01-23T19:05:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8226",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8226",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8226.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8226.patch",
"merged_at": "2024-01-23T19:05:08"
} | # What does this PR do ?
Use previous RNN-T decoding algorithm as default (`loop_labels=False`)
**Collection**: [ASR]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8226/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8226/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8225 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8225/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8225/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8225/events | https://github.com/NVIDIA/NeMo/issues/8225 | 2,096,384,288 | I_kwDOC_bI7s589Ekg | 8,225 | Is there a method to add an N-gram to streaming ASR with cache-aware model? | {
"login": "gabitza-tech",
"id": 53811655,
"node_id": "MDQ6VXNlcjUzODExNjU1",
"avatar_url": "https://avatars.githubusercontent.com/u/53811655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gabitza-tech",
"html_url": "https://github.com/gabitza-tech",
"followers_url": "https://api.github.com/users/gabitza-tech/followers",
"following_url": "https://api.github.com/users/gabitza-tech/following{/other_user}",
"gists_url": "https://api.github.com/users/gabitza-tech/gists{/gist_id}",
"starred_url": "https://api.github.com/users/gabitza-tech/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gabitza-tech/subscriptions",
"organizations_url": "https://api.github.com/users/gabitza-tech/orgs",
"repos_url": "https://api.github.com/users/gabitza-tech/repos",
"events_url": "https://api.github.com/users/gabitza-tech/events{/privacy}",
"received_events_url": "https://api.github.com/users/gabitza-tech/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Streaming ASR at the moment does not support ngram",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-23T15:44:48 | 2024-03-01T01:45:20 | 2024-03-01T01:45:19 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hi,
I would like to use a cache-aware streaming model with CTC decoder + n-gram. Is this feature supported or could you give me some ideas on how I could implement this?
Thank you in advance! Any help is greatly appreaciated!
Best regards,
Gabi | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8225/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8225/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8223 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8223/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8223/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8223/events | https://github.com/NVIDIA/NeMo/pull/8223 | 2,096,141,276 | PR_kwDOC_bI7s5k1v35 | 8,223 | Context-biasing by CTC-based Word Spotter (CTC-WS) | {
"login": "andrusenkoau",
"id": 52885736,
"node_id": "MDQ6VXNlcjUyODg1NzM2",
"avatar_url": "https://avatars.githubusercontent.com/u/52885736?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/andrusenkoau",
"html_url": "https://github.com/andrusenkoau",
"followers_url": "https://api.github.com/users/andrusenkoau/followers",
"following_url": "https://api.github.com/users/andrusenkoau/following{/other_user}",
"gists_url": "https://api.github.com/users/andrusenkoau/gists{/gist_id}",
"starred_url": "https://api.github.com/users/andrusenkoau/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andrusenkoau/subscriptions",
"organizations_url": "https://api.github.com/users/andrusenkoau/orgs",
"repos_url": "https://api.github.com/users/andrusenkoau/repos",
"events_url": "https://api.github.com/users/andrusenkoau/events{/privacy}",
"received_events_url": "https://api.github.com/users/andrusenkoau/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "GNroy",
"id": 16904306,
"node_id": "MDQ6VXNlcjE2OTA0MzA2",
"avatar_url": "https://avatars.githubusercontent.com/u/16904306?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/GNroy",
"html_url": "https://github.com/GNroy",
"followers_url": "https://api.github.com/users/GNroy/followers",
"following_url": "https://api.github.com/users/GNroy/following{/other_user}",
"gists_url": "https://api.github.com/users/GNroy/gists{/gist_id}",
"starred_url": "https://api.github.com/users/GNroy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GNroy/subscriptions",
"organizations_url": "https://api.github.com/users/GNroy/orgs",
"repos_url": "https://api.github.com/users/GNroy/repos",
"events_url": "https://api.github.com/users/GNroy/events{/privacy}",
"received_events_url": "https://api.github.com/users/GNroy/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins"
] | 2024-01-23T13:51:57 | 2024-02-13T12:05:08 | 2024-02-13T12:05:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8223",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8223",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8223.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8223.patch",
"merged_at": "2024-02-13T12:05:08"
} | # What does this PR do ?
A new context-biasing method for CTC and Transducer (RNNT) models (only Hybrid Transducer-CTC in case of Transducer) by CTC-based Word Spotter (CTC-WS). The idea is to use CTC logprobs for fast decoding with context-biasing graph (tree). The context-biasing graph is built according to the context-biasing list of words/phrases and CTC transition topology. Obtained results (words with start/end timestamps) are merged with greedy CTC/Transducer word-level predictions.
CTC-WS allows context-biasing in greedy decoding mode which is much faster than approaches based on shallow fusion (beam search decoding with external lm or context-biasing graph).
A detailed description of the CTC-WS algorithm and the comparison results will be published later.
**Collection**: [ASR]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
```python
python scripts/asr_context_biasing/eval_greedy_decoding_with_context_biasing.py \
nemo_model_file=<path to the .nemo file of the model> \
input_manifest=<path to the evaluation JSON manifest file \
preds_output_folder=<optional folder to store the predictions> \
decoder_type=<type of model decoder [ctc or rnnt]> \
acoustic_batch_size=<batch size to calculate log probabilities> \
apply_context_biasing=<True or False to apply context biasing> \
context_file=<path to the context biasing file with key words/phrases> \
beam_threshold=[<list of the beam thresholds, separated with commas>] \
context_score=[<list of the context scores, separated with commas>] \
ctc_ali_token_weight=[<list of the ctc alignment token weights, separated with commas>] \
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "andrusenkoau",
"id": 52885736,
"node_id": "MDQ6VXNlcjUyODg1NzM2",
"avatar_url": "https://avatars.githubusercontent.com/u/52885736?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/andrusenkoau",
"html_url": "https://github.com/andrusenkoau",
"followers_url": "https://api.github.com/users/andrusenkoau/followers",
"following_url": "https://api.github.com/users/andrusenkoau/following{/other_user}",
"gists_url": "https://api.github.com/users/andrusenkoau/gists{/gist_id}",
"starred_url": "https://api.github.com/users/andrusenkoau/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andrusenkoau/subscriptions",
"organizations_url": "https://api.github.com/users/andrusenkoau/orgs",
"repos_url": "https://api.github.com/users/andrusenkoau/repos",
"events_url": "https://api.github.com/users/andrusenkoau/events{/privacy}",
"received_events_url": "https://api.github.com/users/andrusenkoau/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8223/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8223/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8222 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8222/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8222/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8222/events | https://github.com/NVIDIA/NeMo/pull/8222 | 2,095,295,628 | PR_kwDOC_bI7s5ky4Gk | 8,222 | Pre-compute max_seqlen and cu_seqlens_argmin in all model-parallel cases | {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Jenkins"
] | 2024-01-23T05:56:46 | 2024-02-02T02:03:49 | 2024-01-23T16:42:45 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8222",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8222",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8222.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8222.patch",
"merged_at": "2024-01-23T16:42:45"
} | # What does this PR do ?
Pre-compute max_seqlen and cu_seqlens_argmin in all model-parallel cases.
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8222/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8222/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8221 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8221/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8221/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8221/events | https://github.com/NVIDIA/NeMo/pull/8221 | 2,095,088,191 | PR_kwDOC_bI7s5kyMdE | 8,221 | Improve communication overlapping in FP8 distributed optimizer | {
"login": "timmoon10",
"id": 4406448,
"node_id": "MDQ6VXNlcjQ0MDY0NDg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4406448?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/timmoon10",
"html_url": "https://github.com/timmoon10",
"followers_url": "https://api.github.com/users/timmoon10/followers",
"following_url": "https://api.github.com/users/timmoon10/following{/other_user}",
"gists_url": "https://api.github.com/users/timmoon10/gists{/gist_id}",
"starred_url": "https://api.github.com/users/timmoon10/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/timmoon10/subscriptions",
"organizations_url": "https://api.github.com/users/timmoon10/orgs",
"repos_url": "https://api.github.com/users/timmoon10/repos",
"events_url": "https://api.github.com/users/timmoon10/events{/privacy}",
"received_events_url": "https://api.github.com/users/timmoon10/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1719393562,
"node_id": "MDU6TGFiZWwxNzE5MzkzNTYy",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/feature",
"name": "feature",
"color": "68F3F0",
"default": false,
"description": "request/PR for a new feature"
},
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"jenkins",
"jenkins"
] | 2024-01-23T01:50:19 | 2024-02-08T22:02:04 | 2024-02-08T22:02:04 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8221",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8221",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8221.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8221.patch",
"merged_at": "2024-02-08T22:02:04"
} | # What does this PR do ?
When training GPT, the Apex distributed Adam optimizer overlaps its first parameter all-gather with the optimizer step. This optimization has been applied to both FP8 and non-FP8 models.
**Collection**: NLP
# Changelog
- Wait until all distopt buckets finish optimizer step before updating FP8 scaling factors
- Support dist opt buckets with multiple dtype configs
- Put GPT "leftover params" (i.e. embeddings, layer norm params, biases) in same distopt bucket as first layer params
# Usage
Run GPT, e.g. with the config at https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/language_modeling/conf/megatron_gpt_config.yaml.
Enable FP8 support with `model.fp8=True`, FP8 parameters with `model.fp8_params=True`, the distributed optimizer with `model.optim.name=distributed_fused_adam`, and overlapped param all-gathers with `model.optim.overlap_param_sync=True`
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* This PR was implemented together with https://github.com/NVIDIA/apex/pull/1771. Each of the two PRs should be able to run without the other, but there may be performance degradations when training GPT with FP8 params. With the Apex PR and without the NeMo PR, there will be redundant amax reductions. Without the Apex PR and with the NeMo PR, the first bucket all-gather will not be overlapped with the optimizer step.
* This communication optimization used to be present for non-FP8 models, but was removed in https://github.com/NVIDIA/NeMo/pull/7359
* Distributed optimizer support for FP8 models was added in https://github.com/NVIDIA/NeMo/pull/7909 | {
"login": "timmoon10",
"id": 4406448,
"node_id": "MDQ6VXNlcjQ0MDY0NDg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4406448?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/timmoon10",
"html_url": "https://github.com/timmoon10",
"followers_url": "https://api.github.com/users/timmoon10/followers",
"following_url": "https://api.github.com/users/timmoon10/following{/other_user}",
"gists_url": "https://api.github.com/users/timmoon10/gists{/gist_id}",
"starred_url": "https://api.github.com/users/timmoon10/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/timmoon10/subscriptions",
"organizations_url": "https://api.github.com/users/timmoon10/orgs",
"repos_url": "https://api.github.com/users/timmoon10/repos",
"events_url": "https://api.github.com/users/timmoon10/events{/privacy}",
"received_events_url": "https://api.github.com/users/timmoon10/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8221/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8221/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8220 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8220/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8220/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8220/events | https://github.com/NVIDIA/NeMo/pull/8220 | 2,095,059,032 | PR_kwDOC_bI7s5kyGWO | 8,220 | Add video support to NeVA LLM conversation data [VideoNeVA] | {
"login": "PannuMuthu",
"id": 30813477,
"node_id": "MDQ6VXNlcjMwODEzNDc3",
"avatar_url": "https://avatars.githubusercontent.com/u/30813477?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PannuMuthu",
"html_url": "https://github.com/PannuMuthu",
"followers_url": "https://api.github.com/users/PannuMuthu/followers",
"following_url": "https://api.github.com/users/PannuMuthu/following{/other_user}",
"gists_url": "https://api.github.com/users/PannuMuthu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PannuMuthu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PannuMuthu/subscriptions",
"organizations_url": "https://api.github.com/users/PannuMuthu/orgs",
"repos_url": "https://api.github.com/users/PannuMuthu/repos",
"events_url": "https://api.github.com/users/PannuMuthu/events{/privacy}",
"received_events_url": "https://api.github.com/users/PannuMuthu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 6627254865,
"node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal",
"name": "Multi Modal",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"@yaoyu-33",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-23T01:13:02 | 2024-08-19T01:52:52 | 2024-08-19T01:52:52 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8220",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8220",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8220.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8220.patch",
"merged_at": null
} | # What does this PR do ?
Refactors `preprocess_multimodal` to support video tokens in LLM conversation data
**Collection**: Multimodal - NeVA
# Changelog
- Adds `videoneva_dataset.py` and `conversation.py` to `/nemo/collections/multimodal/data/`
- `videoneva_dataset.py` implements `TarOrFolderVisualLoader` (modified from `neva_dataset.py`), `tokenize`, and `preprocess_multimodal`
- `TarOrFolderVisualLoader` is a modification of `TarOrFolderImageLoader` (from `neva_dataset.py`) which extends support to video files with the `open_video` function
- `tokenize` is identical to `neva_dataset.py` implementation
- `preprocess_multimodal` extends `preprocess_multimodal` from `neva_dataset.py` to include support for video tokens
- `videoneva/conversation.py` is a modification of `neva/conversation.py` to include additional video-related constants
# Usage
* You can potentially add a usage example below
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8220/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8220/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8219 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8219/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8219/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8219/events | https://github.com/NVIDIA/NeMo/issues/8219 | 2,094,971,156 | I_kwDOC_bI7s583rkU | 8,219 | Add support for HF style Bert | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
{
"login": "shanmugamr1992",
"id": 111910568,
"node_id": "U_kgDOBqueqA",
"avatar_url": "https://avatars.githubusercontent.com/u/111910568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shanmugamr1992",
"html_url": "https://github.com/shanmugamr1992",
"followers_url": "https://api.github.com/users/shanmugamr1992/followers",
"following_url": "https://api.github.com/users/shanmugamr1992/following{/other_user}",
"gists_url": "https://api.github.com/users/shanmugamr1992/gists{/gist_id}",
"starred_url": "https://api.github.com/users/shanmugamr1992/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shanmugamr1992/subscriptions",
"organizations_url": "https://api.github.com/users/shanmugamr1992/orgs",
"repos_url": "https://api.github.com/users/shanmugamr1992/repos",
"events_url": "https://api.github.com/users/shanmugamr1992/events{/privacy}",
"received_events_url": "https://api.github.com/users/shanmugamr1992/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [] | 2024-01-22T23:37:33 | 2024-01-22T23:38:08 | 2024-01-22T23:38:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Is your feature request related to a problem? Please describe.**
Post-LN is not supported in MCore transformer at the moment (everything is Pre-LN). In order to convert HF checkpoints, we want to add post-LN style to MCore as well. Post-LN requires an additional LN in the beginning of the network as well.
**Describe the solution you'd like**
Please refer to NeMo code update here for HF Bert support: https://github.com/NVIDIA/NeMo/pull/8088
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8219/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8219/timeline | null | completed | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8217 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8217/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8217/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8217/events | https://github.com/NVIDIA/NeMo/pull/8217 | 2,094,866,644 | PR_kwDOC_bI7s5kxb7c | 8,217 | NeVA Tutorial Notebook | {
"login": "PannuMuthu",
"id": 30813477,
"node_id": "MDQ6VXNlcjMwODEzNDc3",
"avatar_url": "https://avatars.githubusercontent.com/u/30813477?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PannuMuthu",
"html_url": "https://github.com/PannuMuthu",
"followers_url": "https://api.github.com/users/PannuMuthu/followers",
"following_url": "https://api.github.com/users/PannuMuthu/following{/other_user}",
"gists_url": "https://api.github.com/users/PannuMuthu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/PannuMuthu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PannuMuthu/subscriptions",
"organizations_url": "https://api.github.com/users/PannuMuthu/orgs",
"repos_url": "https://api.github.com/users/PannuMuthu/repos",
"events_url": "https://api.github.com/users/PannuMuthu/events{/privacy}",
"received_events_url": "https://api.github.com/users/PannuMuthu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"@yaoyu-33 ",
"Verified `torchrun` can be executed in NeMo Container 1.23.10 within the notebook:\r\n\r\n**Pretrain**: \r\n\r\n\r\n**Finetune**:\r\n\r\n\r\n**Inference**:\r\n\r\n",
"jenkins",
"jenkins"
] | 2024-01-22T22:19:01 | 2024-02-16T03:37:09 | 2024-02-16T03:37:09 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8217",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8217",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8217.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8217.patch",
"merged_at": "2024-02-16T03:37:09"
} | # What does this PR do ?
Adds NeVA tutorial for training / inference
**Collection**: Multimodal
# Changelog
- New Jupyter notebook under `NeMo/tutorials/multimodal` outlining steps for pretraining and instruction fine-tuning NeVA
# Usage
* Documentation purposes
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8217/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8217/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8216 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8216/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8216/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8216/events | https://github.com/NVIDIA/NeMo/pull/8216 | 2,094,597,430 | PR_kwDOC_bI7s5kwguE | 8,216 | Fix to peft & virtual pipeline parallel unsupported check | {
"login": "vysarge",
"id": 10239441,
"node_id": "MDQ6VXNlcjEwMjM5NDQx",
"avatar_url": "https://avatars.githubusercontent.com/u/10239441?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vysarge",
"html_url": "https://github.com/vysarge",
"followers_url": "https://api.github.com/users/vysarge/followers",
"following_url": "https://api.github.com/users/vysarge/following{/other_user}",
"gists_url": "https://api.github.com/users/vysarge/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vysarge/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vysarge/subscriptions",
"organizations_url": "https://api.github.com/users/vysarge/orgs",
"repos_url": "https://api.github.com/users/vysarge/repos",
"events_url": "https://api.github.com/users/vysarge/events{/privacy}",
"received_events_url": "https://api.github.com/users/vysarge/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@cuichenx / @ericharper can you review? Thanks!",
"jenkins"
] | 2024-01-22T19:23:12 | 2024-03-12T22:36:39 | 2024-01-23T19:15:08 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8216",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8216",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8216.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8216.patch",
"merged_at": "2024-01-23T19:15:08"
} | # What does this PR do ?
Corrects the check added in [PR-7964](https://github.com/NVIDIA/NeMo/pull/7964) to raise a ValueError when attempting to run virtual pipeline parallel with peft.
**Collection**: nlp/language_modeling
# Changelog
- Moves this safety check from `MegatronGPTSFTModel.__init__` (where self.use_peft had not yet been set to true, so the check did not function) to `NLPAdapterModelMixin.add_adapter`
# Usage
Running with the unsupported combination of peft and virtual pipeline parallel now yields a more useful error message:
```
python examples/nlp/language_modeling/tuning/megatron_gpt_peft_tuning.py \
++model.virtual_pipeline_model_parallel_size=10 \
++model.peft.peft_scheme=lora \
...
```
gives
```
File "/opt/NeMo/examples/nlp/language_modeling/tuning/megatron_gpt_peft_tuning.py", line 73, in main
model.add_adapter(peft_cfg_cls(model_cfg))
File "/opt/NeMo/nemo/collections/nlp/parts/mixins/nlp_adapter_mixins.py", line 178, in add_adapter
raise ValueError('Virtual pipeline model parallel is not supported when using PEFT')
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8216/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8216/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8215 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8215/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8215/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8215/events | https://github.com/NVIDIA/NeMo/pull/8215 | 2,094,508,028 | PR_kwDOC_bI7s5kwNIb | 8,215 | Add `loop_labels` algorithm for TDT greedy decoding | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Should be reviewed/merged after #8286",
"@hainan-xv Do we have any small model for tests? I have no idea how to write tests for the decoding without the model",
"jenkins",
"jenkins",
"jenkins",
"jenkins"
] | 2024-01-22T18:31:41 | 2024-02-16T08:33:06 | 2024-02-16T08:33:05 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8215",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8215",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8215.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8215.patch",
"merged_at": "2024-02-16T08:33:05"
} | # What does this PR do ?
TDT greedy decoding using`loop_labels` algorithm introduced in #7926.
**Collection**: [ASR]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8215/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8215/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8214 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8214/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8214/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8214/events | https://github.com/NVIDIA/NeMo/issues/8214 | 2,093,739,505 | I_kwDOC_bI7s58y-3x | 8,214 | Unable to train ASR model on multiple GPUs | {
"login": "ericininder",
"id": 155972611,
"node_id": "U_kgDOCUv0Aw",
"avatar_url": "https://avatars.githubusercontent.com/u/155972611?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericininder",
"html_url": "https://github.com/ericininder",
"followers_url": "https://api.github.com/users/ericininder/followers",
"following_url": "https://api.github.com/users/ericininder/following{/other_user}",
"gists_url": "https://api.github.com/users/ericininder/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericininder/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericininder/subscriptions",
"organizations_url": "https://api.github.com/users/ericininder/orgs",
"repos_url": "https://api.github.com/users/ericininder/repos",
"events_url": "https://api.github.com/users/ericininder/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericininder/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This is not the correct way to use distributed training in NeMo. We utilize pytorch lightning which calls ddp and torch distributed for you. Simply call your script with python ABC.py --config-path xyz/ --config-name something.yaml. \r\n\r\nYou can see some of the NeMo tutorials to see how we setup training with our scripts ",
"Thanks for your replying.\r\nI have already trained on one node & multiple GPU cards.\r\n@titu1994 \r\nHere's the another question, how to set up multi nodes' information such as MASTER_ADDRESS or MASTER_PORT by PyTorch Lightning.\r\nIs there any available tutorials?\r\nThanks a lot. ",
"It would be better to ask the folks at Pytorch Lightning since they might have the solution ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-22T11:50:33 | 2024-03-01T01:45:21 | 2024-03-01T01:45:21 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | The following is my command to launch distributed training in NeMO
python3 -m torch.distributed.launch --nproc_per_node=2 --nnode=1 examples/asr/asr_ctc/speech_to_text_ctc.py --config-path=examples/asr/conf/quartznet/ --config-name=quartznet_15x5
torch vision:2.0.1+cu118
GPU:A100
then, the error would occur due to unrecognized argument:--local-rank

How do I change the source code from "--local_rank" to "--local-rank"
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8214/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8214/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8213 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8213/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8213/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8213/events | https://github.com/NVIDIA/NeMo/issues/8213 | 2,093,559,003 | I_kwDOC_bI7s58ySzb | 8,213 | can you provide msdd_5scl_15_05_50Povl_infer.yaml?Inference for training models | {
"login": "xiulianzw",
"id": 20657139,
"node_id": "MDQ6VXNlcjIwNjU3MTM5",
"avatar_url": "https://avatars.githubusercontent.com/u/20657139?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/xiulianzw",
"html_url": "https://github.com/xiulianzw",
"followers_url": "https://api.github.com/users/xiulianzw/followers",
"following_url": "https://api.github.com/users/xiulianzw/following{/other_user}",
"gists_url": "https://api.github.com/users/xiulianzw/gists{/gist_id}",
"starred_url": "https://api.github.com/users/xiulianzw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xiulianzw/subscriptions",
"organizations_url": "https://api.github.com/users/xiulianzw/orgs",
"repos_url": "https://api.github.com/users/xiulianzw/repos",
"events_url": "https://api.github.com/users/xiulianzw/events{/privacy}",
"received_events_url": "https://api.github.com/users/xiulianzw/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-22T10:12:28 | 2024-02-29T01:43:48 | 2024-02-29T01:43:48 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
Provide a code snippet on how new APIs/changes would be used by others.
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
Add any other context or screenshots about the feature request here.
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8213/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8213/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8212 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8212/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8212/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8212/events | https://github.com/NVIDIA/NeMo/pull/8212 | 2,093,414,247 | PR_kwDOC_bI7s5ksdcW | 8,212 | Add support in Neural Typecheck to disable semantic checks | {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
}
] | closed | false | null | [] | null | [
"jenkins"
] | 2024-01-22T09:03:31 | 2024-01-24T18:25:27 | 2024-01-24T18:25:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8212",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8212",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8212.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8212.patch",
"merged_at": "2024-01-24T18:25:23"
} | # What does this PR do ?
Adds support to temporarily / permanently (and globally) disable semantic type checks.
**Collection**: [Core]
# Changelog
- Adds utility methods to disable global semantic type checking, or local context manager.
- Adds test to see if semantic types are properly ignored (but still input kwargs, shape and container checks)
# Usage
```python
import torch
from nemo.core import Typing, typecheck
from nemo.core.neural_types import *
class InputOutputTypes(Typing):
@property
def input_types(self):
return {"x": NeuralType(('B',), LogprobsType())}
@property
def output_types(self):
return {"y": NeuralType(('B',), LabelsType())}
@typecheck()
def __call__(self, x):
x += 1
return x
# Provide input with wrong type after disabling semantic type checks
with typecheck.disable_semantic_checks():
input_data = torch.zeros(10)
input_data.neural_type = NeuralType(('B',), LabelsType()) # Should be LogprobsType()
result = obj(x=input_data)
# assert that even if semantic types are disabled, output is attached with appropriate types
assert result.sum() == torch.tensor(10.0)
assert result.neural_type.compare(NeuralType(('B',), LabelsType())) == NeuralTypeComparisonResult.SAME
```
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8212/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8212/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8210 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8210/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8210/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8210/events | https://github.com/NVIDIA/NeMo/pull/8210 | 2,092,435,411 | PR_kwDOC_bI7s5kpR__ | 8,210 | Added support for neptune logger | {
"login": "harishankar-gopalan",
"id": 3500976,
"node_id": "MDQ6VXNlcjM1MDA5NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/3500976?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/harishankar-gopalan",
"html_url": "https://github.com/harishankar-gopalan",
"followers_url": "https://api.github.com/users/harishankar-gopalan/followers",
"following_url": "https://api.github.com/users/harishankar-gopalan/following{/other_user}",
"gists_url": "https://api.github.com/users/harishankar-gopalan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/harishankar-gopalan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/harishankar-gopalan/subscriptions",
"organizations_url": "https://api.github.com/users/harishankar-gopalan/orgs",
"repos_url": "https://api.github.com/users/harishankar-gopalan/repos",
"events_url": "https://api.github.com/users/harishankar-gopalan/events{/privacy}",
"received_events_url": "https://api.github.com/users/harishankar-gopalan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"Hi @titu1994 what would be the next process to get this merged to the main trunk ?",
"Could you avoid merging the main branch with this PR, I need to see the tests pass. It is fine if the branch is out of date with the main branch. ",
"jenkins",
"> jenkins\n\nI guess the automation is completed and all checks have passed.\n@titu1994 "
] | 2024-01-21T05:50:35 | 2024-01-23T08:52:46 | 2024-01-23T08:52:46 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8210",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8210",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8210.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8210.patch",
"merged_at": "2024-01-23T08:52:46"
} | # What does this PR do ?
Adds Neptune logging support to NeMo which is already exposed by the PTL trainer.
**Collection**: Core, NLP
# Changelog
- In experiment manager, consumed NeptuneLogger parameters from the OmegaConf
- Added tests for NeptuneLogger
- Added documentation for NeptuneLogger configuration
# Usage
* Can be directly used by configuring the mentioned keys in the docs under exp_manager similar to how WandB params are specified.
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
@titu1994
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8210/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 1,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8210/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8209 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8209/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8209/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8209/events | https://github.com/NVIDIA/NeMo/issues/8209 | 2,092,206,308 | I_kwDOC_bI7s58tIjk | 8,209 | [Question] Issue of Invalid output device when using pyaudio in VAD inference | {
"login": "ahkarami",
"id": 28620609,
"node_id": "MDQ6VXNlcjI4NjIwNjA5",
"avatar_url": "https://avatars.githubusercontent.com/u/28620609?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ahkarami",
"html_url": "https://github.com/ahkarami",
"followers_url": "https://api.github.com/users/ahkarami/followers",
"following_url": "https://api.github.com/users/ahkarami/following{/other_user}",
"gists_url": "https://api.github.com/users/ahkarami/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ahkarami/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ahkarami/subscriptions",
"organizations_url": "https://api.github.com/users/ahkarami/orgs",
"repos_url": "https://api.github.com/users/ahkarami/repos",
"events_url": "https://api.github.com/users/ahkarami/events{/privacy}",
"received_events_url": "https://api.github.com/users/ahkarami/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"@okuchaiev ",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-20T19:04:48 | 2024-03-04T01:46:46 | 2024-03-04T01:46:45 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | @fayejf
Hi,
I have implemented a code for using the Marble_Net VAD model according to the below tutorial:
[Online_Offline_Microphone_VAD_Demo](https://github.com/NVIDIA/NeMo/blob/stable/tutorials/asr/Online_Offline_Microphone_VAD_Demo.ipynb)
But I got the following error (I have tested it on Colab and two other servers):
```
OSError: [Errno -9996] Invalid output device (no default output device)
```
How can I address it? (I have searched the error and examined some solutions, but none of them worked. The issue related to the `pyaudio` library)
Would you please guide me that how can I remove the `pyaudio library` and use the VAD model for inferencing just a mono-channel 16Khz audio file in HDD?
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8209/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8209/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8208 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8208/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8208/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8208/events | https://github.com/NVIDIA/NeMo/pull/8208 | 2,092,058,499 | PR_kwDOC_bI7s5koDd9 | 8,208 | Added Neptune logger support | {
"login": "harishankar-gopalan",
"id": 3500976,
"node_id": "MDQ6VXNlcjM1MDA5NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/3500976?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/harishankar-gopalan",
"html_url": "https://github.com/harishankar-gopalan",
"followers_url": "https://api.github.com/users/harishankar-gopalan/followers",
"following_url": "https://api.github.com/users/harishankar-gopalan/following{/other_user}",
"gists_url": "https://api.github.com/users/harishankar-gopalan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/harishankar-gopalan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/harishankar-gopalan/subscriptions",
"organizations_url": "https://api.github.com/users/harishankar-gopalan/orgs",
"repos_url": "https://api.github.com/users/harishankar-gopalan/repos",
"events_url": "https://api.github.com/users/harishankar-gopalan/events{/privacy}",
"received_events_url": "https://api.github.com/users/harishankar-gopalan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Hi, thanks for the additional support for Neptune. Due to the ever growing dependency list for NeMo, we will make Neptune an optional dependency only. Please follow the suggestions above ",
"Oh also, could you follow DCOBot comments to sign your commits since that is a NeMo contribution requirement. ",
"> Oh also, could you follow DCOBot comments to sign your commits since that is a NeMo contribution requirement.\r\n\r\nI have amended the commits to include Sign off.",
"> Hi, thanks for the additional support for Neptune. Due to the ever growing dependency list for NeMo, we will make Neptune an optional dependency only. Please follow the suggestions above\r\n\r\nGot that, have made the changes to remove dependency from the requirements files."
] | 2024-01-20T13:42:01 | 2024-01-21T05:52:02 | 2024-01-21T05:52:02 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8208",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8208",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8208.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8208.patch",
"merged_at": null
} | # What does this PR do ?
Adds Neptune logging support to NeMo which is already exposed by the PTL trainer.
**Collection**: [Note which collection this PR will affect]
Affects the core/experiment manager collection
# Changelog
- In experiment manager, consumed NeptuneLogger parameters from the OmegaConf
- Added tests for NeptuneLogger
- Added documentation for NeptuneLogger configuration
# Usage
* Can be directly used by configuring the mentioned keys in the docs under exp_manager similar to how WandB params are specified.
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
@ericharper
# Additional Information
* Related to # (issue)
| {
"login": "harishankar-gopalan",
"id": 3500976,
"node_id": "MDQ6VXNlcjM1MDA5NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/3500976?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/harishankar-gopalan",
"html_url": "https://github.com/harishankar-gopalan",
"followers_url": "https://api.github.com/users/harishankar-gopalan/followers",
"following_url": "https://api.github.com/users/harishankar-gopalan/following{/other_user}",
"gists_url": "https://api.github.com/users/harishankar-gopalan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/harishankar-gopalan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/harishankar-gopalan/subscriptions",
"organizations_url": "https://api.github.com/users/harishankar-gopalan/orgs",
"repos_url": "https://api.github.com/users/harishankar-gopalan/repos",
"events_url": "https://api.github.com/users/harishankar-gopalan/events{/privacy}",
"received_events_url": "https://api.github.com/users/harishankar-gopalan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8208/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8208/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8207 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8207/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8207/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8207/events | https://github.com/NVIDIA/NeMo/pull/8207 | 2,091,800,898 | PR_kwDOC_bI7s5knOQb | 8,207 | Make TDT inference not require duration params | {
"login": "hainan-xv",
"id": 5440014,
"node_id": "MDQ6VXNlcjU0NDAwMTQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/5440014?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hainan-xv",
"html_url": "https://github.com/hainan-xv",
"followers_url": "https://api.github.com/users/hainan-xv/followers",
"following_url": "https://api.github.com/users/hainan-xv/following{/other_user}",
"gists_url": "https://api.github.com/users/hainan-xv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hainan-xv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hainan-xv/subscriptions",
"organizations_url": "https://api.github.com/users/hainan-xv/orgs",
"repos_url": "https://api.github.com/users/hainan-xv/repos",
"events_url": "https://api.github.com/users/hainan-xv/events{/privacy}",
"received_events_url": "https://api.github.com/users/hainan-xv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"@hainan-xv Thanks for the PR; I think it makes it more convenient to use decoding with TDT models. One minor comment about style.",
"jenkins"
] | 2024-01-20T01:45:16 | 2024-01-24T22:54:17 | 2024-01-24T22:53:54 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8207",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8207",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8207.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8207.patch",
"merged_at": "2024-01-24T22:53:54"
} | # What does this PR do ?
Making it so that TDT inference doesn't require --duration params to be passed.
**Collection**: [Note which collection this PR will affect]
ASR
# Changelog
The model now infers the duration params from model's loss configs.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hainan-xv",
"id": 5440014,
"node_id": "MDQ6VXNlcjU0NDAwMTQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/5440014?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hainan-xv",
"html_url": "https://github.com/hainan-xv",
"followers_url": "https://api.github.com/users/hainan-xv/followers",
"following_url": "https://api.github.com/users/hainan-xv/following{/other_user}",
"gists_url": "https://api.github.com/users/hainan-xv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hainan-xv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hainan-xv/subscriptions",
"organizations_url": "https://api.github.com/users/hainan-xv/orgs",
"repos_url": "https://api.github.com/users/hainan-xv/repos",
"events_url": "https://api.github.com/users/hainan-xv/events{/privacy}",
"received_events_url": "https://api.github.com/users/hainan-xv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8207/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8207/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8206 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8206/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8206/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8206/events | https://github.com/NVIDIA/NeMo/pull/8206 | 2,091,788,979 | PR_kwDOC_bI7s5knLsu | 8,206 | making TDT model inference easier without having to specify the duration parameters | {
"login": "hainan-xv",
"id": 5440014,
"node_id": "MDQ6VXNlcjU0NDAwMTQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/5440014?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hainan-xv",
"html_url": "https://github.com/hainan-xv",
"followers_url": "https://api.github.com/users/hainan-xv/followers",
"following_url": "https://api.github.com/users/hainan-xv/following{/other_user}",
"gists_url": "https://api.github.com/users/hainan-xv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hainan-xv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hainan-xv/subscriptions",
"organizations_url": "https://api.github.com/users/hainan-xv/orgs",
"repos_url": "https://api.github.com/users/hainan-xv/repos",
"events_url": "https://api.github.com/users/hainan-xv/events{/privacy}",
"received_events_url": "https://api.github.com/users/hainan-xv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-01-20T01:22:18 | 2024-01-20T01:36:03 | 2024-01-20T01:35:46 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8206",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8206",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8206.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8206.patch",
"merged_at": null
} | # What does this PR do ?
This PR makes ASR TDT model inference easier by not having to specify the duration parameters.
**Collection**: [Note which collection this PR will affect]
# Changelog
During inference, duration params are going to be inferred from the params from the 'loss' config of the model
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "hainan-xv",
"id": 5440014,
"node_id": "MDQ6VXNlcjU0NDAwMTQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/5440014?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hainan-xv",
"html_url": "https://github.com/hainan-xv",
"followers_url": "https://api.github.com/users/hainan-xv/followers",
"following_url": "https://api.github.com/users/hainan-xv/following{/other_user}",
"gists_url": "https://api.github.com/users/hainan-xv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hainan-xv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hainan-xv/subscriptions",
"organizations_url": "https://api.github.com/users/hainan-xv/orgs",
"repos_url": "https://api.github.com/users/hainan-xv/repos",
"events_url": "https://api.github.com/users/hainan-xv/events{/privacy}",
"received_events_url": "https://api.github.com/users/hainan-xv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8206/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8206/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8205 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8205/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8205/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8205/events | https://github.com/NVIDIA/NeMo/pull/8205 | 2,091,775,600 | PR_kwDOC_bI7s5knIw2 | 8,205 | Use PackedSeqParams in accordance with changes in Megatron-LM | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins"
] | 2024-01-20T00:55:31 | 2024-01-23T19:14:32 | 2024-01-23T19:14:31 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8205",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8205",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8205.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8205.patch",
"merged_at": "2024-01-23T19:14:31"
} | # What does this PR do ?
Change input to MCoreGPTModel if using packed sequence
**Collection**: NLP
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8205/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8205/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8204 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8204/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8204/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8204/events | https://github.com/NVIDIA/NeMo/pull/8204 | 2,091,181,363 | PR_kwDOC_bI7s5klC-T | 8,204 | [docker] Install k2 before NeMo for faster image rebuilding | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"CI doesn't build container, no point waiting for it. Fast merged "
] | 2024-01-19T19:11:55 | 2024-01-19T20:08:59 | 2024-01-19T20:08:39 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8204",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8204",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8204.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8204.patch",
"merged_at": "2024-01-19T20:08:39"
} | # What does this PR do ?
Speed up rebuilding NeMo images with NeMo code changes. Previously k2 would have to be rebuilt each time NeMo code changed because k2 building occurs in a later image layer. Proposed changes make it very fast to rebuild when changing NeMo python code, saving storage by not multiplying k2 build layers at the same time.
**Collection**: All
# Changelog
- Build k2 before installing NeMo in docker for faster rebuilds.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8204/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8204/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8203 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8203/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8203/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8203/events | https://github.com/NVIDIA/NeMo/pull/8203 | 2,090,044,763 | PR_kwDOC_bI7s5khREH | 8,203 | RNN-T and TDT Greedy Decoding with TorchScript | {
"login": "artbataev",
"id": 9380560,
"node_id": "MDQ6VXNlcjkzODA1NjA=",
"avatar_url": "https://avatars.githubusercontent.com/u/9380560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/artbataev",
"html_url": "https://github.com/artbataev",
"followers_url": "https://api.github.com/users/artbataev/followers",
"following_url": "https://api.github.com/users/artbataev/following{/other_user}",
"gists_url": "https://api.github.com/users/artbataev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/artbataev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/artbataev/subscriptions",
"organizations_url": "https://api.github.com/users/artbataev/orgs",
"repos_url": "https://api.github.com/users/artbataev/repos",
"events_url": "https://api.github.com/users/artbataev/events{/privacy}",
"received_events_url": "https://api.github.com/users/artbataev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-19T09:17:22 | 2024-04-10T01:44:47 | 2024-04-10T01:44:47 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8203",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8203",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8203.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8203.patch",
"merged_at": null
} | # What does this PR do ?
Adds torch.jit.script support for "loop labels" decoding algorithm, introduced in #7926
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8203/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8203/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8202 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8202/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8202/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8202/events | https://github.com/NVIDIA/NeMo/pull/8202 | 2,089,306,766 | PR_kwDOC_bI7s5kes8U | 8,202 | Add the interface to use SHARP to FSDP strategy | {
"login": "erhoo82",
"id": 15861259,
"node_id": "MDQ6VXNlcjE1ODYxMjU5",
"avatar_url": "https://avatars.githubusercontent.com/u/15861259?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erhoo82",
"html_url": "https://github.com/erhoo82",
"followers_url": "https://api.github.com/users/erhoo82/followers",
"following_url": "https://api.github.com/users/erhoo82/following{/other_user}",
"gists_url": "https://api.github.com/users/erhoo82/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erhoo82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erhoo82/subscriptions",
"organizations_url": "https://api.github.com/users/erhoo82/orgs",
"repos_url": "https://api.github.com/users/erhoo82/repos",
"events_url": "https://api.github.com/users/erhoo82/events{/privacy}",
"received_events_url": "https://api.github.com/users/erhoo82/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins"
] | 2024-01-18T23:55:27 | 2024-01-19T16:02:23 | 2024-01-19T16:02:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8202",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8202",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8202.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8202.patch",
"merged_at": "2024-01-19T16:02:23"
} | # What does this PR do ?
Add the SHARP argument interface to FSDP strategy.
SHARP here applies to the data-parallel process group.
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "dimapihtar",
"id": 37850217,
"node_id": "MDQ6VXNlcjM3ODUwMjE3",
"avatar_url": "https://avatars.githubusercontent.com/u/37850217?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dimapihtar",
"html_url": "https://github.com/dimapihtar",
"followers_url": "https://api.github.com/users/dimapihtar/followers",
"following_url": "https://api.github.com/users/dimapihtar/following{/other_user}",
"gists_url": "https://api.github.com/users/dimapihtar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dimapihtar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimapihtar/subscriptions",
"organizations_url": "https://api.github.com/users/dimapihtar/orgs",
"repos_url": "https://api.github.com/users/dimapihtar/repos",
"events_url": "https://api.github.com/users/dimapihtar/events{/privacy}",
"received_events_url": "https://api.github.com/users/dimapihtar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8202/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8202/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8201 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8201/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8201/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8201/events | https://github.com/NVIDIA/NeMo/pull/8201 | 2,089,105,893 | PR_kwDOC_bI7s5kd_Px | 8,201 | Rename Finetuning Scripts | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"LGTM!"
] | 2024-01-18T21:52:33 | 2024-01-20T00:19:07 | 2024-01-20T00:19:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8201",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8201",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8201.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8201.patch",
"merged_at": "2024-01-20T00:19:06"
} | # What does this PR do ?
Rename certain unified SFT/PEFT scripts to remove reference to 'PEFT' in the script name, since it was confusing for people to run SFT with a 'peft' script
Rename `*_peft_tuning*` to `*_finetuning*` to include both SFT and PEFT in naming.
Rename `*_peft_eval*` to `*_generate*` to achieve the above and also make clear that the script is simply used to generate text (run inference), and not calculate any metrics.
Old scripts are kept until the next release, with a deprecation message added.
Also making deprecating messages more prominent, with a banner and a wait timer so the message does not get drowned in other nemo logging messages.
**Collection**: NLP
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
- [x] UX Improvement
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8201/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8201/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8200 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8200/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8200/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8200/events | https://github.com/NVIDIA/NeMo/pull/8200 | 2,088,938,529 | PR_kwDOC_bI7s5kda3g | 8,200 | Concept draft of an extended input configuration format | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-18T19:40:30 | 2024-02-15T01:44:00 | 2024-02-15T01:44:00 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8200",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8200",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8200.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8200.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8200/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8200/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8199 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8199/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8199/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8199/events | https://github.com/NVIDIA/NeMo/pull/8199 | 2,088,852,996 | PR_kwDOC_bI7s5kdIUB | 8,199 | Fix CPU Initialization and TP>1 for LoRA Merge Script | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"LGTM!",
"jenkins"
] | 2024-01-18T18:37:18 | 2024-01-19T19:45:18 | 2024-01-19T19:45:17 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8199",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8199",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8199.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8199.patch",
"merged_at": "2024-01-19T19:45:17"
} | # What does this PR do ?
Fix 1) merging on CPU, in cases where a GPU is not available, and 2) merging a LoRA model trained with TP>1 into a base model in the distributed checkpointing format.
Tested on Llama2-7b + TP {1, 2, 4} LoRA ckpt, with cpu and gpu options
# Usage
Merging on GPU/CPU can be controlled by
`trainer.accelerator='cpu' | 'gpu'`
Also, the script should always be run with
`trainer.devices=1` now for distributed checkpoints. If the model cannot fit into one GPU, use the CPU option.
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8199/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8199/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8198 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8198/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8198/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8198/events | https://github.com/NVIDIA/NeMo/pull/8198 | 2,088,820,744 | PR_kwDOC_bI7s5kdBPl | 8,198 | Add include_text parameter to SFT dataloaders | {
"login": "Kipok",
"id": 2354422,
"node_id": "MDQ6VXNlcjIzNTQ0MjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2354422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kipok",
"html_url": "https://github.com/Kipok",
"followers_url": "https://api.github.com/users/Kipok/followers",
"following_url": "https://api.github.com/users/Kipok/following{/other_user}",
"gists_url": "https://api.github.com/users/Kipok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kipok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kipok/subscriptions",
"organizations_url": "https://api.github.com/users/Kipok/orgs",
"repos_url": "https://api.github.com/users/Kipok/repos",
"events_url": "https://api.github.com/users/Kipok/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kipok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins"
] | 2024-01-18T18:15:59 | 2024-01-21T22:02:23 | 2024-01-21T22:02:23 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8198",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8198",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8198.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8198.patch",
"merged_at": "2024-01-21T22:02:23"
} | # What does this PR do ?
Adding a new parameter to include original text in the dictionary returned from a dataloader. This is needed for a cleaner support of metrics in NeMo-Aligner.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "Kipok",
"id": 2354422,
"node_id": "MDQ6VXNlcjIzNTQ0MjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2354422?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kipok",
"html_url": "https://github.com/Kipok",
"followers_url": "https://api.github.com/users/Kipok/followers",
"following_url": "https://api.github.com/users/Kipok/following{/other_user}",
"gists_url": "https://api.github.com/users/Kipok/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Kipok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kipok/subscriptions",
"organizations_url": "https://api.github.com/users/Kipok/orgs",
"repos_url": "https://api.github.com/users/Kipok/repos",
"events_url": "https://api.github.com/users/Kipok/events{/privacy}",
"received_events_url": "https://api.github.com/users/Kipok/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8198/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8198/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8197 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8197/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8197/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8197/events | https://github.com/NVIDIA/NeMo/pull/8197 | 2,088,641,527 | PR_kwDOC_bI7s5kcaGr | 8,197 | Add Lhotse support for `offset` key in NeMo manifests | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"I think so, I’ll keep actively looking for anything I might have missed though. ",
"jenkins"
] | 2024-01-18T16:25:46 | 2024-01-19T18:59:03 | 2024-01-19T18:59:02 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8197",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8197",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8197.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8197.patch",
"merged_at": "2024-01-19T18:59:02"
} | # What does this PR do ?
Add Lhotse support for `offset` key in NeMo manifests
**Collection**: All speech collections
# Changelog
- Add Lhotse support for `offset` key in NeMo manifests
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8197/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8197/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8196 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8196/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8196/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8196/events | https://github.com/NVIDIA/NeMo/pull/8196 | 2,088,509,208 | PR_kwDOC_bI7s5kb9AH | 8,196 | [do-not-merge] Run ASR test with gdb | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins"
] | 2024-01-18T15:18:18 | 2024-01-27T01:59:15 | 2024-01-19T19:02:32 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8196",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8196",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8196.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8196.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8196/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8196/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8195 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8195/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8195/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8195/events | https://github.com/NVIDIA/NeMo/pull/8195 | 2,087,641,500 | PR_kwDOC_bI7s5kY_B7 | 8,195 | Fixed the tp overlap switch | {
"login": "sanandaraj5597",
"id": 55270934,
"node_id": "MDQ6VXNlcjU1MjcwOTM0",
"avatar_url": "https://avatars.githubusercontent.com/u/55270934?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sanandaraj5597",
"html_url": "https://github.com/sanandaraj5597",
"followers_url": "https://api.github.com/users/sanandaraj5597/followers",
"following_url": "https://api.github.com/users/sanandaraj5597/following{/other_user}",
"gists_url": "https://api.github.com/users/sanandaraj5597/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sanandaraj5597/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sanandaraj5597/subscriptions",
"organizations_url": "https://api.github.com/users/sanandaraj5597/orgs",
"repos_url": "https://api.github.com/users/sanandaraj5597/repos",
"events_url": "https://api.github.com/users/sanandaraj5597/events{/privacy}",
"received_events_url": "https://api.github.com/users/sanandaraj5597/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins"
] | 2024-01-18T06:56:31 | 2024-01-23T22:08:30 | 2024-01-23T22:08:30 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8195",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8195",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8195.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8195.patch",
"merged_at": "2024-01-23T22:08:30"
} | # What does this PR do ?
Added a switch to pass tp_overlap to MCORE transformer config. | {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8195/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8195/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8194 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8194/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8194/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8194/events | https://github.com/NVIDIA/NeMo/issues/8194 | 2,087,390,227 | I_kwDOC_bI7s58awwT | 8,194 | ERRORs in repetition_penalty | {
"login": "guozhen1997",
"id": 37097045,
"node_id": "MDQ6VXNlcjM3MDk3MDQ1",
"avatar_url": "https://avatars.githubusercontent.com/u/37097045?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/guozhen1997",
"html_url": "https://github.com/guozhen1997",
"followers_url": "https://api.github.com/users/guozhen1997/followers",
"following_url": "https://api.github.com/users/guozhen1997/following{/other_user}",
"gists_url": "https://api.github.com/users/guozhen1997/gists{/gist_id}",
"starred_url": "https://api.github.com/users/guozhen1997/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/guozhen1997/subscriptions",
"organizations_url": "https://api.github.com/users/guozhen1997/orgs",
"repos_url": "https://api.github.com/users/guozhen1997/repos",
"events_url": "https://api.github.com/users/guozhen1997/events{/privacy}",
"received_events_url": "https://api.github.com/users/guozhen1997/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "yidong72",
"id": 43824965,
"node_id": "MDQ6VXNlcjQzODI0OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/43824965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yidong72",
"html_url": "https://github.com/yidong72",
"followers_url": "https://api.github.com/users/yidong72/followers",
"following_url": "https://api.github.com/users/yidong72/following{/other_user}",
"gists_url": "https://api.github.com/users/yidong72/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yidong72/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yidong72/subscriptions",
"organizations_url": "https://api.github.com/users/yidong72/orgs",
"repos_url": "https://api.github.com/users/yidong72/repos",
"events_url": "https://api.github.com/users/yidong72/events{/privacy}",
"received_events_url": "https://api.github.com/users/yidong72/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Yes. You are right. \r\n```python\r\nlogits_update[logits_update >= 0] = logits_update / repetition_penalty\r\nlogits_update[logits_update < 0] = logits_update * repetition_penalty\r\n```\r\nwe can fix it by treating negative and positive logits differently.\r\n\r\nRegarding to `compute_logprob=False`, you are right. the all_generated_indices will not be updated and the repetition penalty is not working. This is a bug. `all_generated_indices` calculation should be pulled out of the `compute_logprob` condition. \r\n\r\ndo you mind create a PR for it?",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-18T03:08:47 | 2024-03-10T01:44:55 | 2024-03-10T01:44:55 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **There's a computation error in repetition_penalty() function when there's negative numbers in logits**
- Version: nemo 1.22.0
- Path: NeMo/nemo/collections/nlp/modules/common/text_generation_utils.py
- Source code:
```
def repetition_penalty(logits, repetition_penalty, used_tokens):
""" Implement the repetition penalty, check paper
https://arxiv.org/pdf/1909.05858.pdf
"""
if used_tokens is not None and repetition_penalty != 1.0:
logits_update = torch.gather(logits, 1, used_tokens)
logits = torch.scatter(logits, 1, used_tokens, logits_update / repetition_penalty)
return logits
```
**There's also a question about the repetition penalty. When setting compute_logprob=False, the all_generated_indices will not be updated and the repetition penalty seems not working, is this correct?** | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8194/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8194/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8193 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8193/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8193/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8193/events | https://github.com/NVIDIA/NeMo/issues/8193 | 2,087,265,943 | I_kwDOC_bI7s58aSaX | 8,193 | Llama example scripts | {
"login": "Teng-xu",
"id": 67929972,
"node_id": "MDQ6VXNlcjY3OTI5OTcy",
"avatar_url": "https://avatars.githubusercontent.com/u/67929972?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Teng-xu",
"html_url": "https://github.com/Teng-xu",
"followers_url": "https://api.github.com/users/Teng-xu/followers",
"following_url": "https://api.github.com/users/Teng-xu/following{/other_user}",
"gists_url": "https://api.github.com/users/Teng-xu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Teng-xu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Teng-xu/subscriptions",
"organizations_url": "https://api.github.com/users/Teng-xu/orgs",
"repos_url": "https://api.github.com/users/Teng-xu/repos",
"events_url": "https://api.github.com/users/Teng-xu/events{/privacy}",
"received_events_url": "https://api.github.com/users/Teng-xu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"This is the full stack trace, and the issue is `Exception: The provided qkv memory layout is not supported!`\r\n```0: Traceback (most recent call last):\r\n0: File \"/fsx/users/xuteng/NeMo/examples/nlp/language_modeling/megatron_llama_pretraining.py\", line 40, in main\r\n0: trainer.fit(model)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py\", line 532, in fit\r\n0: call._call_and_handle_interrupt(\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py\", line 42, in _call_and_handle_interrupt\r\n0: return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/strategies/launchers/subprocess_script.py\", line 93, in launch\r\n0: return function(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py\", line 571, in _fit_impl\r\n0: self._run(model, ckpt_path=ckpt_path)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py\", line 980, in _run\r\n0: results = self._run_stage()\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py\", line 1023, in _run_stage\r\n0: self.fit_loop.run()\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/loops/fit_loop.py\", line 202, in run\r\n0: self.advance()\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/loops/fit_loop.py\", line 355, in advance\r\n0: self.epoch_loop.run(self._data_fetcher)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/loops/training_epoch_loop.py\", line 133, in run\r\n0: self.advance(data_fetcher)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/loops/training_epoch_loop.py\", line 219, in advance\r\n0: batch_output = self.automatic_optimization.run(trainer.optimizers[0], kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/loops/optimization/automatic.py\", line 188, in run\r\n0: self._optimizer_step(kwargs.get(\"batch_idx\", 0), closure)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/loops/optimization/automatic.py\", line 266, in _optimizer_step\r\n0: call._call_lightning_module_hook(\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py\", line 145, in _call_lightning_module_hook\r\n0: output = fn(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/core/module.py\", line 1270, in optimizer_step\r\n0: optimizer.step(closure=optimizer_closure)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/core/optimizer.py\", line 161, in step\r\n0: step_output = self._strategy.optimizer_step(self._optimizer, closure, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/strategies/ddp.py\", line 257, in optimizer_step\r\n0: optimizer_output = super().optimizer_step(optimizer, closure, model, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/strategies/strategy.py\", line 231, in optimizer_step\r\n0: return self.precision_plugin.optimizer_step(optimizer, model=model, closure=closure, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/plugins/precision/amp.py\", line 73, in optimizer_step\r\n0: return super().optimizer_step(optimizer, model=model, closure=closure, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/plugins/precision/precision_plugin.py\", line 116, in optimizer_step\r\n0: return optimizer.step(closure=closure, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/torch/optim/lr_scheduler.py\", line 69, in wrapper\r\n0: return wrapped(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/torch/optim/optimizer.py\", line 280, in wrapper\r\n0: out = func(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/apex/contrib/optimizers/distributed_fused_adam.py\", line 2071, in step\r\n0: loss = closure()\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/plugins/precision/precision_plugin.py\", line 103, in _wrap_closure\r\n0: closure_result = closure()\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/loops/optimization/automatic.py\", line 142, in __call__\r\n0: self._result = self.closure(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/torch/utils/_contextlib.py\", line 115, in decorate_context\r\n0: return func(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/loops/optimization/automatic.py\", line 128, in closure\r\n0: step_output = self._step_fn()\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/loops/optimization/automatic.py\", line 315, in _training_step\r\n0: training_step_output = call._call_strategy_hook(trainer, \"training_step\", *kwargs.values())\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py\", line 293, in _call_strategy_hook\r\n0: output = fn(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/strategies/ddp.py\", line 330, in training_step\r\n0: return self.model(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1504, in _call_impl\r\n0: return forward_call(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/pytorch_lightning/overrides/base.py\", line 90, in forward\r\n0: output = self._forward_module.training_step(*inputs, **kwargs)\r\n0: File \"/fsx/users/xuteng/NeMo/nemo/utils/model_utils.py\", line 381, in wrap_training_step\r\n0: output_dict = wrapped(*args, **kwargs)\r\n0: File \"/fsx/users/xuteng/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py\", line 607, in training_step\r\n0: loss_mean = self.fwd_bwd_step(dataloader_iter, batch_idx, False)\r\n0: File \"/fsx/users/xuteng/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py\", line 509, in fwd_bwd_step\r\n0: losses_reduced_per_micro_batch = fwd_bwd_function(\r\n0: File \"/opt/conda/lib/python3.10/site-packages/megatron/core/pipeline_parallel/schedules.py\", line 327, in forward_backward_no_pipelining\r\n0: output_tensor = forward_step(\r\n0: File \"/opt/conda/lib/python3.10/site-packages/megatron/core/pipeline_parallel/schedules.py\", line 183, in forward_step\r\n0: output_tensor, loss_func = forward_step_func(data_iterator, model)\r\n0: File \"/fsx/users/xuteng/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py\", line 884, in fwd_output_and_loss_func\r\n0: output_tensor = model(**forward_args)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1504, in _call_impl\r\n0: return forward_call(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/megatron/core/transformer/module.py\", line 137, in forward\r\n0: outputs = self.module(*inputs, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1504, in _call_impl\r\n0: return forward_call(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/megatron/core/models/gpt/gpt_model.py\", line 166, in forward\r\n0: hidden_states = self.decoder(\r\n0: File \"/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1504, in _call_impl\r\n0: return forward_call(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/megatron/core/transformer/transformer_block.py\", line 302, in forward\r\n0: hidden_states = self._checkpointed_forward(\r\n0: File \"/opt/conda/lib/python3.10/site-packages/megatron/core/transformer/transformer_block.py\", line 204, in _checkpointed_forward\r\n0: hidden_states, context = tensor_parallel.checkpoint(\r\n0: File \"/opt/conda/lib/python3.10/site-packages/megatron/core/tensor_parallel/random.py\", line 272, in checkpoint\r\n0: return CheckpointFunction.apply(function, distribute_saved_activations, *args)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/torch/autograd/function.py\", line 506, in apply\r\n0: return super().apply(*args, **kwargs) # type: ignore[misc]\r\n0: File \"/opt/conda/lib/python3.10/site-packages/megatron/core/tensor_parallel/random.py\", line 211, in forward\r\n0: outputs = run_function(*args)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/megatron/core/transformer/transformer_block.py\", line 168, in custom_forward\r\n0: hidden_states, context = layer(\r\n0: File \"/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1504, in _call_impl\r\n0: return forward_call(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/megatron/core/transformer/transformer_layer.py\", line 153, in forward\r\n0: attention_output_with_bias = self.self_attention(\r\n0: File \"/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1504, in _call_impl\r\n0: return forward_call(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/megatron/core/transformer/attention.py\", line 263, in forward\r\n0: core_attn_out = self.core_attention(\r\n0: File \"/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py\", line 1504, in _call_impl\r\n0: return forward_call(*args, **kwargs)\r\n0: File \"/opt/conda/lib/python3.10/site-packages/megatron/core/transformer/custom_layers/transformer_engine.py\", line 427, in forward\r\n0: return super().forward(\r\n0: File \"/opt/conda/lib/python3.10/site-packages/transformer_engine/pytorch/attention.py\", line 2085, in forward\r\n0: qkv_layout = _get_qkv_layout(query_layer, key_layer, value_layer,\r\n0: File \"/opt/conda/lib/python3.10/site-packages/transformer_engine/pytorch/attention.py\", line 1195, in _get_qkv_layout\r\n0: raise Exception(\"The provided qkv memory layout is not supported!\")\r\n0: Exception: The provided qkv memory layout is not supported!```",
"have you tried training recipes here? https://github.com/NVIDIA/NeMo-Megatron-Launcher/tree/master/launcher_scripts/conf/training/llama",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-18T00:51:40 | 2024-03-04T01:46:47 | 2024-03-04T01:46:47 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | I was trying to configure a test for the Llama model using Megatron Nemo. While I discovered an example configuration file (https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/language_modeling/conf/megatron_llama_config.yaml), I couldn't locate any sample scripts specifically designed for launching training with Llama. In my attempt, I used the Llama config file along with "megatron_gpt_pretraining.py," but unfortunately, it didn't work. Could you provide guidance or share any example scripts tailored for Llama pretraining? | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8193/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8193/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8192 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8192/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8192/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8192/events | https://github.com/NVIDIA/NeMo/pull/8192 | 2,087,149,053 | PR_kwDOC_bI7s5kXTzO | 8,192 | [Draft] Refactor community model checkpoint converters | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"jenkins"
] | 2024-01-17T22:59:34 | 2024-02-01T17:47:06 | 2024-02-01T17:47:06 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8192",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8192",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8192.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8192.patch",
"merged_at": null
} | # What does this PR do ?
Move checkpoint converters to the same folder and update to use similar arguments
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8192/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8192/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8191 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8191/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8191/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8191/events | https://github.com/NVIDIA/NeMo/pull/8191 | 2,086,869,609 | PR_kwDOC_bI7s5kWWJ9 | 8,191 | Dgalvez/cuda graphs greedy rnnt inference squash | {
"login": "galv",
"id": 4767568,
"node_id": "MDQ6VXNlcjQ3Njc1Njg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4767568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/galv",
"html_url": "https://github.com/galv",
"followers_url": "https://api.github.com/users/galv/followers",
"following_url": "https://api.github.com/users/galv/following{/other_user}",
"gists_url": "https://api.github.com/users/galv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/galv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/galv/subscriptions",
"organizations_url": "https://api.github.com/users/galv/orgs",
"repos_url": "https://api.github.com/users/galv/repos",
"events_url": "https://api.github.com/users/galv/events{/privacy}",
"received_events_url": "https://api.github.com/users/galv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"@titu1994 for RNNT review. \r\n@galv instead of `go_very_fast` can you change to `enable_cuda_graphs=true` something like that? ",
"This PR is ready for review. @artbataev @titu1994 would you be willing?",
"I can review this tomorrow @artbataev could you review it too ?",
"Cool, I will review the PR today or tomorrow.\r\n\r\n@galv Please fix DCO (anyway, you will need to fix it for merging).",
"Jenkins ",
"jenkins",
"jenkins",
"jenkins",
"@artbataev Let me know if you think this is good to go.",
"@galv as I see, the issue can be fixed when passing appropriate device to cuda streams initializers and getters:\r\n```\r\ndef with_conditional_node(while_loop_kernel, while_loop_args, while_loop_conditional_handle, device):\r\n ...\r\n body_stream = torch.cuda.Stream(device=device)\r\n previous_stream = torch.cuda.current_stream(device=device)\r\n\r\ndef _reinitialize(...):\r\n ...\r\n with torch.cuda.stream(torch.cuda.Stream(device=device)), torch.inference_mode(), torch.cuda.graph(self.graph):\r\n ... \r\n capture_status, _, graph, _, _ = cu_call(\r\n cudart.cudaStreamGetCaptureInfo(torch.cuda.current_stream(device=device).cuda_stream)\r\n )\r\n```",
"@artbataev thank you for the initial suggestion. It works when the decoder has not been run yet. However, it doesn't work if the decoder has already been run. You can see my failing test here: https://github.com/NVIDIA/NeMo/commit/36b32738edccfda31b480f96e5b86ce28a6850d8\r\n\r\nClearly something obscure is happening here. The commit message provides more details. I've spent a few hours trying to debug this so I need to stop for the day.",
"@galvI tried some changes, and it seems I can get it to work.\r\nBut I'm wondering why these changes are required and why everything works when creating a graph for the first time on any device. There may be some bugs in PyTorch.\r\n\r\n1. Pass stream explicitly to `torch.cuda.graph`. After this change, I'm able to run the test, but the final comparison of the results fails (the results seem to be incorrect for the second run)\r\n2. Pass the device explicitly to all calls `torch.cuda.current_stream`. After this change, the test is passed.\r\n\r\n```python\r\n# Always create a new stream, because the per-thread default stream disallows stream capture to a graph.\r\nstream_for_graph = torch.cuda.Stream(self.device)\r\nwith torch.cuda.stream(stream_for_graph), torch.inference_mode(), torch.cuda.graph(self.graph, stream=stream_for_graph):\r\n ... # capture graph\r\n # pass device explicitly\r\n capture_status, _, graph, _, _ = cu_call(\r\n cudart.cudaStreamGetCaptureInfo(torch.cuda.current_stream(device=self.device).cuda_stream)\r\n )\r\n ...\r\n\r\[email protected]\r\ndef with_conditional_node(while_loop_kernel, while_loop_args, while_loop_conditional_handle, device):\r\n ...\r\n # pass device explicitly here and in other calls\r\n capture_status, _, graph, _, _ = cu_call(cudart.cudaStreamGetCaptureInfo(torch.cuda.current_stream(device=device).cuda_stream))\r\n ... \r\n``` \r\n\r\nYou can see the full commit here: https://github.com/artbataev/NeMo/commit/77fc36e199d5c804b447cef0c817340ef4e0334c\r\n",
"jenkins",
"jenkins",
"jenkins\r\n\r\nPrevious failure seems to be a spurious failure caused by git clone failing.\r\n\r\n@artbataev I incorporated your change after verifying it on a multi-GPU machine. Thank you again. I made one more commit https://github.com/NVIDIA/NeMo/pull/8191/commits/fb2bd7aeb6a99540b7ca1d2334e1502ad989b8a7 as well which makes this work with cuda-python version 12.4.0 and greater. It turns out that the bug fix in that version makes the phGraph_out variable not writable. So I must not use my workaround when cuda-python > 12.3.0. Things are well tested at this point.",
"@galv I manually restarted Jenkins, but it is still waiting for an executor",
"@galv please fix the test failing on Jenkins (the guard is needed)\r\n\r\n> FAILED tests/collections/asr/decoding/test_cuda_graph_rnnt_greedy_decoding.py::test_change_devices - ImportError: Found cuda-python 12.3.0rc4+8.gcb4e395, but at least version 12.3.0 is needed.",
"jenkins\r\n\r\nSorry for missing the guard in that test. Hopefully things go through now.",
"jenkins"
] | 2024-01-17T19:48:41 | 2024-02-26T16:35:35 | 2024-02-26T16:35:34 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8191",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8191",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8191.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8191.patch",
"merged_at": "2024-02-26T16:35:34"
} | # What does this PR do ?
Speeds up RNN-T greedy decoding greatly by eliminating the 90% of the time that the GPU is idle, waiting on the CPU, via cuda graphs with conditional nodes.
Here are some results for transcribing librispeech test other, a 5.4 hour dataset, on an A100, with bfloat16, at batch size 16:
<img width="504" alt="image" src="https://github.com/NVIDIA/NeMo/assets/4767568/3e1dad23-e4a6-43b0-992f-2e4635dcc25b">
You can see that we get a 3.125x speed up with a 600 million parameter model, and a 2.65x speedup with a 1.1 billion parameter model.
This benchmark comes from running the following. Note that I exclude the time required to create the cuda graph from the timing measurement. This fits an inference use case where that is a one time task.
```
for model_name in stt_en_fastconformer_transducer_xlarge nvidia/parakeet-rnnt-1.1b; do
for use_cuda_graph_decoder in false true; do
for amp in true; do
for batch_size in 16; do
echo "GALVEZ: ${model_name} fast:${use_cuda_graph_decoder}"
$(which python) examples/asr/speech_to_text_eval.py pretrained_name=$model_name dataset_manifest=/home/dgalvez/scratch/data/test_other.json batch_size=$batch_size output_filename=test_other_decoded.js\
onl amp=$amp amp_dtype=bfloat16 rnnt_decoding.greedy.use_cuda_graph_decoder=$use_cuda_graph_decoder use_cer=false num_workers=1
done
done
done
done
```
This is a squashing of #7976 . I wanted to squash that, but unfortunately I reference a few commits in various bugs I filed, and didn't want the links to break.
**Collection**: ASR. Adds some utils for cuda-python to common.
# Changelog
- Adds a new class `RNNTGreedyDecodeCudaGraph`, which uses cuda graphs with conditional nodes to remove the CPU overhead.
# Usage
* You can potentially add a usage example below
```bash
python examples/asr/speech_to_text_eval.py \
pretrained_name=stt_en_fastconformer_transducer_xlarge \
dataset_manifest=/home/dgalvez/scratch/data/test_other.json \
batch_size=16 \
output_filename=test_other_decoded.jsonl \
amp=true amp_dtype=bfloat16 \
rnnt_decoding.greedy.loop_labels=false \
rnnt_decoding.greedy.use_cuda_graph_decoder=true \
use_cer=false num_workers=1
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [x] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to #7976
| {
"login": "galv",
"id": 4767568,
"node_id": "MDQ6VXNlcjQ3Njc1Njg=",
"avatar_url": "https://avatars.githubusercontent.com/u/4767568?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/galv",
"html_url": "https://github.com/galv",
"followers_url": "https://api.github.com/users/galv/followers",
"following_url": "https://api.github.com/users/galv/following{/other_user}",
"gists_url": "https://api.github.com/users/galv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/galv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/galv/subscriptions",
"organizations_url": "https://api.github.com/users/galv/orgs",
"repos_url": "https://api.github.com/users/galv/repos",
"events_url": "https://api.github.com/users/galv/events{/privacy}",
"received_events_url": "https://api.github.com/users/galv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8191/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8191/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8189 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8189/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8189/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8189/events | https://github.com/NVIDIA/NeMo/pull/8189 | 2,086,627,523 | PR_kwDOC_bI7s5kVhMb | 8,189 | Gradient accumulation hack to support EP | {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-01-17T17:15:39 | 2024-01-27T03:18:13 | 2024-01-27T03:18:13 | MEMBER | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | true | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8189",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8189",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8189.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8189.patch",
"merged_at": null
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "akoumpa",
"id": 153118171,
"node_id": "U_kgDOCSBl2w",
"avatar_url": "https://avatars.githubusercontent.com/u/153118171?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akoumpa",
"html_url": "https://github.com/akoumpa",
"followers_url": "https://api.github.com/users/akoumpa/followers",
"following_url": "https://api.github.com/users/akoumpa/following{/other_user}",
"gists_url": "https://api.github.com/users/akoumpa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/akoumpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akoumpa/subscriptions",
"organizations_url": "https://api.github.com/users/akoumpa/orgs",
"repos_url": "https://api.github.com/users/akoumpa/repos",
"events_url": "https://api.github.com/users/akoumpa/events{/privacy}",
"received_events_url": "https://api.github.com/users/akoumpa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8189/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8189/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8188 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8188/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8188/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8188/events | https://github.com/NVIDIA/NeMo/pull/8188 | 2,086,620,905 | PR_kwDOC_bI7s5kVfwT | 8,188 | Multimodal required NLP base model changes | {
"login": "yaoyu-33",
"id": 54727607,
"node_id": "MDQ6VXNlcjU0NzI3NjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/54727607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yaoyu-33",
"html_url": "https://github.com/yaoyu-33",
"followers_url": "https://api.github.com/users/yaoyu-33/followers",
"following_url": "https://api.github.com/users/yaoyu-33/following{/other_user}",
"gists_url": "https://api.github.com/users/yaoyu-33/gists{/gist_id}",
"starred_url": "https://api.github.com/users/yaoyu-33/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yaoyu-33/subscriptions",
"organizations_url": "https://api.github.com/users/yaoyu-33/orgs",
"repos_url": "https://api.github.com/users/yaoyu-33/repos",
"events_url": "https://api.github.com/users/yaoyu-33/events{/privacy}",
"received_events_url": "https://api.github.com/users/yaoyu-33/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins"
] | 2024-01-17T17:11:24 | 2024-01-19T16:11:02 | 2024-01-19T16:11:01 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8188",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8188",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8188.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8188.patch",
"merged_at": "2024-01-19T16:11:01"
} | # What does this PR do ?
Some of the base codes need to be modified in order for multimodal optimization to work.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8188/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8188/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8187 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8187/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8187/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8187/events | https://github.com/NVIDIA/NeMo/pull/8187 | 2,086,496,361 | PR_kwDOC_bI7s5kVEoA | 8,187 | add sbert | {
"login": "JRD971000",
"id": 71892896,
"node_id": "MDQ6VXNlcjcxODkyODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/71892896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JRD971000",
"html_url": "https://github.com/JRD971000",
"followers_url": "https://api.github.com/users/JRD971000/followers",
"following_url": "https://api.github.com/users/JRD971000/following{/other_user}",
"gists_url": "https://api.github.com/users/JRD971000/gists{/gist_id}",
"starred_url": "https://api.github.com/users/JRD971000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JRD971000/subscriptions",
"organizations_url": "https://api.github.com/users/JRD971000/orgs",
"repos_url": "https://api.github.com/users/JRD971000/repos",
"events_url": "https://api.github.com/users/JRD971000/events{/privacy}",
"received_events_url": "https://api.github.com/users/JRD971000/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-01-17T16:01:19 | 2024-01-31T20:04:17 | 2024-01-31T20:04:17 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8187",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8187",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8187.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8187.patch",
"merged_at": null
} | # What does this PR do ?
Adding Megatron Sentence Bert
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8187/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8187/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8185 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8185/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8185/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8185/events | https://github.com/NVIDIA/NeMo/issues/8185 | 2,086,151,328 | I_kwDOC_bI7s58WCSg | 8,185 | Fast Conformer training from scratch doesn't converge (WER = 1 ) , but it converges on pretrained model | {
"login": "Dreahim",
"id": 153502163,
"node_id": "U_kgDOCSZB0w",
"avatar_url": "https://avatars.githubusercontent.com/u/153502163?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Dreahim",
"html_url": "https://github.com/Dreahim",
"followers_url": "https://api.github.com/users/Dreahim/followers",
"following_url": "https://api.github.com/users/Dreahim/following{/other_user}",
"gists_url": "https://api.github.com/users/Dreahim/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Dreahim/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Dreahim/subscriptions",
"organizations_url": "https://api.github.com/users/Dreahim/orgs",
"repos_url": "https://api.github.com/users/Dreahim/repos",
"events_url": "https://api.github.com/users/Dreahim/events{/privacy}",
"received_events_url": "https://api.github.com/users/Dreahim/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"What is the amount of data you are pretraining with ? We pretrain these asr models with 25,000 hours of speech. Small amounts of data for pretraining will mean you need to experiment a lot with hyper parameters to get it to converge. ",
"I am training with 150 hours of data, I trained it about 15 epochs ,\nBut WER is still 1 for both training and validation data, even the loss is still constant, the model does not learn even a little.",
"I observe similar effect, see this [discussion](https://github.com/NVIDIA/NeMo/discussions/7797). Still no clear answer why fastconformer doesn't converge from scratch. ",
"150 hours is enough to finetune but quite low to train from scratch. Still, it should train at least even if it gets poor wer. \r\n\r\nCan you print your entire model.optim config, plus mention what dropout and spec augment are you using ?",
"What is your lr, warmup steps and precision and also how many steps you have trained it for?",
"This is my model optim config\r\n\r\n optim:\r\n name: adamw\r\n lr: 1e-3\r\n # optimizer arguments\r\n betas: [0.9, 0.98]\r\n # less necessity for weight_decay as we already have large augmentations with SpecAug\r\n # you may need weight_decay for large models, stable AMP training, small datasets, or when lower augmentations are used\r\n # weight decay of 0.0 with lr of 2.0 also works fine\r\n weight_decay: 1e-3\r\n\r\n # scheduler setup\r\n sched:\r\n name: CosineAnnealing\r\n # scheduler config override\r\n warmup_steps: 15000\r\n warmup_ratio: null\r\n min_lr: 1e-4\r\n\r\ndropout is 0.1\r\nspec_augment:\r\n _target_: nemo.collections.asr.modules.SpectrogramAugmentation\r\n freq_masks: 2 # set to zero to disable it\r\n # you may use lower time_masks for smaller models to have a faster convergence\r\n time_masks: 10 # set to zero to disable it\r\n freq_width: 27\r\n time_width: 0.05\r\n\r\nI use the default configs for fast conformer config available here [](https://github.com/NVIDIA/NeMo/blob/main/examples/asr/conf/fastconformer/fast-conformer_ctc_bpe.yaml ), and I tried to use medium model but I get the same results",
"> I observe similar effect, see this [discussion](https://github.com/NVIDIA/NeMo/discussions/7797). Still no clear answer why fastconformer doesn't converge from scratch.\r\n\r\nThank you for this discussion, I checked it\r\nI tried to use conformer, but I get similar results\r\nplease, tell me what was your dataset hours ? and how many epochs you trained to start getting results and WER started to decraese ?",
"> > I observe similar effect, see this [discussion](https://github.com/NVIDIA/NeMo/discussions/7797). Still no clear answer why fastconformer doesn't converge from scratch.\r\n> \r\n> Thank you for this discussion, I checked it I tried to use conformer, but I get similar results please, tell me what was your dataset hours ? and how many epochs you trained to start getting results and WER started to decraese ?\r\n\r\n@Dreahim , I experimented with a micro dataset of 900 examples (less than 2 hours), and my validation data had intersection with train. Batch size was 16 and no more than 400 epochs. Convergence - if it happens - begins before 50 epochs, sometimes earlier.",
"Is it a hybrid or rnnt model? How many steps you have trained for already?",
"> Is it a hybrid or rnnt model? How many steps you have trained for already?\r\n\r\nIt is fast conformer ctc, I trained for 2-3 epechs, and I stop it because there is no any convergion",
"I moved to conformer ctc, and there is no any convertion\\\r\nI tried a lot but I don't get any results , what is the problem ??!!\r\n\r\nthese are my configrations\r\n\r\n\r\n```\r\nname: \"Conformer-CTC-BPE\"\r\n\r\nmodel:\r\n sample_rate: 16000\r\n log_prediction: true # enables logging sample predictions in the output during training\r\n ctc_reduction: 'mean_batch'\r\n skip_nan_grad: false\r\n\r\n train_ds:\r\n manifest_filepath: ???\r\n sample_rate: ${model.sample_rate}\r\n batch_size: 4 # you may increase batch_size if your memory allows\r\n shuffle: true\r\n num_workers: 8\r\n pin_memory: true\r\n max_duration: 50.0 # it is set for LibriSpeech, you may need to update it for your dataset\r\n min_duration: 0.1\r\n # tarred datasets\r\n is_tarred: false\r\n tarred_audio_filepaths: null\r\n shuffle_n: 2048\r\n # bucketing params\r\n bucketing_strategy: \"synced_randomized\"\r\n bucketing_batch_size: null\r\n\r\n validation_ds:\r\n manifest_filepath: ???\r\n sample_rate: ${model.sample_rate}\r\n batch_size: 4 # you may increase batch_size if your memory allows\r\n shuffle: false\r\n use_start_end_token: false\r\n num_workers: 8\r\n pin_memory: true\r\n\r\n test_ds:\r\n manifest_filepath: null\r\n sample_rate: ${model.sample_rate}\r\n batch_size: 16 # you may increase batch_size if your memory allows\r\n shuffle: false\r\n use_start_end_token: false\r\n num_workers: 8\r\n pin_memory: true\r\n\r\n # recommend to SPE Unigram tokenizer with small vocab size of 128 or 256 when using 4x sub-sampling\r\n # you may find more detail on how to train a tokenizer at: /scripts/tokenizers/process_asr_text_tokenizer.py\r\n tokenizer:\r\n dir: ??? # path to directory which contains either tokenizer.model (bpe) or vocab.txt (wpe)\r\n type: bpe # Can be either bpe (SentencePiece tokenizer) or wpe (WordPiece tokenizer)\r\n\r\n preprocessor:\r\n _target_: nemo.collections.asr.modules.AudioToMelSpectrogramPreprocessor\r\n sample_rate: ${model.sample_rate}\r\n normalize: \"per_feature\"\r\n window_size: 0.025\r\n window_stride: 0.01\r\n window: \"hann\"\r\n features: 80\r\n n_fft: 512\r\n log: true\r\n frame_splicing: 1\r\n dither: 0.00001\r\n pad_to: 0\r\n pad_value: 0.0\r\n\r\n spec_augment:\r\n _target_: nemo.collections.asr.modules.SpectrogramAugmentation\r\n freq_masks: 2 # set to zero to disable it\r\n # you may use lower time_masks for smaller models to have a faster convergence\r\n time_masks: 5 # set to zero to disable it\r\n freq_width: 27\r\n time_width: 0.05\r\n\r\n encoder:\r\n _target_: nemo.collections.asr.modules.ConformerEncoder\r\n feat_in: ${model.preprocessor.features}\r\n feat_out: -1 # you may set it if you need different output size other than the default d_model\r\n n_layers: 18\r\n d_model: 256\r\n\r\n # Sub-sampling params\r\n subsampling: striding # vggnet, striding, stacking or stacking_norm, dw_striding\r\n subsampling_factor: 4 # must be power of 2 for striding and vggnet\r\n subsampling_conv_channels: -1 # -1 sets it to d_model\r\n causal_downsampling: false\r\n\r\n # Feed forward module's params\r\n ff_expansion_factor: 4\r\n\r\n # Multi-headed Attention Module's params\r\n self_attention_model: rel_pos # rel_pos or abs_pos\r\n n_heads: 4 # may need to be lower for smaller d_models\r\n # [left, right] specifies the number of steps to be seen from left and right of each step in self-attention\r\n att_context_size: [-1, -1] # -1 means unlimited context\r\n att_context_style: regular # regular or chunked_limited\r\n xscaling: true # scales up the input embeddings by sqrt(d_model)\r\n untie_biases: true # unties the biases of the TransformerXL layers\r\n pos_emb_max_len: 5000\r\n\r\n # Convolution module's params\r\n conv_kernel_size: 31\r\n conv_norm_type: 'batch_norm' # batch_norm or layer_norm or groupnormN (N specifies the number of groups)\r\n # conv_context_size can be\"causal\" or a list of two integers while conv_context_size[0]+conv_context_size[1]+1==conv_kernel_size\r\n # null means [(kernel_size-1)//2, (kernel_size-1)//2], and 'causal' means [(kernel_size-1), 0]\r\n conv_context_size: null\r\n\r\n ### regularization\r\n dropout: 0.1 # The dropout used in most of the Conformer Modules\r\n dropout_pre_encoder: 0.1 # The dropout used before the encoder\r\n dropout_emb: 0.0 # The dropout used for embeddings\r\n dropout_att: 0.1 # The dropout for multi-headed attention modules\r\n\r\n # set to non-zero to enable stochastic depth\r\n stochastic_depth_drop_prob: 0.0\r\n stochastic_depth_mode: linear # linear or uniform\r\n stochastic_depth_start_layer: 1\r\n\r\n decoder:\r\n _target_: nemo.collections.asr.modules.ConvASRDecoder\r\n feat_in: null\r\n num_classes: -1\r\n vocabulary: []\r\n\r\n # config for InterCTC loss: https://arxiv.org/abs/2102.03216\r\n # specify loss weights and which layers to use for InterCTC\r\n # e.g., to reproduce the paper results, set loss_weights: [0.3]\r\n # and apply_at_layers: [8] (assuming 18 layers). Note that final\r\n # layer loss coefficient is automatically adjusted (to 0.7 in above example)\r\n interctc:\r\n loss_weights: [0.3]\r\n apply_at_layers: [8]\r\n\r\n optim:\r\n name: adamw\r\n lr: 5.0\r\n # optimizer arguments\r\n betas: [0.9, 0.98]\r\n # less necessity for weight_decay as we already have large augmentations with SpecAug\r\n # you may need weight_decay for large models, stable AMP training, small datasets, or when lower augmentations are used\r\n # weight decay of 0.0 with lr of 2.0 also works fine\r\n weight_decay: 1e-3\r\n\r\n # scheduler setup\r\n sched:\r\n name: NoamAnnealing\r\n d_model: ${model.encoder.d_model}\r\n # scheduler config override\r\n warmup_steps: 10000\r\n warmup_ratio: null\r\n min_lr: 1e-6\r\n\r\ntrainer:\r\n devices: -1 # number of GPUs, -1 would use all available GPUs\r\n num_nodes: 1\r\n max_epochs: 1000\r\n max_steps: -1 # computed at runtime if not set\r\n val_check_interval: 1.0 # Set to 0.25 to check 4 times per epoch, or an int for number of iterations\r\n accelerator: auto\r\n strategy: ddp\r\n accumulate_grad_batches: 1\r\n gradient_clip_val: 0.0\r\n precision: 32 # 16, 32, or bf16\r\n log_every_n_steps: 10 # Interval of logging.\r\n enable_progress_bar: True\r\n num_sanity_val_steps: 0 # number of steps to perform validation steps for sanity check the validation process before starting the training, setting to 0 disables it\r\n check_val_every_n_epoch: 1 # number of evaluations on validation every n epochs\r\n sync_batchnorm: true\r\n enable_checkpointing: False # Provided by exp_manager\r\n logger: false # Provided by exp_manager\r\n benchmark: false # needs to be false for models with variable-length speech input as it slows down training\r\n\r\nexp_manager:\r\n exp_dir: null\r\n name: ${name}\r\n create_tensorboard_logger: true\r\n create_checkpoint_callback: true\r\n checkpoint_callback_params:\r\n # in case of multiple validation sets, first one is used\r\n monitor: \"val_wer\"\r\n mode: \"min\"\r\n save_top_k: 5\r\n always_save_nemo: True # saves the checkpoints as nemo files instead of PTL checkpoints\r\n\r\n # you need to set these two to True to continue the training\r\n resume_if_exists: false\r\n resume_ignore_no_checkpoint: false\r\n\r\n # You may use this section to create a W&B logger\r\n create_wandb_logger: false\r\n wandb_logger_kwargs:\r\n name: null\r\n project: null\r\n```",
"Few things. Reduce spec augment time masks from 10 to 0 to see if model is learning at all. \r\n\r\nLr lower to 5e-4. \r\n\r\nHow many steps does it show per epoch ? Instead of setting warmup steps to 15000, set warmup ratio to 0.1 or so. \r\n\r\nYou might need multiple Epochs - what is your hardware configuration ? Ie how many gpus + how many nodes. You might have to use gradient accumulation to increase the effective batch size to 256 at least. \r\n\r\nTraining from scratch on smaller datasets is an effort in hyper parameters optimization. You will see that when we train on AN4 in the tutorials, we chose very specific optimization parameters in the ASR with Transducers tutorial. \r\n\r\nNeMo recommendation is to always always use fine-tuning instead of training from scratch unless it's for an academic paper. We have almost never seen a case that from scratch does better than fine-tuning from a model trained on thousands of hours of speech ",
"Epoch does not mean that much. How many steps you have trained? Have you passed the first 10k steps of warmup already? \n\nWhat is your global batch size? You should have at least 256 global batch in some cases to make sure ctc converges.\n\nHave you tried rnnt or hybrid models? \n\n Lowering lr as @titu1994 suggested is an option if you have smaller batch sizes. Other option is using grad accumulation.",
"> Few things. Reduce spec augment time masks from 10 to 0 to see if model is learning at all.\r\n> \r\n> Lr lower to 5e-4.\r\n> \r\n> How many steps does it show per epoch ? Instead of setting warmup steps to 15000, set warmup ratio to 0.1 or so.\r\n> \r\n> You might need multiple Epochs - what is your hardware configuration ? Ie how many gpus + how many nodes. You might have to use gradient accumulation to increase the effective batch size to 256 at least.\r\n> \r\n> Training from scratch on smaller datasets is an effort in hyper parameters optimization. You will see that when we train on AN4 in the tutorials, we chose very specific optimization parameters in the ASR with Transducers tutorial.\r\n> \r\n> NeMo recommendation is to always always use fine-tuning instead of training from scratch unless it's for an academic paper. We have almost never seen a case that from scratch does better than fine-tuning from a model trained on thousands of hours of speech\r\n\r\nOk, I am going to try theese configrations, my GPU is RTX 3070 Ti so I can't increase batch size up to 256, I use batch size 1 for training",
"> Epoch does not mean that much. How many steps you have trained? Have you passed the first 10k steps of warmup already?\r\n> \r\n> What is your global batch size? You should have at least 256 global batch in some cases to make sure ctc converges.\r\n> \r\n> Have you tried rnnt or hybrid models?\r\n> \r\n> Lowering lr as @titu1994 suggested is an option if you have smaller batch sizes. Other option is using grad accumulation.\r\n\r\nYes, I trained many times, one time I reached to 700k steps, and no results\r\nmy batch size is 1 or 2 because my GPU is 2070 TI, I can't raise more than this",
"I really don't think you can train a model to convergence from scratch on batch size 1. Fine-tuning is still possible, but not training from scratch.",
"Your only option is to enable and use grad accumulation to make the batch larger but you need many days just to pass the warmup stage. You may reduce the warmup but not sure how much you can reduce it.",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-17T13:03:57 | 2024-02-29T01:43:51 | 2024-02-29T01:43:51 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello! I have a problem when I train ASR models from scratch on my arabic dataset
when I use pretrained fast-conformer model, It works well and converges

and these are predicted and refrence results

These are good results, reached 0.2 WER after about 10 epochs
but when I train the same model from scratch using config file on nemo github config files, It doesn't converges and these are results


I used command line and nemo notebooks, I used many ways for traning, but I always get the same results
I also tried to train the model from scratch using pretrained config file, but I have got the same results
What is the problem ? | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8185/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8185/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8184 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8184/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8184/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8184/events | https://github.com/NVIDIA/NeMo/pull/8184 | 2,085,442,023 | PR_kwDOC_bI7s5kRgQh | 8,184 | add knobs for rope/swiglu fusion | {
"login": "lhb8125",
"id": 16619280,
"node_id": "MDQ6VXNlcjE2NjE5Mjgw",
"avatar_url": "https://avatars.githubusercontent.com/u/16619280?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lhb8125",
"html_url": "https://github.com/lhb8125",
"followers_url": "https://api.github.com/users/lhb8125/followers",
"following_url": "https://api.github.com/users/lhb8125/following{/other_user}",
"gists_url": "https://api.github.com/users/lhb8125/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lhb8125/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lhb8125/subscriptions",
"organizations_url": "https://api.github.com/users/lhb8125/orgs",
"repos_url": "https://api.github.com/users/lhb8125/repos",
"events_url": "https://api.github.com/users/lhb8125/events{/privacy}",
"received_events_url": "https://api.github.com/users/lhb8125/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"Jenkins",
"jenkins"
] | 2024-01-17T05:51:20 | 2024-01-24T03:13:12 | 2024-01-24T03:13:12 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8184",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8184",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8184.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8184.patch",
"merged_at": "2024-01-24T03:13:11"
} | # What does this PR do ?
Add knob for rope fusion
Add knob for swiglu fusion
Change knob for bias_gelu fusion
The PR is related to the PR of MLM: https://gitlab-master.nvidia.com/ADLR/megatron-lm/-/merge_requests/984
**Collection**: [NLP]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
- set `model.apply_rope_fusion: true` to enable rope fusion
- set `model.bias_activation_fusion: true` to enable bias+activation fusion, which works for both gelu and swiglu type.
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ericharper",
"id": 11999610,
"node_id": "MDQ6VXNlcjExOTk5NjEw",
"avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ericharper",
"html_url": "https://github.com/ericharper",
"followers_url": "https://api.github.com/users/ericharper/followers",
"following_url": "https://api.github.com/users/ericharper/following{/other_user}",
"gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericharper/subscriptions",
"organizations_url": "https://api.github.com/users/ericharper/orgs",
"repos_url": "https://api.github.com/users/ericharper/repos",
"events_url": "https://api.github.com/users/ericharper/events{/privacy}",
"received_events_url": "https://api.github.com/users/ericharper/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8184/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8184/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8183 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8183/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8183/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8183/events | https://github.com/NVIDIA/NeMo/pull/8183 | 2,085,197,452 | PR_kwDOC_bI7s5kQszw | 8,183 | removed deprecated peft model | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins"
] | 2024-01-17T00:49:30 | 2024-01-17T19:33:38 | 2024-01-17T19:33:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8183",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8183",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8183.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8183.patch",
"merged_at": "2024-01-17T19:33:37"
} | # What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8183/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8183/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8182 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8182/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8182/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8182/events | https://github.com/NVIDIA/NeMo/pull/8182 | 2,085,076,017 | PR_kwDOC_bI7s5kQTJL | 8,182 | Avoid the attention mask materialization | {
"login": "stu1130",
"id": 6792331,
"node_id": "MDQ6VXNlcjY3OTIzMzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/6792331?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stu1130",
"html_url": "https://github.com/stu1130",
"followers_url": "https://api.github.com/users/stu1130/followers",
"following_url": "https://api.github.com/users/stu1130/following{/other_user}",
"gists_url": "https://api.github.com/users/stu1130/gists{/gist_id}",
"starred_url": "https://api.github.com/users/stu1130/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stu1130/subscriptions",
"organizations_url": "https://api.github.com/users/stu1130/orgs",
"repos_url": "https://api.github.com/users/stu1130/repos",
"events_url": "https://api.github.com/users/stu1130/events{/privacy}",
"received_events_url": "https://api.github.com/users/stu1130/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [] | 2024-01-16T22:31:39 | 2024-01-16T23:32:37 | 2024-01-16T23:32:37 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8182",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8182",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8182.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8182.patch",
"merged_at": null
} | # What does this PR do ?
The attention mask requires 1 * seq_len * seq_len * 4 bytes memory per GPTDataset. It will overwhelm CPU RAM memory when we have extremely long sequence. The PR avoids mask materialization when it's not needed.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "stu1130",
"id": 6792331,
"node_id": "MDQ6VXNlcjY3OTIzMzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/6792331?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stu1130",
"html_url": "https://github.com/stu1130",
"followers_url": "https://api.github.com/users/stu1130/followers",
"following_url": "https://api.github.com/users/stu1130/following{/other_user}",
"gists_url": "https://api.github.com/users/stu1130/gists{/gist_id}",
"starred_url": "https://api.github.com/users/stu1130/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stu1130/subscriptions",
"organizations_url": "https://api.github.com/users/stu1130/orgs",
"repos_url": "https://api.github.com/users/stu1130/repos",
"events_url": "https://api.github.com/users/stu1130/events{/privacy}",
"received_events_url": "https://api.github.com/users/stu1130/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8182/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8182/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8181 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8181/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8181/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8181/events | https://github.com/NVIDIA/NeMo/pull/8181 | 2,084,820,827 | PR_kwDOC_bI7s5kPZuG | 8,181 | updated online sample mapping | {
"login": "arendu",
"id": 108822655,
"node_id": "U_kgDOBnyAfw",
"avatar_url": "https://avatars.githubusercontent.com/u/108822655?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/arendu",
"html_url": "https://github.com/arendu",
"followers_url": "https://api.github.com/users/arendu/followers",
"following_url": "https://api.github.com/users/arendu/following{/other_user}",
"gists_url": "https://api.github.com/users/arendu/gists{/gist_id}",
"starred_url": "https://api.github.com/users/arendu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arendu/subscriptions",
"organizations_url": "https://api.github.com/users/arendu/orgs",
"repos_url": "https://api.github.com/users/arendu/repos",
"events_url": "https://api.github.com/users/arendu/events{/privacy}",
"received_events_url": "https://api.github.com/users/arendu/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins",
"jenkins\r\n",
"jenkins"
] | 2024-01-16T20:22:44 | 2024-02-05T16:45:32 | 2024-02-05T16:45:31 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8181",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8181",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8181.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8181.patch",
"merged_at": "2024-02-05T16:45:31"
} | # What does this PR do ?
second attempt at https://github.com/NVIDIA/NeMo/pull/8137
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "michalivne",
"id": 7453913,
"node_id": "MDQ6VXNlcjc0NTM5MTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7453913?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michalivne",
"html_url": "https://github.com/michalivne",
"followers_url": "https://api.github.com/users/michalivne/followers",
"following_url": "https://api.github.com/users/michalivne/following{/other_user}",
"gists_url": "https://api.github.com/users/michalivne/gists{/gist_id}",
"starred_url": "https://api.github.com/users/michalivne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/michalivne/subscriptions",
"organizations_url": "https://api.github.com/users/michalivne/orgs",
"repos_url": "https://api.github.com/users/michalivne/repos",
"events_url": "https://api.github.com/users/michalivne/events{/privacy}",
"received_events_url": "https://api.github.com/users/michalivne/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8181/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8181/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8180 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8180/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8180/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8180/events | https://github.com/NVIDIA/NeMo/pull/8180 | 2,084,246,659 | PR_kwDOC_bI7s5kNaGB | 8,180 | Remove left-over prints in NeMo+Lhotse code | {
"login": "pzelasko",
"id": 15930688,
"node_id": "MDQ6VXNlcjE1OTMwNjg4",
"avatar_url": "https://avatars.githubusercontent.com/u/15930688?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pzelasko",
"html_url": "https://github.com/pzelasko",
"followers_url": "https://api.github.com/users/pzelasko/followers",
"following_url": "https://api.github.com/users/pzelasko/following{/other_user}",
"gists_url": "https://api.github.com/users/pzelasko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/pzelasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pzelasko/subscriptions",
"organizations_url": "https://api.github.com/users/pzelasko/orgs",
"repos_url": "https://api.github.com/users/pzelasko/repos",
"events_url": "https://api.github.com/users/pzelasko/events{/privacy}",
"received_events_url": "https://api.github.com/users/pzelasko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"jenkins"
] | 2024-01-16T15:19:54 | 2024-01-18T19:57:38 | 2024-01-18T19:57:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8180",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8180",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8180.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8180.patch",
"merged_at": "2024-01-18T19:57:37"
} | # What does this PR do ?
Remove left-over prints in NeMo+Lhotse code
**Collection**: All speech collections
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [x] Did you write any new necessary tests?
- [x] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [x] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "titu1994",
"id": 3048602,
"node_id": "MDQ6VXNlcjMwNDg2MDI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3048602?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/titu1994",
"html_url": "https://github.com/titu1994",
"followers_url": "https://api.github.com/users/titu1994/followers",
"following_url": "https://api.github.com/users/titu1994/following{/other_user}",
"gists_url": "https://api.github.com/users/titu1994/gists{/gist_id}",
"starred_url": "https://api.github.com/users/titu1994/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/titu1994/subscriptions",
"organizations_url": "https://api.github.com/users/titu1994/orgs",
"repos_url": "https://api.github.com/users/titu1994/repos",
"events_url": "https://api.github.com/users/titu1994/events{/privacy}",
"received_events_url": "https://api.github.com/users/titu1994/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8180/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8180/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8179 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8179/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8179/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8179/events | https://github.com/NVIDIA/NeMo/issues/8179 | 2,084,193,439 | I_kwDOC_bI7s58OkSf | 8,179 | FileNotFoundError: [Errno 2] No such file or directory: 'megatron/core/requirements.txt' | {
"login": "make1986",
"id": 28540794,
"node_id": "MDQ6VXNlcjI4NTQwNzk0",
"avatar_url": "https://avatars.githubusercontent.com/u/28540794?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/make1986",
"html_url": "https://github.com/make1986",
"followers_url": "https://api.github.com/users/make1986/followers",
"following_url": "https://api.github.com/users/make1986/following{/other_user}",
"gists_url": "https://api.github.com/users/make1986/gists{/gist_id}",
"starred_url": "https://api.github.com/users/make1986/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/make1986/subscriptions",
"organizations_url": "https://api.github.com/users/make1986/orgs",
"repos_url": "https://api.github.com/users/make1986/repos",
"events_url": "https://api.github.com/users/make1986/events{/privacy}",
"received_events_url": "https://api.github.com/users/make1986/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1485815557,
"node_id": "MDU6TGFiZWwxNDg1ODE1NTU3",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": "Something isn't working"
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "krishnacpuvvada",
"id": 93558329,
"node_id": "U_kgDOBZOWOQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93558329?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/krishnacpuvvada",
"html_url": "https://github.com/krishnacpuvvada",
"followers_url": "https://api.github.com/users/krishnacpuvvada/followers",
"following_url": "https://api.github.com/users/krishnacpuvvada/following{/other_user}",
"gists_url": "https://api.github.com/users/krishnacpuvvada/gists{/gist_id}",
"starred_url": "https://api.github.com/users/krishnacpuvvada/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/krishnacpuvvada/subscriptions",
"organizations_url": "https://api.github.com/users/krishnacpuvvada/orgs",
"repos_url": "https://api.github.com/users/krishnacpuvvada/repos",
"events_url": "https://api.github.com/users/krishnacpuvvada/events{/privacy}",
"received_events_url": "https://api.github.com/users/krishnacpuvvada/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "krishnacpuvvada",
"id": 93558329,
"node_id": "U_kgDOBZOWOQ",
"avatar_url": "https://avatars.githubusercontent.com/u/93558329?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/krishnacpuvvada",
"html_url": "https://github.com/krishnacpuvvada",
"followers_url": "https://api.github.com/users/krishnacpuvvada/followers",
"following_url": "https://api.github.com/users/krishnacpuvvada/following{/other_user}",
"gists_url": "https://api.github.com/users/krishnacpuvvada/gists{/gist_id}",
"starred_url": "https://api.github.com/users/krishnacpuvvada/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/krishnacpuvvada/subscriptions",
"organizations_url": "https://api.github.com/users/krishnacpuvvada/orgs",
"repos_url": "https://api.github.com/users/krishnacpuvvada/repos",
"events_url": "https://api.github.com/users/krishnacpuvvada/events{/privacy}",
"received_events_url": "https://api.github.com/users/krishnacpuvvada/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Having same issue when installing from pip:\r\n```\r\nCollecting megatron-core==0.4.0 (from nemo_toolkit[all])\r\n Downloading megatron_core-0.4.0.tar.gz (154 kB)\r\n ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 154.8/154.8 kB 8.7 MB/s eta 0:00:00\r\n Installing build dependencies ... done\r\n Getting requirements to build wheel ... error\r\n error: subprocess-exited-with-error\r\n \r\n × Getting requirements to build wheel did not run successfully.\r\n │ exit code: 1\r\n ╰─> [21 lines of output]\r\n Traceback (most recent call last):\r\n File \"/home/thomas/AI-Project/.conda/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py\", line 353, in <module>\r\n main()\r\n File \"/home/thomas/AI-Project/.conda/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py\", line 335, in main\r\n json_out['return_val'] = hook(**hook_input['kwargs'])\r\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n File \"/home/thomas/AI-Project/.conda/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py\", line 118, in get_requires_for_build_wheel\r\n return hook(config_settings)\r\n ^^^^^^^^^^^^^^^^^^^^^\r\n File \"/tmp/pip-build-env-m4c0trdg/overlay/lib/python3.11/site-packages/setuptools/build_meta.py\", line 325, in get_requires_for_build_wheel\r\n return self._get_build_requires(config_settings, requirements=['wheel'])\r\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n File \"/tmp/pip-build-env-m4c0trdg/overlay/lib/python3.11/site-packages/setuptools/build_meta.py\", line 295, in _get_build_requires\r\n self.run_setup()\r\n File \"/tmp/pip-build-env-m4c0trdg/overlay/lib/python3.11/site-packages/setuptools/build_meta.py\", line 480, in run_setup\r\n super(_BuildMetaLegacyBackend, self).run_setup(setup_script=setup_script)\r\n File \"/tmp/pip-build-env-m4c0trdg/overlay/lib/python3.11/site-packages/setuptools/build_meta.py\", line 311, in run_setup\r\n exec(code, locals())\r\n File \"<string>\", line 52, in <module>\r\n File \"<string>\", line 45, in req_file\r\n FileNotFoundError: [Errno 2] No such file or directory: 'megatron/core/requirements.txt'\r\n [end of output]\r\n \r\n note: This error originates from a subprocess, and is likely not a problem with pip.\r\nerror: subprocess-exited-with-error\r\n\r\n× Getting requirements to build wheel did not run successfully.\r\n│ exit code: 1\r\n╰─> See above for output.\r\n\r\nnote: This error originates from a subprocess, and is likely not a problem with pip.\r\n```\r\n\r\nEnvironment overview (please complete the following information)\r\n\r\n Environment location: local\r\n Method of NeMo install: pip install nemo_toolkit['all']\r\n\r\nEnvironment details\r\n\r\n Ubuntu 22.04 LTS\r\n python 3.11\r\n\r\nAdditional context\r\nRTX 4080M\r\nCUDA 12.2",
"Hey everyone, \r\nI stumbled upon the same issue. In this commit [c67243521b048e7ce1446a0d45a0b6e262528e73]((https://github.com/NVIDIA/NeMo/commit/c67243521b048e7ce1446a0d45a0b6e262528e73),) they merged a change updating the megatron version from 0.3.0 to 0.4.0, which seems to be the root of the problem.\r\n\r\nI managed to resolve it by installing an earlier release [v1.21.0](https://github.com/NVIDIA/NeMo/releases/tag/v1.21.0) instead of the current one [v1.22.0](https://github.com/NVIDIA/NeMo/releases/tag/v1.22.0).\r\n\r\nTo install from the previous release, use the following pip command:\r\n\r\n```\r\npip install nemo_toolkit[all]==1.21\r\n```\r\n\r\nI hope this helps!",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue still exists when following the command: `pip install git+https://github.com/NVIDIA/[email protected]#egg=nemo_toolkit[all]` as instructed here: [nvidia/canary-1b](https://huggingface.co/nvidia/canary-1b)\r\n",
"> This issue still exists when following the command: `pip install git+https://github.com/NVIDIA/[email protected]#egg=nemo_toolkit[all]` as instructed here: [nvidia/canary-1b](https://huggingface.co/nvidia/canary-1b)\r\n\r\nIt's true I have the same issue following the [nvidia/canary-1b](https://huggingface.co/nvidia/canary-1b) instructions",
"> > This issue still exists when following the command: `pip install git+https://github.com/NVIDIA/[email protected]#egg=nemo_toolkit[all]` as instructed here: [nvidia/canary-1b](https://huggingface.co/nvidia/canary-1b)\r\n> \r\n> It's true I have the same issue following the [nvidia/canary-1b](https://huggingface.co/nvidia/canary-1b) instructions\r\n\r\ncan you try `pip install git+https://github.com/NVIDIA/[email protected]#egg=nemo_toolkit[asr]` instead of [all] for canary",
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-16T15:00:01 | 2024-04-22T01:45:36 | 2024-04-22T01:45:35 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Describe the bug**
Can't install nemo-toolkit
**Steps/Code to reproduce bug**
Tried to do it through pip and source and getting:
```shell
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [18 lines of output]
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
main()
File "/usr/local/lib/python3.8/dist-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
File "/usr/local/lib/python3.8/dist-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
File "/tmp/pip-build-env-fgqdh0em/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 325, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=['wheel'])
File "/tmp/pip-build-env-fgqdh0em/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 295, in _get_build_requires
self.run_setup()
File "/tmp/pip-build-env-fgqdh0em/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 480, in run_setup
super(_BuildMetaLegacyBackend, self).run_setup(setup_script=setup_script)
File "/tmp/pip-build-env-fgqdh0em/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 311, in run_setup
exec(code, locals())
File "<string>", line 52, in <module>
File "<string>", line 45, in req_file
FileNotFoundError: [Errno 2] No such file or directory: 'megatron/core/requirements.txt'
[end of output]
```
**Environment overview (please complete the following information)**
- Environment location: [Bare-metal, Docker, Cloud(specify cloud provider - AWS, Azure, GCP, Collab)]
- Method of NeMo install: [pip install or from source]. Please specify exact commands you used to install.
- If method of install is [Docker], provide `docker pull` & `docker run` commands used
**Environment details**
- Ubuntu 20.04
- python 3.8, 3.9, 3.10, 3.11
**Additional context**
RTX 3090
CUDA 12.2
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8179/reactions",
"total_count": 11,
"+1": 11,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8179/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8178 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8178/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8178/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8178/events | https://github.com/NVIDIA/NeMo/issues/8178 | 2,083,344,556 | I_kwDOC_bI7s58LVCs | 8,178 | Feature Request - MAML Support | {
"login": "Chaitanya-Jadhav",
"id": 46163353,
"node_id": "MDQ6VXNlcjQ2MTYzMzUz",
"avatar_url": "https://avatars.githubusercontent.com/u/46163353?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Chaitanya-Jadhav",
"html_url": "https://github.com/Chaitanya-Jadhav",
"followers_url": "https://api.github.com/users/Chaitanya-Jadhav/followers",
"following_url": "https://api.github.com/users/Chaitanya-Jadhav/following{/other_user}",
"gists_url": "https://api.github.com/users/Chaitanya-Jadhav/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Chaitanya-Jadhav/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Chaitanya-Jadhav/subscriptions",
"organizations_url": "https://api.github.com/users/Chaitanya-Jadhav/orgs",
"repos_url": "https://api.github.com/users/Chaitanya-Jadhav/repos",
"events_url": "https://api.github.com/users/Chaitanya-Jadhav/events{/privacy}",
"received_events_url": "https://api.github.com/users/Chaitanya-Jadhav/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.",
"This issue was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-16T08:51:23 | 2024-02-24T01:42:58 | 2024-02-24T01:42:58 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | **Feature Request:**
I would like to request the addition of support for Model-Agnostic Meta-Learning (MAML) in the NVIDIA NeMo Toolkit. MAML is a powerful meta-learning algorithm that allows models to quickly adapt to new tasks.
**Why is this feature important?**
Its inclusion in the NeMo Toolkit would benefit for low resourced languages.
[Model-Agnostic Meta-Learning for Fast Adaptation of Deep Networks](https://arxiv.org/abs/1703.03400) | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8178/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8178/timeline | null | not_planned | false |
https://api.github.com/repos/NVIDIA/NeMo/issues/8177 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8177/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8177/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8177/events | https://github.com/NVIDIA/NeMo/pull/8177 | 2,083,094,388 | PR_kwDOC_bI7s5kJZfz | 8,177 | onnx export for G2P models | {
"login": "ppisljar",
"id": 13629809,
"node_id": "MDQ6VXNlcjEzNjI5ODA5",
"avatar_url": "https://avatars.githubusercontent.com/u/13629809?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ppisljar",
"html_url": "https://github.com/ppisljar",
"followers_url": "https://api.github.com/users/ppisljar/followers",
"following_url": "https://api.github.com/users/ppisljar/following{/other_user}",
"gists_url": "https://api.github.com/users/ppisljar/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ppisljar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ppisljar/subscriptions",
"organizations_url": "https://api.github.com/users/ppisljar/orgs",
"repos_url": "https://api.github.com/users/ppisljar/repos",
"events_url": "https://api.github.com/users/ppisljar/events{/privacy}",
"received_events_url": "https://api.github.com/users/ppisljar/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"Hello,\r\n\r\ni am trying to make G2P models exportable, but i am running into issues with ONNX export.\r\nI hope someone here can guide me to the correct solution.\r\n\r\n\r\n",
"both (t5 and ctc) return this error:\r\ni am guessing i am doing something wrong with the output types ?\r\n\r\n```\r\nTraceback (most recent call last):\r\n File \"/workspace/6_export.py\", line 38, in <module>\r\n model.export('mymodel.onnx')\r\n File \"/usr/local/lib/python3.10/dist-packages/nemo/core/classes/exportable.py\", line 113, in export\r\n out, descr, out_example = model._export(\r\n File \"/usr/local/lib/python3.10/dist-packages/nemo/core/classes/exportable.py\", line 220, in _export\r\n torch.onnx.export(\r\n File \"/usr/local/lib/python3.10/dist-packages/torch/onnx/utils.py\", line 516, in export\r\n _export(\r\n File \"/usr/local/lib/python3.10/dist-packages/torch/onnx/utils.py\", line 1582, in _export\r\n graph, params_dict, torch_out = _model_to_graph(\r\n File \"/usr/local/lib/python3.10/dist-packages/torch/onnx/utils.py\", line 1182, in _model_to_graph\r\n _C._jit_pass_onnx_assign_output_shape(\r\nRuntimeError: ArrayRef: invalid index Index = 0; Length = 0\r\n\r\n```",
"i was able to get onnx export to finish (with a lot of warnings) for CTC model, if i changed the last lines to :\r\n\r\n```\r\n preds_str, _ = self.decoding.ctc_decoder_predictions_tensor(\r\n log_probs, decoder_lengths=encoded_len, return_hypotheses=True\r\n )\r\n results = [h.y_sequence for h in preds_str]\r\n return tuple(results)\r\n```\r\n\r\nas it seems that returning a string was an issue ?\r\n\r\nhowever when i try to use this onnx model, it tells me it has 0 inputs:\r\n\r\n```\r\nort_session = onnxruntime.InferenceSession(\"mymodel.onnx\", providers=[\"CPUExecutionProvider\"])\r\nprint(ort_session.get_inputs())\r\n```\r\n\r\nreturns []",
"in the latest commit https://github.com/NVIDIA/NeMo/pull/8177/commits/e93ffeca5c57fd88e4a00d8fd522052731f07a68 ctc decoding is skipped, in this way export works succesfully for CTC model as well.\r\n\r\nis it not possible to make ctc decoding part of the onnx model ?",
"i verified the generated onnx models and they seem to work correctly.\r\n\r\nstill i would really appreciate if someone can guide to towards making ctc decoding part of the nemo model as well as without it its quite hard to consume it.",
"@rlangman can you take a look ?",
"@borisfom could you take a look at this?",
"@ppisljar @rlangman : For ASR models. it's typical to exclude CTC decoder and tokenizer from ONNX export - as they normally could not be exported. So only DNN part (EncDecModel) is usually represented by ONNX graph.",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"jenkins",
"@mgrafu , @borisfom are you OK with the changes?",
"jenkins",
"ping",
"jenkins",
"jenkins",
"jenkins"
] | 2024-01-16T06:19:05 | 2024-03-20T09:00:18 | 2024-03-20T09:00:17 | CONTRIBUTOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8177",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8177",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8177.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8177.patch",
"merged_at": "2024-03-20T09:00:17"
} | # What does this PR do ?
Adds support for ONNX export to G2P models (CTC/byT5)
**Collection**: tts
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [x] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
**PR Type**:
- [x] New Feature
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "ekmb",
"id": 10428420,
"node_id": "MDQ6VXNlcjEwNDI4NDIw",
"avatar_url": "https://avatars.githubusercontent.com/u/10428420?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ekmb",
"html_url": "https://github.com/ekmb",
"followers_url": "https://api.github.com/users/ekmb/followers",
"following_url": "https://api.github.com/users/ekmb/following{/other_user}",
"gists_url": "https://api.github.com/users/ekmb/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ekmb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ekmb/subscriptions",
"organizations_url": "https://api.github.com/users/ekmb/orgs",
"repos_url": "https://api.github.com/users/ekmb/repos",
"events_url": "https://api.github.com/users/ekmb/events{/privacy}",
"received_events_url": "https://api.github.com/users/ekmb/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8177/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8177/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8176 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8176/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8176/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8176/events | https://github.com/NVIDIA/NeMo/pull/8176 | 2,083,030,346 | PR_kwDOC_bI7s5kJL9C | 8,176 | Support GPT MCore models in M-LM->NeMo Conversion Script | {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale.",
"jenkins",
"jenkins"
] | 2024-01-16T05:08:10 | 2024-03-04T22:53:27 | 2024-02-29T23:29:36 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8176",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8176",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8176.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8176.patch",
"merged_at": "2024-02-29T23:29:36"
} | # What does this PR do ?
Add support for MCore GPT models in the Megatron-LM to NeMo model conversion script.
The script originally supported legacy M-LM -> legacy NeMo conversion.
The script now supports two more paths: legacy M-LM -> MCore NeMo, and MCore M-LM -> MCore NeMo conversions.
MCore M-LM -> legacy NeMo is not a valid use case and hence not supported.
**Collection**: NLP
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
To convert to MCore NeMo model, add `mcore_gpt=True` in the hparams.yaml file that is the input to this script.
To convert from MCore M-LM model, pass in `--mcore_input` to the script.
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [x] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "cuichenx",
"id": 43478052,
"node_id": "MDQ6VXNlcjQzNDc4MDUy",
"avatar_url": "https://avatars.githubusercontent.com/u/43478052?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cuichenx",
"html_url": "https://github.com/cuichenx",
"followers_url": "https://api.github.com/users/cuichenx/followers",
"following_url": "https://api.github.com/users/cuichenx/following{/other_user}",
"gists_url": "https://api.github.com/users/cuichenx/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cuichenx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cuichenx/subscriptions",
"organizations_url": "https://api.github.com/users/cuichenx/orgs",
"repos_url": "https://api.github.com/users/cuichenx/repos",
"events_url": "https://api.github.com/users/cuichenx/events{/privacy}",
"received_events_url": "https://api.github.com/users/cuichenx/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8176/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8176/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8175 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8175/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8175/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8175/events | https://github.com/NVIDIA/NeMo/pull/8175 | 2,082,448,734 | PR_kwDOC_bI7s5kHQTO | 8,175 | Update checkpoint_averaging_model_parallel.py | {
"login": "jubick1337",
"id": 16004982,
"node_id": "MDQ6VXNlcjE2MDA0OTgy",
"avatar_url": "https://avatars.githubusercontent.com/u/16004982?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jubick1337",
"html_url": "https://github.com/jubick1337",
"followers_url": "https://api.github.com/users/jubick1337/followers",
"following_url": "https://api.github.com/users/jubick1337/following{/other_user}",
"gists_url": "https://api.github.com/users/jubick1337/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jubick1337/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jubick1337/subscriptions",
"organizations_url": "https://api.github.com/users/jubick1337/orgs",
"repos_url": "https://api.github.com/users/jubick1337/repos",
"events_url": "https://api.github.com/users/jubick1337/events{/privacy}",
"received_events_url": "https://api.github.com/users/jubick1337/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
}
] | closed | false | null | [] | null | [
"jenkins",
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-15T17:33:52 | 2024-02-08T01:43:38 | 2024-02-08T01:43:37 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8175",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8175",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8175.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8175.patch",
"merged_at": null
} | checkpoint_averaging_model_parallel.py
Description update
# What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
**Collection**: [Note which collection this PR will affect]
# Changelog
- Add specific line by line info of high level changes in this PR.
# Usage
* You can potentially add a usage example below
```python
# Add a code snippet demonstrating how to use this
```
# Jenkins CI
To run Jenkins, a NeMo User with write access must comment `jenkins` on the PR.
# Before your PR is "Ready for review"
**Pre checks**:
- [ ] Make sure you read and followed [Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md)
- [ ] Did you write any new necessary tests?
- [ ] Did you add or update any necessary documentation?
- [ ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- [ ] Reviewer: Does the PR have correct import guards for all optional libraries?
**PR Type**:
- [ ] New Feature
- [ ] Bugfix
- [ ] Documentation
If you haven't finished some of the above items you can still open "Draft" PR.
## Who can review?
Anyone in the community is free to review the PR once the checks have passed.
[Contributor guidelines](https://github.com/NVIDIA/NeMo/blob/main/CONTRIBUTING.md) contains specific people who can review PRs to various areas.
# Additional Information
* Related to # (issue)
| {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8175/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8175/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8174 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8174/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8174/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8174/events | https://github.com/NVIDIA/NeMo/pull/8174 | 2,082,379,788 | PR_kwDOC_bI7s5kHBvn | 8,174 | Canary speechllm | {
"login": "stevehuang52",
"id": 105218074,
"node_id": "U_kgDOBkWAGg",
"avatar_url": "https://avatars.githubusercontent.com/u/105218074?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stevehuang52",
"html_url": "https://github.com/stevehuang52",
"followers_url": "https://api.github.com/users/stevehuang52/followers",
"following_url": "https://api.github.com/users/stevehuang52/following{/other_user}",
"gists_url": "https://api.github.com/users/stevehuang52/gists{/gist_id}",
"starred_url": "https://api.github.com/users/stevehuang52/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevehuang52/subscriptions",
"organizations_url": "https://api.github.com/users/stevehuang52/orgs",
"repos_url": "https://api.github.com/users/stevehuang52/repos",
"events_url": "https://api.github.com/users/stevehuang52/events{/privacy}",
"received_events_url": "https://api.github.com/users/stevehuang52/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"id": 1923495043,
"node_id": "MDU6TGFiZWwxOTIzNDk1MDQz",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core",
"name": "core",
"color": "f25e3a",
"default": false,
"description": "Changes to NeMo Core"
},
{
"id": 4418253970,
"node_id": "LA_kwDOC_bI7s8AAAABB1k0kg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS",
"name": "TTS",
"color": "49AF28",
"default": false,
"description": ""
},
{
"id": 4585431311,
"node_id": "LA_kwDOC_bI7s8AAAABEVAhDw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale",
"name": "stale",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 4811884691,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR",
"name": "ASR",
"color": "F3B33E",
"default": false,
"description": ""
},
{
"id": 4811886210,
"node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP",
"name": "NLP",
"color": "CBF09A",
"default": false,
"description": ""
},
{
"id": 4811888028,
"node_id": "LA_kwDOC_bI7s8AAAABHs-VnA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Speaker%20Tasks",
"name": "Speaker Tasks",
"color": "871AD4",
"default": false,
"description": ""
},
{
"id": 4840216855,
"node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI",
"name": "CI",
"color": "1D76DB",
"default": false,
"description": ""
},
{
"id": 4847373924,
"node_id": "LA_kwDOC_bI7s8AAAABIO0OZA",
"url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common",
"name": "common",
"color": "c5def5",
"default": false,
"description": ""
}
] | closed | false | null | [] | null | [
"This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.",
"This PR was closed because it has been inactive for 7 days since being marked as stale."
] | 2024-01-15T16:44:11 | 2024-02-07T01:43:28 | 2024-02-07T01:43:27 | COLLABORATOR | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | false | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/pulls/8174",
"html_url": "https://github.com/NVIDIA/NeMo/pull/8174",
"diff_url": "https://github.com/NVIDIA/NeMo/pull/8174.diff",
"patch_url": "https://github.com/NVIDIA/NeMo/pull/8174.patch",
"merged_at": null
} | null | {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8174/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8174/timeline | null | null | true |
https://api.github.com/repos/NVIDIA/NeMo/issues/8173 | https://api.github.com/repos/NVIDIA/NeMo | https://api.github.com/repos/NVIDIA/NeMo/issues/8173/labels{/name} | https://api.github.com/repos/NVIDIA/NeMo/issues/8173/comments | https://api.github.com/repos/NVIDIA/NeMo/issues/8173/events | https://github.com/NVIDIA/NeMo/issues/8173 | 2,081,968,376 | I_kwDOC_bI7s58GFD4 | 8,173 | Set up microphone for Colab | {
"login": "MostafaAlaviyan",
"id": 84375686,
"node_id": "MDQ6VXNlcjg0Mzc1Njg2",
"avatar_url": "https://avatars.githubusercontent.com/u/84375686?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MostafaAlaviyan",
"html_url": "https://github.com/MostafaAlaviyan",
"followers_url": "https://api.github.com/users/MostafaAlaviyan/followers",
"following_url": "https://api.github.com/users/MostafaAlaviyan/following{/other_user}",
"gists_url": "https://api.github.com/users/MostafaAlaviyan/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MostafaAlaviyan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MostafaAlaviyan/subscriptions",
"organizations_url": "https://api.github.com/users/MostafaAlaviyan/orgs",
"repos_url": "https://api.github.com/users/MostafaAlaviyan/repos",
"events_url": "https://api.github.com/users/MostafaAlaviyan/events{/privacy}",
"received_events_url": "https://api.github.com/users/MostafaAlaviyan/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [] | closed | false | {
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | [
{
"login": "okuchaiev",
"id": 22035961,
"node_id": "MDQ6VXNlcjIyMDM1OTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/okuchaiev",
"html_url": "https://github.com/okuchaiev",
"followers_url": "https://api.github.com/users/okuchaiev/followers",
"following_url": "https://api.github.com/users/okuchaiev/following{/other_user}",
"gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions",
"organizations_url": "https://api.github.com/users/okuchaiev/orgs",
"repos_url": "https://api.github.com/users/okuchaiev/repos",
"events_url": "https://api.github.com/users/okuchaiev/events{/privacy}",
"received_events_url": "https://api.github.com/users/okuchaiev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
] | null | [
"Hi, the real-time streaming notebooks (such as that one) won't work in Colab unfortunately. You need to run the notebooks locally. They will not be able to record your microphone audio if you run them in Colab or in a Docker container."
] | 2024-01-15T12:47:32 | 2024-01-18T00:07:48 | 2024-01-18T00:07:48 | NONE | {
"total": 0,
"completed": 0,
"percent_completed": 0
} | null | null | null | Hello everyone
I want to run the
https://github.com/NVIDIA/NeMo/blob/main/tutorials/asr/Online_Offline_Microphone_VAD_Demo.ipynb
in colab, but colab dose not access to the microphone.
How can I resolve the issue? | {
"login": "erastorgueva-nv",
"id": 80532067,
"node_id": "MDQ6VXNlcjgwNTMyMDY3",
"avatar_url": "https://avatars.githubusercontent.com/u/80532067?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/erastorgueva-nv",
"html_url": "https://github.com/erastorgueva-nv",
"followers_url": "https://api.github.com/users/erastorgueva-nv/followers",
"following_url": "https://api.github.com/users/erastorgueva-nv/following{/other_user}",
"gists_url": "https://api.github.com/users/erastorgueva-nv/gists{/gist_id}",
"starred_url": "https://api.github.com/users/erastorgueva-nv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erastorgueva-nv/subscriptions",
"organizations_url": "https://api.github.com/users/erastorgueva-nv/orgs",
"repos_url": "https://api.github.com/users/erastorgueva-nv/repos",
"events_url": "https://api.github.com/users/erastorgueva-nv/events{/privacy}",
"received_events_url": "https://api.github.com/users/erastorgueva-nv/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
} | {
"url": "https://api.github.com/repos/NVIDIA/NeMo/issues/8173/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/NVIDIA/NeMo/issues/8173/timeline | null | completed | false |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.