Datasets:

---

renwei2024

/

nemo-github-issues

like 0

[ { "id": 4418253970, "node_id": "LA_kwDOC_bI7s8AAAABB1k0kg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS", "name": "TTS", "color": "49AF28", "default": false, "description": "" }, { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[]

[ { "id": 4556669155, "node_id": "LA_kwDOC_bI7s8AAAABD5lA4w", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick", "name": "cherry-pick", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[ "jenkins" ]

[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[]

[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]

[ { "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]

[ "Thanks for letting us know. @athitten could you take a look if we can safely unpin Transformers ? Fyi @ericharper ", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "Any news related to this issue?", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]

[ { "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]

[ "I managed to reproduce🙃" ]

[ { "id": 4556669155, "node_id": "LA_kwDOC_bI7s8AAAABD5lA4w", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick", "name": "cherry-pick", "color": "ededed", "default": false, "description": null }, { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]

[]

[]

[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]

[]

[]

[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]

[]

[]

[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[ "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins" ]

[ { "id": 4418253970, "node_id": "LA_kwDOC_bI7s8AAAABB1k0kg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS", "name": "TTS", "color": "49AF28", "default": false, "description": "" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" } ]

[]

[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]

[ { "id": 4556669155, "node_id": "LA_kwDOC_bI7s8AAAABD5lA4w", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick", "name": "cherry-pick", "color": "ededed", "default": false, "description": null } ]

[]

[]

[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[ "Could you please keep the conversion script consistent with other ones? I specifically mean:\r\n* https://github.com/NVIDIA/NeMo/blob/main/scripts/nlp_language_modeling/convert_mpt_7b_hf_to_nemo.py\r\n* https://github.com/NVIDIA/NeMo/blob/main/scripts/nlp_language_modeling/convert_starcoder_hf_to_nemo.py\r\n* https://github.com/NVIDIA/NeMo/blob/main/scripts/nlp_language_modeling/convert_hf_falcon_to_nemo.py\r\n\r\nIn particular, at best we keep these aligned across scripts:\r\n* defining a new `convert_state_dict` function\r\n* config handling (`override_model_dict` etc.)\r\n* script parameters.\r\n\r\n[Llama2 conversion script](https://github.com/NVIDIA/NeMo/blob/main/scripts/nlp_language_modeling/convert_hf_llama_to_nemo.py) has a bit different flavour, but I believe we should follow the \"majority\" style for new scripts (and align Llama2 at some point).", "As for architecture, Mistral seems to heavily borrow from Llama2.\r\n\r\nWould it be possible to just extend Llama2 conversion script to cover HF Mistral checkpoint?", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "Hi @janekl thanks for your comments! I'm leaning towards merging this as is and once we settle on how we want to refactor the import scripts do the actual refactor. I think you are right it shares a lot with the Llama script, and once the PRs you mention have been approved & merged we can follow the appropriate guidelines here as well.", "jenkins", "jenkins", "I think that adding a Jenkins conversion test for a small Mistral model would be really desirable. \r\n\r\nExamples are here https://github.com/NVIDIA/NeMo/blob/f10d6941d7c18a0154d41c943deaae4d65a4b752/Jenkinsfile#L391-L419\r\n\r\ncc @ericharper ", "> Hi @janekl thanks for your comments! I'm leaning towards merging this as is and once we settle on how we want to refactor the import scripts do the actual refactor. I think you are right it shares a lot with the Llama script, and once the PRs you mention have been approved & merged we can follow the appropriate guidelines here as well.\r\n\r\nSorry for replying late. That's fine, we can polish it later, there is some consistency PR open here https://github.com/NVIDIA/NeMo/pull/8192.\r\n\r\nIn any case, please see my comments in two other threads. We really need to test conversion in analogy to other scripts. Otherwise we won't have any confidence in refactoring work later. I think @ericharper should support this extra effort." ]

[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[ "jenkins", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "Re-opening, can someone please help review this minor change?", "+1 on this issue", "Closing as this issue has been addressed in #8130" ]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]

[]

[ "The docs should be up and running again, I'll inform the team about the broken links. ", "Links are updated, pls let us know if you find any issues. " ]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]

[]

[ "I found that enabling ub_tp_comm_overlap will create a new mpi process group, which will cause problems. I don't know if it has something to do with the mpi version.", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]

[]

[]

[ "jenkins" ]

[ { "id": 4418253970, "node_id": "LA_kwDOC_bI7s8AAAABB1k0kg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS", "name": "TTS", "color": "49AF28", "default": false, "description": "" }, { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]

[ { "login": "tbartley94", "id": 90423858, "node_id": "MDQ6VXNlcjkwNDIzODU4", "avatar_url": "https://avatars.githubusercontent.com/u/90423858?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tbartley94", "html_url": "https://github.com/tbartley94", "followers_url": "https://api.github.com/users/tbartley94/followers", "following_url": "https://api.github.com/users/tbartley94/following{/other_user}", "gists_url": "https://api.github.com/users/tbartley94/gists{/gist_id}", "starred_url": "https://api.github.com/users/tbartley94/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tbartley94/subscriptions", "organizations_url": "https://api.github.com/users/tbartley94/orgs", "repos_url": "https://api.github.com/users/tbartley94/repos", "events_url": "https://api.github.com/users/tbartley94/events{/privacy}", "received_events_url": "https://api.github.com/users/tbartley94/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]

[ "@titu1994 <- `wer` metric changes as discussed in thread. (gonna just do the refactoring first before deciding on what to do with bleu)\r\n\r\n@AlexGrinch <- fly by change for `transformer_bpe`", "> Wait what exactly is going on with the removal of decoding logic?? Revert that\r\n\r\nWhich, moving the decoding into `parts` or aliasing the `prediction_tensors`?\r\n\r\nIf the former: there's no reason to keep the decoding in metrics since they're not reflecting respective models anymore. We also don't put any other decoding in metrics, only WER has that, and it's really confusing to have to look in a metrics folder for decoding classes. Given we keep the other decoding stuff in `parts.submodules`, it seems like they're better off over there. \r\n\r\nIf the latter: yeah I don't like it, but it's either there or we perform a check in the forward loop. Better solution would be renaming `{rnnt/ctc}_predictions_tensor` to just `predictions_tensor`, but I think people are just accustomed to that name scheme at this point.", "@sam1373 can you review just the metrics files (wer.py, wer_bpe.py) to make sure stuff seems correct for SSL ?", "jenkins ", "Aight, added back in the `fold_consecutive` flag. Still trying to keep the `update` pass model agnostic so had to be a bit hacky with the `__init__`. If that's not gonna work, I may have to either add a conditional in the `update` pass or edit the `ctc_decoding_predictions_tensor` to allow setting the `fold_consecutive` flag. ", "jenkins", "CI seems to have failed ?", "> CI seems to have failed ?\r\n\r\nYeah someone must have added another test over the break. Lemme check", "> CI seems to have failed ?\r\n\r\nAight, seems like I messed up a variable assignment in the lambda call. All my pytests passing on local now (exceping that weird tokenization bug in `test_asr_rnnt_encodec_model`", "jenkins", "jenkins", "jenkins", "@titu1994 I'm getting through unittests but Jenkins seems to be breaking down around when running Speaker Diarization. Don't really have access to the backend but none of it seems related to my PR.", "You can click the link in Jenkins. I'll discuss offline ", "jenkins ", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "@titu1994 Jenkins is happy. Could I get a final review one last time? (Before this extends into yet more modules.)", "jenkins" ]

[ { "id": 4556669155, "node_id": "LA_kwDOC_bI7s8AAAABD5lA4w", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick", "name": "cherry-pick", "color": "ededed", "default": false, "description": null } ]

[]

[ "jenkins", "I think that this is not needed in main, since lightning-utilities has released fixed version https://github.com/Lightning-AI/utilities/releases/tag/v0.10.1\r\nI'm closing this PR\r\ncc: @titu1994, @ericharper " ]

[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]

[]

[ "jenkins" ]

[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]

[]

[]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]

[]

[ "Thanks for letting us know, we're looking into it. ", "This should be fixee now. Thanks for letting us know !" ]

[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[ "jenkins", "merging this as this is critical to unblock any llama2 workflows" ]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]

[]

[ "We are aware of this, hence the Todo to remove it. But our condition for removal is that we update all the PC models we release such that they do not have spaces between special tokens. So the removal won't have an effect at that point since all the models will anyway emit no space between special tokens. \r\n\r\nThe simplest solution to this problem is to collapse the space between special tokens in both the ground truth and the predicted models, rather than keep the spaces and anyway get incorrect metrics during inference. ", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]

[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]

[ { "login": "karpnv", "id": 1645775, "node_id": "MDQ6VXNlcjE2NDU3NzU=", "avatar_url": "https://avatars.githubusercontent.com/u/1645775?v=4", "gravatar_id": "", "url": "https://api.github.com/users/karpnv", "html_url": "https://github.com/karpnv", "followers_url": "https://api.github.com/users/karpnv/followers", "following_url": "https://api.github.com/users/karpnv/following{/other_user}", "gists_url": "https://api.github.com/users/karpnv/gists{/gist_id}", "starred_url": "https://api.github.com/users/karpnv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/karpnv/subscriptions", "organizations_url": "https://api.github.com/users/karpnv/orgs", "repos_url": "https://api.github.com/users/karpnv/repos", "events_url": "https://api.github.com/users/karpnv/events{/privacy}", "received_events_url": "https://api.github.com/users/karpnv/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]

[ "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]

[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]

[]

[ "jenkins", "@ericharper should we move this to the base model instead ?", "jenkins", "> @ericharper should we move this to the base model instead ?\r\n\r\nYes, let's do it in another pr." ]

[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4418253970, "node_id": "LA_kwDOC_bI7s8AAAABB1k0kg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS", "name": "TTS", "color": "49AF28", "default": false, "description": "" }, { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 4847373924, "node_id": "LA_kwDOC_bI7s8AAAABIO0OZA", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/common", "name": "common", "color": "c5def5", "default": false, "description": "" } ]

[]

[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[ "Closed by https://github.com/NVIDIA/NeMo/pull/8038." ]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]

[ { "login": "ericharper", "id": 11999610, "node_id": "MDQ6VXNlcjExOTk5NjEw", "avatar_url": "https://avatars.githubusercontent.com/u/11999610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ericharper", "html_url": "https://github.com/ericharper", "followers_url": "https://api.github.com/users/ericharper/followers", "following_url": "https://api.github.com/users/ericharper/following{/other_user}", "gists_url": "https://api.github.com/users/ericharper/gists{/gist_id}", "starred_url": "https://api.github.com/users/ericharper/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ericharper/subscriptions", "organizations_url": "https://api.github.com/users/ericharper/orgs", "repos_url": "https://api.github.com/users/ericharper/repos", "events_url": "https://api.github.com/users/ericharper/events{/privacy}", "received_events_url": "https://api.github.com/users/ericharper/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, { "login": "okuchaiev", "id": 22035961, "node_id": "MDQ6VXNlcjIyMDM1OTYx", "avatar_url": "https://avatars.githubusercontent.com/u/22035961?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okuchaiev", "html_url": "https://github.com/okuchaiev", "followers_url": "https://api.github.com/users/okuchaiev/followers", "following_url": "https://api.github.com/users/okuchaiev/following{/other_user}", "gists_url": "https://api.github.com/users/okuchaiev/gists{/gist_id}", "starred_url": "https://api.github.com/users/okuchaiev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okuchaiev/subscriptions", "organizations_url": "https://api.github.com/users/okuchaiev/orgs", "repos_url": "https://api.github.com/users/okuchaiev/repos", "events_url": "https://api.github.com/users/okuchaiev/events{/privacy}", "received_events_url": "https://api.github.com/users/okuchaiev/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]

[ "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "Touch.", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]

[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[ "@athitten Can you write unit tests for this? It would be nice to have at leas a docsting (it could be in the test itself) describing what is the expected behaviour of this function and what purpose does it serve.\r\n\r\nIf this code is here to fix a bug in PTL or cover some case not covered by PTL please describe what it is and write a comment in the code. This looks like a hack to me and should be properly commented to help future developers understand what's going on in this function and when potentially can it be removed.", "jenkins", "jenkins", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]

[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" }, { "id": 6627254865, "node_id": "LA_kwDOC_bI7s8AAAABiwPiUQ", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Multi%20Modal", "name": "Multi Modal", "color": "ededed", "default": false, "description": null } ]

[]

[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "jenkins\r\n", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins" ]

[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[ "@HeyyyyyyG is this WIP?", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "> LGTM! but i think we should merge #7988 before this one\r\n\r\nYes totally agree", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins" ]

[ { "id": 1485815558, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU4", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/documentation", "name": "documentation", "color": "0075ca", "default": true, "description": "Improvements or additions to documentation" }, { "id": 4840216855, "node_id": "LA_kwDOC_bI7s8AAAABIH_ZFw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/CI", "name": "CI", "color": "1D76DB", "default": false, "description": "" } ]

[]

[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins", "jenkins" ]

[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" } ]

[]

[ "jenkins", "jenkins", "jenkins", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "jenkins", "Tests seem to have failed, could you check ?", "jenkins", "jenkins", "jenkins", "> Tests seem to have failed, could you check ?\r\n\r\nAll tests are passed. There were some weird issues with connection unrelated to this PR." ]

[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]

[]

[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]

[ { "id": 1485815557, "node_id": "MDU6TGFiZWwxNDg1ODE1NTU3", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]

[]

[ "I ran into the same issue => hacked the code to zero out the loss on problematic micro-batches: https://github.com/odelalleau/NeMo/commit/b383e6a1e55dd315fa194c0a8fafd7ee3fef3437\r\n\r\n(obviously not a proper fix but can be useful to get unblocked)", "Yeah, this will also fix the problem. ", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue should keep active since the same problem has been encountered by others as well.", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]

[]

[ { "login": "AlexGrinch", "id": 8689095, "node_id": "MDQ6VXNlcjg2ODkwOTU=", "avatar_url": "https://avatars.githubusercontent.com/u/8689095?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AlexGrinch", "html_url": "https://github.com/AlexGrinch", "followers_url": "https://api.github.com/users/AlexGrinch/followers", "following_url": "https://api.github.com/users/AlexGrinch/following{/other_user}", "gists_url": "https://api.github.com/users/AlexGrinch/gists{/gist_id}", "starred_url": "https://api.github.com/users/AlexGrinch/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AlexGrinch/subscriptions", "organizations_url": "https://api.github.com/users/AlexGrinch/orgs", "repos_url": "https://api.github.com/users/AlexGrinch/repos", "events_url": "https://api.github.com/users/AlexGrinch/events{/privacy}", "received_events_url": "https://api.github.com/users/AlexGrinch/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]

[ "Closing this issue as it was already answered here:\r\n\r\nhttps://github.com/NVIDIA/NeMo/issues/4390" ]

[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]

[]

[ "Hi, apologies for late response. \r\n\r\nHave you looked at these sections on finetuning: https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/asr/configs.html#fine-tuning-configurations and https://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/stable/asr/examples/kinyarwanda_asr.html#training-from-scratch-and-finetuning \r\n\r\nLet us know if you have issues using the scripts. ", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale." ]

[]

[]

[ "jenkins", "@titu1994 It seem to be a know issue, hope will be fixed soon https://github.com/Lightning-AI/utilities/issues/196", "Merging for now - fyi @ericharper @athitten ", "Don't merge this to main for now (unless Eric or @athitten gives the go ahead for main)", "@titu1994 The issue is fixed in Lightning-Utilities in `main`, waiting for the next release: https://github.com/Lightning-AI/utilities/pull/210\r\n" ]

[ { "id": 4556669155, "node_id": "LA_kwDOC_bI7s8AAAABD5lA4w", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick", "name": "cherry-pick", "color": "ededed", "default": false, "description": null } ]

[]

[]

[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null } ]

[]

[ "should be possible. Are you facing any issues while finetuning? \r\n@VahidooX to confirm. ", "Not for offline model to streaming. You can do this if you keep the encoder architecture the same, with the flags for loading a checkpoint inside the maybe init from checkpoint function. You will have to exclude the decoder and joint weights when you specify the RNNT model checkpoint inside your ctc train script. \r\n\r\nhttps://docs.nvidia.com/deeplearning/nemo/user-guide/docs/en/main/core/api.html#nemo.core.ModelPT.maybe_init_from_pretrained_checkpoint", "The convolutions in streaming models are different from the offline models, so not sure if it is possible. Names can be different. Have not tried it, but it is better to start from a streaming model instead. We have some pretrained streaming checkpoints already for English. You may keep the decoder if load from a ctc to another ctc.", "Oh I just realized user wants to train offline first and use it for streaming, sadly this may not be possible as Vahid pointed out. I will update my comment above ", "The conformer CTC model is an encoder only architecture. So I tried to initialize and offline Conformer-CTC for the conformer-CTC streaming architecture and then ran the finetune on just 100hrs of train data with the streaming configs. It still worked and gave much lower WER in the zeroth epoch itself. Which means that it is indeed possible!!", "That's pretty amazing ! Wasn't there shape mismatch when loading the checkpoint ?", "Sorry my mistake. There was no error as such and the online Conf-CTC checkpoint loaded correctly. On fine-tuning with conf-CTC streaming, it ran without an error but to my surprise the .nemo model generated still contains model.config which is non-streaming. If that is the case then how did some part of the streaming configs enabled training to proceed as usual in the first place? Please comment if this sounds like an error - \r\n\r\n'''\r\n[NeMo W 2024-01-04 04:28:17 exp_manager:900] The checkpoint callback was told to monitor a validation value and trainer's max_steps was set to -1. Please ensure that max_steps will run for at least 1 epochs to ensure that checkpointing will not error out.\r\n[NeMo W 2024-01-04 04:28:19 modelPT:142] If you intend to do training or fine-tuning, please call the ModelPT.setup_training_data() method and provide a valid configuration file to setup the train data loader.\r\n Train config :\r\n manifest_filepath: ../../data/hindi_normalized/filtered_hindi_v1_manifest.json\r\n sample_rate: 16000\r\n batch_size: 24\r\n shuffle: true\r\n num_workers: 16\r\n pin_memory: true\r\n use_start_end_token: false\r\n trim_silence: false\r\n max_duration: 30\r\n min_duration: 0.1\r\n is_tarred: false\r\n tarred_audio_filepaths: null\r\n shuffle_n: 2048\r\n bucketing_strategy: synced_randomized\r\n bucketing_batch_size: 8\r\n \r\n [NeMo W 2024-01-04 04:30:11 modelPT:486] Trainer wasn't specified in model constructor. Make sure that you really wanted it.\r\n[NeMo W 2024-01-04 04:30:11 lr_scheduler:890] Neither `max_steps` nor `iters_per_batch` were provided to `optim.sched`, cannot compute effective `max_steps` !\r\n Scheduler will not be instantiated !\r\nInitializing distributed: GLOBAL_RANK: 0, MEMBER: 1/1\r\n----------------------------------------------------------------------------------------------------\r\ndistributed_backend=nccl\r\nAll distributed processes registered. Starting with 1 processes\r\n----------------------------------------------------------------------------------------------------\r\n\r\nLOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0]\r\n\r\n | Name | Type | Params\r\n------------------------------------------------------------------------\r\n0 | preprocessor | AudioToMelSpectrogramPreprocessor | 0\r\n1 | encoder | ConformerEncoder | 115 M\r\n2 | decoder | ConvASRDecoder | 66.2 K\r\n3 | loss | CTCLoss | 0\r\n4 | spec_augmentation | SpectrogramAugmentation | 0\r\n5 | _wer | WERBPE | 0\r\n6 | spec_augment | SpectrogramAugmentation | 0\r\n------------------------------------------------------------------------\r\n115 M Trainable params\r\n0 Non-trainable params\r\n115 M Total params\r\n460.710 Total estimated model params size (MB)\r\n2024-01-04 04:30:13.561892: I tensorflow/core/util/util.cc:169] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`.\r\nSLURM auto-requeueing enabled. Setting signal handlers.\r\n[W reducer.cpp:1256] Warning: find_unused_parameters=True was specified in DDP constructor, but did not find any unused parameters in the forward pass. This flag results in an extra traversal of the autograd graph every iteration, which can adversely affect performance. If your model indeed never has any unused parameters in the forward pass, consider turning this flag off. Note that this warning may be a false positive if your model has flow control causing later iterations to have unused parameters. (function operator())\r\n'''\r\n", "what is the script you used to finetune streaming model? and model config. \r\nCC: @VahidooX ", "I used the script \"examples/asr/speech_to_text_finetune.py\" and large topology of the config \"examples/asr/conf/conformer/cache_aware_streaming/conformer_ctc_bpe_streaming.yaml\" with 17 conformer layers. Please note that the initial pre-trained model is conformer ctc model with 17 layers (non-streaming).", "This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.", "This issue was closed because it has been inactive for 7 days since being marked as stale.", "> Sorry my mistake. There was no error as such and the online Conf-CTC checkpoint loaded correctly. On fine-tuning with conf-CTC streaming, it ran without an error but to my surprise the .nemo model generated still contains model.config which is non-streaming. If that is the case then how did some part of the streaming configs enabled training to proceed as usual in the first place? Please comment if this sounds like an error -\r\n> \r\n> ''' [NeMo W 2024-01-04 04:28:17 exp_manager:900] The checkpoint callback was told to monitor a validation value and trainer's max_steps was set to -1. Please ensure that max_steps will run for at least 1 epochs to ensure that checkpointing will not error out. [NeMo W 2024-01-04 04:28:19 modelPT:142] If you intend to do training or fine-tuning, please call the ModelPT.setup_training_data() method and provide a valid configuration file to setup the train data loader. Train config : manifest_filepath: ../../data/hindi_normalized/filtered_hindi_v1_manifest.json sample_rate: 16000 batch_size: 24 shuffle: true num_workers: 16 pin_memory: true use_start_end_token: false trim_silence: false max_duration: 30 min_duration: 0.1 is_tarred: false tarred_audio_filepaths: null shuffle_n: 2048 bucketing_strategy: synced_randomized bucketing_batch_size: 8\r\n> \r\n> ```\r\n> [NeMo W 2024-01-04 04:30:11 modelPT:486] Trainer wasn't specified in model constructor. Make sure that you really wanted it.\r\n> ```\r\n> \r\n> ## [NeMo W 2024-01-04 04:30:11 lr_scheduler:890] Neither `max_steps` nor `iters_per_batch` were provided to `optim.sched`, cannot compute effective `max_steps` !\r\n> Scheduler will not be instantiated !\r\n> Initializing distributed: GLOBAL_RANK: 0, MEMBER: 1/1\r\n> ## distributed_backend=nccl\r\n> All distributed processes registered. Starting with 1 processes\r\n> LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0]\r\n> \r\n> ## | Name | Type | Params\r\n> ## 0 | preprocessor | AudioToMelSpectrogramPreprocessor | 0\r\n> 1 | encoder | ConformerEncoder | 115 M\r\n> 2 | decoder | ConvASRDecoder | 66.2 K\r\n> 3 | loss | CTCLoss | 0\r\n> 4 | spec_augmentation | SpectrogramAugmentation | 0\r\n> 5 | _wer | WERBPE | 0\r\n> 6 | spec_augment | SpectrogramAugmentation | 0\r\n> 115 M Trainable params 0 Non-trainable params 115 M Total params 460.710 Total estimated model params size (MB) 2024-01-04 04:30:13.561892: I tensorflow/core/util/util.cc:169] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`. SLURM auto-requeueing enabled. Setting signal handlers. [W reducer.cpp:1256] Warning: find_unused_parameters=True was specified in DDP constructor, but did not find any unused parameters in the forward pass. This flag results in an extra traversal of the autograd graph every iteration, which can adversely affect performance. If your model indeed never has any unused parameters in the forward pass, consider turning this flag off. Note that this warning may be a false positive if your model has flow control causing later iterations to have unused parameters. (function operator()) '''\r\n\r\nIs there any upadate on this? " ]

[]

[]

[ "> Ooh so the issue was missing dependencies and not the torchaudio code itself ? Won't we need to install the dependencies anyway inside container?\r\n\r\n@titu1994 We install the dependencies when building the container https://github.com/NVIDIA/NeMo/blob/main/Dockerfile#L34" ]

[]

[]

[]

[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]

[]

[]

[ { "id": 1923495043, "node_id": "MDU6TGFiZWwxOTIzNDk1MDQz", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/core", "name": "core", "color": "f25e3a", "default": false, "description": "Changes to NeMo Core" }, { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[ "jenkins", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]

[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[ "@titu1994 could you also please help to review this? Short one, focusing on UX", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "@titu1994 could you have another look?" ]

[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]

[]

[]

[ { "id": 4556669155, "node_id": "LA_kwDOC_bI7s8AAAABD5lA4w", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/cherry-pick", "name": "cherry-pick", "color": "ededed", "default": false, "description": null } ]

[]

[]

[]

[]

[]

[ { "id": 4418253970, "node_id": "LA_kwDOC_bI7s8AAAABB1k0kg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/TTS", "name": "TTS", "color": "49AF28", "default": false, "description": "" } ]

[]

[ "jenkins", "jenkins", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "jenkins" ]

[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "Created a PR to release branch: https://github.com/NVIDIA/NeMo/pull/8354/files" ]

[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[ "jenkins", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale." ]

[ { "id": 4585431311, "node_id": "LA_kwDOC_bI7s8AAAABEVAhDw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/stale", "name": "stale", "color": "ededed", "default": false, "description": null }, { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" }, { "id": 6876332615, "node_id": "LA_kwDOC_bI7s8AAAABmdyCRw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/Run%20CICD", "name": "Run CICD", "color": "fef2c0", "default": false, "description": "" } ]

[]

[ "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "This PR was closed because it has been inactive for 7 days since being marked as stale.", "@Davood-M I am having the same error as input is not long enough in my SFT experiment. Do you know if its fixed in latest version?", "jenkins", "Hi @Davood-M, if your entire input length (template + placeholder strings) > sequence length, then we'll need to do the truncation. We truncate only the `truncation_field` part in your placeholder strings. If the `truncation_field` is not long enough to truncate, then we simply make this field to be empty. This situation may happen if the length of your template > the length of your placeholder strings. I think the solutions are either change your template or increase sequence length.", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "HI,\r\nWhat is the latest non-dev container that does not have this issue? I'm guessing this is a recent issue", "This error can be resolved by either 1. setting the truncation_field=\"output\" or 2. setting truncation_field=None/null. ", "Does that resolve the `write_predictions_to_file` bug?", "Hi @arendu\r\nI tried the solution you suggested but get a new error\r\n\r\n```\r\n11: Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.\r\n 9: Traceback (most recent call last):\r\n 9: File \"/opt/NeMo/examples/nlp/language_modeling/tuning/megatron_gpt_generate.py\", line 164, in main\r\n 9: trainer.test(model)\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/trainer.py\", line 754, in test\r\n 9: return call._call_and_handle_interrupt(\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/call.py\", line 43, in _call_and_handle_interrupt\r\n 9: return trainer.strategy.launcher.launch(trainer_fn, *args, trainer=trainer, **kwargs)\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/strategies/launchers/subprocess_script.py\", line 105, in launch\r\n 9: return function(*args, **kwargs)\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/trainer.py\", line 794, in _test_impl\r\n 9: results = self._run(model, ckpt_path=ckpt_path)\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/trainer.py\", line 987, in _run\r\n 9: results = self._run_stage()\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/trainer.py\", line 1026, in _run_stage\r\n 9: return self._evaluation_loop.run()\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/loops/utilities.py\", line 182, in _decorator\r\n 9: return loop_run(self, *args, **kwargs)\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/loops/evaluation_loop.py\", line 135, in run\r\n 9: self._evaluation_step(batch, batch_idx, dataloader_idx, dataloader_iter)\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/loops/evaluation_loop.py\", line 396, in _evaluation_step\r\n 9: output = call._call_strategy_hook(trainer, hook_name, *step_args)\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/call.py\", line 309, in _call_strategy_hook\r\n 9: output = fn(*args, **kwargs)\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/strategies/strategy.py\", line 425, in test_step\r\n 9: return self.lightning_module.test_step(*args, **kwargs)\r\n 9: File \"/opt/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_sft_model.py\", line 434, in test_step\r\n 9: return self.inference_step(dataloader_iter, 'test')\r\n 9: File \"/opt/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_sft_model.py\", line 437, in inference_step\r\n 9: batch, batch_idx, dataloader_idx = next(dataloader_iter)\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/loops/fetchers.py\", line 207, in __next__\r\n 9: batch, batch_idx, dataloader_idx = super(_DataLoaderIterDataFetcher, fetcher).__next__()\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/loops/fetchers.py\", line 60, in __next__\r\n 9: batch = next(self.iterator)\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/utilities/combined_loader.py\", line 341, in __next__\r\n 9: out = next(self._iterator)\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/pytorch_lightning/utilities/combined_loader.py\", line 142, in __next__\r\n 9: out = next(self.iterators[0])\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/torch/utils/data/dataloader.py\", line 631, in __next__\r\n 9: data = self._next_data()\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/torch/utils/data/dataloader.py\", line 675, in _next_data\r\n 9: data = self._dataset_fetcher.fetch(index) # may raise StopIteration\r\n 9: File \"/usr/local/lib/python3.10/dist-packages/torch/utils/data/_utils/fetch.py\", line 54, in fetch\r\n 9: return self.collate_fn(data)\r\n 9: File \"/opt/NeMo/nemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py\", line 479, in collate_fn\r\n 9: contexts = torch.LongTensor(self._collate_item(contexts, max_length=max_length, pad_id=self.tokenizer.eos_id))\r\n 9: ValueError: expected sequence of length 4096 at dim 1 (got 4512)\r\n 9: \r\n```", "Hi @aditya-malte, in your setup what values are your `truncation_field` and `prompt_template`?" ]

[ { "id": 4811884691, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ikw", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/ASR", "name": "ASR", "color": "F3B33E", "default": false, "description": "" } ]

[]

[ "Thanks !" ]

[ { "id": 4811886210, "node_id": "LA_kwDOC_bI7s8AAAABHs-Ogg", "url": "https://api.github.com/repos/NVIDIA/NeMo/labels/NLP", "name": "NLP", "color": "CBF09A", "default": false, "description": "" } ]

[]

[ "jenkins", "This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.", "jenkins", "jenkins" ]