text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
@iSazonov then delete ALL THE BUILT-IN ALIASES. I won't like it, but I can get behind it. This "one this month", "one the day before GA", "one six months ago" -- it's ridiculous. | [
1
] |
^kids such a loser btw | [
1
] |
Damn. It was unnessessary difficult to parametrize environment variables that are passed down to ECS task definition. But thanks to https://github.com/Eiara/terraform_container_definitions I managed to do it. | [
1
] |
i would have guessed that this would show up right next to define config spi flash winbond that s in exynos common h should that define move here or should this define move there | [
0
] |
ok talked on irc and we do not a great solution for this perhaps if conductor start starving workers we need to tune up the workers pool size value | [
0
] |
what the im following the guide and i can not do anything if meson sucks wtf | [
1
] |
somehow i managed to miss the rest of this thread i wonder if i fat fingered the mute button in my reader anyway i tend to agree with you maybe this check is not worth adding | [
0
] |
please leave the echo summary in stack sh | [
0
] |
Lame, no carrot nose or top hat. | [
1
] |
remove android | [
0
] |
LGTM, merging. Checked that it doesn't cause ridiculous amounts of warnings in Scipy, which silences a lot of warnings. So should be OK for other libs as well. | [
1
] |
the commas at the end of these lines should be removed | [
0
] |
Also the spellbook was stupid because look at this shit | [
1
] |
i have a couple of concerns here the most minor one is that this now forces us to use this decorator only on instance or class methods is there anywhere where this is not the case the second concern is that if i recall correctly the get context from function and args function was created because the decorator was used on some methods where context had to be searched for which argues that for those methods it is not the first non self argument to the method this means that for those methods this could result in a notify still containing the context but missing the first argument to the method which may be rather useful also it is worth pointing out that there are no other consumers of get context from function and args it is used in nova openstack common notifier api py but the version used is of course from nova openstack common context py given that this patch should probably also remove the function assuming my two concerns above are not a factor | [
0
] |
This statement is now ridiculous. Of course the user has Python | [
1
] |
that's a cute and disgusting hack. maybe at least document it? | [
1
] |
This should be in line 2501 not here, not sure if you mannully placed it or if DM messed it up | [
1
] |
should add money goggles that let you see the current market value of shit when you examine them | [
1
] |
This review got fucked up, probably because of a new commit while sending it. Ignore it. | [
1
] |
you need pass wait handle into cfn singal sh | [
0
] |
you fukken wat mate why are you defining the lens part in AMMO CASING | [
1
] |
yes another story in that case conntrack is useful because sg rules are stateful | [
0
] |
brian you are right let me remove the get metric names and get metrics method | [
0
] |
it is safer to just say no do we need want to attempt this with the migration tool a user can migrate his sof data adding this method seems like an exploit waiting to happen in my opinion | [
0
] |
this was a move i am trying to isolate this code from the json impl so that i can kill it | [
0
] |
should probably put body n here also instead of below | [
0
] |
ya i do not like being a scheduler lol imho this sort of goes back to michaels blogs post question about why did not they just make this yield from a comment or why did not python just adopt and embrace greenlet s and say have a interpreter option that would use greenthreads vs real threads transparently since in the worst case u are placing yield from on every line of code especially in i o heavy applications and at that point it makes u wonder what the heck is going on with python as a language | [
0
] |
nit picky but i would probably have lined up conf with kwargs above seems odd where it is | [
0
] |
should be retry marker | [
0
] |
this is a useless comment remove | [
0
] |
itym owned by parent pid this commit | [
0
] |
I second the vote for "make it work somehow". Telling people they have to manually build every project separately is ridiculous. People expect to just build a solution and for the build engine to work. | [
1
] |
i have changed that vim fools me done | [
0
] |
please delete at least one of these configs | [
0
] |
this should be vlan id ml db network segments segmentation id | [
0
] |
there are a bunch of other places you are iterating through this list looking for a specific entry see e g in add pidstatistics below make a helper that returns the entry for a given pid or null if none exists then pidmatch is a trivial return findpid ppid null | [
0
] |
hierophant code is a mess to be honest and i don't really want to touch it all that much because i'm afraid i'll totally fuck it up but i'll try that | [
1
] |
this is going to break the shit out of any scaled mobs or items, we should either accept that and continue or not do it for mobs Most important for dwarfism/giant mobs | [
1
] |
servod is usually killed by keyboardinterrupt and since these processes are daemonic they should be killed when servod is they are intended to run as long as servod is running | [
0
] |
this class is now useless removed in a recent patch | [
0
] |
this example is for ovs dpdk can you also add an exmaple for plain ovs case | [
0
] |
only the root disk is wipe by wipe disk metadata | [
0
] |
no need for semicolon at the end | [
0
] |
probably a dumb question but is limits a feature of all apis to where it should be in the base | [
0
] |
Ah, yes, this is referring to the thumb prologs thing, which seems like a disgusting hack. Now, it turned out in the end that it worked, and I can't think of a better way, so I guess I'll just take that out? If you have alternatives that are more generic that would be cool. | [
1
] |
particularly for the html does it make sense here to describe where the docs will be spit out to | [
0
] |
The most nonsense/bogus framework is ionic frameworks. It is simply wasting your time. | [
1
] |
Oh crap. I hate shellscript programming so much. | [
1
] |
resourceVersion semantics would be wacky | [
1
] |
You're a freaking mvp. Only problem is that says owner.current.handle_devil is an undefined proc, but I think I can figure it out myself. Unless you by chance know exactly what to do, don't bother, | [
1
] |
The fuck, no you cant just block all other var edits | [
1
] |
is it suppose to be param req get param | [
0
] |
This is completely unacceptable! The LEARN MORE button on the hero section of a website is the most important link on the entire website! How is gods name could they not make this link dynamic. It's just ridiculous! | [
1
] |
a stupid decorator i like such notes btw this decorator is located at l of this module so you can change it a bit | [
0
] |
why add mocked out sleep here | [
0
] |
remove comment | [
0
] |
let s use flavors format flavor id | [
0
] |
i am only stupid half the time p | [
0
] |
i see why you did it this way in just a straight removal of the tuskar stuff but it looks goofy outside of that context can we just use template name instead of this local var | [
0
] |
well that is ugly but i suppose it works for now this db call needs to move into the compute conductor | [
0
] |
Not this shit again... | [
1
] |
these java util calendar objects seem somewhat pointless to me you could just use icu j calendars throughout | [
0
] |
iface transport name | [
0
] |
expect eq kill errnomessage kill but i think we d generally prefer to get rid of this and line altogether and let the child process die naturally when it recognizes that the parent no longer cares about it see below | [
0
] |
must be executed | [
0
] |
are you sure that you need slaves | [
0
] |
Crap.. Which version of AS? | [
1
] |
if this is only meant for crap why do not you just use static assert we have switched over from our own equivalent of this in art bionic and libcore | [
0
] |
this is unrecommended because of things like https://go.dev/play/p/8u0R9_rA-zJ | [
1
] |
http client not acceptable | [
0
] |
It's ok, they can RIP next to `mesege` and various other levels of `shit?` and `ALL IS GOOD` that early contributors will remember fondly into the ages :P | [
1
] |
i do not believe those kind of nits are useful at all | [
0
] |
FUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUUCKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKK | [
1
] |
this needs a linewrap at removed | [
0
] |
Yea, because people will understand the code themselves and not copy shitcode from another places. | [
1
] |
useless line | [
0
] |
Damn. I am confused. This indeed looks wrong but I passed the tests... | [
1
] |
This PR is being closed as it is horrifically out-of-sync with `master` and `dev`, and i lack the brain go-go juice to make this work. Not to mention this feature is so low priority its a funny | [
1
] |
flimsy as hell. try scrolling while you are fetching more. it'll replace existing panels. | [
1
] |
yeah, macros are ugly and give really weird error codes since the preprocessor fills them in before any error is thrown, so it's best to get rid of them! | [
1
] |
please use mock patch object like mock patch object vmops vmwarevmops sized image exists return value false mock patch object vmops vmwarevmops extend virtual disk mock patch object vm util copy virtual disk here and below | [
0
] |
this might be cleaner as a lambda preexec fn lambda subprocess setup preexec fn oh but silly pep will whinge at you about using lambda for their purpose we should kill that rule globally it is harmful | [
0
] |
I am fucking retarded | [
1
] |
It would have to be written as `s.Key.IsHit() && (s.Key.IsBasic() || s.Key.IsTick())` since "tick" judgements aren't "basic" | [
1
] |
Bingo, I just found the remaining bastard ! sRGB-primary-blue-continuous_06 | [
1
] |
kwargs is a dict | [
0
] |
a nitpick why do not you simply return renderstate here imho the unique ptr is an impl detail also returning unique ptr is dangerous it s too easy to gut the glwindow object by a mistake | [
0
] |
pete just a nit please end sentences with a | [
0
] |
this method is useless you can move the code into declare topic consumer | [
0
] |
The "PHP_VERSION_ID" fix is just ridiculous as some of symfony developers (sorry, no mean to offend anybody). | [
1
] |
iiuc having the raw conversion between the hnotequal and hselect will force materialization of the hnotequal please reorder | [
0
] |
that s just you passing foo unquoted | [
0
] |
shame on me that i have missed this earlier i think you need to bump the version to | [
0
] |
// because telaporting papers are silly | [
1
] |
i would suggest changing pkill g service pid to kill service pid because instant killing of parent and child processes with sigterm when a parent is supposed to stop children itself does not seem a good thing to do and leads to failures in grenade see | [
0
] |
checkpatch pl failure since this is a cherry pick we have to ignore this | [
0
] |
Oh fuck, I didn't look at this. | [
1
] |
yes you are correct removed the help block from the child templates | [
0
] |
0 shits given there's no valid reason to counter those weights. | [
1
] |
those initialization should be delayed until instance initialization | [
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.