issue_owner_repo
listlengths 2
2
| issue_body
stringlengths 0
261k
⌀ | issue_title
stringlengths 1
925
| issue_comments_url
stringlengths 56
81
| issue_comments_count
int64 0
2.5k
| issue_created_at
stringlengths 20
20
| issue_updated_at
stringlengths 20
20
| issue_html_url
stringlengths 37
62
| issue_github_id
int64 387k
2.46B
| issue_number
int64 1
127k
|
|---|---|---|---|---|---|---|---|---|---|
[
"Piwigo",
"Piwigo"
] |
When an album is moved, the number of photos in sub-albums badge is not updated.
|
[Album Manager] Bug on "nb_sub_photos" badges when moving an album
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2120/comments
| 0 |
2024-02-19T15:40:20Z
|
2024-02-19T16:07:04Z
|
https://github.com/Piwigo/Piwigo/issues/2120
| 2,142,660,255 | 2,120 |
[
"Piwigo",
"Piwigo"
] |
In Album Manager, when you change the name of an album and then move it, the album reverts to its old name.
|
[Album Manager] Bug when moving an album after changing its name
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2119/comments
| 0 |
2024-02-19T15:34:16Z
|
2024-02-19T16:07:03Z
|
https://github.com/Piwigo/Piwigo/issues/2119
| 2,142,646,856 | 2,119 |
[
"Piwigo",
"Piwigo"
] |
Following https://github.com/Piwigo/Piwigo/commit/fa3625a607399de43a8fa9c23a887915ea0aeac3 for #223 the `quality=70` is not enough for every case. Let's add a new advanced configuration setting.
|
ability to configure animated webP compression for resize
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2118/comments
| 0 |
2024-02-19T14:05:41Z
|
2024-02-19T16:17:42Z
|
https://github.com/Piwigo/Piwigo/issues/2118
| 2,142,452,963 | 2,118 |
[
"Piwigo",
"Piwigo"
] |
When arriving on the history page in the search section from a picture, the datepicker changes its value twice and therefore triggers its OnChange event twice, the first of which launches an ajax request with the wrong parameter (end: 1899-12-31).
|
Double request due to datepicker on history page
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2117/comments
| 0 |
2024-02-19T11:50:01Z
|
2024-02-19T11:53:40Z
|
https://github.com/Piwigo/Piwigo/issues/2117
| 2,142,188,786 | 2,117 |
[
"Piwigo",
"Piwigo"
] |
When all the images in the piwigo_images table have an md5sum value and the pwg.images.setMd5sum API is called, a JSONDecodeError is thrown. Issue is with the call to get_photos_no_md5sum():
https://github.com/Piwigo/Piwigo/blob/562170528c63a2318d153a08ec4847684fa71784/include/ws_functions/pwg.images.php#L2596
I have a fix in my local repo that wraps it in an if statement similar to how this is handled on the admin UI that I'll submit after I figure out pull requests:
https://github.com/Piwigo/Piwigo/blob/562170528c63a2318d153a08ec4847684fa71784/admin.php#L290-L295
Sample Code:
```
from piwigo import Piwigo
mysite = Piwigo('http://localhost')
mysite.pwg.session.login(username="______", password="__________")
pwg_token = mysite.pwg.session.getStatus()['pwg_token']
response = mysite.pwg.images.setMd5sum(block_size="20", pwg_token=pwg_token)
print(response)
```
Output:
```
nathanz@piwigo-01:~$ python3 piwigo_api_test.py
Traceback (most recent call last):
File "/home/nathanz/.local/lib/python3.10/site-packages/piwigo/ws.py", line 124, in __call__
result = r.json()
File "/usr/lib/python3/dist-packages/requests/models.py", line 900, in json
return complexjson.loads(self.text, **kwargs)
File "/usr/lib/python3.10/json/__init__.py", line 346, in loads
return _default_decoder.decode(s)
File "/usr/lib/python3.10/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python3.10/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/nathanz/piwigo_api_test.py", line 8, in <module>
response = mysite.pwg.images.setMd5sum(block_size="20", pwg_token=pwg_token)
File "/home/nathanz/.local/lib/python3.10/site-packages/piwigo/ws.py", line 96, in checking
return fn(self, **kw)
File "/home/nathanz/.local/lib/python3.10/site-packages/piwigo/ws.py", line 135, in __call__
raise WsErrorException(r.text)
piwigo.ws.WsErrorException: <br />
<b>Fatal error</b>: Uncaught mysqli_sql_exception: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 3 in /var/www/html/include/dblayer/functions_mysqli.inc.php:132
Stack trace:
#0 /var/www/html/include/dblayer/functions_mysqli.inc.php(132): mysqli->query()
#1 /var/www/html/include/dblayer/functions_mysqli.inc.php(888): pwg_query()
#2 /var/www/html/admin/include/functions.php(3294): query2array()
#3 /var/www/html/include/ws_functions/pwg.images.php(2602): add_md5sum()
#4 /var/www/html/include/ws_core.inc.php(600): ws_images_setMd5sum()
#5 /var/www/html/include/ws_protocols/rest_handler.php(41): PwgServer->invoke()
#6 /var/www/html/include/ws_core.inc.php(281): PwgRestRequestHandler->handleRequest()
#7 /var/www/html/ws.php(22): PwgServer->run()
#8 {main}
thrown in <b>/var/www/html/include/dblayer/functions_mysqli.inc.php</b> on line <b>132</b><br />
```
|
JSONDecodeError when calling pwg.images.setMd5sum API
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2114/comments
| 0 |
2024-02-10T02:48:57Z
|
2024-02-10T02:48:57Z
|
https://github.com/Piwigo/Piwigo/issues/2114
| 2,128,060,694 | 2,114 |
[
"Piwigo",
"Piwigo"
] |
If we have multiple lines of text the icon is no longer aligned to the center
|
Admin messages, icon and text misaligned
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2113/comments
| 0 |
2024-02-09T10:21:38Z
|
2024-02-09T10:23:36Z
|
https://github.com/Piwigo/Piwigo/issues/2113
| 2,126,847,029 | 2,113 |
[
"Piwigo",
"Piwigo"
] |
Following #2091 we have received a related request on forum https://piwigo.org/forum/viewtopic.php?pid=189156#p189156 asking to keep `#` in search by word. I agree and consider other characters : `#^~$`
|
[search] more allowed characters in search by words
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2112/comments
| 0 |
2024-02-06T16:57:28Z
|
2024-02-07T07:55:33Z
|
https://github.com/Piwigo/Piwigo/issues/2112
| 2,121,273,820 | 2,112 |
[
"Piwigo",
"Piwigo"
] |
Tested with Piwigo 14.1 and 14.2
When a photo already present on the server is re-uploaded, the server crashes with the following trace log:
```
2024/02/03 16:31:46 [error] 302#302: *399 FastCGI sent in stderr: "PHP message: PHP Fatal error:
Uncaught mysqli_sql_exception: Duplicate entry '66-2' for key 'PRIMARY' in
include/dblayer/functions_mysqli.inc.php:132
Stack trace:
#0 include/dblayer/functions_mysqli.inc.php(132): mysqli->query()
#1 include/dblayer/functions_mysqli.inc.php(550): pwg_query()
#2 admin/include/functions.php(1914): mass_inserts()
#3 admin/include/functions_upload.inc.php(444): fill_lounge()
#4 admin/include/functions_upload.inc.php(179): add_uploaded_file_add_to_categories()
#5 include/ws_functions/pwg.images.php(1852): add_uploaded_file()
#6 include/ws_core.inc.php(600): ws_images_uploadAsync()
#7 include/ws_protocols/rest_handler.php(41): PwgServer->invoke()
#8 include/ws_core.inc.php(281): PwgRestRequestHandler->handleRequest()
#9 ws.php(22): PwgServer->run()
#10 {main}
thrown in include/dbl" while reading response header from upstream, client: ###:###:###:###,
server: _, request: "POST /ws.php?format=json&method=pwg.images.uploadAsync HTTP/1.1",
upstream: "fastcgi://127.0.0.1:####", host: "###:###:###:###:#####"
```
The server returns the error 500 to the method `pwg.images.uploadAsync`, as if an error was encountered during the transfer. The third party app concludes that the upload fails and might be repeated.
Ideally, the server should return errors with codes different than a generic error 500 when a transfer fails, for example somthing like:
- 530 "error during buffer directory creation"
- 531 "MD5 checksum chunk file mismatched"
- 532 "error while creating merged…"
- 533 "error while locking merged…"
- 534 "error while merging chunk…"
This would prevent the third party app to allow re-uploading.
|
Crashes when uploading a photo that is already present
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2110/comments
| 0 |
2024-02-04T17:04:45Z
|
2024-04-11T10:27:07Z
|
https://github.com/Piwigo/Piwigo/issues/2110
| 2,117,205,665 | 2,110 |
[
"Piwigo",
"Piwigo"
] |
When used behind Haproxy, piwigo logs haproxy ip address as visitors source ip address instead of visitors real ip address. This was described in piwigo forum by docofchaos in september 2016. Docofchaos also proposed a fix :
edit functions.inc.php in /usr/local/www/apache24/includes:
comment $ip = $_SERVER['REMOTE_ADDR'];
and insert
if (isset($_SERVER['HTTP_X_FORWARDED_FOR'])){
$ip = $_SERVER['HTTP_X_FORWARDED_FOR'];
} else {
$ip = $_SERVER['REMOTE_ADDR'];
}
This fixed the problem for me in piwigo 14.2.0 (freebsd implementation)
|
piwigo "historique" records haproxy ip address instead of visitors source ip address
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2109/comments
| 0 |
2024-02-03T15:03:08Z
|
2024-02-03T15:03:08Z
|
https://github.com/Piwigo/Piwigo/issues/2109
| 2,116,522,641 | 2,109 |
[
"Piwigo",
"Piwigo"
] |
Fresh install, using unraid docker app. Keep getting this error when i try to sync using the VideoJS plugin.
Warning: Undefined array key "sync_binaries" in /config/www/_data/templates_c/p6jhns^7c8995f4399ea0ff60aa67cedf8918ee7f0ad387_0.file.admin_sync.tpl.php on line 235
Warning: Attempt to read property "value" on null in /config/www/_data/templates_c/p6jhns^7c8995f4399ea0ff60aa67cedf8918ee7f0ad387_0.file.admin_sync.tpl.php on line 235
|
Warning: Undefined array key "sync_binaries"
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2108/comments
| 0 |
2024-02-03T02:35:47Z
|
2024-02-03T02:35:47Z
|
https://github.com/Piwigo/Piwigo/issues/2108
| 2,116,132,373 | 2,108 |
[
"Piwigo",
"Piwigo"
] |
Previously we only had 'details 1' in the search details. So we've enhanced the api and now for the search history we have the search details (Search by words, tags, albums, date posted, author, added by and file types).
|
[History search] lines concerning gallery searches have a 'detail 1'
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2106/comments
| 0 |
2024-02-02T10:31:27Z
|
2024-02-19T16:13:07Z
|
https://github.com/Piwigo/Piwigo/issues/2106
| 2,114,607,323 | 2,106 |
[
"Piwigo",
"Piwigo"
] |
Replace the tree icon with the house icon and make the icon non-clickable.
https://piwigo.org/forum/viewtopic.php?id=33356
|
[14.x album editor] confusion between breadcrumbs and action icons
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2105/comments
| 0 |
2024-02-02T10:08:24Z
|
2024-02-02T10:11:08Z
|
https://github.com/Piwigo/Piwigo/issues/2105
| 2,114,560,366 | 2,105 |
[
"Piwigo",
"Piwigo"
] |
In Piwigo 14.x and its new album editor, I see an example of very blurry album thumbnail.
<img width="807" alt="Screenshot 2024-02-02 at 11 00 41" src="https://github.com/Piwigo/Piwigo/assets/9326959/58528623-c000-4477-8bf3-3f10f441877f">
After investigation, I've found that it's an upscale of the thumbnail photo size. That's because sizes S, XS and XXS are disabled on this Piwigo.
|
[14.x album editor] blurry album thumbnail
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2104/comments
| 0 |
2024-02-02T10:01:47Z
|
2024-02-02T10:05:40Z
|
https://github.com/Piwigo/Piwigo/issues/2104
| 2,114,547,006 | 2,104 |
[
"Piwigo",
"Piwigo"
] |
The description on an album's edit page opens and closes its modal when ESC is pressed
|
[album editor] ESC opens the magnified description box
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2103/comments
| 0 |
2024-02-02T09:37:12Z
|
2024-02-02T09:40:02Z
|
https://github.com/Piwigo/Piwigo/issues/2103
| 2,114,501,776 | 2,103 |
[
"Piwigo",
"Piwigo"
] |
Search engine, 'album' filter :
- select an album, then remove it by clicking on the cross
- choose an album again; instead of closing the album choice modal, stay on it;
- add another album, and close the modal
- click on the cross to remove one of the selected albums
=> clicking on the cross does nothing, it doesn't work. You can click on Empty, however.
|
[search] Unable to click on x when several albums selected
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2102/comments
| 0 |
2024-02-02T09:14:58Z
|
2024-02-02T09:17:50Z
|
https://github.com/Piwigo/Piwigo/issues/2102
| 2,114,459,466 | 2,102 |
[
"Piwigo",
"Piwigo"
] |
The "search by file extension" filter in the new search UI only takes into account the main file. Not multiple formats. Even if not many Piwigo use this advanced feature, for those who use it they obviously want it to be taken into account.
|
[search] include multiple format for file extension
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2101/comments
| 0 |
2024-01-30T10:01:13Z
|
2024-07-31T15:16:07Z
|
https://github.com/Piwigo/Piwigo/issues/2101
| 2,107,422,459 | 2,101 |
[
"Piwigo",
"Piwigo"
] |
Unable to batch upload files to piwigo hosted site via Remote-Sync. Errors given on all files are
15:34:23.044 [Thread-4] INFO o.p.r.api.sync.SyncDirectoryWalker - Uploading Dunkers_0053.jpeg in album with ID null
15:34:23.044 [Thread-4] ERROR o.p.r.api.sync.ConnectedWalker - Cannot upload an image without an album. Please move the image in a subfolder.
Additionally unable to upload via FTP as the documentation is out of date (Photos>Add>FTP+Sync does not exist anymore)
Version: 14.1.0
|
Unable to batch upload
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2100/comments
| 5 |
2024-01-29T20:44:01Z
|
2024-01-31T14:05:13Z
|
https://github.com/Piwigo/Piwigo/issues/2100
| 2,106,387,015 | 2,100 |
[
"Piwigo",
"Piwigo"
] |
I have an album with a set of jpg photos. I want to add the corresponding raw with the web form.
However, the tool tells me that there are several photos with the same name. This is true for my entire photo library but not for this album only.
I note in fact that it is not necessary/possible to select the album for adding multiple formats via the web form. I think this option is missing because it is impossible to have unique photo names since I am using a camera with a name format like IMG_XXXX.JPG/CR2 (with X in 0 and 9). In fact, every 9999, the counter returns to 0 and generates a name that already exists in the photo library
Did I miss a subtlety to use the tool to meet my needs?
Do you have a workaround without having to go through each photo individually?
|
Unable to add multiple formats with the same name but in different albums
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2099/comments
| 0 |
2024-01-28T23:58:42Z
|
2024-01-29T12:55:05Z
|
https://github.com/Piwigo/Piwigo/issues/2099
| 2,104,409,588 | 2,099 |
[
"Piwigo",
"Piwigo"
] |
Leaving this issue here as the Piwigo Android looks dead on here, but basically, when using the Piwigo NG app, it prompts for which folder to use, but doesn't download any images. Screenshots below.
Select the photo, and press Download Photo.
Choose a folder, and press, use folder.
Accept the permissions to use the folder.
Then the prompt goes away, but when looking in that same folder using a file exploring so, there is nothing available.
|
Download photo on Android Piwigo NG does nothing
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2098/comments
| 0 |
2024-01-25T18:51:20Z
|
2024-01-25T18:51:20Z
|
https://github.com/Piwigo/Piwigo/issues/2098
| 2,100,979,990 | 2,098 |
[
"Piwigo",
"Piwigo"
] |
<img width="514" alt="2024-01-25_09h09_08" src="https://github.com/Piwigo/Piwigo/assets/2781135/9b4bcd81-0343-4991-8dbe-847aa70b103c">
|
Open Streatmap +/- overapping Album list
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2097/comments
| 0 |
2024-01-25T08:15:19Z
|
2024-01-25T08:15:19Z
|
https://github.com/Piwigo/Piwigo/issues/2097
| 2,099,818,064 | 2,097 |
[
"Piwigo",
"Piwigo"
] |
The new search engine (14.x) has this list of filters by default : allwords, albums, tags, author. If you remove "author" and add "posted_date", you automatically come back to the default list on next search.
It would be better to keep in memory what each user likes better as search filters.
|
[search] save list of filters
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2096/comments
| 0 |
2024-01-24T16:19:03Z
|
2024-01-24T16:27:11Z
|
https://github.com/Piwigo/Piwigo/issues/2096
| 2,098,621,871 | 2,096 |
[
"Piwigo",
"Piwigo"
] |
In the Batch Manager, the action is "Who can see these photos?" but it's not really obvious it's related to user privacy level. Many users are confused. Make it more obvious.
|
[UX] make obvious "Who can see this photo?" is related to privacy level
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2095/comments
| 1 |
2024-01-24T14:07:25Z
|
2024-01-24T14:10:09Z
|
https://github.com/Piwigo/Piwigo/issues/2095
| 2,098,347,706 | 2,095 |
[
"Piwigo",
"Piwigo"
] |
<img width="546" alt="Screenshot 2024-01-24 at 14 16 43" src="https://github.com/Piwigo/Piwigo/assets/9326959/e62a76ea-845b-43e3-baf3-23576ef71117">
We to see more than 5 lines. That's the filter by tags. Same for authors.
|
[search 14.x] selectize listbox is too short
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2094/comments
| 0 |
2024-01-24T13:18:23Z
|
2024-01-24T13:20:24Z
|
https://github.com/Piwigo/Piwigo/issues/2094
| 2,098,251,413 | 2,094 |
[
"Piwigo",
"Piwigo"
] |
See https://piwigo.org/forum/viewtopic.php?id=33403
During import or synchronization, for properties like `name` or `author` or `tags` we need to replace new lines `\r\n` or `\n` with a simple space character.
|
remove new line during IPTC metadata import/sync
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2093/comments
| 0 |
2024-01-22T15:15:14Z
|
2024-01-29T18:27:55Z
|
https://github.com/Piwigo/Piwigo/issues/2093
| 2,094,144,933 | 2,093 |
[
"Piwigo",
"Piwigo"
] |
After saving the photo modification, when I click to view the photo in the Gallery, I'm redirected to the 1st album in alphabetical order instead of the album I was consulting (if the photo is present in several albums). After editing a photo, it makes more sense to return to the original page. See French forum : https://fr.piwigo.org/forum/viewtopic.php?pid=238834#p238834
|
Not coming back to current album after photo editing
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2092/comments
| 0 |
2024-01-20T10:07:07Z
|
2024-01-20T10:07:07Z
|
https://github.com/Piwigo/Piwigo/issues/2092
| 2,091,995,162 | 2,092 |
[
"Piwigo",
"Piwigo"
] |
I use numeric codes in album descriptions to identify specific datasets. They look like that:
10001567_000_001
If I search for this string the new search system removes the underscores resulting in a large number and expectedly the search doesn't find anything.
The same behaviour occurs even if I wrap the whole string in quotes , which is surprising because the search should look for the exact string (at least according to the current search instructions on Piwigo).
|
Unwanted string normalization in the new search system
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2091/comments
| 3 |
2024-01-19T12:06:03Z
|
2024-02-06T16:55:00Z
|
https://github.com/Piwigo/Piwigo/issues/2091
| 2,090,418,240 | 2,091 |
[
"Piwigo",
"Piwigo"
] |
Hello,
I'm using the Bootstrap Darkroom theme for my [gallery](https://sandbox.seboto.de/). I read about the new search engine which was introduced with version 14 and I was wondering why it is not available on my page. I tried to switch to the **Modus** theme and then it appears, but I'm not able to make it visible using the **Bootstrap Darkroom** theme.
Any ideas? Here is my setup and config:
```
Piwigo: 14.1.0
Installiert auf 4 Januar 2015, vor 9 Jahre 1 Woche 6 Tage
Betriebssystem: Linux
PHP: 7.4.33
MySQL: 5.5.5-10.6.5-MariaDB-1:10.6.5+maria~focal
Grafikbibliothek: GD 2.3.0
Größe des Cache 301.08 Mo berechnet vor 1 Woche
Plugins:
Additional Pages
Admin Tools
Advanced Menu Manager
Batch Downloader
Batch Manager Prefilters
Batch Manager, Description
BBCode Bar
Charlie's content 3.2.4a
Comments Blacklist
Comments on Albums
Community
Contact Form
Cookie Consent
Crypto Captcha
Download by Size
Download Counter
Evil_Blog
Extended Description
Force HTTPS
Grum Plugins Classes.3
GuestBook
Header Manager
Language Switch
LocalFiles Editor
Manage Properties Photos
OpenStreetMap
Perso About
Perso Footer
Personal Favicon
PWG Stuffs
Rotate Image
SmartAlbums
Smilies Support
Statistics
Stop Spammers
Subscribe To Comments
User Collections
User Tags
VideoJS
Write Metadata
```
Kind regards
Jens
|
New Search not available with Bootstrap Darkroom Theme
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2090/comments
| 2 |
2024-01-18T20:47:05Z
|
2024-01-18T22:02:28Z
|
https://github.com/Piwigo/Piwigo/issues/2090
| 2,089,024,586 | 2,090 |
[
"Piwigo",
"Piwigo"
] |
In Piwigo 14 we have introduced the feature "search in this set", which can be accessed by either a button or an icon.
<img width="504" alt="piwigo-14-search-in-this-set" src="https://github.com/Piwigo/Piwigo/assets/9326959/67ad8d88-118f-4549-b547-e6483166eea4">
With a few months of use, I love this feature BUT I think the button is too obstrusive. We'd better hide it by default. I know it's going to make the feature quite invisible but we have to choose between _"highly visible but obstrusive"_ and _"nearly invisible but slickly integrated"_ (with only the icon)
|
hide button "search in this set" by default
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2089/comments
| 0 |
2024-01-18T11:16:01Z
|
2024-01-18T11:19:48Z
|
https://github.com/Piwigo/Piwigo/issues/2089
| 2,088,068,048 | 2,089 |
[
"Piwigo",
"Piwigo"
] |
In this code (`include/functions.inc.php` function `pwg_log`:
```
// If plugin developers add their own sections, Piwigo will automatically add it in the history.section enum column
if (isset($page['section']))
{
// set cache if not available
if (!isset($conf['history_sections_cache']))
{
conf_update_param('history_sections_cache', get_enums(HISTORY_TABLE, 'section'), true);
}
$conf['history_sections_cache'] = safe_unserialize($conf['history_sections_cache']);
if (in_array($page['section'], $conf['history_sections_cache']))
{
$section = $page['section'];
}
elseif (preg_match('/^[a-zA-Z0-9_-]+$/', $page['section']))
{
$history_sections = get_enums(HISTORY_TABLE, 'section');
$history_sections[] = $page['section'];
// alter history table structure, to include a new section
pwg_query('ALTER TABLE '.HISTORY_TABLE.' CHANGE section section enum(\''.implode("','", array_unique($history_sections)).'\') DEFAULT NULL;');
// and refresh cache
conf_update_param('history_sections_cache', get_enums(HISTORY_TABLE, 'section'), true);
$section = $page['section'];
}
}
```
We do as if the `history.section` is case sensitive. It's not. If you try to add `section42` in the ENUM field while `Section42` already exists, MySQL will throw an error.
|
history.section autofill should not be case sensitive
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2088/comments
| 0 |
2024-01-18T10:22:24Z
|
2024-01-18T10:28:36Z
|
https://github.com/Piwigo/Piwigo/issues/2088
| 2,087,971,812 | 2,088 |
[
"Piwigo",
"Piwigo"
] |
After upgrade from 13.8 to 14.1 when I try search function I got error
"Unknown column 'search_uuid' in 'where clause' SELECT COUNT(*) FROM piwigo_search WHERE search_uuid = 'psk-20240109-8txoOz4znJ' ; in /var/www/html/piwigo/include/dblayer/functions_mysqli.inc.php on line 847"
No errors in upgrade_feed.php (0 upgrades to apply)
Environment
Before updating
Piwigo 13.8.0 Check for updates
Installed April 8, 2023, 9 months/months 1 day ago
Operating system: Linux (Debian GNU/Linux 11 (bullseye))
PHP: 7.4.33 (Show info) [2024-01-09 22:21:56]
MySQL: 5.5.5-10.5.18-MariaDB-0+deb11u1 [2024-01-09 22:21:56]
Graphics Libraries: GD 2.3.0
Cache size 2068.42 MB now Refresh
After updating
Piwigo 14.1.0 Check for updates
Installed April 8, 2023, 9 months/months 1 day ago
Operating system: Linux
PHP: 7.4.33 (Show info) [2024-01-09 22:28:05]
MySQL: 5.5.5-10.5.18-MariaDB-0+deb11u1 [2024-01-09 22:28:05]
Graphics Libraries: GD 2.3.0
Cache size 2056.59 MB calculated now Refresh
|
Search function error after upgrade from 13.8 to 14.1
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2087/comments
| 3 |
2024-01-09T20:55:10Z
|
2024-01-24T13:33:08Z
|
https://github.com/Piwigo/Piwigo/issues/2087
| 2,073,154,758 | 2,087 |
[
"Piwigo",
"Piwigo"
] |
We had a compatibility problem between the administration Fontello and the gallery Fontello (theme default). The font-family was the same, so the Fontello was overloaded. After modifying the font-family, we realized that there was another incompatibility with the fontello of the modus theme and the fontello of the gallery, since the latter had the same prefix.
|
Wrong icons when AdminTools is activated
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2086/comments
| 0 |
2024-01-09T15:25:01Z
|
2024-01-10T13:36:31Z
|
https://github.com/Piwigo/Piwigo/issues/2086
| 2,072,596,283 | 2,086 |
[
"Piwigo",
"Piwigo"
] |
Prior to Piwigo 14, I was about to run a search using "rating:>3" and it would return all the images that have a rating score greater than 3.
Since upgrading to 14 (and now 14.1) it will strip out the **:** and **>** characters and only return the images which have a rating of 3.
This ONLY effects the front end, running the name search in the Batch Manager returns all images with a rating above 3 (the normal behaviour)
Current version and activated plugins below.
|
No longer able to search by rating score.
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2084/comments
| 2 |
2024-01-04T22:55:04Z
|
2024-07-31T14:10:53Z
|
https://github.com/Piwigo/Piwigo/issues/2084
| 2,066,452,889 | 2,084 |
[
"Piwigo",
"Piwigo"
] |
If you allow the `'`-Character for files (because you have an extensive folder structure already and do not want to change it), you can now inject SQL code using file or folder names.
It would be better to either use SQL parameters or - if that is too big of a refactor - escape _all_ user input before it goes into an SQL statement.
Example config:
```PHP
$conf['sync_chars_regex'] = '/^[-A-Za-zŽžÀ-ÿ0-9._\' ,)~(]+$/';
```
Error message:
```
Fatal error: Uncaught mysqli_sql_exception: You have an error in your SQL syntax;
check the manual that corresponds to your MariaDB server version for the right syntax to use near
's 50ter','Burkhard's 50ter','1','3','2,3,20','true','true','public','15'...'
at line 21 in /volume1/web/include/dblayer/functions_mysqli.inc.php:132
Stack trace:
#0 /volume1/web/include/dblayer/functions_mysqli.inc.php(132): mysqli->query('\nINSERT INTO `...')
#1 /volume1/web/include/dblayer/functions_mysqli.inc.php(550): pwg_query('\nINSERT INTO `...')
#2 /volume1/web/admin/site_update.php(313): mass_inserts('categories', Array, Array)
#3 /volume1/web/admin.php(346): include('/volume1/web/ad...')
#4 {main} thrown in /volume1/web/include/dblayer/functions_mysqli.inc.php on line 132
```
|
SQL-Injection Attack for certain configurations
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2083/comments
| 2 |
2024-01-01T12:36:05Z
|
2024-05-05T17:35:16Z
|
https://github.com/Piwigo/Piwigo/issues/2083
| 2,061,535,543 | 2,083 |
[
"Piwigo",
"Piwigo"
] |
I have a weird issue where a call to pwg.images.addSimple fails when the image in question is added with the tags parameter present.
Piwigo is 14.1.0
Apache2 2.4.57-2
php 8.2
on Debian Bookworm.
I am pretty sure this used to work, but since I upgraded Piwigo and PHP I cannot tell you which of the two might have broken it.
There is of course also a small chance that I am doing something weird in Shotwell's upload code.
Failure mode is either a 501 Missing "method" name if the tags are hierarchical (eg. "/foo/bar/baz") or a 401 Access denied if its just plain tags.
Working form data:
```
> Host: jensge.org
>
> --588d05a9fcd087d51198ec360f1ba1b725c79def406bf6a2e745877851d0b96f
> Content-Disposition: form-data; name="name"
>
> DCIM_00001_1.png
> --588d05a9fcd087d51198ec360f1ba1b725c79def406bf6a2e745877851d0b96f
> Content-Disposition: form-data; name="method"
>
> pwg.images.addSimple
> --588d05a9fcd087d51198ec360f1ba1b725c79def406bf6a2e745877851d0b96f
> Content-Disposition: form-data; name="category"
>
> 6
> --588d05a9fcd087d51198ec360f1ba1b725c79def406bf6a2e745877851d0b96f
> Content-Disposition: form-data; name="level"
>
> 8
> --588d05a9fcd087d51198ec360f1ba1b725c79def406bf6a2e745877851d0b96f
> Content-Type: image/jpeg
> Content-Disposition: form-data; filename=DCIM_00001_1.png.jpg; name=image
>
> ����
```
Non-working form data, resulting in "401 Access denied" error:
```
> Host: jensge.org
>
> --cc6dd8138b0a340f9f29a319659f3fac31ef95b4301f83b39253b76fb254d8d2
> Content-Disposition: form-data; name="name"
>
> IMG_0059.JPG
> --cc6dd8138b0a340f9f29a319659f3fac31ef95b4301f83b39253b76fb254d8d2
> Content-Disposition: form-data; name="method"
>
> pwg.images.addSimple
> --cc6dd8138b0a340f9f29a319659f3fac31ef95b4301f83b39253b76fb254d8d2
> Content-Disposition: form-data; name="category"
>
> 6
> --cc6dd8138b0a340f9f29a319659f3fac31ef95b4301f83b39253b76fb254d8d2
> Content-Disposition: form-data; name="level"
>
> 8
> --cc6dd8138b0a340f9f29a319659f3fac31ef95b4301f83b39253b76fb254d8d2
> Content-Disposition: form-data; name="tags"
>
> Hamburg,Wandern
> --cc6dd8138b0a340f9f29a319659f3fac31ef95b4301f83b39253b76fb254d8d2
> Content-Type: image/jpeg
> Content-Disposition: form-data; filename=IMG_0059.JPG; name=image
>
> ����
```
|
pwg.images.addSimple fails when supplying tags
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2082/comments
| 7 |
2024-01-01T12:13:08Z
|
2024-01-24T14:38:34Z
|
https://github.com/Piwigo/Piwigo/issues/2082
| 2,061,524,184 | 2,082 |
[
"Piwigo",
"Piwigo"
] |
Due to https://github.com/Piwigo/Piwigo/commit/9c9f46499474a6e288a25f2bc69fedb9e7fcd0f3 we have lost `icon-menu` and `icon-calendar` because fontello has changed their name. For what reason? we don't know yet.
|
[14.1.0] lost menu and calendar icons
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2081/comments
| 0 |
2023-12-29T17:17:32Z
|
2023-12-29T17:18:22Z
|
https://github.com/Piwigo/Piwigo/issues/2081
| 2,060,271,875 | 2,081 |
[
"Piwigo",
"Piwigo"
] |
> Parse error: syntax error, unexpected ')' in admin/cat_modify.php on line 324
See https://piwigo.org/forum/viewtopic.php?id=33288 or https://piwigo.org/forum/viewtopic.php?id=33325
|
[14.x] Parse error: syntax error, unexpected ')' in cat_modify.php
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2080/comments
| 0 |
2023-12-28T15:28:18Z
|
2023-12-28T15:29:15Z
|
https://github.com/Piwigo/Piwigo/issues/2080
| 2,058,564,301 | 2,080 |
[
"Piwigo",
"Piwigo"
] |
```
Server environment:
Piwigo: 14.0.0
Operating Systen: WINNT
PHP: 8.1.28-dev
MySQL: 11.4.0-MariaDB
Image library: ImageMagick 7.1.1-23
Plugins active:
LocalFiles Editor
OpenStreetMap
Security Headers
VideoJS
```
**How to reproduce:**
Go to Photos > Batch Manager, select "All" as filter, update the set, select the whole set and go for thumbnail generation.
Shortly afterwards the following error is thrown:
> Piwigo ist auf einen nicht behebbaren Fehler gestoßen.
>
> [Hacking attempt] the input parameter "whole_set" is not valid
>
> #1 check_input_parameter C:\Inetpub\wwwroot\piwigo\admin\batch_manager_global.php(54)
> #2 include C:\Inetpub\wwwroot\piwigo\admin\batch_manager.php(814)
> #3 include C:\Inetpub\wwwroot\piwigo\admin.php(346)
Only entry in PIwigo log:
> [2023-12-27 12:43:02] [DEBUG] [admin/intro::299] recent activity calculated in 0.335 s
PHP log shows:
> [27-Dec-2023 12:40:25 Europe/Berlin] PHP Fatal error: [Hacking attempt] the input parameter "whole_set" is not valid
> #1 check_input_parameter C:\Inetpub\wwwroot\piwigo\admin\batch_manager_global.php(54)
> #2 include C:\Inetpub\wwwroot\piwigo\admin\batch_manager.php(814)
> #3 include C:\Inetpub\wwwroot\piwigo\admin.php(346) in C:\Inetpub\wwwroot\piwigo\include\functions_html.inc.php on line 389
|
Batch Manager: Trying to run action on all items leads to "Hacking attempt" error
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2079/comments
| 9 |
2023-12-27T11:52:18Z
|
2024-02-26T10:33:16Z
|
https://github.com/Piwigo/Piwigo/issues/2079
| 2,057,283,167 | 2,079 |
[
"Piwigo",
"Piwigo"
] |
Hello,
After having upgraded piwigo in release 14.0 (docker), I've tried to add heic files and then synchronise.
Files are not find by the synchronise tool.
Thanx
Regards
|
Synchronize tool does not find heic files Release 14
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2078/comments
| 0 |
2023-12-27T09:58:39Z
|
2023-12-27T09:58:39Z
|
https://github.com/Piwigo/Piwigo/issues/2078
| 2,057,163,623 | 2,078 |
[
"Piwigo",
"Piwigo"
] |
Hi guys,
I would like to report a bug in the v14 in its Italian translation (previous version worked ok).
The impacted page is admin.php?page=album-2 and the error is triggered when the button saving the album properties is clicked.
The error is
`Uncaught SyntaxError: Unexpected identified 'album'
`
In order to fix, I changed line 1253 of file language/it_IT/admin.lang.php
from
`$lang['This albums is already in related categories list'] = 'Quest\'album è già nell\'elenco degli album associati';
`
to
`$lang['This albums is already in related categories list'] = 'Quest\\\'album è già nell\\\'elenco degli album associati';
`
I'm not expert enough on Piwigo to know how translations are managed, so I don't create any pull request.
Nevertheless, I hope this post can help fixing the bug.
Cheers,
|
Javascript error in Piwigo v14 in Italian translation
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2077/comments
| 0 |
2023-12-26T18:15:48Z
|
2023-12-26T18:36:13Z
|
https://github.com/Piwigo/Piwigo/issues/2077
| 2,056,611,146 | 2,077 |
[
"Piwigo",
"Piwigo"
] |
... when the tag filter is not active
|
[search 14.x] impossible to clear album filter
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2076/comments
| 0 |
2023-12-26T09:10:01Z
|
2023-12-26T09:23:28Z
|
https://github.com/Piwigo/Piwigo/issues/2076
| 2,056,206,036 | 2,076 |
[
"Piwigo",
"Piwigo"
] |
I get these during an install on PHP 7.4:
> Trying to access array offset on value of type null in admin/include/plugins.class.php on line 383
The result is that it breaks `install.php` and my automatic installation (for Piwigo.com) gets broken.
|
[install] error on plugins auto activation on PHP 7.4+
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2074/comments
| 0 |
2023-12-22T17:48:53Z
|
2023-12-22T17:51:17Z
|
https://github.com/Piwigo/Piwigo/issues/2074
| 2,054,299,386 | 2,074 |
[
"Piwigo",
"Piwigo"
] |
When you have a plugin like extended description providing a rendered version of the label, you're blocked because the tag manager only shows you a rendered version. It is thus impossible to modify the raw version.
|
Tag manager and Extended Description: you cannot modify the raw version
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2073/comments
| 0 |
2023-12-22T09:07:52Z
|
2023-12-22T09:34:17Z
|
https://github.com/Piwigo/Piwigo/issues/2073
| 2,053,613,073 | 2,073 |
[
"Piwigo",
"Piwigo"
] |
Several users have reported a problem with version 14 and its new album editor: the description field is too small for their use.
Indeed, when we use a rich description with html, we need more space.
|
[Album Editor 14.x] Description field is too small
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2072/comments
| 0 |
2023-12-19T16:40:41Z
|
2023-12-19T17:08:18Z
|
https://github.com/Piwigo/Piwigo/issues/2072
| 2,049,033,629 | 2,072 |
[
"Piwigo",
"Piwigo"
] |
<img width="504" alt="20230124175824-c21a3925-la" src="https://github.com/Piwigo/Piwigo/assets/137212265/9b21a9ad-93e0-4345-9129-7cc6807d176c">
|
Sorting users
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2071/comments
| 0 |
2023-12-18T17:03:52Z
|
2023-12-18T17:05:22Z
|
https://github.com/Piwigo/Piwigo/issues/2071
| 2,047,086,160 | 2,071 |
[
"Piwigo",
"Piwigo"
] |
When applying an action twice on "the whole set", you get this fatal error:
> Fatal error: Uncaught mysqli_sql_exception: Column 'object_id' cannot be null in include/dblayer/functions_mysqli.inc.php:132 Stack trace:
>
> #0 include/dblayer/functions_mysqli.inc.php(132): mysqli->query('\nINSERT INTO `...')
> #1 include/dblayer/functions_mysqli.inc.php(550): pwg_query('\nINSERT INTO `...')
> #2 include/functions.inc.php(644): mass_inserts('piwigo_activity', Array, Array)
> #3 admin/batch_manager_global.php(246): pwg_activity('photo', Array, 'edit', Array)
> #4 admin/batch_manager.php(814): include('/www/htdocs/w00...')
> #5 admin.php(346): include('/www/htdocs/w00...')
> #6 {main} thrown in include/dblayer/functions_mysqli.inc.php on line 132
|
[batch manager] Column 'object_id' cannot be null
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2070/comments
| 0 |
2023-12-18T13:30:17Z
|
2023-12-18T13:31:21Z
|
https://github.com/Piwigo/Piwigo/issues/2070
| 2,046,671,521 | 2,070 |
[
"Piwigo",
"Piwigo"
] |
Add configuration option and picture interface to select image size from sidebar.
Will possibly satisfy issue #656 as well.
Will submit PR shortly.
|
Add Available image sizes to sidebar
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2067/comments
| 0 |
2023-12-13T17:08:59Z
|
2023-12-13T17:08:59Z
|
https://github.com/Piwigo/Piwigo/issues/2067
| 2,040,142,553 | 2,067 |
[
"Piwigo",
"Piwigo"
] |
Updating Smarty to version 4.3, see #1845 has brought compatibility with PHP 8.2 but lost compatibility with PHP 7.0. Unfortunately we still see many hosting with PHP 7.0 and I wondered if keeping compatibility with PHP 7.0 was still possible.
After some quick investigations it seems that the only problem is the use of `nullable types` like `?int $var` or `?string $var`. There are only a tiny use of them in Smarty. Removing them makes Smarty 4.3 compatible with PHP 7.0 (as fas as my tests go)
|
[14.x] keep compatibility with PHP 7.0
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2066/comments
| 1 |
2023-12-13T13:58:57Z
|
2023-12-13T14:06:53Z
|
https://github.com/Piwigo/Piwigo/issues/2066
| 2,039,774,989 | 2,066 |
[
"Piwigo",
"Piwigo"
] |
I updated to 14.0.0, which went wrong somehow, so I started with a fresh install. It seems that I am unable to edit users (or the UI is confusing). More precisely, when hovering the pen (see screenshot below), the background turns orange, but clicking does nothing. The console is clean (apart from two lines like the following, which are displayed every after every click). The Network pane (Firefox) also shows no blocked connections. Any ideas?
Thank you!
20:10:39.653 false
20:10:39.655 2023/12/12
|
[v14.0.0] Cannot edit user
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2065/comments
| 3 |
2023-12-12T19:12:51Z
|
2023-12-13T21:00:08Z
|
https://github.com/Piwigo/Piwigo/issues/2065
| 2,038,400,525 | 2,065 |
[
"Piwigo",
"Piwigo"
] |
On several test environments, I can't manage my albums. I get this in the javascript console:
```
TypeError: undefined is not an object (evaluating 'node.parent')
```
It refers to this piece of code in `albums.js` :
```
var url_split = window.location.href.split("cat_move");
var catToOpen = url_split[url_split.length - 1].split("-")[1];
console.log(catToOpen);
if (catToOpen && isNumeric(catToOpen)) {
nodeToGo = $('.tree').tree('getNodeById', catToOpen);
goToNode(nodeToGo, nodeToGo);
if (nodeToGo.children) {
$(".tree").tree("openNode", nodeToGo, false);
}
}
```
The problem is that it tries to find an album id in the URL which is supposed to be like `http://domain.tld/admin.php?page=albums&parent_id=2#cat-2` and it assumes there is only one legit "-" in this URL. Which is totally not sure. In my case, the domain name is something like `server.ip-1-2-3-4.tld`. Good luck with that.
The search for the album id should not rely on parsing the URL.
|
[albums] undefined node.parent
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2064/comments
| 0 |
2023-12-12T17:42:35Z
|
2024-07-15T14:47:35Z
|
https://github.com/Piwigo/Piwigo/issues/2064
| 2,038,268,059 | 2,064 |
[
"Piwigo",
"Piwigo"
] |
Hi, I was just looking into updating the Cloudron Piwigo package to 14. Firstly, thanks for the great release :)
So once the code is updated, it will present the upgrade.php page in the browser, which asks for admin credentials to submit that form to run the database migration as I understand. In our case the app is updated automatically on behalf of the user, so unless the database migration is run automatically other users will incur some downtime until the admin gets to it. Is there any way this could also be run on the server itself via some commandline?
|
Database upgrade via command line
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2063/comments
| 2 |
2023-12-12T13:48:03Z
|
2023-12-12T14:39:56Z
|
https://github.com/Piwigo/Piwigo/issues/2063
| 2,037,796,668 | 2,063 |
[
"Piwigo",
"Piwigo"
] |
Some users, especially "executive" on the forum, has reported file permission issues in 14.x beta versions of Piwigo. This is due to a change of build server. Let's force it to 644 (remove `write` for group)
|
[14 beta] file permissions 664 instead of 644
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2062/comments
| 0 |
2023-12-11T20:38:37Z
|
2023-12-11T20:39:50Z
|
https://github.com/Piwigo/Piwigo/issues/2062
| 2,036,487,048 | 2,062 |
[
"Piwigo",
"Piwigo"
] |
Right after the overwrite of previous version files by the unzip in the administration, PHP engine might still have old files in cache. We do not want to use the cache and force reload of all application files. Thus we need to disable opcache.
For example, on the server I'm testing upgrade from 13.8.0 to 14.0.0, I get in the database:
```
MariaDB [tmp_pwgmig]> select * from piwigo_upgrade order by applied desc limit 10;
+-----+---------------------+----------------------------------------------------+
| id | applied | description |
+-----+---------------------+----------------------------------------------------+
| 165 | 2023-12-11 17:22:40 | [migration from 13.0.0 to 13.8.0, 0.000 s] Add... |
| 166 | 2023-12-11 17:22:40 | [migration from 13.0.0 to 13.8.0, 0.009 s] Crea... |
| 167 | 2023-12-11 17:22:40 | [migration from 13.0.0 to 13.8.0, 0.001 s] add ... |
| 170 | 2023-12-11 17:22:40 | [migration from 13.0.0 to 13.8.0, 0.000 s] add ... |
| 169 | 2023-12-11 17:22:40 | [migration from 13.0.0 to 13.8.0, 0.006 s] Dele... |
| 168 | 2023-12-11 17:22:40 | [migration from 13.0.0 to 13.8.0, 0.006 s] Crea... |
| 70 | 2023-12-11 17:22:28 | upgrade included in installation |
| 67 | 2023-12-11 17:22:28 | upgrade included in installation |
| 66 | 2023-12-11 17:22:28 | upgrade included in installation |
| 63 | 2023-12-11 17:22:28 | upgrade included in installation |
+-----+---------------------+----------------------------------------------------+
10 rows in set (0.001 sec)
```
Obviously upgrade 165 couldn't be applied in Piwigo 13.8.0. It's a new upgrade script in Piwigo 14!
Piwigo think we're on 13.8.0 because the old `include/constants.inc.php` is still in `opcache`. Same problem for sub-files of Smarty.
|
[upgrade] mixed old and new files included through opcache
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2061/comments
| 0 |
2023-12-11T16:33:20Z
|
2023-12-11T16:36:52Z
|
https://github.com/Piwigo/Piwigo/issues/2061
| 2,036,066,203 | 2,061 |
[
"Piwigo",
"Piwigo"
] |
|
Mobile version of search filters
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2060/comments
| 0 |
2023-12-11T10:29:07Z
|
2023-12-11T16:36:25Z
|
https://github.com/Piwigo/Piwigo/issues/2060
| 2,035,340,342 | 2,060 |
[
"Piwigo",
"Piwigo"
] |
Piwigo should integrate routines for automatically recognising faces, animals, plants, etc. and for classifying photos with recognised objects. A user may enable automatic recognition and then name or confirm recognised objects linked to multiple images. The recognised objects could also be shared with other users.
API methods should be provided to exploit/update recognised objects with third party apps (e.g. iOS and Android apps) but also to contribute to the recognition of new or known objects.
|
Automatic recognition and classification of faces, animals, objects
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2059/comments
| 1 |
2023-12-10T11:09:14Z
|
2024-06-07T12:14:24Z
|
https://github.com/Piwigo/Piwigo/issues/2059
| 2,034,324,192 | 2,059 |
[
"Piwigo",
"Piwigo"
] |
See #1744 or #1544 or #1276 or #1063 or #658 or #423
|
upgrade script to 14
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2058/comments
| 0 |
2023-12-08T17:22:56Z
|
2023-12-09T14:48:46Z
|
https://github.com/Piwigo/Piwigo/issues/2058
| 2,033,046,762 | 2,058 |
[
"Piwigo",
"Piwigo"
] |
When you perform a conscious update (with administration user interface) from Piwigo 13.7.0 to 13.8.0 an activity is registered:
```
pwg_activity(
'system',
ACTIVITY_SYSTEM_CORE,
'update',
array('from_version'=>PHPWG_VERSION, 'to_version'=>$upgrade_to)
);
```
Unfortunately, if you perform a manual update (by overwriting files on the server), Piwigo won't register the date of the update. Let's mark it as an `autoupdate` (just like we have for plugins).
|
track core autoupdates in system activities
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2057/comments
| 0 |
2023-12-07T10:28:32Z
|
2023-12-07T10:29:42Z
|
https://github.com/Piwigo/Piwigo/issues/2057
| 2,030,427,049 | 2,057 |
[
"Piwigo",
"Piwigo"
] |
Currently it is only possible to search for dates (created and posted). In my application a time based search is required, because a lot of pictures are taken per date.
Currently the time part of a datetime is not parsed. If the time was parsed optionally, it would be possible to query a complete datetime.
https://github.com/Piwigo/Piwigo/blob/bd152ba00e0a26bb9a270e5d7bc924fe42d0aac3/include/functions_search.inc.php#L674C1-L689C6
|
Time based search in addition to date search
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2055/comments
| 0 |
2023-12-05T16:57:15Z
|
2023-12-05T16:57:15Z
|
https://github.com/Piwigo/Piwigo/issues/2055
| 2,026,692,092 | 2,055 |
[
"Piwigo",
"Piwigo"
] |
<img width="920" alt="image" src="https://github.com/Piwigo/Piwigo/assets/137212265/10714e2d-ef8a-4f44-8aa3-2867bf57d8bc">
|
Displaying the Directory on album editing
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2054/comments
| 0 |
2023-12-05T16:22:43Z
|
2023-12-05T16:28:05Z
|
https://github.com/Piwigo/Piwigo/issues/2054
| 2,026,601,834 | 2,054 |
[
"Piwigo",
"Piwigo"
] |
The bug is linked to issue #2033 .
After creating a new album and adding a photo, when you go to the photo editing page the select "represent[]" is filled in by the selectize plugin, which causes the form to warn of a change even if you don't interact with it.
|
Warning bug in photo editing page
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2053/comments
| 0 |
2023-12-05T13:39:23Z
|
2023-12-05T13:44:51Z
|
https://github.com/Piwigo/Piwigo/issues/2053
| 2,026,222,500 | 2,053 |
[
"Piwigo",
"Piwigo"
] |
Hi I've been working with the API to fetch some images for another web app. Works great for my needs.
I am seeing a small error in the page URL generated by the API.
Piwigo 13.8.0
Installed on 7 May 2022, 1 year 6 months 3 weeks 1 day ago
Operating system: Linux
PHP: 8.1.25 (Show info) [2023-11-29 19:02:30]
MySQL: 8.0.35-0ubuntu0.20.04.1 [2023-11-29 19:02:30]
Graphics Library: ImageMagick 6.9.10-23
`var tag = 'whatever';`
The URL generated by
`//piwi.lan/ws.php?format=json&method=pwg.tags.getImages&tag_name=${tag}`
```
{
"stat": "ok",
"result": {
"paging": {
"page": 0,
"per_page": 100,
"count": 2,
"total_count": 2
},
"images": [
{
"rank": 0,
"is_favorite": false,
"id": 11,
"width": 1280,
"height": 793,
"hit": 1,
"file": "inverted.jpg",
"name": "inverted",
"comment": null,
"date_creation": null,
"date_available": "2023-11-24 11:14:54",
"page_url": "http://piwi.lan/picture.php?/11",
...
```
```
"page_url": "https://piwi.lan/picture.php?/11"
"page_url": "http://piwi.lan/picture.php?/11"
```
both give the error:
```
Deprecated: strncmp(): Passing null to parameter #1 ($string1) of type string is deprecated in /www/piwi/public_html/include/functions_url.inc.php on line 447
Warning: Cannot modify header information - headers already sent by (output started at /www/piwi/public_html/include/functions_url.inc.php:447) in /mnt/tera/www/piwi/public_html/include/page_header.php on line 99
```
If I use the navigation arrow to go up the the album view. the url is
`http://piwi.lan/index.php?/categories/flat` -- no error
Then click to return to the photo the url is:
`http://piwi.lan/picture.php?/11/categories` -- no error
if I edit the url to `https://piwi.lan/picture.php?/11/` -- no error.
persists in rc 14
Piwigo 14.0.0RC1
Installed on 23 November 2023, 6 days ago
Operating system: Linux
PHP: 8.1.25 (Show info) [2023-11-29 18:58:30]
MySQL: 8.0.35-0ubuntu0.20.04.1 [2023-11-29 18:58:30]
Graphics Library: ImageMagick 6.9.10-23
|
API returned-page URL warning
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2052/comments
| 3 |
2023-11-30T02:32:49Z
|
2023-11-30T16:59:15Z
|
https://github.com/Piwigo/Piwigo/issues/2052
| 2,017,757,524 | 2,052 |
[
"Piwigo",
"Piwigo"
] |
|
[14RC1] Search widget extends beyond the window on the right
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2051/comments
| 0 |
2023-11-27T16:23:58Z
|
2023-11-27T17:35:18Z
|
https://github.com/Piwigo/Piwigo/issues/2051
| 2,012,644,897 | 2,051 |
[
"Piwigo",
"Piwigo"
] |
Each time we have a missing user (because it was deleted), we get a:
> Notice: Undefined variable: user_name in include/ws_functions/pwg.php on line 1000
This makes the JSON output of method `pwg.history.search` unparsable for page [Administration > Tools > History > tab Search].
|
[pwg.history.search] notice on missing users
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2050/comments
| 0 |
2023-11-27T15:01:18Z
|
2023-11-27T15:02:10Z
|
https://github.com/Piwigo/Piwigo/issues/2050
| 2,012,470,374 | 2,050 |
[
"Piwigo",
"Piwigo"
] |
Is there a way to visualize image dimensions and file size in thumbnail tooltips in **_albums_** similar to what's been implemented in #545?
|
Dimensions/filesize on thumbnail tooltip in albums
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2049/comments
| 0 |
2023-11-27T12:34:52Z
|
2023-11-27T12:34:52Z
|
https://github.com/Piwigo/Piwigo/issues/2049
| 2,012,178,969 | 2,049 |
[
"Piwigo",
"Piwigo"
] |
I want to remove them as fllows
|
How can i remove the footer and the banner
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2048/comments
| 0 |
2023-11-25T02:15:32Z
|
2023-11-25T02:15:32Z
|
https://github.com/Piwigo/Piwigo/issues/2048
| 2,010,437,248 | 2,048 |
[
"Piwigo",
"Piwigo"
] |
User aren't used to this. the boom icon could be confusing. We should change it to something users already have experience with in piwigo
|
[search]Change the broom icon
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2047/comments
| 0 |
2023-11-22T16:02:12Z
|
2023-11-22T16:04:47Z
|
https://github.com/Piwigo/Piwigo/issues/2047
| 2,006,660,388 | 2,047 |
[
"Piwigo",
"Piwigo"
] |
Plugin Extended Description uses `<!--hidden-->` and `<!--mb-hidden-->` in album name to hide an album from the list of album thumbnails and from the menubar (independantly). It's really not great and a database column `categories.show_in_thumbnails` and `categories.show_in_menubar` would have been much better, but that's another story...
In Piwigo 14 and the new album editor, we now uses the API method `pwg.categories.setInfo` to update album name/description and since 23fa4c1a736cfa6e87e06edf243d5441b886d429 Piwigo applies a `strip_tags` on provided name.
Meaning it's impossible in Piwigo 14.0.0RC1 to use the "set as hidden" system provided by Extended Description.
|
[14.0.0RC1] impossible to use `<!--hidden-->` in album name
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2046/comments
| 0 |
2023-11-22T14:34:48Z
|
2023-11-23T18:47:34Z
|
https://github.com/Piwigo/Piwigo/issues/2046
| 2,006,481,724 | 2,046 |
[
"Piwigo",
"Piwigo"
] |
Hi,
Not a bug, only translation issue
The message after rotating a photo is diplayed in english, however the default language is french
Environnement
13.8.0
Installé le 5 Janvier 2022, il y a 1 an 10 mois 2 semaines 2 jours
Système d'exploitation: Linux
PHP: 7.4.33
MySQL: 5.5.5-10.5.21-MariaDB-0+deb11u1 [2023-11-22 12:22:05]
Bibliothèque graphique: External ImageMagick 6.9.11-60
Taille du cache 46013.37 Mo
Liste des plugins activés
- Admin Tools
- Custom Download Link
- Download Formats Buttons
- Language Switch
- LocalFiles Editor
- Rotate Image
- RV DB Integrity
- Take A Tour of Your Piwigo
- VideoJS
|
13.8.0 : not a bug, only translation issue
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2045/comments
| 0 |
2023-11-22T11:23:19Z
|
2023-11-22T11:23:19Z
|
https://github.com/Piwigo/Piwigo/issues/2045
| 2,006,124,488 | 2,045 |
[
"Piwigo",
"Piwigo"
] |
Leftover css from lightmode
|
Album manager darkmode missing color changes
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2044/comments
| 0 |
2023-11-20T15:06:02Z
|
2023-11-20T15:07:43Z
|
https://github.com/Piwigo/Piwigo/issues/2044
| 2,002,407,221 | 2,044 |
[
"Piwigo",
"Piwigo"
] |
To be updated to 2023 and even 2024
|
Copyright image shows 2016
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2043/comments
| 0 |
2023-11-17T10:49:58Z
|
2023-11-17T10:51:47Z
|
https://github.com/Piwigo/Piwigo/issues/2043
| 1,998,820,326 | 2,043 |
[
"Piwigo",
"Piwigo"
] |
I was in the process of adding a creation date to a set of 19 images I had just uploaded, and upon trying to save the changes, the page reloads and displays this message: `Fatal error: Uncaught Error: Call to undefined function mb_substr() in /path/topiwigo/admin/intro.php:397 Stack trace: #0 /path/to/piwigo/admin.php(346): include() #1 {main} thrown in /path/to/piwigo/admin/intro.php on line 397`.
The gallery site loads just fine, it's only trying to access the administration page where this error is displayed. This is all with php8.2.
EDIT: It looks like only the Dashboard page of the admin tools is inaccessible. Navigating directly with something like `admin.php?page=tags` works correctly.
|
Fatal error accessing administation page (14.0.0RC1)
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2042/comments
| 1 |
2023-11-14T16:46:17Z
|
2023-11-15T08:55:14Z
|
https://github.com/Piwigo/Piwigo/issues/2042
| 1,993,136,121 | 2,042 |
[
"Piwigo",
"Piwigo"
] |
If you search on tag "cat" and tag "dog" in a single step, and that those 2 tags have no common photos, then the tag filter becomes empty. So do other filters. That's because #2027 : if there is no resulting photos, then Piwigo can't find tags related to this empty set of photos and no tags are available in the tag filter.
|
[search, 14RC1] search on 2 unrelated tags breaks the search
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2041/comments
| 0 |
2023-11-14T15:08:41Z
|
2023-11-14T15:09:46Z
|
https://github.com/Piwigo/Piwigo/issues/2041
| 1,992,941,312 | 2,041 |
[
"Piwigo",
"Piwigo"
] |
Change display of reset button to avoid having two buttons on same level
|
Batch manager single mode submit and reset button same level
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2040/comments
| 0 |
2023-11-13T08:49:27Z
|
2023-11-13T14:05:28Z
|
https://github.com/Piwigo/Piwigo/issues/2040
| 1,990,158,108 | 2,040 |
[
"Piwigo",
"Piwigo"
] |
Hi,
- upload a video to the server from a mobile phone under IOS
- delete the video from the application under IOS
Why the directories are not deleted on the piwigo server?
There are still there, even empty?
Thank you
```
$ ls -lalrtR 11
11:
total 16
drwxrwxrwx 5 www-data www-data 4096 Nov 3 11:35 ..
drwxrwxrwx 4 www-data www-data 4096 Nov 7 08:41 .
drwxrwxrwx 3 www-data www-data 4096 Nov 11 14:12 07
drwxrwxrwx 3 www-data www-data 4096 Nov 11 14:34 03
11/07:
total 16
-rw-rw-rw- 1 www-data www-data 12 Nov 7 08:41 index.htm
drwxrwxrwx 4 www-data www-data 4096 Nov 7 08:41 ..
drwxrwxrwx 3 www-data www-data 4096 Nov 11 14:12 .
drwxrwxrwx 2 www-data www-data 4096 Nov 11 14:12 pwg_representative
11/07/pwg_representative:
total 12
-rw-rw-rw- 1 www-data www-data 12 Nov 7 08:41 index.htm
drwxrwxrwx 3 www-data www-data 4096 Nov 11 14:12 ..
drwxrwxrwx 2 www-data www-data 4096 Nov 11 14:12 .
11/03:
total 16
-rw-rw-rw- 1 www-data www-data 12 Nov 3 11:35 index.htm
drwxrwxrwx 4 www-data www-data 4096 Nov 7 08:41 ..
drwxrwxrwx 2 www-data www-data 4096 Nov 11 14:34 pwg_representative
drwxrwxrwx 3 www-data www-data 4096 Nov 11 14:34 .
11/03/pwg_representative:
total 12
-rw-rw-rw- 1 www-data www-data 12 Nov 3 11:35 index.htm
drwxrwxrwx 3 www-data www-data 4096 Nov 11 14:34 ..
drwxrwxrwx 2 www-data www-data 4096 Nov 11 14:34 .
```
IOS : mobile apple 7 plus with latest testflight version 3.1 (540
Piwigo server : 13.8.0 under raspberry pi 4 Model B Rev 1.4 under OS Raspbian GNU/Linux 11 (bullseye) aarch64
|
directories not deleted on server when a video is deleted
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2039/comments
| 6 |
2023-11-11T13:45:53Z
|
2023-11-20T22:14:58Z
|
https://github.com/Piwigo/Piwigo/issues/2039
| 1,988,955,550 | 2,039 |
[
"Piwigo",
"Piwigo"
] |
hello
PHP Warning: Undefined array key "Optimal" in .maintenance_actions.tpl.php on line 334
|
Make compatible Maintenance
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2038/comments
| 4 |
2023-11-10T17:05:36Z
|
2023-11-29T10:19:39Z
|
https://github.com/Piwigo/Piwigo/issues/2038
| 1,988,010,078 | 2,038 |
[
"Piwigo",
"Piwigo"
] |
<img width="768" alt="image" src="https://github.com/Piwigo/Piwigo/assets/137212265/0343a38b-7444-4593-be58-5c5411329979">
|
Make locked album obvious on both dashboard and album manager
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2037/comments
| 0 |
2023-11-10T16:50:28Z
|
2023-11-11T18:47:40Z
|
https://github.com/Piwigo/Piwigo/issues/2037
| 1,987,986,246 | 2,037 |
[
"Piwigo",
"Piwigo"
] |
Hello. My piwigo 14.0.0.beta3 seems to be unable to use the GD library to display webp images. It runs on PHP8.1, and the graphics library used by piwigo is GD 2.3.3.
I see on phpinfo that GD supports webp, but after synchronizing the webp image to piwigo, I can see the image file on piwigo, but I can’t load the image. In the album, it only shows the name, and on its name “Copy image link” opens and shows a line of output “[Image GD] unsupported file extension”
The reason I use the GD library: Because the server running piwigo has very few resources and the traffic is not large, I found that Imagick occupies more resources than GD in this situation, so I chose to use the GD graphics library
I look forward to your answer, thank you!
|
14.0.0.beta3 uses GD to display webp output [Image GD] unsupported file extension.
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2036/comments
| 2 |
2023-11-10T13:51:22Z
|
2024-03-16T08:26:04Z
|
https://github.com/Piwigo/Piwigo/issues/2036
| 1,987,670,135 | 2,036 |
[
"Piwigo",
"Piwigo"
] |
Some parameters (`min_register`, `max_register` and `filter`) are used in the function, but are not declared on ws.php: therefore no automatic format check etc. and no documentation via tools/ws.htm
|
[API] pwg.user.getList declare new parameters (filter, min_register and max_register)
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2035/comments
| 0 |
2023-11-10T13:36:56Z
|
2023-11-10T13:40:56Z
|
https://github.com/Piwigo/Piwigo/issues/2035
| 1,987,644,825 | 2,035 |
[
"Piwigo",
"Piwigo"
] |
Hello, I tried to upgrade from 13.8.0 to 14.0.0.beta2 and 14.0.0.beta3 according to the method of https://piwigo.org/guides/update/manual. I encountered the same problem when upgrading these two versions, that is, after the upgrade, an SQL error occurred when accessing the “Settings”-“Options” page in the administrator background. I did not find any related posts about this error. I will paste the error information output after accessing admin.php?page=configuration below. Please tell me what I did wrong?Thank you.
My environment:
PHP: 8.1.25
MySQL: 8.0.35-0ubuntu0.22.04.1
Error message:
> Fatal error: Uncaught mysqli_sql_exception: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'groups' at line 4 in example.com/include/dblayer/functions_mysqli.inc.php:132 Stack trace:
>
> #0 example.com/include/dblayer/functions_mysqli.inc.php(132): mysqli->query()
> #1 example.com/include/dblayer/functions_mysqli.inc.php(888): pwg_query()
> #2 example.com/admin/configuration.php(407): query2array()
> #3 example.com/admin.php(346): include('...')
> #4 {main} thrown in example.com/include/dblayer/functions_mysqli.inc.php on line 132
|
14.0.0.beta3 Backend “Settings”-“Options” page shows SQL statement error
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2034/comments
| 0 |
2023-11-09T08:34:05Z
|
2023-11-09T11:33:00Z
|
https://github.com/Piwigo/Piwigo/issues/2034
| 1,985,097,636 | 2,034 |
[
"Piwigo",
"Piwigo"
] |
For both album and photo
|
Redesign visit in gallery buttons
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2033/comments
| 0 |
2023-11-08T10:54:49Z
|
2023-11-08T14:01:12Z
|
https://github.com/Piwigo/Piwigo/issues/2033
| 1,983,324,538 | 2,033 |
[
"Piwigo",
"Piwigo"
] |
When downloading images, some images are not displayed after upload. After uploading images, I see some images are not displayedб but images correctly displaying locally on the PC
|
Some images are not displayed
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2032/comments
| 0 |
2023-11-06T19:34:10Z
|
2023-11-06T19:34:10Z
|
https://github.com/Piwigo/Piwigo/issues/2032
| 1,979,923,437 | 2,032 |
[
"Piwigo",
"Piwigo"
] |
Currently in version 13, UIX give ability for admin to set admin/webmaster but the API prevent from
|
Only webmaster should be able to give admin/webmaster status
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2031/comments
| 0 |
2023-11-06T11:38:05Z
|
2023-11-08T14:01:35Z
|
https://github.com/Piwigo/Piwigo/issues/2031
| 1,978,932,465 | 2,031 |
[
"Piwigo",
"Piwigo"
] |
Piwigo 13.8.0
Apache 2.4
PHP 8.0
MariaDB 10
When performing search ONLY "tags" selected, following error appears:
_**Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /Sites/piwigo/include/functions_search.inc.php:78
Stack trace:
#0 /Sites/piwigo/include/functions_search.inc.php(235): get_sql_search_clause(Array)
#1 /Sites/piwigo/include/functions_search.inc.php(1499): get_regular_search_results(Array, '')
#2 /Sites/piwigo/include/section_init.inc.php(364): get_search_results('46', NULL)
#3 /Sites/piwigo/index.php(12): include('/volume1/web/pi...')
#4 {main} thrown in /Sites/piwigo/include/functions_search.inc.php on line 78**_
Please find attached search page capture:
<img width="894" alt="Search_page_capture" src="https://github.com/Piwigo/Piwigo/assets/47954029/2e65919a-b26d-402a-8451-abd002511d21">
|
Error in functions_search.inc.php
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2030/comments
| 4 |
2023-10-27T08:54:44Z
|
2023-10-31T08:38:35Z
|
https://github.com/Piwigo/Piwigo/issues/2030
| 1,965,071,211 | 2,030 |
[
"Piwigo",
"Piwigo"
] |
|
[search] Double icon on add album button
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2029/comments
| 1 |
2023-10-23T13:45:07Z
|
2023-11-06T14:19:02Z
|
https://github.com/Piwigo/Piwigo/issues/2029
| 1,957,212,598 | 2,029 |
[
"Piwigo",
"Piwigo"
] |
At the moment most of the display for the new search is in modus, we need a default display that can then be personnalised depending on the selected theme & skin
|
[search] make compatible with themes
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2028/comments
| 0 |
2023-10-23T11:44:24Z
|
2023-10-31T16:16:22Z
|
https://github.com/Piwigo/Piwigo/issues/2028
| 1,956,974,544 | 2,028 |
[
"Piwigo",
"Piwigo"
] |
... or "related" to current set of photos. For example, if you're filtering on a specific album with photos added by "john" and "paul", only show these 2 users in the "added_by" filter.
|
[search] make filter values contextual
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2027/comments
| 1 |
2023-10-22T19:03:28Z
|
2023-10-24T09:50:04Z
|
https://github.com/Piwigo/Piwigo/issues/2027
| 1,956,017,416 | 2,027 |
[
"Piwigo",
"Piwigo"
] |
Hi there,
trying to setup the latest stable version but the install page is stuck with "No such file or directory" message... Any ideas?
p.s. it's pure php (hardcoded file path?) issue, there is nothing in error logs
|
Install is blocked by "No such file or directory" message
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2026/comments
| 1 |
2023-10-22T00:23:52Z
|
2023-10-22T22:37:52Z
|
https://github.com/Piwigo/Piwigo/issues/2026
| 1,955,708,230 | 2,026 |
[
"Piwigo",
"Piwigo"
] |
The "search by word" filter does not try to match the images.author field. That's not logic. We do it for tags and for albums, so why not for author?
|
[search] search by words should work on author field
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2025/comments
| 0 |
2023-10-18T16:18:39Z
|
2023-10-18T16:19:37Z
|
https://github.com/Piwigo/Piwigo/issues/2025
| 1,950,146,620 | 2,025 |
[
"Piwigo",
"Piwigo"
] |
Just tried to delete a photo and got this error message:
Warning: [mysql error 1054] Unknown column 'rank' in 'order clause'
SELECT i.id
FROM pwg_images AS i
LEFT JOIN pwg_image_tag AS it1 ON i.id = it1.image_id
WHERE
it1.tag_id = 22
GROUP BY i.id
ORDER BY rank ASC
; in /srv/$hostname/include/dblayer/functions_mysqli.inc.php on line 847
Fatal error: Uncaught Error: Call to a member function fetch_assoc() on bool in /srv/$hostname/include/dblayer/functions_mysqli.inc.php:908 Stack trace: #0 /srv/$hostname/plugins/SmartAlbums/include/functions.inc.php(546): query2array() #1 /srv/$hostname/plugins/SmartAlbums/include/functions.inc.php(51): smart_get_pictures() #2 [internal function]: smart_make_associations() #3 /srv/$hostname/plugins/SmartAlbums/include/functions.inc.php(115): array_map() #4 /srv/$hostname/include/functions_plugins.inc.php(264): smart_make_all_associations() #5 /srv/$hostname/admin/include/functions.php(2209): trigger_notify() #6 /srv/$hostname/plugins/AdminTools/include/events.inc.php(276): invalidate_user_cache() #7 /srv/$hostname/include/functions_plugins.inc.php(264): admintools_save_picture() #8 /srv/$hostname/picture.php(137): trigger_notify() #9 {main} thrown in /srv/$hostname/include/dblayer/functions_mysqli.inc.php on line 908
System: Devuan GNU/Linux 4 Chimaera
Webserver: nginx_1.18.0-6.1+deb11u3_all
PHP: php7.4-fpm_7.4.33-~deb11u4_amd64
Database: mariadb-server_1%3a10.5.21-0+deb11u1_all
Piwigo: 13.8.0
EDIT: The photo has been deleted in spite of that message, but still … should not happen this way
|
Photo cannot be deleted, Piwigo 13.8.0 with PHP 7.4
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2024/comments
| 1 |
2023-10-17T14:17:15Z
|
2023-10-19T04:53:29Z
|
https://github.com/Piwigo/Piwigo/issues/2024
| 1,947,544,822 | 2,024 |
[
"Piwigo",
"Piwigo"
] |
Hi, I'm new to programming and using piwigo and I'd like someone's help to generate a pwg_token.
I've searched a lot on the internet on how to generate the pwg_token, but I've been unsuccessful. Do you need a plugin to generate it?
I'm currently using postman and n8n to send a file to piwigo.
|
Generate token
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2022/comments
| 1 |
2023-10-13T21:11:09Z
|
2023-10-16T12:35:35Z
|
https://github.com/Piwigo/Piwigo/issues/2022
| 1,942,649,216 | 2,022 |
[
"Piwigo",
"Piwigo"
] |
Given a call to ws.php with the following parameters:
```
format=php
method=pwg.tags.getImages
tag_name[]=tag1
tag_name[]=tagA
tag_mode_and=true
```
If the call is made and `tag1` does not exist, that is ignored and all images with the `tagA` are listed. This behavior doesn't quite make sense with `tag_mode_and` set to true; I would expect an error message stating that the tag doesn't exist.
|
pwg.tags.getImages silently ignores invalid tags in tag_mode_and mode
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2021/comments
| 0 |
2023-10-12T18:01:32Z
|
2023-10-12T18:04:41Z
|
https://github.com/Piwigo/Piwigo/issues/2021
| 1,940,515,712 | 2,021 |
[
"Piwigo",
"Piwigo"
] |
On GET /admin.php?page=plugins_installed&incompatible_plugins=true :
> foreach() argument must be of type array|object, bool given in admin/plugins_installed.php on line 51
|
[PHP 8.x] plugins, warning when requesting list of incompatible plugins
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2020/comments
| 0 |
2023-10-10T13:18:44Z
|
2023-10-10T13:19:41Z
|
https://github.com/Piwigo/Piwigo/issues/2020
| 1,935,358,034 | 2,020 |
[
"Piwigo",
"Piwigo"
] |
My initiative was triggered by this issue: https://github.com/Piwigo/piwigo-openstreetmap/issues/163
SQL-Injections are serious security threats, in [Security and coding](https://github.com/Piwigo/Piwigo/wiki/Security-and-coding) guideline it is mentioned at first place. However, many developers are lazy and it is fully up to them whether they use `pwg_db_real_escape_string()` or not. I think they should be nudged a bit stronger to write secure code, which means they should use prepared statements. Personally, I see `real_escape_string()` just as a workaround - not as a solution!
My proposal for https://github.com/Piwigo/Piwigo/blob/master/include/dblayer/functions_mysqli.inc.php would be this one:
```
/**
* Execute a query
*
* @param string $query The SQL query/command to be executed.
* @param array<mixed> $values Array of parameters values. Use an emtpy array [] if the query does not have any parameter.
* @return mysqli_result|bool
*/
function pwg_query($query, $values = NULL)
{
global $mysqli, $conf, $page, $debug, $t2;
if (is_null($values) or strpos($query, "'") !== false)
{
trigger_error('
The query is vulnerable to SQL-Injection, it is highly recommended to use prepared statements.
If the query does not contain any parameters, pass an emtpy array [] to get rid of this warning', E_USER_WARNING);
}
$start = microtime(true);
if (is_array($values) and count($values) > 0)
{
$stmt = $mysqli->prepare($query);
$types = '';
foreach ($values as $val)
{
$type = gettype($val);
if ($type == 'integer')
{
$types .= 'i';
}
elseif ($type == 'double')
{
$types .= 'd';
}
elseif ($type == 'string')
{
$types .= 's';
}
else
{
my_error("Data type '$type' not supported as bind parameter", $conf['die_on_sql_error']);
}
}
$stmt->bind_param($types, ...$values);
($result = $stmt->execute()) or my_error($query, $conf['die_on_sql_error']);
$result = $stmt->get_result();
}
else
{
($result = $mysqli->query($query)) or my_error($query, $conf['die_on_sql_error']);
}
$time = microtime(true) - $start;
if (!isset($page['count_queries']))
{
$page['count_queries'] = 0;
$page['queries_time'] = 0;
}
$page['count_queries']++;
$page['queries_time'] += $time;
if ($conf['show_queries'])
{
$output = '';
$output .= '<pre>[' . $page['count_queries'] . '] ';
$output .= "\n" . $query;
if (is_array($values) and count($values) > 0)
{
$parameter_query = $query;
for ($i = 0; $i < count($values); $i++)
{
$parameter_query = substr_replace($parameter_query, ":p$i", strpos($parameter_query, '?'), 1);
}
$parameter_value = [];
foreach (pwg_bind_values($values) as $val)
{
array_push($parameter_value, $val);
}
$output .= "\n" . $parameter_query;
$output .= "\n" . implode(', ', $parameter_value);
}
$output .= "\n" . '(this query time : ';
$output .= '<b>' . number_format($time, 3, '.', ' ') . ' s)</b>';
$output .= "\n" . '(total SQL time : ';
$output .= number_format($page['queries_time'], 3, '.', ' ') . ' s)';
$output .= "\n" . '(total time : ';
$output .= number_format(($time + $start - $t2), 3, '.', ' ') . ' s)';
if ($result != null and preg_match('/\s*SELECT\s+/i', $query))
{
$output .= "\n" . '(num rows : ';
$output .= pwg_db_num_rows($result) . ' )';
}
elseif ($result != null
and preg_match('/\s*INSERT|UPDATE|REPLACE|DELETE\s+/i', $query))
{
$output .= "\n" . '(affected rows : ';
$output .= pwg_db_changes() . ' )';
}
$output .= "</pre>\n";
$debug .= $output;
}
return $result;
}
/**
* Generates a SQL parameter sequence array, like [ ':p0 => foo', ':p1 => bar', ':p2 => 3' ]
* @param array<mixed> $values Array of parameters values.
* @return array<string>
*/
function pwg_bind_values($values)
{
for ($i = 0; $i < count($values); $i++)
{
yield "p$i => $values[$i]";
}
}
```
Then SQL query would look like this:
```
$query = '
SELECT id
FROM '.TAGS_TABLE.'
WHERE name = ?';
pwg_query($query, [$tag_name] );
```
The developer will see a warning, if they use vulnerable SQL strings where parameter values are composed as string in the query. Of course, all existing code will remain working, it raises just a (well visible) warning.
I know, it will be a lot of work to transform 722 function calls of `pwg_query` but in the end there is no alternative to get more secure code. Parameterized statements are much easier to use, than checking user input with regular expressions, dealing with quotes, etc. As a positive side-effect, the performance will be better than hard-coded statements.
What is your opinion about this proposal?
Wernfried
|
Turn SQL statements into prepared statements to protect against SQL-Injection
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2019/comments
| 4 |
2023-10-08T20:16:22Z
|
2023-10-13T17:58:01Z
|
https://github.com/Piwigo/Piwigo/issues/2019
| 1,932,053,218 | 2,019 |
[
"Piwigo",
"Piwigo"
] |
On the new search engine, when a search by words matches a tag or an album, it is "suggested". In 14beta3, Piwigo shows private suggestions, not meant to be visible to the user.
|
[search] remove private tags/albums from matching results
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2018/comments
| 0 |
2023-10-05T10:09:59Z
|
2023-10-05T10:12:48Z
|
https://github.com/Piwigo/Piwigo/issues/2018
| 1,927,902,949 | 2,018 |
[
"Piwigo",
"Piwigo"
] |
https://github.com/Piwigo/Piwigo/blob/b5c9ca4819806a9f831596c780d69bb79865f569/include/functions_comment.inc.php#L348
Gues that should be: `$comment['website_url'] = strip_tags($comment['website_url']); `
|
What for is this??
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2017/comments
| 0 |
2023-10-02T12:39:40Z
|
2023-10-02T12:39:40Z
|
https://github.com/Piwigo/Piwigo/issues/2017
| 1,921,841,550 | 2,017 |
[
"Piwigo",
"Piwigo"
] |
save `search_id` in table `history`, display it on the history log page... and remove the useless `search.last_seen` field.
|
[search] save search in visit history
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2016/comments
| 0 |
2023-10-02T10:27:23Z
|
2023-10-02T12:55:40Z
|
https://github.com/Piwigo/Piwigo/issues/2016
| 1,921,645,683 | 2,016 |
[
"Piwigo",
"Piwigo"
] |
There's a possible SQL injection issue in Piwigo Openstreetmap, s. Piwigo/piwigo-openstreetmap#163. PR #2014 provides a fix for the issue.
|
Possible SQL injection in tag_name
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2015/comments
| 2 |
2023-10-01T20:18:34Z
|
2023-10-12T10:27:38Z
|
https://github.com/Piwigo/Piwigo/issues/2015
| 1,920,952,235 | 2,015 |
[
"Piwigo",
"Piwigo"
] |
In your requirements it says:
- PHP 5.3 or greater (7+ recommended)
Is this still true? I consider to contribute to this project, mainly the SQL related part. PHP 5.3 is ancient, and even version 7 is "end of life". Do I really have to make my code working for PHP version 5.3?
If yes, then I will refuse my plans contributing to this project.
Kind Regards
Wernfried
|
Minimum reqirements for Piwigo
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2013/comments
| 6 |
2023-10-01T08:52:40Z
|
2023-10-02T09:12:32Z
|
https://github.com/Piwigo/Piwigo/issues/2013
| 1,920,649,832 | 2,013 |
[
"Piwigo",
"Piwigo"
] |
Currently using Piwigo 14.x I have that: `<link rel="canonical" href="/gallery/piwigo/">`
But it should be like that: `<link rel="canonical" href="https://mygallery.com/gallery/piwigo/">`
See: https://developers.google.com/search/docs/crawling-indexing/consolidate-duplicate-urls?visit_id=638316025548026739-4151637945&rd=1
What is the reason why this URL (and others) are build like that?
From what I can see, are all URLs wrong (for example template modus with plugin Media Icon) :
```
<link rel="shortcut icon" type="image/x-icon" href="themes/default/icon/favicon.ico">
<link rel="stylesheet" type="text/css" href="themes/modus/css/open-sans/open-sans.css"> <link rel="stylesheet" type="text/css" href="_data/combined/1sgez2i.css"> <link rel="canonical" href="/gallery/piwigo/"><meta name="viewport" content="width=device-width,initial-scale=1">
<meta name="description" content="Startseite">
<link rel="stylesheet" type="text/css" href="./plugins/Media_Icon/template/media_icon.css">
<script type="text/javascript" src="./plugins/ShareAlbum/template/js/clipboard.min.js?v14.0.0beta1"></script>
```
|
canonical url = basically wrong (and not only those ..)
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2011/comments
| 2 |
2023-09-29T16:56:08Z
|
2023-10-01T07:56:29Z
|
https://github.com/Piwigo/Piwigo/issues/2011
| 1,919,615,763 | 2,011 |
[
"Piwigo",
"Piwigo"
] |
In the edit photo page, when opening the "add album" selector to associate photo with albums, we get a:
> PHP Warning: Undefined array key "show_root_btn" in album_selector.inc.tpl.php
@osworx has provided a fix on #1999 but I don't agree with the solution and I have another one.
|
PHP Warning: Undefined array key "show_root_btn" in album_selector.inc.tpl.php
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2009/comments
| 0 |
2023-09-28T16:48:57Z
|
2023-09-28T16:49:29Z
|
https://github.com/Piwigo/Piwigo/issues/2009
| 1,917,918,112 | 2,009 |
[
"Piwigo",
"Piwigo"
] |
After update from 2.95 getting error Fatal error: Uncaught Error: Call to undefined function mb_substr() in /var/www/photos/piwigo/admin/intro.php:379 Stack trace: #0 /var/www/photos/piwigo/admin.php(345): include() #1 {main} thrown in /var/www/photos/piwigo/admin/intro.php on line 379
|
Trouble with update
|
https://api.github.com/repos/Piwigo/Piwigo/issues/2008/comments
| 3 |
2023-09-28T11:22:48Z
|
2023-10-05T16:18:14Z
|
https://github.com/Piwigo/Piwigo/issues/2008
| 1,917,291,309 | 2,008 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.