issue_owner_repo
listlengths
2
2
issue_body
stringlengths
0
261k
issue_title
stringlengths
1
925
issue_comments_url
stringlengths
56
81
issue_comments_count
int64
0
2.5k
issue_created_at
stringlengths
20
20
issue_updated_at
stringlengths
20
20
issue_html_url
stringlengths
37
62
issue_github_id
int64
387k
2.46B
issue_number
int64
1
127k
[ "Piwigo", "Piwigo" ]
With Piwigo 14.0.0beta3 (starting with beta1) we have implemented a new search system. One important decision in this new design is that a search can be "updated" with API method `pwg.images.filteredSearch.update`. Now let's take an example when it's a real problem: 1. on monday morning, Peter copies the url of his search `http://domain/index.php?/search/psk-20230927-QD6IP9evVB` and sends it to Matthew by email 2. on tuesday, Peter keeps working on this search, adds some filters and modify previously added filters 3. on wednesday, Matthew clicks on the link and will see the updated search of tueday, not the search as it was on monday That's a problem, because Peter certainly thinks that he has copied the search rules "as they are" at the moment of the copy. Updating a search was an interesting idea, to avoid too many lines in the `piwigo_search` table, but leads to this kind of user experience issue. We must revert this design decision and create a new search each time a parameter is modified/added/removed.
[search] a specific search can be changed after being shared
https://api.github.com/repos/Piwigo/Piwigo/issues/2007/comments
0
2023-09-27T14:29:49Z
2023-09-27T14:31:23Z
https://github.com/Piwigo/Piwigo/issues/2007
1,915,720,883
2,007
[ "Piwigo", "Piwigo" ]
Piwigo version: 13.8.0 I'm trying to upload an image to my piwigo instance from darktable, as can be seen in the nginx access log: ``` 192.168.100.12 - - [27/Sep/2023:08:57:52 +0200] "POST /ws.php?format=json HTTP/2.0" 200 88 "-" "darktable/4.5.0+723~g12fe3a93dd" ``` Upload fails, the following error is then logged in the nginx error log: ``` PHP message: PHP Fatal error: Uncaught mysqli_sql_exception: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 4 in /var/www/hostname/piwigo/include/dblayer/functions_mysqli.inc.php:132 Stack trace: #0 /var/www/hostname/piwigo/include/dblayer/functions_mysqli.inc.php(132): mysqli->query() #1 /var/www/hostname/piwigo/include/ws_functions/pwg.images.php(2397): pwg_query() #2 /var/www/hostname/piwigo/include/ws_core.inc.php(600): ws_images_uploadCompleted() #3 /var/www/hostname/piwigo/include/ws_protocols/rest_handler.php(41): PwgServer->invoke() #4 /var/www/hostname/piwigo/include/ws_core.inc.php(281): PwgRestRequestHandler->handleRequest() #5 /var/www/hostname/piwigo/ws.php(22): PwgServer->run() #6 {main} thrown in /var/www/hostname/piwigo/include/dblayer/functions_mysqli.inc.php on line 132" while reading response header from upstream, client: 192.168.100.12, server: hostname, request: "POST /ws.php?format=json HTTP/2.0", upstream: "fastcgi://127.0.0.1:9001", host: "hostname" ``` If I dump the offending query in `pwg.images.php(2397)`, it shows the problem: ``` 2023/09/27 08:57:52 [error] 7751#7751: *215 FastCGI sent in stderr: "PHP message: SELECT COUNT(*) AS nb_photos FROM piwigo_image_category WHERE category_id = ;PHP message: PHP Fatal error: Uncaught mysqli_sql_exception: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 4 in /var/www/hostname/piwigo/include/dblayer/functions_mysqli.inc.php:132 ``` So, the `category_id` is empty or missing from the `WHERE` clause. I would expect the query not to fail and the upload to succeed.
Upload from Darktable fails
https://api.github.com/repos/Piwigo/Piwigo/issues/2005/comments
3
2023-09-27T07:08:08Z
2024-06-15T08:32:34Z
https://github.com/Piwigo/Piwigo/issues/2005
1,914,845,239
2,005
[ "Piwigo", "Piwigo" ]
Hi, all. Can you help me with this issue: /config/www/_data/templates_c/1uyas8y_rafr8z^51f34276967318fc82694b733f6652fbc085696f_0.file.header.tpl.php on line 109 Warning : Attempt to read property "value" on null in /config/www/_data/templates_c/1uyas8y_rafr8z^51f34276967318fc82694b733f6652fbc085696f_0.file.header.tpl.php on line 109 ">
: Attempt to read property "value" on null in
https://api.github.com/repos/Piwigo/Piwigo/issues/2004/comments
11
2023-09-26T13:41:06Z
2023-10-16T12:36:23Z
https://github.com/Piwigo/Piwigo/issues/2004
1,913,543,655
2,004
[ "Piwigo", "Piwigo" ]
For example, if you search by words "orange" in album "bees", you should get zero results BUT : ![image](https://github.com/Piwigo/Piwigo/assets/9326959/3fead850-c2a4-4c61-8320-e4dfdb0ad54a) you actually get 368 results because "orange" matches the tag "orange" and you have 368 photos linked to this tag. The matching tag overides the global result.
[search] matching tags for search by words overiding other filters
https://api.github.com/repos/Piwigo/Piwigo/issues/2003/comments
0
2023-09-25T15:09:56Z
2023-09-25T15:12:32Z
https://github.com/Piwigo/Piwigo/issues/2003
1,911,728,503
2,003
[ "Piwigo", "Piwigo" ]
Using the latest 14.0.3beta and php 8.2.x results in numerous undefined keys and messages. Made for such a few PRs , but at least you should test it with php 8.2. by yourself. E.g. in **photos_add_direct.tpl** Undefined array kay "ADD_TO_ALBUM" Attempt to read property "value" on null **header.tpl** Undefined array key "U_RETURN" Undefined array key "USERNAME" Undefined array key "U_CHANGE_THEME" Undefined array key "U_FAQ" and so on .. Happens after a fresh installation and calling the pages for the first time!
[14.0.0.beta3] Many undefined keys and other messages
https://api.github.com/repos/Piwigo/Piwigo/issues/2001/comments
7
2023-09-24T15:04:20Z
2023-11-13T14:38:11Z
https://github.com/Piwigo/Piwigo/issues/2001
1,910,265,714
2,001
[ "Piwigo", "Piwigo" ]
Current display is (very) strange. 1. When hoovering the search menu, icons are hiden - width of the whole menu is flickering (see video). https://github.com/Piwigo/Piwigo/assets/1905204/4878823f-0791-4a24-8060-ac557b93357b 2. Searching by date will not let me to translate the items (see image): ![piwigo_1403pre_search_by_date](https://github.com/Piwigo/Piwigo/assets/1905204/95143110-7399-4ac0-8b11-76cc1ef624e3)
[14.0.3pre] Search menu & icons / search by date (translating)
https://api.github.com/repos/Piwigo/Piwigo/issues/2000/comments
5
2023-09-24T14:58:52Z
2023-09-26T12:13:37Z
https://github.com/Piwigo/Piwigo/issues/2000
1,910,263,948
2,000
[ "Piwigo", "Piwigo" ]
![image](https://github.com/Piwigo/Piwigo/assets/54360213/a9c8e340-7c80-4c63-8d03-01c3371ca6c6)
[search] icons overlap filter title
https://api.github.com/repos/Piwigo/Piwigo/issues/1987/comments
2
2023-09-21T08:57:57Z
2023-10-05T14:30:17Z
https://github.com/Piwigo/Piwigo/issues/1987
1,906,464,284
1,987
[ "Piwigo", "Piwigo" ]
This happens with the filters using selectize and the album filter.
[search] on click remove the dropdown for the filter closes
https://api.github.com/repos/Piwigo/Piwigo/issues/1986/comments
0
2023-09-20T13:40:45Z
2023-09-20T13:48:04Z
https://github.com/Piwigo/Piwigo/issues/1986
1,905,029,927
1,986
[ "Piwigo", "Piwigo" ]
![image](https://github.com/Piwigo/Piwigo/assets/54360213/8bed3fbd-5d23-4b9f-841b-74a22cec9dd5)
[search] tag filter not closing other filters
https://api.github.com/repos/Piwigo/Piwigo/issues/1984/comments
0
2023-09-19T09:00:21Z
2023-09-19T09:03:12Z
https://github.com/Piwigo/Piwigo/issues/1984
1,902,523,993
1,984
[ "Piwigo", "Piwigo" ]
Instead of a selectize, a custom widget like filetypes would be better.
[search] change filter by added_by into a "filetypes-style" list
https://api.github.com/repos/Piwigo/Piwigo/issues/1983/comments
0
2023-09-18T17:11:43Z
2023-09-18T17:17:53Z
https://github.com/Piwigo/Piwigo/issues/1983
1,901,398,733
1,983
[ "Piwigo", "Piwigo" ]
If you have many (thousands) sub-albums at a given level, Piwigo will perform very slow SQL queries, even if only 12 albums (by default) are displayed on the page. ``` SELECT c.*, user_representative_picture_id, nb_images, date_last, max_date_last, count_images, nb_categories, count_categories FROM categories c INNER JOIN user_cache_categories ucc ON id = cat_id AND user_id = 2 WHERE id_uppercat is NULL ORDER BY `rank` (this query time : 0.887 s) (total SQL time : 0.890 s) (total time : 0.939 s) (num rows : 12544 ) [20] SELECT * FROM images WHERE id IN (94254,[... huge number of image ids...],50510) ; (this query time : 0.122 s) (total SQL time : 1.012 s) (total time : 1.107 s) (num rows : 12521 ) [21] ```
optimize data load for huge number of sub-albums
https://api.github.com/repos/Piwigo/Piwigo/issues/1982/comments
9
2023-09-18T10:19:50Z
2023-11-28T13:14:15Z
https://github.com/Piwigo/Piwigo/issues/1982
1,900,614,575
1,982
[ "Piwigo", "Piwigo" ]
<details><summary>Warnings</summary> <p> ```php Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$registerPlugin is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$registerFilter is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$append is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$unregisterFilter is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /var/www/html/piwigo/include/cssmin.class.php on line 34 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$_codeFrame is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$_filterHandler is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$getLiterals is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$addLiterals is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$setLiterals is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$loadPlugin is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$_writeFile is deprecated in /var/www/html/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 ``` </p> </details> <details><summary>PHP Version</summary> <p> PHP 8.2.7 (cli) (built: Jun 9 2023 19:37:27) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.7, Copyright (c) Zend Technologies with Zend OPcache v8.2.7, Copyright (c), by Zend Technologies </p> </details> <details><summary>OS</summary> <p> No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 12 (bookworm) Release: 12 Codename: bookworm </p> </details>
Deprecated warnings
https://api.github.com/repos/Piwigo/Piwigo/issues/1979/comments
4
2023-09-13T22:06:15Z
2023-10-12T10:08:23Z
https://github.com/Piwigo/Piwigo/issues/1979
1,895,329,663
1,979
[ "Piwigo", "Piwigo" ]
I'm trying to use a custom themes directory, but this doesn't seem to work. [config_default.inc.php](https://github.com/Piwigo/Piwigo/blob/13.8.0/include/config_default.inc.php#L845) suggests that I can use `$conf['themes_dir']` to customise the directory where my themes reside. When I change this, however, and remove the default _themes_ directory, Piwigo is unable to find the themes anymore: > Warning: include(/themeconf.inc.php): failed to open stream: No such file or directory in /var/www/html/include/template.class.php on line 1141 > > Warning: include(): Failed opening '/themeconf.inc.php' for inclusion (include_path='.:/usr/local/lib/php') in /var/www/html/include/template.class.php on line 1141 > > Fatal error: Uncaught --> Smarty: Unable to load template 'file:menubar.tpl' <-- thrown in /var/www/html/include/smarty/libs/sysplugins/smarty_internal_template.php on line 195 It seems that (at least in some places), Piwigo ignores the `$conf['themes_dir']` setting. One of these places is in [commons.inc.php](https://github.com/Piwigo/Piwigo/blob/13.8.0/include/common.inc.php#L242): ` $template = new Template(PHPWG_ROOT_PATH.'themes', $theme );` There's probably more of such places, as I couldn't work around the issue by just changing that line. Could this be fixed so that I can use this setting? And if not, could it be removed from the defualt config file? Thanks, Guno
Not possible to use custom themes directory
https://api.github.com/repos/Piwigo/Piwigo/issues/1978/comments
1
2023-09-09T15:55:57Z
2023-12-28T15:48:08Z
https://github.com/Piwigo/Piwigo/issues/1978
1,888,795,490
1,978
[ "Piwigo", "Piwigo" ]
When downloading a format, the name is `<base name>.format_ext` and sometimes it is not name you want for your file. Here is the case I've been working on : a user has the following files : ``` CMYK_basename.pdf RGB_basename.svg [email protected] [email protected] Adobe_basename.svg [email protected] [email protected] ``` where `[email protected]` is used as base file and others as formats. With the implementation of format files automatic detection (see API method `pwg.images.formats.searchImage`), it is not possible to detect `[email protected]` as format of `[email protected]`. So I had to implement a "live rename" of the posted file name during check and upload : ``` add_event_handler('init', 'custom_plugin_init'); function custom_plugin_init() { global $template, $conf; if ( 'ws' == script_basename() and isset($_REQUEST['method']) and 'pwg.images.formats.searchImage' == $_REQUEST['method'] and isset($_POST['filename_list']) ) { $candidates = json_decode(stripslashes($_POST['filename_list']), true); foreach ($candidates as $format_external_id => $format_filename) { $candidates[$format_external_id] = custom_plugin_format_rename_input($format_filename); } $_POST['filename_list'] = json_encode($candidates); } if ( 'ws' == script_basename() and isset($_REQUEST['method']) and 'pwg.images.upload' == $_REQUEST['method'] and isset($_POST['name']) ) { $_POST['name'] = custom_plugin_format_rename_input($_POST['name']); } } function custom_plugin_format_rename_input($input_name) { $new_name = $input_name; // [email protected] => base file // // CMYK_basename.pdf => [email protected] // RGB_basename.svg => [email protected] // [email protected] => [email protected] // [email protected] => [email protected] // Adobe_basename.svg => [email protected] // [email protected] => [email protected] // [email protected] => [email protected] if (preg_match('/(CMYK|RGB|Adobe)_(\w+)(\.pdf|\.svg|@3xwhite\.png|@3xblue\.png)$/', $input_name, $matches)) { $pattern_to_template = array( 'CMYK#.pdf' => 'RGB_%[email protected]', 'RGB#.svg' => 'RGB_%[email protected]', 'RGB#@3xwhite.png' => 'RGB_%[email protected]', 'Adobe#.svg' => 'RGB_%[email protected]', 'Adobe#@3xwhite.png' => 'RGB_%[email protected]', 'Adobe#@3xblue.png' => 'RGB_%[email protected]', ); $key = $matches[1].'#'.$matches[3]; if (isset($pattern_to_template[$key])) { $new_name = sprintf($pattern_to_template[$key], $matches[2]); } } return $new_name; } ``` That's enough for the input of formats, but when you download, you get `[email protected]` instead of `[email protected]` as provided during upload. So I need a trigger `loc_action_before_http_headers` in `action.php` to be able to write: ``` add_event_handler('loc_action_before_http_headers', 'custom_plugin_loc_action_before_http_headers'); function custom_plugin_loc_action_before_http_headers() { global $element_info; // [email protected] => CMYK_basename.pdf // [email protected] => RGB_basename.svg // [email protected] => [email protected] // [email protected] => Adobe_basename.svg // [email protected] => [email protected] // [email protected] => [email protected] $ext_to_pattern = array( 'print.pdf' => 'CMYK_%s.pdf', 'rgb.svg' => 'RGB_%s.svg', 'rgb.white.png' => 'RGB_%[email protected]', 'adobe.svg' => 'Adobe_%s.svg', 'adobe.white.png' => 'Adobe_%[email protected]', 'adobe.blue.png' => 'Adobe_%[email protected]', ); if (preg_match('/^RGB_(.+)@3xblue\.('.implode('|', array_map(function ($a) { return preg_quote($a); }, array_keys($ext_to_pattern))).')$/', $element_info['file'], $matches)) { $element_info['file'] = sprintf($ext_to_pattern[ $matches[2] ], $matches[1]); } } ``` By the way, here is the appropriate piece of local configuration: ``` $conf['enable_formats'] = true; $conf['format_ext'] = array( 'rgb.white.png', 'rgb.svg', 'adobe.blue.png', 'adobe.white.png', 'adobe.svg', 'print.pdf', 'png', // to let the upload format accept *@3xblue.png / *@3xwhite.png 'svg', // to let the upload format accept *.svg 'pdf', // to let the upload format accept *.pdf ); ``` Let's add this trigger `loc_action_before_http_headers` :-)
need trigger to trick file name on download
https://api.github.com/repos/Piwigo/Piwigo/issues/1977/comments
0
2023-09-08T15:51:34Z
2023-11-24T17:06:59Z
https://github.com/Piwigo/Piwigo/issues/1977
1,887,934,482
1,977
[ "Piwigo", "Piwigo" ]
"confirm merge" & "cancel" ![image](https://github.com/Piwigo/Piwigo/assets/54360213/6265b88b-c6b2-4a5a-ab22-12ecc9d5ed9c)
Tag manager missing translations
https://api.github.com/repos/Piwigo/Piwigo/issues/1976/comments
0
2023-09-06T13:16:41Z
2023-09-07T08:36:57Z
https://github.com/Piwigo/Piwigo/issues/1976
1,883,998,723
1,976
[ "Piwigo", "Piwigo" ]
If there ismore than one row of thumbnails there is no margin between the rows ![image](https://github.com/Piwigo/Piwigo/assets/54360213/ed32a32e-0e47-4beb-9848-db225f4db2fc)
Thumbnails when uplaoded have no margin on bottom
https://api.github.com/repos/Piwigo/Piwigo/issues/1975/comments
0
2023-09-04T14:47:39Z
2023-09-07T08:36:22Z
https://github.com/Piwigo/Piwigo/issues/1975
1,880,443,134
1,975
[ "Piwigo", "Piwigo" ]
In all tabs except properties there is a breadcrumb in the top section. This is repetitive. ![image](https://github.com/Piwigo/Piwigo/assets/54360213/2879a24d-386a-4a69-b292-8fd9fe7616f3)
In edit album breadcrumb appears in different tabs
https://api.github.com/repos/Piwigo/Piwigo/issues/1974/comments
0
2023-09-04T14:44:43Z
2023-09-07T08:36:13Z
https://github.com/Piwigo/Piwigo/issues/1974
1,880,437,904
1,974
[ "Piwigo", "Piwigo" ]
Can't scroll down to see last setting (locked album) ![image](https://github.com/Piwigo/Piwigo/assets/54360213/729843c1-305c-4138-bc9f-06eee1ac171e)
Edit album page the bottom bar overlaps content
https://api.github.com/repos/Piwigo/Piwigo/issues/1973/comments
0
2023-09-04T14:10:02Z
2023-09-07T08:36:04Z
https://github.com/Piwigo/Piwigo/issues/1973
1,880,374,715
1,973
[ "Piwigo", "Piwigo" ]
![image](https://github.com/Piwigo/Piwigo/assets/54360213/475df7a4-158a-47a8-a0f7-b8828482c2fc)
Number of pictures in sub album icon needs margin
https://api.github.com/repos/Piwigo/Piwigo/issues/1972/comments
0
2023-09-04T13:27:15Z
2023-09-07T08:35:50Z
https://github.com/Piwigo/Piwigo/issues/1972
1,880,291,477
1,972
[ "Piwigo", "Piwigo" ]
I recently made a discovery on my Canon R6: the shutter speed EXIF data that is saved is not exactly the same as the shutter speed that is set. For example, a recent photo I took at a shutter speed of 1/640 is saved by the camera as 104858/67109119 (!), which is equal to 1/639.999990463. That's pretty close to 1/640, and most EXIF utilities I've used on the photo report 1/640. But in my Piwigo gallery, it's reported as 1/639, so I think that Piwigo must be truncating that denominator instead of rounding up. That looks odd, and it would be nice if it could show 1/640. For example: https://www.daveguertin.net/picture.php?/8292/category/all Or is there a setting somewhere that I could change?
EXIF display truncates shutter speed instead of rounding
https://api.github.com/repos/Piwigo/Piwigo/issues/1971/comments
2
2023-09-01T14:00:10Z
2023-11-27T23:06:24Z
https://github.com/Piwigo/Piwigo/issues/1971
1,877,483,214
1,971
[ "Piwigo", "Piwigo" ]
Goodmorning,i receive multiple errors on collection tab Warning: Undefined array key "cat" in /opt/lampp/htdocs/xxx/_data/templates_c/xr1exc^0bb276d1f6c18ee93c79b1cfc4aa034f5a00551d_0.file.menubar_user_collections.tpl.php on line 51 Warning: Attempt to read property "value" on null in /opt/lampp/htdocs/xxx/_data/templates_c/xr1exc^0bb276d1f6c18ee93c79b1cfc4aa034f5a00551d_0.file.menubar_user_collections.tpl.php on line 51 Warning: Trying to access array offset on value of type null in /opt/lampp/htdocs/xxx/_data/templates_c/xr1exc^0bb276d1f6c18ee93c79b1cfc4aa034f5a00551d_0.file.menubar_user_collections.tpl.php on line 51
undefined array key
https://api.github.com/repos/Piwigo/Piwigo/issues/1970/comments
9
2023-08-31T13:31:21Z
2023-12-04T18:15:31Z
https://github.com/Piwigo/Piwigo/issues/1970
1,875,540,672
1,970
[ "Piwigo", "Piwigo" ]
There is a new documentation, in French only for now, available on https://doc-fr.piwigo.org/ Let's promote it in the help pages of the administration. The documentation provides much more details than the embedded pages.
promote new french documentation in admin help pages
https://api.github.com/repos/Piwigo/Piwigo/issues/1969/comments
0
2023-08-26T11:11:03Z
2023-08-26T11:12:07Z
https://github.com/Piwigo/Piwigo/issues/1969
1,868,030,357
1,969
[ "Piwigo", "Piwigo" ]
In #1946 Piwigo has acquired the ability to easily filter photos by posted date with 4 pre-defined values: - in the last 7 days - in the last 30 days - in the last 6 months - in the last year After a few weeks of test and based on other filter systems I have seen, I think we should better have: - in the last 24 hours - in the last 7 days - in the last 30 days - in the last 3 months - in the last 6 months - year 2023 - year 2022 - year 2021 - ... Of course, we only display years with at least 1 photo posted.
[search] filter by year of posting
https://api.github.com/repos/Piwigo/Piwigo/issues/1968/comments
1
2023-08-26T10:49:42Z
2023-08-26T10:58:30Z
https://github.com/Piwigo/Piwigo/issues/1968
1,868,020,718
1,968
[ "Piwigo", "Piwigo" ]
`O'Fallon` becomes `O\'Fallon` and there is no way to correct it. Creating a tag with a quote does not lead to the same issue. Only renaming.
[tag manager] renaming a tag with a quote also adds a slash
https://api.github.com/repos/Piwigo/Piwigo/issues/1967/comments
0
2023-08-23T16:55:10Z
2023-08-23T16:56:17Z
https://github.com/Piwigo/Piwigo/issues/1967
1,863,695,109
1,967
[ "Piwigo", "Piwigo" ]
Encapsulated PostScript file : vector image.
support for EPS files
https://api.github.com/repos/Piwigo/Piwigo/issues/1966/comments
0
2023-08-21T16:40:42Z
2023-08-21T17:00:07Z
https://github.com/Piwigo/Piwigo/issues/1966
1,859,751,054
1,966
[ "Piwigo", "Piwigo" ]
Produced by Adobe Photoshop
support for PSD files
https://api.github.com/repos/Piwigo/Piwigo/issues/1965/comments
0
2023-08-21T16:34:14Z
2023-08-21T16:38:24Z
https://github.com/Piwigo/Piwigo/issues/1965
1,859,741,140
1,965
[ "Piwigo", "Piwigo" ]
When opening a canonical url like `picture.php?/75` (without any section provided), Piwigo 13 (and 14beta) with PHP 8.1 throws this error: > Deprecated: strncmp(): Passing null to parameter #1 ($string1) of type string is deprecated in include/functions_url.inc.php on line 463
canonical url and Deprecated: strncmp(): Passing null to parameter
https://api.github.com/repos/Piwigo/Piwigo/issues/1964/comments
0
2023-08-21T13:38:22Z
2023-08-21T13:43:57Z
https://github.com/Piwigo/Piwigo/issues/1964
1,859,395,575
1,964
[ "Piwigo", "Piwigo" ]
https://github.com/Piwigo/Piwigo/blob/4ac772224f25f1b2f3bf94bd1f9c45b653d561f5/include/functions_html.inc.php#L614 While this funtion with strtolower may have rights for some languages, it makes no sense for a language like German. Maybe also other languages will write the first letter uppercase, there should be a (config) setting to avoid such behaviour. That is also valid for the line 618 below.
Why lower text?
https://api.github.com/repos/Piwigo/Piwigo/issues/1963/comments
3
2023-08-20T13:35:00Z
2023-08-23T09:36:48Z
https://github.com/Piwigo/Piwigo/issues/1963
1,858,127,331
1,963
[ "Piwigo", "Piwigo" ]
Hello team, using the latest release of Piwigo (14.0.0beta2) with php 8.2.x is generally working fine. What I am having troubles, is HOW the loading of languages is working. For example: installed Piwigo with German (de_DE / code = de) as default. But I am in the need of presenting **German AND Austrian language at the same time** (in the frontend only). So, I have created another language called de_AT in a new folder. Is selectable and defineable as default - (see image below): ![grafik](https://github.com/Piwigo/Piwigo/assets/1905204/958f83e7-53dc-4568-a0f1-f29fa94320b0) But, the problem is, that while de_DE IS deactivated (see image again), the strings from the new de_AT file are NOT loaded. Example: in Germany it is Januar (January), but in Austria it is Jänner. But Januar (from the de_DE file) is displayed always (see image below): ![grafik](https://github.com/Piwigo/Piwigo/assets/1905204/7b716b20-c352-4e8e-925f-6c12908990f7) As written above, I need both languages in one installation. Overwriting the original variable is therefore no option. Also not an option to delete the de_DE language files. **Second**: how (and when) are languages loaded (for the frontend)? **Third**: what for is the file tools/language/translation_valided.inc.php ? Can see there is a section de_DE - but what for are these values? **Forth**: as I can see (example en_US), that there are only a few values defined. I then assume, that the en_GB (or en_UK) is loaded per default, and the values of the en_US should overwrite then them. Same should be available when using de_DE AND de_AT (because there are only a few minor differences between them ..). Hope someone can answer my questions .. and maybe present a fix ..
[Version 14.x] > loading language(s) / default language / general understanding of languages ?
https://api.github.com/repos/Piwigo/Piwigo/issues/1962/comments
0
2023-08-20T10:25:25Z
2023-08-20T10:25:25Z
https://github.com/Piwigo/Piwigo/issues/1962
1,858,072,385
1,962
[ "Piwigo", "Piwigo" ]
When running php 8.1, I get this Deprecation warning with piwigo 13.8.0: ``` Deprecated: nl2br(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/piwigo/include/functions_plugins.inc.php on line 214 ``` It occurs on the main page a lot and in each album or photo once. I tested it also with php8.2 where I get this warning as well + a ton more. ``` [Piwigo](https://piwigo.org/) 13.8.0 Installed on 24 April 2022, 1 year 3 months 3 weeks 2 days ago Operating system: Linux PHP: 8.1.22 MySQL: 10.5.19-MariaDB-0+deb11u2 [2023-08-18 12:37:00] Graphics Library: External ImageMagick 6.9.11-60 ```
PHP8.1: Deprecated: nl2br(): Passing null to parameter #1
https://api.github.com/repos/Piwigo/Piwigo/issues/1960/comments
2
2023-08-18T12:33:05Z
2023-10-23T08:03:57Z
https://github.com/Piwigo/Piwigo/issues/1960
1,856,648,398
1,960
[ "Piwigo", "Piwigo" ]
#1144 is a more general issue mixing several image file formats. Here I focus on `HEIC` support. As of August 2023, `HEIC` is absolutely not supported by all web browsers (only Safari) so the simple solution is to generate a `JPEG` representative of the `*.heic` file. Just like we do for `*.pdf` files. Current versions of ImageMagick can do it.
support for HEIC
https://api.github.com/repos/Piwigo/Piwigo/issues/1959/comments
0
2023-08-18T12:13:57Z
2023-08-21T15:35:51Z
https://github.com/Piwigo/Piwigo/issues/1959
1,856,621,912
1,959
[ "Piwigo", "Piwigo" ]
Hello ! I just installed piwigo to try it and ran into an error: When I visited the photos_add page I had a warnings about some php config values. I tried to hide the warning and the page reloaded into an error : ``` Warning: Undefined array key "setup_warnings" in /var/www/piwigo/_data/templates_c/p6jhns^a89b9dd2b03da870ac5f8f79b4ece1a8cca1ddc7_0.file.photos_add_direct.tpl.php on line 488 Warning: Attempt to read property "value" on null in /var/www/piwigo/_data/templates_c/p6jhns^a89b9dd2b03da870ac5f8f79b4ece1a8cca1ddc7_0.file.photos_add_direct.tpl.php on line 488 Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /var/www/piwigo/_data/templates_c/p6jhns^a89b9dd2b03da870ac5f8f79b4ece1a8cca1ddc7_0.file.photos_add_direct.tpl.php:488 Stack trace: #0 /var/www/piwigo/include/smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_64dde9cc6a1609_83470618() #1 /var/www/piwigo/include/smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode() #2 /var/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php(216): Smarty_Template_Compiled->render() #3 /var/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_templatebase.php(238): Smarty_Internal_Template->render() #4 /var/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_templatebase.php(116): Smarty_Internal_TemplateBase->_execute() #5 /var/www/piwigo/include/template.class.php(469): Smarty_Internal_TemplateBase->fetch() #6 /var/www/piwigo/include/template.class.php(392): Template->parse() #7 /var/www/piwigo/admin/photos_add_direct.php(158): Template->assign_var_from_handle() #8 /var/www/piwigo/admin/photos_add.php(73): include('...') #9 /var/www/piwigo/admin.php(345): include('...') #10 {main} thrown in /var/www/piwigo/_data/templates_c/p6jhns^a89b9dd2b03da870ac5f8f79b4ece1a8cca1ddc7_0.file.photos_add_direct.tpl.php on line 488 ``` I dug into the php files and found the cause of the error : When you enable hide_warnings, [setup_warnings doesn't get set in the template variables](https://github.com/Piwigo/Piwigo/blob/29ccabc89f4b00f67731e612cf84c8f16beaaa53/admin/include/photos_add_direct_prepare.inc.php#L184), and thus [count() is called on a null value](https://github.com/Piwigo/Piwigo/blob/29ccabc89f4b00f67731e612cf84c8f16beaaa53/admin/themes/default/template/photos_add_direct.tpl#L404) in the template. I fixed the error by setting the variable to an empty array if hide_warnings is enabled but there might be better ways to go about it: ```diff diff --git a/admin/include/photos_add_direct_prepare.inc.php a/admin/include/photos_add_direct_prepare.inc.php 216a217,222 > } else { > $template->assign( > array( > 'setup_warnings' => array() > ) > ); ```
TypeError on photos_add with hide_warnings = true
https://api.github.com/repos/Piwigo/Piwigo/issues/1958/comments
1
2023-08-17T10:16:01Z
2024-05-05T19:14:53Z
https://github.com/Piwigo/Piwigo/issues/1958
1,854,705,329
1,958
[ "Piwigo", "Piwigo" ]
When performing a search with filter "by words" with "album name" and/or "album description" and/or "tags" checked, then you might have some tags/albums matching the search. Like the previous "quicksearch", we want to show the albums/tags found. ![image](https://github.com/Piwigo/Piwigo/assets/9326959/34447efc-af03-4440-aba0-0d21a0912a3a) ![image](https://github.com/Piwigo/Piwigo/assets/9326959/c372e3f4-aefa-40f9-9646-25ef86951056)
[search] tags and albums found with search by words
https://api.github.com/repos/Piwigo/Piwigo/issues/1957/comments
0
2023-08-17T09:12:19Z
2023-08-17T09:49:56Z
https://github.com/Piwigo/Piwigo/issues/1957
1,854,588,149
1,957
[ "Piwigo", "Piwigo" ]
When calling `get_cat_display_name_cache` with `single_link=true`, you get (with PHP 8.1) : > Notice : Only variables should be passed by reference in `include/functions_html.inc.php` on line 115
get_cat_display_name_cache with single_link, variable by reference
https://api.github.com/repos/Piwigo/Piwigo/issues/1956/comments
0
2023-08-17T08:51:14Z
2023-08-17T08:56:26Z
https://github.com/Piwigo/Piwigo/issues/1956
1,854,554,144
1,956
[ "Piwigo", "Piwigo" ]
Imagine you're browsing an album and you want to search photos inside this album. Let's switch to the new search engine, filtered on the current album and let the user add other search criteria (posted date, file type...) ![search in this set](https://sandbox.piwigo.com/i?/uploads/4/y/1/4y1zzhnrnw//2023/04/26/20230426135142-3f7c7f4d-xx.png)
[search] search within this album, search within this tag
https://api.github.com/repos/Piwigo/Piwigo/issues/1955/comments
2
2023-08-12T14:46:24Z
2023-08-16T15:01:37Z
https://github.com/Piwigo/Piwigo/issues/1955
1,848,051,883
1,955
[ "Piwigo", "Piwigo" ]
Hello, Is this possible to implement a /health endpoint on your API. Something that will do https://testfully.io/blog/api-health-check-monitoring/ Thanks Thomas
Implement /health api endpoint
https://api.github.com/repos/Piwigo/Piwigo/issues/1954/comments
2
2023-08-10T09:05:03Z
2023-08-12T06:09:02Z
https://github.com/Piwigo/Piwigo/issues/1954
1,844,740,170
1,954
[ "Piwigo", "Piwigo" ]
In Piwigo 13 and before, the search url looks like `index.php?/search/123`. Easy to understand that there is a search `122` and `121` before that. Anybody can perfectly open it and discover what has been searched before. Not the level of privacy we want for Piwigo. I've been thinking about it (with @MatthieuLP ) and we've decided to switch to a `search_uuid` system, for example `index.php?/search/psk-20230809-thuVvgrfrG` where: - `psk` means "piwigo search key' - `20230809` is the date - `thuVvgrfrG` is randomly generated This way, quite impossible to "spy" on other users searches. Furthermore, with the new search system being prepared for Piwigo 14, a search can be "updated" (in Piwigo 13, you could only created a new search when you wanted to modify search criteria). We have also thought about this issue with @MatthieuLP and concluded: 1. `pwg.images.filteredSearch.update` must forbid update if the requester is not the creator of the search 2. when opening a search url (provided by a coworker for example) that is not ours, fork (duplicate) the search and redirect on its url
[search] prevent spying searches made by other users
https://api.github.com/repos/Piwigo/Piwigo/issues/1953/comments
0
2023-08-09T17:18:14Z
2023-08-12T14:41:01Z
https://github.com/Piwigo/Piwigo/issues/1953
1,843,703,033
1,953
[ "Piwigo", "Piwigo" ]
The fallback to display the content of the database configuration file to be written manually, if the install script can not write the file, is not working. The script checks if the file could be opend, but even it could not, it tires to write to the file pointer, resulting in the error: `PHP Fatal error: Uncaught TypeError: fputs(): Argument #1 ($stream) must be of type resource, bool given in /xxx/www/install.php:328` After the fatal error, the execution of the script is canceled and the fallback to display the configuration settings to the user is not working.
Fallback if database.inc.php not working
https://api.github.com/repos/Piwigo/Piwigo/issues/1951/comments
0
2023-08-08T19:33:14Z
2023-08-08T19:33:14Z
https://github.com/Piwigo/Piwigo/issues/1951
1,841,940,714
1,951
[ "Piwigo", "Piwigo" ]
I installed Bootstrap Darkroom, activated, made it default, even cleared user cache and disabled Modus but I still see Modus theme. What's going on? This simple things should not be a pain in the ass. I am using latest version 13.8. If I disable the other themes I get: ``` Warning: include(/themeconf.inc.php): Failed to open stream: No such file or directory in /var/www/piwigo/include/template.class.php on line 1141 Warning: include(): Failed opening '/themeconf.inc.php' for inclusion (include_path='.:/usr/share/php') in /var/www/piwigo/include/template.class.php on line 1141 Fatal error: Uncaught --> Smarty: Unable to load template 'file:menubar.tpl' <-- thrown in /var/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 195 ``` wtf?
Theme does not change
https://api.github.com/repos/Piwigo/Piwigo/issues/1950/comments
3
2023-08-02T10:51:05Z
2023-08-12T14:42:41Z
https://github.com/Piwigo/Piwigo/issues/1950
1,832,940,733
1,950
[ "Piwigo", "Piwigo" ]
# Context This occured when an album's description contains HTML : ```html <style> .additional_info { max-width:9999px; } .additional_info p { text-align:center; } .additional_info iframe { margin:0px auto; display:block; } </style> ``` # Issue Currently, the server removes all markups like `<style>` and `</style>`. However the content in between stays and markups are replaced by line breaks : ``` id: "131", name: "My album", comment: " .additional_info { max-width:9999px; } .additional_info p { text-align:center; } .additional_info iframe { margin:0px auto; display:block; } ", ``` # Expected The server should then remove this content, for both <style> and <script> which should not be displayed.
Content of HTML <script> and <style> is not removed from API return data
https://api.github.com/repos/Piwigo/Piwigo/issues/1949/comments
0
2023-08-02T10:25:33Z
2023-08-02T10:25:33Z
https://github.com/Piwigo/Piwigo/issues/1949
1,832,899,210
1,949
[ "Piwigo", "Piwigo" ]
See details on https://github.com/Piwigo/Piwigo/pull/1944#issuecomment-1651830787
replace cssmin.class.php by minify
https://api.github.com/repos/Piwigo/Piwigo/issues/1948/comments
0
2023-08-02T09:49:38Z
2024-07-01T13:18:15Z
https://github.com/Piwigo/Piwigo/issues/1948
1,832,839,019
1,948
[ "Piwigo", "Piwigo" ]
Hey guys any chance you could add Piwigo to the Umbrel OS app store? https://apps.umbrel.com/ https://umbrel.com/
Umbrel OS App Store
https://api.github.com/repos/Piwigo/Piwigo/issues/1947/comments
0
2023-07-24T15:56:23Z
2023-07-24T15:56:23Z
https://github.com/Piwigo/Piwigo/issues/1947
1,818,704,332
1,947
[ "Piwigo", "Piwigo" ]
With values among {7 last days, 30 last days, 6 last months, 1 last year}
[search] filter by posted date
https://api.github.com/repos/Piwigo/Piwigo/issues/1946/comments
0
2023-07-24T14:49:12Z
2023-08-02T09:51:09Z
https://github.com/Piwigo/Piwigo/issues/1946
1,818,582,804
1,946
[ "Piwigo", "Piwigo" ]
In the new multi-criteria search when you delete an empty filter and then go to the filter manager and validate the form, on the reload, the deleted filter is back in the filter list. Reproduce the issue : - Open a filter and click 'Delete' action - Open the filter manager - Click validate When the page reloads, the filter you deleted should be back. A semi-fix to this issue is to change ``` $("#addLinkedAlbum").has(e.target).length === 0 ``` to ``` $("#addLinkedAlbum").has(e.target).length !== 0 ``` But it breaks the filter's closing when you click outside them. For now we choose to keep it as it is because the path to reproduce is unlikely to happen and can be worked around if needed.
[search] Empty filter deletion is bugged
https://api.github.com/repos/Piwigo/Piwigo/issues/1945/comments
2
2023-07-24T09:41:41Z
2023-08-02T09:53:15Z
https://github.com/Piwigo/Piwigo/issues/1945
1,818,039,228
1,945
[ "Piwigo", "Piwigo" ]
Hello all, I just want ask if any of the following issues are known by you and have already a fix, as I checked the release notes after 12.2.0 and found no reference to them: - CVE-2022-32297: Second-Order SQL Injection https://github.com/sth276/research/blob/main/piwigo_vul/Second-Order%20SQL%20Injection%20Vulnerabilities%20in%20Piwigo.md - CVE-2022-26267: information disclosure in /admin/maintenance_actions.php. Sadly the original advisory does not exist anymore... https://nvd.nist.gov/vuln/detail/CVE-2022-26267 - CVE-2022-26266: SQL injection vulnerability via pwg.users.php. Thank you.
Status of reported issues for 12.2.0 having a CVE assigned
https://api.github.com/repos/Piwigo/Piwigo/issues/1942/comments
0
2023-07-18T20:02:37Z
2023-07-18T20:02:37Z
https://github.com/Piwigo/Piwigo/issues/1942
1,810,630,227
1,942
[ "Piwigo", "Piwigo" ]
`pwg.images.filteredSearch.update` should accept a `filteypes` input parameter and the actual search should take it into account.
[search] filter by filetype
https://api.github.com/repos/Piwigo/Piwigo/issues/1941/comments
0
2023-07-10T13:17:38Z
2023-07-12T12:24:58Z
https://github.com/Piwigo/Piwigo/issues/1941
1,796,761,471
1,941
[ "Piwigo", "Piwigo" ]
If I make an API request with a mothode like pwg.groups.add I get invalid JSON data back: ` { stat: "ok", result: { username: "Chewie", status: "webmaster", theme: "bootstrap_darkroom", language: "de_DE", pwg_token: "7407944da77474e", charset: "utf-8", current_datetime: "2023-07-09 13:41:51", version: 13.8.0, available_sizes: [ "square", "thumb", "2small", "xsmall", "small", "medium", "large", "xlarge", "xxlarge" ], upload_file_types: "jpg,jpeg,png,gif", upload_form_chunk_size: 500 } } ` The correct code would be: ` { stat: "ok", result: { username: "Chewie", status: "webmaster", theme: "bootstrap_darkroom", language: "de_DE", pwg_token: "7407944da77474e", charset: "utf-8", current_datetime: "2023-07-09 13:41:51", version: "13.8.0", available_sizes: [ "square", "thumb", "2small", "xsmall", "small", "medium", "large", "xlarge", "xxlarge" ], upload_file_types: "jpg,jpeg,png,gif", upload_form_chunk_size: 500 } } ` Please change the output so that the program version is in quotes! version: 13.8.0 version: "13.8.0"
API returns invalid JSON
https://api.github.com/repos/Piwigo/Piwigo/issues/1940/comments
1
2023-07-09T12:19:12Z
2023-07-09T16:40:06Z
https://github.com/Piwigo/Piwigo/issues/1940
1,795,376,828
1,940
[ "Piwigo", "Piwigo" ]
hello I propose update the mailer he adds dsn configurator and authentification Gmail Compatible php 8.2 [phpmailer.zip](https://github.com/Piwigo/Piwigo/files/11994073/phpmailer.zip) these files are adding into ../include/phpmailer please look I am forking this my fork :) thanks K ;)
update mailer 6.5.1 to 6.8.0
https://api.github.com/repos/Piwigo/Piwigo/issues/1939/comments
1
2023-07-09T01:14:48Z
2023-08-02T10:46:58Z
https://github.com/Piwigo/Piwigo/issues/1939
1,795,189,236
1,939
[ "Piwigo", "Piwigo" ]
Hello, I just upgraded my server from Debian 11 to Debian 12, leading the PHP version to be upgraded from 7.4 from 8.2, and now I have all these issues printed on the web page when I try to access my Piwigo instance (copied below). Does anyone know where it comes from and if there is a workaround to fix it? Server: Debian 12.0 Piwigo version: 13.8.0 PHP: 8.2.7 SQL: 10.11.3-MariaDB-1 Debian 12 Thank you! ``` Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$registerPlugin is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$registerFilter is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$append is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$unregisterFilter is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$clearAssign is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property CssAtMediaStartToken::$MediaTypes is deprecated in /srv/www/piwigo/include/cssmin.class.php on line 34 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Variable::$do_else is deprecated in /srv/www/piwigo/_data/templates_c/r37wi4_1uwy3cn^fcd9cca320bed98a47ea8be8fbc88a12497fc8c6_0.file.header.tpl.php on line 141 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$_codeFrame is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$_filterHandler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$getLiterals is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$addLiterals is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$setLiterals is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$_writeFile is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$_foreach is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Variable::$do_else is deprecated in /srv/www/piwigo/_data/templates_c/r37wi4^fec25d4bae14c85cbb6bfaca8a0c14e7ad99a05f_0.file.menubar.tpl.php on line 28 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Variable::$do_else is deprecated in /srv/www/piwigo/_data/templates_c/r37wi4^fec25d4bae14c85cbb6bfaca8a0c14e7ad99a05f_0.file.menubar.tpl.php on line 62 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$loadPlugin is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated : Creation of dynamic property Smarty_Variable::$do_else is deprecated in /srv/www/piwigo/_data/templates_c/r37wi4^eaba834c5adb87385c4c23f41fc6b3241555f9e5_0.file.mainpage_categories.tpl.php on line 53 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated : Creation of dynamic property Smarty_Internal_Extension_Handler::$_updateScope is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /srv/www/piwigo/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 ```
php-8.2 issue with Piwigo 13.8.0
https://api.github.com/repos/Piwigo/Piwigo/issues/1938/comments
2
2023-07-08T21:42:46Z
2023-08-02T09:50:40Z
https://github.com/Piwigo/Piwigo/issues/1938
1,795,131,630
1,938
[ "Piwigo", "Piwigo" ]
In version 14beta1, when using the quicksearch input in the menu, Piwigo still uses the old system. Let's use the new multi-criteria search. We don't remove the quicksearch algorithm because it will still be used in 2 situations: 1. [Administration > Photos > Batch Manager > filter Search] 2. API method `pwg.images.search`
[search] quicksearch merge into new multi-criteria search
https://api.github.com/repos/Piwigo/Piwigo/issues/1937/comments
0
2023-07-03T13:22:01Z
2023-07-03T13:23:00Z
https://github.com/Piwigo/Piwigo/issues/1937
1,786,177,157
1,937
[ "Piwigo", "Piwigo" ]
Hi, After logging into the system with the admin user, I upload a photo to the system. ![2](https://github.com/Piwigo/Piwigo/assets/33905344/3683f114-afbd-488f-a25f-6fe53846abaf) ![3](https://github.com/Piwigo/Piwigo/assets/33905344/438b22a3-4c9d-4a6a-bfd4-4d4aaad02356) ![4](https://github.com/Piwigo/Piwigo/assets/33905344/820f8944-2451-4a06-9ff9-eb28c3d54195) Open the uploaded photo for editing. Write the XSS payload in the description and then save the photo. ![5](https://github.com/Piwigo/Piwigo/assets/33905344/432c00a2-6e40-414a-b41f-16a0e5af8b64) Now, anyone registered or not in the system will be affected by the XSS vulnerability when they open this image. ![6](https://github.com/Piwigo/Piwigo/assets/33905344/d2d6479d-0e0b-4ed3-8a6a-e91a736cbb96) ![7](https://github.com/Piwigo/Piwigo/assets/33905344/8bf313a3-ca26-408e-8596-536a53d95bc8) The latest version 13.7.0 is affected by this vulnerability.
Stored Cross-Site Scripting Vulnerability
https://api.github.com/repos/Piwigo/Piwigo/issues/1936/comments
1
2023-07-03T12:52:58Z
2023-07-07T09:06:36Z
https://github.com/Piwigo/Piwigo/issues/1936
1,786,125,168
1,936
[ "Piwigo", "Piwigo" ]
Good morning, Since update 13.7, I no longer have any plugins activated, the theme is no longer activated and my css mods in the localfile editor are no longer taken into account. When I try to connect to my admin account it works but when I want to access the settings and the administration I have this error: "Fatal error: Uncaught Error: Call to undefined function userprefs_get_param() in /var/www/piwigo/include/common.inc.php:234 Stack trace: #0 /var/www/piwigo/admin.php(16): include_once() #1 {main} thrown in /var/www/piwigo/include/common.inc.php on line 234" This error seems to indicate the line that refers to the theme: $template = new Template(PHPWG_ROOT_PATH.'admin/themes', userprefs_get_param('admin_theme', 'clear')); I don't know what to do... The backup has an error and it is not possible to go back. Can anyone help me? thanks in advance ;) Piwigo version: Piwigo 13.7.0 PHP Version: PHP 7.4.28
Error going to admin settings
https://api.github.com/repos/Piwigo/Piwigo/issues/1935/comments
1
2023-07-03T10:07:55Z
2023-07-03T10:30:41Z
https://github.com/Piwigo/Piwigo/issues/1935
1,785,832,445
1,935
[ "Piwigo", "Piwigo" ]
In Piwigo 14.0.0beta1, in the "added by" filter, the number of photos next to each user is wrong. If a photo is visible in several albums, it will be counted twice.
[search] incorrect number of photos for added_by users
https://api.github.com/repos/Piwigo/Piwigo/issues/1934/comments
0
2023-06-30T08:53:23Z
2023-06-30T08:54:23Z
https://github.com/Piwigo/Piwigo/issues/1934
1,782,153,951
1,934
[ "Piwigo", "Piwigo" ]
I have an album named "great britain". If I search for "great" in the "search by word" filter, it should find all photos belonging to this album. It does not. Indeed the SQL query generated is: ``` SELECT DISTINCT(id) FROM piwigo_images i INNER JOIN piwigo_image_category AS ic ON id = ic.image_id WHERE ( (file LIKE '%great%' OR name LIKE '%great%' OR comment LIKE '%great%') AND category_id IN (1)) ORDER BY date_available DESC, file ASC, id ASC ``` We see that album 1 matches the "great" word in its name (or description). The SQL queries says "it must belong to this album + its filename OR title OR description must match the word "great" also. We never occurs in my data sample. The `category_id IN (...)` is not correctly placed in the SQL query. We should have this instead: ``` SELECT DISTINCT(id) FROM piwigo_images i INNER JOIN piwigo_image_category AS ic ON id = ic.image_id WHERE ( (file LIKE '%great%' OR name LIKE '%great%' OR comment LIKE '%great%' OR category_id IN (1)) ) ORDER BY date_available DESC, file ASC, id ASC ```
[search] search by word in album names does not work
https://api.github.com/repos/Piwigo/Piwigo/issues/1933/comments
0
2023-06-29T15:35:39Z
2023-06-29T15:39:20Z
https://github.com/Piwigo/Piwigo/issues/1933
1,781,085,133
1,933
[ "Piwigo", "Piwigo" ]
Hello I don't remember if there is already a system to locate specific parts of the templates for the prefilter system. However it could be useful to have one (or more) in the properties panel of a photo around here https://github.com/Piwigo/Piwigo/blob/13.7.0/admin/themes/default/template/picture_modify.tpl#L227 And not having to rely on ugly search-replace like this (which broke in v13) https://github.com/mistic100/Piwigo-PhotoSphere/blob/787a7a34ac787a59b0fdc038c541e43ffaa0c279/include/admin_events.inc.php#L44-L48 Thanks
Add placeholder for settings in admin/picture_modify.tpl
https://api.github.com/repos/Piwigo/Piwigo/issues/1932/comments
5
2023-06-28T11:26:17Z
2023-07-07T19:35:42Z
https://github.com/Piwigo/Piwigo/issues/1932
1,778,748,421
1,932
[ "Piwigo", "Piwigo" ]
This issue follows the #1869 previously opened for the 14beta1. We will continue to implement new widgets and review the design of some that we already implemented.
[search] Continuation of new multi-criteria search implementation
https://api.github.com/repos/Piwigo/Piwigo/issues/1931/comments
1
2023-06-27T14:55:55Z
2023-08-02T10:53:26Z
https://github.com/Piwigo/Piwigo/issues/1931
1,777,170,979
1,931
[ "Piwigo", "Piwigo" ]
In Piwigo 13 and earlier, Piwigo was displaying the search rules in an on-demand popup. This is no longer useful with the new "always displayed" search criteria.
[search] remove the old search_rules
https://api.github.com/repos/Piwigo/Piwigo/issues/1930/comments
0
2023-06-27T13:20:25Z
2023-06-27T13:20:47Z
https://github.com/Piwigo/Piwigo/issues/1930
1,776,952,258
1,930
[ "Piwigo", "Piwigo" ]
With API method `pwg.categories.getList` there is no `search` param as in the `pwg.categories.getAdminList`. We need one to be able to filter the list of albums in the "search by album" filter. Related to #1869
[search] album selector can be filtered
https://api.github.com/repos/Piwigo/Piwigo/issues/1929/comments
0
2023-06-27T12:40:52Z
2023-06-27T12:41:34Z
https://github.com/Piwigo/Piwigo/issues/1929
1,776,842,680
1,929
[ "Piwigo", "Piwigo" ]
Hi, looks like downloading pictures from my piwigo 13.7.0 gives corrupted files. It's through download link : action.php?id=106772&part=e&download At the end of action.php, adding ob_end_clean(); before the "ob_flush() 'n' flush();" stuff solved my problem. Was reading a bit of : https://github.com/Piwigo/Piwigo/issues/643#issuecomment-769504627 and https://github.com/Piwigo/Piwigo/issues/1297#issuecomment-1266606502 The corrupted downloaded file had a bit of data added at the beginning and some removed at the end, as shown by this diff command ``` diff -y <(od -An -tx1 -w1 -v downloaded.jpg) <(od -An -tx1 -w1 -v original.jpg) | grep -E \(\<\|\>\) ``` ``` ef < bb < bf < > 51 > ff > d9 ```
Corrupted downloaded pictures / action.php
https://api.github.com/repos/Piwigo/Piwigo/issues/1928/comments
0
2023-06-26T22:51:55Z
2023-06-26T22:51:55Z
https://github.com/Piwigo/Piwigo/issues/1928
1,775,801,490
1,928
[ "Piwigo", "Piwigo" ]
There is a XSS stored vulnerability in version 13.7.0
XSS vulnerability
https://api.github.com/repos/Piwigo/Piwigo/issues/1926/comments
0
2023-06-12T08:10:13Z
2023-06-12T08:46:40Z
https://github.com/Piwigo/Piwigo/issues/1926
1,752,170,733
1,926
[ "Piwigo", "Piwigo" ]
After uploading multiple photos, they all show on a straight line which causes a horizontal scroll to show. ![image](https://github.com/Piwigo/Piwigo/assets/60923356/aa0f1e4f-ca5f-486f-ab62-44c6097eb9d0)
[Add photos] Hozizontal scroll on added photos page
https://api.github.com/repos/Piwigo/Piwigo/issues/1925/comments
0
2023-05-31T13:14:48Z
2023-06-14T14:03:59Z
https://github.com/Piwigo/Piwigo/issues/1925
1,734,205,991
1,925
[ "Piwigo", "Piwigo" ]
Access the 'Users' function and use the filter function ![image](https://github.com/Piwigo/Piwigo/assets/67749472/e2d503b5-096f-4528-97f1-8b9b015cc222) Observe the request on Burp Suite ![image](https://github.com/Piwigo/Piwigo/assets/67749472/7e4280b1-3b93-4c36-9bd3-a03aa1645555) Manipulate the 'order' or 'exclude[]' parameter by adding a single quote, and an error in MYSQL shows up, proving the existence of SQL injection ![image](https://github.com/Piwigo/Piwigo/assets/67749472/ee524c6f-96c5-4c0f-adf2-746a5d58a869) We can try to retrieve all the databases name with the error-based payload `id AND (SELECT 2690 FROM(SELECT COUNT(*),CONCAT(0x716b707671,(SELECT MID((IFNULL(CAST(schema_name AS NCHAR),0x20)),1,51) FROM INFORMATION_SCHEMA.SCHEMATA LIMIT 0,1),0x7162787071,FLOOR(RAND(0)*2))x FROM INFORMATION_SCHEMA.PLUGINS GROUP BY x)a)` , just increasing the LIMIT value to enumerate all the databases name ![image](https://github.com/Piwigo/Piwigo/assets/67749472/42af1d2b-c9aa-4d96-ad3a-511eecd03349) Analyze the vulnerability from the source code, locate the ws_users_getList() function (/piwigo/include/ws_functions/pwg.users.php), notice that 'order' was concat directly after the 'ORDER BY' clause without any kind of input sanitization. The same case happens for the 'exclude[]' parameter ![image](https://github.com/Piwigo/Piwigo/assets/67749472/4339a86f-c04f-4599-a87d-872bd6fea415) This vulnerability affects the latest version up to 13.7.0, and it is uncertain if other versions will be affected.
SQL Injection in the "Users" function of piwigo
https://api.github.com/repos/Piwigo/Piwigo/issues/1924/comments
0
2023-05-25T07:54:09Z
2023-05-29T10:27:38Z
https://github.com/Piwigo/Piwigo/issues/1924
1,725,285,095
1,924
[ "Piwigo", "Piwigo" ]
Hello I've installed Piwigo 13.7.0 on my server. after finishing the database and user setup i get a white site with the following errors/warnings ``` Warning: Undefined array key "modus_theme" in /var/www/clients/client1/web3/web/share/themes/modus/themeconf.inc.php on line 28 Warning: Trying to access array offset on value of type null in /var/www/clients/client1/web3/web/share/themes/modus/themeconf.inc.php on line 28 Warning: include(/var/www/clients/client1/web3/web/share/themes/modus/skins/.inc.php): Failed to open stream: No such file or directory in /var/www/clients/client1/web3/web/share/themes/modus/themeconf.inc.php on line 28 Warning: include(): Failed opening '/var/www/clients/client1/web3/web/share/themes/modus/skins/.inc.php' for inclusion (include_path='.:/usr/share/php') in /var/www/clients/client1/web3/web/share/themes/modus/themeconf.inc.php on line 28 Warning: Undefined array key "modus_theme" in /var/www/clients/client1/web3/web/share/themes/modus/themeconf.inc.php on line 42 Warning: Trying to access array offset on value of type null in /var/www/clients/client1/web3/web/share/themes/modus/themeconf.inc.php on line 42 Warning: include(/var/www/clients/client1/web3/web/share/themes/default/themeconf.inc.php): Failed to open stream: No such file or directory in /var/www/clients/client1/web3/web/share/include/template.class.php on line 1141 Warning: include(): Failed opening '/var/www/clients/client1/web3/web/share/themes/default/themeconf.inc.php' for inclusion (include_path='.:/usr/share/php') in /var/www/clients/client1/web3/web/share/include/template.class.php on line 1141 Fatal error: Uncaught --> Smarty: Unable to load template 'file:no_photo_yet.tpl' <-- thrown in /var/www/clients/client1/web3/web/share/include/smarty/libs/sysplugins/smarty_internal_template.php on line 195 ``` i am Using apache2 and php8 what can i do to fix this error ? thanks br
Fresh Piwigo 13.7.0 installation -> Undefined array key "modus_theme"
https://api.github.com/repos/Piwigo/Piwigo/issues/1923/comments
2
2023-05-24T20:13:07Z
2023-06-29T13:03:03Z
https://github.com/Piwigo/Piwigo/issues/1923
1,724,672,688
1,923
[ "Piwigo", "Piwigo" ]
After upgrading Piwigo to version 13.7.0, clicking on Dashboard (top left command) systematically leads to the fatal error: > Fatal error: Uncaught ArgumentCountError: Too few arguments to function get_piwigo_news(), 0 passed in /.../admin/intro.php on line 198 and exactly 2 expected in /.../admin/include/functions.php:3546 > > Stack trace: > #0 /.../admin/intro.php(198): get_piwigo_news() > #1 /.../admin.php(345): include('/srv/data/web/v...') > #2 {main} thrown in /.../admin/include/functions.php on line 3546
Clicking on Dashboard after the 13.7.0 update leads to a fatal error
https://api.github.com/repos/Piwigo/Piwigo/issues/1921/comments
2
2023-05-21T08:49:01Z
2023-06-29T18:23:09Z
https://github.com/Piwigo/Piwigo/issues/1921
1,718,421,787
1,921
[ "Piwigo", "Piwigo" ]
related to #1059 In the output of web API method `pwg.session.getStatus` add a `save_visits` parameter to tell the mobile app (or anything else) whether it should log visits and downloads.
pwg.session.getStatus add output parameter save_visits
https://api.github.com/repos/Piwigo/Piwigo/issues/1920/comments
0
2023-05-17T13:38:46Z
2023-08-03T09:19:54Z
https://github.com/Piwigo/Piwigo/issues/1920
1,713,944,108
1,920
[ "Piwigo", "Piwigo" ]
When making an album private, user "guest" is listed like any other user to be granted access. While it's a feature used by a very few administrators, it is far more often used by mistake. I would prefer to have "guest" removed. The problem is that we can't disable it in case it was used on purpose. So I propose to have a configuration setting like `$conf['album_permissions_list_guest']` to `false` by default, unless it was used in the past. <img width="680" alt="Screenshot 2023-05-16 at 12 23 10" src="https://github.com/Piwigo/Piwigo/assets/9326959/0bd8830e-d594-4484-8b47-0bb9d26466d1">
remove guest from users list in album permission
https://api.github.com/repos/Piwigo/Piwigo/issues/1919/comments
5
2023-05-16T10:23:37Z
2024-07-01T13:18:14Z
https://github.com/Piwigo/Piwigo/issues/1919
1,711,721,753
1,919
[ "Piwigo", "Piwigo" ]
After upgrade from 13.6.0 to 13.7.0 I noticed an issue with "Automatic sort order" function. **Http 400 Bad request - missing token** **Step to reproduce this issue:** 1. Albums > Manage > Automatic Sort Order 2. Select any type of option and submit. With previous release (13.6.0) this feature was working fine.
Bad Request on Automatic Sort Order
https://api.github.com/repos/Piwigo/Piwigo/issues/1918/comments
1
2023-05-16T08:27:02Z
2023-05-16T10:16:18Z
https://github.com/Piwigo/Piwigo/issues/1918
1,711,513,140
1,918
[ "Piwigo", "Piwigo" ]
Instead of using the `element_url` provided by `pwg.images.getInfos`, it would be better to have a `download_url` for several reasons: 1. if it is missing (or better, is empty), it would mean that the user has no download right 2. if provided the API user (eg mobile app) would use the right URL, such as `action.php?...` with or without `pwg_token`: download statistics would be more accurante
[pwg.images.getInfos] provide a download_url
https://api.github.com/repos/Piwigo/Piwigo/issues/1917/comments
1
2023-05-15T14:14:54Z
2023-08-03T08:52:57Z
https://github.com/Piwigo/Piwigo/issues/1917
1,710,202,292
1,917
[ "Piwigo", "Piwigo" ]
The issue was hot fixed in #1914, here is a long term solution
[Album Manager] Sort action triggers an error
https://api.github.com/repos/Piwigo/Piwigo/issues/1916/comments
0
2023-05-15T13:34:59Z
2023-05-15T15:04:45Z
https://github.com/Piwigo/Piwigo/issues/1916
1,710,119,938
1,916
[ "Piwigo", "Piwigo" ]
After upgrading to last version on an Alpine containerized VM (Piwigo 13.7 & PHP 8.1), the home access crash with: ``` Fatal error: Uncaught ValueError: The arguments array must contain 2 items, 1 given in /var/www/include/functions_session.inc.php:114 Stack trace: #0 /var/www/include/functions_session.inc.php(114): vsprintf() #1 /var/www/include/functions_session.inc.php(131): get_remote_addr_session_hash() #2 [internal function]: pwg_session_read() #3 /var/www/include/common.inc.php(150): session_start() #4 /var/www/index.php(11): include_once('...') #5 {main} thrown in /var/www/include/functions_session.inc.php on line 114 ``` https://github.com/Piwigo/Piwigo/blob/bb023d09ad1e8b73a7a95038b11c31f11c08f732/include/functions_session.inc.php#L109-L116 In this case `$_SERVER['REMOTE_ADDR']` give `/srv/mp/socket` and not the end-user IP. Seems related to PHP 8.1 and current OS environment, but small fix to robustify test: ``` if (strpos($_SERVER['REMOTE_ADDR'],':')===false && strpos($_SERVER['REMOTE_ADDR'],'.')) ``` ---- Full environment details: ``` [Piwigo](https://fr.piwigo.org/) 13.7.0 Système d'exploitation: Linux PHP: 8.1.19 MySQL: 10.6.13-MariaDB [2023-05-15 12:34:10] Bibliothèque graphique: ImageMagick 7.1.0-62 ```
php8.1 issue when accessing home - Alpine containerized VM - Root cause: REMOTE_ADDR = '/srv/mp/socket'
https://api.github.com/repos/Piwigo/Piwigo/issues/1915/comments
0
2023-05-15T10:38:20Z
2023-05-15T10:38:20Z
https://github.com/Piwigo/Piwigo/issues/1915
1,709,810,243
1,915
[ "Piwigo", "Piwigo" ]
Automatic album sorting is broken on Piwigo 13.7.0, see https://piwigo.org/forum/viewtopic.php?pid=186750#p186750 and https://github.com/Piwigo/Piwigo/commit/6b6ce95a5896bb9e2a85f0f23925c08315190177
[13.7.0] bad request on album sort
https://api.github.com/repos/Piwigo/Piwigo/issues/1914/comments
0
2023-05-15T08:23:01Z
2023-05-15T08:28:54Z
https://github.com/Piwigo/Piwigo/issues/1914
1,709,581,690
1,914
[ "Piwigo", "Piwigo" ]
Related to #93 Now that we have `user_prefs`, we can hide/show the subscription to newsletter link for each administrator independantly.
any administrator can subscribe to Piwigo newsletter
https://api.github.com/repos/Piwigo/Piwigo/issues/1913/comments
0
2023-05-10T12:38:30Z
2023-05-10T12:40:17Z
https://github.com/Piwigo/Piwigo/issues/1913
1,703,835,941
1,913
[ "Piwigo", "Piwigo" ]
They're getting very old looking. I've asked Alice to create new icons. The new icons must also be much bigger: we don't know how they're going to be displayed and recent screens have HDPI (high pixel density) so we need more pixels in images! <img width="1118" alt="image" src="https://user-images.githubusercontent.com/9326959/236441233-385be3c9-f633-4808-b38d-22d3ef94dc2e.png">
refresh mimetype icons
https://api.github.com/repos/Piwigo/Piwigo/issues/1912/comments
0
2023-05-05T11:00:31Z
2023-05-05T11:03:21Z
https://github.com/Piwigo/Piwigo/issues/1912
1,697,421,241
1,912
[ "Piwigo", "Piwigo" ]
Accessing the 'profile' page ![image](https://user-images.githubusercontent.com/27283436/236197441-196a43d0-f0ba-43ac-9448-f029bec196c7.png) Add the 'user_id' parameter with single quotes ![image](https://user-images.githubusercontent.com/27283436/236197644-ae97d84c-4296-4721-aa16-b21665c9500e.png) Discovering an error in MySQL can actually prove the existence of SQL injection, but we can still try using the sleep() function for testing ![image](https://user-images.githubusercontent.com/27283436/236197884-f0ce2eba-c8f8-4149-b00d-d749df754b5a.png) ![image](https://user-images.githubusercontent.com/27283436/236197944-08f57be8-55a0-4f3b-b0f0-5c9a817a38a5.png) //Try to analyze how this vulnerability was generated from a code level perspective. ![image](https://user-images.githubusercontent.com/27283436/236198160-a60843de-6d4d-4387-8a11-d1859ddcdb4d.png) First find '/admin/profile.php' ![image](https://user-images.githubusercontent.com/27283436/236198316-b51f7340-abce-4fa1-8140-237b263485dd.png) Track build_user() function (in the /Piwigo/include/functions_user.inc.php) ![image](https://user-images.githubusercontent.com/27283436/236198585-aef18e94-9fa6-49fc-ba1f-f6c4d66cec17.png) The '$user_id' enters the getuserdata() function, so continue tracking getuserdata() ![image](https://user-images.githubusercontent.com/27283436/236200448-87f3c1ab-eeb8-4fdb-8fb6-2595fa2a8b18.png) Finally, the '$user_id' variable will enter this string of SQL statements, which clearly does not filter the incoming parameter values, resulting in SQL injection ![image](https://user-images.githubusercontent.com/27283436/236200578-779570be-22ca-4459-8c2f-66fbbc2369ad.png) This vulnerability affects the latest version up to 13.6.0, and it is uncertain whether other versions will be affected.
There is a SQL Injection in the "profile" function of piwigo
https://api.github.com/repos/Piwigo/Piwigo/issues/1911/comments
0
2023-05-04T12:22:34Z
2023-05-05T08:25:03Z
https://github.com/Piwigo/Piwigo/issues/1911
1,695,904,246
1,911
[ "Piwigo", "Piwigo" ]
Before replicating this vulnerability, you need to first create a new album and access the "photos_add" function, and choose to create a new album ![image](https://user-images.githubusercontent.com/27283436/235838268-ab39be83-c3da-446c-bb35-714a9dfd6c7d.png) //like this ![image](https://user-images.githubusercontent.com/27283436/235838338-e1fed0c2-e344-4feb-a4e3-d01f724848cb.png) Then,accessing permalinks functionality ![image](https://user-images.githubusercontent.com/27283436/235837872-be02b38c-07e1-4f69-8441-181634101d86.png) click this ![image](https://user-images.githubusercontent.com/27283436/235838443-43cae672-198d-4e8a-b7c3-a8733f877cbf.png) Select the album you just created and use 'burp' to intercept this request ![image](https://user-images.githubusercontent.com/27283436/235838758-ad3686a9-2173-4a60-b862-aa652e3a607a.png) You can see this' cat_id 'parameter, which is where SQL injection exists ![image](https://user-images.githubusercontent.com/27283436/235838800-7c01adcd-44dc-4423-81c5-f03a6a9efa63.png) We are trying to add a single quotation mark to trigger an error in MySQL ![image](https://user-images.githubusercontent.com/27283436/235839002-ebdfd005-b9b9-4fc7-9508-257d39643ff5.png) We can also directly try using the sleep () function to trigger a delay ![image](https://user-images.githubusercontent.com/27283436/235839307-64cce621-3c8c-49ac-8ac1-92236683148c.png) It is not difficult to find that there is an SQL injection here. Next, we will analyze this problem from the code level. The vulnerability arises from '/admin/permalinks.php' //Start Here ![image](https://user-images.githubusercontent.com/27283436/235840323-b04c4561-5000-458d-a632-81c2ff4c24c7.png) In our data package, we passed in the "set_permalink" and “cat_ Id"parameter, and "cat_id"is greater than 0, so we can enter this if branch ![image](https://user-images.githubusercontent.com/27283436/235841193-cfa23f7e-6f2f-4e56-a45e-45ffb91e7ce6.png) Then, because we passed in the 'permalink' parameter, we actually entered the internal else branch ![image](https://user-images.githubusercontent.com/27283436/235841540-f7f3f886-d562-4317-9e7f-8ece506edbcf.png) Then we try to analyze the set_cat_permalink() function.(In /admin/include/functions_permalinks.php) ![image](https://user-images.githubusercontent.com/27283436/235841825-42a15428-17d5-41ba-8f81-375575afe18b.png) In the end, we can find this SQL statement, where '$cat_id' is passed directly into the SQL statement without any filtering.It is precisely this location that caused SQL injection ![image](https://user-images.githubusercontent.com/27283436/235842001-973b7eca-030c-4643-9aba-a52b9a960de5.png) This vulnerability exists in version 13.6.0, and it is uncertain whether this issue exists in earlier versions
There is a SQL Injection in the "permalinks" function of piwigo
https://api.github.com/repos/Piwigo/Piwigo/issues/1910/comments
0
2023-05-03T06:02:27Z
2023-05-05T08:24:43Z
https://github.com/Piwigo/Piwigo/issues/1910
1,693,458,747
1,910
[ "Piwigo", "Piwigo" ]
This vulnerability lies in the 'add tags' function in the backend. ![image](https://user-images.githubusercontent.com/27283436/235408999-91894fb4-dd88-461e-9984-efba5ba6ce34.png) Try adding a tag, and we will name it an HTML code ![image](https://user-images.githubusercontent.com/27283436/235409099-aaf83b53-7952-4e31-bc2e-f94ba84774ef.png) Try adding it, and we will find that our HTML code has been successfully embedded in the front-end ![image](https://user-images.githubusercontent.com/27283436/235409240-6f063adf-3e8d-490e-a69e-769d42bea4b1.png) ![image](https://user-images.githubusercontent.com/27283436/235409255-96361bd1-2984-4414-a7fc-5e273aae0d6a.png) Interestingly, when the administrator attempts to delete it, it will also trigger again(three times) ![image](https://user-images.githubusercontent.com/27283436/235409306-178b6616-e523-4544-8cd9-8673ee84c93a.png) ![image](https://user-images.githubusercontent.com/27283436/235409320-f0337c0a-4692-48f3-8d6d-44d1ff29aeac.png) ![image](https://user-images.githubusercontent.com/27283436/235409329-2ba7e734-6779-4788-817f-1f90a4386b0c.png) Of course, not only can img be used here, but it can also use more dangerous html code such as scripts.This may cause administrator COOKIE leakage or other more serious risks In my previous issue submission, I mentioned the CSRF vulnerability.In my previous issue submission, I mentioned the CSRF vulnerability. In fact, it can be combined with XSS vulnerabilities. We can generate such a CSRF POC ![image](https://user-images.githubusercontent.com/27283436/235409676-3f8910e8-17f2-4cb5-a398-c9fa673882c8.png) ![image](https://user-images.githubusercontent.com/27283436/235409760-8443cd88-9199-4634-bcfe-01db7eb7212f.png) After the administrator triggers it, a tag with malicious HTML code will be generated in the background. When the administrator accidentally accesses the tag, it can cause an attack ![image](https://user-images.githubusercontent.com/27283436/235409925-f6b3b3ac-68b5-44f6-928e-384256295139.png) ![image](https://user-images.githubusercontent.com/27283436/235409950-8b8d0702-1dc7-4901-b237-46bda3d32b3a.png)
There is a XSS vulnerability in the "add tags" function of piwigo
https://api.github.com/repos/Piwigo/Piwigo/issues/1909/comments
2
2023-05-01T05:13:45Z
2023-05-01T06:01:27Z
https://github.com/Piwigo/Piwigo/issues/1909
1,690,389,750
1,909
[ "Piwigo", "Piwigo" ]
This vulnerability lies in the 'add tags' function in the backend. ![image](https://user-images.githubusercontent.com/27283436/235408051-ac0c44e8-32e0-4912-a260-83f0b8891db2.png) Try creating a new label here. ![image](https://user-images.githubusercontent.com/27283436/235408127-ba083289-7885-4be2-8ce4-942db7401af2.png) Use burpsuite to intercept this request. ![image](https://user-images.githubusercontent.com/27283436/235408173-fba8ba87-c076-44ff-8d9d-f676b012bc1a.png) You can see that CSRF-Token does not exist here,So we can generate a CSRF POC. ![image](https://user-images.githubusercontent.com/27283436/235408363-e77366d5-a4a7-4f7c-8171-f6a647328a34.png) Execute this poc,note that there are no tags here at this time ![image](https://user-images.githubusercontent.com/27283436/235408598-989972f6-1af3-4c2f-a910-3ce86b9dda7e.png) ![image](https://user-images.githubusercontent.com/27283436/235408639-8b68b254-ab51-4a28-b1bf-ac3849c3ba89.png) After executing the POC, it was found that there were new tags added ![image](https://user-images.githubusercontent.com/27283436/235408695-1388a381-607f-4234-a33c-87df2daabe70.png) ![image](https://user-images.githubusercontent.com/27283436/235408722-176217b6-0685-4378-bfcf-816576092fe8.png) //CSRF POC: `<html> <!-- CSRF PoC - generated by Burp Suite Professional --> <body> <form action="http://localhost/piwigo/ws.php?format=json&method=pwg.tags.add" method="POST"> <input type="hidden" name="name" value="test" /> <input type="submit" value="Submit request" /> </form> <script> history.pushState('', '', '/'); document.forms[0].submit(); </script> </body> </html> ` Of course, only one CSRF vulnerability is not serious. Next, I will demonstrate the possibility of combining it with XSS vulnerabilities for exploitation
There is a CSRF vulnerability in the "add tags" function of piwigo
https://api.github.com/repos/Piwigo/Piwigo/issues/1908/comments
3
2023-05-01T04:58:37Z
2023-05-05T08:07:10Z
https://github.com/Piwigo/Piwigo/issues/1908
1,690,372,075
1,908
[ "Piwigo", "Piwigo" ]
When the admin user displays Piwigo in da_DK (Dansk), the admin dashboard displays: > Warning: Invalid argument supplied for foreach() in `admin/include/functions.php` on line 3564 This is because we have recently shutdown several forums : da/pl/tr/ru/cn (not enough activity or only spams). As a consequence it breaks Piwigo when it tries to fetch the latest news. I have added a new method `porg.news.getLatest` on piwigo.org, see https://github.com/Piwigo/piwigodotorg/commit/6d62b0747f295656f9db5b16c918d4f351e6a0d2 and we should use it instead of directly requesting the forum.
[da_DK] missing news from piwigo.org
https://api.github.com/repos/Piwigo/Piwigo/issues/1907/comments
0
2023-04-27T15:59:32Z
2023-04-27T16:02:09Z
https://github.com/Piwigo/Piwigo/issues/1907
1,687,138,057
1,907
[ "Piwigo", "Piwigo" ]
In the old history page, we could click on the images to go edit them, with the new page we lost this possibility so we add it back.
[History page] Make the images clickable to go directly to their edit page
https://api.github.com/repos/Piwigo/Piwigo/issues/1905/comments
0
2023-04-25T08:39:53Z
2023-05-05T08:28:16Z
https://github.com/Piwigo/Piwigo/issues/1905
1,682,706,554
1,905
[ "Piwigo", "Piwigo" ]
hide the warning by default
[New album manager] We can see the warning alert for 0.1s on page load
https://api.github.com/repos/Piwigo/Piwigo/issues/1904/comments
0
2023-04-24T15:20:27Z
2023-04-24T15:20:56Z
https://github.com/Piwigo/Piwigo/issues/1904
1,681,528,480
1,904
[ "Piwigo", "Piwigo" ]
Just remove the untranslated sentence.
[User manager] Confirm popin for user delete has untranslated text in it
https://api.github.com/repos/Piwigo/Piwigo/issues/1903/comments
0
2023-04-24T15:18:55Z
2023-05-05T08:28:33Z
https://github.com/Piwigo/Piwigo/issues/1903
1,681,526,047
1,903
[ "Piwigo", "Piwigo" ]
... but only admins in a specific group. <img width="657" alt="Screenshot 2023-04-22 at 17 19 44" src="https://user-images.githubusercontent.com/9326959/233792912-ec0a05d7-7d7e-44cb-a536-8f10db2c6466.png">
email admins when new user registers: do not notify all admins
https://api.github.com/repos/Piwigo/Piwigo/issues/1902/comments
0
2023-04-22T15:20:10Z
2023-04-22T15:21:56Z
https://github.com/Piwigo/Piwigo/issues/1902
1,679,583,733
1,902
[ "Piwigo", "Piwigo" ]
Since we updated dark mode colors, some validation messages are not displayed with the correct colors.
[Dark mode] Color updates
https://api.github.com/repos/Piwigo/Piwigo/issues/1901/comments
0
2023-04-19T14:23:24Z
2023-05-05T08:28:51Z
https://github.com/Piwigo/Piwigo/issues/1901
1,675,012,564
1,901
[ "Piwigo", "Piwigo" ]
Instead of having a single "active themes" section and a single "inactive themes" section, I get several of each one. ![image](https://user-images.githubusercontent.com/9326959/232432249-fd943b7c-d7d0-49f8-a8e0-713bdd43e50c.png)
theme manager, repetition of "active themes" section
https://api.github.com/repos/Piwigo/Piwigo/issues/1900/comments
0
2023-04-17T08:42:40Z
2023-04-17T08:50:19Z
https://github.com/Piwigo/Piwigo/issues/1900
1,670,694,964
1,900
[ "Piwigo", "Piwigo" ]
When deleting an album from the web UI, the server returns a wrong number of orphans. For example, in the below screenshots, we see that the selected album contains 2 photos and the server calculates 4 future orphans: <img width="993" alt="Screenshot 2023-04-14 at 16 33 55" src="https://user-images.githubusercontent.com/7103032/232075291-811b42e1-963b-4cba-ba64-9c9e3618291a.png"> <img width="430" alt="Screenshot 2023-04-14 at 16 39 50" src="https://user-images.githubusercontent.com/7103032/232075823-a3417672-a688-4bcb-b205-5cca0223f4b5.png"> Consequently, the iOS app also returns a wrong number of orphans: ![Simulator Screenshot - iPhone 14 Plus - 2023-04-14 at 16 46 02](https://user-images.githubusercontent.com/7103032/232077414-ac314aeb-1c8d-434a-a06b-6b4ba40cafb6.png)
[13.6] pwg.category.calculateOrphans returns a wrong number of orphans
https://api.github.com/repos/Piwigo/Piwigo/issues/1899/comments
4
2023-04-14T14:49:42Z
2023-05-05T08:26:50Z
https://github.com/Piwigo/Piwigo/issues/1899
1,668,397,224
1,899
[ "Piwigo", "Piwigo" ]
Please add **menubar_related_categories.tpl** to the **admin/extend_for_templates.php** file. Explanation: I would like to customize the default menubar_related_categories.tpl and put it in my template-extension directory. However, there is no Original menubar_related_categories.tpl listed under Configuration >> Templates which I could bind it to. All my other customized templates are the default list, but not this one. Right now I can directly modify the original file in themes/default/template/, and that works fine. However, modifying that file will not survive upgrades to Piwigo, unlike those in template-extension/ . Thank you. Mike Williams Piwigo 13.6, apache2.4 php8.1
menubar_related_categories.tpl not in template_extension list
https://api.github.com/repos/Piwigo/Piwigo/issues/1898/comments
1
2023-04-05T18:14:22Z
2023-07-04T14:53:06Z
https://github.com/Piwigo/Piwigo/issues/1898
1,656,079,351
1,898
[ "Piwigo", "Piwigo" ]
This warning makes the export of an RSS feed impossible: `Deprecated: Function strptime() is deprecated in /.../include/functions_notification.inc.php on line 604` How to reproduce: ![grafik](https://user-images.githubusercontent.com/1645099/229267455-a944708b-5590-410e-bdf6-4757e477420e.png) ![grafik](https://user-images.githubusercontent.com/1645099/229267458-1e961c8d-b5e4-46e0-9ff6-ddd0d66d3546.png) ![grafik](https://user-images.githubusercontent.com/1645099/229267464-30262d2b-2759-4a6f-8c3a-b86c05033d04.png) Expected: have a valid RSS feed Environment: Piwigo 13.6.0 PHP8.1
[PHP8.1] RSS feed: Function strptime() is deprecated
https://api.github.com/repos/Piwigo/Piwigo/issues/1897/comments
4
2023-04-01T05:32:35Z
2023-10-06T01:09:55Z
https://github.com/Piwigo/Piwigo/issues/1897
1,650,309,176
1,897
[ "Piwigo", "Piwigo" ]
Hi, we cannot upload a picture to an album, please find errors & warnings in httpd logs : ``` [Thu Mar 30 09:46:53.382592 2023] [php:warn] [pid 14085] [client 134.184.232.206:42111] PHP Warning: Undefined array key "" in /var/www/html/piwigo/include/functions_html.inc.php on line 125, referer: https://<tld>/admin.php?page=photos_add&album=149 [Thu Mar 30 09:46:53.383020 2023] [php:warn] [pid 14085] [client 134.184.232.206:42111] PHP Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/include/functions_html.inc.php on line 129, referer: https://<tld>/admin.php?page=photos_add&album=149 [Thu Mar 30 09:48:35.305264 2023] [php:warn] [pid 14155] [client 134.184.232.206:35752] PHP Warning: Undefined array key 0 in /var/www/html/piwigo/include/ws_functions/pwg.images.php on line 1480, referer: https://<tld>/admin.php?page=photos_add&album=149 [Thu Mar 30 09:48:35.306782 2023] [php:error] [pid 14155] [client 134.184.232.206:35752] PHP Fatal error: Uncaught mysqli_sql_exception: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 4 in /var/www/html/piwigo/include/dblayer/functions_mysqli.inc.php:132\nStack trace:\n#0 /var/www/html/piwigo/include/dblayer/functions_mysqli.inc.php(132): mysqli->query()\n#1 /var/www/html/piwigo/include/ws_functions/pwg.images.php(1482): pwg_query()\n#2 /var/www/html/piwigo/include/ws_core.inc.php(600): ws_images_upload()\n#3 /var/www/html/piwigo/include/ws_protocols/rest_handler.php(41): PwgServer->invoke()\n#4 /var/www/html/piwigo/include/ws_core.inc.php(281): PwgRestRequestHandler->handleRequest()\n#5 /var/www/html/piwigo/ws.php(22): PwgServer->run()\n#6 {main}\n thrown in /var/www/html/piwigo/include/dblayer/functions_mysqli.inc.php on line 132, referer: https://<tld>/admin.php?page=photos_add&album=149 ``` The upload interface is missing the album list as shown in the screenshot : ![image](https://user-images.githubusercontent.com/43171930/228768374-1a72fcd9-c5c8-4db9-b61f-fec0ee6d43e3.png) The only way to get back to the Piwigo interface is to browse to another page, cancelling the upload does nothing. After that a "null" album is created, the uploaded picture is orphaned and the following errors are shown : ``` Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 195 Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 195 Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 196 Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 196 Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 197 Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 197 Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 198 Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 198 Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 199 Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 199 Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 200 Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 200 Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 201 Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 201 Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 202 Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 202 Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 202 Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 202 ``` As shown in the web UI : ![image](https://user-images.githubusercontent.com/43171930/228770139-0c07fdb5-23a8-42cc-86f4-6854e6006eb1.png) Errors on the httpd logs : ``` [Thu Mar 30 09:56:06.627294 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 195, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.628396 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 195, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.628502 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 196, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.628588 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 196, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.628687 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 197, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.628778 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 197, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.628855 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 198, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.628887 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 198, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.629009 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 199, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.629090 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 199, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.629118 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 200, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.629140 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 200, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.629161 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 201, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.629207 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 201, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.629309 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 202, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.629331 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 202, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.629353 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Undefined array key "cat" in /var/www/html/piwigo/admin/albums.php on line 202, referer: https://<tld>/admin.php [Thu Mar 30 09:56:06.629374 2023] [php:warn] [pid 14157] [client 134.184.232.206:29192] PHP Warning: Trying to access array offset on value of type null in /var/www/html/piwigo/admin/albums.php on line 202, referer: https://<tld>/admin.php ``` Server information : *Piwigo 13.6.0 *PHP 8.1.16 *httpd-2.4.6-97.el7.centos.4.x86_64 Let me know if we can provide more information about this issue, thanks.
php8.1 issue when uploading a picture
https://api.github.com/repos/Piwigo/Piwigo/issues/1895/comments
5
2023-03-30T08:04:03Z
2024-03-27T13:57:00Z
https://github.com/Piwigo/Piwigo/issues/1895
1,647,118,541
1,895
[ "Piwigo", "Piwigo" ]
I have a fresh web space and want to to install Piwigo. I called install.php If I click the "Start Installation" button without giving any information ![grafik](https://user-images.githubusercontent.com/1645099/228645928-2bb502c5-53f3-42bf-abd3-1df43c508a89.png) The following warning appears in the log file: ``` [29-Mar-2023 21:19:00 Europe/Berlin] PHP Warning: mysqli::__construct(): (HY000/2002): No such file or directory in /.../piwigo/include/dblayer/functions_mysqli.inc.php on line 52 [29-Mar-2023 21:19:00 Europe/Berlin] PHP Warning: mysqli::set_charset(): Couldn't fetch mysqli in /.../piwigo/include/dblayer/functions_mysqli.inc.php on line 88 ``` Piwigo 13.6.0 PHP 7.4 ------------------- If I run PHP8.0/PHP8.1 with Piwigo 13.6.0 the following happens: After pressing the "Start installation" button a white page loads. And the following log entries appears in the log: ``` [29-Mar-2023 21:24:34 Europe/Berlin] PHP Warning: mysqli::__construct(): (HY000/2002): No such file or directory in /.../piwigo/include/dblayer/functions_mysqli.inc.php on line 52 [29-Mar-2023 21:24:34 Europe/Berlin] PHP Fatal error: Uncaught Error: mysqli object is already closed in /.../piwigo/include/dblayer/functions_mysqli.inc.php:88 Stack trace: #0 /.../piwigo/include/dblayer/functions_mysqli.inc.php(88): mysqli->set_charset() #1 /.../piwigo/install.php(261): pwg_db_check_charset() #2 {main} thrown in /.../piwigo/include/dblayer/functions_mysqli.inc.php on line 88 ``` I cannot use PHP7.4 anymore after March 31st 2023 on my web space. As a beginner of Piwigo I would expect any short information on the install page, that PHP8 is not supported yet.
install.php: PHP7.4 Warning + PHP8 white page
https://api.github.com/repos/Piwigo/Piwigo/issues/1894/comments
6
2023-03-29T19:30:26Z
2023-08-03T09:13:04Z
https://github.com/Piwigo/Piwigo/issues/1894
1,646,393,157
1,894
[ "Piwigo", "Piwigo" ]
When enabeling the debuging mode, I get: Fatal error: Uncaught Error: Non-static method Smarty_Internal_Debug::display_debug() cannot be called statically in /var/www/html/piwigo/include/template.class.php:571 Stack trace: #0 /var/www/html/piwigo/include/page_tail.php(94): Template->p() #1 /var/www/html/piwigo/index.php(358): include('...') #2 {main} thrown in /var/www/html/piwigo/include/template.class.php on line 571
Non-static method Smarty_Internal_Debug::display_debug() cannot be called statically
https://api.github.com/repos/Piwigo/Piwigo/issues/1893/comments
1
2023-03-27T16:13:03Z
2023-03-27T16:13:41Z
https://github.com/Piwigo/Piwigo/issues/1893
1,642,402,720
1,893
[ "Piwigo", "Piwigo" ]
When I edit an album and click the checkbox for "Apply settings for sub-albums", I get: Fatal error: Uncaught mysqli_sql_exception: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'OR uppercats REGEXP '(^|,)23(,|$)'' at line 4 in /var/www/html/piwigo/include/dblayer/functions_mysqli.inc.php:132 Stack trace: #0 /var/www/html/piwigo/include/dblayer/functions_mysqli.inc.php(132): mysqli->query() #1 /var/www/html/piwigo/include/dblayer/functions_mysqli.inc.php(888): pwg_query() #2 /var/www/html/piwigo/include/functions_category.inc.php(323): query2array() #3 /var/www/html/piwigo/admin/cat_modify.php(122): get_subcat_ids() #4 /var/www/html/piwigo/admin/album.php(64): include('...') #5 /var/www/html/piwigo/admin.php(345): include('...') #6 {main} thrown in /var/www/html/piwigo/include/dblayer/functions_mysqli.inc.php on line 132
Databse-Querry-Error
https://api.github.com/repos/Piwigo/Piwigo/issues/1892/comments
2
2023-03-27T16:07:09Z
2023-03-27T17:08:53Z
https://github.com/Piwigo/Piwigo/issues/1892
1,642,392,800
1,892
[ "Piwigo", "Piwigo" ]
Hi, Since one year my personal galery is accessible on internet via a https server. Certificat done with let's encrypt. I tested one year about vulnerability, and I tested again today. some fixes are at my hand, some not. I think the two below are for piwigo team. -No Anti-CSRF tokens were found in a HTML submission form -The identified library jquery, version 1.11.3 is vulnerable. Websites used: -https://hostedscan.com -https://securityheaders.com/ I found several issues opens but no answer for some. Thank you for your attention
About vulnerabiliy
https://api.github.com/repos/Piwigo/Piwigo/issues/1891/comments
1
2023-03-27T13:10:28Z
2023-03-27T13:11:50Z
https://github.com/Piwigo/Piwigo/issues/1891
1,642,024,773
1,891
[ "Piwigo", "Piwigo" ]
Hi, Since one year my personal galery is accessible on internet via a https server. Certificat done with let's encrypt. I tested one year about vulnerability, and I tested again today. some fixes are at my hand, some not. I think the two below are for piwigo team. -No Anti-CSRF tokens were found in a HTML submission form -The identified library jquery, version 1.11.3 is vulnerable. Websites used: -https://hostedscan.com -https://securityheaders.com/ I found several issues opens but no answer for some. Thank you for your attention
About vulnerabiliy
https://api.github.com/repos/Piwigo/Piwigo/issues/1890/comments
1
2023-03-27T13:09:52Z
2023-03-27T13:12:06Z
https://github.com/Piwigo/Piwigo/issues/1890
1,642,024,650
1,890
[ "Piwigo", "Piwigo" ]
Hi, Since one year my personal galery is accessible on internet via a https server. Certificat done with let's encrypt. I tested one year about vulnerability, and I tested again today. some fixes are at my hand, some not. I think the two below are for piwigo team. -No Anti-CSRF tokens were found in a HTML submission form -The identified library jquery, version 1.11.3 is vulnerable. Websites used: -https://hostedscan.com -https://securityheaders.com/ I found several issues opens but no answer for some. Thank you for your attention
Vulnerability on jQuery 1.11.3
https://api.github.com/repos/Piwigo/Piwigo/issues/1889/comments
3
2023-03-27T13:09:32Z
2023-07-07T14:00:26Z
https://github.com/Piwigo/Piwigo/issues/1889
1,642,024,588
1,889
[ "Piwigo", "Piwigo" ]
FR : 'Restauré' is written 'Restoré' which males no sense.
[Plugin Manager] Spelling mistake when we restore a plugin
https://api.github.com/repos/Piwigo/Piwigo/issues/1888/comments
0
2023-03-27T08:59:06Z
2023-03-27T09:02:19Z
https://github.com/Piwigo/Piwigo/issues/1888
1,641,689,111
1,888
[ "Piwigo", "Piwigo" ]
In the 13.x album editor, album deletion doesnt work. It just redirects to the album list page and the album we tried to delete is still here.
[Album Editor] Delete album doesnt work
https://api.github.com/repos/Piwigo/Piwigo/issues/1887/comments
0
2023-03-27T08:42:36Z
2023-05-05T08:29:12Z
https://github.com/Piwigo/Piwigo/issues/1887
1,641,662,322
1,887
[ "Piwigo", "Piwigo" ]
I'm using LSIO container and I fill out all the setup stuff and submit, and then just get redirected to `upgrade.php` in the location bar, but it's Error 500. The database does get populated with the initial stuff, and the bind mounts get populated with the files; I just get stuck at this point. Anyone have any ideas?
500 error after new install
https://api.github.com/repos/Piwigo/Piwigo/issues/1886/comments
4
2023-03-26T20:42:48Z
2023-06-29T13:04:59Z
https://github.com/Piwigo/Piwigo/issues/1886
1,641,079,363
1,886
[ "Piwigo", "Piwigo" ]
Storage limitations are becoming the main issue about photo management. It would be extremely useful if Piwigo could be supporting object storage.
S3/Object storage support
https://api.github.com/repos/Piwigo/Piwigo/issues/1884/comments
2
2023-03-26T10:18:36Z
2023-03-27T18:15:15Z
https://github.com/Piwigo/Piwigo/issues/1884
1,640,851,424
1,884
[ "Piwigo", "Piwigo" ]
![image](https://user-images.githubusercontent.com/9326959/227492216-074b1df7-173f-4a4f-b555-5ea4f1b954c8.png) The "annuler" (French for "cancel") does nothing. We expect the popin to close.
tag edition, cancel button does not work
https://api.github.com/repos/Piwigo/Piwigo/issues/1883/comments
0
2023-03-24T10:07:57Z
2023-04-19T09:55:16Z
https://github.com/Piwigo/Piwigo/issues/1883
1,639,095,012
1,883
[ "Piwigo", "Piwigo" ]
The hover text in the thumbnail display in the global batch manager currently shows the file name, width x height, and filesize. It would be nice to also add the date_creation. This makes it easier to identify groups of photos that belong together (for a particular event, for example). I'll work up a patch.
show the date_creation in the hover text of the thumbnails in the global batch manager
https://api.github.com/repos/Piwigo/Piwigo/issues/1882/comments
2
2023-03-22T19:04:08Z
2023-03-22T19:09:13Z
https://github.com/Piwigo/Piwigo/issues/1882
1,636,347,584
1,882