issue_owner_repo
listlengths
2
2
issue_body
stringlengths
0
261k
issue_title
stringlengths
1
925
issue_comments_url
stringlengths
56
81
issue_comments_count
int64
0
2.5k
issue_created_at
stringlengths
20
20
issue_updated_at
stringlengths
20
20
issue_html_url
stringlengths
37
62
issue_github_id
int64
387k
2.46B
issue_number
int64
1
127k
[ "Piwigo", "Piwigo" ]
When you edit an user email with a wrong email (Ex: email.com) you get the correct error but it doesnt dissapear after a short period of time and it keeps the popin locked and you cant edit the user afterwards without reloading the page.
[User Manager] Email edit block the user editor
https://api.github.com/repos/Piwigo/Piwigo/issues/1880/comments
0
2023-03-14T09:44:13Z
2023-05-05T08:29:38Z
https://github.com/Piwigo/Piwigo/issues/1880
1,623,099,291
1,880
[ "Piwigo", "Piwigo" ]
The actual dark mode for alert color and icons is too bright. New colors below : ![image](https://user-images.githubusercontent.com/60923356/224751570-f2abdb96-9276-4c3f-8264-e619745d25ba.png) ![image](https://user-images.githubusercontent.com/60923356/224751631-8061539d-cb26-4f29-8bed-2ed4807ffc16.png) This will also apply to group icons and user icons in user manager, and some other places where the classes are used
[Dark mode] Change icon style in dark mode
https://api.github.com/repos/Piwigo/Piwigo/issues/1879/comments
1
2023-03-13T15:40:36Z
2023-05-05T08:29:54Z
https://github.com/Piwigo/Piwigo/issues/1879
1,621,751,760
1,879
[ "Piwigo", "Piwigo" ]
In the displayed user list, the status is not translated (always in english)
[User Manager] User status isnt translated
https://api.github.com/repos/Piwigo/Piwigo/issues/1878/comments
0
2023-03-13T09:20:01Z
2023-05-05T08:27:56Z
https://github.com/Piwigo/Piwigo/issues/1878
1,621,061,050
1,878
[ "Piwigo", "Piwigo" ]
Hallo I use sometimes Piwigo, at the moment 13.6 and always, when I use it again, I have to search how to set an image as cover for an album. It is hidden, very good hidden as: **Administration > Alben > Verwaltung > <my_album> > Album bearbeiten (Bleistiftsymbol) > Albumfotos verwalten > Alle > <my_cover_foto> > Foto bearbeiten (Bleistiftsymbol) > Album-Vorschaubild > <my_album> > Einstellungen sichern (*)** Now only the image (my_cover_foto> will be shown as cover of my_album. It is vice versa as expected, not the album gets a cover photo but the photo is set for the album. At least I expect a Button like "Set as cover photo" as in other galleries. Thank, frank (*) the clickpath is in German, I switched language to English (this is neither that intuitive, no drop-down select box, but select and set as default and unselect the previous language, as I don't need two languages at one time) but menu is still in German. To wipe the cache there is not button, only a header "Cache leeren" without any button. I think I could open several issues for UX but when I look at the amount of open issues, I better wont :smirk: I use Piwigo as it is. This issue is more a reminder for me, to find the cover image the next time a bit faster :smirk:
Select image as album cover - much too hidden
https://api.github.com/repos/Piwigo/Piwigo/issues/1877/comments
7
2023-03-07T15:55:38Z
2023-07-27T09:30:13Z
https://github.com/Piwigo/Piwigo/issues/1877
1,613,738,110
1,877
[ "Piwigo", "Piwigo" ]
GET params in history page are not checked so it leaves an open gate for sql injections
[History page] SQL injection issue found in 13.5.0
https://api.github.com/repos/Piwigo/Piwigo/issues/1876/comments
0
2023-03-01T10:54:13Z
2023-03-06T08:52:27Z
https://github.com/Piwigo/Piwigo/issues/1876
1,604,731,360
1,876
[ "Piwigo", "Piwigo" ]
Hello, if I want to know to what extent and by whom my PIWIGO site is used, I regularly receive incorrect information. For example, if I want to get an overview via Tools -> History -> Search, many page views are not displayed there at all. Even page views that take place via the mobile APP are not listed at all. If I want to specify and select the search, this is no longer possible with the "new" statistics GUI. If I want to track the user activities via Users -> Manage -> Activity, only the activities of the admin user are displayed. All other users are not displayed in the standard view: it looks as if no user activity has taken place. If I then select an individual user via "Selected user", I can see that activities have indeed taken place. I don't have any other setting options in the entire Search GUI. Overall, the whole stats section doesn't work well. I can't see what activity really took place on the site. In the old GUI there were differentiated setting options. What can I do to solve the above problems? Thanks for your help in advance and best regards - Daniel
Incorrect Data via Statistics, History and User-Activity
https://api.github.com/repos/Piwigo/Piwigo/issues/1875/comments
1
2023-02-27T12:41:35Z
2023-04-17T11:08:18Z
https://github.com/Piwigo/Piwigo/issues/1875
1,601,112,626
1,875
[ "Piwigo", "Piwigo" ]
Hello, I recently setup piwigo on my server, in a docker container, which runs behind a [reverse-proxy](https://hub.docker.com/r/jwilder/nginx-proxy) that automatically manages Let's Encrypt SSL certificates and endpoints. This allows me to connect to Piwigo (and other dockerized web apps) with https, without the need to configure the web apps themselves for https. I'm using the *Modus* theme, and updated to the latest versions of the app & plugins installed. Sometimes, I click a link in the app and I get an "unable to connect" error, then notice that the URL it's trying to connect to has the port appended to it, like so: https://my-piwigo.example.com:80/the/path. From the "perspective" of the (internal) app the port number is 80, but from the client side (external, my web browser) it should be 443. The login button, as accessed through the "Login" link in the upper-right corner of an album, is one example of this. I enter my credentials, click Submit, and get a browser error: ``` This site can’t provide a secure connection my-piwigo.example.com sent an invalid response. ERR_SSL_PROTOCOL_ERROR ``` The URL in the location bar has an `:80` on the end. If you just leave the port number off, it would work fine. Perhaps this "feature" was added to support installations that run on non-standard ports? If so, is there somewhere I can try setting it to 443? Although, since port 80 is the correct "internal" (behind the proxy) port, that might also not work, depending how the app works.
Appending the port to the URI in links breaks reverse proxy
https://api.github.com/repos/Piwigo/Piwigo/issues/1874/comments
2
2023-02-25T18:27:59Z
2023-03-06T21:18:38Z
https://github.com/Piwigo/Piwigo/issues/1874
1,599,791,620
1,874
[ "Piwigo", "Piwigo" ]
Hi, - Update to 13.6. : done - The file user_list_backend.php is still there even if it is an empty file Why the file is not deleted? What is the reason? ``` find . -name user_list_backend.php -ls 1177265 0 -rwxr-xr-x 1 www-data www-data 0 Feb 24 10:54 ./admin/user_list_backend.php ``` In fact I found a lot of files with zero size: ``` # find . -size 0 -ls 1177832 0 -rwxr-xr-x 1 www-data www-data 0 Feb 24 11:42 ./themes/smartpocket/template/menubar_related_categories.tpl 1185164 0 -rw-r--r-- 1 www-data www-data 0 Feb 20 14:07 ./themes/bootstrap_darkroom/node_modules/typeface-roboto/.npmignore 1185152 0 -rw-r--r-- 1 www-data www-data 0 Feb 20 14:07 ./themes/bootstrap_darkroom/node_modules/typeface-roboto/files/.npmignore 1185306 0 -rw-r--r-- 1 www-data www-data 0 Feb 20 14:07 ./themes/bootstrap_darkroom/node_modules/typeface-pt-sans/.npmignore 1185296 0 -rw-r--r-- 1 www-data www-data 0 Feb 20 14:07 ./themes/bootstrap_darkroom/node_modules/typeface-pt-sans/files/.npmignore 1185294 0 -rw-r--r-- 1 www-data www-data 0 Feb 20 14:07 ./themes/bootstrap_darkroom/node_modules/typeface-pt-sans/files/pt-sans-latin-700.eot.mtd 1185300 0 -rw-r--r-- 1 www-data www-data 0 Feb 20 14:07 ./themes/bootstrap_darkroom/node_modules/typeface-pt-sans/files/pt-sans-latin-400.eot.mtd 1185297 0 -rw-r--r-- 1 www-data www-data 0 Feb 20 14:07 ./themes/bootstrap_darkroom/node_modules/typeface-pt-sans/files/pt-sans-latin-400.svg.mtd 1184989 0 -rw-r--r-- 1 www-data www-data 0 Feb 20 14:07 ./themes/bootstrap_darkroom/scss/custom/.keep 1185468 0 -rw-r--r-- 1 www-data www-data 0 Feb 20 14:07 ./themes/bootstrap_darkroom/css/custom/.keep 1185084 0 -rw-r--r-- 1 www-data www-data 0 Feb 20 14:07 ./themes/bootstrap_darkroom/template/menu_templates/menubar_randompic.tpl 1435319 0 -rw-r--r-- 1 www-data www-data 0 Jun 30 2022 ./include/smarty/expectException 1311957 0 -rwxr-xr-x 1 www-data www-data 0 Oct 21 15:13 ./admin/themes/clear/css/components/general.css 1177265 0 -rwxr-xr-x 1 www-data www-data 0 Feb 24 10:54 ./admin/user_list_backend.php 1437642 0 -rw-rw-rw- 1 www-data www-data 0 Nov 11 17:30 ./_data/templates_c/wrt636e789b9a5669_14097981 1181789 0 -rw-r--r-- 1 www-data www-data 0 Nov 11 13:51 ./_data/i/galleries/2022/2022_02_12/P1070299-sq.JPG 1181788 0 -rw-r--r-- 1 www-data www-data 0 Nov 11 13:51 ./_data/i/galleries/2022/2022_02_12/P1070300-xx.JPG 1177202 0 -rwxr-xr-x 1 www-data www-data 0 Oct 21 15:13 ./_data/dummy.txt 1185637 0 -rw-r--r-- 1 www-data www-data 0 Dec 20 16:22 ./local/bootstrap_darkroom/custom.css ``` Thank you.
about file: user_list_backend.php
https://api.github.com/repos/Piwigo/Piwigo/issues/1873/comments
2
2023-02-24T11:13:25Z
2023-02-24T11:29:43Z
https://github.com/Piwigo/Piwigo/issues/1873
1,598,433,262
1,873
[ "Piwigo", "Piwigo" ]
Without entering too much into details there is a possible SQL injection in file `admin/user_list_backend.php`. This file has no reason to be still in Piwigo since version 12 and the new user manager (which relies on `ws.php` as backend). This file must simply be removed.
[13.x] SQL injection on user_list_backend.php
https://api.github.com/repos/Piwigo/Piwigo/issues/1872/comments
0
2023-02-24T08:42:01Z
2023-02-24T08:42:44Z
https://github.com/Piwigo/Piwigo/issues/1872
1,598,184,264
1,872
[ "Piwigo", "Piwigo" ]
Since version 13.0.0, the `pwg.categories.getImages` method returns a total number of images `total_count` which is wrong. This prevents third party apps from determining how many pages should be requested to retrieve a complete image data.
[13.x] pwg.categories.getImages returns a wrong total number of images
https://api.github.com/repos/Piwigo/Piwigo/issues/1871/comments
0
2023-02-20T18:29:37Z
2023-02-21T14:21:21Z
https://github.com/Piwigo/Piwigo/issues/1871
1,592,297,737
1,871
[ "Piwigo", "Piwigo" ]
The new search system will combine the current quick search and the advanced search systems.
[Multi-criteria Search] Implement new search system in the gallery
https://api.github.com/repos/Piwigo/Piwigo/issues/1869/comments
0
2023-02-14T10:03:48Z
2023-06-26T09:32:35Z
https://github.com/Piwigo/Piwigo/issues/1869
1,583,861,167
1,869
[ "Piwigo", "Piwigo" ]
This div is not centered properly ![Capture d’écran de 2023-02-13 16-52-30](https://user-images.githubusercontent.com/60923356/218506328-07b2d06e-1258-4a45-9519-346b987309aa.png)
First album button is not centered
https://api.github.com/repos/Piwigo/Piwigo/issues/1868/comments
0
2023-02-13T15:53:41Z
2023-02-21T14:24:23Z
https://github.com/Piwigo/Piwigo/issues/1868
1,582,610,307
1,868
[ "Piwigo", "Piwigo" ]
If you are using a domain like www.example-01-02.org you getting JS errors in frontend of albums (/admin.php?page=albums). I wrote a fix and created a merge request: https://github.com/Piwigo/Piwigo/pull/1828 I would be very happy if the problem is fixed so that I can make updates in my instance again
Admin albums view does not work properly for some Domains
https://api.github.com/repos/Piwigo/Piwigo/issues/1867/comments
0
2023-02-13T09:01:23Z
2023-02-13T09:02:01Z
https://github.com/Piwigo/Piwigo/issues/1867
1,581,926,802
1,867
[ "Piwigo", "Piwigo" ]
When the parameter `order` is set to `random`, the method `pwg.categories.getImages` returns in the second `page` images which were already provided in the first `page` (as if the random operation is called several times?). This prevents from collecting all images.
[BUG] pwg.categories.getImages returns wrong image list when order = random
https://api.github.com/repos/Piwigo/Piwigo/issues/1866/comments
0
2023-02-12T20:07:28Z
2023-02-20T18:29:59Z
https://github.com/Piwigo/Piwigo/issues/1866
1,581,392,825
1,866
[ "Piwigo", "Piwigo" ]
Upgraded to 13.5.0 and added some new albums today and when trying to set permissions the page threw an error. This was using PHP 8.1. Switched back to PHP 7.2 which was also still on my server and the page worked without issue. Verified whether the function.inc.php was the most recent one and even copied complete include directory from the installer zip over the current directory but with same result. Below the error thrown. ` Fatal error: Uncaught ValueError: Unknown format specifier "j" in /var/www/fotos/include/functions.inc.php:1218 Stack trace: #0 /var/www/fotos/include/functions.inc.php(1218): vsprintf() #1 /var/www/fotos/_data/templates_c/p6jhns^a274768b87497ffd55d466b1fbc581c81f970752_0.file.cat_perm.tpl.php(159): l10n() #2 /var/www/fotos/include/smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_63cffb55d35d71_47390677() #3 /var/www/fotos/include/smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode() #4 /var/www/fotos/include/smarty/libs/sysplugins/smarty_internal_template.php(216): Smarty_Template_Compiled->render() #5 /var/www/fotos/include/smarty/libs/sysplugins/smarty_internal_templatebase.php(238): Smarty_Internal_Template->render() #6 /var/www/fotos/include/smarty/libs/sysplugins/smarty_internal_templatebase.php(116): Smarty_Internal_TemplateBase->_execute() #7 /var/www/fotos/include/template.class.php(469): Smarty_Internal_TemplateBase->fetch() #8 /var/www/fotos/include/template.class.php(392): Template->parse() #9 /var/www/fotos/admin/cat_perm.php(297): Template->assign_var_from_handle() #10 /var/www/fotos/admin/album.php(73): include('...') #11 /var/www/fotos/admin.php(345): include('...') #12 {main} thrown in /var/www/fotos/include/functions.inc.php on line 1218 ` System info Piwigo 13.5.0 Besturingssysteem: Linux PHP: 8.1.15 (Toon info) [2023-02-07 16:09:56] MySQL: 8.0.30-22 [2023-02-07 16:09:56] Afbeeldingen-bibliotheek: ImageMagick 6.9.11-60 Also switched some of the themes but to no avail. Anything other or just something that needs to be updated? If more info is needed let me know.
13.5.0 Permissions page error with PHP 8.1
https://api.github.com/repos/Piwigo/Piwigo/issues/1863/comments
1
2023-02-07T15:12:08Z
2023-05-16T20:02:13Z
https://github.com/Piwigo/Piwigo/issues/1863
1,574,512,088
1,863
[ "Piwigo", "Piwigo" ]
We can't see the placeholder properly. ![image](https://user-images.githubusercontent.com/60923356/217210375-252d2bce-0c46-4a0b-916a-24e87d5a13a9.png)
[Group Manager] Place holder color in dark mode
https://api.github.com/repos/Piwigo/Piwigo/issues/1862/comments
0
2023-02-07T10:05:20Z
2023-02-21T14:24:50Z
https://github.com/Piwigo/Piwigo/issues/1862
1,574,036,063
1,862
[ "Piwigo", "Piwigo" ]
![image](https://user-images.githubusercontent.com/60923356/217201262-58fcbde4-3fd4-4e99-943b-3d2d21977efc.png)
[Dark mode] Breadcrumb for add photo form isn't dark
https://api.github.com/repos/Piwigo/Piwigo/issues/1861/comments
0
2023-02-07T09:14:04Z
2023-02-21T14:25:34Z
https://github.com/Piwigo/Piwigo/issues/1861
1,573,958,873
1,861
[ "Piwigo", "Piwigo" ]
Can anyone to help me? here's mine simple move: 1. copy /usr/local/nginx/html/piwigo to the new server 2. back up MySQL database from source, restore it into new database on new server It works, but there's some problem, the photo seems to lost (the second photo): ![20230206221545809](https://user-images.githubusercontent.com/49600740/217127022-4d8e7dd1-dab6-43da-a7be-75566c5ad3bc.jpg) ![20230206222038167](https://user-images.githubusercontent.com/49600740/217127044-d77be06f-561b-4dc9-b645-af237e5bff39.jpg) Most grateful for any hints.
How to move piwigo to new server?
https://api.github.com/repos/Piwigo/Piwigo/issues/1860/comments
2
2023-02-07T01:52:44Z
2023-03-01T09:39:18Z
https://github.com/Piwigo/Piwigo/issues/1860
1,573,551,178
1,860
[ "Piwigo", "Piwigo" ]
New banner will look like this now. ![image](https://user-images.githubusercontent.com/60923356/217022988-ca46f26f-8f19-4e4d-971e-df9fb3e2b31f.png) ![image](https://user-images.githubusercontent.com/60923356/217023020-9a992e8d-aeec-4d0d-9b2d-d417e236a8b9.png)
New design for mobile app banner
https://api.github.com/repos/Piwigo/Piwigo/issues/1859/comments
0
2023-02-06T16:06:58Z
2023-02-21T14:25:17Z
https://github.com/Piwigo/Piwigo/issues/1859
1,572,850,698
1,859
[ "Piwigo", "Piwigo" ]
At the moment, the user list is showed from the most ancient to the most recent user created. Logically we should have the most recent first.
[User Manager] User list order
https://api.github.com/repos/Piwigo/Piwigo/issues/1858/comments
0
2023-02-06T13:59:47Z
2023-02-08T15:15:31Z
https://github.com/Piwigo/Piwigo/issues/1858
1,572,619,846
1,858
[ "Piwigo", "Piwigo" ]
After updates to 13.x the smart pocket theme comments view shows the followeing error: Warning: Undefined array key "derivative_params" in /var/www/vhosts/DOMAIN/SUBDOMAIN/_data/templates_c/1lvjnrm^d8b0832142a9c6e3409ef344eab1cd4291954f28_0.file.comments.tpl.php on line 31 Warning: Attempt to read property "value" on null in /var/www/vhosts/DOMAIN/SUBDOMAIN/_data/templates_c/1lvjnrm^d8b0832142a9c6e3409ef344eab1cd4291954f28_0.file.comments.tpl.php on line 31 in general all seems to work, it might be mainly a cosmetic issue
Database query error in comments view for Smart Pocket theme after 13.x update
https://api.github.com/repos/Piwigo/Piwigo/issues/1856/comments
1
2023-01-27T14:06:00Z
2023-01-27T14:10:33Z
https://github.com/Piwigo/Piwigo/issues/1856
1,559,825,648
1,856
[ "Piwigo", "Piwigo" ]
On Piwigo.com server logs I've noticed that attackers were trying to hack the embedded Smarty demo. Let's remove it to avoid losing their time :-D
potential security issue with Smarty demo
https://api.github.com/repos/Piwigo/Piwigo/issues/1855/comments
0
2023-01-25T13:17:20Z
2023-01-25T13:18:11Z
https://github.com/Piwigo/Piwigo/issues/1855
1,556,643,672
1,855
[ "Piwigo", "Piwigo" ]
![Screen Shot 2023-01-25 at 11 04 38](https://user-images.githubusercontent.com/9326959/214535510-b6c27d03-d050-4346-b4af-36ff75a52081.png) I'm talking about the `System: Autoupdate(1)` added in Piwigo 13.5.0 I don't know yet if we should keep it and improve its style, or simply hide it.
system activities show up on activity chart
https://api.github.com/repos/Piwigo/Piwigo/issues/1854/comments
3
2023-01-25T10:08:36Z
2023-12-12T16:30:53Z
https://github.com/Piwigo/Piwigo/issues/1854
1,556,378,151
1,854
[ "Piwigo", "Piwigo" ]
Sometimes you want to avoid any kind of software update/install from Piwigo administration pages. It might even be a security issue, depending on the environment.
ability to disable core/extensions updates
https://api.github.com/repos/Piwigo/Piwigo/issues/1852/comments
0
2023-01-20T17:31:46Z
2023-01-23T10:17:14Z
https://github.com/Piwigo/Piwigo/issues/1852
1,551,218,142
1,852
[ "Piwigo", "Piwigo" ]
![image](https://user-images.githubusercontent.com/60923356/211792550-af9fdbb0-7808-4336-a61f-21301b71244c.png) Text color on over is too low ![image](https://user-images.githubusercontent.com/60923356/211792564-0c2dd4d5-5325-4c7d-b4c2-73336b43916c.png) Separators are not the same color as the text, and delete icon get over the text sometimes ![image](https://user-images.githubusercontent.com/60923356/211792825-655ce0f4-75da-478c-87b7-8fdc822d47a6.png) Dark mode isn't done for this icon
Dark mode issues on Album edit and Picture edit
https://api.github.com/repos/Piwigo/Piwigo/issues/1851/comments
0
2023-01-11T11:18:11Z
2023-06-26T09:30:39Z
https://github.com/Piwigo/Piwigo/issues/1851
1,528,859,846
1,851
[ "Piwigo", "Piwigo" ]
![image](https://user-images.githubusercontent.com/9326959/211339990-ce793b29-c011-42c5-8109-986830dc5e44.png)
right after core update, Piwigo still says the current version is the previous one
https://api.github.com/repos/Piwigo/Piwigo/issues/1849/comments
0
2023-01-09T15:07:26Z
2023-01-20T17:26:09Z
https://github.com/Piwigo/Piwigo/issues/1849
1,525,776,048
1,849
[ "Piwigo", "Piwigo" ]
When using format=json on the api, the wrong mediatype is returned. This causes a problem when using different frameworks in java since automatic decoding is not supported. For example the following code snippet will return an exception: ``` ClientConfig clientConfig = new ClientConfig().register(GsonMessageBodyHandler.class); Client client = ClientBuilder.newClient(clientConfig); Response response = client.target("https://<hostname>") .path(String.format("ws.php")) .queryParam(FORMAT_JSON.getKey(), FORMAT_JSON.getValue()) .queryParam(IMAGE_INFO.getKey(), IMAGE_INFO.getValue()) .queryParam(IMAGE_ID, imageId) .request(MediaType.APPLICATION_JSON).get(); return response.readEntity(PiwigoResponse.class); ``` Will send a request url: `https://<hostname>/ws.php?format=json&method=pwg.images.getInfo&image_id=339` And result in an exception: ``` org.glassfish.jersey.message.internal.MessageBodyProviderNotFoundException: MessageBodyReader not found for media type=text/plain;charset=utf-8, type=class <package>.PiwigoResponse, genericType=class <package>.PiwigoResponse. ```
Piwigo API returns wrong mediatype
https://api.github.com/repos/Piwigo/Piwigo/issues/1847/comments
0
2023-01-07T20:48:31Z
2024-02-19T12:44:21Z
https://github.com/Piwigo/Piwigo/issues/1847
1,524,142,030
1,847
[ "Piwigo", "Piwigo" ]
Using Piwigo with PHP 8.2 gives lots of deprecation notices in the smarty library. ``` Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$registerPlugin is deprecated in …/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$registerFilter is deprecated in …/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$append is deprecated in …/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in …/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Warning: Cannot modify header information - headers already sent by (output started at …/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php:182) in …/include/page_header.php on line 99 Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$unregisterFilter is deprecated in …/include/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182 Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in …/include/smarty/libs/sysplugins/smarty_internal_template.php on line 719 ``` I see that Piwigo is using version 4.1 of Smarty. According to the [ changelog](https://github.com/smarty-php/smarty/blob/master/CHANGELOG.md), compatibility with PHP 8.2 was introduced with version 4.3 Alternatively, just ignore deprecations by changing this line. https://github.com/Piwigo/Piwigo/blob/4729504aac02545e9d5e27717cbf7f9ce3663b9d/include/config_default.inc.php#L501 In general, you would want to see deprecations in test/development, but not in live environments.
Need to upgrade Smarty from 4.1 to 4.3 for compatibility with PHP 8.2
https://api.github.com/repos/Piwigo/Piwigo/issues/1845/comments
5
2023-01-04T12:16:59Z
2023-06-14T06:04:20Z
https://github.com/Piwigo/Piwigo/issues/1845
1,518,876,926
1,845
[ "Piwigo", "Piwigo" ]
Hi, ################################## Env: Piwigo 13.4.0 Check for upgrade Installed on 10 November 2022, 1 month 2 weeks 5 days ago Operating system: Linux PHP: 7.4.33 (Show info) [2022-12-29 17:20:22] MySQL: 5.5.5-10.5.15-MariaDB-0+deb11u1 [2022-12-29 16:20:22] Graphics Library: External ImageMagick 6.9.11-60 ffmpeg -version ffmpeg version 4.3.5-0+deb11u1+rpt2 Copyright (c) 2000-2022 the FFmpeg developers built with gcc 10 (Raspbian 10.2.1-6+rpi1) configuration: --prefix=/usr --extra-version=0+deb11u1+rpt2 --toolchain=hardened --incdir=/usr/include/arm-linux-gnueabihf --enable-gpl --disable-stripping --enable-avresample --disable-filter=resample --enable-gnutls --enable-ladspa --enable-libaom --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libcodec2 --enable-libdav1d --enable-libflite --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libjack --enable-libmp3lame --enable-libmysofa --enable-libopenjpeg --enable-libopenmpt --enable-libopus --enable-libpulse --enable-librabbitmq --enable-librsvg --enable-librubberband --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libsrt --enable-libssh --enable-libtheora --enable-libtwolame --enable-libvidstab --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx265 --enable-libxml2 --enable-libxvid --enable-libzmq --enable-libzvbi --enable-lv2 --enable-omx --enable-openal --enable-opencl --enable-opengl --enable-sdl2 --enable-mmal --enable-neon --enable-rpi --enable-v4l2-request --enable-libudev --enable-epoxy --enable-pocketsphinx --enable-libdc1394 --enable-libdrm --enable-vout-drm --enable-libiec61883 --enable-chromaprint --enable-frei0r --enable-libx264 --enable-shared --libdir=/usr/lib/arm-linux-gnueabihf --cpu=arm1176jzf-s --arch=arm libavutil 56. 51.100 / 56. 51.100 libavcodec 58. 91.100 / 58. 91.100 libavformat 58. 45.100 / 58. 45.100 libavdevice 58. 10.100 / 58. 10.100 libavfilter 7. 85.100 / 7. 85.100 libavresample 4. 0. 0 / 4. 0. 0 libswscale 5. 7.100 / 5. 7.100 libswresample 3. 7.100 / 3. 7.100 libpostproc 55. 7.100 / 55. 7.100 mediainfo --version MediaInfo Command line, MediaInfoLib - v22.03 ################################## Two videos selected, "photos " > "Batch manager" > " Global mode" Action " Videos" "Thumbnail" checked "Apply actions" ################################## -results (see hereunder and screenshots attached) -displayed in red "You ask me to do nothing, are you sure?" -displayed in green" Array Array" - bunch of error lines: Warning: array_merge(): Expected parameter 1 to be an array, null given in /var/www/html/piwigo/plugins/piwigo-videojs/admin/admin_batchmanager.php on line 151 Warning: array_merge(): Expected parameter 1 to be an array, null given in /var/www/html/piwigo/plugins/piwigo-videojs/admin/admin_batchmanager.php on line 176 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_dependencies.php on line 38 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_dependencies.php on line 38 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_dependencies.php on line 38 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_dependencies.php on line 38 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 52 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 52 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 52 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 77 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 84 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 112 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 202 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 77 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 84 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 112 Notice: Trying to access array offset on value of type null in /var/www/html/piwigo/plugins/piwigo-videojs/include/function_sync2.php on line 202 ################################## ![Capture d’écran du 2022-12-28 16-22-06](https://user-images.githubusercontent.com/64729485/209981885-d1842b66-a443-43ac-9ccd-ce340ea7f4d6.png) ![Capture d’écran du 2022-12-28 16-13-31](https://user-images.githubusercontent.com/64729485/209981888-6b08a5e4-1f95-4d13-a877-910119e27fbd.png) ![Capture d’écran du 2022-12-28 16-13-14](https://user-images.githubusercontent.com/64729485/209981891-95851bf5-6b43-4b14-ba03-69b4a5cf0fc7.png)
using 13.4 version of piwigo, nothing done for video
https://api.github.com/repos/Piwigo/Piwigo/issues/1844/comments
1
2022-12-29T16:31:01Z
2022-12-29T18:23:56Z
https://github.com/Piwigo/Piwigo/issues/1844
1,513,883,795
1,844
[ "Piwigo", "Piwigo" ]
Would it be possible to add an alt-text field to each photo? It would be nice if my blind friends could follow along as well. The alt attribute is used by people who depend on a screenreader. It reads out a description of what you can see on an image, if that description is provided. A description could be something like _"A red cat on a news paper on a table"_. This is something else that the title of an image, which, in this case could be: _"Go away, cat!"_ As you can see, the title has a different function than the alt-text. In this case they complement each other. And even now, where I didn’t provide the image of that cat, you can still imagine what it looks like. That’s the power of the alt-attribute. Right now, Piwigo uses the title field to fill the alt attribute. This means that the title will be read out _twice_ if you use a screen reader. Once when you hear the alt attribute, and then again when the title is read out. Hearing your screenreader say something like _"Image: Go away, cat! Title: Go away, cat!"_ is in no way comparable to _"Image: A red cat on a newspaper on a table. Title: Go away, cat!"_ But it even gets a bit worse: if no title is added (which is by default), the alt text is the name of the image file, with its extension. Which in the above example where we see a red can on a table, would result in a blind person hearing _"Image: DSC01790.JPG"_. This is not considered to be good UX since it really has nothing to do with a red cat on a newspaper on a table. It would therefore be fantastic if it was possible to add an extra alt-text field to the single image edit mode. When this alt-text-field is filled, it will show up in the alt-attribute, and when it is left empty, the alt attribute is left empty as well, which is better than filling it with the file name, or a redundant title. (it should be left empty, not removed. If you remove the alt attribute from the image, the file name will be read out…) It would then be very helpful for many people if a good explanation was added next to this field, so that people would start to use it properly. And yes, I have taught photographers who don’t know anything about the web about alt-text, and the all use it and they even like it (-:
A field to add a serious alt text to each photo
https://api.github.com/repos/Piwigo/Piwigo/issues/1843/comments
1
2022-12-27T15:16:00Z
2023-03-19T14:39:20Z
https://github.com/Piwigo/Piwigo/issues/1843
1,511,895,185
1,843
[ "Piwigo", "Piwigo" ]
I'm interested in using the web api, but I wonder if there is any schema files or similar documentation? I've found the link to discover all methods (http://yourdomain/yourpiwigo/tools/ws.htm), but what I'm looking for is information that could be used to generate code. I'm thinking about writing some java services on top with help of the rest api and json, and it would be create to be able to automatically generate the classes to be used with the rest interface.
Generated schema files for the Piwigo Web API
https://api.github.com/repos/Piwigo/Piwigo/issues/1842/comments
0
2022-12-27T14:43:20Z
2024-02-19T12:44:10Z
https://github.com/Piwigo/Piwigo/issues/1842
1,511,866,231
1,842
[ "Piwigo", "Piwigo" ]
Following #1827 it would be very useful to know when (and which) core updates have been applied. It would even be useful to have a trace of all "system activities", such as plugin/theme installations, activations... and also maintenance actions or configuration registration.
register system activities (core updates, plugin activations...)
https://api.github.com/repos/Piwigo/Piwigo/issues/1841/comments
0
2022-12-24T16:35:07Z
2023-01-21T11:00:29Z
https://github.com/Piwigo/Piwigo/issues/1841
1,510,141,695
1,841
[ "Piwigo", "Piwigo" ]
When an administrator adds a new user, we have the `user_id` (`activity.object_id`) and it could be found in the users table, but instead we only have "user#id" in the details.
[activities] missing usernames on user registration
https://api.github.com/repos/Piwigo/Piwigo/issues/1839/comments
0
2022-12-21T17:59:16Z
2022-12-21T18:02:59Z
https://github.com/Piwigo/Piwigo/issues/1839
1,506,709,336
1,839
[ "Piwigo", "Piwigo" ]
On photo libraries with many users connecting everyday, the list of user activities quickly becomes "polluted" with "not that important" information. We would like to be able to hide all connections or just hide connections from "non admins".
[activities] hide connections from user activity list
https://api.github.com/repos/Piwigo/Piwigo/issues/1838/comments
0
2022-12-21T16:17:03Z
2022-12-22T01:48:00Z
https://github.com/Piwigo/Piwigo/issues/1838
1,506,569,592
1,838
[ "Piwigo", "Piwigo" ]
![image](https://user-images.githubusercontent.com/60923356/208913849-a533979b-9e84-4fd8-b1ba-f1c82b3424f6.png) We want to implement a dropdown under the badges for more clarity in the album manager.
[Album Manager] Add custom tooltip for the badges
https://api.github.com/repos/Piwigo/Piwigo/issues/1837/comments
2
2022-12-21T13:17:45Z
2023-01-23T15:26:37Z
https://github.com/Piwigo/Piwigo/issues/1837
1,506,285,442
1,837
[ "Piwigo", "Piwigo" ]
Following #1827 and considering we haven't used the obsolete.list file in any minor update patch for 8 years (last one was for `2.7.x_to_2.7.4` it would be simpler and safer to completely avoid executing deletion instructions provided by an obsolete.list file.
no longer execute obsolete.list instructions on minor updates
https://api.github.com/repos/Piwigo/Piwigo/issues/1836/comments
0
2022-12-21T11:21:07Z
2022-12-21T11:22:38Z
https://github.com/Piwigo/Piwigo/issues/1836
1,506,145,407
1,836
[ "Piwigo", "Piwigo" ]
Hello, I found Stored XSS in Piwigo version 13.4.0. **Impact:** In this way, ordinary users can be promoted to administrator users. **Here are the complete attack steps:** 1. Register an ordinary user. ![image](https://user-images.githubusercontent.com/71068573/208852813-4ff58926-0e8b-4940-bb4d-dcba99b4aeae.png) 2. Sign out. 3. POST messages with burpsuite, and change User-Agent's data to xss-payload. Here's an example. ``` POST /src/piwigo/identification.php HTTP/1.1 Host: 192.168.2.153 Content-Length: 98 Cache-Control: max-age=0 Upgrade-Insecure-Requests: 1 Origin: http://192.168.2.153 Content-Type: application/x-www-form-urlencoded User-Agent: <script>alert(document.cookie);</script> (<svg+onload=alert(1)>) Chrome/108.0.0.0 Safari/537.36 Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9 Referer: http://192.168.2.153/src/piwigo/identification.php Accept-Encoding: gzip, deflate Accept-Language: zh-CN,zh;q=0.9 Cookie: phavsz=1445x798x1.25; pwg_id=ocv8aqqvjkdcshuv99j8l3ctub; pwg_tags_per_page=100; pwg_album_manager_view=tile; PHPSESSID=pfjer613d8pnr8ou8uj458i837 Connection: close username=w1nd&password=123456&remember_me=<svg+onload=alert(1)>&redirect=&login=%E6%8F%90%E4%BA%A4 ``` ![image](https://user-images.githubusercontent.com/71068573/208853591-ff2301ae-6106-43a6-9769-96b76208922b.png) 4. Finally, when the administrator user logs in and visit /admin.php?page=user_activity, the stored xss will be triggered. `/admin.php?page=user_activity` ![image](https://user-images.githubusercontent.com/71068573/208853661-115ae9c5-2256-4425-a480-6ce41706b66d.png) ![image](https://user-images.githubusercontent.com/71068573/208853690-abc73865-40e4-4b67-9a30-d2ce80efad5c.png) Please fix the vulnerability & let me know :). Thank You!
Piwigo-13.4.0-Stored XSS Vulnerability in User-Agent
https://api.github.com/repos/Piwigo/Piwigo/issues/1835/comments
0
2022-12-21T08:21:08Z
2022-12-25T10:25:36Z
https://github.com/Piwigo/Piwigo/issues/1835
1,505,891,189
1,835
[ "Piwigo", "Piwigo" ]
We want to add a filter badge to keep track of the number of filters active and a little phrase to show how many users are filtered. - [x] Badge - [x] User filtered sentence
[User Manager] Add filter informations
https://api.github.com/repos/Piwigo/Piwigo/issues/1834/comments
0
2022-12-20T13:18:37Z
2023-01-23T15:26:00Z
https://github.com/Piwigo/Piwigo/issues/1834
1,504,548,450
1,834
[ "Piwigo", "Piwigo" ]
$conf['question_mark_in_urls'] = false; $conf['php_extension_in_urls'] = false; .htaccess AcceptPathInfo On Options +MultiViews Since upgrading to php 8.x for PIWIGO 13.x the above options no longer work. For me this is a major issue, as all my sitemaps used this option, and of course, with it now broken if anyone searches on the web for my photography the link no loner works as / is. I did manage to get working a rather messy workaround that adds .php? to incoming URL, but I have not been able to generate a new sitemap, as hopefully this will get fixed in the future.
Since php 8.x - question_mar / php_extension not working
https://api.github.com/repos/Piwigo/Piwigo/issues/1833/comments
1
2022-12-19T16:19:30Z
2023-02-25T01:27:46Z
https://github.com/Piwigo/Piwigo/issues/1833
1,503,220,979
1,833
[ "Piwigo", "Piwigo" ]
The number of users per page is now saved in database with user pref
[User Manager] Save pagination in user_prefs
https://api.github.com/repos/Piwigo/Piwigo/issues/1832/comments
0
2022-12-19T15:33:09Z
2023-01-23T15:27:01Z
https://github.com/Piwigo/Piwigo/issues/1832
1,503,155,547
1,832
[ "Piwigo", "Piwigo" ]
When you delete an album from the edit page, you are redirected to the old cat_list page, instead of the albums page
[Album Edit] Wrong redirect when deleting an album
https://api.github.com/repos/Piwigo/Piwigo/issues/1831/comments
0
2022-12-19T14:25:28Z
2023-01-23T15:27:13Z
https://github.com/Piwigo/Piwigo/issues/1831
1,503,052,619
1,831
[ "Piwigo", "Piwigo" ]
Following #1801 I can still see this kind of query on admin dashboard ``` SELECT id FROM images LEFT JOIN image_category ON id = image_id WHERE category_id is null ORDER BY id ASC ; (this query time : 7.399 s) (total SQL time : 7.450 s) (total time : 7.524 s) (num rows : 10 ) ``` 7.399 seconds is huge. This gallery may have 500k photos, there must be a way to find the number of orphans faster.
calculating number of orphans is (still) slow
https://api.github.com/repos/Piwigo/Piwigo/issues/1830/comments
0
2022-12-16T10:02:58Z
2023-10-06T13:03:35Z
https://github.com/Piwigo/Piwigo/issues/1830
1,499,923,037
1,830
[ "Piwigo", "Piwigo" ]
Hi, i reported a security vulnerability about a stored XSS. you can see all the details here: https://huntr.dev/bounties/24782873-43d5-4315-bacc-a3ae18ce41f9/ i hope i was helpful
Security Vulnerability
https://api.github.com/repos/Piwigo/Piwigo/issues/1829/comments
1
2022-12-15T13:22:14Z
2023-07-07T13:55:08Z
https://github.com/Piwigo/Piwigo/issues/1829
1,498,429,209
1,829
[ "Piwigo", "Piwigo" ]
In my piwigo setup I have changed the "upload" folder into a symlink, which points to a raid on my server. After upgrading to Piwigo 13.3, this symlink is gone, and when checking the folder it was pointing to, its completely empty. It actually looks like the upgrade process has deleted all of my pictures. The only images I can find is just thumbnails, located in _data/i/upload. Luckily I do have a backup of all pictures on a different raid, however I assume not everyone actually has that. I also had some videos on the raid which I used the "synchronize" feature to add to Piwigo, but they are still present on the raid. My setup was as following: /var/www/html/upload -> /raid/piwigo/pictures /var/www/html/galleries/videos -> /raid/piwigo/videos So all videos on the raid is still there, but all pictures are gone. The video symlink is still present, but the "upload" symlink is gone + pictures on raid is gone.
Pictures gone/deleted after upgrade from 13.1 -> 13.3
https://api.github.com/repos/Piwigo/Piwigo/issues/1827/comments
20
2022-12-15T10:10:36Z
2023-08-31T16:06:34Z
https://github.com/Piwigo/Piwigo/issues/1827
1,498,152,783
1,827
[ "Piwigo", "Piwigo" ]
When we open the create user popin, the username input should be focused on.
[User Manager] Focus on the username input when creating user
https://api.github.com/repos/Piwigo/Piwigo/issues/1826/comments
0
2022-12-14T11:36:06Z
2022-12-15T20:31:44Z
https://github.com/Piwigo/Piwigo/issues/1826
1,496,425,682
1,826
[ "Piwigo", "Piwigo" ]
When we select a set, all the users are selected, without taking care of the filter used
[User Manager] Selection mode set selection issue
https://api.github.com/repos/Piwigo/Piwigo/issues/1825/comments
0
2022-12-14T11:02:20Z
2022-12-15T20:32:20Z
https://github.com/Piwigo/Piwigo/issues/1825
1,496,356,739
1,825
[ "Piwigo", "Piwigo" ]
Imagine you have users registered from January 2015 to September 2022. The "registered on" filter will start on "Jan 2015" and stop on "Sep 2022". We're now in December 2022, and we create a new user. This user won't appear in the list! Simply because `pwg.users.getList` is called with `min_register=2015 1` and `max_register=2022 9`, excluding automatically any user registered in December 2022. Only a refresh on the page make the new user appear in the list. The filter should be applied when closed OR `min_register` should not be used if equals the minimum value and `max_register` should not be applied if equals the maximum value.
[user manager] filters min_register/max_register applied even when filters closed
https://api.github.com/repos/Piwigo/Piwigo/issues/1824/comments
0
2022-12-13T14:33:06Z
2022-12-13T14:34:41Z
https://github.com/Piwigo/Piwigo/issues/1824
1,494,369,716
1,824
[ "Piwigo", "Piwigo" ]
Name:Piwigo Version:13.3.0 Download Link: [Download](https://cn.piwigo.org/download/dlcounter.php?code=latest) ![image](https://user-images.githubusercontent.com/11979927/207238636-91a7b5db-3614-4a82-995b-e3d2fd80a5c8.png) Problematic packets: > POST /admin.php?page=album-1-properties HTTP/1.1 > Host: 10.1.35.85 > Content-Length: 83 > Cache-Control: max-age=0 > Upgrade-Insecure-Requests: 1 > Origin: http://10.1.35.85 > Content-Type: application/x-www-form-urlencoded > User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36 > Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9 > Referer: http://10.1.35.85/admin.php?page=album-1-properties > Accept-Encoding: gzip, deflate > Accept-Language: zh-CN,zh;q=0.9 > Cookie: pwg_id=4krmi42ujo29itg4pcvk9msjh2 > Connection: close > > name=%3Cimg+src%3D%221%22+onerror%3D%22alert%281%29%22%3E&comment=&parent=0&submit= > Vulnerability recurrence 1.Log in to the background,Click "Albums" ->"Manage ->"Edit Album" ![image](https://user-images.githubusercontent.com/11979927/207276225-0f4aa605-6c2a-4008-a9f5-7960e2514d3b.png) 2.input payload:<img src="1" onerror="alert(document.domain)">,Submit。 ![image](https://user-images.githubusercontent.com/11979927/207276587-2d68d45c-a633-4178-a770-127c3db6add3.png) PS:The vulnerability will be displayed. Line 124 of admin.php directly outputs the parameter of album without filtering, which leads to this vulnerability. ![image](https://user-images.githubusercontent.com/11979927/207277655-b42e3515-f397-4f24-afd6-9234f28e4ddc.png) ![image](https://user-images.githubusercontent.com/11979927/207277089-43a45038-359b-47b3-9be0-dfdae6bd22ef.png)
Piwigo 13.3.0 exists stored cross-site scripting (XSS)
https://api.github.com/repos/Piwigo/Piwigo/issues/1823/comments
0
2022-12-13T09:20:01Z
2022-12-13T09:20:01Z
https://github.com/Piwigo/Piwigo/issues/1823
1,493,795,513
1,823
[ "Piwigo", "Piwigo" ]
This is an error that occasionally pops up. I have an image entry in my database that has the following characteristics: ID = 80079 File = 8362e904.jpg When you try to access the page for the image, you get the following Mysql error: ``` [mysql error 1367] Illegal double '8362e904' value found during parsing SELECT id, file, level FROM piwigo_images WHERE id = 8362e904 in piwigo/include/dblayer/functions_mysqli.inc.php on line 847 ``` As you can see, the software identifies "8362e904" as the ID and not the file name. It determines that the variable is actually a number, therefore it must be the numerical ID. Can an additional check be added to correctly determine if it is an integer before assuming it is a valid ```mediumint```?
Mysql "Illegal double" Error on ID / File name
https://api.github.com/repos/Piwigo/Piwigo/issues/1821/comments
2
2022-12-13T05:50:24Z
2022-12-17T18:43:07Z
https://github.com/Piwigo/Piwigo/issues/1821
1,493,436,732
1,821
[ "Piwigo", "Piwigo" ]
On password reset page, I have a "incorrect username or email address" error and I'm pretty sure it's caused by a + in my mail address
Password reset and "+" symbol in email address
https://api.github.com/repos/Piwigo/Piwigo/issues/1820/comments
1
2022-12-10T17:44:46Z
2022-12-10T17:46:58Z
https://github.com/Piwigo/Piwigo/issues/1820
1,488,740,562
1,820
[ "Piwigo", "Piwigo" ]
Hi I am willing to write a simple MySQL script that can connect to the piwigo db to create and add tags to photos. This would allow integration with photoprism and other tools (any, potentially, and also implement tagging rules). Today we have mugshot which does not work in the background and is constrained to whatever is explicitly coded in there. What I want to write is a function that allows to assign tags to files directly on db (that should be done by editing image_tags) and create or check tags. This part I am missing, I need to alter the list of tags adding entries, for example I identify “John Smith” on photo 1 , photo 7 and photo 346 using another tool. I need to check whether a tag called “John Smith” exists or not, create it if not, and assign it to photos. However I do not find the tag names linked to their tag ids. Help?
Tag interface with external AI tools
https://api.github.com/repos/Piwigo/Piwigo/issues/1819/comments
3
2022-12-08T20:34:18Z
2023-03-19T14:41:24Z
https://github.com/Piwigo/Piwigo/issues/1819
1,485,355,327
1,819
[ "Piwigo", "Piwigo" ]
`include/functions_comment.inc.php` was last changed on 2022-11-22 (commit 117c7c7530c0072ac1782f6b374d5107f81f18da) on the 13.x branch but is not included in the 13.x_to_13.3.0.zip upgrade archive (as downloaded per https://piwigo.org/download/dlcounter.php?code=13xto1330). The recently updated `check_files_integrity` plugin rightly complains in an upgraded installation. This might actually be responsible for some weird "apostrophes in comments work / do not work / are not escaped /are escaped" reports in the forum. Question remains, what else is missing..
The 13.x_to_13.3.0 upgrade archive lacks the include/functions_comment.inc.php file.
https://api.github.com/repos/Piwigo/Piwigo/issues/1818/comments
4
2022-12-07T23:25:30Z
2023-01-09T15:04:43Z
https://github.com/Piwigo/Piwigo/issues/1818
1,483,083,524
1,818
[ "Piwigo", "Piwigo" ]
I've upgraded my Piwigo installation 13.3.0 from PHP 7.4 to PHP 8.1 and after doing so, the mobile app (Android) does not work any more. It stucks when trying to load the albums. Enabled the PHP error log at the server and there is following message: PHP Deprecated: strip_tags(): Passing null to parameter #1 ($string) of type string is deprecated in /www/htdocs/w00bce33/photo/include/ws_functions/pwg.categories.php on line 324
Mobile app does not work after upgrading server to PHP 8.1
https://api.github.com/repos/Piwigo/Piwigo/issues/1816/comments
2
2022-12-04T00:22:57Z
2023-02-11T16:57:13Z
https://github.com/Piwigo/Piwigo/issues/1816
1,474,292,126
1,816
[ "Piwigo", "Piwigo" ]
This is an improvement that could be made to improve functionality with the [Extended Descriptions](https://piwigo.org/ext/extension_view.php?eid=175) plugin. The Extended Description plugin adds the ability to use hidden HTML tags inside of title and description blocks. The addition of a ```<!--hidden-->``` tag in the title will make the album not appear on the parent album or index listing. This works really great for making custom pages that link to the albums in other ways. The issue comes when the URL for the page is generated by the system. While the regular expressions work correctly to strip out the tag brackets, it will leave the rest of the HTML code behind. So for example an album with this title: ````<!--hidden-->My Secret Album```` will generate a URL that says: ````#_hidden_my_secret_album````. ```` function str2url($str) { $str = $safe = pwg_transliterate($str); $str = preg_replace('/[^\x80-\xffa-z0-9_\s\'\:\/\[\],-]/','',$str); $str = preg_replace('/[\s\'\:\/\[\],-]+/',' ',trim($str)); $res = str_replace(' ','_',$str); if (empty($res)) { $res = str_replace(' ','_', $safe); } return $res; } ```` Add the strip_tags function at the start of the code. ```` function str2url($str) { $str = strip_tags($str); $str = $safe = pwg_transliterate($str); $str = preg_replace('/[^\x80-\xffa-z0-9_\s\'\:\/\[\],-]/','',$str); $str = preg_replace('/[\s\'\:\/\[\],-]+/',' ',trim($str)); $res = str_replace(' ','_',$str); if (empty($res)) { $res = str_replace(' ','_', $safe); } return $res; } ```` This will generate a tag correctly. This title: ````<!--hidden-->My Secret Album```` will generate a URL that says: ````#_my_secret_album````. The other alternative is creating permalinks for each and every album, but that would not help with picture URLs which also can use the <!--hidden--> tags in their titles.
Strip Tags from URL
https://api.github.com/repos/Piwigo/Piwigo/issues/1815/comments
0
2022-12-02T20:41:01Z
2022-12-02T22:30:56Z
https://github.com/Piwigo/Piwigo/issues/1815
1,473,420,346
1,815
[ "Piwigo", "Piwigo" ]
I am noting in the JS file ```batchManagerGlobal.js``` that the standard batch size for md5 sync's is 1000 files. This worked really well until I started processing files that were 8MB+. After a few hundred seconds the command would timeout because it wasn't receiving data back fast enough. Is it possible to make the value a bit more dynamic based on file size? Changing the value temporarily to a size of 10 and it was able to process everything after a few minutes.
MD5 batch size too large when files are large?
https://api.github.com/repos/Piwigo/Piwigo/issues/1814/comments
0
2022-12-01T06:46:16Z
2022-12-01T06:46:37Z
https://github.com/Piwigo/Piwigo/issues/1814
1,470,771,693
1,814
[ "Piwigo", "Piwigo" ]
Just upgraded from 12.3.0 to 13.3.0 (with php 7.4) I have a problem with all internal links of the frontend (not in the administration) that are missing a '?' (when i add it manually i can see the correct page). It happens on all the themes i have tested (elegant, bootstrap_darkroom and smartpocket). For exemple the link to a category is > mypiwigoinstance/index.php/category/mycategory but should be > mypiwigoinstance/index.php?/category/mycategory
[13.3.0] Missing '?' in links
https://api.github.com/repos/Piwigo/Piwigo/issues/1813/comments
3
2022-11-29T15:43:59Z
2022-12-08T08:47:50Z
https://github.com/Piwigo/Piwigo/issues/1813
1,468,281,787
1,813
[ "Piwigo", "Piwigo" ]
When you create a sub album of a private album, it must be set to private with the proper icon (icon-lock). In back end the album is properly set to private but the front end show us a public album when it is created, no matter the status of the parent
[Album Manager] No lock icon for newly created private albums
https://api.github.com/repos/Piwigo/Piwigo/issues/1812/comments
1
2022-11-28T15:24:27Z
2023-02-13T09:41:08Z
https://github.com/Piwigo/Piwigo/issues/1812
1,466,620,035
1,812
[ "Piwigo", "Piwigo" ]
![image](https://user-images.githubusercontent.com/60923356/204261984-d7ee3f69-c146-4081-8198-5b7343b9b34a.png)
[Album Manager] Add a custom tooltip for the badges
https://api.github.com/repos/Piwigo/Piwigo/issues/1811/comments
0
2022-11-28T11:05:36Z
2023-06-26T09:34:25Z
https://github.com/Piwigo/Piwigo/issues/1811
1,466,224,999
1,811
[ "Piwigo", "Piwigo" ]
Color contrast of the inactive tab should be improved for good accessibility.
Color contrast
https://api.github.com/repos/Piwigo/Piwigo/issues/1810/comments
5
2022-11-25T15:10:57Z
2023-01-25T12:33:30Z
https://github.com/Piwigo/Piwigo/issues/1810
1,464,670,995
1,810
[ "Piwigo", "Piwigo" ]
When opening the delete album popin, I can see some ajax requests to `pwg.categories.calculateOrphans`. Sometimes only 1, but sometimes many calls. For example, 17 calls for the exact same album. It sounds too much.
[13.x, album manager] too many calls to pwg.categories.calculateOrphans
https://api.github.com/repos/Piwigo/Piwigo/issues/1809/comments
1
2022-11-25T10:24:40Z
2022-11-28T14:50:43Z
https://github.com/Piwigo/Piwigo/issues/1809
1,464,333,692
1,809
[ "Piwigo", "Piwigo" ]
... whatever the option selected by the user. This bug silently deletes photos and needs an immediate solution.
[13.x, album manage] deleting album always delete orphans
https://api.github.com/repos/Piwigo/Piwigo/issues/1808/comments
0
2022-11-25T10:06:24Z
2022-11-25T10:10:01Z
https://github.com/Piwigo/Piwigo/issues/1808
1,464,306,109
1,808
[ "Piwigo", "Piwigo" ]
On the plugin manager, the JS causes long page loading time the more plugins there are.
[Plugin Manager] Latency problems when there is a lot of plugins
https://api.github.com/repos/Piwigo/Piwigo/issues/1807/comments
0
2022-11-23T14:53:22Z
2022-11-28T08:20:41Z
https://github.com/Piwigo/Piwigo/issues/1807
1,461,906,537
1,807
[ "Piwigo", "Piwigo" ]
![image](https://user-images.githubusercontent.com/60923356/203537724-bc9f2a02-7d4a-4a59-a1d7-d604468879ac.png) New icons implementation and new tooltip for the badges
[Album Manager] UI Upgrade for the album manager
https://api.github.com/repos/Piwigo/Piwigo/issues/1806/comments
2
2022-11-23T11:45:32Z
2022-11-28T14:26:51Z
https://github.com/Piwigo/Piwigo/issues/1806
1,461,607,378
1,806
[ "Piwigo", "Piwigo" ]
Hallo I have Piwigo 13.2.0 with Plugin Community 12.c from "plg" on Ubuntu 18.04 with Apache 2.4 and PHP 8.0 I set the permission to everybody on an album and if a user opens the gallery with a mobile device, and tries to upload pictures with Menu-Button > Menü > Bilder hochladen there is no File-menu to upload. If the user switches to Default ("Standard") view (instead of "Mobil" View) the dialog appears and sometimes it is possible to upload, but often there is an error shown: not enough memory. frank
Community - upload on Android in mobile view not working
https://api.github.com/repos/Piwigo/Piwigo/issues/1804/comments
1
2022-11-22T20:13:42Z
2023-07-27T09:20:07Z
https://github.com/Piwigo/Piwigo/issues/1804
1,460,492,724
1,804
[ "Piwigo", "Piwigo" ]
null
[Album Manager] Click on action icons is hard with tiptip
https://api.github.com/repos/Piwigo/Piwigo/issues/1803/comments
0
2022-11-22T15:47:08Z
2022-11-23T09:52:47Z
https://github.com/Piwigo/Piwigo/issues/1803
1,460,120,198
1,803
[ "Piwigo", "Piwigo" ]
I've notice that when you add a comment on a picture, the username and the comment are escaped twice because with things like \' in the comments. The same is true when you create a new user or create an album
Escapes in comments, users and albums are done twice
https://api.github.com/repos/Piwigo/Piwigo/issues/1802/comments
0
2022-11-22T15:00:58Z
2022-11-23T09:56:47Z
https://github.com/Piwigo/Piwigo/issues/1802
1,460,040,827
1,802
[ "Piwigo", "Piwigo" ]
With more hundreds of thousands photos, calculating the number of orphan photos, performed on each admin page, is slow: ``` SELECT id FROM images LEFT JOIN image_category ON id = image_id WHERE category_id is null ORDER BY id ASC ; (this query time : 1.862 s) ``` We may not need to calculate this on each page, every second...
calculating number of orphans is slow
https://api.github.com/repos/Piwigo/Piwigo/issues/1801/comments
0
2022-11-22T10:14:23Z
2022-11-22T11:24:04Z
https://github.com/Piwigo/Piwigo/issues/1801
1,459,556,238
1,801
[ "Piwigo", "Piwigo" ]
Javascript syntax error in Català for user manager and photo edition page.
broken page (javascript issue) on user manager and photo edit in Català
https://api.github.com/repos/Piwigo/Piwigo/issues/1800/comments
0
2022-11-22T08:21:45Z
2022-11-22T10:05:10Z
https://github.com/Piwigo/Piwigo/issues/1800
1,459,369,671
1,800
[ "Piwigo", "Piwigo" ]
After I've upgraded my Piwigo instance to version 13, the plugin management page `admin.php?page=plugin` stopped working. It displays fine, I can browse and install new plugins, but the management of downloaded plugins is impossible. The toggles for plugin activition do turn to the activated state when I click them, but nothing happens in the background and they return the the inactive state after page refresh. This means that I can install plugins but I can't activate them (aside from writing directly to the SQL database using Adminer, for instance). Similarly, other interactive elements within the page down work -- switching the layout, filtering (activated, deactivated), searching, ... Tested in multiple browsers. My browser console shows: ``` Uncaught ReferenceError: actualizeFilter is not defined <anonymous> https://myURL.xyz/mygallery/_data/combined/d0gzsd.js:156 j https://myURL.xyz/mygallery/_data/combined/vxjfpm.js:5 fireWith https://myURL.xyz/mygallery/_data/combined/vxjfpm.js:5 ready https://myURL.xyz/mygallery/_data/combined/vxjfpm.js:5 J https://myURL.xyz/mygallery/_data/combined/vxjfpm.js:5 promise https://myURL.xyz/mygallery/_data/combined/vxjfpm.js:5 ready https://myURL.xyz/mygallery/_data/combined/vxjfpm.js:5 init https://myURL.xyz/mygallery/_data/combined/vxjfpm.js:5 m https://myURL.xyz/mygallery/_data/combined/vxjfpm.js:5 <anonymous> https://myURL.xyz/mygallery/_data/combined/vxjfpm.js:5 <anonymous> https://myURL.xyz/mygallery/_data/combined/vxjfpm.js:5 <anonymous> https://myURL.xyz/mygallery/_data/combined/vxjfpm.js:5 ``` I've tried deleting the `piwigo_plugins` table (delete and then create an empty one with the same structure) as per https://piwigo.org/forum/viewtopic.php?pid=183333#p183333 . Didn't help. I've also tried deleting the whole directory `mygallery/_data/combined`, just to be sure. Didn't help.
Plugins page doesn't work after upgrade to Piwigo 13
https://api.github.com/repos/Piwigo/Piwigo/issues/1799/comments
0
2022-11-21T08:06:20Z
2022-11-21T08:06:20Z
https://github.com/Piwigo/Piwigo/issues/1799
1,457,491,949
1,799
[ "Piwigo", "Piwigo" ]
Hallo Piwigo 13.1.0 or 13.2.0, no difference and latest download of LightBox 12.a by P@t: If I activate the [extension Lightbox](https://piwigo.org/ext/extension_view.php?eid=280) which says to be compatible with Piwigo 13 and open an image, there is a Fatal Error and the site crashes: ```Fatal error: Uncaught TypeError: implode(): Argument #1 ($pieces) must be of type array, string given in /var/www/example.org/galerie/piwigo/plugins/lightbox/lightbox.php:31 Stack trace: #0 /var/www/example.org/galerie/piwigo/plugins/lightbox/lightbox.php(31): implode() #1 /var/www/example.org/galerie/piwigo/plugins/lightbox/main.inc.php(18): include('...') #2 /var/www/example.org/galerie/piwigo/include/functions_plugins.inc.php(214): lightbox_plugin() #3 /var/www/example.org/galerie/piwigo/include/category_default.inc.php(146): trigger_change() #4 /var/www/example.org/galerie/piwigo/index.php(306): include('...') #5 {main} thrown in /var/www/example.org/galerie/piwigo/plugins/lightbox/lightbox.php on line 31``` In the extensions' settings I see already a lot of warnings, e.g. "undefined array key" etc. Seems not completely compatible with PHP 8 yet (even PHP 7 is very soon EOL). As there is no github site for this extension and the developer of it seems to be some dev from Piwigo himself, I post this bug here. The Forum is broken too, by the way, login not working, register not working as no confirmation-link nor password-forgotten link is sent (no, neither in spam, and neiter when I try several times and neither I get an answer from "[email protected]"), so this doesnt work: ``` Info An e-mail has been sent to the specified address with instructions on how to change your password. If it does not arrive you can contact the forum administrator at [email protected]. ``` Sorry. Thank, frank
Extension Lightbox - Crash when activated
https://api.github.com/repos/Piwigo/Piwigo/issues/1798/comments
0
2022-11-17T12:40:58Z
2022-11-17T12:40:58Z
https://github.com/Piwigo/Piwigo/issues/1798
1,453,279,830
1,798
[ "Piwigo", "Piwigo" ]
The JS breaks the page when the album name has an single quote in it
[Album Edit] Titles for photo order and notifications breaks the page
https://api.github.com/repos/Piwigo/Piwigo/issues/1796/comments
0
2022-11-16T14:59:59Z
2022-11-17T08:23:49Z
https://github.com/Piwigo/Piwigo/issues/1796
1,451,762,102
1,796
[ "Piwigo", "Piwigo" ]
null
[Edit photo] The title isn't translated
https://api.github.com/repos/Piwigo/Piwigo/issues/1795/comments
0
2022-11-16T14:25:29Z
2022-11-17T08:24:08Z
https://github.com/Piwigo/Piwigo/issues/1795
1,451,703,412
1,795
[ "Piwigo", "Piwigo" ]
When you create an album with Enter keypress causes the creation of multiple albums because each time we open the popin we add the keypress event so it adds up.
[Album Manager] Press enter causes multiple album creation
https://api.github.com/repos/Piwigo/Piwigo/issues/1794/comments
0
2022-11-16T14:15:22Z
2022-11-16T14:19:01Z
https://github.com/Piwigo/Piwigo/issues/1794
1,451,685,880
1,794
[ "Piwigo", "Piwigo" ]
The button label is wrong after we click on the sort album popin at root, then the label stays the same even when we open the sort order popin for sub albums
[Album Manager] Sort validation btn label isn't correct
https://api.github.com/repos/Piwigo/Piwigo/issues/1793/comments
0
2022-11-16T13:33:46Z
2022-11-16T14:19:31Z
https://github.com/Piwigo/Piwigo/issues/1793
1,451,616,412
1,793
[ "Piwigo", "Piwigo" ]
in php8 the get_magic_quotes_gpc function is removed and the escape for user input is broken
Php8 'get_magic_quotes_gpc' is removed and break user input escape
https://api.github.com/repos/Piwigo/Piwigo/issues/1792/comments
0
2022-11-16T11:59:44Z
2022-11-16T13:04:22Z
https://github.com/Piwigo/Piwigo/issues/1792
1,451,463,907
1,792
[ "Piwigo", "Piwigo" ]
The new album manager takes way too long to load. (approx. 30sec) Back and front need to be optimised.
[Album manager] Performance issues in front and backend for big album databases
https://api.github.com/repos/Piwigo/Piwigo/issues/1790/comments
0
2022-11-15T15:00:50Z
2022-11-23T09:49:39Z
https://github.com/Piwigo/Piwigo/issues/1790
1,449,926,937
1,790
[ "Piwigo", "Piwigo" ]
Hallo I just installed a clean and simple Piwigo 13.1 on my Ubuntu 18.04 LTS with PHP 8.0.25 I added two fotos into a "Testalbum" pic1.jpg and pic2.jpg When I go to Album > Manage > Testalbum > Edit album > Photos sort order I can check automatic order > File name Z>A > Save Settings But still I have pic1.jpg first, not pic2.jpg and I always read "Manual order" over my pics, never "Automatic order". Here a screenshot: ![grafik](https://user-images.githubusercontent.com/927269/201930567-6302c981-7442-4626-814f-a84519f244f5.png) I dont find a way, how this automatic sort would work. I noticed that issue, when I uploaded a bunch of fotos to a gallery and they were "Kraut und Rüben" (totally unsorted) and I didnt get them to an alphabetic order at all. So I created this two-pic-example with a fresh install. Maybe there is a way to make the automatic sorting work and I am just too blind to find, but at the moment it seems like a bug to me. Thank, frank
Automatic sort order not working
https://api.github.com/repos/Piwigo/Piwigo/issues/1789/comments
0
2022-11-15T13:27:48Z
2022-11-15T13:28:55Z
https://github.com/Piwigo/Piwigo/issues/1789
1,449,785,482
1,789
[ "Piwigo", "Piwigo" ]
The latest version of piwigo uploads pictures with a browser. When the pictures are uploaded to 100%, there is no action. I stayed here until the picture was uploaded to 100%. Chrome and edge browsers are used, and then mobile browsers are used.
Updated to the latest version, the browser can't upload pictures
https://api.github.com/repos/Piwigo/Piwigo/issues/1788/comments
6
2022-11-14T12:04:17Z
2022-12-31T15:55:06Z
https://github.com/Piwigo/Piwigo/issues/1788
1,447,936,731
1,788
[ "Piwigo", "Piwigo" ]
The scroll bar on Chrome is always visible even if there is no need for it. ![image](https://user-images.githubusercontent.com/60923356/201622252-ec2b1c7f-93c0-41b0-bd81-809adbcf9f22.png)
[Linked Albums popin] The scroll bar is always visible on Chrome
https://api.github.com/repos/Piwigo/Piwigo/issues/1787/comments
0
2022-11-14T09:19:57Z
2022-11-16T13:04:40Z
https://github.com/Piwigo/Piwigo/issues/1787
1,447,688,236
1,787
[ "Piwigo", "Piwigo" ]
The response provided by piwigo function ws_categories_getList in include/ws_function/pwg.categories.php is badly interpreted by Digikam's "Upload to Piwigo" webservice: "Invalid response received from remote Piwigo" (parseResponseListAlbums in core/dplugins/generic/webservices/piwigo/piwigotalker.cpp). Piwigo responses looks like: <?xml version="1.0" encoding="utf-8" ?> <rsp stat="ok"> <categories> <category id="215" ...> </category> </categories> </rsp> Digikam webservices logs are: digikam.webservices: parseResponseLogin: "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\n<rsp stat=\"ok\">\n1\n</rsp>" digikam.webservices: parseResponseGetVersion: "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\n<rsp stat=\"ok\">\n13.1.0\n</rsp>" digikam.webservices: Version: 1301 digikam.webservices: foundResponse : true digikam.webservices: parseResponseListAlbums
Upload from Digikam 7.8.0 to piwigo 13.1.0 broken
https://api.github.com/repos/Piwigo/Piwigo/issues/1786/comments
2
2022-11-13T19:54:57Z
2023-02-11T17:10:20Z
https://github.com/Piwigo/Piwigo/issues/1786
1,447,059,635
1,786
[ "Piwigo", "Piwigo" ]
If we add a link on the user edit popin to see his visit history, we can filter on any user even if it is not in the history first results.
[History page] Add possibility to filter on a user from the user page
https://api.github.com/repos/Piwigo/Piwigo/issues/1784/comments
0
2022-11-09T14:43:38Z
2022-11-16T13:05:13Z
https://github.com/Piwigo/Piwigo/issues/1784
1,442,229,979
1,784
[ "Piwigo", "Piwigo" ]
Since we can filter on an image from the history page, it would be nice to be able to go to the history page from the edit image page with the image as a filter.
[History page] Add posibility to filter on an image from the edit image page
https://api.github.com/repos/Piwigo/Piwigo/issues/1783/comments
0
2022-11-09T11:35:20Z
2022-11-16T13:05:03Z
https://github.com/Piwigo/Piwigo/issues/1783
1,441,932,229
1,783
[ "Piwigo", "Piwigo" ]
In the past we had a filed where we could input an IP and filter on it. Now we have to click on an IP that is already in the results. We should add a way to filter on specific IP that isn't directly in the results.
[History page] Can't filter on a specific IP
https://api.github.com/repos/Piwigo/Piwigo/issues/1782/comments
0
2022-11-09T10:33:43Z
2022-11-16T13:05:23Z
https://github.com/Piwigo/Piwigo/issues/1782
1,441,841,936
1,782
[ "Piwigo", "Piwigo" ]
We cant close the popin by pressing ESC and cant validate the form by pressing ENTER. There is also no info when we validate and the album name is empty.
[Album manager] Bad UX for the album creation popin
https://api.github.com/repos/Piwigo/Piwigo/issues/1781/comments
0
2022-11-08T16:22:01Z
2022-11-16T13:05:33Z
https://github.com/Piwigo/Piwigo/issues/1781
1,440,512,828
1,781
[ "Piwigo", "Piwigo" ]
When using thousands of albums, the new albums manager handling the whole hierarchy behaves very slowly. Even fails to load sometimes. Let's introduced a threshold to switch to the old manager (that is still available, actually)
[13.x] slow album manager with many albums
https://api.github.com/repos/Piwigo/Piwigo/issues/1780/comments
0
2022-11-08T11:17:25Z
2022-11-08T11:18:26Z
https://github.com/Piwigo/Piwigo/issues/1780
1,439,995,160
1,780
[ "Piwigo", "Piwigo" ]
When installing a fresh copy of 13.1.0, it fails. I found an error in the creation of the config file, in install.php and I made some changes to the code which let me complete the install. Could someone - who knows better than I do - look at the changes and see if the production code should be altered. This piece of code, from install.php line 310 to 329, is what you must find: ------------------------------- // writing the configuration file if ( !($fp = @fopen( $config_file, 'w' ))) { // make sure nobody can list files of _data directory secure_directory(PHPWG_ROOT_PATH.$conf['data_location']); $tmp_filename = md5(uniqid(time())); $fh = @fopen( PHPWG_ROOT_PATH.$conf['data_location'] . 'pwg_' . $tmp_filename, 'w' ); @fputs($fh, $file_content, strlen($file_content)); @fclose($fh); $template->assign( array( 'config_creation_failed' => true, 'config_url' => 'install.php?dl='.$tmp_filename, 'config_file_content' => $file_content, ) ); } @fputs($fp, $file_content, strlen($file_content)); @fclose($fp); ------------------------------- I replaced it with this. The fputs needs to be inside the braces, I think. If it's outside, it may be trying to write to the file even though the open has failed. ------------------------------------------------------------------ // writing the configuration file if ( ($fp = @fopen( $config_file, 'w' ))) { // make sure nobody can list files of _data directory secure_directory(PHPWG_ROOT_PATH.$conf['data_location']); $tmp_filename = md5(uniqid(time())); $tmp_fullfilename = PHPWG_ROOT_PATH.$conf['data_location'] . 'pwg_' . $tmp_filename; $fh = @fopen( $tmp_fullfilename, 'w' ); if ( $fh == 0 ) { @fclose($fp); fatal_error("$tmp_fullfilename is not writeable. Ensure directory and file are accessible and writeable."); } @fputs($fh, $file_content, strlen($file_content)); @fclose($fh); $template->assign( array( 'config_creation_failed' => true, 'config_url' => 'install.php?dl='.$tmp_filename, 'config_file_content' => $file_content, ) ); @fputs($fp, $file_content, strlen($file_content)); @fclose($fp); } else { fatal_error("Failed to open $config_file - Ensure directory and file are accessible and writeable."); } ------------------------------------------------------------------
Bug in 13.1.0 install
https://api.github.com/repos/Piwigo/Piwigo/issues/1779/comments
2
2022-11-08T08:08:12Z
2022-11-20T08:29:19Z
https://github.com/Piwigo/Piwigo/issues/1779
1,439,689,461
1,779
[ "Piwigo", "Piwigo" ]
working with docker we have to alter the image adding packages and this defeats easy rebuilds and portability. the main issue is, I have e.g. ffmpeg or any other package required for mobile, but these are on strange paths on NAS OS. for this there is a "docker" way to deal with it, which is run commands after container start, but is not really nice and requires constant maintenance of the command on top of the issue resolution of related packages in piwigo. I suggest that the external packages are moved to a separate directory than config, because config is also mounted in docker but managed by piwigo itself mostly. the whole point is e.g. I have ffpeg in /here/there/ffmpeg on host, and I would like to map the volume like /here/there:/external_pkgs/ffmpeg this also allows me to put another docker container in a single docker-compose.yml and make sure every external app complies with piwigo requirements and it will be easy to downgrade or upgrade them just when necessary and not by mistake.
feature request - external packages as volumes outside of conf
https://api.github.com/repos/Piwigo/Piwigo/issues/1778/comments
0
2022-11-06T09:39:28Z
2022-11-06T09:39:28Z
https://github.com/Piwigo/Piwigo/issues/1778
1,437,330,685
1,778
[ "Piwigo", "Piwigo" ]
Upgrade results in the following error: Fatal error: Uncaught --> Smarty: Smarty->_clearTemplateCache() undefined method <-- thrown in /var/www/pics/include/smarty/libs/sysplugins/smarty_internal_undefined.php on line 64 If I click reload in the browser, it brings up an update page for the database. I can click though and the upgrade appears to finish. Has it? This looks related to issue #1545 & #1558
Upgrade from 11.5.0 to 13.1.0 results in Fatal error.
https://api.github.com/repos/Piwigo/Piwigo/issues/1777/comments
1
2022-11-05T19:44:03Z
2023-10-01T21:07:41Z
https://github.com/Piwigo/Piwigo/issues/1777
1,437,164,978
1,777
[ "Piwigo", "Piwigo" ]
The tooltip on the sort order button it's done with the proper tooltip widget. It should be done like the "visit the gallery" btn. ![Capture d’écran de 2022-11-02 15-47-02](https://user-images.githubusercontent.com/60923356/199520889-76b4bba7-9dd2-49e5-93b9-1a5d1df51d26.png) ![Capture d’écran de 2022-11-02 15-44-40](https://user-images.githubusercontent.com/60923356/199520929-9eb61584-5c5b-4191-944e-87b68a89b4ed.png)
[Album Manager] No tooltip on the sort order button
https://api.github.com/repos/Piwigo/Piwigo/issues/1775/comments
0
2022-11-02T14:47:38Z
2022-11-16T13:05:46Z
https://github.com/Piwigo/Piwigo/issues/1775
1,433,279,435
1,775
[ "Piwigo", "Piwigo" ]
When we type for search, the popin height changed depending on the number of results we have. The height needs to be fixed and only let 4/5 results appear.
Linked albums popin height alway changes
https://api.github.com/repos/Piwigo/Piwigo/issues/1774/comments
0
2022-11-02T13:55:50Z
2022-11-16T13:05:58Z
https://github.com/Piwigo/Piwigo/issues/1774
1,433,190,938
1,774
[ "Piwigo", "Piwigo" ]
I mentioned before on #1649 that the uploaded video is corrupted, but no answer. Unfortunately, I encountered this problem again today. Although I did not know php, I analyzed the behavior of the browser and the server. I feel that I have found the problem. The logic of the two functions 'upload' and 'uploadCompleted' has some of bug. 1. When I upload a large file, piwigo will create a 'XXX.part' file under the 'gallery/upload/buffer' folder to store the uploaded temporary data, and the name of this 'XXX.part' seems to be a part of the file hash, so files with the same data always generate 'XXX.part' with the same name. 2. The front-end will call 'pwg.images.upload' in turn to pass the number of pieces to the server, and the server will write the data into the 'XXX.part' file in turn 3. The final front end calls 'pwg.images.uploadCompleted' to submit 'XXX.part' to the system Now the problem comes if I fail to upload a file, such as the network is disconnected or the system is hibernating (using the mobile network to upload the network abnormality or the system automatically sleeps for a long time is a very common problem). After a failure I re-upload the same archive 'piwigo' tells me the upload was successful but the data stored in 'piwigo' is wrong. For example, I transfer a file containing three chunks, chunk1 chunk2 chunk3. When uploading to chunk2 for the first time, the network is abnormal. At this time, the 'XXX.part' data stored by piwigo is chunk1+chunk2. When I found the error re-upload all went well, but 'piwigo' re-uploaded chunk1 chunk2 chunk3, so 'XXX.part' now stored chunk1+chunk2+chunk1+chunk2+chunk3 and submitted it to the system also told i succeed. When I saw the success message I thought the data was safely stored but in fact the wrong data was stored on the server which is obviously an unacceptable bug. So when the server is processing upload, if it finds that it is chunk1, it should truncate file size to 0. But this can't solve the problem of multiple users uploading the same file at the same time, to solve this problem, you should create a different 'XXX.part' for each user. In addition, in order to be more secure (such as preventing data from being tampered with by hackers), the 'UploadComplete' function should pass in the hash of the front-end uploaded data, and the server should verify whether the hash of the stored data is consistent. The following is the environment when I test: * amd64 * Linux Mint 20.3 Una * Piwigo 13.1.0 * docker-compose ``` version: '1' services: main: image: linuxserver/piwigo:latest restart: always ports: - 9000:80 environment: - TZ=Asia/Shanghai - PUID=1000 - PGID=1000 volumes: - ./data/gallery:/gallery db: image: mariadb:10.8 restart: always environment: - TZ=Asia/Shanghai - MYSQL_ROOT_PASSWORD=123 - MYSQL_DATABASE=piwigo - MYSQL_USER=piwigo - MYSQL_PASSWORD=piwigo12345678 volumes: - ./data/db:/var/lib/mysql ```
There is a bug in method 'upload' and 'uploadCompleted'
https://api.github.com/repos/Piwigo/Piwigo/issues/1773/comments
0
2022-11-01T16:15:05Z
2022-11-01T16:15:05Z
https://github.com/Piwigo/Piwigo/issues/1773
1,431,701,467
1,773
[ "Piwigo", "Piwigo" ]
On the upload form, the promotion of the mobile applications page on piwigo.org is hardcoded to open the page in English. It would be better to use the localized page, if any.
[13.x, upload form] promotion to mobile applications page always in English
https://api.github.com/repos/Piwigo/Piwigo/issues/1772/comments
0
2022-10-31T09:25:50Z
2022-10-31T09:28:13Z
https://github.com/Piwigo/Piwigo/issues/1772
1,429,529,612
1,772
[ "Piwigo", "Piwigo" ]
Just updated to 13.1. One of my albums has an apostrophe in the title. I was unable to manually sort the photos in that album, nor in any of its sub-albums. Removing the apostrophe allows me to sort photos normally; adding it back in breaks the page again. With the apostrophe present, the menus along the left side of the photo sort order page are all stuck open, which I think implies all the Javascript on the page is broken. In the inspection console I receive the error "Uncaught SyntaxError: missing ) after argument list [admin.php:582:93]"
Apostrophe in album name breaks "Photo sort order" page for that album and all its sub-albums
https://api.github.com/repos/Piwigo/Piwigo/issues/1771/comments
1
2022-10-30T22:40:03Z
2022-11-22T08:19:18Z
https://github.com/Piwigo/Piwigo/issues/1771
1,429,042,675
1,771
[ "Piwigo", "Piwigo" ]
I have encountered some unexpected detection of file type in `admin/include/functions_upload.inc.php` ``` elseif (IMAGETYPE_TIFF_MM == $type or IMAGETYPE_TIFF_II == $type) { $is_tiff = true; $file_path.= 'tif'; } ``` This piece of code tells Piwigo it's a TIFF file, while it's not.
some RAW files incrrectly considered as TIFF files
https://api.github.com/repos/Piwigo/Piwigo/issues/1770/comments
0
2022-10-29T14:19:12Z
2022-10-29T14:21:36Z
https://github.com/Piwigo/Piwigo/issues/1770
1,428,285,250
1,770
[ "Piwigo", "Piwigo" ]
Piwigo Fresh 13.1.0 Installation Warning: mysqli::__construct(): (HY000/2002): Connection refused in /gallery/inclu ![piwigo error](https://user-images.githubusercontent.com/37554361/198764733-653580a2-e960-4330-885c-8bf0553f8d5c.png) de/dblayer/functions_mysqli.inc.php on line 52 Warning: my_error(): Couldn't fetch mysqli in /gallery/include/dblayer/functions_mysqli.inc.php on line 839 Warning: my_error(): Couldn't fetch mysqli in /gallery/include/dblayer/functions_mysqli.inc.php on line 839 Piwigo encountered a non recoverable error [mysql error ] Can't connect to server #1 my_error /gallery/include/common.inc.php(118) #2 include_once /gallery/index.php(11)
Piwigo encountered a non recoverable error
https://api.github.com/repos/Piwigo/Piwigo/issues/1769/comments
0
2022-10-29T02:01:10Z
2022-10-29T02:01:10Z
https://github.com/Piwigo/Piwigo/issues/1769
1,428,018,821
1,769
[ "Piwigo", "Piwigo" ]
Change the label to 'Apply to root albums' when you open the popin at the root of your albums
Change label of button to apply order to albums at root
https://api.github.com/repos/Piwigo/Piwigo/issues/1768/comments
0
2022-10-25T09:20:10Z
2022-11-16T13:06:15Z
https://github.com/Piwigo/Piwigo/issues/1768
1,422,142,371
1,768
[ "Piwigo", "Piwigo" ]
When in php8 after we create a user, the popin doesn't close and the UI doesn't tell us that the user has been created.
[User Creation] Popin doesn't give any reponse after creation.
https://api.github.com/repos/Piwigo/Piwigo/issues/1767/comments
0
2022-10-25T08:01:56Z
2022-11-16T13:06:33Z
https://github.com/Piwigo/Piwigo/issues/1767
1,422,036,578
1,767
[ "Piwigo", "Piwigo" ]
Hello, i updated to 13.1.0 recently, but the photo view inside an album is not working anymore. Thrown error in GUI: ` Fatal error: Uncaught --> Smarty Compiler: Syntax error in template "file:/var/www/vhosts/xxxx/xxxx/themes/smartpocket/template/footer.tpl" on line 20 "document.cookie = 'screen_size='+jQuery(document).width()+'x'+jQuery(document).height()+';path={isset($COOKIE_PATH) ? $COOKIE_PATH : ''}';" - Unexpected " ? ", expected one of: "}" <-- thrown in /var/www/vhosts/xxxx/xxxxx/include/smarty/libs/sysplugins/smarty_internal_templatecompilerbase.php on line 20 ` Standard view works fine. Albums are still listed on mobile, but when opening an album, no photos are shown and the error is listed at the bottom of the page
Mobile album photo view in 13.1.0 not working anymore due to syntax error in footer.tpl in smartpocket theme (with PHP 7.x)
https://api.github.com/repos/Piwigo/Piwigo/issues/1766/comments
14
2022-10-23T09:17:04Z
2022-11-16T10:45:31Z
https://github.com/Piwigo/Piwigo/issues/1766
1,419,717,485
1,766
[ "Piwigo", "Piwigo" ]
I'm trying to download files, like mp4 videos but they're not working because piwigo only tries to use the direct link like: Preview is working fine, but by clicking this is tried to load: upload/2022/10/23/pwg_representative/20221023003559-e34adaf3.jpg 403 upload/2022/10/23/20221023003559-e34adaf3.mp4 403 Nginx (of course) logs the access restrictions: `2022/10/23 01:28:27 [error] 3875859#3875859: *1421 access forbidden by rule, client: , server: , request: "GET /upload/2022/10/23/pwg_representative/20221023003559-e34adaf3.jpg HTTP/2.0", host: "" 2022/10/23 01:28:31 [error] 3875859#3875859: *1421 access forbidden by rule, client: , server: , request: "GET /upload/2022/10/23/20221023003559-e34adaf3.mp4 HTTP/2.0", host: "" ` By opening the access to the upload folder on the webserver the whole authentication would be useless and everyone could retrieve the files without permissions. Edit: This is happening only on the mobile app -> in the webinterface I can download the file.
Non picture files like mp4 not working
https://api.github.com/repos/Piwigo/Piwigo/issues/1765/comments
0
2022-10-22T23:32:42Z
2022-10-22T23:46:53Z
https://github.com/Piwigo/Piwigo/issues/1765
1,419,552,748
1,765
[ "Piwigo", "Piwigo" ]
Environment | Value --- | --- Operating system: | Linux PHP: | 7.3.10 MySQL: | 5.5.5-10.0.38-MariaDB-0ubuntu0.16.04.1 Graphics Library: | ImageMagick 6.9.7-4 I use the Carrousel function from the Extended Description plugin on an Additional Pages landing page. ``` [slider album=10 random=false size=L speed=4 title=false effect=fade arrows=false elastic=false control=false] ``` After upgrading to piwigo version 13.0.0 the following error appears when loading the page: ``` Warning: math: illegal characters in include/smarty/libs/plugins/function.math.php on line 76 ``` And the images are not displayed correctly anymore
Bug in carrousel from Extended Description since upgrade to piwigo 13.0.0
https://api.github.com/repos/Piwigo/Piwigo/issues/1764/comments
2
2022-10-22T21:38:31Z
2022-10-22T22:25:47Z
https://github.com/Piwigo/Piwigo/issues/1764
1,419,520,169
1,764