status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,349 |
["main/webapp/modules/core/scripts/facets/list-facet.js", "main/webapp/modules/core/scripts/util/misc.js", "main/webapp/modules/core/scripts/views/data-table/cell-ui.js", "main/webapp/modules/core/styles/views/data-table-view.less"]
|
Make multi-line "edit cell dialog" larger if it contains more text and if user's screen resolution can handle it
|
When editing individual cells with quite a bit of text, I end up dragging the little 'enlargement corner' in the "edit cell" dialog all the time, which is not fun. I think, today, many user's screen resolution can totally deal with a slightly larger dialog window. Perhaps even one that flexibly adapts a bit to the length of text in it.
<img width="539" alt="image" src="https://user-images.githubusercontent.com/9881645/196239811-71405d75-5a03-4bd8-a3e0-3efd60dfd470.png">
versus
<img width="549" alt="image" src="https://user-images.githubusercontent.com/9881645/196239912-33477083-9b98-43a1-94cc-03529a34a126.png">
|
https://github.com/OpenRefine/OpenRefine/issues/5349
|
https://github.com/OpenRefine/OpenRefine/pull/5357
|
14c274a3209d369799155bdd8c098d15af682fc9
|
98e01e8df1b1db8082cf16950e6127af81709715
| 2022-10-17T17:11:57Z |
java
| 2022-10-20T07:52:22Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,346 |
["extensions/wikibase/module/langs/translation-en.json", "extensions/wikibase/module/scripts/schema-alignment-tab.html", "extensions/wikibase/module/scripts/schema-alignment.js", "extensions/wikibase/module/styles/schema-alignment.css"]
|
UI edits to schema selection and edits saving in Wikibase extension
|
This has been mentioned in previous PRs and issues, but starting a new issue to track all the final adjustments needed in more detail. This is a request to improve the following UI features:
<img width="1025" alt="Screenshot 2022-10-16 at 21 45 24" src="https://user-images.githubusercontent.com/25489750/196059745-f935c4d5-a547-4af1-b946-8851c431fa8e.png">
1. I think this text is not needed - it's too clunky in the layout; it's information experienced users know and don't need to see at all times; it's also something new users should learn from tutorials / documentation; new users (as shown during user testing) tend not to read small text anyway, and just click around until they find the solution to go forth, or just go and watch a tutorial;
2. Save schema should be called "Save schema progress".
3. Save schema progress / Discard changes should move below the main schema editing area (see wireframes).
4. This should probably just say "Select..."
5. "Save new" is potentially confusing if users just want to save and override an existing schema. Another idea was to keep the button to say only "Save", but I think this will make it potentially confusing next to the dropdown in case users decide they are just saving their selection choice. I propose we call this button "Save schema edits" and we move it to the right of the screen (see wireframes).
### Proposed solution
Proposed redesign:
<img width="1064" alt="Screenshot 2022-10-16 at 23 59 48" src="https://user-images.githubusercontent.com/25489750/196060312-3ab0d35c-76dc-44ac-aca2-a05112b969e7.png">
For more context see complete design wireframes accessible via this link: https://docs.google.com/document/d/1uWkrid1UJwM3FCak_fI4VUY2EUabVUUFk9z6OeWtzKs/edit?usp=sharing
### Alternatives considered
Several previous iterations can be seen in the wireframe versions in the link above. The naming of the "Save" button and the schema vs schema template was discussed in more detail in previous PRs, e.g. https://github.com/OpenRefine/OpenRefine/pull/5303
### Additional context
The need to adjust this was discussed during the final round of user testing for the Commons extension project carried out Sept / Oct 2022.
|
https://github.com/OpenRefine/OpenRefine/issues/5346
|
https://github.com/OpenRefine/OpenRefine/pull/5935
|
61f87212620c68a156e7e88dd58331078f7066d1
|
d5fffc02f3b6145f119115a0f67bdf4ec9ce9862
| 2022-10-16T22:02:30Z |
java
| 2023-06-30T09:28:13Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,338 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml", "extensions/jython/pom.xml", "extensions/phonetic/pom.xml", "extensions/wikidata/pom.xml", "main/pom.xml"]
|
Logging not working in unit tests
|
Logging appears to be broken for all the tests. They report variously (for main, Wikidata extension):
```
[INFO] Running TestSuite
SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
```
or (for Jython, database, GData, phonetic extensions)
```
[INFO] Running TestSuite
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
```
_Originally posted by @tfmorris in https://github.com/OpenRefine/OpenRefine/issues/5294#issuecomment-1278129770_
|
https://github.com/OpenRefine/OpenRefine/issues/5338
|
https://github.com/OpenRefine/OpenRefine/pull/5339
|
431b8ced91d2fba6fd0014bbbf336866d537e40f
|
cca62b5aad96489a8e5963a58278a4da49bf67c5
| 2022-10-13T21:27:24Z |
java
| 2022-10-14T06:56:21Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,337 |
["extensions/wikibase/module/langs/translation-en.json", "extensions/wikibase/src/org/openrefine/wikibase/editing/MediaFileUtils.java", "extensions/wikibase/src/org/openrefine/wikibase/qa/EditInspector.java", "extensions/wikibase/src/org/openrefine/wikibase/qa/scrutinizers/EditScrutinizer.java", "extensions/wikibase/src/org/openrefine/wikibase/qa/scrutinizers/FileNameScrutinizer.java", "extensions/wikibase/tests/src/org/openrefine/wikibase/editing/MediaFileUtilsTest.java", "extensions/wikibase/tests/src/org/openrefine/wikibase/qa/EditInspectorTest.java", "extensions/wikibase/tests/src/org/openrefine/wikibase/qa/scrutinizers/FileNameScrutinizerTest.java", "extensions/wikibase/tests/src/org/openrefine/wikibase/qa/scrutinizers/ScrutinizerTest.java"]
|
Provide error message when user tries to upload duplicate files
|
I am trying to upload duplicate files to Wikimedia Commons, and I am indeed not succeeding in doing so, which is great. I am trying to upload files that already exist on Commons, with the exact same file name, from this project: (only the two first, flagged rows, using the filename2 column)
[Jan-Geerling-photographs-Rotterdam-1503.openrefine (2).tar.gz](https://github.com/OpenRefine/OpenRefine/files/9778264/Jan-Geerling-photographs-Rotterdam-1503.openrefine.2.tar.gz)
The upload process is stuck at 0% but the user doesn't get any feedback or error messages, and I think it would be good to have these; otherwise the user is left in the dark about what they may be doing wrong.
|
https://github.com/OpenRefine/OpenRefine/issues/5337
|
https://github.com/OpenRefine/OpenRefine/pull/5344
|
b2b4ac0db507ec8105519b8cf70372ec9d227cb3
|
5e1611c82677e133773e6f9c8522a2cf8f5ee475
| 2022-10-13T15:31:36Z |
java
| 2022-10-28T08:45:38Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,333 |
["extensions/wikidata/module/scripts/schema-alignment.js", "main/webapp/modules/core/scripts/project.js"]
|
Schema editor (Wikimedia Commons) doesn't scroll down
|
Testing various brand new Commons features just created by @wetneb in #5322 and others. Most things seem to work super swimmingly. However, while constructing a schema in the schema editor, the schema refuses to scroll down.
Video showing the behavior:
https://user-images.githubusercontent.com/9881645/195176893-ed26fb2c-8c78-48da-9582-face5042f037.mov
Happens with this project: [Jan-Geerling-photographs-Rotterdam-1503.openrefine (1).tar.gz](https://github.com/OpenRefine/OpenRefine/files/9759034/Jan-Geerling-photographs-Rotterdam-1503.openrefine.1.tar.gz)
I'm testing with Version 3.7-SNAPSHOT [5f3fa43] on MacOS 12.6 using Chrome Version 105.0.5195.125 (Official Build) (arm64)
|
https://github.com/OpenRefine/OpenRefine/issues/5333
|
https://github.com/OpenRefine/OpenRefine/pull/5334
|
a8f6d442a2fffb7e38b04c3796ddd0016ce5ae66
|
431b8ced91d2fba6fd0014bbbf336866d537e40f
| 2022-10-11T19:04:14Z |
java
| 2022-10-13T21:05:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,306 |
["extensions/wikidata/module/styles/dialogs/wikibase-dialog.less"]
|
Proportions of Wikibase logos are not respected in the Wikibase management dialog
|
In this dialog, the logos that are not natively square are stretched, not preserving their aspect ratio:
Not providing more details because I am intending to tackle this issue directly.
|
https://github.com/OpenRefine/OpenRefine/issues/5306
|
https://github.com/OpenRefine/OpenRefine/pull/5307
|
0ec9a5f9f6c82480ba95f9d1914dbfeb8c0e0bb1
|
d5c599a31259b167505a5116173dad71a60e11b6
| 2022-10-01T17:34:37Z |
java
| 2022-10-04T20:32:44Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,298 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/module/scripts/dialogs/perform-edits-dialog.js", "extensions/wikidata/src/org/openrefine/wikidata/commands/PreviewWikibaseSchemaCommand.java", "extensions/wikidata/src/org/openrefine/wikidata/functions/WikibaseIssuesFunction.java", "extensions/wikidata/src/org/openrefine/wikidata/qa/EditInspector.java", "extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/EditScrutinizer.java", "extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/NewEntityScrutinizer.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/qa/EditInspectorTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/qa/scrutinizers/NewEntityScrutinizerTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/qa/scrutinizers/ScrutinizerTest.java"]
|
Media file upload: provide clear error report when user has mistakes in local file paths
|
I've encountered a case where an OpenRefine user tried to upload media files to Wikimedia Commons. The upload failed because the (MacOS) file paths in the user's dataset didn't start with a `/` (very subtle!)
The user didn't get any error messages and it took a bit of searching to discover this issue. Maybe this will occur more frequently if users start from datasets with pre-entered local file paths.
### Proposed solution
Perform a general/rough check if the file path is formatted correctly and provide the user with a clear error message if there are obvious mistakes in there (e.g. missing drive letter in Windows paths, missing starting `/` for MacOS paths, wrong directions of (back)slashes, missing file extensions...?)
Related / similar: https://github.com/OpenRefine/OpenRefine/issues/5192
|
https://github.com/OpenRefine/OpenRefine/issues/5298
|
https://github.com/OpenRefine/OpenRefine/pull/5317
|
a0a5b847d0576063e2947fc9b8ab13accc55bf7d
|
a2de7095a21ee7bb51aa02902259ca97a9ca8ea4
| 2022-09-29T16:08:11Z |
java
| 2022-10-13T16:11:55Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,285 |
["main/webapp/modules/core/scripts/reconciliation/standard-service-panel.html", "main/webapp/modules/core/styles/reconciliation/recon-dialog.less"]
|
Dysfunctional reconciliation dialog window in OpenRefine 3.7 snapshots (since around Sep 20, 2022)
|
I tried reconciling against Wikidata in a large-ish dataset using our 3.7 snapshot release, and the reconciliation dialog appears wonky at the bottom. The `Start reconciling` and `Cancel` buttons are dysfunctional (nothing happens when clicking them).
<img width="906" alt="image" src="https://user-images.githubusercontent.com/9881645/192108615-8fce38f3-1257-41a6-b822-b3b68aa27658.png">
### To Reproduce
The bad things happened with this dataset: [homosaurus-v3-jsonld.openrefine.tar.gz](https://github.com/OpenRefine/OpenRefine/files/9639142/homosaurus-v3-jsonld.openrefine.tar.gz)
I tried reconciling the `http://www.w3.org/2004/02/skos/core#prefLabel` column
In Version 3.7-SNAPSHOT [549f83b] and the September 21 snapshot release.
I loaded this same dataset in OpenRefine 3.6.1 on Wikimedia PAWS, where the window does behave as expected, so it seems like the issue was recently introduced.
### Versions<!-- (please complete the following information)-->
- Operating System: MacOS 12.6
- Browser Version: Chrome Version 105.0.5195.125 (Official Build) (arm64)
- JRE or JDK Version: n/a?
- OpenRefine: Version 3.7-SNAPSHOT [549f83b] and the September 21 snapshot release
|
https://github.com/OpenRefine/OpenRefine/issues/5285
|
https://github.com/OpenRefine/OpenRefine/pull/5286
|
005db2ca88005899fa154a5146ed32d3641dbaa6
|
28307f2d7a3255e597dd70738b72a78983caed10
| 2022-09-24T16:34:22Z |
java
| 2022-09-26T09:10:04Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,283 |
["main/webapp/modules/core/scripts/dialogs/clustering-dialog.html", "main/webapp/modules/core/scripts/dialogs/clustering-dialog.js", "main/webapp/modules/core/styles/dialogs/clustering-dialog.less", "main/webapp/modules/core/styles/util/dialog.less"]
|
Cluster and edit dialog should prevent selecting another algorithm while processing a different one
|
In the 'Cluster and edit' dialog, when a user selects another algorithm to run while one is still processing, OpenRefine will run both algorithms at once and the results of the algorithm that finishes last will be displayed over the results of the first as shown in the recording below.
Because it is difficult to tell which results go to each of the selected algorithms this problem leads to confusion and delay. Moreover, OpenRefine is using more memory so the algorithms will take longer to process.
### To Reproduce
Steps to reproduce the behavior:
1. Go to 'Edit cells' > 'Cluster and edit...'
2. Select a 'Keying function' that has results.
3. Switch to a function that has results that takes enough time.
4. Switch back to the original function while the previous is running.
5. Observe that the results of the function that finished first is replaced by the one that finished last.
### Current Results
### Expected Behavior
The dialog should prevent switching to another algorithm while one is running by blocking input with an overlay, or adding a cancel button if the operation is cancelable.
|
https://github.com/OpenRefine/OpenRefine/issues/5283
|
https://github.com/OpenRefine/OpenRefine/pull/5369
|
848db0ebdccba6116c5f14c1bad0b567ea5587a1
|
bc8140d5e024146f63e9aebd6d40be2d3a87e834
| 2022-09-23T04:55:21Z |
java
| 2022-10-24T21:00:06Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,281 |
["extensions/wikibase/module/langs/translation-en.json", "extensions/wikibase/module/scripts/schema-alignment.js"]
|
Change the naming of the "subject" field for MediaInfo entities
|
The placeholder for the subject field of all entities in the Wikibase schema reads "type entity or drag reconciled column".
This is a bit abstract and could be better adapted depending on the entity type.
### Proposed solution
Change this placeholder to:
* type item or drag reconciled column (for items)
* type file name or drag reconciled column (for mediainfo entities)
### Alternatives considered
Potentially it could be nice to have a label (not just a placeholder) for this field, especially because we refer to it from the issues (if it is left empty) as the "subject field", but users might not understand that as it is not mentioned in the UI anywhere.
### Additional context
Suggested by @lozanaross. Part of the Structured Data on Commons project.
|
https://github.com/OpenRefine/OpenRefine/issues/5281
|
https://github.com/OpenRefine/OpenRefine/pull/5345
|
5e1611c82677e133773e6f9c8522a2cf8f5ee475
|
92966cc2439524f6d6644efc4f69002a2b7a9f53
| 2022-09-21T19:25:40Z |
java
| 2022-10-28T08:46:15Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,277 |
["main/tests/server/src/com/google/refine/expr/functions/ToStringTests.java"]
|
ToString test fails when run in a French locale
|
Running the server tests (with `mvn test`) with a `fr_FR.UTF-8` locale currently fails with a
```
ToStringTests.testToString:50 expected [100.0] but found [100,0]
```
This test should pass regardless of the system locale.
|
https://github.com/OpenRefine/OpenRefine/issues/5277
|
https://github.com/OpenRefine/OpenRefine/pull/5326
|
f1f683b73d25140f6205005a421cef6205bd1e63
|
6d632e0f5b61fb7a64bffe235fd3a89aabb2db1e
| 2022-09-21T10:49:42Z |
java
| 2022-10-09T06:37:44Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,240 |
["refine"]
|
"Error: We need either 'curl' or 'wget' present" error is misleading
|
refine checks for `curl` or `wget` using `which`. Such test fails if `which` is not installed.
https://github.com/OpenRefine/OpenRefine/blob/abab670399924daf2222b366e078b758f6192d80/refine#L121-L122
|
https://github.com/OpenRefine/OpenRefine/issues/5240
|
https://github.com/OpenRefine/OpenRefine/pull/5332
|
7db6ec34590c57811dbd8a4c80976ddd122c5793
|
ea70840d3cd83bd96128756ca149d6db8b54fcd0
| 2022-09-08T14:31:19Z |
java
| 2022-10-17T18:51:09Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,229 |
["main/src/com/google/refine/operations/cell/TransposeColumnsIntoRowsOperation.java", "main/tests/server/src/com/google/refine/operations/cell/TransposeColumnsIntoRowsOperationTest.java"]
|
Transpose cells across columns into Rows BUGS with blank cells?
|
Hi. Today I used a menu called 'Transpose cells across columns into Rows'. I checked on 'Ignore blank cells' but it failed. I think that the mistake is on the label. It works with null cells but not with empty cells. So It can't work with blank cells whis is empty OR null. Can you verify it? Thanks a lot, Fabio
|
https://github.com/OpenRefine/OpenRefine/issues/5229
|
https://github.com/OpenRefine/OpenRefine/pull/5862
|
7bcc259104794b44c1afd2198038599cf2cb0c3a
|
9bc4104a3b84693b71c2e536e0a3819ad5469f8d
| 2022-09-02T09:59:21Z |
java
| 2023-06-02T15:40:26Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,225 |
["pom.xml"]
|
Logging broken by SLF4J update
|
Logging in the OpenRefine backend no longer works since SLF4J was updated:
```
SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#noProviders for further details.
SLF4J: Class path contains SLF4J bindings targeting slf4j-api versions prior to 1.8.
SLF4J: Ignoring binding found at [jar:file:/home/antonin/ORmaster/server/target/lib/log4j-slf4j-impl-2.18.0.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#ignoredBindings for an explanation.
Gtk-Message: 17:38:21.693: Failed to load module "canberra-gtk-module"
17:38:24.095 [ velocity] ResourceManager : unable to find resource 'macros.vm' in any resource loader. (0ms)
17:38:24.098 [ velocity] Velocimacro : Velocimacro : Error using VM library : macros.vm (3ms)
```
Reproducible on Linux and MacOS with the latest snapshot releases as well as running locally from source.
Not providing more details because I intend to work on this directly.
|
https://github.com/OpenRefine/OpenRefine/issues/5225
|
https://github.com/OpenRefine/OpenRefine/pull/5226
|
4f5c8b3789cf1320ff4e5d24ee02160e4896cd74
|
df74a30c4fd334bb970356de2d1449db38ab0073
| 2022-09-01T15:46:05Z |
java
| 2022-09-04T16:09:09Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,220 |
["extensions/wikidata/module/MOD-INF/controller.js", "extensions/wikidata/module/scripts/commons-manifest-v2.0.js", "extensions/wikidata/module/scripts/wikibase-manager.js"]
|
Ship Commons manifest with OpenRefine by default
|
I notice that it takes quite a bit of explanation/documentation to help people install the [Wikimedia Commons manifest](https://github.com/OpenRefine/wikibase-manifests/blob/master/wikimedia-commons-manifest.json) in OpenRefine if they want to get started editing or uploading there. Could we perhaps have this manifest pre-installed for every OpenRefine user, just like Wikidata's? Seeing that Wikimedia Commons is a Wikimedia wiki, i.e. a public one that anyone can edit (and re-use files from).
### Alternatives considered
Also totally OK to not do this. Or, alternatively, have the Wikimedia Commons manifest shipped in the Wikimedia Commons extension (but not in OpenRefine itself).
|
https://github.com/OpenRefine/OpenRefine/issues/5220
|
https://github.com/OpenRefine/OpenRefine/pull/5323
|
9948f8d08675f7e011c2c19a619ae3e440687d07
|
93f3084db0acd95acb6a48ff33aca195dd90d0c1
| 2022-08-30T15:15:41Z |
java
| 2022-10-17T18:47:40Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,218 |
["main/src/com/google/refine/importing/ImportingJob.java"]
|
Memory usage display issues when creating project
|
I was creating a project from a 35MB CSV file and I noticed that the progress bar showing the memory usage had some issues:
- The max memory showed as 4294MB but my max memory was set to 4096MB in refine.ini
- The used memory stayed constant at 1728MB which seemed off. I checked ImportingJob.java and found that the used memory was being set as the total JVM memory when it should be total - free memory.
|
https://github.com/OpenRefine/OpenRefine/issues/5218
|
https://github.com/OpenRefine/OpenRefine/pull/5222
|
051b25bf7d05fb11c8b5a3ee81f88ff1cedaacf1
|
6a7046323181dd0094058cc64d1171c166488cf4
| 2022-08-29T12:35:11Z |
java
| 2022-09-02T06:52:40Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,214 |
["extensions/wikidata/src/org/openrefine/wikidata/updates/MediaInfoEdit.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/updates/MediaInfoEditTest.java"]
|
File upload to Commons fails with error message 'MediaWiki error while fetching documents to edit [no-such-entity]: Could not find an entity with the ID "Q-...'
|
I was doing a fresh small Wikimedia Commons test upload (5 files), and the upload fully fails (after schema building and logging in, the yellow progress box remains stuck at 0%).
Log says the following:
```
16:07:27.482 [ ProjectManager] Saving some modified projects ... (102569ms)
16:07:27.716 [ project_utilities] Saved project '2151753902839' (234ms)
16:09:35.638 [ refine] GET /command/wikidata/login (127922ms)
16:09:35.655 [ refine] GET /command/core/get-csrf-token (17ms)
16:09:35.671 [ refine] POST /command/wikidata/preview-wikibase-schema (16ms)
16:09:40.911 [ refine] GET /command/core/get-csrf-token (5240ms)
16:09:40.921 [ refine] POST /command/wikidata/perform-wikibase-edits (10ms)
16:09:40.939 [..mWikibaseEditsOperation] Performing edits (18ms)
16:09:40.939 [..ting.EditBatchProcessor] Requesting documents (0ms)
16:09:41.328 [..ting.EditBatchProcessor] MediaWiki error while fetching documents to edit [no-such-entity]: Could not find an entity with the ID "Q-452493955621971882". (389ms)
16:09:41.329 [..ting.EditBatchProcessor] Retrying in 10000 ms (1ms)
16:09:51.517 [..ting.EditBatchProcessor] MediaWiki error while fetching documents to edit [no-such-entity]: Could not find an entity with the ID "Q-452493955621971882". (10188ms)
16:09:51.517 [..ting.EditBatchProcessor] Retrying in 20000 ms (0ms)
16:10:11.696 [..ting.EditBatchProcessor] MediaWiki error while fetching documents to edit [no-such-entity]: Could not find an entity with the ID "Q-452493955621971882". (20179ms)
16:10:11.696 [..ting.EditBatchProcessor] Retrying in 40000 ms (0ms)
16:10:51.877 [..ting.EditBatchProcessor] MediaWiki error while fetching documents to edit [no-such-entity]: Could not find an entity with the ID "Q-452493955621971882". (40181ms)
16:10:51.878 [..ting.EditBatchProcessor] Retrying in 80000 ms (1ms)
```
### Dataset
It's this project:
[mini-test-upload-Commons-aug-2022.openrefine.tar.gz](https://github.com/OpenRefine/OpenRefine/files/9433885/mini-test-upload-Commons-aug-2022.openrefine.tar.gz)
and you can [download the files themselves here](https://drive.google.com/drive/folders/1eFMHxBoqh1gEymKktfjvkXNO0sRH-Ytr?usp=sharing) (note that I'm the creator and the photos haven't been published anywhere else yet, so no evidence that you have the right to upload them with a free license; so after a test upload it's best to ask for deletion)
### Current Results
Upload stays at 0%
### Expected Behavior
Upload goes to 100%
### Versions<!-- (please complete the following information)-->
- Operating System: MacOS 12.5.1
- Browser Version: Version 104.0.5112.101 (Official Build) (arm64)
- JRE or JDK Version: n/a?
- OpenRefine: Version 3.7-SNAPSHOT [4c7e668] and Version 3.7-SNAPSHOT [42eb681]
### Additional context
I was doing this test because two individual Wikimedians reported to me that their upload got stuck after 1 file (i.e. they can only upload one file at the time).
|
https://github.com/OpenRefine/OpenRefine/issues/5214
|
https://github.com/OpenRefine/OpenRefine/pull/5228
|
3a8ea45d47d76dd10f9bef3569f180901e3a003d
|
4f5c8b3789cf1320ff4e5d24ee02160e4896cd74
| 2022-08-26T14:20:19Z |
java
| 2022-09-04T16:07:51Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,210 |
["main/webapp/modules/core/scripts/dialogs/clustering-dialog.html", "main/webapp/modules/core/scripts/dialogs/clustering-dialog.js", "main/webapp/modules/core/styles/dialogs/clustering-dialog.less"]
|
Cluster and edit display issues
|
When performing cluster and edit on a big enough dataset, some items are pushed out of the dialog and squished.
### Current Results
### Expected Behavior
The contents should fit in the dialog and be laid out properly.
|
https://github.com/OpenRefine/OpenRefine/issues/5210
|
https://github.com/OpenRefine/OpenRefine/pull/5213
|
46daa21d02967c3fab7402f83b20f1f935439060
|
8d4512786ae43f329f5b1cfaf2a9f925968f5d52
| 2022-08-25T03:59:24Z |
java
| 2022-08-29T09:11:16Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,205 |
[".github/workflows/snapshot_release.yml", "packaging/dmg_settings.py", "packaging/pom.xml"]
|
Provide Applications shortcut in MacOS dmg + potentially add a nice background [$250 bounty]
|
Our MacOS download provides a .dmg that, upon opening, only contains the OpenRefine application, without any other frills. It works, but it's barebones :-)
I have just downloaded quite a bit of software, and I notice that many applications make their .dmg a bit fancier these days. They usually include a shortcut to the user's Applications folder, sometimes with a background image with some context/help that makes it easier and more obvious to the user that they can just drag the application there in order to install the software.
Some applications also have backgrounds in that .dmg window, which makes everything look just a bit more polished, professional and friendly.
LibreOffice: In my opinion: good to have that arrow + the project logo and a visual. The arrow looks amateurish though. Not sure if the licenses and readmes folders make any sense - I don't think anyone will ever click/open these?
<img width="662" alt="image" src="https://user-images.githubusercontent.com/9881645/185951265-bc3794d2-4f57-4859-ac0b-1ac9caed7830.png">
Zotero: Simple but good, maybe a bit amateurish because of its simplicity.
<img width="479" alt="image (1)" src="https://user-images.githubusercontent.com/9881645/185951522-e4483a35-aaa4-4941-a5f0-d46cab02e0a1.png">
VLC: Something in between. Balanced and subtle. Not bad IMO!
### Proposed solution
Can we do this too?
* Highest priority IMO: the shortcut to the Applications folder
* Nice to have but not necessary: a background with more context. I'd like that background to be nice and tasteful ;-)
* We can talk about: what else makes sense to include in the window without making it too bloated? Perhaps we can even include something like a donation link? ;-) (not sure if that would be possible)
### Alternatives considered
We can also totally leave it like it is - it works. But I think it's a nice touch in general.
### Funding available
The OpenRefine project has funding available to work on this. Do you know someone who would be able to get this fixed? Send them our way!
https://openrefine.org/blog/2022/09/30/windows-macos-packaging.html
|
https://github.com/OpenRefine/OpenRefine/issues/5205
|
https://github.com/OpenRefine/OpenRefine/pull/5509
|
a6f9095c7149ea1ba2ae4d39803f3f6cc7e2ec25
|
5ba697a94e74557bdba6f1b8619631a93958d53f
| 2022-08-22T14:58:14Z |
java
| 2022-12-08T11:03:38Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,204 |
["docs/package.json", "docs/yarn.lock"]
|
Embed donation box (or prompt) in new release pages
|
I'd like to embed donation forms in various places in OpenRefine's web presence - mainly near the places where our users usually download the software.
Donations will always be optional - but the project can really use them to pay for day-to-day maintenance work (e.g. packaging) which is not easily funded through grants. Quite a lot of open source projects show donation boxes / forms right next to, or right after, downloading the software, and I'd like to give that a try here too.
I was looking whether it'd be possible to embed such a donation box into our releases pages, like [this one](https://github.com/OpenRefine/OpenRefine/releases/tag/3.6.0), but I couldn't really figure out how to do it. I forked the OpenRefine repo but then could not find where to edit/update this page. Could someone look into this?
Ideally, for maximum visibility, the donation box would be under the Download header, right below the four download links for the different OSes.
I have an embed code for the donation box. It's an iframe html code, provided through Donorbox. Our fiscal sponsor, Code for Science & Society, also [embedded it here](https://codeforscience.org/donate/openrefine/) - but that page is not very visible. I'm not sure if it's safe to post the embed code publicly here, but please ping me and I can give it to anyone who feels like tackling this.
### Alternatives considered
I think it would be great if we actually dedicate a bit more attention and planning, and perhaps even some A/B testing, to arrive at a donation 'path' online which is nice to our users and also encourages people to actually donate. I saw that some open source projects send the downloader to a new page with dedicated donation options right after they clicked a download link. I think that's even more effective: in that case, the user first downloads, and then (while the software is downloading) can use the waiting time to donate. If we just show a donation box below the download links, it may be missed, and/or the user may forget about the possibility because they immediately jump to the downloaded software.
|
https://github.com/OpenRefine/OpenRefine/issues/5204
|
https://github.com/OpenRefine/OpenRefine/pull/4075
|
bba2e6e0157fbf5fdb9a33084440f68a2f97c9b2
|
4cde23ed84d00a2aa8229e8e86d5f0512fa49cb4
| 2022-08-22T14:39:49Z |
java
| 2021-07-29T18:11:34Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,192 |
["extensions/wikibase/module/langs/translation-en.json", "extensions/wikibase/src/org/openrefine/wikibase/editing/MediaFileUtils.java", "extensions/wikibase/src/org/openrefine/wikibase/qa/EditInspector.java", "extensions/wikibase/src/org/openrefine/wikibase/qa/scrutinizers/EditScrutinizer.java", "extensions/wikibase/src/org/openrefine/wikibase/qa/scrutinizers/FileNameScrutinizer.java", "extensions/wikibase/tests/src/org/openrefine/wikibase/editing/MediaFileUtilsTest.java", "extensions/wikibase/tests/src/org/openrefine/wikibase/qa/EditInspectorTest.java", "extensions/wikibase/tests/src/org/openrefine/wikibase/qa/scrutinizers/FileNameScrutinizerTest.java", "extensions/wikibase/tests/src/org/openrefine/wikibase/qa/scrutinizers/ScrutinizerTest.java"]
|
Commons/Wikibase file upload: provide error report / warning when user tries to upload file names without extension
|
In my own cluelessness, I have already attempted to upload files with file names that didn't yet have a file extension (.jpg / .png etc). I have just noticed that other people also fall into this trap - it's an obvious omission to make, if you are focused on just getting the file name right. OpenRefine then refuses to do the upload and will throw a vague error.
### Proposed solution
Maybe provide an error message in the Issues tab during schema building, when it is detected that the file column / field does not contain the required .ogg .tiff thingies ? Other suggestions are welcome too.
### Alternatives considered
Alternatively, in the category 'pampering the user more and maybe too much', I could also imagine that 'something smart' happens where OpenRefine derives the file extension from the file path column, as that column will certainly contain one. Maybe it can then fill it in for the user during upload. Not sure if this idea makes sense.
|
https://github.com/OpenRefine/OpenRefine/issues/5192
|
https://github.com/OpenRefine/OpenRefine/pull/5344
|
b2b4ac0db507ec8105519b8cf70372ec9d227cb3
|
5e1611c82677e133773e6f9c8522a2cf8f5ee475
| 2022-08-18T11:58:16Z |
java
| 2022-10-28T08:45:38Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,190 |
["extensions/wikidata/module/scripts/wikibase-suggest.js"]
|
Suggestion of properties and items in the Wikibase schema builder sometimes totally refuses to load any suggestions (or only wrong ones)
|
Sometimes, item and property suggestion in the Wikibase extension's schema builder simply refuses to work (refusing to provide any suggestions at all, or only wrong suggestions), making schema building quite painful.
This issue is difficult to reproduce - I have seen the behavior quite often but haven't discovered a pattern in it. I was recently creating a screen recording while it happened badly and [you can see it happening in this video](https://drive.google.com/file/d/1g0g2SsbVKAMJk70vawf-swkkBtFLiz2N/view?usp=sharing).
Reproducing my process (but I have the idea it doesn't only happen under these circumstances):
* I added what I thought was a wrong statement in the schema builder, deleted the statement, and then tried to recreate it. I wanted the same property but another value. Property (Source of file) simply refuses to load.
* Then you see me fiddling a bit, working on other statements, trying if moving out of the schema builder and back fixes it (it does not)
* Finally I decide to exit my project and go back to OpenRefine's start screen and re-open the project. Then I can add the statement just fine and the suggester does its job.
Unfortunately I didn't have the Terminal running, so I don't have a log of what happened.
This issue has been reported on Wikimedia's OpenRefine Telegram group as well.
### Expected Behavior
Properties and items display correctly and promptly.
### Versions<!-- (please complete the following information)-->
- Operating System: MacOS 12.5
- Browser Version: Something probably right before Chrome 104.0.5112.79 (Official Build) (x86_64)
- JRE or JDK Version: n/a?
- OpenRefine: 3.7 snapshot release of 13 August 2022
|
https://github.com/OpenRefine/OpenRefine/issues/5190
|
https://github.com/OpenRefine/OpenRefine/pull/5328
|
b47215737e452a39ccb86cc842d544419873a6c2
|
9948f8d08675f7e011c2c19a619ae3e440687d07
| 2022-08-16T17:37:14Z |
java
| 2022-10-15T13:41:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,181 |
["extensions/wikibase/module/langs/translation-en.json", "extensions/wikibase/src/org/openrefine/wikibase/editing/MediaFileUtils.java", "extensions/wikibase/src/org/openrefine/wikibase/qa/EditInspector.java", "extensions/wikibase/src/org/openrefine/wikibase/qa/scrutinizers/EditScrutinizer.java", "extensions/wikibase/src/org/openrefine/wikibase/qa/scrutinizers/FileNameScrutinizer.java", "extensions/wikibase/tests/src/org/openrefine/wikibase/editing/MediaFileUtilsTest.java", "extensions/wikibase/tests/src/org/openrefine/wikibase/qa/EditInspectorTest.java", "extensions/wikibase/tests/src/org/openrefine/wikibase/qa/scrutinizers/FileNameScrutinizerTest.java", "extensions/wikibase/tests/src/org/openrefine/wikibase/qa/scrutinizers/ScrutinizerTest.java"]
|
Check for invalid characters in filename
|
Per https://www.mediawiki.org/wiki/Manual:$wgIllegalFileChars the colon (:) is a forbidden character in the filename.
Current behaviour: The colon (:) is silently replaced by a dash (-) during the upload process.
Problem with this behaviour: In case of a break of uploading a batch is is necessary to reconsile the filename again Wikimedia Commons to exclude already uploaded files. Due to the silent replacement such files are not found.
(edit) Another check should be done against invalid title characters like "/" per https://www.mediawiki.org/wiki/Manual:$wgLegalTitleChars
Suggestion: Show a warning that some filenames contain an invalid title or file name character.
|
https://github.com/OpenRefine/OpenRefine/issues/5181
|
https://github.com/OpenRefine/OpenRefine/pull/5344
|
b2b4ac0db507ec8105519b8cf70372ec9d227cb3
|
5e1611c82677e133773e6f9c8522a2cf8f5ee475
| 2022-08-13T15:43:57Z |
java
| 2022-10-28T08:45:38Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,177 |
["extensions/wikidata/module/scripts/schema-alignment.js", "extensions/wikidata/module/scripts/wikibase-suggest.js"]
|
Requests to Googleapis.com made in the Wikibase schema tab
|
Whenever we add properties in a schema, some calls to `googleapis.com` are made, and they result in a 404 error. Those calls are not necessary and should therefore not be made.
Furthermore, when adding a property, we make an HTTP call to fetch its datatype, and that call is made using JSONP, which is insecure. We should rather use CORS instead.
Not giving more details because I intend to tackle this directly.
|
https://github.com/OpenRefine/OpenRefine/issues/5177
|
https://github.com/OpenRefine/OpenRefine/pull/5178
|
e6847715a7ef67ef72e04ffd2ddc08338546d313
|
b3271ddfef11509eb5f7a5d8c943573a1b0563c1
| 2022-08-13T11:10:36Z |
java
| 2022-08-18T06:27:57Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,173 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/views/data-table/add-column-by-fetching-urls-dialog.html", "main/webapp/modules/core/scripts/views/data-table/menu-edit-column.js"]
|
Is the 5000ms default delay for the fetch URL operation too high?
|
I had feedback from a user who initially did not notice the <s>1000 ms</s> 5000 ms delay in the "Add column by fetching URLs" operation, and had to wait a long time for the operation to complete.
### Proposed solution
There is a case for saying that <s>1000 ms</s>5000 ms is perhaps a bit too high for a default value. It makes sense to have a relatively generous wait by default, so that users who are not aware of the problems caused by sending too many requests at a time do not accidentally hammer services.
### Alternatives considered
Add some contextual help to highlight this field (which is perhaps not so visible). This could be an occasion to educate users about responsible crawling, perhaps?
### Additional context
Perhaps this is less of an issue when we are able to show partial results for long-running operations (so that users do not have to wait for the completion of the operation to keep working on the project).
|
https://github.com/OpenRefine/OpenRefine/issues/5173
|
https://github.com/OpenRefine/OpenRefine/pull/5188
|
9981408dc706438beb8c4dcfe04284c431d85432
|
0664b1cd7253bac6234177e165e5d81ba1ef7a18
| 2022-08-12T16:07:11Z |
java
| 2022-08-17T06:16:28Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,164 |
["docs/package.json", "docs/yarn.lock"]
|
Add import options to operational history
|
We are currently working on [ontorefine-cli](https://github.com/Ontotext-AD/ontorefine-cli), a command-line interface to [ontotext-refine](https://platform.ontotext.com/ontorefine/index.html), itself a fork of OpenRefine with added functionalities to produce RDF.
The main use-case of the CLI is to be able to repeat and automate a end-to-end workflow. The story we want to tell is that of a user iteratively coming up with a conversion "recipe" using the UI and then applying this on more data with the same characteristics.
While we can easily extract the list of operations from the UNDO/REDO tab in OpenRefine, access to the import options is a little bit more tricky. They are available in the "Project metadata" dialog, which is available when selecting "about" from the list of projects. For our use case, these options are required because without them, we can not assure that the raw input data is processed by the CLI in exactly the same way as the project in the UI. This is even more important for XML or JSON inputs, for which the import options contain flattening instructions.
### Proposed solution
Our proposition is that the import options become available in the operations history json array, generated from the undo/redo tab with proper values for "op:", such as "import/csv" or "import/xml".
These entries should be ignored when working on a project in the UI, but will be applied by the CLI when transforming new data with the same structure.
### Alternatives considered
Passing the import options as a separate file to the CLI, which requires some tedious explanations for the users on how to find them, copy and paste them into a file.
|
https://github.com/OpenRefine/OpenRefine/issues/5164
|
https://github.com/OpenRefine/OpenRefine/pull/4075
|
bba2e6e0157fbf5fdb9a33084440f68a2f97c9b2
|
4cde23ed84d00a2aa8229e8e86d5f0512fa49cb4
| 2022-08-09T12:30:55Z |
java
| 2021-07-29T18:11:34Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,162 |
["extensions/wikidata/src/org/openrefine/wikidata/updates/ItemEdit.java", "extensions/wikidata/src/org/openrefine/wikidata/updates/LabeledStatementEntityEdit.java", "extensions/wikidata/src/org/openrefine/wikidata/updates/MediaInfoEdit.java", "extensions/wikidata/src/org/openrefine/wikidata/updates/StatementEdit.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/updates/ItemEditTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/updates/StatementEditTest.java"]
|
OpenRefine hangs when editing a redirected Wikibase item
|
Editing redirected items hangs the editing process.
### To Reproduce
Steps to reproduce the behavior:
1. First, create a project with Wikidata item `Q112112347`
2. Create a schema to make an edit on that item
3. Upload the edits
### Current Results
```
12:29:35.699 [ refine] POST /command/wikidata/perform-wikibase-edits (17ms)
12:29:35.735 [..mWikibaseEditsOperation] Performing edits (36ms)
12:29:35.737 [..ting.EditBatchProcessor] Requesting documents (2ms)
12:29:36.706 [..ting.EditBatchProcessor] MediaWiki error while editing [nosuchrevid]: Revision with ID not found. (969ms)
```
### Expected Behavior
The edit happens directly on the target of the redirection without any action needed from the user.
### Versions<!-- (please complete the following information)-->
- OpenRefine: 3.7 snapshot
|
https://github.com/OpenRefine/OpenRefine/issues/5162
|
https://github.com/OpenRefine/OpenRefine/pull/5163
|
0313e27324bbc945614e89511dc69ff12f2834dc
|
05fe3d267ed0b372a9cff416615cda1edc8fd7a4
| 2022-08-09T11:52:31Z |
java
| 2022-08-11T19:32:53Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,160 |
["packaging/pom.xml"]
|
OpenRefine 3.6 will not launch on Mac when installed for all the users of the machine (root:wheel)
|
In chatting with the devs on Gitter, it seems like this needs to be baked into the build process:
sudo chmod +r /Applications/OpenRefine.app/Contents/Resources/webapp/WEB-INF/*
otherwise, if the application is owned by "root:wheel" -- which is how Munki would deploy it for those orgs that use that -- the application will not launch.
|
https://github.com/OpenRefine/OpenRefine/issues/5160
|
https://github.com/OpenRefine/OpenRefine/pull/5201
|
4c7e66805d03d2eed1ef71b670a8d14c28a671e0
|
2027cc2669c497345a2b75c73d713520d9997807
| 2022-08-08T17:05:15Z |
java
| 2022-08-22T15:16:32Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,155 |
["extensions/wikidata/module/langs/translation-en.json"]
|
Improve error message for invalid entity ids in Wikibase extension
|
This warning is not very user-friendly:
Not describing this issue more because I want to work on it directly.
|
https://github.com/OpenRefine/OpenRefine/issues/5155
|
https://github.com/OpenRefine/OpenRefine/pull/5156
|
ed2145963af0118226868c5006bf59e026b338fe
|
aec892dd76aad0430d4a8f37658ab4d55aeb3277
| 2022-08-07T09:28:10Z |
java
| 2022-08-12T21:18:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,154 |
["main/tests/cypress/cypress/e2e/project/grid/misc/proper-display.cy.js", "main/tests/cypress/cypress/support/commands.js", "main/webapp/modules/core/MOD-INF/controller.js", "main/webapp/modules/core/scripts/views/data-table/cell-renderers/error-renderer.js", "main/webapp/modules/core/scripts/views/data-table/cell-renderers/null-renderer.js", "main/webapp/modules/core/scripts/views/data-table/cell-renderers/recon-renderer.js", "main/webapp/modules/core/scripts/views/data-table/cell-renderers/registry.js", "main/webapp/modules/core/scripts/views/data-table/cell-renderers/simple-value-renderer.js", "main/webapp/modules/core/scripts/views/data-table/cell-ui.js"]
|
Extension point for cell rendering
|
As part of the Wikimedia Commons integration project, there is an interest (@trnstlntk @lozanaross ) in customizing the cell rendering to include thumbnails of the media files being uploaded (or edited): https://github.com/OpenRefine/CommonsExtension/issues/34.
There is currently no official way for an extension to customize how the cells of a particular column are rendered. Therefore, implementing this would first require introducing the corresponding extension point in OpenRefine itself.
Introducing extension points is a subtle thing to do, as we need to care about the following aspects:
* The introduction of the extension points commits us to maintaining such an interface in a stable way in the future, to some extent. For instance, if we wanted to rewrite the grid rendering in a different framework, this would likely imply changing this extension point, hence breaking extensions which rely on it;
* The use case that motivates the introduction of the extension point should be generalized sufficiently for the extension point to be useful to other use cases: we need to make a good effort at thinking about in which other use cases one might want to customize the way cells are rendered.
### Proposed solution
We first need to enable extensions to store column-specific metadata which controls how the column is rendered. Introduce for this a JSON field in the column metadata object, where extensions can store arbitrary JSON.
Then, add a new extension point which lets extensions register cell rendering callbacks. A cell rendering callback is a javascript function, which takes as arguments:
* a cell object (as a JSON-deserialized object, which came from the backend)
* the column metadata for the column in which it is being rendered
The callback is expected to return:
* either a DOM element, which then becomes the rendered cell value (on top of which is added the "edit" button, still managed by the core software)
* or `null`, meaning that the callback is not attempting to override the rendering of this cell and delegates its rendering to other callbacks or the core software
When cell rendering callbacks are registered, they are also attributed a priority (an integer) by the registrant. When rendering a cell, cell rendering callbacks are executed in order of decreasing priority. The first callback that returns a DOM element determines how the cell is rendered. If all callbacks return `null`, then the core software is used to render the cell.
### Alternatives considered
Do not build an extension point for cell rendering, and instead build this feature in the core software, with the understanding that rendering file paths of images as thumbnails is a feature that would be useful to a wide enough community.
## Feedback welcome
@elebitzero @tfmorris Can you think of other ways to support this?
|
https://github.com/OpenRefine/OpenRefine/issues/5154
|
https://github.com/OpenRefine/OpenRefine/pull/5312
|
d80741e5140275abfb5ea05855502e0a5be1f681
|
0fa6dd505bee1139f32e36b8da06b36744d0e8bc
| 2022-08-05T12:41:58Z |
java
| 2022-12-06T21:12:29Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,144 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/module/scripts/dialogs/perform-edits-dialog.js", "extensions/wikidata/module/scripts/warningsrenderer.js", "extensions/wikidata/src/org/openrefine/wikidata/qa/EditInspector.java", "extensions/wikidata/src/org/openrefine/wikidata/qa/QAWarning.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/commands/PreviewWikibaseSchemaCommandTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/qa/QAWarningTest.java"]
|
"Locate offending rows" does not work
|
Clicking on the "Locate offending rows" button in any Wikibase issue does not have any effect.
Also, the warning below should not have a "Locate offending rows" button because the issue is not always generated by a single row in the project:
Not writing more here because I intend to fix this directly.
|
https://github.com/OpenRefine/OpenRefine/issues/5144
|
https://github.com/OpenRefine/OpenRefine/pull/5146
|
ae7a2af69cba5a0b8e47fd49dfbd4b5f17b059e4
|
0313e27324bbc945614e89511dc69ff12f2834dc
| 2022-08-03T13:59:18Z |
java
| 2022-08-11T19:31:04Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,143 |
["main/webapp/modules/core/scripts/views/data-table/add-column-dialog.html", "main/webapp/modules/core/scripts/views/data-table/menu-edit-column.js"]
|
In the "Add column based on this column" dialog, validating a form by pressing Enter should run the operation
|
When adding a column based on a column, I often first type the expression I want, and then set a column name in the field at the top, and then press Enter, expecting it to have the same effect as clicking the "OK" button. It currently does not do anything.
### Proposed solution
This field should be part of a form, and when that form is submitted, that should be equivalent to pressing the OK button.
This should not require setting up any event listener on keyboard events, but instead integrate the existing input fields in a form, and binding the submission event on that form to the execution of the operation (and closing the dialog).
### Alternatives considered
None.
### Screenshot
|
https://github.com/OpenRefine/OpenRefine/issues/5143
|
https://github.com/OpenRefine/OpenRefine/pull/5149
|
7e85d97b52d1e98117cb791646608d79de350080
|
14aaf7273bcba63ff8f8aae83105239e735dbd7d
| 2022-08-03T13:26:21Z |
java
| 2022-08-09T12:21:21Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,138 |
["main/webapp/modules/core/scripts/dialogs/clustering-dialog.js"]
|
Cluster & Edit doesn't work anymore in OR 3.6.0
|
### To Reproduce
Select any appropriate column, Edit cells, Cluster and edit; tick some boxes, select Merge and recluster.
### Current Results
The first time, the same clusters re-appear, it hasn't processed any. A subsequent time, a message "You must check some Edit? checkboxes for your edits to be applied." appears, but some boxes are ticked.
The problem appears on a data set of just over 5000 rows, 6 columns.
On a small sample from my dataset, the problem is less severe. It processes 1 of 2 clusters selected.
### Expected Behavior
In version 3.5.2 everything still works fine.
### Screenshots
### Versions
- Operating System: Windows 10 10.0.19044.1766
- Browser Version: Google Chrome 103.0.5060.134 (Official build) (64-bits)
- JRE or JDK Version: openjdk version "17.0.3" 2022-04-19
- OpenRefine: 3.6.0
|
https://github.com/OpenRefine/OpenRefine/issues/5138
|
https://github.com/OpenRefine/OpenRefine/pull/5153
|
9aaee8bbcbfc98d2bda998430c759290ab014673
|
ba1e15ee375cbea2077e335f909b4e615471d4e2
| 2022-08-02T15:18:57Z |
java
| 2022-08-05T06:58:04Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,130 |
["main/src/com/google/refine/model/Column.java", "main/src/com/google/refine/model/changes/DataExtensionChange.java", "main/tests/server/src/com/google/refine/model/ColumnTests.java", "main/tests/server/src/com/google/refine/operations/recon/ExtendDataOperationTests.java", "main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/views/data-table/column-header-ui.js"]
|
Improve how to indicate the data source following data extension
|
Currently a default OpenRefine-to-Wikibase workflow works well if users only reconcile data against a single service, e.g. Wikidata, and then proceed towards schema building and data upload with this single service. However, in reality - with the introduction of the possibility to reconcile against and upload data edits to any arbitrary Wikibase (and Wikimedia Commons, too) - users may wish to work across several services at once. For example, enriching (or extending) a dataset from one Wikibase with data from another, in addition to also including data from various other authority control sources (e.g. GND, Getty’s ULAN, VIAF, etc). Currently, however, once a data extension operation is carried out — there is no easy visual cue to a user to specify what source each column has been pulled from and - depending on the data type - also reconciled against, leading easily to making mistakes during schema building when users only see column titles and a green bar.
If data is pulled from Wikidata via reconciled values - the data can be shown to be reconciled to Wikidata with a little logo as per suggestion in this issue: #4824, but there is no way to tell users the **source** was **also** Wikidata. For that users proposed that prefixes are added to the column headers.
### Proposed solution
Add prefixes to column names to indicate where the data was pulled from. E.g. wmc: for Wikimedia Commons; wd: for Wikidata; wb: for any other Wikibase, etc.
Example where some artworks are reconciled with Wikidata and then the 'collection' property values are pulled from Wikidata via data extension:
Example with data pulled from Commons:
### Alternatives considered
Adding small service logos next to the reconciled status green bar, but that solution does not always translate 1:1 with the data extension use case.
### Additional context
This feature request is most useful during schema building, so the prefixes should naturally be carried over to the drag / drop elements in that interface that contain the column names.
|
https://github.com/OpenRefine/OpenRefine/issues/5130
|
https://github.com/OpenRefine/OpenRefine/pull/6285
|
ec4045764429a86a22704a4638e24bc3e27d2593
|
bb6481738a465dc4c54660f17e82b95497d1a7d3
| 2022-07-30T10:07:20Z |
java
| 2024-01-23T19:31:55Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,126 |
["docs/package.json", "docs/yarn.lock"]
|
NoSuchMethodError during Wikidata edits through upload
|
While trying to add directors to movies, OpenRefine gets stuck on 45%. In my console I see an error:
```
Exception in thread "Thread-5" java.lang.NoSuchMethodError: 'org.wikidata.wdtk.datamodel.interfaces.TermUpdate org.wikidata.wdtk.datamodel.helpers.Datamodel.makeTermUpdate(java.util.Collection, java.util.Collection)'
at org.openrefine.wikidata.updates.ItemEdit.toEntityUpdate(ItemEdit.java:147)
at org.openrefine.wikidata.editing.EditBatchProcessor.performEdit(EditBatchProcessor.java:173)
at org.openrefine.wikidata.operations.PerformWikibaseEditsOperation$PerformEditsProcess.run(PerformWikibaseEditsOperation.java:262)
at java.base/java.lang.Thread.run(Unknown Source)
```
|
https://github.com/OpenRefine/OpenRefine/issues/5126
|
https://github.com/OpenRefine/OpenRefine/pull/4075
|
bba2e6e0157fbf5fdb9a33084440f68a2f97c9b2
|
4cde23ed84d00a2aa8229e8e86d5f0512fa49cb4
| 2022-07-27T19:32:37Z |
java
| 2021-07-29T18:11:34Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,120 |
["docs/docs/technical-reference/contributing.md", "docs/versioned_docs/version-3.6/technical-reference/contributing.md"]
|
[doc] docusaurus installation instructions missing
|
https://docs.openrefine.org/technical-reference/contributing says
> you can install Docusaurus with
and then the commands are missing.
Maybe cite something from https://docusaurus.io/docs/installation and make a link to that page?
|
https://github.com/OpenRefine/OpenRefine/issues/5120
|
https://github.com/OpenRefine/OpenRefine/pull/5128
|
128aa969f12dea46f8979e3e055e7318672921a4
|
ad2059f3adeac4085fe814974f9bf63fcd102740
| 2022-07-26T17:42:54Z |
java
| 2022-07-29T11:15:04Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,107 |
["extensions/gdata/module/scripts/index/gdata-source-ui.js", "main/webapp/modules/core/scripts/util/misc.js"]
|
The login for the Google Data importer seems to be broken
|
When using the Google Data importer, the login process works, but at the stage of displaying the documents, it keeps stalling.
### To Reproduce
Steps to reproduce the behavior:
1. Login into Google
2. Then, wait indefinitely.
### Current Results
It stalles.
But I don't believe it's a KEY issue from packaging. I was able to login a first time. I experience the same problem with v3.6rc1 and v3.6.
To make things worst, henceforth v3.6, I think we have this problem on ALL our platforms. I tested Windows 10 and Ubuntu 22.04 and I see the same thing, an infinite spin. :-(
### Expected Behavior
Display the list of files
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: Tested on Mac 11.6, Windows 10 and Ubuntu 22.04
- Browser Version: Chrome v102
- JRE or JDK Version: Java 11
- OpenRefine: v3.6rc1 and v3.6
### Other information
I don't think it's related to https://github.com/OpenRefine/OpenRefine/issues/4414.
|
https://github.com/OpenRefine/OpenRefine/issues/5107
|
https://github.com/OpenRefine/OpenRefine/pull/5109
|
e78656669705cc7e9477f85df979648a2e5fdc8b
|
1643eb52d424387a3d374c98f4f658492af71a54
| 2022-07-24T14:42:18Z |
java
| 2022-07-25T04:47:35Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,089 |
["extensions/wikidata/module/styles/schema-alignment.less"]
|
Wikitext overlaps file path (Wikimedia Commons schema preview)
|
See screenshot above - Wikitext is pushed to the far right and overlaps the file path when uploading files to Wikimedia Commons. Probably introduced since the new 'override Wikitext' feature; I haven't noticed this earlier.
### To Reproduce
Steps to reproduce the behavior:
1. Work on a Wikimedia Commons upload project and include a column of Wikitext
2. Create schema
3. Preview schema and notice the overlaps
### Current Results
Overlaps
### Expected Behavior
No overlaps, and Wikitext is fully legible
### Versions<!-- (please complete the following information)-->
- Operating System: MacOS 12.4
- Browser Version: Chrome 103.0.5060.114
- OpenRefine: 3.7 snapshot release of 20220718
### Datasets
[Rotterdam-1604-Geerling.openrefine (1).tar.gz](https://github.com/OpenRefine/OpenRefine/files/9135485/Rotterdam-1604-Geerling.openrefine.1.tar.gz)
|
https://github.com/OpenRefine/OpenRefine/issues/5089
|
https://github.com/OpenRefine/OpenRefine/pull/5091
|
e11e075b475aa88803a0e2078744ac940db5ad93
|
3b44b64d3811d3a07077951490c87040990c7ba0
| 2022-07-18T20:09:31Z |
java
| 2022-07-20T06:48:38Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,087 |
["extensions/sample/pom.xml"]
|
Sample extension home page returns 500 TypeError, not a function
|
When you visit http://127.0.0.1:3333/extension/sample/ as described at https://github.com/OpenRefine/OpenRefine/wiki/Sample-Extension, you get the following stack trace instead of the contents of `index.vt` as expected:
### Current Results
```
URI: /extension/sample/
500
Butterfly Error Butterfly caught the following error while processing the request: org.mozilla.javascript.EcmaError: TypeError: Cannot call property stringArrayLength in object [JavaPackage com.google.refine.sampleExtension.SampleUtil]. It is not a function, it is "object". (file:/Applications/OpenRefine-3.5.2.app/Contents/Resources/webapp/extensions/sample/module/MOD-INF/controller.js#75) at org.mozilla.javascript.ScriptRuntime.constructError(ScriptRuntime.java:4563) at
org.mozilla.javascript.ScriptRuntime.constructError(ScriptRuntime.java:4544) at
org.mozilla.javascript.ScriptRuntime.typeError(ScriptRuntime.java:4576) at
org.mozilla.javascript.ScriptRuntime.typeErrorById(ScriptRuntime.java:4581) at
org.mozilla.javascript.ScriptRuntime.notFunctionError(ScriptRuntime.java:4662) at
org.mozilla.javascript.ScriptRuntime.getPropFunctionAndThisHelper(ScriptRuntime.java:2585) at
org.mozilla.javascript.ScriptRuntime.getPropFunctionAndThis(ScriptRuntime.java:2568) at
org.mozilla.javascript.gen.file__Applications_OpenRefine_3_5_2_app_Contents_Resources_webapp_extensions_sample_module_MOD_INF_controller_js_16._c_process_2(file:/Applications/OpenRefine-3.5.2.app/Contents/Resources/webapp/extensions/sample/module/MOD-INF/controller.js:75) at
org.mozilla.javascript.gen.file__Applications_OpenRefine_3_5_2_app_Contents_Resources_webapp_extensions_sample_module_MOD_INF_controller_js_16.call(file:/Applications/OpenRefine-3.5.2.app/Contents/Resources/webapp/extensions/sample/module/MOD-INF/controller.js) at
org.mozilla.javascript.ContextFactory.doTopCall(ContextFactory.java:380) at
org.mozilla.javascript.ScriptRuntime.doTopCall(ScriptRuntime.java:3868) at
org.mozilla.javascript.gen.file__Applications_OpenRefine_3_5_2_app_Contents_Resources_webapp_extensions_sample_module_MOD_INF_controller_js_16.call(file:/Applications/OpenRefine-3.5.2.app/Contents/Resources/webapp/extensions/sample/module/MOD-INF/controller.js) at
edu.mit.simile.butterfly.ButterflyModuleImpl$Controller.process(ButterflyModuleImpl.java:399) at
edu.mit.simile.butterfly.ButterflyModuleImpl$Controller.run(ButterflyModuleImpl.java:377) at
org.mozilla.javascript.Context.call(Context.java:535) at org.mozilla.javascript.ContextFactory.call(ContextFactory.java:472) at edu.mit.simile.butterfly.ButterflyModuleImpl.processScript(ButterflyModuleImpl.java:650) at
edu.mit.simile.butterfly.ButterflyModuleImpl.process(ButterflyModuleImpl.java:427) at
edu.mit.simile.butterfly.Butterfly.service(Butterfly.java:518) at com.google.refine.RefineServlet.service(RefineServlet.java:210) at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) at
org.eclipse.jetty.servlet.ServletHolder$NotAsyncServlet.service(ServletHolder.java:1395) at
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:755) at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1617) at
org.eclipse.jetty.servlets.GzipFilter.doFilter(GzipFilter.java:50) at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1596) at
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:545) at
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) at
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:590) at
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) at
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235) at
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1607) at
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233) at
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1297) at
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188) at
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:485) at
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1577) at
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186) at
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1212) at
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) at
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) at
com.google.refine.ValidateHostHandler.handle(ValidateHostHandler.java:96) at
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) at
org.eclipse.jetty.server.Server.handle(Server.java:500) at
org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:383) at
org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:547) at
org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:375) at
org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:270) at
org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311) at
org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103) at
org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117) at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748)
```
### Expected Behavior
Return a formatted template from `index.vt`
### Versions<!-- (please complete the following information)-->
- Operating System: MacOS 11.6.2
- Browser Version: Chrome Version 103.0.5060.114 (Official Build) (x86_64)
- JRE or JDK Version: bundled JRE
- OpenRefine: 3.2.1
|
https://github.com/OpenRefine/OpenRefine/issues/5087
|
https://github.com/OpenRefine/OpenRefine/pull/5090
|
0cd8caf8d170e030c3b3d5a3c7b8ce28b9a326b2
|
693c1476832226bb9950fa5dc76995d1bc88eef7
| 2022-07-18T01:58:49Z |
java
| 2022-07-19T07:35:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,051 |
["main/tests/cypress/cypress/integration/project/grid/viewpanel-header/sort.spec.js"]
|
Unstable Cypress test for the sorting functionality
|
We regularly have CI failures due some Cypress tests which test our sorting functionalities:
* https://github.com/OpenRefine/OpenRefine/runs/7269100211?check_suite_focus=true
* https://github.com/OpenRefine/OpenRefine/runs/7246541652?check_suite_focus=true
We should fix those tests or OpenRefine itself so that this does not happen.
|
https://github.com/OpenRefine/OpenRefine/issues/5051
|
https://github.com/OpenRefine/OpenRefine/pull/5053
|
8b47035864856c90981b51954d356f4c19cc2c50
|
19caa8e5e03039ed571e2c322314521a8eb46cd4
| 2022-07-10T08:51:28Z |
java
| 2022-07-18T19:44:12Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,043 |
["extensions/wikidata/module/MOD-INF/controller.js", "extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/module/scripts/dialogs/save-new-template-dialog.html", "extensions/wikidata/module/scripts/dialogs/save-new-template-dialog.js", "extensions/wikidata/module/scripts/schema-alignment-tab.html", "extensions/wikidata/module/scripts/schema-alignment.js", "extensions/wikidata/module/scripts/template-manager.js", "extensions/wikidata/module/scripts/wikibase-manager.js", "extensions/wikidata/module/scripts/wikibase-manifest-schema-v2.js", "extensions/wikidata/module/styles/schema-alignment.less"]
|
Ability to save "schema templates": schemas where some values are left empty
|
Wikibase communities generally establish some data modelling conventions, which users are asked to follow when importing data.
For instance, a book on Wikidata will generally have a certain set of statements on it (title, author, date of publication…).
When importing data in a Wikibase instance, users need to have the knowledge of those modelling conventions. If they do not have this knowledge, a blank schema page can be quite daunting.
### Proposed solution
We should make it possible for users to define "schema templates" which represent a prototypical Wikibase schema for an import in a certain domain. Those schema templates would be incomplete Wikibase schemas, in the sense that some statement values could be left blank, for instance. After loading such a template, the user could then drag and drop the columns from their project to the appropriate locations in the schema.
For the implementation, we would just use the same classes as the ones that define schemas, but relax the validation in the constructors to allow for empty value. We would then add methods to check that a given schema is complete. This would be the opportunity to return more precise error messages when the schema is incomplete (#4724).
### Alternatives considered
Use [ShEx](https://en.wikipedia.org/wiki/ShEx) or [SHACL](https://en.wikipedia.org/wiki/SHACL). Those formats are not designed for the Wikibase data model, but rather for RDF. This means that it would not be possible to take a schema represented in one of those formats, and render it as a Wikibase schema with holes. Therefore this does not seem fitting here.
### Additional context
Requested by @trnstlntk @lozanaross in the context of the Wikimedia Commons integration project.
|
https://github.com/OpenRefine/OpenRefine/issues/5043
|
https://github.com/OpenRefine/OpenRefine/pull/5191
|
6b276a58605bfa93431a1a8349fe9e5f625cc713
|
51d45d139dcb484c54f07987e7892d0b02fafb1b
| 2022-07-08T14:24:53Z |
java
| 2022-08-31T06:56:22Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,037 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/module/scripts/dialogs/perform-edits-dialog.js", "extensions/wikidata/src/org/openrefine/wikidata/commands/PreviewWikibaseSchemaCommand.java", "extensions/wikidata/src/org/openrefine/wikidata/functions/WikibaseIssuesFunction.java", "extensions/wikidata/src/org/openrefine/wikidata/qa/EditInspector.java", "extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/EditScrutinizer.java", "extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/NewEntityScrutinizer.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/qa/EditInspectorTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/qa/scrutinizers/NewEntityScrutinizerTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/qa/scrutinizers/ScrutinizerTest.java"]
|
Implement expensive Wikibase QA checks only triggered before upload
|
The Wikibase extension comes with some quality assurance checks, which validate the candidate edits against some constraints, to warn the user of potential issues in the edits.
The checks implemented so far are designed to run quickly, so that we can update the issues tab in real time, as the user transforms their dataset and filters it to display a specific subset of rows.
Sometimes it would be useful to implement more expensive checks, which we would not want to run every time a change in project data happens, because it would delay the delivery of issues to the user and waste resources. For instance, I am thinking about the following checks:
* when uploading new items with external unique identifiers, check if there are any existing items with those identifier values. For now we only report an issue if we are creating two different items with the same identifier value
* when uploading new media files, check that their filenames do not exist on the MediaWiki instance yet
* checking for the presence of suitable inverse statements (for now we only check for them within the edits to be made)
* and probably more constraint checks that we cannot implement fully without fetching data from the Wikibase instance
### Proposed solution
Constraint checks could be run into two modes:
* the fast mode (the current one), in which the check must be performed quickly (without fetching external information except for small metadata like constraint definitions)
* the slow mode (the new one), in which the checks are allowed to take longer, for instance by making some network operations
The slow mode would only be triggered when opening the "Upload edits to Wikibase" dialog. This dialog would show those more thoroughly computed checks (currently it already displays the existing fast checks).
### Alternatives considered
One other solution could be to change the architecture used to compute QA issues, so that each scrutinizer could return its issues asynchronously. This would mean that the issues that are the fastest to compute would be displayed first, and then the slower ones would appear. This would be very nice to have, but I think it would not get rid of the need to have two modes (slow / fast), because I would not want to run the expensive checks over and over, every time a change is made (it would generate a lot of requests to the target wikibase, a lot of which would likely be redundant).
|
https://github.com/OpenRefine/OpenRefine/issues/5037
|
https://github.com/OpenRefine/OpenRefine/pull/5317
|
a0a5b847d0576063e2947fc9b8ab13accc55bf7d
|
a2de7095a21ee7bb51aa02902259ca97a9ca8ea4
| 2022-07-07T14:54:00Z |
java
| 2022-10-13T16:11:55Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,035 |
["extensions/wikidata/module/scripts/wikibase-manifest-schema-v1.js", "extensions/wikidata/module/scripts/wikibase-manifest-schema-v2.js"]
|
Wikibase manifest format does not allow for local reconciliation endpoint
|
For testing purposes I have created a Wikibase manifest for [EDTF Wikibase](https://edtf.wikibase.wiki/wiki/), a test Wikibase instance which demonstrates the EDTF datatype.
As part of this I have written the following Wikibase manifest:
```json
{
"version": "1.0",
"mediawiki": {
"name": "EDTF Wikibase",
"root": "https://edtf.wikibase.wiki/wiki/",
"main_page": "https://edtf.wikibase.wiki/wiki/Main_Page",
"api": "https://edtf.wikibase.wiki/w/api.php"
},
"wikibase": {
"site_iri": "http://edtf.wikibase.wiki/entity/",
"maxlag": 5,
"properties": {
"instance_of": "P3",
"subclass_of": "P15"
}
},
"oauth": {
"registration_page": "https://artbase.rhizome.org/wiki/Special:OAuthConsumerRegistration/propose"
},
"reconciliation": {
"endpoint": "http://localhost:8000/${lang}/api"
}
}
```
### Current Results
This manifest is currently not accepted by the UI, seemingly because the reconciliation endpoint is not recognized as a valid URL.
I suspect this is due to the `localhost` host which might not be accepted by the underlying regex.
### Expected Behavior
According to https://json-schema.org/understanding-json-schema/reference/string.html, the format we are currently using (`url`) is not even supported by the standard. Since we include the `${lang}` variable in it, we should probably use `uri-template` instead, although that would mean conforming to that particular format.
Alternatively we could use our own regex to validate this field, or drop validation for it. After all, the validity of this field is checked immediately after parsing the Wikibase manifest, by trying to add the reconciliation service.
### Environment
OpenRefine 3.7-SNAPSHOT, Linux, Firefox
|
https://github.com/OpenRefine/OpenRefine/issues/5035
|
https://github.com/OpenRefine/OpenRefine/pull/5274
|
28307f2d7a3255e597dd70738b72a78983caed10
|
daac8fa28437b43d8448d997dcd4bd70a0360387
| 2022-07-07T11:56:37Z |
java
| 2022-09-26T09:13:32Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,022 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/project/history-apply-dialog.html", "main/webapp/modules/core/scripts/project/history-panel.js"]
|
Apply Operation History from JSON file
|
Related to #4498, I would like to see a button to Apply Operation History by opening a JSON file instead of having to open the file separately. This would remove any need to copy-paste the contents of these files, and make it easier for users.
|
https://github.com/OpenRefine/OpenRefine/issues/5022
|
https://github.com/OpenRefine/OpenRefine/pull/5748
|
086bb76f03251074e3d31075cc514f16c28e4118
|
0f78baeadd16225d31a00437427f185fc691fa7a
| 2022-07-05T11:22:59Z |
java
| 2023-05-03T07:22:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,013 |
[".github/workflows/pull_request.yml", ".github/workflows/snapshot_release.yml"]
|
Re-enable Coveralls in the CI
|
Our submission of coverage info to Coveralls is broken, so I have disabled it.
It would be great to fix the underlying issue or migrate to another coverage info submission mechanism.
https://github.com/trautonen/coveralls-maven-plugin/issues/147
|
https://github.com/OpenRefine/OpenRefine/issues/5013
|
https://github.com/OpenRefine/OpenRefine/pull/5807
|
9bc4104a3b84693b71c2e536e0a3819ad5469f8d
|
001191ec392b6cb7ccf6cf0a7efb7de793f0482f
| 2022-07-04T10:19:18Z |
java
| 2023-06-02T15:41:10Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,012 |
["docs/docs/index.md", "docs/docs/manual/wikibase/overview.md", "docs/docs/manual/wikibase/uploading.md", "docs/sidebars.js", "docs/static/img/add-wikibase-manifest.png", "docs/static/img/commons-contribution.png", "docs/static/img/commons-project.png", "docs/static/img/commons-schema.png"]
|
(3.6) Add basic Wikimedia Commons editing documentation to OpenRefine's docs
|
Write some basic info about the new Wikimedia Commons features (introduced in OpenRefine 3.6) in our [documentation](https://docs.openrefine.org/manual/wikibase/overview).
|
https://github.com/OpenRefine/OpenRefine/issues/5012
|
https://github.com/OpenRefine/OpenRefine/pull/5023
|
9bdd80063b83259ef5e73629d78731f27ee44b32
|
f26bd4a1a87391caf55daf9344df241cd01e2c01
| 2022-07-04T08:39:08Z |
java
| 2022-07-07T14:12:31Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,009 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/module/scripts/dialogs/wikibase-dialog.html", "extensions/wikidata/module/scripts/dialogs/wikibase-dialog.js", "extensions/wikidata/module/scripts/dialogs/wikibase-item.html", "extensions/wikidata/module/scripts/menu-bar-extension.js", "extensions/wikidata/module/styles/dialogs/wikibase-dialog.less"]
|
More UI improvements for Wikibase selection dialog
|
In the (resolved) issue #3824, the Wikibase selection dialog window has been improved.
@lozanaross and I have tested the "new style" window in v3.7 while observing people during Wikimedia Commons upload user tests, and we notice that its behavior is still confusing to folks, especially the way in which Wikibase instances change place in the window as a new one is selected (the active one will jump to the top). A UX where instances are e.g. in alphabetical order, and the active one is highlighted otherwise, would feel more natural/intuitively understandable.
### Proposed solution
This design by @lozanaross is probably still a better way to go (or do we already have a newer version?). Radio button to select the desired active instance, cross to delete an instance, `Add another instance` button to add a new one. Instances stay in the same place/order and don't switch around after selection/addition.
### Additional context
Also see #5007 - may be good to integrate a link to the Wikibase manifest repository as well?
I may miss elements that are relevant for better UX of this dialog, so feel free to chime in with more factors to take into account.
|
https://github.com/OpenRefine/OpenRefine/issues/5009
|
https://github.com/OpenRefine/OpenRefine/pull/5049
|
feb6128cf7c64cb6547b290ca52bf66f866bdf98
|
8e4dce1ac7df5adf561ea8f912db86e299817ee1
| 2022-07-03T12:00:22Z |
java
| 2022-07-19T23:12:45Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 5,007 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/module/scripts/dialogs/wikibase-dialog.html", "extensions/wikidata/module/scripts/dialogs/wikibase-dialog.js"]
|
"Discover Wikibase manifests..." button
|
OpenRefine 3.6 comes with a very handy new `Discover services...` button in the reconciliation dialog that helps people discover reconciliation services (clicking the button will bring folks to https://reconciliation-api.github.io/testbench/#/ which lists many of these services).
Similarly, it would be great (and a uniform pattern) if we had a similar `Discover Wikibase manifests...` button in the Wikibase extension's 'Select Wikibase instance' dialog window.
When clicking on that new button, folks could be led to https://github.com/OpenRefine/wikibase-manifests. This could also be an encouragement for more Wikibase maintainers to publish their manifests there.
|
https://github.com/OpenRefine/OpenRefine/issues/5007
|
https://github.com/OpenRefine/OpenRefine/pull/5030
|
941d7e3b9da5ce77dab16971406fa92e3b21ca1e
|
9e23a1f3a07f7c4dc3a1e2ba78149d9b1add70aa
| 2022-07-02T18:24:45Z |
java
| 2022-07-08T06:19:07Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,988 |
["main/webapp/modules/core/MOD-INF/controller.js", "main/webapp/modules/core/externals/suggest/css/suggest-4_3.css", "main/webapp/modules/core/externals/suggest/css/suggest-4_3.min.css"]
|
Longer property description not fully appearing in schema builder
|
When searching for properties to build statements in the Wikibase extension's schema builder, longer property descriptions don't fully appear. Sometimes such descriptions are quite informative, and users can thus miss helpful info.
Example:
I am quite curious what is said at the end of the description of P8791.
### To Reproduce
Steps to reproduce the behavior:
1. Start building a schema in the schema builder
2. Search for properties with a longer description, e.g. (partial) search terms `digitiz` and `depic` will provide good examples where the description is cut off in OpenRefine's interface
### Expected Behavior
A bit more space is built in, either horizontally or vertically or both, so that property descriptions are fully displayed.
|
https://github.com/OpenRefine/OpenRefine/issues/4988
|
https://github.com/OpenRefine/OpenRefine/pull/4992
|
ca0bc5a91601de41613f4feba206bba9a85d1ec1
|
941d7e3b9da5ce77dab16971406fa92e3b21ca1e
| 2022-06-25T10:46:38Z |
java
| 2022-07-08T06:17:28Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,985 |
["main/src/com/google/refine/commands/recon/ReconMarkNewTopicsCommand.java", "main/src/com/google/refine/operations/recon/ReconMarkNewTopicsOperation.java", "main/tests/cypress/cypress/integration/project/grid/column/reconcile/actions/create_new_item_for_each.spec.js", "main/tests/server/src/com/google/refine/operations/recon/ReconMarkNewTopicsOperationTests.java", "main/webapp/modules/core/MOD-INF/controller.js", "main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/views/data-table/menu-reconcile.js", "main/webapp/modules/core/styles/dialogs/recon-service-selection-dialog.less"]
|
Feature request: "shortcut" menu item for new item creation against a chosen reconciliation service
|
Idea from @lozanaross, endorsed by me, which we discussed in the context of Wikimedia Commons user testing sessions.
Creating new items via reconciliation services is a confusing process, as we regularly see in demos or user tests. People first have to reconcile non-existent entities (eg not yet existing Wikidata items or Wikimedia Commons filenames) against a reconciliation service, and then mark them as new. We propose a shortcut to make this process easier and probably more logical.
### Proposed solution
Add a menu item which may be something like `Create new items via reconciliation service...`
When selecting this menu item, the user then gets a small dialog, very similar to the one produced by the `Use values as identifiers` menu command, saying: `Create a new item for each of the selected cells, against reconciliation service:` with a drop-down menu that allows the user to choose between all the reconciliation services they have installed.
(The idea is that prior reconciliation before this process then would not be necessary.)
### Alternatives considered
Keep the current situation with very confused users.
|
https://github.com/OpenRefine/OpenRefine/issues/4985
|
https://github.com/OpenRefine/OpenRefine/pull/5322
|
a2de7095a21ee7bb51aa02902259ca97a9ca8ea4
|
26380050f4a5725ef2499164832ab7ed6e1bb11b
| 2022-06-23T17:33:13Z |
java
| 2022-10-13T16:12:26Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,980 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/NewEntityScrutinizer.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/qa/scrutinizers/NewEntityScrutinizerTest.java"]
|
Check that created Wikibase items have distinct (name,description) pairs
|
Hi all,
I am creating new Wikidata entries for a museum via OR (version 3.5) using the Wikidata extension. However, I have had several instances where the edits do not perform from a certain point onwards. Strange but perhaps important detail: OR shows the edits as 78% complete, while in Wikidata I can see in my contributions that only about 30 of the 293 items of _Part 4 of the public domain upload for the DIVA museum_ have been uploaded. Many titles are the same (Lepel, Vork, Modelprent met verschillende voorwerpen, ...), but it seems to me that this cannot be the problem, right? They are in fact different objects, as you can see in the object number column, and thus I created new items for each cell.
### To Reproduce
Steps to reproduce the behavior:
1. Reconciliation of column Title (= item)
2. If the item doesn't exist > Actions > Create new item for each cell
3. Edit Wikibase schema
4. Upload edits to Wikibase
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10,
- Browser Version: Chrome 19, Firefox 61
- OpenRefine: OpenRefine 3.5
|
https://github.com/OpenRefine/OpenRefine/issues/4980
|
https://github.com/OpenRefine/OpenRefine/pull/5327
|
26380050f4a5725ef2499164832ab7ed6e1bb11b
|
b6a68e8cbefd5fd34541ba63eefcc2c56ed92839
| 2022-06-22T10:20:03Z |
java
| 2022-10-13T16:30:57Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,972 |
["main/webapp/modules/core/scripts/index/open-project-ui.js"]
|
Import Project and Language buttons are not visible
|
Hi. I have this type of errors when I open chrome devloper tools. I use Win 10 but I can't see Import Project and Language buttons on the left. Is sounds very strange. Thanks for any help.
Uncaught TypeError: Cannot set properties of null (setting 'id')
at Refine.OpenProjectUI._renderProjects (index-bundle.js:64956:18)
at Object.success (index-bundle.js:64942:26)
at fire (index-bundle.js:3234:31)
at Object.fireWith [as resolveWith] (index-bundle.js:3364:7)
at done (index-bundle.js:9842:14)
at callback (index-bundle.js:10313:8)
at Object.send (index-bundle.js:10323:7)
at Function.ajax (index-bundle.js:9740:15)
at Refine.OpenProjectUI._fetchProjects (index-bundle.js:64937:7)
at Refine.OpenProjectUI._buildTagsAndFetchProjects (index-bundle.js:64913:10)
index-bundle.js:64486 Uncaught TypeError: Cannot read properties of undefined (reading 'resize')
at resize (index-bundle.js:64486:32)
index-bundle.js:64486 Uncaught TypeError: Cannot read properties of undefined (reading 'resize')
at resize (index-bundle.js:64486:32)
at dispatch (index-bundle.js:5228:27)
at elemData.handle (index-bundle.js:4880:28)
|
https://github.com/OpenRefine/OpenRefine/issues/4972
|
https://github.com/OpenRefine/OpenRefine/pull/4976
|
eb6b3b1b30a5bbe66527391f3d1354142a1ba224
|
def198285814d1b88c90da2d305c0fc38e73ab08
| 2022-06-18T19:56:21Z |
java
| 2022-06-22T06:30:46Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,931 |
["extensions/wikidata/module/scripts/dialogs/manage-account-dialog.js"]
|
Log in / close buttons not visible when logging in in third party wikibase
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
### To Reproduce
Steps to reproduce the behavior:
1. Take the current snapshot release (I took for mac)
2. Make a project to upload data to a third party wikibase
3. Upload edits when not logged in
### Current Results
<img width="1728" alt="Screenshot 2022-06-06 at 17 29 52" src="https://user-images.githubusercontent.com/10883585/172193769-9b5be487-9814-4a1b-b546-eaf448db99f0.png">
### Expected Behavior
<img width="1728" alt="Screenshot 2022-06-06 at 17 30 00" src="https://user-images.githubusercontent.com/10883585/172193798-5f773163-7926-4e24-b3ca-2f7bbafc8c01.png">
NOTE: the screenshots show also the solution of the problem, some css problem
### Versions<!-- (please complete the following information)-->
- Version 3.6-SNAPSHOT [153eb2a]
|
https://github.com/OpenRefine/OpenRefine/issues/4931
|
https://github.com/OpenRefine/OpenRefine/pull/4940
|
c7cae9b83b7ccdf41dc77471dd4c2040061b59a5
|
dd52dd93345737c22d81dcf5afa8eb4b51a0365b
| 2022-06-06T15:34:43Z |
java
| 2022-06-08T15:01:14Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,930 |
["refine", "refine.bat"]
|
Java version messaging to users is inconsistent between Windows and Linux 'refine' scripts
|
If a user has set their `%JAVA_HOME%` env variable on Windows but the `%PATH%` variable has a different Java version for the runtime and is lower than the compiled class file version 55.0 (Java 11) then users will notice an error and failure during startup even though the Java version check was successful.
### To Reproduce
Steps to reproduce the behavior:
1. First, set `%JAVA_HOME%` to a path having Java 8 Update 333
2. Keep `%PATH%` env variable set to Java 11 runtime
3. Then, run `refine.bat`
### Current Results
```
E:\GitHub Repos\OpenRefine>refine
Using refine.ini for configuration
Getting Java Version...
openjdk version "11.0.14.1" 2022-02-08
OpenJDK Runtime Environment Temurin-11.0.14.1+1 (build 11.0.14.1+1)
OpenJDK 64-Bit Server VM Temurin-11.0.14.1+1 (build 11.0.14.1+1, mixed mode)
=====================================================
Getting Free Ram...
Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.UnsupportedClassVersionError: com/google/refine/Refine has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
```
### Expected Behavior
#### Windows
Since we now really depend on `%JAVA_HOME%` when setting the CLASSPATH in the `refine.bat` script for Windows, we should fully use %JAVA_HOME% for the Java version inspection and logging to support.log.
We currently have good support for checking the Java versions we support and reporting errors in our `refine` script for Linux and should ideally incorporate that `checkJavaMajorVersion()` functionality and adapt it into our `refine.bat` script for Windows. That way we are consistent with our Java error messaging to users on both platforms.
#### Linux
One of the additional things in the `refine` Linux script seems to be that we are not using the `$JAVA_HOME` env variable during the `checkJavaMajorVersion()` either but instead always a `$JAVA` variable. We should ideally always refer to and use `$JAVA_HOME` as a best practice in our version checking and classpath setup for refine startup, no matter the OS, since that is standard practice and gives users the ability to control their own Java environment or symbolically link to a different one.
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 11 and Linux
- Browser Version: Edge latest and Chrome
- JRE or JDK Version: openjdk version "11.0.14.1" 2022-02-08
- OpenRefine: master branch
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/4930
|
https://github.com/OpenRefine/OpenRefine/pull/4949
|
23029441e790975c5c6257ac4b26b94e11b7423a
|
abab670399924daf2222b366e078b758f6192d80
| 2022-06-06T12:55:22Z |
java
| 2022-06-15T09:13:10Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,924 |
["extensions/wikidata/src/org/openrefine/wikidata/editing/EditBatchProcessor.java", "extensions/wikidata/src/org/openrefine/wikidata/editing/MediaFileUtils.java", "extensions/wikidata/src/org/openrefine/wikidata/updates/MediaInfoEdit.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/editing/MediaFileUtilsTest.java"]
|
SDC: do null edit to trigger page update while adding structured data
|
[Category:INaturalist images missing SDC depicts](https://commons.wikimedia.org/wiki/Category:INaturalist_images_missing_SDC_depicts) is an example of a so-called 'maintenance category' for Structured Data on Wikimedia Commons; it indicates that certain files still lack a certain statement. I have recently added [depicts (P180)](https://www.wikidata.org/wiki/Special:EntityPage/P180) statements to many of these files, which should cause them to disappear from this category, but they keep showing up there. (I edited more than 20,000 files so I'd expect the category to still contain 20K to 30K files - not 50K.)
On the file side, though, the category itself doesn't appear with the individual files anymore ([example](https://commons.wikimedia.org/wiki/File:2014-08-19_Zebra_Finch,_Sumba,_Nusa_Tenggara_Timur,_Indonesia_3.jpg))
@multichill [told me](https://commons.wikimedia.org/wiki/User_talk:Multichill#Category:INaturalist_images_missing_SDC_depicts_may_need_a_poke) that this is due to [a bug on the Wikimedia Commons side](https://phabricator.wikimedia.org/T237991). SDC edits with bots and batch tools usually don't trigger a page refresh. [He advises us](https://commons.wikimedia.org/wiki/User_talk:Multichill#Category:INaturalist_images_missing_SDC_depicts_may_need_a_poke) to implement such a page refresh (by doing a null edit) in OpenRefine.
### Proposed solution
OpenRefine does a 'null edit' to trigger an update.
### Alternatives considered
Maybe this is not the most pressing issue (although maintenance categories on Wikimedia Commons are certainly really useful and it's nice if our edits become visible there). In the end, it's an upstream issue which should ideally be fixed on the Commons side though.
### Additional context
Phabricator ticket about the upstream issue on Wikimedia Commons: https://phabricator.wikimedia.org/T237991
|
https://github.com/OpenRefine/OpenRefine/issues/4924
|
https://github.com/OpenRefine/OpenRefine/pull/5031
|
6847db703a3c8e6984340121735f6493b051fcf4
|
74d8aa4fca0d1e20f09235b823e960d8f195e7d1
| 2022-06-03T16:56:48Z |
java
| 2022-07-19T08:21:37Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,918 |
["main/src/com/google/refine/importing/ImportingUtilities.java", "main/tests/server/src/com/google/refine/importing/ImportingUtilitiesTests.java"]
|
Restrict protocols that can be used when creating a project from a URL
|
We use Java's `URLConnection` to download the content of a file when creating a project from a URL.
This class supports various protocols, some of which can cause the software to execute user-supplied code when fetching the resource. This is potentially a vulnerability in situations where OpenRefine is hosted (which we do not officially support).
We should therefore restrict the set of protocols that can be used in this feature, for instance to `http`, `https`, `ftp` and `sftp`.
|
https://github.com/OpenRefine/OpenRefine/issues/4918
|
https://github.com/OpenRefine/OpenRefine/pull/4919
|
3342bc2f831939f5d84eaefae055349f35663179
|
8cb2fec45dd90fda8ed9608c691f6bb8ed721cd2
| 2022-06-03T09:22:40Z |
java
| 2022-06-06T12:15:44Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,890 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/views/data-table/menu-facets.js"]
|
Scatterplot facet should show error on non-numeric column
|
Column->Facet->Scatterplot facet requires the selected column to be numeric and at least one other numeric column.
### To Reproduce
1. Create Project. Choose sample file foods.csv
2. Next then Create Project
3. Calcium Column -> Facet -> Scatterplot Facet
### Current Results
Scatterplot shows a blank dialog when invoked on a non-numeric column.
### Expected Behavior
An error message should be displayed.
### Screenshots
|
https://github.com/OpenRefine/OpenRefine/issues/4890
|
https://github.com/OpenRefine/OpenRefine/pull/4893
|
456cc11dca50bcf4474bcf2c50325eeb7fba7e6e
|
a6c395a0189e1ace79bf5bd99839e84e841173ef
| 2022-05-25T22:23:34Z |
java
| 2022-06-15T09:47:18Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,889 |
["refine", "refine.bat"]
|
Invalid "distclean" option in scripts
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
The refine scripts:
* refine
* refine.bat
contain the invalid "distclean" option.
For maven, "distclean" is not a processable goal or directive for any plugin. It is not included in the clean plugin.
### To Reproduce
Steps to reproduce the behavior:
1. ./refine distclean
### Current Results
<!-- What results occurred or were shown. -->
An error.
### Expected Behavior
<!-- A clear and concise description of what you expected to happen or to show. -->
The"distclean" option should likely perform a process including the "mvn clean" command along with several forced directory removals to clean the distribution compiles.
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
None
### Versions<!-- (please complete the following information)-->
- Operating System: <!-- e.g. iOS, Windows 10, Linux, Ubuntu 18.04 -->N/A
- Browser Version: <!-- e.g. Chrome 19, Firefox 61, Safari, NOTE: OpenRefine does not support IE but works OK in most cases -->N/A
- JRE or JDK Version: <!-- output of "java -version" e.g. JRE 1.8.0_181 -->N/A
- OpenRefine: <!-- e.g. OpenRefine 3.0 Beta] -->All
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
N/A
### Additional context
<!-- Add any other context about the problem here. -->
None
|
https://github.com/OpenRefine/OpenRefine/issues/4889
|
https://github.com/OpenRefine/OpenRefine/pull/4921
|
a85366426c08194f15f7609c19935a3183fee477
|
3342bc2f831939f5d84eaefae055349f35663179
| 2022-05-25T19:13:54Z |
java
| 2022-06-03T15:57:27Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,883 |
["main/tests/cypress/cypress/integration/project/grid/column/edit-cells/common-transforms/collapse-consecutive-whitespace.spec.js", "main/webapp/modules/core/scripts/views/data-table/menu-edit-cells.js"]
|
"Collapse consecutive whitespace" operation does not collapse all possible unicode whitespace
|
The "Collapse consecutive whitespace" operation does not work when applied to certain whitespace unicode characters.
### To Reproduce
Steps to reproduce the behavior:
1. First, import this openrefine project: [Clipboard.openrefine.tar.gz](https://github.com/OpenRefine/OpenRefine/files/8762921/Clipboard.openrefine.tar.gz)
2. Then, run the "Collapse consecutive whitespace" operation on the only column
### Current Results
The cell is not edited
### Expected Behavior
The cell should be edited to "hello world"
### Versions<!-- (please complete the following information)-->
- JRE or JDK Version: 11
- OpenRefine: 3.6-SNAPSHOT
### Datasets
Real world dataset where this appears: https://opendata.paris.fr/explore/dataset/lieux-de-tournage-a-paris/information/?disjunctive.type_tournage&disjunctive.nom_tournage&disjunctive.nom_realisateur&disjunctive.nom_producteur&disjunctive.ardt_lieu
### Additional context
Discovered while doing a demo at Dataharvest 2022
|
https://github.com/OpenRefine/OpenRefine/issues/4883
|
https://github.com/OpenRefine/OpenRefine/pull/4898
|
af484da16b10b1ccd8afccd0b1b8f2d053fb29f1
|
c9d5a4f34ede842c63c410cd5db35b29e9569546
| 2022-05-24T13:14:06Z |
java
| 2022-06-15T12:39:58Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,878 |
["refine.bat"]
|
Changing the working directory to the folder of the batch file on Windows
|
If I start the script from another folder, it will not work.
### To Reproduce
Steps to reproduce the behavior:
1. First, from a different folder than the base folder of OpenRefine, call the batch file:
### Current Results
```
C:\Dev>cd ..
C:\>\Dev\OpenRefine\refine
The system cannot find the file refine.ini
C:\>
```
### Expected Behavior
A normal launch
```
C:\Dev\OpenRefine>cd \
C:\>\Dev\OpenRefine\refine
Using refine.ini for configuration
Getting Java Version...
openjdk version "11.0.14.1" 2022-02-08
OpenJDK Runtime Environment Temurin-11.0.14.1+1 (build 11.0.14.1+1)
OpenJDK 64-Bit Server VM Temurin-11.0.14.1+1 (build 11.0.14.1+1, mixed mode)
=====================================================
(…)
```
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- OpenRefine: v3.3, maybe less.
|
https://github.com/OpenRefine/OpenRefine/issues/4878
|
https://github.com/OpenRefine/OpenRefine/pull/4879
|
a1531318bc22a133b99439f19ed099fb3bc003e2
|
05373a1ac36bb3608abb63209c6411925efb4770
| 2022-05-22T02:11:41Z |
java
| 2022-05-23T17:33:56Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,877 |
["main/webapp/modules/core/scripts/reconciliation/standard-service-panel.js"]
|
Waiting screen while guessing reconciliation types should be internal to the reconciliation dialog
|
Currently, when opening the reconciliation dialog, we have the following user experience:
1. user selects the reconciliation service
2. a "Working…" screen appears while OpenRefine guesses reconciliation types. The user cannot do anything while this is shown.
3. the reconciliation configuration dialog appears and the user can start configuring the reconciliation
Sometimes the guessing of reconciliation types actually takes quite some time (depending on the recon endpoint, the internet connection speed, the specifics of the dataset…) and it can be quite frustrating to wait for this process to complete - especially if you already know which type you want to reconcile the data to, or if the service does not use types at all.
### Proposed solution
Instead of having this "Working…" screen, we should directly show the reconciliation configuration dialog. We would have a waiting spinner (similar to the one used in data extension preview) in the sub-area of the dialog which shows guessed types. It could look like this (with an animated spinner):
### Alternatives considered
None
### Additional context
Problem observed in a session at Dataharvest 2022 (in a conference room with pretty bad wifi)
|
https://github.com/OpenRefine/OpenRefine/issues/4877
|
https://github.com/OpenRefine/OpenRefine/pull/5722
|
bc6a4e7c960812ce6182d78c0a2079cf9829ad4d
|
6b2d889e82a8f218952706cdaa568709e58cb2c8
| 2022-05-21T11:57:26Z |
java
| 2023-03-24T08:02:15Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,876 |
["docs/README.md", "docs/docusaurus.config.js"]
|
Release OpenRefine's documentation under a Creative Commons license
|
I looked up some documentation yesterday, and it struck me that the footer at every https://docs.openrefine.org/ page says _"Copyright © 2022 OpenRefine contributors"_. I would find it fitting for an open source project to release our documentation under a [Creative Commons license](https://www.creativecommons.org).
At first sight, Attribution-ShareAlike 4.0 (or a more liberal 4.0 license) sounds like a good choice to me (most recent version of the CC licenses, compatible with the [Definition of Free Cultural Works](https://freedomdefined.org/Definition), compatible with licenses used in Wikimedia projects). The 'ShareAlike' component would make it into a [viral license](https://en.wikipedia.org/wiki/Viral_license) and we could even drop that part.
I totally imagine that the current _©_ setting/footer is just there because it is the default built into the Jekyll theme used for our documentation, and we never thought about modifying it ;-)
### What do other open source projects do?
I did a quick check of licensing used by other open source projects for their documentation, and it's interesting :-) More examples will give more inspiration.
* [Jupyter](https://docs.jupyter.org/en/latest/) and [Inkscape](https://inkscape-manuals.readthedocs.io/en/latest/) also have © - probably also just the result of going with the default offered by the themes of their documentation portal, I assume.
* OpenStreetmap has most of its documentation on a [MediaWiki wiki](https://wiki.openstreetmap.org/wiki/Beginners%27_guide), and they use CC BY-SA 2.0.
* [LibreOffice](https://documentation.libreoffice.org/en/english-documentation/) uses CC BY-SA 3.0
* Mozilla's MDN Web Docs mostly has [CC BY-SA 2.5 and later](https://developer.mozilla.org/en-US/docs/MDN/About#copyrights_and_licenses).
### Additional context and thoughts
Some of our documentation has been written by a contractor, and we may want to check their contract again and check back in with them for an agreement (maybe it's not necessary).
|
https://github.com/OpenRefine/OpenRefine/issues/4876
|
https://github.com/OpenRefine/OpenRefine/pull/4895
|
a90fdedad1b36aea7d6a2aa132e7865e75939c69
|
acbf61f60eb591b66890017b0cd3108592fd1df0
| 2022-05-21T07:40:37Z |
java
| 2022-05-30T07:12:02Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,873 |
["docs/docs/technical-reference/build-test-run.md", "docs/versioned_docs/version-3.5/technical-reference/build-test-run.md", "docs/versioned_docs/version-3.6/technical-reference/build-test-run.md"]
|
Can not build the Windows version of OpenRefine from the batch script
|
When I try to build from the command line on Windows, I get an error and it doesn't compile.
### To Reproduce
Steps to reproduce the behavior:
1. First, do `refine build`
### Current Results
```
C:\Dev\OpenRefine>echo %MAVEN_HOME%
C:\Program Files\apache-maven-3.8.5\bin
C:\Dev\OpenRefine>echo %JAVA_HOME%
C:\Program Files\OpenJDK\openjdk-11.0.14.1_1
C:\Dev\OpenRefine>refine build
Using refine.ini for configuration
> postinstall
> node copy-dependencies.js
node_modules/tablesorter/dist/js/jquery.tablesorter.js was copied to modules/core/3rdparty/tablesorter/jquery.tablesorter.js
node_modules/tablesorter/dist/css/theme.blue.css was copied to modules/core/3rdparty/tablesorter/theme.blue.css
node_modules/moment/min/moment-with-locales.js was copied to modules/core/3rdparty/moment-with-locales.js
node_modules/underscore/underscore.js was copied to modules/core/3rdparty/underscore.js
node_modules/js-cookie/src/js.cookie.js was copied to modules/core/3rdparty/js.cookie.js
node_modules/jquery-migrate/dist/jquery-migrate.js was copied to modules/core/3rdparty/jquery-migrate.js
node_modules/datejs-coolite/build/date.js was copied to modules/core/3rdparty/date.js
node_modules/jquery/dist/jquery.js was copied to modules/core/3rdparty/jquery.js
node_modules/select2/select2.css was copied to modules/core/3rdparty/select2/select2.css
node_modules/select2/select2.js was copied to modules/core/3rdparty/select2/select2.js
node_modules/select2/select2.png was copied to modules/core/3rdparty/select2/select2.png
node_modules/select2/select2-spinner.gif was copied to modules/core/3rdparty/select2/select2-spinner.gif
node_modules/@wikimedia/jquery.i18n/libs/CLDRPluralRuleParser/src/CLDRPluralRuleParser.js was copied to modules/core/3rdparty/jquery.i18n/CLDRPluralRuleParser.js
node_modules/@wikimedia/jquery.i18n/src/languages/bs.js was copied to modules/core/3rdparty/jquery.i18n/languages/bs.js
node_modules/@wikimedia/jquery.i18n/src/languages/dsb.js was copied to modules/core/3rdparty/jquery.i18n/languages/dsb.js
node_modules/@wikimedia/jquery.i18n/src/languages/fi.js was copied to modules/core/3rdparty/jquery.i18n/languages/fi.js
node_modules/@wikimedia/jquery.i18n/src/languages/ga.js was copied to modules/core/3rdparty/jquery.i18n/languages/ga.js
node_modules/@wikimedia/jquery.i18n/src/languages/he.js was copied to modules/core/3rdparty/jquery.i18n/languages/he.js
node_modules/@wikimedia/jquery.i18n/src/languages/hsb.js was copied to modules/core/3rdparty/jquery.i18n/languages/hsb.js
node_modules/@wikimedia/jquery.i18n/src/languages/hu.js was copied to modules/core/3rdparty/jquery.i18n/languages/hu.js
node_modules/@wikimedia/jquery.i18n/src/languages/hy.js was copied to modules/core/3rdparty/jquery.i18n/languages/hy.js
node_modules/@wikimedia/jquery.i18n/src/languages/la.js was copied to modules/core/3rdparty/jquery.i18n/languages/la.js
node_modules/@wikimedia/jquery.i18n/src/languages/ml.js was copied to modules/core/3rdparty/jquery.i18n/languages/ml.js
node_modules/@wikimedia/jquery.i18n/src/languages/os.js was copied to modules/core/3rdparty/jquery.i18n/languages/os.js
node_modules/@wikimedia/jquery.i18n/src/languages/ru.js was copied to modules/core/3rdparty/jquery.i18n/languages/ru.js
node_modules/@wikimedia/jquery.i18n/src/languages/sl.js was copied to modules/core/3rdparty/jquery.i18n/languages/sl.js
node_modules/@wikimedia/jquery.i18n/src/languages/uk.js was copied to modules/core/3rdparty/jquery.i18n/languages/uk.js
node_modules/@wikimedia/jquery.i18n/src/jquery.i18n.emitter.bidi.js was copied to modules/core/3rdparty/jquery.i18n/jquery.i18n.emitter.bidi.js
node_modules/@wikimedia/jquery.i18n/src/jquery.i18n.emitter.js was copied to modules/core/3rdparty/jquery.i18n/jquery.i18n.emitter.js
node_modules/@wikimedia/jquery.i18n/src/jquery.i18n.fallbacks.js was copied to modules/core/3rdparty/jquery.i18n/jquery.i18n.fallbacks.js
node_modules/@wikimedia/jquery.i18n/src/jquery.i18n.js was copied to modules/core/3rdparty/jquery.i18n/jquery.i18n.js
node_modules/@wikimedia/jquery.i18n/src/jquery.i18n.language.js was copied to modules/core/3rdparty/jquery.i18n/jquery.i18n.language.js
node_modules/@wikimedia/jquery.i18n/src/jquery.i18n.messagestore.js was copied to modules/core/3rdparty/jquery.i18n/jquery.i18n.messagestore.js
node_modules/@wikimedia/jquery.i18n/src/jquery.i18n.parser.js was copied to modules/core/3rdparty/jquery.i18n/jquery.i18n.parser.js
up to date, audited 10 packages in 701ms
1 moderate severity vulnerability
To address all issues (including breaking changes), run:
npm audit fix --force
Run `npm audit` for details.
Le chemin d’accès spécifié est introuvable.
Le chemin d’accès spécifié est introuvable.
C:\Dev\OpenRefine>
```
### Expected Behavior
That the project gets buid.
As a work around, `mvn install` seams to work. Not sure what I'm doing.
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- JRE or JDK Version: openjdk version "11.0.14.1" 2022-02-08
- OpenRefine: v3.5.x and maybe below
|
https://github.com/OpenRefine/OpenRefine/issues/4873
|
https://github.com/OpenRefine/OpenRefine/pull/5343
|
6ba546629944a919c1e1c637fa904387e8f98f37
|
01bd489d92ca2582d46755e4ee3a9486465b9f43
| 2022-05-19T21:42:17Z |
java
| 2022-10-28T08:53:29Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,868 |
["refine.bat"]
|
Bring back a readable Windows batch script tool
|
When you use the Windows batch script, you can not read the text.
### To Reproduce
Steps to reproduce the behavior:
1. launch `refine.bat`
### Current Results
### Expected Behavior
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10, but all.
- OpenRefine: v3.4 and maybe less…
### Additional context
PR #4867 will implement the fix
|
https://github.com/OpenRefine/OpenRefine/issues/4868
|
https://github.com/OpenRefine/OpenRefine/pull/4867
|
0d7e9c9b2e3acb99cbe486b699f34abfcad4b432
|
250660844938216ff1649fe40f7aa33e83018602
| 2022-05-19T05:18:20Z |
java
| 2022-05-19T14:14:29Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,864 |
["main/src/com/google/refine/exporters/OdsExporter.java", "main/tests/server/src/com/google/refine/exporters/OdsExporterTests.java"]
|
ODS exporter adds an additonal empty sheet to the project
|
The ODF exporter creates files with two sheets: the first is empty, and the second contains the project data. We should remove the first one.
### To Reproduce
Steps to reproduce the behavior:
1. First, export any project to ODF
2. Then, open it (for instance with LibreOffice)
### Current Results
The exported file contains two sheets, the first one being empty.
### Expected Behavior
The exported file should contain a single sheet with the project data.
### Versions<!-- (please complete the following information)-->
- Operating System: Debian
- JRE or JDK Version: 11
- OpenRefine: 3.6-SNAPSHOT
### Datasets
Example exported file: [Clipboard.ods](https://github.com/OpenRefine/OpenRefine/files/8716506/Clipboard.ods)
### Additional context
Similar to #4738
|
https://github.com/OpenRefine/OpenRefine/issues/4864
|
https://github.com/OpenRefine/OpenRefine/pull/4900
|
15737f90172a9e386b119d8e65e3b9f70a7c8ada
|
b84c01f658b3204cdb30fec3bdf7ccd8038d6628
| 2022-05-18T13:15:20Z |
java
| 2022-07-04T11:45:51Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,847 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/module/scripts/dialogs/wikibase-dialog.js"]
|
"manifest.version should match pattern "^1\.[0-9]+$"" error for 'Commons manifest version 2.0
|
The regex should be changed to ^[1-9]{1,3}\.[0-9]+$, the current version of the Wikimedia Commons manifest is 2.0, and thus creates this error.
Secondly: there should be a space and not a period in its error message.
### To Reproduce
Steps to reproduce the behavior:
1. Go to the Wikibase schema
2. The "Wikidata" dropdown in the top-right corner, pick "Select Wikibase instance"
3. "Add Wikibase" option
3. [Wikimedia Commons wikibase manifest](https://raw.githubusercontent.com/OpenRefine/wikibase-manifests/master/wikimedia-commons-manifest.json), either copy it or put in this URL
4. "manifest.version should match pattern "^1\.[0-9]+$""
### Current Results
Unable to add Wikimedia Commons as a Wikibase Instance
### Expected Behavior
Not this error.
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 11
- Browser Version: Chrome 101.0.4951.54
- JRE or JDK Version: java version "1.8.0_331"
Java(TM) SE Runtime Environment (build 1.8.0_331-b09)
Java HotSpot(TM) 64-Bit Server VM (build 25.331-b09, mixed mode)
- OpenRefine: Version 3.5.2 [e3efd4e]
### Additional context
As a side note: "manifests for some public Wikibases can be found [here](https://github.com/OpenRefine/wikibase-manifests)" should be changed to "See the overview of [public Wikibases manifests](https://github.com/OpenRefine/wikibase-manifests)". Read more about [why you shouldn't label links with "click here"](https://www.w3.org/QA/Tips/noClickHere)
|
https://github.com/OpenRefine/OpenRefine/issues/4847
|
https://github.com/OpenRefine/OpenRefine/pull/4941
|
43f3137f877962f4ceff68d252caefa97d3da963
|
2b5920b13b001a0a9797a497e30cb05f48277e36
| 2022-05-12T13:08:29Z |
java
| 2022-06-09T09:13:45Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,838 |
["main/src/com/google/refine/importers/ExcelImporter.java", "main/tests/server/src/com/google/refine/importers/ExcelImporterTests.java", "main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/index/parser-interfaces/excel-parser-ui.html", "main/webapp/modules/core/scripts/index/parser-interfaces/excel-parser-ui.js"]
|
Option to render non-text Excel cells as text when importing
|
It would be easier if OpenRefine offered an option to parse all cells as text when importing Excel files, as it does with csv files. When refining e.g. publication dates, the default behaviour of parsing digit characters in Excel files as numbers can lead to unwanted results and is cumbersome to fix.
### Proposed solution
Offer the option to leave a checkbox "Parse cell text into numbers, dates, ..." unchecked at import, as with csv files.
### Alternatives considered
All Excel files could be converted to csv files before importing them into OpenRefine.
### Additional context
|
https://github.com/OpenRefine/OpenRefine/issues/4838
|
https://github.com/OpenRefine/OpenRefine/pull/5397
|
be4cde353599a241da9043d6ca42f8ed74a537b1
|
08e2bd9bdde5257e557b8f5ea028dc39d19c5e9d
| 2022-05-10T06:36:35Z |
java
| 2022-11-21T12:36:04Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,821 |
["main/webapp/modules/core/scripts/util/dialog.js", "main/webapp/modules/core/scripts/views/data-table/cell-recon-search-for-match.html", "main/webapp/modules/core/scripts/views/data-table/cell-ui.js"]
|
'Search for match' dialog: search dropdown mostly covers 'Don't reconcile cell' button, and fully covers 'Cancel' button
|
During the (Wikidata) reconciliation process... In the 'Search for match' dialog window that is displayed when searching for a match, the search dropdown mostly covers 'Don't reconcile cell' button, and fully covers 'Cancel' button
### To Reproduce
Steps to reproduce the behavior:
1. Reconcile a column in your dataset (I have only seen the behavior when reconciling against Wikidata)
2. Find an unreconciled value (or any value really) and click 'Search for match'
3. In the 'Search for match' pop up dialog, when I search for the thing, my 'Don't reconcile cell' button is almost fully covered and the 'Cancel' button is fully covered. In many cases (usually when no reconciled entity is found) I want to choose 'Don't reconcile' and then I need to do some precision clicking, which shouldn't be necessary. I can imagine that, in some cases, the user may just want to cancel the operation too.
Maybe the UI for this operation can be improved so that the buttons are not covered by the search dropdown anymore.
### Expected Behavior
Buttons should remain visible.
### Screenshots
Clicking 'Choose new match':
Sad face
### Versions<!-- (please complete the following information)-->
- Operating System: MacOS 10.13.6
- Browser Version: Chrome 100.0.4896.127 (Official Build) (x86_64)
- JRE or JDK Version: n/a?
- OpenRefine: 3.6-SNAPSHOT [b0f3282]
### Datasets
Any with Wikidata reconciliation going on :-)
|
https://github.com/OpenRefine/OpenRefine/issues/4821
|
https://github.com/OpenRefine/OpenRefine/pull/4945
|
abab670399924daf2222b366e078b758f6192d80
|
5e698f2cd62f0f52a445eed22ee3ce615f8c9b66
| 2022-04-29T20:35:20Z |
java
| 2022-06-15T09:26:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,819 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/module/scripts/dialogs/wikibase-dialog.js", "extensions/wikidata/module/scripts/schema-alignment-tab.html", "extensions/wikidata/module/scripts/schema-alignment.js", "extensions/wikidata/module/scripts/wikibase-manager.js", "extensions/wikidata/module/styles/schema-alignment.less", "main/tests/cypress/cypress/integration/extensions/wikidata/layout.spec.js", "main/tests/cypress/cypress/integration/extensions/wikidata/select_wikibase_instance.spec.js", "main/tests/cypress/cypress/support/ext_wikidata.js"]
|
Selection of Wikibase instance directly in the schema editor
|
Our Wikibase schema editor currently looks like this:
This has a few problems:
* the currently selected Wikibase instance is not very well identifiable, because it is just mentioned in passing in a big blob of text
* the big blob of text may be read the first time, but then it is really just taking up space on the screen
* the way to change the Wikibase instance is not obvious
### Proposed solution
@lozanaross proposed the following design (from [this series of wireframes developed for the Wikimedia Commons integration project](https://upload.wikimedia.org/wikipedia/commons/2/2e/Structured_Data_on_Commons_file_upload_in_OpenRefine_-_wireframes_draft_v2.pdf)):
(disregard the schema template part: that is for a separate issue).
Note also the change of layout for the buttons on the right-hand side, which also makes sense to me.
I am not sure if the explanations removed in the process should be displayed elsewhere or if we can remove them entirely.
### Alternatives considered
None
### Additional context
Design proposed for the Wikimedia Commons integration project.
|
https://github.com/OpenRefine/OpenRefine/issues/4819
|
https://github.com/OpenRefine/OpenRefine/pull/5288
|
9e949d9401e202c3db5d81919d75c21f0df5ce89
|
b02cce870a655d78b7b40953e34c1d71848fecfa
| 2022-04-29T12:05:18Z |
java
| 2022-10-05T20:11:19Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,818 |
["extensions/wikidata/src/org/openrefine/wikidata/qa/EditInspector.java"]
|
Verbose log output when using a Wikibase without quality constraints extension
|
When using OpenRefine with a Wikibase instance which does not use WikibaseQualityConstraints (the constraint system deployed for instance on Wikidata), we currently get many warnings in the logs every time the schema is previewed.
### To Reproduce
Steps to reproduce the behavior:
1. First, install a wikibase instance that is not wikidata
2. Then, create a schema
3. Finally, observe the logs
### Current Results
```
13:17:15.240 [ refine] POST /command/wikidata/preview-wikibase-schema (21ms)
13:17:15.242 [..kidata.qa.EditInspector] scrutinizer [FormatScrutinizer] is skipped due to missing necessary constraint configurations in the Wikibase manifest (2ms)
13:17:15.243 [..kidata.qa.EditInspector] scrutinizer [InverseConstraintScrutinizer] is skipped due to missing necessary constraint configurations in the Wikibase manifest (1ms)
13:17:15.243 [..kidata.qa.EditInspector] scrutinizer [UnsourcedScrutinizer] is skipped due to missing necessary constraint configurations in the Wikibase manifest (0ms)
13:17:15.243 [..kidata.qa.EditInspector] scrutinizer [RestrictedPositionScrutinizer] is skipped due to missing necessary constraint configurations in the Wikibase manifest (0ms)
13:17:15.243 [..kidata.qa.EditInspector] scrutinizer [QualifierCompatibilityScrutinizer] is skipped due to missing necessary constraint configurations in the Wikibase manifest (0ms)
13:17:15.244 [..kidata.qa.EditInspector] scrutinizer [SingleValueScrutinizer] is skipped due to missing necessary constraint configurations in the Wikibase manifest (1ms)
13:17:15.244 [..kidata.qa.EditInspector] scrutinizer [QuantityScrutinizer] is skipped due to missing necessary constraint configurations in the Wikibase manifest (0ms)
13:17:15.244 [..kidata.qa.EditInspector] scrutinizer [RestrictedValuesScrutinizer] is skipped due to missing necessary constraint configurations in the Wikibase manifest (0ms)
13:17:15.244 [..kidata.qa.EditInspector] scrutinizer [EntityTypeScrutinizer] is skipped due to missing necessary constraint configurations in the Wikibase manifest (0ms)
13:17:15.244 [..kidata.qa.EditInspector] scrutinizer [MultiValueScrutinizer] is skipped due to missing necessary constraint configurations in the Wikibase manifest (0ms)
13:17:15.245 [..kidata.qa.EditInspector] scrutinizer [DifferenceWithinRangeScrutinizer] is skipped due to missing necessary constraint configurations in the Wikibase manifest (1ms)
13:17:15.245 [..kidata.qa.EditInspector] scrutinizer [ConflictsWithScrutinizer] is skipped due to missing necessary constraint configurations in the Wikibase manifest (0ms)
13:17:15.245 [..kidata.qa.EditInspector] scrutinizer [ItemRequiresScrutinizer] is skipped due to missing necessary constraint configurations in the Wikibase manifest (0ms)
13:17:15.245 [..kidata.qa.EditInspector] scrutinizer [UseAsQualifierScrutinizer] is skipped due to missing necessary constraint configurations in the Wikibase manifest (0ms)
```
### Expected Behavior
Those log messages should not be shown. We could obtain this behaviour by changing the log level to `DEBUG` instead of `INFO`.
### Versions<!-- (please complete the following information)-->
- OpenRefine: master branch
|
https://github.com/OpenRefine/OpenRefine/issues/4818
|
https://github.com/OpenRefine/OpenRefine/pull/4825
|
db0371bdcf46436dc54ea867ae7a1f54baf8991b
|
7be724927fc418295195ff649617d8331d661e12
| 2022-04-29T11:23:15Z |
java
| 2022-05-02T15:29:02Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,787 |
["extensions/wikidata/module/scripts/schema-alignment.js"]
|
Bug while uploading edits to Wikidata
|
Bug that I found while making a public demo:
```
16:47:42.115 [..mWikibaseEditsOperation] Performing edits (199ms)
16:47:42.141 [..ting.EditBatchProcessor] Requesting documents (26ms)
Exception in thread "Thread-14" java.lang.ClassCastException: class org.openrefine.wikidata.updates.MediaInfoEdit cannot be cast to class org.openrefine.wikidata.updates.ItemEdit (org.openrefine.wikidata.updates.MediaInfoEdit and org.openrefine.wikidata.updates.ItemEdit are in unnamed module of loader edu.mit.simile.butterfly.ButterflyClassLoader @1ab13761)
at org.openrefine.wikidata.editing.ReconEntityRewriter.rewrite(ReconEntityRewriter.java:165)
at org.openrefine.wikidata.editing.EditBatchProcessor.performEdit(EditBatchProcessor.java:151)
at org.openrefine.wikidata.operations.PerformWikibaseEditsOperation$PerformEditsProcess.run(PerformWikibaseEditsOperation.java:262)
at java.base/java.lang.Thread.run(Thread.java:829)
```
Not sharing more details now because I intend to work on it soon.
|
https://github.com/OpenRefine/OpenRefine/issues/4787
|
https://github.com/OpenRefine/OpenRefine/pull/4794
|
dd6fb9b020cbe35295a3387403b92e61867faa16
|
b0f328209a6949ffe8abf1cf9588c3306f627141
| 2022-04-21T15:07:56Z |
java
| 2022-04-29T12:17:22Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,738 |
["main/src/com/google/refine/exporters/OdsExporter.java", "main/tests/server/src/com/google/refine/exporters/OdsExporterTests.java"]
|
The exported file is inconsistent with the original
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
### To Reproduce
Steps to reproduce the behavior:
1. First, import any ods file(such as A.ods) and create project
2. Then, export this ods project to ODF spreadsheet(A-ods.ods)
3. Finally, import the A-ods.ods, and this ods file is different from the original one
### Current Results
<!-- What results occurred or were shown. -->
1. create the project and export to ODF spreadsheet
2. import the ods files that exported
3. is different with original one
### Expected Behavior
<!-- A clear and concise description of what you expected to happen or to show. -->
same with original file
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: <!-- e.g. iOS, Windows 10, Linux, Ubuntu 18.04 --> Ubuntu 18.04
- Browser Version: <!-- e.g. Chrome 19, Firefox 61, Safari, NOTE: OpenRefine does not support IE but works OK in most cases -->Chromium Version 100.0.4896.75 (Official Build) snap (64-bit)
- JRE or JDK Version: <!-- output of "java -version" e.g. JRE 1.8.0_181 -->OpenJDK 11
- OpenRefine: <!-- e.g. OpenRefine 3.0 Beta] -->OpenRefine 3.6
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
the original files :
[Sample.ods](https://github.com/OpenRefine/OpenRefine/files/8465447/Sample.ods)
After export :
[Sample-ods.ods](https://github.com/OpenRefine/OpenRefine/files/8465453/Sample-ods.ods)
### Additional context
<!-- Add any other context about the problem here. -->
The content of the original file seems to be in a different sheet and moved down by 3 lines as a whole
|
https://github.com/OpenRefine/OpenRefine/issues/4738
|
https://github.com/OpenRefine/OpenRefine/pull/4767
|
46d1f7b701c27922279653fcd5b4e47e0652b3ae
|
11127dab8a432d8273630ed1dcd2711ade81ccc8
| 2022-04-11T15:31:49Z |
java
| 2022-05-18T13:17:01Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,735 |
["main/src/com/google/refine/LookupCacheManager.java", "main/src/com/google/refine/util/HttpClient.java", "main/src/com/google/refine/util/LookupException.java", "server/src/com/google/util/logging/IndentingLayout.java", "server/src/com/google/util/threads/ThreadPoolExecutorAdapter.java"]
|
All Lincense Headers should be on top of package not inside package
|
### Feature Request
I am proposing this change in our code base, All linces Headers should come on top of package, this is to fix is really very small but it brings the aspect of clean code. Let me hear from your suggestions.
|
https://github.com/OpenRefine/OpenRefine/issues/4735
|
https://github.com/OpenRefine/OpenRefine/pull/4736
|
88c46768dfa796441a62b050cc35b39cb955de15
|
5b2c9ef3b26823a014e5498e2652db6e858a1a42
| 2022-04-11T04:38:34Z |
java
| 2022-04-12T10:22:27Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,727 |
[".github/workflows/snapshot_release.yml"]
|
Snapshot releases (Mac and Linux versions) on MacOS are not properly loading
|
When opening the Mac OS (.dmg) snapshot release, it doesn't load OpenRefine any further than the logo, as seen in this screenshot:
When I try with the Linux download, that one doesn't even open a new browser tab at all.
### Expected Behavior
OpenRefine should fully load.
### Context
Terminal log when trying to start the MacOS .dmg (pretty minimal):
```
Sandras-MacBook-Air:~ fokky$ /Applications/OpenRefine\ snapshot\ 20220408.app/Contents/MacOS/JavaAppLauncher ; exit;
08:15:29.649 [ refine_server] Starting Server bound to '127.0.0.1:3333' (0ms)
08:15:29.717 [ refine_server] Initializing context: '/' from '/Applications/OpenRefine snapshot 20220408.app/Contents/Resources/webapp' (68ms)
08:15:31.931 [ refine] Starting OpenRefine 3.6-SNAPSHOT [0ba3b92]... (2214ms)
08:15:31.937 [ refine] initializing FileProjectManager with dir (6ms)
08:15:31.937 [ refine] /Users/fokky/Library/Application Support/OpenRefine (0ms)
```
When I try to open the Linux version of the snapshot release, that one doesn't even start up a new browser tab. Terminal log for that one is:
```
miniMac:~ fokky$ /Users/fokky/Desktop/openrefine-3.6-SNAPSHOT\ 3/refine ; exit;
Using refine.ini for configuration
cat: refine.ini: No such file or directory
-------------------------------------------------------------------------------------------------
You have 812M of free memory.
Your current configuration is set to use 1024M of memory.
OpenRefine can run better when given more memory. Read our FAQ on how to allocate more memory here:
https://docs.openrefine.org/manual/installing#increasing-memory-allocation
-------------------------------------------------------------------------------------------------
ls: server/target/lib: No such file or directory
\nCould not find Maven locally, starting download for Maven ...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 8469k 100 8469k 0 0 10.7M 0 --:--:-- --:--:-- --:--:-- 10.7M
/Users/fokky/Desktop/openrefine-3.6-SNAPSHOT 3/refine: line 294: cd: main/webapp: No such file or directory
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.300 s
[INFO] Finished at: 2022-04-10T09:26:43+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] The goal you specified requires a project to execute but there is no POM in this directory (/Users/fokky/Desktop). Please verify you invoked Maven from the correct directory. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MissingProjectException
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.426 s
[INFO] Finished at: 2022-04-10T09:26:47+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] The goal you specified requires a project to execute but there is no POM in this directory (/Users/fokky/Desktop). Please verify you invoked Maven from the correct directory. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MissingProjectException
Error: Could not find or load main class com.google.refine.Refine
Caused by: java.lang.ClassNotFoundException: com.google.refine.Refine
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.
[Process completed]
```
### Versions<!-- (please complete the following information)-->
- Operating System: MacOS 10.13.6, MacOS 12.2.1
- Browser Version: Chrome
- JRE or JDK Version: n/a?
- OpenRefine: 3.6 snapshot release
### Files used
I just tried with the April 8 and April 10 snapshot releases, but the problem has been around for longer (several weeks?).
I heard from a Linux user (via the Structured Data on Commons Telegram group) that they have the same issue of OpenRefine snapshot releases not loading for them.
|
https://github.com/OpenRefine/OpenRefine/issues/4727
|
https://github.com/OpenRefine/OpenRefine/pull/4748
|
6b9387f04d8effaa49358677735ee1a4354fb78a
|
6ac025189dcfd5ec47d19a72ef035546d96ff62b
| 2022-04-10T07:30:38Z |
java
| 2022-04-13T07:28:07Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,722 |
["main/webapp/modules/core/scripts/reconciliation/standard-service-panel.js"]
|
« Auto-match candidates with high confidence » is deceitful and should not be pre-check
|
In the Reconciliation dialog, the checkbox « Auto-match candidates with high confidence » is pre-checked when entering the dialog.
Since the confidence from the Recon service is not always useful (it can say 100% to many items even when some should be defraded, user don't really know what the number means and exactly how it is given). Because of that, I think the checkbox should be un-cheked by default. A preference could be create to control the default value of that control.
Since this has a direct impact on data pushed to Wikidata, and I highly raise the possibility of bad data being pushed, I consider this a bug.
### To Reproduce
Steps to reproduce the behavior:
1. Open the reconciliation dialog
### Current Results
The checkbox « Auto-match candidates with high confidence » is pre-checked.
### Expected Behavior
The checkbox « Auto-match candidates with high confidence » is unchecked when opening the dialog.
### Screenshots
### Versions
- Operating System: N/A
- OpenRefine: v3.5.x and below.
|
https://github.com/OpenRefine/OpenRefine/issues/4722
|
https://github.com/OpenRefine/OpenRefine/pull/5733
|
55fdd752f9f6903aa9e0fbf4229b4742615847a5
|
69e1db6362c48e367f31eb4bd84cb783884c1373
| 2022-04-09T00:07:19Z |
java
| 2023-03-28T18:16:38Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,694 |
["server/src/com/google/refine/Refine.java"]
|
InterruptedException Ignored When Stopping the Servelet
|
On line 255 of Refine.java file located at /server/src/com/google/refine/Refine.java the caught InterruptedException is ignored as shown below.
InterruptedExceptions should never be ignored in the code. The throwing of the InterruptedException clears the interrupted state of the Thread, so if the exception is not handled properly the information that the thread was interrupted will be lost.
Instead, InterruptedExceptions should either be rethrown - immediately or after cleaning up the method’s state - or the thread should be re-interrupted.
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
|
https://github.com/OpenRefine/OpenRefine/issues/4694
|
https://github.com/OpenRefine/OpenRefine/pull/4734
|
386e1d90428e83cfbaef921753cfbc1c5d46435b
|
ce79221f12d33196d0d35a6150d9e29aa76a1e6f
| 2022-04-04T16:09:02Z |
java
| 2022-04-12T16:29:32Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,675 |
["docs/docs/technical-reference/build-test-run.md"]
|
Technical Docs for our Server tests setup with TestNG are outdated
|
The download link in our docs for TestNG update URL is now out of date and some of the info in this section: https://docs.openrefine.org/technical-reference/build-test-run#testing-in-eclipse
There's good info to get and reuse some of it from their README.md file in their repo here:
https://github.com/cbeust/testng-eclipse
|
https://github.com/OpenRefine/OpenRefine/issues/4675
|
https://github.com/OpenRefine/OpenRefine/pull/4688
|
a5e1f358f1ce42619361225969ab75bf5ed1cc00
|
f0489975665c535f69d071651f47e9f15a30f717
| 2022-04-01T01:19:44Z |
java
| 2022-04-07T18:04:52Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,656 |
["docs/docs/manual/installing.md"]
|
Unclear documentation in "Set where data is stored" of installing section
|
**Problem 1**:
It is confusing where to find the workspace when first reading the user manual.
The reason is as below (screenshots below):
- The first appearance of the term "workspace directory" in section _Back up your data_ doesn't point to the correct section #**set-where-data-is-stored**, which now points to #where-is-data-stored.
- But **Set where data is stored** section's instruction is not clear enough.
- The clearest guidance to find the workspace is under section **Find the right place to install**
**Problem 2**: the default location of program files cannot be reached. As there is a space in the path, copying and pasting this path in the terminal with cd command gives
> string not in pwd: Application error.
`~/Library/Application Support/OpenRefine/`
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
### To Reproduce
Steps to reproduce the behavior:
1. First, go to [set where data is stored](https://docs.openrefine.org/manual/installing#set-where-data-is-stored)
2. Then, copy path and paste in the terminal.
### Current Results
<!-- What results occurred or were shown. -->
1. Cannot find workspace directory
2. Cannot locate the program directory using the path.
### Expected Behavior
<!-- A clear and concise description of what you expected to happen or to show. -->
1. Find program files in the web app.
2. Find program files in the local directory
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: <!-- e.g. iOS, Windows 10, Linux, Ubuntu 18.04 --> iOS
- Browser Version: <!-- e.g. Chrome 19, Firefox 61, Safari, NOTE: OpenRefine does not support IE but works OK in most cases --> Chrome 99
- JRE or JDK Version: <!-- output of "java -version" e.g. JRE 1.8.0_181 --> openjdk version "17.0.2"
- OpenRefine: <!-- e.g. OpenRefine 3.0 Beta] --> 3.5.2 [e3efd4e]
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/4656
|
https://github.com/OpenRefine/OpenRefine/pull/4663
|
f09b13636c7aac625bb3fbeaec2e3eacae34eb04
|
e80889c42815c8a110e225ed7c7fa3748b9808df
| 2022-03-29T11:21:52Z |
java
| 2022-04-03T05:08:55Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,645 |
["main/webapp/modules/core/scripts/views/data-table/cell-ui.js"]
|
OpenCorporates reconciliation endpoint incompatible with OpenRefine 3.6
|
Since #3731, the OpenCorporates reconciliation endpoint (https://opencorporates.com/reconcile) does not work correctly in OpenRefine.
### To Reproduce
Steps to reproduce the behavior:
1. First, reconcile some list of companies to OpenCorporates
2. Then, click one of the reconciliation candidates
### Current Results
You land on a 404 page because the slash characters in the URL are incorrectly escaped.
### Expected Behavior
Working URLs.
This could be achieved by:
* keeping the previous behaviour for services which do not declare any protocol version in their manifest (i.e. they are following 0.1)
* adjusting the specs (and OpenRefine's code) to specify in the templates whether escaping is expected or not (https://github.com/reconciliation-api/specs/issues/39)
### Versions<!-- (please complete the following information)-->
- OpenRefine: 3.6-SNAPSHOT
|
https://github.com/OpenRefine/OpenRefine/issues/4645
|
https://github.com/OpenRefine/OpenRefine/pull/4917
|
8cb2fec45dd90fda8ed9608c691f6bb8ed721cd2
|
c67ae736c80ca78fc1b368fc2e34eb21aaada046
| 2022-03-28T12:29:15Z |
java
| 2022-06-06T12:16:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,644 |
["refine"]
|
Invalid URL for downloading Maven while first building the project
|
On Mac, with no Maven installed, **./refine build** command throws an error:
tar: Error opening archive: Unrecognized archive format
Error: Error while expanding apache-maven-3.8.4-bin.tar.gz
I have found the issue is in the mvn_prepare() function in _refine_ script. The following URL no longer has a 3.8.4 folder, as the below screenshot. Instead, it has a 3.8.5 folder now. So changing 3.8.4 to 3.8.5 in the script will work.
` MVN_VERSION="3.8.4" `
` MVN_URL="https://dlcdn.apache.org/maven/maven-3/${MVN_VERSION}/binaries/apache-maven-${MVN_VERSION}-bin.tar.gz"`
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
### To Reproduce
Steps to reproduce the behavior:
1. First, git clone the project repo.
2. Then, follow the build steps like [How to build, test, and run](https://docs.openrefine.org/technical-reference/build-test-run#building-testing-and-running-openrefine-from-intellij-idea)
3. Finally, enter ./refine build command in the terminal.
### Current Results
<!-- What results occurred or were shown. -->
The project is not built successfully with no maven installed.
### Expected Behavior
<!-- A clear and concise description of what you expected to happen or to show. -->
The project should be built successfully.
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: <!-- e.g. iOS, Windows 10, Linux, Ubuntu 18.04 --> iOS
- Browser Version: <!-- e.g. Chrome 19, Firefox 61, Safari, NOTE: OpenRefine does not support IE but works OK in most cases --> Chrome 99
- JRE or JDK Version: <!-- output of "java -version" e.g. JRE 1.8.0_181 --> openjdk version "17.0.2"
- OpenRefine: <!-- e.g. OpenRefine 3.0 Beta] --> 3.5.2 [e3efd4e]
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/4644
|
https://github.com/OpenRefine/OpenRefine/pull/4653
|
c18a362b7a4098a9a7fb0de32c6c93d1667d13e7
|
4e0cfe5d6c0dc7c0ab704549a647deb307da5548
| 2022-03-28T09:13:08Z |
java
| 2022-03-30T07:22:19Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,640 |
["main/src/com/google/refine/expr/functions/strings/Replace.java"]
|
Add simple example of Regex usage to description of replace()
|
We currently have this description for GREL `replace()` function:
https://github.com/OpenRefine/OpenRefine/blob/083c7feba3b84d97ec884f3c2b38b6f1f0249640/main/src/com/google/refine/expr/functions/strings/Replace.java#L68
We should probably extend that last sentence to also say the Regex pattern should start and end with `/` or just include a simple example showing the Regex pattern usage , perhaps something simple like:
`value.replace(/\n/, " ")`
`value.replace(/\\n\\n/," ")`
and improve [our official reference docs](https://github.com/OpenRefine/OpenRefine/blob/master/docs/docs/manual/grelfunctions.md) for `replace()` as well regarding that.
|
https://github.com/OpenRefine/OpenRefine/issues/4640
|
https://github.com/OpenRefine/OpenRefine/pull/4641
|
5bfae756836cb95d8ff75964cf5625ba1872b94b
|
c18a362b7a4098a9a7fb0de32c6c93d1667d13e7
| 2022-03-26T01:41:01Z |
java
| 2022-03-30T07:19:41Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,631 |
["extensions/gdata/src/com/google/refine/extension/gdata/GoogleAPIExtension.java"]
|
Export to Google Drive and Sheets is broken
|
Export to Google Drive and Export to Google Sheets options give the following error when clicked when it should recognize if a user is logged in, or at least give the option to log in. (Seen on Brave, Chrome, and Edge):
|
https://github.com/OpenRefine/OpenRefine/issues/4631
|
https://github.com/OpenRefine/OpenRefine/pull/4635
|
1ef305152ffe755c207a342488d94fe17b953518
|
3cbb5b143df3caa6e50d5493a34cee3f12cbcf77
| 2022-03-23T05:59:38Z |
java
| 2022-03-29T08:23:32Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,628 |
["extensions/wikidata/module/scripts/dialogs/logged-in-dialog.html", "extensions/wikidata/module/scripts/dialogs/owner-only-consumer-login-dialog.html", "extensions/wikidata/module/scripts/dialogs/password-login-dialog.html", "extensions/wikidata/module/styles/dialogs/manage-account-dialog.less"]
|
Wikibase dialog buttons should be in the dialog footer
|
The buttons in the following Wikibase dialogs should be in the footer while the content that is currently in it should be either moved to the top or right above the footer:
|
https://github.com/OpenRefine/OpenRefine/issues/4628
|
https://github.com/OpenRefine/OpenRefine/pull/4630
|
2d4e382652ec894ebc28b57b133ce62ce859ff81
|
5bfae756836cb95d8ff75964cf5625ba1872b94b
| 2022-03-22T05:22:04Z |
java
| 2022-03-30T07:09:48Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,625 |
["main/src/com/google/refine/importing/ImportingUtilities.java", "main/tests/server/src/com/google/refine/importing/ImportingUtilitiesTests.java"]
|
Unable to create a project from a URL on Windows if the URL path contains ":" character
|
On Windows, creating a project from a URL that contains the colon ":" character in the URL path throws an error related to the naming of a temporary directory/file.
### To Reproduce
Steps to reproduce the behavior:
1. Create a new project from a URL as `protocol://domain/foo/:bar/foo`
2. Click on the Next button
3. An error message is displayed that states "Error uploading data illegal char <:> at index [...]" (see screenshot below)
### Current Results
An error message is displayed that states "Error uploading data illegal char <:> at index [...]". The project creation fails.
### Expected Behavior
The project should be created from a URL that contains a colon character or any other character that is valid in a URL.
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Chrome 99
- JRE or JDK Version: JRE 1.8.0_301
- OpenRefine: 3.5.2 [e3efd4e]
### Additional context
Creating a project from a URL containing a colon character seems to work fine on Linux and macOS.
|
https://github.com/OpenRefine/OpenRefine/issues/4625
|
https://github.com/OpenRefine/OpenRefine/pull/5787
|
5c69c56b1832738f917e48f93c240b67433ff450
|
fd5b0c2efaacd7a34a755e01201b7951f8f4555e
| 2022-03-20T15:07:55Z |
java
| 2023-04-18T06:25:16Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,622 |
["main/webapp/modules/core/styles/util/dialog.less"]
|
No spacing between ok/cancel buttons in Custom text/numeric dialogs
|
These dialogs don't have spacing between the ok/cancel buttons:
- Column->Facet->Custom text facet...
- Column->Facet->Custom numeric facet...
|
https://github.com/OpenRefine/OpenRefine/issues/4622
|
https://github.com/OpenRefine/OpenRefine/pull/4623
|
442d80fa21c96cba5297356b161fc73fb85dadcb
|
2cbdd6867675466471d65944d9e40b14864985aa
| 2022-03-19T06:40:59Z |
java
| 2022-03-19T08:07:13Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,606 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/index/default-importing-sources/import-from-web-form.html", "main/webapp/modules/core/scripts/index/default-importing-sources/sources.js", "main/webapp/modules/core/styles/index/default-importing-sources.less"]
|
Create project -> Web addresses -> add URL needs a remove button
|
The add URL menu under Create Project doesn't let users remove added URL rows
### Proposed solution
Add a trashcan button to added rows which allows users to remove rows:
|
https://github.com/OpenRefine/OpenRefine/issues/4606
|
https://github.com/OpenRefine/OpenRefine/pull/4609
|
89eda70f88df55ef7614628b0049ab19a76a280d
|
b02c0fbdf63a5854b96126fca12d4080a4acd734
| 2022-03-10T07:05:32Z |
java
| 2022-03-15T10:11:20Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,603 |
["docs/docs/manual/installing.md", "docs/versioned_docs/version-3.5/manual/installing.md"]
|
“Info.plist” is on a read-only volume and cannot be unlocked
|
I'm using the OpenRefine latest version on a Mac and couldn't follow the FAQ instructions to increase memory allocation. When I try to edit the “Info.plist” file, the following message appears:
<img width="678" alt="Screenshot 2022-03-09 at 20 06 15" src="https://user-images.githubusercontent.com/84020632/157525236-c4cd94a0-c5ac-4544-a6a4-999c7b119a82.png">
|
https://github.com/OpenRefine/OpenRefine/issues/4603
|
https://github.com/OpenRefine/OpenRefine/pull/4604
|
1ccdf5c12926ad3b7a1eecbaca40691a67aa948a
|
74664832d1291a7dc25b156d75998c1501929786
| 2022-03-09T20:09:44Z |
java
| 2022-03-10T05:23:47Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,600 |
["main/src/com/google/refine/io/FileProjectManager.java"]
|
Set more granular file permissions on workspace.json
|
The `workspace.json` file at the root of the OpenRefine workspace can contain sensitive information such as credentials.
### Proposed solution
To prevent this from being unnecessarily exposed, we could set more conservative file permissions, such that only the user running OpenRefine is able to read this file.
### Alternatives considered
Setting up some encryption for the preferences, but this would only provide an additional security guarantee if we ask the user for some password at runtime to decrypt it (otherwise the credentials required to decrypt it would also be available to an attacker in the same way).
|
https://github.com/OpenRefine/OpenRefine/issues/4600
|
https://github.com/OpenRefine/OpenRefine/pull/4601
|
2cbdd6867675466471d65944d9e40b14864985aa
|
b50244e9c614e9a7b7d581094bfe2b4f400a7f68
| 2022-03-09T17:25:33Z |
java
| 2022-03-19T08:45:15Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,593 |
["extensions/wikidata/pom.xml"]
|
Upgrade Wikidata-Toolkit to 0.13.1
|
We are currently relying on a custom snapshot of Wikidata-Toolkit, we should rather update to a freshly released version.
|
https://github.com/OpenRefine/OpenRefine/issues/4593
|
https://github.com/OpenRefine/OpenRefine/pull/4594
|
b50244e9c614e9a7b7d581094bfe2b4f400a7f68
|
5d7720678d49139831e2b55ab4b0ec95560ff33c
| 2022-03-05T18:27:30Z |
java
| 2022-03-19T09:06:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,590 |
["main/tests/cypress/cypress/integration/project/grid/column/edit-column/rename_remove_column.spec.js", "main/webapp/modules/core/scripts/views/data-table/menu-edit-column.js", "main/webapp/modules/core/scripts/views/data-table/rename-column.html"]
|
Rename column should use a normal dialog
|
The "Rename this column" option in column->Edit Column is using the browser popup:
### Proposed Solution
Make a new popup window for "Rename this column" similar to this one:
|
https://github.com/OpenRefine/OpenRefine/issues/4590
|
https://github.com/OpenRefine/OpenRefine/pull/4597
|
943bf3721173f642d819d0d647c95bd83aaee884
|
b79cb56ed72bc58be621a56ffb2ca3e6011bbfaa
| 2022-03-04T06:16:41Z |
java
| 2022-03-09T07:07:47Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,579 |
["main/webapp/modules/core/scripts/dialogs/sql-exporter-dialog.html"]
|
SQL Exporter Download dialog stretches across screen with Chrome/Edge browser
|
SQL Exporter's **Download** tab causes the dialog to fully expand on screen.
### To Reproduce
Steps to reproduce the behavior:
1. Open or create a small project
2. Then click Export -> SQL Exporter...
3. Finally click on **Download** tab
### Current Results
Dialog horizontal size is maximized across screen with Chrome and Edge. However, it appears to work normal in Firefox.
### Expected Behavior
Dialog should not expand when clicked on **Download** tab and instead stay same size as clicked on **Content** tab.
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 11
- Browser Version: Chrome and Edge latest
- JRE or JDK Version: embedded
- OpenRefine: OpenRefine 3.6 embedded Snapshot
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/4579
|
https://github.com/OpenRefine/OpenRefine/pull/4586
|
aa91aeabac8613ba43945c86f24242b932ffd22e
|
f39db7c05538b993880a3eef2b9f603103b45b93
| 2022-03-01T14:26:22Z |
java
| 2022-03-02T08:11:04Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,577 |
["extensions/wikidata/pom.xml"]
|
Wikimedia Commons batch edit stalls at 12%
|
I am performing a (rather simple) batch edit on Wikimedia Commons, in which I want to edit nearly 2,000 files. The batch upload stalls at 12%. (I've retried 3 consecutive times; always stalls at the same point. Last edited file can be seen in [the batch's Edit Group](https://editgroups-commons.toolforge.org/b/OR/a9e247ec31d/)).
### To Reproduce
See below for the dataset/project.
### Expected Behavior
Batch upload should continue. If something is going wrong, it would be great if I would see some understandable and actionable feedback why this is happening.
### Screenshots
Log (last lines - the 'We are editing too fast' warning has repeatedly appeared since starting the batch):
```
20:56:17.957 [..ting.EditBatchProcessor] Requesting documents (12041ms)
20:56:19.538 [..baseapi.WbEditingAction] We are editing too fast. Pausing for 5473 milliseconds. (1581ms)
20:56:25.311 [..baseapi.WbEditingAction] We are editing too fast. Pausing for 54 milliseconds. (5773ms)
20:56:30.596 [..baseapi.WbEditingAction] We are editing too fast. Pausing for 3416 milliseconds. (5285ms)
20:56:34.488 [..baseapi.WbEditingAction] We are editing too fast. Pausing for 2429 milliseconds. (3892ms)
20:56:49.745 [..baseapi.WbEditingAction] We are editing too fast. Pausing for 6173 milliseconds. (15257ms)
20:57:02.484 [..baseapi.WbEditingAction] We are editing too fast. Pausing for 5831 milliseconds. (12739ms)
20:57:17.914 [..baseapi.WbEditingAction] We are editing too fast. Pausing for 5405 milliseconds. (15430ms)
20:57:40.803 [..baseapi.WbEditingAction] We are editing too fast. Pausing for 1518 milliseconds. (22889ms)
20:57:50.428 [..ting.EditBatchProcessor] Requesting documents (9625ms)
Exception in thread "Thread-1" java.lang.IndexOutOfBoundsException: Index: 21
at java.base/java.util.Collections$EmptyList.get(Unknown Source)
at org.wikidata.wdtk.wikibaseapi.WbGetEntitiesAction.wbGetEntities(WbGetEntitiesAction.java:239)
at org.wikidata.wdtk.wikibaseapi.WbGetEntitiesAction.wbGetEntities(WbGetEntitiesAction.java:108)
at org.wikidata.wdtk.wikibaseapi.WikibaseDataFetcher.getEntityDocumentMap(WikibaseDataFetcher.java:404)
at org.wikidata.wdtk.wikibaseapi.WikibaseDataFetcher.getEntityDocuments(WikibaseDataFetcher.java:187)
at org.openrefine.wikidata.editing.EditBatchProcessor.prepareNewBatch(EditBatchProcessor.java:229)
at org.openrefine.wikidata.editing.EditBatchProcessor.performEdit(EditBatchProcessor.java:146)
at org.openrefine.wikidata.operations.PerformWikibaseEditsOperation$PerformEditsProcess.run(PerformWikibaseEditsOperation.java:245)
at java.base/java.lang.Thread.run(Unknown Source)
```
### Versions<!-- (please complete the following information)-->
- Operating System: Mac OS X 10.13.6
- Browser Version: Chrome 98.0.4758.109
- OpenRefine: 3.6-SNAPSHOT [353d562] (the February 20, 2022 snapshot release)
### Datasets
The OpenRefine project is:
[public-art-Belgium.openrefine.tar.gz](https://github.com/OpenRefine/OpenRefine/files/8156425/public-art-Belgium.openrefine.tar.gz)
|
https://github.com/OpenRefine/OpenRefine/issues/4577
|
https://github.com/OpenRefine/OpenRefine/pull/4594
|
b50244e9c614e9a7b7d581094bfe2b4f400a7f68
|
5d7720678d49139831e2b55ab4b0ec95560ff33c
| 2022-02-28T20:11:39Z |
java
| 2022-03-19T09:06:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,568 |
["packaging/apple_certs/README", "packaging/apple_certs/codesign.sh", "packaging/apple_certs/libjffi-1.2.jnilib", "packaging/pom.xml"]
|
Dependency to Jython-standalone prevents us from signing our MacOS package
|
The fact that we depend on the `jython-standalone` distribution prevents us from signing our MacOS package and notarizing it with Apple.
### To Reproduce
Check the CI logs here:
https://github.com/OpenRefine/OpenRefine/runs/5335255475?check_suite_focus=true
### Current Results
When notarizing our DMG build, we get the following errors:
```
[INFO] [exec] "issues": [
[INFO] [exec] {
[INFO] [exec] "severity": "error",
[INFO] [exec] "code": null,
[INFO] [exec] "path": "openrefine-mac-3.6-SNAPSHOT.dmg/OpenRefine.app/Contents/Resources/webapp/extensions/jython/module/MOD-INF/lib/jython-standalone-2.7.2.jar/jni/Darwin/libjffi-1.2.jnilib",
[INFO] [exec] "message": "The binary uses an SDK older than the 10.9 SDK.",
[INFO] [exec] "docUrl": null,
[INFO] [exec] "architecture": "i386"
[INFO] [exec] },
[INFO] [exec] {
[INFO] [exec] "severity": "error",
[INFO] [exec] "code": null,
[INFO] [exec] "path": "openrefine-mac-3.6-SNAPSHOT.dmg/OpenRefine.app/Contents/Resources/webapp/extensions/jython/module/MOD-INF/lib/jython-standalone-2.7.2.jar/jni/Darwin/libjffi-1.2.jnilib",
[INFO] [exec] "message": "The binary uses an SDK older than the 10.9 SDK.",
[INFO] [exec] "docUrl": null,
[INFO] [exec] "architecture": "x86_64"
[INFO] [exec] }
[INFO] [exec] ]
```
<!-- What results occurred or were shown. -->
### Expected Behavior
Successful notarization.
### Additional context
We might be able to switch to `jython-slim` which should also let us save some megabytes (but some additional dependencies are probably pulled in then)
### Funding available
The OpenRefine project has funding available to work on this. Do you know someone who would be able to get this fixed? Send them our way!
https://openrefine.org/blog/2022/09/30/windows-macos-packaging.html
|
https://github.com/OpenRefine/OpenRefine/issues/4568
|
https://github.com/OpenRefine/OpenRefine/pull/5456
|
16a6df8101fbdd5d05db4092ec0f589944c622ad
|
be4cde353599a241da9043d6ca42f8ed74a537b1
| 2022-02-25T15:37:41Z |
java
| 2022-11-21T08:43:12Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,566 |
["main/src/com/google/refine/importers/tree/TreeImportingParserBase.java", "main/tests/server/src/com/google/refine/importers/XmlImporterTests.java"]
|
Importing XML doesn't populate Import Options metadata
|
When importing an XML document in OpenRefine 3.5.2, the Import Options metadata does not get populated.
### To Reproduce
Create a new project the attached XML sample, use `item` as the first record.
### Current Results
Import option metadata is empty
### Expected Behavior
Import option metadata should contain filename, record path, and other data
### Versions
- Operating System: MacOS Big Sur 11.6.4
- Browser Version: Chrom 98.0.4758.102
- JRE or JDK Version: java version "13.0.2" 2020-01-14
- OpenRefine: OpenRefine 3.5.2
### Datasets
[sample.zip](https://github.com/OpenRefine/OpenRefine/files/8141418/sample.zip)
GitHub doesn't support directly uploading the XML file, so it's been zipped.
### Additional context
This may affect other importers than just XML.
|
https://github.com/OpenRefine/OpenRefine/issues/4566
|
https://github.com/OpenRefine/OpenRefine/pull/4567
|
a29040462fa7a6782f0074416bfe73325f0c4f4c
|
ab96af521dd4253208e99fe4c337971926752fba
| 2022-02-25T13:18:31Z |
java
| 2022-02-26T16:39:50Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,546 |
["main/webapp/modules/core/scripts/views/data-table/cell-ui.js"]
|
Invalid URL detection in cell UI
|
Sometimes the cell UI gets URL boundaries wrong.
### To Reproduce
Create a project and put the following string in a cell:
```
{{Information
|Description = {{en|1=<br>
:'''Species''' {{Species-inline|vernacular=Wood Duck|binominal=Aix sponsa}}
:'''Recordist''' Jonathon Jongsma
:'''Remarks''' Bird seen. Several widely-spaced and rather strange hoarse 'screams' from a female wood duck sitting about 15m directly above my head in a large cottonwood at the edge of an urban park pond. Recording quality is rather poor because all I had with me was a mobile phone.
:'''Bird seen''' yes
:'''Elevation''' 250 m
:'''Country''' United States}}
|Source = [http://www.xeno-canto.org/101287
|Author ](http://www.xeno-canto.org/101287|Author) = Jonathon Jongsma
|Date = 2012-05-10 07:53
|Permission =
|other_versions =
}}{{Location dec|44.942|-93.259}}
{{Xeno-canto}}
=={{int:license-header}}==
{{cc-by-sa-3.0}}
[[Category:Sound files uploaded by Fæ]]
[[Category:Xeno-canto]]
[[Category:Audio files of Aix sponsa]]
```
### Current Results
### Expected Behavior
The URL should not continue on the following line.
### Versions<!-- (please complete the following information)-->
- Operating System: irrelevant
- Browser Version: Firefox
- JRE or JDK Version: irrelevant
- OpenRefine: master branch
|
https://github.com/OpenRefine/OpenRefine/issues/4546
|
https://github.com/OpenRefine/OpenRefine/pull/4954
|
d4456021c381beb25aa3da24c474da4d4d50efde
|
af4167c6e1e84b671b2d4a6ccde494eca8f238e0
| 2022-02-18T07:14:38Z |
java
| 2022-06-12T13:47:27Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,540 |
["main/src/com/google/refine/commands/Command.java"]
|
Chevrons not rendered correctly in "undo" notification
|
Chevrons (`«»`) are not rendered correctly in the "undo" notification.
### To Reproduce
1. Run the "Replace smart quotes with ascii" common transform on a text column
2. Observe that the "undo" notification contains replacement characters instead of chevrons
### Current Results
Chevrons appear in the history list OK, but not in the "undo" notification, which times out and disappears.
### Expected Behavior
The chevrons should be accurately rendered in this modal.
### Screenshots
<img width="413" alt="image" src="https://user-images.githubusercontent.com/12046008/154407674-8b5eaf87-7eb7-4c4b-92d6-e1008251f365.png">
<img width="503" alt="image" src="https://user-images.githubusercontent.com/12046008/154406942-68695787-4810-4612-ba2d-8ca28e436ba3.png">
### Versions
- Operating System: macOS 12.1 (21C52)
- Browser Version: Safari 15.2 (17612.3.6.1.6)
- User-agent string: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.2 Safari/605.1.15"
- JRE or JDK Version: Sorry, I can't get this info immediately; if there is a separate fix for this issue or if my system is not set up correctly please let me know.
```
❯ which java
/usr/bin/java
~
❯ java --version
The operation couldn’t be completed. Unable to locate a Java Runtime.
Please visit http://www.java.com for information on installing Java.
```
- OpenRefine: 3.5.2 [e3efd4e]
### Datasets
I don't believe this is caused by my data but am happy to attach it here if doing so would help fix the bug.
Thanks
Hugh
|
https://github.com/OpenRefine/OpenRefine/issues/4540
|
https://github.com/OpenRefine/OpenRefine/pull/4710
|
bb765b42b321f35c99b99582bb07b8330cd4954e
|
9c5bde002e44e0fee4f7f124ad58d93eb7f57b52
| 2022-02-17T04:53:37Z |
java
| 2022-04-07T15:09:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,521 |
[".github/workflows/pull_request.yml", ".github/workflows/snapshot_release.yml", "packaging/pom.xml", "pom.xml"]
|
JREs downloaded at build time in Maven reactor
|
When doing `./refine build`, the JREs are downloaded, whereas this should only be done for packaging (`mvn package` or `./refine dist`).
This should be fixed.
|
https://github.com/OpenRefine/OpenRefine/issues/4521
|
https://github.com/OpenRefine/OpenRefine/pull/4524
|
879da1f2f0b30b4c507758e52807245568f96b7e
|
57c93d78355accd3c68204c3bd120f81ea816538
| 2022-02-12T07:21:44Z |
java
| 2022-02-12T21:39:52Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,511 |
["docs/docs/manual/installing.md", "packaging/pom.xml"]
|
Running OpenRefine on Windows without Java points to Oracle website
|
When running OpenRefine without Java on Windows, users are redirected to https://java.com/en/download/manual.jsp, which proposes to download Java 8. That is a bad idea, since OpenRefine 3.6 will not be compatible with Java 8 anymore (only Java 11+).
We should consider updating this link (if it is possible) and changing it to a user-friendly alternative.
|
https://github.com/OpenRefine/OpenRefine/issues/4511
|
https://github.com/OpenRefine/OpenRefine/pull/4563
|
ab96af521dd4253208e99fe4c337971926752fba
|
4b2e718bea14ba8b43e1a9dee2517278c933e2e5
| 2022-02-08T19:44:59Z |
java
| 2022-02-28T07:53:32Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,507 |
[".github/workflows/release/add_apple_keys.sh", ".github/workflows/snapshot_release.yml", "packaging/Entitlements.plist", "packaging/apple_certs/AppleWWDRCA.cer", "packaging/apple_certs/README", "packaging/apple_certs/apple_cert.cer.enc", "packaging/apple_certs/apple_cert.p12.enc", "packaging/pom.xml"]
|
Run MacOS packaging in CI, on MacOS
|
With our current setup, we can generate the `.dmg` artifact for MacOS on Linux, but it is not compressed, and the only way to compress it (as far as I know) is to do that inside a MacOS VM. Furthermore, we want to sign the MacOS build, and that can also not be done on another platform.
### Proposed solution
Our MacOS build should be generated inside the CI, by a runner running MacOS. We should take inspiration from [Gephi](https://github.com/gephi/gephi) for that.
### Alternatives considered
None
|
https://github.com/OpenRefine/OpenRefine/issues/4507
|
https://github.com/OpenRefine/OpenRefine/pull/4512
|
6b94bbbb61c16eabdbcb17e1de1a5cf08d9bc591
|
35dba769c7ffb1c13fa67dddc7b2c48ae0745456
| 2022-02-08T15:19:09Z |
java
| 2022-02-09T09:42:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,498 |
["main/tests/cypress/cypress/integration/project/undo_redo/extract.spec.js", "main/webapp/modules/core/scripts/project/history-extract-dialog.html", "main/webapp/modules/core/scripts/project/history-panel.js"]
|
Exporting 'Extract operation history' as JSON
|
Currently if I want to export the Extract Operation History list of actions, I manually copy paste the JSON and save as a .json file. Would it be possible to add an Export button with a traditional 'save as' dialog?
|
https://github.com/OpenRefine/OpenRefine/issues/4498
|
https://github.com/OpenRefine/OpenRefine/pull/4523
|
c878030916b11e4c3fc83a6c2186045f6f546371
|
879da1f2f0b30b4c507758e52807245568f96b7e
| 2022-02-03T11:42:01Z |
java
| 2022-02-12T20:20:02Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.