status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,664 |
["main/src/com/google/refine/util/HttpClient.java"]
|
Every other reconciliation batch fails in 3.5
|
With the current development version, every other reconciliation call fails with a `NoHttpResponseException`, apparently because it's attempting to reuse a closed connection.
### To Reproduce
Reconcile a project with more than 20-30 rows and observe that the console logs failures on every other call.
### Current Results
Every other batch fails with an HTTP error.
### Expected Behavior
All batches get reconciled
### Versions<!-- (please complete the following information)-->
- OpenRefine: current development version
|
https://github.com/OpenRefine/OpenRefine/issues/3664
|
https://github.com/OpenRefine/OpenRefine/pull/3875
|
e664712a701d61e1ec110ffb20285081426eb296
|
36589e5b1c771f71ae53c67ca99a35f03471c4fb
| 2021-02-23T02:52:05Z |
java
| 2021-05-15T06:52:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,652 |
["lgtm.yml"]
|
LGTM build is broken
|
The LGTM service seems to be running tests when it attempts to check our pull requests, but the database extension tests fail because the corresponding databases are unavailable.
We should fix this: it is not clear to me why we would need to run any tests on LGTM.
Example build:
https://lgtm.com/projects/g/OpenRefine/OpenRefine/logs/rev/pr-bbec6ee044d3fb9c1abb9fd4b5b3d13d306cb2be/lang:java/stage:Build%20merge_e3c15fda718be8292d9a43235ee79ed780070d29
|
https://github.com/OpenRefine/OpenRefine/issues/3652
|
https://github.com/OpenRefine/OpenRefine/pull/3675
|
57821867115778c86cec1fad912ba88ab01d047e
|
a4d3b5522ff465ff2d09de24b3dbebb3b9513e58
| 2021-02-18T17:52:37Z |
java
| 2021-02-28T00:22:41Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,633 |
["extensions/database/tests/conf/tests.xml"]
|
Database extension tests are not run
|
The backend tests for the database extension (support for SQL import/export) are not currently run, when running tests locally. In the CI, they are run (because we use a specific configuration file in that context).
It is good that tests requiring a database engine are not run by default (we do not want OpenRefine developers to have to run multiple database engines just to run the tests, especially if they are working on an independent aspect of the tool). But we should at least run the tests which do not rely on any such external database.
### To Reproduce
Run `./refine test` and observe that 0 tests are run for the database extension.
This is due to an incorrect configuration file for the test suite, which I seem to be responsible for. Oops.
|
https://github.com/OpenRefine/OpenRefine/issues/3633
|
https://github.com/OpenRefine/OpenRefine/pull/3634
|
9b7bbc3c737021ffc22dcd67ab3bc3d94aeef06e
|
c68507b0dc9899855060d1e7c52041ae2540c490
| 2021-02-14T14:58:01Z |
java
| 2021-02-15T18:01:58Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,608 |
["extensions/gdata/licenses/gdata-java-client.LICENSE.txt", "extensions/gdata/licenses/javamail/COPYRIGHT.txt", "extensions/gdata/licenses/javamail/LICENSE.txt", "extensions/gdata/licenses/javamail/README.txt"]
|
remove /javamail folder and files no longer needed
|
On the [mailing list discussion](https://groups.google.com/d/msgid/openrefine-dev/CAChbWaNWKPuec59kdQjwsNObn7_WTzCmBzEojGTOBkb5zgbyGg%40mail.gmail.com?utm_medium=email&utm_source=footer) @thadguidry stated:
>Unless I missed something in the dependency tree...
>I don't see why we still need to keep the /javamail folder and files inside it for the gdata extension any longer?
>https://github.com/OpenRefine/OpenRefine/tree/master/extensions/gdata/licenses
@tfmorris replied:
> Yes, they should have been removed in September 2018 along with the associated files (782ae4e788941a3b111b13e9639b9765f24cbcf5).
>Please create a ticket in the issue tracker.
|
https://github.com/OpenRefine/OpenRefine/issues/3608
|
https://github.com/OpenRefine/OpenRefine/pull/3609
|
f2d2be135681e81d9f54db17d6e6e62b051c887e
|
ff0b81e0f08b0f99d5136c7e951a75258eb98daf
| 2021-02-10T20:58:27Z |
java
| 2021-02-10T21:15:48Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,604 |
["extensions/gdata/module/scripts/index/gdata-source-ui.js", "extensions/gdata/src/com/google/refine/extension/gdata/GoogleAPIExtension.java", "refine", "refine.bat", "refine.ini"]
|
Can't import public Google Sheet without logging in
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
Openrefine should import any publicly available google sheet without the need of g-API credentials
### To Reproduce
Steps to reproduce the behavior:
1. First, visit https://docs.google.com/spreadsheets/d/1_BY7R4cGZh1kPnwe89tFlMGdJSgEeemSHhyodNQGSBk
2. Then, import the above URL in openrefine through `Google Data` option
3. See an error
### Current Results
<!-- What results occurred or were shown. -->
```sh
19:29:34.784 [ refine] POST /command/core/importing-controller (46ms)
19:29:34.789 [ org.mortbay.log] /command/core/importing-controller (5ms)
java.lang.NullPointerException
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:878)
at com.google.api.client.util.Preconditions.checkNotNull(Preconditions.java:125)
at com.google.api.client.auth.oauth2.Credential$Builder.<init>(Credential.java:637)
at com.google.refine.extension.gdata.GoogleAPIExtension.getSheetsService(GoogleAPIExtension.java:160)
at com.google.refine.extension.gdata.GDataImportingController.getWorksheetEntriesForDoc(GDataImportingController.java:217)
at com.google.refine.extension.gdata.GDataImportingController.doInitializeParserUI(GDataImportingController.java:197)
at com.google.refine.extension.gdata.GDataImportingController.doPost(GDataImportingController.java:98)
at com.google.refine.commands.importing.ImportingControllerCommand.doPost(ImportingControllerCommand.java:68)
at com.google.refine.RefineServlet.service(RefineServlet.java:187)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1221)
at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:78)
at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:131)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399)
at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
### Expected Behavior
<!-- A clear and concise description of what you expected to happen or to show. -->
Openrefine should be able to import the above sheet
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
https://docs.google.com/spreadsheets/d/1_BY7R4cGZh1kPnwe89tFlMGdJSgEeemSHhyodNQGSBk
|
https://github.com/OpenRefine/OpenRefine/issues/3604
|
https://github.com/OpenRefine/OpenRefine/pull/3611
|
8b459d69e3538539bbe2d2fd50ba36bf37768609
|
314dbb560d3d63aaa624a6071c30021c2bad9e00
| 2021-02-10T14:02:59Z |
java
| 2021-02-11T18:50:54Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,584 |
["main/tests/cypress/cypress/integration/project/grid/column/text_filter.spec.js"]
|
Build broken after the introduction of the UX test suite style checker
|
Since the introduction of the Cypress test suite style checker, our build fails on unrelated pull requests:
https://github.com/OpenRefine/OpenRefine/runs/1836757675
It would be good to fix the linting of the existing code or disable this check.
|
https://github.com/OpenRefine/OpenRefine/issues/3584
|
https://github.com/OpenRefine/OpenRefine/pull/3593
|
fb248495f14a4df4b57f981db0eb557b61ccec7a
|
382c030a7c8d8ffed2bd3f2c6717c74f5e7204af
| 2021-02-05T07:40:02Z |
java
| 2021-02-07T20:27:12Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,578 |
["main/webapp/modules/core/langs/translation-cs.json", "main/webapp/modules/core/langs/translation-de.json", "main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/langs/translation-es.json", "main/webapp/modules/core/langs/translation-id.json", "main/webapp/modules/core/langs/translation-it.json", "main/webapp/modules/core/langs/translation-jp.json", "main/webapp/modules/core/langs/translation-pt.json", "main/webapp/modules/core/langs/translation-pt_BR.json", "main/webapp/modules/core/langs/translation-sv.json"]
|
Fix help and documentation for record variables
|
The current help for the `record` variable in the web client points to https://github.com/OpenRefine/OpenRefine/wiki/Variables#record, but that's just a stub that includes a generic link to the top level of the user manual.
It could be updated to point to https://docs.openrefine.org/manual/expressions#record, but it would be better to just include the documentation in the help, like everything else except the `record` variable.
Also, the manual's documentation could use improvement. For `row.record.cells` it says "The cells of the row" when it's a slice of cells from the record for the given column.
|
https://github.com/OpenRefine/OpenRefine/issues/3578
|
https://github.com/OpenRefine/OpenRefine/pull/4550
|
29607c5ad178f878ad90e333669549be6b9327b5
|
bb0ee48949d505fbba34e73f9e7335d0920e740b
| 2021-02-04T19:52:24Z |
java
| 2022-02-19T07:49:39Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,571 |
[".github/workflows/pull_request.yml"]
|
Pull request workflow should test the merged pull request, not the branch
|
It seems that our GitHub Actions workflow to test pull requests is checking out the branch that the PR intends to merge, without generating the merge commit (which includes further changes on master).
We should fix this, using one of these options:
* fix the `checkout` action to use the correct commit id
* go back to the `pull_request` event and the default checkout options for it (requires not relying on secrets)
* configure the GitHub project to only make PRs mergeable when they are up to date with master (this adds a button on the PRs to generate these merge commits automatically).
|
https://github.com/OpenRefine/OpenRefine/issues/3571
|
https://github.com/OpenRefine/OpenRefine/pull/3585
|
193d3c888c76e165f14ba54eafb3ea31d64fa5f5
|
7e0f14f95ae3139fb0359156cca8eed2986620b9
| 2021-02-04T13:52:24Z |
java
| 2021-02-05T11:28:06Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,553 |
["main/tests/cypress/cypress/integration/project/grid/column/edit-cells/common-transforms/Replace-Smart-quotes-with-ascii.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/edit-cells/common-transforms/to-empty-string.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/edit-cells/common-transforms/to-lowercase.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/edit-cells/common-transforms/to-null.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/edit-cells/common-transforms/to-text.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/edit-cells/common-transforms/to-titlecase.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/edit-cells/common-transforms/to-uppercase.spec.js"]
|
Add UX Test for column / Edit cells / Common transforms
|
This issue is following the work implemented for issue #3423 in [PR 3541](https://github.com/OpenRefine/OpenRefine/pull/3541)
The goal is to cover all functionalities under column / edit cells / common transforms
### Proposed solution
Write the remaining tests for
- Convert Smart quotes with ascii
- to titlecase
- to uppercase
- to lowercase
- to text
- to null
- to empty string
|
https://github.com/OpenRefine/OpenRefine/issues/3553
|
https://github.com/OpenRefine/OpenRefine/pull/3683
|
b5192327495aaee18c64a8a0eb8f70aae5adadb7
|
9760380150dc9e74c55940e7fa08545c6f1b72a5
| 2021-02-02T08:21:30Z |
java
| 2021-03-04T12:51:03Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,532 |
[".github/workflows/pull_request.yml", "main/tests/cypress/cypress/integration/project/grid/column/sort.spec.js", "main/tests/cypress/cypress/integration/project/grid/viewpanel-header/sort.spec.js", "main/tests/cypress/cypress/support/openrefine_api.js", "main/tests/cypress/package.json"]
|
Add lint and styling workflow for cypress suite
|
<!-- Please provide a clear and concise description of your problem or unsatisfied needs. Ex. I'm always frustrated when [...] or, It would be easier if OpenRefine did [...]. This comment can be deleted, if desired, but it will be hidden in your final submission. Please make sure that your new text is outside the enclosing angle brackets. -->
### Proposed solution
<!-- If you have a proposal for how this need could be met, please provide a clear and concise description of what you want to happen. -->
### Alternatives considered
<!-- If there alternative solutions that you have considered or think should be considered, please list them here -->
### Additional context
<!-- Add any other context or screenshots about the feature request here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/3532
|
https://github.com/OpenRefine/OpenRefine/pull/3546
|
54f438721ed7adccb59a5e4af275fa5b217859ad
|
6750a45d53a46f0cd87072ec9458826a48e7fe36
| 2021-01-28T11:13:46Z |
java
| 2021-02-04T14:37:03Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,529 |
["docs/docusaurus.config.js"]
|
Add link checker to documentation CI
|
The dead links from #3524 are something that we should be able to catch by checking the links when running CI on the docs build.
W3C has an online checker here: http://validator.w3.org/checklink?uri=https%3A%2F%2Fdocs.openrefine.org%2F&hide_type=all&depth=&check=Check
but there are local utilities which can be used as well.
|
https://github.com/OpenRefine/OpenRefine/issues/3529
|
https://github.com/OpenRefine/OpenRefine/pull/3576
|
968378a39cdb7fb4f55d8600fa53412da3f8a8a6
|
1af0e06a41203377eebd13e2fe7948737311af44
| 2021-01-27T23:49:45Z |
java
| 2021-02-20T09:08:45Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,520 |
["main/webapp/modules/core/scripts/index/edit-metadata-dialog.js", "main/webapp/modules/core/styles/index/open-project-ui.less"]
|
Cannot edit project metadata
|
### To Reproduce
- Create a project that generates a lot of `Import option metadata (JSON)` . In the example below I created a project from 100 txt files.
- Once the project created, go back in `Open Project` and select `About` to edit the project metadata
- The `Import option metadata (JSON)` take the full screen.
- You cannot scroll up or down. You have to use the browser zoom to see other options.
### Expected Behavior
Allow the user to scroll up / down to edit metadata and save edits
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: ubuntu 18.04
- Browser Version: chrome and firefox
- OpenRefine: 3.4.1
### Datasets
Project creation from this zip file: [test.zip](https://github.com/OpenRefine/OpenRefine/files/5869061/test.zip)
OpenRefine project export: [1-txt.openrefine.tar.gz](https://github.com/OpenRefine/OpenRefine/files/5869024/1-txt.openrefine.tar.gz)
|
https://github.com/OpenRefine/OpenRefine/issues/3520
|
https://github.com/OpenRefine/OpenRefine/pull/4527
|
40cfe2f2b5fb8cdbc9a2a71af04cfc145c9d3943
|
ee551ab38a72d8d14f32192c2fcabbe3f8110775
| 2021-01-25T19:09:16Z |
java
| 2022-02-15T09:35:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,491 |
[".github/workflows/release_manager.sh"]
|
Improve snapshot workflow to avoid passing tokens via GET
|
Our snapshot release process currently passes access tokens by GET parameters, which generates the following warning from GitHub:
> Hi @wetneb,
>
> On January 12th, 2021 at 14:29 (UTC) your personal access token (GitHub action for OpenRefine nightlies) using curl/7.58.0 was used as part of a query parameter to access an endpoint through the GitHub API:
>
> https://api.github.com/repositories/236515399/releases
>
> Please use the Authorization HTTP header instead, as using the `access_token` query parameter is deprecated. If this token is being used by an app you don't have control over, be aware that it may stop working as a result of this deprecation.
>
> Depending on your API usage, we'll be sending you this email reminder on a monthly basis for each token and User-Agent used in API calls made on your behalf.
> Just one URL that was accessed with a token and User-Agent combination will be listed in the email reminder, not all.
>
> Visit https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param for more information about suggested workarounds and removal dates.
>
> Thanks,
> The GitHub Team
Therefore we should migrate to using a header instead. In addition, I have created a new GitHub account which has only access to the snapshot repository, so that the secret token does not come with more permissions in other repos.
|
https://github.com/OpenRefine/OpenRefine/issues/3491
|
https://github.com/OpenRefine/OpenRefine/pull/3492
|
4465bc4588dbb30ff7135fcd0ce3dfc0a11240b4
|
4fcb02fbd20d4cbc1fa2337b700bfb257969c989
| 2021-01-18T08:16:03Z |
java
| 2021-01-18T16:10:29Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,481 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/index.js"]
|
Unwanted symbol in project version metadata dialogue
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
Project about dialogue has a weird symbol ahead of its info in the metadata.
### To Reproduce
Steps to reproduce the behavior:
1. Create a project
2. Then, click on it's about tab
3. Finally, see the bug
### Current Results
<!-- What results occurred or were shown. -->
The weird symbol `$1` appears ahead of it
### Expected Behavior
<!-- A clear and concise description of what you expected to happen or to show. -->
No unwanted characters should be present
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
<img width="1388" alt="Screenshot 2021-01-16 at 11 01 59 PM" src="https://user-images.githubusercontent.com/44091822/104818678-11400100-584f-11eb-8743-7ba053fdd70a.png">
|
https://github.com/OpenRefine/OpenRefine/issues/3481
|
https://github.com/OpenRefine/OpenRefine/pull/3485
|
ffdede24236c9f71bbc9076b283a138b35917366
|
f661201e9aeacaadd8d0b9678d7a798bbf6e4047
| 2021-01-16T17:33:53Z |
java
| 2021-01-27T08:57:42Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,476 |
["docs/src/css/custom.css"]
|
Move away from px to em in docs styling
|
<!-- Please provide a clear and concise description of your problem or unsatisfied needs. Ex. I'm always frustrated when [...] or, It would be easier if OpenRefine did [...]. This comment can be deleted, if desired, but it will be hidden in your final submission. Please make sure that your new text is outside the enclosing angle brackets. -->
We are using pixels for styling in docs which is absolute and can't vary according to screen size.
### Proposed solution
<!-- If you have a proposal for how this need could be met, please provide a clear and concise description of what you want to happen. -->
Support use of em which is relative to the screen resolution you are viewing on.
|
https://github.com/OpenRefine/OpenRefine/issues/3476
|
https://github.com/OpenRefine/OpenRefine/pull/3477
|
7f18c6618919ff277c3e9a3c548e0fd0f07c54f4
|
b5bd5e62e42538e81d5e106a098f6f6483072f23
| 2021-01-15T19:36:59Z |
java
| 2021-01-19T08:28:44Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,475 |
["main/src/com/google/refine/ProjectManager.java", "main/src/com/google/refine/ProjectMetadata.java", "main/src/com/google/refine/commands/project/SetProjectTagsCommand.java", "main/src/com/google/refine/commands/row/GetRowsCommand.java", "main/src/com/google/refine/history/History.java", "main/src/com/google/refine/model/Project.java", "main/tests/server/src/com/google/refine/ProjectManagerTests.java", "main/tests/server/src/com/google/refine/RefineTest.java", "main/tests/server/src/com/google/refine/history/HistoryTests.java", "main/tests/server/src/com/google/refine/model/ProjectStub.java"]
|
Row count is returned as 0 occasionally from the server while fetching metadata
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
While writing tests for project_metadata #3474 , I encountered an occasional bug. Table row metadata is being returned as zero sometimes from the openrefine server and hence Rows is being shown as 0.
### To Reproduce
Steps to reproduce the behavior:
1. Visit the `Open Project` page
2. See table columns, row is sometimes returned as 0 from the server
### Response returned by the server
```json
{
"projects": {
"2610263550897": {
"created": "2021-01-15T17:30:02Z",
"modified": "2021-01-15T17:30:02Z",
"name": "1610731802333",
"tags": [],
"creator": "",
"contributors": "",
"subject": "",
"description": "",
"rowCount": 0,
"title": "",
"version": "",
"license": "",
"homepage": "",
"image": "",
"importOptionMetadata": [
{
"includeFileSources": false,
"includeArchiveFileName": false,
"encoding": "US-ASCII",
"ignoreLines": -1,
"headerLines": 1,
"skipDataLines": 0,
"storeBlankRows": true,
"storeBlankCellsAsNulls": true,
"separator": ",",
"guessCellValueTypes": false,
"processQuotes": true,
"quoteCharacter": "\"",
"trimStrings": true,
"projectName": "1610731802333",
"fileSource": "food.mini.csv",
"archiveFileName": null
}
],
"customMetadata": {}
}
}
}
```
<img width="1409" alt="Screenshot 2021-01-16 at 1 00 52 AM" src="https://user-images.githubusercontent.com/44091822/104770361-78e64580-5796-11eb-8247-e4c04f23fe8b.png">
Meanwhile, when I click on the project, it shows two rows.
<img width="821" alt="Screenshot 2021-01-16 at 1 01 01 AM" src="https://user-images.githubusercontent.com/44091822/104770319-679d3900-5796-11eb-96aa-4c61c00d5757.png">
|
https://github.com/OpenRefine/OpenRefine/issues/3475
|
https://github.com/OpenRefine/OpenRefine/pull/5655
|
002310972764fbf34105764f18cfec44b520df96
|
4d2519f38db8b4f5d1ec42598a4fae24b193e830
| 2021-01-15T19:32:29Z |
java
| 2023-03-17T20:47:05Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,469 |
[".github/workflows/snapshot_release.yml"]
|
Snapshot release workflow is failing
|
Snapshot release workflow is failing
|
https://github.com/OpenRefine/OpenRefine/issues/3469
|
https://github.com/OpenRefine/OpenRefine/pull/3472
|
827525c92d80e380083a74472c5d46bdd1ab57d2
|
49e287b1100d36ff51a836f53675e0f55fd331bd
| 2021-01-14T16:51:38Z |
java
| 2021-01-14T18:06:57Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,462 |
["main/src/com/google/refine/importers/ImportingParserBase.java", "main/src/com/google/refine/importers/tree/TreeImportingParserBase.java", "main/tests/data/json-sample-format-1.json", "main/tests/server/src/com/google/refine/importers/JsonImporterTests.java", "main/tests/server/src/com/google/refine/importers/XmlImporterTests.java"]
|
XML and JSON importers and using "Store file source" doesn't make a column
|
### To Reproduce
Steps to reproduce the behavior:
1. Create new project from a file or URL (either JSON or XML)
2. Choose JSON or XML as appropriate for file.
3. Then make any record row selection from an element in the JSON or XML with a mouse selection
4. Click on **Store file source** check box
5. Notice the preview refresh
### Current Results
Preview refreshes but doesn't add the extra column **File** as it does if you simply select another importer like Line based or CSV.
### Expected Behavior
**File** column should be created when clicking **Store file source** checkbox option on importers
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Firefox latest
- JRE or JDK Version: JDK8
- OpenRefine: 3.5-beta [8eabec1] (master)
### Datasets
https://github.com/PerseusDL/treebank_data/raw/master/v2.1/Greek/texts/tlg0012.tlg001.perseus-grc1.tb.xml
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/3462
|
https://github.com/OpenRefine/OpenRefine/pull/3921
|
7dd779e674bf0c60397e5718631ea225cd3a943b
|
fed23ec7f67f6769c8506e8e0a5a4ca6b8534105
| 2021-01-10T04:15:43Z |
java
| 2021-05-30T20:24:06Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,460 |
["main/webapp/modules/core/scripts/index/default-importing-controller/file-selection-panel.js"]
|
Broken counts in file selection dialog
|
The counts of files by extension in the file selection dialog (when importing an archive) are broken, we have "$1" in the UI instead of the actual number.
### To Reproduce
Steps to reproduce the behavior:
1. First, import the file `https://ndownloader.figshare.com/files/25791104` in OpenRefine
2. Then, see the selection dialog
### Current Results
### Expected Behavior
Actual counts should be shown.
### Versions<!-- (please complete the following information)-->
- Operating System: Debian
- Browser Version: Firefox 78
- JRE or JDK Version: 11
- OpenRefine: Version 3.5-beta [ff6220a]
|
https://github.com/OpenRefine/OpenRefine/issues/3460
|
https://github.com/OpenRefine/OpenRefine/pull/3495
|
c6f15ed653ab45c5f30261dbd33bc72c951cf01a
|
7f18c6618919ff277c3e9a3c548e0fd0f07c54f4
| 2021-01-09T12:57:24Z |
java
| 2021-01-19T08:11:31Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,444 |
[".github/dependabot.yml", "main/tests/cypress/yarn.lock"]
|
Setup dependabot updates for cypress-test-suite
|
<!-- Please provide a clear and concise description of your problem or unsatisfied needs. Ex. I'm always frustrated when [...] or, It would be easier if OpenRefine did [...]. This comment can be deleted, if desired, but it will be hidden in your final submission. Please make sure that your new text is outside the enclosing angle brackets. -->
We have not set up an automated dependencies update for cypress-test-suite residing in main/tests/cypress.
### Proposed solution
<!-- If you have a proposal for how this need could be met, please provide a clear and concise description of what you want to happen. -->
Setup dependabot for the following yarn package manager.
|
https://github.com/OpenRefine/OpenRefine/issues/3444
|
https://github.com/OpenRefine/OpenRefine/pull/3447
|
eb7cdf2d9ccba84f3e2bdb5202059a2d43e810c0
|
0e08c50e07de43bad36e6a54638a20b0c9a8b931
| 2021-01-04T11:53:30Z |
java
| 2021-01-07T07:37:24Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,429 |
["main/tests/cypress/cypress/integration/create-project/preview_project.spec.js", "main/tests/cypress/cypress/integration/project/grid/misc/proper-display.spec.js", "main/tests/cypress/cypress/support/commands.js"]
|
Add UX tests for the create project preview
|
### Proposed solution
#### Start over behavior
Add a test to start over a project creation.
Just ensure the user is redirected to the previous page.
#### Rename the project add tags
Rename the project and add tags.
Ensure those modifications are persisted (when visiting the project list page ? or is there a better way to do it ?)
#### Navigation
Ensure that once a project reaches the preview step, a user can navigate back&forth to other screens of OpenRefine (language for example)
#### Parsing Options
Does it make sense to test each and every parsing option? It looks like a backend matter.
Looking at the requests, they are similar, whatever the option is (importing-controller, get-models, get-rows)
To start, we could have an MVP test that would
* load a CSV
* change a few parsing options, and ensure the grid reflect those changes
This simple test could be duplicated with JSON data to have better coverage.
|
https://github.com/OpenRefine/OpenRefine/issues/3429
|
https://github.com/OpenRefine/OpenRefine/pull/3676
|
6c3a4cfa88dbbb65bad6aad15573fa1e937a29f1
|
b455dc577a2348a3e49ca1e00b4862c951adeb06
| 2020-12-16T13:45:19Z |
java
| 2021-03-12T09:40:36Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,428 |
["main/tests/cypress/cypress/fixtures/shop.mini.tsv", "main/tests/cypress/cypress/integration/create-project/create_project.spec.js", "main/tests/cypress/cypress/integration/create-project/preview_project.spec.js", "main/tests/cypress/cypress/support/commands.js"]
|
Add UX tests for all methods to create a project
|
Creating a project is a major feature of OpenRefine, and should be extensively tested
### Proposed solution
One single test file per creation method is probably the best way to organize things.
#### Create from a local file
Add a test to ensure an alert is triggered when uploading an invalid file (jpg for example)
#### Web addresses
To test this, we would have first a PR that adds a file in the repository, then use it for testing upload from a web address.
Test with multiple URLs.
What is the expected behavior here? Dataset to be combined into one single project?
#### Clipboard
Test with copy-pasting
* CSV data
* JSON data
... and ensure this goes to the next step
#### Database
To keep simple here, only SQLite should be tested at first.
The SQLite file can be saved in the fixtures folder
#### Google Data
Is that possible to have a google spreadsheet stored in the repository? (No)
### Additional context
Generally speaking, those tests should only test the expected behaviors on the initial project creation page.
Different options for CSV and so on is a different test.
|
https://github.com/OpenRefine/OpenRefine/issues/3428
|
https://github.com/OpenRefine/OpenRefine/pull/3603
|
763ef2fd09a70e90b5ce5ab282a1ab1577b0f9c0
|
3db9453661261e1917aaa21fd3c1e3559536f6f2
| 2020-12-16T13:33:37Z |
java
| 2021-02-26T20:12:46Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,427 |
["main/tests/cypress/cypress/integration/project/grid/all-column/collapse_all.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/view/collapse.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/view/collapse_left.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/view/collapse_right.spec.js"]
|
Add UX tests for column / View
|
Test the Column / View dropdowns
### Proposed solution
Add four tests,
* collapse.spec.js
* collapse_all.spec.js
* collapse_left.spec.js
* collapse_right.spec.js
The test should basically collapse one or more columns, and ensure that the columns labels are empty (or possibly just hidden).
### Additional context
See also #3415, with some very similar tests about collapsing
When collapsing, column labels are not hidden, they are removed from the DOM.
|
https://github.com/OpenRefine/OpenRefine/issues/3427
|
https://github.com/OpenRefine/OpenRefine/pull/4188
|
5e310a77005664f250cafa512d00b7f1365e5bca
|
e286d9f02f7e86143a3ca54e82cbccefd6f91582
| 2020-12-16T13:15:53Z |
java
| 2021-10-04T14:39:47Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,423 |
["main/tests/cypress/cypress/integration/project/grid/column/edit-cells/join-multi-valued-cells.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/edit-cells/split-multi-valued-cells.spec.js", "main/tests/cypress/cypress/support/commands.js"]
|
Add UX Test for column / Edit cells
|
To test every behavior under Column / Edit Cells
### Proposed solution
Add multiple tests
#### Transform
Add a simple test to append a string to a value `value+"test"`
Ensure the modification is in the grid
#### Common Transforms
Those transforms are very straightforward and do not need to be specified.
Simplify add a test for each one of them and ensure the values are properly modified
#### Fill down, Blank Down
Use "Sugar Tot" on food.small dataset and
* ensure lines 8,10 have the value of the previous cell when using "Fill down"
* ensure line 2 is blank when using "Fill blank"
#### Split multi-valued cells
Ensure several rows are created when using "Split multi-valued cells" on "Shrt_Desc"
Ensure no new rows are created when using "Split multi-valued cells" on "Water" (or any column that does not contains ",")
#### Join multi-valued cells
How does this feature works?
#### Cluster and edit
See #3422
#### Replace
Replace a simple string in column "Shrt_Desc", such as "BUTTER" replaced by "TEST" and ensure the modification is in the grid.
|
https://github.com/OpenRefine/OpenRefine/issues/3423
|
https://github.com/OpenRefine/OpenRefine/pull/3641
|
a07ca9d72d219db4d818b3d7651d5536aeab88d3
|
91c3cc734def9be4a40f07021577ac0baa5d0b95
| 2020-12-16T12:55:53Z |
java
| 2021-03-10T14:46:50Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,422 |
["main/tests/cypress/cypress/integration/project/grid/column/edit-cells/cluster-and-edit.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/facet/facets.spec.js"]
|
Add UX Test for clustering
|
In-depth testing is probably good for clustering
This is a placeholder ticket for far, where the community can discuss what to test for the clustering
|
https://github.com/OpenRefine/OpenRefine/issues/3422
|
https://github.com/OpenRefine/OpenRefine/pull/5216
|
4d1ff04f87dca74fb674d431ac27d25b9c083a73
|
28ad91728a1fd7a77bbe1973b9dbee461afc4def
| 2020-12-16T12:54:38Z |
java
| 2022-08-29T09:10:11Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,421 |
["main/tests/cypress/cypress/integration/project/grid/column/text_filter.spec.js"]
|
Add UX Test for column / Text filter
|
Test the Column / Text filter
### Proposed solution
Add a test for the behavior with
* an exact string, check the number of occurrences
* a partial string, also check the number of occurrences
* Test case sensitive
* Test a regular expression
|
https://github.com/OpenRefine/OpenRefine/issues/3421
|
https://github.com/OpenRefine/OpenRefine/pull/3566
|
c1cbc2bdd7fdbe4edf638a3a8fcf696b2cee8b09
|
fb248495f14a4df4b57f981db0eb557b61ccec7a
| 2020-12-16T12:49:27Z |
java
| 2021-02-07T20:05:36Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,418 |
["main/tests/cypress/cypress/fixtures/fixtures.js", "main/tests/cypress/cypress/fixtures/food.sort.csv", "main/tests/cypress/cypress/fixtures/food.sort.js", "main/tests/cypress/cypress/integration/project/grid/column/sort.spec.js", "main/tests/cypress/cypress/integration/project/grid/viewpanel-header/sort.spec.js", "main/tests/cypress/cypress/support/commands.js"]
|
Add UX tests for the sorting
|
Enrich and improve the tests we have on the sorting
Test all sorting capabilities of OpenRefine, with a given project
### Proposed solution
#### Test for sorting from the column dropdown
Test sorting behaviors from the column dropdown
* test the sorting of the Water column, using text sort, number sort, the sort should be different
* Cast a column to a boolean, test the boolean sort
* Test the text sort a-z, z-a, and with case-sensitive values
* With a given sort, test the different combinations for Blanks, Valid values, Errors
#### Test the sorting from the grid header
Once a sort is added from the column dropdown, sorting controls appear in the grid header
* Ensure the "Sort/remove sort" button is working
* Ensure the "Reorder permanently" is working by refreshing the page
* Test the reverse sort
* Remove the sort
|
https://github.com/OpenRefine/OpenRefine/issues/3418
|
https://github.com/OpenRefine/OpenRefine/pull/3519
|
f58054b33728669f2cdd82c3738a1079de5e0ef1
|
0b748bcc3744f7cc42fedd9e353e4682bfb09064
| 2020-12-16T12:30:25Z |
java
| 2021-02-01T12:40:40Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,417 |
["main/tests/cypress/cypress/integration/project/grid/column/sort.spec.js", "main/tests/cypress/cypress/integration/project/grid/viewpanel-header/.gitkeep", "main/tests/cypress/cypress/integration/project/grid/viewpanel-header/pagination.spec.js", "main/tests/cypress/cypress/integration/project/grid/viewpanel-header/sort.spec.js", "main/tests/cypress/cypress/support/openrefine_api.js"]
|
Add UX Test for the grid header / pagination
|
Add tests for the header block that sits on top of the grid (pagination)
### Proposed solution
Add a pagination test to
* Ensure 5,10,25 rows to be shown when changing pagination
* Test the first, previous, next, last buttons
* Test entering an arbitrary page number
* Test entering a page number that does not exist
|
https://github.com/OpenRefine/OpenRefine/issues/3417
|
https://github.com/OpenRefine/OpenRefine/pull/3550
|
6750a45d53a46f0cd87072ec9458826a48e7fe36
|
3692257aa1bf9fe5fa02589652564502ac7895fe
| 2020-12-16T12:26:40Z |
java
| 2021-02-04T14:42:57Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,416 |
["main/tests/cypress/cypress/integration/project/grid/viewpanel-header/rows_records.spec.js", "main/tests/cypress/cypress/support/commands.js", "main/webapp/modules/core/scripts/index/parser-interfaces/json-parser-ui.js"]
|
Add UX Test for the grid header / show as records-rows
|
Add test for the feature that shows records as rows, as records
### Proposed solution
Add a test to show as rows, records and
* load a project of CSV data, show as row/records, ensure nothing changes
* load JSON data, and test the rendering as rows, as records
Exact expected behavior of this feature to be reviewed
|
https://github.com/OpenRefine/OpenRefine/issues/3416
|
https://github.com/OpenRefine/OpenRefine/pull/3606
|
64e75f79addaeae761d19d9607d43e68a51f9e22
|
0c5742771c4ce6471ee33eeb72fe76191e85aa10
| 2020-12-16T12:23:32Z |
java
| 2021-02-18T10:16:34Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,415 |
["main/tests/cypress/cypress/integration/project/grid/all-column/view.spec.js", "main/webapp/modules/core/langs/translation-en.json"]
|
Add UX tests for the special column "All"
|
Add tests for the special column "All", and all the dropdowns
### Proposed solution
#### Transform
* Add "test" to one column, ensure the modification is applied
* Add "test" to all columns, ensure the modification is applied
#### Facet by star, by flag
This should be a simple test,
* flag one or more rows, ensure the faceted filtering is working
* star one or more rows, ensure the faceted filtering is working
All the detailed behaviors on the Facet are tested within the "Facet" test, see
#### Facet - Blank value per column / Non blank
With a dataset with blank / null values, add a facet by "blank value per column"
Ensure only the column that contains blank values are listed in the facet panel
#### Facet - Blank records per column / Non blank
How is this feature different from "Blank value per column" ?
##### Edit rows - Flag all
Click Edit Columns / Flag, ensure all rows are flagged
Test the unflag
#### Edit rows - Star all
Click Edit Columns / Star, ensure all rows are starred
Test the unstar
#### Edit rows - Remove matching rows
Is this correct that this control will always remove all rows?
#### Edit columns - Reorder
Add a test that reorders the columns in a different order.
Ensure the modifications are persisted in the grid.
#### Edit columns - Fill down, Blank down
With a dataset that contains blanks on several columns, ensure all blanks are filled when clicking on "fill down"
With a dataset that contains duplicate on several columns, ensure all cells that contain duplicates are blanked when clicking on "blank down"
#### View - Collapse, expand all
* Collapse all columns, ensure the grid doesn't contain any single label
* Collapse all, expands, ensure all the labels are visible
#### View - show hide null values in cells
* Ensure the null values are displayed as empty (nothing in the cell), then click on "show hide null values", and ensure the string "null" is visible in each matching cells
|
https://github.com/OpenRefine/OpenRefine/issues/3415
|
https://github.com/OpenRefine/OpenRefine/pull/5290
|
e2f57fc245e2b41574596d3415c3ee61d85677ad
|
1b54b9d0dbf826598f43aa755a31e9bed25ce83f
| 2020-12-16T12:20:33Z |
java
| 2022-09-30T05:58:28Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,414 |
["main/tests/cypress/cypress/integration/project/grid/all-column/flag.spec.js", "main/tests/cypress/cypress/integration/project/grid/all-column/star.spec.js"]
|
Add UX Test for controls at the row level
|
This tests intent to ensure the behaviors of the features at the row-level
### Proposed solution
Add test for controls that sit at the very left of each row in the grid.
### Flag
Flag, unflag one and several rows. Ensure that the flag icon is colored in yellow.
### Star
Star, unstar one and several rows. Ensure that the star icon is colored in yellow.
|
https://github.com/OpenRefine/OpenRefine/issues/3414
|
https://github.com/OpenRefine/OpenRefine/pull/3601
|
253f91949b2892526020e209dbacbf722826cadc
|
389fa6257d560924157b1ba5e22b3222e2367706
| 2020-12-16T12:14:26Z |
java
| 2021-02-12T13:16:33Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,413 |
["main/tests/cypress/cypress/fixtures/fixtures.js", "main/tests/cypress/cypress/fixtures/food.mini.js", "main/tests/cypress/cypress/integration/open-project/list_projects.spec.js", "main/tests/cypress/cypress/integration/open-project/open_project.spec.js", "main/tests/cypress/cypress/integration/project/project-header/export_project.spec.js"]
|
Add UX Test for the projects list
|
Improve the tests we have on the projects list page (project management)
### Proposed solution
#### Test the "About" panel
* Editing of metadata
* test the panel
#### Test the Delete behavior
Test project deletion and ensure it's been really deleted, not only removed from the list.
#### Test the sorting of the projects list
#### Test the sorting of tagging list
To be tested
* Sort by tags
* Filter by tags
|
https://github.com/OpenRefine/OpenRefine/issues/3413
|
https://github.com/OpenRefine/OpenRefine/pull/3480
|
f94bb5e8f415dbd29a3e2e377dc42d65a44cf830
|
900ff2db9a7545f757407f84a0e5a69f39b01243
| 2020-12-16T12:10:51Z |
java
| 2021-01-28T10:45:05Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,412 |
["main/tests/cypress/cypress/integration/project/project-header/export_project.spec.js", "main/tests/cypress/cypress/integration/project/project-header/help.spec.js", "main/tests/cypress/cypress/integration/project/project-header/permalink.spec.js", "main/tests/cypress/cypress/integration/project/project-header/project_rename.spec.js"]
|
Add UX Test for project header elements
|
Header elements should be tested.
### Proposed solution
#### Test for header left components
* Test project renaming
* Ensure that the permalink is working
Move export_project.spec.js into this folder
#### Tests for export formats
* Add a test for each export format.
For now, we can not ensure that the downloaded file exists, but it will allow detecting when the server triggers an HTTP error on exporting.
* Add a test for the help button
|
https://github.com/OpenRefine/OpenRefine/issues/3412
|
https://github.com/OpenRefine/OpenRefine/pull/4212
|
1d6d46999f1a64a452740025035b46e53e728e1d
|
a5a2cd3c9ba8c9d32355b2f26ce3d659d72c8614
| 2020-12-16T12:06:03Z |
java
| 2021-10-18T07:40:30Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,384 |
[".github/workflows/pull_request.yml", ".github/workflows/snapshot_release.yml", "README.md"]
|
Missing features in GitHub Actions build
|
This is a quick note of the things I want to improve in the GitHub Actions build:
- [x] when building commits on the master branch we should also test the database extension (currently we do not) and submit coverage to coveralls
- [ ] therefore it could make sense to have a single workflow file and use conditions to disable steps (such as build and upload of snapshot releases when checking a PR)
- [x] we need to test for more than JRE 8 (add JRE 14)
- [x] the coveralls token needs to be available in jobs triggered by PRs from forks (https://github.com/OpenRefine/OpenRefine/pull/3385/checks?check_run_id=1500751010)
|
https://github.com/OpenRefine/OpenRefine/issues/3384
|
https://github.com/OpenRefine/OpenRefine/pull/3386
|
060375b0076ab593a74d2615f627cb63b3f26f08
|
9e94d32b49d50c1cf155eedb94a56bcfae9c49b2
| 2020-12-04T14:25:23Z |
java
| 2020-12-07T04:36:05Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,382 |
["main/src/com/google/refine/grel/Parser.java", "main/tests/server/src/com/google/refine/grel/GrelTests.java", "main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/dialogs/templating-exporter-dialog.js"]
|
Templating exporter should have clear error reporting
|
Currently when your code in the Templating exporter has a problem, the Preview window will just show "Updating..." forever.
It would be good to have a timeout after a few seconds and report back the line/character causing the problem. If not that, then just a generic error message would be an improvement.
When your code (inside double curly braces) isn't resolving correctly (e.g. because of an extra closing curly brace) the entire expression including the curly braces just outputs as a string instead.
This should have its own error message, instead of the string output.
|
https://github.com/OpenRefine/OpenRefine/issues/3382
|
https://github.com/OpenRefine/OpenRefine/pull/3945
|
782deb86d4b6ac3941619a602100d06e4a69aee3
|
4d106b118ff496d07e17b28b37a4e3ec2c3580b7
| 2020-12-03T16:14:27Z |
java
| 2021-11-25T20:19:10Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,381 |
["main/src/com/google/refine/templating/Parser.java", "main/tests/server/src/com/google/refine/exporters/TemplatingExporterTests.java"]
|
Broken escaping in templating export
|
Curly braces are used in the templating exporter to delimit expressions from the rest of the template text. Therefore if we want to use curly braces in the expressions they need to be escaped. According to the code, we are supposed to do this with `\{`, but that does not actually work.
### To Reproduce
Steps to reproduce the behavior:
1. First, open any project
2. Then, open the templating export dialog
3. Finally, input the following template:
```
{{"\}\}"}}
```
This is supposed to evaluate to just `}}` for each row.
### Current Results
We get `{{"\}\}"}}` instead.
### Expected Behavior
We should get `}}`
### Versions<!-- (please complete the following information)-->
- Operating System: Linux
- Browser Version: irrelevant
- JRE or JDK Version: 11
- OpenRefine: 3.4.1
### Additional context
Brought up while trying to document the templating exporter.
|
https://github.com/OpenRefine/OpenRefine/issues/3381
|
https://github.com/OpenRefine/OpenRefine/pull/4355
|
4327ec8311457dfe929807ec564b32c429b73467
|
cf532df9c7ce0d5e9c609c6fcedf2a83bc463cfe
| 2020-12-03T16:14:14Z |
java
| 2022-02-03T07:58:12Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,369 |
["main/src/com/google/refine/model/recon/StandardReconConfig.java", "main/src/com/google/refine/operations/recon/ReconOperation.java", "main/src/com/google/refine/util/HttpClient.java", "main/tests/server/src/com/google/refine/RefineTest.java", "main/tests/server/src/com/google/refine/model/recon/StandardReconConfigTests.java", "main/tests/server/src/com/google/refine/operations/column/ColumnAdditionByFetchingURLsOperationTests.java", "main/tests/server/src/com/google/refine/operations/recon/ReconOperationTests.java"]
|
Parts of reconciliation batches can fail silently; and parts of reconciled column lookup batches can fail silently
|
This may be a duplicate of an existing bug or bugs, but I find it incredibly frustrating: when items are 'unmatched' it appears to be impossible to distinguish whether there is really no match for the item, or whether the reconciliation process simply failed to complete for some sub-batch of entries.
A couple of days ago, I was running a reconciliation of a set of authors with LoC authority IDs against Wikidata using the "reconcili.link" service. I ran it once, and about 80% reconciled. I then filtered for the unmatched authors, reconciled again, and a further 15% of the original set reconciled.
I presume that what happened was that during the first reconciliation, one or more sub-batches of contiguous records timed out, or otherwise failed to return. (The problem did appear to be affecting contiguous records). That, I guess, is something that can always happen. The problem is that OpenRefine then marked those records' reconciliation status as "unmatched" rather than "unknown", not differentiating between items for which the reconcilation had failed to complete from those for which the reconcilation had concluded but found nothing.
Similarly, when I then added a column looking up LoC IDs based on the reconciled values (which I find is a necessary thing to have to do to sanity check reconcilations), only about 80% of the IDs got added, with more added when I re-ran the lookup for those without values.
This is frustrating enough for me, aware that this can happen, knowing that I may need to re-run reconciliations or augmentations two or three or even more times to be sure. But the even worse impact is with unaware users, who as a result may then add new duplicate items to Wikidata for their unreconciled entries, without realising that the unreconciled status cannot be depended on.
|
https://github.com/OpenRefine/OpenRefine/issues/3369
|
https://github.com/OpenRefine/OpenRefine/pull/4232
|
f94116148b9def04e3eb6bf8bfed3b1dd2320a64
|
235b5957e22c73328e9f84d6fac44a9cb92318f5
| 2020-11-28T17:32:47Z |
java
| 2021-10-22T06:43:45Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,367 |
[".github/workflows/snapshot_release.yml"]
|
Having UX tests running on Firefox
|
Tests are broken on Firefox
Basically the browser get stuck and the requests are not even hitting OpenRefine.
### Proposed solution
In case backend API calls are causing the bug : Move them to a Cypress plugin, so node will take care of the API calls, and not the browser itself
Try with Firefox developer edition
### Alternatives considered
Escalate to Cypress support
### Additional context
Problem has been detected on Travis and local (Macos)
Firefox support is relatively new for Cypress
|
https://github.com/OpenRefine/OpenRefine/issues/3367
|
https://github.com/OpenRefine/OpenRefine/pull/3459
|
45693bb150e6b3b2f51f3c6abb12cb3d73f6e67e
|
c3445b102fcb5e0cb99014dfdad5eeb3c81d8d14
| 2020-11-27T15:46:09Z |
java
| 2021-04-20T06:25:49Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,362 |
["main/webapp/modules/core/scripts/dialogs/custom-tabular-exporter-dialog.html"]
|
"Help" link on custom tabular exporter window doesn't work
|
### To Reproduce
### Current Results
When you click on the "Help" link (in the section about date formatting) it opens up a new tab and reloads the same project.
### Expected Behavior
It should link to the new docs, I suppose? To
https://docs.openrefine.org/manual/exploring#data-types
(Although I haven't yet explicated very thoroughly the different date format options shown here.)
If someone could confirm what the link was supposed to point to (a page on the wiki, or some other text) that would be helpful.
### Versions
- Browser Version: Firefox
- OpenRefine: 3.4.1
|
https://github.com/OpenRefine/OpenRefine/issues/3362
|
https://github.com/OpenRefine/OpenRefine/pull/3375
|
690fdeb0b3f1a5c4cc931f6f912f5b2aff22a0b2
|
c9ceb9ef476fc0750ab6dcdef867c57db92cbc7e
| 2020-11-26T16:43:40Z |
java
| 2021-01-13T18:48:18Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,354 |
["extensions/wikidata/src/org/openrefine/wikidata/qa/EditInspector.java"]
|
Unable to make schema for own Wikibase: NullPointerException in EditInspector
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
### To Reproduce
Steps to reproduce the behavior:
1. Setup a Wikibase instance with a query service and openrefine
2. Use the query service to download some data (https://tinyurl.com/y5xmdjtw)
3. Try to create a schema to save the (updated) data back
The manifest I am using for testing is:
```
{
"version": "1.0",
"mediawiki": {
"name": "Nimiarkisto (dev)",
"root": "https://nimiarkisto.nikerabb.it/wiki/",
"main_page": "https://nimiarkisto.nikerabb.it",
"api": "https://nimiarkisto.nikerabb.it/w/api.php"
},
"wikibase": {
"site_iri": "http://nimiarkisto.fi/entity/",
"maxlag": 5,
"properties": {
"instance_of": "P31",
"subclass_of": "P3"
}
},
"oauth": {
"registration_page": "https://nimiarkisto.nikerabb.it/wiki/Special:OAuthConsumerRegistration/propose"
},
"reconciliation": {
"endpoint": "https://nimiarkisto.nikerabb.it/reconciliation/${lang}/api"
}
}
```
### Current Results
"Issues" tab is completely empty.
"Preview tab" says:
> This tab shows the first edits (out of 0) that will be made once you upload the changes to Nimiarkisto (dev). You can use facets to inspect the edits on particular items.
Choosing "Upload edits to Wikibase" just briefly shows "Analyzing" popup and displays the "Schema tab".
From OpenRefine logs:
```
openrefine_1 | 16:54:12.836 [ refine] GET /command/core/get-csrf-token (11552ms)
openrefine_1 | 16:54:12.942 [ refine] POST /command/wikidata/preview-wikibase-schema (106ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [FormatScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (4ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [InverseConstraintScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (0ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [UnsourcedScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (0ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [RestrictedPositionScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (0ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [QualifierCompatibilityScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (0ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [SingleValueScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (0ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [DistinctValuesScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (0ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [QuantityScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (0ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [RestrictedValuesScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (0ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [EntityTypeScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (0ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [MultiValueScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (0ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [DifferenceWithinRangeScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (0ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [ConflictsWithScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (0ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [ItemRequiresScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (0ms)
openrefine_1 | 16:54:12.946 [..kidata.qa.EditInspector] scrutinizer [UseAsQualifierScrutinizer] is skipped due to missing of necessary constraint configurations in the Wikibase manifest (0ms)
openrefine_1 | 16:54:12.946 [ command] Exception caught (0ms)
openrefine_1 | java.lang.NullPointerException
openrefine_1 | at org.openrefine.wikidata.qa.EditInspector.inspect(EditInspector.java:127)
openrefine_1 | at org.openrefine.wikidata.commands.PreviewWikibaseSchemaCommand.doPost(PreviewWikibaseSchemaCommand.java:110)
openrefine_1 | at com.google.refine.RefineServlet.service(RefineServlet.java:187)
openrefine_1 | at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
openrefine_1 | at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
openrefine_1 | at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1221)
openrefine_1 | at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:78)
openrefine_1 | at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:131)
openrefine_1 | at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
openrefine_1 | at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399)
openrefine_1 | at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
openrefine_1 | at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
openrefine_1 | at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
openrefine_1 | at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
openrefine_1 | at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
openrefine_1 | at org.mortbay.jetty.Server.handle(Server.java:326)
openrefine_1 | at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
openrefine_1 | at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:945)
openrefine_1 | at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:756)
openrefine_1 | at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
openrefine_1 | at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
openrefine_1 | at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
openrefine_1 | at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
openrefine_1 | at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
openrefine_1 | at java.lang.Thread.run(Thread.java:748)
```
If I use "Export Schema" from the "Extensions: Wikidata" dropdown, it gives this:
```
{
"itemDocuments":[
{
"subject":{
"type":"wbitemvariable",
"columnName":"nimilippu"
},
"nameDescs":[
],
"statementGroups":[
{
"property":{
"type":"wbpropconstant",
"pid":"P10020",
"label":"image",
"datatype":"external-id"
},
"statements":[
{
"value":{
"type":"wbstringvariable",
"columnName":"kuvapolku"
},
"qualifiers":[
],
"references":[
]
}
]
}
]
}
],
"siteIri":"http://nimiarkisto.fi/entity/",
"mediaWikiApiEndpoint":"https://nimiarkisto.nikerabb.it/w/api.php"
}
```
### Expected Behavior
To see items on the preview tab.
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: Debian 10
- Browser Version: Google Chrome 87.0.4280.66
- JRE or JDK Version: openjdk version "1.8.0_212"
OpenJDK Runtime Environment (IcedTea 3.12.0) (Alpine 8.212.04-r0)
OpenJDK 64-Bit Server VM (build 25.212-b04, mixed mode)
- OpenRefine: Version 3.5-beta [528f4a4]
### Datasets
See https://tinyurl.com/y5xmdjtw for the data I'm trying to use
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/3354
|
https://github.com/OpenRefine/OpenRefine/pull/3355
|
46fc9b626e6abcf61e8de0de256529a66a3fcc08
|
96789f994c8f61af4c07e1b6bc79d369784f09df
| 2020-11-24T17:23:58Z |
java
| 2020-11-25T08:14:38Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,348 |
["main/src/com/google/refine/clustering/binning/FingerprintKeyer.java", "main/tests/server/src/com/google/refine/clustering/binning/KeyerTests.java"]
|
Wynn and Thorn in Old English text does not get fingerprinted correctly
|
Using `fingerprint` and `ngramFingerprint` should correctly transliterate (fold) the Wynn `Ƿƿ` and thorn `þ` grapheme's for modern composition.
### Current Results
`ngramFingerprint('ƿiges ƿarne')`
```
aeginrsƿ
```
`fingerprint('ƿiges ƿarne')`
```
ƿarne ƿiges
```
`fingerprint('Ƿenne bruceþ, þe can ƿeana lyt')`
```
bruceþ can lyt þe ƿeana ƿenne
```
### Expected Behavior
`ngramFingerprint('ƿiges ƿarne')`
```
aeginrsw
```
`fingerprint('ƿiges ƿarne')`
```
warne wiges
```
`fingerprint('Ƿenne bruceþ, þe can ƿeana lyt')`
```
bruceth can lyt the weana wenne
```
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Firefox
- JRE or JDK Version: JDK8
- OpenRefine: 3.4.1
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
https://en.wikipedia.org/wiki/Wynn
https://en.wikipedia.org/wiki/Thorn_(letter)
(Thad spent his weekend playing with Gensim (TF-IDF) and playing with Vector Space Models on some Old English texts and wanting further analysis and tried a few experiments in OpenRefine additionally and hit upon this issue)
|
https://github.com/OpenRefine/OpenRefine/issues/3348
|
https://github.com/OpenRefine/OpenRefine/pull/3349
|
581ed906285055bb1b3456108e1ed4b7c63ddd87
|
2872ceeb7a0949e4ca9715284bca56c3c9a3050f
| 2020-11-22T20:36:08Z |
java
| 2020-11-29T03:08:00Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,344 |
["main/src/com/google/refine/commands/browsing/GetScatterplotCommand.java", "main/tests/server/src/com/google/refine/commands/browsing/ScatterplotDrawCommandTests.java"]
|
Rotate buttons are not working in scatterplot facet and dialog.
|
The rotate buttons in the scatterplot dialog and facet does not work.
### To Reproduce
Steps to reproduce the behavior:
1. First, create a create any scatterplot using scatterplotfacet.
2. Then, click on the rotate buttons given below the plot.
### Current Results
After clicking the rotate button the graph does not rotate.
Image with no rotation:
Image with rotation:
Same happens in the scatterplotfacet.
### Expected Behavior
The plot should rotate.
### Versions<!-- (please complete the following information)-->
- Operating System: Ubuntu 20.04.1
- Browser Version: Chrome 19
- OpenRefine: OpenRefine 3.4.1
### Additional context
The problem is somewhere in the server side either when converting the client-end configurations of the plot into plotting parameters or somewhere else in between the client side and plotting of the graph.
|
https://github.com/OpenRefine/OpenRefine/issues/3344
|
https://github.com/OpenRefine/OpenRefine/pull/3926
|
dd4eb781e143529b89ac2e0bea02037654a93e7e
|
3adc03c0dbd966f753b85be413fb6a73a3bd92c0
| 2020-11-19T17:15:26Z |
java
| 2021-05-26T12:08:42Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,329 |
["docs/src/css/custom.css"]
|
Style issue in Docusaurus docs
|
We have too much padding on menu entries in the left-hand side bar of the docs:
This was probably introduced by mistake in #3178.
We should restore this padding to Docusaurus' defaults - the area that needed more padding is on the right-hand side (see PR discussion).
Mentioned by @allanaaa in today's documentation meeting.
|
https://github.com/OpenRefine/OpenRefine/issues/3329
|
https://github.com/OpenRefine/OpenRefine/pull/3365
|
2872ceeb7a0949e4ca9715284bca56c3c9a3050f
|
e08356598acda58ece0a3818d649c88e58c54e9c
| 2020-11-12T16:21:12Z |
java
| 2020-11-29T15:25:58Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,319 |
["main/webapp/modules/core/scripts/facets/range-facet.js", "main/webapp/modules/core/scripts/facets/timerange-facet.js"]
|
adjust colors of filtered numeric facet
|
I taught a workshop on OpenRefine today, and some learners could not see the dark-blue on light-blue histograms when filtering data in a numeric facet.
### Proposed solution
Add a color choosing menu that adjusts the "filtered histogram color" (and perhaps the initial histogram color).
### Alternatives considered
I don't know of another way in OpenRefine to access a histogram of filtered data, or to compare the distribution
### Additional context
The color contrast was not strong enough for them:
<!-- Add any other context or screenshots about the feature request here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/3319
|
https://github.com/OpenRefine/OpenRefine/pull/5253
|
daac8fa28437b43d8448d997dcd4bd70a0360387
|
fd7caa5b0ebb74e98077c08956721b15381b77e9
| 2020-11-05T22:14:33Z |
java
| 2022-09-26T09:17:54Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,312 |
["extensions/gdata/module/langs/translation-en.json", "extensions/gdata/module/scripts/index/gdata-source-ui.js", "extensions/gdata/module/scripts/index/import-from-gdata-form.html"]
|
I18N Fix GData importer for better translatability
|
This is an issue that was raised by translators on Weblate.
Currently the gdata-import module has sentences split up into multiple fragments, such as:
"Please", "sign in and and authorize", "to access your Google data." with the middle phrase being a button label. This mandates an ordering which doesn't work in all languages.
A better structure would be: "Please sign-in and authorize to access your Google data:" followed by a button "Sign In"
A similar problem exists for "Re-sign in", "with another account" where the first fragment is a button label.
The key `gdata-import/sign-in` can be used to find the appropriate strings and code.
A related issue is the structure of
"Ignore first" ____ "line(s) at beginning of file"
but that is shared with many importers, so probably should be addressed separately.
|
https://github.com/OpenRefine/OpenRefine/issues/3312
|
https://github.com/OpenRefine/OpenRefine/pull/3613
|
7bccdd1bcffb7c3e1f8a95d28010ee5cc3ef6028
|
c3febcfdee0221acf589f2c78b9a24d815993ed3
| 2020-11-03T22:45:00Z |
java
| 2021-02-11T18:56:41Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,291 |
["main/src/com/google/refine/expr/functions/strings/Find.java", "main/tests/server/src/com/google/refine/expr/functions/strings/FindTests.java"]
|
Dead code + inaccuracy in the Find function documentation
|
In #2095 we updated the `find` function to support two types of arguments: regex (`/[a-z]/`) and simple string (`"[a-z]"`).
There are two things we need to clean up there:
* The embedded description of the function does not reflect that:
https://github.com/OpenRefine/OpenRefine/blob/ac7b5a0a19c1ecaefa1ac1d9d0d26ea9baceacee/main/src/com/google/refine/expr/functions/strings/Find.java#L75
* There is a bit of dead code here:
https://github.com/OpenRefine/OpenRefine/blob/ac7b5a0a19c1ecaefa1ac1d9d0d26ea9baceacee/main/src/com/google/refine/expr/functions/strings/Find.java#L59
(at this point the `p` variable cannot be a `String`, we already know it's a `Pattern`).
|
https://github.com/OpenRefine/OpenRefine/issues/3291
|
https://github.com/OpenRefine/OpenRefine/pull/3294
|
77f26c1218428d3968d1f9ad2819e07e3885d200
|
352127558ace16cffc4f11216c47470f07ad73ba
| 2020-10-29T16:32:16Z |
java
| 2020-11-01T07:52:36Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,288 |
["refine", "refine.bat", "server/src/com/google/refine/Refine.java", "server/src/com/google/refine/ValidateHostHandler.java"]
|
HTTP server implementation is vulnerable to DNS rebinding attacks
|
OpenRefine has endpoints with intentional remote code execution without authentication (like running Python or Clojure transformations). While the lack of authentication would not be an issue with normal desktop use when OpenRefine is bound to a loopback interface like 127.0.0.1, the current implementation still exposes users to Remote Code Execution via [DNS rebinding](https://en.wikipedia.org/wiki/DNS_rebinding) attacks.
### To Reproduce
I did not prepare a full Proof of Concept exploit, but the general steps would be:
- Run OpenRefine
- Visit rebindable.com, which loads a malicious script in the browser
- Attacker rebinds rebindable.com to 127.0.0.1
- Malicious script calls OpenRefine endpoints as if they were under rebindable.com
### Current Results
The calls will succeed and an attacker can use them to run arbitrary code on the user's computer. This works because after the domain has been rebound, the script can now call OpenRefine endpoints as if they were same-origin.
### Expected Behavior
The calls should be rejected.
### Additional context
I have sent a pull request (#3212) to address this problem by validating the Host header. See implementation details in the thread associated with the PR. This issue was opened at the request of @tfmorris.
|
https://github.com/OpenRefine/OpenRefine/issues/3288
|
https://github.com/OpenRefine/OpenRefine/pull/3212
|
64cd0bc18386715b546c2a224990919895a7e29c
|
6234a61e82235f69363764c9b9016c0c7d3da778
| 2020-10-27T11:15:15Z |
java
| 2021-03-22T11:53:39Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,282 |
["main/src/com/google/refine/clustering/binning/FingerprintKeyer.java", "main/src/com/google/refine/clustering/binning/NGramFingerprintKeyer.java", "main/tests/server/src/com/google/refine/clustering/binning/KeyerTests.java"]
|
Fingerprint functions should support Unicode whitespace and punctuation
|
Although the fingerprint keyers currently do diacritic folding for alphabetic characters, they don't correctly handle all Unicode whitespace and punctuation characters.
### Proposed solution
Both the FingeprintKeyer and NGramFingerprintKeyer should be extended to correctly handle all Unicode whitespace characters (e.g. em space, NBSP, ZWSP, etc) and punctuation.
Additionally, the (almost) duplicate code in the N-gram keyer should be removed and use the common methods from the fingerprint keyer to make maintenance easier and less bug prone.
|
https://github.com/OpenRefine/OpenRefine/issues/3282
|
https://github.com/OpenRefine/OpenRefine/pull/3283
|
a3fc40aa0d654da7fe59bb1351f5e7be3b58d511
|
c8220d687ed76f02168fd55c0fdcb336a8fb37eb
| 2020-10-21T17:46:29Z |
java
| 2020-10-25T19:32:30Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,277 |
["main/src/com/google/refine/io/FileProjectManager.java", "main/tests/server/src/com/google/refine/io/FileProjectManagerTests.java"]
|
Can't see projects or open Workspace Directory with non-ASCII characters in workspace path
|
Hi,
I have installed OpenRefine 3.3. in Windows10 and open with Chrome
Everything works ok, but I can't see Created Projects nor open the Browse directory
Also, I can't import projects.
Many thanks
|
https://github.com/OpenRefine/OpenRefine/issues/3277
|
https://github.com/OpenRefine/OpenRefine/pull/4796
|
acbf61f60eb591b66890017b0cd3108592fd1df0
|
cfb222608281f87690aeb0f64052ca784ba5380e
| 2020-10-19T09:17:52Z |
java
| 2022-05-30T12:01:41Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,274 |
["extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/FormatScrutinizer.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/qa/scrutinizers/FormatScrutinizerTest.java"]
|
P304 as reference breaks the Wikidata schema
|
Hi:
Here using OR v3.4 in Linux. Uploading data to Wikidata.
I found using the P304 brakes the schema: the UI doesn't provide any clear feedback and when looking at the logs I got this:
```
21:18:01.030 [ command] Exception caught (15ms)
java.util.regex.PatternSyntaxException: Unknown inline modifier near index 6
(\d+(?[A-Za-z]+)?|[A-Za-z]+(?\d+(?[A-Za-z]+)?)?)([-–](\d+(?[A-Za-z]+)?|[A-Za-z]+(?\d+(?[A-Za-z]+)?)?))?(, ?(\d+(?[A-Za-z]+)?|[A-Za-z]+(?\d+(?[A-Za-z]+)?)?)([-–](\d+(?[A-Za-z]+)?|[A-Za-z]+(?\d+(?[A-Za-z]+)?)?))?)*
^
at java.util.regex.Pattern.error(Pattern.java:1969)
at java.util.regex.Pattern.group0(Pattern.java:2908)
at java.util.regex.Pattern.sequence(Pattern.java:2065)
at java.util.regex.Pattern.expr(Pattern.java:2010)
at java.util.regex.Pattern.group0(Pattern.java:2919)
at java.util.regex.Pattern.sequence(Pattern.java:2065)
at java.util.regex.Pattern.expr(Pattern.java:2010)
at java.util.regex.Pattern.compile(Pattern.java:1702)
at java.util.regex.Pattern.<init>(Pattern.java:1352)
at java.util.regex.Pattern.compile(Pattern.java:1028)
at org.openrefine.wikidata.qa.scrutinizers.FormatScrutinizer.getPattern(FormatScrutinizer.java:68)
at org.openrefine.wikidata.qa.scrutinizers.FormatScrutinizer.scrutinize(FormatScrutinizer.java:80)
at org.openrefine.wikidata.qa.scrutinizers.SnakScrutinizer.scrutinizeSnakSet(SnakScrutinizer.java:71)
at org.openrefine.wikidata.qa.scrutinizers.SnakScrutinizer.scrutinize(SnakScrutinizer.java:64)
at org.openrefine.wikidata.qa.scrutinizers.StatementScrutinizer.scrutinize(StatementScrutinizer.java:36)
at org.openrefine.wikidata.qa.EditInspector.inspect(EditInspector.java:107)
at org.openrefine.wikidata.commands.PreviewWikibaseSchemaCommand.doPost(PreviewWikibaseSchemaCommand.java:92)
at com.google.refine.RefineServlet.service(RefineServlet.java:187)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166)
at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:81)
at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:132)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:938)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:755)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
I'm not sure if this happens with any value for P304. In my case the precise value was _69-91_
An example of the reference I pretend is, exactly, the one for P31 at [Q100407249](https://www.wikidata.org/wiki/Q100407249).
Without using P304 [everything seems to work](https://editgroups.toolforge.org/b/OR/a1e0f311154/) as expected.
Hope this helps.
|
https://github.com/OpenRefine/OpenRefine/issues/3274
|
https://github.com/OpenRefine/OpenRefine/pull/3721
|
4c930fed9ae6e32243080e0719012400166e8516
|
343c8afbea9bc5a1825a20ad53ba0058a9b0c3f1
| 2020-10-16T19:35:20Z |
java
| 2021-04-04T17:25:07Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,256 |
["main/tests/cypress/cypress/integration/project/grid/column/edit-cells/warning-on-blank-down.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/edit-cells/warning-on-fill-down.spec.js", "main/tests/cypress/cypress/support/commands.js", "main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/views/data-table/data-table-view.js", "main/webapp/modules/core/scripts/views/data-table/menu-edit-cells.js", "main/webapp/modules/core/scripts/views/data-table/warn-of-pending-sort.html"]
|
Warn on Fill/Blank Down with pending Sort
|
If the user has a pending sort, which hasn't been made permanent, the visual appearance on the screen doesn't match the data that the Fill Down and, particularly, Blank Down operations will operate on.
### Proposed solution
Warn the user when they attempt any operation that depends on row ordering when they have a Sort active which has not yet been made permanent.
|
https://github.com/OpenRefine/OpenRefine/issues/3256
|
https://github.com/OpenRefine/OpenRefine/pull/4284
|
debc4e65c874ad256b6ff63143658d80016129b3
|
282b5a79567e4e276ff4b20a5ce98a54d729466d
| 2020-10-09T16:12:57Z |
java
| 2021-11-10T19:24:19Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,240 |
["pom.xml"]
|
Add the Java runtime version to the About page
|
Per https://github.com/OpenRefine/OpenRefine/issues/2379#issuecomment-702002694 add the Java run time version to the About page.
### Proposed solution
Simply display the string contained in the the system property `java.runtime.version` without any interpretation. When we drop Java 8 support, we can switch to `Runtime.version`
|
https://github.com/OpenRefine/OpenRefine/issues/3240
|
https://github.com/OpenRefine/OpenRefine/pull/6408
|
74330aa67a3b42ff3754095c47b539ceef2bc073
|
494b66380b58dbdbdfc56fefa816e28376c2e94f
| 2020-10-01T17:10:31Z |
java
| 2024-03-01T21:12:31Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,235 |
["main/src/com/google/refine/expr/functions/arrays/Uniques.java", "main/tests/server/src/com/google/refine/expr/functions/arrays/JoinTests.java", "main/tests/server/src/com/google/refine/expr/functions/arrays/ReverseTests.java", "main/tests/server/src/com/google/refine/expr/functions/arrays/SortTests.java", "main/tests/server/src/com/google/refine/expr/functions/arrays/UniquesTests.java"]
|
GREL uniques() function should preserve array order
|
Currently the GREL `uniques()` function returns the array elements in, effectively, random order. It would be more useful and predictable if the ordering were stable.
### Proposed solution
Return the array in the same order as the original, but with the duplicates eliminated.
|
https://github.com/OpenRefine/OpenRefine/issues/3235
|
https://github.com/OpenRefine/OpenRefine/pull/3236
|
6dd428face14679c726278c2faa7131f40def069
|
82b1cf0bfaf3c8ab57a12e0f2004bdeb71432383
| 2020-09-30T21:19:44Z |
java
| 2020-10-02T03:26:19Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,228 |
["main/webapp/modules/core/scripts/dialogs/scatterplot-dialog.html", "main/webapp/modules/core/scripts/dialogs/scatterplot-dialog.js", "main/webapp/modules/core/scripts/facets/scatterplot-facet.js", "main/webapp/modules/core/styles/project/facets.less"]
|
Scatterplot facet UI regression
|
The UI of the scatterplot has got more ugly between 3.4 and the current development version.
### To Reproduce
Steps to reproduce the behavior: create any scatterplot facet.
### Current Results (master)
### Expected Behavior (3.4)
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: Linux
- Browser Version: Firefox 68
- JRE or JDK Version: 11
|
https://github.com/OpenRefine/OpenRefine/issues/3228
|
https://github.com/OpenRefine/OpenRefine/pull/3338
|
e410e345d2d97f8c626695c039ecf521db720639
|
8740d1bcbac5b3316f69963a0994555a63b85680
| 2020-09-28T15:39:23Z |
java
| 2020-11-29T01:16:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,224 |
[".github/workflows/snapshot_release.yml", "packaging/openrefine.iss"]
|
Allow easier install and uninstall on Windows
|
<!-- Issuehunt Badges -->
[<img alt="Issuehunt badges" src="https://img.shields.io/badge/IssueHunt-%24500%20Rewarded-%237E24E3.svg" />](https://oss.issuehunt.io/r/OpenRefine/OpenRefine/issues/3224)
<!-- /Issuehunt Badges -->
On Windows, OpenRefine currently has a manual process to extract, install, and create desktop shortcuts and configuration.
### Proposed solution
- Create a native installer for OpenRefine on Windows (one that produces an .exe or .msi) that runs without any dependency or other software needed to be preinstalled.
- Install and Uninstall should be available in Add/Remove Programs for OpenRefine.
- Ensure custom folder path input is available during install.
- Have option to create desktop shortcut and add OpenRefine to Start menu.
-
### Installer solutions
#### INNO
----
[Inno Setup](https://jrsoftware.org/isinfo.php) is the most likely candidate for helping packaging a proper installer for Windows with automatic desktop shortcut handling and uninstall.
Inno provides automation through both Inno Setup Scripts (.iss files) as well as Pascal scripting (modern Delphi-like Pascal)
Licensing - Inno seems to have a compatible license, and a simple acknowledgement in our docs is all that is needed, I think. Item 3 in Inno Setup License: https://github.com/jrsoftware/issrc/blob/main/license.txt
CI/CD and packaging methods - I think using the GitHub Actions VM image Windows Server 2019 would provide the necessary toolkits that are required for Inno Setup as it already includes InnoSetup 6.0.5 (latest stable version) as well as the .Net CORE components. See https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md
#### NSIS
----
[Nullsoft Scriptable Install System - SourceForge.net](https://sourceforge.net/projects/nsis/) (NSIS)
https://github.com/NSIS-Dev
There is a Maven plugin: https://github.com/DigitalMediaServer/nsis-maven-plugin (which seems to be cross-platform itself too)
VSCode has the NSIS Plug-ins for IntelliSense https://github.com/idleberg/vscode-nsis-plugins
### Alternatives considered
[WiX Windows Installer](https://wixtoolset.org/) was considered but it doesn't leverage the latest Windows 10 SDK handling.
### Additional context
none for now
<!-- Issuehunt content -->
---
<details>
<summary>
<b>IssueHunt Summary</b>
</summary>
#### [<img src='https://avatars.githubusercontent.com/u/2149798?v=4' alt='dori4n' width=24 height=24> dori4n](https://oss.issuehunt.io/u/dori4n) has been rewarded.
### Backers (Total: $500.00)
- [<img src='https://avatars.githubusercontent.com/u/2538880?v=4' alt='openrefine' width=24 height=24> openrefine](https://oss.issuehunt.io/u/openrefine) ($500.00)
### Submitted pull Requests
- [#5833 Add Windows installer using InnoSetup 6](https://oss.issuehunt.io/r/OpenRefine/OpenRefine/pull/5833)
---
### Tips
- Checkout the [Issuehunt explorer](https://oss.issuehunt.io/r/OpenRefine/OpenRefine/) to discover more funded issues.
- Need some help from other developers? [Add your repositories](https://oss.issuehunt.io/r/new) on IssueHunt to raise funds.
</details>
<!-- /Issuehunt content-->
|
https://github.com/OpenRefine/OpenRefine/issues/3224
|
https://github.com/OpenRefine/OpenRefine/pull/5833
|
a4170af4badd03d4e6d94564fc963af33ee219f6
|
3b40ccd1275852d4c72c03bb7a53d8f3dd262588
| 2020-09-26T14:18:15Z |
java
| 2023-07-05T04:56:50Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,213 |
["extensions/database/module/langs/translation-en.json", "extensions/database/module/langs/translation-fr.json", "extensions/database/module/scripts/index/database-import-controller.js", "extensions/database/module/scripts/index/database-import-form.html", "extensions/database/module/styles/database-import.less", "extensions/database/module/styles/pure.css"]
|
on import page "Database" is not translated in french
|
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Chrome
- JRE or JDK Version: <!-- output of "java -version" e.g. JRE 1.8.0_181 -->
- OpenRefine: 3.4
And I could not find the string in weblate...
|
https://github.com/OpenRefine/OpenRefine/issues/3213
|
https://github.com/OpenRefine/OpenRefine/pull/3217
|
d774f68675bd28443b97d76ae81210f1af85ca6f
|
5746951ec069549345eb368ea74a77c3fec9a912
| 2020-09-24T12:46:05Z |
java
| 2020-09-26T14:05:33Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,204 |
["refine.ini"]
|
refine.ini file current states that if I am a user that it is recommended that I use my own credentials for Google Data
|
In the refine.ini on L29 it mentions that Default OAuth credentials for Google Data have been embedded in the release version of OpenRefine.
`# Default OAuth credentials for Google Data have been embedded in the release version of OpenRefine`
And on L30 it mentions that if I am a user that I can skip the configuration, but its recommended to use my own credentials.
`# So if you are a user, you can just skip these configurations, but it's recommended to use your own credentials`
This is confusing and conflicting information. My expectation, as a user, is that I should only be prompted with an authorization login box for Google Data and enter my credentials, and not have to setup special configuration through the use of Google API Console for credential management as a user of OpenRefine.
I think L30 can just be simplified to only say:
`# So if you are a user, you can just skip these configurations.`
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Firefox latest
- JRE or JDK Version: JDK8
- OpenRefine: OpenRefine 3.4 with java
|
https://github.com/OpenRefine/OpenRefine/issues/3204
|
https://github.com/OpenRefine/OpenRefine/pull/3206
|
64a432c873ce3e559bee60193c56fd5e7442d474
|
109c847f130e775b374550fc6fcfe6f5de793351
| 2020-09-22T23:29:13Z |
java
| 2020-09-25T15:30:51Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,194 |
["main/src/com/google/refine/model/Recon.java", "main/src/com/google/refine/model/recon/StandardReconConfig.java", "main/src/com/google/refine/operations/recon/ReconOperation.java", "main/tests/server/src/com/google/refine/model/ReconTests.java", "main/tests/server/src/com/google/refine/model/recon/StandardReconConfigTests.java", "main/webapp/modules/core/scripts/views/data-table/cell-renderers/recon-renderer.js"]
|
Allow reconciliation dialog to have option to store errors in cells
|
Sometimes intermittent internet problems can occur during (long or short) reconciliation batches due to various reasons. (dogs, cats, chairs, etc.)
Sometimes these might be HTTP errors where connectivity is still established.
Other times these errors might be due to SocketExceptions or networking abnormalities that prevent TCP packets (and hence HTTP) from being sent or received.
### Proposed solution
It would be nice for Reconciliation dialog similar to Fetch URLs to allow storing errors in the cells. Maybe default is enabled?
That way they could be retrieved with `cell.errorMessage` and filtered out for retry from those that did have successful batch queries returned.
### Alternatives considered
Maybe it needs to be a deeper field added to `cell.recon` ? or possibly just at `cell.value` level? But it would be nice to have 1 place for cell errors, so I think `cell.errorMessage` might be better for now. Up to the devs on this. As long as it's documented at Cell or Recon: https://github.com/OpenRefine/OpenRefine/wiki/Variables#cell
### Additional context
Related to #2229 but this issue specifically asks to store errors as part of other improvements mentioned in #2229 for unreliable connections.
OpenRefine log example at 80% completed recon during a connectivity issue that occurred (my chair backed up too much and accidentally pulled the network plug):
```log
at java.net.DualStackPlainSocketImpl.waitForConnect(Native Method)
at java.net.DualStackPlainSocketImpl.socketConnect(Unknown Source)
at java.net.AbstractPlainSocketImpl.doConnect(Unknown Source)
at java.net.AbstractPlainSocketImpl.connectToAddress(Unknown Source)
at java.net.AbstractPlainSocketImpl.connect(Unknown Source)
at java.net.PlainSocketImpl.connect(Unknown Source)
at java.net.SocksSocketImpl.connect(Unknown Source)
at java.net.Socket.connect(Unknown Source)
at org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:339)
at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:142)
at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:373)
at org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:381)
at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:237)
at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:185)
at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:111)
at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:108)
at com.google.refine.model.recon.StandardReconConfig.batchRecon(StandardReconConfig.java:478)
at com.google.refine.operations.recon.ReconOperation$ReconProcess.run(ReconOperation.java:282)
at java.lang.Thread.run(Unknown Source)
12:47:53.233 [..mpl.execchain.RetryExec] I/O exception (java.net.SocketException) caught when processing request to {s}->https://wdreconcile.toolforge.org:443: Network is unreachable: connect (77ms)
12:47:53.233 [..mpl.execchain.RetryExec] Retrying request to {s}->https://wdreconcile.toolforge.org:443 (0ms)
12:47:53.249 [..mpl.execchain.RetryExec] I/O exception (java.net.SocketException) caught when processing request to {s}->https://wdreconcile.toolforge.org:443: Network is unreachable: connect (16ms)
12:47:53.249 [..mpl.execchain.RetryExec] Retrying request to {s}->https://wdreconcile.toolforge.org:443 (0ms)
12:47:53.264 [..mpl.execchain.RetryExec] I/O exception (java.net.SocketException) caught when processing request to {s}->https://wdreconcile.toolforge.org:443: Network is unreachable: connect (15ms)
12:47:53.264 [..mpl.execchain.RetryExec] Retrying request to {s}->https://wdreconcile.toolforge.org:443 (0ms)
12:47:53.279 [ refine-standard-recon] Failed to batch recon with load:
{"q0":{"query":"Edward Jones","type":"Q4830453","type_strict":"should"},"q1":{"query":"Dropbox","type":"Q4830453","type_strict":"should"},"q2":{"query":"Novo Nordisk","type":"Q4830453","type_strict":"should"},"q3":{"query":"Nvidia","type":"Q4830453","type_strict":"should"},"q4":{"query":"Farmers Insurance","type":"Q4830453","type_strict":"should"},"q5":{"query":"CHG Healthcare","type":"Q4830453","type_strict":"should"},"q6":{"query":"USAA","type":"Q4830453","type_strict":"should"},"q7":{"query":"Burns & McDonnell","type":"Q4830453","type_strict":"should"},"q8":{"query":"Cisco","type":"Q4830453","type_strict":"should"},"q9":{"query":"Kettering Health Network","type":"Q4830453","type_strict":"should"}} (15ms)
java.net.SocketException: Network is unreachable: connect
at java.net.DualStackPlainSocketImpl.waitForConnect(Native Method)
at java.net.DualStackPlainSocketImpl.socketConnect(Unknown Source)
at java.net.AbstractPlainSocketImpl.doConnect(Unknown Source)
at java.net.AbstractPlainSocketImpl.connectToAddress(Unknown Source)
at java.net.AbstractPlainSocketImpl.connect(Unknown Source)
at java.net.PlainSocketImpl.connect(Unknown Source)
at java.net.SocksSocketImpl.connect(Unknown Source)
at java.net.Socket.connect(Unknown Source)
at org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:339)
at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:142)
at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:373)
at org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:381)
at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:237)
at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:185)
at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:111)
at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:108)
at com.google.refine.model.recon.StandardReconConfig.batchRecon(StandardReconConfig.java:478)
at com.google.refine.operations.recon.ReconOperation$ReconProcess.run(ReconOperation.java:282)
at java.lang.Thread.run(Unknown Source)
12:47:53.357 [..mpl.execchain.RetryExec] I/O exception (java.net.SocketException) caught when processing request to {s}->https://wdreconcile.toolforge.org:443: Network is unreachable: connect (78ms)
12:47:53.357 [..mpl.execchain.RetryExec] Retrying request to {s}->https://wdreconcile.toolforge.org:443 (0ms)
12:47:53.372 [..mpl.execchain.RetryExec] I/O exception (java.net.SocketException) caught when processing request to {s}->https://wdreconcile.toolforge.org:443: Network is unreachable: connect (15ms)
12:47:53.373 [..mpl.execchain.RetryExec] Retrying request to {s}->https://wdreconcile.toolforge.org:443 (1ms)
12:47:53.388 [..mpl.execchain.RetryExec] I/O exception (java.net.SocketException) caught when processing request to {s}->https://wdreconcile.toolforge.org:443: Network is unreachable: connect (15ms)
12:47:53.388 [..mpl.execchain.RetryExec] Retrying request to {s}->https://wdreconcile.toolforge.org:443 (0ms)
12:47:53.403 [ refine-standard-recon] Failed to batch recon with load:
{"q0":{"query":"Publix Super Markets","type":"Q4830453","type_strict":"should"},"q1":{"query":"Cadence","type":"Q4830453","type_strict":"should"},"q2":{"query":"Workday","type":"Q4830453","type_strict":"should"},"q3":{"query":"Progressive Insurance","type":"Q4830453","type_strict":"should"},"q4":{"query":"Adobe","type":"Q4830453","type_strict":"should"},"q5":{"query":"Allianz Life Insurance Co. of North America","type":"Q4830453","type_strict":"should"},"q6":{"query":"Atlantic Health System","type":"Q4830453","type_strict":"should"},"q7":{"query":"Bain & Co.","type":"Q4830453","type_strict":"should"},"q8":{"query":"Sheetz","type":"Q4830453","type_strict":"should"},"q9":{"query":"Hilton","type":"Q4830453","type_strict":"should"}} (15ms)
java.net.SocketException: Network is unreachable: connect
at java.net.DualStackPlainSocketImpl.waitForConnect(Native Method)
at java.net.DualStackPlainSocketImpl.socketConnect(Unknown Source)
at java.net.AbstractPlainSocketImpl.doConnect(Unknown Source)
at java.net.AbstractPlainSocketImpl.connectToAddress(Unknown Source)
at java.net.AbstractPlainSocketImpl.connect(Unknown Source)
at java.net.PlainSocketImpl.connect(Unknown Source)
at java.net.SocksSocketImpl.connect(Unknown Source)
at java.net.Socket.connect(Unknown Source)
at org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:339)
at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:142)
at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:373)
at org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:381)
at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:237)
at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:185)
at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:111)
at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:108)
at com.google.refine.model.recon.StandardReconConfig.batchRecon(StandardReconConfig.java:478)
at com.google.refine.operations.recon.ReconOperation$ReconProcess.run(ReconOperation.java:282)
at java.lang.Thread.run(Unknown Source)
12:47:53.480 [..mpl.execchain.RetryExec] I/O exception (java.net.SocketException) caught when processing request to {s}->https://wdreconcile.toolforge.org:443: Network is unreachable: connect (77ms)
12:47:53.480 [..mpl.execchain.RetryExec] Retrying request to {s}->https://wdreconcile.toolforge.org:443 (0ms)
12:47:53.495 [..mpl.execchain.RetryExec] I/O exception (java.net.SocketException) caught when processing request to {s}->https://wdreconcile.toolforge.org:443: Network is unreachable: connect (15ms)
12:47:53.496 [..mpl.execchain.RetryExec] Retrying request to {s}->https://wdreconcile.toolforge.org:443 (1ms)
12:47:53.511 [..mpl.execchain.RetryExec] I/O exception (java.net.SocketException) caught when processing request to {s}->https://wdreconcile.toolforge.org:443: Network is unreachable: connect (15ms)
12:47:53.511 [..mpl.execchain.RetryExec] Retrying request to {s}->https://wdreconcile.toolforge.org:443 (0ms)
12:47:53.526 [ refine-standard-recon] Failed to batch recon with load:
{"q0":{"query":"World Wide Technology","type":"Q4830453","type_strict":"should"},"q1":{"query":"KPMG","type":"Q4830453","type_strict":"should"},"q2":{"query":"Custom Ink","type":"Q4830453","type_strict":"should"},"q3":{"query":"The Cheesecake Factory","type":"Q4830453","type_strict":"should"},"q4":{"query":"Delta Air Lines","type":"Q4830453","type_strict":"should"},"q5":{"query":"W. L. Gore & Associates","type":"Q4830453","type_strict":"should"},"q6":{"query":"Baptist Health South Florida","type":"Q4830453","type_strict":"should"},"q7":{"query":"Nationwide","type":"Q4830453","type_strict":"should"},"q8":{"query":"Four Seasons Hotels & Resorts","type":"Q4830453","type_strict":"should"},"q9":{"query":"Camden Property Trust","type":"Q4830453","type_strict":"should"}} (15ms)
java.net.SocketException: Network is unreachable: connect
at java.net.DualStackPlainSocketImpl.waitForConnect(Native Method)
at java.net.DualStackPlainSocketImpl.socketConnect(Unknown Source)
at java.net.AbstractPlainSocketImpl.doConnect(Unknown Source)
at java.net.AbstractPlainSocketImpl.connectToAddress(Unknown Source)
at java.net.AbstractPlainSocketImpl.connect(Unknown Source)
at java.net.PlainSocketImpl.connect(Unknown Source)
at java.net.SocksSocketImpl.connect(Unknown Source)
at java.net.Socket.connect(Unknown Source)
at org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:339)
at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:142)
at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:373)
at org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:381)
at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:237)
at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:185)
at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:111)
at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:108)
at com.google.refine.model.recon.StandardReconConfig.batchRecon(StandardReconConfig.java:478)
at com.google.refine.operations.recon.ReconOperation$ReconProcess.run(ReconOperation.java:282)
at java.lang.Thread.run(Unknown Source)
```
|
https://github.com/OpenRefine/OpenRefine/issues/3194
|
https://github.com/OpenRefine/OpenRefine/pull/6006
|
265093b3fc5d2ac6e91c40e7d5a264603731873b
|
12aac2f2cf46ac5a06ecaef5d0cbd7b59e02ddba
| 2020-09-17T18:11:09Z |
java
| 2023-10-23T09:20:18Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,186 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/module/langs/translation-en_GB.json", "extensions/wikidata/module/scripts/dialogs/manage-account-dialog.js", "extensions/wikidata/module/scripts/dialogs/password-login-dialog.html", "extensions/wikidata/module/scripts/dialogs/wikibase-dialog.js", "extensions/wikidata/module/scripts/wikibase-manager.js", "extensions/wikidata/module/styles/dialogs/wikibase-dialog.less"]
|
Display the logo of each Wikibase instance in the login form and Wikibase selection dialog
|
The Wikibase login form now shows the Wikibase logo on the left hand side:
It would be nice if we could have the logo of the selected Wikibase instance instead. This would be immediately recognizable to the user, who would therefore be less likely to enter credentials for another instance.
These logos could also be shown in the UI where we select which instance to work against.
### Proposed solution
The URL of the logo used by the Wikibase instance can be fetched via the API:
https://daap.bannerrepeater.org/w/api.php?action=query&meta=siteinfo&siprop=general%7Cnamespaces%7Cnamespacealiases%7Cstatistics
Which gives a logo URL: https://daap.bannerrepeater.org/w/resources/assets/wiki.png
This would give something like this:
### Alternatives considered
The logo could be added to the manifest, but if we can fetch it from the MediaWiki instance directly I think it simplifies everyone's life if we do that.
### Additional context
We need to think about whether fetching these images from the frontend directly from the remote site could cause security or privacy issues. It seems that it is not more dangerous than visiting the Wikibase instance itself (since that loads the logo too), so I think is is acceptable?
|
https://github.com/OpenRefine/OpenRefine/issues/3186
|
https://github.com/OpenRefine/OpenRefine/pull/3702
|
c3445b102fcb5e0cb99014dfdad5eeb3c81d8d14
|
f5b35a99b3787614d01609840d12f94f1f547393
| 2020-09-13T09:38:39Z |
java
| 2021-04-20T19:05:50Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,180 |
["pom.xml"]
|
Add new Jsoup wholeText() function to get unencoded, un-normalized text from element and children
|
When parsing HTML text it is sometimes advantageous to get the unencoded, un-normalized text and keeping any newlines and whitespaces found. This helps to keep a near exact copy of text within an element in certain situations, for example, multi-line chat/comment threads, etc.
### Proposed solution
Implement Joup's `wholeText()` function introduced last year.
- Ref: https://github.com/jhy/jsoup/blob/master/CHANGES#L275
#### Example HTML
```html
<div class="commentthread_comment_text" id="comment_content_2577697791650773248">
Me : Make a 2nd game ?
<br>Dev : Nah man , too much work.
<br>Me : So what's it gonna be ?
<br>Dev : REMASTER !!!!
<br>
```
and apply new GREL function `wholeText()`
```
value.parseHtml().select("div.commentthread_comment_text")[0].wholeText()
```
parse and output would stay consistent as original, keeping any new lines and whitespaces found
```
Me : Make a 2nd game ?
Dev : Nah man , too much work.
Me : So what's it gonna be ?
Dev : REMASTER !!!!
```
instead of current GREL function `htmlText()` that internally uses Jsoup `text()` where whitespace is normalized and trimmed and new lines are not kept to help disambiguate further in certain situations:
```
value.parseHtml().select("div.commentthread_comment_text")[0].htmlText()
```
which outputs as
```
Me : Make a 2nd game ? Dev : Nah man , too much work. Me : So what's it gonna be ? Dev : REMASTER !!!!
```
### Alternatives considered
play chess? buy more Tesla stock?
### Additional context
Docs: https://jsoup.org/apidocs/org/jsoup/nodes/Element.html#wholeText()
|
https://github.com/OpenRefine/OpenRefine/issues/3180
|
https://github.com/OpenRefine/OpenRefine/pull/6206
|
c6b78d66f8fa8e4cd79c17fa40dd9f19fcfcdbed
|
4d7d8f72a088ee27b8a60e9b84041bf939ea72c4
| 2020-09-10T20:14:20Z |
java
| 2023-12-04T23:25:57Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,173 |
["pom.xml"]
|
Reconciliation Guess Types error causes web client to hang
|
An error received in response to the "guess types" call at the beginning of reconciliation causes the web client to hang with the spinner up forever.
The response is of the form:
`{code: "error", message: "org.apache.http.conn.HttpHostConnectException: Con…] failed: Connection refused (Connection refused)", stack: "org.apache.http.conn.HttpHostConnectException: Con…pClientConnectionOperator.java:142)↵ ... 34 more↵"}`
which causes an exception: `TypeError: Cannot read property 'length' of undefined`
here:
https://github.com/OpenRefine/OpenRefine/blob/6095c44cb714f7b1ea6a1eac961b0394ac138a8b/main/webapp/modules/core/scripts/reconciliation/standard-service-panel.js#L55-L57
### Current Results
The web client gets an error and hangs with the spinner up until the page is refreshed.
### Expected Behavior
The user gets a meaningful error message explaining what happened.
### Additional Context
The `reconciliation_service_skeleton` example reconciliation service doesn't work with Python 3 and can be used to reproduce the issue.
|
https://github.com/OpenRefine/OpenRefine/issues/3173
|
https://github.com/OpenRefine/OpenRefine/pull/6206
|
c6b78d66f8fa8e4cd79c17fa40dd9f19fcfcdbed
|
4d7d8f72a088ee27b8a60e9b84041bf939ea72c4
| 2020-09-07T19:15:34Z |
java
| 2023-12-04T23:25:57Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,172 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/views/data-table/menu-reconcile.js"]
|
"Reconcile > Use values as identifiers" does not reconcile
|
### To Reproduce
Run "Reconcile" > "Use values as identifiers" on any column, whether it contains properly-formatted unique IDs for the given service or not. You will see that it seems not to reconcile at all - it only says, whatever your cell contents are, it's 100% matched and generates a real-looking URL, whether or not that URL will resolve.
### Expected Behavior
Reconciliation seems to be missing the part where it actually validates these unique IDs to see if they match up with existing entities. I expect failures to say so.
### Screenshots
I tested on Wikidata and VIAF. VIAF gives no hover-information, the matches just send you to 404s, e.g. http://viaf.org/viaf/Q17291. None of the content in that VIAF column should be matching (Q### is an invalid format) except that first value, which resolves correctly to https://viaf.org/viaf/38242123/.
There are two things happening on Wikidata that I thought I'd mention - IDs that don't exist give the error in the above screenshot. IDs that seem to exist but have yet to be assigned (something that fits the Q### format) look a bit different (so that may be a second bug to work out). I would expect these to have some other kind of obvious error message or flag.
### Versions<!-- (please complete the following information)-->
Windows, Firefox
- OpenRefine: the new 3.4 release, as well as 3.4 beta 2 (last week)
|
https://github.com/OpenRefine/OpenRefine/issues/3172
|
https://github.com/OpenRefine/OpenRefine/pull/4666
|
9c5bde002e44e0fee4f7f124ad58d93eb7f57b52
|
f31ac9e205a30a2e9902fb5d75910fcc44e4fbc7
| 2020-09-07T16:26:33Z |
java
| 2022-04-07T15:27:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,152 |
["pom.xml"]
|
GREL sort() throws NullPointerException when used on arrays that contain nulls
|
`sort()` does not work on arrays that contain `null` values.
### To Reproduce
Steps to reproduce the behavior:
1. Perform a Transform on the following GREL expression
```
[ null, "E09000002", "E05000036", null, "E14000540", null, "E30000234", "E38000004" ].sort()
```
### Current Results
In Expression preview the following is shown:
`Error: java.lang.NullPointerException`
### Expected Behavior
`sort()` should still work and perhaps default to nulls last as a convenience for users.
Optionally, a Boolean parameter could be added to `sort()` for users to override the default nulls last behavior.
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Firefox latest
- JRE or JDK Version: JDK8
- OpenRefine: openrefine-3.4-beta-514-gaa43445
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
I think instead of defaulting to the NullPointerException, instead we could still allow sorting of arrays that contain null values and place nulls first or last with a new sort() Boolean parameter for nullsLast.
https://github.com/OpenRefine/OpenRefine/blob/master/main/src/com/google/refine/expr/functions/arrays/Sort.java#L55
To do that we could use java.util.Comparator https://www.tutorialspoint.com/How-to-sort-an-array-of-objects-containing-null-elements-in-java
|
https://github.com/OpenRefine/OpenRefine/issues/3152
|
https://github.com/OpenRefine/OpenRefine/pull/6134
|
6162ec34f817d19406dfafd8307f18c636f7e65d
|
4569aec10719483fa4ab57b7a3bcacee7a7dd96e
| 2020-08-31T00:32:06Z |
java
| 2023-11-03T20:38:12Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,149 |
["main/src/com/google/refine/grel/controls/ForEach.java", "main/tests/server/src/com/google/refine/RefineTest.java", "main/tests/server/src/com/google/refine/expr/functions/GetTests.java", "main/tests/server/src/com/google/refine/grel/GrelTests.java", "main/tests/server/src/com/google/refine/grel/controls/ForEachTests.java"]
|
Extend forEach() to support JSON objects as well as arrays
|
Currently `forEach()` support native arrays, JSON arrays, and collections, but not JSON objects. Adding JSON objects would would allow parsing payloads like:
* Wikimedia Commons -> https://commons.wikimedia.org/w/api.php?action=query&titles=File:Google%202015%20logo.svg&prop=imageinfo&iiprop=url&format=json
* MySociety MapIt -> https://mapit.mysociety.org/point/4326/0.1293497,51.5464828
### Proposed solution
Extend `forEach()` to allow JSON objects as well as arrays for the first argument.
### Alternatives considered
This is the simplest version of #3147.
|
https://github.com/OpenRefine/OpenRefine/issues/3149
|
https://github.com/OpenRefine/OpenRefine/pull/3150
|
ad0d30aed8d429739d0219c25ef04d0d9b0606b5
|
aa43445c994e5700c74acc6805d2ffaf2fd36cb5
| 2020-08-30T00:39:39Z |
java
| 2020-08-30T06:40:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,147 |
["main/resources/com/google/refine/grel/ControlEvalError.properties", "main/src/com/google/refine/grel/ast/VariableExpr.java", "main/src/com/google/refine/grel/controls/ForEachIndex.java", "main/tests/server/src/com/google/refine/grel/controls/ForEachIndexTests.java"]
|
Implement `forEachItem` for JSON object
|
Users have ongoing complaints about the difficult in parsing JSON which has arbitrary structure, most often in the form of JSON API responses which were designed to return objects keyed by arbitrary identifiers rather than just returning array as the vast more of APIs do.
Examples provided in #2186 include:
* Wikimedia Commons -> https://commons.wikimedia.org/w/api.php?action=query&titles=File:Google%202015%20logo.svg&prop=imageinfo&iiprop=url&format=json
* MySociety MapIt -> https://mapit.mysociety.org/point/4326/0.1293497,51.5464828
And the issue has been discussed both on the OpenRefine mailing list and StackOverflow:
* https://groups.google.com/d/msg/openrefine/O72bg8GZkj8/vBoEzmGxBwAJ
* https://stackoverflow.com/questions/10782737/google-refine-iterate-over-a-json-dictionary
### Proposed solution
Similar to the `forEachIndex` function that we have for arrays, we would implement a `forEachItem` iterator control which would accept a JSON node object, two variable names (one for key and one for value), and a GREL expression. It would iterate over each item in the JSON object, assigning the string value of the key to the key variable and the value for the item to the value variable and then execute the GREL expression.
The control would **only** accept a JSON object to iterate over and would explicitly **not** support iterating over objects that implement the `HasFields` interface.
### Alternatives considered
* extend `forEach()` to iterate over JSON object items. This wouldn't provide access to the field name / key, but would probably satisfy the vast majority of cases since the key is usually included in the child object as an id.
* implement iteration for every object that implements HasFields. Since OpenRefine `HasFields` objects typically have a small fixed set of fields, this seems to have limit value.
|
https://github.com/OpenRefine/OpenRefine/issues/3147
|
https://github.com/OpenRefine/OpenRefine/pull/5997
|
c457bc44b9f8a530dccc7ad81c95598824bb6ada
|
e22c23a63bbd63beea3e87591701af5975ba7c35
| 2020-08-29T22:43:20Z |
java
| 2023-08-08T04:42:29Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,143 |
["docs/docs/manual/grelfunctions.md", "main/src/com/google/refine/expr/functions/math/RandomNumber.java", "main/src/com/google/refine/grel/ControlFunctionRegistry.java", "main/tests/server/src/com/google/refine/expr/functions/math/RandomNumberTest.java", "main/tests/server/src/com/google/refine/grel/FunctionTests.java"]
|
Enhance randomNumber() function
|
The `randomNumber()` function currently takes two Number arguments, converts them to integers and returns a random number in the open interval.
### Proposed solution
I think the following changes would improve the function:
- shorten the name to just `random()`
- create a 0-arg version which returns a Double in the interval 0.0 - 1.0
- provide two alternatives for the 2-arg version which return either an Long or a Double, depending on type of the parameters which are passed in
### Alternatives considered
- the 2-arg integer version could have a different name like `randint` a la Python
- a variant that accepts a seed value could be useful for those who want reproducible results
|
https://github.com/OpenRefine/OpenRefine/issues/3143
|
https://github.com/OpenRefine/OpenRefine/pull/4672
|
4e5414fc50804f461239aaeb2f6ec07238b71957
|
0573be98f488121ea80e79e3cc548ac69bca5b0f
| 2020-08-29T20:38:04Z |
java
| 2022-04-15T18:48:33Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,141 |
["main/webapp/modules/core/scripts/dialogs/add-column-by-reconciliation.js", "main/webapp/modules/core/scripts/reconciliation/standard-service-panel.js", "main/webapp/modules/core/scripts/util/custom-suggest.js", "main/webapp/modules/core/scripts/views/data-table/cell-renderers/recon-renderer.js", "main/webapp/modules/core/scripts/views/data-table/menu-reconcile.js"]
|
XSS vulnerability in suggest flyouts
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
The flyout services in reconciliation endpoints can return arbitrary HTML which is directly included in the DOM without sanitization:
https://reconciliation-api.github.io/specs/latest/#flyout-services
This means that reconciliation services can execute arbitrary Javascript in the user's browser when they hover a suggested item in an autocompleted field.
**Describe the solution you'd like**
Drop flyout services.
**Describe alternatives you've considered**
Change the specs so that the flyout services only return data following a fixed schema (a description string, for instance, but that would be redundant with the description that can be returned in the suggest responses directly).
Or cook up some way to sanitize the HTML returned by the service, by removing `<script>` tags for instance, but that is bound to be brittle.
**Additional context**
Similar to #3140.
|
https://github.com/OpenRefine/OpenRefine/issues/3141
|
https://github.com/OpenRefine/OpenRefine/pull/6045
|
fbed8f7eeacb5ceb88b717cb1c6b61adaa6efd63
|
fdb112a664759db7c83d437d0e6b02104f2f4eae
| 2020-08-29T20:28:27Z |
java
| 2023-09-21T04:59:57Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,140 |
["main/webapp/modules/core/scripts/views/data-table/cell-renderers/recon-renderer.js"]
|
Sandbox reconciliation candidate preview iframes
|
We display the entity previews returned by reconciliation services using an `<iframe>`, which lets services return arbitrary HTML pages for their entities.
These pages could potentially contain scripts, which could do all sorts of things, including talking to the backend, which can be considered a security vulnerability.
Reconciliation services are already able to execute arbitrary javascript in the user's browser when they add the service with its URL, because of the JSONP-based fetching method.
### Solution proposed
Use the `<iframe sandbox="">` attribute to disable scripts and other APIs:
https://developer.mozilla.org/fr/docs/Web/HTML/Element/iframe#attr-sandbox
Perhaps `sandbox=""` is too restrictive, we should review its impact on a few existing public reconciliation endpoints.
### Alternative solutions
Should we use another mechanism than iframes? It seems difficult to let services expose arbitrary previews without relying on that.
### Relevant code
https://github.com/OpenRefine/OpenRefine/blob/6095c44cb714f7b1ea6a1eac961b0394ac138a8b/main/webapp/modules/core/scripts/views/data-table/cell-ui.js#L468-L477
|
https://github.com/OpenRefine/OpenRefine/issues/3140
|
https://github.com/OpenRefine/OpenRefine/pull/6103
|
135050ee35363625daac165961b4fa5f589c76dd
|
a74297af935b8615e6ee9a3fe06b883e5f13e14d
| 2020-08-29T12:37:29Z |
java
| 2023-10-18T07:32:14Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,133 |
["pom.xml"]
|
Improve accuracy of returned error message for toString()
|
`toString()` can also be used for Number formatting (not only Date formatting) as evidenced by @tfmorris on the mailing list today.
We should improve the `toString()` error message output here:
https://github.com/OpenRefine/OpenRefine/blob/ded6ca07d1fb1f88f1b7f9bae7e1de6d3c22e311/main/src/com/google/refine/expr/functions/ToString.java#L67
replacing the line with this would help more:
```java
return new EvalError(ControlFunctionRegistry.getFunctionName(this) +
" accepts an object and an optional second String argument containing a date format or number format");
```
|
https://github.com/OpenRefine/OpenRefine/issues/3133
|
https://github.com/OpenRefine/OpenRefine/pull/6089
|
b4154aab26b205889da7eaa8dd44b982e5143b19
|
38e117d8dfacc9e93cc26aa8404b1134c3acb636
| 2020-08-26T19:00:46Z |
java
| 2023-10-07T06:54:07Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,132 |
["main/src/com/google/refine/model/recon/StandardReconConfig.java"]
|
Increase read timeout for reconciliation
|
The old reconciliation endpoint, which remains the default one we ship unless we merge #3087, is pretty slow and can take a few seconds for a single query. Therefore the read timeout should be ample: I would propose 60 seconds.
### To Reproduce
Steps to reproduce the behavior:
1. Reconcile to Wikidata
### Current Results
For expensive queries (for instance many properties supplied in the query):
```
java.net.SocketTimeoutException: Read timed out
at java.base/java.net.SocketInputStream.socketRead0(Native Method)
at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
at java.base/java.net.SocketInputStream.read(SocketInputStream.java:168)
at java.base/java.net.SocketInputStream.read(SocketInputStream.java:140)
at java.base/sun.security.ssl.SSLSocketInputRecord.read(SSLSocketInputRecord.java:467)
at java.base/sun.security.ssl.SSLSocketInputRecord.readHeader(SSLSocketInputRecord.java:461)
at java.base/sun.security.ssl.SSLSocketInputRecord.bytesInCompletePacket(SSLSocketInputRecord.java:70)
at java.base/sun.security.ssl.SSLSocketImpl.readApplicationRecord(SSLSocketImpl.java:1349)
at java.base/sun.security.ssl.SSLSocketImpl$AppInputStream.read(SSLSocketImpl.java:958)
at org.apache.http.impl.io.SessionInputBufferImpl.streamRead(SessionInputBufferImpl.java:137)
at org.apache.http.impl.io.SessionInputBufferImpl.fillBuffer(SessionInputBufferImpl.java:153)
at org.apache.http.impl.io.SessionInputBufferImpl.readLine(SessionInputBufferImpl.java:282)
at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:138)
at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56)
at org.apache.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:259)
at org.apache.http.impl.DefaultBHttpClientConnection.receiveResponseHeader(DefaultBHttpClientConnection.java:163)
at org.apache.http.impl.conn.CPoolProxy.receiveResponseHeader(CPoolProxy.java:165)
at org.apache.http.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:273)
at org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:125)
at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:272)
at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:185)
at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:111)
at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:108)
at com.google.refine.model.recon.StandardReconConfig.batchRecon(StandardReconConfig.java:477)
at com.google.refine.operations.recon.ReconOperation$ReconProcess.run(ReconOperation.java:282)
```
This means that reconciliation is skipped for some cells.
### Expected Behavior
Reconciliation succeeds.
### Versions<!-- (please complete the following information)-->
- Operating System: Debian
- Browser Version: irrelevant
- JRE or JDK Version: 11
- OpenRefine: master branch
|
https://github.com/OpenRefine/OpenRefine/issues/3132
|
https://github.com/OpenRefine/OpenRefine/pull/3156
|
64a003777e352f29679123c9de2e009a9485fb93
|
37ae9a3d51a27de3a4ce2db18a4416dadcff9cb8
| 2020-08-26T08:27:11Z |
java
| 2020-09-02T17:16:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,108 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/module/scripts/dialogs/manage-account-dialog.js", "extensions/wikidata/module/scripts/dialogs/password-login-dialog.html"]
|
Wikidata extension - discourage use of main password
|
From https://github.com/OpenRefine/OpenRefine/pull/2810#discussion_r458339637
The Wikidata/wikibase extension supports the use of login by password which puts the user's password at risk, so we should encourage them to use a so-called "bot" account/password so that they can limit its privileges, revoke it easily, etc.
Since these accounts appear to always have an embedded at sign (@), that might be one way to check that users are following this best practice and warn them if they aren't.
|
https://github.com/OpenRefine/OpenRefine/issues/3108
|
https://github.com/OpenRefine/OpenRefine/pull/3190
|
b9db24d96273c0c80573377d2d86e1f86d149b8b
|
79eac0b8113f295c48b7152461e373beb0433e43
| 2020-08-22T15:10:56Z |
java
| 2020-09-30T14:31:36Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,088 |
["main/webapp/modules/core/about.html"]
|
Obsolete and missing Javascript files on About page
|
Neither of these files which are referenced from about.html exist: https://github.com/OpenRefine/OpenRefine/blob/fc21d58ed11af8e512be5fd5852a281c88791fb7/main/webapp/modules/core/about.html#L46-L47
They should be replaced with the current version of jQuery and the script which now contains OpenRefine version info.
|
https://github.com/OpenRefine/OpenRefine/issues/3088
|
https://github.com/OpenRefine/OpenRefine/pull/3090
|
fc21d58ed11af8e512be5fd5852a281c88791fb7
|
591d47abe3158d35c1bee681be38624b2042e23c
| 2020-08-17T00:07:06Z |
java
| 2020-08-17T11:16:11Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,082 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/views/data-table/cell-editor.html", "main/webapp/modules/core/scripts/views/data-table/cell-ui.js"]
|
Improve handling of dates in cell editing UI
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
Say you want to manually edit a cell to input a date there. This is what it currently looks like:
The problems are:
* As a user, how do I know which formats are supported? Especially if I start with a text value and want to transform it to a date, I should not have to refer to the user manual to find out how to format it.
* When I try to input a wrong date, a JS alert pops up: "Not a valid date." That is not very helpful!
**Describe the solution you'd like**
Find a way to add a short description of the supported format(s) to the dialog itself, and/or improve the error message to mention the formats.
**Describe alternatives you've considered**
We could consider using an off-the-shelf date picker but it is not clear to me whether that would be really more user-friendly in a data cleaning context. Perhaps it could be used optionally, with still the ability to modify the date textually?
**Additional context**
Brought up in a documentation meeting with @allanaaa and @thadguidry.
|
https://github.com/OpenRefine/OpenRefine/issues/3082
|
https://github.com/OpenRefine/OpenRefine/pull/4973
|
51cbca21495cdb1708735be78e919f585303e092
|
e03779d085e590a1641f83b5db43e32f2cba695b
| 2020-08-15T12:42:06Z |
java
| 2022-08-01T19:45:51Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,069 |
["extensions/pc-axis/module/MOD-INF/controller.js", "extensions/pc-axis/module/langs/translation-en.json", "extensions/pc-axis/module/scripts/pc-axis-parser-ui.js", "main/webapp/modules/core/MOD-INF/controller.js", "main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/index/default-importing-controller/parsing-panel.js"]
|
Importer names not internationalized (i18n)
|
These strings in controller.js need to be internationalized so that they can be translated:
https://github.com/OpenRefine/OpenRefine/blob/0ce5c5de13e63ad63c95af08366a4d5a4ba2aadd/main/webapp/modules/core/MOD-INF/controller.js#L207-L229
I haven't looked into how they are being fetched/used, so this may not be completely straightforward.
|
https://github.com/OpenRefine/OpenRefine/issues/3069
|
https://github.com/OpenRefine/OpenRefine/pull/3104
|
f10df46f2682db32077c378e48a42515cd4cefc7
|
047d7c2de47523e0b045511f925f019ddf57b9a9
| 2020-08-12T16:26:18Z |
java
| 2020-10-01T09:31:29Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,064 |
["extensions/wikidata/src/org/openrefine/wikidata/schema/WbItemDocumentExpr.java", "extensions/wikidata/src/org/openrefine/wikidata/schema/WbReferenceExpr.java", "extensions/wikidata/src/org/openrefine/wikidata/schema/WbStatementExpr.java", "extensions/wikidata/src/org/openrefine/wikidata/schema/WbStatementGroupExpr.java", "extensions/wikidata/src/org/openrefine/wikidata/schema/WikibaseSchema.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbItemDocumentExprTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbReferenceExprTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbStatementExprTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbStatementGroupExprTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WikibaseSchemaTest.java"]
|
Make Wikibase schema classes properly immutable
|
### To Reproduce
The classes that constitute the wikibase schema (in `org.openrefine.wikidata.schema`) are meant to be immutable.
But many of the getters in these classes return lists, which are not immutable in Java.
This means that it is possible to modify these lists after getting them from the schema classes, which should be forbidden. This can lead to subtle bugs, see #3060.
### Current Results
Getters of Wikibase schema classes return modifiable lists.
### Expected Behavior
The returned lists should be unmodifiable. Wrapping with `Collections.immutableList()` should be enough (it is only an unmodifiable wrapper around a list, without actually copying the list).
|
https://github.com/OpenRefine/OpenRefine/issues/3064
|
https://github.com/OpenRefine/OpenRefine/pull/3070
|
0ce5c5de13e63ad63c95af08366a4d5a4ba2aadd
|
f50efb3699012ea539e9f0f4cfc63399a5ea7b12
| 2020-08-12T07:58:57Z |
java
| 2020-08-13T07:59:54Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,061 |
["main/src/com/google/refine/importers/TextFormatGuesser.java", "main/tests/server/src/com/google/refine/importers/TextFormatGuesserTests.java"]
|
TSV based content from Clipboard importer is detected as Excel
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
### To Reproduce
Steps to reproduce the behavior:
1. Using Clipboard importer, paste in the below Dataset TSV content example
2. Click Next
### Current Results
Error message:
> Attempted to parse as an Excel file but failed. Try to use Excel to re-save the file as a different Excel version or as TSV and upload again.
### Expected Behavior
**CSV / TSV / separator-based files** Importer should have been detected first.
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Firefox latest
- JRE or JDK Version: JDK8
- OpenRefine: openrefine-3.4-beta-458-g109aa78
### Datasets
TSV content
```tsv
Species BodyWeight(kg) BrainWeight(kg) Brain-to-Body-Weight_Proportion
Newborn_Human 3.2 0.374984813 0.117182754
Adult_Human 73 1.349981613 0.018492899
Pithecanthropus_Man 70 0.925010921 0.013214442
Squirrel 0.8 0.007620352 0.00952544
Hamster 0.15 0.001406136 0.009374242
Chimpanzee 50 0.419981176 0.008399624
Rabbit 1.4 0.011521246 0.008229462
Dog_(Beagle) 10 0.071985109 0.007198511
Cat 4.5 0.029982456 0.006662768
Rat 0.4 0.001995806 0.004989516
Bottle-Nosed_Dolphin 400 1.49998461 0.003749962
Beaver 24 0.044996363 0.001874848
Gorilla 320 0.502489628 0.00157028
Tiger 170 0.263491808 0.001549952
Owl 1.5 0.002222603 0.001481735
Camel 550 0.761989823 0.001385436
Elephant 4600 5.999983798 0.001304344
Lion 187 0.239995723 0.0012834
Sheep 120 0.139978605 0.001166488
Walrus 800 0.925010921 0.001156264
Horse 450 0.502489628 0.001116644
Cow 700 0.441481454 0.000630688
Giraffe 950 0.532018491 0.000560019
Green_Lizard 0.2 9.07185E-05 0.000453592
Sperm_Whale 35000 7.799974401 0.000222856
Turtle 3 0.000317515 0.000105838
Alligator 270 0.008391459 3.10795E-05
```
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/3061
|
https://github.com/OpenRefine/OpenRefine/pull/3068
|
62ae8ae946690c8d1282ef472d3a50fcabc05086
|
fc21d58ed11af8e512be5fd5852a281c88791fb7
| 2020-08-11T17:43:31Z |
java
| 2020-08-16T08:35:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,059 |
["docs/docs/manual/installing.md", "docs/docs/manual/running.md", "docs/docs/manual/starting.md", "docs/src/css/custom.css"]
|
Our documentation needs some design tweaks
|
Our Docusaurus install (https://docs.openrefine.org/) needs some customization. Guides and tools are here:
https://v2.docusaurus.io/docs/styling-layout
My preferences:
- more negative space, especially above a new section header (margin-top of 60-80px would be great)
- more space between the sections in the TOC sidebar, perhaps less space between the h3-equivalent list items
- slightly bigger header sizes
- images should be centred within the article
- text inside infoboxes should be the same colour as the rest of the text (i.e. black in normal mode, white in dark mode)
- better colours for the infoboxes, within the limits of accessible contrasts (and taking light/dark modes into account)
Please share your own preferences!
**Describe the solution you'd like**
For infoboxes, it appears they're very sparingly used in other docs, and almost nobody is using more than one kind. So, we might want to follow their example and pick only one type to use for everything. Colour-wise, something desaturated works for me. Nothing so bold that you eyes go to that information first, to the detriment of the rest of the text.
A few examples:
- Clutch (docusaurus) has very pale blue boxes with off-black text and colourful fill on the icon. I'm a big fan of these. No dark mode version to critique though.
https://clutch.sh/docs/getting-started/docker
- Vector (docusaurus) is using caution infoboxes with the same background colour as their code boxes, but with a yellow stripe and an emphasized icon. I really like this as well.
https://vector.dev/docs/setup/installation/package-managers/nix
Infobox in blue: https://vector.dev/docs/setup/configuration/
Alert box in red: https://vector.dev/docs/reference/sources/docker
- Microsoft uses a purple (in dark mode) for its note boxes that I quite like - less intrusive without being too pastel or faded. In light mode it's a lavender that I'm ambivalent about.
https://docs.microsoft.com/en-us/powershell/scripting/install/migrating-from-windows-powershell-51-to-powershell-7?view=powershell-7
- ComponentKit (docusaurus) is using a red-pink combo that I think is terrible.
https://componentkit.org/docs/actions
|
https://github.com/OpenRefine/OpenRefine/issues/3059
|
https://github.com/OpenRefine/OpenRefine/pull/3178
|
95b9e58da7af158a5a5346bfa0589bd4b56b345c
|
cb69a90a64014b55c46ca3c09adfb6d40227b3cc
| 2020-08-11T17:03:03Z |
java
| 2020-09-16T13:21:56Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,056 |
["pom.xml"]
|
Infinite Scroll algorithm suggestions
|
@lisa761 @wetneb The PR #2746 has gotten a bit unwieldy for discussion, so I've created this as a place to discuss the infinite scrolling algorithm. The current algorithm uses a "chunk" size of 100 rows and 2 (or 3?) chunks. I'm guessing that most displays have a viewport into this buffer of on the order of 40-50 rows unless the user has a large portrait mode monitor. On my reasonably fast laptop, 100 rows takes approximately 1000 msec to render, which is probably an order of magnitude more than we want.
I think by making the chunk size much smaller (on the order of 5-10 rows) we can smooth things out, reduce lag, and reduce the cost of "mistakes" where we've requested something that's no longer useful. I was envisioning something with an asymmetric sliding window with more buffer in the scrolling direction when I came across this Google [blog post](https://developers.google.com/web/updates/2016/07/infinite-scroller) with its concept of "runway" which is very similar to what I was envisioning. The other thing that realized is that their "tombstone" paradigm is a much better way of addressing the blank screen problem than the spinner that I suggested.
I don't know how much work it would be to incorporate some of these ideas at this stage of the game, but some useful optimizations are:
- request data and render rows in much smaller chunks (<=10 rows)
- check that received data is still useful before rendering it (cut our losses early for any wasted work)
- delete/recycle rows as a separate lower priority background job (as long as we don't fall too far behind)
- continue to optimize the rendering by reusing elements wherever possible rather than creating them anew
- use pre-rendered "tombstone" elements as space fillers
The biggest point is to do work in smaller chunks. I think it's going to be very hard to make the current chunk size of 100 rows smooth enough.
|
https://github.com/OpenRefine/OpenRefine/issues/3056
|
https://github.com/OpenRefine/OpenRefine/pull/6023
|
cfbf548ffba224bd36ec74c5228f302a58fcfe43
|
79c51c854d932f4fd5c44fef3090a4e294f2982a
| 2020-08-11T04:15:34Z |
java
| 2023-08-22T18:54:16Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,054 |
["extensions/gdata/module/scripts/gdata-extension.js", "extensions/gdata/module/scripts/index/gdata-source-ui.js"]
|
Can't login to Google to access private Sheets / Drive
|
It's impossible to login in when attempting to import from Google Sheets / Drive, because the spinner is shown instead of the "sign-in and authorize button"
### To Reproduce
Steps to reproduce the behavior:
1. When clicking on Google Data there is immediately a small spinner next to Authorized Documents.
### Current Results
I get a **Preparing**... spinner on the screen.
### Expected Behavior
No small spinner for Authorized Documents when first clicking on Google Drive options to Create Project.
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Firefox latest
- JRE or JDK Version: JDK8
- OpenRefine: OpenRefine 3.4 Beta SNAPSHOT
|
https://github.com/OpenRefine/OpenRefine/issues/3054
|
https://github.com/OpenRefine/OpenRefine/pull/3612
|
ff0b81e0f08b0f99d5136c7e951a75258eb98daf
|
8b459d69e3538539bbe2d2fd50ba36bf37768609
| 2020-08-11T00:20:28Z |
java
| 2021-02-11T18:50:10Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,047 |
["main/src/com/google/refine/history/HistoryEntry.java"]
|
Fix project metadata dates
|
In #1383 the project creation and modification dates were changed to the `LocalDateTime` datatype, but this can't represent a point in time (because it has no time zone info), so is completely inappropriate for this use.
This was actually one of the few areas of OpenRefine where `java.util.Date` was perfectly appropriate and suited to the use, so it didn't need to be change. ~~All projects which were written since this change are going to have dates which are only knowable within a 24 hour window, not precisely.~~
We can go back to `java.util.Date` or use fancy new `OffsetDateTime` or `Instant` but it should get serialized as ISO 8601 at UTC and formatted using the user's locale & timezone.
|
https://github.com/OpenRefine/OpenRefine/issues/3047
|
https://github.com/OpenRefine/OpenRefine/pull/6176
|
f329963e41db4b19a3a99d66686296af9cfbdd2d
|
307d8bf9147c1fb41b8013efb5fe14d9cb490277
| 2020-08-08T21:13:41Z |
java
| 2023-11-26T01:33:06Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,043 |
["main/src/com/google/refine/importing/ImportingUtilities.java", "main/tests/server/src/com/google/refine/importing/ImportingUtilitiesTests.java"]
|
ImportingUtilities.allocateFile might not detect some malicious file names
|
It appears `com.google.refine.importing.ImportingUtilities.allocateFile(File, String)` might not detect some malicious file names. However, I am not familiar with this project so hopefully someone more familiar with it can confirm or deny whether these cases are actually problematic.
Sorry in case these are false alerts.
### Not checking file being same as directory
`allocateFile` does not check whether the resolved file name is equivalent to the directory. This can for example be the case when the file name
- is an empty string
- consists only of single periods or slashes: `.`, `///`, `././.`, ...
- uses double periods: `ignored/..`
All these file names pass the `startsWith` sanitization check and only in case the directory already exists would be renamed in the loop. Otherwise they would be returned as they are and might cause issues.
### Rename loop might allow directory traversal
When the result file name is already taken, `allocateFile` tries to construct an alternative file name. However, if an adversary knows the directory structure they can create a file name which, when transformed, allows directory traversal.
For example, let's assume the `dir` parameter argument is `C:/User/Test/temp`. An adversary could then use the file name `"./../../Test/temp"` (respectively `"../../../User/Test/temp"`):
```java
// ImportingUtilities.allocateFile(File, String) code
File file = new File(dir, name); // file = "C:/User/Test/temp/./../../Test/temp"
if (!file.toPath().normalize().startsWith(dir.toPath().normalize())) {
throw new IllegalArgumentException("Zip archives with files escaping their root directory are not allowed.");
}
int dot = name.indexOf('.');
String prefix = dot < 0 ? name : name.substring(0, dot); // prefix = ""
String suffix = dot < 0 ? "" : name.substring(dot); // suffix = "./../../Test/temp"
int index = 2;
while (file.exists()) { // File already exists
// file = "C:/User/Test/temp/-2./../../Test/temp"
file = new File(dir, prefix + "-" + index++ + suffix);
}
```
The resulting file would then be `C:/User/Test/temp/-2./../../Test/temp` (normalized: `C:/User/Test/Test/temp`) which is outside the intended directory `C:/User/Test/temp`. Though the adversary is restricted to the parent directory names and cannot choose arbitrary directory names.
|
https://github.com/OpenRefine/OpenRefine/issues/3043
|
https://github.com/OpenRefine/OpenRefine/pull/4237
|
226a1baeea2c4786bdd64aae92f8be6e8c4c43db
|
30a0f6643dc6c8802940e90b6b68c47fae7d89e8
| 2020-08-07T23:46:43Z |
java
| 2021-10-23T07:01:14Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,039 |
["main/pom.xml"]
|
Speed up git commit extraction in Maven config
|
Extracting the commit information from the git repository when running `mvn compile` can take some time. There are ways to speed it up:
https://github.com/git-commit-id/git-commit-id-maven-plugin/issues/462
|
https://github.com/OpenRefine/OpenRefine/issues/3039
|
https://github.com/OpenRefine/OpenRefine/pull/3040
|
e38d586a0e0fc554937385d05a286af50e09e5e2
|
47df8196700382ab9a86e4bf560435dad0edcddb
| 2020-08-07T08:23:28Z |
java
| 2020-08-07T18:57:46Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,033 |
["docs/docs/manual/cellediting.md"]
|
Document clustering algorithms
|
The documentation on the clustering algorithms is scant, and in some cases, non-existent. The user interface should provide a brief description of each algorithm as well as guidance on how to pick the most appropriate one for their application as well as any pertinent tradeoffs.
Some are obvious from their names (or at least easily Google-able), but other are much more opaque.
PPM is a particularly egregious example, but since I just looked at the implementation, here's what it does:
PPM stands for [Prediction by Partial Matching](https://en.wikipedia.org/wiki/Prediction_by_partial_matching) which is an arithmetic coding technique. The implementation that OpenRefine uses is based on the MIT SIMILE project's Vicino package, which, in turn, uses Bob Carpenter's arithcode package, which has a tutorial available here: https://raw.githubusercontent.com/bob-carpenter/java-arithcode/master/arithcode-1.2/doc/tutorial.html. The two strings to be compared are concatenated together and then "compressed" using the coder. The PPMModel uses 8 bytes of context and returns as the score the length of the encoded output. This is used four times to compute distance scores for (x,y), (y,x), (x,x), (y,y) (because the scores are directional) which are then combined together in this fashion to generate a final score:
`10.0d * ((d(x,y) + d(y,x)) / (d(x,x) + d(y,y)) - 1.0d)`
This score is relatively computationally expensive to compute and has to be done in a pairwise fashion for every pair of strings. To prevent an N^2 explosion, both the "nearest neighbor" clustering algorithms first divide the strings into manageable sized blocks and only does the pairwise comparison for members of the block. Depending on the blocking algorithm used, it's possible for two similar strings to end up in different blocks and never get compared to each other.
|
https://github.com/OpenRefine/OpenRefine/issues/3033
|
https://github.com/OpenRefine/OpenRefine/pull/4718
|
c9c958366a0a306531b6e3880d9b92e2a8d4cc27
|
4e5414fc50804f461239aaeb2f6ec07238b71957
| 2020-08-06T01:13:19Z |
java
| 2022-04-15T10:06:22Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,031 |
["pom.xml"]
|
Update docusaurus to more recent version to validate internal links
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
It would be nice if the Docusaurus build could fail when the docs contain broken internal links. This is enabled by default in more recents versions of Docusaurus v2:
https://v2.docusaurus.io/docs/docusaurus.config.js#onbrokenlinks
The feature should initially be disabled while @allanaaa writes up the missing pages.
**Describe alternatives you've considered**
We could also consider validating external links.
**Additional context**
Discussed during a documentation meeting
|
https://github.com/OpenRefine/OpenRefine/issues/3031
|
https://github.com/OpenRefine/OpenRefine/pull/5938
|
d51b234da4031d62e13c7bded05d5137e2f076d0
|
4eb77ebff0ac942b3b12a7db0e296d14956f1ec9
| 2020-08-04T15:51:36Z |
java
| 2023-06-19T19:29:15Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,028 |
["main/webapp/modules/core/scripts/views/data-table/cell-ui.js"]
|
Preview popup is "cropped" for items in the bottom of the screen
|
For last rows (in the bottom of the screen), the popup is partly invisible.
### Expected Behavior
Move the popup up to see it entirely
### Screenshots
<img width="634" alt="OpenRefine - Preview popup cropped" src="https://user-images.githubusercontent.com/2158081/89255924-3f27e500-d623-11ea-87ea-4576bd2c8d27.png">
|
https://github.com/OpenRefine/OpenRefine/issues/3028
|
https://github.com/OpenRefine/OpenRefine/pull/3706
|
91c3cc734def9be4a40f07021577ac0baa5d0b95
|
efca0bee2c42311b5a28b094992aaaa14ee3c793
| 2020-08-04T05:24:50Z |
java
| 2021-03-10T15:14:12Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,026 |
["main/src/com/google/refine/expr/functions/ToDate.java", "main/src/com/google/refine/util/ParsingUtilities.java", "main/tests/server/src/com/google/refine/expr/functions/strings/ToFromConversionTests.java", "main/tests/server/src/com/google/refine/io/ProjectMetadataTests.java", "main/tests/server/src/com/google/refine/util/ParsingUtilitiesTests.java"]
|
ToDate("2012-03-01","XXX") test failure & wasted conversion attempts
|
I'm investigating a local test failure which I'm unsure whether is specific to OS X or just how timezones are set up on my particular machine.
The failing test is:
Assert.assertEquals(invoke("toDate", "2012-03-01","XXX"), invoke("toDate", "2012-03-01"));
which returns 2012-03-01T01:00:00 instead of 2012-03-01T00:00:00
This appears to have something to do with the default fallthrough case here, perhaps due to Daylight Savings Time: https://github.com/OpenRefine/OpenRefine/blob/306b541c699e7e87d5e08be1310575b85b15dbf0/main/src/com/google/refine/expr/functions/ToDate.java#L170-L172
While investigating this, I came across this code:
https://github.com/OpenRefine/OpenRefine/blob/306b541c699e7e87d5e08be1310575b85b15dbf0/main/src/com/google/refine/expr/functions/ToDate.java#L135-L145
which I don't completely understand, but in the test case creates an array with 160 copies of the (invalid) code "XXX" which it then uses to attempt to parse the date 160 times, always failing, before falling back to the code above
|
https://github.com/OpenRefine/OpenRefine/issues/3026
|
https://github.com/OpenRefine/OpenRefine/pull/3027
|
6bcc2bfbe98bbe74441529509e658b556ed4f2cc
|
55edae2b7bb835bd2ed87cd8ab35e49d64c41767
| 2020-08-03T21:29:29Z |
java
| 2020-08-09T11:53:43Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,007 |
["extensions/database/pom.xml"]
|
sameSite attribute not set correctly
|
Javascript warning in Firefox console regarding cookies and "sameSite" attribute when switching the expression language.
### To Reproduce
Steps to reproduce the behavior:
1. Open Expression Editor
2. Then change language from GREL to Python
3. See warning
### Current Results
```
Cookie “scripting.lang” will be soon rejected because it has the “sameSite” attribute set to “none” or an invalid
value, without the “secure” attribute. To know more about the “sameSite“ attribute, read
https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite
project-bundle.js:10919:96
```
### Expected Behavior
no warning in Firefox Console
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Firefox latest
- JRE or JDK Version: JDK8
- OpenRefine: openrefine-3.4-beta-388-g1dcc832
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/3007
|
https://github.com/OpenRefine/OpenRefine/pull/6223
|
0e7bf3c5081f7cf5c73899ea8e4bc8dc07678365
|
e0a980785d2a4cbe4908bfa066f8c96e4778150a
| 2020-07-28T23:55:07Z |
java
| 2023-12-06T21:27:37Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,002 |
["docs/yarn.lock"]
|
Assertion failed: Input argument is not an HTMLInputElement
|
While helping @tfmorris with testing Jquery on #2933 and using latest SNAPSHOT OpenRefine `openrefine-3.4-beta-388-g1dcc832` and using Firefox latest the Debugger throws an error:
### To Reproduce
Steps to reproduce the behavior:
1. Open Developer Tools - Console on Firefox
2. Create new project with Clipboard
3. Paste in `a,b,c`
4. Hit Enter key
### Current Results
`TypeError: n is undefined`
thrown in onloadwff.js:71
seems to be around the if() condition for `if("password"===n.type)` ?
```
Assertion failed: Input argument is not an HTMLInputElement onloadwff.js:71:836526
```
### Expected Behavior
not sure what is currently supposed to happen. I'm not sure why the focus is changing, since the cursor was blinking after the `a,b,c` in the clipboard prior to me hitting the ENTER key.
I assumed that the Enter key is mapped to the Next button on the Clipboard importer?
And should have clicked it for me and gone to Preview screen? dunno for sure now with current OpenRefine keyboard shortcut key handling or with changes with FF debugger handling and it's causing some weird issue?
#### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
* OpenRefine Clipboard prior to hitting ENTER key:
* Debugger is immediately thrown up for me in Firefox:
* Console:
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Firefox latest
- JRE or JDK Version: JDK8
- OpenRefine: openrefine-3.4-beta-388-g1dcc832
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/3002
|
https://github.com/OpenRefine/OpenRefine/pull/4167
|
0dc2414fd0b1f47f946b080ecd5dd6bea212a82a
|
3d243ba98c297fea5fad07ab8e0bf4b2887aacf9
| 2020-07-28T20:13:25Z |
java
| 2021-09-21T06:03:40Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,990 |
["extensions/database/pom.xml"]
|
Dialog to add a reconciliation service does not open
|
_Originally posted at https://github.com/wetneb/openrefine-wikibase/issues/84 by @pyrog_
On **Safari** Version 13.0.4 (14608.4.9.1.4), the box to add a reconciliation service don't open.
Work fine on **Chrome** and **Firefox**.
Console:
```
SyntaxError: Unexpected token '}'
(fonction anonyme) — project:74
project-bundle.js:10335
```
<img width="630" alt="Can't add a reconciliation service on Safari" src="https://user-images.githubusercontent.com/2158081/88482061-205c8b00-cf5f-11ea-99fd-3a26a0b00e79.png">
|
https://github.com/OpenRefine/OpenRefine/issues/2990
|
https://github.com/OpenRefine/OpenRefine/pull/6214
|
0df3cbcafcb3f25626133f6b66040328358514f5
|
e0110d300b7a4369839dafbd8d9129c70afae10a
| 2020-07-26T15:30:12Z |
java
| 2023-12-06T08:08:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,987 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/index/default-importing-controller/file-selection-panel.html", "main/webapp/modules/core/scripts/index/default-importing-controller/file-selection-panel.js"]
|
Importing problem when we choose two or more files.
|
When you choose two files (.xml and .csv)extensions then it will not work properly in importing.
If we checked only one file at a time then it work fine but we click back and checked another extension file then it will not guessed the right file.
### To Reproduce
Steps to reproduce the behavior:
1. First, go to "This computer"
2. Then, choose two files at a time [TestFiles](https://drive.google.com/drive/folders/1skaTnzTcTuLJM1HLYC7t6iAh4NN7AB0E?usp=sharing)
3. And press "Configure Parsing Options"
4. and see what happens
### Current Results
(This issue is more understand by these two videos )
### Expected Behavior
give an error when we parse two file at a time.
### Versions<!-- (please complete the following information)-->
- Operating System: Ubuntu 18.04
- Browser Version: Chrome
|
https://github.com/OpenRefine/OpenRefine/issues/2987
|
https://github.com/OpenRefine/OpenRefine/pull/3011
|
0ebd89c952ef6f57b716d62ceb75a271bb1c0100
|
04309dcfb40a87a5f273fdd170027a5604fdef95
| 2020-07-25T13:48:12Z |
java
| 2020-08-03T12:15:39Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,980 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/index/default-importing-controller/parsing-panel.js"]
|
Create Project > multiple files > preview: "Back" button not displaying properly
|
When you start a project by loading an archive file with multiple files inside, there is a "Back" button loaded next to "Start Over" on the preview page. But the "Back" button isn't actually displaying.
### To Reproduce
Steps to reproduce the behavior:
1. Create a project with a .zip or etc.
2. Then, you see a file-selection screen.
3. Finally, the preview screen loads with a malfunctioning "Back" button.
### Screenshots
### Versions<!-- (please complete the following information)-->
3.4 beta 2
Windows 10
Firefox, and I reproduced it in Chrome
|
https://github.com/OpenRefine/OpenRefine/issues/2980
|
https://github.com/OpenRefine/OpenRefine/pull/2989
|
602149db6ea5bd8ad76bf530c4fa423220eb0bea
|
86ec7e6b40bb190bc47634b2b2fd3ba28a465a26
| 2020-07-22T17:39:15Z |
java
| 2020-07-26T07:08:50Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,971 |
["eclipse-debug-config.png"]
|
eclipse-debug-config.png image in root
|
A file `eclipse-debug-config.png` was accidentally added to the repo root. This should be removed.
|
https://github.com/OpenRefine/OpenRefine/issues/2971
|
https://github.com/OpenRefine/OpenRefine/pull/2972
|
a4e5e49aaf3f2b659c6553a95511d65e7a43b364
|
a312859fb1e9f6374036fa0e59ba66effb3605e0
| 2020-07-21T11:54:20Z |
java
| 2020-07-21T12:39:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,962 |
["extensions/database/pom.xml"]
|
MARC import failure - java.lang.NoClassDefFoundError: com/ibm/icu/text/Normalizer
|
It looks like the MARC importer has a missing transitive dependency which triggers a failure with certain MARC input files (but not all). The attached example file is one that triggers the error (unzip it first).
```
java.lang.NoClassDefFoundError: com/ibm/icu/text/Normalizer
at org.marc4j.MarcPermissiveStreamReader.getDataAsString(MarcPermissiveStreamReader.java:1310)
at org.marc4j.MarcPermissiveStreamReader.parseDataField(MarcPermissiveStreamReader.java:1006)
at org.marc4j.MarcPermissiveStreamReader.parseRecord(MarcPermissiveStreamReader.java:777)
at org.marc4j.MarcPermissiveStreamReader.next(MarcPermissiveStreamReader.java:289)
at com.google.refine.importers.MarcImporter.createParserUIInitializationData(MarcImporter.java:76)
at com.google.refine.importing.DefaultImportingController.doInitializeParserUI(DefaultImportingController.java:216)
```
[scriblio.mrc.zip](https://github.com/OpenRefine/OpenRefine/files/4942290/scriblio.mrc.zip)
|
https://github.com/OpenRefine/OpenRefine/issues/2962
|
https://github.com/OpenRefine/OpenRefine/pull/6214
|
0df3cbcafcb3f25626133f6b66040328358514f5
|
e0110d300b7a4369839dafbd8d9129c70afae10a
| 2020-07-18T19:00:08Z |
java
| 2023-12-06T08:08:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,961 |
["server/pom.xml", "server/src/com/google/refine/Refine.java"]
|
Replace jdatapath dependency with Java 8 user home directory finding
|
We currently use an obscure dependency, `jdatapath`, to find the user's home directory on Windows. Since Java 8 was taught how to do that correctly itself, we should switch to that and drop the dependency.
`System.getProperty("user.home")` or `org.apache.commons.lang3.SystemUtils.getUserHome()`
https://stackoverflow.com/questions/585534/what-is-the-best-way-to-find-the-users-home-directory-in-java
|
https://github.com/OpenRefine/OpenRefine/issues/2961
|
https://github.com/OpenRefine/OpenRefine/pull/3840
|
5c891e6ad7d4f13f2fd99fea7e7d5e9b104f8436
|
1654cd31b1b967bc23a5df921b65b2c24dce8395
| 2020-07-18T17:18:44Z |
java
| 2021-06-10T06:09:09Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,960 |
["extensions/database/pom.xml"]
|
Update to official marc4j distribution
|
Instead of using our own self-published artefact, we should update to the latest official `marc4j` which is currently `org.marc4j:marc4j:2.9.1`
|
https://github.com/OpenRefine/OpenRefine/issues/2960
|
https://github.com/OpenRefine/OpenRefine/pull/6214
|
0df3cbcafcb3f25626133f6b66040328358514f5
|
e0110d300b7a4369839dafbd8d9129c70afae10a
| 2020-07-18T17:09:34Z |
java
| 2023-12-06T08:08:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,959 |
["main/pom.xml"]
|
Update Vicino for N-gram clusterer bug fix
|
We've got a bug fix for the SIMILE Vicino N-gram clusterer sitting at https://github.com/OpenRefine/simile-vicino/commit/e9e9eda18bf905f5a0ee6c04cc6a1b48d621b8c0 which never got published. We should publish a new version with the bug fix and update OpenRefine to use it.
We could use this opportunity to clean up the OpenRefine dependencies a little by:
- [x] switching to the official `secondstring` dependency from the original author instead of publishing our own (resolved in https://github.com/OpenRefine/simile-vicino/pull/1/
- [x] switching vicino bzip2 dependency to use Apache commons-compress instead of ant-tools, as we've done for OpenRefine (resolved in https://github.com/OpenRefine/simile-vicino/pull/1/)
- [x] updating to arithcode-1.2. This is a very minor release, but it includes tests, which is a plus. (pending in https://github.com/OpenRefine/simile-vicino/pull/2/)
- [x] moving the `secondstring` and `arithcode` dependencies from OpenRefine to https://github.com/OpenRefine/simile-vicino
|
https://github.com/OpenRefine/OpenRefine/issues/2959
|
https://github.com/OpenRefine/OpenRefine/pull/2998
|
c60e4e0b2a0f3d47d776ef74c71fbd04e679ccad
|
db42bcab927e49bfff7801bce42437c4c75044a2
| 2020-07-18T17:03:31Z |
java
| 2020-07-28T06:19:58Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,936 |
["extensions/database/pom.xml"]
|
Default Windows workspace directory got changed
|
**Describe the bug**
In the process of changing a number of installation settings for OpenRefine (including changing JAVA_HOME, installing Java, installing JDK, changing the workspace directory in the .ini file and then removing it, changing memory, etc.), OpenRefine's default behaviour changed from storing my workspace directory in
`C:\Users\(user id)\AppData\Local\OpenRefine`
(where it had been since I installed it)
to
`C:\Users\(user id)\AppData\Roaming\OpenRefine`
(where it found nothing).
Specifically, I:
- installed OpenRefine (a long time ago)
- created lots of projects in the default Local directory (a long time ago)
- changed the workspace directory using the .ini file (last week)
- deleted that line in the .ini file (last week)
- started OpenRefine (yesterday) and discovered that it was using Roaming, and thus not finding any projects.
For the time being I am manually setting the .ini file:
`-Drefine.data_dir=C:\Users\Allana\AppData\Local\OpenRefine`
**To Reproduce**
I am not sure which change I made caused this issue, since I made a number of changes last week. (I did not uninstall or reinstall OpenRefine itself.)
I think generally knowing when OpenRefine uses Local and when it uses Roaming will help narrow it down.
**Expected behavior**
OpenRefine should always default back to the same workspace directory where no manual settings exist, no matter what changes happen later.
**Desktop:**
- OS: Windows 10
- Browser Version: Firefox 78.0.2
- JRE 1.8.0_251
**OpenRefine:**
- Version 3.4 beta 2
**Log**
> 11:44:05.950 [ refine_server] Starting Server bound to '127.0.0.1:3333' (0ms)
> 11:44:05.961 [ refine_server] Initializing context: '/' from 'D:\Program Files\openrefine-3.4-beta2\webapp' (11ms)
> 11:44:09.549 [ refine_server] Failed to use jdatapath to detect user data path: resorting to environment variables (3588ms)
> 11:44:09.551 [ refine_server] Failed to use jdatapath to detect user data path: resorting to environment variables (2ms)
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in [jar:file:/D:/Program%20Files/openrefine-3.4-beta2/server/target/lib/slf4j-log4j12-1.7.18.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in [jar:file:/D:/Program%20Files/openrefine-3.4-beta2/webapp/WEB-INF/lib/slf4j-log4j12-1.7.18.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 11:44:09.718 [ refine] Starting OpenRefine 3.4-beta2 [c67e13b]... (167ms)
> 11:44:09.718 [ refine] initializing FileProjectManager with dir (0ms)
> 11:44:09.719 [ refine] C:\Users\Allana\AppData\Roaming\OpenRefine (1ms)
|
https://github.com/OpenRefine/OpenRefine/issues/2936
|
https://github.com/OpenRefine/OpenRefine/pull/6214
|
0df3cbcafcb3f25626133f6b66040328358514f5
|
e0110d300b7a4369839dafbd8d9129c70afae10a
| 2020-07-14T15:58:41Z |
java
| 2023-12-06T08:08:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,920 |
["pom.xml"]
|
SchemaAlignmentDialog - Uncaught TypeError: Cannot read property 'suggest' of undefined
|
When attempting to load this particular project, which was apparently reconciled against Wikidata, the loading spinner stays up forever and the Javascript console shows that it's trying to reference a null reconciliation service variable:
endpoint = this._reconService.suggest.entity;
```
project-bundle.js:47051 Uncaught TypeError: Cannot read property 'suggest' of undefined
at Object.SchemaAlignmentDialog._initField (project-bundle.js:47051)
at Object.SchemaAlignmentDialog._addItem (project-bundle.js:46463)
at Object.SchemaAlignmentDialog._reset (project-bundle.js:46358)
at Object.SchemaAlignmentDialog.setUpTabs (project-bundle.js:46274)
at Array.<anonymous> (project-bundle.js:47432)
```
Reloading the page is successful, so it's apparently a race condition with something not properly synchronized, but with this particular project it has failed 3 out of 3 times on the first load attempt.
### Current Results
Uncaught TypeError: Cannot read property 'suggest' of undefined
at Object.SchemaAlignmentDialog._initField (project-bundle.js:47051)
at Object.SchemaAlignmentDialog._addItem (project-bundle.js:46463)
at Object.SchemaAlignmentDialog._reset (project-bundle.js:46358)
at Object.SchemaAlignmentDialog.setUpTabs (project-bundle.js:46274)
at Array.<anonymous> (project-bundle.js:47432)
at project-bundle.js:31080
at project-bundle.js:31057
at project-bundle.js:33638
at Object.<anonymous> (project-bundle.js:31676)
at fire (project-bundle.js:3121)
SchemaAlignmentDialog._initField @ project-bundle.js:47051
SchemaAlignmentDialog._addItem @ project-bundle.js:46463
SchemaAlignmentDialog._reset @ project-bundle.js:46358
SchemaAlignmentDialog.setUpTabs @ project-bundle.js:46274
(anonymous) @ project-bundle.js:47432
(anonymous) @ project-bundle.js:31080
(anonymous) @ project-bundle.js:31057
(anonymous) @ project-bundle.js:33638
(anonymous) @ project-bundle.js:31676
fire @ project-bundle.js:3121
fireWith @ project-bundle.js:3233
done @ project-bundle.js:9277
callback @ project-bundle.js:9687
XMLHttpRequest.send (async)
(anonymous) @ VM745:1
send @ project-bundle.js:9633
ajax @ project-bundle.js:9178
next @ project-bundle.js:31670
Ajax.chainGetJSON @ project-bundle.js:31684
HistoryPanel.update @ project-bundle.js:33631
(anonymous) @ project-bundle.js:31062
(anonymous) @ project-bundle.js:31057
Refine.update @ project-bundle.js:31122
ProcessPanel._runOnDones @ project-bundle.js:34154
ProcessPanel._render @ project-bundle.js:34123
(anonymous) @ project-bundle.js:33991
(anonymous) @ project-bundle.js:31676
fire @ project-bundle.js:3121
fireWith @ project-bundle.js:3233
done @ project-bundle.js:9277
callback @ project-bundle.js:9687
XMLHttpRequest.send (async)
(anonymous) @ VM745:1
send @ project-bundle.js:9633
ajax @ project-bundle.js:9178
next @ project-bundle.js:31670
Ajax.chainGetJSON @ project-bundle.js:31684
ProcessPanel.update @ project-bundle.js:33987
ProcessPanel @ project-bundle.js:33964
initializeUI @ project-bundle.js:30914
(anonymous) @ project-bundle.js:31350
(anonymous) @ project-bundle.js:30981
fire @ project-bundle.js:3121
fireWith @ project-bundle.js:3233
done @ project-bundle.js:9277
callback @ project-bundle.js:9687
XMLHttpRequest.send (async)
(anonymous) @ VM745:1
send @ project-bundle.js:9633
ajax @ project-bundle.js:9178
jQuery.<computed> @ project-bundle.js:9324
(anonymous) @ project-bundle.js:30969
fire @ project-bundle.js:3121
fireWith @ project-bundle.js:3233
done @ project-bundle.js:9277
callback @ project-bundle.js:9687
XMLHttpRequest.send (async)
(anonymous) @ VM745:1
send @ project-bundle.js:9633
ajax @ project-bundle.js:9178
jQuery.<computed> @ project-bundle.js:9324
getJSON @ project-bundle.js:9307
(anonymous) @ project-bundle.js:30955
fire @ project-bundle.js:3121
fireWith @ project-bundle.js:3233
done @ project-bundle.js:9277
callback @ project-bundle.js:9687
XMLHttpRequest.send (async)
(anonymous) @ VM745:1
send @ project-bundle.js:9633
ajax @ project-bundle.js:9178
jQuery.<computed> @ project-bundle.js:9324
getJSON @ project-bundle.js:9307
Refine.reinitializeProjectData @ project-bundle.js:30945
onLoad @ project-bundle.js:31348
fire @ project-bundle.js:3121
fireWith @ project-bundle.js:3233
ready @ project-bundle.js:3445
completed @ project-bundle.js:3476
### Expected behavior
Project loads successfully.
### Screenshots
### Versions
- OS: macOS Mojave
- Browser Version: Chrome 83
- java version "1.8.0_171"
Java(TM) SE Runtime Environment (build 1.8.0_171-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.171-b11, mixed mode)
- OpenRefine 3.5-SNAPSHOT
|
https://github.com/OpenRefine/OpenRefine/issues/2920
|
https://github.com/OpenRefine/OpenRefine/pull/6264
|
e180416252d4321a510b8031cd3e54a4c3fb51c8
|
fba818fadeaec38caafb2bef8c5faab082811477
| 2020-07-12T00:13:29Z |
java
| 2023-12-27T17:49:13Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,917 |
["main/pom.xml", "server/pom.xml"]
|
java.lang.NoClassDefFoundError: org/json/JSONException on startup of 3.4-beta2
|
Extensions which have a dependency on org.json and depend on OpenRefine to include it rather than bundling it themselves will fail to initialize with the above NoClassDefFoundError. This is a general problem with dynamically loading extensions that have missing dependencies or other class loader issues.
Butterfly attempts to deal with module loading issues by catching `Exception` as a catch-all, but because this is an `Error`, it is not a subclass of `Exception`.
### Steps to reproduce the behavior:
1. Download 3.4-beta2 Windows kit
2. Unzip
3. Double click openrefine.exe
4. See error
I killed it quickly because I realized that I wasn't sure I'd backed up my workspace directory, so not sure if it would have finished starting up.
### Current results
15:26:29.926 [ refine_server] Starting Server bound to '127.0.0.1:3333' (0ms)
15:26:29.984 [ refine_server] Initializing context: '/' from 'C:\Users\tfmorris\Downloads\openrefine-win-with-java-3.4-beta2\openrefine-3.4-beta2\webapp' (58ms)
...
Exception in thread "main" java.lang.NoClassDefFoundError: org/json/JSONException
at java.lang.Class.getDeclaredMethods0(Native Method)
at java.lang.Class.privateGetDeclaredMethods(Unknown Source)
at java.lang.Class.privateGetPublicMethods(Unknown Source)
at java.lang.Class.getMethods(Unknown Source)
at org.mozilla.javascript.JavaMembers.discoverAccessibleMethods(JavaMembers.java:380)
at org.mozilla.javascript.JavaMembers.discoverAccessibleMethods(JavaMembers.java:335)
at org.mozilla.javascript.JavaMembers.reflect(JavaMembers.java:450)
at org.mozilla.javascript.JavaMembers.<init>(JavaMembers.java:76)
at org.mozilla.javascript.JavaMembers.lookupClass(JavaMembers.java:838)
at org.mozilla.javascript.NativeJavaClass.initMembers(NativeJavaClass.java:84)
at org.mozilla.javascript.NativeJavaClass.<init>(NativeJavaClass.java:78)
at org.mozilla.javascript.NativeJavaPackage.getPkgProperty(NativeJavaPackage.java:164)
at org.mozilla.javascript.NativeJavaPackage.get(NativeJavaPackage.java:114)
at org.mozilla.javascript.ScriptableObject.getProperty(ScriptableObject.java:1617)
at org.mozilla.javascript.ScriptRuntime.getObjectProp(ScriptRuntime.java:1437)
at org.mozilla.javascript.ScriptRuntime.getObjectProp(ScriptRuntime.java:1423)
at org.mozilla.javascript.gen.c10._c0(file:/C:/Users/tfmorris/AppData/Roaming/OpenRefine/extensions/rdf-extension/MOD-INF/controller.js:4)
at org.mozilla.javascript.gen.c10.call(file:/C:/Users/tfmorris/AppData/Roaming/OpenRefine/extensions/rdf-extension/MOD-INF/controller.js)
at org.mozilla.javascript.ContextFactory.doTopCall(ContextFactory.java:398)
at org.mozilla.javascript.ScriptRuntime.doTopCall(ScriptRuntime.java:3065)
at org.mozilla.javascript.gen.c10.call(file:/C:/Users/tfmorris/AppData/Roaming/OpenRefine/extensions/rdf-extension/MOD-INF/controller.js)
at org.mozilla.javascript.gen.c10.exec(file:/C:/Users/tfmorris/AppData/Roaming/OpenRefine/extensions/rdf-extension/MOD-INF/controller.js)
at edu.mit.simile.butterfly.ButterflyModuleImpl.initScope(ButterflyModuleImpl.java:619)
at edu.mit.simile.butterfly.ButterflyModuleImpl.scriptInit(ButterflyModuleImpl.java:629)
at edu.mit.simile.butterfly.ButterflyModuleImpl.init(ButterflyModuleImpl.java:94)
at edu.mit.simile.butterfly.Butterfly.initializeModule(Butterfly.java:476)
at edu.mit.simile.butterfly.Butterfly.configure(Butterfly.java:451)
at edu.mit.simile.butterfly.Butterfly.init(Butterfly.java:308)
at org.mortbay.jetty.servlet.ServletHolder.initServlet(ServletHolder.java:440)
at org.mortbay.jetty.servlet.ServletHolder.doStart(ServletHolder.java:263)
at com.google.refine.RefineServer.configure(Refine.java:291)
at com.google.refine.RefineServer.init(Refine.java:203)
at com.google.refine.Refine.init(Refine.java:109)
at com.google.refine.Refine.main(Refine.java:103)
Caused by: java.lang.ClassNotFoundException: org.json.JSONException
at java.net.URLClassLoader.findClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
... 34 more
### Expected behavior
Although it's generally discourage to catch Errors, in this case it makes sense to do so, although the exception handling may need to go in Butterfly rather than OpenRefine.
|
https://github.com/OpenRefine/OpenRefine/issues/2917
|
https://github.com/OpenRefine/OpenRefine/pull/2919
|
83ed9ffdaf3304eaec935c59ed5a60c6a2cd1117
|
a49ce47a87b21ebc071e7f877d3e8406d43ce728
| 2020-07-10T19:59:39Z |
java
| 2020-07-23T18:14:37Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,916 |
["extensions/wikibase/module/styles/dialogs/wikibase-dialog.css", "main/webapp/modules/core/MOD-INF/controller.js", "main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/reconciliation/recon-dialog-2.html", "main/webapp/modules/core/scripts/reconciliation/recon-dialog-2.js", "main/webapp/modules/core/scripts/reconciliation/recon-dialog.html", "main/webapp/modules/core/scripts/reconciliation/recon-dialog.js", "main/webapp/modules/core/scripts/views/data-table/column-header-ui.js", "main/webapp/modules/core/scripts/views/data-table/menu-reconcile.js", "main/webapp/modules/core/styles/reconciliation/recon-dialog.css"]
|
Simplify the Services dialog for reconciliation
|
The current slide handling for Services dialog for reconciliation is not ideal.
As mentioned in #1658 , this could probably be improved.
Currently the slider icon looks like an old product price tag to me, so not the best choice for a slider icon. It should be an close X icon and also we should simplify the handling by introducing a visibility toggle icon as well or another button (to do the visibility toggle) called "Services..." next to the existing button "Add Standard Service...". Instead of keeping the slide effect that retains the price tag icon and sliver of the Services panel shown on the left edge.
Something like this behavior: https://material.io/components/sheets-side#standard-side-sheet
_Originally posted by @thadguidry in https://github.com/OpenRefine/OpenRefine/issues/1658#issuecomment-656778345_
|
https://github.com/OpenRefine/OpenRefine/issues/2916
|
https://github.com/OpenRefine/OpenRefine/pull/6118
|
78f939d60c12bab930e57f8ceeec8946fba128c2
|
f856713fd81af6629178e38d93fe55016529204b
| 2020-07-10T17:14:49Z |
java
| 2023-12-07T10:33:20Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.