status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,273 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
Migrate to a new documentation platform
|
We want to get ourselves better docs than those we have on the GitHub wiki at the moment.
We need to decide which documentation system to use, where to host it, and so on. Let's use this issue to map the possibilities we are aware of. I will start:
* Sphinx: documentation system based on reStructuredText or Markdown, which can be hosted for free on ReadTheDocs. Example docs: https://editgroups.readthedocs.io/en/latest/
* Gitbook: based on Markdown, it looks like it can be hosted on gitbook.com. Example docs: https://devdocs.foodsharing.network/
* I really like Django's docs - not sure if the framework is reusable though: https://docs.djangoproject.com/en/3.0/topics/
I think our docs should be:
- [ ] versioned: one sub-site per version, ideally without duplicating content too much to keep things maintainable?
- [ ] translated: it should be easy for people who currently contribute on Weblate to also translate the docs.
Any other requirements we should have? Which existing docs should we take inspiration from?
|
https://github.com/OpenRefine/OpenRefine/issues/2273
|
https://github.com/OpenRefine/OpenRefine/pull/3906
|
84956e2896326e1a8f1bf7076d9375c5ce2761b5
|
4537f5f46f0ce77cff461d882852f7dccfa6fcfb
| 2020-01-06T18:03:37Z |
java
| 2021-05-15T06:55:30Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,268 |
["docs/yarn.lock"]
|
Migrate from old private fork of OpenCSV
|
We are currently using a custom snapshot of OpenCSV which is years old. The OpenCSV project is still active and a lot of releases have been published since then. We should look into upgrading to a newer version, which would also let us get rid of the locally stored .jar.
|
https://github.com/OpenRefine/OpenRefine/issues/2268
|
https://github.com/OpenRefine/OpenRefine/pull/3044
|
47df8196700382ab9a86e4bf560435dad0edcddb
|
1f5f0df6247d94c2097c34794cd5a1c92a0f1a11
| 2019-12-29T15:26:02Z |
java
| 2020-08-08T00:20:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,266 |
["pom.xml"]
|
Coveralls integration seems broken
|
https://coveralls.io/github/OpenRefine/OpenRefine has not been updated for months, coveralls info is not available on PRs: this needs to be fixed.
|
https://github.com/OpenRefine/OpenRefine/issues/2266
|
https://github.com/OpenRefine/OpenRefine/pull/2759
|
e75d3c655a7abf1ef3e304490379d5d0055a8b10
|
ed781271422637d6c332b26a741bb84e9fc6e04d
| 2019-12-27T14:09:52Z |
java
| 2020-06-19T19:22:19Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,248 |
["extensions/database/pom.xml"]
|
Extraction of column dependencies from expressions
|
_This is work package 1 in our [2020 roadmap](http://openrefine.org/images/czi-eoss-proposal.pdf)._
Expressions are used in operations and facets to compute values from the tabular data.
Determining which column an expression depends on requires the ability to analyze expressions and extract the variables it reads. Performing this analysis requires changing the `Evaluable` interface implemented by our expression languages (currently GREL, Jython and Clojure bydefault) to allow for such an inspection.
For instance, assume a project with the columns `customer_id`, `name`, `address`, `country` and `num_orders`. One could create a column joining `address` and `country` into a new column `new_address`, using the expression `join([coalesce(cells['address'].value,''),coalesce(cells['country'].value,'')],' ')`.
This expression only depends on the columns `address` and `country`.
One could add a blank facet on the `customer_id` column, which uses the GREL expression `isBlank(value)`: this only depends on the `customer_id` column.
Some expressions rely on all columns, for instance, `filter(row.columnNames,cn,isNonBlank(cells[cn].value))` depends on all columns in the project (even if they are not explicitly named in the expression).
We need to implement an extraction method which can extract an over-approximation of the set of columns an expression depends on. This means that the extraction can give up: in this case we assume that the expression could depend on all columns.
This requires traversing the abstract syntax tree (AST) of the expression to analyze which variables it relies on. This can be done easily for GREL but requires more work for other interpreters.
## First prototype
- [x] Add method `Set<String> getColumnDependencies(String baseColumn)` to the `Evaluable` interface, which returns `null` if it gives up;
- [x] Implement a simple extraction method for GREL expressions;
- [x] Leave the other languages unanalyzed (give up all the time).
This will already work for the majority of the expressions encountered in a simple OpenRefine workflow and will let us make progress on the rest of the work which depends on this.
## Long term
Given that we already have plans to migrate from Jython to GraalPython, we propose to carry out this migration and implement this analysis using the Truffle library (which is used to define interpreters in the Graal framework). The AST analysis could then be implemented in a relatively generic way by using Truffle's API to manipulate expressions.
Related issues:
- Add Graalpython interpreter, which adds support for Python 3 as expression language (#2249);
- Potentially add other Graal-based expression languages, such as [Graaljs](https://github.com/graalvm/graaljs), for #911 or [Fastr](https://github.com/oracle/fastr), for #1226;
- Rewrite GREL using the Truffle framework (#2250);
- Expose GREL functions (such as cross) in other expression languages via Truffle (#2251);
- Write a Truffle-based AST extractor to perform column dependency extraction uniformly in all expression languages which use Truffle.
If pulling in the Truffle framework turns out not to be workable, as a fallback strategy we can also implement AST analysis directly with Jython, if it exposes its AST API in a satisfactory way.
|
https://github.com/OpenRefine/OpenRefine/issues/2248
|
https://github.com/OpenRefine/OpenRefine/pull/4174
|
c10d7fcd1d9a3d429ba1bde2799622247aa20a33
|
c84bfe17c8ced992619c9a3c0d53ad60b907d4e5
| 2019-12-16T09:58:59Z |
java
| 2021-09-24T05:49:30Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,244 |
["extensions/wikidata/src/org/openrefine/wikidata/schema/WbQuantityExpr.java", "extensions/wikidata/src/org/openrefine/wikidata/schema/WbStringVariable.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbQuantityExprTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbStringVariableTest.java"]
|
OpenRefine incorrectly saves to Wikidata statements with a value over 2,147,483,647
|
I used OpenRefine 3.3-beta to add statements with a numeric value to Wikidata (statements with _P2769: budget_ to be exact). For all statements which had a value over 2,147,483,647 (2<sup>31</sup>-1) it saved the statements with the value of exactly 2,147,483,647.
For example:
in OpenRefine while preparing a new statement for _Q4294878: Ministry of Justice of Ukraine_ everything was fine, the correct value of 14,341,937,500 was displayed.
But after saving it to Wikidata, it turned out it saved an incorrect value.
Here is the edit: https://www.wikidata.org/w/index.php?title=Q4294878&type=revision&diff=1074857426&oldid=1055945359
And it did this not only with this value, but all of them bigger than 2,147,483,647.
I used Opera on Windows 10.
My OpenRefine project, just in case:
[Budget-of-Ukraine-for-year-2020.openrefine.tar.gz](https://github.com/OpenRefine/OpenRefine/files/3957651/Budget-of-Ukraine-for-year-2020.openrefine.tar.gz)
So, I suggest you should use Int64 or bigger one instead.
|
https://github.com/OpenRefine/OpenRefine/issues/2244
|
https://github.com/OpenRefine/OpenRefine/pull/2246
|
21504a60d5cbdd58d0eed037c9342a6db5dbeaf1
|
909d3476509789a0c1613694e633688efc6a84e2
| 2019-12-12T20:13:21Z |
java
| 2019-12-16T07:19:21Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,242 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
Allow importing of flat file ODS, and not only ZIPPED (PK) representation
|
**Describe the bug**
Importing a flat file OpenDocument representation results in a Java Exception.
**To Reproduce**
Steps to reproduce the behavior:
1. Import example `1996-2000.ods` file attached.
2. See error popup dialog
**Current Results**
```
09:28:10.739 [ refine] POST /command/core/importing-controller (5ms)
09:28:10.740 [ open office] Error reading ODF spreadsheet (1ms)
java.lang.IllegalArgumentException: org.odftoolkit.odfdom.pkg.OdfValidationException; The ODF package shall be a ZIP file!
at org.odftoolkit.odfdom.pkg.OdfPackage.readZip(OdfPackage.java:360)
at org.odftoolkit.odfdom.pkg.OdfPackage.initializeZip(OdfPackage.java:349)
at org.odftoolkit.odfdom.pkg.OdfPackage.<init>(OdfPackage.java:245)
at org.odftoolkit.odfdom.pkg.OdfPackage.loadPackage(OdfPackage.java:300)
at org.odftoolkit.odfdom.doc.OdfDocument.loadDocument(OdfDocument.java:221)
at com.google.refine.importers.OdsImporter.createParserUIInitializationData(OdsImporter.java:89)
at com.google.refine.importing.DefaultImportingController.doInitializeParserUI(DefaultImportingController.java:216)
```
**Expected behavior**
OpenRefine should allow importing both OpenDocument format representations.
Ref: https://en.wikipedia.org/wiki/OpenDocument_technical_specification
1. ZIP
2. flat files
We state that we support .ods format on the import ui, this leads users to conclude both representations could be imported, but actually only ZIP representation is supported currently it seems in OpenRefine.
We should support flat file ODS as well, because some tools/libraries still use/create both 2 representations of ODS files.
**Desktop (please complete the following information):**
- OS: Windows 10
- Browser Version: Firefox
- JRE or JDK Version: openjdk-13.0.1_windows-x64_bin\jdk-13.0.1
**OpenRefine (please complete the following information):**
- Version: OpenRefine 3.3-beta [c8eaaee]
**Datasets**
Extract the zip file (had to zip in order to attach to this Github issue)
[1996-2000.zip](https://github.com/OpenRefine/OpenRefine/files/3956472/1996-2000.zip)
**Additional context**
Does OdfToolkit have any classes to allow flat file ODS to be loaded?
https://github.com/tdf/odftoolkit/blob/master/odfdom/src/main/java/org/odftoolkit/odfdom/pkg/OdfPackage.java
https://odftoolkit.org/api/odfdom/org/odftoolkit/odfdom/pkg/OdfPackage.html#loadPackage-java.io.File-java.lang.String-org.xml.sax.ErrorHandler-
|
https://github.com/OpenRefine/OpenRefine/issues/2242
|
https://github.com/OpenRefine/OpenRefine/pull/3906
|
84956e2896326e1a8f1bf7076d9375c5ce2761b5
|
4537f5f46f0ce77cff461d882852f7dccfa6fcfb
| 2019-12-12T15:48:00Z |
java
| 2021-05-15T06:55:30Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,238 |
["main/src/com/google/refine/commands/cell/SplitMultiValueCellsCommand.java", "main/src/com/google/refine/operations/cell/MultiValuedCellSplitOperation.java", "main/tests/server/src/com/google/refine/operations/cell/SplitMultiValuedCellsTests.java", "main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/views/data-table/menu-edit-cells.js", "main/webapp/modules/core/scripts/views/data-table/split-multi-valued-cells-dialog.html"]
|
add new option for spliting multi-valued cells: by transition between lowercase and uppercase, and number and text
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
I discoverd interesting options in MS PowerQuery. It could be nice to have the same in OR : split by transition between lowercase and uppercase, split by transition between number and text
Here is the menu (in french) in PowerQuery :
**Describe the solution you'd like**
**Describe alternatives you've considered**
**Additional context**
|
https://github.com/OpenRefine/OpenRefine/issues/2238
|
https://github.com/OpenRefine/OpenRefine/pull/2471
|
307a52ee95d42eed352f32101462eeb71e5ca691
|
947356ddad43cf4a125ec541046a9c220bb16dc4
| 2019-12-05T12:07:47Z |
java
| 2020-06-15T17:30:18Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,237 |
["extensions/database/pom.xml"]
|
Add new record field for count of rows in a record
|
It would be useful to have a simple field in record that returns the row count of the WrappedRecord.
**Describe the solution you'd like**
Something like `row.record.count` which would return a String of the # number of rows contained in the WrappedRecord.
Example
```
record , data
A , 100
, 200
B , 100
, 200
, 300
```
GREL applied on column "record" to insert a new column "count" containing count of record rows:
`row.record.count`
RESULT:
```
record , data, count
A , 100, 2
, 200, 2
B , 100, 5
, 200, 5
, 300, 5
, 400, 5
, 500, 5
```
**Describe alternatives you've considered**
facetCount() does not count the actual record rows, for instance with
`facetCount(value, "cell.value", "record")`
**Additional context**
As discussed on [mailing list here](https://groups.google.com/d/topic/openrefine/6iQQzEx19oA/discussion)
|
https://github.com/OpenRefine/OpenRefine/issues/2237
|
https://github.com/OpenRefine/OpenRefine/pull/4174
|
c10d7fcd1d9a3d429ba1bde2799622247aa20a33
|
c84bfe17c8ced992619c9a3c0d53ad60b907d4e5
| 2019-12-05T04:57:13Z |
java
| 2021-09-24T05:49:30Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,233 |
["main/webapp/modules/core/scripts/views/data-table/data-table-view.js"]
|
Translate the "Sort" link
|
**Describe the bug**
When a sort is made, the link "Sort" is displayed. It is not translated when the language of the UI is not english.
I suppose it could be done by editing this line
https://github.com/OpenRefine/OpenRefine/blob/76162cfed150b32e1496bc07082302c35f56c6d7/main/webapp/modules/core/scripts/views/data-table/data-table-view.js#L152
**To Reproduce**
**Current Results**
**Expected behavior**
**Screenshots**
**Desktop (please complete the following information):**
- OS: Win10
- Browser Version: Chrome
- JRE or JDK Version: JRE 1.8.0_231
**OpenRefine (please complete the following information):**
- Version : OpenRefine 3.3 Beta
|
https://github.com/OpenRefine/OpenRefine/issues/2233
|
https://github.com/OpenRefine/OpenRefine/pull/2275
|
d82e5425e5d779d88400f39a39b0c5a704326665
|
e98dd269925acde52a53746e2f90fee735e61a27
| 2019-11-23T11:15:15Z |
java
| 2020-01-08T08:47:42Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,228 |
["extensions/wikidata/src/org/openrefine/wikidata/commands/LoginCommand.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/commands/LoginCommandTest.java"]
|
Wikidata login is not remembered during a session
|
**Describe the bug**
When using the Wikidata upload twice in the same workflow, the user is asked to login each times - it should only be asked to log in the first time even if they do not ask for the login to be saved in the preferences.
|
https://github.com/OpenRefine/OpenRefine/issues/2228
|
https://github.com/OpenRefine/OpenRefine/pull/2262
|
e589413ae972d1bd53c59449098b08cb021b6ee1
|
ee6a37dc531438846f7186ab1200c5230263e425
| 2019-11-22T16:25:15Z |
java
| 2019-12-30T20:52:31Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,227 |
["main/src/com/google/refine/commands/lang/LoadLanguageCommand.java", "main/tests/server/src/com/google/refine/commands/lang/LoadLanguageCommandTests.java"]
|
No translation returned when language has not been set initially
|
When running OR from a fresh workspace, where no language preference has been set yet, the UI is not displayed in English at all. It must be due to the introduction of the language fallback.
|
https://github.com/OpenRefine/OpenRefine/issues/2227
|
https://github.com/OpenRefine/OpenRefine/pull/2232
|
391c728a160375d077740e6fbc63d15bfb4e3c4f
|
cc5498a42aece77ae0196b33768ba48f0588df26
| 2019-11-22T16:22:50Z |
java
| 2019-11-27T15:35:18Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,224 |
["extensions/database/pom.xml"]
|
Error importing date from ODS file
|
**Describe the bug**
A date in a cell in a ODS file is imported as a "java.util.GregorianCalendar" and displayed as
java.util.GregorianCalendar[time=1546297200000,areFieldsSet=true,areAllFieldsSet=true,lenient=true,zone=sun.util.calendar.ZoneInfo[id="Europe/Paris",offset=3600000,dstSavings=3600000,useDaylight=true,transitions=184,lastRule=java.util.SimpleTimeZone[id=Europe/Paris,offset=3600000,dstSavings=3600000,useDaylight=true,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=1,startTime=3600000,startTimeMode=2,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=1,endTime=3600000,endTimeMode=2]],firstDayOfWeek=2,minimalDaysInFirstWeek=4,ERA=1,YEAR=2019,MONTH=0,WEEK_OF_YEAR=1,WEEK_OF_MONTH=1,DAY_OF_MONTH=1,DAY_OF_YEAR=1,DAY_OF_WEEK=3,DAY_OF_WEEK_IN_MONTH=1,AM_PM=0,HOUR=0,HOUR_OF_DAY=0,MINUTE=0,SECOND=0,MILLISECOND=0,ZONE_OFFSET=3600000,DST_OFFSET=0] |
**To Reproduce**
Create a ODS file with Libreoffice
Put a date in a cell (like 1/1/2000)
Import into openrefine
**Current Results**
What results occured or were shown.
**Expected behavior**
A clear and concise description of what you expected to happen or to show.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Desktop (please complete the following information):**
- OS: Win10
- Browser Version: Chrome
- JRE or JDK Version: 1.8.0.231
**OpenRefine (please complete the following information):**
- Version : OpenRefine 3.3 Beta
**Datasets**
If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine)
**Additional context**
Add any other context about the problem here.
|
https://github.com/OpenRefine/OpenRefine/issues/2224
|
https://github.com/OpenRefine/OpenRefine/pull/4222
|
a5a2cd3c9ba8c9d32355b2f26ce3d659d72c8614
|
7e9210c87d22efd889e97db1607fe5da1c1e7d39
| 2019-11-20T09:33:45Z |
java
| 2021-10-18T18:49:33Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,223 |
["extensions/database/pom.xml"]
|
impossible to connect to google sheet to import a private dataset
|
**Describe the bug**
Error message (in french, sorry) when I try to authorize Openrefine to access a private google sheet :
"La fonctionnalité "Se connecter avec Google" a été désactivée temporairement pour cette application
Cette application n'a pas encore été validée par Google et ne peut pas bénéficier de la fonctionnalité Google Sign-In."
**To Reproduce**
Create a private google sheet
Try to sign-in in "Google Data" (by the way this naming is not good)
**Current Results**
What results occured or were shown.
**Expected behavior**
A clear and concise description of what you expected to happen or to show.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Desktop (please complete the following information):**
- OS: Win10
- Browser Version: Chrome
- JRE or JDK Version : 1.8.231
**OpenRefine (please complete the following information):**
- Version: Openrefine 3.3 beta
**Datasets**
**Additional context**
Add any other context about the problem here.
|
https://github.com/OpenRefine/OpenRefine/issues/2223
|
https://github.com/OpenRefine/OpenRefine/pull/4222
|
a5a2cd3c9ba8c9d32355b2f26ce3d659d72c8614
|
7e9210c87d22efd889e97db1607fe5da1c1e7d39
| 2019-11-20T08:52:24Z |
java
| 2021-10-18T18:49:33Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,220 |
["extensions/database/pom.xml"]
|
Add facet by blank per column in All menu
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
it can be useful to find all the columns with no value. We can use a facet with this formula filter(row.columnNames,cn,isBlank(cells[cn].value)), then sort by count to find the columns filled with blank values (for which the count will be the same as the total row of the dataset).
This facet could be prebuild on the same basis as https://github.com/OpenRefine/OpenRefine/issues/1977
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
Add any other context or screenshots about the feature request here.
|
https://github.com/OpenRefine/OpenRefine/issues/2220
|
https://github.com/OpenRefine/OpenRefine/pull/4174
|
c10d7fcd1d9a3d429ba1bde2799622247aa20a33
|
c84bfe17c8ced992619c9a3c0d53ad60b907d4e5
| 2019-11-19T10:30:53Z |
java
| 2021-09-24T05:49:30Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,213 |
["main/src/com/google/refine/exporters/CustomizableTabularExporterUtilities.java", "main/src/com/google/refine/exporters/XlsExporter.java", "main/tests/server/src/com/google/refine/exporters/XlsxExporterTests.java"]
|
Error exporting a project in XLSX
|
**Describe the bug**
In OR 3.3 beta, I got a java error message when I tried to export a project into XLSX
**To Reproduce**
**Current Results**
Here is the error message
HTTP ERROR 500
Problem accessing /command/core/export-rows/get_q_any_contains.xlsx. Reason:
Address of hyperlink must be a valid URI
Caused by:
```
java.lang.IllegalArgumentException: Address of hyperlink must be a valid URI
at org.apache.poi.xssf.usermodel.XSSFHyperlink.validate(XSSFHyperlink.java:264)
at org.apache.poi.xssf.usermodel.XSSFHyperlink.setAddress(XSSFHyperlink.java:245)
at com.google.refine.exporters.XlsExporter$1.addRow(XlsExporter.java:132)
at com.google.refine.exporters.CustomizableTabularExporterUtilities$1.visit(CustomizableTabularExporterUtilities.java:168)
at com.google.refine.browsing.util.RowVisitorAsRecordVisitor.visit(RowVisitorAsRecordVisitor.java:61)
at com.google.refine.browsing.util.ConjunctiveFilteredRecords.accept(ConjunctiveFilteredRecords.java:64)
at com.google.refine.browsing.util.FilteredRecordsAsFilteredRows.accept(FilteredRecordsAsFilteredRows.java:50)
at com.google.refine.exporters.CustomizableTabularExporterUtilities.exportRows(CustomizableTabularExporterUtilities.java:182)
at com.google.refine.exporters.XlsExporter.export(XlsExporter.java:140)
at com.google.refine.commands.project.ExportRowsCommand.doPost(ExportRowsCommand.java:119)
at com.google.refine.RefineServlet.service(RefineServlet.java:189)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166)
at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:81)
at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:132)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:938)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:755)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.net.URISyntaxException: Illegal character in query at index 81: http://catalogue.unice.fr/primo-explore/fulldisplay?docid=sc_aleph_uns01000411732 any,contains,comptabilité générale zoom
at java.net.URI$Parser.fail(URI.java:2848)
at java.net.URI$Parser.checkChars(URI.java:3021)
at java.net.URI$Parser.parseHierarchical(URI.java:3111)
at java.net.URI$Parser.parse(URI.java:3053)
at java.net.URI.<init>(URI.java:588)
at org.apache.poi.xssf.usermodel.XSSFHyperlink.validate(XSSFHyperlink.java:262)
... 32 more
Caused by:
java.net.URISyntaxException: Illegal character in query at index 81: http://catalogue.unice.fr/primo-explore/fulldisplay?docid=sc_aleph_uns01000411732 any,contains,comptabilité générale zoom
at java.net.URI$Parser.fail(URI.java:2848)
at java.net.URI$Parser.checkChars(URI.java:3021)
at java.net.URI$Parser.parseHierarchical(URI.java:3111)
at java.net.URI$Parser.parse(URI.java:3053)
at java.net.URI.<init>(URI.java:588)
at org.apache.poi.xssf.usermodel.XSSFHyperlink.validate(XSSFHyperlink.java:262)
at org.apache.poi.xssf.usermodel.XSSFHyperlink.setAddress(XSSFHyperlink.java:245)
at com.google.refine.exporters.XlsExporter$1.addRow(XlsExporter.java:132)
at com.google.refine.exporters.CustomizableTabularExporterUtilities$1.visit(CustomizableTabularExporterUtilities.java:168)
at com.google.refine.browsing.util.RowVisitorAsRecordVisitor.visit(RowVisitorAsRecordVisitor.java:61)
at com.google.refine.browsing.util.ConjunctiveFilteredRecords.accept(ConjunctiveFilteredRecords.java:64)
at com.google.refine.browsing.util.FilteredRecordsAsFilteredRows.accept(FilteredRecordsAsFilteredRows.java:50)
at com.google.refine.exporters.CustomizableTabularExporterUtilities.exportRows(CustomizableTabularExporterUtilities.java:182)
at com.google.refine.exporters.XlsExporter.export(XlsExporter.java:140)
at com.google.refine.commands.project.ExportRowsCommand.doPost(ExportRowsCommand.java:119)
at com.google.refine.RefineServlet.service(RefineServlet.java:189)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166)
at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:81)
at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:132)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:938)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:755)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Powered by Jetty://
Here are the logs in Win10 console :
1:27:40.390 [ ExportRowsCommand] error:Address of hyperlink must be a valid URI (8860ms)
11:27:40.397 [ org.mortbay.log] /command/core/export-rows/get_q_any_contains.xlsx (7ms)
java.lang.IllegalArgumentException: Address of hyperlink must be a valid URI
at org.apache.poi.xssf.usermodel.XSSFHyperlink.validate(XSSFHyperlink.java:264)
at org.apache.poi.xssf.usermodel.XSSFHyperlink.setAddress(XSSFHyperlink.java:245)
at com.google.refine.exporters.XlsExporter$1.addRow(XlsExporter.java:132)
at com.google.refine.exporters.CustomizableTabularExporterUtilities$1.visit(CustomizableTabularExporterUtilities.java:168)
at com.google.refine.browsing.util.RowVisitorAsRecordVisitor.visit(RowVisitorAsRecordVisitor.java:61)
at com.google.refine.browsing.util.ConjunctiveFilteredRecords.accept(ConjunctiveFilteredRecords.java:64)
at com.google.refine.browsing.util.FilteredRecordsAsFilteredRows.accept(FilteredRecordsAsFilteredRows.java:50)
at com.google.refine.exporters.CustomizableTabularExporterUtilities.exportRows(CustomizableTabularExporterUtilities.java:182)
at com.google.refine.exporters.XlsExporter.export(XlsExporter.java:140)
at com.google.refine.commands.project.ExportRowsCommand.doPost(ExportRowsCommand.java:119)
at com.google.refine.RefineServlet.service(RefineServlet.java:189)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166)
at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:81)
at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:132)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:938)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:755)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.net.URISyntaxException: Illegal character in query at index 81: http://catalogue.unice.fr/primo-explore/fulldisplay?docid=sc_aleph_uns01000411732 any,contains,comptabilitÚ gÚnÚrale zoom
at java.net.URI$Parser.fail(URI.java:2848)
at java.net.URI$Parser.checkChars(URI.java:3021)
at java.net.URI$Parser.parseHierarchical(URI.java:3111)
at java.net.URI$Parser.parse(URI.java:3053)
at java.net.URI.<init>(URI.java:588)
at org.apache.poi.xssf.usermodel.XSSFHyperlink.validate(XSSFHyperlink.java:262)
... 32 more
```
**Expected behavior**
A clear and concise description of what you expected to happen or to show.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Desktop (please complete the following information):**
- OS: Win10
- Browser Version: Firefox
- JRE or JDK Version: JRE 1.8.0_201
**OpenRefine (please complete the following information):**
- Version 3.3 beta
**Datasets**
If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine)
**Additional context**
Add any other context about the problem here.
|
https://github.com/OpenRefine/OpenRefine/issues/2213
|
https://github.com/OpenRefine/OpenRefine/pull/2263
|
ee6a37dc531438846f7186ab1200c5230263e425
|
60089ab716bb1d99b2248ea44c17c430b061c3d8
| 2019-11-12T10:37:28Z |
java
| 2019-12-30T20:52:45Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,209 |
["main/src/com/google/refine/commands/lang/LoadLanguageCommand.java", "main/tests/server/src/com/google/refine/commands/lang/LoadLanguageCommandTests.java"]
|
Language fallback not working in UI
|
When using another language than English in the UI, if a string has not been translated it will not be displayed correctly. We want to use the English string as a fallback instead.
|
https://github.com/OpenRefine/OpenRefine/issues/2209
|
https://github.com/OpenRefine/OpenRefine/pull/2210
|
6cff49b23bcd89a8e140d7c2772d2bbf486a6d49
|
b561824d04d066da6c5ce165bb02567437402b84
| 2019-11-07T16:22:16Z |
java
| 2019-11-18T22:01:39Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,206 |
["extensions/wikidata/src/org/openrefine/wikidata/editing/EditBatchProcessor.java", "extensions/wikidata/src/org/openrefine/wikidata/editing/ReconEntityRewriter.java", "extensions/wikidata/src/org/openrefine/wikidata/schema/exceptions/NewItemNotCreatedYetException.java", "extensions/wikidata/src/org/openrefine/wikidata/updates/ItemUpdate.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/editing/ReconEntityRewriterTest.java"]
|
Creation of wikidata items pointing to other new wikidata items
|
**Describe the bug**
When creating a new Wikidata item A pointing themselves to a new Wikidata item B, the item A gets duplicated: first an item is created with the parts that do not point to B, and then a duplicate item is created with the parts that point to B.
**To Reproduce**
See example project in #2205
**Expected behavior**
The second edit should not create a new item but rather edit the newly created one to add the statements pointing to B.
**OpenRefine (please complete the following information):**
- Version [e.g. OpenRefine 3.3 Beta]
|
https://github.com/OpenRefine/OpenRefine/issues/2206
|
https://github.com/OpenRefine/OpenRefine/pull/2207
|
4d3d2f006ae177a0f1ed79199133c610901429e6
|
286915ed8322d8d0755e9b8e7d867a4ab873d346
| 2019-11-04T21:12:23Z |
java
| 2019-11-07T23:46:48Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,204 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
Add Error for GREL cross showing null values when using reference column of other type than string.
|
GREL cross shows null values when using reference column of type other than text string. It is true that cross requires string value types however, it would be nice to have a check done and error handling when pointing to a value of type other for the reference column.
I ran into this when using reconcile-csv and not paying attention to import type for my unique id column. It is my fault but would be nice to see an error returned other than null. Also, adding this in case someone does something silly such as I have and it takes them a few minutes to catch as to why their cross is not showing the data.
|
https://github.com/OpenRefine/OpenRefine/issues/2204
|
https://github.com/OpenRefine/OpenRefine/pull/3665
|
ad22c7709a89e83458483c2ab640e3c6c37fe850
|
46e4b885878eaa5c065335c5764bbf996a956c74
| 2019-10-31T15:35:13Z |
java
| 2021-02-24T14:56:07Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,197 |
["main/webapp/modules/core/scripts/views/data-table/menu-edit-cells.js", "main/webapp/modules/core/scripts/views/data-table/split-multi-valued-cells-dialog.html"]
|
Derive default enter-separator from previous split-cells
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
I'm always frustrated when the ["Join multi-valued cells" prompt suggests `,`](https://github.com/OpenRefine/OpenRefine/blob/9d72de1874726be82e458335deef7cd4aee0302f/main/webapp/modules/core/scripts/views/data-table/menu-edit-cells.js#L119-L120) to me, even though:
1. I used a different symbol in the previous ["Split multi-valued cells" operation](https://github.com/OpenRefine/OpenRefine/blob/9d72de1874726be82e458335deef7cd4aee0302f/main/webapp/modules/core/scripts/views/data-table/menu-edit-cells.js#L288-L323), and
2. the `,` is present at least in some of the still split cells.
**Describe the solution you'd like**
Would both operations be more convenient & less error-prone if OpenRefine:
a) derived the default character from 1. or at least,
b) not suggested a symbol for which 2. was true?
**Describe alternatives you've considered**
I'm not sure.
**Additional context**
Related to #1113 & #2139.
|
https://github.com/OpenRefine/OpenRefine/issues/2197
|
https://github.com/OpenRefine/OpenRefine/pull/2520
|
cfa1038066b2190e4b8d2b0b4358a73179fc04e8
|
7b8f8486f6dbefa9fe996ff7675906878f1c25d0
| 2019-10-15T19:31:44Z |
java
| 2020-06-25T12:35:53Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,196 |
["extensions/database/pom.xml"]
|
Tag Wikidata edits as coming from OpenRefine through the API
|
It is now possible to apply tags to edits made via the Wikibase API, by supplying them as parameters while making the edits:
https://phabricator.wikimedia.org/T229917
I have added support for this in Wikidata-Toolkit: https://github.com/Wikidata/Wikidata-Toolkit/issues/431. This should be released soon.
Pulling this in would remove the need for edit filters to tag OpenRefine edits, saving up some resources in Wikidata (the tags would still need to be created).
Tasks:
* [ ] update Wikidata-Toolkit to latest released version
* [ ] add OpenRefine tag to edits from the API
|
https://github.com/OpenRefine/OpenRefine/issues/2196
|
https://github.com/OpenRefine/OpenRefine/pull/4174
|
c10d7fcd1d9a3d429ba1bde2799622247aa20a33
|
c84bfe17c8ced992619c9a3c0d53ad60b907d4e5
| 2019-10-15T13:59:39Z |
java
| 2021-09-24T05:49:30Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,195 |
["extensions/database/pom.xml"]
|
JSON: concatenate null value with string, result changed between 3.1 and 3.2
|
**Describe the bug**
Extracting and concatenating strings from JSON gives different results in OR 3.1 and OR 3.2 if one of the string is actually not a string but a null value.
In 3.1 the null value is evaluated to the string 'null', in 3.2 the whole string concatenation seems to fail.
I don't seem to be able to find the change in the 3.2 release notes that explain this change of behaviour.
**To Reproduce**
Steps to reproduce the behavior:
1. create a project with two columns named 'JSON' und 'result'
2. apply the following code from my operation history
```javascript
[
{
"op": "core/text-transform",
"engineConfig": {
"facets": [],
"mode": "row-based"
},
"columnName": "JSON",
"expression": "grel:'[ \"foo\", null ]'",
"onError": "keep-original",
"repeat": false,
"repeatCount": 10,
"description": "Text transform on cells in column JSON."
},
{
"op": "core/text-transform",
"engineConfig": {
"facets": [],
"mode": "row-based"
},
"columnName": "result",
"expression": "grel:forEach(cells['JSON'].value.parseJson(), v, 'x: ' + v).join(' || ')",
"onError": "store-error",
"repeat": false,
"repeatCount": 10,
"description": "Text transform on cells in column result."
}
]
```
**Current Results**
In OR 3.1 this results in the value 'x: foo || x: null' in column result, in OR 3.2 it gives 'x: foo'.
**Expected behavior**
Not sure. I think 'x: foo || x: null' or maybe 'x: foo || x: ' would be correct? Or some kind of error message. Or was the behaviout in OR 3.1. erroneous The point is that the behaviour changed and I wasn't able to predict it from reading the release notes.
**Screenshots**
**Desktop (please complete the following information):**
- OS: Ubuntu 19.04
- Browser Version: Chromium Version 77.0.3865.90 (Offizieller Build) snap (64-Bit)
- JRE or JDK Version:
openjdk version "11.0.4" 2019-07-16
OpenJDK Runtime Environment (build 11.0.4+11-post-Ubuntu-1ubuntu219.04)
OpenJDK 64-Bit Server VM (build 11.0.4+11-post-Ubuntu-1ubuntu219.04, mixed mode, sharing)
**OpenRefine (please complete the following information):**
- Version OpenRefine 3.1 [b90e413] and OpenRefine 3.2 [55c921b]
|
https://github.com/OpenRefine/OpenRefine/issues/2195
|
https://github.com/OpenRefine/OpenRefine/pull/4222
|
a5a2cd3c9ba8c9d32355b2f26ce3d659d72c8614
|
7e9210c87d22efd889e97db1607fe5da1c1e7d39
| 2019-10-15T13:56:50Z |
java
| 2021-10-18T18:49:33Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,188 |
["extensions/database/pom.xml"]
|
Unable to extract history
|
**Describe the bug**
Working on a +8000 records project with +4000 history items. When trying to extract the history, nothing happens.
**To Reproduce**
Steps to reproduce the behavior:
1. Go to Undo / Redo
2. Click on Extract...
3. Nothing happens
**Current Results**
No response.
**Expected behavior**
History JSON.
**Desktop (please complete the following information):**
- OS: macOS Mojave 10.14.6 / Windows 10 Enterprise, Build 1709, 16299.1217
- Browser Version: Firefox 69.0.3 (64-bit), Google Chrome 77.0.3865.120 (Official Build) (64-bit), Safari 13.0.2 (14608.2.40.1.2) / Win: Google Chrome 77.0.3865.90 (Official Build) (64-bit)
- JRE or JDK Version: JRE 1.7.0_79-b15
**OpenRefine (please complete the following information):**
- Version OpenRefine 3.1
|
https://github.com/OpenRefine/OpenRefine/issues/2188
|
https://github.com/OpenRefine/OpenRefine/pull/4049
|
7e1b7dfb82c374ee1f2831e81b810bc4738c8241
|
de1633cd79666cac13251971dc2f589502fa243c
| 2019-10-11T20:18:28Z |
java
| 2021-07-12T06:33:03Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,183 |
["main/webapp/modules/core/styles/views/data-table-view.less"]
|
Text in the "viewpanel-header" is overlapping in German.
|
When using OpenRefine in German (or another language with long words) the text overlaps
**To Reproduce**
1. Set the language to German
2. Open a project
3. See error
**Screenshot**
**Desktop:**
- Windows 10
- Browser Version: newest Chrome and Firefox
- Bug is not dependent on the resolution
**OpenRefine:**
- Version 3.2 [55c921b]
**Additional information**
The problem comes from the absolute positioning in the css of the page. This also results in overlapping on screens with smaller resolution:
|
https://github.com/OpenRefine/OpenRefine/issues/2183
|
https://github.com/OpenRefine/OpenRefine/pull/2185
|
28c2a6154e54160d6cc6789a342036d125a34663
|
93e9d713bf9ff3ee9cf5e4583626976dfb26bf2b
| 2019-10-11T09:31:35Z |
java
| 2019-10-11T11:29:30Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,166 |
["main/webapp/modules/core/externals/suggest/suggest-4_3.js"]
|
Selected reconciliation property IDs are lost after changing type
|
**Describe the bug**
In the reconciliation dialog, after selecting a suggested property, and then changing the type, the selected ID is lost, and the inserted label is used as the property.
**To Reproduce**
1. Add `console.log("columnDetails:", columnDetails);` in `standard-service-panel.js`, line 305 (after `columnDetails` are done)
2. Open Reconciliation dialog, select the Wikidata reconciliation service
3. In the area on the right ("Also use relevant details from other columns:"), start typing a property, select a suggestion (e.g. occupation/P106)
4. In the area on the left ("Reconcile each cell to an entity of one of these types:"), change the type selection
5. Open your browser's web console, click "Start Reconciling", and check the "columnDetails" output
**Current Results**
The property ID is "occupation".
**Expected behavior**
The property ID should be "P106", like it is if we first select a type, and then pick a suggested property.
**Desktop:**
- OS: Linux Mint 18.1 Cinnamon 64-bit
- Browser Version: Firefox 68.0.1 (64-bit)
- JRE or JDK Version: OpenJDK Runtime Environment (build 1.8.0_222-8u222-b10-1ubuntu1~16.04.1-b10)
- Version: tested in OpenRefine 3.2 and in master
|
https://github.com/OpenRefine/OpenRefine/issues/2166
|
https://github.com/OpenRefine/OpenRefine/pull/2167
|
59982fd9bfd4bd1d30c777135ece7489399b3474
|
aa5d7b03cd537fb9ed703459185ebfd5adc97e17
| 2019-09-23T07:31:25Z |
java
| 2019-09-27T08:34:41Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,163 |
["main/src/com/google/refine/commands/cell/EditOneCellCommand.java", "main/tests/server/src/com/google/refine/commands/cell/EditOneCellCommandTests.java"]
|
When using the cell "Edit" option to enter a number, the behaviour should be consistent with toNumber()
|
**Describe the bug**
If you enter a string into a cell such as "3" and then use "toNumber()" to convert it to a number, toNumber() first tries to parse as a Long, and then tries parsing as a Double. So "3" will be stored as a Long, while "3.0" will be stored as a Double
However, if you edit a cell by using the single cell "edit" option and enter a number, and change the 'type' to Number, OR only attempts to parse the string typed into the cell edit dialogue as a Double - meaning that "3" is stored as a Double, not a Long. This means that entering "3" and "3.0" have exactly the same result in this case.
**Expected behavior**
The two options should be consistent in terms of how they parse strings to numbers and store the data.
The 'toNumber()' behaviour is preferred, and the 'edit' cell dialogue should be consistent with 'toNumber()' when entering numbers into cells
**OpenRefine (please complete the following information):**
- Version 3.2
**Additional context**
https://groups.google.com/d/msg/openrefine/8uq_mZMISCs/E4IKWNHeBQAJ
|
https://github.com/OpenRefine/OpenRefine/issues/2163
|
https://github.com/OpenRefine/OpenRefine/pull/2274
|
b4ac8be752cb2d7ac145e05565ba2d1003fffe1a
|
d82e5425e5d779d88400f39a39b0c5a704326665
| 2019-09-20T23:20:21Z |
java
| 2020-01-08T08:46:11Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,158 |
["main/webapp/modules/core/scripts/facets/list-facet.js", "main/webapp/modules/core/scripts/index/lang-settings-ui.js"]
|
Language preference not working in OR 3.2
|
**Describe the bug**
Impossible to change the language of the UI
**To Reproduce**
Change the language to "French" or "Spanish" and apply. Nothing is changed, the UI is still in English
see this tweet https://twitter.com/daieuxdailleurs/status/1171672967648043008
**Current Results**
What results occured or were shown.
**Expected behavior**
A clear and concise description of what you expected to happen or to show.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Desktop (please complete the following information):**
- OS: Win10
- Browser Version: FF
- JRE or JDK Version: 1.8.0_201
**OpenRefine (please complete the following information):**
- Version : OpenRefine 3.2
**Datasets**
If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine)
**Additional context**
Add any other context about the problem here.
|
https://github.com/OpenRefine/OpenRefine/issues/2158
|
https://github.com/OpenRefine/OpenRefine/pull/2159
|
9d4183dda4246f21e9fec1400e3a39b165613d90
|
18a78dbb4efd26151ce5271abba7d2deea8e9760
| 2019-09-11T16:38:46Z |
java
| 2019-09-18T18:08:03Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,154 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
Version 3.2 not starting due to Exception
|
This may relate to #1939 .
**Describe the bug**
Not starting due to Exception
> Exception in thread "main" java.lang.NoClassDefFoundError: org/json/JSONException
**To Reproduce**
1. Download openrefine-mac-3.2.dmg.
2. Copy to it to the Application folder.
3. Double click the icon.
**Current Results**
The terminal shows the folloiwng:
```
/Applications/OpenRefine.app/Contents/MacOS/JavaAppLauncher ; exit;
16:29:25.565 [ refine_server] Starting Server bound to '127.0.0.1:3333' (0ms)
16:29:25.572 [ refine_server] Initializing context: '/' from '/Applications/OpenRefine.app/Contents/Resources/webapp' (7ms)
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/Applications/OpenRefine.app/Contents/Java/lib/slf4j-log4j12-1.7.18.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/Applications/OpenRefine.app/Contents/Resources/webapp/WEB-INF/lib/slf4j-log4j12-1.7.18.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
16:29:26.003 [ refine] Starting OpenRefine 3.2 [55c921b]... (431ms)
16:29:26.003 [ refine] initializing FileProjectManager with dir (0ms)
16:29:26.003 [ refine] /Users/yayamamo/Library/Application Support/OpenRefine (0ms)
Exception in thread "main" java.lang.NoClassDefFoundError: org/json/JSONException
at java.lang.Class.getDeclaredMethods0(Native Method)
at java.lang.Class.privateGetDeclaredMethods(Class.java:2701)
at java.lang.Class.privateGetPublicMethods(Class.java:2902)
at java.lang.Class.getMethods(Class.java:1615)
...
```
**Expected behavior**
**Screenshots**
**Desktop (please complete the following information):**
- OS: macOS Mojave (10.14.6)
- JRE or JDK Version:
```
$ java -version
java version "1.8.0_65"
Java(TM) SE Runtime Environment (build 1.8.0_65-b17)
Java HotSpot(TM) 64-Bit Server VM (build 25.65-b01, mixed mode)
```
**OpenRefine (please complete the following information):**
- Version OpenRefine 3.2
**Datasets**
**Additional context**
There is no folder named "~/Library/Application Support/OpenRefine".
|
https://github.com/OpenRefine/OpenRefine/issues/2154
|
https://github.com/OpenRefine/OpenRefine/pull/3665
|
ad22c7709a89e83458483c2ab640e3c6c37fe850
|
46e4b885878eaa5c065335c5764bbf996a956c74
| 2019-09-11T07:40:37Z |
java
| 2021-02-24T14:56:07Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,152 |
["main/src/com/google/refine/clustering/binning/BinningClusterer.java", "main/tests/server/src/com/google/refine/clustering/binning/BinningClustererTests.java", "main/tests/server/src/com/google/refine/clustering/knn/kNNClustererTests.java"]
|
Cluster returning "groups" of 1 row/choice
|
All of the cluster methods return clusters with one row/choice, which takes up processing time and makes using anything beyond ngram-fingerprint nearly impossible for larger sets.
**Desktop (please complete the following information):**
- Windows 10
- Browser Version: Chrome and Firefox
**OpenRefine (please complete the following information):**
- Version 3.2
|
https://github.com/OpenRefine/OpenRefine/issues/2152
|
https://github.com/OpenRefine/OpenRefine/pull/2155
|
18a78dbb4efd26151ce5271abba7d2deea8e9760
|
bbb5766a33ccfcc95b3648c7ddc3cbd5723d0e91
| 2019-09-10T16:12:44Z |
java
| 2019-09-18T18:08:18Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,145 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
NoSuchMethodError: com.google.refine.operations.cell.TextTransformOperation
|
**Describe the bug**
Java error while performing Text Transform on a column
**To Reproduce**
Steps to reproduce the behavior:
1. Import Project attached to this issue Dataset.
2. On column "year", apply text transform `value.partition(">")[2]`
4. See error in Current Results.
**Current Results**
```
C:\Users\THAD\OpenRefine>(
echo -----------------------
echo PROCESSOR_ARCHITECTURE = AMD64
echo JAVA_HOME = C:\Program Files\Java\jdk-12.0.1
echo java -version = java version "1.8.0_221"
echo freeRam = 10183M
echo REFINE_MEMORY = 1400M
echo -----------------------
) 1>support.log
C:\Users\THAD\OpenRefine>set CLASSPATH="server\classes;server\target\lib\*"
C:\Users\THAD\OpenRefine>"C:\Program Files\Java\jdk-12.0.1\bin\java.exe" -cp "server\classes;server\target\lib\*" -Xms1400M -Xmx1400M -Drefine.memory=1400M -Drefine.max_form_content_size=1048576 -Drefine.port=3333 -Drefine.host=127.0.0.1 -Drefine.webapp=main\webapp -Djava.library.path=server\target\lib/native/windows com.google.refine.Refine
10:13:18.496 [ refine_server] Starting Server bound to '127.0.0.1:3333' (0ms)
10:13:18.497 [ refine_server] refine.memory size: 1400M JVM Max heap: 1468006400 (1ms)
10:13:18.512 [ refine_server] Initializing context: '/' from 'C:\Users\THAD\OpenRefine\main\webapp' (15ms)
10:13:24.854 [ refine_server] Failed to use jdatapath to detect user data path: resorting to environment variables (6342ms)
10:13:24.857 [ refine_server] Failed to use jdatapath to detect user data path: resorting to environment variables (3ms)
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/C:/Users/THAD/OpenRefine/server/target/lib/slf4j-log4j12-1.7.18.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/C:/Users/THAD/OpenRefine/main/webapp/WEB-INF/lib/slf4j-log4j12-1.7.18.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
10:13:24.992 [ refine] Starting OpenRefine 3.3 [9d72de1]... (135ms)
10:13:24.992 [ refine] initializing FileProjectManager with dir (0ms)
10:13:24.993 [ refine] C:\Users\THAD\AppData\Roaming\OpenRefine (1ms)
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.python.core.PySystemState (file:/C:/Users/THAD/OpenRefine/main/webapp/../../extensions/jython/module/MOD-INF/lib/jython-standalone-2.7.1.jar) to method java.io.Console.encoding()
WARNING: Please consider reporting this to the maintainers of org.python.core.PySystemState
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
10:13:35.702 [ refine] POST /command/core/load-language (10709ms)
10:13:35.722 [ refine] GET /command/core/get-preference (20ms)
[snip]
12:46:41.524 [ refine] POST /command/core/preview-expression (485ms)
12:46:52.925 [ refine] POST /command/core/log-expression (11401ms)
12:46:52.926 [ refine] POST /command/core/text-transform (1ms)
12:46:52.932 [ org.mortbay.log] Error for /command/core/text-transform (6ms)
java.lang.NoSuchMethodError: com.google.refine.operations.cell.TextTransformOperation.access$0(Lcom/google/refine/operations/cell/TextTransformOperation;)Ljava/lang/String;
at com.google.refine.operations.cell.TextTransformOperation$1.visit(TextTransformOperation.java:158)
at com.google.refine.browsing.util.ConjunctiveFilteredRows.visitRow(ConjunctiveFilteredRows.java:76)
at com.google.refine.browsing.util.ConjunctiveFilteredRows.accept(ConjunctiveFilteredRows.java:65)
at com.google.refine.operations.EngineDependentMassCellOperation.createHistoryEntry(EngineDependentMassCellOperation.java:78)
at com.google.refine.model.AbstractOperation$1.createHistoryEntry(AbstractOperation.java:63)
at com.google.refine.process.QuickHistoryEntryProcess.performImmediate(QuickHistoryEntryProcess.java:70)
at com.google.refine.process.ProcessManager.queueProcess(ProcessManager.java:80)
at com.google.refine.commands.Command.performProcessAndRespond(Command.java:236)
at com.google.refine.commands.EngineDependentCommand.doPost(EngineDependentCommand.java:80)
at com.google.refine.RefineServlet.service(RefineServlet.java:189)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166)
at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:81)
at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:132)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:938)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:755)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:835)
```
**Expected behavior**
Transform should have completed without an error.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Desktop (please complete the following information):**
- OS: Windows 10
- Browser Version: Firefox
- JRE or JDK Version: jdk-12.0.1
**OpenRefine (please complete the following information):**
- Version: Trunk (clean build)
**Datasets**
[Batchelder-Award-Winners.openrefine.tar.gz](https://github.com/OpenRefine/OpenRefine/files/3562694/Batchelder-Award-Winners.openrefine.tar.gz)
**Additional context**
hmm ... Java 12 confusion perhaps ?
|
https://github.com/OpenRefine/OpenRefine/issues/2145
|
https://github.com/OpenRefine/OpenRefine/pull/3446
|
fe123129d227ee7fca14fb2f3f427dc411dd4e5f
|
eb7cdf2d9ccba84f3e2bdb5202059a2d43e810c0
| 2019-08-31T18:02:12Z |
java
| 2021-01-05T09:13:07Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,136 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/src/org/openrefine/wikidata/qa/EditInspector.java", "extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/CalendarScrutinizer.java", "extensions/wikidata/src/org/openrefine/wikidata/schema/WbDateConstant.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/qa/scrutinizers/CalendarScrutinizerTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbDateConstantTest.java"]
|
Support for custom calendars in Wikidata dates
|
Date values currently created by the Wikidata extension always use the Gregorian calendar. This should be configurable on a per-date basis. We just need to figure out a syntax for this.
Perhaps `YYYY-MM-DD_QID`, where `QID` is the item id of the calendar?
|
https://github.com/OpenRefine/OpenRefine/issues/2136
|
https://github.com/OpenRefine/OpenRefine/pull/2137
|
d4ba7e2791a7834956256fad2745d7434c9a6286
|
29f6d1d14b9a594ba0320a9ea26012fa2048f56e
| 2019-08-24T09:31:11Z |
java
| 2019-09-11T16:16:49Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,117 |
["main/src/com/google/refine/browsing/facets/ScatterplotFacet.java", "main/src/com/google/refine/commands/browsing/GetScatterplotCommand.java", "main/tests/server/src/com/google/refine/browsing/facets/ScatterplotFacetTests.java", "main/tests/server/src/com/google/refine/commands/browsing/ScatterplotDrawCommandTests.java"]
|
Scatterplot
|
The plots are not displaying when I do a scatterplot facet. Using the current edition of OR. Tried it in both Firefox & Mozilla on a Windows 10 Machine (scatterplots failed to display in both browsers, though the failure to display looked different in the different browsers). I tried it with two different data sets, on three different machines.
|
https://github.com/OpenRefine/OpenRefine/issues/2117
|
https://github.com/OpenRefine/OpenRefine/pull/2140
|
c35b2e154ff610681c6e507bf8f92c81ba41db73
|
e935730c6f8b7f81eb941483909e8bbea0eb68a1
| 2019-08-09T21:09:53Z |
java
| 2019-09-13T12:50:48Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,112 |
["main/webapp/modules/core/scripts/facets/text-search-facet.js"]
|
Text filter should wait until user finishes before updating.
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
When entering a string or regex expression in the text filter, I'm often prevented from finishing the expression before OpenRefine attempts to update the results. This is frustrating, especially when trying to formulate complex regex.
**Describe the solution you'd like**
My preferred solution would be a `Submit` button (ideally with a keyboard shortcut) so that OpenRefine doesn't keep trying to update while I'm typing.
**Describe alternatives you've considered**
The only alternative I've found is to write regex expressions in a text file and copy/paste into the text filter.
|
https://github.com/OpenRefine/OpenRefine/issues/2112
|
https://github.com/OpenRefine/OpenRefine/pull/2324
|
59e2ba2f97c1afdf69556349e259cd565319f97c
|
3d5a93d506a7a85d59c413d364c0ea03a3991d50
| 2019-08-07T18:33:39Z |
java
| 2020-03-07T21:10:21Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,106 |
["extensions/database/pom.xml"]
|
Common Transformation "Trim Whitespace" introduced errors
|
**Describe the bug**
When I used the Common Transformation from the drop down menu, it not only removed trailing white space, it also removed last letters from many words.
**To Reproduce**
1. Go to 'Edit Cells --> Common Tranforms'
2. Click on 'Trim leading and trailing whitespace'
3. Data in column was then missing the last character whether it was a whitespace character or not.
|
https://github.com/OpenRefine/OpenRefine/issues/2106
|
https://github.com/OpenRefine/OpenRefine/pull/4049
|
7e1b7dfb82c374ee1f2831e81b810bc4738c8241
|
de1633cd79666cac13251971dc2f589502fa243c
| 2019-08-01T17:52:49Z |
java
| 2021-07-12T06:33:03Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,103 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/src/org/openrefine/wikidata/qa/EditInspector.java", "extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/CommonDescriptionScrutinizer.java", "extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/DescriptionScrutinizer.java", "extensions/wikidata/src/org/openrefine/wikidata/qa/scrutinizers/EnglishDescriptionScrutinizer.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/qa/scrutinizers/CommonDescriptionScrutinizerTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/qa/scrutinizers/EnglishDescriptionScrutinizerTest.java"]
|
New wikidata validator: description lengths and endings
|
In the Wikidata extension, we could add validators to raise warnings when the following happens:
- adding a description which is too long (250 characters)
- adding a description which ends by punctuation signs (these should not be removed automatically but flagged, as they might indicate that full sentences were used as descriptions)
- any other sanity checks?
|
https://github.com/OpenRefine/OpenRefine/issues/2103
|
https://github.com/OpenRefine/OpenRefine/pull/2349
|
9356b846b661599a9c40ff4f4e5cecc6288646e8
|
61ab6401df430723e07df2f0c8cb9a5aa01d2e87
| 2019-07-28T16:21:13Z |
java
| 2020-03-02T14:22:19Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,097 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/module/langs/translation-fr.json", "extensions/wikidata/module/langs/translation-it.json", "extensions/wikidata/module/scripts/menu-bar-extension.js"]
|
Schema not exportable while running QuickStatements
|
**Describe the bug**
When you are running a QuickStatements job and want to back-up your schema for preparing another one batch edit, you'll just get the QuickStatements windows focused instead of a local schema backup file.
**To Reproduce**
Steps to reproduce the behavior:
1. Open a QuickStatements window
2. Click on 'Export schema' in OpenRefine
3. The QuickStatements window gets focused instead of exporting the schema
**Current Results**
The QuickStatements window gets focused.
**Expected behavior**
The schema gets exported.
**OpenRefine (please complete the following information):**
- 3.2-beta [8d89a2a]
|
https://github.com/OpenRefine/OpenRefine/issues/2097
|
https://github.com/OpenRefine/OpenRefine/pull/2098
|
7b11ee94aa50efe3fada39713fc6963df2264cdc
|
deaff938b35e28bb893c4c429be3264860232f2d
| 2019-07-23T08:07:15Z |
java
| 2019-07-24T08:06:21Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,088 |
["main/pom.xml"]
|
Build fails if run from a git clone with --depth=1
|
**Describe the bug**
The build fails if the git clone was created with the `--depth=1` option (which speeds up the download by only fetching the latest revision).
**To Reproduce**
Steps to reproduce the behavior:
1. `git clone https://github.com/OpenRefine/OpenRefine --depth=1`
2. `./refine` fails
**Desktop:**
- OS: Debian
- Browser Version: not relevant
- JRE or JDK Version: not relevant
**OpenRefine:**
- master branch
|
https://github.com/OpenRefine/OpenRefine/issues/2088
|
https://github.com/OpenRefine/OpenRefine/pull/2090
|
7f995466dd134a9a1f31f3d333ed2d3522e06520
|
6616d017259f96894c7cce75a82e110cd1aeed4b
| 2019-07-17T21:25:24Z |
java
| 2019-07-20T06:47:41Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,087 |
["extensions/database/pom.xml"]
|
Export and sync data to a Dat peer-to-peer network
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
https://dat.foundation has a clear API and command line tools to sync data to a distributed peer-to-peer network. I currently have to manually export, then do commands outside of OpenRefine to perform syncing and metadata enrichment of my dataset to Dat.
**Describe the solution you'd like**
OpenRefine could expose an additional export option to "sync to my dat network" which would have some export settings available to the user (file-based config is fine for now although GUI would be welcome) to manage this network.
**Describe alternatives you've considered**
manually exporting every time I need to do a sync everyday.
|
https://github.com/OpenRefine/OpenRefine/issues/2087
|
https://github.com/OpenRefine/OpenRefine/pull/4222
|
a5a2cd3c9ba8c9d32355b2f26ce3d659d72c8614
|
7e9210c87d22efd889e97db1607fe5da1c1e7d39
| 2019-07-15T18:39:02Z |
java
| 2021-10-18T18:49:33Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,086 |
["main/src/com/google/refine/ProjectManager.java", "main/src/com/google/refine/commands/expr/LogExpressionCommand.java", "main/tests/server/src/com/google/refine/commands/expr/LogExpressionCommandTests.java"]
|
Exception when logging expressions
|
**Describe the bug**
```
17:33:49.314 [ refine] POST /command/core/preview-expression (1280ms)
17:33:53.149 [ refine] POST /command/core/log-expression (3835ms)
17:33:53.149 [ command] Exception caught (0ms)
java.lang.NullPointerException
at com.google.refine.commands.expr.LogExpressionCommand.doPost(LogExpressionCommand.java:56)
at com.google.refine.RefineServlet.service(RefineServlet.java:189)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166)
at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:81)
at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:132)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:938)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:755)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:835)
```
This happens when creating a new column or new facet from an expression.
**OpenRefine (please complete the following information):**
- master branch
|
https://github.com/OpenRefine/OpenRefine/issues/2086
|
https://github.com/OpenRefine/OpenRefine/pull/2264
|
60089ab716bb1d99b2248ea44c17c430b061c3d8
|
14dd4c01125b15df8fda9651c49ce19b5f32bf75
| 2019-07-15T08:52:06Z |
java
| 2019-12-30T20:52:58Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,076 |
["main/src/com/google/refine/model/recon/StandardReconConfig.java", "main/tests/server/src/com/google/refine/tests/model/recon/StandardReconConfigTests.java"]
|
NullPointerException while reconciling
|
**Describe the bug**
After starting a reconciliation operation, one can obtain the following in the logs:
```
10:47:49.402 [ refine] POST /command/core/reconcile (13834ms)
Exception in thread "Thread-6" java.lang.NullPointerException
at com.google.refine.model.recon.StandardReconConfig.computeFeatures(StandardReconConfig.java:567)
at com.google.refine.model.recon.StandardReconConfig.createReconServiceResults(StandardReconConfig.java:555)
at com.google.refine.model.recon.StandardReconConfig.batchRecon(StandardReconConfig.java:485)
at com.google.refine.operations.recon.ReconOperation$ReconProcess.run(ReconOperation.java:282)
at java.lang.Thread.run(Thread.java:748)
```
|
https://github.com/OpenRefine/OpenRefine/issues/2076
|
https://github.com/OpenRefine/OpenRefine/pull/2077
|
8d97c519d8b68ff3a1512d7b392b632e2141fc3b
|
ab605dcaaf44ee39e3601bc98cc80363fcd35c62
| 2019-07-02T08:16:23Z |
java
| 2019-07-09T07:37:40Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,071 |
["main/src/com/google/refine/exporters/CsvExporter.java", "main/src/com/google/refine/importers/ImporterUtilities.java", "main/src/com/google/refine/importers/SeparatorBasedImporter.java", "main/tests/server/src/com/google/refine/exporters/TsvExporterTests.java", "main/tests/server/src/com/google/refine/importers/SeparatorBasedImporterTests.java"]
|
TSV export escapes double quotes (") unnecessarily
|
I export a project in tab separated values. In the resulting TSV file I found duplicates double quotes. OR seems to escape the quotes, but I don't want this behavior
### To Reproduce
Export to TSV a project containing cell values with double quote characters (") in them.
### Current Results
Cells which contain double quote characters (") are wrapped in quotes and have the internal quotes escaped, even though the separate value is \t, not ". e.g. the cell value 'comme "braille mental"' (without the single quotes) gets exported as '"comme ""braille mental"""'
### Expected behavior
Quote characters should be left untouched and only embedded TAB, LF, & CR characters should be escaped (\t, \n, \r).
### Screenshots
In my project
In my tsv
**Desktop**
- OS: win10
- Browser Version: Chrome
- JRE or JDK Version:1.8.0_211
**OpenRefine**
- Version : OR 3.1
|
https://github.com/OpenRefine/OpenRefine/issues/2071
|
https://github.com/OpenRefine/OpenRefine/pull/6344
|
0240d6ece11e89a28969fad18433ca4aa62e647d
|
f0ca6f7a3017b6e2e714946140f6b45d3600dbe2
| 2019-06-16T17:59:26Z |
java
| 2024-02-21T06:20:53Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,068 |
["main/src/com/google/refine/browsing/facets/FacetConfig.java", "main/src/com/google/refine/clustering/ClustererConfig.java", "main/src/com/google/refine/model/AbstractOperation.java", "main/src/com/google/refine/preference/PreferenceValue.java", "main/src/com/google/refine/sorting/Criterion.java", "main/tests/server/src/com/google/refine/tests/preference/TopListTests.java", "main/tests/server/src/com/google/refine/tests/util/TestUtils.java"]
|
Duplicate serialization of operation types
|
**Describe the bug**
Operation type can be added more than once to JSON serialization, as in the following example:
```
{"op":"core/recon",
"engineConfig":{"facets":[],"mode":"row-based"},"columnName":"institution","config":{"mode":"standard-service","service":"https://reconcile.ror.org/reconcile","identifierSpace":"http://ror.org/organization","schemaSpace":"http://ror.org/ns/type.object.id","type":{"id":"/ror/organization","name":"/ror/organization"},"autoMatch":true,"columnDetails":[],"limit":0},
"description":"Reconcile cells in column institution to type /ror/organization",
"op":"core/recon"
}
```
This is deserialized correctly by the current Jackson code but not by the previous org.json code. This makes it impossible to open projects made with OpenRefine 3.2-beta with 3.1.
|
https://github.com/OpenRefine/OpenRefine/issues/2068
|
https://github.com/OpenRefine/OpenRefine/pull/2070
|
09a42fd2f592a5db6e94380bd4cce2c93d487721
|
cde59a0dca8604f948f6f5dbf7c8e1baa6e8072c
| 2019-06-13T19:41:24Z |
java
| 2019-07-02T08:19:16Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,054 |
["appveyor.yml"]
|
Disable packaging in Appveyor builds
|
Just like for Travis, we should not create packaged version of OpenRefine in appveyor builds, as this takes time and makes the builds less robust:
https://ci.appveyor.com/project/openrefine/openrefine/builds/24943885
|
https://github.com/OpenRefine/OpenRefine/issues/2054
|
https://github.com/OpenRefine/OpenRefine/pull/2055
|
68b0bbcd92b119a8497dbed4b60a563a37106c93
|
203cf8c20e19baf60cf2d1038233aa6f3a1672c8
| 2019-05-31T08:11:40Z |
java
| 2019-06-04T09:44:54Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,051 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml", "main/pom.xml"]
|
Update jackson-databind
|
Following https://nvd.nist.gov/vuln/detail/CVE-2019-12086 we should update Jackson to 2.9.9.
|
https://github.com/OpenRefine/OpenRefine/issues/2051
|
https://github.com/OpenRefine/OpenRefine/pull/2052
|
51a8cbf94664953379295b8714b8a23588bb02ec
|
68b0bbcd92b119a8497dbed4b60a563a37106c93
| 2019-05-24T08:28:33Z |
java
| 2019-05-31T08:53:47Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,047 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
build from source releases fails due to missing git directory
|
**Describe the bug**
build from source releases fails due to missing git directory
**To Reproduce**
Steps to reproduce the behavior:
1. Download release source (ie: wget https://github.com/OpenRefine/OpenRefine/archive/3.1.tar.gz)
1. Run `./refine build`
**Current Results**
```
[ERROR] Failed to execute goal pl.project13.maven:git-commit-id-plugin:2.2.4:revision (get-the-git-infos) on project main: .git directory is not found! Please specify a valid [dotGitDirectory] in your pom.xml -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :main
Error: Error while running maven task 'process-resources'
The command '/bin/sh -c ./refine build' returned a non-zero code: 1
```
**Expected behavior**
A clean build
**Desktop (please complete the following information):**
- OS: linux (using latest `alpine` docker image)
- JRE or JDK Version:
```
java -version
openjdk version "1.8.0_212"
OpenJDK Runtime Environment (IcedTea 3.12.0) (Alpine 8.212.04-r0)
OpenJDK 64-Bit Server VM (build 25.212-b04, mixed mode)
```
**OpenRefine (please complete the following information):**
- Version: OpenRefine 3.1
**Additional context**
Trying to build docker images with a few extensions. Upstream images would be appreciated :D
|
https://github.com/OpenRefine/OpenRefine/issues/2047
|
https://github.com/OpenRefine/OpenRefine/pull/3446
|
fe123129d227ee7fca14fb2f3f427dc411dd4e5f
|
eb7cdf2d9ccba84f3e2bdb5202059a2d43e810c0
| 2019-05-23T17:11:36Z |
java
| 2021-01-05T09:13:07Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,044 |
["extensions/database/pom.xml"]
|
Labels for Text filter checkboxes are linked to first instance
|
**Describe the bug**
Labels for checkboxes in text filters are resuing the same `ref`s and checkboxes are reusing the same `id`s
**To Reproduce**
Steps to reproduce the behavior:
1. Add multiple Text filters
**Current Results**
https://streamable.com/forh6
|
https://github.com/OpenRefine/OpenRefine/issues/2044
|
https://github.com/OpenRefine/OpenRefine/pull/3654
|
3db9453661261e1917aaa21fd3c1e3559536f6f2
|
3e20bc8da05210a7c52fe761d7618711d7d54641
| 2019-05-19T12:37:21Z |
java
| 2021-02-27T22:29:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,041 |
["main/src/com/google/refine/model/changes/CellAtRowCellIndex.java", "main/src/com/google/refine/model/changes/ColumnReorderChange.java", "main/tests/server/src/com/google/refine/tests/operations/column/ColumnReorderOperationTests.java"]
|
Column Reorder leaves undeleted hidden cells.
|
hi, I appriciates you for maintaining this nice tool.
**Describe the bug**
Column Reorder leaves undeleted hidden cells in case of removing column.
So you get unexpected cell data in a some condition.
**To Reproduce**
1. import a data set
2. remove columns with Reorder
above instance : remove 'b', 'c' columns with Reoerder
3. split a left column
above instance : split 'a' column with separator '|'
4. you get some unexpected data
above instance : g,h,i is unexpected split data
**Desktop :**
anywhere, I guess
**OpenRefine :**
- Version 3.1
**Datasets**
project of above instance
[split-issue.openrefine.tar.gz](https://github.com/OpenRefine/OpenRefine/files/3180421/split-issue.openrefine.tar.gz)
I made a patch for this issue.
|
https://github.com/OpenRefine/OpenRefine/issues/2041
|
https://github.com/OpenRefine/OpenRefine/pull/2042
|
4756741219a5ce772338e386884a497b27c748a1
|
51a8cbf94664953379295b8714b8a23588bb02ec
| 2019-05-15T01:12:24Z |
java
| 2019-05-31T07:41:13Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,040 |
["extensions/database/pom.xml"]
|
toString() for array arguments in GREL returns a memory address. Consider giving a more intuitive representation.
|
In GREL, `toString( [ 3 ,4])`, will return something like: `[Ljava.lang.Object;@79738ce6`. It would be helpful to provide a more intuitive and natural representation, such as: `[ 3, 4 ]`.
Something like `java.util.Arrays.deepToString` might give a better meaning when running toString on an array in GREL.
Thoughts?
**Some Additional Information:**
You will also notice that the expression preview of the array ` [ 3 ,4]` already shows a more natural representation: `[ 3, 4 ]`. Because arrays are not storable however, attempting to run this transformation leads to the error: `Object[] value not storable`. This is conflicting behavior. The preview shows a valid transformation, yet the execution of the transformation results in an error. See issue #1088 for more information on storing and displaying arrays in GREL.
|
https://github.com/OpenRefine/OpenRefine/issues/2040
|
https://github.com/OpenRefine/OpenRefine/pull/3654
|
3db9453661261e1917aaa21fd3c1e3559536f6f2
|
3e20bc8da05210a7c52fe761d7618711d7d54641
| 2019-05-06T16:14:05Z |
java
| 2021-02-27T22:29:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,012 |
["main/src/com/google/refine/importers/TextFormatGuesser.java"]
|
Clipboard paste on Turtle file content uploads forever
|
**Describe the bug**
Pasting the contents of a valid Turtle file into the Clipboard importer causes forever loading of /command/core/get-importing-job-status
**To Reproduce**
Steps to reproduce the behavior:
1. Click Create Project from Clipboard
2. Paste example Turtle file content
3. Click Next
**Current Results**
See forever uploading and continuous logging in console for /get-importing-job-status
**Expected behavior**
Pasting file content and uploading should behave the same as importing a file with the same content from your computer.
**Desktop (please complete the following information):**
- OS: Windows 10
- Browser Version: Firefox latest
- JRE or JDK Version: java version "1.8.0_201"
**OpenRefine (please complete the following information):**
- Version: OpenRefine Trunk
**Datasets**
test.ttl
https://drive.google.com/file/d/1AG_u-ZHfPVqhUZ0l4rtcBZ8DB-ScScLG/view?usp=sharing
|
https://github.com/OpenRefine/OpenRefine/issues/2012
|
https://github.com/OpenRefine/OpenRefine/pull/2014
|
7099ec3a35dac7f86a110e451c9801679a75af27
|
4e7e73432a825ff6f154fdf94f65d868f3a3ef69
| 2019-04-10T01:02:14Z |
java
| 2019-04-11T07:39:53Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,007 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
Speed of Reconcile with Wikidata
|
Hi there,
Is there a way to know what is costing time when reconciling data with Wikidata? It feels very very slow when I try to reconcile a list of technologies names with the built-in wikidata reconciliation function (~10 minutes per entry). But when I go to wikidata to search these terms the website seems pretty fast.
I want to know what is taking time. When checking logs of OpenRefine, the only log that seems related is the following line:
```
17:32:08.047 [ refine] POST /command/core/reconcile (29493ms)
```
Is there a way to inspect more about the communication between OpenRefine and the reconciliation service? Thanks.
|
https://github.com/OpenRefine/OpenRefine/issues/2007
|
https://github.com/OpenRefine/OpenRefine/pull/3792
|
3bd053afa1f0665064dbd2db4672963b87c533e2
|
e9123ece73fdeb41d4d471eaced005e6773aa735
| 2019-04-04T18:09:13Z |
java
| 2021-05-04T07:30:50Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,002 |
["main/tests/cypress/package.json", "main/tests/cypress/yarn.lock"]
|
Using "search for match" sends back to the first row
|
**Describe the bug**
When reconciling, after matching an entry using the "Search for match" button, the display moves to the first rows of the first page of the project instead of staying at the point we were at.
**To Reproduce**
Steps to reproduce the behavior:
0. Open a project that is several pages long and reconcile a column.
1. Go to the second page of results
2. Click on the "Search for match button" on an entry that has not been automatically reconciled, which opens a modal window
3. Click on the match button
4. The rows displayed are now the first ones of the first page.
**Current Results**
A page that has likely already completely reconciled is displayed and we must navigate again to the page we are working on (which can become really frustrating if we have a project with a lot of pages and many entries to reconcile manually.)
**Expected behavior**
When the modal is closed, the same rows that were displayed before we used it are still displayed.
**Screenshots**
**Desktop (please complete the following information):**
- OS: Ubuntu 18.04 & 18.10
- Browser Version: Firefox 66
- JRE or JDK Version: openjdk version "1.8.0_191"
**OpenRefine (please complete the following information):**
- Version OpenRefine 3.1 Beta
**Datasets**
Any dataset
|
https://github.com/OpenRefine/OpenRefine/issues/2002
|
https://github.com/OpenRefine/OpenRefine/pull/5098
|
3b44b64d3811d3a07077951490c87040990c7ba0
|
85d6e75f53318f37e3a6b8a417b403b1fbd0cdd8
| 2019-03-30T11:50:50Z |
java
| 2022-07-20T18:41:37Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,000 |
["refine"]
|
curl and proxy
|
checks performed by `curl` (or `wget`) on the default interface `127.0.0.0.1` in `check_running` with `refine` shell script should never use a proxy server : the `--noproxy 127.0.0.0.1` parameter would avoid any bad network/proxy configuration.
```patch
--- refine 2019-03-28 14:43:15.710000051 +0100
+++ refine.curl 2019-03-28 15:03:26.410000074 +0100
@@ -154,7 +154,7 @@
CHECK_STR="<title>OpenRefine</title>"
if [ "$CURL" ] ; then
- curl -s -S -f $URL > /dev/null 2>&1
+ curl --noproxy 127.0.0.1 -s -S -f $URL > /dev/null 2>&1
if [ "$?" = "7" ] || [ "$?" = "22" ] ; then
NOT_RUNNING="1"
fi
@@ -167,7 +167,7 @@
if [ -z "${NOT_RUNNING}" ] ; then
if [ "$CURL" ] ; then
- RUNNING=`curl -s $URL | grep "$CHECK_STR"`
+ RUNNING=`curl --noproxy 127.0.0.1 -s $URL | grep "$CHECK_STR"`
elif [ "$WGET" ] ; then
RUNNING=`wget -q -O - $URL | grep "$CHECK_STR"`
fi
```
I leave it to you to look for `wget`, thanks for OpenRefine :+1: , regards, lacsaP.
|
https://github.com/OpenRefine/OpenRefine/issues/2000
|
https://github.com/OpenRefine/OpenRefine/pull/6361
|
d5f8c40d5bf3ef77171bf8185c63334f0b3141b3
|
6a65c6b6227b2e7eb37f0655ea9a1019614415b7
| 2019-03-28T14:23:40Z |
java
| 2024-02-16T16:01:41Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,998 |
["main/src/com/google/refine/expr/functions/strings/Diff.java", "main/tests/server/src/com/google/refine/tests/expr/functions/strings/DiffTests.java"]
|
Diff function has unpredictable results
|
**Describe the bug**
Using Diff and comparing Dates for equality in 2 columns sometimes leads to unexpected results.
**To Reproduce**
Steps to reproduce the behavior:
1. Have 2 columns of dates to compare, where column `end_date` value is `2900-01-01-T00:00:00Z` and column `begin_date` value is `1923-08-03-T00:00:00Z`
2. Compare dates in 2 columns with this GREL:
`diff(cells['end_date'].value, cells['begin_date'].value, "days")`
**Current Results**
?
**Expected behavior**
Negative number is expected
**Desktop (please complete the following information):**
- OS: Windows 10
- Browser Version: Chrome
- JRE or JDK Version: JRE 1.8.0_181]
**OpenRefine (please complete the following information):**
- Version OpenRefine 3.1
**Additional context**
See Mailing List https://groups.google.com/d/msg/openrefine/cwgIgA7-d8k/OJmEAc4nBAAJ
This is possibly being caused by an incorrect comparison.
From java.time.OffsetDateTime notes: "This is a value-based class; use of identity-sensitive operations (including reference equality (==), identity hash code, or synchronization) on instances of OffsetDateTime may have unpredictable results and should be avoided. The equals method should be used for comparisons." - https://docs.oracle.com/javase/8/docs/api/java/time/OffsetDateTime.html
Our code is here:
https://github.com/OpenRefine/OpenRefine/blob/ebaad96dfc33f44b1a0904800cd8bdac7c655220/main/src/com/google/refine/expr/functions/strings/Diff.java#L58
|
https://github.com/OpenRefine/OpenRefine/issues/1998
|
https://github.com/OpenRefine/OpenRefine/pull/2056
|
5bda3bcbefb63ab7855ab1971b0fc420153c5422
|
dfa0ab17bc24d9dd706bc347502d26d4186ba9dc
| 2019-03-27T14:23:13Z |
java
| 2019-06-05T08:42:40Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,994 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
Failure to load project metadata containing customMetadata
|
**Describe the bug**
When a project metadata.json contains a populated customMetadata hash - e.g.
```
"customMetadata": {
"hash": "a9f7bc0818ab566264e5b83d17eb745c"
},
```
OpenRefine fails to read the metadata, and the list of projects does not display in the UI
**To Reproduce**
- Ensure there is a project with customMetadata hash in your data directory
- Run OpenRefine
**Current Results**
In console:
```
22:51:47.936 [..ject_metadata_utilities] load metadata failed: /Users/damyantiandowen/Library/Application Support/OpenRefine/1894812472650.project/metadata.old.json (1ms)
22:51:47.936 [..ject_metadata_utilities] com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot construct instance of `java.io.Serializable` (no Creators, like default construct, exist): abstract types either need to be mapped to concrete types, have custom deserializer, or contain additional type information
at [Source: (FileReader); line: 1, column: 124] (through reference chain: com.google.refine.ProjectMetadata["customMetadata"]->java.util.LinkedHashMap["hash"])
at com.fasterxml.jackson.databind.exc.InvalidDefinitionException.from(InvalidDefinitionException.java:67)
at com.fasterxml.jackson.databind.DeserializationContext.reportBadDefinition(DeserializationContext.java:1452)
at com.fasterxml.jackson.databind.DeserializationContext.handleMissingInstantiator(DeserializationContext.java:1028)
at com.fasterxml.jackson.databind.deser.AbstractDeserializer.deserialize(AbstractDeserializer.java:265)
at com.fasterxml.jackson.databind.deser.std.MapDeserializer._readAndBindStringKeyMap(MapDeserializer.java:527)
at com.fasterxml.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:364)
at com.fasterxml.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:29)
at com.fasterxml.jackson.databind.deser.impl.FieldProperty.deserializeAndSet(FieldProperty.java:136)
at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserializeFromObject(BeanDeserializer.java:369)
at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:159)
at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4013)
at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3049)
at com.google.refine.io.ProjectMetadataUtilities.loadFromFile(ProjectMetadataUtilities.java:161)
at com.google.refine.io.ProjectMetadataUtilities.loadMetaDataIfExist(ProjectMetadataUtilities.java:108)
at com.google.refine.io.ProjectMetadataUtilities.load(ProjectMetadataUtilities.java:97)
at com.google.refine.io.FileProjectManager.loadProjects(FileProjectManager.java:436)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.fasterxml.jackson.databind.deser.impl.MethodProperty.deserializeAndSet(MethodProperty.java:139)
at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:252)
at com.fasterxml.jackson.databind.ObjectReader._bindAndClose(ObjectReader.java:1613)
at com.fasterxml.jackson.databind.ObjectReader.readValue(ObjectReader.java:1262)
at com.google.refine.io.FileProjectManager.loadFromFile(FileProjectManager.java:367)
at com.google.refine.io.FileProjectManager.load(FileProjectManager.java:347)
at com.google.refine.io.FileProjectManager.<init>(FileProjectManager.java:92)
at com.google.refine.io.FileProjectManager.initialize(FileProjectManager.java:79)
at com.google.refine.RefineServlet.init(RefineServlet.java:141)
at javax.servlet.GenericServlet.init(GenericServlet.java:241)
at edu.mit.simile.butterfly.Butterfly.init(Butterfly.java:180)
at org.mortbay.jetty.servlet.ServletHolder.initServlet(ServletHolder.java:440)
at org.mortbay.jetty.servlet.ServletHolder.doStart(ServletHolder.java:263)
at com.google.refine.RefineServer.configure(Refine.java:291)
at com.google.refine.RefineServer.init(Refine.java:203)
at com.google.refine.Refine.init(Refine.java:109)
at com.google.refine.Refine.main(Refine.java:103)
(0ms)
```
In UI - no projects display
**Expected behavior**
customMetadata should be read
projects should show in UI
**OpenRefine (please complete the following information):**
- 3.2 beta
**Additional context**
Additionally, using the "About" button in the UI which should normally show the project metadata does not show relevant information:
Project metadata display in OpenRefine 3.1
<img width="1372" alt="Screenshot 2019-03-24 at 22 57 37" src="https://user-images.githubusercontent.com/576174/54887230-7069a000-4e88-11e9-8adb-68674bfdbe0f.png">
Project metadata display in OpenRefine 3.2 (same project)
<img width="307" alt="Screenshot 2019-03-24 at 22 58 40" src="https://user-images.githubusercontent.com/576174/54887239-81b2ac80-4e88-11e9-9c2d-ac92b95ca0d2.png">
|
https://github.com/OpenRefine/OpenRefine/issues/1994
|
https://github.com/OpenRefine/OpenRefine/pull/3155
|
37ae9a3d51a27de3a4ce2db18a4416dadcff9cb8
|
a61a0526c1dbae4a9585c899327c242f64e9bbde
| 2019-03-24T22:59:44Z |
java
| 2020-09-02T17:18:46Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,990 |
["main/src/com/google/refine/commands/history/ApplyOperationsCommand.java", "main/src/com/google/refine/io/FileHistoryEntryManager.java", "main/src/com/google/refine/model/AbstractOperation.java", "main/src/com/google/refine/operations/OperationResolver.java", "main/src/com/google/refine/operations/UnknownOperation.java", "main/tests/server/src/com/google/refine/tests/history/FileHistoryEntryManagerTests.java", "main/tests/server/src/com/google/refine/tests/history/HistoryEntryTests.java"]
|
Extract Operation Corrupted
|
**Describe the bug**
I started using OpenRefine Version 3.2-beta [8d89a2a]. It seems to have corrupted by undo history--specifically on a number of projects that I've touched, I can no longer "Extract" my history as JSON.
Going back to version 3.1, I find that 3.1 can't extract the history either. Making an edit in 3.1 seems to fix the problem going forward, so that I can then go back to 3.2-beta and see this:
**To Reproduce**
I can share the project via e-mail, but I haven't been able to replicate the "corruption."
**Desktop (please complete the following information):**
- OS: Windows 10
- Browser Version: Version 72.0.3626.121 (Official Build) (64-bit)
- JRE or JDK Version:
-- java version "1.8.0_121"
-- Java(TM) SE Runtime Environment (build 1.8.0_121-b13)
-- Java HotSpot(TM) Client VM (build 25.121-b13, mixed mode)
**OpenRefine (please complete the following information):**
- OpenRefine Version 3.2-beta [8d89a2a]
**Datasets**
Will share via e-mail
|
https://github.com/OpenRefine/OpenRefine/issues/1990
|
https://github.com/OpenRefine/OpenRefine/pull/2026
|
9f00f25916ca880b86d4923509ce5b601ff83afc
|
98dffc4fdf21ffc328beda00b5fad6d64a7117c8
| 2019-03-22T19:58:12Z |
java
| 2019-05-11T08:37:47Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,989 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
new java.io.FileNotFoundException messages in console output when a (non-existent) custom workspace path is set
|
Some commit between 3.1 and 3.2 beta changed the behavior of the console output when a (non-existent) custom workspace path is set (e.g. ./refine -d /tmp/test). There are new explicit java.io.FileNotFoundException messages. This change makes it slightly more difficult to grep logfiles for (important) exceptions. Maybe it's better to silence these messages?
OpenRefine 3.1
```
[felix@tux openrefine-3.1]$ ./refine -d /tmp/test1
(...)
23:36:08.666 [ refine] Starting OpenRefine 3.1 [b90e413]... (484ms)
23:36:08.666 [ refine] initializing FileProjectManager with dir (0ms)
23:36:08.666 [ refine] /tmp/test1 (0ms)
23:36:08.672 [ FileProjectManager] Failed to load workspace from any attempted alternatives. (6ms)
```
OpenRefine 3.2 beta
```
[felix@tux openrefine-3.2-beta]$ ./refine -d /tmp/test2
(...)
23:35:01.567 [ refine] Starting OpenRefine 3.2-beta [8d89a2a]... (465ms)
23:35:01.567 [ refine] initializing FileProjectManager with dir (0ms)
23:35:01.567 [ refine] /tmp/test2 (0ms)
23:35:01.719 [ FileProjectManager] java.io.FileNotFoundException: /tmp/test2/workspace.json (No such file or directory) (152ms)
23:35:01.719 [ FileProjectManager] java.io.FileNotFoundException: /tmp/test2/workspace.temp.json (No such file or directory) (0ms)
23:35:01.719 [ FileProjectManager] java.io.FileNotFoundException: /tmp/test2/workspace.old.json (No such file or directory) (0ms)
23:35:01.720 [ FileProjectManager] Failed to load workspace from any attempted alternatives. (1ms)
```
|
https://github.com/OpenRefine/OpenRefine/issues/1989
|
https://github.com/OpenRefine/OpenRefine/pull/3016
|
6eea757534593e6bc80130290747d1ecd317d796
|
3210f14f3374e4b7efce3a5fa6aba9aa38bd26a9
| 2019-03-21T23:04:34Z |
java
| 2020-07-30T12:50:32Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,986 |
["extensions/database/pom.xml"]
|
3 Test error
|
[ERROR] Tests run: 580, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 71.381 s <<< FAILURE! - in TestSuite
[ERROR] testFetchCurrent(com.google.refine.tests.operations.recon.ExtendDataOperationTests) Time elapsed: 10.012 s <<< FAILURE!
java.lang.NullPointerException
at com.google.refine.tests.operations.recon.ExtendDataOperationTests.testFetchCurrent(ExtendDataOperationTests.java:263)
[ERROR] testFetchRecord(com.google.refine.tests.operations.recon.ExtendDataOperationTests) Time elapsed: 10.001 s <<< FAILURE!
java.lang.NullPointerException
at com.google.refine.tests.operations.recon.ExtendDataOperationTests.testFetchRecord(ExtendDataOperationTests.java:303)
[ERROR] testToDate(com.google.refine.tests.expr.functions.strings.ToFromConversionTests) Time elapsed: 0.121 s <<< FAILURE!
java.lang.AssertionError: expected [2012-03-01T00:00Z] but found [2012-02-29T16:00Z]
at com.google.refine.tests.expr.functions.strings.ToFromConversionTests.testToDate(ToFromConversionTests.java:164)
|
https://github.com/OpenRefine/OpenRefine/issues/1986
|
https://github.com/OpenRefine/OpenRefine/pull/5209
|
03eb640af5f770b60709bbb4e0171553387c82c5
|
60856b74f280313329bc756f0d4c6c9978dde354
| 2019-03-19T02:46:18Z |
java
| 2022-08-24T19:02:21Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,984 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
XLSX export error
|
Getting the following error trying to export to XLSX in version 3.2:
HTTP ERROR 500
Problem accessing /command/core/export-rows/extract-judgments-QDC-csv.xlsx. Reason:
DEFAULT
Caused by:
java.lang.NoSuchFieldError: DEFAULT
at org.apache.poi.xssf.usermodel.XSSFWorkbook.<init>(XSSFWorkbook.java:125)
at com.google.refine.exporters.XlsExporter.export(XlsExporter.java:75)
at com.google.refine.commands.project.ExportRowsCommand.doPost(ExportRowsCommand.java:115)
at com.google.refine.RefineServlet.service(RefineServlet.java:189)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166)
at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:81)
at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:132)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:938)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:755)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Powered by Jetty://
Using version 3.2 on MacOS Mojave.
CSV and XLS exports working OK.
|
https://github.com/OpenRefine/OpenRefine/issues/1984
|
https://github.com/OpenRefine/OpenRefine/pull/3016
|
6eea757534593e6bc80130290747d1ecd317d796
|
3210f14f3374e4b7efce3a5fa6aba9aa38bd26a9
| 2019-03-14T03:54:21Z |
java
| 2020-07-30T12:50:32Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,981 |
["main/pom.xml", "main/src/com/google/refine/exporters/XlsExporter.java", "main/src/com/google/refine/importers/ExcelImporter.java", "main/tests/server/src/com/google/refine/tests/exporters/XlsxExporterTests.java", "main/tests/server/src/com/google/refine/tests/importers/ExcelImporterTests.java"]
|
Cannot open Excel file in Openrefine 3.2-beta
|
The following file cannot be opened in Openrefine 3.2-beta (on Windows 10 and Java 1.8).
The error I get is the following:
```
java.lang.NoSuchMethodError: org.apache.poi.util.POILogger.log(ILjava/lang/Object;)V
at org.apache.poi.openxml4j.opc.PackageRelationshipCollection.parseRelationshipsPart(PackageRelationshipCollection.java:304)
at org.apache.poi.openxml4j.opc.PackageRelationshipCollection.<init>(PackageRelationshipCollection.java:156)
at org.apache.poi.openxml4j.opc.PackageRelationshipCollection.<init>(PackageRelationshipCollection.java:124)
at org.apache.poi.openxml4j.opc.PackagePart.loadRelationships(PackagePart.java:559)
at org.apache.poi.openxml4j.opc.PackagePart.<init>(PackagePart.java:112)
at org.apache.poi.openxml4j.opc.PackagePart.<init>(PackagePart.java:83)
at org.apache.poi.openxml4j.opc.PackagePart.<init>(PackagePart.java:128)
at org.apache.poi.openxml4j.opc.ZipPackagePart.<init>(ZipPackagePart.java:78)
at org.apache.poi.openxml4j.opc.ZipPackage.getPartsImpl(ZipPackage.java:188)
at org.apache.poi.openxml4j.opc.OPCPackage.getParts(OPCPackage.java:623)
at org.apache.poi.openxml4j.opc.OPCPackage.open(OPCPackage.java:230)
at org.apache.poi.util.PackageHelper.open(PackageHelper.java:39)
at org.apache.poi.xssf.usermodel.XSSFWorkbook.<init>(XSSFWorkbook.java:187)
at com.google.refine.importers.ExcelImporter.createParserUIInitializationData(ExcelImporter.java:98)
at com.google.refine.importing.DefaultImportingController.doInitializeParserUI(DefaultImportingController.java:215)
at com.google.refine.importing.DefaultImportingController.doPost(DefaultImportingController.java:90)
at com.google.refine.commands.importing.ImportingControllerCommand.doPost(ImportingControllerCommand.java:62)
at com.google.refine.RefineServlet.service(RefineServlet.java:189)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166)
at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:81)
at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:132)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:923)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:547)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
```
[ordine.xlsx](https://github.com/OpenRefine/OpenRefine/files/2954388/ordine.xlsx)
|
https://github.com/OpenRefine/OpenRefine/issues/1981
|
https://github.com/OpenRefine/OpenRefine/pull/2011
|
b8de8905ba64f2b01f781ed5cbe04e6c789a0e10
|
057e59aa4170efe8575f14c0b6a42aa8e4e97bbe
| 2019-03-11T22:05:53Z |
java
| 2019-04-14T19:52:28Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,978 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
discrepancy in number of rows expected
|
**Describe the bug**
I have a txt file (table using | delimiter) with only 7 columns, but 755846 rows (including 1 header row).
When I import it into OR it tells me there are only 755797 rows (or records, no difference in number)
I have checked the input file and there 0 duplicate rows and there are 0 blank rows
Whats even more weird is that when I export that same data from OR as a tsv file and open it a text editor (or use wc -l) it tells me it contains 755846 rows!
So why does the OR view of it tell me there are 50 less rows than it actually has?
**To Reproduce**
unfortunately the input file contains some unpublished data so I cannot openly share it here.
**Screenshots**
The input file has this summary:
When imported into OR it shows this:
when exported from OR and opened in a text editor again, it shows this:
**Desktop (please complete the following information):**
- OS: Windows 10,
- Browser Version: Chrome Version 72.0.3626.121 (Official Build) (64-bit)
- java version "1.8.0_201"
**OpenRefine (please complete the following information):**
- Version 3.1 [b90e413]
Any suggestions?
|
https://github.com/OpenRefine/OpenRefine/issues/1978
|
https://github.com/OpenRefine/OpenRefine/pull/2965
|
8cfdd5747aee7ff360069ed692576c2c9230f230
|
fa682d0e224c0b3f460b9a3ff1e85d262c8ac499
| 2019-03-08T11:37:46Z |
java
| 2020-07-20T12:48:41Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,974 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
Add "Select all/none" button when importing multi-sheet Excel
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
When I'm creating a new project and import data from an Excel-file that has for instance 12 worksheets, the 12 checkboxes associated with those 12 sheets are all checked by default (see screenshot). When I only need 1 sheet in my project, I now need to deselect the other 11 sheets one-by-one by hand, which is unhandy.
**Describe the solution you'd like**
I'd like a button to select/deselect all the 12 checkboxes at once. This could be placed next to (or rather: in front of) "Worksheets to Import"
|
https://github.com/OpenRefine/OpenRefine/issues/1974
|
https://github.com/OpenRefine/OpenRefine/pull/2965
|
8cfdd5747aee7ff360069ed692576c2c9230f230
|
fa682d0e224c0b3f460b9a3ff1e85d262c8ac499
| 2019-03-05T10:01:13Z |
java
| 2020-07-20T12:48:41Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,973 |
["main/webapp/modules/core/scripts/project.js"]
|
Remove freebaseapps.com from scripts
|
Example:
https://github.com/OpenRefine/OpenRefine/blob/af8608e897263bd7b5cb13c0b19d80dac61e09bb/main/webapp/modules/core/scripts/project.js#L57
|
https://github.com/OpenRefine/OpenRefine/issues/1973
|
https://github.com/OpenRefine/OpenRefine/pull/2395
|
b5282fcce7cbd13b5e9ccd5a83a895e34fb42877
|
fd12ea8c5d6367a5f9122be4ea1c21b751abc167
| 2019-03-01T18:09:51Z |
java
| 2020-03-12T10:57:42Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,970 |
["main/tests/cypress/package.json", "main/tests/cypress/yarn.lock"]
|
Disable spell checking for expression fields
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
Spell checking is currently enabled (by default) in the text inputs for expressions. This leads to expressions being underlined as incorrect (see screenshot).
**Describe the solution you'd like**
Spell checking should be disabled. There are standard ways to do that, working in many browsers:
https://stackoverflow.com/questions/254712/disable-spell-checking-on-html-textfields
It looks like all we need is a `spellcheck="false"`.
**Describe alternatives you've considered**
A proper syntax highlighting should be added (#153).
**Additional context**
|
https://github.com/OpenRefine/OpenRefine/issues/1970
|
https://github.com/OpenRefine/OpenRefine/pull/5098
|
3b44b64d3811d3a07077951490c87040990c7ba0
|
85d6e75f53318f37e3a6b8a417b403b1fbd0cdd8
| 2019-02-25T09:30:29Z |
java
| 2022-07-20T18:41:37Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,951 |
["extensions/database/pom.xml"]
|
SQLite database connector
|
The current database connector supports connections to PostgreSQL, MariaDB and MySQL.
A SQLite3 connector would be useful for several reasons:
- there is lots of tooling around SQLite, so it may be possible to use it as glue between different DBMS;
- SQLite3 provides a convenient way of distributing / sharing data in a way that also makes it amenable to querying.
- SQLIte3 is a file based system so it does not require a connection to a running server.
|
https://github.com/OpenRefine/OpenRefine/issues/1951
|
https://github.com/OpenRefine/OpenRefine/pull/6214
|
0df3cbcafcb3f25626133f6b66040328358514f5
|
e0110d300b7a4369839dafbd8d9129c70afae10a
| 2019-02-07T21:13:33Z |
java
| 2023-12-06T08:08:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,948 |
["extensions/database/pom.xml"]
|
Link select cursor not working in Edge 41.16 and Firefox ESR 52.7.5
|
After reconciliation, weblinks to different candidates cannot be clicked. The text select cursor occours instead of the link select cursor (hand). The mouse hover with the link is not visible when the mouse moves over the reconciliation candidates.
Other items like tickmarks and menues are working correctly.
Error occurs with Microsoft Edge 41.16299.785.0 and Firefox ESR 52.7.4 (64 Bit) in Open Refine 3.1. See also:
https://groups.google.com/forum/#!topic/openrefine/IKBZ1wYM1JY
|
https://github.com/OpenRefine/OpenRefine/issues/1948
|
https://github.com/OpenRefine/OpenRefine/pull/4049
|
7e1b7dfb82c374ee1f2831e81b810bc4738c8241
|
de1633cd79666cac13251971dc2f589502fa243c
| 2019-02-05T07:01:47Z |
java
| 2021-07-12T06:33:03Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,944 |
["extensions/wikidata/module/scripts/dialogs/schema-alignment-dialog.js", "extensions/wikidata/src/org/openrefine/wikidata/schema/WbDateConstant.java", "extensions/wikidata/src/org/openrefine/wikidata/schema/WbDateVariable.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbDateConstantTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbDateVariableTest.java"]
|
Wikidata dates with precision > 11 are not allowed
|
From https://github.com/wetneb/openrefine-wikibase/issues/54:
```
org.wikidata.wdtk.wikibaseapi.apierrors.MediaWikiApiErrorException: [modification-failed] Out of range, must be no higher than 11
at org.wikidata.wdtk.wikibaseapi.apierrors.MediaWikiApiErrorHandler.throwMediaWikiApiErrorException(MediaWikiApiErrorHandler.java:62)
at org.wikidata.wdtk.wikibaseapi.ApiConnection.checkErrors(ApiConnection.java:422)
at org.wikidata.wdtk.wikibaseapi.ApiConnection.sendJsonRequest(ApiConnection.java:362)
at org.wikidata.wdtk.wikibaseapi.WbEditingAction.performAPIAction(WbEditingAction.java:720)
at org.wikidata.wdtk.wikibaseapi.WbEditingAction.wbEditEntity(WbEditingAction.java:298)
at org.wikidata.wdtk.wikibaseapi.WikibaseDataEditor.createItemDocument(WikibaseDataEditor.java:247)
at org.openrefine.wikidata.editing.EditBatchProcessor.performEdit(EditBatchProcessor.java:140)
at org.openrefine.wikidata.operations.PerformWikibaseEditsOperation$PerformEditsProcess.run(PerformWikibaseEditsOperation.java:211)
at java.lang.Thread.run(Thread.java:748)
```
|
https://github.com/OpenRefine/OpenRefine/issues/1944
|
https://github.com/OpenRefine/OpenRefine/pull/1946
|
a54786dad60551e6b1dc194650e42f93540066ec
|
7b2e2b5894569bdedc47eae8266879f2d34224b1
| 2019-02-02T14:32:24Z |
java
| 2019-02-20T03:09:02Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,943 |
["main/webapp/modules/core/scripts/views/data-table/cell-ui.js", "main/webapp/modules/core/styles/views/data-table-view.less"]
|
Item preview in reconciliation should show up when hovering a candidate or match
|
From a user:
> I cannot see the Wikidata hovercards. I use OpenRefine 3.1 and tested it with Firefox and Chrome. The browser doesn't make any requests when holding my mouse over an reconciled entry. The preview url (https://tools.wmflabs.org/openrefine-wikidata/en/preview?id=Q42) does work though. Is there something you have to turn on in order to see the hovercards?
This seems to be a fairly common misunderstanding for people who see screenshots or videos and expect that hovering links will display the preview. We should make sure previews are displayed when hovering both matched cells and candidates in unmatched cells.
|
https://github.com/OpenRefine/OpenRefine/issues/1943
|
https://github.com/OpenRefine/OpenRefine/pull/1959
|
7f6831523e910ea9eec79d81a3d2bf10db801d01
|
79394b9c0e635debda7b45d13b49380a925d1aaf
| 2019-01-31T22:13:55Z |
java
| 2019-02-27T10:57:18Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,942 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml", "extensions/wikidata/pom.xml", "main/pom.xml"]
|
String not displayed in UI
|
**Describe the bug**
A clear and concise description of what the bug is.
in the "Add column based on ..." window, we can see this code : "core-views/addasdasd" instead of the expected string
**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
**Current Results**
What results occured or were shown.
**Expected behavior**
A clear and concise description of what you expected to happen or to show.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Desktop (please complete the following information):**
- OS: [e.g. iOS, Windows 10, Linux, Ubuntu 18.04]
- Browser Version: [e.g. Chrome 19, Firefox 61, Safari, NOTE: OpenRefine does not support IE but works OK in most cases]
- JRE or JDK Version:[output of "java -version" e.g. JRE 1.8.0_181]
**OpenRefine (please complete the following information):**
- Version : OpenRefine 3.1
**Datasets**
If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine)
**Additional context**
Add any other context about the problem here.
|
https://github.com/OpenRefine/OpenRefine/issues/1942
|
https://github.com/OpenRefine/OpenRefine/pull/2952
|
3e615651281fff0abb37e94c0a085ae3a9afc75f
|
8cfdd5747aee7ff360069ed692576c2c9230f230
| 2019-01-31T21:15:54Z |
java
| 2020-07-17T17:07:42Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,940 |
["main/src/com/google/refine/exporters/sql/SqlCreateBuilder.java", "main/src/com/google/refine/exporters/sql/SqlInsertBuilder.java", "main/tests/server/src/com/google/refine/exporters/sql/SqlExporterTests.java"]
|
SQL exporter doesn't create compliant column names
|
**Describe the bug**
The SQL exporter will not create SQL-compliant column names. If a column has spaces, they are replaced with "-" by default, and replaced with nothing if the "Trim Column Names" checkbox is unchecked. Hyphens are not an acceptable character in a SQL column name.
**To Reproduce**
Steps to reproduce the behavior:
1. Open a dataset that has column names with spaces in them.
2. Click Export>SQL Exporter.
3. Click "Download" tab.
4. Click Preview
5. Attempt to create a table in an SQL database with the SQL exported by OpenRefine. It will not create, and SQL will print an error like:
````
ERROR: syntax error at or near "-"
LINE 11: Line1-Street TEXT NULL,
^
````
**Current Results**
What results occured or were shown.
**Expected behavior**
The SQL Exporter should, by default, convert column names to an SQL-compliant name, replacing spaces and other illegal characters with "_" (underscore). Column names can also not begin with numbers. They cannot have single quotes or punctuation.
**Screenshots**
<img width="830" alt="image" src="https://user-images.githubusercontent.com/1330459/52015084-c5032700-24a6-11e9-80c2-cecf14078dfe.png">
<img width="388" alt="image" src="https://user-images.githubusercontent.com/1330459/52015094-caf90800-24a6-11e9-9e56-53dd83e88954.png">
<img width="315" alt="image" src="https://user-images.githubusercontent.com/1330459/52015101-cfbdbc00-24a6-11e9-9303-fe6f7eff2b0b.png">
**Desktop (please complete the following information):**
- OS: Mac 10.14.2
- Browser Version: Safari 12.0.2
- JRE or JDK Version: 1.8.0_121
**OpenRefine (please complete the following information):**
- Version 3.1 [b90e413]
|
https://github.com/OpenRefine/OpenRefine/issues/1940
|
https://github.com/OpenRefine/OpenRefine/pull/4685
|
1ed4aaba92564f395c0a91c12c40725455abcc42
|
b5c522eab6ba0eabed5087122820ddad75c6ee80
| 2019-01-30T21:52:04Z |
java
| 2022-04-03T05:05:34Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,936 |
["main/src/com/google/refine/model/recon/StandardReconConfig.java", "main/tests/server/src/com/google/refine/tests/model/recon/StandardReconConfigTests.java"]
|
Disappearing changes
|
**Describe the bug**
Some changes of a project have disappeared when I closed and reopened the project. Before closing it I exported the project and in the history folder there are all the changes. But even re-importing the project I can't see them on screen.
See: https://groups.google.com/forum/#!topic/openrefine/Pw1Bk6eV9hY
**To Reproduce**
It seems that the bug could be reproduced using a reconciliator as the Library of Congress Conciliator or the Geonames conciliator. But it's a strange behaviour that I never encountered before.
**Desktop (please complete the following information):**
- OS: Ubuntu 18.04
- Browser Version: Firefox 64
- JRE or JDK Version: 1.8.0_151
**OpenRefine (please complete the following information):**
- Version: OpenRefine 3.1
|
https://github.com/OpenRefine/OpenRefine/issues/1936
|
https://github.com/OpenRefine/OpenRefine/pull/1937
|
d98b1a5d5c26e9f6edd5949e7bb9a7409cffb6b0
|
b2124d5bb48057d462f98b908fca18cf20142ceb
| 2019-01-22T09:56:51Z |
java
| 2019-02-02T16:25:58Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,934 |
["extensions/wikidata/module/scripts/dialogs/schema-alignment-dialog.js", "main/webapp/modules/core/externals/suggest/suggest-4_3.js", "main/webapp/modules/core/scripts/views/data-table/cell-ui.js", "main/webapp/modules/core/scripts/views/data-table/menu-reconcile.js"]
|
Make entity and property suggest results clickable
|
In Wikidata, when using the entity suggester, it is possible to use a middle click on any result to open it in a new page without selecting it in the suggester. OpenRefine could do the same - that would make it easier to inspect a suggestion before choosing it. This is especially important for the "Search for match" dialog where the validation of the suggest widget triggers an action immediately after.
|
https://github.com/OpenRefine/OpenRefine/issues/1934
|
https://github.com/OpenRefine/OpenRefine/pull/1958
|
7144798aac6984b0581a26e36829c2eff1ad6d1e
|
70094f68b224fd7a2a76d15cbd9bd800514d8962
| 2019-01-19T09:28:32Z |
java
| 2019-02-25T10:30:31Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,933 |
["extensions/wikidata/module/scripts/langsuggest.js", "extensions/wikidata/src/org/openrefine/wikidata/schema/WbLanguageConstant.java", "extensions/wikidata/src/org/openrefine/wikidata/utils/LanguageCodeStore.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbLanguageConstantTest.java"]
|
Update Wikidata languages for monolingual text and terms
|
The list of languages supported by the Wikidata extension stored statically in the UI of the Wikidata extension (for language code completion in terms and monolingual text values).
Relevant files:
* `extensions/wikidata/module/scripts/langsuggest.js`
* `extensions/wikidata/module/scripts/jquery.uls.data.js`
It is also stored in Wikidata-Toolkit, the library that we use in the backend.
We need to update these lists as Wikidata regularly adds new languages. We need a streamlined process to do that before each release.
Originally posted at https://github.com/wetneb/openrefine-wikibase/issues/52 where support for the `mul` code is requested.
|
https://github.com/OpenRefine/OpenRefine/issues/1933
|
https://github.com/OpenRefine/OpenRefine/pull/2060
|
934bd72ec78acffe061ce5e3a4cf1dd9cf7b8435
|
fb597f7b2f96dae58bbdb3663dc7d6cd631751c9
| 2019-01-12T23:25:31Z |
java
| 2019-06-14T13:22:37Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,922 |
["extensions/database/pom.xml"]
|
Update commons-fileupload
|
The `commons-fileupload` library should be updated to (>1.3.1) to fix a vulnerability in the current version.
|
https://github.com/OpenRefine/OpenRefine/issues/1922
|
https://github.com/OpenRefine/OpenRefine/pull/6333
|
77eb12c87effaffcd0c81dbdfd8b563c521ad1b0
|
b42bdda89367e94d2e5204cbc262ac5b368baba2
| 2018-12-31T14:39:15Z |
java
| 2024-01-29T19:33:48Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,917 |
["extensions/wikidata/src/org/openrefine/wikidata/updates/ItemUpdate.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/updates/ItemUpdateTest.java"]
|
Exception when performing edits on Wikidata: "Multiple terms provided for the same language"
|
**Describe the bug**
After some successfully performed edits on Wikidata, the following exception raises and breaks the editing process.
```
Exception in thread "Thread-11" java.lang.IllegalArgumentException: Multiple terms provided for the same language.
at org.wikidata.wdtk.datamodel.implementation.TermedStatementDocumentImpl.constructTermMap(TermedStatementDocumentImpl.java:389)
at org.wikidata.wdtk.datamodel.implementation.TermedStatementDocumentImpl.<init>(TermedStatementDocumentImpl.java:157)
at org.wikidata.wdtk.datamodel.implementation.ItemDocumentImpl.<init>(ItemDocumentImpl.java:96)
at org.wikidata.wdtk.datamodel.implementation.DataObjectFactoryImpl.getItemDocument(DataObjectFactoryImpl.java:277)
at org.wikidata.wdtk.datamodel.helpers.Datamodel.makeItemDocument(Datamodel.java:629)
at org.wikidata.wdtk.datamodel.helpers.Datamodel.makeItemDocument(Datamodel.java:595)
at org.openrefine.wikidata.editing.EditBatchProcessor.performEdit(EditBatchProcessor.java:134)
at org.openrefine.wikidata.operations.PerformWikibaseEditsOperation$PerformEditsProcess.run(PerformWikibaseEditsOperation.java:211)
at java.lang.Thread.run(Thread.java:748)
```
**To Reproduce**
Steps to reproduce the behavior:
1.
**Current Results**
On the web interface the message "Peform [sic] edits on Wikidata // 51% complete" remains, as if the process continued, but the process has actually stopped and no more changes are uploaded to Wikidata.
**Expected behavior**
The problem ("Multiple terms provided for the same language") should be detected and handled **before the editing process starts**.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Desktop (please complete the following information):**
- OS: [e.g. iOS, Windows 10, Linux, Ubuntu 18.04]
- Browser Version: [e.g. Chrome 19, Firefox 61, Safari, NOTE: OpenRefine does not support IE but works OK in most cases]
- JRE or JDK Version:[output of "java -version" e.g. JRE 1.8.0_181]
**OpenRefine (please complete the following information):**
- OpenRefine 3.1
**Datasets**
If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine)
**Additional context**
Add any other context about the problem here.
|
https://github.com/OpenRefine/OpenRefine/issues/1917
|
https://github.com/OpenRefine/OpenRefine/pull/1919
|
4b86f1cd50b03291f40df9f67a9fd2978687526a
|
9a0ee0f568dfbcde4c7d089bd0d6cf09fe762d94
| 2018-12-29T22:52:36Z |
java
| 2019-01-06T14:55:39Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,913 |
["extensions/database/pom.xml"]
|
Sort reconciliation candidates by inverse score
|
Reconciliation services might return their candidates without sorting them by decreasing score. In that case we might want to sort them (with a stable sort) on OpenRefine's side.
Once we agree on what the correct behaviour should be, we should update the documentation of the API here:
https://github.com/OpenRefine/OpenRefine/wiki/Reconciliation-Service-API
Original SO question:
https://stackoverflow.com/questions/53852042/openrefine-reconcile-by-second-or-third-candidate
|
https://github.com/OpenRefine/OpenRefine/issues/1913
|
https://github.com/OpenRefine/OpenRefine/pull/3259
|
632189b7a60b57f32301dbd4a06ebdca9502abcb
|
9fa7f6afe5976d8c9e7505477fc6c8f1c1aa36e8
| 2018-12-19T13:52:12Z |
java
| 2020-10-12T16:00:26Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,912 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/module/langs/translation-fr.json", "extensions/wikidata/module/scripts/dialogs/schema-alignment-dialog.js", "extensions/wikidata/module/styles/dialogs/schema-alignment-dialog.css"]
|
Copy references across statements in Wikidata schema
|
Began using OpenRefine seriously, and the Wikidata support is just fantastic. One thing that would save some time is if after adding a reference in the Wikidata schema, the reference could be "filled down" or copied and pasted, or otherwise duplicated, for cases where all the statements are supported by the same source (e.g. census data).
|
https://github.com/OpenRefine/OpenRefine/issues/1912
|
https://github.com/OpenRefine/OpenRefine/pull/1961
|
bfec5ea2cb329557c25cc1ac26f08a7508ae703c
|
dccc20f1492c920fa2ecd2d5ff147d202e14b69d
| 2018-12-17T19:30:29Z |
java
| 2019-02-27T10:01:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,904 |
["main/pom.xml", "main/src/com/google/refine/importing/ImportingUtilities.java", "main/src/com/google/refine/operations/column/ColumnAdditionByFetchingURLsOperation.java", "main/tests/server/src/com/google/refine/operations/column/ColumnAdditionByFetchingURLsOperationTests.java"]
|
Mock the Url Fetching Tests (because they fail too often as not reachable)
|
**Describe the bug**
When running `refine test` the UrlFetchingTests often fail.
**To Reproduce**
Steps to reproduce the behavior:
1. refine test
**Current Results**
[ERROR] Tests run: 558, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 60.912 s <<< FAILURE! - in TestSuite
[ERROR] testInvalidUrl(com.google.refine.tests.operations.column.ColumnAdditionByFetchingURLsOperationTests) Time elapsed: 5.006 s <<< FAILURE!
java.lang.AssertionError: expected [false] but found [true]
at com.google.refine.tests.operations.column.ColumnAdditionByFetchingURLsOperationTests.testInvalidUrl(ColumnAdditionByFetchingURLsOperationTests.java:226)
**Expected behavior**
URL tests should be mocked against an http server and pass, and not depend on real sites availability.
**Desktop (please complete the following information):**
- OS: Windows 10 64 bit
- JRE or JDK Version: JDK 1.8.0_181 or JDK 11.0.1
**OpenRefine (please complete the following information):**
- Version: Trunk
|
https://github.com/OpenRefine/OpenRefine/issues/1904
|
https://github.com/OpenRefine/OpenRefine/pull/2692
|
983c8bd42278c2a8549969e864ee4db1ca737f73
|
749704518c330c6f96ec3e784c45b8c055d5c6cd
| 2018-12-09T15:21:58Z |
java
| 2020-06-16T07:38:06Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,887 |
["extensions/wikidata/src/org/openrefine/wikidata/editing/NewItemLibrary.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/editing/NewItemLibraryTest.java", "main/src/com/google/refine/model/recon/StandardReconConfig.java"]
|
cell.recon.features not populated when 'new' item used to create a new item
|
**Describe the bug**
After using 'reconcile', marking some items as 'new', then uploading statements to Wikidata, creating new items, the items previously marked as 'new' are now correctly reconciled against the new items that have been created.
However, the properties of the cell.recon.features object are not updated when a new item is created, which leads to misleading information when creating facets or transforms based on these values.
**To Reproduce**
Steps to reproduce the behavior:
1. Reconcile a column, marking and item as 'new'
2. Upload edits to wikidata creating new items in Wikidata
3. Find the newly created item and create a facet or transform using one of:
* `cell.recon.feature.typeMatch`
* `cell.recon.feature.nameMatch`
* `cell.recon.feature.nameLevenshtein`
* `cell.recon.feature.nameWordDistance`
4. See these all appear as `null`
5. Try using the facet `Best candidates name match` - see these entries appear as 'unreconciled' in this facet
**OpenRefine (please complete the following information):**
- Version: OpenRefine 3.1
**Additional context**
I think the correct behaviour here would be to populate the cell.recon.features properties.
If this isn't appropriate for some reason then the `Best candidates name match` facet needs updating to check for items which have cell.recon.match properties but no cell.recon.feature properties
@wetneb what do you think?
|
https://github.com/OpenRefine/OpenRefine/issues/1887
|
https://github.com/OpenRefine/OpenRefine/pull/1925
|
1ed2da338ccd0d7579f787ba59b16d296e8d1bd1
|
6dd9f416390071b52c10e807c1dc1258a5ced5e1
| 2018-12-05T15:38:36Z |
java
| 2019-01-10T03:44:45Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,886 |
["main/webapp/modules/core/scripts/views/data-table/menu-reconcile.js"]
|
"Best candidates name match" facet show "(unreconciled)" for items marked as "new"
|
**Describe the bug**
When using a "Best Candidates name match" facet those items which have been marked as ```new``` are listed as ```(unreconciled)``` in facet
**To Reproduce**
Steps to reproduce the behavior:
1. Reconcile some values and mark some as ```new```
2. Click on Reconcile->Facets->Best candidates name match
3. View facet output
**Current Results**
```new``` items will be shown as ```(unreconciled)```
**Expected behavior**
```new``` items should show as ```new```
**OpenRefine (please complete the following information):**
- Version: OpenRefine 3.1
**Additional context**
May make sense to fix at the same time as #1883
|
https://github.com/OpenRefine/OpenRefine/issues/1886
|
https://github.com/OpenRefine/OpenRefine/pull/1888
|
c8eca193f29b7e30d12b1019c36f6fa916196e75
|
eeb25797f665131eb7bf29c2cf8847b026627681
| 2018-12-04T15:34:22Z |
java
| 2018-12-06T04:19:29Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,884 |
["main/webapp/modules/core/scripts/views/data-table/menu-reconcile.js"]
|
Reconciliation Facet "Judgement Action Timestamp" reads 'number' for all values
|
**Describe the bug**
Following change of behaviour of List Facet (#1666) facets that give a number or date output need explicitly converting to a string to show explicit values in a list facet
One of the Facets supported to help with reconciliation - the ```Judgement Action Timestamp`` facet outputs a Epoch time as a number which leads to just a single entry of ```number``` in the facet.
**To Reproduce**
Steps to reproduce the behavior:
1. Reconcile some values
2. Click on ```Reconcile->Facets->Judgement Action Timestamp```
3. View facet output
**Current Results**
Facet just contains entry ```number```
**Expected behavior**
The previous behaviour would have been to show the Epoch time. A basic fix would be to revert to this previous behaviour
However, given #608 requests support for converting an epoch time to a date, it would be great to implement that functionality, then use it within this facet to give a proper date/time display for this facet
|
https://github.com/OpenRefine/OpenRefine/issues/1884
|
https://github.com/OpenRefine/OpenRefine/pull/1888
|
c8eca193f29b7e30d12b1019c36f6fa916196e75
|
eeb25797f665131eb7bf29c2cf8847b026627681
| 2018-12-03T10:40:22Z |
java
| 2018-12-06T04:19:29Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,883 |
["extensions/database/pom.xml"]
|
Reconcile Facets show 'boolean' instead of true/false
|
**Describe the bug**
Following change of behaviour of List Facet (#1666) facets that give a boolean output need explicitly converting to a string to show the correct true/false values.
Two Facets supported to help with reconciliation
`Best candidate's type match`
`Best candidate's name match`
Need updating to convert their boolean outputs to strings
**To Reproduce**
Steps to reproduce the behavior:
1. Reconcile some values
2. Click on ```Reconcile->Facets->Best candidates * match```
3. View facet output
**Current Results**
Resulting facets says "boolean", where it should have counts for 'true' and 'false'
|
https://github.com/OpenRefine/OpenRefine/issues/1883
|
https://github.com/OpenRefine/OpenRefine/pull/6333
|
77eb12c87effaffcd0c81dbdfd8b563c521ad1b0
|
b42bdda89367e94d2e5204cbc262ac5b368baba2
| 2018-12-03T10:30:15Z |
java
| 2024-01-29T19:33:48Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,882 |
["extensions/wikidata/src/org/openrefine/wikidata/operations/PerformWikibaseEditsOperation.java", "extensions/wikidata/src/org/openrefine/wikidata/operations/SaveWikibaseSchemaOperation.java", "main/lib-local-src/butterfly-1.0.1-sources.jar", "main/lib-local-src/butterfly-1.0.2-sources.jar", "main/lib-local/butterfly-1.0.1.jar", "main/lib-local/butterfly-1.0.2.jar", "main/pom.xml"]
|
Jackson annotations ignored for extensions
|
Serialization and deserialization of classes provided by extensions currently fail, even if the classes were properly migrated to Jackson and tested. The problem comes from the fact that they are loaded dynamically by Butterfly, by a classloader that does not have access to the definition of the Jackson annotations. The annotations are therefore ignored, so Jackson attempts to deserialize and serialize them without any annotations.
|
https://github.com/OpenRefine/OpenRefine/issues/1882
|
https://github.com/OpenRefine/OpenRefine/pull/1889
|
9656ea3f8c83cf22376d406e5da074cd6150c871
|
234ca8486a09936f3b119626b102a8e8ea9dd7ae
| 2018-12-03T02:18:39Z |
java
| 2018-12-30T10:38:36Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,881 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml", "extensions/wikidata/pom.xml", "main/pom.xml"]
|
Refine tests fails for ProjectMetadataTests.serializeProjectMetadata
|
**Describe the bug**
Refine tests fails for ProjectMetadataTests.serializeProjectMetadata
**To Reproduce**
Steps to reproduce the behavior:
1. 'refine clean'
2. 'refine test'
**Current Results**
```
[ERROR] Failures:
[ERROR] ToFromConversionTests.testToDate:164 expected [2012-03-01T00:00Z] but found [2012-03-01T06:00Z]
[ERROR] ProjectMetadataTests.serializeProjectMetadata:22 expected:<{"name":"numeric facet test","tags":[],"created":"2018-09-04T16:07:31Z","modified":"2018-09-04T17:02:31Z","creator":"","contributors":"","subject":"","description":"","rowCount":4,"title":"","homepage":"","image":"","license":"","version":"","customMetadata":{},"importOptionMetadata":[{"guessCellValueTypes":false,"projectTags":[""],"ignoreLines":-1,"processQuotes":true,"fileSource":"(clipboard)","encoding":"","separator":"\\t","storeBlankCellsAsNulls":true,"storeBlankRows":true,"skipDataLines":0,"includeFileSources":false,"headerLines":1,"limit":-1,"quoteCharacter":"\"","projectName":"numeric facet test"}]}> but was:<{"created":"2018-09-04T22:07:31Z","modified":"2018-09-04T23:02:31Z","name":"numeric facet test","tags":[],"creator":"","contributors":"","subject":"","description":"","rowCount":4,"title":"","version":"","license":"","homepage":"","image":"","importOptionMetadata":[{"guessCellValueTypes":false,"projectTags":[""],"ignoreLines":-1,"processQuotes":true,"fileSource":"(clipboard)","encoding":"","separator":"\\t","storeBlankCellsAsNulls":true,"storeBlankRows":true,"skipDataLines":0,"includeFileSources":false,"headerLines":1,"limit":-1,"quoteCharacter":"\"","projectName":"numeric facet test"}],"customMetadata":{}}>
[INFO]
[ERROR] Tests run: 555, Failures: 2, Errors: 0, Skipped: 0
```
**Expected behavior**
Tests Pass
**Desktop (please complete the following information):**
- OS: Windows 10 64bit
- JRE or JDK Version: JDK 1.8.0_181 64bit
**OpenRefine (please complete the following information):**
- Version: OpenRefine 3.1 [Trunk]
|
https://github.com/OpenRefine/OpenRefine/issues/1881
|
https://github.com/OpenRefine/OpenRefine/pull/2662
|
5c801b2d4c9e553c8811552443483bd4d2ab63f1
|
88ab328e93244c74e34b6a44e2037e005dd9276c
| 2018-12-02T04:20:45Z |
java
| 2020-06-03T06:01:22Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,876 |
["main/src/com/google/refine/model/recon/StandardReconConfig.java", "main/tests/server/src/com/google/refine/tests/model/recon/StandardReconConfigTests.java"]
|
Guess reconciliation type command does not work since Jackson migration
|
This is probably due to invalid queries being made or incorrect parsing of the results.
|
https://github.com/OpenRefine/OpenRefine/issues/1876
|
https://github.com/OpenRefine/OpenRefine/pull/1877
|
dd0fa967d03922e8e7dd008af6d6bb02f8046f29
|
d4222c05ef55a13302b669216301eace8a648b4c
| 2018-12-02T00:50:56Z |
java
| 2018-12-09T13:47:40Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,874 |
["main/src/com/google/refine/expr/functions/ToDate.java", "main/src/com/google/refine/util/ParsingUtilities.java", "main/tests/server/src/com/google/refine/tests/expr/functions/strings/ToFromConversionTests.java", "main/tests/server/src/com/google/refine/tests/io/ProjectMetadataTests.java", "main/tests/server/src/com/google/refine/tests/util/ParsingUtilitiesTests.java"]
|
Tests do not pass if the local time is not GMT
|
**Describe the bug**
The date conversion tests do not pass when run from a timezone other than GMT.
**To Reproduce**
Steps to reproduce the behavior:
1. Set your timezone to a location outside GMT
2. Run the tests with `./refine test`
**Current Results**
`[ERROR] ToFromConversionTests.testToDate:164 expected [2012-03-01T00:00Z] but found [2012-02-29T15:00Z]`
|
https://github.com/OpenRefine/OpenRefine/issues/1874
|
https://github.com/OpenRefine/OpenRefine/pull/1880
|
3498e8bd361359e2fbc4b6dfa084e58d18c4ee18
|
5421a23fba268d871d321d297393f0de930df6ea
| 2018-12-01T22:24:33Z |
java
| 2018-12-06T14:01:46Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,857 |
["docs/docs/manual/grelfunctions.md", "main/src/com/google/refine/expr/functions/strings/ParseUri.java", "main/src/com/google/refine/grel/ControlFunctionRegistry.java", "main/tests/server/src/com/google/refine/expr/functions/strings/ParseUriTest.java"]
|
Implement GREL to parse URIs and extract key aspects
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
Given a URI or URL it can be very useful to break down the URI into its constituent parts. Also to check the URI for validity.
The gokbutils extension implements an 'extractHost' function, but this is only a single part of the set of things you might want to extract from a valid URI. Other aspects include:
* scheme or protocol
* host
* port
* path
* fragment (after a #)
* query (after a ?)
**Describe the solution you'd like**
A GREL command or set of GREL commands to make it easy to extract these from a string that looks like a URI. For example:
if value = "https://www.openrefine.org:80/documentation#download":
value.parseURI() -> a set of elements which can be accessed via dot notation or 'get()' function. If 'value' is not a valid URI return an error
value.parseURI().host -> www.openrefine.org
and/or
value.parseURI().get("host") -> www.openrefine.org
and/or
value.parseURI().authority -> www.openrefine.org
and similarly (using either dot or 'get' syntax)
value.parseURI().path -> /documentation
value.parseURI().port -> 80
value.parseURI().scheme -> https
value.parseURI().fragment -> dowload
etc.
**Describe alternatives you've considered**
Some or all of this can be achieved using match or split with the appropriate regular expressions, but the parseURI would allow for the validity of the string as a URI to be checked, and makes it more accessible.
**Additional context**
What I've basically described here is implementing some of the methods of https://docs.oracle.com/javase/7/docs/api/java/net/URI.html
e.g. URI.create(String) would be used to create a URI object from the string
URI.getAuthority would be used to get the host
etc.
|
https://github.com/OpenRefine/OpenRefine/issues/1857
|
https://github.com/OpenRefine/OpenRefine/pull/4697
|
e582a7481e08eedbc9d0ae9419ec53cec7785e9d
|
874a48252274f50f116d6d732d8d384ca34b5691
| 2018-11-22T23:00:35Z |
java
| 2022-04-23T13:08:42Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,844 |
["extensions/database/pom.xml"]
|
Incorrect text on Transform all columns/select columns screen
|
**Describe the bug**
When selecting columns to apply transformations to from the "All->Transform" dropdown, the text on screen reads "Select and Order Columns to Export" rather than "Select and Order Columns to Transform"
This screen also contains a link labelled "Content" that does not seem to have any function
**To Reproduce**
Steps to reproduce the behavior:
1. Go to 'All' dropdown menu
2. Click on 'Transform'
3. Click "OK"
4. See incorrect text
**Current Results**
<img width="822" alt="screenshot 2018-11-21 at 15 31 12" src="https://user-images.githubusercontent.com/576174/48851766-bd871980-eda3-11e8-9d83-f2586c2b3503.png">
**Expected behavior**
Text should read ""Select Columns to Transform"
"Content" link should not be displayed (unless a reason for it can be defined and that action implemented)
|
https://github.com/OpenRefine/OpenRefine/issues/1844
|
https://github.com/OpenRefine/OpenRefine/pull/6221
|
f215cff334824d4e055b57e9b5ecf2986d786794
|
fa56c15d3b36fed141921776da830640a2c2dc0d
| 2018-11-21T15:42:08Z |
java
| 2023-12-06T07:50:22Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,843 |
["main/webapp/modules/core/MOD-INF/controller.js", "main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/dialogs/common-transform-dialog.html", "main/webapp/modules/core/scripts/dialogs/common-transform-dialog.js", "main/webapp/modules/core/scripts/views/data-table/data-table-view.js"]
|
Add option to use the "Common Transforms" when applying transformations from the "All" dropdown menu
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
When applying transformations to All columns (from the "All" dropdown) you have to write the transformations by hand - there is no option to select the pre-set transforms that are in the Common transforms menu when you apply a transformation to a single column
**Describe the solution you'd like**
Add a 'Common Transfroms' option to the All drop down menu. After selecting a transform from the list you would be prompted to select the columns that the transformation will be applied to (in the same way as the "Transform" option from the All menu
Originally requested on #1724 by @jenyoung - splitting out here to keep the feature requests separate
|
https://github.com/OpenRefine/OpenRefine/issues/1843
|
https://github.com/OpenRefine/OpenRefine/pull/3789
|
109956d2350360fc03ecc5a720e3631376f865cc
|
d269a5ea4d591aae467be0b089f5214eb0c057b1
| 2018-11-21T15:37:16Z |
java
| 2021-04-26T09:33:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,840 |
["main/src/com/google/refine/importing/ImportingUtilities.java", "main/tests/server/src/com/google/refine/tests/importing/ImportingUtilitiesTests.java"]
|
Directory traversal (unsafe unzip) vulnerability
|
**Describe the bug**
It is possible to create files outside the temporary folder by importing a zip file containing files with relative paths. This can be used to create scripts and configurations at locations where they can be picked up by applications, other scripts or executed during start up.
Additional information https://snyk.io/research/zip-slip-vulnerability
**To Reproduce**
Video (zipped video because GH extension restrictions) [openrefine_zip_dir_traversal.zip](https://github.com/OpenRefine/OpenRefine/files/2600812/openfire_zip_dir_traversal.zip)
Steps to reproduce the behavior:
Create payload and start server on Linux
```
cd /tmp/
touch "dangerousscript.sh"
zip legitdata.zip "../../../../../../../../tmp/dangerousscript.sh"
python -m http.server 8000
```
Steps on openrefine
1. Start openrefine ($ ./refine)
2. Click on "Create Project"
3. Click on "Web Addresses (URLs)" (also possible through uploading a local zip file)
4. Insert a malicious URL, eg. http://lookslegit.com/cooldata/legitdata.zip
5. If the file does not exist, the malicious file is silently created
If the file does exist, openrefine shows a stack trace (see below) on terminal
**Current Results**
No error nor warning.
**Expected behavior**
Warn the user about dangerous content in the zip and prevent the creation of the file.
**Video**
The video is inside a zip file because github filexetension restrictions.
**Desktop (please complete the following information):**
- OS: Linux (Arch, Debian)
- Browser Version: Not important
- JRE or JDK Version:
```
openjdk version "1.8.0_171"
OpenJDK Runtime Environment (build 1.8.0_171-8u171-b11-2-b11)
OpenJDK 64-Bit Server VM (build 25.171-b11, mixed mode)
```
And
```
openjdk version "1.8.0_192"
OpenJDK Runtime Environment (build 1.8.0_192-b26)
OpenJDK 64-Bit Server VM (build 25.192-b26, mixed mode)
```
**OpenRefine (please complete the following information):**
- Version 3.0 [TRUNK] and 3.1-beta [TRUNK] (maybe also previous versions)
**Stack trace**
```
java.io.FileNotFoundException: /tmp/Jetty_127_0_0_1_3333_webapp____4ulpc9/import/2/raw-data/-2../../../../../../../../tmp/dangerousscript.sh (No such file or directory)
at java.io.FileOutputStream.open0(Native Method)
at java.io.FileOutputStream.open(FileOutputStream.java:270)
at java.io.FileOutputStream.<init>(FileOutputStream.java:213)
at java.io.FileOutputStream.<init>(FileOutputStream.java:162)
at com.google.refine.importing.ImportingUtilities.saveStreamToFile(ImportingUtilities.java:591)
at com.google.refine.importing.ImportingUtilities.explodeArchive(ImportingUtilities.java:749)
at com.google.refine.importing.ImportingUtilities.postProcessRetrievedFile(ImportingUtilities.java:619)
at com.google.refine.importing.ImportingUtilities.saveStream(ImportingUtilities.java:512)
at com.google.refine.importing.ImportingUtilities.download(ImportingUtilities.java:441)
at com.google.refine.importing.ImportingUtilities.download(ImportingUtilities.java:372)
at com.google.refine.importing.ImportingUtilities.retrieveContentFromPostRequest(ImportingUtilities.java:285)
at com.google.refine.importing.ImportingUtilities.loadDataAndPrepareJob(ImportingUtilities.java:141)
at com.google.refine.importing.DefaultImportingController.doLoadRawData(DefaultImportingController.java:119)
at com.google.refine.importing.DefaultImportingController.doPost(DefaultImportingController.java:87)
at com.google.refine.commands.importing.ImportingControllerCommand.doPost(ImportingControllerCommand.java:62)
at com.google.refine.RefineServlet.service(RefineServlet.java:178)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166)
at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:81)
at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:132)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:938)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:755)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
|
https://github.com/OpenRefine/OpenRefine/issues/1840
|
https://github.com/OpenRefine/OpenRefine/pull/1901
|
3f9189c5a7ca72ace7cbb5f7fba99a2cf09f2f61
|
7f7b71459ca031978c3f8024cb14af13446d6d9c
| 2018-11-20T17:14:08Z |
java
| 2018-12-09T17:05:16Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,834 |
["main/webapp/modules/core/scripts/views/data-table/menu-edit-cells.js"]
|
Fix regular expression option in replace menu
|
**Describe the bug**
(Fix coming)
The new search & replace menu (issue #1742) does not work well with "regular expression" option : \ character is escaped when it should not.
**To Reproduce**
Ex : with "regular expression" checked, replacing "x\dx" with "" gives replace(/x\\dx/,"") in GREL, instead of replace (/x\dx/,"")
**Current Results**
What results occured or were shown.
**Expected behavior**
A clear and concise description of what you expected to happen or to show.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Desktop (please complete the following information):**
- OS: [e.g. iOS, Windows 10, Linux, Ubuntu 18.04]
- Browser Version: [e.g. Chrome 19, Firefox 61, Safari, NOTE: OpenRefine does not support IE but works OK in most cases]
- JRE or JDK Version:[output of "java -version" e.g. JRE 1.8.0_181]
**OpenRefine (please complete the following information):**
- Version : OpenRefine 3.1 Beta
**Datasets**
**Additional context**
|
https://github.com/OpenRefine/OpenRefine/issues/1834
|
https://github.com/OpenRefine/OpenRefine/pull/1835
|
5387e91493e0db29efded728c9b7db456dd27701
|
ccde661a273e7606d16340fd37af212dfcbd7c45
| 2018-11-18T11:47:39Z |
java
| 2018-11-22T16:09:34Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,833 |
["main/src/com/google/refine/expr/functions/strings/Find.java", "main/src/com/google/refine/expr/functions/strings/Match.java", "main/tests/server/src/com/google/refine/tests/expr/functions/FindFunctionTests.java", "main/tests/server/src/com/google/refine/tests/expr/functions/strings/FindTests.java", "main/tests/server/src/com/google/refine/tests/expr/functions/strings/MatchTests.java"]
|
In GREL `find` function treat quoted argument as literal string
|
**Describe the bug**
See discussion at https://groups.google.com/forum/#!topic/openrefine/bYOG-bn_2xw
@msaby reported:
> The GREL find() function can take a string as a parameter, but it seems the string is "translated" into regex.
**To Reproduce**
Steps to reproduce the behavior:
1. find ("ab", ".b") --> ["ab"] (because the . is not interpreted as a literal . but as a regex)
**Expected behavior**
The dot '.' in the above expression should be treated as a literal character, not a regular expression dot. Hence expected behaviour is:
find("ab",".b") --> [ ]
find("ab",/.b/) --> ["ab"]
|
https://github.com/OpenRefine/OpenRefine/issues/1833
|
https://github.com/OpenRefine/OpenRefine/pull/2095
|
6616d017259f96894c7cce75a82e110cd1aeed4b
|
154d62ae5b752c26b0fe5416b41577aba984804f
| 2018-11-17T23:21:09Z |
java
| 2019-07-21T16:26:43Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,832 |
["extensions/database/pom.xml"]
|
Cleanup the multiple SLF4j bindings
|
**Describe the bug**
SLF4J API is designed to bind with one and only one underlying logging framework at a time. If more than one binding is present on the class path, SLF4J will emit a warning, listing the location of those bindings.
**To Reproduce**
Steps to reproduce the behavior:
1. Run ./refine
**Current Results**
```
22:40:43.060 [ refine_server] Creating new workspace directory /home/thad/.local/share/openrefine (383ms)
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/thad/OpenRefine/server/target/lib/slf4j-log4j12-1.7.18.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/thad/OpenRefine/main/webapp/WEB-INF/lib/slf4j-log4j12-1.7.18.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
22:40:43.095 [ refine] Starting OpenRefine 3.1-beta [TRUNK]... (35ms)
```
**Expected behavior**
No multiple SLF4J bindings warning.
**Desktop (please complete the following information):**
- OS: Ubuntu 18.04
- Browser Version: Firefox latest
- JRE or JDK Version: OpenJDK 8
**OpenRefine (please complete the following information):**
- Version: Trunk (master)
**Additional Context**
https://www.slf4j.org/codes.html#multiple_bindings
Maybe we want to exclude as runtime dependencies in maven ? and only as compile time ?
|
https://github.com/OpenRefine/OpenRefine/issues/1832
|
https://github.com/OpenRefine/OpenRefine/pull/3091
|
591d47abe3158d35c1bee681be38624b2042e23c
|
0951af8646a9993b41a68f2d182ca82b86d0c1f9
| 2018-11-17T22:57:11Z |
java
| 2020-08-17T12:20:53Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,828 |
["docs/yarn.lock"]
|
Reconcile Biodiversity Taxon names not working in 3.0
|
**Describe the bug**
Reconciliation service
"http://iphylo.org/~rpage/phyloinformatics/services/reconciliation_gbif.php" for GBIF (and the others) do still work in V2.7 but not in 3.0
i.e. no return values
|
https://github.com/OpenRefine/OpenRefine/issues/1828
|
https://github.com/OpenRefine/OpenRefine/pull/4763
|
d36fab8a86806f8ce3e902549a06bb5049d9ae2f
|
b2b3a663472f03365e07ab4c36d1ffa31dd658af
| 2018-11-16T10:53:16Z |
java
| 2022-04-15T07:19:09Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,827 |
["main/src/com/google/refine/browsing/facets/ListFacet.java", "main/tests/server/src/com/google/refine/tests/browsing/facets/ListFacetTests.java"]
|
Filter overrides facet in 3.1 beta
|
**Describe the bug**
Adding a text filter to a column when you already have a facet selected on a different column leads to the facet selection being reset.
**To Reproduce**
Steps to reproduce the behavior:
Example data:
Col 1,Col 2
a,b
c,d
e,f
1. Create a facet on Col 1
2. Select 'a' in that facet -> one row shows
3. Creata a text filter on Col 2
4. Type 'd' into the text filter
5. See that the facet is reset
**Current Results**
The filter essentially overrides the fact
**Expected behavior**
That the facet should remain with the same value selected, the filter should add to this, not override it
**Screenshots**
In 3.0 this works (see 'a' is still selected in facet)
<img width="673" alt="screenshot 2018-11-16 at 09 19 36" src="https://user-images.githubusercontent.com/576174/48612486-0a708780-e981-11e8-8cad-84dffdc7f807.png">
In 3.1 the facet is reset - see that 'a' is no longer selected in the facet:
<img width="666" alt="screenshot 2018-11-16 at 09 22 13" src="https://user-images.githubusercontent.com/576174/48612518-1f4d1b00-e981-11e8-97cc-0dd3f4faf9f0.png">
**Desktop (please complete the following information):**
- OS: macOS Mojave
- Browser Version: Safari Version 12.0.1 (14606.2.104.1.1)
- java version "1.8.0_72"
**OpenRefine (please complete the following information):**
- OpenRefine 3.1 Beta
|
https://github.com/OpenRefine/OpenRefine/issues/1827
|
https://github.com/OpenRefine/OpenRefine/pull/1829
|
b85d4d0cb841a67e9d2bff64a6b902e68c0c84ab
|
3431a9ee1e7497cc8489baa1b6421d43dfd6618d
| 2018-11-16T09:24:25Z |
java
| 2018-11-17T08:56:41Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,822 |
["main/src/com/google/refine/expr/functions/Cross.java", "main/tests/server/src/com/google/refine/tests/expr/functions/CrossFunctionTests.java"]
|
Cross(value) not working with non string value
|
**Describe the bug**
Don't know if it is a bug or a feature, but the new syntax cross(value, "project","col") is only working if value is a string. It won't work with a date or a number. So how can you use this new syntax if the column you want to match with "project.col" contains dates or numbers?
**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
**Current Results**
What results occured or were shown.
**Expected behavior**
A clear and concise description of what you expected to happen or to show.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Desktop (please complete the following information):**
- OS: [e.g. iOS, Windows 10, Linux, Ubuntu 18.04]
- Browser Version: [e.g. Chrome 19, Firefox 61, Safari, NOTE: OpenRefine does not support IE but works OK in most cases]
- JRE or JDK Version:[output of "java -version" e.g. JRE 1.8.0_181]
**OpenRefine (please complete the following information):**
- Version : OpenRefine 3.1
**Datasets**
If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine)
**Additional context**
Add any other context about the problem here.
|
https://github.com/OpenRefine/OpenRefine/issues/1822
|
https://github.com/OpenRefine/OpenRefine/pull/1852
|
998a5423db73d3e9234767b951ba73f9604b3c97
|
0d3c7c7af46f55197a4fce08eaa0780f008a2ab5
| 2018-11-13T15:06:02Z |
java
| 2018-11-24T15:28:05Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,819 |
["extensions/database/pom.xml"]
|
SQL request with LIMIT statement should be allowed
|
**Describe the bug**
The SQL importer does not allow requests containing a LIMIT statement.
It is safe to forbid keywords like UPDATE or DROP, but LIMIT should be allowed
Mathieu
**To Reproduce**
Try to import data from a MySQL database containing a (table_name) table : connect to the database, and make a SELECT * FROM (table_name) LIMIT 10;
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
**Current Results**
What results occured or were shown.
**Expected behavior**
A clear and concise description of what you expected to happen or to show.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Desktop (please complete the following information):**
- OS: [e.g. iOS, Windows 10, Linux, Ubuntu 18.04]
- Browser Version: [e.g. Chrome 19, Firefox 61, Safari, NOTE: OpenRefine does not support IE but works OK in most cases]
- JRE or JDK Version:[output of "java -version" e.g. JRE 1.8.0_181]
**OpenRefine (please complete the following information):**
- Version : OpenRefine 3.1
**Datasets**
If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine)
**Additional context**
Add any other context about the problem here.
|
https://github.com/OpenRefine/OpenRefine/issues/1819
|
https://github.com/OpenRefine/OpenRefine/pull/3091
|
591d47abe3158d35c1bee681be38624b2042e23c
|
0951af8646a9993b41a68f2d182ca82b86d0c1f9
| 2018-11-10T18:28:52Z |
java
| 2020-08-17T12:20:53Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,812 |
["main/webapp/modules/core/scripts/util/encoding.js"]
|
Longer dialogs like "Select Encoding" get cutoff on bottom initially
|
Longer dialogs get cutoff on smaller screens. I saw this caused issues for users sometimes, like she had during the GLAM Wikidata 2018 at this time point https://youtu.be/VOO8IS73Cq0?t=20597
To help a bit, we should initially set to 10% from Top, instead of our current vertical centering via element height approach in `dialog.js`
```javascript
// container.css("top", Math.round((overlay.height() - elmt.height()) / 2) + "px");
container.css("top", "10%");
```
|
https://github.com/OpenRefine/OpenRefine/issues/1812
|
https://github.com/OpenRefine/OpenRefine/pull/1814
|
7eaa83940e97d1d1ee643a37b55a85ea834bab97
|
5e94815f314817ba80ae17b692bc027c246c595a
| 2018-11-06T16:45:08Z |
java
| 2018-11-06T23:01:14Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,805 |
["README.md", "extensions/database/pom.xml", "extensions/gdata/pom.xml", "extensions/pc-axis/pom.xml", "extensions/wikidata/pom.xml", "main/pom.xml", "packaging/pom.xml", "pom.xml", "server/pom.xml"]
|
Add maven goal to run OR
|
The Maven configuration files used by Eclipse do not contain any goal to actually run the software, which means that the developer must configure Eclipse manually to run OR with the right arguments. We should add a Maven goal to run OR.
We might not want `./refine` and `refine.bat` to use the Maven goal to run OR as it would require shipping Maven in the packaged versions.
|
https://github.com/OpenRefine/OpenRefine/issues/1805
|
https://github.com/OpenRefine/OpenRefine/pull/1806
|
04aaaaa709b9824409e98df4769ae391dd931641
|
46ae2a5c183c9eaee10ede1999dca14347a511f5
| 2018-11-04T20:09:09Z |
java
| 2018-11-06T10:06:59Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,780 |
["main/tests/cypress/yarn.lock"]
|
Blue triangle in Wikidata references should be clickable
|
Just like on Wikidata, clicking on the blue triangle next to the list of references in a statement should collapse/expand the list of references. Currently this blue triangle is not clickable.
|
https://github.com/OpenRefine/OpenRefine/issues/1780
|
https://github.com/OpenRefine/OpenRefine/pull/4750
|
a9832d25d219c0dc24621bf3f4c8b7bcea77724f
|
1dcda3c63b24f25afe0a5156eb74cd909901808b
| 2018-10-27T13:05:14Z |
java
| 2022-04-13T09:02:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,779 |
["extensions/wikidata/module/scripts/previewrenderer.js"]
|
Qualifier order should be preserved when making Wikidata edits
|
**Describe the bug**
Add a statement with multiple qualifiers using different properties.
Make the edits on Wikidata.
The qualifier order is not respected.
**Expected behaviour**
The qualifier order should be identical to the order in the schema.
|
https://github.com/OpenRefine/OpenRefine/issues/1779
|
https://github.com/OpenRefine/OpenRefine/pull/1804
|
fe6aef5290e1e0eae121285419f334396109aeb6
|
04aaaaa709b9824409e98df4769ae391dd931641
| 2018-10-27T13:03:04Z |
java
| 2018-11-05T17:34:02Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 1,778 |
["extensions/wikidata/module/scripts/dialogs/perform-edits-dialog.html", "extensions/wikidata/module/scripts/dialogs/perform-edits-dialog.js"]
|
Edit summaries for Wikidata edit batches should have auto-complete
|
Previous edit summaries should be suggested when adding a summary to an edit group in the Wikidata extension, just like the Wikipedia edit interface suggests previous edit summaries.
|
https://github.com/OpenRefine/OpenRefine/issues/1778
|
https://github.com/OpenRefine/OpenRefine/pull/1789
|
96e30158825999d4c8121311077e77ae09f2868f
|
218e0adb153cdea484833aa8e2c083ef9593e41b
| 2018-10-27T13:01:34Z |
java
| 2018-11-01T12:05:13Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.