status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,913 |
["extensions/database/pom.xml"]
|
Toggle on services dialog after adding standard services does not work
|
Before adding any standard service toggling service dialog works fine. But, after adding service it doesn't.
|
https://github.com/OpenRefine/OpenRefine/issues/2913
|
https://github.com/OpenRefine/OpenRefine/pull/6214
|
0df3cbcafcb3f25626133f6b66040328358514f5
|
e0110d300b7a4369839dafbd8d9129c70afae10a
| 2020-07-09T14:47:59Z |
java
| 2023-12-06T08:08:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,910 |
["extensions/database/pom.xml"]
|
Service remove button click event propagates to underlying element
|
**Describe the bug**
<!-- A clear and concise description of what the bug is. -->
When trying to remove a service the service gets selected
**To Reproduce**
Steps to reproduce the behavior:
1. Reconcile ➡ Start reconcile...
2. Click little cross symbol
3. Service start loading
**Current Results**
On selecting the cross precisely (it's small) it is still the underlying element that responds. When reloading the page the old service has been removed.
<!-- What results occurred or were shown. -->
**Expected behavior**
The service is removed, not loaded
<!-- A clear and concise description of what you expected to happen or to show. -->
**Desktop<!-- (please complete the following information)-->:**
- OS: Windows <!-- e.g. iOS, Windows 10, Linux, Ubuntu 18.04 -->
- Browser Version: Chrome <!-- e.g. Chrome 19, Firefox 61, Safari, NOTE: OpenRefine does not support IE but works OK in most cases -->
**OpenRefine <!--(please complete the following information)-->:**
- Version <!-- e.g. OpenRefine 3.0 Beta] -->
OpenRefine 3.4 beta 2
|
https://github.com/OpenRefine/OpenRefine/issues/2910
|
https://github.com/OpenRefine/OpenRefine/pull/6214
|
0df3cbcafcb3f25626133f6b66040328358514f5
|
e0110d300b7a4369839dafbd8d9129c70afae10a
| 2020-07-08T21:00:26Z |
java
| 2023-12-06T08:08:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,905 |
["pom.xml"]
|
Form to add a reconciliation service should be submitted when pressing Enter in the endpoint input
|
**Describe the bug**
Open the dialog to add a new reconciliation service using its endpoint. Type the URL and press Enter.
**Current Results**
Nothing happens.
**Expected behavior**
The form should be submitted.
**Desktop<!-- (please complete the following information)-->:**
- OS: Linux
- Browser Version: Firefox 68.9
- JRE or JDK Version: 11
**OpenRefine <!--(please complete the following information)-->:**
- Version 3.4 beta2
|
https://github.com/OpenRefine/OpenRefine/issues/2905
|
https://github.com/OpenRefine/OpenRefine/pull/5677
|
6d9fc8c17ee63151a1ded235cd0d37b0f8e2e18c
|
ac33e2e8f8980cc1648686d8e2bb9889032e0233
| 2020-07-08T08:37:21Z |
java
| 2023-03-10T19:24:44Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,903 |
["main/pom.xml", "main/src/com/google/refine/RefineServlet.java", "main/src/com/google/refine/commands/recon/GuessTypesOfColumnCommand.java", "main/src/com/google/refine/model/recon/ReconciledDataExtensionJob.java", "main/src/com/google/refine/model/recon/StandardReconConfig.java", "main/tests/server/src/com/google/refine/commands/recon/GuessTypesOfColumnCommandTests.java", "main/tests/server/src/com/google/refine/importers/WikitextImporterTests.java", "main/tests/server/src/com/google/refine/operations/recon/ExtendDataOperationTests.java"]
|
During reconcile its stuck
|
During reconcile the data, the page is stuck and its shows ''working'' from yesterday
### To Reproduce
Steps to reproduce the behavior:
1. Go to 'column'
2. Click on 'reconcile'
### Current Results
its shows WORKING only, but its not working actually
### Expected behavior
<!-- A clear and concise description of what you expected to happen or to show. -->
### Screenshots
**Desktop<!-- (please complete the following information)-->:**
- OS: Windows 10
- Browser Version: Google Crome
- JRE or JDK Version: <!-- output of "java -version" e.g. JRE 1.8.0_181 -->
**OpenRefine :**
- Open refine 3.3
|
https://github.com/OpenRefine/OpenRefine/issues/2903
|
https://github.com/OpenRefine/OpenRefine/pull/2906
|
259705ad5f33b185bfa4bb0384787e68d31095b3
|
9ac54edbba2fd0876b3f2f99c8bc1588799ecb3b
| 2020-07-08T03:31:56Z |
java
| 2020-08-23T12:04:59Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,898 |
[".travis.yml", "main/src/com/google/refine/clustering/binning/FingerprintKeyer.java", "main/tests/server/src/com/google/refine/clustering/binning/KeyerTests.java"]
|
Modernize text normalization (ex-asciify())
|
OpenRefine currently implements its own homegrown diacritic folding in a method called `asciify()` which includes the comment:
> * NOTE: this function deals only with latin-1 supplement and latin-1 extended code charts
In 2020, we need to do better. We are missing a large number of characters (see below for examples). We also don't handle any of the combining diacritics and it can only do a 1-for-1 replacement, so can't handle expanding ligatures.
### Describe the solution you'd like
Normalizing to NFD or NFKD, removing all diacritics, and lower casing would probably be a good starting point and then we can consider adding some of the other things described in this recipe:https://stackoverflow.com/a/1453284/167425
(and requested in #409 and #650).
### Additional context
The list below represents just a **portion** of the "A"s that are excluded from the current list:
U+01CD | Ǎ | 461 | Latin Capital Letter A with caron
U+01CE | ǎ | 462 | Latin Small Letter A with caron
U+01DE | Ǟ | 478 | Latin Capital Letter A with diaeresis and macron | 0323 | for Sami
U+01DF | ǟ | 479 | Latin Small Letter A with diaeresis and macron | 0324
U+01E0 | Ǡ | 480 | Latin Capital Letter A with dot above and macron | 0325
U+01E1 | ǡ | 481 | Latin Small Letter A with dot above and macron
U+0200 | Ȁ | 512 | Latin Capital Letter A with double grave
U+0201 | ȁ | 513 | Latin Small Letter A with double grave
U+0202 | Ȃ | 514 | Latin Capital Letter A with inverted breve
U+0203 | ȃ | 515 | Latin Small Letter A with inverted breve
U+0226 | Ȧ | 550 | Latin Capital Letter A with dot above
U+0227 | ȧ | 551 | Latin Small Letter A with dot above
U+023A | Ⱥ | 570 | Latin Capital Letter A with stroke
U+0386 | Ά | 902 | Greek Capital Letter A with acute accent
U+0391 | Α | 913 | Greek Capital Letter Alpha
U+03B1 | α | 945 | Greek Small Letter Alpha
U+0410 | А | Cyrillic Capital Letter A
|
https://github.com/OpenRefine/OpenRefine/issues/2898
|
https://github.com/OpenRefine/OpenRefine/pull/2900
|
ab2ec8d28f3f03cad37112bfcd8d29bef944cb5d
|
0562638ffa2344a58753cad972bdc6638ffab4b3
| 2020-07-07T02:34:34Z |
java
| 2020-07-07T19:35:41Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,895 |
["main/tests/server/src/com/google/refine/commands/lang/LoadLanguageCommandTests.java"]
|
Intermittent test failure - NPE in testLoadNoLanguage
|
I've seen this failure a few times, most recently in a LGTM build (which probably doesn't need to run the tests, but that aside):
```
[2020-07-06 08:43:11] [autobuild] [ERROR] testLoadNoLanguage(com.google.refine.commands.lang.LoadLanguageCommandTests) Time elapsed: 0.016 s <<< FAILURE!
[2020-07-06 08:43:11] [autobuild] java.lang.NullPointerException
[2020-07-06 08:43:11] [autobuild] at com.google.refine.commands.lang.LoadLanguageCommandTests.testLoadNoLanguage(LoadLanguageCommandTests.java:69)
```
I don't see an obvious cause at first glance, so it'll require some investigation.
|
https://github.com/OpenRefine/OpenRefine/issues/2895
|
https://github.com/OpenRefine/OpenRefine/pull/2922
|
c5e6ac9f9016410dc6b44acc7a700490c4f2eca1
|
561619399cbb0e66e698c76d6aa1154ad39f1e45
| 2020-07-06T20:29:49Z |
java
| 2020-07-14T16:06:04Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,891 |
["main/webapp/modules/core/scripts/facets/facet.js", "main/webapp/modules/core/scripts/project.js"]
|
Facet UI remains hidden when left panel set to be hidden
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
When using facets with the data-table set to full width (added by #2616), the left panel does not reappear to show the facet UI. The facet happens, and the user will need to toggle the left panel back to visible to be able to see it.
**Describe the solution you'd like**
<!-- A clear and concise description of what you want to happen. -->
Since we are not telling the user that it has happened in anyway (except for the table going back to the first row), the left panel should automatically reappear to show the results. We could also just send a message that tells the user to toggle the panel back to see it. Although, the former is more user-friendly.
<img width="960" alt="2020-07-06 (7)" src="https://user-images.githubusercontent.com/52909743/86592053-5639cf80-bfb0-11ea-9f49-520e91c283ea.png">
<img width="960" alt="2020-07-06 (8)" src="https://user-images.githubusercontent.com/52909743/86592056-576afc80-bfb0-11ea-9d3c-6d5dc378a8d3.png">
|
https://github.com/OpenRefine/OpenRefine/issues/2891
|
https://github.com/OpenRefine/OpenRefine/pull/3716
|
50a905e9da5ac93152e93c81361e91ad6c8984d2
|
00b108865f84183ab8ab08fa6c1ee63d8efcd64b
| 2020-07-06T12:17:15Z |
java
| 2021-03-13T10:01:20Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,883 |
["main/webapp/modules/core/langs/translation-en.json"]
|
Importer data type guessing description shouldn't include "dates"
|
The textual description of the text table importer option currently says "Parse cell text into numbers, dates, …" but the code doesn't actually attempt any date conversion.
Change the text to read "Attempt to parse cell text into numbers". ~~Bonus points for updating any easily fixable translations.~~
|
https://github.com/OpenRefine/OpenRefine/issues/2883
|
https://github.com/OpenRefine/OpenRefine/pull/2896
|
0e832e2d7cb61ae88a318fd8fd253f62bd887c09
|
66aeaa44094d6e01f10308aee7570550b0b4184b
| 2020-07-05T22:24:10Z |
java
| 2020-07-06T23:55:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,880 |
["extensions/wikidata/src/org/openrefine/wikidata/schema/WbDateVariable.java", "extensions/wikidata/src/org/openrefine/wikidata/schema/WbLocationVariable.java", "extensions/wikidata/src/org/openrefine/wikidata/schema/WbStringVariable.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbDateVariableTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbItemVariableTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbLanguageVariableTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbLocationVariableTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbStringVariableTest.java", "main/src/com/google/refine/model/changes/DataExtensionChange.java", "main/tests/server/src/com/google/refine/operations/recon/ExtendDataOperationTests.java"]
|
NPE in edit generation in the Wikidata extension
|
**Describe the bug**
Generating edits for string values can fail in the presence of null cells.
**To Reproduce**
Steps to reproduce the behavior:
1. Create a schema that adds a label from a row with a null cell
2. Observe the error
(I cannot believe I have not run into this bug earlier!)
**Current Results**
```
java.lang.NullPointerException
at org.openrefine.wikidata.schema.WbStringVariable.fromCell(WbStringVariable.java:59)
at org.openrefine.wikidata.schema.WbStringVariable.fromCell(WbStringVariable.java:39)
at org.openrefine.wikidata.schema.WbVariableExpr.evaluate(WbVariableExpr.java:82)
at org.openrefine.wikidata.schema.WbStatementExpr.evaluate(WbStatementExpr.java:95)
at org.openrefine.wikidata.schema.WbStatementGroupExpr.evaluate(WbStatementGroupExpr.java:63)
at org.openrefine.wikidata.schema.WbItemDocumentExpr.evaluate(WbItemDocumentExpr.java:79)
at org.openrefine.wikidata.schema.WikibaseSchema.evaluateItemDocuments(WikibaseSchema.java:114)
at org.openrefine.wikidata.schema.WikibaseSchema$EvaluatingRowVisitor.visit(WikibaseSchema.java:171)
at com.google.refine.browsing.util.RowVisitorAsRecordVisitor.visit(RowVisitorAsRecordVisitor.java:61)
at com.google.refine.browsing.util.ConjunctiveFilteredRecords.accept(ConjunctiveFilteredRecords.java:64)
at com.google.refine.browsing.util.FilteredRecordsAsFilteredRows.accept(FilteredRecordsAsFilteredRows.java:50)
at org.openrefine.wikidata.schema.WikibaseSchema.evaluate(WikibaseSchema.java:142)
at org.openrefine.wikidata.commands.PreviewWikibaseSchemaCommand.doPost(PreviewWikibaseSchemaCommand.java:88)
```
**Expected behavior**
The value should be skipped.
**OpenRefine <!--(please complete the following information)-->:**
- Version 3.4 beta2
|
https://github.com/OpenRefine/OpenRefine/issues/2880
|
https://github.com/OpenRefine/OpenRefine/pull/3723
|
787c272fe0b49267b2919af0e922f1b7ca00b94e
|
e664712a701d61e1ec110ffb20285081426eb296
| 2020-07-04T16:57:32Z |
java
| 2021-05-15T06:51:26Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,875 |
["main/tests/server/src/com/google/refine/operations/column/ColumnAdditionByFetchingURLsOperationTests.java"]
|
Spurious test failures in ColumnAdditionByFetchingURLsOperationTests
|
**Describe the bug**
Sometimes the following test fails:
```
[ERROR] Tests run: 704, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 75.502 s <<< FAILURE! - in TestSuite
[ERROR] testHttpHeaders(com.google.refine.operations.column.ColumnAdditionByFetchingURLsOperationTests) Time elapsed: 1.751 s <<< FAILURE!
java.lang.AssertionError: expected [false] but found [true]
at com.google.refine.operations.column.ColumnAdditionByFetchingURLsOperationTests.runAndWait(ColumnAdditionByFetchingURLsOperationTests.java:133)
at com.google.refine.operations.column.ColumnAdditionByFetchingURLsOperationTests.testHttpHeaders(ColumnAdditionByFetchingURLsOperationTests.java:266)
```
**To Reproduce**
Run the tests many times? I find it curious that it does not happen on Travis more often, perhaps my machine is just slow.
**Desktop<!-- (please complete the following information)-->:**
- OS: Linux
- JRE or JDK Version: OpenJDK 11
**OpenRefine <!--(please complete the following information)-->:**
- master branch
|
https://github.com/OpenRefine/OpenRefine/issues/2875
|
https://github.com/OpenRefine/OpenRefine/pull/2876
|
49fd21759c81cfccd08fce8b6ddf20a427bbf2a0
|
f5786afa350c68abf0f001caa961a6b0e9afb52a
| 2020-07-03T17:27:48Z |
java
| 2020-07-03T19:20:01Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,873 |
["extensions/wikidata/src/org/openrefine/wikidata/commands/ConnectionManager.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/commands/LoginCommandTest.java"]
|
Can not log out of wikidata if my wikidata session has already ended
|
**Describe the bug**
If I am logged into wikidata, but my session expires or I get logged out for some reason I can not use the log out button in the app.
**Current Results**
When I do click logout I see the following in the console and the app continues to think that I am logged in.
```
17:33:56.920 [ refine] GET /command/wikidata/login (9487ms)
17:33:56.948 [ refine] POST /command/core/get-all-preferences (28ms)
17:33:58.792 [ refine] GET /command/core/get-csrf-token (1844ms)
17:33:58.807 [ refine] POST /command/wikidata/login (15ms)
17:33:59.078 [ connection_mananger] [assertuserfailed] You are no longer logged in, so the action could not be completed. (271ms)
```
This is probably due to the assertuser option being used for this login call?
**Expected behaviour**
Clicking the logout button in this situation should detect that I am no longer logged in and thus allow me to re login to the app.
**Screenshots**
Stuck here in the app, can not log out
**Desktop<!-- (please complete the following information)-->:**
- OS: Windows 10
- Browser Version: Firefox 76.0.1 (64-bit)
- JRE or JDK Version:
```
java version "1.8.0_91"
Java(TM) SE Runtime Environment (build 1.8.0_91-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.91-b14, mixed mode)
```
**OpenRefine <!--(please complete the following information)-->:**
- Version 3.3
|
https://github.com/OpenRefine/OpenRefine/issues/2873
|
https://github.com/OpenRefine/OpenRefine/pull/2878
|
f4692de9e1827a9a207f9c953fc28230910043c8
|
952447461f2bb45918401f0d4a0dc9458b4e0604
| 2020-07-03T16:36:06Z |
java
| 2020-07-04T06:38:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,869 |
["main/webapp/modules/core/langs/translation-fr.json"]
|
UI label duplicated in English and French
|
**Describe the bug**
When using OpenRefine in French, in the Reconcile dialog, both the French and English version of a label are displayed at the same time: "Correspondance automatique des valeurs candidates Auto-match candidates with high confidence"
**To Reproduce**
Set the UI in French, go to any project, click on any column and open the dialog to start reconciling it.
**Desktop<!-- (please complete the following information)-->:**
- OS: Linux
- Browser Version: Firefox
**OpenRefine <!--(please complete the following information)-->:**
- Version 3.4 beta
|
https://github.com/OpenRefine/OpenRefine/issues/2869
|
https://github.com/OpenRefine/OpenRefine/pull/2871
|
de2c2aa7788d19f53a645ebc28f27e5c691ff7fe
|
49fd21759c81cfccd08fce8b6ddf20a427bbf2a0
| 2020-07-03T13:01:35Z |
java
| 2020-07-03T14:12:43Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,861 |
[".travis.yml"]
|
Stop testing for Oracle JDK in CI
|
The differences between Oracle JDK and OpenJDK are minor starting from version 11. It is probably wasteful to be running both of them in Travis.
More background on the differences: https://www.baeldung.com/oracle-jdk-vs-openjdk
Over the past few years I do not recall encountering any bug in OpenRefine which would only be present with one of OracleJDK and OpenJDK. Running many builds at the same time increases the chances that we run into spurious build failures and can increase the build time if the builds are not run concurrently. So I propose we remove oraclejdk11 from Travis.
|
https://github.com/OpenRefine/OpenRefine/issues/2861
|
https://github.com/OpenRefine/OpenRefine/pull/2866
|
29f6885cccc9c6a28a21f283a6404a38fe06a73f
|
f83c6f43765fb62ae45580702a535cf5636823b0
| 2020-07-02T09:28:37Z |
java
| 2020-07-06T18:31:54Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,850 |
["main/src/com/google/refine/importers/TextFormatGuesser.java", "main/tests/data/Colorado-Municipalities-small-xlsx.gz", "main/tests/server/src/com/google/refine/importers/TextFormatGuesserTests.java", "main/tests/server/src/com/google/refine/importers/films.ods"]
|
Allow XLS and XLSX files without a file extension to be detected as Excel instead of Wikitext
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
Currently, if a XLSX file has no file extension because of someone's preference or OS setup for saving files, then when importing the XLSX file, OpenRefine will not detect it as an Excel file but instead will choose Wikitext importer as the first option.
**Describe the solution you'd like**
XLS and XLSX files should be detected as Excel for the importer regardless of their file extension.
**Describe alternatives you've considered**
Ensuring that files when saved include the .xls or .xlsx extension as well as renaming lots of XLSX files to include the file extension on their filename.
**Additional context**
Windows is an OS that heavily depends on file extensions to navigate and perform actions based on them. However, when a filename has no file extension, OpenRefine should go through its sets of algorithms to detect the most appropriate importer based on the content of the file.
Unfortunately, there is not file signature (magic bytes) for .xls and .xlsx files. Although .xlsx files do start with the same magic bytes as .zip files https://en.wikipedia.org/wiki/List_of_file_signatures
So other detection mechanisms will have to be used such as Apache POI.
**Test file**
Extract file and then try to open `Colorado-Municipalities-XLSX` as well as rename it to just `ColoradoMunicipalities` and notice that OpenRefine will detect as Wikitext and not Excel.
[Colorado-Municipalities-XLSX.zip](https://github.com/OpenRefine/OpenRefine/files/4854060/Colorado-Municipalities-XLSX.zip)
|
https://github.com/OpenRefine/OpenRefine/issues/2850
|
https://github.com/OpenRefine/OpenRefine/pull/2924
|
fb9c8e5fefcc7f6835f9304d30a11ab4502c513b
|
a3fab26cca508ea92f013cfba327d82b95de2c5c
| 2020-06-30T19:36:59Z |
java
| 2020-07-15T06:56:00Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,837 |
["main/pom.xml", "main/src/com/google/refine/importing/ImportingUtilities.java", "main/tests/server/src/com/google/refine/importing/ImportingUtilitiesTests.java"]
|
Creating a project from a URL - HTTP errors are ignored
|
**Describe the bug**
OpenRefine does not show HTTP errors when creating a project from a URL.
Instead it acts like it downloaded successfully but there is nothing shown in the preview data grid.
**To Reproduce**
Steps to reproduce the behavior:
1. Create new project from URL
`https://download.data.world/file_download/associatedpress/covid-impact-survey-public-data/COVID_W2_toplines.zip`
2. Click on Next>>
3. No error is given
4. Preview data grid screen shows as if download completed successfully but is blank
**Current Results**
Preview data grid screen is blank. No HTTP error is shown to user
**Expected behavior**
Should not have gone to preview data grid screen because a 401 error was returned in the response.
**Screenshots**
<!-- If applicable, add screenshots to help explain your problem. -->
**Desktop<!-- (please complete the following information)-->:**
- OS: Windows 10
- Browser Version: Firefox
- JRE or JDK Version: JDK8
**OpenRefine <!--(please complete the following information)-->:**
- Version: OpenRefine (trunk)
|
https://github.com/OpenRefine/OpenRefine/issues/2837
|
https://github.com/OpenRefine/OpenRefine/pull/2870
|
e61d50a1aa35a13507c54946147663a4ba1863be
|
f62f63706c96d40e9de489a5a5f8a26787fb2eca
| 2020-06-29T01:09:09Z |
java
| 2020-07-07T09:58:47Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,835 |
["extensions/database/module/scripts/project/database-exporters.js"]
|
404 on /fr/fr.json during Project Open
|
**Describe the bug**
When loading a project, in the console, if you choose a userLang different than `en`, you get two error lines, `
Failed to load resource: the server responded with a status of 404 (Not Found)` and `:3333/fr/en.json:1 Failed to load resource: the server responded with a status of 404 (Not Found)`
**To Reproduce**
Steps to reproduce the behavior:
1. Choose another language than english
2. Load a project
3. Open JS Console
4. See error
**Current Results**
Note that in english, you have just ONE error line for `EN`.
**Screenshots**
**Desktop<!-- (please complete the following information)-->:**
- OS: MacOS X.14.6
- Browser Version: Chrome latest
- `usarLang` = '`fr`'
**OpenRefine <!--(please complete the following information)-->:**
- Version v3.5 (master)
|
https://github.com/OpenRefine/OpenRefine/issues/2835
|
https://github.com/OpenRefine/OpenRefine/pull/2847
|
0f3a6006f3bd1d901a0dea4c3d5209c6582a0ed2
|
b64cbfea4f055057a085ec3e855943bec628b0b9
| 2020-06-28T22:51:03Z |
java
| 2020-06-30T06:22:12Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,824 |
["main/pom.xml", "main/tests/server/src/com/google/refine/importers/RdfTripleImporterTests.java"]
|
RDF N-Triples import fails with noSuchMethod error
|
This is probably a regression introduced by recent dependency updates:
```
org.apache.jena.ext.com.google.common.util.concurrent.ExecutionError: java.lang.NoSuchMethodError: org.apache.commons.codec.digest.MurmurHash3.hash128x64([B)[J
at org.apache.jena.ext.com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2050)
at org.apache.jena.ext.com.google.common.cache.LocalCache.get(LocalCache.java:3943)
at org.apache.jena.ext.com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4865)
at org.apache.jena.atlas.lib.cache.CacheGuava.getOrFill(CacheGuava.java:58)
at org.apache.jena.riot.lang.BlankNodeAllocatorHash.alloc(BlankNodeAllocatorHash.java:99)
```
### To Reproduce
Use https://researchworks.oclc.org/researchdata/fast/FASTTopical.nt.zip to create a new project.
The preview never renders and the stack trace shows on the server log.
### Comments
It looks like it's looking for Apache `commons-codec` which we've included at various points in the past, but don't currently. Not sure if it's Jena's packaging that's messed up or the way we're picking which dependencies to include.
|
https://github.com/OpenRefine/OpenRefine/issues/2824
|
https://github.com/OpenRefine/OpenRefine/pull/2826
|
043e595ea06d5ef197afb2700aa1cf2143bacde4
|
83f52d4ba500d5dfd523e729c69c7ffb70c0b3e4
| 2020-06-26T20:45:35Z |
java
| 2020-06-27T21:40:21Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,820 |
["main/webapp/modules/core/MOD-INF/controller.js"]
|
Include JSON as a possibility to be guessed for .txt files
|
Files sometimes have different content that does not match the file extension. For example, on Windows depending on the software you have installed, saving a file with JSON content might default to saving it with a `.txt` extension instead of the correct `.json`. On the internet, files might have various extensions or no extensions when downloaded and saved. This is not OpenRefine's direct problem, but OpenRefine should be able to inspect (guess) what content a file truly has.
### Proposed solution
`.txt` extension and no extension are 2 of the common ways that files are sometimes found with structured data inside them.
When dealing with a `.txt` file or no extension, it would be preferable for OpenRefine to first read a portion of a file's beginning content and using that as the first contextual clue of what kind of file it is.
For example:
OpenRefine does not guess JSON format when opening a `.txt` file on Windows 10 that is 100% JSON content. It guesses `line-based` and uses that importer instead, incorrectly. OpenRefine should instead have guessed JSON as the bestFormat in the rankedFormats, by inspecting the beginning of the file chars are JSON content, maybe 50 chars or more?)
Other file extensions normally don't cause context problems in the wild. But `.txt` is the most common format and the one that software and some OS's sometimes default to saving files with and as such `.txt` should be treated as that, "a generic bunch of text that first needs to be inspected for some kind of structured data" in order to determine the right kind of importer.
**Describe alternatives you've considered**
Opening the file in Notepad and then looking at the content of the file myself to make a judgement call of what format it might contain and then clicking the appropriate importer selection on OpenRefine's UI.
**Test File**
[Testfile.txt](https://github.com/OpenRefine/OpenRefine/files/4845532/Testfile.txt)
**Additional Context**
Breakpoint on L970 in ImportingUtilities.java seems like a good start for debugging from what I saw and where it gave text/line-based as the best format in the ranked list.
|
https://github.com/OpenRefine/OpenRefine/issues/2820
|
https://github.com/OpenRefine/OpenRefine/pull/2867
|
28a9f68236ef3c196e448784b8c4247dab64a0f2
|
a4b7a00c703629ebd1aa3e6806e966fc45275bf7
| 2020-06-26T16:39:33Z |
java
| 2020-07-03T06:55:50Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,805 |
["main/src/com/google/refine/importing/ImportingManager.java", "main/src/com/google/refine/importing/ImportingUtilities.java", "main/tests/server/src/com/google/refine/importing/ImportingManagerTests.java", "main/webapp/modules/core/MOD-INF/controller.js"]
|
Support fallback to Structured Syntax Name Suffixes in MIME types
|
We should support the use of [Structured Syntax Name Suffixes](https://tools.ietf.org/html/rfc6838#section-4.2.8) as a fallback for importers.
Currently we support `rdf+xml` and know that it's more specific than the generic `text/xml` so we should try the RDF importer before the XML importer, but if we encounter an unknown type with a syntax suffix, we don't prioritize the appropriate importer.
The idea would be that if we were to encounter `application/3gpdash-qoe-report+xml` or `application/activity+json` (to pick the first ones on the [list](https://www.iana.org/assignments/media-types/media-types.xhtml#application)), we would suggest the XML and JSON importers, respectively, as the first fallback options.
This is something we could implement directly in the importer framework, so perhaps it's orthogonal to the idea that @wetneb had for #2598.
_Originally posted by @tfmorris in https://github.com/OpenRefine/OpenRefine/issues/2598#issuecomment-625901620_
|
https://github.com/OpenRefine/OpenRefine/issues/2805
|
https://github.com/OpenRefine/OpenRefine/pull/2806
|
3aa610d6aabc15bc8dae62df2cb1d65641949286
|
4b146acc6ef8a4f41168824db0967e24d7efb45c
| 2020-06-24T15:38:13Z |
java
| 2020-06-25T06:36:57Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,803 |
["extensions/wikidata/module/scripts/dialogs/schema-alignment-dialog.js"]
|
Reconciled columns not being draggable to item inputs in Wikidata schema
|
**Describe the bug**
In some situations, reconciled columns cannot be dragged and dropped to inputs that expect Wikidata entities.
<!-- A clear and concise description of what the bug is. -->
**To Reproduce**
The exact steps are not clear to me, but this can be observed in the following screencast at 40:00:
https://www.twitch.tv/videos/659297903
**Desktop<!-- (please complete the following information)-->:**
- OS: Windows
- Browser Version: Firefox
- JRE or JDK Version: <!-- output of "java -version" e.g. JRE 1.8.0_181 -->
**OpenRefine <!--(please complete the following information)-->:**
- Version 3.3
|
https://github.com/OpenRefine/OpenRefine/issues/2803
|
https://github.com/OpenRefine/OpenRefine/pull/2872
|
92ad819e34b8df0636090619dc10e5e2efd0ffd1
|
68404abe2a77a1b153ae274e322be448ace49fa8
| 2020-06-24T09:01:10Z |
java
| 2020-08-21T05:15:02Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,800 |
["main/src/com/google/refine/importing/ImportingManager.java", "main/src/com/google/refine/importing/ImportingUtilities.java", "main/tests/server/src/com/google/refine/importing/ImportingManagerTests.java", "main/webapp/modules/core/MOD-INF/controller.js"]
|
File type detection does not recognize JSON in certain cases
|
**Describe the bug**
Creating a project by fetching JSON from certain URLs does not pick the JSON importer by default.
<!-- A clear and concise description of what the bug is. -->
**To Reproduce**
Steps to reproduce the behavior:
1. Go to "Create project"
2. "Web addresses"
3. Use "https://query.wikidata.org/sparql?query=SELECT%20%3Fitem%20%3Furl%20WHERE%20%7B%0A%20%20%3Fitem%20p%3AP6269%20%5Bps%3AP6269%20%3Furl%20%3B%0A%20%20%20%20%20%20%20%20pq%3AP2700%20wd%3AQ458022%5D.%0A%7D%20LIMIT%20100&format=json"
**Current Results**
The default importer is "line-based text files"
**Expected behavior**
The JSON importer should be proposed by default.
**Desktop<!-- (please complete the following information)-->:**
- OS: Windows, Linux
**OpenRefine <!--(please complete the following information)-->:**
- Version 3.3, still present in master
**Additional context**
Encountered in this video: https://www.twitch.tv/videos/659297903
|
https://github.com/OpenRefine/OpenRefine/issues/2800
|
https://github.com/OpenRefine/OpenRefine/pull/2806
|
3aa610d6aabc15bc8dae62df2cb1d65641949286
|
4b146acc6ef8a4f41168824db0967e24d7efb45c
| 2020-06-24T07:13:10Z |
java
| 2020-06-25T06:36:57Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,797 |
["extensions/gdata/src/com/google/refine/extension/gdata/UploadCommand.java"]
|
Google Drive project export declares wrong data type
|
The Export Project to Google Drive command creates a gzip compressed tar archive, but then uploads it to Google Drive without an extension and with a MIME type of `application/zip` which causes Google Drive to give it a `zip` extension on download.
https://github.com/OpenRefine/OpenRefine/blob/d97d6c66b8f209de3fe686bd6c9145ef21570db6/extensions/gdata/src/com/google/refine/extension/gdata/UploadCommand.java#L162
https://github.com/OpenRefine/OpenRefine/blob/d97d6c66b8f209de3fe686bd6c9145ef21570db6/extensions/gdata/src/com/google/refine/extension/gdata/UploadCommand.java#L173
### To Reproduce
Steps to reproduce the behavior:
1. Export a project to Google Drive
2. Go to Google Drive and download the resulting file
3. Attempt to unzip the resulting file
4. See error
```
Archive: /Users/tfmorris/Downloads/Google Scholar highly cited researchers.zip
End-of-central-directory signature not found. Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive. In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
```
### Expected behavior
File is uploaded with the correct type.
|
https://github.com/OpenRefine/OpenRefine/issues/2797
|
https://github.com/OpenRefine/OpenRefine/pull/2829
|
139019f6e3623a5337eb81f887ff8c2922f715a1
|
de2c2aa7788d19f53a645ebc28f27e5c691ff7fe
| 2020-06-23T20:24:41Z |
java
| 2020-07-03T12:24:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,780 |
["pom.xml"]
|
Eclipse run/debug launches fail with undefined parameter
|
Attempting to use any of the launch configurations (Run, Debug, Test) in Eclipse results in an immediate error dialog saying that the `surefireArgs` parameter isn't defined.
|
https://github.com/OpenRefine/OpenRefine/issues/2780
|
https://github.com/OpenRefine/OpenRefine/pull/2781
|
17df444630ce3ce6d8e4bcf8cad13ae3321f0c6b
|
5063466f1693f1eb88c9c39606779ec3d62bc1b9
| 2020-06-21T23:25:53Z |
java
| 2020-06-22T15:24:01Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,777 |
["main/pom.xml"]
|
Test dependencies' jars are copied into the packaged release
|
**Describe the bug**
Our Maven configuration currently copies all dependencies from the local Maven repository into the application, which is required for a self-contained package. But the test dependencies should not be copied there as they are not required to run the application.
**To Reproduce**
Currently, in the `3.4-beta` packaged versions, you will find jars of mockito, for instance - that should not be there and is wasting bandwidth.
|
https://github.com/OpenRefine/OpenRefine/issues/2777
|
https://github.com/OpenRefine/OpenRefine/pull/2778
|
5d6d0ad6ba501e01542985e13ff2aa3e7ab4efae
|
2977ffa16751f546fbcf8a3273267052840707f2
| 2020-06-21T13:27:49Z |
java
| 2020-06-21T19:09:28Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,776 |
["main/webapp/modules/core/scripts/index/default-importing-controller/parsing-panel.js"]
|
Clipboard imports now get named as "(clipboard)" instead of "clipboard"
|
**Describe the bug**
One side effect of #2720 is that clipboard imports now get named "(clipboard)" by default instead of "clipboard". Was this intended?
Since this is not something I was expecting I would propose to only include this in 3.5, not 3.4, since there is a risk that there are other unforeseen consequences. Not that I think this particular change is necessarily bad (we might actually want to keep the brackets), just that this is not something I was expecting.
**To Reproduce**
Steps to reproduce the behavior:
1. Type in anything in the clipboard import area
2. Validate
3. See the default project name in the top right text input
**Current Results**
The project name is "(clipboard)" by default.
**Expected behavior**
So far "clipboard" was the default.
**Additional context**
This new name seems to be generated in the backend, so I was about to propose to localize it but unless we manage to generate it in the frontend instead, it might not be doable at the moment.
|
https://github.com/OpenRefine/OpenRefine/issues/2776
|
https://github.com/OpenRefine/OpenRefine/pull/2814
|
c68047a61423561d4b5d5d2bc47b63364b4718ae
|
139019f6e3623a5337eb81f887ff8c2922f715a1
| 2020-06-21T13:12:45Z |
java
| 2020-07-03T12:22:44Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,771 |
["main/webapp/modules/core/scripts/project.js"]
|
Simple preference to control the facet width
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
I want to be able to change the width of the facet panel (left one).
~~`ui.toolPanelWidth=300`~~ or ~~`ui.toolPanelWidth=500`~~, at the user’s will.
**Changed to `ui.facetsHistoryPanelWidth`**.
**Describe the solution you'd like**
A simple preference that controls the width of the panel.
**Describe alternatives you've considered**
Go into the console and play with JS.
**Screens shapshots**
Regards,
Antoine
|
https://github.com/OpenRefine/OpenRefine/issues/2771
|
https://github.com/OpenRefine/OpenRefine/pull/2772
|
6e472376aa7b19dd52cedda298bb38b42780d63f
|
fd3bfbea75150df8b44adf8ce73c8bbbc227689a
| 2020-06-20T18:29:54Z |
java
| 2021-04-16T16:06:04Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,770 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/index/default-importing-controller/controller.js", "main/webapp/modules/core/scripts/index/parser-interfaces/json-parser-ui.js"]
|
Improve error handling for JSON Import during Create Project
|
Attempting to import invalid JSON leaves the UI in an inconsistent state.
### To Reproduce
Steps to reproduce the behavior:
1. Import this data from the clipboard:
```
[
{"foo":NaN},
{"bar":Infinity}
]
```
2. Select "JSON Files" for "Parse data as..."
1. Note that the preview doesn't show any data except for the JSON delimiters
1. Click on `{}` and note the error "Non-standard token 'NaN': enable JsonParser.Feature.ALLOW_NON_NUMERIC_NUMBERS to allow"
1. Dismiss the error alert dialog
1. Note that the screen continues to show spinner with "Updating preview..."
### Expected behavior
* The "Updating Preview..." spinner should be dismissed on error (or when the error dialog is dismissed)
* The parse error should be shown immediately without the user having to select a record
### Versions
- Browser Version: Chrome 83
- OpenRefine 3.4-SNAPSHOT (HEAD of current master)
|
https://github.com/OpenRefine/OpenRefine/issues/2770
|
https://github.com/OpenRefine/OpenRefine/pull/4755
|
26f41c336fefd4f3a586e063ff3ce666c498e598
|
a1531318bc22a133b99439f19ed099fb3bc003e2
| 2020-06-20T18:21:17Z |
java
| 2022-05-23T17:33:04Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,768 |
["main/webapp/modules/core/scripts/preferences.js"]
|
Editing a preferences shows the value at loading time, not the current pref's value
|
**Describe the bug**
When you edit a pref, the value shown in the prompt will always be the value at the page loaded time, and not the current value.
**To Reproduce**
Steps to reproduce the behavior:
1. Go to the Preference window
2. Create a pref, let's say « TestPref », and assign it `100`.
3. Reload the page, you can see your new pref with the good value
4. Edit the value of the « TestPref » to `TEXT`
5. Go to edit AGAIN the value of the « TestPref » and see the value `100` proposed, instead of `TEXT`, the current value of this preference.
**Screenshots**
Step 4.
Step 5.
**Desktop<!-- (please complete the following information)-->:**
- OS: Mac OS X.14
- Browser Version: Chrome (current)
**OpenRefine <!--(please complete the following information)-->:**
- Version v3.3. to v3.5
|
https://github.com/OpenRefine/OpenRefine/issues/2768
|
https://github.com/OpenRefine/OpenRefine/pull/2769
|
a2ed9d586aaaf3f349cd5a7fa409aaa40cd496fe
|
8b978d1336e09064d08f200505184cc42a832ab7
| 2020-06-20T18:16:20Z |
java
| 2021-01-27T08:07:03Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,765 |
["pom.xml"]
|
Editing preferences in another language doesn't show i18n strings
|
**Describe the bug**
If I go to the « Préférences » window, with the French language selected, I get the raw i18n codes.
**To Reproduce**
Steps to reproduce the behavior:
1. Set OR’s language to something else than English
2. Go into the « Preferences » window.
3. See error of bad texts.
**Current Results**
We see the i18n codes strings.
**Expected behavior**
Seeing the text in the localized language.
**Screenshots**
**Desktop<!-- (please complete the following information)-->:**
- Mac X.14, Chrome
**OpenRefine <!--(please complete the following information)-->:**
- Version v3.3, v3.4b1, v3.5-SNAPSHOT
|
https://github.com/OpenRefine/OpenRefine/issues/2765
|
https://github.com/OpenRefine/OpenRefine/pull/5363
|
a247881135741be7bd5afadba5298f349737c1f1
|
8b06512b0e7bdbe3c30cd53504149cbf060b8218
| 2020-06-20T17:29:50Z |
java
| 2022-10-22T02:40:00Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,753 |
["benchmark/pom.xml", "pom.xml"]
|
"Import Project" screen misstatement
|
**Describe the bug**
The "Import Project" screen incorrectly states that OpenRefine project exports can be accepted in .zip and .tar, as per https://groups.google.com/forum/#!topic/openrefine-dev/g5UUWpAQMYM
**Expected behavior**
Should say "Locate an existing Refine project file (.tar.gz):"
**Screenshot**
Thanks!
|
https://github.com/OpenRefine/OpenRefine/issues/2753
|
https://github.com/OpenRefine/OpenRefine/pull/4866
|
7241fe19abfb159ab147b904ead4a35219d4d7da
|
0d7e9c9b2e3acb99cbe486b699f34abfcad4b432
| 2020-06-18T19:54:03Z |
java
| 2022-05-18T20:14:11Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,750 |
["benchmark/pom.xml", "pom.xml"]
|
Fix LGTM integration to not run packaging
|
It looks like LGTM is running the full Maven build including packaging, which causes the build failure in the PR checks - it would be worth configuring LGTM more like Travis, or perhaps tweaking our POMs to avoid that?
_Originally posted by @wetneb in https://github.com/OpenRefine/OpenRefine/pull/2748#issuecomment-645574252_
|
https://github.com/OpenRefine/OpenRefine/issues/2750
|
https://github.com/OpenRefine/OpenRefine/pull/4866
|
7241fe19abfb159ab147b904ead4a35219d4d7da
|
0d7e9c9b2e3acb99cbe486b699f34abfcad4b432
| 2020-06-17T19:55:52Z |
java
| 2022-05-18T20:14:11Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,724 |
["main/src/com/google/refine/importers/WikitextImporter.java", "main/webapp/modules/core/scripts/reconciliation/recon-manager.js"]
|
Update Wikidata reconciliation endpoint
|
**Describe the bug**
The current URL of the reconciliation endpoint `https://tools.wmflabs.org/openrefine-wikidata/en/api` (in English) will soon stop working (see #2667 for background).
**Additional context**
https://phabricator.wikimedia.org/T254169
|
https://github.com/OpenRefine/OpenRefine/issues/2724
|
https://github.com/OpenRefine/OpenRefine/pull/2725
|
b593306d1c62851d9e89d5ecb906c1c9e02a565e
|
348d82d13191514da07309d5bd899ba60b7e4b63
| 2020-06-14T22:31:41Z |
java
| 2020-06-15T21:20:05Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,700 |
["main/webapp/modules/core/MOD-INF/controller.js", "main/webapp/modules/core/langs/translation-fr.json"]
|
Plurals don't work for i18n package
|
**Describe the bug**
The i18n package is missing the CLD rule parser, so plurals don't work for many languages.
**To Reproduce**
Per https://github.com/OpenRefine/OpenRefine/issues/1858#issuecomment-637274292
```
$.i18n().locale = 'en';
$.i18n("$1 de $2 {{plural:$2|page|pages}}", 5, 10);
$.i18n().locale = 'fr';
$.i18n("$1 de $2 {{plural:$2|page|pages}}", 5, 10);
```
The last line gives this:
```
project-bundle.js:28751 Uncaught ReferenceError: pluralRuleParser is not defined
at Object.getPluralForm (project-bundle.js:28751)
at Object.convertPlural (project-bundle.js:28751)
at Object.plural (project-bundle.js:28744)
at Object.emit (project-bundle.js:28744)
at project-bundle.js:28744
at Function.map (project-bundle.js:504)
at Object.emit (project-bundle.js:28744)
at Object.parse (project-bundle.js:28739)
at a.parse (project-bundle.js:28723)
at Function.e.i18n (project-bundle.js:28723)
```
**Proposed solution**
Include https://github.com/santhoshtr/CLDRPluralRuleParser/blob/8baf9aedc428924fe6ee508b3d952cb5564efb3a/src/CLDRPluralRuleParser.js
(and perhaps https://github.com/santhoshtr/CLDRPluralRuleParser/blob/8baf9aedc428924fe6ee508b3d952cb5564efb3a/data/plurals.json)
(check for the appropriate version to match the version of Wikimedia i18n that we're using)
**OpenRefine:**
- Version 3.4 beta - current master
|
https://github.com/OpenRefine/OpenRefine/issues/2700
|
https://github.com/OpenRefine/OpenRefine/pull/2774
|
0cf788039156506b43584cdc69b0a7a59658a4e1
|
5d6d0ad6ba501e01542985e13ff2aa3e7ab4efae
| 2020-06-11T19:20:46Z |
java
| 2020-06-21T13:57:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,690 |
["extensions/database/pom.xml"]
|
Refactor - replace Apache Ant tools for tar & bzip2 with CommonsCompress
|
As discussed in https://github.com/OpenRefine/OpenRefine/pull/2645#issuecomment-635622749, we currently bundle the Apache Ant tools because that was, bizarrely, the historical location that the tar archive utilities and bzip2 compressor were bundled. Now that they have a proper home in Apache Commons Compress, using the same implementations, we should migrate to those.
This should save us some size in our release distributions as well as being less confusing. It is also where all new updates will occur and easily gives us access to other compressors like 7zip.
|
https://github.com/OpenRefine/OpenRefine/issues/2690
|
https://github.com/OpenRefine/OpenRefine/pull/6223
|
0e7bf3c5081f7cf5c73899ea8e4bc8dc07678365
|
e0a980785d2a4cbe4908bfa066f8c96e4778150a
| 2020-06-11T01:56:57Z |
java
| 2023-12-06T21:27:37Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,688 |
["extensions/gdata/src/com/google/refine/extension/gdata/UploadCommand.java", "extensions/gdata/src/com/google/refine/extension/gdata/logo-openrefine-550.png", "extensions/gdata/tests/src/com/google/refine/extension/gdata/UploadCommandTest.java"]
|
Icon being downloaded from Github for every Google Drive upload
|
**Describe the bug**
As stated in subject. Not sure how this made it through code review.
https://github.com/OpenRefine/OpenRefine/blob/11fbd01a1bd66dbf6858114a43d49b8edee465ff/extensions/gdata/src/com/google/refine/extension/gdata/UploadCommand.java#L174
https://github.com/OpenRefine/OpenRefine/blob/11fbd01a1bd66dbf6858114a43d49b8edee465ff/extensions/gdata/src/com/google/refine/extension/gdata/UploadCommand.java#L72
**Expected behavior**
Icon should be included in distribution and uploaded directly without being downloaded first
**OpenRefine <!--(please complete the following information)-->:**
- Version 3.4 current master
|
https://github.com/OpenRefine/OpenRefine/issues/2688
|
https://github.com/OpenRefine/OpenRefine/pull/2689
|
7b41bbe0b0d319c8177b818389178f29570968eb
|
3a7812aef7c15a4b670f7376fbe9f948413e8c92
| 2020-06-10T19:42:19Z |
java
| 2020-06-14T07:46:38Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,687 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/index/default-importing-controller/controller.js", "main/webapp/modules/core/scripts/index/default-importing-sources/sources.js"]
|
Creating a project from a URL - only first URL is validated
|
The second and subsequent URLs are not validated before they're used to attempt to create a project (as discussed in #2534)
**Steps to reproduce the behavior:**
1. Go to 'Create Project' -> 'Web Addresses (URL)'
2. Paste a valid URL (e.g. "http://api.worldbank.org/countries/all/indicators/SP.POP.TOTL?date=2000:2001")
3. Click "Add another URL" and enter "badurl" (or any other invalid URL)
4. Click Next
5. See error modal dialog
**Expected behavior**
The value of all URL input fields should be validated to ensure that they are well-formed URLs.
**OpenRefine (please complete the following information):**
- master branch (3.4 snapshot)
|
https://github.com/OpenRefine/OpenRefine/issues/2687
|
https://github.com/OpenRefine/OpenRefine/pull/4605
|
864ac30b86a4051b994f9ba6e5fc1a8598f88963
|
9d900105ceebe947578367e463a2e0faedee448c
| 2020-06-10T12:22:03Z |
java
| 2022-03-14T06:42:06Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,681 |
["pom.xml"]
|
Register OpenRefine in Windows application registry to avoid cleanup of app data
|
**Describe the bug**
There are reports that recent versions of CCleaner could potentially erase workspace files of OpenRefine on Windows:
https://groups.google.com/forum/#!topic/openrefine/pE9kXmiNRqU
**To Reproduce**
Not sure if this is reproducible, someone with a Windows machine should investigate.
**Current Results**
All projects are deleted.
**Expected behavior**
CCleaner should detect the application data for OpenRefine should not be deleted by default. Perhaps this data is deleted because OpenRefine is not formally installed in the application registry, so we might want to ship proper Windows installers (such as with InnoSetup) which do this.
**Desktop<!-- (please complete the following information)-->:**
- OS: Windows
**OpenRefine <!--(please complete the following information)-->:**
- All versions are probably affected.
|
https://github.com/OpenRefine/OpenRefine/issues/2681
|
https://github.com/OpenRefine/OpenRefine/pull/5185
|
cc6f2b991d54cff68ebafea88c00055c9b11bb0f
|
fbf02cd11bc2c8f749cc46833fb00180df9ab540
| 2020-06-06T07:06:06Z |
java
| 2022-08-15T18:47:18Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,680 |
["main/pom.xml", "main/src/com/google/refine/importing/ImportingUtilities.java", "main/src/com/google/refine/operations/column/ColumnAdditionByFetchingURLsOperation.java", "main/tests/server/src/com/google/refine/operations/column/ColumnAdditionByFetchingURLsOperationTests.java"]
|
Network tests being silently skipped
|
One of the HTTP tests relies on the external endpoint `http://headers.jsontest.com` but if this service is overquota and returning 503s (like it is today), the related tests are silently skipped.
https://github.com/OpenRefine/OpenRefine/blob/5351e9f41c9188006f156c27eadbd6a838cb152d/main/tests/server/src/com/google/refine/operations/column/ColumnAdditionByFetchingURLsOperationTests.java#L285-L298
We should figure out a better way to do this, which doesn't rely on an unreliable external service. One possibility would be to self-host the servlet https://github.com/jsontest/jsontest
|
https://github.com/OpenRefine/OpenRefine/issues/2680
|
https://github.com/OpenRefine/OpenRefine/pull/2692
|
983c8bd42278c2a8549969e864ee4db1ca737f73
|
749704518c330c6f96ec3e784c45b8c055d5c6cd
| 2020-06-05T20:38:55Z |
java
| 2020-06-16T07:38:06Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,678 |
["main/webapp/modules/core/error.vt"]
|
error.vt in the main module should use absolute path for loading resources
|
[error.vt](https://github.com/OpenRefine/OpenRefine/blob/master/main/webapp/modules/core/error.vt) uses relative paths to load resources. This template is used in [Command#respondWithErrorPage](https://github.com/OpenRefine/OpenRefine/blob/master/main/src/com/google/refine/commands/Command.java#L379). So if a Command instance is visited and call this method to return the error page, the resources included in the page won't be loaded correctly.
To reproduce:
1. Create TestCommand in the main module (others are the same), the command does nothing but calls respondWithErrorPage directly.
2. Register the command in controller.js.
3. Visit /command/core/test
4. See that the error page isn't displayed correctly.
After changing to use absolute paths in error.vt, the error page then looks fine:
|
https://github.com/OpenRefine/OpenRefine/issues/2678
|
https://github.com/OpenRefine/OpenRefine/pull/2679
|
4a1c1e34ef3db0f5427bee9d84ceb6445a863a1c
|
1c4243ea57d4da14328a5d0a092793b2641e2328
| 2020-06-05T07:42:20Z |
java
| 2020-06-06T10:25:52Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,675 |
["main/webapp/modules/core/scripts/dialogs/clustering-dialog.js"]
|
facetContainer in Cluster dialog shows interactive when compute-clusters is running
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
Clustering dialog shows facets in `facetContainer` to still be interactive even while `compute-clusters` is running in background.
**Describe the solution you'd like**
Grey out the `facetContainer` to make it non-interactive **until** the `/command/core/compute-clusters` operation is finished and the `<div class="clustering-dialog-table-container" bind=tableContainer">` is populated with Cluster entries.
**Describe alternatives you've considered**
Do not show `facetContainer` at all (instead of grey out non-interactive) and make it completely hidden until `compute-clusters` is finished.
**Screenshot**
The false impression that users get that they can still manipulate the facet sliders in 2. `facetContainer` while 1. `compute-clusters` is running.
|
https://github.com/OpenRefine/OpenRefine/issues/2675
|
https://github.com/OpenRefine/OpenRefine/pull/2709
|
a7e84e8a56ac585d5ffc7735200dc1ac44fe6e22
|
13249ea25276b8dce4cddfbee44100c62a0dbad1
| 2020-06-03T14:53:38Z |
java
| 2020-06-12T18:56:40Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,669 |
["pom.xml"]
|
Add tag "openrefine-3.5" to Wikidata
|
The lastest master branch version has been updated to 3.5, but the tag "openrefine-3.5" hasn't been added to Wikidata yet (see https://www.wikidata.org/wiki/Special:Tags), so developers will get the following error when uploading edits to Wikidata via the Wikidata extension:
> ...
> 21:44:36.248 [ refine] POST /command/wikidata/perform-wikibase-edits (10ms)>
> 21:44:36.270 [..mWikibaseEditsOperation] Performing edits (22ms)
> 21:44:36.272 [..ting.EditBatchProcessor] Requesting documents (2ms)
> 21:44:38.524 [..ting.EditBatchProcessor] MediaWiki error while editing [badtags]: The tag "openrefine-3.5" is not allowed to be manually applied. (2252ms)
> ...
|
https://github.com/OpenRefine/OpenRefine/issues/2669
|
https://github.com/OpenRefine/OpenRefine/pull/5185
|
cc6f2b991d54cff68ebafea88c00055c9b11bb0f
|
fbf02cd11bc2c8f749cc46833fb00180df9ab540
| 2020-06-02T13:50:25Z |
java
| 2022-08-15T18:47:18Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,659 |
["pom.xml"]
|
Wikidata entity type constraint does not mention the property involved
|
**Describe the bug**
|
https://github.com/OpenRefine/OpenRefine/issues/2659
|
https://github.com/OpenRefine/OpenRefine/pull/4914
|
3858c56318c58c18310d3995a1bcc1771c4896f8
|
8005c45db0c1441339c8603ec68bef4ea52e1abd
| 2020-05-31T13:26:47Z |
java
| 2022-06-02T19:35:32Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,642 |
["pom.xml"]
|
Update Jython to latest 2.7.2
|
Update in our code here: https://github.com/OpenRefine/OpenRefine/blob/3ca08f6ff189cc1bd806a1d49d2ead538882c0e2/extensions/jython/pom.xml#L124
New features and bugs fixed in Jython 2.7.2 since 2.7.1 are here:
https://github.com/jythontools/jython/blob/v2.7.2/NEWS
|
https://github.com/OpenRefine/OpenRefine/issues/2642
|
https://github.com/OpenRefine/OpenRefine/pull/4904
|
cfb222608281f87690aeb0f64052ca784ba5380e
|
058cee15fe7b12a544fd3c5d69ddca23b4e2c46a
| 2020-05-27T17:03:01Z |
java
| 2022-05-30T20:06:45Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,640 |
["server/src/com/google/refine/Refine.java"]
|
Improve browser launch in Linux distribution
|
**Describe the bug**
It would be worth making sure we are using the most appropriate API call to launch the browser on Linux. In some circumstances, this can happen:
```
You have 15876M of free memory.
Your current configuration is set to use 1400M of memory.
OpenRefine can run better when given more memory. Read our FAQ on how to allocate more memory here:
https://github.com/OpenRefine/OpenRefine/wiki/FAQ:-Allocate-More-Memory
Starting OpenRefine at 'http://127.0.0.1:3333/'
15:02:40.754 [ refine_server] Starting Server bound to '127.0.0.1:3333' (0ms)
15:02:40.755 [ refine_server] refine.memory size: 1400M JVM Max heap: 1407188992 (1ms)
15:02:40.763 [ refine_server] Initializing context: '/' from '/home/projadmin/dj/openrefine-3.3/webapp' (8ms)
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/projadmin/dj/openrefine-3.3/server/target/lib/slf4j-log4j12-1.7.18.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/projadmin/dj/openrefine-3.3/webapp/WEB-INF/lib/slf4j-log4j12-1.7.18.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
15:02:41.204 [ refine] Starting OpenRefine 3.3 [58b839b]... (441ms)
15:02:41.204 [ refine] initializing FileProjectManager with dir (0ms)
15:02:41.204 [ refine] /home/projadmin/.local/share/openrefine (0ms)
15:02:44.359 [ refine] Sorry, some error prevented us from launching the browser for you.
```
It would be worth checking that we are using the best approach to open `http://localhost:3333/` - the API to do this might have evolved. We could try different APIs in turn, too (making sure that we do not launch it twice).
**Desktop (please complete the following information):**
- OS: Linux
**OpenRefine (please complete the following information):**
- Version 3.3
**Additional information**
Mailing list thread: https://groups.google.com/forum/#!topic/openrefine/oo4W-zlSqc8
|
https://github.com/OpenRefine/OpenRefine/issues/2640
|
https://github.com/OpenRefine/OpenRefine/pull/4706
|
0573be98f488121ea80e79e3cc548ac69bca5b0f
|
d6a3e8465bc05bf90a45f3144c2c53f841bf0845
| 2020-05-25T11:31:42Z |
java
| 2022-04-15T20:01:01Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,638 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/langs/translation-es.json", "main/webapp/modules/core/langs/translation-fr.json", "main/webapp/modules/core/scripts/views/data-table/data-table-view.js", "main/webapp/modules/core/styles/views/data-table-view.less"]
|
Feature to Goto a page directly
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
We can go to the first, the last, a next or previous page, but we can't jump to any page.
A simple link, with a prompt, telling you your current page, the max # of pages, and asking to what page you want to go would be a nice feature.
**Describe the solution you'd like**
**Describe alternatives you've considered**
Clicking many times the next button. I works.
|
https://github.com/OpenRefine/OpenRefine/issues/2638
|
https://github.com/OpenRefine/OpenRefine/pull/2639
|
5d2c10b9d8e247f9a8d49be646fed487651b20c3
|
d7aaac2e9730a88b162cf151a50a62a08f870840
| 2020-05-24T04:08:54Z |
java
| 2020-06-17T09:31:56Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,637 |
["extensions/database/tests/conf/test-pgsql.sql"]
|
Fix a test with SQL engine and Travis & Appveyor for the Database Import
|
**Describe the bug**
It would be really nice to have both Travis and Appveyor, actually test create the sqlite and test... as well as fix the `travis-pgsql.sql` failure on Appveyor.
This looks like a syntax error, we probably don't need that USE line any longer in `extensions\database\tests\conf\travis-mysql.sql` ?
Since we already state on Travis config that we are going to use the test_db through the `before_install` Line 26 here: https://github.com/OpenRefine/OpenRefine/blob/master/.travis.yml#L26
Why is this comment still here? https://github.com/OpenRefine/OpenRefine/blob/master/extensions/database/tests/conf/travis_tests.xml#L32
Did something not get put back into place correctly? https://github.com/OpenRefine/OpenRefine/commit/a6424e53a092abd90a72a24d60cae5d8b20eca8f
Groups run nothing? Is that a problem? So let's ensure the integrity of our database extension with tests by Travis and Appveyor that are healthy again and working correctly fully.
**OpenRefine (please complete the following information):**
- Version 3.4
**Screenshots**
On GitHub. The PR when viewed will show near the bottom the checks passing/failing.
When you click on Details blue link it will take you to Appveyor or Travis and there you can see the logs from each respectively:
Our tests should actually use those various SQL engine instances that we have wired up to spin up in the CI (Continuous Integration) vendors like Appveyor and Travis. I am unsure if all the DB extension tests are using those instances...and if we are in fact still testing against those 3 DB instances we spin up on Travis and Appveyor. So double-check all of that. I want to make sure we didn't accidentally turn off testing for some, or skipping tests for some (we did skip some things in the past because of problems with Appveyor but should no longer be skipping tests AT ALL, so that we can ensure regression testing properly going forward with all these changes and expanding our contributor base such as with GSoC and yourself ;-) I.E. I don't want our quality to go down and for us to get lazy.
**Additional context**
Recommandations: Iterate on it until db tests are working well on Appveyor and Travis. Looks like mostly just some .yml file updates and .sql file updates in various places are all that's needed. You can see the previous pqsql and mysql as examples...oh wait, we have sqlite already by that fellow a few months ago...so just ensure Appveyor and Travis are indeed testing the DB extension against those 3, postgres, mysql, sqlite properly.
Our tests should actually use those various SQL engine instances that we have wired up to spin up in the CI (Continuous Integration) vendors like Appveyor and Travis. I am unsure if all the DB extension tests are using those instances...and if we are in fact still testing against those 3 DB instances we spin up on Travis and Appveyor. So double-check all of that. I want to make sure we didn't accidentally turn off testing for some, or skipping tests for some (we did skip some things in the past because of problems with Appveyor but should no longer be skipping tests AT ALL, so that we can ensure regression testing properly going forward with all these changes and expanding our contributor base such as with GSoC and yourself ;-) I.E. I don't want our quality to go down and for us to get lazy.
_This issue is mostly written from discussion in the previous issue: « Only show the database login fields when necessary #2615 »_
|
https://github.com/OpenRefine/OpenRefine/issues/2637
|
https://github.com/OpenRefine/OpenRefine/pull/6393
|
01be686e69506abc2974828be437e785ffbbf7c9
|
6ba044c4e39d49b0dd4221f4b9a9328e5c71117c
| 2020-05-23T05:32:48Z |
java
| 2024-02-24T19:44:31Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,627 |
["main/src/com/google/refine/io/FileProjectManager.java", "main/src/com/google/refine/io/ProjectMetadataUtilities.java", "main/src/com/google/refine/preference/PreferenceStore.java", "main/tests/server/src/com/google/refine/io/FileProjectManagerTests.java", "pom.xml"]
|
added Reconciliation Services disappear on restart
|
**Describe the bug**
All added Reconciliation Services other than the default "Wikidata (en)" disappear on restart.
The only hint I get in the console could be this line: [FileProjectManager] com.fasterxml.jackson.databind.JsonMappingException: Invalid UTF-8 middle byte 0x72
at [Source: (File); line: 1, column: 2280] (through reference chain: com.google.refine.io.FileProjectManager["preferences"]->com.google.refine.preference.PreferenceStore["entries"]) (368ms)
This only happens with OpenRefine 3.3 and 3.4 (Beta). I also tested 3.1 and 3.2 and encountered no problems there!
I tested it on two different Windows machines with the same bug persisting on both.
**To Reproduce**
Steps to reproduce the behavior:
Just add any reconciliation service, e.g. https://lobid.org/gnd/reconcile (GND service), shut down OpenRefine and restart
**Expected behavior**
all added Reconciliation Services should be preserved on restart
**Desktop (please complete the following information):**
- OS: Windows 10
- Browser Version: Chrome Version 81.0.4044.138 (64-Bit)
- JRE or JDK Version: java version "1.8.0_251"
**OpenRefine (please complete the following information):**
- Version 3.3
**Datasets**
all of my datasets are affected
|
https://github.com/OpenRefine/OpenRefine/issues/2627
|
https://github.com/OpenRefine/OpenRefine/pull/2657
|
5351e9f41c9188006f156c27eadbd6a838cb152d
|
e6ed8e5d62868c31ff83f7b11fc86721466d814f
| 2020-05-19T11:50:29Z |
java
| 2020-06-06T09:00:01Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,618 |
["pom.xml"]
|
Extending the "fluent interface" (or Dot Syntax) for controls
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
Currently, a function can be called by its normal syntax, like `datePart(now(), "year")` but it can also be called by its _Dot Syntax_, that is: `now().datePart("year")`.
On the other hand, `if(vMaybeTrue, eTrue, eFalse)` cannot be called `vMaybeTrue.if(eTrue, eFalse)`, because controls do not have the _Dot Syntax_.
It would enable a writing that could provide sometimes better readability.
It will also ease the process of transforming a function into a control if needed for some reasons.
**Describe the solution you'd like**
I'd like to be able to write in GREL:
- `[0, 20, 2].forRange(vVar, eExpr)`
- `["string", "boolean", "number"].forEach(eExpr)`
- `vMaybeTrue.if(eTrue, eFalse)`
- `["a", 1, errorObject].filter(vVar, eExpr)`
- etc.
**Describe alternatives you've considered**
Not using the Dot Syntax.
|
https://github.com/OpenRefine/OpenRefine/issues/2618
|
https://github.com/OpenRefine/OpenRefine/pull/4782
|
aefd252eeab1088cfa439b906acae1f0a61a6a14
|
b013adff314ef06ca9908c25a1f1be4d2d40a42a
| 2020-05-13T18:49:58Z |
java
| 2022-04-20T18:19:05Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,606 |
["docs/docs/manual/grelfunctions.md", "main/src/com/google/refine/expr/functions/strings/ReplaceEach.java", "main/src/com/google/refine/grel/ControlFunctionRegistry.java", "main/tests/server/src/com/google/refine/expr/functions/strings/ReplaceEachTest.java"]
|
Add 2 new GREL functions for replacing strings matching a search list
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
Currently we do not have a nice single replace() function that takes a List of Strings as an argument to search for in a String and replace any found match with a replacement character.
We have to resort to use of cross() or forEach() with inArray() to perform the lookup/inspection of a List or Array and then perform our String replacement.
Mailing list thread comment:
https://groups.google.com/d/msg/openrefine/XIfKTL6sv0w/BjUedqn0AgAJ
GIVEN: 2 columns where column A has the string we want to replace when a list of substrings are found.
AND: column B has a list (or can be split into an Array) of those substrings to search for
AND: and when matching,
THEN: replace ANY matching substring in our column A with a single replacement value like "" empty string or whatever the user desires.
The following GREL performs this:
```
forEach(
forEach(
value.split(","),
i,
i.trim()
),
i,
if(
inArray(cells.B.value.split("|"),i),
"",
i
)
)
.join(",")
```
however, it is very verbose.
**Describe the solution you'd like**
Instead we can probably simplify this large expression to something like this that takes as an argument (a list of strings to search for) and those that match get replaced with a replacement char.
```
value.trim().replaceEach(cells.B.value.split("|"), "")
```
**Describe alternatives you've considered**
headaches and more coffee and continue with GREL snakes.
**Additional context**
Apache StringUtils seems to have already 2 nice functions to help `replaceEach()` and `replaceEachRepeatedly()` :
http://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html#replaceEach-java.lang.String-java.lang.String:A-java.lang.String:A-
... as well as many "index" methods.
Example Problem OpenRefine Project with provided "GREL snake" current solution:
[vidal_santos.openrefine.tar.gz](https://github.com/OpenRefine/OpenRefine/files/4560531/vidal_santos.openrefine.tar.gz)
|
https://github.com/OpenRefine/OpenRefine/issues/2606
|
https://github.com/OpenRefine/OpenRefine/pull/4752
|
bef71b9739256b668e0263da6ff3180db9d97bc1
|
3858c56318c58c18310d3995a1bcc1771c4896f8
| 2020-04-30T19:34:46Z |
java
| 2022-06-02T19:29:37Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,595 |
["extensions/database/pom.xml"]
|
XlsExporter mime types for excel are not standard
|
**Describe the bug**
XlsExporter.java has https://github.com/OpenRefine/OpenRefine/blob/master/main/src/com/google/refine/exporters/XlsExporter.java#L68
https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types
* .xls application/vnd.ms-excel
* .xlsx application/vnd.openxmlformats-officedocument.spreadsheetml.sheet
I can provide a PR if this issue is deemed worth fixing.
**OpenRefine (please complete the following information):**
- Version - latest master branch
|
https://github.com/OpenRefine/OpenRefine/issues/2595
|
https://github.com/OpenRefine/OpenRefine/pull/5196
|
b3271ddfef11509eb5f7a5d8c943573a1b0563c1
|
67304e1dd249028e750e57f2a55f018db001b19b
| 2020-04-26T08:26:03Z |
java
| 2022-08-18T19:42:47Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,590 |
["main/src/com/google/refine/model/recon/StandardReconConfig.java", "main/src/com/google/refine/operations/recon/ReconOperation.java", "main/tests/server/src/com/google/refine/model/recon/StandardReconConfigTests.java"]
|
Wikidata reconciliation dies with java.lang.IllegalArgumentException: Strings must not be null
|
**Describe the bug**
Reconciling a list of 250 author names against Wikidata type Q5 (human) stayed at 0% complete with the spinner going forever.
Looking at the console showed a traceback from an unhandled exception:
```
Exception in thread "Thread-9" java.lang.IllegalArgumentException: Strings must not be null
at org.apache.commons.lang.StringUtils.getLevenshteinDistance(StringUtils.java:6164)
at com.google.refine.model.recon.StandardReconConfig.computeFeatures(StandardReconConfig.java:577)
at com.google.refine.model.recon.StandardReconConfig.createReconServiceResults(StandardReconConfig.java:560)
at com.google.refine.model.recon.StandardReconConfig.batchRecon(StandardReconConfig.java:489)
at com.google.refine.operations.recon.ReconOperation$ReconProcess.run(ReconOperation.java:282)
at java.lang.Thread.run(Thread.java:748)
```
**Expected behavior**
At a minimum, errors in the reconciliation process shouldn't kill the whole process and hang the UI. It looks like any exceptions other than IOErrors will currently kill the reconciliation process (as noted in #1128).
This specific bug should be fixed as well. It looks like the reconciliation service is returning a Null as a candidate since that's the only way I can see to trigger the error in this code:
https://github.com/OpenRefine/OpenRefine/blob/8414a82df8dac9941ff918f217649020e99487f5/main/src/com/google/refine/model/recon/StandardReconConfig.java#L569-L575
**Desktop :**
- OS: Mac OS X Mojave 10.14
- JRE or JDK Version: SE JRE build 1.8.0_171-b11 64-Bit Server VM (build 25.171-b11, mixed mode)
**OpenRefine (please complete the following information):**
- Version - master at HEAD bf7b27fcddb1d4c8408e0939b52f5d37a6793895
|
https://github.com/OpenRefine/OpenRefine/issues/2590
|
https://github.com/OpenRefine/OpenRefine/pull/2671
|
6e66cb5144e1a621cfe1843a86b06f6bad9dcedd
|
1849e6223459844aab7c7b895999c2c195b0fa0a
| 2020-04-24T17:03:59Z |
java
| 2020-06-23T19:54:54Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,588 |
["extensions/database/pom.xml"]
|
Imprecise facet statistics in records mode
|
**Describe the bug**
The blank values in a column are counted incorrectly in records mode.
**To Reproduce**
Import the following CSV dataset:
```
a,b,c
1,2,3
,,4
,,5
,6,7
3,4,8
,2,9
```
Create a text facet on the second column, **in records mode**.
Observe that it counts a single blank value, whereas there are two of them.
**Current Results**
The count for `(blank)` is 1.
**Expected behavior**
The count for `(blank)` should be 2.
**OpenRefine (please complete the following information):**
- master branch (but applicable to all versions since at least 2.6 probably)
|
https://github.com/OpenRefine/OpenRefine/issues/2588
|
https://github.com/OpenRefine/OpenRefine/pull/5196
|
b3271ddfef11509eb5f7a5d8c943573a1b0563c1
|
67304e1dd249028e750e57f2a55f018db001b19b
| 2020-04-24T16:29:26Z |
java
| 2022-08-18T19:42:47Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,584 |
["main/src/com/google/refine/importers/TabularImportingParserBase.java", "main/tests/server/src/com/google/refine/importers/TsvCsvImporterTests.java"]
|
CSV importer with auto-detect datatype feature fails to parse table
|
**Describe the bug**
Import the following CSV table:
```
a,b
1,2
2018-09-01T01:02:03Z,f
true,23.2
```
and enable "Parse cell text into numbers, dates, …"
**Current Results**
```
java.lang.ClassCastException: class java.lang.Long cannot be cast to class java.lang.String (java.lang.Long and java.lang.String are in module java.base of loader 'bootstrap')
at com.google.refine.importers.TabularImportingParserBase.readTable(TabularImportingParserBase.java:173)
at com.google.refine.importers.SeparatorBasedImporter.parseOneFile(SeparatorBasedImporter.java:160)
at com.google.refine.importers.ImportingParserBase.parseOneFile(ImportingParserBase.java:128)
at com.google.refine.importers.ImportingParserBase.parse(ImportingParserBase.java:89)
at com.google.refine.importing.ImportingUtilities.previewParse(ImportingUtilities.java:961)
at com.google.refine.importing.DefaultImportingController.doUpdateFormatAndOptions(DefaultImportingController.java:175)
at com.google.refine.importing.DefaultImportingController.doPost(DefaultImportingController.java:94)
at com.google.refine.commands.importing.ImportingControllerCommand.doPost(ImportingControllerCommand.java:68)
at com.google.refine.RefineServlet.service(RefineServlet.java:187)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166)
at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:81)
at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:132)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:938)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:755)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
```
**Expected behavior**
No exception thrown, table parsed correctly.
**OpenRefine (please complete the following information):**
- master branch
|
https://github.com/OpenRefine/OpenRefine/issues/2584
|
https://github.com/OpenRefine/OpenRefine/pull/2610
|
15710ace177a23f51d045db54d8299e238bf7b63
|
825e687b0b676fd1be1fa0a9d00be22de0e57060
| 2020-04-24T07:26:55Z |
java
| 2020-05-05T12:00:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,578 |
["docs/siteConfig.js"]
|
Add Edit on GitHub link to documentation
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
On pages like https://docs.openrefine.org/operations/key_value_columnize.html, it would be good to have an edit link, pointing to:
https://github.com/OpenRefine/OpenRefine/edit/master/docs/src/operations/key_value_columnize.md
**Describe the solution you'd like**
Integrate it nicely in the design (there might be native things in Docusaurus for that).
|
https://github.com/OpenRefine/OpenRefine/issues/2578
|
https://github.com/OpenRefine/OpenRefine/pull/2579
|
e5e2c8f6652b651e6e6cfa79d7b2fb58694697fb
|
f11e31c34258c0b4f454cf14390749a753815a80
| 2020-04-21T19:43:33Z |
java
| 2020-04-21T21:13:43Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,565 |
["extensions/wikidata/module/scripts/dialogs/manage-account-dialog.html", "extensions/wikidata/module/scripts/dialogs/manage-account-dialog.js"]
|
Pressing enter in the Wikidata login form cancels the login
|
**Describe the bug**
When pressing Enter in the Wikidata login form, the dialog disappears without logging in.
**Expected behavior**
The login form should be submitted instead.
Also, the username field should be focused when the dialog is created.
**OpenRefine (please complete the following information):**
- master branch
|
https://github.com/OpenRefine/OpenRefine/issues/2565
|
https://github.com/OpenRefine/OpenRefine/pull/2566
|
1a0e1875613bc7449bce7f13a0ae15c4b62c28f7
|
6441a2a1f63e426547326e60d5aca9b94bd8a07f
| 2020-04-19T09:21:49Z |
java
| 2020-04-26T13:39:10Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,553 |
["extensions/database/pom.xml"]
|
Minimize and maximize a facet at will to manage facets footprints
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
I would like to be able to minimize a facet.
**Describe the solution you'd like**
A little button just beside the close button. It would change of visual when the facet is minimized or when it's fully displayed.
**Describe alternatives you've considered**
Deleting and recreating the facets not used.
**Additional context**
Here's two pictures and a full video demo (6 Mb .GIF file). Facets are minimized and maximized at will:
All minimized:
|
https://github.com/OpenRefine/OpenRefine/issues/2553
|
https://github.com/OpenRefine/OpenRefine/pull/5196
|
b3271ddfef11509eb5f7a5d8c943573a1b0563c1
|
67304e1dd249028e750e57f2a55f018db001b19b
| 2020-04-16T06:48:16Z |
java
| 2022-08-18T19:42:47Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,544 |
["main/src/com/google/refine/io/FileProjectManager.java", "main/src/com/google/refine/io/ProjectMetadataUtilities.java", "main/src/com/google/refine/preference/PreferenceStore.java", "main/tests/server/src/com/google/refine/io/FileProjectManagerTests.java", "pom.xml"]
|
Loss of Starring an Expression in History
|
What breaks:
* Star an expression in history
**Details:**
* OpenRefine win 3.3 release
* Windows 10
* JDK 8
* Firefox, Chrome, Edge
* The last part of `workspace.json` is formed as such:
```json
],
"ui.browsing.listFacet.limit": 22000,
"scripting.starred-expressions": null,
"userLang": "en",
"scripting.expressions": {
"top": 100,
"list": ["grel:value.startsWith(\"http\")", "grel:value.replace(\"/wiki/Property:\",\"/entity/\")", "grel:value.contains(\"Property\")"],
"class": "com.google.refine.preference.TopList"
},
"ui.show-control-characters": "true"
}
}
```
**Error:**
* Clicking on a Star next to a GREL in the Expression History **does not work** and throws an NPE here:
```
10:06:28.438 [ org.mortbay.log] /command/core/toggle-starred-expression (0ms)
java.lang.NullPointerException
at com.google.refine.commands.expr.ToggleStarredExpressionCommand.doPost(ToggleStarredExpressionCommand.java:53)
at com.google.refine.RefineServlet.service(RefineServlet.java:189)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166)
at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:81)
at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:132)
<snip>
```
**Additional context:**
Wondering if any leftover TODO's from this issue #2086 ?
|
https://github.com/OpenRefine/OpenRefine/issues/2544
|
https://github.com/OpenRefine/OpenRefine/pull/2657
|
5351e9f41c9188006f156c27eadbd6a838cb152d
|
e6ed8e5d62868c31ff83f7b11fc86721466d814f
| 2020-04-13T15:32:20Z |
java
| 2020-06-06T09:00:01Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,537 |
[".github/workflows/maven.yml"]
|
CI builds fail in forked repos
|
**Describe the bug**
In forked repos without the RELEASE_REPO_TOKEN secret defined, CI builds fail attempting to upload release artifacts.
**To Reproduce**
You can see a failed build here: https://github.com/tfmorris/OpenRefine/runs/579874494?check_suite_focus=true
**Current Results**
Fails with the error `##[error]request to https://api.github.comnull/ failed, reason: getaddrinfo ENOTFOUND api.github.comnull` during the Upload Release Asset Windows setp.
**Expected behavior**
It should gracefully skip the upload step and not fail the build.
p.s. As an aside, it appears that the "nightly" build is actually built and uploaded for every commit, which seems wasteful.
|
https://github.com/OpenRefine/OpenRefine/issues/2537
|
https://github.com/OpenRefine/OpenRefine/pull/2538
|
a27ed31d616442e86ef3d9e7a9ec8b90f2483f02
|
2a9ea896d425059ef08d7e212b5a7aa36f836c70
| 2020-04-12T01:05:13Z |
java
| 2020-04-12T19:22:32Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,527 |
["extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/module/scripts/menu-bar-extension.js"]
|
Missing "export" in menu item labels in Wikidata extension menu
|
**Describe the bug**
The overhaul of the export menu in #2458 has affected Wikidata extension menu as well: the last two items no longer have "export" or "upload" in their label, which is required there since this menu is not just about export.
**To Reproduce**
Steps to reproduce the behavior: go to the Wikidata extension menu
**Screenshots**
**OpenRefine (please complete the following information):**
- master branch (since #2458)
|
https://github.com/OpenRefine/OpenRefine/issues/2527
|
https://github.com/OpenRefine/OpenRefine/pull/2528
|
69db33de5a2e0f2a0eb63cb4595b7908a23924b0
|
7cb8bb360bf2024375d13f096071a57e7547e6d3
| 2020-04-08T07:50:54Z |
java
| 2020-04-14T07:57:52Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,526 |
["extensions/wikidata/pom.xml"]
|
Wikidata login fails since 2020-04-07 due to a server-side change in cookie handling
|
**Describe the bug**
<!-- A clear and concise description of what the bug is. -->
I am using OpenRefine 3.3 version but unfortunately facing problem with the upload edits to wikidata and also facing problem during log in.
**To Reproduce**
Steps to reproduce the behavior:
1. Go to edit wikidata schema
2. Click on upload edits to wikidata
3. Scroll down to '....'
4. Invalid credentials and facing problem with log in
**Current Results**
<!-- What results occured or were shown. -->
**Expected behavior**
<!-- A clear and concise description of what you expected to happen or to show. -->
**Screenshots**
<!-- If applicable, add screenshots to help explain your problem. -->
**Desktop (please complete the following information):**
- OS: [e.g. iOS, Windows 10, Linux, Ubuntu 18.04]
- Browser Version: [e.g. Chrome 19, Firefox 61, Safari, NOTE: OpenRefine does not support IE but works OK in most cases]
- JRE or JDK Version:[output of "java -version" e.g. JRE 1.8.0_181]
**OpenRefine (please complete the following information):**
- Version [e.g. OpenRefine 3.0 Beta]
**Datasets**
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
**Additional context**
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/2526
|
https://github.com/OpenRefine/OpenRefine/pull/2529
|
e26178e0b430c61914ed1fee83e7d6d6b2d422db
|
d7ee1f5b3db812b091b8cf227e9a4d39ac57b3b4
| 2020-04-08T02:14:18Z |
java
| 2020-04-08T15:23:03Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,519 |
["main/tests/cypress/cypress/integration/project/grid/misc/proper-display.js", "main/webapp/modules/core/scripts/views/data-table/cell-ui.js"]
|
Hyperlink is created for cell value even when invalid and text datatype is choosen
|
**Describe the bug**
Hyperlink is created for cell value, even when text is specified as the datatype.
**To Reproduce**
Steps to reproduce the behavior:
1. Edit a cell's value
2. Choose datatype: Text
3. Paste the following text exactly (includes whitespace):
```
https://www.wikidata.org/wiki/Property:P670 https://www.wikidata.org/wiki/Property:P669 are now mapped to https://schema.org/streetAddress via https://www.wikidata.org/wiki/Property:P2235
```
4. Click Apply
**Current Results**
Notice that cell value is shown completely as a clickable hyperlink rather than just text.
**Expected behavior**
The cell's value should be rendered with only those pieces which represent valid URLs hyperlinked. For the example above, there should be four hyperlinks with unlinked text " are now mapped to " and " via " between them.
Browsers now have native support for URL detection and we should take advantage of that. See comment https://github.com/OpenRefine/OpenRefine/issues/2519#issuecomment-612645821
**Screenshots**
**Desktop (please complete the following information):**
- OS: Windows 10
- Browser Version: Firefox
- JRE or JDK Version: JDK8
**OpenRefine (please complete the following information):**
- Version: Trunk (master)
**Additional Context**
The use case that I actually had here in #2519 was that of a cell of text that might contain multiple URLs would be convenient to be able to click on the URLs and it open a browser for quick verification during reconciling processes.
As long as scrolling the grid still works, editing the cells still works, running GREL operations on the cell text, and exporting the cells still works, then I think it satisfies most of the needs that will come up within GLAM reconciling processes with multiple URLs in a cell text for clicking and verifying.
|
https://github.com/OpenRefine/OpenRefine/issues/2519
|
https://github.com/OpenRefine/OpenRefine/pull/3597
|
4e219fd595b9ac0621cdb696c660a6a0a7476a42
|
7bccdd1bcffb7c3e1f8a95d28010ee5cc3ef6028
| 2020-04-06T15:44:15Z |
java
| 2021-02-11T18:54:36Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,516 |
["main/webapp/modules/core/scripts/index/default-importing-sources/sources.js"]
|
Creating a project from a URL: URLs with leading whitespace are rejected
|
**Describe the bug**
The input field to create a project from a URL does not trim its input when validating it.
<!-- A clear and concise description of what the bug is. -->
**To Reproduce**
Steps to reproduce the behavior:
1. Go to 'Create Project' -> 'Web Addresses (URL)'
2. Paste " http://api.worldbank.org/countries/all/indicators/SP.POP.TOTL?date=2000:2001" with the leading whitespace
3. Validate
4. The URL is rejected
**Expected behavior**
The value of this input should be trimmed before validation.
**OpenRefine (please complete the following information):**
- master branch (3.4 snapshot)
|
https://github.com/OpenRefine/OpenRefine/issues/2516
|
https://github.com/OpenRefine/OpenRefine/pull/2534
|
515d7019731ba721f96e4d086ab2441d6509f517
|
cccaf2992a82bc9a901af59c4ad29592429a9259
| 2020-04-04T08:12:07Z |
java
| 2020-06-10T12:28:30Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,510 |
["pom.xml"]
|
true.type() return « java.lang.Boolean » and not « boolean »
|
**Describe the bug**
Expression|Result|Expected result
-- | -- | --
true.type()|**"java.lang.Boolean"**|_"boolean"_
(1).type()|"number"|"number"
"A".type()|"string"|"string"
now().type()|"date"|"date"
[].type()|"array"|"array"
null.type()|"undefined"|~~"null"~~ "undefined"
**To Reproduce**
Steps to reproduce the behavior:
1. Go to 'Edit cells -> Transforms…'
2. Enter 'true.type()' in the Expression field
3. See « java.lang.Boolean » in the preview
**Current Results**
true.type() -> "java.lang.Boolean"
null.type() -> "undefined"
**Expected behavior**
true.type() -> "boolean"
~~null.type() -> "null"~~
**OpenRefine (please complete the following information):**
- Version v3.3
|
https://github.com/OpenRefine/OpenRefine/issues/2510
|
https://github.com/OpenRefine/OpenRefine/pull/4460
|
959718191635582d5bb6001e1ddb96331d74fb64
|
c3e0c314cf584b620ca11a5ea0d52cb71171bc4f
| 2020-04-01T05:35:48Z |
java
| 2022-01-24T20:07:50Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,509 |
["extensions/database/src/com/google/refine/extension/database/DatabaseImportController.java"]
|
OpenRefine 3.3 throws Number Format Exception on Windows 10 when trying to preview query
|
When I connect to my MySQL DB, I'm asked to enter a query and when I keep a simple query "SELECT * FROM mytable", It displays "Updating Preview" Forever and throws an exception in Command Line. Sharing the logs:
Logs:07:49:14.972 [ refine] GET /command/core/get-csrf-token (253429ms)
07:49:14.979 [ refine] POST /command/core/cancel-importing-job (7ms)
07:49:19.654 [ refine] GET /command/database/saved-connection (4675ms)
07:49:19.664 [ refine] GET /command/core/get-csrf-token (10ms)
07:49:19.673 [ refine] POST /command/database/connect (9ms)
07:49:25.019 [ refine] GET /command/core/get-csrf-token (5346ms)
07:49:25.025 [ refine] POST /command/database/test-query (6ms)
07:49:25.047 [ refine] GET /command/core/get-csrf-token (22ms)
07:49:25.052 [ refine] POST /command/core/create-importing-job (5ms)
07:49:25.104 [ refine] GET /command/core/get-csrf-token (52ms)
07:49:25.111 [ refine] POST /command/core/importing-controller (7ms)
07:49:25.130 [ refine] GET /command/core/get-csrf-token (19ms)
07:49:25.137 [ refine] POST /command/core/importing-controller (7ms)
07:49:25.137 [ org.mortbay.log] /command/core/importing-controller (0ms)
java.lang.NumberFormatException: null
at java.base/java.lang.Integer.parseInt(Integer.java:614)
at java.base/java.lang.Integer.parseInt(Integer.java:770)
at com.google.refine.extension.database.DatabaseImportController.getQueryInfo(DatabaseImportController.java:453)
at com.google.refine.extension.database.DatabaseImportController.doParsePreview(DatabaseImportController.java:184)
at com.google.refine.extension.database.DatabaseImportController.doPost(DatabaseImportController.java:100)
at com.google.refine.commands.importing.ImportingControllerCommand.doPost(ImportingControllerCommand.java:68)
at com.google.refine.RefineServlet.service(RefineServlet.java:189)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166)
at org.mortbay.servlet.UserAgentFilter.doFilter(UserAgentFilter.java:81)
at org.mortbay.servlet.GzipFilter.doFilter(GzipFilter.java:132)
at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:326)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:923)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:547)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
Desktop:
Windows 10
Chrome Latest
Java version "11.0.5" 2019-10-15 LTS
Java(TM) SE Runtime Environment 18.9 (build 11.0.5+10-LTS)
Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.5+10-LTS, mixed mode)
**OpenRefine (please complete the following information):**
OpenRefine 3.3
|
https://github.com/OpenRefine/OpenRefine/issues/2509
|
https://github.com/OpenRefine/OpenRefine/pull/3116
|
5ca5f3cb7b6cc1be1813e9e196a3c0f669298a4c
|
ded6ca07d1fb1f88f1b7f9bae7e1de6d3c22e311
| 2020-04-01T02:21:35Z |
java
| 2020-08-25T18:40:49Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,504 |
["extensions/database/pom.xml"]
|
Enhance cross() with empty "project name" calling parameter to represent the current project and empty column name to represent the index
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
The `cross()` function can get data from an external project, but also from the current project (kind of a self-join). In order to minimize the text to write (and read), if the project name parameter could be set to an empty string, it would help or visibility, and for reusability, as the SAME transformation formula can be used in 2 different projects that share some data structure (or on the same project that would have changed name since).
Also, in order to be able to do a cross with the index of the row, I would let empty value for the column name. In that case, the value (first parameter of `cross()`) should be of type number.
**Describe the solution you'd like**
if `cross()` is called with an empty project name, then it should mean that the current project is the one to use. Ex.: `cross(1, "", "ID")[0]`.
if `cross()` is called with an empty column name, then the cross should be done not with a column, but with the internal index of the row, in a numerical match.
**Describe alternatives you've considered**
Writing the full column name, like now. Creating a column in the related project with the index as the value of each row.
|
https://github.com/OpenRefine/OpenRefine/issues/2504
|
https://github.com/OpenRefine/OpenRefine/pull/4884
|
9858b33e5183334884d003d9e670192a0ea11376
|
e9540586f6cde9e31fdaf6a14fbc822d0e8fd648
| 2020-03-31T07:38:59Z |
java
| 2022-05-24T21:24:45Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,484 |
["extensions/wikidata/module/styles/dialogs/schema-alignment-dialog.css"]
|
While creating wikidata schema I-beam pointer appears for drag and drop
|
**Describe the bug**
<!-- A clear and concise description of what the bug is. -->
On hovering over the items to be selected and drag & drop for creating wikidata schema, I-beam pointers appears over there which is not appropriate if it is having a feature of drag & drop.
**To Reproduce**
Steps to reproduce the behavior:
1. Open any project in OpenRefine
2. Go to 'Extensions : Wikidata'
3. Scroll down to 'Edit wikidata schema'
4. Then click on 'Add item'
5. Move on to any item shown above to drag and drop that item & observe the cursor.
**Current Results**
<!-- What results occured or were shown. -->
I-beam cursor is appearing over the item.
**Expected behavior**
<!-- A clear and concise description of what you expected to happen or to show. -->
Grabbing cursor or any other apt cursor should appear.
**Screenshots/ GIF**
**OpenRefine (please complete the following information):**
- Version [e.g. OpenRefine 3.0 Beta]
|
https://github.com/OpenRefine/OpenRefine/issues/2484
|
https://github.com/OpenRefine/OpenRefine/pull/2491
|
f0387d73a5907696b5a0f68a3fb422b4fa1167ba
|
7a7ba57d91f5ad3de5c20590566dee7d034e3cf9
| 2020-03-27T11:10:40Z |
java
| 2020-03-28T18:10:04Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,480 |
[".gitignore", "refine", "refine.bat", "refine.ini"]
|
Adding refine.ini to git-ignore
|
I am proposing to add refine.ini to git-ignore as after setting up Gdata credentials the file will always show as a change to be committed.
|
https://github.com/OpenRefine/OpenRefine/issues/2480
|
https://github.com/OpenRefine/OpenRefine/pull/2497
|
aac835923843dbb4e0a5e717f37be002b2ef5699
|
da21c285efcf2d2d24baea9db5d6dba24d390915
| 2020-03-26T17:37:12Z |
java
| 2020-04-06T08:53:49Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,477 |
["packaging/pom.xml", "refine"]
|
The packaging of just the Windows or Linux version doesn't work (./refine windows_dist | linux_dist)
|
**Describe the bug**
If you try to build the executable for Mac, you can use `./refine mac_dist "3.4-SNPASHOT"` or for all the platform, you can use `./refine dist "3.4-SNPASHOT"`.
The doc also says you can do the same for Windows and Linux:
```
mac_dist <version> .................. Make MacOSX binary distribution
windows_dist <version> .............. Make Windows binary distribution
linux_dist <version> ................ Make Linux binary distribution
dist <version> ...................... Make all distributions
```
But, these:
`./refine windows_dist "3.4-SNPASHOT"`
`./refine linux_dist "3.4-SNPASHOT"`
Do not work…
```
antoine$ ./refine windows_dist "3.4-SNPASHOT"
./refine: line 920: windows_dist: command not found
antoine$ ./refine linux_dist "3.4-SNPASHOT"
./refine: line 921: linux_dist: command not found
```
**To Reproduce**
Steps to reproduce the behavior:
1. Go to your code folder
2. Type: `./refine linux_dist "3.4-SNPASHOT"`
4. See error: « **./refine: line 921: linux_dist: command not found** »
**Current Results**
« **./refine: line 921: linux_dist: command not found** »
**Expected behavior**
Compile for that platform. Use profiles to invoke Maven with specific executions steps. (see below)
**OpenRefine (please complete the following information):**
- Version 3.3
**Additional context**
@wetneb wrote: « At the moment, it is not figured out how to invoke Maven for specific executions in the package stage »
@afkbrb wrote back: « We can use profiles: https://stackoverflow.com/questions/1791305/maven-assembly-plugin-run-only-one-descriptor. And I've made `windows_dist` and `linux_dist` work locally.
|
https://github.com/OpenRefine/OpenRefine/issues/2477
|
https://github.com/OpenRefine/OpenRefine/pull/2498
|
da21c285efcf2d2d24baea9db5d6dba24d390915
|
e26178e0b430c61914ed1fee83e7d6d6b2d422db
| 2020-03-25T20:56:20Z |
java
| 2020-04-06T11:36:38Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,465 |
["main/src/com/google/refine/importers/OdsImporter.java", "main/tests/data/NoData_NoSpreadsheet.ods", "main/tests/server/src/com/google/refine/importers/OdsImporterTests.java"]
|
Generated ODS document without Table causes NPE
|
**Describe the bug**
An ODS document without a `office:spreadsheet` element causes an NPE
**To Reproduce**
Steps to reproduce the behavior:
1. Download [NoData_NoSpreadsheet.ods.zip](https://github.com/OpenRefine/OpenRefine/files/4371589/NoData_NoSpreadsheet.ods.zip)
1. Rename to NoData_NoSpreadsheet.ods
1. Import the generated file NoData_NoSpreadsheet.ods (just rename attached ODS package file)
1. OpenRefine recognizes as a valid ODF file (incorrectly) and attempts to parse as ODS format.
1. See error
**Current Results**
Fails silently and presents the user with a blank preview pane and no indication of error.
The server console/log shows the following stack trace:
```log
14:39:30.626 [ refine] POST /command/core/importing-controller (3ms)
Mar 23, 2020 2:39:30 PM org.odftoolkit.odfdom.dom.OdfSchemaDocument getTables
SEVERE: null
java.lang.NullPointerException
at org.odftoolkit.odfdom.dom.OdfSchemaDocument.fillTableList(OdfSchemaDocument.java:340)
at org.odftoolkit.odfdom.dom.OdfSchemaDocument.getTables(OdfSchemaDocument.java:324)
at org.odftoolkit.odfdom.doc.OdfDocument.getTableList(OdfDocument.java:692)
at com.google.refine.importers.OdsImporter.parseOneFile(OdsImporter.java:142)
at com.google.refine.importers.ImportingParserBase.parseOneFile(ImportingParserBase.java:118)
at com.google.refine.importers.ImportingParserBase.parse(ImportingParserBase.java:89)
at com.google.refine.importing.ImportingUtilities.previewParse(ImportingUtilities.java:961)
at com.google.refine.importing.DefaultImportingController.doUpdateFormatAndOptions(DefaultImportingController.java:174)
at com.google.refine.importing.DefaultImportingController.doPost(DefaultImportingController.java:93)
at com.google.refine.commands.importing.ImportingControllerCommand.doPost(ImportingControllerCommand.java:68)
at com.google.refine.RefineServlet.service(RefineServlet.java:190)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
```
**Expected behavior**
OpenRefine should show an error dialog saying that the file is not a valid ODS document and include a link to the online ODF validator - https://odfvalidator.org/.
**Desktop:**
- OS: Windows 10
- Browser Version: Firefox
- JRE or JDK Version: JDK8
**OpenRefine:**
- Version OpenRefine 3.3
**Additional context**
The provided generated ODS file is actually NOT VALID, and failed parsing with [online hosted ODF Validator instance](https://odfvalidator.org/)
```
Result for NoData_NoSpreadsheet.ods
The document is NOT conformant ODF1.2!
Details:
NoData_NoSpreadsheet.ods: Info: ODF version of root document: 1.2
NoData_NoSpreadsheet.ods/mimetype: Error: The file 'mimetype' shall not be compressed in the ODF package 'NoData_NoSpreadsheet.ods'!
NoData_NoSpreadsheet.ods/mimetype: Error: The file 'mimetype' is not the first file in the ODF package 'NoData_NoSpreadsheet.ods'!
internal:/schema/odf1.2/OpenDocument-v1.2-os-manifest-schema.rng: Info: parsed.
NoData_NoSpreadsheet.ods/META-INF/manifest.xml: Info: no errors, no warnings
NoData_NoSpreadsheet.ods/mimetype: Info: 2 errors, no warnings
NoData_NoSpreadsheet.ods: Info: Media Type: application/vnd.oasis.opendocument.spreadsheet
internal:/schema/odf1.2/OpenDocument-v1.2-os-schema.rng: Info: parsed.
NoData_NoSpreadsheet.ods/meta.xml: Info: Generator: LibreOffice/6.0.3.2$Windows_X86_64 LibreOffice_project/8f48d515416608e3a835360314dac7e47fd0b821
NoData_NoSpreadsheet.ods/meta.xml: Info: no errors, no warnings
NoData_NoSpreadsheet.ods/settings.xml: Info: no errors, no warnings
NoData_NoSpreadsheet.ods/styles.xml: Info: no errors, no warnings
NoData_NoSpreadsheet.ods/content.xml[23,16]: Error: uncompleted content model. expecting: <chart>,<database>,<drawing>,<image>,<presentation>,<spreadsheet>,<text>
</office:body> ----^ NoData_NoSpreadsheet.ods/content.xml: Info: 1 errors, no warnings
internal:/schema/odf1.2/OpenDocument-v1.2-os-dsig-schema.rng: Info: parsed.
NoData_NoSpreadsheet.ods: Info: 3 errors, no warnings
```
|
https://github.com/OpenRefine/OpenRefine/issues/2465
|
https://github.com/OpenRefine/OpenRefine/pull/4709
|
f0489975665c535f69d071651f47e9f15a30f717
|
35e54fa7ee8fc299dbf245b1e6453e9c852cabdc
| 2020-03-23T20:11:30Z |
java
| 2022-04-07T18:12:01Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,461 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
GREL cross function should support lookup by numbers and other datatypes (date, boolean, etc.)
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
The GREL `cross` function only works for string values at the moment. It could also support numbers (`int`, `long`). Looking up by floating point number is probably not a great idea because of rounding errors.
**Describe alternatives you've considered**
The `cross` function could directly convert values to string (in its index, and in its first argument).
**Additional context**
Suggested in #2456.
|
https://github.com/OpenRefine/OpenRefine/issues/2461
|
https://github.com/OpenRefine/OpenRefine/pull/4312
|
fb54c7c00164ba973ed4b49954e0e63328912c82
|
11abc33be723c9ed222513e690dd217dbbbd8079
| 2020-03-23T13:51:02Z |
java
| 2021-11-22T08:32:47Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,454 |
["extensions/database/pom.xml"]
|
Menus in an alternate language sometimes are too small
|
**Describe the bug**
If you choose a different language than english for OR, sometimes the menu's length is not good.
**To Reproduce**
Steps to reproduce the behavior:
1. Go to the « All Rows » menu.
2. See error
**Current Results**
Text overflows out of the menu.
**Expected behavior**
The menu should adapt and be bigger.
**Screenshots**
**Desktop (please complete the following information):**
- MacOS X.14, Chrome latest
**OpenRefine (please complete the following information):**
- Version 3.3
|
https://github.com/OpenRefine/OpenRefine/issues/2454
|
https://github.com/OpenRefine/OpenRefine/pull/4535
|
83a4771e5521f66f40324af7ed8950b580158b45
|
4f75902c89a8e3fe790fa36318d05a9b97ca3873
| 2020-03-22T03:50:09Z |
java
| 2022-02-16T08:23:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,453 |
["extensions/gdata/module/langs/translation-en.json", "extensions/gdata/module/scripts/project/exporters.js", "extensions/wikidata/module/langs/translation-en.json", "extensions/wikidata/module/scripts/menu-bar-extension.js", "main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/project/exporters.js"]
|
Have separate menu items for « Export to file… » and « Export to Google Drive… »
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
Now, if you want to export your project (to file), you go in the menu, and you have to answer a dialog where you choose either « to file » or « to Google Drive ».
Also, using the term « Export to local » is vague, « Export to file » (or even « Export to OpenRefine ZIP » would be better tho the latter is a bit too verbose… ;-)
**Describe the solution you'd like**
It would be much better if there where 2 items in the menu, named « Export to file… » and « Export to Google Drive… ». It would save clicks for exporting to file, which is the operation most of our user do, and it would be clearer in the interface that OpenRefine can export the whole project to Google Drive.
**Describe alternatives you've considered**
Doing the same as now. But if we want to add interface elements for Export to gDrive, it will clutter the interface.
**Additional context**
|
https://github.com/OpenRefine/OpenRefine/issues/2453
|
https://github.com/OpenRefine/OpenRefine/pull/2458
|
a915f9847f5124d8834ce9eef404c304232f190c
|
cff88e6267b1d636fd00ba076598af6c658a9b2b
| 2020-03-21T22:28:45Z |
java
| 2020-03-23T10:14:02Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,443 |
["main/resources/com/google/refine/grel/FunctionDescription_en.properties", "main/resources/com/google/refine/messages/OpenRefineMessage.properties", "main/src/com/google/refine/importers/ImporterUtilities.java", "main/src/com/google/refine/operations/recon/ReconOperation.java"]
|
Back-end localization
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
Some strings that appear in the UI are generated in the backend: exceptions, descriptions of operations, documentation of GREL functions, and probably others that I am not aware of.
We currently do not have any way to translate these.
**Describe the solution you'd like**
We should investigate an architecture to make these strings translatable. I can think of two approaches:
* Replace these strings by identifiers (possibly with template parameters in the case of operation description) and delay their formatting to the front-end, such that we can use the existing frontend localization system (Wikimedia jQuery i18n plugin). This would mean that the backend can continue to ignore in which language the application is being used;
* Bring in server-side localization using an appropriate Java library. We should make sure the messages which appear in the backend are picked up by Weblate somehow.
**Describe alternatives you've considered**
We might use one solution for a particular class of messages (say operation descriptions) and another for other messages (say exceptions).
--------------------------
_This is a [proposed Outreachy project in 2022](https://github.com/OpenRefine/OpenRefine/wiki/GSoC-Outreachy-2022%C2%A0Ideas). If you are **not** planning to apply for an internship via Outreachy/GSoC, we kindly ask that you do not work on this task yet, in order to leave the floor to potential interns._
|
https://github.com/OpenRefine/OpenRefine/issues/2443
|
https://github.com/OpenRefine/OpenRefine/pull/5189
|
0664b1cd7253bac6234177e165e5d81ba1ef7a18
|
e6847715a7ef67ef72e04ffd2ddc08338546d313
| 2020-03-20T13:13:21Z |
java
| 2022-08-17T15:09:33Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,439 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
OR on Mac cannot save data as XLSX or ODS
|
**Describe the bug**
OpenRefine can load data by creating a new project. However, this data cannot be saved (exported) as XLSX or ODS (both apps installed - just in case it might be a library cause).
**To Reproduce**
macOS 10.15.3
Install OR (either from download or from brew)
Create a project, load data
Export data (creates a tar file)
Export as XLSX (does not finish - no file dialog)
Export as ODS (does not finish - no file dialog)
**Current Results**
Can't save projects in application format
**Expected behavior**
Save and load projects in application formats
**Screenshots**
**Desktop (please complete the following information):**
- OS: macOS 10.15.3
- Browser Version: Firefox 74.0
- JRE or JDK Version:
openjdk 13.0.2 2020-01-14
OpenJDK Runtime Environment (build 13.0.2+8)
OpenJDK 64-Bit Server VM (build 13.0.2+8, mixed mode, sharing)
**OpenRefine (please complete the following information):**
- Version OpenRefine 3.3 (1) (homebrew), OpenRefine 3.3 (download)
**Datasets**
any
**Additional context**
|
https://github.com/OpenRefine/OpenRefine/issues/2439
|
https://github.com/OpenRefine/OpenRefine/pull/4200
|
b309bbabdbd4fa52cfb21d28e4dbbff414be8139
|
fe62e35034052bc1c964b0fbf9d7831b386cb6a9
| 2020-03-19T14:51:48Z |
java
| 2021-10-08T06:41:55Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,437 |
["main/webapp/modules/core/scripts/index/default-importing-sources/import-from-web-form.html", "main/webapp/modules/core/scripts/index/default-importing-sources/sources.js"]
|
Page reloads when creating project from URL and press ENTER
|
**Describe the bug**
When I try to create a project by adding URL from `Web Addresses (URLs)` option and press ENTER, the page reloads and switches back to `This computer` choose file option.
**To Reproduce**
Steps to reproduce the behavior:
1. Go to `Web Addresses (URLs)`
2. Add a valid URL to create a project
3. Press ENTER
4. See the response
**Current Results**
Page reloads and switches to `This computer` choose file option
**Expected behavior**
Either it should create the project from that URL or doesn't show any unexpected behavior like this.
**Screenshots**
|
https://github.com/OpenRefine/OpenRefine/issues/2437
|
https://github.com/OpenRefine/OpenRefine/pull/2444
|
f8adf29df6f781a94111244abafe1293fd361b8f
|
bf8af234935ed9c49ef3b30bbb52ae27b56f5741
| 2020-03-19T09:00:32Z |
java
| 2020-03-20T21:35:40Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,435 |
["main/src/com/google/refine/importers/OdsImporter.java", "main/tests/server/src/com/google/refine/importers/RdfTripleImporterTests.java", "main/webapp/modules/core/about.html"]
|
Remove or replace the calls made to freebase.com
|
Context: Freebase reconciliation services have been shut down now. So, there's a need to clean up the code which is redirecting the call to freebase.com which will eventually cause an error 404. Code including freebase.com in it should be removed or replaced accordingly without disturbing any other functionality.
Such code can be found: https://github.com/OpenRefine/OpenRefine/blob/master/main/src/com/google/refine/importers/ExcelImporter.java
https://github.com/OpenRefine/OpenRefine/blob/master/main/src/com/google/refine/importers/OdsImporter.java
and many other places may be.
|
https://github.com/OpenRefine/OpenRefine/issues/2435
|
https://github.com/OpenRefine/OpenRefine/pull/4997
|
fbe51bb5d4186a7ac56b7f37e6bd89d796e6bff5
|
ec4476b6a4dd58b9d705c49d1bf35bc79b01b765
| 2020-03-18T13:51:16Z |
java
| 2022-06-30T03:51:00Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,425 |
["extensions/database/pom.xml"]
|
Column created using "Create column based on this column" doesn't update on original column change
|
**Describe the bug**
<!-- A clear and concise description of what the bug is. -->
When creating a column based on an other column, values of the created column don't update when changes are made to the original column.
**To Reproduce**
Steps to reproduce the behavior:
1. Start reconciling a column using ULAN (Getty) vocabulary. We consider the column to reconcile is called "name"
2. Click the arrow left to "name" and click Edit Column > Add column based on this column
3. The new column is called "judgement" and is computed as such (in Python) :
`return cell.recon.judgement`. Click "OK"
4. The column "judgement" is created and showing the reconciliation status of every record ("matched", "new" or "none")
5. When reconciling a record with a candidate (or creating new item), the "judgement" value for this perticular record is not updating.
**Current Results**
<!-- What results occured or were shown. -->
When performing a match or creating a new item, the "judgement" value for this perticular record is not updating.
**Expected behavior**
<!-- A clear and concise description of what you expected to happen or to show. -->
A column created using the "Create column based on this column" functionality should update every time the column it is based on changes.
ie For an unmatched record, the associated value in the "judgement" column is "none". This value should turn to "matched" when reconciliation is performed or to "new" when "create new item" is clicked
**Screenshots**
<!-- If applicable, add screenshots to help explain your problem. -->
Let's consider this : after reconciling a few items, I create the "judgement" column using the steps described above. In my example, since the first two items have been dealt with (no match so I create new item for both of them), "judgment" is indicating "new" for them. Because the third and last item is still untunched at this point, judgement is showing "none". So, at this point everything's ok.
<img width="389" alt="Screenshot 2020-03-17 at 11 36 11" src="https://user-images.githubusercontent.com/16724487/76850904-9da52000-6848-11ea-9bed-cdd948b5dd6c.png">
As I am dealing with the third and last record, nothing changes is the "judgement" column. The value should change from "none" to "new" but isnt'.
<img width="387" alt="Screenshot 2020-03-17 at 11 36 31" src="https://user-images.githubusercontent.com/16724487/76851288-50757e00-6849-11ea-8763-3d92b4c79deb.png">
**Desktop (please complete the following information):**
- OS: macOS Mojave 10.14.6
- Browser Version: Firefox 74.0 (64 bits)
- JRE or JDK Version:
java version "13.0.2" 2020-01-14
Java(TM) SE Runtime Environment (build 13.0.2+8)
Java HotSpot(TM) 64-Bit Server VM (build 13.0.2+8, mixed mode, sharing)
**OpenRefine (please complete the following information):**
- Version: OpenRefine 3.3 [58b839b]
**Datasets**
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
**Additional context**
<!-- Add any other context about the problem here. -->
This task is performed in order to differenciate the different reconciliation status of my records. ("matched" if record is matched with a candidate, "new" if a new record had to be created, "none" if the record has not been dealt with already)
I believe this is a bug because when the expression used to compute a new column is based on the value of the original column, the newly column updates correctly. Here, the expression is based on the cell which might not trigger anything on state change.
|
https://github.com/OpenRefine/OpenRefine/issues/2425
|
https://github.com/OpenRefine/OpenRefine/pull/4948
|
adaf5156b591a912209413c00f304c5ba3c142bc
|
96ea2f03d8bfcfd6886d2c93f1c69517585076b4
| 2020-03-17T11:34:38Z |
java
| 2022-06-09T19:09:46Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,424 |
["main/webapp/modules/core/scripts/views/data-table/cell-ui.js"]
|
Data Type setted not remembered by application
|
**Describe the bug**
<!-- A clear and concise description of what the bug is. -->
Change the data type of any cell, and see again the type of data is not remembered by the application.
**To Reproduce**
Steps to reproduce the behavior:
1. Go to 'Edit Cell'
2. Click on 'Boolean Datatype'
3. Set the data to `True/False`.
4. Again click on edit cell and see data type as text rather than boolean.
**Expected behavior**
<!-- A clear and concise description of what you expected to happen or to show. -->
Data-Type preference should be remembered
**Screenshots**
<!-- If applicable, add screenshots to help explain your problem. -->
<img width="446" alt="Screenshot 2020-03-17 at 4 03 45 PM" src="https://user-images.githubusercontent.com/44091822/76847968-e967c180-6868-11ea-8d00-d29c2af5c002.png">
|
https://github.com/OpenRefine/OpenRefine/issues/2424
|
https://github.com/OpenRefine/OpenRefine/pull/2440
|
55ea09d21cbb0acd87babe0337a324171998dbc8
|
b6f6904af49faca4d3e351bdefd49fb279a78c66
| 2020-03-17T10:34:10Z |
java
| 2020-04-24T07:28:24Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,411 |
["extensions/wikidata/tests/conf/tests.xml", "extensions/wikidata/tests/data/entitycache/entitycache-P571.json", "extensions/wikidata/tests/data/entitycache/entitycache-P813.json", "extensions/wikidata/tests/data/entitycache/entitycache-P854.json", "extensions/wikidata/tests/src/org/openrefine/wikidata/commands/PreviewWikibaseSchemaCommandTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/testing/WikidataRefineTest.java"]
|
Mock Wikidata service for PreviewWikibaseSchemaCommandTest
|
PreviewWikibaseSchemaCommandTest calls Wikidata service during test. We should mock the service, similar to #2398 .
|
https://github.com/OpenRefine/OpenRefine/issues/2411
|
https://github.com/OpenRefine/OpenRefine/pull/2412
|
fd2460914c0ea5aae6cd79bb27257e364d8d7e06
|
c20dc69294d8ed73ac5b0ffe83714817b5e9e4ea
| 2020-03-14T10:06:11Z |
java
| 2020-03-14T15:36:09Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,409 |
["main/src/com/google/refine/importers/tree/XmlImportUtilities.java", "main/tests/server/src/com/google/refine/importers/JsonImporterTests.java", "main/tests/server/src/com/google/refine/importers/XmlImportUtilitiesTests.java"]
|
The Trim trailing and leading whitespace option for json/xml files does not work
|
**Describe the bug**
When you create a new json/xml project which has trailing whitespace in some elements, clicking the checkbox to eliminate them does not actually work.
**To Reproduce**
Steps to reproduce the behavior:
1. Create a json project that has leading/trailing whitespace in some elements
2. Click on `Trim leading & trailing whitespace from strings` checkbox
**Current Results**
Nothing happens, the whitespace remains.
**Expected behavior**
The whitespace should be removed when the checkbox is clicked
**Screenshots**
<img width="960" alt="2020-03-14 (2)" src="https://user-images.githubusercontent.com/52909743/76658053-3f9ee100-6599-11ea-9dc9-8efde602a9b2.png">
As seen here, there is leading whitespace in the first row, column name, body and email
<img width="960" alt="2020-03-14 (3)" src="https://user-images.githubusercontent.com/52909743/76658055-40d00e00-6599-11ea-9283-04171decb502.png">
`Trim leading & trailing whitespace from strings` checkbox is clicked but still the whitespace remains.
**Desktop:**
- OS: Windows 10
- Browser Version: Google Chrome Version 80.0.3987.132
- openjdk version "11.0.6"
**OpenRefine:**
- Version OpenRefine 3.3
|
https://github.com/OpenRefine/OpenRefine/issues/2409
|
https://github.com/OpenRefine/OpenRefine/pull/2415
|
afd5cf70f0a0fe17af17c6dd07c6d0597da38436
|
a91691cb6bc5215602c54c21a5c67709ae821396
| 2020-03-13T20:34:33Z |
java
| 2020-03-15T16:04:01Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,402 |
["docs/yarn.lock"]
|
'Updating Preview' gets stuck in an infinite loop on clicking any config option in XML
|
**Describe the bug**
The 'Update Preview' gets stuck in an infinite loop if the user does not select a record element first before clicking on any configuration option when working with XML datasets.
**To Reproduce**
1. Go to Create Project
2. Open any XML dataset (e.g. https://www.govinfo.gov/bulkdata/FR/2020/03/FR-2020-03-09.xml)
3. Click any configuration option (e.g. Load at Most checkbox)
**Current Results**
Update Preview gets stuck and there is an error in console `Index 0 out of bounds for length 0`
**Expected behavior**
There should be a message that tells the user to first select an element
**Screenshots**
<img width="674" alt="2020-03-12" src="https://user-images.githubusercontent.com/52909743/76525418-cec0d180-6491-11ea-87ca-25c8ed1b9bd4.png">
|
https://github.com/OpenRefine/OpenRefine/issues/2402
|
https://github.com/OpenRefine/OpenRefine/pull/3044
|
47df8196700382ab9a86e4bf560435dad0edcddb
|
1f5f0df6247d94c2097c34794cd5a1c92a0f1a11
| 2020-03-12T13:21:35Z |
java
| 2020-08-08T00:20:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,398 |
["main/tests/server/src/com/google/refine/importers/WikitextImporterTests.java"]
|
Mock reconciliation calls in Wikitext importer tests
|
The Wikitext importer makes calls to the Wikidata reconciliation service at import time.
We should make sure these calls are mocked in its tests.
|
https://github.com/OpenRefine/OpenRefine/issues/2398
|
https://github.com/OpenRefine/OpenRefine/pull/2410
|
83d175be1bafa2b44875c6d8e940c4d5a2e39ef2
|
14ef45efb23cbbe2713aa662abf5b980b179d5ba
| 2020-03-12T11:36:26Z |
java
| 2020-03-14T09:40:15Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,396 |
["refine", "refine.ini"]
|
Misleading JAVA_OPTIONS configuration samples in refine.ini
|
In [refine.ini](https://github.com/OpenRefine/OpenRefine/blob/master/refine.ini), we have two samples for JAVA_OPTIONS configuration:
```ini
#JAVA_OPTIONS=-XX:+UseParallelGC -verbose:gc -Drefine.headless=true
#JAVA_OPTIONS=-Drefine.data_dir=C:\Users\user\AppData\Roaming\OpenRefine
```
These configurations works fine on Windows. But on linux, if we uncomment the first sample, we'll see the following error:
That's because `JAVA_OPTIONS=-XX:+UseParallelGC -verbose:gc -Drefine.headless=true` is processed as `export JAVA_OPTIONS=-XX:+UseParallelGC -verbose:gc -Drefine.headless=true` in the [refine](https://github.com/OpenRefine/OpenRefine/blob/master/refine) shell script. But the export result is `JAVA_OPTIONS=-XX:+UseParallelGC`, `-verbose:gc` and `-Drefine.headless=true` are processed as identifiers.
Seems we can fix this by rewriting the configuration:
```ini
JAVA_OPTIONS="-XX:+UseParallelGC -verbose:gc -Drefine.headless=true"
```
However, we'll get another error:
That's because the new configuration is interpreted as `"-XX:+UseParallelGC -verbose:gc -Drefine.headless"="true"`.
Actually, we should use `JAVA_OPTIONS=(-XX:+UseParallelGC -verbose:gc -Drefine.headless=true)`. Because `JAVA_OPTIONS` is processed as an array of JVM options in `refine` script.
So, my opinion is that we should tell Unix/Linux users to use parentheses for this configuration.
|
https://github.com/OpenRefine/OpenRefine/issues/2396
|
https://github.com/OpenRefine/OpenRefine/pull/2401
|
6ec40bc4783e17972f81bff7345094005ab9f3e0
|
9a5cb644ecebf53b4ab69d4896998c3676447a7a
| 2020-03-12T09:37:43Z |
java
| 2020-03-13T08:38:56Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,393 |
["main/webapp/modules/core/scripts/index/parser-interfaces/xml-parser-ui.html"]
|
Incorrect linking between checkboxes and labels in XML importer configuration
|
**Describe the bug**
<!-- A clear and concise description of what the bug is. -->
Same as #2388 but for XML importer
|
https://github.com/OpenRefine/OpenRefine/issues/2393
|
https://github.com/OpenRefine/OpenRefine/pull/2394
|
bbf4f479da0116387e9197a0dcf4d359bd35dfa6
|
b5282fcce7cbd13b5e9ccd5a83a895e34fb42877
| 2020-03-12T07:21:31Z |
java
| 2020-03-12T10:54:53Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,386 |
["extensions/database/pom.xml"]
|
No validator to check type of file uploaded in import project
|
**Describe the bug**
<!-- A clear and concise description of what the bug is. -->
No validator to check type of file uploaded in import project while importing from local computer
**To Reproduce**
Steps to reproduce the behavior:
1. Go to 'http://127.0.0.1:3333'
2. Click on 'Get data from this computer'
3. Select JPG, PNG or any other invalid format
4. See error
**Expected behavior**
<!-- A clear and concise description of what you expected to happen or to show. -->
There should be an error of file type not supported
**Screenshots**
<!-- If applicable, add screenshots to help explain your problem. -->
<img width="1202" alt="Screenshot 2020-03-11 at 1 59 46 AM" src="https://user-images.githubusercontent.com/44091822/76356489-0a498780-633c-11ea-9024-bb3cfaf07660.png">
|
https://github.com/OpenRefine/OpenRefine/issues/2386
|
https://github.com/OpenRefine/OpenRefine/pull/4535
|
83a4771e5521f66f40324af7ed8950b580158b45
|
4f75902c89a8e3fe790fa36318d05a9b97ca3873
| 2020-03-10T20:31:30Z |
java
| 2022-02-16T08:23:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,376 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/index/default-importing-sources/sources.js"]
|
URL validator absent in the Get Data from URL input
|
**Describe the bug**
<!-- A clear and concise description of what the bug is. -->
URL validator absent in the Get Data from URL input
**To Reproduce**
Steps to reproduce the behavior:
1. Go to 'Index page'
2. Click on 'import from web url'
3. Enter any random string eg:dnweferfe
4. Click on next and see the server tries to fetch the data from the wrong address
**Expected behavior**
<!-- A clear and concise description of what you expected to happen or to show. -->
There should be a URL Field validator which may restrain the user from entering random strings.
**Screenshots**
<!-- If applicable, add screenshots to help explain your problem. -->
<img width="1220" alt="Screenshot 2020-03-09 at 5 14 06 AM" src="https://user-images.githubusercontent.com/44091822/76173374-119a5500-61c5-11ea-9b4c-c74688a57a53.png">
**Additional context**
<!-- Add any other context about the problem here. -->
cc: @thadguidry @wetneb If this is a valid enhancement .
|
https://github.com/OpenRefine/OpenRefine/issues/2376
|
https://github.com/OpenRefine/OpenRefine/pull/2377
|
8b94b142cb7e9e1f1fc92474453c0c171ccd984c
|
3fd3faca11fc43d0356aac62d9a250f3f0e8c598
| 2020-03-08T23:46:27Z |
java
| 2020-03-11T22:22:49Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,374 |
["main/webapp/modules/core/scripts/facets/list-facet.js"]
|
List Facets dialogue box is editable
|
**Describe the bug**
<!-- A clear and concise description of what the bug is. -->
List Facets dialogue box is editable, which should not be.
**To Reproduce**
Steps to reproduce the behavior:
1. Go to `Customised Facets`
2. Click on `Word Facet`
3. List all choices
4. See error
**Current Results**
<!-- What results occurred or were shown. -->
You can edit the dialogue and remove or add anything which should not be applicable as it is listing the facets.
**Screenshots**
<!-- If applicable, add screenshots to help explain your problem. -->
<img height="400" width="498" alt="Screenshot 2020-03-09 at 4 04 34 AM" src="https://user-images.githubusercontent.com/44091822/76172385-37226100-61bb-11ea-9b8e-a1f0985612c1.png">
<img height="400" width="529" alt="Screenshot 2020-03-09 at 4 04 39 AM" src="https://user-images.githubusercontent.com/44091822/76172387-3984bb00-61bb-11ea-93bd-9dad68bd59ce.png">
|
https://github.com/OpenRefine/OpenRefine/issues/2374
|
https://github.com/OpenRefine/OpenRefine/pull/2375
|
c90fd31dafb6721b3d10735ee423fba231d1700b
|
fec414cb14553381187aed48b778b930cd4d1f67
| 2020-03-08T22:36:34Z |
java
| 2020-03-10T10:17:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,345 |
["main/webapp/modules/core/scripts/project/exporters.js"]
|
Remove freebase functions that are no longer needed
|
Freebase cleanup, remove the use of exportTrippleLoader if only used for freebase. Refer to this : https://github.com/OpenRefine/OpenRefine/pull/2341#issuecomment-592533219 by @thadguidry
|
https://github.com/OpenRefine/OpenRefine/issues/2345
|
https://github.com/OpenRefine/OpenRefine/pull/2399
|
2757326cd7e06961b2242d9ffb89ee13d8153c03
|
6ec40bc4783e17972f81bff7345094005ab9f3e0
| 2020-02-28T15:27:16Z |
java
| 2020-03-12T13:03:26Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,338 |
[".github/workflows/pull_request.yml", "docs/docs/technical-reference/build-test-run.md", "docs/docs/technical-reference/contributing.md", "docs/versioned_docs/version-3.5/technical-reference/build-test-run.md", "docs/versioned_docs/version-3.5/technical-reference/contributing.md"]
|
Code style improvements
|
We have not been enforcing a consistent code style lately. This causes some issues in inconsistent indentation, diverging name conventions, etc.
- [x] decide which style code should follow (probably broken down by languages)
- [x] convert the existing code to match these guidelines
- [x] set up continuous integration to enforce these styles
This would need to be done both for Java and Javascript.
|
https://github.com/OpenRefine/OpenRefine/issues/2338
|
https://github.com/OpenRefine/OpenRefine/pull/4476
|
751c4a9e5125b646245d1ad213686c2970c88719
|
5b4e21234458af5f62addf41fb273a690fb26434
| 2020-02-27T19:44:37Z |
java
| 2022-01-29T16:47:03Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,321 |
["pom.xml"]
|
Problems starting OpenRefine
|
**Describe the bug**
I cannot launch OpenRefine and work with any projects.
**Current Results**
When I run openrefine.exe, the cmd window opens, pauses, then displays an error message. I have tried deleting it and redownloading it, checking my Java version with the IT department, and checking the JRE/JDK version.
Here is the error message:
```
10:19:05.232 [ refine_server] Starting Server bound to '127.0.0.1:3333' (0ms)
10:19:05.248 [ refine_server] Initializing context: '/' from '\\AD.CSBSJU.EDU\HOMEDIR$\STAFF\C\CWALSH001\My Documents\openrefine-3.3\webapp' (16ms)
10:19:08.262 [ org.mortbay.log] EXCEPTION (3014ms)
java.lang.ClassNotFoundException: com.google.refine.RefineServlet
at java.net.URLClassLoader.findClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
at org.mortbay.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:401)
at org.mortbay.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:363)
at org.mortbay.util.Loader.loadClass(Loader.java:91)
at org.mortbay.util.Loader.loadClass(Loader.java:71)
at org.mortbay.jetty.servlet.Holder.doStart(Holder.java:73)
at org.mortbay.jetty.servlet.ServletHolder.doStart(ServletHolder.java:242)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at org.mortbay.jetty.servlet.ServletHandler.initialize(ServletHandler.java:685)
at org.mortbay.jetty.servlet.Context.startContext(Context.java:140)
at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1250)
at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:517)
at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:467)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130)
at org.mortbay.jetty.Server.doStart(Server.java:224)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at com.google.refine.RefineServer.init(Refine.java:197)
at com.google.refine.Refine.init(Refine.java:109)
at com.google.refine.Refine.main(Refine.java:103)
10:19:08.262 [ /] unavailable (0ms)
javax.servlet.UnavailableException: com.google.refine.RefineServlet
at org.mortbay.jetty.servlet.Holder.doStart(Holder.java:79)
at org.mortbay.jetty.servlet.ServletHolder.doStart(ServletHolder.java:242)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at org.mortbay.jetty.servlet.ServletHandler.initialize(ServletHandler.java:685)
at org.mortbay.jetty.servlet.Context.startContext(Context.java:140)
at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1250)
at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:517)
at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:467)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130)
at org.mortbay.jetty.Server.doStart(Server.java:224)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at com.google.refine.RefineServer.init(Refine.java:197)
at com.google.refine.Refine.init(Refine.java:109)
at com.google.refine.Refine.main(Refine.java:103)
10:19:08.262 [ org.mortbay.log] failed refine: java.lang.NullPointerException (0ms)
10:19:08.278 [ org.mortbay.log] Failed startup of context org.mortbay.jetty.webapp.WebAppContext@6737fd8f{/,\\AD.CSBSJU.EDU\HOMEDIR$\STAFF\C\CWALSH001\My Documents\openrefine-3.3\webapp} (16ms)
java.lang.NullPointerException
at java.lang.Class.isAssignableFrom(Native Method)
at org.mortbay.jetty.servlet.ServletHolder.doStart(ServletHolder.java:256)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at org.mortbay.jetty.servlet.ServletHandler.initialize(ServletHandler.java:685)
at org.mortbay.jetty.servlet.Context.startContext(Context.java:140)
at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1250)
at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:517)
at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:467)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130)
at org.mortbay.jetty.Server.doStart(Server.java:224)
at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50)
at com.google.refine.RefineServer.init(Refine.java:197)
at com.google.refine.Refine.init(Refine.java:109)
at com.google.refine.Refine.main(Refine.java:103)
10:19:08.325 [ refine_server] Failed to use jdatapath to detect user data path: resorting to environment variables (47ms)
10:19:08.340 [ refine_server] Failed to use jdatapath to detect user data path: resorting to environment variables (15ms)
10:19:08.340 [ org.mortbay.log] EXCEPTION (0ms)
java.lang.ClassNotFoundException: com.google.refine.RefineServlet
at java.net.URLClassLoader.findClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
at org.mortbay.util.Loader.loadClass(Loader.java:91)
at org.mortbay.util.Loader.loadClass(Loader.java:71)
at org.mortbay.jetty.servlet.Holder.doStart(Holder.java:73)
at org.mortbay.jetty.servlet.ServletHolder.doStart(ServletHolder.java:242)
at com.google.refine.RefineServer.configure(Refine.java:291)
at com.google.refine.RefineServer.init(Refine.java:203)
at com.google.refine.Refine.init(Refine.java:109)
at com.google.refine.Refine.main(Refine.java:103)
10:19:08.340 [ /] unavailable (0ms)
javax.servlet.UnavailableException: com.google.refine.RefineServlet
at org.mortbay.jetty.servlet.Holder.doStart(Holder.java:79)
at org.mortbay.jetty.servlet.ServletHolder.doStart(ServletHolder.java:242)
at com.google.refine.RefineServer.configure(Refine.java:291)
at com.google.refine.RefineServer.init(Refine.java:203)
at com.google.refine.Refine.init(Refine.java:109)
at com.google.refine.Refine.main(Refine.java:103)
Exception in thread "main" java.lang.NullPointerException
at java.lang.Class.isAssignableFrom(Native Method)
at org.mortbay.jetty.servlet.ServletHolder.doStart(ServletHolder.java:256)
at com.google.refine.RefineServer.configure(Refine.java:291)
at com.google.refine.RefineServer.init(Refine.java:203)
at com.google.refine.Refine.init(Refine.java:109)
at com.google.refine.Refine.main(Refine.java:103)
```
**Expected behavior**
I expected OpenRefine's web app to open.
**Screenshots**
**Desktop (please complete the following information):**
- OS: Windows 10
- Browser Version: Firefox 73.0.1 64-bit
- JRE or JDK Version: JRE 1.8.0_211-b12
**OpenRefine (please complete the following information):**
- Version: 3.3
**Additional context**
Add any other context about the problem here.
|
https://github.com/OpenRefine/OpenRefine/issues/2321
|
https://github.com/OpenRefine/OpenRefine/pull/4460
|
959718191635582d5bb6001e1ddb96331d74fb64
|
c3e0c314cf584b620ca11a5ea0d52cb71171bc4f
| 2020-02-20T16:25:28Z |
java
| 2022-01-24T20:07:50Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,319 |
["extensions/database/pom.xml"]
|
Stuck With Setup With Environment
|
error Failed to install the app. Make sure you have the Android development environment set up: https://facebook.github.io/react-native/docs/getting-started.html#android-development-environment. Run CLI with --verbose flag for more details.
Error: Command failed: gradlew.bat app:installDebug -PreactNativeDevServerPort=8081
:ReactNative:Unexpected empty result of running '[node, undefined, config]' command.
:ReactNative:Running '[node, undefined, config]' command failed.
FAILURE: Build failed with an exception.
* Where:
Script 'C:\Users\vmpat\teacherApp\node_modules\@react-native-community\cli-platform-android\native_modules.gradle' line: 170
* What went wrong:
A problem occurred evaluating script.
> internal/modules/cjs/loader.js:985 throw err; ^Error: Cannot find module 'C:\Users\vmpat\teacherApp\android\undefined' at Function.Module._resolveFilename (internal/modules/cjs/loader.js:982:15)
at Function.Module._load (internal/modules/cjs/loader.js:864:27)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:74:12) at internal/main/run_main_module.js:18:47 { code: 'MODULE_NOT_FOUND', requireStack: []}
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 943ms
at checkExecSyncError (child_process.js:630:11)
at execFileSync (child_process.js:648:15)
at runOnAllDevices (C:\Users\vmpat\teacherApp\node_modules\react-native\node_modules\@react-native-community\cli-platform-android\build\commands\runAndroid\runOnAllDevices.js:94:39)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
at async Command.handleAction (C:\Users\vmpat\teacherApp\node_modules\react-native\node_modules\@react-native-community\cli\build\index.js:164:9)
PS C:\Users\vmpat\teacherApp> npx react-native run-android
error React Native CLI uses autolinking for native dependencies, but the following modules are linked manually:
- react-native-splash-screen (to unlink run: "react-native unlink
react-native-splash-screen")
This is likely happening when upgrading React Native from below 0.60 to 0.60 or above. Going forward, you can unlink this dependency via "react-native unlink <dependency>" and it will be included in your
app automatically. If a library isn't compatible with autolinking, disregard this message and notify the library maintainers.
Read more about autolinking: https://github.com/react-native-community/cli/blob/master/docs/autolinking.md
info Running jetifier to migrate libraries to AndroidX. You can disable it using "--no-jetifier" flag.
Jetifier found 1205 file(s) to forward-jetify. Using 4 workers...
info Starting JS server...
info Launching emulator...
error Failed to launch emulator. Reason: Emulator exited before boot..
warn Please launch an emulator manually or connect a device. Otherwise app may fail to launch.
info Installing the app...
:ReactNative:Unexpected empty result of running '[node, undefined, config]' command.
:ReactNative:Running '[node, undefined, config]' command failed.
FAILURE: Build failed with an exception.
* Where:
Script 'C:\Users\vmpat\teacherApp\node_modules\@react-native-community\cli-platform-android\native_modules.gradle' line: 170
* What went wrong:
A problem occurred evaluating script.
> internal/modules/cjs/loader.js:985 throw err; ^Error: Cannot find module 'C:\Users\vmpat\teacherApp\android\undefined' at Function.Module._resolveFilename (internal/modules/cjs/loader.js:982:15)
at Function.Module._load (internal/modules/cjs/loader.js:864:27)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:74:12) at internal/main/run_main_module.js:18:47 { code: 'MODULE_NOT_FOUND', requireStack: []}
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 2s
error Failed to install the app. Make sure you have the Android development environment set up: https://facebook.github.io/react-native/docs/getting-started.html#android-development-environment. Run CLI with --verbose flag for more details.
Error: Command failed: gradlew.bat app:installDebug -PreactNativeDevServerPort=8081
:ReactNative:Unexpected empty result of running '[node, undefined, config]' command.
:ReactNative:Running '[node, undefined, config]' command failed.
FAILURE: Build failed with an exception.
* Where:
Script 'C:\Users\vmpat\teacherApp\node_modules\@react-native-community\cli-platform-android\native_modules.gradle' line: 170
* What went wrong:
A problem occurred evaluating script.
> internal/modules/cjs/loader.js:985 throw err; ^Error: Cannot find module 'C:\Users\vmpat\teacherApp\android\undefined' at Function.Module._resolveFilename (internal/modules/cjs/loader.js:982:15)
at Function.Module._load (internal/modules/cjs/loader.js:864:27)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:74:12) at internal/main/run_main_module.js:18:47 { code: 'MODULE_NOT_FOUND', requireStack: []}
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 2s
at checkExecSyncError (child_process.js:630:11)
at execFileSync (child_process.js:648:15)
at runOnAllDevices (C:\Users\vmpat\teacherApp\node_modules\react-native\node_modules\@react-native-community\cli-platform-android\build\commands\runAndroid\runOnAllDevices.js:94:39)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
at async Command.handleAction (C:\Users\vmpat\teacherApp\node_modules\react-native\node_modules\@react-native-community\cli\build\index.js:164:9)
|
https://github.com/OpenRefine/OpenRefine/issues/2319
|
https://github.com/OpenRefine/OpenRefine/pull/4253
|
3eb19a25f8b649475706f0b7af210f4f3033eac3
|
70ec2a99dd513b87787ea3e9a1a90fc7cba82c3c
| 2020-02-20T08:10:41Z |
java
| 2021-10-30T09:05:26Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,316 |
["main/webapp/modules/core/scripts/views/data-table/cell-ui.js"]
|
"Match other cells with same content" keeps appearing as the default choice
|
**Describe the bug**
When doing reconciliation, I sometimes manually match entries to Wikidata items using "Search for match". I choose the correct match but the match is applied to _all entries with the same name_ because the radio button "Match other cells with same content" is always ticked by default. Even if I change it, next time this button will again be ticked.
**Expected behavior**
It would be very cool if I could either choose the default button in settings, or OpenRefine could remember my last choice.
**Screenshots**
<img width="303" alt="Bez názvu" src="https://user-images.githubusercontent.com/21329813/74816668-ddd1bb00-52fb-11ea-9f0b-7e2c15717660.png">
**Desktop**
- OS: [Windows 10]
- Browser Version: Chrome version 80.0.3987.106
- OpenRefine 3.3 Beta
|
https://github.com/OpenRefine/OpenRefine/issues/2316
|
https://github.com/OpenRefine/OpenRefine/pull/4687
|
78b906540d9a8e90209ad6779c46fe8dfa9bcd7f
|
ff991e57dc4bfcd40a2b7bfb1164240624118c7e
| 2020-02-19T08:42:18Z |
java
| 2022-04-05T08:25:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,306 |
["extensions/gdata/src/com/google/refine/extension/gdata/SpreadsheetSerializer.java", "extensions/gdata/src/com/google/refine/extension/gdata/UploadCommand.java"]
|
gSheet export thru « Custom tabular exporter… » doesn't work with empty values
|
**Describe the bug**
I'm trying to export with « Custom tabular exporter… » and choosing « Upload to -> A new Google spreadsheet », and in some rows, if a value is missing, then the cell value disapear and the cell on the right shift left.
**To Reproduce**
Steps to reproduce the behavior:
1. « Custom tabular exporter… »
2. choose « Upload to -> A new Google spreadsheet »
3. See the resulting document with mess up data.
**Current Results**
Some cell are shifted left when there is no data in the cell on the left.
**Expected behavior**
A clear and concise description of what you expected to happen or to show.
**Screenshots**
**Desktop (please complete the following information):**
- OS: MacOS 10.14.6
- Browser Version: Chrome latest
- JRE 13.0.1
**OpenRefine (please complete the following information):**
- Version 3.3
Relates to Google Groups « OpenRefine » discussion : [This seams to be a bug in exporting to gSheet](https://groups.google.com/forum/#!topic/openrefine/8BjfWdLwUhs)
|
https://github.com/OpenRefine/OpenRefine/issues/2306
|
https://github.com/OpenRefine/OpenRefine/pull/2782
|
bf57667a47e10c6bd23166435ec65ce682e7943f
|
6b00c7b602ae0b962c8b8fafb16e167395006ed8
| 2020-02-09T23:56:48Z |
java
| 2020-06-22T17:01:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,305 |
["extensions/database/pom.xml"]
|
Request to upload WD schema of new objects at once
|
**Is your feature request related to a problem or area of OpenRefine? Please describe.**
I get frustrated when adding objects through OpenRefine to WD with a schema which includes multiple types of new objects. If the schema includes objects which are still to be created which are connected through statements, then OpenRefine cannot import the changes to WD.
**Potential solution**
A solution to this would be for OpenRefine to go through each object definition first (Object-Label-Description-Instance of/Subclass of), to reconcile this data and then continue further with the schema, where interlinked statements are presented.
**Alternative**
An alternative is:
- creating the full scheme (since this way it is easier to make sure all statements are included)
- exporting the whole schema
- splitting the schema for the different new object types: importing the schema, deleting all but one object type to be created
- updating to WD
- reconciling the newly created objects
- importing the schema again with the next objects, until all new objects are created and reconciled. Finally, quickest and least messy is to export the remaining part of the schema (e.g. statements with 2 new objects of different types to QuickStatements.
However, this alternative can get messy with complex semantic structures.
**Additional context**
Add any other context or screenshots about the feature request here.
Link to the data used as example of this limitation in OpenRefine:
https://raw.githubusercontent.com/dvalexieva97/chalga-ili-rap/master/albums-songs_rap.csv
|
https://github.com/OpenRefine/OpenRefine/issues/2305
|
https://github.com/OpenRefine/OpenRefine/pull/4222
|
a5a2cd3c9ba8c9d32355b2f26ce3d659d72c8614
|
7e9210c87d22efd889e97db1607fe5da1c1e7d39
| 2020-02-04T21:26:59Z |
java
| 2021-10-18T18:49:33Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,304 |
["extensions/wikidata/src/org/openrefine/wikidata/editing/EditBatchProcessor.java"]
|
Make maxlag configurable in Wikidata extension
|
Maxlag is a parameter that controls how aggressive a mass-editing tool should be when uploading edits to Wikidata.
With the current issues around Wikidata's stability it is often impossible to edit with maxlag set to 5 seconds, the default value recommended by the guidelines (and the one set in OpenRefine by default).
As part of #1640 we want to make the configuration of the Wikibase instance user-configurable (instead of being hard-coded to Wikidata) and part of that includes letting users set the maxlag value as they wish.
|
https://github.com/OpenRefine/OpenRefine/issues/2304
|
https://github.com/OpenRefine/OpenRefine/pull/2631
|
53020a9ad79908a1e9137922847e7b66e13fb21c
|
219ce236a2d7372868da91b052322cac789bd026
| 2020-02-03T10:12:32Z |
java
| 2020-05-21T18:39:34Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,290 |
["extensions/database/pom.xml"]
|
"Choose new match" then "search for match" discards old match, but doesn't add new one
|
(3,3 rc 1 / Windows 10 1809 / Chrome 79.0.3945.117) After running reconciliation, if I "choose new match" then "search for match", put in a specific Q-number to search for, then select it, the old match is discarded but the new match isn't added, and the row goes into the "reconciliation = none" facet
|
https://github.com/OpenRefine/OpenRefine/issues/2290
|
https://github.com/OpenRefine/OpenRefine/pull/4222
|
a5a2cd3c9ba8c9d32355b2f26ce3d659d72c8614
|
7e9210c87d22efd889e97db1607fe5da1c1e7d39
| 2020-01-16T23:25:15Z |
java
| 2021-10-18T18:49:33Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,286 |
["refine"]
|
Build system does not support HTTPS calls to Maven
|
**Describe the bug**
When I try to run `./refine build`, I get a 501 error when the build system attempts to contact `http://repo.maven.apache.org/`. This appears to be related to Maven's HTTPS switchover on 2020-01-15 (https://blog.sonatype.com/central-repository-moving-to-https), which causes `http://` calls to be rejected.
**To Reproduce**
Steps to reproduce the behavior:
1. Clone the master repository
2. `./refine build`
**Current Results**
```[INFO] ------------------------------------------------------------------------
[INFO] Building OpenRefine 3.3-SNAPSHOT
[INFO] ------------------------------------------------------------------------
Downloading: http://repo.maven.apache.org/maven2/org/codehaus/mojo/build-helper-maven-plugin/1.8/build-helper-maven-plugin-1.8.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] OpenRefine ......................................... FAILURE [ 3.014 s]
[INFO] OpenRefine - main .................................. SKIPPED
[INFO] OpenRefine - server ................................ SKIPPED
[INFO] OpenRefine - extensions ............................ SKIPPED
[INFO] OpenRefine - Jython extension ...................... SKIPPED
[INFO] OpenRefine - Wikidata extension .................... SKIPPED
[INFO] OpenRefine - Database extension .................... SKIPPED
[INFO] OpenRefine - Gdata extension ....................... SKIPPED
[INFO] OpenRefine - PC-axis extension ..................... SKIPPED
[INFO] OpenRefine - Phonetic clustering extension ......... SKIPPED
[INFO] OpenRefine - packaging ............................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3.927 s
[INFO] Finished at: 2020-01-15T12:02:00-05:00
[INFO] Final Memory: 7M/37M
[INFO] ------------------------------------------------------------------------
[ERROR] Plugin org.codehaus.mojo:build-helper-maven-plugin:1.8 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.codehaus.mojo:build-helper-maven-plugin:jar:1.8: Could not transfer artifact org.codehaus.mojo:build-helper-maven-plugin:pom:1.8 from/to central (http://repo.maven.apache.org/maven2): Failed to transfer file: http://repo.maven.apache.org/maven2/org/codehaus/mojo/build-helper-maven-plugin/1.8/build-helper-maven-plugin-1.8.pom. Return code is: 501 , ReasonPhrase:HTTPS Required. -> [Help 1]
```
**Expected behavior**
The build system is able to successfully contact the Maven repository and download necessary files.
**Desktop (please complete the following information):**
- OS: macOS 10.14.6
- Browser Version: n/a
- JRE or JDK Version: openjdk 12.0.1 2019-04-16
**OpenRefine (please complete the following information):**
- Version: 3.3-SNAPSHOT
|
https://github.com/OpenRefine/OpenRefine/issues/2286
|
https://github.com/OpenRefine/OpenRefine/pull/2287
|
9668210e58bedb33b21435545d37c6b3b6a799c2
|
2e686987bdc46f2d93ad1f0f89f27377fdb4fe75
| 2020-01-15T17:09:10Z |
java
| 2020-01-16T15:19:42Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,281 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
Can't load data from Postgres-Database using in-build database-connectors
|
Since Version **3.3 beta** the preview screen after submitting a SQL-Statement to load data from my local installed PSQL-database runs into an infinite loop.
Using Version 3.2 everything works fine.
Unfortunately in the terminal windows there are no errors displayed during this error.
(Running OpenRefine on Ubuntu 18)
|
https://github.com/OpenRefine/OpenRefine/issues/2281
|
https://github.com/OpenRefine/OpenRefine/pull/4200
|
b309bbabdbd4fa52cfb21d28e4dbbff414be8139
|
fe62e35034052bc1c964b0fbf9d7831b386cb6a9
| 2020-01-09T07:52:29Z |
java
| 2021-10-08T06:41:55Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,280 |
["main/webapp/modules/core/scripts/views/data-table/data-table-view.js"]
|
Add "Fill down / Blank down" operation for all columns at once
|
There aren't many cell edits that make sense to apply to a whole dataset at once, but filling down is one of them (and I assume its sibling "Blank Down" too).
This would be a common operation needed after splitting multi-valued cells: depending on what the user wants to do with the exported data, they might need filling the resulting empty cells in _all_ other columns with the data from each record's first row.
The "All" dropdown could contain extra options "Edit rows > Fill down" and "Edit rows > Blank down", just like all other columns have.
**Describe alternatives you've considered**
I don't know of a different way to do that apart from applying it to each column one by one?
**Additional context**
Currently using OpenRefine 3.1 RC1.
|
https://github.com/OpenRefine/OpenRefine/issues/2280
|
https://github.com/OpenRefine/OpenRefine/pull/2296
|
fe147328f3ed24d8d75164faa6349735bf868daa
|
5894041943ded044feda91691889d821c0c9700c
| 2020-01-09T05:09:21Z |
java
| 2020-01-27T09:24:08Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 2,277 |
["extensions/database/pom.xml", "extensions/gdata/pom.xml"]
|
Something is already running on http://127.0.0.1:3333/
|
Hello ,
Distributor ID: LinuxMint
Description: Linux Mint 18.3 Sylvia
Release: 18.3
Codename: sylvia
I've set no_proxy="localhost,127.0.0.1,127.0.0.1/8"
I also tried to set this no_proxy on refine.ini
I've tried to change the port
I've stopped the nginx server who was returning a 403 error page by default.
No services are running on the ports I've tried.
Whatever I do, I get this error.
I'm actually investigating the code to find the reason of this error.
|
https://github.com/OpenRefine/OpenRefine/issues/2277
|
https://github.com/OpenRefine/OpenRefine/pull/3906
|
84956e2896326e1a8f1bf7076d9375c5ce2761b5
|
4537f5f46f0ce77cff461d882852f7dccfa6fcfb
| 2020-01-07T11:50:29Z |
java
| 2021-05-15T06:55:30Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.