status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,485 |
["extensions/database/src/com/google/refine/extension/database/DatabaseModuleImpl.java"]
|
stream not closed if dbextension.properties is customized and secured via another user acccount
|
If `dbextension.properties` is customized and given alternate permissions, than while attempting a stream of file, an exception is logged but the stream isn't effectively closed.
### To Reproduce
Steps to reproduce the behavior:
1. Change permissions on dbextension.properties
### Current Results
stream is left open
### Expected Behavior
stream should be autoclosed with newer try with resources
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 11 (WSL2 virtual environment for test user account)
- Browser Version: Firefox
- JRE or JDK Version: JDK 17.0.1
- OpenRefine: master branch
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/4485
|
https://github.com/OpenRefine/OpenRefine/pull/4486
|
1e7ca54628daa02635ae8c78814b21ec0ba4e990
|
ec02fa61318256e0d8c9360d3a680383fba22943
| 2022-01-31T16:30:38Z |
java
| 2022-02-03T17:15:56Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,477 |
["docs/yarn.lock"]
|
Documentation warnings with yarn caniuse-lite browser library
|
Locally and in our Netlify CI/CD there are warnings about updating caniuse-lite that are distracting.
### To Reproduce
Steps to reproduce the behavior:
1. `cd docs`
2. ` docusaurus write-translations && yarn build`
### Current Results
```log
10:31:48 AM: [info] [webpackbar] Compiling Client
10:31:48 AM: [info] [webpackbar] Compiling Server
10:32:56 AM: Browserslist: caniuse-lite is outdated. Please run:
10:32:56 AM: npx browserslist@latest --update-db
10:32:56 AM: Why you should do it regularly:
10:32:56 AM: https://github.com/browserslist/browserslist#browsers-data-updating
```
### Expected Behavior
caniuse-lite should be maintained as updated (helps a bit for Docusaurus with JS and polyfills) as explained in https://github.com/browserslist/browserslist#browsers-data-updating
|
https://github.com/OpenRefine/OpenRefine/issues/4477
|
https://github.com/OpenRefine/OpenRefine/pull/4479
|
5b4e21234458af5f62addf41fb273a690fb26434
|
2bcb31d8742bb44710f184aad6de816f0531cee9
| 2022-01-29T17:26:25Z |
java
| 2022-01-29T18:11:24Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,472 |
["extensions/wikidata/src/org/openrefine/wikidata/editing/MediaFileUtils.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/editing/MediaFileUtilsTest.java"]
|
Prevent users from uploading duplicate files to Wikimedia Commons
|
In some cases, people who use OpenRefine for uploading new files to Wikimedia Commons will not be aware that (some of) these files already exist on Wikimedia Commons. This may happen, for instance, in cases where a cultural institution (GLAM) wants to do a batch upload to Commons, where previously a volunteer may already have found and uploaded (some of) their files there, or vice versa.
### Proposed solution
_Exact_ duplicates can be tracked/identified during upload to Wikimedia Commons, and upload tools usually (but [not always](https://bitbucket.org/magnusmanske/flickr2commons/issues/80/not-tagging-duplicates-properly)) support discovery and rejection of upload of such duplicates. It would be really good if OpenRefine would indeed do this too.
[Commons:Guide to batch uploading](https://commons.wikimedia.org/wiki/Commons:Guide_to_batch_uploading#Check_for_duplicates) contains some pointers on how to check for duplicates: it is possible to [ask the Commons API](https://commons.wikimedia.org/w/api.php?action=query&titles=File:Example.jpg&prop=imageinfo&iiprop=sha1) to look for files with [a same SHA-1 hash](https://commons.wikimedia.org/w/api.php?action=query&list=allimages&prop=imageinfo&aisha1=d01b79a6781c72ac9bfff93e5e2cfbeef4efc840).
As an example, Wikimedia Commons' own UploadWizard provides the user with an immediate warning if they try to upload an exact duplicate of a file.
### What about nearly exact duplicates?
It would be great if it would be possible to also identify nearly exact duplicates (e.g. visually extremely similar files), but this seems not technically possible yet.
As an example, [this file](https://commons.wikimedia.org/wiki/File:Naturalis_Biodiversity_Center_-_RMNH.AVES.110015_-_Chloridops_kona_Wilson,_1888_-_Kona_Grosbeak_-_specimen_-_lateral_view.jpeg) was uploaded in 2015 during a GLAM partnership (by a Wikipedian in Residence). The file [is also shared on the GBIF website](https://www.gbif.org/occurrence/2433871981) and was [uploaded again with another tool in 2022](https://commons.wikimedia.org/wiki/File:Chloridops_kona_S.B.Wilson,_1888_2433871981.jpg). While both files are visually identical, they do have different file sizes and EXIF data, so some processing has happened through time.
There are some [ideas and discussions](https://commons.wikimedia.org/wiki/User:F%C3%A6/Imagehash) around this issue on Wikimedia Commons, but to my knowledge no concrete/actionable steps yet (e.g. applying other types of image hashing). See also https://phabricator.wikimedia.org/T251026
|
https://github.com/OpenRefine/OpenRefine/issues/4472
|
https://github.com/OpenRefine/OpenRefine/pull/5108
|
6cf4b368a2bec57da401b82c921ed590907e2d87
|
892b19a444d1ee52730ee1b46bfedeb17c15440d
| 2022-01-27T13:49:59Z |
java
| 2022-07-29T08:34:11Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,456 |
["extensions/wikidata/pom.xml", "extensions/wikidata/src/org/openrefine/wikidata/commands/ConnectionManager.java", "extensions/wikidata/src/org/openrefine/wikidata/commands/LoginCommand.java", "extensions/wikidata/src/org/openrefine/wikidata/utils/EntityCache.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/commands/ConnectionManagerTests.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/commands/LoginCommandTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/commands/PreviewWikibaseSchemaCommandTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/testing/WikidataRefineTest.java"]
|
Fix test failures for the Wikidata extension with Java 17
|
The tests for the Wikidata extension fail with Java 17 on the CI:
https://github.com/OpenRefine/OpenRefine/runs/4908006956?check_suite_focus=true
This should be fixed.
|
https://github.com/OpenRefine/OpenRefine/issues/4456
|
https://github.com/OpenRefine/OpenRefine/pull/4459
|
1b01165e94300402679c7db4c69ab1407495e286
|
17f1ee727188378a8bb7941f6748e07e1dfff825
| 2022-01-22T17:38:33Z |
java
| 2022-01-24T22:16:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,452 |
["docs/docs/manual/sortview.md", "docs/static/img/goto.png", "docs/versioned_docs/version-3.5/manual/sortview.md"]
|
Add documentation (and screen snippet) of new "Go to page" feature
|
We forgot to close an old issue and update the documentation for the new "Go to page / Jump to page" feature kindly done by @antoine2711
### Current Results
There is no documentation for the new "Go to page - Page number" input box feature in the "Grid" section of docs - https://docs.openrefine.org/manual/running#the-grid
### Expected Behavior
Have a paragraph that describes:
- Changing numbers to go to a page
- Clicking in number input box and then using arrow keys UP/DOWN on keyboard can also advance/reverse page numbers
- Include a small screen snippet of the grid header area or better yet, the entire grid (`div#right-panel` in OpenRefine)
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: all
- Browser Version: all
- JRE or JDK Version: n/a
- OpenRefine: 3.5+
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
As designed, discussed, tested in Issue #2638 and PR #2639
|
https://github.com/OpenRefine/OpenRefine/issues/4452
|
https://github.com/OpenRefine/OpenRefine/pull/4469
|
df57a5e70f1077f6e664c301bd745f7c8e451e92
|
c86a6b6bdff7c143dd9e8ecdec6a21f5e0386f82
| 2022-01-21T03:39:30Z |
java
| 2022-01-28T19:22:26Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,440 |
["main/src/com/google/refine/expr/functions/xml/ScriptText.java", "main/tests/cypress/cypress/integration/project/grid/viewpanel-header/sort.spec.js"]
|
Flaky integration test in cypress/integration/project/grid/viewpanel-header/sort.spec.js
|
Our test suite regularly fails when running `cypress/integration/project/grid/viewpanel-header/sort.spec.js` and that happens even for unrelated changes. We should look into why this test is flaky and fix it.
|
https://github.com/OpenRefine/OpenRefine/issues/4440
|
https://github.com/OpenRefine/OpenRefine/pull/4449
|
affd37af0b6d604f6aa28544281381c2ec45fcd0
|
8fb53bb7c444a30d8a6dca165f07ac898b4f4f4e
| 2022-01-18T13:07:11Z |
java
| 2022-01-20T15:32:46Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,410 |
["docs/docs/manual/running.md", "main/src/com/google/refine/commands/GetVersionCommand.java", "main/webapp/modules/core/scripts/index.js", "refine.ini", "server/src/com/google/refine/Refine.java"]
|
Question: Is it possible to disable the update notice?
|
**Description**: If a new version of OpenRefine is available a message is displayed: "New Version Download OpenRefine v3.5.1 now."
**Question**: Is it possible to disable this message?
**Rationale**: We run OpenRefine in a controlled environment, in which any software needs to be packaged and signed. The user cannot update the software. Therefore it would be nice not to display that message.
|
https://github.com/OpenRefine/OpenRefine/issues/4410
|
https://github.com/OpenRefine/OpenRefine/pull/4559
|
7140da8d9b77b3a55b031a3b01befbd28c038faa
|
0617d771dd7ef5f673f1e688e715f997b2c2eb0e
| 2022-01-06T09:53:52Z |
java
| 2022-02-24T08:15:09Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,407 |
["main/webapp/modules/core/scripts/views/data-table/data-table-view.js"]
|
down-arrow image path broken on custom installation
|
I setup a docker image with OpenRefine 3.5.1 and found out that the down-arrow image path is broken. It would be ok if the image would have the same path as the logo.
### To Reproduce
Steps to reproduce the behavior:
1. Deploy OpenRefine in a Docker container
2. Then, import some dummy data into a project
3. Finally, the down-arrow button is broken
### Screenshots
### Versions
- Operating System: Linux/Docker
- Browser Version: Latest Chrome
- JRE or JDK Version: 11
- OpenRefine: 3.5.1
|
https://github.com/OpenRefine/OpenRefine/issues/4407
|
https://github.com/OpenRefine/OpenRefine/pull/4408
|
abffd29c5849f2faf212dd8a161d308b6179b85c
|
ea42ad772efffc3f2e4a9dbae0d8274609799806
| 2022-01-05T09:41:12Z |
java
| 2022-01-05T10:36:03Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,405 |
["refine"]
|
Maven version updated
|
Maven jar version 3.8.3 currently used in refine start script has been removed from apache servers. Online version available is 3.8.4
### To Reproduce
Steps to reproduce the behavior:
1. Fresh computer.
2. Clone OpenRefine repo
3. run ./refine
### Current Results
During maven prepare the download step gets a 404 page instead of the tar.gz file making the unpack step fail.
### Expected Behavior
Correctly unpacked maven.
|
https://github.com/OpenRefine/OpenRefine/issues/4405
|
https://github.com/OpenRefine/OpenRefine/pull/4406
|
1f5a93728814a7402e2a3bec60f37e4c1d1506fd
|
abffd29c5849f2faf212dd8a161d308b6179b85c
| 2022-01-04T10:18:11Z |
java
| 2022-01-05T07:58:30Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,402 |
["main/src/com/google/refine/io/ProjectMetadataUtilities.java", "main/tests/server/src/com/google/refine/io/ProjectMetadataUtilitiesTest.java"]
|
Problems with special characters in project name
|
This issue describes problems with special characters in the project name and other fields from `metadata.json`.
### To Reproduce
Steps to reproduce the behavior:
1. Create a project with special characters in the project name ("Testing äüöß").
2. Close OpenRefine and check `metadata.json` (everything ok!)
3. Reopen OpenRefine and check special characters in the project name ("Testing äüöß").
4. Close OpenRefine and check `metadata.json` (not ok!)
5. Reopen OpenRefine and check special characters in the project name ("Testing äüöß")
### Current Results
The special characters are somehow completely wrong and their number doubles with each restart of OpenRefine.
### Expected Behavior
Reading and writing metadata to `metadata.json` preserves special characters.
### Screenshots
#### After creating the project (step 1):
#### First restart (step 3):
##### Second restart (step 5):
### Versions
- Operating System: Windows 10
- Browser Version: Firefox 95
- JRE: 11.0.13 (using the bundled version "openrefine-win-with-java-3.5.1.zip")
- OpenRefine: observed in 3.5.0, 3.5.1 and 3.5.2
### Additional context
1. The list of garbled up characters grows exponentially which results in realy large `metadata.json` files and OutOfMemory errors.
2. This might be related or even be the same problem as described in #3431.
3. I also observed this problem in `metadata.json` in the fields `.importOptionMetadata` and `.preferences.entries."exporters.templating.template"`.
|
https://github.com/OpenRefine/OpenRefine/issues/4402
|
https://github.com/OpenRefine/OpenRefine/pull/4768
|
8e5e06a4b11843bbfcb5d1db128c08aef46d2b5c
|
8fc801e15b591a8bedd508b5b3e698f5eadd44f1
| 2022-01-03T09:54:06Z |
java
| 2022-04-24T18:35:16Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,397 |
["pom.xml"]
|
Many unneeded dependencies pulled in from odftoolkit
|
We currently pull in a lot of unneeded dependencies from the `odftoolkit` Java library. Thankfully this has happened after 3.5.1, so we have not released anything with those dependencies yet.
See https://github.com/tdf/odftoolkit/issues/142
Additionally, version 0.10.0 of this toolkit depends on `org.json`, which was not the case in `0.9.0`. Therefore we need to roll back to 0.9.0.
https://github.com/tdf/odftoolkit/issues/144
|
https://github.com/OpenRefine/OpenRefine/issues/4397
|
https://github.com/OpenRefine/OpenRefine/pull/4398
|
9dc1ec2f98f3b6b00a27cd0ea11601d3ae1b9947
|
57b0ce99ccc911eee557dc253a46576ab564cda6
| 2021-12-30T14:18:18Z |
java
| 2021-12-30T14:50:01Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,384 |
[".github/workflows/pull_request.yml", "main/pom.xml", "main/tests/server/src/com/google/refine/RefineTest.java", "main/tests/server/src/com/google/refine/importers/WikitextImporterTests.java", "main/tests/server/src/com/google/refine/operations/recon/ExtendDataOperationTests.java", "pom.xml"]
|
Remove dependency to PowerMock
|
PowerMock is not compatible with Java 17, and causes other problems even when it is supported, such as the lack of good coverage reporting because of the dynamic patching to some classes.
We should get rid of it by making our classes testable in a cleaner way.
|
https://github.com/OpenRefine/OpenRefine/issues/4384
|
https://github.com/OpenRefine/OpenRefine/pull/4454
|
6f86233afc31990cc3e30d996db44164544d7151
|
71c5f88462c1027b1de70fe6fed84b1152f487c5
| 2021-12-21T14:29:20Z |
java
| 2022-01-22T11:35:45Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,375 |
["refine"]
|
Do not print the Java command line in the refine script
|
We currently print the Java command line arguments in the logs when starting OpenRefine and that is problematic for a few reasons:
* it is ugly
* it can leak some secrets (such as Google OAuth credentials)
### To Reproduce
Steps to reproduce the behavior:
1. launch `./refine` on Unix
### Current Results
```
Using refine-dev.ini for configuration
You have 7630M of free memory.
Your current configuration is set to use 1400M of memory.
OpenRefine can run better when given more memory. Read our FAQ on how to allocate more memory here:
https://github.com/OpenRefine/OpenRefine/wiki/FAQ-Allocate-More-Memory
/usr/bin/java -cp server/classes:server/target/lib/* -Xms1400M -Xmx1400M -Drefine.memory=1400M -Drefine.max_form_content_size=1048576 -Drefine.verbosity=info -Dpython.path=main/webapp/WEB-INF/lib/jython -Dpython.cachedir=/home/user/.local/share/google/refine/cachedir -Dext.gdata.clientid=some_oauth_id -Dext.gdata.clientsecret=some_secret_key -Dext.gdata.apikey=your -Drefine.autoreload=true -Dbutterfly.autoreload=true -Drefine.webapp=main/webapp -Drefine.port=3333 -Drefine.interface=127.0.0.1 -Drefine.host=127.0.0.1 com.google.refine.Refine
Starting OpenRefine at 'http://127.0.0.1:3333/'
18:36:24.284 [ refine_server] Starting Server bound to '127.0.0.1:3333' (0ms)
18:36:24.299 [ refine_server] refine.memory size: 1400M JVM Max heap: 1468006400 (15ms)
18:36:24.346 [ refine_server] Initializing context: '/' from '/home/antonin/ORmaster/main/webapp' (47ms)
18:36:24.408 [ refine_server] Starting autoreloading scanner... (62ms)
Gtk-Message: 18:36:25.082: Failed to load module "canberra-gtk-module"
18:36:25.957 [ refine] Starting OpenRefine 3.6-SNAPSHOT [e003da8]... (1549ms)
18:36:25.957 [ refine] initializing FileProjectManager with dir (0ms)
18:36:25.957 [ refine] /home/antonin/.local/share/openrefine (0ms)
18:36:32.792 [ refine] POST /command/core/load-language (6835ms)
18:36:32.832 [ refine] GET /command/core/get-preference (40ms)
18:36:32.866 [ refine] POST /command/core/load-language (34ms)
```
### Expected Behavior
A clean log should appear.
### Versions<!-- (please complete the following information)-->
- Operating System: Debian
- Browser Version: irrelevant
- JRE or JDK Version: 11
- OpenRefine: master branch
|
https://github.com/OpenRefine/OpenRefine/issues/4375
|
https://github.com/OpenRefine/OpenRefine/pull/4376
|
573e652e53b921a18736490cff44fdcc5d180bc4
|
89437db9944a813ea107d30e7e330cadac3855ec
| 2021-12-17T17:38:45Z |
java
| 2021-12-18T11:27:31Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,367 |
["main/pom.xml", "main/src/com/google/refine/commands/auth/AuthorizeCommand.java", "main/src/com/google/refine/commands/auth/DeAuthorizeCommand.java", "main/src/com/google/refine/oauth/AuthorizationHeaderSigningStrategy.java", "main/src/com/google/refine/oauth/Credentials.java", "main/src/com/google/refine/oauth/GoogleProvider.java", "main/src/com/google/refine/oauth/OAuthUtilities.java", "main/src/com/google/refine/oauth/Provider.java", "main/webapp/modules/core/MOD-INF/controller.js", "pom.xml"]
|
Unused OAuth functionality in the main module
|
Our `main` module currently contains a `com.google.refine.oauth` package which does not seem used at all in the frontend. I think it is the remains of an older integration with Google services.
We should remove this dead code and remove our dependency to the `signpost` library, which should make OpenRefine a bit lighter.
|
https://github.com/OpenRefine/OpenRefine/issues/4367
|
https://github.com/OpenRefine/OpenRefine/pull/4368
|
10cf6a1e6e97bb77e1e04c2ce52b60540ab530ca
|
bfdc414f84ad94fae2dbc18d477478078045eb8f
| 2021-12-11T13:40:47Z |
java
| 2021-12-14T13:08:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,358 |
[".github/workflows/pull_request.yml", "appveyor.yml"]
|
Migrate Windows CI to GitHub actions
|
We currently use Appveyor to run our Windows CI. That implies additional a maintenance burden for the config file of this service.
### Proposed solution
GitHub Actions also offers Windows runners. We could use those instead.
### Alternatives considered
None
|
https://github.com/OpenRefine/OpenRefine/issues/4358
|
https://github.com/OpenRefine/OpenRefine/pull/4502
|
73ae73efafb4c12a5250ca1cdedb90b8bc8d48c3
|
c2e4d2b087606069a1a55cb2e16bef37f6374adc
| 2021-12-09T13:14:35Z |
java
| 2022-02-08T08:35:40Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,346 |
[".github/workflows/release_manager.sh", ".github/workflows/snapshot_release.yml", "README.md", "appveyor.yml", "benchmark/pom.xml", "extensions/pom.xml", "packaging/pom.xml", "pom.xml"]
|
Use Maven Central to host snapshot releases instead of a custom GitHub repository
|
We currently upload our snapshot releases to the releases section of a dedicated GitHub repository.
That works okay, but the process is a bit convoluted (it requires some scripts and a dedicated GitHub account to do the upload in the CI). Also, we want to extend this to cover not just the `master` branch, but also the `4.0` branch, and this is not so simple.
### Proposed solution
We could do like Gephi does: use the Maven Central snapshot repository, where we can upload not just jars, but also released artifacts like our `.dmg`, `.zip` and `.tar.gz`. This lets us store one snapshot per candidate version (we would be able to access the latest master snapshot and the latest 4.0 snapshot).
### Alternatives considered
We could keep the existing system put both of those snapshot releases in the same repository, but then the latest release would not always correspond to the same branch, giving unpredictable results for the users.
We could also create another dummy repository to hold the snapshot releases of 4.0, but that is a bit confusing.
### Additional context
Solution discovered at the Gephi code retreat.
|
https://github.com/OpenRefine/OpenRefine/issues/4346
|
https://github.com/OpenRefine/OpenRefine/pull/4357
|
a8d0f5597877aa0d1098ac6b1a8fd9461d91db52
|
9e2bcb5c0fdcf13b1fce9eed65fd4721e4c2af47
| 2021-12-07T13:32:57Z |
java
| 2021-12-09T13:39:54Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,333 |
["docs/docs/technical-reference/version-release-process.md", "packaging/linux.xml", "packaging/pom.xml", "packaging/windows-without-jre.xml", "pom.xml", "settings.xml"]
|
Download JRE on the fly during the packaging process
|
We currently rely on the `settings.xml` file for the developer to specify where they have downloaded Mac and Windows JREs, to package them into the `.dmg` and `.zip` packages.
Instead, we could download those JREs on the fly in the packaging process. This is [what Gephi does](https://github.com/gephi/gephi/blob/master/modules/application/pom.xml) (using an `antrun` maven goal).
The advantage would be that the developer does not have to care about this step (simplifying our release process greatly).
That does not solve the fact that the JRE URLs must still be regularly updated to make sure we are bundling a fresh JRE at each release.
|
https://github.com/OpenRefine/OpenRefine/issues/4333
|
https://github.com/OpenRefine/OpenRefine/pull/4505
|
c2e4d2b087606069a1a55cb2e16bef37f6374adc
|
6cd4fb0c772773a49dcd70c0db288b73b25104bc
| 2021-12-01T10:34:54Z |
java
| 2022-02-08T15:14:49Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,324 |
["extensions/wikidata/module/scripts/dialogs/wikibase-dialog.js"]
|
Lack of descriptive message when adding an incorrect schema manifest
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
### To Reproduce
Steps to reproduce the behavior:
1. First, add access the menu in the top right corner 'Extensions: Wikidata' -> 'Select Wikibase instance' -> 'Add Wikibase'
2. Then, paste/write your manifest containing syntax mistakes (see screenshot)
3. Finally, select 'Add Wikibase' in the bottom right corner of the window
### Current Results
<!-- What results occurred or were shown. -->
The error "Invalid Wikibase manifest." appears in red letters.
### Expected Behavior
<!-- A clear and concise description of what you expected to happen or to show. -->
A more descriptive error would help narrow down and fix the mistakes.
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: Ubuntu 18.04
- Browser Version: Chrome 95
- JRE or JDK Version: jdk 11
- OpenRefine: 3.6
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
Extract:
{
"version": "1.0",
"mediawiki": {
"name": "Wikimedia Commons",
"root": "https://commons.wikimedia.org/wiki",
"main_page": "https://commons.wikimedia.org/wiki/Main_Page",
"api": "https://commons.wikimedia.org/w/api.php"
},
//..
"wikibase": {
"site_iri": "https://commons.wikimedia.org/entity",
"maxlag": 5,
"properties": {
"instance_of": "P31",
"subclass_of": "P279",
}
}
### Additional context
<!-- Add any other context about the problem here. -->
n/a
|
https://github.com/OpenRefine/OpenRefine/issues/4324
|
https://github.com/OpenRefine/OpenRefine/pull/4341
|
f4833beb915065f1db1495ef9ce1f25d73bbccfb
|
d2a66cc97bdd1a94e3375579b0f1f431085e49b2
| 2021-11-26T12:21:32Z |
java
| 2021-12-06T14:45:37Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,314 |
["main/pom.xml", "server/pom.xml"]
|
Unused dependency from OpenRefine to rhino
|
In `main/pom.xml` and `server/pom.xml` it is declared that OpenRefine depends on Rhino, but this is not directly the case: OpenRefine should only depend on Rhino through Butterfly, our web framework.
The command `mvn dependency:analyze` reports a few other unused dependencies in the project which could be worth investigating (it is possible that some of them are false positives).
```
Used undeclared dependencies found:
com.squareup.okhttp3:okhttp:jar:4.9.2:test
org.powermock:powermock-core:jar:2.0.9:test
log4j:log4j:jar:1.2.17:compile
xtc:rats-runtime:jar:1.15.0:compile
commons-lang:commons-lang:jar:2.6:compile
de.fau.cs.osr.ptk:ptk-common:jar:3.0.8:compile
org.mockito:mockito-core:jar:3.3.3:test
org.powermock:powermock-module-testng-common:jar:2.0.9:test
com.squareup.okio:okio:jar:2.8.0:test
org.apache.velocity:velocity:jar:1.6.3:compile
com.fasterxml.jackson.core:jackson-core:jar:2.13.0:compile
org.apache.httpcomponents.core5:httpcore5:jar:5.1.2:compile
Unused declared dependencies found:
org.mozilla:rhino-runtime:jar:1.7.13:compile
org.slf4j:slf4j-log4j12:jar:1.7.32:compile
velocity:velocity:jar:1.5:compile
org.apache.httpcomponents:httpclient:jar:4.5.13:compile
joda-time:joda-time:jar:2.10.13:compile
org.apache.jena:jena-arq:jar:4.2.0:compile
org.apache.jena:jena-base:jar:4.2.0:compile
org.apache.jena:jena-cmds:jar:4.2.0:compile
com.metaweb:lessen:jar:1.0:compile
org.eclipse.jetty:jetty-servlets:jar:9.4.41.v20210516:compile
org.powermock:powermock-module-testng:jar:2.0.9:test
Non-test scoped test only dependencies found:
com.fasterxml.jackson.core:jackson-databind:jar:2.13.0:compile
com.google.guava:guava:jar:31.0.1-jre:compile
commons-collections:commons-collections:jar:3.2.2:compile
org.apache.poi:poi-ooxml:jar:5.1.0:compile
org.apache.httpcomponents:httpcore:jar:4.4.14:compile
commons-fileupload:commons-fileupload:jar:1.4:compile
org.jsoup:jsoup:jar:1.14.2:compile
```
|
https://github.com/OpenRefine/OpenRefine/issues/4314
|
https://github.com/OpenRefine/OpenRefine/pull/4315
|
3ad989e1d9035e8c0615137aa7037c1e7dfa1e56
|
fb54c7c00164ba973ed4b49954e0e63328912c82
| 2021-11-20T16:43:36Z |
java
| 2021-11-21T20:03:30Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,304 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/reconciliation/recon-dialog.html", "main/webapp/modules/core/scripts/reconciliation/recon-dialog.js", "main/webapp/modules/core/styles/reconciliation/recon-dialog.less"]
|
Provide a link to an overview of existing/active reconciliation services in the reconciliation dialog window
|
<!-- Please provide a clear and concise description of your problem or unsatisfied needs. Ex. I'm always frustrated when [...] or, It would be easier if OpenRefine did [...]. This comment can be deleted, if desired, but it will be hidden in your final submission. Please make sure that your new text is outside the enclosing angle brackets. -->
Especially for users who are new to the variety of reconciliation services that are out there, it's not obvious to discover / find a list of them. Knowing which ones exist and can be used can be quite inspiring and helpful.
### Proposed solution
<!-- If you have a proposal for how this need could be met, please provide a clear and concise description of what you want to happen. -->
In a recent [user interview](https://phabricator.wikimedia.org/T294939), one OpenRefine user mentioned that they would find it very helpful if OpenRefine's user interface itself - possibly the reconciliation dialog window - would contain (a pointer to) a list of existing / active reconciliation services.
Perhaps, at first, this could be a simple link to https://reconciliation-api.github.io/testbench/
### Alternatives considered
<!-- If there alternative solutions that you have considered or think should be considered, please list them here -->
OpenRefine's [manual also collects various pointers](https://docs.openrefine.org/manual/reconciling) to places where one can find lists of reconciliation services. But in order to get there, the user first needs to be aware of the manual itself, find this specific page, and then click through to the various options.
### Additional context
This suggestion came up during a [user interview for Wikimedia Commons batch upload functionalities](https://phabricator.wikimedia.org/T294939).
|
https://github.com/OpenRefine/OpenRefine/issues/4304
|
https://github.com/OpenRefine/OpenRefine/pull/4765
|
a1e1ac3e21570d08fc4ff941374cd6ed95ce28da
|
01916e51b9a2fa22518f67e2de7f9f3462b34a41
| 2021-11-17T16:33:49Z |
java
| 2022-05-18T13:01:21Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,299 |
["main/tests/cypress/cypress/integration/create-project/preview_project.spec.js", "main/webapp/modules/core/scripts/index/parser-interfaces/separator-based-parser-ui.html"]
|
CSV importer: confusing behaviour of checkboxes
|
In the configuration options for the CSV/TSV importer, two checkboxes are linked as if one of them had to be checked.
This is a bad pattern: if those checkboxes are really meant to be grouped, then they should be radio buttons and be positioned next to each other.
### To Reproduce
Steps to reproduce the behavior:
1. First, open a CSV/TSV file
2. Then, click on the "Parse next 1 lines as column headers"
### Current Results
### Expected Behavior
In this case I was actually trying to get both checkboxes to be not checked (so that my project gets created with `Column 1`, `Column 2`… as column headers). I can achieve this by keeping the `Parse next…` checkbox on and setting the number of lines to 0 but that is a bit counter-intuitive.
### Versions<!-- (please complete the following information)-->
- Operating System: Debian
- Browser Version: Firefox
- JRE or JDK Version: 11
- OpenRefine: master (3.6 SNAPSHOT)
|
https://github.com/OpenRefine/OpenRefine/issues/4299
|
https://github.com/OpenRefine/OpenRefine/pull/4528
|
b1d99df3296eff29bb9b4eb7083680acd1f46b57
|
40cfe2f2b5fb8cdbc9a2a71af04cfc145c9d3943
| 2021-11-15T09:10:06Z |
java
| 2022-02-15T09:17:20Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,296 |
["main/pom.xml"]
|
Eclipse reports modular compilation issues
|
Now that we have bumped the minimal Java version from 8 to 11, Eclipse starts reporting new issues which are linked to [Java modularity](https://www.baeldung.com/java-9-modularity).
### To Reproduce
Steps to reproduce the behavior:
1. First, set up OpenRefine in Eclipse
2. Observe this compilation failure at line `import javax.xml.stream.XMLInputFactory;` in `XmlImporter.java`: "The package javax.xml.stream is accessible from more than one module: <unnamed>, java.xml"
### Expected Behavior
No compilation errors.
### Versions<!-- (please complete the following information)-->
- Operating System: Debian
- JRE or JDK Version: 11
- OpenRefine: master
|
https://github.com/OpenRefine/OpenRefine/issues/4296
|
https://github.com/OpenRefine/OpenRefine/pull/4297
|
21fc4375bdb0217782a5443696559b73ad9ee333
|
b0432e53972381384422100a9d85e2857d87d592
| 2021-11-13T12:18:04Z |
java
| 2021-11-16T20:38:41Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,294 |
["main/src/com/google/refine/util/ParsingUtilities.java"]
|
Java test suite fails locally in some timezones due to Daylight Saving Time differences
|
Running `./refine test` on the master branch currently fails for me.
This is due to the fact that our date parsing code translates java `Date` objects to Java 8 `OffsetDateTime` in an incorrect way.
### To Reproduce
Steps to reproduce the behavior:
1. Add `-Duser.timezone=CET` to your Java test settings in `pom.xml` (`<argLine>@{surefireArgs} -Dfile.encoding=cp1252 -Duser.timezone=CET</argLine>`)
1. Run `./refine test`
### Current Results
Test failures due to date parsing in importers.
### Expected Behavior
No test failures.
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: Debian
- JRE or JDK Version: 11
- OpenRefine: master branch
|
https://github.com/OpenRefine/OpenRefine/issues/4294
|
https://github.com/OpenRefine/OpenRefine/pull/4295
|
c92d745af3fc6694f1f991e16101bc70d5fabce2
|
3f5a4bd900028630f2b89b4ef94eaef74b044de1
| 2021-11-13T11:36:16Z |
java
| 2021-11-14T09:29:46Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,287 |
["docs/docs/manual/wikibase/configuration.md"]
|
Reconciling against a Wikibase instance with federated properties (from Wikidata) fails at the point of value entry
|
When connecting OpenRefine to a private Wikibase instance on WBStack which includes federated properties, reconciliation and property selection works fine, but when you need to enter values in the schema, the value entry field does not appear.
### To Reproduce
Steps to reproduce the behavior:
1. First, connect to this reconciliation endpoint: https://labs.tib.eu/reconcile/lodwgfedereated/ with this manifest: https://labs.tib.eu/reconcile/lodwgfedereated/manifest.json
2. Then, reconcile some items (feel free to add test items, this is a blank test wiki, no real data shall be harmed).
3. Finally, try to build a schema.
### Current Results
It is not possible to enter values in the statements.
### Expected Behavior
It should be possible to complete schema built just like with other Wiki instances.
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Firefox 91
- JRE or JDK Version: whatever was packages with the latest release
- OpenRefine: OpenRefine 3.5
|
https://github.com/OpenRefine/OpenRefine/issues/4287
|
https://github.com/OpenRefine/OpenRefine/pull/4572
|
f1b2a6342098df3de70197564e62eb13d09f0dc8
|
373986ebb569216947029cdac927567efbbca0da
| 2021-11-10T12:17:19Z |
java
| 2022-02-26T15:22:13Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,282 |
["main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/dialogs/column-reordering-dialog.html", "main/webapp/modules/core/scripts/dialogs/column-reordering-dialog.js"]
|
Allow multiple column selection in "Re-order / Remove Columns" modal
|
As mentioned on #3289 , the "Re-order / Remove Columns" modal (accessed from the All > Edit Columns menu) could benefit from enhancement to help with datasets that have a large number of columns that one might not be interested in. In particular, I'd love to see a way to move all of the column names to the "Drop columns here to remove" area on the right so that one can then drag back only the columns one wants. Ideally this would be by allowing selection of multiple column names from the left (including a select-all with usual keyboard shortcuts, like cmd-A or ctrl-A), but if that is too complicated then perhaps just a button to "Remove all".
### Proposed solution
Allow the column names on the left (the "Drag columns to re-order" section) to be bulk-selected before the drag action. This would require some form of highlighting in order to show which columns are selected. The selection mechanism could be shift-click for a range from the first click, and ctrl-click (cmd-click on Mac) for selecting additional columns, as is normal for applications which allow selection of multiple rows (such as file browsers, iTunes, etc). A Ctrl-A (cmd-A on Mac) could select all columns, though this cold be ambiguous if we allowed selection from both the 'reorder' and 'delete' sides.
### Alternatives considered
A simple "Remove All" button so that one drags the desired column names back from the right rather than individually deleting columns from the left. In fact this could be included in the proposed solution if there is no good way to unambiguously select-all with a keyboard shortcut.
|
https://github.com/OpenRefine/OpenRefine/issues/4282
|
https://github.com/OpenRefine/OpenRefine/pull/4557
|
c6fddf1bdc1c91101a8ebc3629e942e80a4ff0c3
|
d8c955c2b86be5c297955724b4bdff4dd55aac1b
| 2021-11-08T10:18:54Z |
java
| 2022-02-23T20:36:10Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,271 |
["main/webapp/modules/core/scripts/dialogs/custom-tabular-exporter-dialog.js"]
|
Change columns order in the Custom Tabular Exporter doesn't work
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
### To Reproduce
Steps to reproduce the behavior:
1. First select "Custom tabular exporter" in Export menu
2. Then, in the first tab "Content", change columns order using drag n drop
3. Finally, in the second tab "Download", click on "Download" button without changing any other option.
### Current Results
<!-- What results occurred or were shown. -->
1. The output file contains the original columns order.
2. Looking at the "Option Code" after drag and drop, no change is apply.
### Expected Behavior
<!-- A clear and concise description of what you expected to happen or to show. -->
1. The JSON code inside the "Option Code" tab must be updated in real-time when user changes columns order in the first tab.
2. The output file must contains columns in the right order.
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
Column "number" moved to 2nd and last position
No change inside the JSON code
### Versions<!-- (please complete the following information)-->
- Operating System: <!-- e.g. iOS, Windows 10, Linux, Ubuntu 18.04 --> Windows 10
- Browser Version: <!-- e.g. Chrome 19, Firefox 61, Safari, NOTE: OpenRefine does not support IE but works OK in most cases --> Chrome 95.0.4638.69 (Official Build) (64 bit)
- JRE or JDK Version: <!-- output of "java -version" e.g. JRE 1.8.0_181 --> Built-in
- OpenRefine: <!-- e.g. OpenRefine 3.0 Beta] --> 3.4.1
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
<!-- Add any other context about the problem here. -->
Same thing happens when you past and apply a JSON configuration with a different order of columns: actually the order does not change.
|
https://github.com/OpenRefine/OpenRefine/issues/4271
|
https://github.com/OpenRefine/OpenRefine/pull/4534
|
4f75902c89a8e3fe790fa36318d05a9b97ca3873
|
602c61054d6ad0ebad40bdc670b7c0ef1c804ec9
| 2021-11-04T18:32:58Z |
java
| 2022-02-16T09:01:37Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,268 |
["extensions/wikidata/src/org/openrefine/wikidata/editing/EditBatchProcessor.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/editing/EditBatchProcessorTest.java"]
|
Make Wikibase extension compatible with other entity types than Items
|
Wikibase stores data in "entities". There are various types of entities: items, properties, lexemes, mediainfo entities…
Currently, the Wikibase extension is only able to edit items. However, the functionality we have developed in the Wikibase extension could be useful in other entity types as well.
### Proposed solution
Assume that a reconciliation service is returning entities which are not items (for instance, the Commons service, which returns MediaInfo items). We want to be able to edit those via the Wikibase extension in the same way that we can currently edit items.
In this first version of the feature, nothing in the user interface would change. We would simply change the Java backend so that all the classes which are involved in the Wikidata editing no longer refer to:
* `ItemIdValue` (for the Wikibase item id): that would be replaced by `EntityIdValue`
* `ItemDocument` (for the content of the Wikibase item): that would be replaced by `TermedStatementDocument`.
Once that change is made, it should be possible to edit MediaInfo entities in the same way that items can currently be edited. If one develops a reconciliation service for Wikibase propreties, those could be edited too.
However, in this state it will **not yet** be possible to add statements with reconciled items from Wikidata as values. For instance, the following workflow will not be possible yet:
* Reconcile files to MediaInfo entities
* Extract metadata from the wikitext (via data extension)
* Reconcile some of the extracted metadata to Wikidata
* Add this metadata back to Commons by adding the reconciled information in a Commons schema (for instance, depicts statements)
But it will be possible to add statements whose datatype does not require reconciliation (for instance, geographical coordinates)
### Additional context
Part of the Commons integration project. First step of #2144.
|
https://github.com/OpenRefine/OpenRefine/issues/4268
|
https://github.com/OpenRefine/OpenRefine/pull/4416
|
5810f0392e3debda0c6e5098f321bf96d8425f99
|
f3bf92a236de1913653a490beca5afc40849c775
| 2021-11-04T14:52:49Z |
java
| 2022-01-12T18:17:53Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,265 |
["refine", "refine.bat"]
|
Memory setting on Linux CLI is broken
|
The parameter to define the memory used by OpenRefine is broken in the `./refine` script that we use on Linux.
### To Reproduce
Steps to reproduce the behavior:
1. Run `./refine -m 2048M`
### Current Results
`./refine: line 852: [: 2048M: integer expression expected`
### Expected Behavior
No error, the memory settings are properly set.
### Versions<!-- (please complete the following information)-->
- Operating System: Debian
- Browser Version: Irrelevant
- JRE or JDK Version: 11
- OpenRefine: 3.5-beta2
### Additional context
Brought up here: https://groups.google.com/g/openrefine/c/2nfrI8eteCU
|
https://github.com/OpenRefine/OpenRefine/issues/4265
|
https://github.com/OpenRefine/OpenRefine/pull/4266
|
782ebf1a0347e190105f93e1837edd491caaf653
|
41c7b70e55627d6c5699fbda71fbcd67963dae55
| 2021-11-04T07:59:14Z |
java
| 2021-11-07T08:59:08Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,243 |
["main/tests/cypress/cypress/integration/project/grid/column/text_filter.spec.js", "main/webapp/modules/core/scripts/facets/text-search-facet.js"]
|
Label for "regular expression" checkbox of text filter not deduplicated
|
The labels of the "regular expression" checkboxes are not properly linked to the corresponding checkbox.
### To Reproduce
Steps to reproduce the behavior:
1. First, open a project and create two text filters
2. Then, click on the label (not the checkbox) "regular expression" in the second text facet
### Current Results
### Expected Behavior
Clicking on the label should tick/untick the right checkbox.
### Versions<!-- (please complete the following information)-->
- Operating System: Debian
- Browser Version: Firefox 78 ESR
- JRE or JDK Version: 11
- OpenRefine: 3.5-beta1
|
https://github.com/OpenRefine/OpenRefine/issues/4243
|
https://github.com/OpenRefine/OpenRefine/pull/4257
|
ddad7b503dc691abc054c8111a2b1290ec162d98
|
77d958c9d417965428bc7dcd9d133184e2a554dc
| 2021-10-23T13:39:31Z |
java
| 2021-11-24T12:44:53Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,242 |
["extensions/wikidata/src/org/openrefine/wikidata/editing/EditBatchProcessor.java"]
|
Wikibase upload only creates first new item in batch
|
Only the first item of a batch of new items is created when using the "Perform edits on Wikibase" operation.
### To Reproduce
Steps to reproduce the behavior:
1. First, create a project with a schema which creates multiple new items
2. Upload the batch to Wikibase
### Current Results
Observe that only the first item of the batch is created
### Expected Behavior
All items are created.
### Versions<!-- (please complete the following information)-->
- Operating System: Debian
- Browser Version: irrelevant
- JRE or JDK Version: 11
- OpenRefine: 3.5-beta1
|
https://github.com/OpenRefine/OpenRefine/issues/4242
|
https://github.com/OpenRefine/OpenRefine/pull/4244
|
30a0f6643dc6c8802940e90b6b68c47fae7d89e8
|
40398e1192dfdf8b1a8dde12e0ee016b395bb828
| 2021-10-23T10:48:56Z |
java
| 2021-10-23T17:33:43Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,233 |
["main/webapp/modules/core/scripts/views/data-table/menu-facets.js"]
|
Duplicates facet does not escape its column name, resulting in an invalid GREL expression
|
The code that generates the GREL expression for the Duplicates facet does not escape the name of the selected column.
If this name contains a single quote character, this results in an invalid GREL expression, hence the facet cannot be used as such.
### To Reproduce
Steps to reproduce the behavior:
1. First, import the following CSV file:
```
Jane's column,Jack's column
foo,bar
hey,ho
hey,bar
```
2. Then, create a Duplicates facet on any of the column (using the column menu)
### Current Results
The facet's GREL expression is invalid: `facetCount(value, 'value', 'Jane's column') > 1`.
### Expected Behavior
The GREL expression should be valid, for instance `facetCount(value, 'value', 'Jane\'s column') > 1` would work.
### Versions<!-- (please complete the following information)-->
- Operating System: irrelevant
- Browser Version: irrelevant
- JRE or JDK Version: irrelevant
- OpenRefine: master
### Additional context
Brought up on our mailing list: https://groups.google.com/g/openrefine/c/2ic5F0YGcbk
|
https://github.com/OpenRefine/OpenRefine/issues/4233
|
https://github.com/OpenRefine/OpenRefine/pull/4538
|
19c8add2af300d8761df316cbdee64293d6f7dab
|
fa8322779b85c0540747aa9e51aa04f803b0940c
| 2021-10-21T15:51:50Z |
java
| 2022-02-18T16:35:18Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,229 |
["packaging/desktop/openrefine.metainfo.xml", "packaging/desktop/openrefine.png", "packaging/desktop/org.openrefine.openrefine.desktop"]
|
openrefine: add desktop file and appstream metadata for Linux distributions
|
Hello,
as part of the effort to package OpenRefine for Debian I have created a desktop file and appstream metadata for better desktop integration in Linux distributions.
"AppStream is a collaborative effort for enhancing the way we interact with the software repositories provided by the distribution by standardizing sets of additional metadata. "
https://freedesktop.org/software/appstream/docs/chap-Quickstart.html
In order to make OpenRefine more visible on the user's desktop, a desktop file provides a short cut in an application menu (or e.g. Gnome shell) and you just have to click on it to start the application. You can also add keywords like rdf, csv, marc, odf, etc. to list openrefine in search results. Even if you don't know the exact program name but the file formats the program should be presented to users.
The appstream metainfo file adds OpenRefine to software centers, provides a short description of the main functionalities and screenshots, so users can more easily decide whether they would like to install a certain application or not.
I'm attaching preliminary versions of these files and an icon with 128x128 pixel resolution. The screenshots are currently missing. Ideally someone would upload them to openrefine.org and then point the links in the appstream metainfo file to them. When OpenRefine has been accepted into Debian I will update this bug report and add some screenshots as well. I suggest to add these files under the packaging directory. Then other distributions could use them as well.
[openrefine_desktop_appstream.zip](https://github.com/OpenRefine/OpenRefine/files/7380883/openrefine_desktop_appstream.zip)
|
https://github.com/OpenRefine/OpenRefine/issues/4229
|
https://github.com/OpenRefine/OpenRefine/pull/5436
|
d65b6da5d5287897bdd0872da4bf8e8af618f919
|
71185fea7693dd04f52840f8273008620f18300f
| 2021-10-20T11:50:27Z |
java
| 2022-11-19T21:36:56Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,228 |
["pom.xml"]
|
simile-vicino: depends on ancient commons-compress library
|
Hello,
as part of the effort to package OpenRefine for Debian I discovered that simile-vicino depends on an ancient commons-compress artifact. I couldn't open an issue there, so I hope it makes sense to file a bug report here.
<dependency>
<groupId>commons-compress</groupId>
<artifactId>commons-compress</artifactId>
<version>20050911</version>
</dependency>
The problem is that Debian and other Linux distributions try to ship only one library version to reduce code duplication and possible security vulnerabilities in the distribution. The latest commons-compress version in Debian does not ship the required CBZip2OutputStream class in src/edu/mit/simile/vicino/distances/BZip2Distance.java anymore.
Interestingly at some point in time the Ant project imported the exact same code, so it would be possible to depend on Ant and still be able to compile vicino.
Of course depending on another Java build system makes no sense. I see two solutions. Either we could replace the CBZip2OutputStream class / functionality or import the necessary code into vicino. At the moment I did the latter in Debian. zip file is attched.
[CBZip2OutputStream.zip](https://github.com/OpenRefine/OpenRefine/files/7380766/CBZip2OutputStream.zip)
|
https://github.com/OpenRefine/OpenRefine/issues/4228
|
https://github.com/OpenRefine/OpenRefine/pull/6417
|
f4878804960162ba6145941bfbe0d14e60133d9b
|
ebbcba11e35e99552ee49bbf12fca4e6ff0fd73a
| 2021-10-20T11:32:05Z |
java
| 2024-03-05T08:04:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,226 |
["extensions/wikidata/src/org/openrefine/wikidata/editing/EditBatchProcessor.java"]
|
Useless waiting time when creating new Wikibase items from OpenRefine
|
When uploading a batch of new items to Wikibase from OpenRefine, we have a long initial waiting time which is a spurious exponential backoff on an operation that does not fetch any items.
### To Reproduce
Steps to reproduce the behavior:
1. First, create a project with a Wikibase schema which does not edit any existing Wikibase items, only creates new ones
2. Then, upload the project to Wikibase
### Current Results
<!-- What results occurred or were shown. -->
Observe the long waiting time before any edit is made (0% progress)
### Expected Behavior
<!-- A clear and concise description of what you expected to happen or to show. -->
Immediate creation of new items.
### Versions<!-- (please complete the following information)-->
- Operating System: Linux
- Browser Version: Firefox
- JRE or JDK Version: 11
- OpenRefine: master (3.6-SNAPSHOT)
|
https://github.com/OpenRefine/OpenRefine/issues/4226
|
https://github.com/OpenRefine/OpenRefine/pull/4227
|
235b5957e22c73328e9f84d6fac44a9cb92318f5
|
6372f2d3827a3cd662302edb81c5476b1b5e3850
| 2021-10-19T19:58:16Z |
java
| 2021-10-22T06:52:28Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,224 |
["main/webapp/modules/core/scripts/reconciliation/standard-service-panel.js"]
|
Reconciliation UI only shows one of the available default types
|
The reconciliation UI does not always show all the default types announced by reconciliation services.
### To Reproduce
Steps to reproduce the behavior:
1. First, add the reconciliation service `https://reconciliation.brickschema.org/reconcile`
2. Then, try to reconcile any column
### Current Results
The dialog only shows the `BrickClass` type whereas the manifest of the service offers two other types.
### Expected Behavior
All three default types should be offered.
### Screenshots
### Versions
- Operating System: Linux
- Browser Version: Firefox
- JRE or JDK Version: 11
- OpenRefine: master
### Additional context
Brought up in the W3C Entity Reconciliation CG.
|
https://github.com/OpenRefine/OpenRefine/issues/4224
|
https://github.com/OpenRefine/OpenRefine/pull/5906
|
1c948620737909fda53cf249520f4cefdf5dd161
|
d7d3a57b438ef1820f876882b9bec07495969566
| 2021-10-19T14:39:05Z |
java
| 2023-06-08T09:30:48Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,207 |
["refine"]
|
Maven download link from refine script does not work
|
### To Reproduce
Running `./refine` fails because it cannot download the maven dependency. The version 3.6.3 is not available for download anymore and the mirror doesn't resolve IP.
|
https://github.com/OpenRefine/OpenRefine/issues/4207
|
https://github.com/OpenRefine/OpenRefine/pull/4208
|
5f73a69cd93a1d77e7831dda7cea56e87ebb47f5
|
33fba98d6a3304d305bc5635012aa92420489523
| 2021-10-12T08:44:50Z |
java
| 2021-10-12T08:54:49Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,205 |
["docs/docs/manual/wikibase/configuration.md", "extensions/wikidata/module/scripts/wikibase-manager.js", "extensions/wikidata/module/scripts/wikibase-manifest-schema-v1.js", "extensions/wikidata/module/scripts/wikidata-manifest-v1.0.js", "extensions/wikidata/tests/data/manifest/wikidata-manifest-v1.0-missing-property-constraint-pid.json", "extensions/wikidata/tests/data/manifest/wikidata-manifest-v1.0-without-constraints.json", "extensions/wikidata/tests/data/manifest/wikidata-manifest-v1.0.json", "extensions/wikidata/tests/src/org/openrefine/wikidata/manifests/ManifestV1Test.java", "main/src/com/google/refine/importers/WikitextImporter.java", "main/webapp/modules/core/scripts/reconciliation/recon-manager.js"]
|
Wikidata reconciliation endpoint is unreliable
|
Reconciliating names doesn't work well using the default https://wdreconcile.toolforge.org endpoint. Indeed when you visit that page, it recommends you use https://wikidata.reconci.link instead. Changing the endpoint solves the issue.
More information in this thread: https://groups.google.com/g/openrefine/c/MZsjyYNaS1Q?pli=1
### To Reproduce
Reconciling "Guillermo Lasso" against Q5 (human) suggest the best result is https://www.wikidata.org/wiki/Q106481416 which contains the name but is not a human.
|
https://github.com/OpenRefine/OpenRefine/issues/4205
|
https://github.com/OpenRefine/OpenRefine/pull/4206
|
94ffe4811f90a6afba3843129a460286b1efee5f
|
3bca46329c955cba358c8726ab55a61ba5a7452e
| 2021-10-12T08:40:06Z |
java
| 2021-10-20T12:45:57Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,198 |
[".github/workflows/pull_request.yml"]
|
Ignore Cypress tests for translations updates
|
It doesn't really make sense to trigger cypress tests for translations, it just trigger CI builds for nothing
Do we also want to disable server tests ? Except if translations can break the build ?
@thadguidry @wetneb any opinion ?
|
https://github.com/OpenRefine/OpenRefine/issues/4198
|
https://github.com/OpenRefine/OpenRefine/pull/4961
|
5e698f2cd62f0f52a445eed22ee3ce615f8c9b66
|
e976d2005fc87e073e958d3989110b4fa5dce810
| 2021-10-06T13:49:44Z |
java
| 2022-06-15T09:34:57Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,194 |
["main/src/com/google/refine/expr/functions/Jsonize.java", "main/tests/server/src/com/google/refine/expr/functions/JsonizeTests.java", "main/tests/server/src/com/google/refine/grel/FunctionTests.java"]
|
toString() and parseJson() are not compatible with JSON spec
|
Per JSON Spec...
> A value can be a string in double quotes, or a number, or true or false or null, or an object or an array. These structures can be nested.
But we throw away (or don't handle properly for some reason) any double quotes in a JSON array when we convert `toString()`.
- Double Quotes retained correctly when encapsulated as expected by single quotes
```
'[ "dentsu mcgarrybowen Regents Place 10 Triton Street", "London NW1 3BF", "+44 (0)20 3640 5592", "For new business enquiries please contact our Marketing and New Business Director, Oli Richards", "For everything else please email us", "© 2020 mb - uk", "22 Torrington Place London, WC1E 7HJ 0203 640 5592" ]'.toString()
```
### To Reproduce
Import the below provided Dataset `test.openrefine.tar.gz` project file as a test case.
Steps to reproduce the behavior:
1. Try to Add a column based on FETCH column with the following GREL expression to convert the parsed out array to a String:
```
forEach(value.parseHtml().select("p"),v,v.htmlText()).toString()
```
2. Notice that in Preview and after clicking OK in the column that double quotes were **not retained** and useful structure that was needed by retaining the quotes is now lost completely.
### Current Results
### Expected Behavior
I would expect this String value representation with Double Quotes retained for JSON structure to be stored in the cell as such:
`[ "dentsu mcgarrybowen Regents Place 10 Triton Street", "London NW1 3BF", "+44 (0)20 3640 5592", "For new business enquiries please contact our Marketing and New Business Director, Oli Richards", "For everything else please email us", "© 2020 mb - uk", "22 Torrington Place London, WC1E 7HJ 0203 640 5592" ]`
### Screenshots
Good JSON array structure I want to keep as a String and push into a cell
But the type is an `array`
Shown below we see `toString()` mangles and loses that good structure where by default it should keep it. If necessary perhaps a parameter option added IF we wanted to throw away that structure or manipulate the formatting of the String ( #816 concerns numbers not JSON arrays as strings.)
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Firefox latest
- JRE or JDK Version: JDK15
- OpenRefine: OpenRefine 3.5 Beta1
### Datasets
[test.openrefine.tar.gz](https://github.com/OpenRefine/OpenRefine/files/7271903/test.openrefine.tar.gz)
### Additional context
Looking at the array possibilities on https://www.json.org/json-en.html
I think our test cases could also probably be expanded and improved for not only `parseJson()` but also `toString()` to include JSON values that are **string in double quotes**, along with **another array**, and not only **number, true, false, null** as we currently test.
|
https://github.com/OpenRefine/OpenRefine/issues/4194
|
https://github.com/OpenRefine/OpenRefine/pull/4307
|
a1c190a5dcc7a9ce8acb211bf48c3fa1fc5f053a
|
f4833beb915065f1db1495ef9ce1f25d73bbccfb
| 2021-10-02T17:47:24Z |
java
| 2021-12-05T07:41:56Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,193 |
["main/src/com/google/refine/expr/functions/html/InnerHtml.java", "main/src/com/google/refine/expr/functions/html/ParseHtml.java", "main/src/com/google/refine/expr/functions/xml/ParseXml.java", "main/src/com/google/refine/expr/functions/xml/WholeText.java", "main/src/com/google/refine/expr/functions/xml/XmlText.java", "main/tests/server/src/com/google/refine/expr/EvalErrorTests.java"]
|
Improve EvalError output in Expression preview for HTML/XML GREL functions
|
We could improve the Error: output to a user shown in the expression preview to tell them what the Type() is for a parameter being passed that is not compatible with the parameter type being expected.
### Proposed solution
On our various HTML/XML GREL functions (htmlText(), wholeText(), ownText(), etc.) add the `new Type().call(bindings, args)` to the EvalError and rephrase the error text as needed slightly to be more friendly to users.
Example:
```java
return new EvalError(ControlFunctionRegistry.getFunctionName(this) + "() cannot work with this '"
+ new Type().call(bindings, args) + "'"
+ " but instead needs a jsoup DataNode from style, script tags, etc. to work with."
+ " See https://jsoup.org/apidocs/org/jsoup/nodes/Element.html#data()"
+ " For arrays, you might select an index or loop over them with forEach()."
+ " dataNodes() is currently not implemented.");
```
### Alternatives considered
<!-- If there alternative solutions that you have considered or think should be considered, please list them here -->
### Additional context
<!-- Add any other context or screenshots about the feature request here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/4193
|
https://github.com/OpenRefine/OpenRefine/pull/4255
|
a983781bf79e74ec4063aa699b8ed39f2a4dd347
|
debc4e65c874ad256b6ff63143658d80016129b3
| 2021-10-02T17:15:13Z |
java
| 2021-11-09T18:13:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,189 |
["main/src/com/google/refine/expr/functions/xml/ScriptText.java", "main/src/com/google/refine/grel/ControlFunctionRegistry.java", "main/tests/server/src/com/google/refine/expr/functions/html/ParseHtmlTests.java"]
|
Add new GREL jsoup function "data()" to support HTML <script> and <style> tag data extraction
|
Data does not only exist in HTML or XML **TextNode**'s but also in `<script>` and `<style>` nodes.
Useful JSON data is also sometimes contained in `<script type="application/json">` as well as JSON-LD data in `<script type="application/ld+json">`
Jsoup provides a different method `data()` for working with Elements that are a DataNode for handling the contents of style, script tags etc, where contents of those tags do not show with **TextNode**'s `text()` - our GREL `htmlText()`
### Proposed solution
1. Add support for jsoup's `data()` functionality for **Element**'s as defined at https://jsoup.org/apidocs/org/jsoup/nodes/Element.html#data()
3. `data()` will operate similarly to our existing `htmlText()` for **TextNode**'s but instead work with [DataNodes](https://jsoup.org/apidocs/org/jsoup/nodes/DataNode.html)
### Alternatives considered
Manually parsing based on root element and splitting the entire document as a single string
### Additional context
1. Example tests of `data()` are [here](https://github.com/jhy/jsoup/blob/master/src/test/java/org/jsoup/nodes/ElementTest.java#L38).
2. `:containsData()` is already available currently from within our GREL `select()` function.
3. `parseJson()` should be immediately applicable to parse the JSON data string.
Ex. `value.parseHtml().select("script")[2].data().parseJson().sitecore.context`
|
https://github.com/OpenRefine/OpenRefine/issues/4189
|
https://github.com/OpenRefine/OpenRefine/pull/4192
|
d0ff40ce60526f03a3b02da72a8b6c8b99001648
|
85189ecd37cb9bed18c7c9a848c2ebec4219acf3
| 2021-09-30T23:49:10Z |
java
| 2022-01-19T08:25:28Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,181 |
["main/src/com/google/refine/expr/functions/xml/Parent.java", "main/src/com/google/refine/grel/ControlFunctionRegistry.java", "main/tests/server/src/com/google/refine/expr/functions/html/ParseHtmlTests.java"]
|
Add new GREL function to support Jsoup parent() function to complement our select()
|
There is no easy way to navigate up the parse tree provided by jsoup selector syntax. We currently can navigate down very easily with Jsoup's selector syntax `value.parseHtml().select("div > p")` and also `value.parseHtml().select("div:has(@) ~ div")` but
this does not directly allow DOM traversal itself. However, Jsoup conveniently provides DOM traversal for finding a https://jsoup.org/apidocs/org/jsoup/nodes/Element.html#parent()
which mimics the behavior from BeautifulSoup's https://www.crummy.com/software/BeautifulSoup/bs4/doc/#parent
### Proposed solution
Add a new GREL function for the jsoup method `parent()` and for simplicity sake just call the GREL function `parent()`
### Alternatives considered
A difficult path of custom installed Jython 2.7 with BeautifulSoup
### Additional context
Existing code for `select()` functionality is here:
https://github.com/OpenRefine/OpenRefine/blob/master/main/src/com/google/refine/expr/functions/xml/SelectXml.java
and function registration to be added to is here:
https://github.com/OpenRefine/OpenRefine/blob/master/main/src/com/google/refine/grel/ControlFunctionRegistry.java#L249
|
https://github.com/OpenRefine/OpenRefine/issues/4181
|
https://github.com/OpenRefine/OpenRefine/pull/4184
|
ed05a72ebd24fd38f57db6b6cb91897fa8e46b9e
|
0e41ab256260f1c4158ecf603badcfa05656f0be
| 2021-09-28T15:33:56Z |
java
| 2022-01-18T12:51:21Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,176 |
[".github/workflows/label_transfer.yml", ".github/workflows/label_transfer/requirements.txt", ".github/workflows/label_transfer/script.py"]
|
Label pull requests based on the labels of the issues they close
|
We do not use labels much on PRs so far, but it could be useful to do that:
- to help reviewers find PRs they could be interested in
- to make up for poor PR titles which do not describe their contents well
- to make it possible to draft release notes automatically from the Git commit log (#2359)
Since we are already tagging issues, and pull requests are normally linked to the issues they solve, we should be able to automatically tag PRs by copying those tags.
|
https://github.com/OpenRefine/OpenRefine/issues/4176
|
https://github.com/OpenRefine/OpenRefine/pull/4177
|
9bbdd3c454157ea36d86ee1fbf1d9f8fc336463b
|
f375006ee9e18f23e12827f361d5a99a63bb41f6
| 2021-09-26T11:46:33Z |
java
| 2021-09-26T11:58:57Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,157 |
["main/tests/cypress/cypress.json", "main/tests/cypress/cypress/integration/project/grid/viewpanel-header/pagination.spec.js", "main/tests/cypress/cypress/integration/project/undo_redo/apply.spec.js"]
|
Cypress tests for undo/redo are unstable
|
See the following PR : https://github.com/OpenRefine/OpenRefine/runs/3629571950?check_suite_focus=true
The undo redo tests quite often fails
Need to check if this is a regression or something else
|
https://github.com/OpenRefine/OpenRefine/issues/4157
|
https://github.com/OpenRefine/OpenRefine/pull/4163
|
e286d9f02f7e86143a3ca54e82cbccefd6f91582
|
9f7b8651f05196d0f02fa0a4d47f149735e49a64
| 2021-09-17T07:55:48Z |
java
| 2021-10-06T13:41:54Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,150 |
[".github/workflows/pull_request.yml", ".github/workflows/snapshot_release.yml"]
|
Cypress build stability on PRs / master branch
|
It seems to me that Cypress tests are much more stable when run from a pull request compared to when run on the master branch. I have the impression that very often, the build succeeds on the pull request, and then when I merge it in master, the build fails.
One notable difference between the two workflows is that in pull requests, we test for Chrome only, and on master we test for both Chrome and Edge. So, it's natural that the master build is more likely to fail.
With those quasi-systematic failures I have learned to disregard failures on the master branch and only pay attention to build statuses on pull requests, which is not ideal. So I would be interested in bringing the CI on the master in line with that for pull requests, so disabling Edge there.
I would be curious to see if it solves the problem or if there are more differences between the two environments that could explain this pattern. Perhaps it's also a bias on my side (when a test fails on a pull request, it's easy to trigger a rebuild by merging master into the branch, which I cannot do on master).
|
https://github.com/OpenRefine/OpenRefine/issues/4150
|
https://github.com/OpenRefine/OpenRefine/pull/4156
|
1e0a012ced36c9db058ad573cfb7fdca44d2725a
|
b98cfc18d3c6bf1723b1cabffc1f01b91344f6b3
| 2021-09-16T12:16:24Z |
java
| 2021-09-17T07:10:32Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,145 |
["extensions/wikidata/module/scripts/dialogs/import-schema-dialog.js", "extensions/wikidata/module/scripts/schema-alignment.js"]
|
Schema import dialog improvements
|
The "Import schema" dialog from the Wikibase extension has two issues:
* the Cancel button does not have a proper label
* importing the schema should close the dialog (currently one has to click the Cancel button afterwards, which is counter-intuitive since we do not want to cancel the import)
### To Reproduce
Steps to reproduce the behavior:
1. First, open the dialog
2. See the improper label of the Cancel button and behaviour of the import button
### Expected Behavior
Proper label, dialog closes on import.
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: Linux
- Browser Version: Chromium
- JRE or JDK Version: 14
- OpenRefine: master
|
https://github.com/OpenRefine/OpenRefine/issues/4145
|
https://github.com/OpenRefine/OpenRefine/pull/4154
|
b98cfc18d3c6bf1723b1cabffc1f01b91344f6b3
|
29ab7b509f156b9bf72730eff22ee72ff3e44f77
| 2021-09-10T11:37:20Z |
java
| 2021-09-17T07:30:11Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,119 |
["main/webapp/modules/core/scripts/index/edit-metadata-dialog.js", "main/webapp/modules/core/styles/index/open-project-ui.less"]
|
Add scrollable div layer to Project metadata view to prevent cutoff of CLOSE button
|
Currently if values in the Project metadata editor are too large then the CLOSE button is not seen and clickable to users.
### Current Results
If the length of values is too long in any of the keys, then sometimes the CLOSE button will be cutoff and hidden from a user preventing them from being able to close the Project metadata panel.
### Expected Behavior
Provide 2 things:
1. a scrollable div layer that can hold and scroll through all the key:value rows.
2. while scrolling, keep the CLOSE button at the bottom, and the Key and Value header labeling at the top.
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Firefox
- JRE or JDK Version: JDK15
- OpenRefine: 3.5 beta1
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
Using [Cypress support for Visual testing](https://docs.cypress.io/guides/tooling/visual-testing#Functional-vs-visual-testing), ensure to add 1 Cypress test that can
1. click edit on Title row and add lots of text into value input box and click OK.
2. using a previously cropped baseline image of the lower left corner that includes the CLOSE button.
3. compare that cropped baseline image with a clip region of the screen during test, such as example (adjust numbers as necessary)
```cy.get('.element')
.toMatchImageSnapshot({
clip: { x: 125, y: 870, width: 75, height: 50 },
});
```
4. assert that the CLOSE button is still displayed and seen
|
https://github.com/OpenRefine/OpenRefine/issues/4119
|
https://github.com/OpenRefine/OpenRefine/pull/4527
|
40cfe2f2b5fb8cdbc9a2a71af04cfc145c9d3943
|
ee551ab38a72d8d14f32192c2fcabbe3f8110775
| 2021-08-23T12:47:38Z |
java
| 2022-02-15T09:35:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,118 |
["refine.bat"]
|
use `findstr` not `find` in refine.bat
|
refine.bat in the windows distribution has this:
```
echo Getting Java Version...
java -version 2^>^&1
echo.=====================================================
for /f "tokens=*" %%a in ('java -version 2^>^&1 ^| find "version"') do (set JVERSION=%%a)
echo Getting Free Ram...
for /f "tokens=2 delims=:" %%i in ('systeminfo ^| findstr /C:"Available Physical Memory"') do (set freeRam=%%i)
```
I have Cygwin installed, so:
```
>which findstr
/cygdrive/c/WINDOWS/system32/findstr
# BUT
>which find
/usr/bin/find
```
I.e. the batch file catches unix `find` not windows `find` (which is the reason for a small error message ni https://github.com/OpenRefine/OpenRefine/issues/4106#issuecomment-903710691).
Please use `findstr` not `find` (as you already do in the "Available Physical Memory" check).
|
https://github.com/OpenRefine/OpenRefine/issues/4118
|
https://github.com/OpenRefine/OpenRefine/pull/4120
|
0140ac52cbeb3a1a5b26af3feac4d1c6fb4eee1a
|
5316e08f4f112d0f4b5f75cf2a1c2a341c39e726
| 2021-08-23T12:18:49Z |
java
| 2021-08-26T18:00:15Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,113 |
["refine", "refine.bat"]
|
Allow changing the autosave period via refine.sh/bat on command line
|
I have some large projects that require launching where I really need the autosave period to be closer to 60 minutes. I use a few Windows shortcuts on my desktop for some common large OpenRefine projects that I sometimes cross with, etc. The problem is that I cannot easily use the Windows shortcuts to launch these particular large OpenRefine projects because I cannot also save the shortcuts with a command line parameter to control the autosaving. I can only control autosaving period from the `refine.ini` file.
a custom `refine.ini` path also is not a parameter that can be passed to the refine.sh/bat which probably would be the best solution all around.
### Proposed solution
allow passing a custom `refine.ini` path as a parameter for the `refine.sh/bat` launcher.
We already have in the scripts a "endConfigReading" section that could be re-used and parameterized for consuming a custom `refine.ini` path such as
```sh
refine /c C:\Users\thadg\bigfile_refine.ini
```
### Alternatives considered
<!-- If there alternative solutions that you have considered or think should be considered, please list them here -->
### Additional context
<!-- Add any other context or screenshots about the feature request here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/4113
|
https://github.com/OpenRefine/OpenRefine/pull/4220
|
3401920892717ac9821b7784899f0185a05ae006
|
07a0447234cd3d556a8cef831874332ea0573fda
| 2021-08-19T14:31:46Z |
java
| 2022-01-22T22:15:30Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,112 |
["main/src/com/google/refine/commands/importing/ImportingControllerCommand.java", "main/src/com/google/refine/importing/ImportingUtilities.java", "main/tests/data/unsupportedPPMD.zip", "main/tests/server/src/com/google/refine/importing/ImportingUtilitiesTests.java"]
|
Importing a ZIP file with PPMd compression fails to show warning box in importer UI
|
ZIP files that were compressed with PPMd are not able to be imported into OpenRefine and fail to show any friendly warning in the UI during import that the compression format is unknown
### To Reproduce
Steps to reproduce the behavior:
1. Compress a ZIP file with PPMd compression
2. Try to import into OpenRefine
3. Notice blank Preview page in UI without any warning but shows Java exception in console.
### Current Results
```
06:56:14.430 [ refine] GET /command/core/get-languages (32ms)
06:56:14.805 [ refine] GET /command/core/get-version (375ms)
06:56:28.177 [ refine] GET /command/core/get-csrf-token (13372ms)
06:56:28.180 [ refine] POST /command/core/create-importing-job (3ms)
06:56:28.205 [ refine] POST /command/core/importing-controller (25ms)
java.util.zip.ZipException: invalid compression method
at java.util.zip.ZipInputStream.read(ZipInputStream.java:225)
at java.io.FilterInputStream.read(FilterInputStream.java:107)
at com.google.refine.importing.ImportingUtilities.saveStreamToFile(ImportingUtilities.java:532)
at com.google.refine.importing.ImportingUtilities.explodeArchive(ImportingUtilities.java:687)
at com.google.refine.importing.ImportingUtilities.postProcessRetrievedFile(ImportingUtilities.java:556)
at com.google.refine.importing.ImportingUtilities.retrieveContentFromPostRequest(ImportingUtilities.java:382)
at com.google.refine.importing.ImportingUtilities.loadDataAndPrepareJob(ImportingUtilities.java:116)
at com.google.refine.importing.DefaultImportingController.doLoadRawData(DefaultImportingController.java:118)
at com.google.refine.importing.DefaultImportingController.doPost(DefaultImportingController.java:87)
at com.google.refine.commands.importing.ImportingControllerCommand.doPost(ImportingControllerCommand.java:68)
at com.google.refine.RefineServlet.service(RefineServlet.java:187)
```
### Expected Behavior
Display a Warning dialog in UI whenever `ImportingUtilities.explodeArchive` fails for any reason, I think.
### Screenshots
Compressed using 7zip and selecting PPMd compression method for large file support
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Firefox
- JRE or JDK Version: JDK 15
- OpenRefine: 3.5.1 beta1
### Datasets
Small test ZIP file compressed with PPMd - [chicago_tribute-covid.zip](https://github.com/OpenRefine/OpenRefine/files/7014220/chicago_tribute-covid.zip)
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/4112
|
https://github.com/OpenRefine/OpenRefine/pull/4286
|
ddeaf47f3773d04dd12886e7cf0f0f477cba2ddd
|
c92d745af3fc6694f1f991e16101bc70d5fabce2
| 2021-08-19T12:14:39Z |
java
| 2021-11-13T12:03:49Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,108 |
["packaging/pom.xml", "settings.xml"]
|
OpenRefine 3.5-beta1 is not respecting the JAVA_HOME variable
|
**Disregard the fact below that OpenJDK 16 will not let OpenRefine work correctly and folks will get a blank logo when starting OpenRefine - I.E. they must use lower then 16 at this current moment**
**This bug report is created while testing for the above issue that I suspected was happening and suddenly found that OpenRefine 3.5.1 is no longer respecting the JAVA_HOME path when launched by OpenRefine.exe, but does respect JAVA_HOME if it is launched by refine.bat**
----
I suspect some weird bug or config changed or perhaps with Launch4j config & packaging is not allowing the OpenRefine.exe to even see JAVA_HOME correctly when a user sets this correctly on their Windows 10 system.
### To Reproduce
Correctly setup my Windows 10 system to have the PATH and JAVA_HOME pointing to OpenJDK 16 installation path.
Proved it's set correctly with the following:
```
Microsoft Windows [Version 10.0.19044.1165]
(c) Microsoft Corporation. All rights reserved.
C:\Users\thadg>java -version
openjdk version "16.0.1" 2021-04-20
OpenJDK Runtime Environment (build 16.0.1+9-24)
OpenJDK 64-Bit Server VM (build 16.0.1+9-24, mixed mode, sharing)
C:\Users\thadg>
```
Then launch OpenRefine.exe from the 3.5.1 beta1 folder installation.
Watch OpenRefine startup just fine.
However, OpenRefine 3.5.1 beta1 is instead using JDK 8 and not the correctly set JAVA_HOME which has OpenJDK 16 path configured as seen in VisualVM.
Scratch my head...
I then start `refine.bat` to see the difference from the OpenRefine.exe launching...
And notice it is now correctly using OpenJDK 16 from my JAVA_HOME as shown in Windows terminal output:
```
Microsoft Windows [Version 10.0.19044.1165]
(c) Microsoft Corporation. All rights reserved.
C:\Users\thadg>E:
E:\>cd E:\Downloads\openrefine-win-3.5-beta1\openrefine-3.5-beta1
E:\Downloads\openrefine-win-3.5-beta1\openrefine-3.5-beta1>refine /m20G
Using refine.ini for configuration
Unknown Refine command called "/m20G", type "refine /?" for proper usage.
E:\Downloads\openrefine-win-3.5-beta1\openrefine-3.5-beta1>refine /m 20G
Using refine.ini for configuration
Getting Java Version...
openjdk version "16.0.1" 2021-04-20
OpenJDK Runtime Environment (build 16.0.1+9-24)
OpenJDK 64-Bit Server VM (build 16.0.1+9-24, mixed mode, sharing)
=====================================================
Getting Free Ram...
log4j:WARN No appenders could be found for logger (org.eclipse.jetty.util.log).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/E:/Downloads/openrefine-win-3.5-beta1/openrefine-3.5-beta1/webapp/WEB-INF/lib/slf4j-log4j12-1.7.30.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/E:/Downloads/openrefine-win-3.5-beta1/openrefine-3.5-beta1/server/target/lib/slf4j-log4j12-1.7.30.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
16:21:00.328 [ refine] Starting OpenRefine 3.5-beta1 [1b9907e]... (0ms)
16:21:00.329 [ refine] initializing FileProjectManager with dir (1ms)
16:21:00.329 [ refine] C:\Users\thadg\AppData\Roaming\OpenRefine (0ms)
```
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Firefox
- JRE or JDK Version: openjdk version "16.0.1" 2021-04-20
- OpenRefine: 3.5.1 beta1
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/4108
|
https://github.com/OpenRefine/OpenRefine/pull/4238
|
77d958c9d417965428bc7dcd9d133184e2a554dc
|
cf8b1401fab085bef09a2ce8b885d6b5c55b61a6
| 2021-08-17T21:38:05Z |
java
| 2021-11-24T12:49:52Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,106 |
[".github/workflows/pull_request.yml", "docs/docs/manual/installing.md", "docs/versioned_docs/version-3.5/manual/installing.md", "pom.xml"]
|
Open Refine opens with logo only when running on Java 16
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
### To Reproduce
Steps to reproduce the behavior:
1. Click on open refine Application
### Current Results
2. This window appears:
3.
4. This page appears
5.
6.I have installed the embedded Java version:
7.I have run it as adminstrator same results.
8. Tried to run the batch file
9. Same results:
10. Tried firefox
11.
### Expected Behavior
Open Refine page appears
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: Edition Windows 10 Pro
Version 20H2
Installed on 17/03/2021
OS build 19042.1165
Experience Windows Feature Experience Pack 120.2212.3530.0
- Browser Version:
- JRE or JDK Version:
- Using embedded but:
-
- OpenRefine: 3.4.1
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/4106
|
https://github.com/OpenRefine/OpenRefine/pull/4378
|
e4675039f5f14aa9ae694fe008a4a0a6c97df273
|
573e652e53b921a18736490cff44fdcc5d180bc4
| 2021-08-17T16:28:22Z |
java
| 2021-12-18T11:26:04Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,103 |
["main/src/com/google/refine/importers/LineBasedImporter.java", "main/tests/server/src/com/google/refine/importers/LineBasedImporterTests.java", "main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/index/parser-interfaces/line-based-parser-ui.html", "main/webapp/modules/core/scripts/index/parser-interfaces/line-based-parser-ui.js"]
|
Allow line-based importer to specify a custom line-delimiter sequence for custom data
|
This might need better streaming support for our line-based importer as a pre-requisite. I don't know.
I often land myself with large byte arrays streamed out to a single file that have custom sequence of chars (`*%%*`) used as record delimiters that I would like to treat simply as a line-delimiter while importing the file into OpenRefine. The file sizes are typically under 4GB, usually only 1GB or 2GB in size, where I often have over 20GB system memory available to give to the Java heap.
Other tools allow reading a file as a stream of characters and separating into new lines based on a custom char sequence.
I would like our OpenRefine line-based importer or a new importer to handle this use case.
### Proposed solution
Allow line-based importer to have an option to use a custom line-delimiter character sequence (overriding the defaults of `\n` or `\r\n`.
### Alternatives considered
I have to use other tools.
### Additional context
<!-- Add any other context or screenshots about the feature request here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/4103
|
https://github.com/OpenRefine/OpenRefine/pull/5434
|
29d4929bcfaa73a630f6a6ed7f57b5b452d8d51e
|
6968bf37165d7d52531f57e8d0beb6d7dc905d33
| 2021-08-13T12:41:21Z |
java
| 2022-11-17T19:48:03Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,081 |
["extensions/gdata/src/com/google/refine/extension/gdata/UploadCommand.java"]
|
Unreleased Resource: Streams
|
https://github.com/OpenRefine/OpenRefine/blob/409cf2c30097ae7a5981e941d4bbee49896cd590/extensions/gdata/src/com/google/refine/extension/gdata/UploadCommand.java#L149
The program can potentially fail to release a system resource.
|
https://github.com/OpenRefine/OpenRefine/issues/4081
|
https://github.com/OpenRefine/OpenRefine/pull/4691
|
ac1f9eab243a5797b9c339ff93d1441a44478854
|
bb765b42b321f35c99b99582bb07b8330cd4954e
| 2021-07-30T06:29:01Z |
java
| 2022-04-05T17:56:01Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,080 |
["extensions/database/src/com/google/refine/extension/database/mariadb/MariaDBDatabaseService.java"]
|
Unreleased Resource: Database
|
https://github.com/OpenRefine/OpenRefine/blob/409cf2c30097ae7a5981e941d4bbee49896cd590/extensions/database/src/com/google/refine/extension/database/mariadb/MariaDBDatabaseService.java#L85-L86
The program can potentially fail to release a database resource.
|
https://github.com/OpenRefine/OpenRefine/issues/4080
|
https://github.com/OpenRefine/OpenRefine/pull/4773
|
11127dab8a432d8273630ed1dcd2711ade81ccc8
|
bbd7c955975557c2c5b00db44e0fdb2da82f98bf
| 2021-07-30T06:19:14Z |
java
| 2022-05-18T13:17:57Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,079 |
["pom.xml"]
|
There is a vulnerability in Jetty: Java based HTTP/1.x, HTTP/2, Servlet, WebSocket Server 9.4.41.v20210516,upgrade recommended
|
https://github.com/OpenRefine/OpenRefine/blob/409cf2c30097ae7a5981e941d4bbee49896cd590/pom.xml#L67
CVE-2021-34429
Recommended upgrade version：9.4.43.v20210629
|
https://github.com/OpenRefine/OpenRefine/issues/4079
|
https://github.com/OpenRefine/OpenRefine/pull/5119
|
ebfb93b02d5954ff5f1afbd0ffa396a6a4d8a182
|
20dd593340249c936dbed4e51cdd0df79cd002e0
| 2021-07-30T05:42:37Z |
java
| 2022-07-26T06:54:01Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,078 |
["main/pom.xml", "main/webapp/WEB-INF/velocity.properties", "pom.xml"]
|
There is a vulnerability in Apache Velocity Engine 1.5,upgrade recommended
|
https://github.com/OpenRefine/OpenRefine/blob/409cf2c30097ae7a5981e941d4bbee49896cd590/main/pom.xml#L236
CVE-2020-13936
Recommended upgrade version：2.3
|
https://github.com/OpenRefine/OpenRefine/issues/4078
|
https://github.com/OpenRefine/OpenRefine/pull/6190
|
307d8bf9147c1fb41b8013efb5fe14d9cb490277
|
0945595a795363743517c3e362871e832bdb367a
| 2021-07-30T05:33:51Z |
java
| 2023-11-27T12:55:57Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,067 |
["main/tests/cypress/cypress/integration/project/grid/column/view/expand-left.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/view/expand-right.spec.js", "main/webapp/modules/core/langs/translation-en.json", "main/webapp/modules/core/scripts/views/data-table/column-header-ui.js"]
|
Want to unhide columns en masse
|
Sometimes after I have already collapsed a bunch of columns, I'd like to unhide them en masse instead of one by one. This is very frustrating since I deal with projects that easily have 50 columns. Right now, I have to click on each column individually.
Edit: I missed that unhiding is available under All - it would be nice to also have it available under the column View menu with the left/right options available as well.
### Proposed solution
To the View Menu, add
- Show all other columns
- Show all columns to left
- Show all columns to right
### Alternatives considered
The only alternative is clicking one by one or exiting and reopening the project.
|
https://github.com/OpenRefine/OpenRefine/issues/4067
|
https://github.com/OpenRefine/OpenRefine/pull/4250
|
85189ecd37cb9bed18c7c9a848c2ebec4219acf3
|
f6c30732dcefece6c4a6a18ff98aca7b50cfc98f
| 2021-07-21T19:53:03Z |
java
| 2022-01-19T08:39:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,048 |
["docs/static/img/cluster.png"]
|
Fix documentation for clustering
|
[The documentation about clustering](https://docs.openrefine.org/manual/cellediting#cluster-and-edit) shows a screenshot of the clustering dialog where all the values in a given cluster look identical, which should not normally happen. This screenshot was taken before #4004 was fixed, which probably explains that. This screenshot should be replaced by a screenshot which shows different values being clustered together.
Current image:
Additionally it could be useful to rework the text to make the clustering feature clearer because it looks like the current documentation does not convey the intended usage very well.
This was noticed in #3422 by @fgiroud.
|
https://github.com/OpenRefine/OpenRefine/issues/4048
|
https://github.com/OpenRefine/OpenRefine/pull/4780
|
874a48252274f50f116d6d732d8d384ca34b5691
|
8e5e06a4b11843bbfcb5d1db128c08aef46d2b5c
| 2021-07-08T10:11:31Z |
java
| 2022-04-24T07:50:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,031 |
["docs/docs/manual/exporting.md", "docs/docs/manual/reconciling.md", "docs/docs/manual/wikibase/advanced-schemas.md", "docs/docs/manual/wikibase/schema-alignment.md", "docs/docusaurus.config.js"]
|
Docusaurus broken link detection does not mark builds as failed
|
We use a feature in Docusaurus to detect broken links in the docs but it only prints errors into the logs without failing the builds at the moment, so we are introducing broken links without noticing!
See for instance this build:
https://app.netlify.com/sites/openrefine-docs/deploys/60df5ce94f1a5f00077e1a61
We should probably change the `onBrokenLinks` option from `error` to `throw`?
|
https://github.com/OpenRefine/OpenRefine/issues/4031
|
https://github.com/OpenRefine/OpenRefine/pull/4032
|
aebcd41102f5907a46977c166e085b3920078dc0
|
9b24ba64f2b36182fec6a6a83095bd7f14e01544
| 2021-07-02T18:47:54Z |
java
| 2021-07-04T16:43:32Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,020 |
["docs/yarn.lock"]
|
Update cross() documentation for version 3.5
|
As described in comment https://github.com/OpenRefine/OpenRefine/issues/2504#issuecomment-869328758 we should update our user manual for version 3.5 about the `cross()` function showing the project name is optional now, and can use an empty project, and also work with `rowIndex` quite nicely. Since this is new in 3.5 version, this probably depends on our better supporting our doc versioning itself such as in
- [x] #4018
, and it might also be good to mention the example use of `rowIndex` as demonstrated in that comment to help folks that want to `cross()` within their own project's columns. Since this is non-obvious but a quick sentence like mentioned would help expose that potential to users.
|
https://github.com/OpenRefine/OpenRefine/issues/4020
|
https://github.com/OpenRefine/OpenRefine/pull/4142
|
997dd239460aa84f5748e353d6318d9fa5f85307
|
8ed2d0cdefc5934de07e5e671e670394ea257612
| 2021-06-28T14:33:24Z |
java
| 2021-09-09T10:00:02Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,015 |
["main/tests/cypress/cypress/integration/create-project/create_project.spec.js", "main/webapp/modules/core/scripts/index/create-project-progress-panel.html", "main/webapp/modules/core/scripts/index/default-importing-controller/controller.js", "main/webapp/modules/core/styles/index/create-project-ui.less"]
|
Test for creating project from web URLs are not working anymore
|
Those two tests doesn't work anymore and have been disabled to keep the test suite stable
- Test the create project from Web URL based on CSV
- Test the create project from Multiple Web URLs based on CSV
it looks likes it's from the latest version of Cypress 7.5
|
https://github.com/OpenRefine/OpenRefine/issues/4015
|
https://github.com/OpenRefine/OpenRefine/pull/5199
|
0ebfccd4f87acc5c8118a5fc228d83034cfc5644
|
2827ba0131b7b06603966f387bc5dae41b74f737
| 2021-06-25T08:08:51Z |
java
| 2022-08-24T06:34:14Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 4,004 |
["main/webapp/modules/core/scripts/dialogs/clustering-dialog.js"]
|
Clustering dialog does not show duplicate whitespace clearly
|
When clustering values which contain duplicate whitespace characters, these characters are not clearly shown in the clustering dialog, giving the impression that we are clustering identical values.
### To Reproduce
Steps to reproduce the behavior:
1. First, import the following file (as a lines-based or CSV file for instance):
```
foo
b ar
b ar
b ar
```
2. Then, open the clustering dialog on that column.
### Current Results
All options look the same:
### Expected Behavior
Space differences should be respected:
### Versions<!-- (please complete the following information)-->
- Operating System: Linux
- Browser Version: Firefox 78
- JRE or JDK Version: 11
- OpenRefine: 3.5 beta1
|
https://github.com/OpenRefine/OpenRefine/issues/4004
|
https://github.com/OpenRefine/OpenRefine/pull/4005
|
91440b4cfb26958fdc5f06856355d79ad925c81d
|
9919ee51bfbb3ed63b1227d56595f288a38daffe
| 2021-06-22T11:47:33Z |
java
| 2021-06-27T14:14:22Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,991 |
["extensions/gdata/module/MOD-INF/controller.js"]
|
Export to Google Drive / Sheets end up with HTTP ERROR 500 - Butterfly Error
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
### To Reproduce
Steps to reproduce the behavior:
I have tried to export the project to Google Drive as well as export to Google Sheets. But facing an issue after granting the authorization. Getting ends up with a HTTP ERROR 500 - Butterfly Error.
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Brave browser (Version 1.25.73 Chromium: 91.0.4472.106)
- JRE or JDK Version: <!-- output of "java -version" e.g. JRE 1.8.0_181 -->
- OpenRefine: OpenRefine 3.5 beta1
|
https://github.com/OpenRefine/OpenRefine/issues/3991
|
https://github.com/OpenRefine/OpenRefine/pull/4223
|
6372f2d3827a3cd662302edb81c5476b1b5e3850
|
adfe1aa925b866cc2e2bccc7e319cf70b2938eda
| 2021-06-17T12:31:11Z |
java
| 2021-10-22T06:57:02Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,987 |
["main/src/com/google/refine/util/HttpClient.java"]
|
Socket timeout too low for reconciliation operations
|
Reconciliation can still fail silently for some batches even with reliable reconciliation services like OpenCorporate's.
## To reproduce
Try to reconcile the file provided in https://groups.google.com/g/openrefine/c/WHuCcfPPJbo
## Current results
https://groups.google.com/g/openrefine/c/WHuCcfPPJbo
You get some errors in the server logs like this:
```
{"q0":{"query":"Phoenix Software","type":"/organization/organization","type_strict":"should"},"q1":{"query":"Box.com (UK) Ltd","type":"/organization/organization","type_strict":"should"},"q2":{"query":"CEMEX UK Operations Ltd","type":"/organization/organization","type_strict":"should"},"q3":{"query":"LEX AUROLEASE LTD","type":"/organization/organization","type_strict":"should"},"q4":{"query":"JEDEX Ltd","type":"/organization/organization","type_strict":"should"},"q5":{"query":"BARTON ENGINEERING AND EXPORT","type":"/organization/organization","type_strict":"should"},"q6":{"query":"XOOMWORKS LIMITED","type":"/organization/organization","type_strict":"should"},"q7":{"query":"X-TECH (OPEN SYSTEMS) LTD","type":"/organization/organization","type_strict":"should"},"q8":{"query":"SODEXO LIMITED","type":"/organization/organization","type_strict":"should"},"q9":{"query":"Exergetic Ltd","type":"/organization/organization","type_strict":"should"}} (15688ms)
java.io.IOException: Failed to batch recon with load:
{"q0":{"query":"Phoenix Software","type":"/organization/organization","type_strict":"should"},"q1":{"query":"Box.com (UK) Ltd","type":"/organization/organization","type_strict":"should"},"q2":{"query":"CEMEX UK Operations Ltd","type":"/organization/organization","type_strict":"should"},"q3":{"query":"LEX AUROLEASE LTD","type":"/organization/organization","type_strict":"should"},"q4":{"query":"JEDEX Ltd","type":"/organization/organization","type_strict":"should"},"q5":{"query":"BARTON ENGINEERING AND EXPORT","type":"/organization/organization","type_strict":"should"},"q6":{"query":"XOOMWORKS LIMITED","type":"/organization/organization","type_strict":"should"},"q7":{"query":"X-TECH (OPEN SYSTEMS) LTD","type":"/organization/organization","type_strict":"should"},"q8":{"query":"SODEXO LIMITED","type":"/organization/organization","type_strict":"should"},"q9":{"query":"Exergetic Ltd","type":"/organization/organization","type_strict":"should"}}
at com.google.refine.model.recon.StandardReconConfig.postQueries(StandardReconConfig.java:444)
at com.google.refine.model.recon.StandardReconConfig.batchRecon(StandardReconConfig.java:467)
at com.google.refine.operations.recon.ReconOperation$ReconProcess.run(ReconOperation.java:282)
at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.net.SocketTimeoutException: Read timed out
at java.base/java.net.SocketInputStream.socketRead0(Native Method)
at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
at java.base/java.net.SocketInputStream.read(SocketInputStream.java:168)
at java.base/java.net.SocketInputStream.read(SocketInputStream.java:140)
at java.base/sun.security.ssl.SSLSocketInputRecord.read(SSLSocketInputRecord.java:478)
at java.base/sun.security.ssl.SSLSocketInputRecord.readHeader(SSLSocketInputRecord.java:472)
at java.base/sun.security.ssl.SSLSocketInputRecord.bytesInCompletePacket(SSLSocketInputRecord.java:70)
at java.base/sun.security.ssl.SSLSocketImpl.readApplicationRecord(SSLSocketImpl.java:1364)
at java.base/sun.security.ssl.SSLSocketImpl$AppInputStream.read(SSLSocketImpl.java:973)
at org.apache.hc.core5.http.impl.io.SessionInputBufferImpl.fillBuffer(SessionInputBufferImpl.java:149)
at org.apache.hc.core5.http.impl.io.SessionInputBufferImpl.readLine(SessionInputBufferImpl.java:280)
at org.apache.hc.core5.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:241)
at org.apache.hc.core5.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:53)
at org.apache.hc.core5.http.impl.io.DefaultBHttpClientConnection.receiveResponseHeader(DefaultBHttpClientConnection.java:298)
at org.apache.hc.core5.http.impl.io.HttpRequestExecutor.execute(HttpRequestExecutor.java:175)
at org.apache.hc.core5.http.impl.io.HttpRequestExecutor.execute(HttpRequestExecutor.java:218)
at org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager$InternalConnectionEndpoint.execute(PoolingHttpClientConnectionManager.java:594)
at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.execute(InternalExecRuntime.java:219)
at org.apache.hc.client5.http.impl.classic.MainClientExec.execute(MainClientExec.java:107)
at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
at org.apache.hc.client5.http.impl.classic.ExecChainElement$1.proceed(ExecChainElement.java:57)
at org.apache.hc.client5.http.impl.classic.ConnectExec.execute(ConnectExec.java:182)
at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
at org.apache.hc.client5.http.impl.classic.ExecChainElement$1.proceed(ExecChainElement.java:57)
at org.apache.hc.client5.http.impl.classic.ProtocolExec.execute(ProtocolExec.java:165)
at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
at org.apache.hc.client5.http.impl.classic.ExecChainElement$1.proceed(ExecChainElement.java:57)
at org.apache.hc.client5.http.impl.classic.HttpRequestRetryExec.execute(HttpRequestRetryExec.java:96)
at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
at org.apache.hc.client5.http.impl.classic.ExecChainElement$1.proceed(ExecChainElement.java:57)
at org.apache.hc.client5.http.impl.classic.ContentCompressionExec.execute(ContentCompressionExec.java:133)
at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
at org.apache.hc.client5.http.impl.classic.ExecChainElement$1.proceed(ExecChainElement.java:57)
at org.apache.hc.client5.http.impl.classic.RedirectExec.execute(RedirectExec.java:115)
at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
at org.apache.hc.client5.http.impl.classic.InternalHttpClient.doExecute(InternalHttpClient.java:179)
at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:75)
at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:89)
at com.google.refine.util.HttpClient.postNameValue(HttpClient.java:174)
at com.google.refine.model.recon.StandardReconConfig.postQueries(StandardReconConfig.java:441)
... 3 more
```
### Expected behavior
The column should reconcile normally. When there are errors they should be reported.
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: Linux
- Browser Version: Firefox
- JRE or JDK Version: OpenJDK 11
- OpenRefine: 3.5-beta1
|
https://github.com/OpenRefine/OpenRefine/issues/3987
|
https://github.com/OpenRefine/OpenRefine/pull/4068
|
6599aecdf51b826774323ca8dbef570d4d9ab8d6
|
6960b7db66f771b0f0762de53f3155eb26177711
| 2021-06-15T07:26:23Z |
java
| 2021-10-16T07:08:56Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,979 |
["main/webapp/modules/core/scripts/index/open-project-ui.js", "main/webapp/modules/core/styles/index/open-project-ui.less"]
|
Edit project tags does not work
|
When hovering on tags on projects in the Project table there is a hover tip, "Edit project tags".
Clicking on a tag does nothing.
### To Reproduce
Steps to reproduce the behavior:
1. Click Open Project
2. Then hover on some tags in the Tags column on list of projects
3. Try to click on some tags to edit
### Current Results
Clicking is not allowed. Not actually editable, but the hover text says so?
### Expected Behavior
However I don't know if it truly is supposed to be clickable in that area to edit.
It might have been an oversight in PR #1357 or a change in Javascript or just now instead should say "Project tags"?
Good news is that clicking on "About" link and editing a projects set of tags within the metadata editor does still work that way.
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Firefox latest
- JRE or JDK Version: JDK13
- OpenRefine: OpenRefine 3.5 Beta1
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/3979
|
https://github.com/OpenRefine/OpenRefine/pull/4613
|
9d900105ceebe947578367e463a2e0faedee448c
|
253b1eab70a93570eac27fae5fb604d122031c4f
| 2021-06-11T16:57:15Z |
java
| 2022-03-14T07:07:27Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,958 |
["extensions/wikidata/module/MOD-INF/controller.js", "extensions/wikidata/module/scripts/ajv.js", "extensions/wikidata/module/scripts/ajv.min.js"]
|
Minified Javascript files in the repository
|
[Posted by Markus Koschany on the openrefine-dev mailing list](https://groups.google.com/g/openrefine-dev/c/eJbPPYnqJiw):
> The webapp includes several minified Javascript files without providing the
> original non-minified source files. This is acceptable and in accordance with
> the license of those files but it is a reason to reject a package for Debian's
> ftp team because Debian requires the original sources. I suggest to include the
> corresponding non-minified Javascript files as well. Actually I believe
> minified JS files don't improve the performance that much since OpenRefine is
> run on the user's local system. You could remove them completely and use the
> non-minified versions instead. There are some files like date.js which appear
> to be minified Javascript as well despite the missing min.js suffix.
We should therefore reevaluate whether we can use non-minified files instead.
The real problem here is our lack of a proper dependency management system for our frontend, #2423.
|
https://github.com/OpenRefine/OpenRefine/issues/3958
|
https://github.com/OpenRefine/OpenRefine/pull/5252
|
1a13ac6d14fb6826c0073c337ef33e9a332babec
|
50ccef925ad44e09b40021ce801e5b87e8f044ea
| 2021-06-03T07:45:12Z |
java
| 2022-09-14T08:55:04Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,957 |
["main/webapp/modules/core/MOD-INF/controller.js", "main/webapp/modules/core/externals/jquery.lavalamp.min.js", "main/webapp/modules/core/scripts/index/open-project-ui.js", "main/webapp/modules/core/styles/index/open-project-ui.less"]
|
jquery.lavalamp.min.js is non-free
|
[Posted by Markus Koschany on the openrefine-dev mailing list](https://groups.google.com/g/openrefine-dev/c/eJbPPYnqJiw):
>
> Lavalamp is licensed under BY-NC 3.0 which makes it technically non-free and it
> cannot be included in Debian main because of the non-commercial clause. If I
> remove the file obviously some of the functionality of the main startpage is
> removed. I believe it should be possible to work around it or replace the
> plugin with a similar effect. In any case I had to remove the file from the
> sources for now.
This is a blocker for OpenRefine's packaging for Debian. Therefore we should investigate as soon as possible how to get rid of this dependency.
|
https://github.com/OpenRefine/OpenRefine/issues/3957
|
https://github.com/OpenRefine/OpenRefine/pull/3974
|
df964ef32868ceae410323bf3f1cd07fe39a39bb
|
d647f93c7ce0f1199ceb8412ec8267c94441faab
| 2021-06-03T07:32:13Z |
java
| 2021-06-11T17:18:55Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,955 |
["main/src/com/google/refine/templating/Template.java", "main/tests/server/src/com/google/refine/exporters/TemplatingExporterTests.java"]
|
Missing Row Separators in Templating Export
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
### To Reproduce
Steps to reproduce the behavior:
1. First, select the "Templating..." option under Export menu.
2. Use the default values for the json output.
3. Finally, observe that a number of "rows" (really records) at the start, are missing the "Row separator".
### Current Results
The first two exported items are missing a row separator:
```
{
"rows" : [
{
"One" : "a",
"Two" : "1",
"Three" : "2"
} {
"One" : null,
"Two" : "3",
"Three" : "4"
},
{
"One" : "c",
"Two" : "5",
"Three" : "6"
}
]
}
```
Also this data set also gets displayed with 2 (not 3) rows because the second row, with no value in the first column, doesn't get numbered.
### Expected Behavior
My data set should have three rows and the export should have all the row separators.
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: MacOS 10.15.7
- Browser Version: Safari 14.1.1, FireFox 88.01
- JRE or JDK Version: build 1.8.0_111-b14
- OpenRefine: 3.4.1
### Datasets
A small reproducible example:
```
"One","Two","Three"
"a",1,2
"",3,4
"c",5,6
```
### Additional context
|
https://github.com/OpenRefine/OpenRefine/issues/3955
|
https://github.com/OpenRefine/OpenRefine/pull/4352
|
5070334db98bc67ad7e4c3f255654c10891aff36
|
cb7e73eebe3fc99bd659b5e62bdb0a81c2d38a81
| 2021-06-02T19:36:33Z |
java
| 2022-01-18T12:58:19Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,944 |
[".github/workflows/pull_request.yml"]
|
New structure for GitHub Actions
|
We currently build pull requests using the `pull_request_target` event for the sake of being able to embed secrets (to post coverage statistics and ui test results), but this is not great for various reasons:
- this exposes a vulnerability, meaning that our secrets can actually be read by a malicious GitHub user
- if we make changes to the testing infrastructure which affect both the code base and the workflow definitions, then pull requests which are open at that time might start failing spuriously
- the reliance
Instead, I propose we use the normal `pull_request`. The secrets we need for building pull requests (Cypress project key, code coverage secret) are not actually that sensitive and could be displayed publicly with a bit of obfuscation.
|
https://github.com/OpenRefine/OpenRefine/issues/3944
|
https://github.com/OpenRefine/OpenRefine/pull/4501
|
916bcfeb6edfbd35718d6bb3d7874ec69a7ff22f
|
af3ed28c29c11a35bda957a8fc4bb1181f604102
| 2021-05-27T15:15:47Z |
java
| 2022-02-07T14:22:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,934 |
["docs/docs/manual/grelfunctions.md", "docs/versioned_docs/version-3.4/manual/grelfunctions.md", "docs/versioned_docs/version-3.5/manual/grelfunctions.md", "main/src/com/google/refine/expr/functions/strings/SplitByLengths.java"]
|
Update user manual and in-app documentation for splitByLength()
|
The documentation, specifically for splitByLength() does not inform the user that they have the possibility to only return values within a given range of indices, Iv since updated the document but wanted to make a bug report on it for submitting the PR.
ex:
`"123456789012345678901234567890".splitByLengths(3,4,5)[0,2]`
`returns [ "123", "4567" ]`
More about this issue can be seen in this thread: https://github.com/OpenRefine/OpenRefine/issues/3929
|
https://github.com/OpenRefine/OpenRefine/issues/3934
|
https://github.com/OpenRefine/OpenRefine/pull/4769
|
2f246c0b3704dfaf880f02c24d4007d518732479
|
63d2b8c867cdc403b658c836fd968114a42b4de9
| 2021-05-24T23:50:47Z |
java
| 2022-04-26T08:54:16Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,919 |
["docs/docs/manual/running.md", "main/src/com/google/refine/util/HttpClient.java"]
|
OpenRefine 3.4.1: Reconciliation Service does not use proxy defined in openrefine.l4j.ini
|
OpenRefine 3.4.1 on Windows (with or without integrated JRE) does not use the proxy set in openrefine.l4j.ini to connect to reconciliation service (https://lobid.org/gnd/reconcile)
### To Reproduce
Steps to reproduce the behavior:
1. First, set proxy in openrefine.l4j.ini using the following parameters:
`-Dhttps.proxyHost=proxy-name.domain.ch`
`-Dhttps.proxyPort=8080`
`-Dhttp.proxyHost=proxy-name.domain.ch`
`-Dhttp.proxyPort=8080`
`-Dhttp.nonProxyHosts=localhost`
2. Then, start OpenRefine using openrefine.exe, open project, select column "CDU - GND" for reconciliation
3. Then start reconciling using https://lobid.org/gnd/reconcile
4. Finally, OpenRefine throws the following error
`16:50:55.909 [ command] Failed to guess cell types for load
{"q0":{"query":"Landquart (Fluss)","limit":3}} (0ms)
org.apache.http.conn.HttpHostConnectException: Connect to lobid.org:443 [lobid.org/193.30.112.187] failed: Connection timed out:...`
### Current Results
The following messages are shown in OpenRefine (with verbosity "all"):
Additionally we did monitor the network traffic using wireshark and did find no connection from our localhost to our proxy but instead a connection request from our localhost to "emphytos.hbz-nrw.de" which bears the alias "lobid.org" with the IP 193.30.112.187.
This leads us to the conclusion that OpenRefine does not use the proxy settings specified in openrefine.l4j.ini.
### Expected Behavior
OpenRefine connects to the Reconciliation service using the proxy specified in openrefine.l4j.ini using the parameters
`-Dhttps.proxyHost=proxy-name.domain.ch`
`-Dhttps.proxyPort=8080`
`-Dhttp.proxyHost=proxy-name.domain.ch`
`-Dhttp.proxyPort=8080`
`-Dhttp.nonProxyHosts=localhost`
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10
- Browser Version: Edge or Firefox
- JRE or JDK Version: java version "1.8.0_281" Java(TM) SE Runtime Environment (build 1.8.0_281-b25) Java HotSpot(TM) 64-Bit Server VM (build 25.281-b25, mixed mode)
- OpenRefine: Version 3.4.1 [437dc4d]
### Datasets
[Dummy.openrefine.tar.gz](https://github.com/OpenRefine/OpenRefine/files/6509899/Dummy.openrefine.tar.gz)
### Additional context
OpenRefine runs behind a proxy that does not allow direct connections to the internet.
We tried both packages that are available for windows (windows with java and widows kit without java)
We also tested with the setting "-Djava.net.useSystemProxies=true", set the proxy-server in the java control panel and got the same results.
We also tried to run openrefine directly from the commandline and added the proxy parameters (we could not test refine.bat because the use of batch files is blocked by group policy).
|
https://github.com/OpenRefine/OpenRefine/issues/3919
|
https://github.com/OpenRefine/OpenRefine/pull/4673
|
b7d35b96f3491e7eea94825c1405bd37114f48be
|
b9427f4edadf846a5fdf36e8b2a154d7d43895c0
| 2021-05-19T15:32:28Z |
java
| 2022-04-19T14:30:43Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,915 |
["extensions/database/README.md"]
|
README.md for database extension is out of date
|
We need to update the database extension README.md to our more current architecture and documentation moves.
|
https://github.com/OpenRefine/OpenRefine/issues/3915
|
https://github.com/OpenRefine/OpenRefine/pull/3916
|
4537f5f46f0ce77cff461d882852f7dccfa6fcfb
|
a195f04737956b5a8afb158696a9d6cbe6df3906
| 2021-05-17T15:48:28Z |
java
| 2021-05-17T22:34:58Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,890 |
["docs/crowdin.yml", "docs/docusaurus.config.js", "docs/netlify.toml", "docs/package.json", "docs/yarn.lock"]
|
Make the user manual translatable
|
We want to make it possible for translators to translate our English documentation into other languages.
### Proposed solution
Docusaurus has a i18n feature which can be used for that. It can be used with various providers. We could try it out with Crowdin, as they are often used together.
### Alternatives considered
* Re-using Weblate (which we already use to translate the interface), but that requires inserting a complicated workflow based on po4a to split the markdown files in translatable strings. This probably gives a not so great translator experience since translators will translate small paragraphs in isolation, without the context.
* Using GitLocalize, but that seems not so stable and reliable.
### Additional context
This was discussed on the mailing list: https://groups.google.com/g/openrefine-dev/c/aesx9AiswIY.
Issue #3888 is a prerequisite for this.
|
https://github.com/OpenRefine/OpenRefine/issues/3890
|
https://github.com/OpenRefine/OpenRefine/pull/4029
|
ab07883336eb07dc9e935e3d27f2726fe95022b1
|
aebcd41102f5907a46977c166e085b3920078dc0
| 2021-05-09T06:53:22Z |
java
| 2021-07-02T18:37:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,877 |
["docs/docs/manual/running.md", "docs/versioned_docs/version-3.5/manual/running.md", "docs/versioned_docs/version-3.6/manual/running.md"]
|
Documentation for ui.browsing.pageSize is not correct
|
The Documentation (https://docs.openrefine.org/manual/running#preferences) states that "ui.browsing.pageSize" is available in version 3.4.1 - the issue (#2624) on the topic is listed for the upcoming version 3.5.
Please correct the version information value in the preference table from 3.4.1 to 3.5.
|
https://github.com/OpenRefine/OpenRefine/issues/3877
|
https://github.com/OpenRefine/OpenRefine/pull/5398
|
5c9559d5eed7649e1403df92aa84ba3017c97a65
|
fb5f494b81ae6fa1571e68186e70d869e7e3950b
| 2021-05-05T05:01:39Z |
java
| 2022-11-01T20:35:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,864 |
["docs/docs/technical-reference/maintainer-guidelines.md", "docs/sidebars.js"]
|
Write up maintainer guidelines
|
We want to involve more people in reviewing issues and pull requests. To make this easier, we should agree on common practices which should be written up in the technical documentation.
I will propose a draft as a PR addressing this issue.
|
https://github.com/OpenRefine/OpenRefine/issues/3864
|
https://github.com/OpenRefine/OpenRefine/pull/3866
|
03963ea7d15715b94e04b5d26546cdfd7f2be705
|
4687f7a22f2dc520eb411ba4ab6805e27709b262
| 2021-05-01T08:58:28Z |
java
| 2021-05-06T10:48:09Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,862 |
["main/webapp/modules/core/scripts/util/encoding.js", "main/webapp/modules/core/styles/util/encoding.less"]
|
Add 'Windows-1252" to the Common Encodings List
|
<!-- Please provide a clear and concise description of your problem or unsatisfied needs. Ex. I'm always frustrated when [...] or, It would be easier if OpenRefine did [...]. This comment can be deleted, if desired, but it will be hidden in your final submission. Please make sure that your new text is outside the enclosing angle brackets. -->
It might sound a bit pretentious but I would suggest adding **windows-1252** to the list of common character encodings as well.
In my experience most of the documents I deal with are **UTF8** or **windows-1252**.
Also according to wikipedia "[It is the most-used single-byte character encoding in the world](https://en.wikipedia.org/wiki/Windows-1252)" :)
|
https://github.com/OpenRefine/OpenRefine/issues/3862
|
https://github.com/OpenRefine/OpenRefine/pull/3865
|
8abf3673928ef6b84378a4a1a39476fd962df372
|
dd49148f383bb577b22de5ca2f4b58e101b796df
| 2021-04-30T12:39:36Z |
java
| 2021-05-08T07:06:42Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,853 |
["main/src/com/google/refine/importers/SeparatorBasedImporter.java", "main/tests/server/src/com/google/refine/importers/SeparatorBasedImporterTests.java"]
|
Default "Use quote as separator" to False for TSV imports
|
I got a TSV file and uploaded it to OpenRefine, but OpenRefine parsed it incorrectly, shifting values over several columns.
### To Reproduce
Steps to reproduce the behavior:
1. Upload the file to OpenRefine.
2. Facet the categories column and select one of the values with "mm" in it. Look at the information in the size columns of the selected row.
### Current Results
You should see that the actual size values have been shifted two or three columns to the left so that the height value is now in the categories value.
### Expected Behavior
In the raw XSLX file, the values are in the columns they are supposed to be in, I believe that OpenRefine is parsing the information incorrectly.
### Screenshots
### Versions
- Operating System: Windows 10
- Browser Version: Microsoft Edge 90.0.818.46
- JRE or JDK Version:
- OpenRefine: 3.4.1
### Datasets
Since Github won't let me upload the original TSV, here is an XSLX I created by exporting the TSV's information from OpenRefine.
[phm-collection.xlsx](https://github.com/OpenRefine/OpenRefine/files/6385815/phm-collection.xlsx)
|
https://github.com/OpenRefine/OpenRefine/issues/3853
|
https://github.com/OpenRefine/OpenRefine/pull/5858
|
0bb8c5d45b039a9366d4146627fa608d80c29b6a
|
0e392d7c3ba67444edf6eb735457c62e4933ed41
| 2021-04-27T15:57:57Z |
java
| 2023-05-28T06:04:37Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,824 |
["extensions/wikidata/module/scripts/dialogs/wikibase-dialog.html", "extensions/wikidata/module/scripts/dialogs/wikibase-dialog.js", "extensions/wikidata/module/scripts/dialogs/wikibase-item.html", "extensions/wikidata/module/scripts/wikibase-manager.js", "extensions/wikidata/module/styles/dialogs/wikibase-dialog.less"]
|
UI tweaks in Wikibase selection dialog
|
I would like to propose some minor tweaks to the dialog to select the Wikibase instance:
* The currently selected Wikibase instance is not displayed prominently enough. I would expect the item in the list to be somehow highlighted (different background color, border…)
* Since the logos take a bit of vertical space I think we could have space to also display the URL of the Wikibase instance underneath the name. I expect it could be useful to distinguish between various instances with similar names/logos.
* When I click on another Wikibase instance to select it, I find it confusing that the dialog does not go away by itself. What else could I want to do in this dialog after that? Its only purpose is to select the Wikibase instance, so once that is done I should be able to just go back to the project and carry on.
Pinging @afkbrb for his thoughts on this :)
|
https://github.com/OpenRefine/OpenRefine/issues/3824
|
https://github.com/OpenRefine/OpenRefine/pull/4766
|
01916e51b9a2fa22518f67e2de7f9f3462b34a41
|
46d1f7b701c27922279653fcd5b4e47e0652b3ae
| 2021-04-18T09:23:31Z |
java
| 2022-05-18T13:05:17Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,819 |
["docs/docs/technical-reference/reconciliation-api.md", "docs/docs/technical-reference/writing-extensions.md", "docs/docusaurus.config.js", "docs/static/js/fix-location.js"]
|
Broken links in documentation
|
As pointed out by @gitonthescene in https://github.com/OpenRefine/OpenRefine/issues/3629#issuecomment-820787026, some links in https://docs.openrefine.org/manual/expressions/#grel-supported-regex are broken, for instance the "contains" GREL function which links to https://docs.openrefine.org/manual/expressions/grelfunctions#containss-sub-or-p.
We should:
- [x] make sure the CI detects this
- [x] fix those links
|
https://github.com/OpenRefine/OpenRefine/issues/3819
|
https://github.com/OpenRefine/OpenRefine/pull/3821
|
791ae1f06be752d3f6e4a70347d50aa157325452
|
ee72a200e1253e4f59fd790933e760297720687f
| 2021-04-16T06:17:54Z |
java
| 2021-04-24T13:33:24Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,818 |
["docs/docs/manual/running.md", "docs/versioned_docs/version-3.4/manual/running.md", "docs/versioned_docs/version-3.5/manual/running.md"]
|
Command line options documentation are inconsistent
|
In https://docs.openrefine.org/manual/running we indicate `-Drefine.headless=true` as the option to add to run OpenRefine in headless mode. But trying it with `./refine -Drefine.headless=true` does not work. Instead `./refine -x refine.headless=true` does.
There seems to be a discrepancy between the syntax on the command line (`-x`) and in `refine.ini` (`-D`). The documentation should make that clear. Ideally we should probably avoid this difference of syntaxes.
### To Reproduce
Run `./refine -Drefine.headless=true`
### Current Results
The syntax is rejected.
### Versions<!-- (please complete the following information)-->
- Operating System: Linux
- OpenRefine: master branch
|
https://github.com/OpenRefine/OpenRefine/issues/3818
|
https://github.com/OpenRefine/OpenRefine/pull/4545
|
6cefaff09edecc3bb7cae26b0e828141b717294f
|
ad008cfa77e2811266e733fa33cc9ce3b33830ed
| 2021-04-15T12:50:31Z |
java
| 2022-02-18T07:06:25Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,809 |
["main/webapp/modules/core/scripts/dialogs/extend-data-preview-dialog.js"]
|
Type-ahead property selection fails with CORS exception in data-extension panel
|
### To Reproduce
Configure OpenRefine with a reconciliation service that provides a property suggestion service.
The manifest for such service includes:
"suggest": {
...
"property": {
"service_path": "/suggest/property",
"service_url": "http://dock05:8080",
"flyout_service_path": "/flyout/property?id=${id}"
},
...
Reconcile against that reconciliation server, then on the reconciled column menu select "Edit column" then "Add columns from reconciled values".
Start typing in the "Add property" text box
### Current Results
Instead of receiving suggestions as expected the browser consoles shows: "Sorry, something went wrong. Please try again later"
At the same time the browser console shows:
project-bundle.js:10439 Cross-Origin Read Blocking (CORB) blocked cross-origin response http://dock05:8080/suggest/property?callback=jQuery112406009935240625213_1618220980169&prefix=d&spell=always&exact=false&scoring=schema&prefixed=true with MIME type application/json. See https://www.chromestatus.com/feature/5629709824032768 for more details.
|
https://github.com/OpenRefine/OpenRefine/issues/3809
|
https://github.com/OpenRefine/OpenRefine/pull/3810
|
acc68187cb73e0eddbc018e86a6698ce623570c6
|
c19aa3546f918ff3c3ea95b90b9413d3f1a1b799
| 2021-04-12T09:56:16Z |
java
| 2021-04-14T20:04:14Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,805 |
["main/src/com/google/refine/ProjectMetadata.java", "main/src/com/google/refine/io/FileProjectManager.java", "main/src/com/google/refine/io/ProjectMetadataUtilities.java", "main/tests/server/src/com/google/refine/io/FileProjectManagerTests.java"]
|
Workspace files being written unnecessarily
|
### Current Results
It looks like all of the individual projects' `metadata.json` files are getting written every 5 minutes, even if the project hasn't been modified in any way - or even opened. This is both wasteful and error prone because it provides many more windows for project corruption when no file write is needed.
### Expected Behavior
File updates should be minimized and restricted to those that are actually needed. Unmodified files should not be re-written.
### Screenshots
### Versions<!-- (please complete the following information)-->
- Operating System: macOS 11.2.3 Big Sure
- Browser Version: Chrome Version 89.0.4389.90 (Official Build) (x86_64)
- JRE or JDK Version: bundled
- OpenRefine: 3.4.1
|
https://github.com/OpenRefine/OpenRefine/issues/3805
|
https://github.com/OpenRefine/OpenRefine/pull/6026
|
1717ddf03fb81ba22999f099c2921eb4ffc0905f
|
bbfdd9a25eee5d69a81a52975fb40f61a100546a
| 2021-04-11T00:32:42Z |
java
| 2023-09-25T13:05:23Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,800 |
["extensions/gdata/src/com/google/refine/extension/gdata/GoogleAPIExtension.java"]
|
Can't import Google Sheet while logged in
|
If I log into OpenRefine with a Google account, trying to import a Google Spreadsheet results in an unhandled exception that leaves the UI with a endless `Preparing...` message.
The issue is the same one described in #3604, but back then it was misinterpreted that the issue was not being signed in - while it was a coding bug issue all along.
### To Reproduce
Steps to reproduce the behavior:
1. Navigate to `Create Project` -> `Google Data`.
2. `Sign in` with a Google account (Google Suite - ie, custom domains - isn't working _at all_ at the moment). Go through the OAuth consent flow and accept.
3. On the list of `Authorized Documents`, select any spreadsheet.
### Current Results
A modal with a loading spinner and the `Preparing...` text appears, but never finishes. The server's console shows an unhandled exception.
```
19:25:22.708 [..etty.server.HttpChannel] /command/core/importing-controller (24365ms)
java.lang.NullPointerException
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:880)
at com.google.api.client.util.Preconditions.checkNotNull(Preconditions.java:125)
at com.google.api.client.auth.oauth2.Credential$Builder.<init>(Credential.java:637)
at com.google.refine.extension.gdata.GoogleAPIExtension.getSheetsService(GoogleAPIExtension.java:166)
at com.google.refine.extension.gdata.GDataImportingController.getWorksheetEntriesForDoc(GDataImportingController.java:217)
at com.google.refine.extension.gdata.GDataImportingController.doInitializeParserUI(GDataImportingController.java:197)
at com.google.refine.extension.gdata.GDataImportingController.doPost(GDataImportingController.java:98)
at com.google.refine.commands.importing.ImportingControllerCommand.doPost(ImportingControllerCommand.java:68)
at com.google.refine.RefineServlet.service(RefineServlet.java:187)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
at org.eclipse.jetty.servlet.ServletHolder$NotAsyncServlet.service(ServletHolder.java:1395)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:755)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1617)
at org.eclipse.jetty.servlets.GzipFilter.doFilter(GzipFilter.java:50)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1596)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:545)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:590)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1607)
at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1297)
at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:485)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1577)
at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1212)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at com.google.refine.ValidateHostHandler.handle(ValidateHostHandler.java:96)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at org.eclipse.jetty.server.Server.handle(Server.java:500)
at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:383)
at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:547)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:375)
at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:270)
at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103)
at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at java.base/java.lang.Thread.run(Thread.java:832)
```
### Expected Behavior
The modal should close and move on to the next step for Project creation, with the selected spreadsheet's data.
### Screenshots
<img width="1792" alt="Screen Shot 2021-04-09 at 02 41 36" src="https://user-images.githubusercontent.com/5470539/114134037-65520300-98dd-11eb-9ef0-c1e5588839bf.png">
### Versions<!-- (please complete the following information)-->
- Operating System: macOS 10.15.7
- Browser Version: Chrome 89
- JRE or JDK Version: `openjdk version "15.0.2" 2021-01-19`, `OpenJDK Runtime Environment (build 15.0.2+7-27)`, `OpenJDK 64-Bit Server VM (build 15.0.2+7-27, mixed mode, sharing)`
- OpenRefine: OpenRefine `3.4-beta-997-gdf5401388` (built from source by running `./refine`)
|
https://github.com/OpenRefine/OpenRefine/issues/3800
|
https://github.com/OpenRefine/OpenRefine/pull/3801
|
26eaacefc630214e35770069011eb148bb2ef2b4
|
282cfa6e930025e98d43f83eca2b5d44f034573f
| 2021-04-09T05:46:45Z |
java
| 2021-06-28T07:35:05Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,797 |
[".github/workflows/pull_request.yml", ".github/workflows/snapshot_release.yml"]
|
CI: all tests are failing due to the incorrect syntax of setup-java GitHub action
| null |
https://github.com/OpenRefine/OpenRefine/issues/3797
|
https://github.com/OpenRefine/OpenRefine/pull/3798
|
d27e59b75f035596ebbc72ce6a02d182e87c573e
|
df540138858499feefc52d1a1750870f49d9d850
| 2021-04-08T17:47:29Z |
java
| 2021-04-08T20:31:08Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,785 |
["main/src/com/google/refine/model/Recon.java", "main/tests/server/src/com/google/refine/model/ReconTests.java"]
|
"Use values as identifiers" via Wikidata QIDs reconciles to wrong items
|
I have a list of Wikidata QIDs and I want to use them in an import. Thus, I proceed to simple reconciliation via identifier values ("Use values as identifiers"). However, As many as 1 % of QIDs get erroneously paired to a completely different ID. This is hard to spot and leads to nonsense getting imported into Wikidata.
### To Reproduce
Steps to reproduce the behavior:
1. Download a list of QIDs, eg: https://w.wiki/3ACf (CSV) and import as a new OpenRefine project
2. First column--> Use values as identifiers.
3. Extract reconciled QID from 1st column via "cell.recon.match.id".
4. compare 1st column values with values in the column created in (3).
### Expected Behavior
I'd like all QIDs to be reconciled without mistake.
### Screenshots
<img width="259" alt="Bez názvu" src="https://user-images.githubusercontent.com/21329813/113614253-8d7a0180-9652-11eb-96d7-e54a643508c4.png">
### Versions<!-- (please complete the following information)-->
- Operating System: Windows 10,
- Browser Version: Newest Chrome
- OpenRefine: 3.4.1.
### Datasets
Linked from above. But this has happened to me on numerous occassions.
|
https://github.com/OpenRefine/OpenRefine/issues/3785
|
https://github.com/OpenRefine/OpenRefine/pull/4217
|
00e425fd9bc52c1bd35ea2e9cadf36aa9e7a5121
|
c71dee891c94b3e25f587c12e62c95d166a3d49d
| 2021-04-05T19:06:55Z |
java
| 2021-10-20T09:28:42Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,782 |
["main/src/log4j.properties", "server/src/log4j.properties"]
|
Generous logging since the Jetty upgrade
|
Since the Jetty upgrade we have more logging lines showing up by default:
```
20:06:58.400 [...eclipse.jetty.util.log] Logging initialized @386ms to org.eclipse.jetty.util.log.Slf4jLog (0ms)
20:06:58.416 [ refine_server] Starting Server bound to '127.0.0.1:3333' (16ms)
20:06:58.416 [ refine_server] refine.memory size: 1400M JVM Max heap: 1468006400 (0ms)
20:06:58.548 [ refine_server] Initializing context: '/' from '/home/antonin/Programmation/ORmaster/main/webapp' (132ms)
20:06:58.690 [ refine_server] Starting autoreloading scanner... (142ms)
20:06:58.832 [..pse.jetty.server.Server] jetty-9.4.26.v20200117; built: 2020-01-17T12:35:33.676Z; git: 7b38981d25d14afb4a12ff1f2596756144edf695; jvm 11.0.11-ea+4-post-Debian-1 (142ms)
20:06:59.579 [..dardDescriptorProcessor] NO JSP Support for /, did not find org.eclipse.jetty.jsp.JettyJspServlet (747ms)
20:06:59.594 [..se.jetty.server.session] DefaultSessionIdManager workerName=node0 (15ms)
20:06:59.594 [..se.jetty.server.session] No SessionScavenger set, using defaults (0ms)
20:06:59.597 [..se.jetty.server.session] node0 Scavenging every 600000ms (3ms)
20:06:59.634 [..util.DeprecationWarning] Using @Deprecated Class org.eclipse.jetty.servlets.GzipFilter (37ms)
20:06:59.636 [..tty.servlets.GzipFilter] GzipFilter is deprecated. Use GzipHandler (2ms)
20:06:59.683 [...handler.ContextHandler] Started o.e.j.w.WebAppContext@6a6cb05c{OpenRefine,/,file:///home/antonin/Programmation/ORmaster/main/webapp/,AVAILABLE}{/home/antonin/Programmation/ORmaster/main/webapp} (47ms)
20:06:59.719 [..erver.AbstractConnector] Started ServerConnector@5b464ce8{HTTP/1.1,[http/1.1]}{127.0.0.1:3333} (36ms)
20:06:59.719 [..pse.jetty.server.Server] Started @1726ms (0ms)
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/antonin/Programmation/ORmaster/main/webapp/WEB-INF/lib/slf4j-log4j12-1.7.30.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/antonin/Programmation/ORmaster/server/target/lib/slf4j-log4j12-1.7.30.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
20:07:01.663 [ refine] Starting OpenRefine 3.5-beta [09c2e06]... (0ms)
20:07:01.665 [ refine] initializing FileProjectManager with dir (2ms)
20:07:01.665 [ refine] /tmp/data (0ms)
20:07:01.686 [ FileProjectManager] Using workspace directory: /tmp/data (21ms)
20:07:01.692 [ FileProjectManager] Loading workspace: /tmp/data/workspace.json (6ms)
20:07:01.693 [ FileProjectManager] Loading workspace: /tmp/data/workspace.temp.json (1ms)
20:07:01.693 [ FileProjectManager] Loading workspace: /tmp/data/workspace.old.json (0ms)
20:07:01.693 [ FileProjectManager] Failed to load workspace from any attempted alternatives. (0ms)
20:07:01.713 [ butterfly] Starting butterfly ... (20ms)
20:07:01.713 [ butterfly] Properties loaded from /home/antonin/Programmation/ORmaster/main/webapp/WEB-INF/butterfly.properties (0ms)
20:07:01.713 [ butterfly] Autoreloading is enabled (0ms)
20:07:01.782 [ butterfly] > process properties (69ms)
20:07:01.783 [ butterfly] Butterfly home: /home/antonin/Programmation/ORmaster/main/webapp (1ms)
20:07:01.784 [ butterfly] < process properties (1ms)
20:07:01.784 [ butterfly] > load modules (0ms)
20:07:01.863 [ butterfly] < load modules (79ms)
20:07:01.864 [ butterfly] > create modules (1ms)
20:07:01.943 [ butterfly] < create modules (79ms)
20:07:01.944 [ butterfly] > load module wirings (1ms)
20:07:01.944 [ butterfly] Loaded module wirings from: /home/antonin/Programmation/ORmaster/main/webapp/WEB-INF/modules.properties (0ms)
20:07:01.945 [ butterfly] < load module wirings (1ms)
20:07:01.945 [ butterfly] > wire modules (0ms)
20:07:01.945 [ butterfly] mounting modules (0ms)
20:07:01.946 [ butterfly] No mount point defined for module 'database', mounting to '/extension/database' (1ms)
20:07:01.946 [ butterfly] No mount point defined for module 'jython', mounting to '/extension/jython' (0ms)
20:07:01.946 [ butterfly] No mount point defined for module 'phonetic', mounting to '/extension/phonetic' (0ms)
20:07:01.947 [ butterfly] No mount point defined for module 'pc-axis', mounting to '/extension/pc-axis' (1ms)
20:07:01.947 [ butterfly] No mount point defined for module 'gdata', mounting to '/extension/gdata' (0ms)
20:07:01.947 [ butterfly] No mount point defined for module 'wikidata', mounting to '/extension/wikidata' (0ms)
20:07:01.947 [ butterfly] No mount point defined for module 'sample', mounting to '/extension/sample' (0ms)
20:07:01.948 [ butterfly] < wire modules (1ms)
20:07:01.948 [ butterfly] > configure modules (0ms)
20:07:02.914 [ butterfly] < configure modules (966ms)
20:07:02.914 [ butterfly] > initialize modules (0ms)
20:07:10.375 [ butterfly] < initialize modules (7461ms)
20:07:10.377 [ butterfly] GET / [main] (2ms)
20:07:11.157 [ butterfly] GET /wirings.js [main] (780ms)
20:07:11.160 [ butterfly] GET /styles/common.less [main] (3ms)
20:07:11.169 [ butterfly] GET /styles/util/encoding.less [main] (9ms)
20:07:11.177 [ butterfly] GET /styles/util/dialog.less [main] (8ms)
20:07:11.192 [ butterfly] GET /index-bundle.js [main] (15ms)
20:07:11.200 [ butterfly] GET /styles/pure.css [main] (8ms)
20:07:11.228 [ butterfly] GET /styles/index.less [main] (28ms)
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.mozilla.javascript.MemberBox (file:/home/antonin/Programmation/ORmaster/main/webapp/WEB-INF/lib/js-1.7R2.jar) to method sun.net.www.protocol.file.FileURLConnection.getInputStream()
WARNING: Please consider reporting this to the maintainers of org.mozilla.javascript.MemberBox
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
20:07:11.286 [ butterfly] GET /styles/index/create-project-ui.less [main] (58ms)
20:07:11.363 [ butterfly] GET /styles/index/open-project-ui.less [main] (77ms)
20:07:11.398 [ butterfly] GET /styles/index/import-project-ui.less [main] (35ms)
20:07:11.472 [ butterfly] GET /styles/index/default-importing-controller.less [main] (74ms)
20:07:11.493 [ butterfly] GET /styles/index/default-importing-file-selection-panel.less [main] (21ms)
20:07:11.521 [ butterfly] GET /styles/index/default-importing-parsing-panel.less [main] (28ms)
20:07:11.527 [ butterfly] GET /styles/index/default-importing-sources.less [main] (6ms)
20:07:11.575 [ butterfly] GET /externals/jquery-ui/css/ui-lightness/jquery-ui.css [main] (48ms)
20:07:11.580 [ butterfly] GET /externals/tablesorter/theme.blue.css [main] (5ms)
20:07:11.584 [ butterfly] GET /externals/select2/select2.css [main] (4ms)
20:07:11.615 [ butterfly] GET /styles/views/data-table-view.less [main] (31ms)
20:07:11.625 [ butterfly] GET /styles/index/fixed-width-parser-ui.less [main] (10ms)
20:07:11.626 [ butterfly] GET /styles/jquery-ui-overrides.less [main] (1ms)
20:07:11.638 [ butterfly] GET /styles/index/xml-parser-ui.less [main] (12ms)
20:07:11.672 [ butterfly] GET /styles/index/json-parser-ui.less [main] (34ms)
20:07:11.699 [ butterfly] GET /extension/database/styles/pure.css [main] (27ms)
20:07:11.702 [ butterfly] GET /styles/index/wikitext-parser-ui.less [main] (3ms)
20:07:11.709 [ butterfly] GET /extension/database/styles/jquery.contextMenu.css [main] (7ms)
20:07:11.729 [ butterfly] GET /extension/database/styles/bootstrap.css [main] (20ms)
20:07:11.750 [ butterfly] GET /extension/database/styles/database-import.less [main] (21ms)
20:07:11.768 [ butterfly] GET /extension/gdata/styles/importing-controller.less [main] (18ms)
20:07:11.931 [ butterfly] GET /images/logo-gem-126.png [main] (163ms)
20:07:11.948 [ butterfly] GET /images/logo-openrefine-550.png [main] (17ms)
20:07:12.227 [ refine] POST /command/core/load-language (279ms)
20:07:12.322 [ refine] GET /command/core/get-preference (95ms)
20:07:12.400 [ refine] POST /command/core/load-language (78ms)
20:07:12.419 [ refine] POST /command/core/load-language (19ms)
20:07:12.443 [ refine] POST /command/core/load-language (24ms)
20:07:12.504 [ butterfly] GET /scripts/index/create-project-ui-source-selection.html [main] (61ms)
20:07:12.617 [ butterfly] GET /scripts/index/create-project-progress-panel.html [main] (113ms)
20:07:12.782 [ butterfly] GET /scripts/index/create-project-error-panel.html [main] (165ms)
20:07:12.823 [ refine] POST /command/core/get-importing-configuration (41ms)
20:07:12.829 [ butterfly] GET /scripts/index/open-project-ui.html [main] (6ms)
20:07:12.880 [ refine] GET /command/core/get-all-project-tags (51ms)
20:07:12.927 [ refine] GET /command/core/get-all-project-metadata (47ms)
20:07:12.966 [ butterfly] GET /scripts/index/import-project-ui.html [main] (39ms)
20:07:12.996 [ refine] GET /command/core/get-csrf-token (30ms)
20:07:13.023 [ butterfly] GET /scripts/index/lang-settings-ui.html [main] (27ms)
20:07:13.080 [ refine] GET /command/core/get-languages (57ms)
20:07:13.212 [ refine] GET /command/core/get-version (132ms)
20:07:13.590 [ refine] GET /command/core/get-csrf-token (378ms)
20:07:13.593 [ refine] GET /command/core/get-csrf-token (3ms)
20:07:13.600 [ butterfly] GET /scripts/index/default-importing-sources/import-from-computer-form.html [main] (7ms)
20:07:13.631 [ refine] POST /command/core/set-preference (31ms)
20:07:13.634 [ refine] POST /command/core/set-preference (3ms)
20:07:13.678 [ butterfly] GET /scripts/index/default-importing-sources/import-from-web-form.html [main] (44ms)
20:07:13.710 [ butterfly] GET /scripts/index/default-importing-sources/import-from-clipboard-form.html [main] (32ms)
20:07:13.743 [ butterfly] GET /extension/database/scripts/index/database-import-form.html [main] (33ms)
20:07:13.802 [ refine] GET /command/database/saved-connection (59ms)
20:07:13.856 [ butterfly] GET /extension/gdata/scripts/index/import-from-gdata-form.html [main] (54ms)
20:07:13.904 [ butterfly] GET /images/large-spinner.gif [main] (48ms)
```
All the ones that start with `[ butterfly]` are new. It's not clear to me if we want to have them or not. It should be possible to remove if we do not.
|
https://github.com/OpenRefine/OpenRefine/issues/3782
|
https://github.com/OpenRefine/OpenRefine/pull/3827
|
0739a89696a32ac1e1ea9c4abcbacc04b591906a
|
bbec28e67dccac85bd50eae36d18e9e22a5fd22f
| 2021-04-03T18:15:38Z |
java
| 2021-05-15T06:50:38Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,764 |
["main/tests/cypress/cypress/support/commands.js"]
|
Fix flaky test 'create_project'
|
Create_project.spec.js is overall flaky and creates a lots of noise in builds and cypress dashbaord
Example of failed builds
- [782](https://dashboard.cypress.io/projects/s5du3k/runs/782/overview)
- [780](https://dashboard.cypress.io/projects/s5du3k/runs/782/overview)
- [777](https://dashboard.cypress.io/projects/s5du3k/runs/782/overview)
- [773](https://dashboard.cypress.io/projects/s5du3k/runs/782/overview)
|
https://github.com/OpenRefine/OpenRefine/issues/3764
|
https://github.com/OpenRefine/OpenRefine/pull/3767
|
68b148d7755c829cf42fadba5b821c1ba193d050
|
1f9d1252a553b0c03bcfa1c0e0f26388edbeb84b
| 2021-03-22T10:44:00Z |
java
| 2021-03-30T08:02:37Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,750 |
["main/webapp/modules/core/MOD-INF/controller.js"]
|
Replace deprecated "for each...in" syntax in controller.js of the main module
|
There are several pieces of code in [controller.js of the main module](https://github.com/OpenRefine/OpenRefine/blob/master/main/webapp/modules/core/MOD-INF/controller.js) that use the deprecated "for each...in" syntax, and Intellij IDEA cannot recognize that syntax.
According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/For-each-in_loops_are_deprecated, we should replace the "for each...in" syntax with "for...in" (also supported by the js engine we're currently using) instead.
|
https://github.com/OpenRefine/OpenRefine/issues/3750
|
https://github.com/OpenRefine/OpenRefine/pull/3753
|
0f024d833ee2e4ae3272b940e652bfac40bac76c
|
deae864bcad4b12a0660e3bc28dae65c190acc07
| 2021-03-18T09:06:15Z |
java
| 2021-03-18T12:47:31Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,747 |
["docs/docs/manual/running.md"]
|
Typo in docs on automating OpenRefine
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
### To Reproduce
Steps to reproduce the behavior:
1. Go to [link](https://docs.openrefine.org/manual/running/#automating-openrefine)
2. Notice that the first link referenced there is [broken](https://docs.openrefine.org/manual/running/running#reusing-operations)
### Current Results
<!-- What results occurred or were shown. -->
Page not found
### Expected Behavior
<!-- A clear and concise description of what you expected to happen or to show. -->
Page found
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: <!-- e.g. iOS, Windows 10, Linux, Ubuntu 18.04 --> All
- Browser Version: <!-- e.g. Chrome 19, Firefox 61, Safari, NOTE: OpenRefine does not support IE but works OK in most cases --> All
- JRE or JDK Version: <!-- output of "java -version" e.g. JRE 1.8.0_181 --> Any
- OpenRefine: <!-- e.g. OpenRefine 3.0 Beta] --> n/a
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
<!-- Add any other context about the problem here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/3747
|
https://github.com/OpenRefine/OpenRefine/pull/3748
|
2a6003c5d2681d8fa006af733b7dad60e1fd1b9d
|
9e7a30b6e26e63da88f2da5b135fee95b72e61c2
| 2021-03-18T00:03:57Z |
java
| 2021-03-18T06:55:44Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,745 |
["extensions/wikidata/src/org/openrefine/wikidata/commands/LoginCommand.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/commands/LoginCommandTest.java"]
|
Invalid characters in cookies set by the Wikibase extension
|
As part of the update of Jetty I am also upgrade the javax.servlet-api, from
```
<dependency>
<groupId>javax.servlet</groupId>
<artifactId>servlet-api</artifactId>
<version>2.5</version>
</dependency>
```
to
```
<dependency>
<groupId>javax.servlet</groupId>
<artifactId>javax.servlet-api</artifactId>
<version>3.1.0</version>
</dependency>
```
And that introduces new checks on cookie keys (in the `Cookie` constructor). We seem to use cookies such as "https://www.wikidata.org/w/api.php-wb-consumer-token"
This raises exceptions: `java.lang.IllegalArgumentException: Cookie name "https://www.wikidata.org/w/api.php-wb-consumer-token" is a reserved token`
It seems to be because characters like `:` are not allowed in cookie names.
https://stackoverflow.com/questions/1969232/what-are-allowed-characters-in-cookies
We should transform the wikibase endpoint to remove special characters before including it in the cookie name.
|
https://github.com/OpenRefine/OpenRefine/issues/3745
|
https://github.com/OpenRefine/OpenRefine/pull/3746
|
2cd7e903bcd83a15857ca786067cf4c8db857ec7
|
2a6003c5d2681d8fa006af733b7dad60e1fd1b9d
| 2021-03-17T15:02:06Z |
java
| 2021-03-18T06:47:38Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,740 |
["main/src/com/google/refine/importers/OdsImporter.java", "main/src/com/google/refine/util/ParsingUtilities.java", "main/tests/data/dates.xls", "main/tests/server/src/com/google/refine/importers/ExcelImporterTests.java"]
|
Timezone-dependent test fails in CET
|
One of our tests fails when it is run in Central European Time:
```
OdsImporterTests.readOds:113 expected [2012-03-28] but found [2012-03-27]
```
### To Reproduce
Steps to reproduce the behavior:
1. First, change your timezone to CET
2. Then, `./refine test`
### Versions<!-- (please complete the following information)-->
- Operating System: Debian
- JRE or JDK Version: 11
- OpenRefine: master
|
https://github.com/OpenRefine/OpenRefine/issues/3740
|
https://github.com/OpenRefine/OpenRefine/pull/3825
|
bbec28e67dccac85bd50eae36d18e9e22a5fd22f
|
787c272fe0b49267b2919af0e922f1b7ca00b94e
| 2021-03-17T07:11:23Z |
java
| 2021-05-15T06:51:04Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,734 |
["main/tests/cypress/cypress/support/openrefine_api.js"]
|
Testing method to create a project fails for large datasets
|
For testing purpose (Cypress), there is a method to create a project based on a dataset passed as parameter.
This method fails is the provided dataset is too large
### To Reproduce
Create a test that starts with the following
```
const fixture = [
['Name', 'Street', 'City', 'State/Province', 'Country', 'Postal code'],
['Jacques Cousteau', '23 quai de Conti', 'Paris', '', 'France', '75270'],
[
'Emmy Noether',
'010 N Merion Avenue',
'Bryn Mawr',
'Pennsylvania',
'USA',
'19010',
],
['Jacques Cousteau', '23 quai de Conti', 'Paris', '', 'France', '75270'],
['Jacques Cousteau', '23 quai de Conti', 'Paris', '', 'France', '75270'],
['Jacques Cousteau', '23 quai de Conti', 'Paris', '', 'France', '75270'],
['Jacques Cousteau', '23 quai de Conti', 'Paris', '', 'France', '75270'],
['Jacques Cousteau', '23 quai de Conti', 'Paris', '', 'France', '75270'],
['Jacques Cousteau', '23 quai de Conti', 'Paris', '', 'France', '75270'],
];
cy.loadAndVisitProject(fixture);
```
### Current Results
the project is created but empty
### Expected Behavior
The project created with all rows
|
https://github.com/OpenRefine/OpenRefine/issues/3734
|
https://github.com/OpenRefine/OpenRefine/pull/3735
|
4009ddae81228b3a1b3ce362869415d7a0f02cbf
|
2cd7e903bcd83a15857ca786067cf4c8db857ec7
| 2021-03-16T21:36:13Z |
java
| 2021-03-17T10:26:35Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,730 |
["main/webapp/modules/core/scripts/views/data-table/cell-ui.js"]
|
Preview & View services amputate ids with a hash character "#"
|
### To Reproduce
Configure a reconciliation service that returns URIs as IDs.
Hovering over reconciliation suggestions, automatically matched values and manually mapped values will fail to retrieve the preview information as ID contained in the callback is truncated.
|
https://github.com/OpenRefine/OpenRefine/issues/3730
|
https://github.com/OpenRefine/OpenRefine/pull/3731
|
7e9210c87d22efd889e97db1607fe5da1c1e7d39
|
aa1b61769c6dc4d2dff5b175a0dab5171304938d
| 2021-03-16T10:14:30Z |
java
| 2021-10-19T13:47:10Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,724 |
["main/src/com/google/refine/commands/project/ExportRowsCommand.java"]
|
Output filename with exotic characters is corrupted
|
East Asian Characters in Project name are corrupted in exported files.
### To Reproduce
1. First, import the attached xls file, which has a filename of German-Japanese-French-Chinese characters.(and contains such characters inside cells too). Project names are not corrupted.
[äöüßいろはにàçéùè§繁體字.xls.zip](https://github.com/OpenRefine/OpenRefine/files/6144916/aouss.aceue.xls.zip)
2. Then, Export data as tsv/csv/excel
3. Finally, the output filename is "äöüß????àçéùè§???-xls.csv". German/French are preserved but Japanese /Chinese are not.
### Versions<!-- (please complete the following information)-->
- Operating System: Mac OS
- Browser Version: Firefox 61, Safari
- JRE or JDK Version: java version "11.0.1" 2018-10-16 LTS/Java(TM) SE Runtime Environment 18.9 (build 11.0.1+13-LTS)/Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.1+13-LTS, mixed mode
- OpenRefine: 3.5-SNAPSHOT
### Additional context
The problem of the same kind on importing files with exotic characters is perfectly resolved. Huge thanks to dev team!
|
https://github.com/OpenRefine/OpenRefine/issues/3724
|
https://github.com/OpenRefine/OpenRefine/pull/3736
|
b8475ca7be46bb031b6f08763c8742e9e920c3bd
|
5bbc4ae3042f2a22e3c3a5d459a7d6444f43c91e
| 2021-03-15T22:55:19Z |
java
| 2021-03-17T07:28:21Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,719 |
["main/src/com/google/refine/io/FileProjectManager.java", "main/tests/server/src/com/google/refine/io/FileProjectManagerTests.java"]
|
Can't see projects (but can open them)
|
No project is showing in open project dialog box, only overlapping All a and Browse workspace directory buttons (same like https://github.com/OpenRefine/OpenRefine/issues/3277). I am able to open workspace directory and I am able to open the projects using direct link (http://127.0.0.1:3333/project?project=xxx).
### To Reproduce
I have deleted one project directory from workspace directory.
### Screenshots
<a href="https://ibb.co/Df8SRJf"><img src="https://i.ibb.co/Df8SRJf/OpRef.jpg" alt="OpRef" border="0"></a>
### Versions
- Operating System: Windows 7
- Browser Version: Chrome 89
- OpenRefine: OpenRefine 3.4.1
|
https://github.com/OpenRefine/OpenRefine/issues/3719
|
https://github.com/OpenRefine/OpenRefine/pull/4796
|
acbf61f60eb591b66890017b0cd3108592fd1df0
|
cfb222608281f87690aeb0f64052ca784ba5380e
| 2021-03-14T21:43:57Z |
java
| 2022-05-30T12:01:41Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,700 |
["docs/docs/manual/reconciling.md"]
|
Reconciling one project against another??
|
<!-- Please provide a clear and concise description of your problem or unsatisfied needs. Ex. I'm always frustrated when [...] or, It would be easier if OpenRefine did [...]. This comment can be deleted, if desired, but it will be hidden in your final submission. Please make sure that your new text is outside the enclosing angle brackets. -->
This actually less of a real feature request than it is a brainstorming exercise. Feel free to close if there’s likely to be no time for it.
The [reconcile-csv](http://okfnlabs.org/reconcile-csv/) reconciliation service could be used to reconcile one project against another by simply exporting the latter as a csv and then supplying the desired id and name columns to pick what to resolve to and what to resolve against.
This makes me wonder if this step is really necessary.
### Proposed solution
<!-- If you have a proposal for how this need could be met, please provide a clear and concise description of what you want to happen. -->
You could have reconciling one project against another as a feature of OpenRefine. You would supply a column of unique ids and a column of what to reconcile against and simply run the reconciliation. There are design choices about how to ensure unique ids but I think this is doable.
Moreover, clustering is just a special case of this where a project is reconciled against itself with the clustering column representing both the ids and the value to reconcile against. So there is a potential to consolidate the underlying code.
You could even serve up the reconciliation service as `http://127.0.0.1/reconcile/<project name or id>/<id col>/<reconcile column>` with the benefit being to keep the API consistent.
Given that clustering is available I’d think most of the pieces would be readily at hand.
Like I said, this is more imagineering than an actual feature request, but I thought I would toss it out there. I’m sorry if it comes across as noise.
Regards,
### Alternatives considered
<!-- If there alternative solutions that you have considered or think should be considered, please list them here -->
Simply continue using tools like reconcile-csv.
### Additional context
<!-- Add any other context or screenshots about the feature request here. -->
|
https://github.com/OpenRefine/OpenRefine/issues/3700
|
https://github.com/OpenRefine/OpenRefine/pull/3703
|
9760380150dc9e74c55940e7fa08545c6f1b72a5
|
4d5188a9750bcc2f399ea9669ff320827cd8c0c6
| 2021-03-05T07:57:02Z |
java
| 2021-03-08T18:03:22Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,694 |
["extensions/wikidata/src/org/openrefine/wikidata/schema/WbDateConstant.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbDateConstantTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WbDateVariableTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/schema/WikibaseSchemaTest.java", "extensions/wikidata/tests/src/org/openrefine/wikidata/testing/TestingData.java"]
|
timestamp for Wikidata export: +2021-00-00 versus +2021-01-01
|
When exporting dates with a precision smaller than days, OpenRefine (Version 3.4.1) seems to export the year 1883 (as a random example) as +1883-01-01T00:00:00Z both with the export tool and QuickStatements.
However, if I understand those links correctly, it should be +1883-00-00T00:00:00Z (even though this isn’t ISO style):
https://www.wikidata.org/wiki/Help:Dates#Time_datatype
https://www.wikidata.org/wiki/Wikidata:Project_chat/Archive/2021/02#Dates_with_%3C11_precision
https://www.mediawiki.org/wiki/Wikibase/DataModel#Dates_and_times
While an argument could be made that Wikibase should normalize those entries, this isn’t the case at the moment, so I wondered if you could adjust OpenRefine’s behaviour. Thank you!
|
https://github.com/OpenRefine/OpenRefine/issues/3694
|
https://github.com/OpenRefine/OpenRefine/pull/3887
|
dd822526e9ff4b4e14e5f27a17bafed4bbbe7745
|
b481387d73ac3bce394f313b291df81a872d36a1
| 2021-03-04T11:28:40Z |
java
| 2021-05-10T07:08:02Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,678 |
["main/tests/cypress/cypress/integration/create-project/create_project.spec.js", "main/tests/cypress/cypress/integration/create-project/preview_project.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/facet/scatterplot-facet.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/reconcile/facets/by_judgment.spec.js", "main/tests/cypress/cypress/integration/project/grid/column/reconcile/reconcile.spec.js", "main/tests/cypress/cypress/integration/tutorial/importing-data-into-openrefine.spec.js", "main/tests/cypress/cypress/support/commands.js", "main/webapp/modules/core/scripts/index/default-importing-controller/controller.js"]
|
Create Project from CSV test failing with "finallyCallBack is not a function"
|
The PR where this test failed is a minor backend dependency update, so I don't think it introduced the test failure.
https://github.com/OpenRefine/OpenRefine/runs/1995643484?check_suite_focus=true
```
cypress/integration/create-project/create_project.spec.js Test the create project from Web URL based on CSV:
1) cypress/integration/create-project/create_project.spec.js Test the create project from Web URL based on CSV
cypress/integration/create-project/create_project.spec.js Test the create project from Multiple Web URLs based on CSV:
✓ cypress/integration/create-project/create_project.spec.js Test the create project from Multiple Web URLs based on CSV: 6055ms
5 passing (46s)
1 failing
1) cypress/integration/create-project/create_project.spec.js
Test the create project from Web URL based on CSV:
TypeError: The following error originated from your application code, not from Cypress.
> finallyCallBack is not a function
When Cypress detects uncaught errors originating from your application it will automatically fail the current test.
This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event.
https://on.cypress.io/uncaught-exception-from-application
at Object.success (http://127.0.0.1:3333/index-bundle.js:35855:13)
at fire (http://127.0.0.1:3333/index-bundle.js:3234:31)
at Object.fireWith [as resolveWith] (http://127.0.0.1:3333/index-bundle.js:3364:7)
at done (http://127.0.0.1:3333/index-bundle.js:9842:14)
at XMLHttpRequest.callback (http://127.0.0.1:3333/index-bundle.js:10313:8)
```
|
https://github.com/OpenRefine/OpenRefine/issues/3678
|
https://github.com/OpenRefine/OpenRefine/pull/4014
|
dbaa80a2eb59f782492fc1bf6eb04352dd2a6098
|
91440b4cfb26958fdc5f06856355d79ad925c81d
| 2021-02-28T20:10:02Z |
java
| 2021-06-26T10:45:28Z |
closed
|
OpenRefine/OpenRefine
|
https://github.com/OpenRefine/OpenRefine
| 3,672 |
["main/webapp/modules/core/scripts/dialogs/extend-data-preview-dialog.js"]
|
Data extension service not using CORS
|
<!-- Describe the bug - Please add a clear and concise description of the bug above this line. You can delete this line if you want. It will be hidden in the final bug report -->
### To Reproduce
Steps to reproduce the behavior:
1. Implement a data reconciliation service with the data extension service specified in the service manifest.
2. Open the browser web console.
3. Finally, try to "Add columns from reconciled values"
### Current Results
Currently you get back a blank form with no properties for selection. I think given the bug from this issue it probably should have shown an error to the user. But when you look in the web console, you can see that the request was using JSONP.
``` sh
GET http://127.0.0.1:5000/properties?type=&callback=jQuery1111022504064285953862_1613364041041&_=1613364041042
```
### Expected Behavior
<!-- A clear and concise description of what you expected to happen or to show. -->
Similar to reconciliation, I would have expected it to try to use CORS first and fallback to JSONP.
### Screenshots
<!-- If applicable, add screenshots to help explain your problem. -->
### Versions<!-- (please complete the following information)-->
- Operating System: <!-- e.g. iOS, Windows 10, Linux, Ubuntu 18.04 -->
- Browser Version: <!-- e.g. Chrome 19, Firefox 61, Safari, NOTE: OpenRefine does not support IE but works OK in most cases -->
- JRE or JDK Version: <!-- output of "java -version" e.g. JRE 1.8.0_181 -->
- OpenRefine: <!-- e.g. OpenRefine 3.0 Beta] -->
### Datasets
<!-- If you are allowed and are OK with making your data public, it would be awesome if you can include or attach the data causing the issue or a URL pointing to where the data is.
If you are concerned about keeping your data private, ping us on our [mailing list](https://groups.google.com/forum/#!forum/openrefine) -->
### Additional context
<!-- Add any other context about the problem here. -->
I can provide a sample service demonstrating this bug if you like. Please let me know. I think the code making this request is [here](https://github.com/OpenRefine/OpenRefine/blob/6c47c81e5913d64ea58952454a1d67750fff2ff0/main/webapp/modules/core/scripts/dialogs/extend-data-preview-dialog.js#L98). It looks like recon [calls ajax directly](https://github.com/OpenRefine/OpenRefine/blob/82b1cf0bfaf3c8ab57a12e0f2004bdeb71432383/main/webapp/modules/core/scripts/reconciliation/recon-manager.js#L93) rather than with the [jQuery shorthand](https://api.jquery.com/jquery.getjson/).
For clarity, this is using OpenRefine 3.4.1 on a Mac with FF 84.0.1.
[EDIT: You can see the use of JSONP from the web console using the Wikidata reconciliation service, so no need to implement your own service.]
|
https://github.com/OpenRefine/OpenRefine/issues/3672
|
https://github.com/OpenRefine/OpenRefine/pull/3710
|
b455dc577a2348a3e49ca1e00b4862c951adeb06
|
50a905e9da5ac93152e93c81361e91ad6c8984d2
| 2021-02-26T00:16:46Z |
java
| 2021-03-12T10:47:22Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.