status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,901 | [".github/workflows/ci.yml"] | ci: failure in Windows MSVC build | https://github.com/bitcoin/bitcoin/actions/runs/6902633477/job/18779735457#step:20:2859:
```bash
LINK : fatal error C1900: Il mismatch between 'P1' version '20230904' and 'P2' version '20221215' [D:\a\bitcoin\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
LINK : fatal error LNK1257: code generation failed [D:\a\bitcoin\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
LINK : fatal error LNK1327: failure during running link.exe [D:\a\bitcoin\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
``` | https://github.com/bitcoin/bitcoin/issues/28901 | https://github.com/bitcoin/bitcoin/pull/28905 | d752349029ec7a76f1fd440db2ec2e458d0f3c99 | daa56f7f665183bcce3df146f143be37f33c123e | 2023-11-17T11:01:35Z | c++ | 2023-11-21T11:07:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,850 | ["src/init.cpp"] | Manpage for `-par` bolds lower bound | ```
\fB\-par=\fR<n>
.IP
Set the number of script verification threads (\fB\-10\fR to 15, 0 = auto, <0 =
leave that many cores free, default: 0)
```
`\fB` makes the `-10` bold, as if it were a parameter rather than a value.
(Additionally, the `-10` comes from the system of whoever ran the gen-manpages script, and should probably be generated deterministically here...) | https://github.com/bitcoin/bitcoin/issues/28850 | https://github.com/bitcoin/bitcoin/pull/28858 | 8992a34ee4b6941eb823f47fd9b1803489af94a8 | 830583eb9d07e054c54a177907a98153ab3e29ae | 2023-11-10T23:13:51Z | c++ | 2023-11-14T15:45:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,800 | ["src/wallet/scriptpubkeyman.cpp", "src/wallet/walletutil.h", "test/functional/test_runner.py", "test/functional/wallet_miniscript.py"] | test: wallet_miniscript.py fails with thread sanitizer | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
Using clang version 15.0.7 on Ubuntu and enabling the thread sanitizer, the `wallet_miniscript.py --descriptors` test consistently fails with a timeout.
### Expected behaviour
Don't timeout.
I could of course increate the timeouts, but this is the only test with that issue.
As an aside, the log output contains extremely long descriptors which should probably be truncated.
### Steps to reproduce
```
./autogen
./configure CC=clang CXX=clang++ --enable-suppress-external-warnings --with-sanitizers=thread --without-gui
make -j33
test/functional/wallet_miniscript.py --descriptors
```
### Relevant log output
Full log: https://termbin.com/p81f
```
2023-11-06T03:18:08.275000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
File "/home/sjors/dev/bitcoin/test/functional/test_framework/authproxy.py", line 151, in _get_response
http_response = self.__conn.getresponse()
File "/home/sjors/.pyenv/versions/3.9.18/lib/python3.9/http/client.py", line 1377, in getresponse
response.begin()
File "/home/sjors/.pyenv/versions/3.9.18/lib/python3.9/http/client.py", line 320, in begin
version, status, reason = self._read_status()
File "/home/sjors/.pyenv/versions/3.9.18/lib/python3.9/http/client.py", line 281, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/home/sjors/.pyenv/versions/3.9.18/lib/python3.9/socket.py", line 704, in readinto
return self._sock.recv_into(b)
socket.timeout: timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/sjors/dev/bitcoin/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "/home/sjors/dev/bitcoin/test/functional/wallet_miniscript.py", line 386, in run_test
self.signing_test(desc, None, None, 1, 3, None)
File "/home/sjors/dev/bitcoin/test/functional/wallet_miniscript.py", line 258, in signing_test
res = self.ms_sig_wallet.importdescriptors(
File "/home/sjors/dev/bitcoin/test/functional/test_framework/coverage.py", line 50, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/home/sjors/dev/bitcoin/test/functional/test_framework/authproxy.py", line 127, in __call__
response, status = self._request('POST', self.__url.path, postdata.encode('utf-8'))
File "/home/sjors/dev/bitcoin/test/functional/test_framework/authproxy.py", line 106, in _request
return self._get_response()
File "/home/sjors/dev/bitcoin/test/functional/test_framework/authproxy.py", line 153, in _get_response
raise JSONRPCException({
test_framework.authproxy.JSONRPCException: 'importdescriptors' RPC took longer than 240.000000 seconds. Consider using larger timeout for calls that take longer to return. (-344)
2023-11-06T03:18:08.335000Z TestFramework (INFO): Stopping nodes
2023-11-06T03:18:08.335000Z TestFramework.node0 (ERROR): Unable to stop node.
Traceback (most recent call last):
File "/home/sjors/dev/bitcoin/test/functional/test_framework/test_node.py", line 361, in stop_node
self.stop(wait=wait)
File "/home/sjors/dev/bitcoin/test/functional/test_framework/coverage.py", line 50, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/home/sjors/dev/bitcoin/test/functional/test_framework/authproxy.py", line 127, in __call__
response, status = self._request('POST', self.__url.path, postdata.encode('utf-8'))
File "/home/sjors/dev/bitcoin/test/functional/test_framework/authproxy.py", line 105, in _request
self.__conn.request(method, path, postdata, headers)
File "/home/sjors/.pyenv/versions/3.9.18/lib/python3.9/http/client.py", line 1285, in request
self._send_request(method, url, body, headers, encode_chunked)
File "/home/sjors/.pyenv/versions/3.9.18/lib/python3.9/http/client.py", line 1296, in _send_request
self.putrequest(method, url, **skips)
File "/home/sjors/.pyenv/versions/3.9.18/lib/python3.9/http/client.py", line 1122, in putrequest
raise CannotSendRequest(self.__state)
http.client.CannotSendRequest: Request-sent
```
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
master@953d302a242381ae13112ea42f87d57e6e796147
### Operating system and version
Ubuntu 23.04
### Machine specifications
AMD Ryzen 7950x
`/tmp` is mounted to tmpfs | https://github.com/bitcoin/bitcoin/issues/28800 | https://github.com/bitcoin/bitcoin/pull/28799 | 4cebad4833804189bade4fa694b413ce47872ce7 | 0f5e31ce7d743683527ede1c9c8033e22cd4554a | 2023-11-06T03:28:08Z | c++ | 2023-11-06T20:18:45Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,720 | ["test/functional/feature_taproot.py", "test/functional/mempool_datacarrier.py", "test/functional/p2p_net_deadlock.py", "test/functional/rpc_psbt.py", "test/functional/test_framework/util.py"] | test: Replace random_bytes() with random.randbytes() | ### Motivation
Now that Python3.9 is available, the `random_bytes` helper function can be removed.
### Possible solution
_No response_
### Useful Skills
* Compiling Bitcoin Core from source
* Running the C++ unit tests and the Python functional tests
* Python 3.9
### Guidance for new contributors
Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/28720 | https://github.com/bitcoin/bitcoin/pull/28727 | 42b0d5f59b868e8ed5ae6c7df3bc133f79e3bfb3 | f0284706546e5ae1118f52c5d96e1e7c90d71063 | 2023-10-24T17:10:44Z | c++ | 2023-10-29T09:14:59Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,718 | ["src/bench/pool.cpp", "src/coins.h", "src/support/allocators/pool.h", "src/test/pool_tests.cpp"] | v26.0 Testing | Umbrella issue for 26.0 testing. Please help testing on a wide variety of supported platforms, as well as interaction with different software.
Let us know which version you tested on which operating system.
If you find an issue, please search Github for known issues first and then open a new Github issue.
*This meta issue should not be used to report bugs, as a single thread makes it impossible to track more than one topic.*
See [26.0 Draft Release Notes](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/26.0-Release-Notes-Draft) for a list of changes.
See here for the testing guide: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/26.0-Release-Candidate-Testing-Guide. | https://github.com/bitcoin/bitcoin/issues/28718 | https://github.com/bitcoin/bitcoin/pull/28913 | 640b45053020cbbd0af4f4b53ed1b742b6232fb2 | e9beaa749c998ad86e97c98025125cafeec6c9de | 2023-10-24T11:05:21Z | c++ | 2023-11-22T11:15:27Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,665 | ["src/Makefile.test.include", "src/test/fuzz/i2p.cpp"] | 'std::out_of_range' crash in I2P fuzz test | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
I got a `std::out_of_range` crash during merging fuzz outputs in the `i2p` target (see log below.) I was not able to reproduce the crash when re-running the seed with the fuzz executable in the regular build, but I figured I’d share it here if someone else wants to take a look. The binaries used for the merge and the reproduction were both built from the latest master: `738ef44abb6895dad016d8f32f7d7fa1c251b354`.
### Expected behaviour
If this issue can be reproduced, it may point at a bug in the I2P fuzzer or the I2P code.
### Steps to reproduce
You can recreate the seed with:
`echo "wIA9ID0gUkVTVUxUPU9LClBSSVY9gD0gPSBSRVNVTFQ9T0sKUFJJVj0CAAD//13/GhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoAEBoaGhoaGhoaGhoaGhouGhoaGhoaGhoaGhoaGn4aGhoaGhoaGgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABoAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAaABoaGhoaGhpXGhoAGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGurq6mrqUFBQUFBQUFBQUFBQUOrq6gAAAABbAAAAAAAAAAAAAAAAAAAAAgAAeHh4eHh4eHgpeHh4eHh4eHh4eHgaGhoaGhoaGhoaGho=" | base64 -d crash-946784c8f03d9aeeef70e22b346a069e6940e186`
### Relevant log output
```
Run i2p with args /home/murch/Workspace/qa-merge/src/test/fuzz/fuzz -set_cover_merge=1 -shuffle=0 -prefer_small=1 -use_value_profile=0 /tmp/merge-all/i2p ../qa-assets/fuzz_seed_corpus/i2p ../qa-assets-active-fuzzing/fuzz_seed_corpus/i2p
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 2619897554
INFO: Loaded 1 modules (380311 inline 8-bit counters): 380311 [0x55a029467ca0, 0x55a0294c4a37),
INFO: Loaded 1 PC tables (380311 PCs): 380311 [0x55a0294c4a38,0x55a029a923a8),
MERGE-OUTER: 14141 files, 0 in the initial corpus, 0 processed earlier
MERGE-OUTER: attempt 1
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 3047975919
INFO: Loaded 1 modules (380311 inline 8-bit counters): 380311 [0x563efb209ca0, 0x563efb266a37),
INFO: Loaded 1 PC tables (380311 PCs): 380311 [0x563efb266a38,0x563efb8343a8),
INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 1048576 bytes
MERGE-INNER: using the control file '/tmp/libFuzzerTemp.Merge17284.txt'
MERGE-INNER: 14141 total files; 0 processed earlier; will process 14141 files now
#1 pulse cov: 244 exec/s: 0 rss: 88Mb
#2 pulse cov: 245 exec/s: 0 rss: 88Mb
#4 pulse cov: 245 exec/s: 0 rss: 88Mb
#8 pulse cov: 245 exec/s: 0 rss: 88Mb
#16 pulse cov: 263 exec/s: 0 rss: 88Mb
#32 pulse cov: 300 exec/s: 0 rss: 88Mb
#64 pulse cov: 313 exec/s: 0 rss: 88Mb
#128 pulse cov: 336 exec/s: 0 rss: 88Mb
#256 pulse cov: 417 exec/s: 0 rss: 88Mb
#512 pulse cov: 435 exec/s: 0 rss: 88Mb
#1024 pulse cov: 455 exec/s: 1024 rss: 88Mb
#2048 pulse cov: 485 exec/s: 1024 rss: 88Mb
#4096 pulse cov: 538 exec/s: 682 rss: 88Mb
terminate called after throwing an instance of 'std::out_of_range'
what(): vector::_M_range_check: __n (which is 385) >= this->size() (which is 0)
==17287== ERROR: libFuzzer: deadly signal
#0 0x563ef9f7eda4 in __sanitizer_print_stack_trace (/home/murch/Workspace/qa-merge/src/test/fuzz/fuzz+0x9bfda4) (BuildId: 1f28ec48de7ec8f793559abd4fba645f972afe4f)
#1 0x563ef9f56248 in fuzzer::PrintStackTrace() (/home/murch/Workspace/qa-merge/src/test/fuzz/fuzz+0x997248) (BuildId: 1f28ec48de7ec8f793559abd4fba645f972afe4f)
#2 0x563ef9f3c2d3 in fuzzer::Fuzzer::CrashCallback() (/home/murch/Workspace/qa-merge/src/test/fuzz/fuzz+0x97d2d3) (BuildId: 1f28ec48de7ec8f793559abd4fba645f972afe4f)
#3 0x7fa19a83c45f (/lib/x86_64-linux-gnu/libc.so.6+0x3c45f) (BuildId: ff2d8e707625b73b293961a4bc168e373d14a44a)
#4 0x7fa19a89152a in __pthread_kill_implementation nptl/pthread_kill.c:43:17
#5 0x7fa19a89152a in __pthread_kill_internal nptl/pthread_kill.c:78:10
#6 0x7fa19a89152a in pthread_kill nptl/pthread_kill.c:89:10
#7 0x7fa19a83c3b5 in raise signal/../sysdeps/posix/raise.c:26:13
#8 0x7fa19a82287b in abort stdlib/abort.c:79:7
#9 0x7fa19aca4ee5 (/lib/x86_64-linux-gnu/libstdc++.so.6+0xa4ee5) (BuildId: 1fcdadafe5a79e1031ab0da645aa3798954cf53d)
#10 0x7fa19acb6e9b (/lib/x86_64-linux-gnu/libstdc++.so.6+0xb6e9b) (BuildId: 1fcdadafe5a79e1031ab0da645aa3798954cf53d)
#11 0x7fa19acb6f06 in std::terminate() (/lib/x86_64-linux-gnu/libstdc++.so.6+0xb6f06) (BuildId: 1fcdadafe5a79e1031ab0da645aa3798954cf53d)
#12 0x7fa19acb7167 in __cxa_throw (/lib/x86_64-linux-gnu/libstdc++.so.6+0xb7167) (BuildId: 1fcdadafe5a79e1031ab0da645aa3798954cf53d)
#13 0x7fa19aca82ba (/lib/x86_64-linux-gnu/libstdc++.so.6+0xa82ba) (BuildId: 1fcdadafe5a79e1031ab0da645aa3798954cf53d)
#14 0x563efa269705 in std::vector<unsigned char, std::allocator<unsigned char>>::_M_range_check(unsigned long) const /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_vector.h:1153:4
#15 0x563efa269705 in std::vector<unsigned char, std::allocator<unsigned char>>::at(unsigned long) const /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_vector.h:1194:2
#16 0x563efa269705 in i2p::sam::Session::MyDestination() const src/i2p.cpp:354:38
#17 0x563efa269705 in i2p::sam::Session::CreateIfNotCreatedAlready() src/i2p.cpp:405:40
#18 0x563efa268664 in i2p::sam::Session::Listen(i2p::Connection&) src/i2p.cpp:143:9
#19 0x563efa07c088 in i2p_fuzz_target(Span<unsigned char const>) src/test/fuzz/i2p.cpp:38:14
#20 0x563ef9f8269e in void std::__invoke_impl<void, void (*&)(Span<unsigned char const>), Span<unsigned char const>>(std::__invoke_other, void (*&)(Span<unsigned char const>), Span<unsigned char const>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/invoke.h:61:14
#21 0x563ef9f8269e in std::enable_if<is_invocable_r_v<void, void (*&)(Span<unsigned char const>), Span<unsigned char const>>, void>::type std::__invoke_r<void, void (*&)(Span<unsigned char const>), Span<unsigned char const>>(void (*&)(Span<unsigned char const>), Span<unsigned char const>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/invoke.h:111:2
#22 0x563ef9f8269e in std::_Function_handler<void (Span<unsigned char const>), void (*)(Span<unsigned char const>)>::_M_invoke(std::_Any_data const&, Span<unsigned char const>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/std_function.h:290:9
#23 0x563efa1dd075 in std::function<void (Span<unsigned char const>)>::operator()(Span<unsigned char const>) const /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/std_function.h:591:9
#24 0x563efa1dd075 in LLVMFuzzerTestOneInput src/test/fuzz/fuzz.cpp:178:5
#25 0x563ef9f3d742 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (/home/murch/Workspace/qa-merge/src/test/fuzz/fuzz+0x97e742) (BuildId: 1f28ec48de7ec8f793559abd4fba645f972afe4f)
#26 0x563ef9f47445 in fuzzer::Fuzzer::CrashResistantMergeInternalStep(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, bool) (/home/murch/Workspace/qa-merge/src/test/fuzz/fuzz+0x988445) (BuildId: 1f28ec48de7ec8f793559abd4fba645f972afe4f)
#27 0x563ef9f2d5cd in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (/home/murch/Workspace/qa-merge/src/test/fuzz/fuzz+0x96e5cd) (BuildId: 1f28ec48de7ec8f793559abd4fba645f972afe4f)
#28 0x563ef9f56a82 in main (/home/murch/Workspace/qa-merge/src/test/fuzz/fuzz+0x997a82) (BuildId: 1f28ec48de7ec8f793559abd4fba645f972afe4f)
#29 0x7fa19a823a8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
#30 0x7fa19a823b48 in __libc_start_main csu/../csu/libc-start.c:360:3
#31 0x563ef9f22074 in _start (/home/murch/Workspace/qa-merge/src/test/fuzz/fuzz+0x963074) (BuildId: 1f28ec48de7ec8f793559abd4fba645f972afe4f)
NOTE: libFuzzer has rudimentary signal handlers.
Combine libFuzzer with AddressSanitizer or similar for better crash reports.
SUMMARY: libFuzzer: deadly signal
MS: 0 ; base unit: 0000000000000000000000000000000000000000
artifact_prefix='./'; Test unit written to ./crash-946784c8f03d9aeeef70e22b346a069e6940e186
```
```
➜ qa-merge git:(merge-fuzz) ✗ FUZZ=i2p src/test/fuzz/fuzz crash-946784c8f03d9aeeef70e22b346a069e6940e186
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 3335468885
INFO: Loaded 1 modules (380311 inline 8-bit counters): 380311 [0x5612fee10ca0, 0x5612fee6da37),
INFO: Loaded 1 PC tables (380311 PCs): 380311 [0x5612fee6da38,0x5612ff43b3a8),
src/test/fuzz/fuzz: Running 1 inputs 1 time(s) each.
Running: crash-946784c8f03d9aeeef70e22b346a069e6940e186
Executed crash-946784c8f03d9aeeef70e22b346a069e6940e186 in 0 ms
***
*** NOTE: fuzzing was not performed, you have only
*** executed the target code on a fixed set of inputs.
***
```
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
738ef44abb6895dad016d8f32f7d7fa1c251b354
### Operating system and version
Ubuntu 23.04
### Machine specifications
_No response_ | https://github.com/bitcoin/bitcoin/issues/28665 | https://github.com/bitcoin/bitcoin/pull/28692 | 3c856e2fe86ae7d245de09921bd1df15f02c93a3 | abfc8c901df6853c1a52b7350f4c18dc70269ec9 | 2023-10-17T13:46:16Z | c++ | 2023-10-20T14:30:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,638 | ["Makefile.am", "src/bitcoin-tx.cpp", "test/util/data/bitcoin-util-test.json", "test/util/data/txreplace1.hex", "test/util/data/txreplacenoinputs.hex", "test/util/data/txreplaceomittedn.hex", "test/util/data/txreplacesingleinput.hex"] | bitcoin-tx replaceable value should be optional, but isn't | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
The help text says:
```
replaceable(=N)
Set RBF opt-in sequence number for input N (if not provided, opt-in all
available inputs)
```
but when I don't provide N, I get an error:
```
$ bitcoin-tx -create in=0000000000000000000000000000000000000000000000000000000000000000:0 replaceable
error: Invalid TX input index ''
```
### Expected behaviour
I expect bitcoin-tx to act like its help string describes:
```
$ bitcoin-tx -create in=0000000000000000000000000000000000000000000000000000000000000000:0 replaceable
020000000100000000000000000000000000000000000000000000000000000000000000000000000000fdffffff0000000000
```
The fix is simple:
```
diff --git a/src/bitcoin-tx.cpp b/src/bitcoin-tx.cpp
index a05443a2e5..b9348fcad0 100644
--- a/src/bitcoin-tx.cpp
+++ b/src/bitcoin-tx.cpp
@@ -222,7 +222,7 @@ static void MutateTxRBFOptIn(CMutableTransaction& tx, const std::string& strInId
{
// parse requested index
int64_t inIdx;
- if (!ParseInt64(strInIdx, &inIdx) || inIdx < 0 || inIdx >= static_cast<int64_t>(tx.vin.size())) {
+ if (strInIdx != "" && (!ParseInt64(strInIdx, &inIdx) || inIdx < 0 || inIdx >= static_cast<int64_t>(tx.vin.size()))) {
throw std::runtime_error("Invalid TX input index '" + strInIdx + "'");
}
```
### Steps to reproduce
Run the command shown above.
### Relevant log output
_No response_
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
master@e3eb3aae3
### Operating system and version
Debian 12
### Machine specifications
_No response_ | https://github.com/bitcoin/bitcoin/issues/28638 | https://github.com/bitcoin/bitcoin/pull/29022 | e6dbf48c64a3c267425911d768a77b95a6c3d078 | 4d7b787ad630495a02092269339fedcef31c24d4 | 2023-10-11T22:40:50Z | c++ | 2023-12-14T18:54:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,603 | ["test/functional/feature_init.py"] | Extend feature_init.py file perturbations | ### Motivation
`feature_init.py` is a functional test that perturbs various files in the data directory (simulation data corruption), and checks the response during startup.
Recently, this test was improved in #27823, but there were some open suggestions in, in particular https://github.com/bitcoin/bitcoin/pull/27823#discussion_r1267289758, to extend and/or randomize the way files are perturbed.
There is also the possibility that more sophisticated perturbations could potentially uncover other unhandled exceptions/assert crashes like the one fixed in #27823.
### Possible solution
_No response_
### Useful Skills
* Python
* Debugging the bitcoin core C++ file parsing code in order to understand why certain perturbation lead to certain errors.
### Guidance for new contributors
Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/28603 | https://github.com/bitcoin/bitcoin/pull/28612 | 0f5e31ce7d743683527ede1c9c8033e22cd4554a | 0387ca0774be0fa05a81cb91f880c53a7ad5fade | 2023-10-05T19:00:50Z | c++ | 2023-11-06T21:57:39Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,601 | ["test/functional/test_framework/wallet_util.py", "test/functional/wallet_createwallet.py", "test/functional/wallet_descriptor.py", "test/functional/wallet_dump.py", "test/functional/wallet_encryption.py", "test/functional/wallet_fundrawtransaction.py", "test/functional/wallet_keypool.py"] | test: unlocked wallet context manager | ### Motivation
Currently tests with a locked wallet have to verbosely specify a long timeout and then lock the wallet again, once they are done testing the unlocked part. This is fragile, because the wallet may lock earlier, or the dev may forget to re-lock the wallet when done.
All issues should be fixed with a context manager.
### Possible solution
A context manager. See also https://github.com/bitcoin/bitcoin/pull/28403#discussion_r1325426430
### Useful Skills
* Compiling Bitcoin Core from source
* Running the C++ unit tests and the Python functional tests
* Python 3 contextlib
### Guidance for new contributors
Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/28601 | https://github.com/bitcoin/bitcoin/pull/28617 | 5eb82d5706ea1b3b9eee2daaf6e47d1405549d4f | 091d29c49590d31dacdace24a8ae0fb781665ed6 | 2023-10-05T15:45:02Z | c++ | 2023-10-19T09:23:44Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,600 | ["test/functional/interface_usdt_coinselection.py", "test/functional/interface_usdt_mempool.py", "test/functional/interface_usdt_net.py", "test/functional/interface_usdt_utxocache.py", "test/functional/interface_usdt_validation.py"] | ci: USDT on mantic | The asan CI uses Ubuntu 23.04, which doesn't have clang-17 and will also be EOL in January:
https://github.com/bitcoin/bitcoin/blob/52c6904c789103a316253df4cb20aa785b2afc42/ci/test/00_setup_env_native_asan.sh#L20
Thus, it would be good to bump to 23.10. However that fails, even outside the CI.
Steps to reproduce on a fresh install of Ubuntu 23.04/10:
```
export DEBIAN_FRONTEND=noninteractive && apt update && apt install curl wget htop git vim ccache -y && git clone https://github.com/bitcoin/bitcoin.git --depth=1 ./bitcoin-core && cd bitcoin-core && apt install build-essential libtool autotools-dev automake pkg-config bsdmainutils python3-zmq libevent-dev libboost-dev systemtap-sdt-dev clang-16 llvm-16 libclang-rt-16-dev bpfcc-tools "linux-headers-$(uname --kernel-release)" -y && ./autogen.sh && ./configure --enable-usdt CC=clang-16 CXX=clang++-16 && make -j $(nproc) && ./test/functional/interface_usdt_mempool.py
```
Output on 23.04: passes
On 23.10:
```
# ./test/functional/interface_usdt_mempool.py
2023-10-05T15:22:55.501000Z TestFramework (INFO): PRNG seed is: 3896309821586557942
2023-10-05T15:22:55.502000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_930vj2wl
2023-10-05T15:22:55.852000Z TestFramework (INFO): Hooking into mempool:added tracepoint...
/virtual/main.c:97:24: error: call to undeclared function '_bpf_readarg_trace_removed_1'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
({ u64 __addr = 0x0; _bpf_readarg_trace_removed_1(ctx, &__addr, sizeof(__addr));bpf_probe_read_user(&removed.hash, HASH_LENGTH, (void *)__addr);});
^
/virtual/main.c:97:24: note: did you mean '_bpf_readarg_trace_added_1'?
/virtual/main.c:13:28: note: '_bpf_readarg_trace_added_1' declared here
static __always_inline int _bpf_readarg_trace_added_1(struct pt_regs *ctx, void *dest, size_t len) {
^
/virtual/main.c:98:24: error: call to undeclared function '_bpf_readarg_trace_removed_2'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
({ u64 __addr = 0x0; _bpf_readarg_trace_removed_2(ctx, &__addr, sizeof(__addr));bpf_probe_read_user(&removed.reason, MAX_REMOVAL_REASON_LENGTH, (void *)__addr);});
^
/virtual/main.c:98:24: note: did you mean '_bpf_readarg_trace_added_2'?
/virtual/main.c:19:28: note: '_bpf_readarg_trace_added_2' declared here
static __always_inline int _bpf_readarg_trace_added_2(struct pt_regs *ctx, void *dest, size_t len) {
^
/virtual/main.c:99:3: error: call to undeclared function '_bpf_readarg_trace_removed_3'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
_bpf_readarg_trace_removed_3(ctx, &removed.vsize, sizeof(*(&removed.vsize)));
^
/virtual/main.c:99:3: note: did you mean '_bpf_readarg_trace_added_3'?
/virtual/main.c:25:28: note: '_bpf_readarg_trace_added_3' declared here
static __always_inline int _bpf_readarg_trace_added_3(struct pt_regs *ctx, void *dest, size_t len) {
^
/virtual/main.c:100:3: error: call to undeclared function '_bpf_readarg_trace_removed_4'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
_bpf_readarg_trace_removed_4(ctx, &removed.fee, sizeof(*(&removed.fee)));
^
/virtual/main.c:101:3: error: call to undeclared function '_bpf_readarg_trace_removed_5'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
_bpf_readarg_trace_removed_5(ctx, &removed.entry_time, sizeof(*(&removed.entry_time)));
^
/virtual/main.c:112:24: error: call to undeclared function '_bpf_readarg_trace_rejected_1'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
({ u64 __addr = 0x0; _bpf_readarg_trace_rejected_1(ctx, &__addr, sizeof(__addr));bpf_probe_read_user(&rejected.hash, HASH_LENGTH, (void *)__addr);});
^
/virtual/main.c:112:24: note: did you mean '_bpf_readarg_trace_added_1'?
/virtual/main.c:13:28: note: '_bpf_readarg_trace_added_1' declared here
static __always_inline int _bpf_readarg_trace_added_1(struct pt_regs *ctx, void *dest, size_t len) {
^
/virtual/main.c:113:24: error: call to undeclared function '_bpf_readarg_trace_rejected_2'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
({ u64 __addr = 0x0; _bpf_readarg_trace_rejected_2(ctx, &__addr, sizeof(__addr));bpf_probe_read_user(&rejected.reason, MAX_REJECT_REASON_LENGTH, (void *)__addr);});
^
/virtual/main.c:113:24: note: did you mean '_bpf_readarg_trace_added_2'?
/virtual/main.c:19:28: note: '_bpf_readarg_trace_added_2' declared here
static __always_inline int _bpf_readarg_trace_added_2(struct pt_regs *ctx, void *dest, size_t len) {
^
/virtual/main.c:124:24: error: call to undeclared function '_bpf_readarg_trace_replaced_1'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
({ u64 __addr = 0x0; _bpf_readarg_trace_replaced_1(ctx, &__addr, sizeof(__addr));bpf_probe_read_user(&replaced.replaced_hash, HASH_LENGTH, (void *)__addr);});
^
/virtual/main.c:124:24: note: did you mean '_bpf_readarg_trace_added_1'?
/virtual/main.c:13:28: note: '_bpf_readarg_trace_added_1' declared here
static __always_inline int _bpf_readarg_trace_added_1(struct pt_regs *ctx, void *dest, size_t len) {
^
/virtual/main.c:125:3: error: call to undeclared function '_bpf_readarg_trace_replaced_2'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
_bpf_readarg_trace_replaced_2(ctx, &replaced.replaced_vsize, sizeof(*(&replaced.replaced_vsize)));
^
/virtual/main.c:125:3: note: did you mean '_bpf_readarg_trace_added_2'?
/virtual/main.c:19:28: note: '_bpf_readarg_trace_added_2' declared here
static __always_inline int _bpf_readarg_trace_added_2(struct pt_regs *ctx, void *dest, size_t len) {
^
/virtual/main.c:126:3: error: call to undeclared function '_bpf_readarg_trace_replaced_3'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
_bpf_readarg_trace_replaced_3(ctx, &replaced.replaced_fee, sizeof(*(&replaced.replaced_fee)));
^
/virtual/main.c:127:3: error: call to undeclared function '_bpf_readarg_trace_replaced_4'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
_bpf_readarg_trace_replaced_4(ctx, &replaced.replaced_entry_time, sizeof(*(&replaced.replaced_entry_time)));
^
/virtual/main.c:128:24: error: call to undeclared function '_bpf_readarg_trace_replaced_5'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
({ u64 __addr = 0x0; _bpf_readarg_trace_replaced_5(ctx, &__addr, sizeof(__addr));bpf_probe_read_user(&replaced.replacement_hash, HASH_LENGTH, (void *)__addr);});
^
/virtual/main.c:129:3: error: call to undeclared function '_bpf_readarg_trace_replaced_6'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
_bpf_readarg_trace_replaced_6(ctx, &replaced.replacement_vsize, sizeof(*(&replaced.replacement_vsize)));
^
/virtual/main.c:130:3: error: call to undeclared function '_bpf_readarg_trace_replaced_7'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
_bpf_readarg_trace_replaced_7(ctx, &replaced.replacement_fee, sizeof(*(&replaced.replacement_fee)));
^
14 errors generated.
2023-10-05T15:22:57.476000Z TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
File "/root/bitcoin-core/test/functional/test_framework/test_framework.py", line 131, in main
self.run_test()
File "/root/bitcoin-core/./test/functional/interface_usdt_mempool.py", line 317, in run_test
self.added_test()
File "/root/bitcoin-core/./test/functional/interface_usdt_mempool.py", line 146, in added_test
bpf = BPF(text=MEMPOOL_TRACEPOINTS_PROGRAM, usdt_contexts=[ctx], debug=0)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/bcc/__init__.py", line 479, in __init__
raise Exception("Failed to compile BPF module %s" % (src_file or "<text>"))
Exception: Failed to compile BPF module <text>
2023-10-05T15:22:57.528000Z TestFramework (INFO): Stopping nodes
2023-10-05T15:22:57.580000Z TestFramework (WARNING): Not cleaning up dir /tmp/bitcoin_func_test_930vj2wl
2023-10-05T15:22:57.580000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/bitcoin_func_test_930vj2wl/test_framework.log
2023-10-05T15:22:57.580000Z TestFramework (ERROR):
2023-10-05T15:22:57.580000Z TestFramework (ERROR): Hint: Call /root/bitcoin-core/test/functional/combine_logs.py '/tmp/bitcoin_func_test_930vj2wl' to consolidate all logs
2023-10-05T15:22:57.580000Z TestFramework (ERROR):
2023-10-05T15:22:57.580000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2023-10-05T15:22:57.580000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues
2023-10-05T15:22:57.580000Z TestFramework (ERROR):
| https://github.com/bitcoin/bitcoin/issues/28600 | https://github.com/bitcoin/bitcoin/pull/28629 | a927d5cabefbb3d2c60d69d6314cb0b768431dac | 06d469c26b556962e0e8e0f141a576b6aea95564 | 2023-10-05T15:23:30Z | c++ | 2023-10-12T10:00:12Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,585 | ["test/functional/feature_assumeutxo.py", "test/functional/test_framework/test_framework.py"] | qa: `feature_assumeutxo.py` fails | https://github.com/bitcoin/bitcoin/actions/runs/6406365281/job/17390816303:
```
284/284 - feature_assumeutxo.py failed, Duration: 2403 s
stdout:
2023-10-04T13:29:47.691000Z TestFramework (INFO): PRNG seed is: 7592694052297737658
2023-10-04T13:29:47.692000Z TestFramework (INFO): Initializing test directory /Users/runner/work/bitcoin/bitcoin/ci/scratch/test_runner/test_runner_₿_🏃_20231004_132534/feature_assumeutxo_47
2023-10-04T13:29:49.351000Z TestFramework (INFO): -- Testing assumeutxo + some indexes + pruning
2023-10-04T13:29:49.355000Z TestFramework (INFO): Creating a UTXO snapshot at height 299
2023-10-04T13:29:49.794000Z TestFramework (INFO): Loading snapshot into second node from /Users/runner/work/bitcoin/bitcoin/ci/scratch/test_runner/test_runner_₿_🏃_20231004_132534/feature_assumeutxo_47/node0/regtest/utxos.dat
2023-10-04T13:29:49.908000Z TestFramework (INFO): Restarting node to stop at height 359
2023-10-04T14:09:50.767000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
self.wait_until(lambda: sum(peer['version'] != 0 for peer in from_connection.getpeerinfo()) == from_num_peers)
'''
2023-10-04T14:09:50.771000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/test_framework.py", line 131, in main
self.run_test()
File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/feature_assumeutxo.py", line 145, in run_test
self.connect_nodes(0, 1)
File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/test_framework.py", line 611, in connect_nodes
self.wait_until(lambda: sum(peer['version'] != 0 for peer in from_connection.getpeerinfo()) == from_num_peers)
File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/test_framework.py", line 740, in wait_until
return wait_until_helper(test_function, timeout=timeout, timeout_factor=self.options.timeout_factor)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/util.py", line 276, in wait_until_helper
raise AssertionError("Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
self.wait_until(lambda: sum(peer['version'] != 0 for peer in from_connection.getpeerinfo()) == from_num_peers)
''' not true after 2400.0 seconds
2023-10-04T14:09:50.855000Z TestFramework (INFO): Stopping nodes
[node 2] Cleaning up leftover process
[node 1] Cleaning up leftover process
[node 0] Cleaning up leftover process
stderr:
Traceback (most recent call last):
File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/feature_assumeutxo.py", line 246, in <module>
AssumeutxoTest().main()
File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/test_framework.py", line 154, in main
exit_code = self.shutdown()
^^^^^^^^^^^^^^^
File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/test_framework.py", line 313, in shutdown
self.stop_nodes()
File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/test_framework.py", line 575, in stop_nodes
node.stop_node(wait=wait, wait_until_stopped=False)
File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/test_node.py", line 357, in stop_node
self.stop(wait=wait)
File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/coverage.py", line 50, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/authproxy.py", line 127, in __call__
response, status = self._request('POST', self.__url.path, postdata.encode('utf-8'))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/runner/work/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-apple-darwin/test/functional/test_framework/authproxy.py", line 105, in _request
self.__conn.request(method, path, postdata, headers)
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/http/client.py", line 1286, in request
self._send_request(method, url, body, headers, encode_chunked)
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/http/client.py", line 1332, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/http/client.py", line 1281, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/http/client.py", line 1041, in _send_output
self.send(msg)
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/http/client.py", line 1002, in send
self.sock.sendall(data)
BrokenPipeError: [Errno 32] Broken pipe
``` | https://github.com/bitcoin/bitcoin/issues/28585 | https://github.com/bitcoin/bitcoin/pull/28589 | 3cd02806ecd2edd08236ede554f1685866625757 | cc68a3b9ddbcbb6d29b67bb92cfe8aac53d4b417 | 2023-10-04T14:18:09Z | c++ | 2023-10-04T17:32:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,572 | ["contrib/devtools/headerssync-params.py", "doc/release-process.md", "src/headerssync.cpp", "src/kernel/chainparams.cpp"] | Update chainparams pre 26.x branch-off | ### Motivation
This should be done before the branch-off, and can be done by anyone, as the steps are reproducible and reviewable.
### Possible solution
Follow the documentation: https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#before-branch-off
### Useful Skills
* Compiling Bitcoin Core from source
* Running the C++ unit tests and the Python functional tests
* ...
### Guidance for new contributors
Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/28572 | https://github.com/bitcoin/bitcoin/pull/28591 | f4674444b21184ee267675eba4886009b4ec619c | 3003861e78a4118ebc8a9063d15de5062bafa4c0 | 2023-10-03T12:38:04Z | c++ | 2023-10-09T13:54:08Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,566 | ["depends/packages/qt.mk", "depends/patches/qt/memory_resource.patch"] | build: depends qt failure with macos 13 & Xcode (tools) 15 | When building qt in depends, on a macOS 13 system, with version 15 of the command line tools, it currently fails to build:
```bash
compiling .moc/moc_qfbscreen_p.cpp
compiling .moc/moc_qfbvthandler_p.cpp
gmake[4]: Entering directory '/bitcoin/depends/work/build/aarch64-apple-darwin22.6.0/qt/5.15.5-8525c199952/qtbase/src/widgets'
uic dialogs/qfiledialog.ui
dyld[55501]: Symbol not found: __ZTVNSt3__13pmr25monotonic_buffer_resourceE
Referenced from: <577DB68A-5C1A-38A3-8285-AC3E88B934FE> /bitcoin/depends/work/build/aarch64-apple-darwin22.6.0/qt/5.15.5-8525c199952/qtbase/bin/uic
Expected in: <3EE92404-8FC3-374B-A598-D5C9A8CD64B5> /usr/lib/libc++.1.dylib
/bin/sh: line 1: 55501 Abort trap: 6 /bitcoin/depends/work/build/aarch64-apple-darwin22.6.0/qt/5.15.5-8525c199952/qtbase/bin/uic dialogs/qfiledialog.ui -o .uic/ui_qfiledialog.h
compiling kernel/qt_widgets_pch.h
gmake[4]: *** [Makefile:72588: .uic/ui_qfiledialog.h] Error 134
```
See discussion in https://github.com/bitcoin/bitcoin/pull/28543#issuecomment-1742666479. May require another patch to Qt. | https://github.com/bitcoin/bitcoin/issues/28566 | https://github.com/bitcoin/bitcoin/pull/28571 | d0b928b29d80267404eef34f722d3fc9f80673ba | 5a4eb56e3fc47fd44dd2efbc55509d0663f9a47c | 2023-10-03T09:31:48Z | c++ | 2023-10-03T14:54:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,541 | ["depends/packages/qt.mk", "depends/patches/qt/fix-macos-linker.patch"] | [depends] qt: "Project ERROR: failed to parse default search paths from compiler output" on macOS 14.0 | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
Running `make -C depends qt` on macOS 14.0 Sonoma produces the following error:
```
Extracting qt...
/Users/.../bitcoin/depends/sources/qtbase-everywhere-opensource-src-5.15.5.tar.xz: OK
/Users/.../bitcoin/depends/sources/qttranslations-everywhere-opensource-src-5.15.5.tar.xz: OK
/Users/.../bitcoin/depends/sources/qttools-everywhere-opensource-src-5.15.5.tar.xz: OK
Preprocessing qt...
patching file 'qtbase/configure'
patching file 'qtbase/mkspecs/features/qt_module.prf'
patching file 'qtbase/src/plugins/platforms/android/androidjnimain.cpp'
patching file 'qtbase/src/plugins/platforms/xcb/qxcbcursor.cpp'
patching file 'qtbase/configure.json'
patching file 'qtbase/configure.pri'
patching file 'qtbase/mkspecs/common/macx.conf'
patching file 'qtbase/mkspecs/features/mac/default_post.prf'
patching file 'qtbase/mkspecs/features/toolchain.prf'
patching file 'qtbase/src/tools/moc/main.cpp'
patching file 'qtbase/src/plugins/platforms/cocoa/qiosurfacegraphicsbuffer.h'
patching file 'qtbase/mkspecs/features/android/default_pre.prf'
patching file 'qtbase/src/tools/rcc/rcc.cpp'
patching file 'qtbase/src/gui/text/qplatformfontdatabase.cpp'
patching file 'qtbase/src/gui/text/qplatformfontdatabase.h'
patching file 'qtbase/src/platformsupport/fontdatabases/mac/qfontengine_coretext.mm'
patching file 'qtbase/src/platformsupport/fontdatabases/mac/qfontengine_coretext_p.h'
patching file 'qtbase/src/platformsupport/fontdatabases/windows/qwindowsfontdatabase.cpp'
patching file 'qtbase/src/platformsupport/fontdatabases/windows/qwindowsfontdatabase_p.h'
patching file 'qtbase/src/platformsupport/themes/genericunix/qgenericunixthemes.cpp'
patching file 'qtbase/src/3rdparty/double-conversion/fixed-dtoa.h'
patching file 'qtbase/mkspecs/features/toolchain.prf'
Configuring qt...
Creating qmake...
Info: creating super cache file /Users/.../bitcoin/depends/work/build/x86_64-apple-darwin23.0.0/qt/5.15.5-723c1c55951/.qmake.super
Info: creating cache file /Users/.../bitcoin/depends/work/build/x86_64-apple-darwin23.0.0/qt/5.15.5-723c1c55951/.qmake.cache
Info: creating stash file /Users/.../bitcoin/depends/work/build/x86_64-apple-darwin23.0.0/qt/5.15.5-723c1c55951/.qmake.stash
Command line: -bindir /Users/.../bitcoin/depends/x86_64-apple-darwin23.0.0/native/bin -c++std c++17 -confirm-license -hostprefix /Users/.../bitcoin/depends/x86_64-apple-darwin23.0.0/native -no-compile-examples -no-cups -no-egl -no-eglfs -no-evdev -no-gif -no-glib -no-icu -no-ico -no-iconv -no-kms -no-linuxfb -no-libjpeg -no-libproxy -no-libudev -no-mimetype-database -no-mtdev -no-openssl -no-openvg -no-reduce-relocations -no-schannel -no-sctp -no-securetransport -no-sql-db2 -no-sql-ibase -no-sql-oci -no-sql-tds -no-sql-mysql -no-sql-odbc -no-sql-psql -no-sql-sqlite -no-sql-sqlite2 -no-system-proxies -no-use-gold-linker -no-zstd -nomake examples -nomake tests -nomake tools -opensource -pkg-config -prefix /Users/.../bitcoin/depends/x86_64-apple-darwin23.0.0 -qt-libpng -qt-pcre -qt-harfbuzz -qt-zlib -static -v -no-feature-bearermanagement -no-feature-colordialog -no-feature-commandlineparser -no-feature-concurrent -no-feature-dial -no-feature-fontcombobox -no-feature-ftp -no-feature-http -no-feature-image_heuristic_mask -no-feature-keysequenceedit -no-feature-lcdnumber -no-feature-networkdiskcache -no-feature-networkproxy -no-feature-pdf -no-feature-printdialog -no-feature-printer -no-feature-printpreviewdialog -no-feature-printpreviewwidget -no-feature-sessionmanager -no-feature-socks5 -no-feature-sql -no-feature-sqlmodel -no-feature-statemachine -no-feature-syntaxhighlighter -no-feature-textbrowser -no-feature-textmarkdownwriter -no-feature-textodfwriter -no-feature-topleveldomain -no-feature-udpsocket -no-feature-undocommand -no-feature-undogroup -no-feature-undostack -no-feature-undoview -no-feature-vnc -no-feature-wizard -no-feature-xml -release -silent -no-dbus -no-opengl -pch -no-feature-corewlan -no-freetype QMAKE_MACOSX_DEPLOYMENT_TARGET=11.0
Project ERROR: failed to parse default search paths from compiler output
make: *** [/Users/.../bitcoin/depends/x86_64-apple-darwin23.0.0/.qt_stamp_configured] Error 3
```
### Expected behaviour
Dependency compilation should work out of the box.
### Steps to reproduce
Check out a fresh repo on a macOS 14.0 system and run `make -C depends qt`
### Relevant log output
_No response_
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
git latest
### Operating system and version
macOS 14.0 Sonoma
### Machine specifications
Both arm64 and x86_64 macs affected. | https://github.com/bitcoin/bitcoin/issues/28541 | https://github.com/bitcoin/bitcoin/pull/28543 | 6f882e6f8689af1f188b687c2128524880815cef | 8113ac0ab4247c29c19746e4a0d03c07b31f0c09 | 2023-09-26T23:34:06Z | c++ | 2023-10-03T09:29:21Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,511 | ["src/pubkey.h", "src/script/descriptor.cpp", "src/test/descriptor_tests.cpp"] | Rule out hybrid keys in output descriptors | @achow101 noted we don't reject them therefore they must be silently accepted. This is not part of the specs, we should remove them. Also cc @sipa.
I can take care of this. | https://github.com/bitcoin/bitcoin/issues/28511 | https://github.com/bitcoin/bitcoin/pull/28587 | d9c1cc5f1f5460f6adcce95779f34f2ed356dda3 | 6e5cf8e95391cd9a8bfc0c357e8a6f3963bad4b4 | 2023-09-20T11:37:05Z | c++ | 2023-10-05T15:58:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,510 | ["src/wallet/wallet.cpp", "test/functional/tool_wallet.py", "test/functional/wallet_migration.py"] | migratewallet crashes on an freshly created datadir ( wallet/wallet.h:959: int wallet::CWallet::GetLastBlockHeight() const: Assertion `m_last_block_processed_height >= 0' failed.) | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
crash
### Expected behaviour
no crash
### Steps to reproduce
```
./src/qt/bitcoin-qt -datadir=/tmp/ -regtest -printtoconsole=1 -nolisten # Create fresh datadir (empty), stop
mv /tmp/reg_scratch/.bitcoin/regtest/wallet.1491854176.bak /tmp/regtest/wallets/ # Move over a wallet file
(Start qt with the same args as above)
(Call migratewallet)
```
### Relevant log output
```
#5 0x0000555555bd2bda in wallet::CWallet::GetTxDepthInMainChain(wallet::CWalletTx const&) const (this=<optimized out>, wtx=<optimized out>) at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/std_function.h:290
#6 wallet::CWallet::MarkConflicted(uint256 const&, int, uint256 const&)::$_0::operator()(wallet::CWalletTx&) const (this=<optimized out>, wtx=<optimized out>) at wallet/wallet.cpp:1351
#7 std::__invoke_impl<wallet::CWallet::TxUpdate, wallet::CWallet::MarkConflicted(uint256 const&, int, uint256 const&)::$_0&, wallet::CWalletTx&>(std::__invoke_other, wallet::CWallet::MarkConflicted(uint256 const&, int, uint256 const&)::$_0&, wallet::CWalletTx&) (__f=<optimized out>, __args=<optimized out>) at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/invoke.h:61
#8 std::__invoke_r<wallet::CWallet::TxUpdate, wallet::CWallet::MarkConflicted(uint256 const&, int, uint256 const&)::$_0&, wallet::CWalletTx&>(wallet::CWallet::MarkConflicted(uint256 const&, int, uint256 const&)::$_0&, wallet::CWalletTx&) (__fn=<optimized out>, __args=<optimized out>) at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/invoke.h:114
#9 std::_Function_handler<wallet::CWallet::TxUpdate (wallet::CWalletTx&), wallet::CWallet::MarkConflicted(uint256 const&, int, uint256 const&)::$_0>::_M_invoke(std::_Any_data const&, wallet::CWalletTx&)
(__functor=<optimized out>, __args=<optimized out>) at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/std_function.h:290
#10 0x0000555555bbb73b in std::function<wallet::CWallet::TxUpdate (wallet::CWalletTx&)>::operator()(wallet::CWalletTx&) const (this=0x7fff417f6bc0, __args=...)
at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/std_function.h:591
#11 wallet::CWallet::RecursiveUpdateTxState(uint256 const&, std::function<wallet::CWallet::TxUpdate (wallet::CWalletTx&)> const&) (this=0x7fff2db509f0, tx_hash=..., try_updating_state=...) at wallet/wallet.cpp:1382
#12 0x0000555555bb9c4b in wallet::CWallet::MarkConflicted(uint256 const&, int, uint256 const&) (this=0x7fff2db509f0, hashBlock=..., conflicting_height=-1, hashTx=...) at wallet/wallet.cpp:1361
#13 0x0000555555bb9b55 in wallet::CWallet::LoadToWallet(uint256 const&, std::function<bool (wallet::CWalletTx&, bool)> const&) (this=0x7fff2db509f0, hash=<optimized out>, fill_wtx=<optimized out>) at wallet/wallet.cpp:1213
#14 0x0000555555bfc8c6 in wallet::LoadTxRecords(wallet::CWallet*, wallet::DatabaseBatch&, std::vector<uint256, std::allocator<uint256> >&, bool&)::$_0::operator()(wallet::CWallet*, DataStream&, CDataStream&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&) const (this=0x7fff417f6ed0, pwallet=0x7fff2db509f0, key=<optimized out>, value=..., err="") at wallet/walletdb.cpp:1065
#15 std::__invoke_impl<wallet::DBErrors, wallet::LoadTxRecords(wallet::CWallet*, wallet::DatabaseBatch&, std::vector<uint256, std::allocator<uint256> >&, bool&)::$_0&, wallet::CWallet*, DataStream&, CDataStream&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&>(std::__invoke_other, wallet::LoadTxRecords(wallet::CWallet*, wallet::DatabaseBatch&, std::vector<uint256, std::allocator<uint256> >&, bool&)::$_0&, wallet::CWallet*&&, DataStream&, CDataStream&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&) (__f=..., __args=<optimized out>, __args=<optimized out>, __args=..., __args="")
at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/invoke.h:61
#16 std::__invoke_r<wallet::DBErrors, wallet::LoadTxRecords(wallet::CWallet*, wallet::DatabaseBatch&, std::vector<uint256, std::allocator<uint256> >&, bool&)::$_0&, wallet::CWallet*, DataStream&, CDataStream&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&>(wallet::LoadTxRecords(wallet::CWallet*, wallet::DatabaseBatch&, std::vector<uint256, std::allocator<uint256> >&, bool&)::$_0&, wallet::CWallet*&&, DataStream&, CDataStream&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&) (__fn=..., __args=<optimized out>, __args=<optimized out>, __args=..., __args="")
at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/invoke.h:114
#17 std::_Function_handler<wallet::DBErrors (wallet::CWallet*, DataStream&, CDataStream&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&), wallet::LoadTxRecords(wallet::CWallet*, wallet::DatabaseBatch&, std::vector<uint256, std::allocator<uint256> >&, bool&)::$_0>::_M_invoke(std::_Any_data const&, wallet::CWallet*&&, DataStream&, CDataStream&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&)
(__functor=..., __args=<optimized out>, __args=<optimized out>, __args=..., __args="") at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/std_function.h:290
#18 0x0000555555bf87dc in std::function<wallet::DBErrors (wallet::CWallet*, DataStream&, CDataStream&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&)>::operator()(wallet::CWallet*, DataStream&, CDataStream&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&) const (this=0x7fff417f6ed0, __args=0x7fff2db509f0, __args=..., __args=..., __args="")
at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/std_function.h:591
#19 wallet::LoadRecords(wallet::CWallet*, wallet::DatabaseBatch&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, DataStream&, std::function<wallet::DBErrors (wallet::CWallet*, DataStream&, CDataStream&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&)>) (pwallet=pwallet@entry=0x7fff2db509f0, batch=..., key="tx", prefix=..., load_func=...) at wallet/walletdb.cpp:509
#20 0x0000555555bf8542 in wallet::LoadRecords(wallet::CWallet*, wallet::DatabaseBatch&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::function<wallet::DBErrors (wallet::CWallet*, DataStream&, CDataStream&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&)>) (pwallet=pwallet@entry=0x7fff2db509f0, batch=..., key="tx", load_func=...) at wallet/walletdb.cpp:523
#21 0x0000555555bf40a2 in wallet::LoadTxRecords(wallet::CWallet*, wallet::DatabaseBatch&, std::vector<uint256, std::allocator<uint256> >&, bool&)
(pwallet=0x7fff2db509f0, batch=..., upgraded_txs=std::vector of length 0, capacity 0, any_unordered=@0x7fff417f6f9f: false) at wallet/walletdb.cpp:1021
#22 wallet::WalletBatch::LoadWallet(wallet::CWallet*) (this=0x7fff417f7208, pwallet=0x7fff2db509f0) at wallet/walletdb.cpp:1187
#23 0x0000555555bc29fd in wallet::CWallet::LoadWallet() (this=0x7fff2db509f0) at wallet/wallet.cpp:2304
#24 0x0000555555bad386 in wallet::CWallet::Create(wallet::WalletContext&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::unique_ptr<wallet::WalletDatabase, std::default_delete<wallet::WalletDatabase> >, unsigned long, bilingual_str&, std::vector<bilingual_str, std::allocator<bilingual_str> >&)
(context=<optimized out>, name="wallet.1491854156.bak", database=std::unique_ptr<wallet::WalletDatabase> = {...}, wallet_creation_flags=0, error=..., warnings=std::vector of length 0, capacity 0) at wallet/wallet.cpp:2868
#25 0x0000555555bcf830 in wallet::MigrateLegacyToDescriptor(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, secure_allocator<char> > const&, wallet::WalletContext&) (wallet_name="wallet.1491854156.bak", passphrase="", context=...) at wallet/wallet.cpp:4169
```
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
current master
### Operating system and version
Linux
### Machine specifications
yes | https://github.com/bitcoin/bitcoin/issues/28510 | https://github.com/bitcoin/bitcoin/pull/28542 | dcf6230f92d491f46d2bf6cfc096ab5874e385c9 | 50f250a67dcc6450abaac2598be0beb86b9e7a48 | 2023-09-20T11:30:03Z | c++ | 2023-10-02T12:27:41Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,491 | ["test/functional/wallet_resendwallettransactions.py"] | test: Intermittent issue in wallet_resendwallettransactions "Unable to create transaction. Fee exceeds maximum configured by user (e.g. -maxtxfee, maxfeerate) (-4)" | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
https://github.com/bitcoin/bitcoin/actions/runs/6198134719/job/16828006466#step:28:2207
```
node0 2023-09-15T14:01:45.132127Z (mocktime: 2023-09-17T02:11:43Z) [D:\a\bitcoin\bitcoin\src\validation.cpp:1102] [Finalize] [mempool] replacing tx bda7041b708336708a9df4bb8c2b5d934439736285253d33820923aaca732b59 (wtxid=f380f631e37abd715addb85cf8a76f27f2df70e7098ba1678cab9bc1f910fb68) with 7c0c53abb2cb5ae0918e761e53bbf1f3fef2b1a1fcb9531fcdbf1642c3cbbef4 (wtxid=183c420f88d2fd222b82c5bb0e5d4aefc51312453c94753f409abad0e0c2d594) for 0.03254028 additional fees, 0 delta bytes
node0 2023-09-15T14:01:45.132212Z (mocktime: 2023-09-17T02:11:43Z) [D:\a\bitcoin\bitcoin\src\validationinterface.cpp:223] [TransactionRemovedFromMempool] [validation] Enqueuing TransactionRemovedFromMempool: txid=bda7041b708336708a9df4bb8c2b5d934439736285253d33820923aaca732b59 wtxid=f380f631e37abd715addb85cf8a76f27f2df70e7098ba1678cab9bc1f910fb68 reason=replaced
node0 2023-09-15T14:01:45.132315Z (mocktime: 2023-09-17T02:11:43Z) [D:\a\bitcoin\bitcoin\src\txmempool.cpp:1029] [RemoveUnbroadcastTx] [mempool] Removed bda7041b708336708a9df4bb8c2b5d934439736285253d33820923aaca732b59 from set of unbroadcast txns before confirmation that txn was sent out
node0 2023-09-15T14:01:45.132414Z (mocktime: 2023-09-17T02:11:43Z) [D:\a\bitcoin\bitcoin\src\validationinterface.cpp:213] [TransactionAddedToMempool] [validation] Enqueuing TransactionAddedToMempool: txid=7c0c53abb2cb5ae0918e761e53bbf1f3fef2b1a1fcb9531fcdbf1642c3cbbef4 wtxid=183c420f88d2fd222b82c5bb0e5d4aefc51312453c94753f409abad0e0c2d594
node0 2023-09-15T14:01:45.132505Z (mocktime: 2023-09-17T02:11:43Z) [D:\a\bitcoin\bitcoin\src\txmempool.cpp:660] [check] [mempool] Checking mempool with 2 transactions and 2 inputs
node0 2023-09-15T14:01:45.132776Z (mocktime: 2023-09-17T02:11:43Z) [D:\a\bitcoin\bitcoin\src\wallet\sqlite.cpp:53] [TraceSqlCallback] [D:\a\_temp\test_runner_₿_🏃_20230915_132301\wallet_resendwallettransactions_69\node0\regtest\default_wallet\wallet.dat] SQLite Statement: INSERT or REPLACE into main values(?, ?)
node0 2023-09-15T14:01:45.133944Z (mocktime: 2023-09-17T02:11:43Z) [D:\a\bitcoin\bitcoin\src\httpserver.cpp:255] [http_request_cb] [http] Received a POST request for / from 127.0.0.1:54896
node0 2023-09-15T14:01:45.134128Z (mocktime: 2023-09-17T02:11:43Z) [D:\a\bitcoin\bitcoin\src\rpc\request.cpp:181] [parse] [rpc] ThreadRPCServer method=syncwithvalidationinterfacequeue user=__cookie__
node0 2023-09-15T14:01:45.134317Z (mocktime: 2023-09-17T02:11:43Z) [D:\a\bitcoin\bitcoin\src\validationinterface.cpp:223] [operator ()] [validation] TransactionRemovedFromMempool: txid=bda7041b708336708a9df4bb8c2b5d934439736285253d33820923aaca732b59 wtxid=f380f631e37abd715addb85cf8a76f27f2df70e7098ba1678cab9bc1f910fb68 reason=replaced
node0 2023-09-15T14:01:45.134416Z (mocktime: 2023-09-17T02:11:43Z) [D:\a\bitcoin\bitcoin\src\validationinterface.cpp:213] [operator ()] [validation] TransactionAddedToMempool: txid=7c0c53abb2cb5ae0918e761e53bbf1f3fef2b1a1fcb9531fcdbf1642c3cbbef4 wtxid=183c420f88d2fd222b82c5bb0e5d4aefc51312453c94753f409abad0e0c2d594
node0 2023-09-15T14:01:45.136375Z (mocktime: 2023-09-17T02:11:43Z) [D:\a\bitcoin\bitcoin\src\wallet\sqlite.cpp:53] [TraceSqlCallback] [D:\a\_temp\test_runner_₿_🏃_20230915_132301\wallet_resendwallettransactions_69\node0\regtest\default_wallet\wallet.dat] SQLite Statement: INSERT or REPLACE into main values(?, ?)
node0 2023-09-15T14:01:45.139157Z (mocktime: 2023-09-17T02:11:43Z) [D:\a\bitcoin\bitcoin\src\wallet\sqlite.cpp:53] [TraceSqlCallback] [D:\a\_temp\test_runner_₿_🏃_20230915_132301\wallet_resendwallettransactions_69\node0\regtest\default_wallet\wallet.dat] SQLite Statement: INSERT or REPLACE into main values(?, ?)
node0 2023-09-15T14:01:45.139450Z (mocktime: 2023-09-17T02:11:43Z) [D:\a\bitcoin\bitcoin\src\wallet\wallet.h:918] [WalletLogPrintf] [default_wallet] AddToWallet 7c0c53abb2cb5ae0918e761e53bbf1f3fef2b1a1fcb9531fcdbf1642c3cbbef4
test 2023-09-15T14:01:45.140000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
File "D:\a\bitcoin\bitcoin\test\functional\test_framework\test_framework.py", line 131, in main
self.run_test()
File "D:\a\bitcoin\bitcoin/test/functional/wallet_resendwallettransactions.py", line 94, in run_test
bumped = node.bumpfee(child_txid)
^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\a\bitcoin\bitcoin\test\functional\test_framework\coverage.py", line 50, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\a\bitcoin\bitcoin\test\functional\test_framework\authproxy.py", line 129, in __call__
raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Unable to create transaction. Fee exceeds maximum configured by user (e.g. -maxtxfee, maxfeerate) (-4)
```
### Expected behaviour
-
### Steps to reproduce
-
### Relevant log output
_No response_
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
-
### Operating system and version
-
### Machine specifications
_No response_ | https://github.com/bitcoin/bitcoin/issues/28491 | https://github.com/bitcoin/bitcoin/pull/28540 | 6619d6a8dca5a4d8e664a76526ac6bef3eb17831 | 9d5150ac47a2e8db0f23a2f04211fec3516afbe1 | 2023-09-15T14:29:12Z | c++ | 2023-09-28T15:22:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,469 | ["src/test/fuzz/fuzz.cpp"] | fuzz: Don't spawn threads prior to __AFL_INIT | Spawning threads prior to `__AFL_INIT` is not supported as the afl++ fork server can't clone threads, see [afl++ docs](https://github.com/AFLplusplus/AFLplusplus/blob/stable/instrumentation/README.persistent_mode.md#3-deferred-initialization).
We however have chosen to do this in several of our targets (e.g. process_message, process_messages) and as a result those targets can not be fuzzed using afl++ (resulting in timeouts). Afaict this is only a problem if the spawned threads are also used (e.g. `join`) in the target.
A potential fix would be to call `initialize` after `__AFL_INIT` but prior to `__AFL_LOOP`, which will however lead to slower fuzzing for all targets.
(I'm uncertain why oss-fuzz does not report the timeouts to us but that seems like an issue on their end) | https://github.com/bitcoin/bitcoin/issues/28469 | https://github.com/bitcoin/bitcoin/pull/28480 | 8ef672937e572e16671fdbfdb5a90eaa882e6ee1 | f608a409f7591b4f5cf170898bee58b9d9dcf1b6 | 2023-09-13T11:11:08Z | c++ | 2023-09-15T09:16:26Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,449 | ["contrib/guix/manifest.scm"] | guix: prune Rust toolchain boostrap from Darwin HOSTS | We once-again have a Rust toolchain bootstrap as part of our Darwin Guix builds. While not necessarily bad, this consumes a fairly significant amount of additional time / resources when bootstrapping, and may make it harder to bootstrap on some platforms. It's probably inevitable that we'll have to bootstrap a Rust toolchain in future (for all HOSTS) whenever Rust becomes a dependency of a more core utility or library, but for now, if it's easy to do, we could prune it out.
The chain to Rust is:
`python-signapple -> python-requests -> python-urllib3 -> python-cryptography -> python-cryptography-rust`.
The easiest solution here might just be to change signapple to not use `python-requests` for it's timestamping POST:
https://github.com/achow101/signapple/blob/48ba6fe3f92ca9e035c5056126524aaea4bfacb0/signapple/sign.py#L267
and use the Python standard library: https://docs.python.org/3/library/urllib.request.html#module-urllib.request instead. | https://github.com/bitcoin/bitcoin/issues/28449 | https://github.com/bitcoin/bitcoin/pull/28759 | 697ded943caab9a993335f27f0606292637b6c1d | 3c0b66c2ece7695ab59f466d7b4d81a4c18ffd76 | 2023-09-11T09:13:36Z | c++ | 2023-10-31T17:09:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,440 | ["src/bench/pool.cpp", "src/coins.h", "src/support/allocators/pool.h", "src/test/pool_tests.cpp"] | Impossible to run bitcoin on a Raspberry Pi 4 with 8GB, on Raspian 64 bit, which ships a 32 bit version of Docker (ARMHF instead of ARM64) | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
```
bitcoind_1 | 2023-09-09T10:04:30Z UpdateTip: new best=00000000000000000a1f0a5dc852ab81d720fb9dceec91bc42f1461a3cf4d3d5 height=371331 version=0x00000003 log2_work=83.254030 tx=81012235 date='2015-08-24T15:55:06Z' progress=0.093034 cache=226.8MiB(31141716txo)
bitcoind_1 | 2023-09-09T10:04:31Z UpdateTip: new best=000000000000000000509e83cabd4f3f02c62638470357eff53275c9532da94f height=371332 version=0x00000003 log2_work=83.254059 tx=81013228 date='2015-08-24T16:03:31Z' progress=0.093036 cache=226.8MiB(31141264txo)
bitcoind_1 | 2023-09-09T10:04:31Z UpdateTip: new best=00000000000000001434c5b3995a1c065fc434fdd1098dbb65020bdf57d90f2a height=371333 version=0x00000003 log2_work=83.254088 tx=81015020 date='2015-08-24T16:21:46Z' progress=0.093038 cache=226.8MiB(31140795txo)
bitcoind_1 | 2023-09-09T10:04:31Z UpdateTip: new best=00000000000000000796a4bd624aeaf6d81b24e666e5db3e7fa62f094df3bc96 height=371334 version=0x00000003 log2_work=83.254117 tx=81015365 date='2015-08-24T16:23:46Z' progress=0.093038 cache=226.8MiB(31141560txo)
bitcoind_1 | 2023-09-09T10:04:32Z UpdateTip: new best=000000000000000006b17425eda94c210ef5111c20c10d1829829d0eeaf905a9 height=371335 version=0x00000003 log2_work=83.254146 tx=81016765 date='2015-08-24T16:35:39Z' progress=0.093040 cache=226.8MiB(31142260txo)
bitcoind_1 | 2023-09-09T10:04:32Z UpdateTip: new best=00000000000000000c684f7fbcbd0bf42879ca1143844d34c5d4ae28358fb41f height=371336 version=0x00000003 log2_work=83.254175 tx=81017385 date='2015-08-24T16:44:52Z' progress=0.093040 cache=226.8MiB(31141393txo)
bitcoind_1 | 2023-09-09T10:04:32Z UpdateTip: new best=00000000000000001004395fb5a59a4d44e51e7f9ff3504c2a5d6e7f06885680 height=371337 version=0x00000003 log2_work=83.254204 tx=81017610 date='2015-08-24T17:00:31Z' progress=0.093041 cache=226.8MiB(31135360txo)
bitcoind_1 | 2023-09-09T10:04:32Z UpdateTip: new best=00000000000000000fb4a9c39dbbf671d79b0eee48cb2f3c85ae39a5005e82d6 height=371338 version=0x00000003 log2_work=83.254234 tx=81019260 date='2015-08-24T17:14:47Z' progress=0.093042 cache=226.8MiB(31134479txo)
bitcoind_1 | 2023-09-09T10:04:33Z UpdateTip: new best=000000000000000006c32b4c4231d2c129a43fae47e2f729530baa1e198a71b8 height=371339 version=0x00000003 log2_work=83.254263 tx=81020779 date='2015-08-24T17:18:04Z' progress=0.093044 cache=226.8MiB(31133741txo)
bitcoind_1 | 2023-09-09T10:04:33Z UpdateTip: new best=0000000000000000101b9824fbbbf52b158c04d33aeab910954cfce6c4c658a6 height=371340 version=0x00000003 log2_work=83.254292 tx=81021579 date='2015-08-24T17:23:07Z' progress=0.093045 cache=226.8MiB(31133299txo)
bitcoind_1 | 2023-09-09T10:04:33Z UpdateTip: new best=000000000000000008aa6cf51dfde20be1d54e671494a44fb7f252fd4e913162 height=371341 version=0x00000003 log2_work=83.254321 tx=81023741 date='2015-08-24T17:44:26Z' progress=0.093048 cache=226.8MiB(31133550txo)
bitcoind_1 | 2023-09-09T10:04:33Z Error: Out of memory. Terminating.
bitcoind_1 | terminate called without an active exception
```
Memory usage at the time it crashed:
```
11:02:02 kbmemfree kbavail kbmemused %memused kbbuffers kbcached kbcommit %commit kbactive kbinact kbdirty
11:02:07 231712 3738772 4107264 51.34 26084 3429852 4710940 38.63 4251760 3238784 93412
11:02:12 231144 3711664 4135192 51.69 25796 3403248 4788664 39.27 4272024 3212576 30548
11:02:17 213516 3723396 4123420 51.54 25812 3432576 4785520 39.24 4268160 3241888 59588
11:02:22 218356 3730188 4116724 51.46 25776 3434476 4786956 39.26 4269748 3243840 89336
11:02:27 228116 3730640 4116264 51.45 25760 3425196 4780584 39.20 4266152 3234516 120972
11:02:32 204724 3713548 4133328 51.67 25456 3431848 4788772 39.27 4272332 3240804 147996
11:02:37 224444 3716164 4131268 51.64 24652 3415048 4788176 39.27 4270996 3223820 15020
11:02:42 253200 3719404 4129136 51.62 25084 3388780 4790644 39.29 4272240 3199076 30304
11:02:47 232160 3710116 4138496 51.73 25476 3399732 4789644 39.28 4273788 3210472 50216
11:02:52 205368 3713000 4135524 51.70 25828 3428468 4789020 39.27 4273788 3239492 76856
11:02:57 211364 3703688 4144752 51.81 25868 3413388 4791064 39.29 4277112 3224240 95920
11:03:02 226660 3704636 4143856 51.80 25712 3399384 4789360 39.28 4276240 3210116 117380
11:03:07 215064 3701712 4146716 51.84 26112 3407656 4795896 39.33 4280708 3218744 145936
11:03:12 207360 3706752 4142552 51.78 26256 3418984 4797584 39.34 4280072 3231016 18036
11:03:17 217064 3715432 4133840 51.67 26256 3417940 4795044 39.32 4279848 3229952 43368
11:03:22 217284 3712796 4136340 51.71 26264 3415216 4794976 39.32 4280332 3227112 73268
11:03:27 210508 3704160 4144884 51.81 26272 3413412 4794444 39.32 4279876 3225244 99088
11:03:32 224988 3703424 4145876 51.82 26232 3398252 4799232 39.36 4283672 3210292 127728
11:03:37 206192 3713316 4136632 51.71 26264 3425568 4799268 39.36 4282624 3238272 148084
11:03:42 212172 3723348 4126960 51.59 26288 3429108 4791204 39.29 4277816 3242172 26408
11:03:47 240548 3725292 4125248 51.57 26276 3403016 4792492 39.30 4280592 3216308 56844
11:03:52 203952 3710732 4139928 51.75 26308 3424324 4797664 39.34 4282804 3237752 78048
11:03:57 215576 3716332 4134396 51.68 26324 3418392 4800320 39.37 4283368 3231808 100300
11:04:02 205540 3705280 4145444 51.82 26348 3417292 4803828 39.39 4285928 3230756 115348
11:04:07 213100 3704864 4145792 51.82 26340 3409512 4804740 39.40 4287800 3222948 135688
11:04:12 214424 3709124 4141832 51.77 26356 3411916 4800868 39.37 4286328 3225704 16632
11:04:17 204652 3702028 4148892 51.86 26356 3414520 4800116 39.36 4287616 3228256 47500
11:04:22 213052 3681992 4168880 52.11 26356 3386772 4812260 39.46 4297872 3200484 77004
11:04:27 208780 3681020 4169712 52.12 26348 3390016 4822388 39.55 4305700 3203616 108244
11:04:32 200124 3665384 4185420 52.32 25968 3383348 4824268 39.56 4307804 3196628 124520
11:04:37 215756 3665912 4184724 52.31 23580 3369252 4824364 39.56 4307996 3180076 494028
11:04:42 1971324 3617144 4184700 52.31 19708 1641096 4822548 39.55 4307480 1448108 654576
11:04:47 1740108 3612528 4189324 52.37 19728 1862428 4822548 39.55 4307484 1669464 744892
11:04:52 1581404 3611644 4190256 52.38 19740 2015900 4822548 39.55 4307488 1823000 762952
11:04:57 1454928 3611664 4190204 52.38 19756 2138980 4822548 39.55 4307488 1946068 742872
11:05:02 1376868 3631312 4170632 52.13 19768 2233992 4784572 39.24 4286420 2041124 706744
11:05:07 1267544 3630916 4170936 52.14 19780 2340000 4784572 39.24 4286432 2147080 667320
11:05:12 1155152 3631364 4170732 52.14 19792 2449516 4784572 39.24 4286300 2256872 635532
11:05:17 1045588 3631688 4170492 52.13 19804 2556456 4784572 39.24 4286268 2363868 603200
11:05:22 913040 3632364 4169824 52.12 19816 2685936 4784572 39.24 4286284 2493380 581092
11:05:27 843540 3630500 4171756 52.15 19836 2751728 4786388 39.25 4286796 2559224 519916
11:05:32 688180 3629032 4173132 52.17 19848 2901696 4784572 39.24 4286304 2709140 522620
11:05:37 558748 3628956 4173360 52.17 19860 3027208 4784572 39.24 4286312 2834752 508664
11:05:42 392452 3628156 4174080 52.18 19872 3188348 4784572 39.24 4286332 2995828 538724
11:05:47 239560 3627644 4174488 52.18 19880 3336584 4786388 39.25 4286840 3144000 531308
11:05:52 203756 3628228 4174148 52.18 19900 3371784 4784572 39.24 4286308 3179412 498168
11:05:57 133836 3628928 4173400 52.17 19920 3440480 4784572 39.24 4286312 3248100 430364
11:06:02 94968 3629700 4172180 52.15 19868 3479136 4784572 39.24 4286384 3286264 359504
11:06:07 87700 3679172 4172144 52.15 19880 3485776 4784572 39.24 4286480 3293272 472160
11:06:12 79144 3679704 4171608 52.15 19892 3494220 4784572 39.24 4286488 3301728 505572
11:06:17 75152 3680568 4170708 52.14 19908 3498656 4784572 39.24 4286500 3306124 562968
11:06:22 79244 3631112 4171068 52.14 19920 3493912 4784572 39.24 4286512 3301244 570720
11:06:27 75452 3679644 4167668 52.10 19908 3500708 4784572 39.24 4287352 3303904 553348
11:06:32 74328 3680424 4166868 52.09 19916 3502296 4784572 39.24 4287512 3305468 585032
```
It never gets to use the swap (but it also shouldn't, using RAM usage at only 50%:
```
$ free -h
total used free shared buff/cache available
Mem: 7.6Gi 392Mi 3.3Gi 1.0Mi 3.9Gi 7.1Gi
Swap: 4.0Gi 0B 4.0Gi
```
My bitcoin.conf:
```
server=1
rpcuser=****************
rpcpassword=****************
[main]
rpcbind=0.0.0.0
rpcallowip=0.0.0.0/0
rpcport=8332
txindex=1
zmqpubrawblock=tcp://0.0.0.0:28332
zmqpubrawtx=tcp://0.0.0.0:28333
[test]
rpcbind=0.0.0.0
rpcallowip=0.0.0.0/0
testnet=0
rpcport=18332
zmqpubrawblock=tcp://0.0.0.0:38332
zmqpubrawtx=tcp://0.0.0.0:38333
```
I have tried to play around with **dbcache**, **maxsigcachesize**, **maxconnections**, and **rpcthreads**. Same error, exactly at ~9% sync.
### Expected behaviour
For it to run smoothly without crashing.
### Steps to reproduce
**On a Raspberry Pi 4, 8GB version.**
Add the following docker-compose.yaml:
```
version: '3'
services:
bitcoind:
build: .
volumes:
- ./bitcoind_data:/root/.bitcoin
restart: always
```
Put the bitcoin.conf inside `./bitcoind_data` relative to where you placed the compose file:
```
server=1
rpcuser=****************
rpcpassword=****************
[main]
rpcbind=0.0.0.0
rpcallowip=0.0.0.0/0
rpcport=8332
txindex=1
zmqpubrawblock=tcp://0.0.0.0:28332
zmqpubrawtx=tcp://0.0.0.0:28333
[test]
rpcbind=0.0.0.0
rpcallowip=0.0.0.0/0
testnet=0
rpcport=18332
zmqpubrawblock=tcp://0.0.0.0:38332
zmqpubrawtx=tcp://0.0.0.0:38333
```
And the following Dockerfile in `.`:
```
FROM debian:trixie-20230814-slim
RUN apt-get update
RUN apt-get install -y git build-essential libtool autotools-dev automake pkg-config bsdmainutils python3 libevent-dev libboost-dev libsqlite3-dev libzmq3-dev libqt5gui5 libqt5core5a libqt5dbus5 qttools5-dev qttools5-dev-tools
RUN git clone -b master https://github.com/bitcoin/bitcoin.git
WORKDIR bitcoin
RUN ./autogen.sh
RUN ./configure
RUN make -j "$(($(nproc)+1))"
RUN make install
RUN apt-get install -y tree
WORKDIR /root
ENTRYPOINT ["bitcoind"]
```
Then run `docker-compose up` and wait about 40 mins, until it reaches a point (in my case progress ~0.09, ~250mb cache) and terminates the process.
### Relevant log output
```
bitcoind_1 | 2023-09-09T10:04:30Z UpdateTip: new best=00000000000000000a1f0a5dc852ab81d720fb9dceec91bc42f1461a3cf4d3d5 height=371331 version=0x00000003 log2_work=83.254030 tx=81012235 date='2015-08-24T15:55:06Z' progress=0.093034 cache=226.8MiB(31141716txo)
bitcoind_1 | 2023-09-09T10:04:31Z UpdateTip: new best=000000000000000000509e83cabd4f3f02c62638470357eff53275c9532da94f height=371332 version=0x00000003 log2_work=83.254059 tx=81013228 date='2015-08-24T16:03:31Z' progress=0.093036 cache=226.8MiB(31141264txo)
bitcoind_1 | 2023-09-09T10:04:31Z UpdateTip: new best=00000000000000001434c5b3995a1c065fc434fdd1098dbb65020bdf57d90f2a height=371333 version=0x00000003 log2_work=83.254088 tx=81015020 date='2015-08-24T16:21:46Z' progress=0.093038 cache=226.8MiB(31140795txo)
bitcoind_1 | 2023-09-09T10:04:31Z UpdateTip: new best=00000000000000000796a4bd624aeaf6d81b24e666e5db3e7fa62f094df3bc96 height=371334 version=0x00000003 log2_work=83.254117 tx=81015365 date='2015-08-24T16:23:46Z' progress=0.093038 cache=226.8MiB(31141560txo)
bitcoind_1 | 2023-09-09T10:04:32Z UpdateTip: new best=000000000000000006b17425eda94c210ef5111c20c10d1829829d0eeaf905a9 height=371335 version=0x00000003 log2_work=83.254146 tx=81016765 date='2015-08-24T16:35:39Z' progress=0.093040 cache=226.8MiB(31142260txo)
bitcoind_1 | 2023-09-09T10:04:32Z UpdateTip: new best=00000000000000000c684f7fbcbd0bf42879ca1143844d34c5d4ae28358fb41f height=371336 version=0x00000003 log2_work=83.254175 tx=81017385 date='2015-08-24T16:44:52Z' progress=0.093040 cache=226.8MiB(31141393txo)
bitcoind_1 | 2023-09-09T10:04:32Z UpdateTip: new best=00000000000000001004395fb5a59a4d44e51e7f9ff3504c2a5d6e7f06885680 height=371337 version=0x00000003 log2_work=83.254204 tx=81017610 date='2015-08-24T17:00:31Z' progress=0.093041 cache=226.8MiB(31135360txo)
bitcoind_1 | 2023-09-09T10:04:32Z UpdateTip: new best=00000000000000000fb4a9c39dbbf671d79b0eee48cb2f3c85ae39a5005e82d6 height=371338 version=0x00000003 log2_work=83.254234 tx=81019260 date='2015-08-24T17:14:47Z' progress=0.093042 cache=226.8MiB(31134479txo)
bitcoind_1 | 2023-09-09T10:04:33Z UpdateTip: new best=000000000000000006c32b4c4231d2c129a43fae47e2f729530baa1e198a71b8 height=371339 version=0x00000003 log2_work=83.254263 tx=81020779 date='2015-08-24T17:18:04Z' progress=0.093044 cache=226.8MiB(31133741txo)
bitcoind_1 | 2023-09-09T10:04:33Z UpdateTip: new best=0000000000000000101b9824fbbbf52b158c04d33aeab910954cfce6c4c658a6 height=371340 version=0x00000003 log2_work=83.254292 tx=81021579 date='2015-08-24T17:23:07Z' progress=0.093045 cache=226.8MiB(31133299txo)
bitcoind_1 | 2023-09-09T10:04:33Z UpdateTip: new best=000000000000000008aa6cf51dfde20be1d54e671494a44fb7f252fd4e913162 height=371341 version=0x00000003 log2_work=83.254321 tx=81023741 date='2015-08-24T17:44:26Z' progress=0.093048 cache=226.8MiB(31133550txo)
bitcoind_1 | 2023-09-09T10:04:33Z Error: Out of memory. Terminating.
bitcoind_1 | terminate called without an active exception
```
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
25.0
### Operating system and version
Raspbian Light
Linux raspberrypi 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr 3 17:24:16 BST 2023 aarch64 GNU/Linux
### Machine specifications
https://www.raspberrypi.com/products/raspberry-pi-4-model-b/specifications/ | https://github.com/bitcoin/bitcoin/issues/28440 | https://github.com/bitcoin/bitcoin/pull/28913 | 640b45053020cbbd0af4f4b53ed1b742b6232fb2 | e9beaa749c998ad86e97c98025125cafeec6c9de | 2023-09-09T10:14:39Z | c++ | 2023-11-22T11:15:27Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,437 | ["test/functional/wallet_fundrawtransaction.py"] | testmempoolaccept CI failure in wallet_fundrawtransaction.py | Saw this today both for legacy wallets
https://cirrus-ci.com/task/5313927408517120?logs=ci#L3168
and for descriptor wallets in another PR
https://cirrus-ci.com/task/4911232080150528?logs=ci#L2755
```
test 2023-09-09T02:47:45.448000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/ci_container_base/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 131, in main
self.run_test()
File "/ci_container_base/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/wallet_fundrawtransaction.py", line 148, in run_test
self.test_external_inputs()
File "/ci_container_base/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/wallet_fundrawtransaction.py", line 1070, in test_external_inputs
assert_equal(self.nodes[0].testmempoolaccept([signed_tx["hex"]])[0]["allowed"], True)
File "/ci_container_base/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 57, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(False == True)
```
Both in `test/functional/wallet_fundrawtransaction.py`, line 1070:
```python3
assert_equal(self.nodes[0].testmempoolaccept([signed_tx["hex"]])[0]["allowed"], True)
```
| https://github.com/bitcoin/bitcoin/issues/28437 | https://github.com/bitcoin/bitcoin/pull/28604 | db283a6b6f1419291bcd15d74d51c8598aefe06a | 62346bc394a4d1fd84069898dc3e4b98a712bf24 | 2023-09-09T03:00:48Z | c++ | 2023-10-09T08:53:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,421 | ["test/functional/feature_txindex_compatibility.py", "test/functional/test_runner.py"] | test: Remove feature_txindex_compatibility.py in v27 | Since #28195 got merged, all non-test code relating to the legacy txindex (and its migration) has been removed from master.
At this point, `feature_txindex_compatibility.py` is just testing whether `-txindex` works successfully when a legacy txindex exists, but as there is no overlap in data structures this feels like a redundant test and I think it can be removed from a future version. Since #28195 is included for v26, I'd [suggest](https://github.com/bitcoin/bitcoin/pull/28195#discussion_r1311494362) we remove this test for v27.
Historical pulls for context:
#13033: introduce new txindex db and migration code
#22626: remove migration code
#23046: add feature_txindex_compatibility.py | https://github.com/bitcoin/bitcoin/issues/28421 | https://github.com/bitcoin/bitcoin/pull/28753 | feae4e04389b89e18a411596c4f2cdc18663a1ef | a3670b227333e8d1a50759a4dd496c2f54f98fa6 | 2023-09-06T12:46:30Z | c++ | 2023-10-30T13:09:15Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,365 | ["ci/test/04_install.sh"] | ci: error: one or more PCH files were found, but they were invalid | This has been reported by multiple contributors. I assume some sort of caching issue? Seems to happen intermittently. https://cirrus-ci.com/task/5028170181640192?logs=ci#L2664:
```bash
make[4]: Entering directory '/ci_container_base/depends/work/build/i686-pc-linux-gnu/qt/5.15.5-ba80ab1130c/qtbase/src/testlib'
make[5]: Entering directory '/ci_container_base/depends/work/build/i686-pc-linux-gnu/qt/5.15.5-ba80ab1130c/qtbase/src/plugins/platforminputcontexts'
make[5]: Entering directory '/ci_container_base/depends/work/build/i686-pc-linux-gnu/qt/5.15.5-ba80ab1130c/qtbase/src/plugins/platforms'
cc1plus: error: one or more PCH files were found, but they were invalid
cc1plus: error: use -Winvalid-pch for more information
cc1plus: error: one or more PCH files were found, but they were invalid
cc1plus: error: use -Winvalid-pch for more information
cc1plus: fatal error: .pch/Qt5Test: No such file or directory
cc1plus: fatal error: .pch/Qt5Test: No such file or directory
compilation terminated.
compilation terminated.
cc1plus: error: one or more PCH files were found, but they were invalid
cc1plus: error: use -Winvalid-pch for more information
cc1plus: fatal error: .pch/Qt5Test: No such file or directory
compilation terminated.
cc1plus: error: one or more PCH files were found, but they were invalid
cc1plus: error: use -Winvalid-pch for more information
make[4]: *** [Makefile:2113: .obj/qtestcase.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: *** [Makefile:2292: .obj/qtestlog.o] Error 1
make[4]: *** [Makefile:2435: .obj/qtesttable.o] Error 1
cc1plus: fatal error: .pch/Qt5Test: No such file or directory
compilation terminated.
make[5]: Entering directory '/ci_container_base/depends/work/build/i686-pc-linux-gnu/qt/5.15.5-ba80ab1130c/qtbase/src/plugins/platformthemes'
make[4]: *** [Makefile:2578: .obj/qtestdata.o] Error 1
cc1plus: error: one or more PCH files were found, but they were invalid
cc1plus: error: use -Winvalid-pch for more information
cc1plus: fatal error: .pch/Qt5Test: No such file or directory
compilation terminated.
make[4]: *** [Makefile:2944: .obj/qtestresult.o] Error 1
make[4]: Leaving directory '/ci_container_base/depends/work/build/i686-pc-linux-gnu/qt/5.15.5-ba80ab1130c/qtbase/src/testlib'
make[3]: *** [Makefile:298: sub-testlib-make_first] Error 2
make[3]: *** Waiting for unfinished jobs....
```
Not sure why Qt is even trying to use pch on a Linux build, as it was meant to be disabled by #20520. | https://github.com/bitcoin/bitcoin/issues/28365 | https://github.com/bitcoin/bitcoin/pull/28595 | 66f8ee2969dcfd5df13f5e33afa80cbc6ffef774 | f4674444b21184ee267675eba4886009b4ec619c | 2023-08-29T15:36:07Z | c++ | 2023-10-09T13:13:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,290 | ["test/functional/feature_config_args.py"] | Intermittent failure in feature_config_args.py | https://cirrus-ci.com/task/5383892962639872?logs=ci#L7698
```
2023-08-17T20:59:43.754000Z TestFramework (INFO): Test seed peers
2023-08-17T21:03:45.922000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/ci_container_base/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 131, in main
self.run_test()
File "/ci_container_base/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_config_args.py", line 377, in run_test
self.test_seed_peers()
File "/ci_container_base/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_config_args.py", line 273, in test_seed_peers
assert time.time() - start < 60
AssertionError
``` | https://github.com/bitcoin/bitcoin/issues/28290 | https://github.com/bitcoin/bitcoin/pull/28386 | fb619e1bc35d8be98ddb893410f98efc6c5ee5ee | c004ba48f467ac827fb6bb3aa546d7b79bc7740e | 2023-08-17T21:09:45Z | c++ | 2023-09-05T08:59:33Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,183 | ["test/lint/lint-python.py"] | lint: MYPY_CACHE_DIR is unused | See also the discussion in https://github.com/bitcoin/bitcoin/pull/24794/files#r844848504 . However, the variable is completely unused:
```
$ git grep MYPY_CACHE_DIR
test/lint/lint-python.py:MYPY_CACHE_DIR = f"{os.getenv('BASE_ROOT_DIR', '')}/test/.mypy_cache"
```
Not sure if it was ever needed. If not, it should be removed. cc @fjahr | https://github.com/bitcoin/bitcoin/issues/28183 | https://github.com/bitcoin/bitcoin/pull/28184 | f66af92f1a3e2ebbae8050e57a60e051f9bf5f39 | 8b44d011184c7d807bc6e61107116ed05c45b8d1 | 2023-07-30T08:37:05Z | c++ | 2023-10-02T09:19:08Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,180 | ["src/rpc/client.cpp", "src/wallet/feebumper.cpp", "src/wallet/feebumper.h", "src/wallet/rpc/spend.cpp", "test/functional/wallet_bumpfee.py"] | Unsafe reduce_output when new coins are added | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
See inline discussion at https://github.com/bitcoin/bitcoin/pull/26467#discussion_r1269177446
@whitslack:
> Consider the case where I am paying someone on chain under the stipulation that _they_ will eat the mining fee. (Thus, I specify _their_ address in `subtractfeefrom` when I'm constructing my transaction.) Later, they tell me that they can't wait for confirmation any longer and need an urgent fee bump. If I naïvely specify their output as the `reduce_output`, I may end up paying them _**much more**_ than I intended to if I only have large UTxOs in my wallet.
### Expected behaviour
Not sure.
Improving the docs is one option, but this behaviour seem quite counter intuitive.
My own suggestion:
> Should we disable the adding of new inputs when `reduce_output` is set? If someone really intends to do that, they should probably use `outputs`.
### Steps to reproduce
Haven't tried.
### Relevant log output
_No response_
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
Master after #26467
### Operating system and version
Any
### Machine specifications
_No response_ | https://github.com/bitcoin/bitcoin/issues/28180 | https://github.com/bitcoin/bitcoin/pull/28505 | c9f288244b8d183e09a917025922b99e3368ef78 | 19a7e608f97838a58c2bbc058c6aea1d5ffe675f | 2023-07-28T11:11:08Z | c++ | 2023-09-27T20:46:27Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,133 | ["test/functional/p2p_getaddr_caching.py", "test/functional/test_framework/test_node.py"] | p2p_getaddr_caching.py failure in TSan CI | ERROR: type should be string, got "https://cirrus-ci.com/task/5471865133596672?logs=ci#L3981\r\n\r\n```\r\n test 2023-07-22T19:16:17.696000Z TestFramework (ERROR): Assertion failed \r\n Traceback (most recent call last):\r\n File \"/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py\", line 131, in main\r\n self.run_test()\r\n File \"/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/p2p_getaddr_caching.py\", line 74, in run_test\r\n addr_receiver_onion1 = self.nodes[0].add_p2p_connection(AddrReceiver(), dstport=self.onion_port1)\r\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n File \"/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_node.py\", line 652, in add_p2p_connection\r\n assert_equal(len(info), 1)\r\n File \"/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py\", line 57, in assert_equal\r\n raise AssertionError(\"not(%s)\" % \" == \".join(str(arg) for arg in (thing1, thing2) + args))\r\n AssertionError: not(2 == 1)\r\n test 2023-07-22T19:16:17.697000Z TestFramework (DEBUG): Closing down network thread \r\n test 2023-07-22T19:16:17.747000Z TestFramework (INFO): Stopping nodes \r\n test 2023-07-22T19:16:17.748000Z TestFramework.node0 (DEBUG): Stopping node \r\n```\r\n\r\n### Is there an existing issue for this?\r\n\r\n- [X] I have searched the existing issues\r\n" | https://github.com/bitcoin/bitcoin/issues/28133 | https://github.com/bitcoin/bitcoin/pull/28144 | eb95368e0c3ab3d9f5f88630c2bd81ad1b01988a | 1b5cbf71dff1f240bac0156f8800382272489f0b | 2023-07-23T19:35:40Z | c++ | 2023-08-01T15:59:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,104 | ["configure.ac", "contrib/guix/manifest.scm"] | win: non-static libssp in libbitcoinconsensus DLL | If you Guix build for Windows, and call objdump on `libbitcoinconsensus-0.dll`, you'll find it uses a non-static libssp:
```bash
objdump -x src/.libs/libbitcoinconsensus-0.dll
...
The Import Tables (interpreted .idata section contents)
vma: Hint Time Forward DLL First
Table Stamp Chain Name Thunk
00263000 00263050 00000000 00000000 0026409c 00263490
DLL Name: libssp-0.dll
vma: Hint/Ord Member-Name Bound-To
2638d0 3 __memcpy_chk
2638e0 7 __stack_chk_fail
2638f4 8 __stack_chk_guard
```
DLLs should be built with a static libgcc/stdc++/ssp:
https://github.com/bitcoin/bitcoin/blob/84c5416b03248c91aa7efe46555699f9f121d8a4/configure.ac#L724-L730
This has been an issue since we switched to using Guix for the 22.0 release. | https://github.com/bitcoin/bitcoin/issues/28104 | https://github.com/bitcoin/bitcoin/pull/28461 | 172cd92620167cc437f6d208a20f2698f15835a9 | 5d13b9586eb97f59d9bb53aae1d8c27dc052b61e | 2023-07-19T11:18:38Z | c++ | 2023-11-22T17:17:12Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,094 | ["test/functional/wallet_resendwallettransactions.py"] | failure in wallet_resendwallettransactions.py --legacy-wallet | https://cirrus-ci.com/task/5656433702731776?logs=ci#L7912 from #26288:
```bash
................................................................
194/268 - wallet_resendwallettransactions.py --legacy-wallet failed, Duration: 111 s
stdout:
2023-07-17T21:30:03.351000Z TestFramework (INFO): PRNG seed is: 4625691275301666838
2023-07-17T21:30:03.352000Z TestFramework (INFO): Initializing test directory /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20230717_204920/wallet_resendwallettransactions_69
2023-07-17T21:30:18.443000Z TestFramework (INFO): Create a new transaction and wait until it's broadcast
2023-07-17T21:30:22.728000Z TestFramework (INFO): Create a block
2023-07-17T21:30:22.733000Z TestFramework (INFO): Bump time & check that transaction is rebroadcast
2023-07-17T21:30:23.639000Z TestFramework (INFO): Chain of unconfirmed not-in-mempool txs are rebroadcast
2023-07-17T21:31:23.811000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 131, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/wallet_resendwallettransactions.py", line 116, in run_test
assert_raises_rpc_error(-5, "Transaction not in mempool", node.getmempoolentry, txid)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 131, in assert_raises_rpc_error
assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
AssertionError: No exception raised
2023-07-17T21:31:23.862000Z TestFramework (INFO): Stopping nodes
2023-07-17T21:31:54.182000Z TestFramework (WARNING): Not cleaning up dir /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20230717_204920/wallet_resendwallettransactions_69
2023-07-17T21:31:54.182000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20230717_204920/wallet_resendwallettransactions_69/test_framework.log
2023-07-17T21:31:54.182000Z TestFramework (ERROR):
2023-07-17T21:31:54.183000Z TestFramework (ERROR): Hint: Call /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/combine_logs.py '/tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20230717_204920/wallet_resendwallettransactions_69' to consolidate all logs
2023-07-17T21:31:54.183000Z TestFramework (ERROR):
2023-07-17T21:31:54.183000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2023-07-17T21:31:54.183000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues
2023-07-17T21:31:54.183000Z TestFramework (ERROR):
```
Full log: https://gist.github.com/fanquake/cb8e0dd478c6a63d448b4db4d29142c4. | https://github.com/bitcoin/bitcoin/issues/28094 | https://github.com/bitcoin/bitcoin/pull/28108 | 7edce77ff3725f8650bb1ae6b45b1cee100db280 | b3022af0e25ad2f6a3abfb5ae5c91e4ecc3cdc52 | 2023-07-18T09:13:59Z | c++ | 2023-07-20T15:39:24Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,057 | ["src/wallet/scriptpubkeyman.cpp", "src/wallet/scriptpubkeyman.h", "src/wallet/wallet.cpp", "test/functional/wallet_migration.py"] | migratewallet crashes (wallet/scriptpubkeyman.cpp:1915: std::optional<MigrationData> wallet::LegacyScriptPubKeyMan::MigrateToDescriptor(): Assertion `IsMine(desc_spk) != ISMINE_NO' failed.) | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
crash
### Expected behaviour
no crash
### Steps to reproduce
* Compile 79e8247ddb166f9b980f40249b7372a502402a4d
* Type `migratewallet`
### Relevant log output
```
wallet/scriptpubkeyman.cpp:1915: std::optional<MigrationData> wallet::LegacyScriptPubKeyMan::MigrateToDescriptor(): Assertion `IsMine(desc_spk) != ISMINE_NO' failed.
Aborted (core dumped)
```
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
current master
### Operating system and version
Linux
### Machine specifications
_No response_ | https://github.com/bitcoin/bitcoin/issues/28057 | https://github.com/bitcoin/bitcoin/pull/28125 | 53313c49d6dc12dacd7e3ce6594d4cad268cec12 | abe4fedab735c145881e85dc2b02cf819a241635 | 2023-07-09T10:34:39Z | c++ | 2023-09-19T17:10:57Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 28,019 | ["doc/fuzzing.md"] | docs: "Fuzzing the Bitcoin Core P2P layer using Honggfuzz NetDriver" is outdated | Due to changes to the functions `V1TransportDeserializer::readHeader` and `V1TransportDeserializer::GetMessage`, the "Fuzzing the Bitcoin Core P2P layer using Honggfuzz NetDriver" section in `fuzzing.md` is outdated. The `git apply` command doesn't work.
```sh
$ git apply << "EOF"
diff --git a/src/bitcoind.cpp b/src/bitcoind.cpp
index 455a82e39..2faa3f80f 100644
--- a/src/bitcoind.cpp
+++ b/src/bitcoind.cpp
@@ -158,7 +158,11 @@ static bool AppInit(int argc, char* argv[])
return fRet;
}
+#ifdef HFND_FUZZING_ENTRY_FUNCTION_CXX
+HFND_FUZZING_ENTRY_FUNCTION_CXX(int argc, char* argv[])
+#else
int main(int argc, char* argv[])
+#endif
{
#ifdef WIN32
util::WinCmdLineArgs winArgs;
diff --git a/src/net.cpp b/src/net.cpp
index cf987b699..636a4176a 100644
--- a/src/net.cpp
+++ b/src/net.cpp
@@ -709,7 +709,7 @@ int V1TransportDeserializer::readHeader(const char *pch, unsigned int nBytes)
}
// Check start string, network magic
- if (memcmp(hdr.pchMessageStart, m_chain_params.MessageStart(), CMessageHeader::MESSAGE_START_SIZE) != 0) {
+ if (false && memcmp(hdr.pchMessageStart, m_chain_params.MessageStart(), CMessageHeader::MESSAGE_START_SIZE) != 0) { // skip network magic checking
LogPrint(BCLog::NET, "HEADER ERROR - MESSAGESTART (%s, %u bytes), received %s, peer=%d\n", hdr.GetCommand(), hdr.nMessageSize, HexStr(hdr.pchMessageStart), m_node_id);
return -1;
}
@@ -768,7 +768,7 @@ Optional<CNetMessage> V1TransportDeserializer::GetMessage(const std::chrono::mic
RandAddEvent(ReadLE32(hash.begin()));
// Check checksum and header command string
- if (memcmp(hash.begin(), hdr.pchChecksum, CMessageHeader::CHECKSUM_SIZE) != 0) {
+ if (false && memcmp(hash.begin(), hdr.pchChecksum, CMessageHeader::CHECKSUM_SIZE) != 0) { // skip checksum checking
LogPrint(BCLog::NET, "CHECKSUM ERROR (%s, %u bytes), expected %s was %s, peer=%d\n",
SanitizeString(msg->m_command), msg->m_message_size,
HexStr(Span<uint8_t>(hash.begin(), hash.begin() + CMessageHeader::CHECKSUM_SIZE)),
EOF
``` | https://github.com/bitcoin/bitcoin/issues/28019 | https://github.com/bitcoin/bitcoin/pull/28021 | 61d59fed74108f31eb4e9a2faa3f36422a37000e | 600c595b8d2f4bf049b9182d4a0aa88e4b34458d | 2023-07-01T21:39:21Z | c++ | 2023-07-03T10:44:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,980 | ["src/test/fuzz/connman.cpp"] | fuzz: connman, `m_nodes` is always empty | `m_nodes` in `CConnman` is always empty in connman target (since we don't call `CreateNodeFromAcceptedSocket`/`OpenNetworkConnection` for an obvious reason). Because of this, the calls for `DisconnectNode`, `FindNode`, `ForEachNode`, `GetNodeStats` and many other ones seems to be "useless". That's the reason we're not getting coverage (at all) for many of these covered functions (See: https://marcofalke.github.io/b-c-cov/fuzz.coverage/src/net.cpp.gcov.html).
I suppose we could use `ConnmanTestMsg` here and then we can use `AddTestNode`, not sure whether it's the best approach:
```diff
diff --git a/src/test/fuzz/connman.cpp b/src/test/fuzz/connma
n.cpp
index f81658b83..607a91488 100644
--- a/src/test/fuzz/connman.cpp
+++ b/src/test/fuzz/connman.cpp
@@ -32,7 +32,7 @@ FUZZ_TARGET_INIT(connman, initialize_connman)
{
FuzzedDataProvider fuzzed_data_provider{buffer.data(), buffer.size()};
SetMockTime(ConsumeTime(fuzzed_data_provider));
- CConnman connman{fuzzed_data_provider.ConsumeIntegral<uint64_t>(),
+ ConnmanTestMsg connman{fuzzed_data_provider.ConsumeIntegral<uint64_t>(),
fuzzed_data_provider.ConsumeIntegral<uint64_t>(),
*g_setup->m_node.addrman,
*g_setup->m_node.netgroupman,
@@ -41,6 +41,15 @@ FUZZ_TARGET_INIT(connman, initialize_connman)
CNode random_node = ConsumeNode(fuzzed_data_provider);
CSubNet random_subnet;
std::string random_string;
+
+ {
+ LOCK(NetEventsInterface::g_msgproc_mutex);
+ for (int i = 0; i < 100; i++) {
+ CNode& p2p_node = *ConsumeNodeAsUniquePtr(fuzzed_data_provider).release();
+ connman.AddTestNode(p2p_node);
+ }
+ }
+
LIMITED_WHILE(fuzzed_data_provider.ConsumeBool(), 10000) {
CallOneOf(
fuzzed_data_provider,
@@ -128,4 +137,6 @@ FUZZ_TARGET_INIT(connman, initialize_connman)
(void)connman.GetTotalBytesSent();
(void)connman.GetTryNewOutboundPeer();
(void)connman.GetUseAddrmanOutgoing();
+
+ connman.ClearTestNodes();
}
```
| https://github.com/bitcoin/bitcoin/issues/27980 | https://github.com/bitcoin/bitcoin/pull/28091 | e92013e178727429fdf81ef180efffdad9f0ff5a | 44b05bf3fef2468783dcebf651654fdd30717e7e | 2023-06-26T19:52:00Z | c++ | 2023-07-31T10:43:39Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,924 | ["ci/test/00_setup_env_mac_native.sh", "src/test/fuzz/banman.cpp"] | fuzz: banman, Assertion `banmap == banmap_read' failed | fabed982ad9143cddaca8346f6b4c243dd84e0c4 re-enabled the assert `assert(banmap == banmap_read)` in `banman`:
```cpp
ban_man.DumpBanlist();
SetMockTime(ConsumeTime(fuzzed_data_provider));
banmap_t banmap;
ban_man.GetBanned(banmap);
BanMan ban_man_read{banlist_file, /* client_interface */ nullptr, /* default_ban_time */ 0};
banmap_t banmap_read;
ban_man_read.GetBanned(banmap_read);
assert(banmap == banmap_read);
```
However, my server crashed because of it. Debugging it I could realize the problem is the function `LookupSubnet`.
During the execution that caused the crash, the banman has been filled with the following subnets:
```sh
2e:6f6e:696f:6ef3:a080:b18d:5d5d:5d00%2038004089/121
191:b491:7979:7979:7979:7979:79ff:ff80%2037980897/121
207:fc26:b9ce:7aae:798b:5f2d:1d39:4380%2038004089/121
676:c962:7962:b787:b392:fed8:7058:c500%2038004089/121
...
```
After dumping it (`DumpBanlist`), we initialize a `BanMan` reading same file:
```cpp
BanMan ban_man_read{banlist_file, /* client_interface */ nullptr, /* default_ban_time */ 0};
banmap_t banmap_read;
ban_man_read.GetBanned(banmap_read);
```
However, when we initialize a `BanMan` it will - at some point - call `BanMapFromJson`.
Taking a look at `BanMapFromJson`, I noticed we have:
```cpp
if (!LookupSubNet(subnet_str, subnet)) {
LogPrintf("Dropping entry with unparseable address or subnet (%s) from ban list\n", subnet_str);
continue;
}
```
Calling `LookupSubNet`, for example, with `2e:6f6e:696f:6ef3:a080:b18d:5d5d:5d00%2038004089/121`, will return true, but the subnet will be `2e:6f6e:696f:6ef3:a080:b18d:5d5d:5d00%31097` making the assertion `assert(banmap == banmap_read)` to fail.
-----------
Got this with macOS Ventura 13.0.
```sh
./configure --enable-fuzz --with-sanitizers=fuzzer,address,undefined --disable-asm CC=$(brew --prefix llvm)/bin/clang CXX=$(brew --prefix llvm)/bin/clang++
```
Crash:
```sh
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 3851287319
INFO: Loaded 1 modules (1130675 inline 8-bit counters): 1130675 [0x107b6cd60, 0x107c80e13),
INFO: Loaded 1 PC tables (1130675 PCs): 1130675 [0x107c80e18,0x108dc1948),
src/test/fuzz/fuzz: Running 1 inputs 1 time(s) each.
Running: crash-cc17009262908f232f471481d1ad808e2bf6dc14
Assertion failed: (banmap == banmap_read), function banman_fuzz_target, file banman.cpp, line 112.
==79739== ERROR: libFuzzer: deadly signal
#0 0x10a453ea4 in __sanitizer_print_stack_trace+0x28 (libclang_rt.asan_osx_dynamic.dylib:arm64+0x5bea4) (BuildId: 5c04277be4ee3a049b85963fe58ab4e132000000200000000100000000000b00)
#1 0x1070bf970 in fuzzer::PrintStackTrace() FuzzerUtil.cpp:210
#2 0x1070a3d8c in fuzzer::Fuzzer::CrashCallback() FuzzerLoop.cpp:233
#3 0x18065c2a0 in _sigtramp+0x34 (libsystem_platform.dylib:arm64+0x42a0) (BuildId: 781896702f47332c9a59a210157aa97b32000000200000000100000000000d00)
#4 0xfa7f80018062dce8 (<unknown module>)
#5 0x51270001805672c4 (<unknown module>)
#6 0x614a00018056661c (<unknown module>)
#7 0x382f000104c37c88 (<unknown module>)
#8 0x1052468f8 in LLVMFuzzerTestOneInput fuzz.cpp:169
#9 0x1070a51c8 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) FuzzerLoop.cpp:617
#10 0x107091590 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) FuzzerDriver.cpp:324
#11 0x1070967c4 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) FuzzerDriver.cpp:860
#12 0x1070c0bc0 in main FuzzerMain.cpp:20
#13 0x180303e4c (<unknown module>)
#14 0x7d03fffffffffffc (<unknown module>)
NOTE: libFuzzer has rudimentary signal handlers.
Combine libFuzzer with AddressSanitizer or similar for better crash reports.
SUMMARY: libFuzzer: deadly signal
```
Seed:
```sh
X3J1bmViYX39GgAAAAAAAAD///8AACsAXAAAAFx00UUXXXQBFRUVFRUVFRUVFRVvLwB/AAAAgAABAAABAQcAAACRtJGdEZGRQAAAAMQgf38AQAqRkf/w/6cCAZG0kXl5eXl5eXl5ef//////////eXl5eXl5eXl5eXl5eXl5jMCDHsFtvdtVxH7U1agiqUM6FTiq9Tg1OfCMddTHrRhzOQ0wCFHRVS3D7kqAmf4ii4FzNYkn9XcN8ubYNitv6cgN9E1kKPbQJOCC2dYrPDwDDQHZQeqOD7K+uD8GdslieWK3h7OS/thwWMUdw+KmgryaSZvunotnNKkz/uq98HjtQrUH/LUmUeb7pTZHqTApZ3jXVmGS2Muo96HLI9g3d0EG5LHce+mRSy2jB6TFuBRAQpwjghLRiU+S75ltwhrmRUXBfa4kpmjq2FrBYiVbbTYisifxMsnvPS7ix+IwpTats2ewEGQITg/MeZbhvKcZxxczHeb6ht1PrRV4/o/msCwN2d8RVC0DYh2gqj1aC06cGMXgoZw+T3ll5CH8dghESnW98W3i283GUy/3tSwPV8GLot5X/DupHLge/RQxtmgnIJhXgq/UMzTL7XK9y1oMooLSPiDhJiVmrKE95f549o1H9UZXSx1mwGCqap51HHrCSsnjiP13Wn1+WtyEUUAObNBDhcSjuHMMWY95B938zoOKTbFpyY3gzAi5Z8ujR2KmnEaKT4MKAVGQAAAAAAAAAAAAAAAAAAAAAP5W0ABJaWjFneFMmuY9koAoGVtScppmwwOw9++Ufx0dTyvFjZHkROJ6mlu0UKCvY6sTccKSugFu0/QncpR5/DBzYqTSe0OKQSMhzIN2HQEAo05OWxU9XQsTKRfg/bSB1//EXudt4jZEIyns29ZRAAAAAAAAAAB5cXFxcXFxcXFxcXFxcXFxcXl5PgAAAAAAAABwkZiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmJiYmEAAAC5vbmlvbvOggLGNXV1dDV0NAABVlEQAXRAAP11d+gj/f7+12l1VlABdEF0AROA9//////8I/38I/yZ/CP9/CP9/CP9/CP9/B/9/CHl5eXn/////////////////////AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAeXl5eQB5ecJ5eQF0eXl5eXl5eXl5eXkAgDsAAACAeXkmeXmwV3P1HqaLvq9HJCO3LQzu6Khz1/N6ndp/+0uXhvDVw6ekexeobSVOnFS7455nfwXAfGVyqxh8mvHWMdOKECKCa6HLBzj/rHbPG+HNtG/wvAIH/Ca5znqueYtfLR05Q66eoEheVZbgZSZn9xtbTUOMCPf+fwZ/3/wCs5ve9RqjRhRopnTXzm6R53SyY8OhPkjZfmHekZiP4qpCUN0rFIU8cZojTVAUZWJjT7OKXmAgZ5GWTGuyos8GKQMfmo4KCFuwt0/0+x9aKSC2z5JDTqebow5cVrdEjrozEjNXNL36tvOaLdGvcMfJ8xlUmOjI6DU+pmEn4ZUXUxUu9CnwZ8ZsjJcs0bOiVJd5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eYeHeXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5fXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5/YfYfutDeXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXkAeXl5eeEeeXl5eXl6eYATE3l5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl5eXl9eXl5eQCAOwAAAIB5eXl5eQ==
```
-----------
The following diff reproduces the behavior:
```diff
diff --git a/src/test/banman_tests.cpp b/src/test/banman_tests.cpp
index cebe3629d..d24f55979 100644
--- a/src/test/banman_tests.cpp
+++ b/src/test/banman_tests.cpp
@@ -20,11 +20,12 @@ BOOST_AUTO_TEST_CASE(file)
SetMockTime(777s);
const fs::path banlist_path{m_args.GetDataDirBase() / "banlist_test"};
{
+ const std::string suspect_subnet{"2e:6f6e:696f:6ef3:a080:b18d:5d5d:5d00%2038004089/121"};
const std::string entries_write{
"{ \"banned_nets\": ["
" { \"version\": 1, \"ban_created\": 0, \"banned_until\": 778, \"address\": \"aaaaaaaaa\" },"
" { \"version\": 2, \"ban_created\": 0, \"banned_until\": 778, \"address\": \"bbbbbbbbb\" },"
- " { \"version\": 1, \"ban_created\": 0, \"banned_until\": 778, \"address\": \"1.0.0.0/8\" }"
+ " { \"version\": 1, \"ban_created\": 0, \"banned_until\": 778, \"address\": \"2e:6f6e:696f:6ef3:a080:b18d:5d5d:5d00%2038004089/121\" }"
"] }",
};
BOOST_REQUIRE(WriteBinaryFile(banlist_path + ".json", entries_write));
@@ -36,6 +37,11 @@ BOOST_AUTO_TEST_CASE(file)
banmap_t entries_read;
banman.GetBanned(entries_read);
BOOST_CHECK_EQUAL(entries_read.size(), 1);
+
+ for (const auto& it : entries_read) {
+ CSubNet sub_net = it.first;
+ BOOST_CHECK_EQUAL(sub_net.ToString(), suspect_subnet);
+ }
}
}
}
```
```diff
diff --git a/test/functional/rpc_setban.py b/test/functional/rpc_setban.py
index b4f3d77e5..93a19920c 100755
--- a/test/functional/rpc_setban.py
+++ b/test/functional/rpc_setban.py
@@ -25,6 +25,10 @@ class SetBanTests(BitcoinTestFramework):
peerinfo = self.nodes[1].getpeerinfo()[0]
assert not "noban" in peerinfo["permissions"]
+ subnet = "2e:6f6e:696f:6ef3:a080:b18d:5d5d:5d00%2038004089/121"
+ self.nodes[1].setban(subnet, "add")
+ assert self.is_banned(self.nodes[1], subnet)
+
# Node 0 get banned by Node 1
self.nodes[1].setban("127.0.0.1", "add")
``` | https://github.com/bitcoin/bitcoin/issues/27924 | https://github.com/bitcoin/bitcoin/pull/27935 | dd5f5713bccac3061676cf3814dcd4488ac557ed | e862bceb1705e6d8c1b738301ed10ae1b4413bfd | 2023-06-20T22:00:20Z | c++ | 2023-11-13T10:57:01Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,915 | ["src/script/descriptor.cpp", "src/script/descriptor.h", "src/test/descriptor_tests.cpp", "src/wallet/scriptpubkeyman.cpp", "src/wallet/test/walletload_tests.cpp", "src/wallet/walletdb.cpp"] | wallets created on master get corrupted when processed with v25 | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
I randomly encountered this by loading a wallet created from master with an older version. I could trace it down to bd13dc2f46ea10302a928fcf0f53b7aed77ad260 (#26076), but I don't know descriptor wallets enough to understand what's going on (cc @Sjors @achow101).
### Expected behaviour
`bitcoind` starts, or at least tells me to use a later version if #26076 was a breaking change instead of corrupting `wallet.dat`.
### Steps to reproduce
(master, clean chain):
`createwallet -regtest ""`
(v25.0rc2):
first `bitcoind -regtest` succeeds
then stop and restart the node: The second `bitcoind -regtest` leads to an InitError:
`Error: Error: Unable to expand wallet descriptor from cache`
now, the wallet cannot be loaded by either version.
### Relevant log output
_No response_
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
v25.0rc2 / master
### Operating system and version
Ubuntu
### Machine specifications
_No response_ | https://github.com/bitcoin/bitcoin/issues/27915 | https://github.com/bitcoin/bitcoin/pull/27920 | 600c595b8d2f4bf049b9182d4a0aa88e4b34458d | f08d914a678f7ceb81e7584efe92d3840f3b9c95 | 2023-06-20T01:37:29Z | c++ | 2023-07-04T01:42:01Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,913 | ["src/policy/feerate.h"] | rpc: signed-integer-overflow in analyzepsbt["estimated_feerate"] | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
crash/UB in https://github.com/bitcoin/bitcoin/blob/f0758d8a6696657269d9c057e7aa079ffa9e1c16/src/rpc/rawtransaction.cpp#L1906
### Expected behaviour
no crash
### Steps to reproduce
* Compile with ubsan
* `UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1" ./src/qt/bitcoin-qt`
* `analyzepsbt cHNidP8BACkgICAgAAEgICAgIP8DABYgICAgICAgICAgICAgICAgICAgICAgICAgIAAA`
### Relevant log output
```
#0 0x55a94d97befd in CFeeRate::GetFee(unsigned int) const src/policy/feerate.cpp:29:63
#1 0x55a94d4648ca in CFeeRate::GetFeePerK() const src/./policy/feerate.h:65:41
#2 0x55a94d4648ca in analyzepsbt()::$_13::operator()(RPCHelpMan const&, JSONRPCRequest const&) const src/rpc/rawtransaction.cpp:1907:85
...
SUMMARY: UndefinedBehaviorSanitizer: signed-integer-overflow policy/feerate.cpp:29:63 in
```
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
current master
### Operating system and version
Linux
### Machine specifications
_No response_ | https://github.com/bitcoin/bitcoin/issues/27913 | https://github.com/bitcoin/bitcoin/pull/27914 | 8847497161741052f27c4f8fb19a1a88238008f2 | 931ac6f8368fb279c8b8b5bb9fcf4b95be2a6c56 | 2023-06-19T13:09:41Z | c++ | 2023-06-26T08:43:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,904 | ["test/functional/test-shell.md"] | TestShell doesn't work | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
Following the instructions here:
https://github.com/bitcoin/bitcoin/blob/master/test/functional/test-shell.md#2-importing-testshell-from-the-bitcoin-core-repository
```
AttributeError: type object 'TestShell' has no attribute 'setup'
```
### Expected behaviour
It should setup the TestShell
### Steps to reproduce
Build binaries.
On macOS:
```
$ python
Python 3.8.16 (default, May 19 2023, 13:41:40)
[Clang 14.0.3 (clang-1403.0.22.14.1)] on darwin
>>> import sys
>>> sys.path.insert(0,"/home/sjors/dev/bitcoin/test/functional")
>>> from test_framework.test_shell import TestShell
>>> TestShell.setup()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: type object 'TestShell' has no attribute 'setup'
```
On Ubuntu:
```
ython 3.8.16 (default, May 8 2023, 15:02:46)
[GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys.path.insert(0,"/home/sjors/dev/bitcoin/test/functional")
>>> from test_framework.test_shell import TestShell
>>> TestShell.setup()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: type object 'TestShell' has no attribute 'setup'
```
### Relevant log output
_No response_
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
master@f0758d8a6696657269d9c057e7aa079ffa9e1c16
### Operating system and version
Ubuntu 23.04 / macOS 13.4
### Machine specifications
Using Python 3.8.16 on both. macOS is on an Intel machine. Python is installed via PyEnv. I'm not using a virtual environment. | https://github.com/bitcoin/bitcoin/issues/27904 | https://github.com/bitcoin/bitcoin/pull/27906 | f0758d8a6696657269d9c057e7aa079ffa9e1c16 | 7f0b79ea132d22ad5212c1d3ff4325715ca5ac12 | 2023-06-16T20:14:59Z | c++ | 2023-06-18T10:48:46Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,893 | ["test/functional/test_framework/test_node.py"] | test: Cleanup is_node_stopped | ### Motivation
See https://github.com/bitcoin/bitcoin/pull/27708/files#r1227794716 and https://github.com/bitcoin/bitcoin/pull/27708/files#r1226949554
### Possible solution
(see above)
### Useful Skills
* Compile Bitcoin Core and run the tests
* Python 3 and the Bitcoin Core functional tests
### Guidance for new contributors
Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/27893 | https://github.com/bitcoin/bitcoin/pull/27895 | 9372ec71e8a3564dbc23997612f44648dcc072e3 | c454395115a89de8c274a79e0284acac1cb01485 | 2023-06-15T08:16:03Z | c++ | 2023-06-15T14:39:51Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,879 | [".cirrus.yml"] | arm64 CI failure | arm64 CI is failing with:
```
FAIL: minisketch/test
=====================
../build-aux/test-driver: line 109: ./minisketch/test: cannot execute binary file: Exec format error
FAIL minisketch/test (exit status: 126)
FAIL: univalue/test/object
==========================
../build-aux/test-driver: line 109: ./univalue/test/object: cannot execute binary file: Exec format error
FAIL univalue/test/object (exit status: 126)
FAIL: univalue/test/unitester
=============================
../build-aux/test-driver: line 109: ./univalue/test/unitester: cannot execute binary file: Exec format error
FAIL univalue/test/unitester (exit status: 126)
FAIL: qt/test/test_bitcoin-qt
=============================
../build-aux/test-driver: line 109: ./qt/test/test_bitcoin-qt: cannot execute binary file: Exec format error
FAIL qt/test/test_bitcoin-qt (exit status: 126)
```
See eg https://github.com/bitcoin/bitcoin/pull/27647/checks?check_run_id=14232303009 or https://github.com/bitcoin/bitcoin/pull/27746/checks?check_run_id=14231876127
I tried re-running the arm64 task for #27675 which had succeeded yesterday, and it now fails too ([before](https://cirrus-ci.com/task/6152515125772288) vs [after](https://cirrus-ci.com/task/6688015473442816)), which suggests either that the bug was introduced after commit fbe48f97dfec3138b06b5f00b75655da0c985008 up to commit 427853ab49f610e971b73ea4cc1d5366747e52b1 (nothing seemed likely to break minisketch/test there) or is an infrastructure issue (bad cache or bad hardware?). | https://github.com/bitcoin/bitcoin/issues/27879 | https://github.com/bitcoin/bitcoin/pull/27886 | 6663c802fee07692283d55a785896d8712d11d9c | a8d0f6c863a088db918b17b32cd3771ce5ed5970 | 2023-06-14T02:23:20Z | c++ | 2023-06-14T13:36:03Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,873 | ["autogen.sh"] | Can't copy to 'build-aux/config.guess' in autoconf.sh: Permission denied | https://github.com/bitcoin/bitcoin/issues/26422 broke the `autogen.sh` part of my development builds on NixOS - found #26422 by bisecting. The error is:
```
$ ./autogen.sh
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'build-aux/m4'.
libtoolize: copying file 'build-aux/m4/libtool.m4'
libtoolize: copying file 'build-aux/m4/ltoptions.m4'
libtoolize: copying file 'build-aux/m4/ltsugar.m4'
libtoolize: copying file 'build-aux/m4/ltversion.m4'
libtoolize: copying file 'build-aux/m4/lt~obsolete.m4'
configure.ac:37: installing 'build-aux/compile'
configure.ac:27: installing 'build-aux/missing'
Makefile.am: installing 'build-aux/depcomp'
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'build-aux/m4'.
libtoolize: copying file 'build-aux/m4/libtool.m4'
libtoolize: copying file 'build-aux/m4/ltoptions.m4'
libtoolize: copying file 'build-aux/m4/ltsugar.m4'
libtoolize: copying file 'build-aux/m4/ltversion.m4'
libtoolize: copying file 'build-aux/m4/lt~obsolete.m4'
configure.ac:122: installing 'build-aux/compile'
configure.ac:58: installing 'build-aux/missing'
src/Makefile.am: installing 'build-aux/depcomp'
cp: cannot create regular file 'build-aux/config.guess': Permission denied
```
_Originally posted by @0xB10C in https://github.com/bitcoin/bitcoin/issues/26422#issuecomment-1589094552_
| https://github.com/bitcoin/bitcoin/issues/27873 | https://github.com/bitcoin/bitcoin/pull/27875 | b3db18a0126bc4181d2a0880c27f45d203d06179 | 1ecdf6ea8fb6dc1d64f41323a1e337beb174c25b | 2023-06-13T11:50:52Z | c++ | 2023-06-16T10:03:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,860 | ["test/functional/p2p_leak_tx.py"] | tsan: failure in p2p_leak_tx.py | master @ 6f5f37eefd425faabd9a97a3c3028395c34f08c4.
https://cirrus-ci.com/task/5086176751648768?logs=ci#L3409:
```bash
node0 2023-06-12T12:48:24.904003Z [msghand] [txmempool.cpp:1011] [RemoveUnbroadcastTx] [mempool] Removed 0668eb571427ae4ed5ee1f9d9d3d0c6de4261bba44335d033a75be0183d87a46 from set of unbroadcast txns
test 2023-06-12T12:48:24.952000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/p2p_leak_tx.py", line 30, in run_test
self.test_notfound_on_replaced_tx()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/p2p_leak_tx.py", line 74, in test_notfound_on_replaced_tx
assert "tx" not in inbound_peer.last_message
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError
test 2023-06-12T12:48:24.954000Z TestFramework (DEBUG): Closing down network thread
``` | https://github.com/bitcoin/bitcoin/issues/27860 | https://github.com/bitcoin/bitcoin/pull/27864 | d80348ccb65601d19b4b408d442e0999b5a6cf98 | 8de9bb7a5ab04669369e2bb59ea92a5c1a91a8d2 | 2023-06-12T13:07:55Z | c++ | 2023-06-13T08:43:53Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,841 | ["contrib/devtools/utxo_snapshot.sh"] | Stuck chainstate when utxo_snapshot.sh fails | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
IBD/chainstate gets stuck if utxo_snapshot.sh fails. No new blocks are downloaded. Restarting bitcoind does not help. Taking another snapshot __at an earlier height__ or reindex is required to repair.
utxo_snapshot.sh output:
```
Rewinding chain back to height 788440 (by invalidating 000000000000000000052ac0ce9b8f1a2e7691771e6386f770432c9443dc2af7); this may take a while
Generating UTXO snapshot...
error code: -8
error message:
/home/chris/Desktop/assumeutxo/test/utxo-788440.dat already exists. If you are sure this is what you want, move it out of the way first
```
Note that moving the file or choosing another filename and rerunning does not fix. But taking another snapshot at an earlier height will.
### Expected behaviour
If utxo_snapshot.sh fails, bitcoind should cancel rewind and recover.
Also, if a filepath that already exists is passed to utxosnapshot.sh, it should early exit before rewinding. This could perhaps be considered a separate issue.
### Steps to reproduce
1. Create a dummy file for the purpose of the test e.g. `echo "some bytes so file is not empty" > ./utxo-788440.dat`
2. Run bitcoind and wait for it to sync
3. Run utxosnapshot.sh with some blockheight and a filepath __that already exists__ e.g. `./contrib/devtools/utxo_snapshot.sh 788440 ./utxo-788440.dat ./src/bitcoin-cli`
4. Wait for chain rewind to happen, snapshot to be generated and write to disk fail
5. Observe bitcoind is now stuck with an invalid block at the rewind height
### Relevant log output
```
2023-06-08T23:51:50Z [httpworker.3] UpdateTip: new best=000000000000000000014a9d36f6a19aca593f0c228ae1b1b6fe33361fa67be1 height=788440 version=0x2001e000 log2_work=94.162204 tx=832727241 date='2023-05-06T02:54:13Z' progress=0.987258 cache=790.3MiB(1245160txo)
2023-06-08T23:51:50Z [httpworker.3] InvalidChainFound: invalid block=000000000000000000052ac0ce9b8f1a2e7691771e6386f770432c9443dc2af7 height=788441 log2_work=94.162217 date=2023-05-06T02:55:43Z
2023-06-08T23:51:50Z [httpworker.3] InvalidChainFound: current best=000000000000000000014a9d36f6a19aca593f0c228ae1b1b6fe33361fa67be1 height=788440 log2_work=94.162204 date=2023-05-06T02:54:13Z
```
```
Rewinding chain back to height 788440 (by invalidating 000000000000000000052ac0ce9b8f1a2e7691771e6386f770432c9443dc2af7); this may take a while
Generating UTXO snapshot...
error code: -8
error message:
/home/chris/Desktop/assumeutxo/test/utxo-788440.dat already exists. If you are sure this is what you want, move it out of the way first
```
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
v25.99.0-3dc6fd620e28
### Operating system and version
Linux 6.3.1-arch2-1
### Machine specifications
_No response_ | https://github.com/bitcoin/bitcoin/issues/27841 | https://github.com/bitcoin/bitcoin/pull/28852 | afdc4c3a30c0543a837a317b643cf2737ed3178c | 1c8893bd1c80043ee47e0dd9b63b09bb65d25fa2 | 2023-06-09T00:04:28Z | c++ | 2023-12-04T22:07:14Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,828 | ["src/rpc/rawtransaction.cpp", "src/wallet/rpc/spend.cpp"] | bitcoin-cli output help text - (json object) not utilizing RPCArg::Optional value | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
When executing: `bitcoin-cli walletcreatefundedpsbt` or `bitcoin-cli createpsbt` without args you will get a help output that looks like this:
```
Creates and funds a transaction in the Partially Signed Transaction format.
Implements the Creator and Updater roles.
All existing inputs must either have their previous output transaction be in the wallet
or be in the UTXO set. Solving data must be provided for non-wallet inputs.
Arguments:
1. inputs (json array, optional) Leave empty to add inputs automatically. See add_inputs option.
[
{ (json object)
"txid": "hex", (string, required) The transaction id
"vout": n, (numeric, required) The output number
"sequence": n, (numeric, optional, default=depends on the value of the 'locktime' and 'options.replaceable' arguments) The sequence number
"weight": n, (numeric, optional, default=Calculated from wallet and solving data) The maximum weight for this input, including the weight of the outpoint and sequence number. Note that signature sizes are not guaranteed to be consistent, so the maximum DER signatures size of 73 bytes should be used when considering ECDSA signatures.Remember to convert serialized sizes to weight units when necessary.
},
...
]
2. outputs (json array, required) The outputs (key-value pairs), where none of the keys are duplicated.
That is, each address can only appear once and there can only be one 'data' object.
For compatibility reasons, a dictionary, which holds the key-value pairs directly, is also
accepted as second parameter.
[
{ (json object)
"address": amount, (numeric or string, required) A key-value pair. The key (string) is the bitcoin address,
the value (float or string) is the amount in BTC
...
},
{ (json object)
"data": "hex", (string, required) A key-value pair. The key must be "data", the value is hex-encoded data
},
...
]
3. locktime (numeric, optional, default=0) Raw locktime. Non-0 value also locktime-activates inputs
4. options (json object, optional)
{
"add_inputs": bool, (boolean, optional, default=false when "inputs" are specified, true otherwise) Automatically include coins from the wallet to cover the target amount.
"include_unsafe": bool, (boolean, optional, default=false) Include inputs that are not safe to spend (unconfirmed transactions from outside keys and unconfirmed replacement transactions).
Warning: the resulting transaction may become invalid if one of the unsafe inputs disappears.
If that happens, you will need to fund the transaction with different inputs and republish it.
"minconf": n, (numeric, optional, default=0) If add_inputs is specified, require inputs with at least this many confirmations.
"maxconf": n, (numeric, optional) If add_inputs is specified, require inputs with at most this many confirmations.
"changeAddress": "str", (string, optional, default=automatic) The bitcoin address to receive the change
"changePosition": n, (numeric, optional, default=random) The index of the change output
"change_type": "str", (string, optional, default=set by -changetype) The output type to use. Only valid if changeAddress is not specified. Options are "legacy", "p2sh-segwit", "bech32", and "bech32m".
"includeWatching": bool, (boolean, optional, default=true for watch-only wallets, otherwise false) Also select inputs which are watch only
"lockUnspents": bool, (boolean, optional, default=false) Lock selected unspent outputs
"fee_rate": amount, (numeric or string, optional, default=not set, fall back to wallet fee estimation) Specify a fee rate in sat/vB.
"feeRate": amount, (numeric or string, optional, default=not set, fall back to wallet fee estimation) Specify a fee rate in BTC/kvB.
"subtractFeeFromOutputs": [ (json array, optional, default=[]) The outputs to subtract the fee from.
The fee will be equally deducted from the amount of each specified output.
Those recipients will receive less bitcoins than you enter in their corresponding amount field.
If no outputs are specified here, the sender pays the fee.
vout_index, (numeric) The zero-based output index, before a change output is added.
...
],
"conf_target": n, (numeric, optional, default=wallet -txconfirmtarget) Confirmation target in blocks
"estimate_mode": "str", (string, optional, default="unset") The fee estimate mode, must be one of (case insensitive):
"unset"
"economical"
"conservative"
"replaceable": bool, (boolean, optional, default=wallet default) Marks this transaction as BIP125-replaceable.
Allows this transaction to be replaced by a transaction with higher fees
"solving_data": { (json object, optional) Keys and scripts needed for producing a final transaction with a dummy signature.
Used for fee estimation during coin selection.
"pubkeys": [ (json array, optional, default=[]) Public keys involved in this transaction.
"pubkey", (string) A public key
...
],
"scripts": [ (json array, optional, default=[]) Scripts involved in this transaction.
"script", (string) A script
...
],
"descriptors": [ (json array, optional, default=[]) Descriptors that provide solving data for this transaction.
"descriptor", (string) A descriptor
...
],
},
}
5. bip32derivs (boolean, optional, default=true) Include BIP 32 derivation paths for public keys if we know them
Result:
{ (json object)
"psbt" : "str", (string) The resulting raw transaction (base64-encoded string)
"fee" : n, (numeric) Fee in BTC the resulting transaction pays
"changepos" : n (numeric) The position of the added change output, or -1
}
Examples:
Create a transaction with no inputs
> bitcoin-cli walletcreatefundedpsbt "[{\"txid\":\"myid\",\"vout\":0}]" "[{\"data\":\"00010203\"}]"
```
The (json object)'s within `outputs` are not being populated with "required" or "optional"
### Expected behaviour
`(json object, optional)` or `(json object, required)` appears in help text.
Edit: This is more complicated as 1 of the 2 are minimally needed. Instead helper text was added.
### Steps to reproduce
Running v25 of bitcoin core and using bitcoin-cli.
### Relevant log output
_No response_
### How did you obtain Bitcoin Core
Pre-built binaries
### What version of Bitcoin Core are you using?
v25.0
### Operating system and version
Ubuntu 22 LTS
### Machine specifications
_No response_ | https://github.com/bitcoin/bitcoin/issues/27828 | https://github.com/bitcoin/bitcoin/pull/27829 | 8ff90d9dcfee12090421675c9c421ee611e5ec8b | 23f3f402fca346302fe424427ae4077d8a458cbb | 2023-06-05T15:42:47Z | c++ | 2023-08-23T20:37:28Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,799 | ["src/node/mini_miner.cpp"] | fuzz: mini_miner: Timeout in mini_miner | ERROR: type should be string, got " https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59285\r\n\r\n_Originally posted by @MarcoFalke in https://github.com/bitcoin/bitcoin/issues/27021#issuecomment-1568242621_\r\n " | https://github.com/bitcoin/bitcoin/issues/27799 | https://github.com/bitcoin/bitcoin/pull/27803 | 8a972813ba68307fa3a296e884b34928be96e246 | 6a560aceb75e618f3106a8850e053cd8de87616a | 2023-06-01T08:18:13Z | c++ | 2023-06-02T09:59:35Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,749 | ["test/functional/rpc_getblockfrompeer.py"] | rpc_getblockfrompeer.py intermittent failure: assert_equal(pruneheight, 248); not(249 == 248) | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
https://cirrus-ci.com/task/4776911524593664?logs=ci#L3147
```
test 2023-05-24T12:16:53.212000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-build-825335453/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "/tmp/cirrus-build-825335453/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/rpc_getblockfrompeer.py", line 126, in run_test
assert_equal(pruneheight, 248)
File "/tmp/cirrus-build-825335453/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 55, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(249 == 248)
```
### Expected behaviour
.
### Steps to reproduce
CI
### Relevant log output
_No response_
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
current master
### Operating system and version
[previous releases, qt5 dev package and depends packages, DEBUG] [focal]
### Machine specifications
_No response_ | https://github.com/bitcoin/bitcoin/issues/27749 | https://github.com/bitcoin/bitcoin/pull/27784 | 08722f20c2d1992739216bbe325b48639b805fde | 433f17bc3fe42b42ff89ca02112fc917a6287506 | 2023-05-25T06:34:28Z | c++ | 2023-05-31T09:33:42Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,722 | ["src/httpserver.cpp"] | bitcoind hangs waiting for `g_requests.empty()` | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
bitcoind hangs
### Expected behaviour
bitcoind shouldn't hang
I was able to dump the running threads and it was stuck waiting for `g_requests` to be empty. The issue seems to be that this callback may not actually be called in case of error: https://github.com/bitcoin/bitcoin/blob/22139f6e83a2bedd2dad9f280567d2c76c54252f/src/httpserver.cpp#L222-L227
See this issue https://github.com/libevent/libevent/issues/589 for more details. I think what happens is that interrupting `bitcoin-cli` before it has received the reply calls the error callback and then the success callback is never called.
I think this is also a memory leak since `g_requests` won't get cleaned up. Whether it's severe or not probably depends on the caller and what type of requests they are making. This new code was introduced here https://github.com/bitcoin/bitcoin/pull/26742
### Steps to reproduce
I was running a simple shell script in 4 terminal windows for fun:
```
#!/bin/bash
for i in {1..50000}
do
./src/bitcoin-cli -rpcuser=admin -rpcpassword=pass getrawtransaction 217819875434324c412d5e938f7f3c1670fb60814974cf7958f1fac90ee5afb7
done
```
I was messing around with this script and randomly Ctrl-C'd each terminal window in rapid succession and then when I waited up to a minute and Ctrl-C'd bitcoind, it didn't shutdown. I can reproduce it pretty reliably as well.
Compilation commands:
```
./autogen.sh; ./configure --without-wallet --with-gui=no --disable-zmq; make -j4
```
Run-time options (note that I was able to reproduce this with the default number of rpcthreads as well):
```
./src/bitcoind -txindex -rpcthreads=1 -debug
```
Output of `gcc --version`:
```
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/4.2.1
Apple clang version 11.0.3 (clang-1103.0.32.62)
Target: x86_64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
```
Output of `g++ --version`:
```
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/4.2.1
Apple clang version 11.0.3 (clang-1103.0.32.62)
Target: x86_64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
```
My libevent version is 2.1.12
### Relevant log output
```
^C2023-05-22T20:56:10Z [http] Interrupting HTTP server
2023-05-22T20:56:10Z [rpc] Interrupting HTTP RPC server
2023-05-22T20:56:10Z [rpc] Interrupting RPC
2023-05-22T20:56:10Z tor: Thread interrupt
2023-05-22T20:56:10Z Shutdown: In progress...
2023-05-22T20:56:10Z [rpc] Stopping HTTP RPC server
2023-05-22T20:56:10Z torcontrol thread exit
2023-05-22T20:56:10Z [http] Unregistering HTTP handler for / (exactmatch 1)
2023-05-22T20:56:10Z addcon thread exit
2023-05-22T20:56:10Z [http] Unregistering HTTP handler for /wallet/ (exactmatch 0)
2023-05-22T20:56:10Z [rpc] Stopping RPC
2023-05-22T20:56:10Z net thread exit
2023-05-22T20:56:10Z [rpc] RPC stopped.
2023-05-22T20:56:10Z [http] Stopping HTTP server
2023-05-22T20:56:10Z [http] Waiting for HTTP worker threads to exit
2023-05-22T20:56:10Z [http] Exited http event loop
2023-05-22T20:56:10Z [http] Waiting for 1 requests to stop HTTP server
```
The important bit is the very last log line. bitcoind was still alive and periodically printed log lines about feeding dynamic environment data into the RNG.
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
17acb2782a66f033238340e4fb81009e7f79e97a
### Operating system and version
macOS intel
### Machine specifications
_No response_ | https://github.com/bitcoin/bitcoin/issues/27722 | https://github.com/bitcoin/bitcoin/pull/28551 | 2f835d2ae4849b5612427da5f259bc34a3773098 | db7b5dfcc502a8a81c51f56fe753990ae8b3a202 | 2023-05-22T23:05:42Z | c++ | 2023-10-04T09:09:03Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,635 | ["src/validation.cpp"] | --with-sanitizers=float-divide-by-zero crash with -debug=bench in Chainstate::ConnectTip | Not sure if this UB causes issues with any compiler. clang is fine, see:
* `-fsanitize=float-divide-by-zero`: Floating point division by zero. This is undefined per the C and C++ standards, but is defined by Clang (and by ISO/IEC/IEEE 60559 / IEEE 754) as producing either an infinity or NaN value, so is not included in `-fsanitize=undefined`.
To reproduce just compile `--with-sanitizers=float-divide-by-zero` and run something, for example `bitcoind`:
```
UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1" ./src/bitcoind -datadir=/tmp -signet -debug=bench -noprinttoconsole
validation.cpp:2839:5: runtime error: division by zero
```
`float-divide-by-zero` is enabled by OSS-Fuzz, see https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=58887
I haven't checked, but I presume this instance was introduced by https://github.com/bitcoin/bitcoin/pull/24216 | https://github.com/bitcoin/bitcoin/issues/27635 | https://github.com/bitcoin/bitcoin/pull/27673 | 6cf47a8f44f96099a84e5c6e628e3499045e024d | f467b28ac35add304442f30c2a05ef5d9df496e2 | 2023-05-12T07:45:40Z | c++ | 2023-05-30T09:49:14Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,595 | ["test/functional/feature_taproot.py"] | ci: failure in feature_taproot.py (TSAN) | master at 26cb32c02d76d6635c67942a5eeb70a6199df69d. https://cirrus-ci.com/task/5769539133112320?logs=ci#L3369:
```bash
node0 2023-05-08T14:19:47.988934Z [httpworker.1] [rpc/request.cpp:181] [parse] [rpc] ThreadRPCServer method=sendrawtransaction user=__cookie__
test 2023-05-08T14:19:47.989000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_taproot.py", line 1759, in run_test
self.test_spenders(self.nodes[0], spenders_taproot_active(), input_counts=[1, 2, 2, 2, 2, 3])
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_taproot.py", line 1509, in test_spenders
node.sendrawtransaction(tx.serialize().hex(), 0)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/coverage.py", line 49, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/authproxy.py", line 126, in __call__
raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: non-mandatory-script-verify-flag (Data push larger than necessary) (-26)
node0 2023-05-08T14:19:47.989451Z [httpworker.1] [txmempool.cpp:659] [check] [mempool] Checking mempool with 0 transactions and 0 inputs
test 2023-05-08T14:19:47.997000Z TestFramework (DEBUG): Closing down network thread
``` | https://github.com/bitcoin/bitcoin/issues/27595 | https://github.com/bitcoin/bitcoin/pull/27631 | 50a664aceb993076522fcced9c933046ead985ea | 8847497161741052f27c4f8fb19a1a88238008f2 | 2023-05-08T14:49:12Z | c++ | 2023-06-23T22:54:06Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,586 | ["ci/test/00_setup_env_i686_multiprocess.sh", "ci/test/00_setup_env_native_fuzz_with_msan.sh", "ci/test/00_setup_env_native_qt5.sh", "configure.ac"] | CPU DoS on mainnet in debug mode | I've been seeing 100% cpu usage on one of my bitcoind nodes recently, with transactions taking >60s to be accepted into the mempool. Digging into it, the problem seems to be `BOOST_MULTI_INDEX_ENABLE_SAFE_MODE` which was introduced in #24395. That results in iterator destruction taking O(n) time (in the number of other active iterators on the same multi-index) in the worst case, rather than O(1) time, due to keeping the iterators in a [singly linked list](https://www.boost.org/doc/libs/1_82_0/boost/multi_index/detail/safe_mode.hpp):
```
* Iterators are chained in a single attached list, whose header is
* kept by the container. More elaborate data structures would yield better
* performance, but I decided to keep complexity to a minimum since
* speed is not an issue here.
```
Speed does become an issue here though, as we keep an iterator around for every mempool entry (in `vTxHashes`).
This isn't always a problem: presumably in the normal case new iterators are added to the head of the list then removed while they're still roughly at the head of the list, giving O(1) timing; but somehow having a full mempool (and hence TrimToSize actually doing things) triggers worst case behaviour? | https://github.com/bitcoin/bitcoin/issues/27586 | https://github.com/bitcoin/bitcoin/pull/27724 | dfe658009d5ab732bf48319588f532fbd2f11f1a | fb4f04768634b1c494618f624e84c728f21e218e | 2023-05-06T02:00:35Z | c++ | 2023-05-29T16:09:47Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,555 | ["src/init.cpp", "src/policy/fees.cpp", "src/policy/fees.h", "src/test/fuzz/policy_estimator.cpp", "src/test/fuzz/policy_estimator_io.cpp", "src/test/util/setup_common.cpp", "test/functional/feature_fee_estimation.py"] | Avoid serving stale fees | After conversation on irc it appears there's some cases where Bitcoin core will serve feerate information even though it loaded a fairly old fee estimates file and is still syncing the chain. This is pretty dangerous for lightning nodes, at least on legacy channels or pre-package-relay.
The immediate improvement would be to store fee estimates to disk once an hour or so to reduce the chance of having an old file. From there this case could probably be detected and refuse to serve estimates until we sync. | https://github.com/bitcoin/bitcoin/issues/27555 | https://github.com/bitcoin/bitcoin/pull/27622 | 8f402710371a40c5777dc3f9c4ba6ca8505a2f90 | f80db62b2d05223b0cd5d3507dd01db7b4378d48 | 2023-05-02T15:26:39Z | c++ | 2023-06-20T15:48:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,537 | [".cirrus.yml", "build-aux/m4/l_filesystem.m4", "ci/test/00_setup_env_i686_centos.sh", "ci/test/00_setup_env_native_qt5.sh", "ci/test/01_base_install.sh", "ci/test/06_script_b.sh", "configure.ac", "doc/dependencies.md", "src/qt/addresstablemodel.cpp", "src/txrequest.cpp"] | Drop support for g++-8? | I am wondering when we can drop support for g++-8. All supported operating systems, except for CentOS Stream 8 offer a greater version:
* Ubuntu Focal: gcc 9 (https://packages.ubuntu.com/focal/gcc)
* Debian Bullseye: gcc 10 (https://packages.debian.org/bullseye/gcc)
* CentOS 8 Stream: gcc 8, with EOL of " May 31st, 2024 " (https://www.centos.org/centos-stream/)
The rationale for dropping it would be that there are currently occasional compile failures with perfectly valid C++-17 code, for example:
* `error: call to non-‘constexpr’ function ‘void __assert_fail(const char*, const char*, unsigned int, const char*)’ assert(false);` (https://godbolt.org/z/bxaMnfcsa) | https://github.com/bitcoin/bitcoin/issues/27537 | https://github.com/bitcoin/bitcoin/pull/27662 | 6cc136bbd36f859a16e469bb5c016d06c19bcd50 | edd6d8395f5dd00ea9fc54d9de1ad4ad236aa5b3 | 2023-04-27T07:57:13Z | c++ | 2023-05-19T08:57:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,472 | ["src/outputtype.cpp"] | Mishandled "unknown" Address Type | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
Bitcoin Core behaves unexpectedly or even crashes.
* `getnewaddress "" unknown`: "Error: No unknown addresses available. (code -12)"
* `getrawchangeaddress unknown`: "Error: No unknown addresses available. (code -12)"
* `createmultisig 2 '["03789ed0bb717d88f7d321a368d905e7430207ebbd82bd342cf11ae157a7ace5fd", "03dbc6764b8884a92e871274b87583e6d5c2a58819473e17e107ef3f6aa5a61626"]' unknown`: Bitcoin-Qt crashes with Assertion Error: "bitcoin-qt: outputtype.cpp:110: CTxDestination AddAndGetDestinationForScript(FillableSigningProvider&, const CScript&, OutputType): Assertion `false' failed."
* Bitcoin-Qt can be started with `-addresstype=unknown` or `-changetype=unknown` without any error message.
### Expected behaviour
Bitcoin Core tells me something like "Unknown address type 'unknown' (code -5)", as if I used any type that is not `legacy`, `p2sh-segwit`, `bech32`, or `bech32m`.
### Steps to reproduce
Open Bitcoin-Qt Console, create/open a wallet with appropriate settings if necessary, and run the commands above.
Or start it with `-addresstype=unknown` or` -changetype=unknown`.
### Relevant log output
_No response_
### How did you obtain Bitcoin Core
Compiled from source
### What version of Bitcoin Core are you using?
master@b22c275582cc
### Operating system and version
Debian 12 (Testing)
### Machine specifications
_No response_ | https://github.com/bitcoin/bitcoin/issues/27472 | https://github.com/bitcoin/bitcoin/pull/27473 | e054b7390ca9498c6c2bbc775c8af9f8e94c52dd | 4ad20a2258935d48dd972cb72bc9030d875164b5 | 2023-04-16T21:16:57Z | c++ | 2023-04-17T14:18:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,381 | ["src/script/miniscript.h"] | miniscript: comparison of integers of different signs | This is being emitted with [GCC 10.2.1](https://packages.debian.org/bullseye/g++-arm-linux-gnueabihf), in some CI jobs: i.e https://github.com/bitcoin/bitcoin/pull/25972/checks?check_run_id=12423693655, or https://github.com/bitcoin/bitcoin/pull/25972/checks?check_run_id=12423693651 (where we actually turn on all our warning flags with depends builds).
```bash
In file included from test/miniscript_tests.cpp:19:
./script/miniscript.h:1197:71: error: comparison of integers of different signs: 'typename iterator_traits<int *>::difference_type' (aka 'int') and 'const uint32_t' (aka 'const unsigned int') [-Werror,-Wsign-compare]
return std::count(subs.begin(), subs.end(), true) >= node.k;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~
test/miniscript_tests.cpp:346:34: note: in instantiation of function template specialization 'miniscript::Node<CPubKey>::IsSatisfiable<(lambda at test/miniscript_tests.cpp:346:48)>' requested here
bool satisfiable = node->IsSatisfiable([](const Node&) { return true; });
^
1 error generated.
```
cc @darosior | https://github.com/bitcoin/bitcoin/issues/27381 | https://github.com/bitcoin/bitcoin/pull/27382 | a8649984d8621fcc102241a8694a05b495366244 | 5150e280103dd41c8a438ce72359b0f25ff23a2f | 2023-03-31T12:24:02Z | c++ | 2023-04-02T12:06:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,355 | ["src/Makefile.test_util.include", "src/test/blockfilter_index_tests.cpp", "src/test/coinstatsindex_tests.cpp", "src/test/txindex_tests.cpp", "src/test/util/index.cpp", "src/test/util/index.h"] | index: ThreadSanitizer: data race on vptr | Seen with master @ 220008604f15d5078092dea28be3e3f7f11b6c8f on aarch64 (with `NO_BDB=1`). Follow up from #27298. See also #26188.
```bash
2023-03-28T13:52:47.882295Z (mocktime: 2020-08-31T15:34:12Z) [test] [dbwrapper.cpp:158] [CDBWrapper] Opened LevelDB successfully
2023-03-28T13:52:47.882390Z (mocktime: 2020-08-31T15:34:12Z) [test] [dbwrapper.cpp:183] [CDBWrapper] Using obfuscation key for /tmp/test_common_Bitcoin Core/0959fba80d599fe246b0b5ced04b4d1ecd504db9812edbff4ada2d88c6b218ae/regtest/indexes/txindex: 0000000000000000
2023-03-28T13:52:47.884002Z (mocktime: 2020-08-31T15:34:12Z) [txindex] [util/thread.cpp:20] [TraceThread] txindex thread start
test/txindex_tests.cpp(38): fatal error: in "txindex_tests/txindex_initial_sync": critical check time_start + timeout_ms > GetTimeMillis() has failed
LLVMSymbolizer: error reading file: No such file or directory
make[3]: *** [Makefile:21823: test/txindex_tests.cpp.test] Error 1
make[3]: Leaving directory '/home/fedora/bitcoin/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src'
make[2]: *** [Makefile:19828: check-am] Error 2
make[2]: Leaving directory '/home/fedora/bitcoin/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src'
make[1]: *** [Makefile:19493: check-recursive] Error 1
make[1]: Leaving directory '/home/fedora/bitcoin/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src'
make: *** [Makefile:816: check-recursive] Error 1
==================
WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) (pid=24142)
Write of size 8 at 0xfffffee67968 by main thread:
#0 BaseIndex::~BaseIndex() src/index/base.cpp:80:1 (test_bitcoin+0xc54cc8) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#1 TxIndex::~TxIndex() src/index/txindex.cpp:56:19 (test_bitcoin+0xc6daec) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#2 txindex_tests::txindex_initial_sync::test_method() src/test/txindex_tests.cpp:82:1 (test_bitcoin+0x7c281c) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#3 txindex_tests::txindex_initial_sync_invoker() src/test/txindex_tests.cpp:17:1 (test_bitcoin+0x7c0f78) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#4 boost::detail::function::void_function_invoker0<void (*)(), void>::invoke(boost::detail::function::function_buffer&) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/function/function_template.hpp:117:11 (test_bitcoin+0x2b78e8) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#5 boost::function0<void>::operator()() const /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/function/function_template.hpp:763:14 (test_bitcoin+0x24f35c) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#6 boost::detail::forward::operator()() /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/execution_monitor.ipp:1388:32 (test_bitcoin+0x24f35c)
#7 boost::detail::function::function_obj_invoker0<boost::detail::forward, int>::invoke(boost::detail::function::function_buffer&) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/function/function_template.hpp:137:18 (test_bitcoin+0x24f35c)
#8 boost::function0<int>::operator()() const /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/function/function_template.hpp:763:14 (test_bitcoin+0x1e3384) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#9 int boost::detail::do_invoke<boost::shared_ptr<boost::detail::translator_holder_base>, boost::function<int ()>>(boost::shared_ptr<boost::detail::translator_holder_base> const&, boost::function<int ()> const&) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/execution_monitor.ipp:301:30 (test_bitcoin+0x1e3384)
#10 boost::execution_monitor::catch_signals(boost::function<int ()> const&) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/execution_monitor.ipp:903:16 (test_bitcoin+0x1e3384)
#11 boost::execution_monitor::execute(boost::function<int ()> const&) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/execution_monitor.ipp:1301:16 (test_bitcoin+0x1e367c) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#12 boost::execution_monitor::vexecute(boost::function<void ()> const&) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/execution_monitor.ipp:1397:5 (test_bitcoin+0x1dcec0) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#13 boost::unit_test::unit_test_monitor_t::execute_and_translate(boost::function<void ()> const&, unsigned long) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/unit_test_monitor.ipp:49:9 (test_bitcoin+0x1dcec0)
#14 boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/framework.ipp:815:44 (test_bitcoin+0x20cdfc) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#15 boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/framework.ipp:784:58 (test_bitcoin+0x20d128) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#16 boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/framework.ipp:784:58 (test_bitcoin+0x20d128) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#17 boost::unit_test::framework::run(unsigned long, bool) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/framework.ipp:1722:29 (test_bitcoin+0x1dbe64) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#18 boost::unit_test::unit_test_main(boost::unit_test::test_suite* (*)(int, char**), int, char**) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/unit_test_main.ipp:250:9 (test_bitcoin+0x1f57c8) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#19 main /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/unit_test_main.ipp:306:12 (test_bitcoin+0x1f5d74) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
Previous read of size 8 at 0xfffffee67968 by thread T4:
#0 BaseIndex::ThreadSync() src/index/base.cpp:217:18 (test_bitcoin+0xc55ba0) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#1 BaseIndex::Start()::$_0::operator()() const src/index/base.cpp:404:73 (test_bitcoin+0xc59324) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#2 decltype(std::declval<BaseIndex::Start()::$_0&>()()) std::__1::__invoke[abi:v160000]<BaseIndex::Start()::$_0&>(BaseIndex::Start()::$_0&) /usr/lib/llvm-16/bin/../include/c++/v1/__functional/invoke.h:394:23 (test_bitcoin+0xc59324)
#3 void std::__1::__invoke_void_return_wrapper<void, true>::__call<BaseIndex::Start()::$_0&>(BaseIndex::Start()::$_0&) /usr/lib/llvm-16/bin/../include/c++/v1/__functional/invoke.h:487:9 (test_bitcoin+0xc59324)
#4 std::__1::__function::__alloc_func<BaseIndex::Start()::$_0, std::__1::allocator<BaseIndex::Start()::$_0>, void ()>::operator()[abi:v160000]() /usr/lib/llvm-16/bin/../include/c++/v1/__functional/function.h:185:16 (test_bitcoin+0xc59324)
#5 std::__1::__function::__func<BaseIndex::Start()::$_0, std::__1::allocator<BaseIndex::Start()::$_0>, void ()>::operator()() /usr/lib/llvm-16/bin/../include/c++/v1/__functional/function.h:356:12 (test_bitcoin+0xc59324)
#6 std::__1::__function::__value_func<void ()>::operator()[abi:v160000]() const /usr/lib/llvm-16/bin/../include/c++/v1/__functional/function.h:510:16 (test_bitcoin+0x10cbd30) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#7 std::__1::function<void ()>::operator()() const /usr/lib/llvm-16/bin/../include/c++/v1/__functional/function.h:1156:12 (test_bitcoin+0x10cbd30)
#8 util::TraceThread(std::__1::basic_string_view<char, std::__1::char_traits<char>>, std::__1::function<void ()>) src/util/thread.cpp:21:9 (test_bitcoin+0x10cbd30)
#9 decltype(std::declval<void (*)(std::__1::basic_string_view<char, std::__1::char_traits<char>>, std::__1::function<void ()>)>()(std::declval<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>(), std::declval<BaseIndex::Start()::$_0>())) std::__1::__invoke[abi:v160000]<void (*)(std::__1::basic_string_view<char, std::__1::char_traits<char>>, std::__1::function<void ()>), std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, BaseIndex::Start()::$_0>(void (*&&)(std::__1::basic_string_view<char, std::__1::char_traits<char>>, std::__1::function<void ()>), std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>&&, BaseIndex::Start()::$_0&&) /usr/lib/llvm-16/bin/../include/c++/v1/__functional/invoke.h:394:23 (test_bitcoin+0xc58e70) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#10 void std::__1::__thread_execute[abi:v160000]<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct>>, void (*)(std::__1::basic_string_view<char, std::__1::char_traits<char>>, std::__1::function<void ()>), std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, BaseIndex::Start()::$_0, 2ul, 3ul>(std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct>>, void (*)(std::__1::basic_string_view<char, std::__1::char_traits<char>>, std::__1::function<void ()>), std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, BaseIndex::Start()::$_0>&, std::__1::__tuple_indices<2ul, 3ul>) /usr/lib/llvm-16/bin/../include/c++/v1/thread:282:5 (test_bitcoin+0xc58e70)
#11 void* std::__1::__thread_proxy[abi:v160000]<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct>>, void (*)(std::__1::basic_string_view<char, std::__1::char_traits<char>>, std::__1::function<void ()>), std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, BaseIndex::Start()::$_0>>(void*) /usr/lib/llvm-16/bin/../include/c++/v1/thread:293:5 (test_bitcoin+0xc58e70)
Location is stack of main thread.
Location is global '??' at 0xfffffee4a000 ([stack]+0x1d968)
Thread T4 'b-txindex' (tid=24147, running) created by main thread at:
#0 pthread_create <null> (test_bitcoin+0x13776c) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#1 std::__1::__libcpp_thread_create[abi:v160000](unsigned long*, void* (*)(void*), void*) /usr/lib/llvm-16/bin/../include/c++/v1/__threading_support:378:10 (test_bitcoin+0xc58b00) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#2 std::__1::thread::thread<void (*)(std::__1::basic_string_view<char, std::__1::char_traits<char>>, std::__1::function<void ()>), std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, BaseIndex::Start()::$_0, void>(void (*&&)(std::__1::basic_string_view<char, std::__1::char_traits<char>>, std::__1::function<void ()>), std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, BaseIndex::Start()::$_0&&) /usr/lib/llvm-16/bin/../include/c++/v1/thread:309:16 (test_bitcoin+0xc58b00)
#3 BaseIndex::Start() src/index/base.cpp:404:21 (test_bitcoin+0xc58b00)
#4 txindex_tests::txindex_initial_sync::test_method() src/test/txindex_tests.cpp:32:5 (test_bitcoin+0x7c18d8) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#5 txindex_tests::txindex_initial_sync_invoker() src/test/txindex_tests.cpp:17:1 (test_bitcoin+0x7c0f78) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#6 boost::detail::function::void_function_invoker0<void (*)(), void>::invoke(boost::detail::function::function_buffer&) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/function/function_template.hpp:117:11 (test_bitcoin+0x2b78e8) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#7 boost::function0<void>::operator()() const /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/function/function_template.hpp:763:14 (test_bitcoin+0x24f35c) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#8 boost::detail::forward::operator()() /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/execution_monitor.ipp:1388:32 (test_bitcoin+0x24f35c)
#9 boost::detail::function::function_obj_invoker0<boost::detail::forward, int>::invoke(boost::detail::function::function_buffer&) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/function/function_template.hpp:137:18 (test_bitcoin+0x24f35c)
#10 boost::function0<int>::operator()() const /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/function/function_template.hpp:763:14 (test_bitcoin+0x1e3384) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#11 int boost::detail::do_invoke<boost::shared_ptr<boost::detail::translator_holder_base>, boost::function<int ()>>(boost::shared_ptr<boost::detail::translator_holder_base> const&, boost::function<int ()> const&) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/execution_monitor.ipp:301:30 (test_bitcoin+0x1e3384)
#12 boost::execution_monitor::catch_signals(boost::function<int ()> const&) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/execution_monitor.ipp:903:16 (test_bitcoin+0x1e3384)
#13 boost::execution_monitor::execute(boost::function<int ()> const&) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/execution_monitor.ipp:1301:16 (test_bitcoin+0x1e367c) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#14 boost::execution_monitor::vexecute(boost::function<void ()> const&) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/execution_monitor.ipp:1397:5 (test_bitcoin+0x1dcec0) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#15 boost::unit_test::unit_test_monitor_t::execute_and_translate(boost::function<void ()> const&, unsigned long) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/unit_test_monitor.ipp:49:9 (test_bitcoin+0x1dcec0)
#16 boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/framework.ipp:815:44 (test_bitcoin+0x20cdfc) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#17 boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/framework.ipp:784:58 (test_bitcoin+0x20d128) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#18 boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/framework.ipp:784:58 (test_bitcoin+0x20d128) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#19 boost::unit_test::framework::run(unsigned long, bool) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/framework.ipp:1722:29 (test_bitcoin+0x1dbe64) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#20 boost::unit_test::unit_test_main(boost::unit_test::test_suite* (*)(int, char**), int, char**) /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/unit_test_main.ipp:250:9 (test_bitcoin+0x1f57c8) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
#21 main /home/fedora/bitcoin/depends/aarch64-unknown-linux-gnu/include/boost/test/impl/unit_test_main.ipp:306:12 (test_bitcoin+0x1f5d74) (BuildId: 4e139378821749f690b2477a97607af03b8272e9)
SUMMARY: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) src/index/base.cpp:80:1 in BaseIndex::~BaseIndex()
==================
real 30m28.818s
user 0m1.731s
sys 0m1.874s
``` | https://github.com/bitcoin/bitcoin/issues/27355 | https://github.com/bitcoin/bitcoin/pull/27988 | b5ebeb376dd3862fe4ca0c57c5861fe18d9c901a | 47ab00666e2569bbe69c560f68d34f85aa49a73c | 2023-03-28T14:06:07Z | c++ | 2023-06-30T09:06:58Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,321 | ["ci/test/01_base_install.sh"] | ci: Cleanup ci/test/01_base_install.sh | ### Motivation
Currently `ci/test/01_base_install.sh` has the following issues:
* Two names to alias `bash -c`: `CI_EXEC_ROOT`, and `CI_EXEC`
* The aliases are not needed, as explained in the comment in the file
Thus, they should be removed, or at least de-duplicated. The whole file is already run in bash, so the only place where `bash -c "..."` is needed is in the `apt install` step to properly pass the packages string with spaces.
### Possible solution
* Remove or de-duplicate `CI_EXEC_ROOT`, and `CI_EXEC`
### Useful Skills
* Bash
* Docker or Podman
* The Bitcoin Core `./ci/` system (see Readme there). For testing I recommend to set up a fresh Linux VM.
### Guidance for new contributors
Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/27321 | https://github.com/bitcoin/bitcoin/pull/27333 | 328087d16f4362a23a72575fee930a275efbf3dd | 45be6af694b7d18371af1882a56d6f04be030728 | 2023-03-24T12:41:33Z | c++ | 2023-03-30T17:55:27Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,320 | ["src/test/validation_chainstatemanager_tests.cpp"] | test_bitcoin: ./chain.h:261: uint256 CBlockIndex::GetBlockHash() const: Assertion `phashBlock != nullptr' failed. | https://cirrus-ci.com/task/6024293113397248?logs=ci#L3199
```
Simulating node restart
2023-03-23T20:11:01.824273Z (mocktime: 2020-08-31T15:36:02Z) [test] [logging/timer.h:58] [Log] [bench] FlushStateToDisk: write block and undo data to disk started
2023-03-23T20:11:01.824318Z (mocktime: 2020-08-31T15:36:02Z) [test] [logging/timer.h:58] [Log] [bench] FlushStateToDisk: write block and undo data to disk completed (0.03ms)
2023-03-23T20:11:01.824330Z (mocktime: 2020-08-31T15:36:02Z) [test] [logging/timer.h:58] [Log] [bench] FlushStateToDisk: write block index to disk started
2023-03-23T20:11:01.825668Z (mocktime: 2020-08-31T15:36:02Z) [test] [logging/timer.h:58] [Log] [bench] FlushStateToDisk: write block index to disk completed (1.33ms)
2023-03-23T20:11:01.825686Z (mocktime: 2020-08-31T15:36:02Z) [test] [logging/timer.h:58] [Log] [bench] FlushStateToDisk: write coins cache to disk (0 coins, 0kB) started
2023-03-23T20:11:01.825704Z (mocktime: 2020-08-31T15:36:02Z) [test] [txdb.cpp:167] [BatchWrite] [coindb] Writing final batch of 0.00 MiB
2023-03-23T20:11:01.825719Z (mocktime: 2020-08-31T15:36:02Z) [test] [txdb.cpp:169] [BatchWrite] [coindb] Committed 0 changed transaction outputs (out of 0) to coin database...
2023-03-23T20:11:01.825732Z (mocktime: 2020-08-31T15:36:02Z) [test] [logging/timer.h:58] [Log] [bench] FlushStateToDisk: write coins cache to disk (0 coins, 0kB) completed (0.03ms)
2023-03-23T20:11:01.825744Z (mocktime: 2020-08-31T15:36:02Z) [test] [validationinterface.cpp:249] [ChainStateFlushed] [validation] Enqueuing ChainStateFlushed: block hash=696e92821f65549c7ee134edceeeeaaa4105647a3c4fd9f298c0aec0ab50425c
Performing Load/Verify/Activate of chainstate
test_bitcoin: ./chain.h:261: uint256 CBlockIndex::GetBlockHash() const: Assertion `phashBlock != nullptr' failed.
make[3]: *** [Makefile:21821: test/validation_chainstatemanager_tests.cpp.test] Error 1 | https://github.com/bitcoin/bitcoin/issues/27320 | https://github.com/bitcoin/bitcoin/pull/27348 | b759cefe936ed3991633acff215ea1dcec5ece28 | 86e7410b22d506a6ff22ccc36afac29dd10d0ede | 2023-03-24T09:31:29Z | c++ | 2023-03-28T10:14:02Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,316 | ["test/functional/wallet_create_tx.py"] | wallet_create_tx.py "Not solvable pre-selected input" exception | ### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current behaviour
CI test failure https://cirrus-ci.com/task/5315879898972160?logs=functional_tests#L2675:
```
test 2023-03-23T17:23:41.645000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\test_framework.py", line 132, in main
self.run_test()
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\wallet_create_tx.py", line 35, in run_test
self.test_create_too_long_mempool_chain()
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\wallet_create_tx.py", line 98, in test_create_too_long_mempool_chain
tx_data = test_wallet.send(outputs=[{test_wallet.getnewaddress(): 25 - i}], options=options)
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\coverage.py", line 49, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\authproxy.py", line 149, in __call__
raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Not solvable pre-selected input COutPoint(e425cbbd63, 1) (-4)
```
(log also includes a `feature_config_args` failure not related to this issue)
### Expected behaviour
Test should pass. This seems like a race condition as there is an `AddToWallet` log line immediately below the exception.
### Steps to reproduce
Happened in CI on commit 53d99551e913bfb85769a2b34fed73898779ff0f, but probably does not happen reliably.
### Relevant log output
https://cirrus-ci.com/task/5315879898972160?logs=functional_tests#L2675
### How did you obtain Bitcoin Core
Other
### What version of Bitcoin Core are you using?
master@ a70911492fcd1f726782cca2f1ffac18c25e8fb4
### Operating system and version
Windows
### Machine specifications
_No response_ | https://github.com/bitcoin/bitcoin/issues/27316 | https://github.com/bitcoin/bitcoin/pull/27318 | 220008604f15d5078092dea28be3e3f7f11b6c8f | 68828288e5d35c17848ab3da8cd231d1b69651c0 | 2023-03-23T18:21:41Z | c++ | 2023-03-28T14:41:15Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,299 | ["depends/packages/fontconfig.mk"] | depends does not compile with clang-16 (fontconfig) | Steps to reproduce on a fresh install of Ubuntu Lunar:
`export DEBIAN_FRONTEND=noninteractive && apt update && apt install curl wget htop git vim ccache -y && git clone https://github.com/bitcoin/bitcoin.git --depth=1 ./bitcoin-core && cd bitcoin-core && apt install libc++abi-16-dev libc++-16-dev clang-16 llvm-16 build-essential libtool autotools-dev automake pkg-config bsdmainutils python3-zmq make automake cmake curl g++-multilib libtool binutils bsdmainutils pkg-config python3 patch bison -y`
Then:
```
( cd depends && make CC=clang-16 CXX="clang++-16" fontconfig )
```
Output:
```
Making all in fc-list
make[3]: Entering directory '/bitcoin-core/depends/work/build/x86_64-pc-linux-gnu/fontconfig/2.12.6-a8f2b26f216/fc-list'
CC fc-list.o
fc-list.c:119:27: error: call to undeclared function 'strdup'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
format = (FcChar8 *) strdup (optarg);
^
fc-list.c:119:27: note: did you mean 'strcmp'?
/usr/include/string.h:156:12: note: 'strcmp' declared here
extern int strcmp (const char *__s1, const char *__s2)
^
fc-list.c:119:15: warning: cast to 'FcChar8 *' (aka 'unsigned char *') from smaller integer type 'int' [-Wint-to-pointer-cast]
format = (FcChar8 *) strdup (optarg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
make[3]: *** [Makefile:510: fc-list.o] Error 1
make[3]: Leaving directory '/bitcoin-core/depends/work/build/x86_64-pc-linux-gnu/fontconfig/2.12.6-a8f2b26f216/fc-list'
make[2]: *** [Makefile:581: all-recursive] Error 1
make[2]: Leaving directory '/bitcoin-core/depends/work/build/x86_64-pc-linux-gnu/fontconfig/2.12.6-a8f2b26f216'
make[1]: *** [Makefile:465: all] Error 2
make[1]: Leaving directory '/bitcoin-core/depends/work/build/x86_64-pc-linux-gnu/fontconfig/2.12.6-a8f2b26f216'
make: *** [funcs.mk:291: /bitcoin-core/depends/work/build/x86_64-pc-linux-gnu/fontconfig/2.12.6-a8f2b26f216/./.stamp_built] Error 2
| https://github.com/bitcoin/bitcoin/issues/27299 | https://github.com/bitcoin/bitcoin/pull/27301 | ff26406b2bb114d877b6d5bb10cec15ba91775ec | b759cefe936ed3991633acff215ea1dcec5ece28 | 2023-03-22T12:26:19Z | c++ | 2023-03-27T16:49:45Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,147 | ["src/script/miniscript.h", "src/test/fuzz/miniscript.cpp"] | miniscript_stable fuzz timeout | https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=56270 | https://github.com/bitcoin/bitcoin/issues/27147 | https://github.com/bitcoin/bitcoin/pull/27165 | 4398cfb22b9c491125d65ac35c0c1c73d5d9dd11 | cb40639bdf04bab31bcdceb3bf941e9bade8317a | 2023-02-23T13:00:40Z | c++ | 2023-02-28T17:04:47Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,140 | ["test/functional/feature_anchors.py", "test/functional/p2p_addrv2_relay.py", "test/functional/test_framework/messages.py", "test/functional/test_framework/socks5.py", "test/functional/test_runner.py"] | Add support for all networks in `deserialize_v2` in test_framework | `deserialize_v2` function (`test_framework`) should be able to deseriablize all networks presented in BIP155 (e.g. onion, ipv6, etc), however, it only works for ipv4 and i2p. I noticed that when I was using `message-capture-parser` and realized that most `addrv2` messages weren't able to be deserialized. | https://github.com/bitcoin/bitcoin/issues/27140 | https://github.com/bitcoin/bitcoin/pull/27452 | 2dea6c5ca01861fb027ee9a852d6a95736e7b0d2 | 2fa60f0b683cefd7956273986dafe3bde00c98fd | 2023-02-21T20:06:55Z | c++ | 2023-08-02T11:57:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,129 | ["test/functional/interface_usdt_mempool.py", "test/functional/mempool_compatibility.py", "test/functional/mempool_package_limits.py", "test/functional/mempool_persist.py", "test/functional/test_framework/wallet.py"] | failure in feature_bip68_sequence.py | https://cirrus-ci.com/task/5552802257174528?logs=ci#L3998
```bash
node0 2023-02-16T16:55:28.505405Z [httpworker.3] [rpc/request.cpp:179] [parse] [rpc] ThreadRPCServer method=sendrawtransaction user=__cookie__
node0 2023-02-16T16:55:28.506156Z [httpworker.3] [txmempool.cpp:644] [check] [mempool] Checking mempool with 58 transactions and 123 inputs
test 2023-02-16T16:55:28.513000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 134, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_bip68_sequence.py", line 73, in run_test
self.test_sequence_lock_unconfirmed_inputs()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_bip68_sequence.py", line 225, in test_sequence_lock_unconfirmed_inputs
tx1 = self.wallet.send_self_transfer(from_node=self.nodes[0])["tx"]
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/wallet.py", line 249, in send_self_transfer
self.sendrawtransaction(from_node=from_node, tx_hex=tx['hex'])
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/wallet.py", line 356, in sendrawtransaction
txid = from_node.sendrawtransaction(hexstring=tx_hex, maxfeerate=maxfeerate, **kwargs)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/coverage.py", line 49, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/authproxy.py", line 146, in __call__
raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: bad-txns-premature-spend-of-coinbase, tried to spend coinbase at depth 7 (-26)
test 2023-02-16T16:55:28.514000Z TestFramework (DEBUG): Closing down network thread
test 2023-02-16T16:55:28.564000Z TestFramework (INFO): Stopping nodes
test 2023-02-16T16:55:28.564000Z TestFramework.node0 (DEBUG): Stopping node
``` | https://github.com/bitcoin/bitcoin/issues/27129 | https://github.com/bitcoin/bitcoin/pull/27177 | 5ef2c1ee7a7416907e0f9135dc0701a88d92a7f6 | 3132ec64d9e0f7af88e61ac35807f44315a5ca96 | 2023-02-20T16:32:21Z | c++ | 2023-05-23T19:48:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,111 | ["src/rpc/rawtransaction.cpp", "test/functional/rpc_decodescript.py"] | decodescript miniscript functionality tops out at 520 bytes | After https://github.com/bitcoin/bitcoin/pull/27037 miniscript is extracted from compatible scripts, unless the `FillableSigningProvider::AddCScript` check for `MAX_SCRIPT_ELEMENT_SIZE` fails, which then it falls back to legacy behavior.
@achow101 | https://github.com/bitcoin/bitcoin/issues/27111 | https://github.com/bitcoin/bitcoin/pull/27113 | 0561f344e0ecce2a9a1492c188c5813e075c67c0 | e996219f9a3766f57febad7c00e43775911bf046 | 2023-02-16T15:26:02Z | c++ | 2023-02-20T16:41:46Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,067 | ["doc/release-notes-27068.md", "src/qt/askpassphrasedialog.cpp", "src/support/allocators/secure.h", "src/wallet/rpc/encrypt.cpp", "src/wallet/rpc/wallet.cpp", "test/functional/wallet_encryption.py"] | Wallet passphrases silently ignore everything after a null character | ## Problem
Encrypting a wallet through JSON RPC or Qt *appears to* allow a user to include null characters in the passphrase, but silently ignores everything including and after the first null character.
For instance (on regtest), trying to set a passphrase of "`a{null character}b`":
`curl --user __cookie__ --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "encryptwallet", "params": ["a\u0000b"]}' -H 'content-type: text/plain;' http://127.0.0.1:18443/`
This will succeed, but allow the user to unlock with the passphrase "`a`", instead of the expected full passphrase (which also works):
`curl --user __cookie__ --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "walletpassphrase", "params": ["a",10]}' -H 'content-type: text/plain;' http://127.0.0.1:18443/`
I am also able to replicate it in Qt on my macOS machine by running `printf 'a\0b' | pbcopy` and pasting the result into the passphrase dialog.
My main concern is a user thinking that they're generating, say, 32 random bytes as a passphrase, and if they're unlucky and get a zero in the first few bytes, it unexpectedly cuts their security down to almost nothing.
## Root Cause
The reason is due to our `SecureString` type. `SecureString` is a `std::string` specialization with a secure allocator. However, when assigned, it's treated like a C- string (no explicit length and null-terminated). See the [original PR](https://github.com/bitcoin/bitcoin/pull/666) for more details.
## Potential Solutions
I think there are two plausible approaches to take. The first (and my preference) is to allow and support null characters, and I will submit a PR that enables that (by making `SecureString` use the entire string). The second is to explicitly reject any passphrases that contain null characters.
One significant complication may be that, if anyone is *already* using a passphrase with a null, then my first solution would stop their wallet from unlocking. However, it would still be unlockable just by trimming the null and any subsequent characters. | https://github.com/bitcoin/bitcoin/issues/27067 | https://github.com/bitcoin/bitcoin/pull/27068 | 174f022f68ce4b25a8a33e15c2cab18e83f15891 | 5e555345865811d4a9688a0681fa4f3109ac5020 | 2023-02-09T18:44:23Z | c++ | 2023-02-22T18:02:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,065 | ["test/functional/wallet_pruning.py"] | Intermittent issue in wallet_pruning.py | ```
wget https://drahtbot.space/temp_scratch/wallet_pruning_258.tar.xz
tar -xvf ./wallet_pruning_258.tar.xz
test/functional/combine_logs.py -c ./wallet_pruning_258
```
```
test 2023-02-08T07:00:29.787000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/root/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 134, in main
self.run_test()
File "/root/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/wallet_pruning.py", line 127, in run_test
self.mine_large_blocks(self.nodes[0], 50)
File "/root/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/wallet_pruning.py", line 63, in mine_large_blocks
self.sync_all()
File "/root/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 728, in sync_all
self.sync_blocks(nodes)
File "/root/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 697, in sync_blocks
assert (all([len(x.getpeerinfo()) for x in rpc_connections]))
AssertionError
| https://github.com/bitcoin/bitcoin/issues/27065 | https://github.com/bitcoin/bitcoin/pull/27066 | 1313b9073574be0c7d859ebd6bab2bd09192fe6d | ffdf6307905b324428b3fd5ab51b08208dbb72c5 | 2023-02-09T09:59:45Z | c++ | 2023-02-10T08:35:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,051 | ["src/wallet/spend.cpp", "test/functional/test_runner.py", "test/functional/wallet_change_address.py", "test/functional/wallet_importdescriptors.py"] | every other change address is unused | I'm seeing 50% of generated change addresses not being used. It's as if two are reserved for every one that is used.
This is happening in version v24.0.1.
Here's a sequence of commands that shows what I mean. Only the odd numbered change hdkeypaths are used:
```
$ /bin/rm -fr ~/.bitcoin/regtest
$ bitcoin-qt -regtest &
$ bitcoin-cli -regtest createwallet 1 > /dev/null
$ bitcoin-cli -regtest createwallet 2 > /dev/null
$ bitcoin-cli -regtest -rpcwallet=1 -generate 1 > /dev/null
$ bitcoin-cli -regtest -rpcwallet=2 -generate 100 > /dev/null
$ to=$(bitcoin-cli -regtest -rpcwallet=2 getnewaddress)
$ txs=$(for i in {1..5}; do bitcoin-cli -regtest -rpcwallet=1 sendtoaddress $to 1; done)
$ addrs=$(for i in $txs; do bitcoin-cli -regtest getrawtransaction $i true | jq -Mc '.vout[]|{value:.value,addr:.scriptPubKey.address}'; done | grep -v ':1,' | jq -r .addr)
$ for a in $addrs; do bitcoin-cli -regtest -rpcwallet=1 getaddressinfo $a | jq -r .hdkeypath; done
m/84'/1'/0'/1/1
m/84'/1'/0'/1/3
m/84'/1'/0'/1/5
m/84'/1'/0'/1/7
m/84'/1'/0'/1/9
```
This happens whether or not I create descriptor wallets. For example, with a descriptor wallet I get these descriptors for the change addresses:
```
wpkh([779aecf0/84'/1'/0'/1/1]029919052bd5b904afbf71d90afbec0a852d1f0181914b6d07bcab028a0d1ac3e4)#94rhf9lu
wpkh([779aecf0/84'/1'/0'/1/3]0360ecbba4ebaac3ab4f62f14b12a136c2cc5e8264ac1be2af1b5e4413944a2c6a)#lwjzrh62
wpkh([779aecf0/84'/1'/0'/1/5]03d3f72c2cc6085bdee5388ff3b96df7d27ac18d85b5cc8d8048e287b52777062e)#5q4fsvmd
wpkh([779aecf0/84'/1'/0'/1/7]02b77a29387f645bb5ed27ef25144ae67a984e056e41b35fce33bb377d199845ab)#mc608kvz
wpkh([779aecf0/84'/1'/0'/1/9]024988fafba17c2d6f5b2b27428e2fb65ca8a7882ac0fae1422e4fdf46c95dbc61)#mwxzye2v
```
and for a legacy wallet I get these:
```
wpkh([bcc40f8d/0'/1'/1']03d3cc823cd01dcb23dce0ac53f8b38c3cb8b9ddbdfc789550c280d25cba432932)#3vxlglf6
wpkh([bcc40f8d/0'/1'/3']03016e2243892459754e125954d205136247f67580e9379ca931f2ec374b924aef)#kxwx63p3
wpkh([bcc40f8d/0'/1'/5']0236dd8b3a6ebd26a4e1e9dc1d84bf053438c339babacd202000f44917bd452336)#jaq2hgn4
wpkh([bcc40f8d/0'/1'/7']03785884e52fad4588d2d0e1df48b8ba691dddfb3696667932a3b46cb0202132fa)#0d786n6s
wpkh([bcc40f8d/0'/1'/9']03ba88cdc9a37aa676a1152c6d7d970aa32324b99d8c6f775c4543e016161ea4d9)#vdvr44ar
``` | https://github.com/bitcoin/bitcoin/issues/27051 | https://github.com/bitcoin/bitcoin/pull/27053 | 0f670e0eae43de2766866563fc54f188d18d004c | 94070029fb6b783833973f9fe08a3a871994492f | 2023-02-06T16:50:06Z | c++ | 2023-02-20T17:20:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,048 | ["src/wallet/rpc/wallet.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h", "test/functional/wallet_migration.py"] | migratewallet help is misleading about encrypted wallets | The help tells me I should unlock my encrypted wallet:
```
> help migratewallet
...
Requires wallet passphrase to be set with walletpassphrase call if wallet is encrypted.
```
But when I do so and attempt to migrate the wallet I'm told that I've entered my password for needlessly:
```
> migratewallet
Error: migratewallet on encrypted wallets is currently unsupported.
```
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
v24.0.1
| https://github.com/bitcoin/bitcoin/issues/27048 | https://github.com/bitcoin/bitcoin/pull/26595 | 8b4dc94734a2472a201296376bfb18f982e6d92f | 63893d5eabb6d5b99aa12456af6e7bcf5dc20ffb | 2023-02-06T01:57:32Z | c++ | 2023-02-22T17:48:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,031 | [".cirrus.yml"] | macos depends build does not cache in the CI | At least in the CI, the depends build does not cache. E.g. https://cirrus-ci.com/task/5094611354386432?logs=ci#L789
This causes the build to take an hour when it should be done in less than 10 minutes witch a ccache. | https://github.com/bitcoin/bitcoin/issues/27031 | https://github.com/bitcoin/bitcoin/pull/27062 | dc905f6c2a60961aee73578fd3092bf90b28409f | af2bd07587b62b719b596b35e6fd54c60f747bd4 | 2023-02-03T09:40:17Z | c++ | 2023-02-09T18:05:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,014 | ["src/test/dbwrapper_tests.cpp", "test/lint/lint-locale-dependence.py"] | test: format-truncation warning in dbwrapper_tests | Compiling master at e1bf5470f919cf212703466411968916db8ae61f on Ubuntu 22.10 (with depends):
```cpp
CXX test/test_bitcoin-dbwrapper_tests.o
test/dbwrapper_tests.cpp: In member function ‘void dbwrapper_tests::iterator_string_ordering::test_method()’:
test/dbwrapper_tests.cpp:365:41: error: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size 10 [-Werror=format-truncation=]
365 | snprintf(buf, sizeof(buf), "%d", x);
| ^~
test/dbwrapper_tests.cpp:365:40: note: directive argument in the range [-2147483648, 9]
365 | snprintf(buf, sizeof(buf), "%d", x);
| ^~~~
In file included from /usr/include/stdio.h:906,
from /usr/include/c++/12/cstdio:42,
from /usr/include/c++/12/ext/string_conversions.h:43,
from /usr/include/c++/12/bits/basic_string.h:3960,
from /usr/include/c++/12/string:53,
from ./clientversion.h:30,
from ./dbwrapper.h:8,
from test/dbwrapper_tests.cpp:5:
In function ‘int snprintf(char*, size_t, const char*, ...)’,
inlined from ‘void dbwrapper_tests::iterator_string_ordering::test_method()’ at test/dbwrapper_tests.cpp:365:21:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:54:35: note: ‘__builtin___snprintf_chk’ output between 2 and 12 bytes into a destination of size 10
54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
55 | __glibc_objsize (__s), __fmt,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
56 | __va_arg_pack ());
| ~~~~~~~~~~~~~~~~~
```
(I ran with `--enable-werror`, otherwise it's merely a warning)
cc @achow101 | https://github.com/bitcoin/bitcoin/issues/27014 | https://github.com/bitcoin/bitcoin/pull/27036 | d8f982603722590f6be7578591390bcc8a459c18 | aff75463e2c75a7a969cdaa535c7be05fd146420 | 2023-02-01T13:57:12Z | c++ | 2023-02-06T09:32:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 27,007 | ["doc/release-notes-27037.md", "src/core_io.h", "src/core_write.cpp", "src/rpc/rawtransaction.cpp", "test/functional/data/rpc_decodescript.json", "test/functional/rpc_decodescript.py"] | decodescript could infer miniscript from given script in "segwit" context | I was playing around with a probably-too-cute script for LN channel smart contract, and was looking for something to decide for me if miniscript can infer the structure of the script.
f.e.
```
decodescript 82012088a914ffffffffffffffffffffffffffffffffffffffff8820ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffad51b2
{
"asm": "OP_SIZE 32 OP_EQUALVERIFY OP_HASH160 ffffffffffffffffffffffffffffffffffffffff OP_EQUALVERIFY ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff OP_CHECKSIGVERIFY 1 OP_CHECKSEQUENCEVERIFY",
"desc": "raw(82012088a914ffffffffffffffffffffffffffffffffffffffff8820ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffad51b2)#5guaahuv",
"type": "nonstandard",
"p2sh": "33YyjgxsJYwSi8Wbp7TaCSFAuJBoUfYWDQ",
"segwit": {
"asm": "0 99f5d0b69f9828fea9363198cf812e95d7fc5e94c7881092b8e3f43984c1bd5c",
"desc": "addr(bc1qn86apd5lnq50a2fkxxvvlqfwjhtlch55c7yppy4cu06rnpxph4wqrar3md)#wtlf0gwk",
"hex": "002099f5d0b69f9828fea9363198cf812e95d7fc5e94c7881092b8e3f43984c1bd5c",
"address": "bc1qn86apd5lnq50a2fkxxvvlqfwjhtlch55c7yppy4cu06rnpxph4wqrar3md",
"type": "witness_v0_scripthash",
"p2sh-segwit": "3MRJN2wTnD2BVm31HLcBwueAYpbbximrtk"
}
}
```
Since it's evaluated at "top level for `desc` it cannot get any meaningful structure from it. Perhaps in `segwit` it could try infering the miniscript in the segwit context
| https://github.com/bitcoin/bitcoin/issues/27007 | https://github.com/bitcoin/bitcoin/pull/27037 | 2ccd7be26f0e10b034e4b13703af24ec3d217a79 | e2ae5c349cd9c0e1db090ca3df3160f26d5c105d | 2023-01-31T16:55:04Z | c++ | 2023-02-03T20:34:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,962 | ["test/functional/mining_getblocktemplate_longpoll.py"] | Intermittent failure in mining_getblocktemplate_longpoll.py | Seen on master, https://cirrus-ci.com/task/6706434163867648?logs=ci#L5577
```
2023-01-24T20:06:14.173000Z TestFramework (INFO): Test that introducing a new transaction into the mempool will terminate the longpoll
2023-01-24T20:07:34.182000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 134, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/mining_getblocktemplate_longpoll.py", line 74, in run_test
assert not thr.is_alive()
AssertionError
2023-01-24T20:07:
```
| https://github.com/bitcoin/bitcoin/issues/26962 | https://github.com/bitcoin/bitcoin/pull/27941 | 0a55bcd2996d878a831e5ae36b7e6a869b0dda2b | 6d473bad2260fd23c6013581e44c9970b557f495 | 2023-01-24T20:55:25Z | c++ | 2023-08-17T12:30:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,937 | ["test/functional/feature_rbf.py"] | test: failure in feature_rbf.py | https://cirrus-ci.com/task/5092814950760448?logs=ci#L2927
```bash
node1 2023-01-20T15:49:57.843992Z [msghand] [net_processing.cpp:4043] [ProcessMessage] [mempool] AcceptToMemoryPool: peer=0: accepted f8ceb5e798ed4540cacc55783ac9de2d29ec0dbc5af2894eb04a2720796969e7 (poolsz 3 txn, 46 kB)
test 2023-01-20T15:49:57.844000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 134, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_rbf.py", line 68, in run_test
self.test_too_many_replacements_with_default_mempool_params()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_rbf.py", line 396, in test_too_many_replacements_with_default_mempool_params
wallet = MiniWallet(normal_node)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/wallet.py", line 109, in __init__
self.rescan_utxos()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/wallet.py", line 147, in rescan_utxos
self.scan_tx(self._test_node.getrawtransaction(txid=txid, verbose=True))
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/coverage.py", line 49, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/authproxy.py", line 146, in __call__
raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: No such mempool transaction. Use -txindex or provide a block hash to enable blockchain transaction queries. Use gettransaction for wallet transactions. (-5)
test 2023-01-20T15:49:57.845000Z TestFramework (DEBUG): Closing down network thread
``` | https://github.com/bitcoin/bitcoin/issues/26937 | https://github.com/bitcoin/bitcoin/pull/26941 | c0b6c40bb084752f686ff77e6883ee6fd16eba26 | bf9361d3757656c75775e5b243b4d11980117d04 | 2023-01-20T16:38:37Z | c++ | 2023-01-22T14:17:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,916 | ["src/util/trace.h"] | tracepoints: gnu-zero-variadic-macro-arguments warnings | These occur for all tracepoints when using Clang 15 and a system installed `systemtap`:
```bash
# clang --version
Debian clang version 15.0.7
./autogen.sh
./configure CC=clang-15 CXX=clang++-15
make
...
net_processing.cpp:4892:5: warning: must specify at least one argument for '...' parameter of variadic macro [-Wgnu-zero-variadic-macro-arguments]
TRACE6(net, inbound_message,
^
./util/trace.h:18:50: note: expanded from macro 'TRACE6'
#define TRACE6(context, event, a, b, c, d, e, f) DTRACE_PROBE6(context, event, a, b, c, d, e, f)
^
/usr/include/aarch64-linux-gnu/sys/sdt.h:494:3: note: expanded from macro 'DTRACE_PROBE6'
STAP_PROBE6(provider,probe,parm1,parm2,parm3,parm4,parm5,parm6)
^
/usr/include/aarch64-linux-gnu/sys/sdt.h:380:3: note: expanded from macro 'STAP_PROBE6'
_SDT_PROBE(provider, name, 6, (arg1, arg2, arg3, arg4, arg5, arg6))
^
/usr/include/aarch64-linux-gnu/sys/sdt.h:78:75: note: expanded from macro '_SDT_PROBE'
__asm__ __volatile__ (_SDT_ASM_BODY(provider, name, _SDT_ASM_ARGS, (n)) \
^
/usr/include/aarch64-linux-gnu/sys/sdt.h:283:9: note: macro '_SDT_ASM_BODY' defined here
#define _SDT_ASM_BODY(provider, name, pack_args, args, ...) \
^
1 warning generated.
``` | https://github.com/bitcoin/bitcoin/issues/26916 | https://github.com/bitcoin/bitcoin/pull/27401 | be443328037162f265cc85d05b1a7665b5f104d2 | 97ba72117cb717bd7bed53133ad623d4e991b220 | 2023-01-19T09:35:17Z | c++ | 2023-08-07T14:03:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,819 | ["test/functional/test_framework/test_framework.py", "test/functional/wallet_descriptor.py"] | test: sqlite tests on freebsd fail with ModuleNotFoundError: No module named '_sqlite3' | It would be good if the test was skipped instead, or if the documentation explained how to install py-sqlite.
```
126/256 - wallet_descriptor.py --descriptors failed, Duration: 0 s
stdout:
stderr:
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/wallet_descriptor.py", line 7, in <module>
import sqlite3
File "/usr/local/lib/python3.9/sqlite3/__init__.py", line 57, in <module>
from sqlite3.dbapi2 import *
File "/usr/local/lib/python3.9/sqlite3/dbapi2.py", line 27, in <module>
from _sqlite3 import *
ModuleNotFoundError: No module named '_sqlite3'
| https://github.com/bitcoin/bitcoin/issues/26819 | https://github.com/bitcoin/bitcoin/pull/26882 | 07c54de550035c3441f34ef6c34209666267eb38 | 32834034a3a6bfe2687feb86145d46e610c6ca9d | 2023-01-05T17:36:52Z | c++ | 2023-01-13T12:52:08Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,808 | ["test/functional/p2p_disconnect_ban.py"] | p2p_disconnect_ban intermittent issue | https://cirrus-ci.com/task/5426348117196800?logs=ci#L4502
```
test 2022-12-17T13:12:20.699000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
self.wait_until(lambda: sum(peer['version'] != 0 for peer in to_connection.getpeerinfo()) == to_num_peers)
'''
test 2022-12-17T13:12:20.699000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 134, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/p2p_disconnect_ban.py", line 112, in run_test
self.connect_nodes(0, 1) # reconnect the node
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 608, in connect_nodes
self.wait_until(lambda: sum(peer['version'] != 0 for peer in to_connection.getpeerinfo()) == to_num_peers)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 732, in wait_until
return wait_until_helper(test_function, timeout=timeout, timeout_factor=self.options.timeout_factor)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 281, in wait_until_helper
raise AssertionError("Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
self.wait_until(lambda: sum(peer['version'] != 0 for peer in to_connection.getpeerinfo()) == to_num_peers)
''' not true after 2400.0 seconds | https://github.com/bitcoin/bitcoin/issues/26808 | https://github.com/bitcoin/bitcoin/pull/27128 | 446c8f581cf3d4eff257f0eb6e43f5248fc4b259 | 150cc8ef4289bebc88799f2cbb2860a1aa539c19 | 2023-01-04T11:35:40Z | c++ | 2023-02-20T16:28:02Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,797 | ["src/wallet/wallet.cpp"] | Bitcoin Core startup is interrupted if there is the setting mintxfee=0 in bitcoin.conf | **Expected behavior**
It is expected that Bitcoin Core is not shutdown automatically during startup. Moreover, it should be possible to set transaction fee at 0.
**Actual behavior**
**To reproduce**
1) Click bitcoin-qt.exe.
**System information**
1) A wallet that contained unspent funds was opened previously.
2) The bitcoin.conf file contains "mintxfee=0".
3) Bitcoin Core 24.0.1 official binary for Windows (portable). | https://github.com/bitcoin/bitcoin/issues/26797 | https://github.com/bitcoin/bitcoin/pull/26955 | 837e9ed611fb9be4017e674b58fc4618d51df080 | f1b5d6be57e19799d5400215180af8cc5441e210 | 2023-01-02T20:24:44Z | c++ | 2023-01-24T11:49:28Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,796 | ["src/random.cpp"] | Request support for HRNG on ARM using their new RNDR / RNDRRS instructions. | Bitcoin Core currently only support to using RDRAND / RDSEED instruction on x86 architecture when requiring to generate a ultra high quality random numbers. For example, a private key.
https://github.com/bitcoin/bitcoin/blob/master/src/random.h
https://github.com/bitcoin/bitcoin/blob/master/src/random.cpp
ARM later added two new similar instructions as well, RNDR (similar to RDRAND) / RNDRRS (similar to RDSEED).
https://developer.arm.com/documentation/ddi0601/2022-12/AArch64-Registers/RNDR--Random-Number
https://developer.arm.com/documentation/ddi0601/2022-12/AArch64-Registers/RNDRRS--Reseeded-Random-Number
OpenSSL also had a similar feature request on last year. (Implemented)
https://github.com/openssl/openssl/issues/15627
https://github.com/openssl/openssl/pull/15361
https://github.com/openssl/openssl/blob/master/providers/implementations/rands/seeding/rand_cpu_arm64.c
I hope this feature is also available on Bitcoin Core as Bitcoin Core also can using on ARM machine (E.g. A Mac computer using Apple silicon, Raspberry Pi...). | https://github.com/bitcoin/bitcoin/issues/26796 | https://github.com/bitcoin/bitcoin/pull/26839 | e77339632efb8faf47deae7dc4fbd82bdc130614 | c8a883a4123ab466f9d911ee2865625ba5314c9e | 2023-01-02T19:46:56Z | c++ | 2023-11-07T20:00:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,774 | ["contrib/install_db4.sh"] | contrib/install_db4.sh script fails on FreeBSD | Running `contrib/install_db4.sh` to download and build libdb4 for legacy wallet support fails on FreeBSD.
```
$ ./contrib/install_db4.sh `pwd`
[...]
sha256sum: option requires an argument -- c
usage: sha256sum [-pqrtx] [-c file] [-s string] [files ...]
$
```
This is on FreeBSD 13.1
Fixed by: #26772
| https://github.com/bitcoin/bitcoin/issues/26774 | https://github.com/bitcoin/bitcoin/pull/26772 | 53653060c1470d1a64295e1add0d0edf1938662f | 4717a5aa31bc9cdb5406f4161f4c600e5c2659c0 | 2022-12-30T08:17:28Z | c++ | 2023-01-04T10:24:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,719 | ["test/lint/spelling.ignore-words.txt"] | Codespell errors in `src/wallet/test/walletload_tests.cpp` | On current master (cb32328d1b80d0ccd6eb9532bd8fe4e0a4de385e).
```
$ ./test/lint/all-lint.py
Skipping Python linting since flake8 is not installed.
src/wallet/test/walletload_tests.cpp:107: crypted ==> encrypted
src/wallet/test/walletload_tests.cpp:108: crypted ==> encrypted
src/wallet/test/walletload_tests.cpp:127: crypted ==> encrypted
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.ignore-words.txt
``` | https://github.com/bitcoin/bitcoin/issues/26719 | https://github.com/bitcoin/bitcoin/pull/26721 | 8ab19237e11ee510a7941a4ab429471b29cccd69 | dcdfd72861c09a7945b9facc3726177a2d06fa64 | 2022-12-17T22:37:23Z | c++ | 2022-12-20T11:46:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,687 | ["src/bench/wallet_create_tx.cpp", "src/qt/sendcoinsdialog.cpp", "src/qt/sendcoinsdialog.h", "src/qt/test/wallettests.cpp", "src/qt/walletmodel.cpp", "src/wallet/interfaces.cpp", "src/wallet/spend.cpp", "src/wallet/spend.h", "src/wallet/test/wallet_tests.cpp"] | Unable to create PSBT for legacy watchonly wallets in the GUI | A user reported to me that they are unable to create a PSBT with a legacy watchonly wallet when they use the GUI. They get an error "The amount exceeds your balance".
I think the issue is that the GUI will retrieve the wallet's balance via `AvailableCoins` before calling `CreateTransaction`. This call to `AvailableCoins` is resulting in fewer coins being returned with recent changes to how `AvailableCoins` works, particularly with additional filtering of spendable coins and preset coins.
***
Note that this does not effect descriptor wallets. A workaround for this issue is to switch to using descriptor wallets. An existing legacy wallet can be turned into a descriptor wallet using the `migratewallet` RPC. However many watchonly legacy wallets are likely the result of importing descriptors via `importmulti`. For such wallets, I recommend creating a new descriptor wallet and re-importing the descriptors. | https://github.com/bitcoin/bitcoin/issues/26687 | https://github.com/bitcoin/bitcoin/pull/26699 | c17d4d3b6b5b28a404cf43ce351d5a482d56cc65 | 27dcc07c08a77eba53ccc91e5521ff674f1bd198 | 2022-12-12T15:33:38Z | c++ | 2023-04-11T18:05:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,667 | ["src/wallet/wallet.cpp", "test/functional/wallet_bumpfee.py"] | Can't bump fee after abandoning child transaction | Steps:
1. Send transaction (A) to a different wallet
2. Using the change, create another transaction (B) to a different wallet
3. `abandontransaction` B
4. `bumpfee` A fails with `Transaction has descendants in the wallet` | https://github.com/bitcoin/bitcoin/issues/26667 | https://github.com/bitcoin/bitcoin/pull/26675 | 2f6a8e5e02465e9de5c9f6202d5e3f8aa19bf70b | fbe5e1220a35c35a668ec965c66508a7839aa7dd | 2022-12-08T19:48:37Z | c++ | 2023-01-11T23:24:53Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,655 | ["src/wallet/wallet.cpp"] | Pruned node unable to start when a wallet is present | This is the weirdest bug I have seen in a while, as I can't reproduce, but it happens persistently on a server of one of our users.
I tried to delete wallet and recreate it, it doesn't work, still stuck.
I tried to remove the wallet and not recreate it, and bitcoin core starts properly.
I uploaded a wallet generated there: https://aois.blob.core.windows.net/public/wallet.tar.gz
I tried to load the wallet on my local node (non-pruned), it works and there is no rescan.
```
2022-12-08T00:11:47Z No coin database inconsistencies in last 6 blocks (503 transactions)
2022-12-08T00:11:47Z block index 10522ms
2022-12-08T00:11:47Z init message: Loading wallet…
2022-12-08T00:11:47Z BerkeleyEnvironment::Open: LogDir=C:\Users\NicolasDorier\tmp\database ErrorFile=C:\Users\NicolasDorier\tmp\db.log
2022-12-08T00:11:47Z [default wallet] Wallet File Version = 169900
2022-12-08T00:11:47Z [default wallet] Keys: 2001 plaintext, 0 encrypted, 2001 w/ metadata, 2001 total. Unknown wallet records: 0
2022-12-08T00:11:47Z [default wallet] Wallet completed loading in 60ms
2022-12-08T00:11:47Z [default wallet] setKeyPool.size() = 2000
2022-12-08T00:11:47Z [default wallet] mapWallet.size() = 0
2022-12-08T00:11:47Z [default wallet] m_address_book.size() = 0
2022-12-08T00:11:47Z Unsetting NODE_NETWORK on prune mode
20
```
On the server of the user the node is pruned, and there is a rescan with error
```
2022-12-08T00:01:33Z [default wallet] Wallet completed loading in 152ms
2022-12-08T00:01:33Z Error: Prune: last wallet synchronisation goes beyond pruned data. You need to -reindex (download the whole blockchain again in case of pruned node)
Error: Prune: last wallet synchronisation goes beyond pruned data. You need to -reindex (download the whole blockchain again in case of pruned node)
```
Even though the wallet just got created.
The pruneheight should also be big enough:
```bash
getblockchaininfo
```
```json
{
"chain": "test",
"blocks": 2410292,
"headers": 2410292,
"bestblockhash": "0000000000000022a51915a9d3473d6185744de708a1bf008a471e702dfc43fc",
"difficulty": 82946068.46057868,
"time": 1670458413,
"mediantime": 1670455720,
"verificationprogress": 0.9999988037011049,
"initialblockdownload": false,
"chainwork": "000000000000000000000000000000000000000000000839f6768de759ba571f",
"size_on_disk": 8702871138,
"pruned": true,
"pruneheight": 1441677,
"automatic_pruning": true,
"prune_target_size": 104857600000,
"warnings": "Unknown new rules activated (versionbit 28)"
}
```
Anything else I can provide you? I am really at loss about why this specific node is asking for a rescan.
**Expected behavior**
Node starts properly when a new wallet is just created.
**Actual behavior**
Node stuck
```
2022-12-08T00:00:24Z Bitcoin Core version v24.0.0 (release build)
2022-12-08T00:00:24Z Using the 'sse4(1way),sse41(4way)' SHA256 implementation
2022-12-08T00:00:24Z Default data directory /home/bitcoin/.bitcoin
2022-12-08T00:00:24Z Using data directory /home/bitcoin/.bitcoin/testnet3
2022-12-08T00:00:24Z Config file: /home/bitcoin/.bitcoin/bitcoin.conf
2022-12-08T00:00:24Z Config file arg: testnet="1"
2022-12-08T00:00:24Z Config file arg: [test] maxmempool="500"
2022-12-08T00:00:24Z Config file arg: [test] onion="tor:9050"
2022-12-08T00:00:24Z Config file arg: [test] port="39388"
2022-12-08T00:00:24Z Config file arg: [test] printtoconsole="1"
2022-12-08T00:00:24Z Config file arg: [test] prune="100000"
2022-12-08T00:00:24Z Config file arg: [test] rpcallowip="::/0"
2022-12-08T00:00:24Z Config file arg: [test] rpcallowip="0.0.0.0/0"
2022-12-08T00:00:24Z Config file arg: [test] rpcauth=****
2022-12-08T00:00:24Z Config file arg: [test] rpcauth=****
2022-12-08T00:00:24Z Config file arg: [test] rpcbind=****
2022-12-08T00:00:24Z Config file arg: [test] rpcport="43782"
2022-12-08T00:00:24Z Config file arg: [test] walletdir="/walletdata/testnet"
2022-12-08T00:00:24Z Config file arg: [test] whitelist="0.0.0.0/0"
2022-12-08T00:00:24Z Config file arg: [test] zmqpubhashblock="tcp://0.0.0.0:28334"
2022-12-08T00:00:24Z Config file arg: [test] zmqpubrawblock="tcp://0.0.0.0:28332"
2022-12-08T00:00:24Z Config file arg: [test] zmqpubrawtx="tcp://0.0.0.0:28333"
2022-12-08T00:00:24Z Using at most 125 automatic connections (1048576 file descriptors available)
2022-12-08T00:00:24Z Using 16 MiB out of 16 MiB requested for signature cache, able to store 524288 elements
2022-12-08T00:00:24Z Using 16 MiB out of 16 MiB requested for script execution cache, able to store 524288 elements
2022-12-08T00:00:24Z Script verification uses 1 additional threads
2022-12-08T00:00:24Z scheduler thread start
2022-12-08T00:00:24Z WARNING: the RPC server is not safe to expose to untrusted networks such as the public internet
2022-12-08T00:00:24Z [http] creating work queue of depth 16
2022-12-08T00:00:24Z Using random cookie authentication.
2022-12-08T00:00:24Z Generated RPC authentication cookie /home/bitcoin/.bitcoin/testnet3/.cookie
2022-12-08T00:00:24Z Using rpcauth authentication.
2022-12-08T00:00:24Z [http] starting 4 worker threads
2022-12-08T00:00:24Z Using wallet directory /walletdata/testnet
2022-12-08T00:00:24Z init message: Verifying wallet(s)…
2022-12-08T00:00:24Z Using BerkeleyDB version Berkeley DB 4.8.30: (April 9, 2010)
2022-12-08T00:00:24Z Using wallet /walletdata/testnet/wallet.dat
2022-12-08T00:00:24Z BerkeleyEnvironment::Open: LogDir=/walletdata/testnet/database ErrorFile=/walletdata/testnet/db.log
2022-12-08T00:00:24Z Using /16 prefix for IP bucketing
2022-12-08T00:00:24Z init message: Loading P2P addresses…
2022-12-08T00:00:25Z Loaded 22930 addresses from peers.dat 393ms
2022-12-08T00:00:25Z init message: Loading banlist…
2022-12-08T00:00:25Z SetNetworkActive: true
2022-12-08T00:00:25Z Cache configuration:
2022-12-08T00:00:25Z * Using 2.0 MiB for block index database
2022-12-08T00:00:25Z * Using 8.0 MiB for chain state database
2022-12-08T00:00:25Z * Using 440.0 MiB for in-memory UTXO set (plus up to 476.8 MiB of unused mempool space)
2022-12-08T00:00:25Z init message: Loading block index…
2022-12-08T00:00:25Z Assuming ancestors of block 0000000000000004877fa2d36316398528de4f347df2f8a96f76613a298ce060 have valid signatures.
2022-12-08T00:00:25Z Setting nMinimumChainWork=00000000000000000000000000000000000000000000076f6e7cbd0beade5d20
2022-12-08T00:00:25Z Prune configured to target 100000 MiB on disk for block and undo files.
2022-12-08T00:00:25Z Switching active chainstate to Chainstate [ibd] @ height -1 (null)
2022-12-08T00:00:25Z Opening LevelDB in /home/bitcoin/.bitcoin/testnet3/blocks/index
2022-12-08T00:00:25Z Opened LevelDB successfully
2022-12-08T00:00:25Z Using obfuscation key for /home/bitcoin/.bitcoin/testnet3/blocks/index: 0000000000000000
2022-12-08T00:01:15Z LoadBlockIndexDB: last block file = 211
2022-12-08T00:01:15Z LoadBlockIndexDB: last block file info: CBlockFileInfo(blocks=3150, size=89162763, heights=2407141...2410289, time=2022-11-19...2022-12-07)
2022-12-08T00:01:15Z Checking all blk files are present...
2022-12-08T00:01:16Z LoadBlockIndexDB(): Block files have previously been pruned
2022-12-08T00:01:30Z Opening LevelDB in /home/bitcoin/.bitcoin/testnet3/chainstate
2022-12-08T00:01:30Z Opened LevelDB successfully
2022-12-08T00:01:30Z Using obfuscation key for /home/bitcoin/.bitcoin/testnet3/chainstate: dd2d995e0b39a1e4
2022-12-08T00:01:32Z Loaded best chain: hashBestChain=000000000000002e323100923fd63334a2b4e3e087609da60e07bfcb41fc3e66 height=2410289 date=2022-12-07T23:46:07Z progress=0.999998
2022-12-08T00:01:32Z init message: Verifying blocks…
2022-12-08T00:01:32Z Verifying last 6 blocks at level 3
2022-12-08T00:01:32Z [0%]...[16%]...[33%]...[50%]...[66%]...[83%]...[99%]...[DONE].
2022-12-08T00:01:32Z No coin database inconsistencies in last 6 blocks (433 transactions)
2022-12-08T00:01:32Z block index 67622ms
2022-12-08T00:01:32Z init message: Loading wallet…
2022-12-08T00:01:32Z BerkeleyEnvironment::Open: LogDir=/walletdata/testnet/database ErrorFile=/walletdata/testnet/db.log
2022-12-08T00:01:32Z [default wallet] Wallet file version = 10500, last client version = 240000
2022-12-08T00:01:33Z [default wallet] Keys: 2001 plaintext, 0 encrypted, 2001 w/ metadata, 2001 total. Unknown wallet records: 0
2022-12-08T00:01:33Z [default wallet] Wallet completed loading in 152ms
2022-12-08T00:01:33Z Error: Prune: last wallet synchronisation goes beyond pruned data. You need to -reindex (download the whole blockchain again in case of pruned node)
Error: Prune: last wallet synchronisation goes beyond pruned data. You need to -reindex (download the whole blockchain again in case of pruned node)
2022-12-08T00:01:33Z Shutdown: In progress...
2022-12-08T00:01:33Z scheduler thread exit
2022-12-08T00:01:34Z Shutdown: done
```
**To reproduce**
I can only reproduce on a single instance, I tried to reproduce on my own server and didn't managed to.
```bash
bitcoin-wallet "-datadir=/walletdata/testnet" "-legacy" "-wallet=" create
```
Config
```ini
testnet=1
[test]
walletdir=/walletdata/testnet
printtoconsole=1
rpcallowip=::/0
rpcport=43782
rpcbind=0.0.0.0:43782
rpcallowip=0.0.0.0/0
port=39388
whitelist=0.0.0.0/0
maxmempool=500
prune=100000
zmqpubrawblock=tcp://0.0.0.0:28332
zmqpubrawtx=tcp://0.0.0.0:28333
zmqpubhashblock=tcp://0.0.0.0:28334
onion=tor:9050
```
**System information**
Bitcoin Core 24.0 amd64
Docker Hub `btcpayserver/bitcoin:24.0`.
| https://github.com/bitcoin/bitcoin/issues/26655 | https://github.com/bitcoin/bitcoin/pull/26679 | 68f88bc03f2d4c908a064394795a045b1ac67c37 | 4586ae2da1a4532dff459d6824b10bd329a5e824 | 2022-12-08T00:14:23Z | c++ | 2023-01-11T00:56:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,599 | ["src/addrdb.cpp", "src/addrman.cpp", "src/hash.h", "src/test/streams_tests.cpp"] | Do not crash if peers.dat is corrupted | When `peers.dat` is corrupted an error message is shown: `Invalid or corrupt peers.dat (Checksum mismatch, data corrupted).` then the node restart.
Most of our users aren't really tech enough to manually delete the `peers.dat` files, nor can we detect it for them. It means that this error give us lot's of work on our support team when somebody is impacted.
`peers.dat` isn't an essential file, as such Bitcoin Core should just be fine restarting without crashing.
A bash workaround to detect the checksum mismatch would also considerably help us. | https://github.com/bitcoin/bitcoin/issues/26599 | https://github.com/bitcoin/bitcoin/pull/26909 | 05e3468fb3c084840a93aed31c67f062ef30ef58 | b5c88a547996776dbdc2e101bae9b67ac639fd02 | 2022-11-29T12:34:08Z | c++ | 2023-01-19T15:03:08Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,579 | ["src/bitcoin-cli.cpp"] | bitcoin-cli -netinfo ignores inbound peer from local network | I have bitcoind serving cfilters to an LND node on my local network on separate machines. Both have `192.168.1.x` IP addresses and they connect fine using neutrino. However, the LND node does not appear in the `bitcoin-cli -netinfo` table.
The reason is because if you look at the `getpeerinfo` response:
```
{
"id": 11728,
"addr": "192.168.1.153:64367",
"addrbind": "192.168.1.13:8333",
"addrlocal": "192.168.1.13:8333",
"network": "not_publicly_routable",
"services": "0000000000000048",
"servicesnames": [
"WITNESS",
"COMPACT_FILTERS"
],
...
```
...so bitcoin-cli ignores the peer here:
https://github.com/bitcoin/bitcoin/blob/9c47eb450346937b3d7ee21b9e669b5c91a7ed6c/src/bitcoin-cli.cpp#L477-L479
...expecting one of these strings only:
https://github.com/bitcoin/bitcoin/blob/9c47eb450346937b3d7ee21b9e669b5c91a7ed6c/src/bitcoin-cli.cpp#L58
I'm happy to fix / add this myself unless there's a reason? Maybe instead of skipping the peer we can just add an "unknown network" category, or "other" ...?
cc: @jonatack | https://github.com/bitcoin/bitcoin/issues/26579 | https://github.com/bitcoin/bitcoin/pull/26584 | 576e16e7026fe1e2bed8907b38c7372e8353508d | 68e484afbbc2e43ad7f2140275cf4e09e45b80ae | 2022-11-26T01:32:40Z | c++ | 2023-02-15T08:18:57Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,552 | ["test/functional/rpc_net.py", "test/functional/test_framework/test_node.py"] | test: intermittent failure in rpc_net.py | See https://github.com/bitcoin/bitcoin/runs/9621443864 (master)
The problem here is is that calling `disconnect_p2ps` waits until `self.num_test_p2p_connections() == 0`.
`num_test_p2p_connections()` checks the field `subver` in `getpeerinfo` to distinguish p2p nodes from full nodes.
However, if we are dealing with a p2p connection that has never sent a version, the node has never received the special subversion and the wait is ineffective (we continue even though the disconnection is not yet completed). | https://github.com/bitcoin/bitcoin/issues/26552 | https://github.com/bitcoin/bitcoin/pull/26553 | 1b680948d43b1d39645b9d839a6fa7c6c1786b51 | 7eeae5c02334da6abb465f1f5df2ae79daef8acd | 2022-11-21T22:37:25Z | c++ | 2022-11-22T10:22:01Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,420 | ["depends/packages/zeromq.mk"] | Unable to cross compile Zeromq Dependency for arm64-apple-darwin | <!-- Describe the issue -->
Trying to compile starting with dependencies fails with
checking build system type... x86_64-pc-linux-gnu
checking host system type... Invalid configuration `arm64-apple-darwin': machine `arm64-apple' not recognized
configure: error: /bin/bash config/config.sub arm64-apple-darwin failed
**Expected behavior**
<!--- What behavior did you expect? -->
**Actual behavior**
checking for arm64-apple-darwin-pkg-config... no
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for xmlto... no
checking for asciidoc... no
checking build system type... x86_64-pc-linux-gnu
checking host system type... Invalid configuration `arm64-apple-darwin': machine `arm64-apple' not recognized
configure: error: /bin/bash config/config.sub arm64-apple-darwin failed
make: *** [funcs.mk:289: /home/bitcoin/Downloads/bitcoin-master/depends/work/build/arm64-apple-darwin/zeromq/4.3.4-0f6f30942e0/./.stamp_configured] Error 1
**To reproduce**
command : make HOST=arm64-apple-darwin -j 8
**System information**
Master Branch
Ubuntu 20.04
Core i5 intel 16GB RAM
| https://github.com/bitcoin/bitcoin/issues/26420 | https://github.com/bitcoin/bitcoin/pull/26421 | ab5b26f072a202be8b9a495ad3bc05ece00903c2 | fe86616bb4ad0c4296d34299bc2e2f0fca1fe936 | 2022-10-29T12:33:33Z | c++ | 2023-02-07T12:01:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,412 | ["test/functional/rpc_getblockfrompeer.py"] | Failure in rpc_getblockfrompeer.py | https://cirrus-ci.com/task/6199503433760768?logs=ci#L4414
https://cirrus-ci.com/task/5628523837652992?logs=ci#L4519
```bash
hash=5005fd299f78e023c07fa4cce23642e5a689c535f8adbc379825b7604b928b64)])
test 2022-10-28T10:04:36.776000Z TestFramework.p2p (DEBUG): Received message from 127.0.0.1:15393: msg_sendheaders()
test 2022-10-28T10:04:36.776000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 139, in try_rpc
fun(*args, **kwds)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/coverage.py", line 49, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/authproxy.py", line 144, in __call__
raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Block header missing (-1)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 133, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/rpc_getblockfrompeer.py", line 112, in run_test
assert_raises_rpc_error(-1, error_msg, self.nodes[1].getblockfrompeer, blockhash, node1_interface_id)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 130, in assert_raises_rpc_error
assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 147, in try_rpc
message, e.error['message']))
AssertionError: Expected substring not found in error message:
substring: 'In prune mode, only blocks that the node has already synced previously can be fetched from a peer'
error message: 'Block header missing'.
``` | https://github.com/bitcoin/bitcoin/issues/26412 | https://github.com/bitcoin/bitcoin/pull/26404 | 984a01589b7bc21e94d2ca9393d2d783cb3908a9 | 4f270d2b63913b86c4366756031c5003837075d6 | 2022-10-28T10:31:51Z | c++ | 2022-10-29T09:14:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,368 | ["src/test/system_tests.cpp"] | "system_tests/run_command" unit test fails on MSVC | I'm building v24.0rc2 on Windows 10 using Visual Studio 2022. The build succeeds without errors and the binary works fine, but there is one failing unit test:
```
C:\bitcoin\src>test_bitcoin.exe
Running 528 test cases...
C:/bitcoin/src/test/system_tests.cpp(64): error: in "system_tests/run_command": check what.find(expected) != std::string::npos has failed
*** 1 failure is detected in the test module "Bitcoin Core Test Suite"
```
Also tried with v23.0 and latest master, same error (for v23.0 the line number is different).
| https://github.com/bitcoin/bitcoin/issues/26368 | https://github.com/bitcoin/bitcoin/pull/26377 | f37bd15d472fdc7dd3d40cafaba9e8dfddd6b530 | 1bad29fe02096b269858b192a4a91c785a44e505 | 2022-10-22T19:29:54Z | c++ | 2022-10-28T09:32:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,364 | ["test/functional/p2p_sendtxrcncl.py"] | Intermitted failure in p2p_sendtxrcncl.py | I have seen `p2p_sendtxrcncl.py` fail randomly multiple times by now, e.g. : https://cirrus-ci.com/task/5513760365346816?logs=functional_tests. Also noted here: https://github.com/bitcoin/bitcoin/pull/23443#issuecomment-1281180599.
Log:
```
node0 2022-10-21T14:09:17.893264Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\node\txreconciliation.cpp:87] [PreRegisterPeer] [txreconciliation:debug] Pre-register peer=8
node0 2022-10-21T14:09:17.893346Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net.cpp:2775] [PushMessage] [net] sending sendtxrcncl (14 bytes) peer=8
node0 2022-10-21T14:09:17.893450Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net.cpp:2775] [PushMessage] [net] sending verack (0 bytes) peer=8
node0 2022-10-21T14:09:17.893570Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net_processing.cpp:3363] [ProcessMessage] [net] receive version message: /python-p2p-tester:0.0.3/: version 70016, blocks=-1, us=127.0.0.1:14312, txrelay=1, peer=8
node0 2022-10-21T14:09:17.893649Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net_processing.cpp:3146] [ProcessMessage] [net] received: verack (0 bytes) peer=8
node0 2022-10-21T14:09:17.893703Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net.cpp:2775] [PushMessage] [net] sending sendcmpct (9 bytes) peer=8
node0 2022-10-21T14:09:17.893811Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\node\txreconciliation.cpp:145] [ForgetPeer] [txreconciliation:debug] Forget txreconciliation state of peer=8
node0 2022-10-21T14:09:17.893898Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net.cpp:2775] [PushMessage] [net] sending ping (8 bytes) peer=8
node0 2022-10-21T14:09:17.894111Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net.cpp:2775] [PushMessage] [net] sending getheaders (645 bytes) peer=8
node0 2022-10-21T14:09:17.894243Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net_processing.cpp:5413] [SendMessages] [net] initial getheaders (199) to peer=8 (startheight:-1)
node0 2022-10-21T14:09:17.894355Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net.cpp:2775] [PushMessage] [net] sending feefilter (8 bytes) peer=8
node0 2022-10-21T14:09:17.894489Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net_processing.cpp:3146] [ProcessMessage] [net] received: ping (8 bytes) peer=8
node0 2022-10-21T14:09:17.894554Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net.cpp:2775] [PushMessage] [net] sending pong (8 bytes) peer=8
node0 2022-10-21T14:09:17.894682Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net_processing.cpp:3146] [ProcessMessage] [net] received: wtxidrelay (0 bytes) peer=8
node0 2022-10-21T14:09:17.894740Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net_processing.cpp:3460] [ProcessMessage] [net] wtxidrelay received after verack from peer=8; disconnecting
test 2022-10-21T14:09:17.954000Z TestFramework.p2p (DEBUG): Closed connection to: 127.0.0.1:14312
node0 2022-10-21T14:09:17.954581Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net.cpp:572] [CloseSocketDisconnect] [net] disconnecting peer=8
node0 2022-10-21T14:09:17.954849Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\net_processing.cpp:1528] [FinalizeNode] [net] Cleared nodestate for peer=8
test 2022-10-21T14:09:17.970000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\test_framework.py", line 133, in main
self.run_test()
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\p2p_sendtxrcncl.py", line 138, in run_test
peer.send_and_ping(msg_verack())
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\p2p.py", line 553, in send_and_ping
self.sync_with_ping(timeout=timeout)
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\p2p.py", line 570, in sync_with_ping
self.wait_until(test_function, timeout=timeout)
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\p2p.py", line 463, in wait_until
wait_until_helper(test_function, timeout=timeout, lock=p2p_lock, timeout_factor=self.timeout_factor)
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\util.py", line 267, in wait_until_helper
if predicate():
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\p2p.py", line 460, in test_function
assert self.is_connected
AssertionError
``` | https://github.com/bitcoin/bitcoin/issues/26364 | https://github.com/bitcoin/bitcoin/pull/26381 | a1fff275e7b6e01a46ad248c3b4e220091c1e806 | 69b10212ea5370606c7a5aa500a70c36b4cbb58f | 2022-10-21T14:40:04Z | c++ | 2022-10-26T10:36:11Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,330 | ["test/functional/feature_index_prune.py"] | test: Intermittent failure in `feature_index_prune.py` | https://cirrus-ci.com/task/5021369209978880
https://cirrus-ci.com/task/6533221721571328
https://cirrus-ci.com/task/5355957631320064 | https://github.com/bitcoin/bitcoin/issues/26330 | https://github.com/bitcoin/bitcoin/pull/26417 | 39f026b1ec17ef8100457ef46a1e4980767c0fe2 | 5274f324375fd31cf8507531fbc612765d03092f | 2022-10-18T08:29:49Z | c++ | 2022-11-02T14:00:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,274 | ["src/rpc/output_script.cpp", "test/functional/rpc_deriveaddresses.py"] | bitcoind dumps core when deriveaddresses is called with index 2147483647 (2^31-1) | The `deriveaddresses` JSON-RPC endpoint accepts a descriptor and an index for the derivation.
Currently, the RPC interface caps the allowed index derivation range in the interval [0,2^31-1].
However, calling `deriveaddresses` using a range that includes the index `2147483647` (2^31-1) results in a crash of bitcoind (on an AMD64 machine):
```
bitcoin-cli deriveaddresses "descriptor" "[2147483647, 2147483647]"
[bitcoind dumps core]
```
In the PR that addresses this pull request (#26275) is included a test case that causes the crash.
For convenience, here's the contents of a core dump generated with that test:
```
$ sudo coredumpctl debug bitcoind
PID: 110184 (bitcoind)
UID: 1000 (muxator)
GID: 1000 (muxator)
Signal: 6 (ABRT)
Timestamp: Thu 2022-10-06 17:48:08 CEST (4min 56s ago)
Command Line: <base>/src/bitcoind -datadir=/tmp/test_runner_₿_🏃_20221006_174805/rpc_deriveaddresses_crash_0/node0 -logtimemicros -debug -debugexclude=libevent -debugexclude=leveldb -uacomment=testnode0 -logthreadnames -logsourcelocations -loglevel=trace -sandbox=log-and-abort
Executable: <base>/src/bitcoind
[...]
Message: Process 110184 (bitcoind) of user 1000 dumped core.
[...]
ELF object binary architecture: AMD x86-64
GNU gdb (GDB) Fedora 12.1-1.fc36
[...]
Core was generated by `<base>/src/bitcoind -datadir=/tmp/test_runner_₿_��'.
Program terminated with signal SIGABRT, Aborted.
#0 0x00007f55a8ac6c4c in __pthread_kill_implementation () from /lib64/libc.so.6
[Current thread is 1 (Thread 0x7f5576ffd640 (LWP 110197))]
Missing separate debuginfos, use: dnf debuginfo-install glibc-2.35-17.fc36.x86_64 libevent-2.1.12-6.fc36.x86_64 libgcc-12.2.1-2.fc36.x86_64 libstdc++-12.2.1-2.fc36.x86_64 sqlite-libs-3.36.0-5.fc36.x86_64 zlib-1.2.11-33.fc36.x86_64
(gdb) bt
#0 0x00007f55a8ac6c4c in __pthread_kill_implementation () from /lib64/libc.so.6
#1 0x00007f55a8a769c6 in raise () from /lib64/libc.so.6
#2 0x00007f55a8a607f4 in abort () from /lib64/libc.so.6
#3 0x00007f55a8c40c11 in __addvsi3 () from /lib64/libgcc_s.so.1
#4 0x0000563935a84d73 in operator() (__closure=0x7f5576ffbd50, self=..., request=...) at rpc/output_script.cpp:276
#5 0x0000563935a87ec2 in std::__invoke_impl<UniValue, deriveaddresses()::<lambda(const RPCHelpMan&, const JSONRPCRequest&)>&, const RPCHelpMan&, const JSONRPCRequest&>(std::__invoke_other, struct {...} &) (__f=...)
at /usr/include/c++/12/bits/invoke.h:61
#6 0x0000563935a8773f in std::__invoke_r<UniValue, deriveaddresses()::<lambda(const RPCHelpMan&, const JSONRPCRequest&)>&, const RPCHelpMan&, const JSONRPCRequest&>(struct {...} &) (__fn=...) at /usr/include/c++/12/bits/invoke.h:116
#7 0x0000563935a86ec3 in std::_Function_handler<UniValue(const RPCHelpMan&, const JSONRPCRequest&), deriveaddresses()::<lambda(const RPCHelpMan&, const JSONRPCRequest&)> >::_M_invoke(const std::_Any_data &, const RPCHelpMan &, const JSONRPCRequest &) (__functor=..., __args#0=..., __args#1=...) at /usr/include/c++/12/bits/std_function.h:291
#8 0x00005639360b4641 in std::function<UniValue (RPCHelpMan const&, JSONRPCRequest const&)>::operator()(RPCHelpMan const&, JSONRPCRequest const&) const (this=0x7f5576ffbd50, __args#0=..., __args#1=...)
at /usr/include/c++/12/bits/std_function.h:591
#9 0x00005639360a93b8 in RPCHelpMan::HandleRequest (this=0x7f5576ffbd30, request=...) at rpc/util.cpp:585
#10 0x00005639359cc1a2 in CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::{lambda(JSONRPCRequest const&, UniValue&, bool)#1}::operator()(JSONRPCRequest const&, UniValue&, bool) const (__closure=0x5639368fbb00 <RegisterOutputScriptRPCCommands(CRPCTable&)::commands+320>, request=..., result=...) at ./rpc/server.h:109
#11 0x00005639359e0be3 in std::__invoke_impl<bool, CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::{lambda(JSONRPCRequest const&, UniValue&, bool)#1}&, JSONRPCRequest const&, UniValue&, bool>(std::__invoke_other, CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::{lambda(JSONRPCRequest const&, UniValue&, bool)#1}&, JSONRPCRequest const&, UniValue&, bool&&) (__f=...) at /usr/include/c++/12/bits/invoke.h:61
#12 0x00005639359da9ba in std::__invoke_r<bool, CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::{lambda(JSONRPCRequest const&, UniValue&, bool)#1}&, JSONRPCRequest const&, UniValue&, bool>(CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::{lambda(JSONRPCRequest const&, UniValue&, bool)#1}&, JSONRPCRequest const&, UniValue&, bool&&) (__fn=...) at /usr/include/c++/12/bits/invoke.h:114
#13 0x00005639359d4916 in std::_Function_handler<bool (JSONRPCRequest const&, UniValue&, bool), CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::{lambda(JSONRPCRequest const&, UniValue&, bool)#1}>::_M_invoke(std::_Any_data const&, JSONRPCRequest const&, UniValue&, bool&&) (__functor=..., __args#0=..., __args#1=..., __args#2=@0x7f5576ffbf44: true) at /usr/include/c++/12/bits/std_function.h:290
#14 0x00005639359302c6 in std::function<bool (JSONRPCRequest const&, UniValue&, bool)>::operator()(JSONRPCRequest const&, UniValue&, bool) const (this=0x5639368fbb00 <RegisterOutputScriptRPCCommands(CRPCTable&)::commands+320>,
__args#0=..., __args#1=..., __args#2=true) at /usr/include/c++/12/bits/std_function.h:591
#15 0x0000563935b0afd5 in ExecuteCommand (command=..., request=..., result=..., last_handler=true) at rpc/server.cpp:475
#16 0x0000563935b0abae in ExecuteCommands (commands=std::vector of length 1, capacity 1 = {...}, request=..., result=...) at rpc/server.cpp:440
#17 0x0000563935b0ad52 in CRPCTable::execute (this=0x5639368fc4c0 <tableRPC>, request=...) at rpc/server.cpp:460
#18 0x0000563935cbe3f5 in HTTPReq_JSONRPC (context=std::any containing node::NodeContext * = {...}, req=0x7f556c002da0) at httprpc.cpp:201
#19 0x0000563935cc0548 in operator() (__closure=0x7f556c001980, req=0x7f556c002da0) at httprpc.cpp:300
#20 0x0000563935cc1c3a in std::__invoke_impl<bool, StartHTTPRPC(const std::any&)::<lambda(HTTPRequest*, const std::string&)>&, HTTPRequest*, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&>(std::__invoke_other, struct {...} &) (__f=...) at /usr/include/c++/12/bits/invoke.h:61
#21 0x0000563935cc1a78 in std::__invoke_r<bool, StartHTTPRPC(const std::any&)::<lambda(HTTPRequest*, const std::string&)>&, HTTPRequest*, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&>(struct {...} &) (__fn=...) at /usr/include/c++/12/bits/invoke.h:114
#22 0x0000563935cc182e in std::_Function_handler<bool(HTTPRequest*, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&), StartHTTPRPC(const std::any&)::<lambda(HTTPRequest*, const std::string&)> >::_M_invoke(const std::_Any_data &, HTTPRequest *&&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > &) (__functor=..., __args#0=@0x7f5576ffcb80: 0x7f556c002da0, __args#1="")
at /usr/include/c++/12/bits/std_function.h:290
#23 0x0000563935cd1c0c in std::function<bool (HTTPRequest*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)>::operator()(HTTPRequest*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const (this=0x7f556c003fb0, __args#0=0x7f556c002da0, __args#1="") at /usr/include/c++/12/bits/std_function.h:591
#24 0x0000563935cd0fc2 in HTTPWorkItem::operator() (this=0x7f556c003f80) at httpserver.cpp:56
#25 0x0000563935cd326d in WorkQueue<HTTPClosure>::Run (this=0x563938765d10) at httpserver.cpp:111
#26 0x0000563935ccbf1d in HTTPWorkQueueRun (queue=0x563938765d10, worker_num=3) at httpserver.cpp:343
#27 0x0000563935cdfd51 in std::__invoke_impl<void, void (*)(WorkQueue<HTTPClosure>*, int), WorkQueue<HTTPClosure>*, int> (__f=@0x56393877e7f8: 0x563935ccbeb2 <HTTPWorkQueueRun(WorkQueue<HTTPClosure>*, int)>)
at /usr/include/c++/12/bits/invoke.h:61
#28 0x0000563935cdfaaa in std::__invoke<void (*)(WorkQueue<HTTPClosure>*, int), WorkQueue<HTTPClosure>*, int> (__fn=@0x56393877e7f8: 0x563935ccbeb2 <HTTPWorkQueueRun(WorkQueue<HTTPClosure>*, int)>)
at /usr/include/c++/12/bits/invoke.h:96
#29 0x0000563935cdf8a6 in std::thread::_Invoker<std::tuple<void (*)(WorkQueue<HTTPClosure>*, int), WorkQueue<HTTPClosure>*, int> >::_M_invoke<0ul, 1ul, 2ul> (this=0x56393877e7e8) at /usr/include/c++/12/bits/std_thread.h:252
#30 0x0000563935cdf7db in std::thread::_Invoker<std::tuple<void (*)(WorkQueue<HTTPClosure>*, int), WorkQueue<HTTPClosure>*, int> >::operator() (this=0x56393877e7e8) at /usr/include/c++/12/bits/std_thread.h:259
#31 0x0000563935cdf60f in std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (*)(WorkQueue<HTTPClosure>*, int), WorkQueue<HTTPClosure>*, int> > >::_M_run (this=0x56393877e7e0) at /usr/include/c++/12/bits/std_thread.h:210
#32 0x00007f55a8e15b03 in execute_native_thread_routine () from /lib64/libstdc++.so.6
#33 0x00007f55a8ac4e2d in start_thread () from /lib64/libc.so.6
#34 0x00007f55a8b4a1b0 in clone3 () from /lib64/libc.so.6
```
The affected code seems to be in frame 4, and corresponds to the following code:
```
(gdb) frame 4
#4 0x0000563935a84d73 in operator() (__closure=0x7f5576ffbd50, self=..., request=...) at rpc/output_script.cpp:276
276 for (int i = range_begin; i <= range_end; ++i) {
```
I think the reason is that, while `range_begin` and `range_end` are `uint64_t`, `i` is an `int`, which on many platforms means `int32_t`.
When `i` is assigned `2^31-1` and is then incremented, it wraps back and causes the crash.
| https://github.com/bitcoin/bitcoin/issues/26274 | https://github.com/bitcoin/bitcoin/pull/26275 | 28cf75697186ea8e473e120a643994bdf8237d6c | cf288377c03577ba3059e56c6c8ad133f54c3342 | 2022-10-06T16:16:46Z | c++ | 2022-10-26T08:12:27Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,185 | ["src/wallet/spend.cpp", "src/wallet/test/coinselector_tests.cpp"] | `bitcoind` and `bitcoin-qt` crashes while creating PSBT | `bitcoind` and `bitcoin-qt` crashes when creating a PSBT with `walletcreatefundedpsbt`
**Expected behavior**
`bitcoind` and `bitcoin-qt` should not crash and users should not see assertion errors on mainnet. Failing gracefully with some error message would be better. Although I was not able to reproduce this issue on Fedora so ideally this should be fixed.
**Actual behavior**
Error in bitcoind:
```
Assertion failed: selected_effective_value >= target, file wallet/coinselection.cpp, line 391
```
Error in bitcoin-qt:
**To reproduce**
1. Create bitcoin.conf
```
signet=1
txindex=1
signet.rpcport=38332
rpcuser=user
rpcpassword=pass
fallbackfee=0.0004
```
2. Add descriptor in a wallet using bitcoin-qt console:
```
importmulti '[{ "desc": "sh(multi(2,[aa130fed]02de62833c851509cf13c0c63e0dc3ef7b74f7d86b17e9090fab68c09830cb2f2e,[00890d8d]03cf11a2bc1371dad3691bce59e37d85b12aae6b030b533d4e7c5aedeb47a5ec0e))#j8w6g6zg", "timestamp":"now"}]'
```
3. Create PSBT using bitcoin-qt, click on different options in the error message and you will notice it creates PSBT with no change by clicking 'ignore' 3 times else crashes with others:
```
walletcreatefundedpsbt "[{\"txid\":\"e911734bf711009dd6057c88bc598df2d31c18d1cc6bd6c790a704b519d77e68\",\"vout\":0}]" "[{\"tb1q9fxp2p0sm93jdlul8v3svzn7x69zcd9ljsgans\":\"0.0009\"}]"
```
4. Close bitcoin-qt and open powershell or command prompt to create PSBT:
```
bitcoind.exe
````
```
bitcoin-cli.exe -rpcwallet=M1 walletcreatefundedpsbt "[{\"txid\":\"e911734bf711009dd6057c88bc598df2d31c18d1cc6bd6c790a704b519d77e68\",\"vout\":0}]" "[{\"tb1q9fxp2p0sm93jdlul8v3svzn7x69zcd9ljsgans\":\"0.0009\"}]"
```
**System information**
Windows 10
Bitcoin Core Master Branch
| https://github.com/bitcoin/bitcoin/issues/26185 | https://github.com/bitcoin/bitcoin/pull/26203 | 1730f6cb23cc05445df3266cb21b8846b99427b4 | cda6c791903c10ec20d3a6c4619bfe78ff02f3b6 | 2022-09-26T21:05:26Z | c++ | 2022-10-04T08:57:17Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,163 | [".cirrus.yml"] | CI: Old versions of git can't handle merges | It appears git versions older than 2.33 can't handle some simple merges, and many of our CI tasks use such old versions.
The simplest fix is probably to just use GitHub's generated merge branch rather than trying to merge in each CI instance, but I haven't tested it. | https://github.com/bitcoin/bitcoin/issues/26163 | https://github.com/bitcoin/bitcoin/pull/26202 | 291e363ce500e492475c4ccd189ea1d031c43613 | 437b608df289c97fd88f1dd79bdc8359e1b1c5b1 | 2022-09-23T17:52:29Z | c++ | 2022-09-29T17:15:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,112 | ["src/coins.cpp", "src/coins.h", "src/init.cpp"] | Running out of disk space can leave bitcoin in a desynced state | I noticed my node was not syncing, and through some debugging on #bitcoin-core-dev it seems like it was caused by running out of disk space which left the node in a desynced state, with the valid chain marked as invalid.
After freeing up some space and doing `reconsiderblock` it fixed it.
Comments from @sipa:
> Ugh. That is bad. Out of disk space should not result in database corruption.
> Database errors propagating up and being interpreted as (permanent) block invalidity was one of the contributing factors to the BDB/LevelDB fork in the 0.7/0.8 transition.
logs:
```
2022-09-05T00:28:55Z UpdateTip: new best=000000000000000000087e337539b369b19570a88c493725020266387d22dac0 height=752167 version=0x2ce8e004 log2_work=93.70770
7 tx=761139817 date='2022-09-01T15:00:06Z' progress=0.998887 cache=146.8MiB(1101860txo)
2022-09-05T00:28:55Z Fatal LevelDB error: IO error: /home/jb55/.bitcoin/chainstate/2963623.ldb: No space left on device
2022-09-05T00:28:55Z You can use -debug=leveldb to get more complete diagnostic messages
2022-09-05T00:28:55Z *** System error while flushing: Fatal LevelDB error: IO error: /home/jb55/.bitcoin/chainstate/2963623.ldb: No space left on device
2022-09-05T00:28:55Z Error: A fatal internal error occurred, see debug.log for details
2022-09-05T00:28:56Z ERROR: ProcessNewBlock: ActivateBestChain failed (System error while flushing: Fatal LevelDB error: IO error: /home/jb55/.bitcoin/chains
tate/2963623.ldb: No space left on device)
2022-09-05T00:28:56Z ERROR: ConnectBlock: Consensus::CheckTxInputs: 221fa678c5c9953d6cd17e584f05c12ab10ba0f2fc8e8131e266f3f0e9819848, bad-txns-inputs-missing
orspent, CheckTxInputs: inputs missing/spent
2022-09-05T00:28:56Z InvalidChainFound: invalid block=000000000000000000079ba062298aa7cef1888f870c23e303a361c19b097ff8 height=752168 log2_work=93.707719 date=2022-09-01T15:13:42Z
2022-09-05T00:28:56Z InvalidChainFound: current best=000000000000000000087e337539b369b19570a88c493725020266387d22dac0 height=752167 log2_work=93.707707 date=2022-09-01T15:00:06Z
2022-09-05T00:28:56Z ERROR: ConnectTip: ConnectBlock 000000000000000000079ba062298aa7cef1888f870c23e303a361c19b097ff8 failed, bad-txns-inputs-missingorspent, CheckTxInputs: inputs missing/spent
2022-09-05T00:28:56Z InvalidChainFound: invalid block=000000000000000000079ba062298aa7cef1888f870c23e303a361c19b097ff8 height=752168 log2_work=93.707719 date=2022-09-01T15:13:42Z
2022-09-05T00:28:56Z InvalidChainFound: current best=000000000000000000087e337539b369b19570a88c493725020266387d22dac0 height=752167 log2_work=93.707707 date=2022-09-01T15:00:06Z
```
| https://github.com/bitcoin/bitcoin/issues/26112 | https://github.com/bitcoin/bitcoin/pull/26331 | 4e7442e743afef4d365fc3ce7c6e9f0a5d4d1ec4 | 04265ba9378efbd4c35b33390b1e5cf246d420a9 | 2022-09-16T17:27:26Z | c++ | 2023-10-09T18:52:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,098 | ["test/functional/interface_rest.py"] | test: failure in interface_rest.py | ERROR: type should be string, got "https://cirrus-ci.com/task/6131758964932608?logs=functional_tests#L43\r\n\r\n```\r\nTraceback (most recent call last):\r\n File \"C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\cirrus-ci-build\\test\\functional\\test_framework\\test_framework.py\", line 133, in main\r\n self.run_test()\r\n File \"C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\cirrus-ci-build\\test\\functional\\interface_rest.py\", line 293, in run_test\r\n json_obj = self.test_rest_request(f\"/blockfilterheaders/basic/{bb_hash}\", query_params={\"count\": 5})\r\n File \"C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\cirrus-ci-build\\test\\functional\\interface_rest.py\", line 85, in test_rest_request\r\n assert_equal(resp.status, status)\r\n File \"C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\cirrus-ci-build\\test\\functional\\test_framework\\util.py\", line 56, in assert_equal\r\n raise AssertionError(\"not(%s)\" % \" == \".join(str(arg) for arg in (thing1, thing2) + args))\r\nAssertionError: not(404 == 200)\r\n```" | https://github.com/bitcoin/bitcoin/issues/26098 | https://github.com/bitcoin/bitcoin/pull/26143 | 9e2a2b88d5cae247bd2dd5aa32743198a5d4841b | 7184fb866fff2f3557aea79ed0a967995e298f0a | 2022-09-15T08:41:19Z | c++ | 2022-09-21T07:55:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,071 | ["src/wallet/wallet.cpp", "test/functional/wallet_resendwallettransactions.py"] | test: failure in wallet_resendwallettransactions.py | https://cirrus-ci.com/task/5603470202896384?logs=ci#L2681 | https://github.com/bitcoin/bitcoin/issues/26071 | https://github.com/bitcoin/bitcoin/pull/26091 | f332c4f64d52e82211c1199bbd5bab2c6bfc57f4 | 96f1b2d34fd5a5f0ab0628caa20df6d5cc989dfd | 2022-09-12T20:27:03Z | c++ | 2022-09-15T17:17:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,062 | ["src/i2p.cpp"] | I2P: Transient destinations should be SIGNATURE_TYPE=7 | https://github.com/bitcoin/bitcoin/commit/2b781ad66e34000037f589c71366c203255ed058#r83655059 | https://github.com/bitcoin/bitcoin/issues/26062 | https://github.com/bitcoin/bitcoin/pull/26065 | 27351fb9159ecbbac358b86fd9d00c90b1d9a3bc | 19526d937fbd16b3c868f4a7ecd2c076e71eb8fc | 2022-09-11T12:56:40Z | c++ | 2022-09-16T08:13:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,051 | ["test/functional/rpc_invalidateblock.py"] | intermittent failure in rpc_invalidateblock.py | Seen in doc-only PR: https://cirrus-ci.com/task/4697486185988096?logs=ci
```
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 133, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/rpc_invalidateblock.py", line 90, in run_test
assert_equal(chain_tips, self.nodes[1].getchaintips())
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 56, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not([{'height': 24, 'hash': '1e8c7b54ab7c4556c4602fc89c0796d104260df2e2f8d2de9006d2446676d71c', 'branchlen': 0, 'status': 'active'}, {'height': 6, 'hash': '46727213ae639f43edd7fde6d5c2dcd54cc182f7c3a5c7a652784a7ece5aa0cf', 'branchlen': 2, 'status': 'invalid'}, {'height': 4, 'hash': '0fefbfc08f4e5e4ae4dd1a74113c580530bda9bfa85ed2c40e59ee8ff5bc352d', 'branchlen': 4, 'status': 'headers-only'}] == [{'height': 24, 'hash': '1e8c7b54ab7c4556c4602fc89c0796d104260df2e2f8d2de9006d2446676d71c', 'branchlen': 0, 'status': 'active'}, {'height': 6, 'hash': '46727213ae639f43edd7fde6d5c2dcd54cc182f7c3a5c7a652784a7ece5aa0cf', 'branchlen': 2, 'status': 'invalid'}, {'height': 4, 'hash': '0fefbfc08f4e5e4ae4dd1a74113c580530bda9bfa85ed2c40e59ee8ff5bc352d', 'branchlen': 4, 'status': 'headers-only'}, {'height': 3, 'hash': '4ff28db3f1e2007c2a8f321dc6759ffdb7ff0c81ea9334d982049b9c8ae674a9', 'branchlen': 1, 'status': 'headers-only'}])
``` | https://github.com/bitcoin/bitcoin/issues/26051 | https://github.com/bitcoin/bitcoin/pull/26054 | 8ca51aa5fb7959b4c7a458208e251c7a2645175c | bb378b6ccdd3804fe38640356e8a27de549c50af | 2022-09-09T15:10:14Z | c++ | 2022-09-10T06:37:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,030 | ["src/wallet/scriptpubkeyman.cpp", "src/wallet/spend.cpp", "src/wallet/spend.h", "src/wallet/wallet.cpp", "src/wallet/wallet.h"] | Don't assume signature grinding for external signers | Since #13666 our fee calculation assumes that ECSDA signatures are a maximum of 71 bytes, rather than 72. However, not all hardware wallets implement R-value grinding.
This can cause us to underpay fees when using an external signer. That's especially problematic when the user picks 1 sat/vbyte as the fee, because it won't even get into our own mempool.
The easiest solution would be to modify `ExternalSignerScriptPubKeyMan` to assume 72 bytes for ECSDA signatures.
Slightly more advanced would be to expand HWI to keep track of which devices and firmware versions (if any) support R-value grinding. We'd then have to store that in the wallet in some new field. Personally I'd rather work on better Taproot support, which thanks to Schnorr avoids this issue altogether. | https://github.com/bitcoin/bitcoin/issues/26030 | https://github.com/bitcoin/bitcoin/pull/26032 | 82793f1984911774b111117f2e81d5f3b0bbec68 | 710cab1d43e53a6e25300ffab961c292df802983 | 2022-09-07T07:58:17Z | c++ | 2023-02-27T17:37:46Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,029 | ["test/functional/wallet_basic.py", "test/functional/wallet_listsinceblock.py"] | test: BDB-only build fails wallet_basic.py | Steps to reproduce:
* Compile bdb-only
* Run wallet_basic.py
```
test 2022-09-05T10:20:34.866000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/test_framework/test_framework.py", line 133, in main
self.run_test()
File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/wallet_basic.py", line 708, in run_test
self.nodes[0].createwallet(wallet_name="wo", descriptors=True, disable_private_keys=True)
File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/test_framework/test_node.py", line 754, in createwallet
return self.__getattr__('createwallet')(wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup, external_signer)
File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/test_framework/coverage.py", line 49, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/test_framework/authproxy.py", line 144, in __call__
raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Compiled without sqlite support (required for descriptor wallets) (-4)
| https://github.com/bitcoin/bitcoin/issues/26029 | https://github.com/bitcoin/bitcoin/pull/26037 | 37095c7dc4a85155c35e2473b6a20a53ae413cea | 2557429d2b82fe5ba308b940bcf14c3047634345 | 2022-09-07T07:53:53Z | c++ | 2022-09-08T06:56:09Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,023 | ["test/functional/test_runner.py"] | Running functional tests using test_runner.py does NOT display the SkipTest() message | **Is your feature request related to a problem? Please describe.**
When I'm running functional tests using test_runner.py, I am not seeing. SkipTest messages being displayed. For example:
_2/254 - feature_bind_extra.py skipped_
Whereas in feature_bind_extra.py, I see this following message:
_raise SkipTest("This test can only be run on Linux.")_
**Describe the solution you'd like**
1. Am I missing a particular configuration when running test_runner.py? Currently, I'm running this:
_test/functional/test_runner.py --extended -j 10_
2. If the feature is missing to display SkipTests, would it be a good idea to add this feature to display why tests are getting skipped when using test_runner.py?
| https://github.com/bitcoin/bitcoin/issues/26023 | https://github.com/bitcoin/bitcoin/pull/26031 | a9049dd296a47319038d8c34bcc1ca46c89dee9c | 013924aa6dc91dd8be93c1eaab6546710ed7fde2 | 2022-09-06T18:00:03Z | c++ | 2022-09-09T08:32:46Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,017 | ["src/sync.h"] | [MSVC] Bitcoin failed to build with waring c4858 on MSVC | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
**Describe**
Hi all,
Bitcoin fails to build on MSVC due to waring c4858. Could you help look?
**Expected behavior**
Build successfully.
<!--- What behavior did you expect? -->
**Actual behavior**
F:\gitP\bitcoin\bitcoin\src\sync.h(168): error C2220: the following warning is treated as an error
F:\gitP\bitcoin\bitcoin\src\sync.h(166): note: while compiling class template member function 'bool UniqueLock<_Ty,std::unique_lock<PARENT>>::TryEnter(const char *,const char *,int)'
with
[
_Ty=RecursiveMutex,
PARENT=std::recursive_mutex
]
F:\gitP\bitcoin\bitcoin\src\sync.h(179): note: see reference to function template instantiation 'bool UniqueLock<_Ty,std::unique_lock<PARENT>>::TryEnter(const char *,const char *,int)' being compiled
with
[
_Ty=RecursiveMutex,
PARENT=std::recursive_mutex
]
F:\gitP\bitcoin\bitcoin\src\net.h(822): note: see reference to class template instantiation 'UniqueLock<_Ty,std::unique_lock<PARENT>>' being compiled
with
[
_Ty=RecursiveMutex,
PARENT=std::recursive_mutex
]
F:\gitP\bitcoin\bitcoin\src\sync.h(168): warning C4858: discarding return value: This function returns whether the operation succeeded in modifying object state. It is dangerous to ignore the return value.
**Detail log**
[Uploading build (3).log…]()
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
**To reproduce**
1. git clone https://github.com/bitcoin/bitcoin F:\gitP\bitcoin\bitcoin
2. cd F:\gitP\bitcoin\bitcoin\build_msvc
3. py -3 msvc-autogen.py
4. cd F:\gitP\bitcoin\tools\vcpkg
5. git -C "F:\gitP\bitcoin\tools\vcpkg" clean -xdf 2>&1
6. bootstrap-vcpkg.bat 2>&1
7. set path=%cd%;%path%
8. cd F:\gitP\bitcoin\bitcoin\build_msvc
9. msbuild /m /p:Platform=x64 /p:Configuration=Release bitcoin.sln /t:Rebuild 2>&1
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
**System information**
VS version: VS2019 (16.11.11)
Operating system: windows server 2019
the commit of Bitcoin we use is 5174a13
**workaround**
I modified the common.init.vcxproj.in file of this text like below to solve this issue:
\<DisableSpecificWarnings\>4018;4244;4267;4334;4715;4805;4834\</DisableSpecificWarnings\>
to be:
\<DisableSpecificWarnings\>4018;4244;4267;4334;4715;4805;4834;4858\</DisableSpecificWarnings\>
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- GUI-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/26017 | https://github.com/bitcoin/bitcoin/pull/26189 | b92b12e8f3ea1e318e428e9c2ca0d529fd4452d2 | 1730f6cb23cc05445df3266cb21b8846b99427b4 | 2022-09-06T07:42:29Z | c++ | 2022-10-03T17:21:35Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.