status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,554 | ["src/util/syscall_sandbox.cpp"] | node3 stderr ERROR: The syscall "fstatfs" (syscall number 138) is not allowed by the syscall sandbox in thread "httpworker.0". Please report. | fe03f7a37fd0ef05149161f6b95a25493e1fe38f
Opensuse tumbleweed
Steps to reproduce:
```
./test/functional/wallet_backup.py --descriptors | https://github.com/bitcoin/bitcoin/issues/23554 | https://github.com/bitcoin/bitcoin/pull/23555 | 80ae64db6b27d69b0fe7b6583066b1141f7a2f51 | cf06c9b35c30512ede8f7dc323340bd9cfb2d0b9 | 2021-11-19T16:12:11Z | c++ | 2021-11-21T07:24:27Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,514 | ["test/functional/rpc_txoutproof.py", "test/functional/test_framework/wallet.py"] | qa: Failure in feature_txindex_compatibility.py on master | ERROR: type should be string, got "https://api.cirrus-ci.com/v1/task/6143696841211904/logs/ci.log:\r\n```\r\n204/225 - \u001b[1mfeature_txindex_compatibility.py\u001b[0m failed, Duration: 1 s\r\n\r\n\u001b[1mstdout:\r\n\u001b[0m2021-11-15T10:09:01.666000Z TestFramework (INFO): Initializing test directory /tmp/cirrus-build/ci/scratch/test_runner/test_runner_₿_🏃_20211115_095356/feature_txindex_compatibility_18\r\n2021-11-15T10:09:02.259000Z TestFramework (ERROR): Assertion failed\r\nTraceback (most recent call last):\r\n File \"/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py\", line 132, in main\r\n self.run_test()\r\n File \"/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_txindex_compatibility.py\", line 47, in run_test\r\n mini_wallet.send_self_transfer(from_node=self.nodes[1], utxo_to_spend=spend_utxo)\r\n File \"/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/wallet.py\", line 150, in send_self_transfer\r\n tx = self.create_self_transfer(**kwargs)\r\n File \"/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/wallet.py\", line 202, in create_self_transfer\r\n assert_equal(mempool_valid, tx_info['allowed'])\r\n File \"/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py\", line 50, in assert_equal\r\n raise AssertionError(\"not(%s)\" % \" == \".join(str(arg) for arg in (thing1, thing2) + args))\r\nAssertionError: not(True == False)\r\n2021-11-15T10:09:02.314000Z TestFramework (INFO): Stopping nodes\r\n2021-11-15T10:09:02.571000Z TestFramework (WARNING): Not cleaning up dir /tmp/cirrus-build/ci/scratch/test_runner/test_runner_₿_🏃_20211115_095356/feature_txindex_compatibility_18\r\n2021-11-15T10:09:02.571000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/cirrus-build/ci/scratch/test_runner/test_runner_₿_🏃_20211115_095356/feature_txindex_compatibility_18/test_framework.log\r\n2021-11-15T10:09:02.572000Z TestFramework (ERROR): \r\n2021-11-15T10:09:02.572000Z TestFramework (ERROR): Hint: Call /tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/combine_logs.py '/tmp/cirrus-build/ci/scratch/test_runner/test_runner_₿_🏃_20211115_095356/feature_txindex_compatibility_18' to consolidate all logs\r\n2021-11-15T10:09:02.572000Z TestFramework (ERROR): \r\n2021-11-15T10:09:02.572000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.\r\n2021-11-15T10:09:02.572000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues\r\n2021-11-15T10:09:02.573000Z TestFramework (ERROR): \r\n```" | https://github.com/bitcoin/bitcoin/issues/23514 | https://github.com/bitcoin/bitcoin/pull/23515 | 024e4debc529db16d1ec7d1f2ceb6ecb768156ea | fa2303989bed629c1d6911034370db66c5485ce0 | 2021-11-15T12:03:17Z | c++ | 2021-11-15T16:19:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,452 | ["doc/zmq.md"] | ZMQ documentation unclear on what info notifications provide. | I was reading the [ZMQ documentation](https://github.com/bitcoin/bitcoin/blob/master/doc/zmq.md
) and it's not immediately clear to me what each of these provides:
- zmqpubhashtx
- zmqpubhashblock
- zmqpubrawblock
- zmqpubrawtx
- zmqpubsequence
zmqpubhashblock and zmqpubrawblock seem obvious and are touched on later in the docs.
However zmqpubhashtx and zmqpubrawtx obviously provide transaction information, but to me it's a bit unclear as to what transactions are included. I'm assuming it's all transactions on the network? | https://github.com/bitcoin/bitcoin/issues/23452 | https://github.com/bitcoin/bitcoin/pull/23471 | 87ce2d646b92e2406a147cb114745b8533d4e0f0 | 6c04b505b4825054d3bca08bda8ea99cdbfba8e9 | 2021-11-06T19:25:07Z | c++ | 2021-12-14T09:07:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,368 | ["src/wallet/test/psbt_wallet_tests.cpp", "src/wallet/test/wallet_test_fixture.cpp", "src/wallet/test/wallet_test_fixture.h"] | qa: Intermittent failures in the psbt_wallet_tests/psbt_updater_test unit test | Recently, on the master branch some failures were observed in the `wallet/test/psbt_wallet_tests.cpp`:
- https://github.com/bitcoin/bitcoin/commit/49e40f5704db5e59fef834cac5d6b5395c75b091, [log](https://cirrus-ci.com/task/5381337495371776):
```
[0;39;49m[1;34;49mwallet/test/psbt_wallet_tests.cpp(27): Entering test case "psbt_updater_test"
[0;39;49m2021-10-25T14:37:00.306414Z [test] [test/util/setup_common.cpp:65] [Seed] Seed: Setting random seed for current tests to RANDOM_CTX_SEED=9ae440b04274b0a20a4eee7d0c0467ce8001fdcecc2785a4e288d14ed935c106
2021-10-25T14:37:00.306585Z [test] [init/common.cpp:165] [LogPackageVersion] Bitcoin Core version v22.99.0-49e40f5704db (debug build)
2021-10-25T14:37:00.306966Z [test] [init.cpp:904] [AppInitParameterInteraction] Assuming ancestors of block 00000000000000000008a89e854d57e5667df88f1cdef6fde2fbca1de5b639ad have valid signatures.
2021-10-25T14:37:00.307006Z [test] [init.cpp:917] [AppInitParameterInteraction] Setting nMinimumChainWork=00000000000000000000000000000000000000001fa4663bbbe19f82de910280
2021-10-25T14:37:00.310970Z [test] [script/sigcache.cpp:102] [InitSignatureCache] Using 16 MiB out of 32/2 requested for signature cache, able to store 524288 elements
2021-10-25T14:37:00.313940Z [test] [validation.cpp:1275] [InitScriptExecutionCache] Using 16 MiB out of 32/2 requested for script execution cache, able to store 524288 elements
2021-10-25T14:37:00.315039Z [test] [policy/fees.cpp:530] [CBlockPolicyEstimator] Failed to read fee estimates from /tmp/test_common_Bitcoin Core/8ee4dffed8f25e8b471e093ed7f53cb707111e2a24db9794e27a7890266e8c2b/fee_estimates.dat. Continue anyway.
2021-10-25T14:37:00.315377Z [test] [dbwrapper.cpp:141] [CDBWrapper] Opened LevelDB successfully
2021-10-25T14:37:00.315463Z [test] [dbwrapper.cpp:166] [CDBWrapper] Using obfuscation key for /tmp/test_common_Bitcoin Core/8ee4dffed8f25e8b471e093ed7f53cb707111e2a24db9794e27a7890266e8c2b/blocks/index: 0000000000000000
2021-10-25T14:37:00.315728Z [test] [validation.cpp:4659] [InitializeChainstate] Switching active chainstate to Chainstate [ibd] @ height -1 (null)
2021-10-25T14:37:00.316030Z [test] [dbwrapper.cpp:141] [CDBWrapper] Opened LevelDB successfully
2021-10-25T14:37:00.316155Z [test] [dbwrapper.cpp:163] [CDBWrapper] Wrote new obfuscate key for /tmp/test_common_Bitcoin Core/8ee4dffed8f25e8b471e093ed7f53cb707111e2a24db9794e27a7890266e8c2b/chainstate: e871977b736770ef
2021-10-25T14:37:00.316192Z [test] [dbwrapper.cpp:166] [CDBWrapper] Using obfuscation key for /tmp/test_common_Bitcoin Core/8ee4dffed8f25e8b471e093ed7f53cb707111e2a24db9794e27a7890266e8c2b/chainstate: e871977b736770ef
2021-10-25T14:37:00.316407Z [test] [flatfile.cpp:69] [Allocate] Pre-allocating up to position 0x1000000 in blk00000.dat
2021-10-25T14:37:00.316887Z [test] [validation.cpp:2294] [ConnectTip] - Load block from disk: 0.17ms [0.00s]
2021-10-25T14:37:00.317033Z [test] [validationinterface.cpp:249] [BlockChecked] BlockChecked: block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f state=Valid
2021-10-25T14:37:00.317093Z [test] [validation.cpp:2306] [ConnectTip] - Connect total: 0.22ms [0.00s (0.22ms/blk)]
2021-10-25T14:37:00.317126Z [test] [validation.cpp:2311] [ConnectTip] - Flush: 0.04ms [0.00s (0.04ms/blk)]
2021-10-25T14:37:00.317196Z [test] [validation.cpp:2317] [ConnectTip] - Writing chainstate: 0.07ms [0.00s (0.07ms/blk)]
2021-10-25T14:37:00.317308Z [test] [validation.cpp:2111] [UpdateTipLog] UpdateTip: new best=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f height=0 version=0x00000001 log2_work=32.000022 tx=1 date='2009-01-03T18:15:05Z' progress=0.000000 cache=0.0MiB(0txo)
2021-10-25T14:37:00.317340Z [test] [validation.cpp:2328] [ConnectTip] - Connect postprocess: 0.15ms [0.00s (0.15ms/blk)]
2021-10-25T14:37:00.317366Z [test] [validation.cpp:2329] [ConnectTip] - Connect block: 0.64ms [0.00s (0.64ms/blk)]
2021-10-25T14:37:00.317402Z [test] [txmempool.cpp:691] [check] Checking mempool with 0 transactions and 0 inputs
2021-10-25T14:37:00.317476Z [test] [validationinterface.cpp:226] [BlockConnected] Enqueuing BlockConnected: block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f block height=0
2021-10-25T14:37:00.317549Z [test] [validationinterface.cpp:199] [UpdatedBlockTip] Enqueuing UpdatedBlockTip: new block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f fork block hash=nulmake[3]: *** [Makefile:18454: wallet/test/psbt_wallet_tests.cpp.test] Error 1
```
- https://github.com/bitcoin/bitcoin/commit/beb45b8b141f8b3ebaa4ea8cb2f35f9ba03efbaf, [log](https://cirrus-ci.com/task/4853362869927936):
```
[0;39;49m[1;34;49mwallet/test/psbt_wallet_tests.cpp(27): Entering test case "psbt_updater_test"
[0;39;49m2021-10-25T14:09:48.595432Z [test] [test/util/setup_common.cpp:65] [Seed] Seed: Setting random seed for current tests to RANDOM_CTX_SEED=b22fbd18efa7c241ad6768e3811a8761f90f3ef69cd147d39e3380959b65a13e
2021-10-25T14:09:48.595477Z [test] [init/common.cpp:165] [LogPackageVersion] Bitcoin Core version v22.99.0-beb45b8b141f (release build)
2021-10-25T14:09:48.595608Z [test] [init.cpp:904] [AppInitParameterInteraction] Assuming ancestors of block 00000000000000000008a89e854d57e5667df88f1cdef6fde2fbca1de5b639ad have valid signatures.
2021-10-25T14:09:48.595620Z [test] [init.cpp:917] [AppInitParameterInteraction] Setting nMinimumChainWork=00000000000000000000000000000000000000001fa4663bbbe19f82de910280
2021-10-25T14:09:48.597202Z [test] [script/sigcache.cpp:102] [InitSignatureCache] Using 16 MiB out of 32/2 requested for signature cache, able to store 524288 elements
2021-10-25T14:09:48.598513Z [test] [validation.cpp:1269] [InitScriptExecutionCache] Using 16 MiB out of 32/2 requested for script execution cache, able to store 524288 elements
2021-10-25T14:09:48.598678Z [scheduler] [util/thread.cpp:17] [TraceThread] scheduler thread start
2021-10-25T14:09:48.599215Z [test] [policy/fees.cpp:530] [CBlockPolicyEstimator] Failed to read fee estimates from /tmp/test_common_Bitcoin Core/eabf744d4fabc12acc33a62b5991339fc39702ee5d19a3f1d76e220b6d7aff94/fee_estimates.dat. Continue anyway.
2021-10-25T14:09:48.599370Z [test] [dbwrapper.cpp:141] [CDBWrapper] Opened LevelDB successfully
2021-10-25T14:09:48.599399Z [test] [dbwrapper.cpp:166] [CDBWrapper] Using obfuscation key for /tmp/test_common_Bitcoin Core/eabf744d4fabc12acc33a62b5991339fc39702ee5d19a3f1d76e220b6d7aff94/blocks/index: 0000000000000000
2021-10-25T14:09:48.599585Z [test] [validation.cpp:4653] [InitializeChainstate] Switching active chainstate to Chainstate [ibd] @ height -1 (null)
2021-10-25T14:09:48.603729Z [test] [dbwrapper.cpp:141] [CDBWrapper] Opened LevelDB successfully
2021-10-25T14:09:48.603818Z [test] [dbwrapper.cpp:163] [CDBWrapper] Wrote new obfuscate key for /tmp/test_common_Bitcoin Core/eabf744d4fabc12acc33a62b5991339fc39702ee5d19a3f1d76e220b6d7aff94/chainstate: 1cfa6d2d89aeac10
2021-10-25T14:09:48.603836Z [test] [dbwrapper.cpp:166] [CDBWrapper] Using obfuscation key for /tmp/test_common_Bitcoin Core/eabf744d4fabc12acc33a62b5991339fc39702ee5d19a3f1d76e220b6d7aff94/chainstate: 1cfa6d2d89aeac10
2021-10-25T14:09:48.603962Z [test] [flatfile.cpp:69] [Allocate] Pre-allocating up to position 0x1000000 in blk00000.dat
2021-10-25T14:09:48.604157Z [test] [validation.cpp:2288] [ConnectTip] - Load block from disk: 0.05ms [0.00s]
2021-10-25T14:09:48.604212Z [test] [validationinterface.cpp:249] [BlockChecked] BlockChecked: block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f state=Valid
2021-10-25T14:09:48.604231Z [test] [validation.cpp:2300] [ConnectTip] - Connect total: 0.09ms [0.00s (0.09ms/blk)]
2021-10-25T14:09:48.604245Z [test] [validation.cpp:2305] [ConnectTip] - Flush: 0.02ms [0.00s (0.02ms/blk)]
2021-10-25T14:09:48.604263Z [test] [validation.cpp:2311] [ConnectTip] - Writing chainstate: 0.02ms [0.00s (0.02ms/blk)]
2021-10-25T14:09:48.604297Z [test] [validation.cpp:2105] [UpdateTipLog] UpdateTip: new best=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f height=0 version=0x00000001 log2_work=32.000022 tx=1 date='2009-01-03T18:15:05Z' progress=0.000000 cache=0.0MiB(0txo)
2021-10-25T14:09:48.604313Z [test] [validation.cpp:2322] [ConnectTip] - Connect postprocess: 0.05ms [0.00s (0.06ms/blk)]
2021-10-25T14:09:48.604326Z [test] [validation.cpp:2323] [ConnectTip] - Connect block: 0.22ms [0.00s (0.23ms/blk)]
2021-10-25T14:09:48.604341Z [test] [txmempool.cpp:683] [check] Checking mempool with 0 transactions and 0 inputs
2021-10-25T14:09:48.604368Z [test] [validationinterface.cpp:226] [BlockConnected] Enqueuing BlockConnected: block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f block height=0
2021-10-25T14:09:48.604401Z [test] [validationinterface.cpp:199] [UpdatedBlockTip] Enqueuing UpdatedBlockTip:Segmentation fault (core dumped)
make[3]: *** [Makefile:18453: wallet/test/psbt_wallet_tests.cpp.test] Error 1
``` | https://github.com/bitcoin/bitcoin/issues/23368 | https://github.com/bitcoin/bitcoin/pull/23403 | 3fc3641043be31e65e43d9f7bcb2c37a8a19760e | 5adc5c02800f00d1e6e8812a2b0559b1800e82e9 | 2021-10-27T08:05:23Z | c++ | 2021-11-01T13:24:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,321 | ["src/wallet/wallet.cpp"] | bitcoind segfault's while loading tr descriptor on regtest v22.0 |
Bitcoin v22.0, tested on both self compiled and official release
First of all, this happens on **regtest** only.
How to reproduce:
- run regtest instance of btc
```
$ bitcoin-cli -named createwallet wallet_name=wallet descriptors=true blank=true
$ cat regtest-descriptors.txt
[
{
"desc": "tr([e4445899/49'/1'/0']tprv8ZgxMBicQKsPd8jCeBWsYLEoWxbVgzJDatJ7XkwQ6G3uF4FsHuaziHQ5JZAW4K515nj6kVVwPaNWZSMEcR7aFCwL4tQqTcaoprMKTTtm6Zg/1/*)#mr3llm7f",
"timestamp": 1634652324,
"active": true,
"internal": true,
"range": [
0,
999
],
"next": 0
}
]
$ bitcoin-cli importdescriptors "$(cat regtest-descriptors.txt)"
```
gdb log:
```
Starting program: /usr/local/bin/bitcoind > debug.log
warning: Error disabling address space randomization: Operation not permitted
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7f111c182700 (LWP 2672)]
[New Thread 0x7f111b981700 (LWP 2673)]
[New Thread 0x7f111b180700 (LWP 2674)]
[New Thread 0x7f111a97f700 (LWP 2675)]
[New Thread 0x7f111a17e700 (LWP 2676)]
[New Thread 0x7f111997d700 (LWP 2677)]
[New Thread 0x7f111917c700 (LWP 2678)]
[New Thread 0x7f111897b700 (LWP 2679)]
[New Thread 0x7f10fbfff700 (LWP 2680)]
[New Thread 0x7f10fb7fe700 (LWP 2681)]
[New Thread 0x7f10faffd700 (LWP 2682)]
[New Thread 0x7f10fa7fc700 (LWP 2683)]
[New Thread 0x7f10f9ffb700 (LWP 2684)]
[New Thread 0x7f10f96be700 (LWP 2685)]
[Thread 0x7f10f96be700 (LWP 2685) exited]
[New Thread 0x7f10f8ebd700 (LWP 2686)]
[New Thread 0x7f10dffff700 (LWP 2687)]
[New Thread 0x7f10df7fe700 (LWP 2688)]
[Thread 0x7f10dffff700 (LWP 2687) exited]
[New Thread 0x7f10deffd700 (LWP 2689)]
[New Thread 0x7f10de7fc700 (LWP 2690)]
Thread 13 "b-httpworker.2" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f10fa7fc700 (LWP 2683)]
CWallet::KeypoolCountExternalKeys (this=0x7f10e0024040) at wallet/wallet.cpp:2104
2104 wallet/wallet.cpp: No such file or directory.
#0 CWallet::KeypoolCountExternalKeys (this=0x7f10e0024040) at wallet/wallet.cpp:2104
#1 0x0000563a086e76a3 in <lambda(const RPCHelpMan&, const JSONRPCRequest&)>::operator()(const JSONRPCRequest &, const RPCHelpMan &) (request=..., self=..., __closure=<optimized out>)
at /usr/include/c++/8/bits/shared_ptr_base.h:1018
#2 0x0000563a086e8464 in std::_Function_handler<UniValue(const RPCHelpMan&, const JSONRPCRequest&), getwalletinfo()::<lambda(const RPCHelpMan&, const JSONRPCRequest&)> >::_M_invoke(const std::_Any_data &, const RPCHelpMan &, const JSONRPCRequest &) (__functor=..., __args#0=..., __args#1=...) at /usr/include/c++/8/bits/std_function.h:88
#3 0x0000563a0880a352 in std::function<UniValue (RPCHelpMan const&, JSONRPCRequest const&)>::operator()(RPCHelpMan const&, JSONRPCRequest const&) const (__args#1=..., __args#0=...,
this=0x7f10fa7fa700) at /usr/include/c++/8/bits/std_function.h:682
#4 RPCHelpMan::HandleRequest (this=this@entry=0x7f10fa7fa6e0, request=...) at rpc/util.cpp:575
#5 0x0000563a084ecf4e in CRPCCommand::CRPCCommand(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, RPCHelpMan (*)())::{lambda(JSONRPCRequest const&, UniValue&, bool)#1}::operator()(JSONRPCRequest const&, UniValue&, bool) const (__closure=<optimized out>, request=..., result=...) at ./rpc/server.h:110
#6 0x0000563a086726f8 in std::function<bool (JSONRPCRequest const&, UniValue&, bool)>::operator()(JSONRPCRequest const&, UniValue&, bool) const (__args#2=<optimized out>, __args#1=...,
__args#0=..., this=<optimized out>) at /usr/include/c++/8/bits/std_function.h:682
#7 wallet::(anonymous namespace)::WalletClientImpl::<lambda(const JSONRPCRequest&, UniValue&, bool)>::operator()(const JSONRPCRequest &, UniValue &, bool) const (
__closure=0x563a0a0ed950, request=..., result=..., last_handler=<optimized out>) at wallet/interfaces.cpp:516
#8 0x0000563a0846fdf3 in std::function<bool (JSONRPCRequest const&, UniValue&, bool)>::operator()(JSONRPCRequest const&, UniValue&, bool) const (__args#2=<optimized out>, __args#1=...,
__args#0=..., this=<optimized out>) at /usr/include/c++/8/bits/std_function.h:682
#9 node::(anonymous namespace)::RpcHandlerImpl::<lambda(const JSONRPCRequest&, UniValue&, bool)>::operator() (last_handler=true, result=..., request=..., __closure=<optimized out>)
at node/interfaces.cpp:397
#10 std::_Function_handler<bool(const JSONRPCRequest&, UniValue&, bool), node::(anonymous namespace)::RpcHandlerImpl::RpcHandlerImpl(const CRPCCommand&)::<lambda(const JSONRPCRequest&, UniValue&, bool)> >::_M_invoke(const std::_Any_data &, const JSONRPCRequest &, UniValue &, bool &&) (__functor=..., __args#0=..., __args#1=..., __args#2=<optimized out>)
at /usr/include/c++/8/bits/std_function.h:282
#11 0x0000563a08570a1e in std::function<bool (JSONRPCRequest const&, UniValue&, bool)>::operator()(JSONRPCRequest const&, UniValue&, bool) const (__args#2=<optimized out>, __args#1=...,
__args#0=..., this=0x563a0a0ed9e8) at /usr/include/c++/8/bits/std_function.h:682
#12 ExecuteCommand (command=..., request=..., result=..., last_handler=<optimized out>) at rpc/server.cpp:480
#13 0x0000563a08571408 in ExecuteCommands (commands=std::vector of length 1, capacity 1 = {...}, request=..., result=...) at /usr/include/c++/8/bits/stl_iterator.h:844
#14 0x0000563a085718e8 in CRPCTable::execute (this=0x563a08c35260 <tableRPC>, request=...) at rpc/server.cpp:464
#15 0x0000563a08630c04 in HTTPReq_JSONRPC (context=..., req=0x7f10f00022f0) at httprpc.cpp:202
#16 0x0000563a08634b99 in std::function<bool (HTTPRequest*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)>::operator()(HTTPRequest*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const (__args#1="", __args#0=<optimized out>, this=0x7f10f0001060) at /usr/include/c++/8/bits/std_function.h:682
#17 HTTPWorkItem::operator() (this=0x7f10f0001030) at httpserver.cpp:49
#18 WorkQueue<HTTPClosure>::Run (this=0x563a0a0de5e0) at httpserver.cpp:107
#19 HTTPWorkQueueRun (queue=0x563a0a0de5e0, worker_num=<optimized out>) at httpserver.cpp:335
#20 0x00007f111ea90b2f in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#21 0x00007f111f1a9fa3 in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0
#22 0x00007f111e7704cf in clone () from /lib/x86_64-linux-gnu/libc.so.6
```
full debug log https://pastebin.com/9nz6xi5V | https://github.com/bitcoin/bitcoin/issues/23321 | https://github.com/bitcoin/bitcoin/pull/23333 | 58275db3717eb594b3eda0465aa9724506252e4d | 5bb03fba049b218cd412847b9559d57b686f3cc7 | 2021-10-20T09:19:57Z | c++ | 2021-10-22T12:35:35Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,297 | ["configure.ac", "depends/Makefile", "depends/config.site.in", "depends/packages/packages.mk", "depends/packages/systemtap.mk", "depends/patches/systemtap/remove_SDT_ASM_SECTION_AUTOGROUP_SUPPORT_check.patch", "doc/dependencies.md"] | tracing: include tracepoints in GUIX builds | There has been light conceptual agreement on including the USDT based tracepoints in Bitcoin Core release builds. This, for example, enables user to hook into production deployments, if they need to. Binaries don't have to be switched out. This is possible because we don't do [expensive computations](https://github.com/bitcoin/bitcoin/blob/master/doc/tracing.md#no-expensive-computations-for-tracepoints) only for the tracepoints and the tracepoints are NOPs when not used.
There is a slight chance that the GUIX build on the current master already includes the tracepoints. I have not done an GUIX build on a branch with the tracepoints merged yet. This can be tested on a `bitcoind` binary using one of the methods mentioned in the [tracing documentation section "Listing avaliable tracepoints"](https://github.com/bitcoin/bitcoin/blob/master/doc/tracing.md#listing-available-tracepoints).
If not present, making the `systemtap` headers (`sys/sdt.h`) available during the GUIX build should build `bitcoind` with the tracepoints.
| https://github.com/bitcoin/bitcoin/issues/23297 | https://github.com/bitcoin/bitcoin/pull/23724 | 2e01b6986099715afa40ed6464da4b321b630e9c | 542e405a8517e50bf6687a02af69117931234fde | 2021-10-17T14:42:20Z | c++ | 2022-01-10T02:59:52Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,296 | ["configure.ac", "test/config.ini.in", "test/functional/interface_usdt_net.py", "test/functional/interface_usdt_utxocache.py", "test/functional/interface_usdt_validation.py", "test/functional/test_framework/test_framework.py", "test/functional/test_runner.py"] | tracing: tests for USDT tracepoints | #22006 added the first three USDT based tracepoints to Bitcoin Core. To provide a [semi-stable](https://github.com/bitcoin/bitcoin/blob/master/doc/tracing.md#semi-stable-api) tracepoint API the tracepoints need test coverage. The tracepoints can be tested in the functional tests using the Python wrapper of [BCC](https://github.com/iovisor/bcc).
Before adding more tracepoints, the existing three tracepoints from #22006 should be tested.
Notes:
1. We currently only support the tracepoints on Linux. The tests should be skipped on other operating systems.
2. Hooking into the tracepoints via the Linux kernel requires special privileges. Since kernel version 5.8. (Aug. 2020) the `CAP_BPF` can be used. On older kernel version the overloaded catch-all capability `CAP_SYS_ADMIN` is required. Functional tests shouldn't require `CAP_SYS_ADMIN` as that essentially means running the test suite with `root` privileges.
3. The tests require the BCC Python library. This should be an optional dependency. Tests should be skipped if the dependency isn't present.
The `connect_block` tracepoint can be tested by mining blocks with transactions and checking that the tracepoint passes the correct data. The `net` `inbound_message` and `outbound_message` tracepoints can be tested by checking the traffic between two nodes.
| https://github.com/bitcoin/bitcoin/issues/23296 | https://github.com/bitcoin/bitcoin/pull/24358 | b3072799248fae8fc16f910b642edb9c5acf8bac | 6c9460edaeb6c89692b71f51be7b7ee386f4f5c4 | 2021-10-17T14:23:23Z | c++ | 2022-04-06T11:07:26Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,248 | ["src/util/syscall_sandbox.cpp"] | Bitcoin Core crashes under clang-13 libc++ with "Bad system call (core dumped)" | Steps to reproduce:
* Install fresh Ubuntu Impish
* Compile Bitcoin Core with `export DEBIAN_FRONTEND=noninteractive && apt update && apt install curl wget htop git vim ccache -y && git clone https://github.com/bitcoin/bitcoin.git ./bitcoin-core && cd bitcoin-core && apt install libc++abi-13-dev libc++-13-dev clang llvm gdb build-essential libtool libunwind-dev autotools-dev automake pkg-config bsdmainutils python3-zmq make automake cmake curl g++-multilib libtool binutils-gold bsdmainutils pkg-config python3 patch bison -y && cd depends && make CC=clang-13 CXX="clang++-13 -stdlib=libc++" NO_QT=1 NO_WALLET=1 NO_ZMQ=1 NO_UPNP=1 NO_NATPMP=1 -j $(nproc) && cd .. && ./autogen.sh && CONFIG_SITE="$PWD/depends/x86_64-pc-linux-gnu/share/config.site" ./configure CC=clang-13 CXX="clang++-13 -stdlib=libc++" && make -j $(nproc) src/bitcoind`
* Run gdb: `gdb --args ./src/bitcoind -sandbox=log-and-abort -datadir=/tmp -regtest`
* `run`
```
(gdb) run
Starting program: /bitcoin-core/src/bitcoind -sandbox=log-and-abort -datadir=/tmp -regtest
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Program received signal SIGSYS, Bad system call.
0x00007ffff7c94cbb in mincore () at ../sysdeps/unix/syscall-template.S:117
117 ../sysdeps/unix/syscall-template.S: No such file or directory.
(gdb) bt
#0 0x00007ffff7c94cbb in mincore () at ../sysdeps/unix/syscall-template.S:117
#1 0x00007ffff7ed6a8a in ?? () from /lib/x86_64-linux-gnu/libunwind.so.8
#2 0x00007ffff7ed6562 in ?? () from /lib/x86_64-linux-gnu/libunwind.so.8
#3 0x00007ffff7ed6e1a in ?? () from /lib/x86_64-linux-gnu/libunwind.so.8
#4 0x00007ffff7ed5dd0 in __libunwind_Unwind_RaiseException () from /lib/x86_64-linux-gnu/libunwind.so.8
#5 0x00007ffff7ec1405 in __cxa_throw () from /lib/x86_64-linux-gnu/libc++abi.so.1
#6 0x00007ffff7f3a865 in ?? () from /lib/x86_64-linux-gnu/libc++.so.1
#7 0x00007ffff7f3a82d in std::__1::__basic_string_common<true>::__throw_out_of_range() const () from /lib/x86_64-linux-gnu/libc++.so.1
#8 0x00007ffff7f3aa46 in ?? () from /lib/x86_64-linux-gnu/libc++.so.1
#9 0x00007ffff7f3c124 in std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::at(unsigned long) () from /lib/x86_64-linux-gnu/libc++.so.1
#10 0x0000555555946314 in sanity_test_range_fmt() ()
#11 0x00005555559464ca in glibcxx_sanity_test() ()
#12 0x00005555558c68df in init::SanityChecks() ()
#13 0x00005555555a4e11 in AppInitSanityChecks() ()
#14 0x0000555555590ecf in main ()
```
There are two issues:
* `log-and-abort` doesn't log
* It crashes | https://github.com/bitcoin/bitcoin/issues/23248 | https://github.com/bitcoin/bitcoin/pull/23255 | 1790a8ddacae0d52135f5020894ef1ceef625cf9 | e418a8e675e4dbca9f9c3cf7dd4633aa3c6c196e | 2021-10-11T10:17:51Z | c++ | 2021-10-12T00:47:17Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,206 | ["src/util/syscall_sandbox.cpp"] | node0 stderr ERROR: The syscall "mremap" (syscall number 25) is not allowed by the syscall sandbox in thread "dnsseed". Please report. | To reproduce:
* Install fresh Fedora 34 VM
* Compile Bitcoin Core and run `./test/functional/p2p_dns_seeds.py` | https://github.com/bitcoin/bitcoin/issues/23206 | https://github.com/bitcoin/bitcoin/pull/23208 | a68de12c0ebfaa9a1dd7f347c7a3aff0e07ae9b9 | 0500a22d8c78cb8514bb1b9b3648f163447e46ac | 2021-10-06T11:29:41Z | c++ | 2021-10-07T04:36:02Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,189 | ["src/Makefile.test.include", "src/script/interpreter.h", "src/script/sign.cpp", "src/script/sign.h", "src/wallet/feebumper.cpp", "src/wallet/feebumper.h", "src/wallet/interfaces.cpp", "src/wallet/rpc/spend.cpp", "src/wallet/test/feebumper_tests.cpp", "test/functional/wallet_bumpfee.py"] | RPC: support fee bumping with external inputs | External inputs are currently only supported for initial transaction creation functions. Extend `solving_data` arguments as necessary to support fee bumping wallet transactions with non-wallet inputs.
https://github.com/bitcoin/bitcoin/pull/17211#issuecomment-897653994 | https://github.com/bitcoin/bitcoin/issues/23189 | https://github.com/bitcoin/bitcoin/pull/23202 | e5a83141fa62a80dc7bd24815e49b9e66a10e6f5 | 607d5a46aa0f5053d8643a3e2c31a69bfdeb6e9f | 2021-10-05T13:44:26Z | c++ | 2022-08-22T09:12:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,187 | ["src/wallet/coincontrol.h", "src/wallet/rpc/spend.cpp", "src/wallet/spend.cpp", "src/wallet/test/spend_tests.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h", "test/functional/rpc_fundrawtransaction.py", "test/functional/rpc_psbt.py", "test/functional/wallet_send.py"] | RPC: Allow user to supply weight of external input | This would allow wallet operations like funding transactions with smart contract-based inputs such as LN, or any input the Core wallet doesn't know how to sign for.
https://github.com/bitcoin/bitcoin/pull/17211#issuecomment-933674310 | https://github.com/bitcoin/bitcoin/issues/23187 | https://github.com/bitcoin/bitcoin/pull/23201 | 792d0d8d512cf8ddca200317b74ce550c1a1a428 | b94d0c7af11bd91dad4f180ce2a2ffa09e4b5668 | 2021-10-05T13:39:37Z | c++ | 2022-01-25T16:51:05Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,167 | ["src/test/checkqueue_tests.cpp"] | lock contentions in checkqueue_tests after #22904 | Tracking issue for the follow up comments in #22904. It seems that PR has introduced lock contentions, and/or the `checkqueue_tests` are now behaving very poorly, with long runtimes and generating GBs of log output in some cases. See comments starting here: https://github.com/bitcoin/bitcoin/pull/22904#issuecomment-930466935.
cc @ajtowns @theuni @martinus | https://github.com/bitcoin/bitcoin/issues/23167 | https://github.com/bitcoin/bitcoin/pull/23223 | 9e3f7dcaa2f89efff48d299132f4998bf701c264 | 3c4729a515d85e3cfcd66220c849857c712597e4 | 2021-10-04T03:12:34Z | c++ | 2021-11-02T19:54:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,144 | ["src/wallet/spend.cpp", "test/functional/wallet_create_tx.py"] | Plumb "too-long-mempool-chain" to RPC error for send/sendtoaddress | **Is your feature request related to a problem? Please describe.**
If coin selection fails as part of `send` or `sendtoaddress`, the error message returned to the RPC client is `Insufficient funds`, even if the actual cause is due to `too-long-mempool-chain`. This is likely to alarm users unnecessarily, as they will believe this means their funds have permanently vanished rather than being temporarily inaccessible.
**Describe the solution you'd like**
If coin selection fails due to `too-long-mempool-chain`, the `send` and `sendtoaddress` methods should pass that error back to the RPC client, instead of `Insufficient funds`.
**Describe alternatives you've considered**
It would be even nicer from a UX standpoint if the limit on mempool chain length were removed, but AIUI [that's a DoS vector](https://github.com/bitcoin/bitcoin/issues/9752#issuecomment-281464014), so is not going to happen.
**Additional context**
Apparently this is [already done for `sendrawtransaction`](https://github.com/bitcoin/bitcoin/pull/10015#issuecomment-288597075). The discussion in https://github.com/bitcoin/bitcoin/pull/10015 is relevant (it appears that the PR was withdrawn for reasons unrelated to my request).
| https://github.com/bitcoin/bitcoin/issues/23144 | https://github.com/bitcoin/bitcoin/pull/24845 | 483fb8d2165bacafe9c12a829afca248feeeb42f | 381593c906fb54340dbc2377e2ebc6fb37582d08 | 2021-09-30T13:23:19Z | c++ | 2023-03-23T15:53:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,134 | ["contrib/guix/manifest.scm"] | macOS Monterey deleting bitcoin core after updates (M1) | When updating to macOS Monterey the bitcoin core app is deleted from the applications folder. If pinned to the dock you will see a "?" where it was in it's location.
Did not delete wallet or node data. Reinstalling the application works just fine.
| https://github.com/bitcoin/bitcoin/issues/23134 | https://github.com/bitcoin/bitcoin/pull/24573 | e4d61d9759d9cc6a3386c8a59fa3753cabb315a9 | 4bdc990daf2876cb0cdc40b21a845063676defbc | 2021-09-29T12:17:26Z | c++ | 2022-03-16T16:44:47Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,116 | ["test/functional/feature_segwit.py"] | qa: Intermittent failure in `feature_segwit.py --legacy-wallet` | On master (a8bbd4cc819633ec50ed0f763b6a75330ae055fb), native Windows [build](https://api.cirrus-ci.com/v1/task/4854921808838656/logs/functional_tests.log):
```
8/219 - feature_segwit.py --legacy-wallet failed, Duration: 17 s
stdout:
2021-09-28T08:10:35.808000Z TestFramework (INFO): Initializing test directory C:\Users\ContainerAdministrator\AppData\Local\Temp\test_runner_₿_🏃_20210928_080804\feature_segwit_208
2021-09-28T08:10:39.302000Z TestFramework (INFO): Verify sigops are counted in GBT with pre-BIP141 rules before the fork
2021-09-28T08:10:49.277000Z TestFramework (INFO): Verify witness txs are skipped for mining before the fork
2021-09-28T08:10:50.441000Z TestFramework (INFO): Verify unsigned p2sh witness txs without a redeem script are invalid
2021-09-28T08:10:50.488000Z TestFramework (INFO): Verify previous witness txs skipped for mining can now be mined
2021-09-28T08:10:50.535000Z TestFramework (INFO): Verify default node can't accept txs with missing witness
2021-09-28T08:10:50.581000Z TestFramework (INFO): Verify block and transaction serialization rpcs return differing serializations depending on rpc serialization flag
2021-09-28T08:10:50.738000Z TestFramework (INFO): Verify witness txs without witness data are invalid after the fork
2021-09-28T08:10:50.769000Z TestFramework (INFO): Verify default node can now use witness txs
2021-09-28T08:10:50.960000Z TestFramework (INFO): Verify sigops are counted in GBT with BIP141 rules after the fork
2021-09-28T08:10:51.971000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\test_framework.py", line 131, in main
self.run_test()
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\feature_segwit.py", line 239, in run_test
assert tmpl['transactions'][0]['sigops'] == 8
AssertionError
``` | https://github.com/bitcoin/bitcoin/issues/23116 | https://github.com/bitcoin/bitcoin/pull/23124 | ba1a82e6083f99cb0ab17235926b762179b4df25 | d648bbb0a7909aed953b6f7907690134606a033a | 2021-09-28T08:17:48Z | c++ | 2021-09-29T11:36:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,111 | ["contrib/devtools/symbol-check.py", "contrib/guix/libexec/build.sh"] | bitcoin-22.0-powerpc64le-linux-gnu tarball does not execute | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
Describe the issue
I download the powerpc64le tarball, extract it and run bitcoind the same as I do with x86 and it doesnt run.
What behavior did you expect?
I expected it to run.
What was the actual behavior (provide screenshots if the issue is GUI-related)?
root@acde684805fd:~# ls
bitcoin-22.0-powerpc64le-linux-gnu.tar.gz
root@acde684805fd:~# tar -xzvf bitcoin-22.0-powerpc64le-linux-gnu.tar.gz -C /usr/local --strip-components=1 --exclude=*-qt
bitcoin-22.0/README.md
bitcoin-22.0/bin/
bitcoin-22.0/bin/bitcoin-cli
bitcoin-22.0/bin/bitcoin-tx
bitcoin-22.0/bin/bitcoin-util
bitcoin-22.0/bin/bitcoin-wallet
bitcoin-22.0/bin/bitcoind
bitcoin-22.0/bin/test_bitcoin
bitcoin-22.0/include/
bitcoin-22.0/include/bitcoinconsensus.h
bitcoin-22.0/lib/
bitcoin-22.0/lib/libbitcoinconsensus.so
bitcoin-22.0/lib/libbitcoinconsensus.so.0
bitcoin-22.0/lib/libbitcoinconsensus.so.0.0.0
bitcoin-22.0/share/
bitcoin-22.0/share/man/
bitcoin-22.0/share/man/man1/
bitcoin-22.0/share/man/man1/bitcoin-cli.1
bitcoin-22.0/share/man/man1/bitcoin-qt.1
bitcoin-22.0/share/man/man1/bitcoin-tx.1
bitcoin-22.0/share/man/man1/bitcoin-util.1
bitcoin-22.0/share/man/man1/bitcoin-wallet.1
bitcoin-22.0/share/man/man1/bitcoind.1
root@acde684805fd:~# which bitcoind
/usr/local/bin/bitcoind
root@acde684805fd:~# bitcoind
bash: /usr/local/bin/bitcoind: No such file or directory <-------------- ERROR !!
root@acde684805fd:~# which bitcoin-cli
/usr/local/bin/bitcoin-cli
root@acde684805fd:~# bitcoin-cli getnetworkinfo
bash: /usr/local/bin/bitcoin-cli: No such file or directory <--------------- ERROR !!
root@acde684805fd:~#
What linux version ?
root@acde684805fd:~# uname -a
Linux acde684805fd 4.19.0-17-powerpc64le #1 SMP Debian 4.19.194-3 (2021-07-18) ppc64le GNU/Linux
What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)?
https://bitcoincore.org/bin/bitcoin-core-22.0/bitcoin-22.0-powerpc64le-linux-gnu.tar.gz
What type of machine are you observing the error on (OS/CPU and disk type)?
Headless Server running Debian Buster, 16 CPUs, NVMe Storage & too much RAM [ Talos™ II Secure Workstation by Raptor Computing Systems ]
GUI-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell?
GUI ? ? ? Nah . . .
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/23111 | https://github.com/bitcoin/bitcoin/pull/23148 | da13c7b18afca274aedddc64e211241becc4b38e | 71a85fbd09b5a450edc53a8ba4131f32e7136ca7 | 2021-09-27T18:25:07Z | c++ | 2021-10-13T13:01:34Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,107 | [".cirrus.yml"] | ci: Windows build fails intermittently when downloading (Failed to download from mirror set) | It seems that sometimes a download will fail, but succeeds on the retry, however the full build will still be marked as failed:
https://cirrus-ci.com/task/4800755426131968?logs=build#L31
```
A suitable version of powershell-core was not found (required v7.1.0). Downloading portable powershell-core v7.1.0...
Downloading powershell-core...
https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/PowerShell-7.1.0-win-x86.zip -> C:\Users\ContainerAdministrator\AppData\Local\Temp\vcpkg\downloads\PowerShell-7.1.0-win-x86.zip
Failed to download from mirror set:
https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/PowerShell-7.1.0-win-x86.zip: WinHttpReceiveResponse() failed: 12030
C:\Users\ContainerAdministrator\AppData\Local\Temp\vcpkg\scripts\buildsystems\msbuild\vcpkg.targets(94,5): error MSB3073: The command ""C:\Users\ContainerAdministrator\AppData\Local\Temp\vcpkg\scripts\buildsystems\msbuild\..\..\..\vcpkg.exe" install --x-wait-for-lock --triplet "x64-windows-static" --vcpkg-root "C:\Users\ContainerAdministrator\AppData\Local\Temp\vcpkg\scripts\buildsystems\msbuild\..\..\..\\" "--x-manifest-root=C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\\" "--x-install-root=C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\vcpkg_installed\\" " exited with code 1. [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\libbitcoinconsensus\libbitcoinconsensus.vcxproj]
Waiting to take filesystem lock on C:\Users\ContainerAdministrator\AppData\Local\Temp\vcpkg\.vcpkg-root...
C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc
Installing vcpkg dependencies to C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\vcpkg_installed\
"C:\Users\ContainerAdministrator\AppData\Local\Temp\vcpkg\scripts\buildsystems\msbuild\..\..\..\vcpkg.exe" install --x-wait-for-lock --triplet "x64-windows-static" --vcpkg-root "C:\Users\ContainerAdministrator\AppData\Local\Temp\vcpkg\scripts\buildsystems\msbuild\..\..\..\\" "--x-manifest-root=C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\\" "--x-install-root=C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\vcpkg_installed\\"
Detecting compiler hash for triplet x64-windows-static...
A suitable version of powershell-core was not found (required v7.1.0). Downloading portable powershell-core v7.1.0...
Downloading powershell-core...
https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/PowerShell-7.1.0-win-x86.zip -> C:\Users\ContainerAdministrator\AppData\Local\Temp\vcpkg\downloads\PowerShell-7.1.0-win-x86.zip
Extracting powershell-core... | https://github.com/bitcoin/bitcoin/issues/23107 | https://github.com/bitcoin/bitcoin/pull/23215 | bdbefdcd5cce6d95896d7fcd25df49bfe2984af5 | 04437ee721e66a7b76bef5ec2f88dd1efcd03b84 | 2021-09-27T13:22:21Z | c++ | 2021-10-23T01:42:53Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,101 | ["src/test/validation_chainstate_tests.cpp"] | compiler warning on building src/test/test_bitcoin-validation_chainstate_tests.o | **Is your feature request related to a problem? Please describe.**
Warning on building using g++ 8.3.
```
1 In file included from ./txdb.h:11,
2 from ./validation.h:26,
3 from ./test/util/chainstate.h:13,
4 from test/validation_chainstate_tests.cpp:11:
5 ./chain.h: In member function ‘void validation_chainstate_tests::chainstate_update_tip::test_method()’:
6 ./chain.h:422:27: warning: ‘background_cs’ may be used uninitialized in this function [-Wmaybe-uninitialized]
7 return vChain.size() > 0 ? vChain[vChain.size() - 1] : nullptr;
8 ~~~~~~~~~~~^~
9 test/validation_chainstate_tests.cpp:109:18: note: ‘background_cs’ was declared here
10 CChainState* background_cs;
11 ^~~~~~~~~~~~~
12
```
**Describe the solution you'd like**
Able to build without warnings.
**Describe alternatives you've considered**
N/A.
**Additional context**
`cd src/ && make test/test_bitcoin-validation_chainstate_tests.o`
Bisecting this warning, I ended up in revision 673a5bd3377929a0
by @jamesob.
Thank you very much and please excuse the noise.
| https://github.com/bitcoin/bitcoin/issues/23101 | https://github.com/bitcoin/bitcoin/pull/23132 | fbbbc594ad2f57969cd49d116f68547856d51359 | 8df7eee5e1c8ad6b224aa00bcfd7a04a974362c4 | 2021-09-26T17:11:21Z | c++ | 2021-10-12T06:51:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,078 | ["test/functional/feature_asmap.py"] | ci: failure in feature_asmap | Seen in #23074. https://github.com/bitcoin/bitcoin/pull/23074#issuecomment-925995340.
```bash
2021-09-23T14:53:38.217000Z TestFramework (INFO): Initializing test directory /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20210923_145026/feature_asmap_26
2021-09-23T14:53:39.000000Z TestFramework (INFO): Test bitcoind with no -asmap arg passed
2021-09-23T14:53:39.442000Z TestFramework (INFO): Test bitcoind -asmap=<absolute path>
2021-09-23T14:53:40.286000Z TestFramework (INFO): Test bitcoind -asmap=<relative path>
2021-09-23T14:53:40.859000Z TestFramework (INFO): Test bitcoind -asmap (using default map file)
2021-09-23T14:53:41.404000Z TestFramework (INFO): Test bitcoind -asmap= (using default map file)
2021-09-23T14:53:42.007000Z TestFramework (INFO): Test bitcoind -asmap restart with addrman containing new and tried entries
2021-09-23T14:55:03.894000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 131, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_asmap.py", line 124, in run_test
self.test_asmap_interaction_with_addrman_containing_entries()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_asmap.py", line 96, in test_asmap_interaction_with_addrman_containing_entries
self.node.getnodeaddresses() # getnodeaddresses re-runs the addrman checks
File "/usr/lib/python3.6/contextlib.py", line 88, in __exit__
next(self.gen)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_node.py", line 400, in assert_debug_log
self._raise_assertion_error('Expected messages "{}" does not partially match log:\n\n{}\n\n'.format(str(expected_msgs), print_log))
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_node.py", line 166, in _raise_assertion_error
raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected messages "['Addrman checks started: new 2, tried 2, total 4', 'Addrman checks completed successfully']" does not partially match log:
- 2021-09-23T14:53:43.886617Z [http] [httpserver.cpp:237] [http_request_cb] Received a POST request for / from 127.0.0.1:52652
- 2021-09-23T14:53:43.886733Z [httpworker.3] [rpc/request.cpp:174] [parse] ThreadRPCServer method=getnodeaddresses user=__cookie__
- 2021-09-23T14:53:43.886809Z [httpworker.3] [addrman.cpp:770] [ForceCheckAddrman] Addrman checks started: new 3, tried 1, total 4
- 2021-09-23T14:53:43.886870Z [httpworker.3] [addrman.cpp:48] [GetTriedBucket] IP 101.0.0.0 mapped to AS1 belongs to tried bucket 113
- 2021-09-23T14:53:43.886980Z [httpworker.3] [addrman.cpp:850] [ForceCheckAddrman] Addrman checks completed successfully
- 2021-09-23T14:53:43.886991Z [httpworker.3] [addrman.cpp:770] [ForceCheckAddrman] Addrman checks started: new 3, tried 1, total 4
- 2021-09-23T14:53:43.887016Z [httpworker.3] [addrman.cpp:48] [GetTriedBucket] IP 101.0.0.0 mapped to AS1 belongs to tried bucket 113
- 2021-09-23T14:53:43.887102Z [httpworker.3] [addrman.cpp:850] [ForceCheckAddrman] Addrman checks completed successfully
- 2021-09-23T14:54:28.662861Z [scheduler] [net.h:865] [StartExtraBlockRelayPeers] net: enabling extra block-relay-only peers
- 2021-09-23T14:54:43.321822Z [scheduler] [random.cpp:523] [SeedPeriodic] Feeding 33048 bytes of dynamic environment data into RNG
-
``` | https://github.com/bitcoin/bitcoin/issues/23078 | https://github.com/bitcoin/bitcoin/pull/23084 | 09cb5ec6c8b4468ee3e8c2b3e1a9075907e5c84d | ba3f0b2c48172ef94e9e55ad6a1df789391f59c4 | 2021-09-24T00:16:46Z | c++ | 2021-09-27T07:20:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,073 | ["build_msvc/bitcoin_config.h.in", "build_msvc/msvc-autogen.py", "doc/release-process.md"] | Auto-generate MSVC version information | Right now, bumping the version involves updating the version in two places:
- `configure.ac`
- `build_msvc/bitcoin_config.h` (in multiple places—see for example commit f277b1782c5aae0fab83e3d678189c150ae0f263)
I think it should be doable to parse the information from `configure.ac` in `msvc-autogen.py`, so that this is no longer something error-prone that has to be done manually.
If you do this, also update [the release process](https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md).
#### Useful skills:
Python, MSVC
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/23073 | https://github.com/bitcoin/bitcoin/pull/23198 | 41a1b5f58ca59d2177dcadf834efd187fa3fba52 | 2efc8c0999a4b99cfe3076f7312806e83e778261 | 2021-09-23T09:07:43Z | c++ | 2021-11-15T14:11:44Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,071 | ["src/validation.cpp"] | BCLog::Bench Callbacks timing nothing of value | **Expected behavior**
LogPrint BCLog::BENCH should print useful timing metrics
**Actual behavior**
`Callbacks` bench logs the execution time of `LogPrint(BCLog::BENCH, " - Index writing:...` function call
```
int64_t nTime5 = GetTimeMicros(); nTimeIndex += nTime5 - nTime4;
LogPrint(BCLog::BENCH, " - Index writing: %.2fms [%.2fs (%.2fms/blk)]\n", MILLI * (nTime5 - nTime4), nTimeIndex * MICRO, nTimeIndex * MILLI / nBlocksTotal);
int64_t nTime6 = GetTimeMicros(); nTimeCallbacks += nTime6 - nTime5;
LogPrint(BCLog::BENCH, " - Callbacks: %.2fms [%.2fs (%.2fms/blk)]\n", MILLI * (nTime6 - nTime5), nTimeCallbacks * MICRO, nTimeCallbacks * MILLI / nBlocksTotal);
```
https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L1873
Callbacks bench was added in this commit: https://github.com/bitcoin/bitcoin/commit/d70bc52ee31b8c4c87ee011625e7031c2dc89c0c
Since then functions between ` Index writing:` and `Callbacks:` were moved.
Now Callbacks bench isn't recording anything of value.
Appears to be timing the execution of the `Index writing` LogPrintf along with some basic computations (nTime6 - nTime5)
**To reproduce**
Start a node with initial block download
```
bitcoind -debug=bench | grep Callbacks:
```
You'll see the times recorded are within a small bounded range.
On my system it was between 30-50 microseconds
**System information**
Self-complied tag v22.0 on Arch Linux x86s AMD Ryzen 5 with SSD and 8 gigs ram
I will open a PR to remove this code
| https://github.com/bitcoin/bitcoin/issues/23071 | https://github.com/bitcoin/bitcoin/pull/23072 | cdce149050c9e2db9276972d3512e0db0abd06af | 95b16e70a8b7ebd103e0ada62a7449184fc9200c | 2021-09-23T08:06:38Z | c++ | 2021-09-23T13:07:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,964 | ["src/bitcoin-chainstate.cpp", "src/init.cpp", "src/node/blockstorage.cpp", "src/node/blockstorage.h", "src/node/chainstate.cpp", "src/test/util/setup_common.cpp", "src/test/validation_chainstate_tests.cpp", "src/test/validation_chainstatemanager_tests.cpp", "src/validation.cpp", "src/validation.h"] | bug: Reindex started via `ThreadSafeQuestion` will always fail | <!-- Describe the issue -->
When our chainstate activation sequence fails and we're running the GUI, we ask the user via a question box whether or not they'd like to re-run the sequence with `fReindex = true`. Fun fact: despite the fact that this sequence is wrapped in a while loop, we only run it twice at most.
https://github.com/bitcoin/bitcoin/blob/7ecb309c4ed1bb9ae6b9a12cbb4f083328edc125/src/init.cpp#L1539-L1556
If they answer yes, the sequence will always fail, because a chainstate will have already been initialized in the original run and `InitializeChainstate` will throw a `std::logic_error`:
https://github.com/bitcoin/bitcoin/blob/7ecb309c4ed1bb9ae6b9a12cbb4f083328edc125/src/validation.cpp#L4573-L4594
This always reproduces. To reproduce:
```
gdb ./src/qt/bitcoin-qt
(gdb) b InitializeChainstate
(gdb) # add breakpoint for the "if (!fLoaded && !ShutdownRequested()) {" line
(gdb) r # should stop at the breakpoint for InitializeChainstate
(gdb) c # to advance to the breakpoint for the "if (!fLoaded && !ShutdownRequested()) {" line
(gdb) set fLoaded=false
(gdb) c # should stop at the breakpoint for InitializeChainstate
(gdb) n # step through InitializeChainstate to see that it throws
```
We expect the re-run of the chainstate activation sequence to not always fail.
| https://github.com/bitcoin/bitcoin/issues/22964 | https://github.com/bitcoin/bitcoin/pull/22564 | 9446de160f37ccf9d639960f38bc1e4337b0c5f7 | b51e60f91472da5216116626afc032acd5616e85 | 2021-09-13T20:24:27Z | c++ | 2022-04-28T10:14:06Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,889 | [".cirrus.yml", "ci/test/00_setup_env_i686_multiprocess.sh", "src/bench/addrman.cpp"] | Compiling fails on 32-bit systems | Since #20233 compiling with clang 10.0 fails:
```
bench/addrman.cpp:113:32: error: non-constant-expression cannot be narrowed from type 'unsigned long long' to 'size_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]
const size_t addrman_count{bench.epochs() * bench.epochIterations()};
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
bench/addrman.cpp:113:32: note: insert an explicit cast to silence this issue
const size_t addrman_count{bench.epochs() * bench.epochIterations()};
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
static_cast<size_t>( )
1 error generated.
make[2]: *** [Makefile:12508: bench/bench_bitcoin-addrman.o] Error 1
``` | https://github.com/bitcoin/bitcoin/issues/22889 | https://github.com/bitcoin/bitcoin/pull/22923 | fac71810914497611c7e23c02ef035098e478359 | 020c2b7609d037fe4d1bb321419d8d455716d6fb | 2021-09-04T13:31:55Z | c++ | 2021-09-09T13:52:26Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,874 | ["src/qt/psbtoperationsdialog.cpp", "src/wallet/rpcwallet.cpp", "test/functional/rpc_psbt.py"] | bitcoin-cli walletprocesspsbt does not trigger passphrase warning | Bitcoin Core v0.21.1
`bitcoin-cli walletprocesspsbt` does not trigger a `wallet locked please enter passphrase` warning when using a wallet which holds private keys. To be clear I am experiencing this behavior when using the `default` wallet created by core.
The expected behavior would be to remind the user they are dealing with an encrypted wallet, since `walletprocesspsbt` attempts to access private keys to sign the psbt. It would be useful if a warning were present in the rpc response to remind the user they are dealing with an encrypted wallet. | https://github.com/bitcoin/bitcoin/issues/22874 | https://github.com/bitcoin/bitcoin/pull/23106 | a8bbd4cc819633ec50ed0f763b6a75330ae055fb | a9d0cec4991ab057557af9992daa4c8146a9b9d0 | 2021-09-03T02:55:36Z | c++ | 2021-09-28T07:49:44Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,873 | ["src/bitcoin-cli.cpp"] | bitcoin-cli -netinfo displays verison number of bitcoin-cli, not the running bitcoind | Running bitcoind version `Bitcoin Core version v22.99.0-952c37a31c39`
when I used `bitcoin-cli -netinfo` to check my network stats it displays
```
Bitcoin Core v22.0rc3 - 70016/Satoshi:22.99.0/
```
which is the version of my installed bitcoin-cli, not the running bitcoind | https://github.com/bitcoin/bitcoin/issues/22873 | https://github.com/bitcoin/bitcoin/pull/22894 | 78d39f843877963249847ccdadb8e39a0d2e6781 | 4bd56bc291a94a6c85f43b80da67b34d4549db12 | 2021-09-03T02:34:38Z | c++ | 2021-09-06T07:16:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,737 | ["contrib/verify-commits/allow-revsig-commits"] | verify commits failed | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
**Expected behavior**
PASS Verified
<!--- What behavior did you expect? -->
**Actual behavior**
Failed.
Some console printed as followed:
No parent of 803ef70fd9f65ef800567ff9456fac525bc3e3c2 was signed with a trusted key!
Parents are: (NOTHING)
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
**To reproduce**
step 1: cd path/to/bitcoin
step 2: gpg --keyserver hkps://keys.openpgp.org --recv-keys $(<contrib/verify-commits/trusted-keys)
console log is :
gpg: key 410108112E7EA81F: no user ID
gpg: key 944D35F9AC3DB76A: "Michael Ford (bitcoin-otc) <[email protected]>" not changed
gpg: key D300116E1C875A3D: "MeshCollider <[email protected]>" not changed
gpg: key 3648A882F4316B9B: "Marco Falke <[email protected]>" not changed
gpg: key 29D4BCB6416F53EC: "Jonas Schnelli <[email protected]>" not changed
gpg: key 860FEB804E669320: "Pieter Wuille <[email protected]>" not changed
gpg: key 74810B012346C9A6: "Wladimir J. van der Laan <[email protected]>" not changed
gpg: Total number processed: 7
gpg: unchanged: 6
step 3: git fetch origin && ./contrib/verify-commits/verify-commits.py origin/master && git checkout origin/master
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
**System information**
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
HEAD commit id: bb9f76a71
OS: MacOS Big Sur
Python:
Python 3.6.6 (v3.6.6:4cf1f54eb7, Jun 26 2018, 19:50:54)
[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.57)] on darwin
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- GUI-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/22737 | https://github.com/bitcoin/bitcoin/pull/22768 | 9d2895157ec0ff6e356f40c5fe84d3007fc991c1 | a85442f62bf157b07849accd495c55c73535dc73 | 2021-08-18T15:15:35Z | c++ | 2021-11-14T14:25:39Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,719 | ["depends/funcs.mk", "depends/packages/qt.mk"] | depends: `$(package)_*_env` settings only apply to the first command | For example, `$(package)_config_env` is prepended to `$(package)_config_cmds`, which means that if `$(package)_config_cmds` contains multiple commands chained by `&&`, only the first command would have its environment modified according to `$(package)_config_env`.
https://github.com/bitcoin/bitcoin/blob/b935abb9eb2eeaceb5621e110e1889c2ce1b7734/depends/funcs.mk#L212
Since `$(package)_*_env` settings contain crucial env vars such as `PATH` or `PKG_CONFIG_PATH`, its omission in subsequent commands is likely a bug:
https://github.com/bitcoin/bitcoin/blob/b935abb9eb2eeaceb5621e110e1889c2ce1b7734/depends/funcs.mk#L137-L142
This has lead to problems such as: https://github.com/bitcoin/bitcoin/pull/16883#issuecomment-683817472
A test-able demo of this problem: https://github.com/dongcarl/bitcoin/commit/e233c6d1e96ed35489c6be37f07bd01546083b9e | https://github.com/bitcoin/bitcoin/issues/22719 | https://github.com/bitcoin/bitcoin/pull/24279 | 5126e625cb60329262b364a456c730fd62979e10 | 3eaf7be6ade22c99f3c0000122e49b94de868d74 | 2021-08-16T16:53:47Z | c++ | 2022-12-08T16:41:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,714 | ["test/functional/test_framework/test_framework.py"] | test: wait_until() failure in p2p_permissions.py | Seen in https://cirrus-ci.com/task/6730209715027968:
```bash
Remaining jobs: [p2p_node_network_limited.py, p2p_permissions.py]
Remaining jobs: [p2p_permissions.py]
217/217 - p2p_permissions.py failed, Duration: 2403 s
stdout:
2021-08-16T05:03:11.839000Z TestFramework (INFO): Initializing test directory /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20210816_044948/p2p_permissions_13
2021-08-16T05:43:14.597000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
self.wait_until(lambda: txid in self.nodes[0].getrawmempool())
'''
2021-08-16T05:43:14.598000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 131, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/p2p_permissions.py", line 34, in run_test
self.check_tx_relay()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/p2p_permissions.py", line 127, in check_tx_relay
self.wait_until(lambda: txid in self.nodes[0].getrawmempool())
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 672, in wait_until
return wait_until_helper(test_function, timeout=timeout, timeout_factor=self.options.timeout_factor)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 256, in wait_until_helper
raise AssertionError("Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
self.wait_until(lambda: txid in self.nodes[0].getrawmempool())
''' not true after 2400.0 seconds
2021-08-16T05:43:14.649000Z TestFramework (INFO): Stopping nodes
``` | https://github.com/bitcoin/bitcoin/issues/22714 | https://github.com/bitcoin/bitcoin/pull/22817 | 03cb2b480bd5e35cd6bafbca3ff6adcba52dab8b | 442e32e1179a49db54521244e1672bd208d0ef94 | 2021-08-16T05:58:29Z | c++ | 2021-09-25T06:50:52Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,682 | ["doc/release-notes.md", "src/rpc/blockchain.cpp", "test/functional/mempool_packages.py", "test/functional/rpc_fundrawtransaction.py", "test/functional/rpc_mempool_entry_fee_fields_deprecation.py", "test/functional/test_runner.py"] | properly deprecate mempool entry RPC fee fields | RPCs that return detailed information about mempool entries (e.g. `getmempoolentry` and `getrawmempool(verbose=True)` include the fields `fee`, `modifiedfee`, `descendantfees`, and `ancestorfees` which were marked as "DEPRECATED" and replaced with a `fees` object field in #12240 (since v0.17).
We should remove these fields, but first, properly deprecate them using `-deprecatedrpc`.
#### Useful skills:
- basic understanding of Bitcoin Core RPC interface
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/22682 | https://github.com/bitcoin/bitcoin/pull/22689 | 95fe477fd189ae30e76050b95280086d913e78c2 | 4fd0ce75c59824a9b035a77bfea6df81f0e87a34 | 2021-08-11T12:51:34Z | c++ | 2021-12-07T14:26:06Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,681 | ["contrib/devtools/README.md", "contrib/devtools/gen-manpages.py", "contrib/devtools/gen-manpages.sh", "doc/release-process.md"] | Manual page generation on master broken | I'm not sure if this is related to other version-related issues, but the `-version` output (when building from git) changed from
```
Bitcoin Core version v0.21.2.0-89d148c8c65b3e6b6a8fb8b722efb4b6a7d0a375
```
to
```
Bitcoin Core version v22.0rc2
```
This means that the generated manual pages (using `contrib/devtools/gen-manpages.sh`) now contain the rc number in the embedded version tag. See d3bd5410f64e96d106486643e3d4300a9fb0ee71:
```
+.\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.47.13.
+.TH BITCOIN-CLI "1" "August 2021" "bitcoin-cli v22.0rc2" "User Commands"
```
No big problem, though it is slightly inconvenient. Up until now we didn't have to regenerate the manual pages between the last rc and -final as there is (by how the process is defined) no code difference, so option won't have changed. | https://github.com/bitcoin/bitcoin/issues/22681 | https://github.com/bitcoin/bitcoin/pull/24263 | 2ab4fbe375571fb8f102c35841e6dc9fb670d5b7 | bd6b1d023878178b317e559b97d7695246374bb1 | 2021-08-11T11:44:05Z | c++ | 2022-02-21T14:17:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,670 | ["src/wallet/coinselection.cpp", "src/wallet/spend.cpp", "test/functional/rpc_fundrawtransaction.py"] | [22.0rc2] There are cases where the fee calculation is incorrect | Please read this, thinking that there may be such a possibility.
I fork each version of Bitcoin to make Fujicoin. I am currently testing Fujicoin made from v22.0rc2.
https://github.com/fujicoin/fujicoin
I often create large transactions with more than 350 inputs, but in v22.0, I fail to transfer money due to lack of fee about once every few times and get into a "not in memory pool" state.
This phenomenon sometimes occurred in previous versions. It rarely occurred in v0.21.x, but it seems that the frequency increased in v22.0.
Specific explanation
--------------------
The following image is the dialog at the time of remittance.
The following images show the remittance result and its details.
I made a program with python and calculated fee from raw Tx. In my calculation the fee was 2.57729334.
Therefore, it is correct to be out of memoly pool due to insufficient remittance fee.
In this case, the pre-remittance fee calculation is incorrect.
As you can see from the figure, this phenomenon can be reproduced many times if the wallet state is the same.
Unfortunately, I don't have any more parsing ability, so I can't identify what kind of transaction causes a calculation error.
Fortunately, I've never experienced this with regular size transactions. Transactions that could not be remitted can be canceled, so there is no actual harm.
I think it's pretty difficult to identify this problem, but I think it's very good if it improves.
| https://github.com/bitcoin/bitcoin/issues/22670 | https://github.com/bitcoin/bitcoin/pull/22686 | 11c7d001a9c3b600ee47d5851054e8d5c01a3de1 | 820129aee9fdd0b3f238e9feef60330342d61966 | 2021-08-10T02:37:41Z | c++ | 2021-08-16T03:23:53Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,638 | ["src/test/settings_tests.cpp", "src/util/settings.cpp"] | Bug: ArgsManager::ReadSettingsFile can return false even when it does load settings | Credit to @luke-jr for helping uncovering this bug https://github.com/bitcoin-core/gui/pull/379#discussion_r680408927
This bug has no user-visible effects currently, but combined with PR [bitcoin-core/gui#379](https://github.com/bitcoin-core/gui/pull/379) and a corrupt `settings.json` file that is corrupted specifically by specifying the same JSON keys multiple times, it can cause some dialog text added in that PR to be misleading. This is a basically an impossible-to-hit rube goldberg bug, but is only fixable at the util level not the GUI level, so I'm tracking this outside the GUI repository.
Simplest fix would be to just change `ReadSettingsFile` to call `rw_settings.clear()` on error. It would also be nice to add a unit test for the regression.
Code path that triggers this is:
https://github.com/bitcoin/bitcoin/blob/d67330d11245b11fbdd5e2dd5343ee451186931e/src/util/system.cpp#L548
https://github.com/bitcoin/bitcoin/blob/d67330d11245b11fbdd5e2dd5343ee451186931e/src/util/settings.cpp#L89
https://github.com/bitcoin/bitcoin/blob/d67330d11245b11fbdd5e2dd5343ee451186931e/src/util/settings.cpp#L92 | https://github.com/bitcoin/bitcoin/issues/22638 | https://github.com/bitcoin/bitcoin/pull/27236 | 3d53a85ddfb5dc74514d94cefa4ff4987646c576 | 87af64a1a1c99888ccde5bc830e19a88701a879a | 2021-08-05T19:13:32Z | c++ | 2023-03-11T10:09:47Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,623 | ["src/clientversion.cpp"] | [22.0] build: Version info ignores a tag | When building against a tagged commit (e.g., https://github.com/bitcoin/bitcoin/releases/tag/v22.0rc2) the version info should pull a tag rather a git commit hash.
Compare:
```
$ bin/bitcoind -version
Bitcoin Core version v0.21.0rc2
Copyright (C) 2009-2020 The Bitcoin Core developers
Please contribute if you find Bitcoin Core useful. Visit
<https://bitcoincore.org/> for further information about the software.
The source code is available from <https://github.com/bitcoin/bitcoin>.
This is experimental software.
Distributed under the MIT software license, see the accompanying file COPYING
or <https://opensource.org/licenses/MIT>
```
and
```
$ bin/bitcoind -version
Bitcoin Core version v22.0.0-g873fbc745d037ad43570f81e58334c397bc95477
``` | https://github.com/bitcoin/bitcoin/issues/22623 | https://github.com/bitcoin/bitcoin/pull/22685 | 820129aee9fdd0b3f238e9feef60330342d61966 | 3facf0a8ae99a03f5e2fb709b8d86c47328d363c | 2021-08-04T12:35:48Z | c++ | 2021-08-16T04:17:24Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,615 | ["src/index/base.h", "src/index/txindex.cpp", "src/index/txindex.h", "src/init.cpp", "src/txdb.cpp", "src/txdb.h", "src/validation.cpp", "src/validation.h"] | Remove txindex migration code | The txindex was moved to its own database in #13033. As part of that change, data migration functionality was added, allowing the txindex to be maintained across upgrade without having to rebuild the entire index from scratch:
https://github.com/bitcoin/bitcoin/blob/5cf28d5203a6203355283ea59f071af6a468d239/src/index/txindex.cpp#L75-L90
13033 was included in v0.17, released in October 2018 and EOL in August 2020. Anyone who hasn't upgraded at this point is running unsupported code, and shouldn't have expectations around upgrading their node without having to rebuild the index. We should simplify the code by removing the `MigrateData()` functionality. | https://github.com/bitcoin/bitcoin/issues/22615 | https://github.com/bitcoin/bitcoin/pull/22626 | 698b4b8fac3d76ab9b9cfe08a1f186b7263630a8 | 71bdf0bff1be4df824099d69b03459d6dab5f80c | 2021-08-03T11:10:34Z | c++ | 2021-09-16T17:53:28Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,612 | ["src/util/system.cpp", "test/functional/feature_config_args.py"] | The bitcoind service silently loads the default configuration if the .conf file is specified but not readable | [ Setup ]
Assuming a working bitcoin core setup is present and all paths (data, conf, run) are properly setup as required by the service unit provided here (https://github.com/bitcoin/bitcoin/blob/master/contrib/init/bitcoind.service).
[ Issue ]
If the following statements are true:
- the folder `/etc/bitcoin` has the permissions `0710` and has the owner/group `root:bitcoin`
- the config file has permissions or ownership that make it not accessible to the user running the daemon, for example: `/etc/bitcoin/bitcoin.conf` has the permissions `0640` and has the owner/group `root:root`.
Starting the service will result in an instance using plain defaults without a single warning about the specified config file being inaccessible to it.
[ Expected behavior ]
Startup failure with a clear error message that the provided config file is not readable. I can't think of a situation in which a config file is specified explicitly (in the startup options, as per service unit linked above), but inaccessible, where the fail condition should be to keep booting using defaults instead.
[ Actual behavior ]
The service starts with no warning whatsoever, nor a message logged about it (see debug.log below)
[ Reliability ]
100% reproducible
[ Core version ]
0.21.1
[ OS ]
Ubuntu server 20.04.1
[ Bootstrap Log ]
```2021-08-02T20:54:00Z Bitcoin Core version v0.21.1 (release build)
2021-08-02T20:54:00Z Assuming ancestors of block 0000000000000000000b9d2ec5a352ecba0592946514a92f14319dc2b367fc72 have valid signatures.
2021-08-02T20:54:00Z Setting nMinimumChainWork=00000000000000000000000000000000000000001533efd8d716a517fe2c5008
2021-08-02T20:54:00Z Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
2021-08-02T20:54:00Z Using RdSeed as additional entropy source
2021-08-02T20:54:00Z Using RdRand as an additional entropy source
2021-08-02T20:54:00Z Default data directory /var/lib/bitcoind/.bitcoin
2021-08-02T20:54:00Z Using data directory /var/lib/bitcoind
2021-08-02T20:54:00Z Config file: /etc/bitcoin/bitcoind.conf
2021-08-02T20:54:00Z Command-line arg: conf="/etc/bitcoin/bitcoind.conf"
2021-08-02T20:54:00Z Command-line arg: daemon=""
2021-08-02T20:54:00Z Command-line arg: datadir="/var/lib/bitcoind"
2021-08-02T20:54:00Z Command-line arg: pid="/run/bitcoind/bitcoind.pid"
2021-08-02T20:54:00Z Using at most 125 automatic connections (1024 file descriptors available)
2021-08-02T20:54:00Z Using 16 MiB out of 32/2 requested for signature cache, able to store 524288 elements
2021-08-02T20:54:01Z Using 16 MiB out of 32/2 requested for script execution cache, able to store 524288 elements
2021-08-02T20:54:01Z Script verification uses 7 additional threads
2021-08-02T20:54:01Z scheduler thread start
2021-08-02T20:54:01Z HTTP: creating work queue of depth 16
2021-08-02T20:54:01Z Using random cookie authentication.
2021-08-02T20:54:01Z Generated RPC authentication cookie /var/lib/bitcoind/.cookie
2021-08-02T20:54:01Z HTTP: starting 4 worker threads
2021-08-02T20:54:01Z Using wallet directory /var/lib/bitcoind
2021-08-02T20:54:01Z init message: Verifying wallet(s)...
2021-08-02T20:54:01Z init message: Loading banlist...
2021-08-02T20:54:01Z SetNetworkActive: true
2021-08-02T20:54:01Z Using /16 prefix for IP bucketing
2021-08-02T20:54:01Z Cache configuration:
2021-08-02T20:54:01Z * Using 2.0 MiB for block index database
2021-08-02T20:54:01Z * Using 8.0 MiB for chain state database
2021-08-02T20:54:01Z * Using 440.0 MiB for in-memory UTXO set (plus up to 286.1 MiB of unused mempool space)
2021-08-02T20:54:01Z init message: Loading block index...
2021-08-02T20:54:01Z Switching active chainstate to Chainstate [ibd] @ height -1 (null)
2021-08-02T20:54:01Z Opening LevelDB in /var/lib/bitcoind/blocks/index
2021-08-02T20:54:01Z Opened LevelDB successfully
2021-08-02T20:54:01Z Using obfuscation key for /var/lib/bitcoind/blocks/index: 0000000000000000
2021-08-02T20:54:04Z LoadBlockIndexDB: last block file = 2673
2021-08-02T20:54:04Z LoadBlockIndexDB: last block file info: CBlockFileInfo(blocks=95, size=126973024, heights=693816...693910, time=2021-08-02...2021-08-02)
2021-08-02T20:54:04Z Checking all blk files are present...
2021-08-02T20:54:04Z Opening LevelDB in /var/lib/bitcoind/chainstate
2021-08-02T20:54:04Z Opened LevelDB successfully
2021-08-02T20:54:04Z Using obfuscation key for /var/lib/bitcoind/chainstate: 552509bc3d6a34b5
2021-08-02T20:54:04Z Loaded best chain: hashBestChain=0000000000000000000275f0f28b4c0cc7a7552f78669b2f6ba2b3d9809d065b height=693910 date=2021-08-02T20:24:59Z progress=0.999991
2021-08-02T20:54:04Z init message: Rewinding blocks...
2021-08-02T20:54:04Z FlushStateToDisk: write coins cache to disk (0 coins, 0kB) started
2021-08-02T20:54:04Z FlushStateToDisk: write coins cache to disk (0 coins, 0kB) completed (0.00s)
2021-08-02T20:54:04Z init message: Verifying blocks...
2021-08-02T20:54:04Z Verifying last 6 blocks at level 3
2021-08-02T20:54:04Z [0%]...[16%]...[33%]...[50%]...[66%]...[83%]...[99%]...[DONE].
2021-08-02T20:54:05Z No coin database inconsistencies in last 6 blocks (9363 transactions)
2021-08-02T20:54:05Z block index 4042ms
2021-08-02T20:54:05Z block tree size = 693913
2021-08-02T20:54:05Z nBestHeight = 693910
2021-08-02T20:54:05Z loadblk thread start
2021-08-02T20:54:05Z Bound to [::]:8333
2021-08-02T20:54:05Z torcontrol thread start
2021-08-02T20:54:05Z Bound to 0.0.0.0:8333
2021-08-02T20:54:05Z Bound to 127.0.0.1:8334
2021-08-02T20:54:05Z init message: Loading P2P addresses...
2021-08-02T20:54:05Z Leaving InitialBlockDownload (latching to false)
2021-08-02T20:54:05Z Loaded 65864 addresses from peers.dat 174ms
2021-08-02T20:54:05Z Loaded 2 addresses from "anchors.dat"
2021-08-02T20:54:05Z 2 block-relay-only anchors will be tried for connections.
2021-08-02T20:54:05Z init message: Starting network threads...
2021-08-02T20:54:05Z net thread start
2021-08-02T20:54:05Z addcon thread start
2021-08-02T20:54:05Z dnsseed thread start
2021-08-02T20:54:05Z Waiting 300 seconds before querying DNS seeds.
2021-08-02T20:54:05Z init message: Done loading
2021-08-02T20:54:05Z opencon thread start
2021-08-02T20:54:05Z msghand thread start
2021-08-02T20:54:05Z New outbound peer connected: version: 70016, blocks=693910, peer=0 (block-relay)
2021-08-02T20:54:07Z New outbound peer connected: version: 70015, blocks=693910, peer=1 (block-relay)
2021-08-02T20:54:07Z Imported mempool transactions from disk: 4395 succeeded, 0 failed, 0 expired, 0 already there, 0 waiting for initial broadcast
2021-08-02T20:54:07Z loadblk thread exit
2021-08-02T20:54:07Z New outbound peer connected: version: 70015, blocks=693910, peer=2 (full-relay)
2021-08-02T20:54:13Z New outbound peer connected: version: 70016, blocks=693910, peer=3 (full-relay)
2021-08-02T20:54:13Z New outbound peer connected: version: 70016, blocks=693910, peer=4 (full-relay)
2021-08-02T20:54:16Z P2P peers available. Skipped DNS seeding.
2021-08-02T20:54:16Z dnsseed thread exit
2021-08-02T20:54:20Z New outbound peer connected: version: 70015, blocks=693910, peer=5 (full-relay)```
| https://github.com/bitcoin/bitcoin/issues/22612 | https://github.com/bitcoin/bitcoin/pull/22622 | 489beb39842fd49393823953940510c28b169c95 | f6f7a12462b381945b1cb9bcb94b129d8fb7e289 | 2021-08-02T21:09:58Z | c++ | 2021-08-23T10:58:01Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,605 | ["contrib/linearize/linearize-data.py", "contrib/signet/miner", "contrib/zmq/zmq_sub.py", "share/rpcauth/rpcauth.py", "src/test/serfloat_tests.cpp", "test/functional/test_framework/messages.py", "test/util/bitcoin-util-test.py"] | use consistent bytes <-> hex-string conversions in functional test framework | <!-- Needs the label "good first issue" assigned manually before or after opening -->
<!-- A good first issue is an uncontroversial issue, that has a relatively unique and obvious solution -->
<!-- Motivate the issue and explain the solution briefly -->
Right now in the functional test framework, conversions from hex-string to bytes and vice-versa are done in different ways:
- convert `bytes_obj` to hex-string: binascii.hexlify(bytes_obj), bytes_obj.hex()
- convert `hex_str` to bytes object: binascii.unhexlify(hex_str), binascii.a2b_hex(hex_str), bytes.fromhex(hex_str)
For consistency reasons, only the built-in way of using `bytes` (class) methods should be used (see also MarcoFalke's comment https://github.com/bitcoin/bitcoin/pull/22593#issuecomment-890918620):
- bytes.fromhex() (https://docs.python.org/3.7/library/stdtypes.html#bytes.fromhex)
- bytes.hex() (https://docs.python.org/3.7/library/stdtypes.html#bytes.hex)
This seems to be the most natural and modern way to do it, without a need to import any libraries, and the other ones using binascii should be replaced by those. As an example, see PR #22593 which replaced a helper `hex_str_to_bytes` (which in turn used binascii.unhexlify) with `bytes.fromhex()`. For quickly identifying instances the command `git grep binascii` can be used, though one would need to check that there is maybe uses of binascii that are still legit.
#### Useful skills:
- Python 3 basic skills, knowledge of fundamental data types string and bytes
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/22605 | https://github.com/bitcoin/bitcoin/pull/22633 | 4fc15d15667d9d9c4fb5515ce73c05b4596298ec | f5a406f003a060325128db47552089b3254044e3 | 2021-08-02T14:53:48Z | c++ | 2021-08-21T14:29:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,596 | ["src/validation.cpp"] | Coin database inconsistencies found |
**Describe the issue**
Core can not check past blocks correctly
**What behavior did you expect?**
Expected setting checkblocks=0, checklevel=6, and assumevalid=0 to result in verification that the chain is valid. And that it would take nigh upon forever. It doesn’t. It poops out in about 12 hours.
**What was the actual behavior**
Debug.log highlights:
(Note: Block height at time of message was 693086)
init message: Verifying blocks…
Verifying last 693086 blocks at level 4
[0%]… [10%]… [20%]… [30%]… [40%]…ERROR: VerifyDB(): *** coin database inconsistencies found (last 601365 blocks, 142571 good transactions before that)
Corrupted block database detected.
**How reliably can you reproduce the issue, what are the steps to do so?**
100% reproducible. To reproduce, just try rechecking the chain. I don’t know the fastest way to do this, in fact, I’m not even entirely sure how many checklevels there even are but I read 6 on stack exchange…anyhow, just add this to bitcoin.conf and restart node:
assumevalid=0
checkblocks=0
checklevel=6
**What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)?**
0.21.1.0; self compiled. I got the code two different t ways: over Internet using git at the command line and from the friendly lizards working for blockstream in space via satellite using blocksat-cli.
**What type of machine are you observing the error on (OS/CPU and disk type)?**
I’ve checked two intel architecture nodes I have running. Both are little intel NUCs.
Ubuntu 20.04 Lts/2.6 ghz intel i7 underclocked at 2.4 GHz max just in case/16 and 32 GB RAM at conservative BIOS settings/NVME SSD (tried it on one node with a single Samsung 970 evo plus formatted ext4 filesystem and another with 2 Samsung 980 NVME in raid 1 configuration…also ext4)
**What is your operating system and its version? If Linux, what is your desktop environment and graphical shell?**
Whatever is default for Ubuntu
**Any extra information that might be useful in the debugging process.**
Someone far smarter than me can reproduce this too (dflate)
Somehow relates to this…see explorers disagreeing (via dflate)
https://blockstream.info/tx/d5d27987d2a3dfc724e359870c6644b40e497bdc0589a033220fe15429d88599?expand
https://explorer.bitcoin.com/btc/tx/d5d27987d2a3dfc724e359870c6644b40e497bdc0589a033220fe15429d88599
Otherwise, not yet. I keep my node off the internet, because, you know, satellite and stuff…but I’ve typed out by hand what seems relevant above.
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/22596 | https://github.com/bitcoin/bitcoin/pull/24851 | 92be831847e31833f5162a431882b27a2ac3f4ee | 0384b194149305ffc8580ad6947e0471a36446ff | 2021-08-01T01:55:02Z | c++ | 2022-10-13T18:15:28Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,595 | ["doc/init.md", "src/i2p.cpp", "src/init.cpp", "src/rpc/request.cpp", "src/util/system.cpp", "src/wallet/init.cpp", "test/functional/feature_posix_fs_permissions.py", "test/functional/test_framework/test_framework.py", "test/functional/test_runner.py"] | `make install` creates files/folders with bad permissions if custom umask is used | The `make install` script, which most users would run via `sudo` to install into `/usr/local`, will use the current umask of the root user when creating certain files and directories. If one uses a restrictive umask by default (e.g. `umask 077`), this means that only the root user will be able to use the full Bitcoin package.
**Expected behavior**
The install script creates all directories and files, including man pages, etc., with permissions `644` / `755`.
**Actual behavior**
Certain folders are created using the default umask, e.g.:
- /usr/local/share/man/man1/
- /usr/local/lib/pkgconfig/
- [...]
This means that only root can access files in these folders and other users won't be able to read the man pages (for example).
**To reproduce**
```bash
$ ./autogen.sh
$ make
$ sudo -iu root
% umask 077
% make install
```
**System information**
OS: Linux
bitcoind version: HEAD | https://github.com/bitcoin/bitcoin/issues/22595 | https://github.com/bitcoin/bitcoin/pull/17127 | 5a80086ec2c15d1cd269e8e354f48ee11e4531eb | 6e08e5cb5cca57cef9e7a6b557e359ef911dbfaa | 2021-08-01T01:51:13Z | c++ | 2023-02-07T10:44:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,571 | ["src/util/settings.cpp"] | settings.json overwritten if missing read permissions | Issue was reported by @Talkless https://github.com/bitcoin-core/gui/pull/379#issuecomment-888537173
Happens due to this line in `ReadSettings`:
https://github.com/bitcoin/bitcoin/blob/4b1fb50def0dea0cd320bc43c12d9a12edde0390/src/util/settings.cpp#L65
which treats a nonexisting file the same as an inaccessible file. It should be changed to treat any settings file that exists and is unreadable as an error. | https://github.com/bitcoin/bitcoin/issues/22571 | https://github.com/bitcoin/bitcoin/pull/22591 | 6490a3ef6c4c6525d169818d18a99050f780c5b7 | 91e07cc50db675b97fee324a8a293bc6b353d991 | 2021-07-28T19:20:39Z | c++ | 2021-09-05T15:12:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,489 | ["src/wallet/rpcdump.cpp", "src/wallet/wallet.cpp", "test/functional/wallet_dump.py"] | The dumpwallet RPC command stops/kills bitcoind | The `dumpwallet` RPC command throws an error at the signet node and stops it.
~~This does not happen in mainnet or testnet, where the command worked successfully in my tests..~~
Originally this error was only happening on signet, but it also happened on testnet after it worked successfully for a while.
**Expected behavior**
The RPC `dumpwallet` command is expected to return a success message and create the dump file that contains the private keys.
**Actual behavior**
The command returns an error on client side (`bitcoin-cli`):
`error: timeout on transient error: Could not connect to the server 127.0.0.1:38332 (error code 1 - "EOF reached")
Make sure the bitcoind server is running and that you are connecting to the correct RPC port.`
And it throws an error at the signet node and stops it.
```
POTENTIAL DEADLOCK DETECTED
Previous lock order was:
'cs_wallet' in wallet/wallet.cpp:2860 (in thread 'httpworker.1')
(2) '::cs_main' in node/interfaces.cpp:687 (in thread 'httpworker.1')
'm_node.mempool->cs' in node/interfaces.cpp:687 (in thread 'httpworker.1')
'cs_wallet' in wallet/wallet.cpp:1204 (in thread 'httpworker.1')
(1) 'cs_KeyStore' in script/signingprovider.cpp:165 (in thread 'httpworker.1')
Current lock order is:
'wallet.cs_wallet' in wallet/rpcdump.cpp:743 (in thread 'httpworker.3')
(1) 'spk_man.cs_KeyStore' in wallet/rpcdump.cpp:743 (in thread 'httpworker.3')
(1) 'spk_man->cs_KeyStore' in wallet/wallet.cpp:2303 (in thread 'httpworker.3')
(2) 'cs_main' in node/interfaces.cpp:493 (in thread 'httpworker.3')
Assertion failed: detected inconsistent lock order for 'cs_main' in node/interfaces.cpp:493 (in thread 'httpworker.3'), details in debug log.
Aborted (core dumped)
```
**To reproduce**
Start the node on signet mode:
`bitcoind -signet`
And dump an existing wallet:
`bitcoin-cli -signet -rpcwallet="legacy_wallet_01" dumpwallet "filename"`
**System information**
The bitcoin node was compiled from master (commit: `df2b5dadfb2dc21b05e5a60b71987fb5b96201f5`)
Ubuntu 20.04, 8 CPUs, 12 GiB RAM and SSD.
| https://github.com/bitcoin/bitcoin/issues/22489 | https://github.com/bitcoin/bitcoin/pull/22492 | 8ed8164e6f1e85dce38ceb4f4766c21718691046 | 539023ab4155c94c6e52dd6b2dd504619ae45e08 | 2021-07-18T22:29:49Z | c++ | 2021-07-20T13:04:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,470 | ["src/addrman.cpp", "src/addrman.h", "src/test/addrman_tests.cpp"] | Changing I2P ports in addrman may wrongly skip some entries from "new" buckets | The problem was originally reported in https://github.com/bitcoin/bitcoin/issues/22450#issuecomment-880602891. This is a dedicated issue to track it independently because it is a different problem than the one reported in #22450 OP/description.
> If the same I2P address appears in multiple new buckets, then the first time this loop finds that address, it'll update the port and reposition it in that bucket. Any subsequent times that the address is encountered, it will already have had its port updated so the inner loop will `continue` ...
Thanks, @jnewbery! | https://github.com/bitcoin/bitcoin/issues/22470 | https://github.com/bitcoin/bitcoin/pull/22497 | 54e31742d208eb98ce706aaa6bbd4b023f42c3a5 | 624a19333022e53aaa56553797bbc5ba94982968 | 2021-07-16T16:26:50Z | c++ | 2021-07-20T01:02:34Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,467 | ["src/addrman.cpp", "src/addrman.h", "src/test/addrman_tests.cpp"] | Assertion `nRndPos1 < vRandom.size() && nRndPos2 < vRandom.size()' failed | The problem was originally reported in https://github.com/bitcoin/bitcoin/issues/22450#issuecomment-880629375. This is a dedicated issue to track it independently because it is a different problem than the one reported in #22450 OP/description.
```
fuzz: addrman.cpp:149: void CAddrMan::SwapRandom(unsigned int, unsigned int): Assertion `nRndPos1 < vRandom.size() && nRndPos2 < vRandom.size()' failed.
```
To reproduce:
```sh
FUZZ=addrman_deserialize ./src/test/fuzz/fuzz /tmp/crash-ef7d4a4f940b8fdb4999f6a92969260cf8e1405f.log
```
[crash-ef7d4a4f940b8fdb4999f6a92969260cf8e1405f.log](https://github.com/bitcoin/bitcoin/files/6830072/crash-ef7d4a4f940b8fdb4999f6a92969260cf8e1405f.log)
| https://github.com/bitcoin/bitcoin/issues/22467 | https://github.com/bitcoin/bitcoin/pull/22497 | 54e31742d208eb98ce706aaa6bbd4b023f42c3a5 | 624a19333022e53aaa56553797bbc5ba94982968 | 2021-07-16T10:37:30Z | c++ | 2021-07-20T01:02:34Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,460 | ["src/wallet/scriptpubkeyman.h", "test/functional/wallet_upgradewallet.py"] | `upgradewallet` on a descriptor wallet ends with error | This is the error I get:
```
$ bitcoin-cli -rpcwallet=descriptor -testnet upgradewallet <
error code: -1
error message:
wallet/rpcwallet.cpp:4522 (operator())
Internal bug detected: '!error.empty()'
You may report this issue here: https://github.com/bitcoin/bitcoin/issues
```
The daemon logs this:
```
2021-07-15T16:16:54Z [descriptor] Performing wallet upgrade to 169900
```
**Expected behavior**
When I do the same on the default (non-descriptor) wallet:
```
$ bitcoin-cli -rpcwallet="" -testnet upgradewallet
{
"wallet_name": "",
"previous_version": 169900,
"current_version": 169900,
"result": "Already at latest version. Wallet version unchanged."
}
```
<!-- **Actual behavior** -->
<!-- See above. Isn't this kind of backwards, to first ask what I expect and then ask what I got? I am writing here because I got something strange in the first place... -->
**System information**
Bitcoin Core v0.21.1 Linux x86_64 glibc (Ubuntu) using binarias from bitcoincore.org
| https://github.com/bitcoin/bitcoin/issues/22460 | https://github.com/bitcoin/bitcoin/pull/22461 | 4371e635d68251202f94353aa3124d74c78f7ec9 | 5341c3b1b35d7019d9f800636fc7ae8180d50b8e | 2021-07-15T16:24:57Z | c++ | 2021-07-18T07:33:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,459 | ["src/bench/peer_eviction.cpp"] | -Wnarrowing warning on 32-bit system | On Debian 10.10 32-bit with GCC 8.3.0:
```
...
bench/peer_eviction.cpp: In function ‘void EvictionProtectionCommon(ankerl::nanobench::Bench&, int, std::function<void(NodeEvictionCandidate&)>)’:
bench/peer_eviction.cpp:30:51: warning: narrowing conversion of ‘(((uint64_t)(& bench)->ankerl::nanobench::Bench::epochs()) * (& bench)->ankerl::nanobench::Bench::epochIterations())’ from ‘uint64_t’ {aka ‘long long unsigned int’} to ‘std::vector<std::vector<NodeEvictionCandidate> >::size_type’ {aka ‘unsigned int’} inside { } [-Wnarrowing]
std::vector<Candidates> copies{bench.epochs() * bench.epochIterations(), candidates};
~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
...
```
`bench/peer_eviction.cpp` was added recently in #22284. | https://github.com/bitcoin/bitcoin/issues/22459 | https://github.com/bitcoin/bitcoin/pull/22464 | a88fa1a555195af6543cdc802e8e1c2e1668dd38 | f8b20fd35b0eb42d28afb302a070e5d9bc21a99f | 2021-07-15T15:53:17Z | c++ | 2021-07-16T06:04:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,458 | ["contrib/guix/manifest.scm"] | guix: building for `aarch64-linux-gnu` on aarch64 fails | Running a Guix build of master (f002f8a0e76bd5abd60ef6809b1ff2b4c2d56071) using:
```bash
HOSTS="aarch64-linux-gnu" ./contrib/guix/guix-build
```
on aarch64 hardware (Alpine Docker container, running on Apple M1) currently fails with the following:
```bash
cc1: error: no include path in which to search for stdc-predef.h
/gnu/store/lzf5zg0diw2bhh2qji4bl2v46wd8pylc-bash-minimal-5.1.8/bin/bash ../../gcc-10.3.0/gcc/../move-if-change tmp-macro_list macro_list
echo timestamp > s-macro_list
rm -rf include-fixed; mkdir include-fixed
chmod a+rx include-fixed
if [ -d ../prev-gcc ]; then \
cd ../prev-gcc && \
make real-install-headers-tar DESTDIR=`pwd`/../gcc/ \
libsubdir=. ; \
else \
set -e; for ml in `cat fixinc_list`; do \
sysroot_headers_suffix=`echo ${ml} | sed -e 's/;.*$//'`; \
multi_dir=`echo ${ml} | sed -e 's/^[^;]*;//'`; \
fix_dir=include-fixed${multi_dir}; \
if ! false && test ! -d `echo /usr/include | sed -e :a -e 's,[^/]*/\.\.\/,,' -e ta`; then \
echo The directory that should contain system headers does not exist: >&2 ; \
echo " `echo /usr/include | sed -e :a -e 's,[^/]*/\.\.\/,,' -e ta`" >&2 ; \
tooldir_sysinc=`echo "/gnu/store/bp869rrz2z24yvjyma9kkj0alzxvqkc2-gcc-cross-sans-libc-aarch64-linux-gnu-10.3.0-lib/lib/gcc/aarch64-linux-gnu/10.3.0/../../../../../../../aarch64-linux-gnu/sys-include" | sed -e :a -e "s,[^/]*/\.\.\/,," -e ta`; \
if test "x`echo /usr/include | sed -e :a -e 's,[^/]*/\.\.\/,,' -e ta`" = "x${tooldir_sysinc}"; \
then sleep 1; else exit 1; fi; \
fi; \
/gnu/store/lzf5zg0diw2bhh2qji4bl2v46wd8pylc-bash-minimal-5.1.8/bin/bash ../../gcc-10.3.0/gcc/../mkinstalldirs ${fix_dir}; \
chmod a+rx ${fix_dir} || true; \
(TARGET_MACHINE='aarch64-unknown-linux-gnu'; srcdir=`cd ../../gcc-10.3.0/gcc; ${PWDCMD-pwd}`; \
SHELL='/gnu/store/lzf5zg0diw2bhh2qji4bl2v46wd8pylc-bash-minimal-5.1.8/bin/bash'; MACRO_LIST=`${PWDCMD-pwd}`/macro_list ; \
gcc_dir=`${PWDCMD-pwd}` ; \
export TARGET_MACHINE srcdir SHELL MACRO_LIST && \
cd ../build-aarch64-unknown-linux-gnu/fixincludes && \
/gnu/store/lzf5zg0diw2bhh2qji4bl2v46wd8pylc-bash-minimal-5.1.8/bin/bash ./fixinc.sh "${gcc_dir}/${fix_dir}" \
`echo /usr/include | sed -e :a -e 's,[^/]*/\.\.\/,,' -e ta` ); \
rm -f ${fix_dir}/syslimits.h; \
if [ -f ${fix_dir}/limits.h ]; then \
mv ${fix_dir}/limits.h ${fix_dir}/syslimits.h; \
else \
cp ../../gcc-10.3.0/gcc/gsyslimits.h ${fix_dir}/syslimits.h; \
fi; \
chmod a+r ${fix_dir}/syslimits.h; \
done; \
fi
The directory that should contain system headers does not exist:
/usr/include
make[3]: *** [Makefile:3172: stmp-fixinc] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/tmp/guix-build-gcc-cross-sans-libc-aarch64-linux-gnu-10.3.0.drv-0/build/gcc'
make[2]: *** [Makefile:4688: all-stage1-gcc] Error 2
make[2]: Leaving directory '/tmp/guix-build-gcc-cross-sans-libc-aarch64-linux-gnu-10.3.0.drv-0/build'
make[1]: *** [Makefile:18381: stage1-bubble] Error 2
make[1]: Leaving directory '/tmp/guix-build-gcc-cross-sans-libc-aarch64-linux-gnu-10.3.0.drv-0/build'
make: *** [Makefile:946: all] Error 2
```
[Full build log](https://gist.github.com/fanquake/df8d9a4f434d2d374cc3d2dd5492793d). | https://github.com/bitcoin/bitcoin/issues/22458 | https://github.com/bitcoin/bitcoin/pull/25861 | 604015ac7955695209dd6405db2c595e60e135b3 | df31e468b9adc21313d52e0c50211a653e98b3dc | 2021-07-15T13:22:44Z | c++ | 2022-09-04T17:22:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,450 | ["src/addrman.h"] | addrman serialize: nNew was wrong, oh ow | Made observable by the fuzz tests in commit e0a2b390c144e123e2fc8a289fdff36815476964
Crash in https://github.com/bitcoin/bitcoin/blob/d8f1e1327f9c2f9fcc804468f6a981580acdf30a/src/addrman.h#L261
OSS-Fuzz reproducer: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=36208
Can be reproduced locally in a few CPU hours via `FUZZ=addrman_deserialize ./src/test/fuzz/fuzz -use_value_profile=1` (using the qa-assets seed as starting point). | https://github.com/bitcoin/bitcoin/issues/22450 | https://github.com/bitcoin/bitcoin/pull/22455 | d3474b8df2f973e9b9142c0b64505a8a78bcb292 | 54e31742d208eb98ce706aaa6bbd4b023f42c3a5 | 2021-07-15T08:38:23Z | c++ | 2021-07-19T12:25:53Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,449 | ["test/functional/p2p_addr_relay.py"] | CI timeout in test/functional/p2p_addr_relay.py::L184 | Cirrus link: https://cirrus-ci.com/task/6054661070258176
```bash
test/functional/p2p_addr_relay.py", line 184, in getaddr_tests
inbound_peer.wait_until(lambda: inbound_peer.addr_received() is True)
```
```bash
37.1.1:8333 timed out
node0 2021-07-14T16:52:07.055283Z (mocktime: 2021-07-14T17:17:09Z) [opencon] [net.cpp:402] [ConnectNode] trying connection 2.163.1.1:8333 lastseen=0.1hrs
node0 2021-07-14T16:52:10.043553Z (mocktime: 2021-07-14T17:17:09Z) [scheduler] [random.cpp:523] [SeedPeriodic] Feeding 33046 bytes of dynamic environment data into RNG
node0 2021-07-14T16:52:12.060196Z (mocktime: 2021-07-14T17:17:09Z) [opencon] [netbase.cpp:571] [ConnectSocketDirectly] connection attempt to 2.163.1.1:8333 timed out
node0 2021-07-14T16:52:12.561757Z (mocktime: 2021-07-14T17:17:09Z) [opencon] [net.cpp:402] [ConnectNode] trying connection 2.143.1.1:8333 lastseen=0.1hrs
node0 2021-07-14T16:52:16.048761Z (mocktime: 2021-07-14T17:17:09Z) [net] [net.cpp:1313] [InactivityCheck] socket sending timeout: 1201s peer=12
node0 2021-07-14T16:52:16.048809Z (mocktime: 2021-07-14T17:17:09Z) [net] [net.cpp:1313] [InactivityCheck] socket sending timeout: 1201s peer=13
node0 2021-07-14T16:52:16.048824Z (mocktime: 2021-07-14T17:17:09Z) [net] [net.cpp:1313] [InactivityCheck] socket sending timeout: 1201s peer=14
node0 2021-07-14T16:52:16.048858Z (mocktime: 2021-07-14T17:17:09Z) [net] [net.cpp:505] [CloseSocketDisconnect] disconnecting peer=12
node0 2021-07-14T16:52:16.048920Z (mocktime: 2021-07-14T17:17:09Z) [net] [net.cpp:505] [CloseSocketDisconnect] disconnecting peer=13
node0 2021-07-14T16:52:16.048948Z (mocktime: 2021-07-14T17:17:09Z) [net] [net.cpp:505] [CloseSocketDisconnect] disconnecting peer=14
test 2021-07-14T16:52:16.049000Z TestFramework.p2p (DEBUG): Closed connection to: 0:0
test 2021-07-14T16:52:16.049000Z TestFramework.p2p (DEBUG): Closed connection to: 0:0
test 2021-07-14T16:52:16.049000Z TestFramework.p2p (DEBUG): Closed connection to: 127.0.0.1:15440
node0 2021-07-14T16:52:16.049171Z (mocktime: 2021-07-14T17:17:09Z) [net] [net_processing.cpp:1190] [FinalizeNode] Cleared nodestate for peer=12
node0 2021-07-14T16:52:16.049336Z (mocktime: 2021-07-14T17:17:09Z) [net] [net_processing.cpp:1190] [FinalizeNode] Cleared nodestate for peer=13
node0 2021-07-14T16:52:16.049444Z (mocktime: 2021-07-14T17:17:09Z) [net] [net_processing.cpp:1190] [FinalizeNode] Cleared nodestate for peer=14
test 2021-07-14T16:52:16.050000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 128, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/p2p_addr_relay.py", line 60, in run_test
self.getaddr_tests()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/p2p_addr_relay.py", line 184, in getaddr_tests
inbound_peer.wait_until(lambda: inbound_peer.addr_received() is True)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/p2p.py", line 450, in wait_until
wait_until_helper(test_function, timeout=timeout, lock=p2p_lock, timeout_factor=self.timeout_factor)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 247, in wait_until_helper
if predicate():
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/p2p.py", line 447, in test_function
assert self.is_connected
AssertionError
test 2021-07-14T16:52:16.051000Z TestFramework (DEBUG): Closing down network thread
test 2021-07-14T16:52:16.101000Z TestFramework (INFO): Stopping nodes
test 2021-07-14T16:52:16.101000Z TestFramework.node0 (DEBUG): Stopping node
```
| https://github.com/bitcoin/bitcoin/issues/22449 | https://github.com/bitcoin/bitcoin/pull/23720 | df6e961c417bc6e733f2fcefd2d712178a3da4b6 | 6b212cbbb9d7a564fc47c390e4bb20989ce26f5a | 2021-07-14T18:27:21Z | c++ | 2021-12-16T14:07:45Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,403 | ["contrib/macdeploy/macdeployqtplus"] | Installation via Bitcoin-Core.dmg is broken on macOS (Apple Silicon) | System: macOS Big Sur 11.4 (20F71), chip Apple M1.
On master (c609e10545492aba480ff17aff7eefc13a0b5cd8), after succesfull `make deploy` (without depends), the app installed from `Bitcoin-Core.dmg` fails to run.
`src/qt/bitcoin-qt` works flawlessly. | https://github.com/bitcoin/bitcoin/issues/22403 | https://github.com/bitcoin/bitcoin/pull/22546 | 358fe779cbb2681666ae5ab23a19662db21a2c46 | 077cfffebd1b12ec4e2efb949fd9a79fb5be3748 | 2021-07-05T13:15:13Z | c++ | 2022-02-23T15:44:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,382 | ["src/rpc/rawtransaction.cpp", "src/validation.cpp", "src/validation.h"] | getrawtransaction is slower when used with blockhash | **Expected behavior**
When using `getrawtransaction` with an included `blockhash`, performance should be better as there is no need to scan the entire txindex.
**Actual behavior**
Running `getrawtransaction` while including the `blockhash` is ~5x slower.
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
**To reproduce**
```
$ time ./bin/bitcoin-cli getrawtransaction 20a93350cd6f4e03dfb6cbb3f104965293627f25c199c1be0e4d187a4ed5f4bb
020000000001018d3f7d8efaa377dda74892af26c1ca028466d97721d2ea6c74a5cbcf404feb9004000000171600147f5a49a2d89f86ff498103bdbcb1762f9f0ab5aefeffffff08a04a05000000000017a91467a849785bb12f1a03260b3b52ec9dff52b30e708724b80100000000001976a914f0b7e8a5ede232c2654fca3b47f8d0c95f7a561688ac50fe0b00000000001976a914ed06524fb21248a37e7f8f20cdc67e27f49c4f1588acf44f01000000000017a9147422dbf3bdf441a640d09a2a91e6fa40837b019f878d9b3100000000001976a9142a5cd9333e4e94c88f7cd33216b2fc0af15fbd8588ac89b400000000000017a914d05dbcdb4587f1a243cc1ed89e96cd4ec19e24a08778e169180000000017a914f520df8923419f60d9a76df60cfc7a0e3a3fc86f8708d806000000000017a9147246c684dd4890e9c8977e6312c30ecdea2b0a55870247304402205704dd3b6d8930e89c660011ab2f6a42aedcbde438d5f121998e3db6a66889310220054a506aee274f885229d6a9ed89eca17bac87dca401f9c63d07990e98b2f0a301210390e3b178ebc51da1589baee9de37de491dba0575838aacf88c2cd70a06a4486eb47c0a00
real 0m0.003s
user 0m0.000s
sys 0m0.002s
$ time ./bin/bitcoin-cli getrawtransaction 20a93350cd6f4e03dfb6cbb3f104965293627f25c199c1be0e4d187a4ed5f4bb false 0000000000000000000a801776a92ced69dc5fb0a5919271872a9261a613d9c3
020000000001018d3f7d8efaa377dda74892af26c1ca028466d97721d2ea6c74a5cbcf404feb9004000000171600147f5a49a2d89f86ff498103bdbcb1762f9f0ab5aefeffffff08a04a05000000000017a91467a849785bb12f1a03260b3b52ec9dff52b30e708724b80100000000001976a914f0b7e8a5ede232c2654fca3b47f8d0c95f7a561688ac50fe0b00000000001976a914ed06524fb21248a37e7f8f20cdc67e27f49c4f1588acf44f01000000000017a9147422dbf3bdf441a640d09a2a91e6fa40837b019f878d9b3100000000001976a9142a5cd9333e4e94c88f7cd33216b2fc0af15fbd8588ac89b400000000000017a914d05dbcdb4587f1a243cc1ed89e96cd4ec19e24a08778e169180000000017a914f520df8923419f60d9a76df60cfc7a0e3a3fc86f8708d806000000000017a9147246c684dd4890e9c8977e6312c30ecdea2b0a55870247304402205704dd3b6d8930e89c660011ab2f6a42aedcbde438d5f121998e3db6a66889310220054a506aee274f885229d6a9ed89eca17bac87dca401f9c63d07990e98b2f0a301210390e3b178ebc51da1589baee9de37de491dba0575838aacf88c2cd70a06a4486eb47c0a00
real 0m0.014s
user 0m0.000s
sys 0m0.002s
```
**System information**
GCP c2-standard-4 (4 vCPUs, 16 GB memory) with 1TB of persistent SSD
Ubuntu 20.04.2 LTS
Bitcoin Core v0.21.1 | https://github.com/bitcoin/bitcoin/issues/22382 | https://github.com/bitcoin/bitcoin/pull/22383 | 5d83e7d714e0b7cafeb2f14892184a9607cb55dc | 7925f3aba820f8965293148ef666c59f87dd3c7f | 2021-07-01T13:49:23Z | c++ | 2021-07-22T18:13:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,357 | ["src/wallet/wallet.cpp"] | ci: failure in feature_backwards_compatibility --descriptors "Transaction not eligible for abandonment" | This is similar to #21352, #20270, #18831, #18161, but they have all been closed/fixed, and this is happening again on master as of the [last CI run](https://github.com/bitcoin/bitcoin/runs/2928080250):
```bash
122/210 - feature_backwards_compatibility.py --descriptors failed, Duration: 68 s
stdout:
2021-06-28T03:28:48.903000Z TestFramework (INFO): Initializing test directory /tmp/cirrus-build/ci/scratch/test_runner/test_runner_₿_🏃_20210628_031620/feature_backwards_compatibility_97
2021-06-28T03:28:52.381000Z TestFramework (INFO): Test wallet backwards compatibility...
2021-06-28T03:29:56.399000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 128, in main
self.run_test()
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_backwards_compatibility.py", line 110, in run_test
self.nodes[1].abandontransaction(tx3_id)
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/coverage.py", line 47, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/authproxy.py", line 146, in __call__
raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Transaction not eligible for abandonment (-5)
2021-06-28T03:29:56.453000Z TestFramework (INFO): Stopping nodes
2021-06-28T03:29:56.723000Z TestFramework (WARNING): Not cleaning up dir /tmp/cirrus-build/ci/scratch/test_runner/test_runner_₿_🏃_20210628_031620/feature_backwards_compatibility_97
2021-06-28T03:29:56.724000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/cirrus-build/ci/scratch/test_runner/test_runner_₿_🏃_20210628_031620/feature_backwards_compatibility_97/test_framework.log
2021-06-28T03:29:56.724000Z TestFramework (ERROR):
2021-06-28T03:29:56.725000Z TestFramework (ERROR): Hint: Call /tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/combine_logs.py '/tmp/cirrus-build/ci/scratch/test_runner/test_runner_₿_🏃_20210628_031620/feature_backwards_compatibility_97' to consolidate all logs
2021-06-28T03:29:56.725000Z TestFramework (ERROR):
2021-06-28T03:29:56.725000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-06-28T03:29:56.725000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues
2021-06-28T03:29:56.725000Z TestFramework (ERROR):
```
| https://github.com/bitcoin/bitcoin/issues/22357 | https://github.com/bitcoin/bitcoin/pull/22359 | 8fa03c4ddf833d767214f147873600e036858d37 | a162edfdd1e655845961ba5e888e92c3047efde1 | 2021-06-28T03:56:59Z | c++ | 2021-08-09T02:21:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,344 | ["depends/packages/qt.mk"] | build: configure doesn't pickup Qt if depends is built against libc++ | On Linux, using the master branch (3e306ee1d5c79eda64eb991fb2696bf530f0b30d) or the 0.21 one (926f76cb205ce9ef085f4945cdb439746b140414), after building depends against `libc++`:
```
$ make -j 9 -C depends CC=clang CXX='clang++ -stdlib=libc++'
```
configuring with
```
$ ./autogen.sh && CONFIG_SITE=$PWD/depends/x86_64-pc-linux-gnu/share/config.site ./configure -q CC=clang CXX='clang++ -stdlib=libc++'
```
fails to pick up the Qt package.
This issue prevents TSAN from being enabled for GUI builds (see #19162). | https://github.com/bitcoin/bitcoin/issues/22344 | https://github.com/bitcoin/bitcoin/pull/22814 | 3c40355d633ba0d6a08461a5c31e9149d3d415d0 | de28c348a0ef866e6d25c06551a1e1c085f41815 | 2021-06-26T05:04:46Z | c++ | 2021-12-30T03:36:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,325 | ["src/bitcoin-cli.cpp"] | test: AssertionError: 1624447103.0015192 < 1624447103.969648 in interface_bitcoin_cli.py | Most recent failure [on master](https://cirrus-ci.com/task/6073953614561280) (https://github.com/bitcoin/bitcoin/commit/567670bec5ecf9bc252e91370382be53fd81ccee):
```bash
test 2021-06-23T11:18:18.969000Z TestFramework.node0 (DEBUG): Node stopped
test 2021-06-23T11:18:18.969000Z TestFramework.bitcoincli (DEBUG): Running bitcoin-cli ['-rpcwait', '-rpcwaittimeout=5', 'echo']
test 2021-06-23T11:18:23.001000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 128, in main
self.run_test()
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/interface_bitcoin_cli.py", line 257, in run_test
assert_greater_than_or_equal(time.time(), start_time + 5)
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 61, in assert_greater_than_or_equal
raise AssertionError("%s < %s" % (str(thing1), str(thing2)))
AssertionError: 1624447103.0015192 < 1624447103.969648
test 2021-06-23T11:18:23.004000Z TestFramework (DEBUG): Closing down network thread
test 2021-06-23T11:18:23.055000Z TestFramework (INFO): Stopping nodes
``` | https://github.com/bitcoin/bitcoin/issues/22325 | https://github.com/bitcoin/bitcoin/pull/22327 | 0553d75268a94630225fa754841e28d88d751665 | b2f5c38333fd2ec03fd1299a1bce507b25753f45 | 2021-06-23T12:07:21Z | c++ | 2021-06-24T14:01:21Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,319 | ["configure.ac", "doc/dependencies.md"] | build: configure error related to boost:process when cross-compiling to windows | When trying to cross-compile for Windows on Ubuntu 20.04.2 LTS I ran into the following configuration error:
```
checking for Boost Process... configure: error: Boost::Process is required for external signer support, but not available!
```
**Steps to reproduce:**
1. depends build for windows
```
cd depends && make -jN HOST=x86_64-w64-mingw32
```
2. After work is built, try to configure:
```
cd .. && ./autogen.sh && CONFIG_SITE=$PWD/depends/x86_64-w64-mingw32/share/config.site ./configure
```
3. Run into configuration error
**System:**
- reproduced on VM with Ubuntu 20.04.2 LTS and desktop with Arch Linux
| https://github.com/bitcoin/bitcoin/issues/22319 | https://github.com/bitcoin/bitcoin/pull/22320 | bfa885898a5f3260fd1628158d1d32093d61bd4a | c31161f4f79b6e1dc0f8bfc2a5e7815e8c55ed91 | 2021-06-23T05:38:32Z | c++ | 2021-06-24T10:35:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,269 | ["configure.ac", "doc/dependencies.md"] | build: boost::process detection doesn't pass include directory | `boost::process` detection fails here (FreeBSD 13.0) with:
```
configure:32183: checking for Boost Process
configure:32196: c++ -std=c++17 -c -g -O2 -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -DPROVIDE_FUZZ_MAIN_FUNCTION conftest.cpp >&5
conftest.cpp:80:10: fatal error: 'boost/process.hpp' file not found
#include <boost/process.hpp>
^~~~~~~~~~~~~~~~~~~
1 error generated.
configure:32196: $? = 1
```
The header in question does exist in `/usr/local/include/boost/process.hpp`. However, no include path is passed?
For comparison, the preceding boost::filesystem check, which passes `-I/usr/local/include` succeeds:
```
configure:32026: checking for exit in -lboost_filesystem
configure:32051: c++ -std=c++17 -o conftest -g -O2 -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -DPROVIDE_FUZZ_MAIN_FUNCTION -I/usr/local/include -L/usr/local/lib conftest.cpp -lboost_filesystem -lboost_system >&5
configure:32051: $? = 0
configure:32061: result: yes
``` | https://github.com/bitcoin/bitcoin/issues/22269 | https://github.com/bitcoin/bitcoin/pull/22320 | bfa885898a5f3260fd1628158d1d32093d61bd4a | c31161f4f79b6e1dc0f8bfc2a5e7815e8c55ed91 | 2021-06-17T11:31:07Z | c++ | 2021-06-24T10:35:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,243 | ["test/functional/p2p_addr_relay.py"] | Intermittent issue in p2p_addr_relay (AssertionError: not(16 == 20)) | ERROR: type should be string, got "https://cirrus-ci.com/task/4899698315100160?logs=ci#L5292\r\n\r\n```\r\n File \"/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/p2p_addr_relay.py\", line 123, in relay_tests\r\n assert_equal(total_ipv4_received, num_ipv4_addrs * ipv4_branching_factor)\r\n File \"/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py\", line 51, in assert_equal\r\n raise AssertionError(\"not(%s)\" % \" == \".join(str(arg) for arg in (thing1, thing2) + args))\r\n AssertionError: not(16 == 20)" | https://github.com/bitcoin/bitcoin/issues/22243 | https://github.com/bitcoin/bitcoin/pull/22306 | a196c89317dd876c22c8b4556f5af3ecfa251119 | bfa885898a5f3260fd1628158d1d32093d61bd4a | 2021-06-14T18:26:11Z | c++ | 2021-06-24T10:10:44Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,236 | ["src/torcontrol.cpp"] | -torcontrol does not resolve a hostname if it is given | **Expected behavior**
-torcontrol should try to resolve a hostname if it is given
**Actual behavior**
The hostname is passed as an ip so the connection fails
```
2021-06-13T20:35:54Z tor: Error parsing socket address mynode.local:9051
2021-06-13T20:35:54Z tor: Initiating connection to Tor control port mynode.local:9051 failed
```
**To reproduce**
Add ```127.0.0.1 mynode``` to /etc/hosts and pass -torcontrol=mynode:9051 as an argument. The connection fails. Try with -torcontrol=127.0.0.1:9051 and it works.
**System information**
Bitcoin Core 0.21.1 from https://bitcoincore.org/bin/bitcoin-core-0.21.1/bitcoin-0.21.1-x86_64-linux-gnu.tar.gz
Ubuntu 18.04 | https://github.com/bitcoin/bitcoin/issues/22236 | https://github.com/bitcoin/bitcoin/pull/22288 | 10eb000409a284b35b421818a11168adadaad4bd | 1c046bb7ac0261d1d8f231ae1d8b39551ee60955 | 2021-06-13T20:09:55Z | c++ | 2021-07-21T10:40:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,233 | ["src/bench/verify_script.cpp", "src/consensus/tx_verify.cpp", "src/consensus/tx_verify.h", "src/script/interpreter.h", "src/test/fuzz/coins_view.cpp", "src/test/script_tests.cpp", "src/test/sigopcount_tests.cpp", "src/test/transaction_tests.cpp"] | fuzz: UndefinedBehaviorSanitizer warnings in consensus/tx_verify.cpp | There's an error causing several CI jobs to fail, e.g. [this](https://cirrus-ci.com/task/5397359480799232), [this](https://cirrus-ci.com/task/6118277442174976), [this](https://cirrus-ci.com/task/6218436868046848) or [this](https://cirrus-ci.com/task/5948261916737536).
```
INFO: Seed: 2688568392
INFO: Loaded 1 modules (532968 inline 8-bit counters): 532968 [0x55d2f9ea7cf8, 0x55d2f9f29ee0),
INFO: Loaded 1 PC tables (532968 PCs): 532968 [0x55d2f9f29ee0,0x55d2fa74bd60),
INFO: 5306 files found in /tmp/cirrus-ci-build/ci/scratch/qa-assets/fuzz_seed_corpus/coins_view
INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 1048576 bytes
INFO: seed corpus: files: 5306 min: 1b max: 3984182b total: 255622128b rss: 194Mb
#1024 pulse cov: 4978 ft: 17604 corp: 440/9989b exec/s: 512 rss: 247Mb
#2048 pulse cov: 5614 ft: 27538 corp: 763/47Kb exec/s: 409 rss: 333Mb
#4096 pulse cov: 5772 ft: 38611 corp: 1339/1242Kb exec/s: 204 rss: 350Mb
consensus/tx_verify.cpp:154:108: runtime error: implicit conversion from type 'int' of value -1653268223 (32-bit, signed) to type 'unsigned int' changed the value to 2641699073 (32-bit, unsigned)
#0 0x55d2f6953400 (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x2ca9400)
#1 0x55d2f64cafcd (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x2820fcd)
#2 0x55d2f64c5f39 (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x281bf39)
#3 0x55d2f63a6b97 (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x26fcb97)
#4 0x55d2f7c22647 (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x3f78647)
#5 0x55d2f7c222f5 (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x3f782f5)
#6 0x55d2f62ac531 (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x2602531)
#7 0x55d2f62abc75 (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x2601c75)
#8 0x55d2f62ae597 (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x2604597)
#9 0x55d2f62ae8f9 (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x26048f9)
#10 0x55d2f629d5ce (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x25f35ce)
#11 0x55d2f62c6412 (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x261c412)
#12 0x7f7a8917c0b2 (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
#13 0x55d2f627236d (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x25c836d)
SUMMARY: UndefinedBehaviorSanitizer: implicit-integer-sign-change consensus/tx_verify.cpp:154:108 in
MS: 0 ; base unit: 0000000000000000000000000000000000000000
artifact_prefix='./'; Test unit written to ./crash-d335a54e65799a7844ecde7d30f5e04719784b36
``` | https://github.com/bitcoin/bitcoin/issues/22233 | https://github.com/bitcoin/bitcoin/pull/22232 | 3d8c714d8e79921e51876cf003ee40a201f6b44f | 9faa4b68db80a4a5c1f5a4e0484d804d7b5e1493 | 2021-06-13T15:04:02Z | c++ | 2021-07-20T13:36:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,206 | ["ci/test/04_install.sh"] | ci: cache Python wheels built by the CI | Python wheels we build in the CI, such as `PyZMQ` or `LIEF`, do not get cached, and are rebuilt every CI run. This wastes time/CPU (`LIEF` can take some time to build). The versions of these packages rarely change, so we should be caching and reusing build output.
It looks like Cirrus even has a [`pip_cache` key](https://cirrus-ci.org/examples/#building-pypi-packages), that we may be able to take advantage of.
Excerpt from the Darwin native job:
```bash
./ci/test_run_all.sh
Setting specific values in env
Fallback to default values in env (if not yet set)
Collecting zmq
Downloading https://files.pythonhosted.org/packages/6e/78/833b2808793c1619835edb1a4e17a023d5d625f4f97ff25ffff986d1f472/zmq-0.0.0.tar.gz
Collecting lief
Downloading https://files.pythonhosted.org/packages/f4/db/29cf3cecc8b9997a16da6319f64039505861c9cf9ae2394bcb8c495ab3e0/lief-0.11.5.zip (15.7MB)
Collecting pyzmq (from zmq)
Downloading https://files.pythonhosted.org/packages/99/3b/69360102db726741053d1446cbe9f7f06df7e2a6d5b805ee71841abf1cdc/pyzmq-22.1.0.tar.gz (1.2MB)
Installing build dependencies: started
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Getting requirements to build wheel: finished with status 'done'
Installing backend dependencies: started
Installing backend dependencies: finished with status 'done'
Preparing wheel metadata: started
Preparing wheel metadata: finished with status 'done'
Building wheels for collected packages: pyzmq
Building wheel for pyzmq (PEP 517): started
Building wheel for pyzmq (PEP 517): finished with status 'done'
Created wheel for pyzmq: filename=pyzmq-22.1.0-cp38-cp38-macosx_10_14_6_x86_64.whl size=740475 sha256=e3fe3beb65a388bafbc38cd273de33d6e340e3c9bb70edfc073eb3ebe9cd8de4
Stored in directory: /Users/admin/Library/Caches/pip/wheels/e5/09/86/54436a8590914d725cccf13bfebf6b0dacaa976d68d299c079
Successfully built pyzmq
Building wheels for collected packages: zmq, lief
Building wheel for zmq (setup.py): started
Building wheel for zmq (setup.py): finished with status 'done'
Created wheel for zmq: filename=zmq-0.0.0-cp38-none-any.whl size=1277 sha256=b7d464167b77efa4d800df1ddaa050dc005834f099428c28bba59bc7b30735f3
Stored in directory: /Users/admin/Library/Caches/pip/wheels/44/7a/7d/ac1d865766b06f9769ac1154bf31dbb5abb3b52ecfe278247a
Building wheel for lief (setup.py): started
Building wheel for lief (setup.py): still running...
Building wheel for lief (setup.py): still running...
Building wheel for lief (setup.py): still running...
``` | https://github.com/bitcoin/bitcoin/issues/22206 | https://github.com/bitcoin/bitcoin/pull/22353 | e1a13f12e1ddd93d34a10f5f1a642794063c74f3 | 3fc20abab03d71a982d6fe9c47155834b256ab17 | 2021-06-10T08:17:26Z | c++ | 2021-06-30T08:23:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,189 | ["src/validation.cpp", "src/validation.h"] | validation: Review mutable static local variables in `CChainState` methods | Now that assumeutxo is well on the way, and multiple `CChainState` exist, we should review the mutable static local variables in `CChainState` methods. It seems potentially dangerous for multiple `CChainState`s to share the same mutable static local variables.
In `CChainState::FlushStateToDisk`:
https://github.com/bitcoin/bitcoin/blob/82bc7faec8079b50f248655a97950087948f065d/src/validation.cpp#L2154-L2155
In `CChainState::LoadExternalBlockFile` (this is fixed by #20331):
https://github.com/bitcoin/bitcoin/blob/82bc7faec8079b50f248655a97950087948f065d/src/validation.cpp#L4286
ping @jamesob
-----
Now that I think about it... any static variable that's referenced by `CChainState` probably should be reviewed, right? | https://github.com/bitcoin/bitcoin/issues/22189 | https://github.com/bitcoin/bitcoin/pull/26513 | 1801d8c3c900d0c3a0d05f9ec096419e3f286f6b | 07ac7a2dbf055f44aefad3c7366c844686e9d5c1 | 2021-06-08T17:29:50Z | c++ | 2022-12-08T15:35:28Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,181 | ["test/functional/wallet_orphanedreward.py"] | qa: Intermittent failure in wallet_orphanedreward.py | On master (359f72105ba0184fbf998dfd84217c4229dc54ad) Linux x86_64 build (https://bitcoinbuilds.org/index.php?ansilog=d9ab0e6e-e84d-432e-99c9-a7abe23e2413.log#l2645):
<details><summary>log excerpt</summary>
<p>
```
L2644 193/208 - wallet_orphanedreward.py failed, Duration: 4 s
L2645
L2646 stdout:
L2647 2021-06-07T17:29:05.693000Z TestFramework (INFO): Initializing test directory /tmp/test_runner_₿_🏃_20210607_131230/wallet_orphanedreward_13
L2648 2021-06-07T17:29:08.981000Z TestFramework (ERROR): Assertion failed
L2649 Traceback (most recent call last):
L2650 File "/home/ubuntu/src/test/functional/test_framework/test_framework.py", line 128, in main
L2651 self.run_test()
L2652 File "/home/ubuntu/src/test/functional/wallet_orphanedreward.py", line 34, in run_test
L2653 assert_equal(self.nodes[1].getbalance(), 10 + 25)
L2654 File "/home/ubuntu/src/test/functional/test_framework/util.py", line 51, in assert_equal
L2655 raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
L2656 AssertionError: not(10.00000000 == 35)
L2657 2021-06-07T17:29:09.036000Z TestFramework (INFO): Stopping nodes
L2658 2021-06-07T17:29:09.741000Z TestFramework (WARNING): Not cleaning up dir /tmp/test_runner_₿_🏃_20210607_131230/wallet_orphanedreward_13
L2659 2021-06-07T17:29:09.741000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/test_runner_₿_🏃_20210607_131230/wallet_orphanedreward_13/test_framework.log
L2660 2021-06-07T17:29:09.741000Z TestFramework (ERROR):
L2661 2021-06-07T17:29:09.741000Z TestFramework (ERROR): Hint: Call /home/ubuntu/src/test/functional/combine_logs.py '/tmp/test_runner_₿_🏃_20210607_131230/wallet_orphanedreward_13' to consolidate all logs
L2662 2021-06-07T17:29:09.741000Z TestFramework (ERROR):
L2663 2021-06-07T17:29:09.741000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
L2664 2021-06-07T17:29:09.742000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues
L2665 2021-06-07T17:29:09.742000Z TestFramework (ERROR):
```
</p>
</details> | https://github.com/bitcoin/bitcoin/issues/22181 | https://github.com/bitcoin/bitcoin/pull/22187 | 76d4018aa5426f2359b80466a56d28fc5046e0e2 | 45a8b01fad96d93113896b9332618e936aef77af | 2021-06-07T19:27:26Z | c++ | 2021-06-08T08:39:15Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,132 | ["build-aux/m4/bitcoin_qt.m4", "build_msvc/common.qt.init.vcxproj", "src/qt/bitcoin.cpp"] | Missing windowsvista style plugin for Windows | Here's a comparison of the Bitcoin Core GUI cross-compiled from linux to Windows between `master` and `0.21`:
| Master | 0.21 |
| ------------- | ------------- |
|  |  |
Yep, there's something wrong here. We can gain some insight into what's going on with the style by leveraging the logging of static plugins introduced in 957895c715f86feaa26c806e5fa8ebb77430a926. The `master` branch already includes this commit. I cherry-picked it on top of the `0.21` branch [here](https://github.com/jarolrod/bitcoin/tree/021-static). Now if we take a look at the `debug.log` for each, we'll see the following
*0.21 Branch:*
```
2021-06-02T07:23:59Z Qt 5.9.8 (static), plugin=windows (static)
2021-06-02T07:23:59Z Static plugins:
2021-06-02T07:23:59Z QWindowsIntegrationPlugin, version 329992
2021-06-02T07:23:59Z Style: windowsvista / QWindowsVistaStyle
```
*Master Branch:*
```
2021-06-02T04:16:06Z Qt 5.12.10 (static), plugin=windows (static)
2021-06-02T04:16:06Z Static plugins:
2021-06-02T04:16:06Z QWindowsIntegrationPlugin, version 330752
2021-06-02T04:16:06Z Style: windows / QWindowsStyle
```
We notice that the `master` branch's style is set to `windows` while the `0.21` branch is set to `windowsvista` style. Looking at the [Qt Widgets Gallery](https://doc.qt.io/qt-5/gallery.html), you can observe that `windows` style looks like Windows 95 while `windowsvista` is the "sleeker"/"modern" [QStyle](https://doc.qt.io/qt-5/qstyle.html) for the Windows platform.
This is what has changed between `master` and `0.21` and what is causing the GUI to look straight out of the 90's (maybe this is a retro release? 🕺).
Now, what is causing this change? Well, I'm not completely sure. Otherwise I'd open up a PR. I do have some findings:
#### Different available QStyle Keys between Qt 5.9.8 and Qt 5.12 at runtime:
Looking at the `Qt Widgets` section of the depends Qt configuration output, we can see the following styles are available:
*0.21 Branch:*
```
Qt Widgets:
GTK+ ................................... no
Styles ................................. Fusion Windows WindowsXP WindowsVista
```
*Master Branch:*
```
Qt Widgets:
GTK+ ................................... no
Styles ................................. Fusion Windows WindowsVista
```
So while it seems that in regards to how Qt is configured, `WindowsVista` style is available in both cases, If we apply the patch below to see the available [QStyle Keys](https://doc.qt.io/qt-5/qstylefactory.html#keys) at runtime, we don't see `windowsvista` as an available key on `master`:
```
qInfo() << QStyleFactory::keys().join(",");
```
*0.21 Branch:*
```
2021-06-02T17:43:35Z GUI: "Windows,WindowsXP,WindowsVista,Fusion"
```
*Master Branch:*
```
2021-06-02T17:03:11Z GUI: "Windows,Fusion"
```
This means that we can't use the line below to fix the issue, and so a fix would involve changes to our build system:
```
QApplication::setStyle("windowsvista");
```
**Windows Vista Style moved to a Plugin in Qt 5.10:**
This is based off what I found while looking for this issue online:
[Source A](https://trac.videolan.org/vlc/ticket/20780)
> I have also ran into this issue with Qt 5.11.1. Qt's Windows Vista style has been moved out to a separate DLL, which is styles\qwindowsvistastyle.dll. If you add this to the package, standard windows will get back their modern look.
[Source B](https://stackoverflow.com/questions/49587418/qt-application-becomes-windows-old-styled-after-build-on-a-buildbot)
> I found a problem. After Qt5.10.1 the "windowsvista" style becomes a plugin. So in the final deploy file windowsvistastyle.dll schould exists. I add a folder "/styles" with this .dll and a problem is gone.
[Source C](https://github.com/Ruin0x11/tiled/commit/7537fd06187591ec4d2feecbdb1fe8da88ccf5a7)
> Ship style plugins, since native styles were moved into plugins as of Qt 5.10. This includes Windows Vista style on Windows and Adwaita on Linux.
If we figure out what needs to be done on the build side to link to this plugin, then we can use a similar patch as [vlc](http://git.videolan.org/?p=vlc.git;a=blobdiff;f=modules/gui/qt/qt.cpp;h=6fdbda06fa8f8aba4c9d43eef29543b28fdeedea;hp=1128633386a3fa43fe9a59ea5f633557a9596483;hb=0630bfa0436105ae7e24051cc16031c8ce2d77f5;hpb=07c35dcde98e25fba642085ea89080d94a0698d8) to fix this and so the following is a solution:
```
Q_IMPORT_PLUGIN(QWindowsVistaStylePlugin)
```
| https://github.com/bitcoin/bitcoin/issues/22132 | https://github.com/bitcoin/bitcoin/pull/22133 | d331e262f5b28c3475fa91d6165e090a545de8a7 | 6fe012c6bd6a7977281df0b9292dc9c684915aba | 2021-06-02T17:57:38Z | c++ | 2021-06-03T12:40:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,105 | ["build-aux/m4/bitcoin_qt.m4"] | build: alpine qt from depends not configuring | Building master (619e930aa1860d92f8eebef3bc1bed8b37c606b8) in an [Alpine 3.13 container](https://github.com/fanquake/core-review/blob/master/docker/alpine.dockerfile):
```bash
make -C depends/ -j9
./autogen.sh
CONFIG_SITE=/bitcoin/depends/x86_64-pc-linux-musl/share/config.site ./configure
...
checking for QT_CORE... yes
checking for QT_GUI... yes
checking for QT_WIDGETS... yes
checking for QT_NETWORK... yes
checking for QT_TEST... yes
checking for QT_DBUS... yes
checking for static Qt... yes
checking for QT_ACCESSIBILITY... yes
checking for QT_DEVICEDISCOVERY... yes
checking for QT_EDID... yes
checking for QT_EVENTDISPATCHER... yes
checking for QT_FB... yes
checking for QT_FONTDATABASE... yes
checking for QT_THEME... yes
checking for QT_INPUT... yes
checking for QT_SERVICE... yes
checking for QT_XCBQPA... yes
checking for QMinimalIntegrationPlugin (-lqminimal)... yes
checking whether the linker accepts -lxcb-shm... yes
checking for QXcbIntegrationPlugin (-lqxcb)... no
configure: WARNING: QXcbIntegrationPlugin not found.; bitcoin-qt frontend will not be built
checking whether to build Bitcoin Core GUI... no
```
config.log excerpt:
```bash
configure:29416: checking for QMinimalIntegrationPlugin (-lqminimal)
configure:29434: g++ -m64 -std=c++17 -o conftest -fPIC -pipe -O2 -fno-extended-identifiers -DQT_NETWORK_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtNetwork -DQT_CORE_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtCore -DQT_WIDGETS_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtWidgets -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtCore -DQT_GUI_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtGui -DQT_CORE_LIB -DQT_GUI_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtGui -DQT_CORE_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtCore -DQT_CORE_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtCore -I/bitcoin/depends/x86_64-pc-linux-musl/include/ -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -L/bitcoin/depends/x86_64-pc-linux-musl/lib conftest.cpp -lqminimal -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5XcbQpa /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5ServiceSupport.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5ThemeSupport.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5FontDatabaseSupport.a -lfontconfig -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lfreetype /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5EdidSupport.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libxcb-static.a -lxcb -lxkbcommon-x11 -lxkbcommon -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5ServiceSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5DBus /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5ThemeSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5FontDatabaseSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lfontconfig -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lfreetype -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5EdidSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5ServiceSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5DBus /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5XcbQpa /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5ServiceSupport.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5ThemeSupport.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5FontDatabaseSupport.a -lfontconfig -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lfreetype /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5EdidSupport.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libxcb-static.a -lxcb -lxkbcommon-x11 -lxkbcommon -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5ServiceSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5DBus /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5ThemeSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5FontDatabaseSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lfontconfig -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lfreetype -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5EdidSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5ThemeSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5FontDatabaseSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lfontconfig -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lfreetype -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5FbSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5EventDispatcherSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5EdidSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5DeviceDiscoverySupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5AccessibilitySupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5Network /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5Widgets /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/plugins/platforms >&5
configure:29434: $? = 0
configure:29435: result: yes
configure:29542: checking whether the linker accepts -lxcb-shm
configure:29561: g++ -m64 -std=c++17 -o conftest -fPIC -pipe -O2 -fno-extended-identifiers -DQT_NETWORK_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtNetwork -DQT_CORE_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtCore -DQT_WIDGETS_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtWidgets -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtCore -DQT_GUI_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtGui -DQT_CORE_LIB -DQT_GUI_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtGui -DQT_CORE_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtCore -DQT_CORE_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtCore -I/bitcoin/depends/x86_64-pc-linux-musl/include/ -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lxcb-shm conftest.cpp >&5
configure:29561: $? = 0
configure:29570: result: yes
configure:29579: checking for QXcbIntegrationPlugin (-lqxcb)
configure:29597: g++ -m64 -std=c++17 -o conftest -fPIC -pipe -O2 -fno-extended-identifiers -DQT_NETWORK_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtNetwork -DQT_CORE_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtCore -DQT_WIDGETS_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtWidgets -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtCore -DQT_GUI_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtGui -DQT_CORE_LIB -DQT_GUI_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtGui -DQT_CORE_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtCore -DQT_CORE_LIB -I/bitcoin/depends/x86_64-pc-linux-musl/include/QtCore -I/bitcoin/depends/x86_64-pc-linux-musl/include/ -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -L/bitcoin/depends/x86_64-pc-linux-musl/lib conftest.cpp -lqxcb -lxcb-shm -lqminimal -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5XcbQpa /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5ServiceSupport.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5ThemeSupport.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5FontDatabaseSupport.a -lfontconfig -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lfreetype /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5EdidSupport.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libxcb-static.a -lxcb -lxkbcommon-x11 -lxkbcommon -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5ServiceSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5DBus /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5ThemeSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5FontDatabaseSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lfontconfig -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lfreetype -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5EdidSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5ServiceSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5DBus /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5XcbQpa /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5ServiceSupport.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5ThemeSupport.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5FontDatabaseSupport.a -lfontconfig -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lfreetype /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5EdidSupport.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libxcb-static.a -lxcb -lxkbcommon-x11 -lxkbcommon -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5ServiceSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5DBus /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5ThemeSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5FontDatabaseSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lfontconfig -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lfreetype -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5EdidSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5ThemeSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5DBus.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5FontDatabaseSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lfontconfig -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lfreetype -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5FbSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5EventDispatcherSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5EdidSupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5DeviceDiscoverySupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5AccessibilitySupport /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5Network /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5Widgets /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Gui.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5Gui /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -lpthread /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtlibpng.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5Core.a -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtharfbuzz.a -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/lib -lQt5Core -lpthread -lm /bitcoin/depends/x86_64-pc-linux-musl/lib/libqtpcre2.a -L/bitcoin/depends/x86_64-pc-linux-musl/plugins/platforms >&5
/usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: /bitcoin/depends/x86_64-pc-linux-musl/lib/libQt5XcbQpa.a(qxcbbackingstore.o): in function `QXcbBackingStoreImage::createShmSegment(unsigned long)':
qxcbbackingstore.cpp:(.text._ZN21QXcbBackingStoreImage16createShmSegmentEm+0x5c): undefined reference to `xcb_shm_create_segment'
/usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: qxcbbackingstore.cpp:(.text._ZN21QXcbBackingStoreImage16createShmSegmentEm+0x6c): undefined reference to `xcb_shm_create_segment_reply'
/usr/lib/gcc/x86_64-alpine-linux-musl/10.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: qxcbbackingstore.cpp:(.text._ZN21QXcbBackingStoreImage16createShmSegmentEm+0x87): undefined reference to `xcb_shm_create_segment_reply_fds'
collect2: error: ld returned 1 exit status
``` | https://github.com/bitcoin/bitcoin/issues/22105 | https://github.com/bitcoin/bitcoin/pull/22174 | 68a89d7a46bf61c2156da3ad68d20095397b943b | fe511454e131749dabd6e51f2c2a68310e32a871 | 2021-05-31T04:06:20Z | c++ | 2021-06-09T07:35:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,085 | ["test/functional/p2p_leak.py"] | qa: Intermittent failure in p2p_leak.py | On master (5c041cb348e667672c8b5ed504dba05adf60783b) Linux32 build (https://bitcoinbuilds.org/index.php?ansilog=d7b3e075-683a-45cc-94d4-9645fc17e0b6.log#l2917):
<details><summary>log excerpt</summary>
<p>
```
L2916 150/205 - p2p_leak.py failed, Duration: 7 s
L2917
L2918 stdout:
L2919 2021-05-27T12:28:03.208000Z TestFramework (INFO): Initializing test directory /tmp/test_runner_₿_🏃_20210527_080707/p2p_leak_52
L2920 2021-05-27T12:28:03.999000Z TestFramework (INFO): Check that the node doesn't send unexpected messages before handshake completion
L2921 2021-05-27T12:28:09.013000Z TestFramework (ERROR): Assertion failed
L2922 Traceback (most recent call last):
L2923 File "/home/ubuntu/src/test/functional/test_framework/test_framework.py", line 128, in main
L2924 self.run_test()
L2925 File "/home/ubuntu/src/test/functional/p2p_leak.py", line 153, in run_test
L2926 assert not no_version_idle_peer.is_connected
L2927 AssertionError
L2928 2021-05-27T12:28:09.065000Z TestFramework (INFO): Stopping nodes
L2929 2021-05-27T12:28:09.567000Z TestFramework (WARNING): Not cleaning up dir /tmp/test_runner_₿_🏃_20210527_080707/p2p_leak_52
L2930 2021-05-27T12:28:09.567000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/test_runner_₿_🏃_20210527_080707/p2p_leak_52/test_framework.log
L2931 2021-05-27T12:28:09.568000Z TestFramework (ERROR):
L2932 2021-05-27T12:28:09.568000Z TestFramework (ERROR): Hint: Call /home/ubuntu/src/test/functional/combine_logs.py '/tmp/test_runner_₿_🏃_20210527_080707/p2p_leak_52' to consolidate all logs
L2933 2021-05-27T12:28:09.568000Z TestFramework (ERROR):
L2934 2021-05-27T12:28:09.568000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
L2935 2021-05-27T12:28:09.568000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues
L2936 2021-05-27T12:28:09.568000Z TestFramework (ERROR):
```
</p>
</details> | https://github.com/bitcoin/bitcoin/issues/22085 | https://github.com/bitcoin/bitcoin/pull/22153 | 346e52afd6d5e317c96fc506bb54cde13e87c8b2 | 8f5c9a7fd41d3ed56798a1c7c142db8d530ab1e2 | 2021-05-27T13:13:44Z | c++ | 2021-06-05T06:38:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,068 | [".cirrus.yml"] | ci: wasted time in brew_install stage of macOS native build | Ever since #21663, which added a `brew update` command, >10% of the runtime of the macOS native CI is spent repetitively doing this update. For example, in this recent build, https://cirrus-ci.com/task/4631533593034752, the `brew_install` stage takes 8m26s to complete..
This seems like something we should be able to avoid. @fkorotkov is it possible for the CI images to be updated to contain a more up to date version of `brew` or similar? | https://github.com/bitcoin/bitcoin/issues/22068 | https://github.com/bitcoin/bitcoin/pull/22122 | 2aab8a6dd0b555d0550a050064623fa7c812364b | fd7a770d32af145461a5e3841e812b9b6541df0b | 2021-05-26T01:31:05Z | c++ | 2021-06-03T05:46:12Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,062 | ["src/test/fuzz/util.h"] | Error when compiling fuzz binary for aarch64-linux-android target | On master (6b254814c076054eedc4311698d16c8971937814):
```
...
CXX test/fuzz/fuzz-addition_overflow.o
CXX test/fuzz/fuzz-addrdb.o
CXX test/fuzz/fuzz-addrman.o
CXX test/fuzz/fuzz-asmap.o
CXX test/fuzz/fuzz-asmap_direct.o
CXX test/fuzz/fuzz-autofile.o
CXX test/fuzz/fuzz-banman.o
In file included from test/fuzz/addition_overflow.cpp:7:
./test/fuzz/util.h:388:15: error: unknown type name 'cookie_io_functions_t'
const cookie_io_functions_t io_hooks = {
^
CXX test/fuzz/fuzz-base_encode_decode.o
In file included from test/fuzz/addrdb.cpp:8:
./test/fuzz/util.h:388:15: error: unknown type name 'cookie_io_functions_t'
const cookie_io_functions_t io_hooks = {
^
CXX test/fuzz/fuzz-bech32.o
1 error generated.
In file included from test/fuzz/addrman.cpp:11:
./test/fuzz/util.h:388:15: error: unknown type name 'cookie_io_functions_t'
const cookie_io_functions_t io_hooks = {
^
make[2]: *** [Makefile:13071: test/fuzz/fuzz-addition_overflow.o] Error 1
make[2]: *** Waiting for unfinished jobs....
1 error generated.
make[2]: *** [Makefile:13085: test/fuzz/fuzz-addrdb.o] Error 1
1 error generated.
make[2]: *** [Makefile:13099: test/fuzz/fuzz-addrman.o] Error 1
In file included from test/fuzz/autofile.cpp:8:
./test/fuzz/util.h:388:15: error: unknown type name 'cookie_io_functions_t'
const cookie_io_functions_t io_hooks = {
^
In file included from test/fuzz/banman.cpp:10:
./test/fuzz/util.h:388:15: error: unknown type name 'cookie_io_functions_t'
const cookie_io_functions_t io_hooks = {
^
1 error generated.
make[2]: *** [Makefile:13141: test/fuzz/fuzz-autofile.o] Error 1
1 error generated.
make[2]: *** [Makefile:13155: test/fuzz/fuzz-banman.o] Error 1
make[2]: Leaving directory '/home/hebasto/GitHub/gui/src'
make[1]: *** [Makefile:16016: all-recursive] Error 1
make[1]: Leaving directory '/home/hebasto/GitHub/gui/src'
make: *** [Makefile:820: all-recursive] Error 1
```
I'm not an expert in Android SDK/NDK peculiarities, so leaving this for more knowledgeable people :) | https://github.com/bitcoin/bitcoin/issues/22062 | https://github.com/bitcoin/bitcoin/pull/22069 | 35b83e6e43159d50179d3e054a6a3de2a690b333 | 48c86eca02030827a0bbe7159e9a452d1ae1e3fc | 2021-05-25T18:18:19Z | c++ | 2021-05-26T05:44:34Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 22,059 | [".cirrus.yml"] | Cirrus CI: Linker OOMKilled | I'm seeing OOMs happen reliably during the linking step in the #19460 Cirrus "[multiprocess, DEBUG] [focal]" build after pushing an update to the PR yesterday to fix a silent merge conflict. Since there is not a big difference between #19640 and #10102, I'm afraid the same problem will happen in all other multiprocess PRs next time I need to update them.
The build output https://cirrus-ci.com/task/5424472971804672 shows a "Container errored with 'OOMKilled'" error during the `CXXLD bitcoin-gui` build step after memory usage spikes to 7.50GB. I've haven't seen this error before, and I'm not sure if it started happening now due to different container settings, or due to different debug build options, or for another reason. I'm not sure what the simplest fix would be either. It doesn't seem like 7.5GB is a huge amount of memory to need for a debug build of a c++ program with some generated code and a lot of template usage, so maybe the container memory limit could just be increased. But at the same time it could also be helpful to know what might have changed recently that could cause the new error, and if there's a simple change to build settings that could be reverted in some other case where we might want to reduce memory usage. | https://github.com/bitcoin/bitcoin/issues/22059 | https://github.com/bitcoin/bitcoin/pull/22061 | 3ad1b8899bfbf87ca4f06c20e8285bc8be31bbe8 | 2e7c3461c0142ca989440d5d7abaed054c7b1e7a | 2021-05-25T14:07:59Z | c++ | 2021-05-26T03:26:26Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,982 | ["src/netaddress.cpp", "src/test/net_tests.cpp"] | Regression: CNetAddr scoped id/zone indices functionality | It's not clear to me if dropping support for this functionality was intentional.
Chain of events:
- #21689 removed test coverage due to a misunderstanding due, I believe, to this functionality being generally supported by all platforms except macOS which does not and returns a different format
- #21756 removed support and caused this regression
- #21690 restores the test coverage that would have caught this regression
Currently, neither the test coverage before #21689 nor the coverage restored by #21690 pass since the merge of #21756.
| https://github.com/bitcoin/bitcoin/issues/21982 | https://github.com/bitcoin/bitcoin/pull/21985 | 2fa3f30050f2db665605c8371b1fd131f39a2f9b | 2fc111b6e3b051b45bc44267c3397cc12cadae3a | 2021-05-17T12:20:54Z | c++ | 2021-05-19T07:22:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,967 | ["src/netaddress.cpp"] | cnetaddr_tostring_canonical_ipv6 test fails during `make check` on fresh clone of repo on macOS 10.14 | **Expected behavior**
`make check` completes successfully when run on a freshly cloned [Bitcoin Core repo](https://github.com/bitcoin/bitcoin).
**Actual behavior**
`make check` fails with the following errors --
```
test/net_tests.cpp:446: error: in "net_tests/cnetaddr_tostring_canonical_ipv6": check net_addr.ToString() == expected_canonical_representation_output has failed [2001:db8::1:1:1:1:1 != 2001:db8:0:1:1:1:1:1]
test/net_tests.cpp:446: error: in "net_tests/cnetaddr_tostring_canonical_ipv6": check net_addr.ToString() == expected_canonical_representation_output has failed [2001:db8::1:1:1:1:1 != 2001:db8:0:1:1:1:1:1]
test/net_tests.cpp:446: error: in "net_tests/cnetaddr_tostring_canonical_ipv6": check net_addr.ToString() == expected_canonical_representation_output has failed [2001:db8::1:1:1:1:1 != 2001:db8:0:1:1:1:1:1]
test/net_tests.cpp:446: error: in "net_tests/cnetaddr_tostring_canonical_ipv6": check net_addr.ToString() == expected_canonical_representation_output has failed [2001:db8:aaaa:bbbb:cccc:dddd::1 != 2001:db8:aaaa:bbbb:cccc:dddd:0:1]
test/net_tests.cpp:446: error: in "net_tests/cnetaddr_tostring_canonical_ipv6": check net_addr.ToString() == expected_canonical_representation_output has failed [2001:db8:aaaa:bbbb:cccc:dddd::1 != 2001:db8:aaaa:bbbb:cccc:dddd:0:1]
...
...
Leaving test module "Bitcoin Core Test Suite"; testing time: 75790us
*** 5 failures are detected in the test module "Bitcoin Core Test Suite"
make[3]: *** [test/net_tests.cpp.test] Error 1
make[2]: *** [check-am] Error 2
make[1]: *** [check-recursive] Error 1
make: *** [check-recursive] Error 1
```
**To reproduce**
1. Follow the build steps available here -- [build-osx.md](https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md) -- on a macOS 10.14. Install all required dependencies and the first set of optional dependencies. Use `Wallet (only SQlite) and GUI Support` configuration.
2. Proceed until the "2. Compile" step under the "Building Bitcoin Core" section, at which point running `make check` will result in the error above.
**System information**
Not running Core yet; this is a build time issue when running `make check` on the bitcoin repo cloned from https://github.com/bitcoin/bitcoin/ master branch at commit c8571486364d6e9ca8c86bd1c81e230ca64f8904.
```
$ ./src/bitcoind -version
Bitcoin Core version v21.99.0-1ef34ee25ed3
```
System Version: macOS 10.14.6 (18G8022)
Processor Name: Intel Core i5
Processor Speed: 1.6 GHz
Number of Processors: 1
Total Number of Cores: 2
L2 Cache (per Core): 256 KB
L3 Cache: 4 MB
Memory: 8 GB
File System: APFS
Physical Drive:
Device Name: APPLE SSD AP0128N
Media Name: AppleAPFSMedia
Medium Type: SSD
Protocol: PCI-Express | https://github.com/bitcoin/bitcoin/issues/21967 | https://github.com/bitcoin/bitcoin/pull/21756 | 1ef34ee25ed34b2b092f15bf3dca5c0508092829 | 7b87fca930ff7129f267906e71be217851146ade | 2021-05-17T03:02:56Z | c++ | 2021-05-17T11:08:14Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,904 | ["src/wallet/db.cpp"] | Crash when opening wallet | Bitcoin Core crashes when trying to open a wallet on Windows because your application logic is nonsensical. When Bitcoin Core was installed, I chose the root level of a dedicated volume (E:) for Bitcoin to store its data on. When I go to open a new wallet, it pegs one CPU core to 100%. Looking at the debug log, it is repeatedly trying to access E:\System Volume Information, and is getting an access denied message because this user doesnt have administrative rights, so it cant access this directory. Your application shouldnt be accessing this directory just to present an open file dialog, and it should be smart enough to throw an exception with an error message to the user and not get stuck in an infinite loop if it encounters problems with file permissions. | https://github.com/bitcoin/bitcoin/issues/21904 | https://github.com/bitcoin/bitcoin/pull/21907 | 386ba92e836387302eb2005b816dd9f972cdb5bc | a31a1ceec721c8b7fb78e657e572c7a621d4d37e | 2021-05-10T13:54:43Z | c++ | 2021-05-13T09:09:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,888 | ["contrib/devtools/security-check.py", "contrib/devtools/test-security-check.py", "depends/packages/boost.mk"] | build: control flow instrumentation not always present in test_bitcoin main | As noticed in #21135, `main` in our macOS and Windows `test_bitcoin` binaries doesn't contain control flow instrumentation. This is because `main` for those binaries is provided by Boost, and when we compile Boost in depends, we don't build with `-fcf-protection=full`, like we do [in configure](https://github.com/bitcoin/bitcoin/blob/5925f1e652768a9502831b9ccf78d16cf3c37d29/configure.ac#L883). The reason the Linux `test_bitcoin` binaries contain instrumentation is because the GCC used to build them is patched by Ubuntu to enable `-fcf-protection=full` by default.
Fixing this isn't as simple as building Boost in depends with `-fcf-protection=full`, because we still support compilers that don't support that option, and we don't currently have a way to test-before-using in depends. However, given that this only affects `test_bitcoin`, and only macOS and Windows, we can probably just do the following:
For macOS, we can actually just build Boost with `-fcf-protection=full`, as our cross-compiler (LLVM Clang 10) supports this option, and any Apple Clang we'd expected to be used for building depends should also support it.
For Windows, the `x86_64-w64-mingw32-g++` in Bionic in based off GCC 7.3.0, and therefore doesn't support `-fcf-protection` (introduced in GCC 8). Given we'd expect users to be cross-compiling for Windows on Bionic for a while longer yet, we can just implement the control flow checks, but skip it for test_bitcoin.
For Linux, we don't need to do anything build wise, just add the instrumentation checks. I would probably prefer to do this when we are using LIEF for Linux. | https://github.com/bitcoin/bitcoin/issues/21888 | https://github.com/bitcoin/bitcoin/pull/23839 | bd482b3ffebc68130f8a18dabf08ed1aff7ea159 | 792d0d8d512cf8ddca200317b74ce550c1a1a428 | 2021-05-09T07:06:35Z | c++ | 2022-01-25T15:01:21Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,885 | ["configure.ac", "doc/developer-notes.md"] | Debugging does not work after commit e507acb (PR #20353) | Not sure if this issue is a bug or the if the the change made in the commit e507acb expects different debugging configuration than the one described below.
**Expected behavior**
If I clone Bitcoin Core from the repository and switch to the commit 2bce932 (the commit prior to e507acb), the debugging (`gdb src/qt/bitcoin-qt` or `gdb src/bitcoind`) will work as expected.
```
git clone https://github.com/bitcoin/bitcoin.git
cd bitcoin
git checkout -b test_commit 2bce932
./autogen.sh
./configure BDB_LIBS="-L${BDB_PREFIX}/lib -ldb_cxx-4.8" BDB_CFLAGS="-I${BDB_PREFIX}/include" --enable-debug
make -j "$(($(nproc)+1))"
gdb src/bitcoind
b init.cpp:1193
(gdb) run -testnet
```
**Actual behavior**
But If I clone the project and debug from e507acb or from any subsequent commit ( such as the current top one 9313c4e6 ) , the `gbd` will not be able to find the files. Shows the message below for any file (in the example, the file is `init.cpp`). The message says that the file does not exist.
```
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Breakpoint 1, AppInitMain (node=..., tip_info=0x0) at init.cpp:1193
1193 init.cpp: No such file or directory.
```
**To reproduce**
```
git clone https://github.com/bitcoin/bitcoin.git
cd bitcoin
git checkout -b test_commit e507acb
./autogen.sh
./configure BDB_LIBS="-L${BDB_PREFIX}/lib -ldb_cxx-4.8" BDB_CFLAGS="-I${BDB_PREFIX}/include" --enable-debug
make -j "$(($(nproc)+1))"
gdb src/bitcoind
b init.cpp:1193
(gdb) run -testnet
```
**System information**
Tested on Ubuntu 20.04 and macOS Big Sur 11.3.
If the change made in the commit e507acb is undone on the local machine, the debugging of the master branch will work normally. | https://github.com/bitcoin/bitcoin/issues/21885 | https://github.com/bitcoin/bitcoin/pull/22409 | 829d3e0e713571c245555d68eb52ead605ddee19 | 5b7210c8745d9572fe94620f848d4ee1304c91a7 | 2021-05-08T22:31:24Z | c++ | 2021-10-11T02:34:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,771 | ["contrib/macdeploy/README.md", "depends/builders/darwin.mk", "depends/hosts/darwin.mk"] | build: Static build behavior depends on the used compiler | The [`qt_mac_applicationIsInDarkMode`](https://github.com/qt/qtbase/blob/5.12.10/src/corelib/kernel/qcore_mac_objc.mm#L217-L227) function
```
bool qt_mac_applicationIsInDarkMode()
{
#if QT_MACOS_PLATFORM_SDK_EQUAL_OR_ABOVE(__MAC_10_14)
if (__builtin_available(macOS 10.14, *)) {
auto appearance = [NSApp.effectiveAppearance bestMatchFromAppearancesWithNames:
@[ NSAppearanceNameAqua, NSAppearanceNameDarkAqua ]];
return [appearance isEqualToString:NSAppearanceNameDarkAqua];
}
#endif
return false;
}
```
behavior depends on the compiler that was used for static build.
It returns `true` or `false` depending on OS appearance setting on old compilers:
- apple clang 10.0.1 on macOS Mojave 10.14.6 (18G8022)
- llvm clang 8.0.0 used in depends
It always returns `false` on newer compilers:
- apple clang 12.0.0 on macOS Catalina 10.15.7 (19H524) and Big Sur 11.2.3 (20D91)
- llvm clang 10.0.1 in depends, see https://github.com/bitcoin/bitcoin/pull/19817#issuecomment-810949389
| https://github.com/bitcoin/bitcoin/issues/21771 | https://github.com/bitcoin/bitcoin/pull/21793 | 13f24d135b280a9ab947f7948f6d86f00104cde1 | bb11a988fa52a081e29441209cd19900bc9c2c80 | 2021-04-24T07:34:23Z | c++ | 2021-05-01T05:38:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,741 | ["src/key_io.cpp", "test/functional/rpc_invalid_address_message.py", "test/functional/wallet_basic.py"] | Error messages for invalid address | Can we add more information in error messages for invalid address especially the errors mentioned in PR: https://github.com/bitcoin/bitcoin/pull/20832/
Example:
Change https://github.com/bitcoin/bitcoin/blob/f385ad765174afb02e60900581612a19c143cf83/src/key_io.cpp#L103
To
```C++
error_str = "Invalid prefix for Bech32 address. Valid Bech32 address starts with `bc1` (mainnet) or `tb1` (testnet)";
```
Context: https://github.com/bitcoin-core/gui/pull/280#issuecomment-820957002 | https://github.com/bitcoin/bitcoin/issues/21741 | https://github.com/bitcoin/bitcoin/pull/26514 | f088949fcfe6ba5000caa2f6adc6803e81925afb | 73a9892bce41585bf99531ebe70678e0a1dc1a44 | 2021-04-21T02:23:41Z | c++ | 2023-03-13T16:57:31Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,717 | ["src/rpc/blockchain.cpp", "test/functional/rpc_blockchain.py"] | Invalid error message for getblock | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
**Expected behavior**
When I make a json-rpc call to `getblock` with:
```json
{
"jsonrpc": "1.0",
"id": "curltest",
"method": "getblock",
"params": ["37351c7060ec3a149af1bbc9ebcc436c0ee652f96559ef1fe9bc45d11000f061", "2"]
}
```
An error should be returned with the [expected data type](https://developer.bitcoin.org/reference/rpc/getblock.html#argument-2-verbosity)(number) for `verbosity`.
<!--- What behavior did you expect? -->
**Actual behavior**
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
Received `"message": "JSON value is not a boolean as expected"` as an error message which is not the [expected data type](number) (https://developer.bitcoin.org/reference/rpc/getblock.html#argument-2-verbosity) for `verbosity`
**To reproduce**
Use this curl on a node
```
curl --location --request POST "127.0.0.1:8332" \
--header "Content-Type: application/json" \
--header "Authorization: Basic YOUR_AUTH" \
--data "{
\"jsonrpc\": \"1.0\",
\"id\": \"curltest\",
\"method\": \"getblock\",
\"params\": [\"37351c7060ec3a149af1bbc9ebcc436c0ee652f96559ef1fe9bc45d11000f061\", \"2\"]
}"
```
**System information**
* self-compiled
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- GUI-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/21717 | https://github.com/bitcoin/bitcoin/pull/21718 | 0dd7b234895b02bfc512ae83bd77b581c861d6e9 | a47ae618a00ca06075caac6dfb1860480086d044 | 2021-04-17T10:52:23Z | c++ | 2021-04-19T06:16:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,705 | ["src/Makefile.test.include"] | build: `make distcheck` fails | On master `585cbe22575306c05b156ea90faa9caa1add4c87` [`make distcheck`](https://www.gnu.org/software/automake/manual/html_node/Checking-the-Distribution.html) fails.
I managed to run it successfully with the following patch:
```diff
--- a/Makefile.am
+++ b/Makefile.am
@@ -342,7 +342,7 @@ EXTRA_DIST += \
CLEANFILES = $(OSX_DMG) $(BITCOIN_WIN_INSTALLER)
-DISTCHECK_CONFIGURE_FLAGS = --enable-man
+DISTCHECK_CONFIGURE_FLAGS = --with-incompatible-bdb --disable-fuzz-binary --disable-tests
doc/doxygen/.stamp: doc/Doxyfile FORCE
$(MKDIR_P) $(@D)
```
Are we interested to support the `distcheck` target? | https://github.com/bitcoin/bitcoin/issues/21705 | https://github.com/bitcoin/bitcoin/pull/25798 | dd62721ba9c154685169588e356315d0787fdf7d | 243d7bde7859777ebe9442477da1b77419bd3f32 | 2021-04-16T12:49:38Z | c++ | 2022-08-11T15:57:12Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,683 | ["test/functional/feature_notifications.py"] | feature_notifications.py cirrus test failure: `IndexError: string index out of range` | https://cirrus-ci.com/task/5589966861369344
```
self.expect_wallet_notify([(bump2, blockheight2, blockhash2), (tx2, -1, UNCONFIRMED_HASH_STRING)])
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/
test/functional/feature_notifications.py", line 172, in expect_wallet_notify
assert_equal(text[-1], '\n')
IndexError: string index out of range
```
Could not reproduce locally.
This is a recent change (March 15, 2021) from 06e1fb0b170 in #21141.
| https://github.com/bitcoin/bitcoin/issues/21683 | https://github.com/bitcoin/bitcoin/pull/21777 | 74a960a220a32b4e240551ba992d5199edac38fc | 683dda2a70e7a210996fa34be23bd0c563971ba9 | 2021-04-14T21:02:30Z | c++ | 2021-04-26T16:04:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,632 | ["ci/test/00_setup_env_native_fuzz_with_msan.sh", "ci/test/00_setup_env_native_msan.sh"] | MemorySanitizer: use-of-uninitialized-value in sqlite3BtreeOpen | From https://github.com/bitcoin/bitcoin/pull/21629/checks?check_run_id=2285803701 (#21629).
```bash
2021-04-07T10:27:19.893068Z [scheduler] [validationinterface.cpp:226] [operator()] BlockConnected: block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f blUninitialized bytes in __interceptor_strcmp at offset 0 inside [0x70100000051c, 1)
==82166==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x557a2f20eabc in sqlite3BtreeOpen (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/test_bitcoin+0x2a60abc)
#1 0x557a2f2077b3 in openDatabase (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/test_bitcoin+0x2a597b3)
#2 0x557a2edb3d65 in SQLiteDatabase::Open() /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/wallet/sqlite.cpp:204:19
#3 0x557a2edaee72 in SQLiteDatabase::SQLiteDatabase(boost::filesystem::path const&, boost::filesystem::path const&, bool) /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/wallet/sqlite.cpp:65:9
#4 0x557a2ed5e878 in std::__1::__unique_if<SQLiteDatabase>::__unique_single std::__1::make_unique<SQLiteDatabase, char const (&) [1], char const (&) [1], bool>(char const (&) [1], char const (&) [1], bool&&) /tmp/cirrus-ci-build/ci/scratch/msan/build/include/c++/v1/memory:3028:32
#5 0x557a2ed4b40b in CreateMockWalletDatabase() /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/wallet/walletdb.cpp:1099:12
#6 0x557a2c934eb8 in WalletTestingSetup::WalletTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/wallet/test/wallet_test_fixture.cpp:9:40
#7 0x557a2d7ba424 in psbt_wallet_tests::parse_hd_keypath::parse_hd_keypath() /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/wallet/test/psbt_wallet_tests.cpp:77:1
#8 0x557a2d7a6ab6 in psbt_wallet_tests::parse_hd_keypath_invoker() /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/wallet/test/psbt_wallet_tests.cpp:77:1
#9 0x557a2ca2e998 in boost::detail::function::void_function_invoker0<void (*)(), void>::invoke(boost::detail::function::function_buffer&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/function/function_template.hpp:117:11
#10 0x557a2f18f6cc in boost::function0<void>::operator()() const /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/function/function_template.hpp:763:14
#11 0x557a2f18f6cc in boost::detail::forward::operator()() /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/test/impl/execution_monitor.ipp:1368:32
#12 0x557a2f18f6cc in boost::detail::function::function_obj_invoker0<boost::detail::forward, int>::invoke(boost::detail::function::function_buffer&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/function/function_template.hpp:137:18
#13 0x557a2f181edf in boost::function0<int>::operator()() const /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/function/function_template.hpp:763:14
#14 0x557a2f181edf in int boost::detail::do_invoke<boost::shared_ptr<boost::detail::translator_holder_base>, boost::function<int ()> >(boost::shared_ptr<boost::detail::translator_holder_base> const&, boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/test/impl/execution_monitor.ipp:290:30
#15 0x557a2f181edf in boost::execution_monitor::catch_signals(boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/test/impl/execution_monitor.ipp:879:16
#16 0x557a2f1825ca in boost::execution_monitor::execute(boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/test/impl/execution_monitor.ipp:1277:16
#17 0x557a2f186f29 in boost::execution_monitor::vexecute(boost::function<void ()> const&) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/test/impl/execution_monitor.ipp:1377:5
#18 0x557a2f09ac73 in boost::unit_test::unit_test_monitor_t::execute_and_translate(boost::function<void ()> const&, unsigned long) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/test/impl/unit_test_monitor.ipp:49:9
#19 0x557a2f00fb22 in boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/test/impl/framework.ipp:823:44
#20 0x557a2f010d47 in boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/test/impl/framework.ipp:792:58
#21 0x557a2f010d47 in boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/test/impl/framework.ipp:792:58
#22 0x557a2effa70b in boost::unit_test::framework::run(unsigned long, bool) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/test/impl/framework.ipp:1696:29
#23 0x557a2f096446 in boost::unit_test::unit_test_main(boost::unit_test::test_suite* (*)(int, char**), int, char**) /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/test/impl/unit_test_main.ipp:248:9
#24 0x557a2f097e10 in main /tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/boost/1_71_0-ae05fff5eee/./boost/test/impl/unit_test_main.ipp:304:12
#25 0x7f79e95570b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
#26 0x557a2c8b01ed in _start (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/test_bitcoin+0x1021ed)
Uninitialized value was created by a heap allocation
#0 0x557a2c8bc4ad in malloc (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/test_bitcoin+0x10e4ad)
#1 0x557a2f2d3032 in sqlite3MemMalloc (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/test_bitcoin+0x2b25032)
SUMMARY: MemorySanitizer: use-of-uninitialized-value (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/test_bitcoin+0x2a60abc) in sqlite3BtreeOpen
Exiting
make[3]: *** [Makefile:17263: wallet/test/psbt_wallet_tests.cpp.test] Error 1
``` | https://github.com/bitcoin/bitcoin/issues/21632 | https://github.com/bitcoin/bitcoin/pull/21865 | f8575bce311886a09e83d5d1918d65e04b3b3faa | 9c05da4a5c57d7fd0fc53817ad6f0a07c0f08b5b | 2021-04-07T12:48:05Z | c++ | 2021-05-06T06:00:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,628 | ["src/dummywallet.cpp", "src/wallet/init.cpp", "src/wallet/sqlite.cpp", "src/wallet/test/wallet_tests.cpp", "test/functional/test_framework/util.py"] | Up to 100x perfomance difference for sqlite vs BDB in CreateWallet test | Building master @ 41a8d2b96ff5cbc2efa9b0996f30228d0a625fdb (sqlite):
```bash
./autogen.sh
./configure --without-bdb --without-gui --with-sqlite
with wallet = yes
with sqlite = yes
with bdb = no
gmake -j8
src/test/test_bitcoin --run_test=wallet_tests --log_level=all
...
wallet/test/wallet_tests.cpp:696: Entering test case "CreateWallet"
wallet/test/wallet_tests.cpp:69: info: check SignTransaction(mtx, &keystore, coins, SIGHASH_ALL, input_errors) has passed
wallet/test/wallet_tests.cpp:69: info: check SignTransaction(mtx, &keystore, coins, SIGHASH_ALL, input_errors) has passed
wallet/test/wallet_tests.cpp:734: info: check m_node.chain->broadcastTransaction(MakeTransactionRef(mempool_tx), DEFAULT_TRANSACTION_MAXFEE, false, error) has passed
wallet/test/wallet_tests.cpp:740: info: check rescan_completed has passed
wallet/test/wallet_tests.cpp:741: info: check addtx_count == 2 has passed
wallet/test/wallet_tests.cpp:744: info: check wallet->mapWallet.count(block_tx.GetHash()) == 1U has passed
wallet/test/wallet_tests.cpp:745: info: check wallet->mapWallet.count(mempool_tx.GetHash()) == 1U has passed
wallet/test/wallet_tests.cpp:753: info: check addtx_count == 4 has passed
wallet/test/wallet_tests.cpp:767: info: check rescan_completed has passed
wallet/test/wallet_tests.cpp:69: info: check SignTransaction(mtx, &keystore, coins, SIGHASH_ALL, input_errors) has passed
wallet/test/wallet_tests.cpp:69: info: check SignTransaction(mtx, &keystore, coins, SIGHASH_ALL, input_errors) has passed
wallet/test/wallet_tests.cpp:772: info: check m_node.chain->broadcastTransaction(MakeTransactionRef(mempool_tx), DEFAULT_TRANSACTION_MAXFEE, false, error) has passed
wallet/test/wallet_tests.cpp:780: info: check addtx_count == 4 has passed
wallet/test/wallet_tests.cpp:783: info: check wallet->mapWallet.count(block_tx.GetHash()) == 1U has passed
wallet/test/wallet_tests.cpp:784: info: check wallet->mapWallet.count(mempool_tx.GetHash()) == 1U has passed
wallet/test/wallet_tests.cpp:696: Leaving test case "CreateWallet"; testing time: 201296644us
wallet/test/wallet_tests.cpp:791: Entering test case "ZapSelectTx"
wallet/test/wallet_tests.cpp:69: info: check SignTransaction(mtx, &keystore, coins, SIGHASH_ALL, input_errors) has passed
wallet/test/wallet_tests.cpp:810: info: check wallet->HasWalletSpend(prev_hash) has passed
wallet/test/wallet_tests.cpp:811: info: check wallet->mapWallet.count(block_hash) == 1u has passed
wallet/test/wallet_tests.cpp:814: info: check wallet->ZapSelectTx(vHashIn, vHashOut) == DBErrors::LOAD_OK has passed
wallet/test/wallet_tests.cpp:816: info: check !wallet->HasWalletSpend(prev_hash) has passed
wallet/test/wallet_tests.cpp:817: info: check wallet->mapWallet.count(block_hash) == 0u has passed
wallet/test/wallet_tests.cpp:791: Leaving test case "ZapSelectTx"; testing time: 200866629us
```
Compare that to running the same tests after building with just bdb:
```bash
gmake clean
./configure --without-gui --with-sqlite=no
with wallet = yes
with sqlite = no
with bdb = yes
gmake -j8
src/test/test_bitcoin --run_test=wallet_tests --log_level=all
...
wallet/test/wallet_tests.cpp:696: Entering test case "CreateWallet"
wallet/test/wallet_tests.cpp:69: info: check SignTransaction(mtx, &keystore, coins, SIGHASH_ALL, input_errors) has passed
wallet/test/wallet_tests.cpp:69: info: check SignTransaction(mtx, &keystore, coins, SIGHASH_ALL, input_errors) has passed
wallet/test/wallet_tests.cpp:734: info: check m_node.chain->broadcastTransaction(MakeTransactionRef(mempool_tx), DEFAULT_TRANSACTION_MAXFEE, false, error) has passed
wallet/test/wallet_tests.cpp:740: info: check rescan_completed has passed
wallet/test/wallet_tests.cpp:741: info: check addtx_count == 2 has passed
wallet/test/wallet_tests.cpp:744: info: check wallet->mapWallet.count(block_tx.GetHash()) == 1U has passed
wallet/test/wallet_tests.cpp:745: info: check wallet->mapWallet.count(mempool_tx.GetHash()) == 1U has passed
wallet/test/wallet_tests.cpp:753: info: check addtx_count == 4 has passed
wallet/test/wallet_tests.cpp:767: info: check rescan_completed has passed
wallet/test/wallet_tests.cpp:69: info: check SignTransaction(mtx, &keystore, coins, SIGHASH_ALL, input_errors) has passed
wallet/test/wallet_tests.cpp:69: info: check SignTransaction(mtx, &keystore, coins, SIGHASH_ALL, input_errors) has passed
wallet/test/wallet_tests.cpp:772: info: check m_node.chain->broadcastTransaction(MakeTransactionRef(mempool_tx), DEFAULT_TRANSACTION_MAXFEE, false, error) has passed
wallet/test/wallet_tests.cpp:780: info: check addtx_count == 4 has passed
wallet/test/wallet_tests.cpp:783: info: check wallet->mapWallet.count(block_tx.GetHash()) == 1U has passed
wallet/test/wallet_tests.cpp:784: info: check wallet->mapWallet.count(mempool_tx.GetHash()) == 1U has passed
wallet/test/wallet_tests.cpp:696: Leaving test case "CreateWallet"; testing time: 2139054us
wallet/test/wallet_tests.cpp:791: Entering test case "ZapSelectTx"
wallet/test/wallet_tests.cpp:69: info: check SignTransaction(mtx, &keystore, coins, SIGHASH_ALL, input_errors) has passed
wallet/test/wallet_tests.cpp:810: info: check wallet->HasWalletSpend(prev_hash) has passed
wallet/test/wallet_tests.cpp:811: info: check wallet->mapWallet.count(block_hash) == 1u has passed
wallet/test/wallet_tests.cpp:814: info: check wallet->ZapSelectTx(vHashIn, vHashOut) == DBErrors::LOAD_OK has passed
wallet/test/wallet_tests.cpp:816: info: check !wallet->HasWalletSpend(prev_hash) has passed
wallet/test/wallet_tests.cpp:817: info: check wallet->mapWallet.count(block_hash) == 0u has passed
wallet/test/wallet_tests.cpp:791: Leaving test case "ZapSelectTx"; testing time: 1821042us
```
In the sqlite case,`CreateWallet` is taking ~100x longer: `201296644us` vs `2139054us`. `ZapWalletTx` is similar: `200866629us` vs `1821042us`. [Full logs here](https://gist.github.com/fanquake/09e983acf0792482534f0fe7e916a03a).
I thought this might be some weird macOS behaviour, but I tested on Linux, and am also seeing up to 27x difference. `CreateWallet`: `27905993us` vs `1092394us`. `ZapWalletTx`: `28024310us` vs `969432us`. [Full logs here](https://gist.github.com/fanquake/a1104888b5574af00a40a9998cfd0b36). | https://github.com/bitcoin/bitcoin/issues/21628 | https://github.com/bitcoin/bitcoin/pull/21634 | 1f14130cb0778d07c7cc5ffccdf8cb5a600ba5df | a1f0b8b62eb851c837a3618583b7c2fd4d12006c | 2021-04-07T06:04:00Z | c++ | 2021-04-13T14:31:12Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,596 | ["src/Makefile.am", "src/test/util_tests.cpp", "src/util/check.cpp", "src/util/check.h", "src/wallet/test/wallet_test_fixture.cpp", "src/wallet/test/wallet_test_fixture.h"] | How to tell compilers to not drop the lock stack when using Assume/Assert? | It would be nice if there was a way to tell compilers not to drop the lock stack and thus issue warnings when accessing a symbol that needs a lock inside `Assume`/`Assert`.
Hit by (at least): @ajtowns , @jnewbery , me. | https://github.com/bitcoin/bitcoin/issues/21596 | https://github.com/bitcoin/bitcoin/pull/24714 | 74b011bbfa3b607606cc7c0ce6e2d22cfd07605a | 87dc1dc55ffaffd782a16c7b50e188433912a617 | 2021-04-04T16:28:01Z | c++ | 2022-03-31T06:18:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,588 | ["depends/packages/qt.mk", "depends/patches/qt/drop_lrelease_dependency.patch", "depends/patches/qt/mac-qmake.conf", "depends/patches/qt/qt.pro", "depends/patches/qt/qttools_src.pro"] | build, qt: Native Qt builds in depends do not work | ## macOS
When doing `% make -C depends qt_configured` the native build is expected:
```
Configure summary:
Build type: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
Compiler: clang (Apple) 12.0.0
Configuration: sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl
Build options:
Mode ................................... release
...
```
Actually, a cross-compile build is configured:
```
Configure summary:
Building on: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
Building for: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
Target compiler: clang (Apple) 12.0.0
Configuration: cross_compile sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl
Build options:
Mode ................................... release
...
```
The reason for this behavior is the line which was added in #21376: https://github.com/bitcoin/bitcoin/blob/e08f3193b543017702d000c2263bccbefa981c14/depends/packages/qt.mk#L116 as the `-device-option` is a cross-compile option, and it triggers cross-compiling.
It is worth to mention that before #21376 native builds with depends on macOS were broken (#14648, #19785).
## Linux x86
Again, no native build when it is expected:
```
$ make -C depends qt_configured
...
Configure summary:
Building on: linux-g++ (x86_64, CPU features: mmx sse sse2)
Building for: linux-g++-64 (x86_64, CPU features: mmx sse sse2)
Target compiler: gcc 9.3.0
Configuration: cross_compile sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl enable_new_dtags f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z dbus reduce_exports static stl
Build options:
Mode ................................... release
...
```
The reason for this behavior is the line which was added in #12971: https://github.com/bitcoin/bitcoin/blob/e08f3193b543017702d000c2263bccbefa981c14/depends/packages/qt.mk#L141 with a [comment](https://github.com/bitcoin/bitcoin/pull/12971#issuecomment-390371544):
> This should fix the gitian build issue
## ARM
Just [broken](https://github.com/bitcoin/bitcoin/issues/18536). | https://github.com/bitcoin/bitcoin/issues/21588 | https://github.com/bitcoin/bitcoin/pull/20641 | b5889611c7ad4e82d71e3390e5e05feca577d8f7 | 4315dc02a1ebc6003d1ef8789490ba4442861a6b | 2021-04-03T23:22:11Z | c++ | 2021-07-18T06:05:39Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,545 | ["src/init.cpp", "src/net_processing.cpp", "src/validation.h"] | feefilter cleanups | There are some potential feefilter cleanups mentioned and motivated in comment https://github.com/bitcoin/bitcoin/pull/21509#issuecomment-805808485 . If you address the locking one, please be careful and make sure that `round()` is only called under a lock. See https://github.com/bitcoin/bitcoin/pull/21509#issuecomment-807992199
#### Useful skills:
* Bitcoin protocol messages
* Bitcoin Core P2P design
* Running our unit and functional tests
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/21545 | https://github.com/bitcoin/bitcoin/pull/21992 | 0a909073dc6c9090179b8adedacce288d619d255 | aeecb1c2eb57bcdf0f1be4682a5d0b79b5470e57 | 2021-03-29T10:02:15Z | c++ | 2021-05-25T06:42:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,485 | ["build-aux/m4/l_socket.m4", "configure.ac", "src/net.cpp", "src/randomenv.cpp"] | (v0.20.1) Not compiling on Illumos/SmartOS | ```
$ bmake
=> Bootstrap dependency digest>=20010302: found digest-20190127
===> Building for bitcoin-0.20.1nb3
Making all in src
gmake[1]: Entering directory '/home/pbulk/build/finance/bitcoin/work/bitcoin-0.20.1/src'
gmake[2]: Entering directory '/home/pbulk/build/finance/bitcoin/work/bitcoin-0.20.1/src'
gmake[3]: Entering directory '/home/pbulk/build/finance/bitcoin/work/bitcoin-0.20.1'
gmake[3]: Leaving directory '/home/pbulk/build/finance/bitcoin/work/bitcoin-0.20.1'
CXXLD bitcoin-tx
Undefined first referenced
symbol in file
freeifaddrs libbitcoin_util.a(libbitcoin_util_a-randomenv.o)
getifaddrs libbitcoin_util.a(libbitcoin_util_a-randomenv.o)
ld: fatal: symbol referencing errors. No output written to .libs/bitcoin-tx
collect2: error: ld returned 1 exit status
gmake[2]: *** [Makefile:7355: bitcoin-tx] Error 1
gmake[2]: Leaving directory '/home/pbulk/build/finance/bitcoin/work/bitcoin-0.20.1/src'
gmake[1]: *** [Makefile:17263: all-recursive] Error 1
gmake[1]: Leaving directory '/home/pbulk/build/finance/bitcoin/work/bitcoin-0.20.1/src'
gmake: *** [Makefile:782: all-recursive] Error 1
*** Error code 2
Stop.
bmake[1]: stopped in /data/pkgsrc/finance/bitcoin
*** Error code 1
```
I found [this](https://github.com/pydron/ifaddr/issues/23), which seems to be the same issue, but on a Python context.
Previous issues with compiling on Illumos seem to have been sorted out (#15708 & more), but now it's stuck here. | https://github.com/bitcoin/bitcoin/issues/21485 | https://github.com/bitcoin/bitcoin/pull/21486 | e4a2918238559e0b82e287833f51b321b97518ab | b14462083f82aeaa9a376978f210db5538db296f | 2021-03-20T09:49:52Z | c++ | 2021-03-31T06:38:06Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,466 | ["src/netaddress.cpp"] | Avoid use of "socket" syscall when formatting IP addresses in CNetAddr::ToString | When fuzzing our codebase in a restricted syscall setup I noticed that calling `CNetAddr::ToString` triggers the use of the `socket` syscall. The syscall is made indirectly via `getnameinfo`.
AFAICT `getnameinfo` is used in our code only to format IPv6 addresses in their "shortened" form. I think our formatting only use case should be possible to fully cover without involving the kernel via `socket` :)
Not a big deal of course, but it would be nice if kept the direct and indirect use of networking related syscalls such as `socket` to functions where they cannot be avoided. That would make reasoning about syscall restrictions and/or application-vs-kernel boundaries somewhat easier.
The call chain is: `CNetAddr::ToString` > `CNetAddr::ToStringIP` > `getnameinfo` > `gni_host` > `gni_host_inet` > `gni_host_inet_numeric` > `if_indextoname` > `__opensock` > `socket`.
Live demo:
```
$ FUZZ=netaddress src/test/fuzz/fuzz
…
ERROR: The syscall "socket" (syscall number 41) is not allowed by the syscall sandbox in thread "test". Please report. Exiting.
terminate called without an active exception
==13417== ERROR: libFuzzer: deadly signal
#0 0x5581be296819 in __sanitizer_print_stack_trace compiler-rt/lib/ubsan/ubsan_diag_standalone.cpp:33
#1 0x5581be22e9f8 in fuzzer::PrintStackTrace() compiler-rt/lib/fuzzer/FuzzerUtil.cpp:210 #2 0x5581be15a14a in fuzzer::Fuzzer::CrashCallback() (.part.48) compiler-rt/lib/fuzzer/FuzzerLoop.cpp:233
#3 0x5581be20ab47 in fuzzer::Fuzzer::CrashCallback() compiler-rt/lib/fuzzer/FuzzerLoop.cpp:205
#4 0x5581be20ab47 in fuzzer::Fuzzer::StaticCrashSignalCallback() compiler-rt/lib/fuzzer/FuzzerLoop.cpp:204
#5 0x7f3139b2089f (/lib/x86_64-linux-gnu/libpthread.so.0+0x1289f)
#6 0x7f3138526f46 in __libc_signal_restore_set /build/glibc-2ORdQG/glibc-2.27/signal/../sysdeps/unix/sysv/linux/nptl-signals.h:80
#7 0x7f3138526f46 in raise /build/glibc-2ORdQG/glibc-2.27/signal/../sysdeps/unix/sysv/linux/raise.c:48
#8 0x7f31385288b0 in abort /build/glibc-2ORdQG/glibc-2.27/stdlib/abort.c:79
#9 0x7f3139db9956 (/usr/lib/x86_64-linux-gnu/libstdc++.so.6+0x8c956)
#10 0x7f3139dbfae5 (/usr/lib/x86_64-linux-gnu/libstdc++.so.6+0x92ae5)
#11 0x7f3139dbfb20 in std::terminate() (/usr/lib/x86_64-linux-gnu/libstdc++.so.6+0x92b20)
#12 0x5581bec4e6f7 in (anonymous namespace)::SyscallSandboxDebugSignalHandler(int, siginfo_t*, void*) src/util/syscall_sandbox.cpp:71:5
#13 0x7f3139b2089f (/lib/x86_64-linux-gnu/libpthread.so.0+0x1289f)
#14 0x7f313860b076 in socket /build/glibc-2ORdQG/glibc-2.27/socket/../sysdeps/unix/syscall-template.S:78
#15 0x7f313860b2b0 in __opensock /build/glibc-2ORdQG/glibc-2.27/socket/../sysdeps/unix/sysv/linux/opensock.c:100
#16 0x7f3138626fd3 in if_indextoname /build/glibc-2ORdQG/glibc-2.27/inet/../sysdeps/unix/sysv/linux/if_index.c:226
#17 0x7f3138626abd in gni_host_inet_numeric /build/glibc-2ORdQG/glibc-2.27/inet/getnameinfo.c:354
#18 0x7f3138626abd in gni_host_inet /build/glibc-2ORdQG/glibc-2.27/inet/getnameinfo.c:389
#19 0x7f3138626abd in gni_host /build/glibc-2ORdQG/glibc-2.27/inet/getnameinfo.c:422
#20 0x7f3138626abd in getnameinfo /build/glibc-2ORdQG/glibc-2.27/inet/getnameinfo.c:539
#21 0x5581beab72e3 in CNetAddr::ToStringIP[abi:cxx11]() const src/netaddress.cpp:580:18
…
``` | https://github.com/bitcoin/bitcoin/issues/21466 | https://github.com/bitcoin/bitcoin/pull/21756 | 1ef34ee25ed34b2b092f15bf3dca5c0508092829 | 7b87fca930ff7129f267906e71be217851146ade | 2021-03-18T11:00:19Z | c++ | 2021-05-17T11:08:14Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,465 | [".tx/config", "build-aux/m4/bitcoin_qt.m4", "depends/packages/qt.mk", "src/Makefile.qt.include", "src/qt/addressbookpage.cpp", "src/qt/bitcoinstrings.cpp", "src/qt/locale/bitcoin_en.ts", "src/qt/locale/bitcoin_en.xlf"] | translation: Provide more context to Transifex translators | ### The Problem
Using native Qt translation files (TS, `*.ts`) for exchanging with Transifex platform limits means to provide context
to translators to the only category:
| C++ source code | TS XML element | Transifex metadata
|-----------------------------------------------|------------------------------------------------|:------------------:
| Class Name | `<name>`ClassName`</name>` | Context
| `disambiguation` parameter of `tr()` function | `<comment>`Short comment`</comment>` | N/A
| [Translator Comments](https://doc.qt.io/qt-5/i18n-source-translation.html#translator-comments) `//: ...` | `<extracomment>`Nice comment.`</extracomment>` | N/A
More details:
- https://docs.transifex.com/formats/introduction
- https://docs.transifex.com/formats/qt-ts
- https://doc.qt.io/qt-5/linguist-ts-file-format.html
### The Solution
[XLIFF](https://en.wikipedia.org/wiki/XLIFF) file format is supported by Transifex much better.
And Qt provides us with a stand-alone conversion tool `lconvert`.
```sh
$ lconvert -o bitcoin_es.xlf -i bitcoin_en.ts
```
Now more context options are available:
| TS XML element | XLIFF XML element | Transifex metadata
|------------------------------------------------|-------------------------------------------------|:------------------:
| `<name>`ClassName`</name>` | `<group resname="ClassName">`...`</group>` | yes
| `<comment>`Short comment`</comment>` | `<context>`Short comment`</context>` | yes
| `<extracomment>`Nice comment.`</extracomment>` | `<note from="developer">`Nice comment.`</note>` | yes
More details:
- https://docs.transifex.com/formats/xliff
- https://code.qt.io/cgit/qt/qttools.git/tree/src/linguist/lconvert/lconvert.pro?h=5.12.10
---
Looking for Concept (N)ACKs. | https://github.com/bitcoin/bitcoin/issues/21465 | https://github.com/bitcoin/bitcoin/pull/21694 | 018045347110d76cfc1f89a79fb49a867e3b8449 | 90e0faaa442b6ced94aee2fa9d9d21c4063d76be | 2021-03-18T00:10:32Z | c++ | 2021-04-20T14:10:24Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,461 | ["src/test/fuzz/fuzz.cpp"] | fuzz: Make it possible to execute each file in a directory without fuzz engine | This functionality is provided by libFuzzer, which is available on most platforms. However, libFuzzer is also missing on some platforms. E.g. https://github.com/google/sanitizers/issues/1165
Thus, it could make sense to implement this in our code to be able to execute the existing fuzz inputs.
The basic idea is to check if a folder was passed into `main` (https://github.com/bitcoin/bitcoin/blob/63314b8211d795b2bf0814e244d801e74f50b152/src/test/fuzz/fuzz.cpp#L75) and then iterate over the files and pass them into `test_one_input`.
#### Useful skills:
* C++17 std::filesystem
* https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/21461 | https://github.com/bitcoin/bitcoin/pull/24472 | 601bfc417d1fb3ac78cda9477814df319182599f | bf2c0fb2a26432762bf98e19a98e252b7bdd7d30 | 2021-03-17T18:41:17Z | c++ | 2022-03-17T07:26:57Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,448 | ["test/functional/feature_config_args.py"] | test: Intermittent failure in feature_config_args | What looks like an intermittent failure in `feature_config_args.py` happened in CI testing of #21407.
https://cirrus-ci.com/task/5952013763608576
```
test 2021-03-16T11:11:46.877000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 128, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_config_args.py", line 219, in run_test
self.test_seed_peers()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_config_args.py", line 214, in test_seed_peers
self.nodes[0].setmocktime(start + 65)
File "/usr/lib/python3.6/contextlib.py", line 88, in __exit__
next(self.gen)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_node.py", line 400, in assert_debug_log
self._raise_assertion_error('Expected messages "{}" does not partially match log:\n\n{}\n\n'.format(str(expected_msgs), print_log))
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_node.py", line 166, in _raise_assertion_error
raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected messages "['Adding fixed seeds as 60 seconds have passed and addrman is empty']" does not partially match log:
- 2021-03-16T11:10:26.849988Z (mocktime: 2021-03-16T11:10:26Z) [httpserver.cpp:238] [http_request_cb] Received a POST request for / from 127.0.0.1:35268
- 2021-03-16T11:10:26.850095Z (mocktime: 2021-03-16T11:10:26Z) [rpc/request.cpp:174] [parse] ThreadRPCServer method=setmocktime user=__cookie__
- 2021-03-16T11:10:26.853443Z (mocktime: 2021-03-16T11:11:31Z) [util/system.h:468] [TraceThread] msghand thread start
- 2021-03-16T11:10:26.853489Z (mocktime: 2021-03-16T11:11:31Z) [util/system.h:468] [TraceThread] opencon thread start
- 2021-03-16T11:10:26.853541Z (mocktime: 2021-03-16T11:11:31Z) [util/system.h:468] [TraceThread] addcon thread start
- 2021-03-16T11:10:26.853580Z (mocktime: 2021-03-16T11:11:31Z) [net.cpp:394] [ConnectNode] trying connection fakenodeaddr lastseen=0.0hrs
- 2021-03-16T11:10:26.854222Z (mocktime: 2021-03-16T11:11:31Z) [util/system.h:468] [TraceThread] net thread start
- 2021-03-16T11:11:26.797916Z (mocktime: 2021-03-16T11:11:31Z) [random.cpp:523] [SeedPeriodic] Feeding 14413 bytes of dynamic environment data into RNG
- 2021-03-16T11:11:27.362393Z (mocktime: 2021-03-16T11:11:31Z) [net.cpp:394] [ConnectNode] trying connection fakenodeaddr lastseen=0.0hrs
```
It is expecting the messsage "Adding fixed seeds as 60 seconds have passed and addrman is empty" but is not getting it. | https://github.com/bitcoin/bitcoin/issues/21448 | https://github.com/bitcoin/bitcoin/pull/21814 | 576300afb0ec486a361f4c69d1c4c1d7bc127671 | a0f46028fcd20a6e71adbb616c1921a2ebdb4aa0 | 2021-03-16T11:37:49Z | c++ | 2021-05-05T14:46:24Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,379 | ["src/Makefile.test.include", "src/node/blockstorage.cpp", "src/node/blockstorage.h", "src/test/blockmanager_tests.cpp", "src/validation.cpp"] | Reindex subtly corrupts blknnnnn.dat files and causes subsequent deserialization errors | **Summary**
When block downloads restart after a reindex of block files, spurious bytes are inserted in the blk.dat file. A subsequent reindex will show a deserialization error in the log file.
**Test system**
CentOS 7, Bitcoin Core v0.21.0 pre-built binaries and reproduced going back to 0.10.3!
**Problem Description**
Performing a reindex of the block files reliably introduces spurious bytes, resulting in subsequent deserialization errors.
At the point where block downloads resume and are added to the blk.dat file, 8 extra bytes are introduced in front of the first new data block. Depending on the scenario, these 8 bytes are either all 0's, or a valid message start string (0xf9beb4d9 "magic" sequence) followed by 4 more bytes. Normal blocks of \<magic> \<length> \<raw block> resume after these 8 bytes.
Investigation revealed that the 4 bytes after the magic were actually the length of a previously existing block in the blk.dat file that had been overwritten.
It appears what is happening is that after reindexing, a file position is calculated for adding newly downloaded blocks, and this position is incorrectly computed to be 8 bytes beyond the proper place. If the insert position is at the end of the file, the intervening 8 bytes are zero filled. If the insert position overwrites pre-existing blocks, the first 8 bytes of the overwritten block(s) are left behind.
It appears the problem results from an inconsistency in the operation of FindBlockPos during reindexing, when it returns file positions at the beginning of the raw block, as opposed to the end of previous block/beginning of the magic.
The block reading algorithm is apparently able to recover and continue, so this problem is not fatal. Inspection of the debug.log shows "LoadExternalBlockFile: Deserialize or I/O error" when it occurs. To be clear, the first reindex doesn't show this error, but causes the problem such that a subsequent reindex will generate it.
Researching old issues, I suspect this problem contributed to symptoms observed in issues #6492 and #14933. It also looks like like #5864 might have been an attempt to address this or a similar problem.
**Reproduction Scenarios**
These scenarios are rather contrived, but are the simplest ones I could come up with to quickly and reliably demonstrate the issue.
**Scenario 1**
To create a deterministic scenario, this example uses what I'll refer to as "canonical" block files. That is, block files where the chain blocks are stored in-order up to the file size limit of 128M. Thus, the canonical blk00000.dat file has the following properties:
size: 134214363
blocks: 119965 (up to height 119964)
SHA-256: fe4b764e0ce523cfce6d9e4f326e0d0977ee317a51b4a129cda707cfa4699dd7
1) Start with a "canonical" blk00000.dat as the only file in a new data dir
2) Start up bitcoin-qt with -reindex.
3) Once the reindex completes and block downloads resume over the network, terminate the process.
In the debug.log, you should see:
2021-03-06T21:41:52Z Leaving block file 0: CBlockFileInfo(blocks=119965, size=134214371, heights=0...119964, time=2009-01-03...2011-04-24)
Note that the size has grown by 8 bytes. Inspection of hexdumps show 8 extra zero bytes at the end of the file.
Before reindex:
```
07fff2c0 14 9f ce 4e af a6 17 17 d9 24 b1 d0 9b 30 28 3d |...N.....$...0(=|
07fff2d0 ee a3 f1 e3 fd 88 ac 00 00 00 00 |...........|
```
After reindex:
```
07fff2c0 14 9f ce 4e af a6 17 17 d9 24 b1 d0 9b 30 28 3d |...N.....$...0(=|
07fff2d0 ee a3 f1 e3 fd 88 ac 00 00 00 00 00 00 00 00 00 |................|
07fff2e0 00 00 00 |...|
```
In this scenario, blk00000.dat is "full", so the new block will go in blk00001.dat. But, in the process of testing blk00000.dat to see if the new block can be appended, it appears an incorrect file pointer offset winds up adding 8 bytes to the file.
**Scenario 2 part 1**
The results of this scenario are more variable due to the random ordering of blocks resulting from parallel block downloads.
1) Start with a blk00000.dat and blk00001.dat containing out-of-order blocks from a parallel block download.
2) Perform a reindex on these block files.
3) Wait past header synchronization until new block downloads resume over the network (blk00002.dat is created), then shut the process down.
What you should discover upon inspection of blk00001.dat is that the file has been changed, and at the point where the content changes, the spurious magic and length bytes will appear. This will be somewhere near but not at the end of the file. (It appears that the insert point is after the last block that could be verified to be part of the main chain; because of parallel block downloads, some remaining blocks that couldn't be attached are overwritten.) An example from my run:
Before reindex:
```
07f788d0 88 ac 00 00 00 00 f9 be b4 d9 ad bf 00 00 01 00 |................|
07f788e0 00 00 ea 8d fd 5c 0e 23 08 c8 b3 a6 73 61 5d fa |.....\.#....sa].|
```
Note magic at offset 0x07f788d6, block length of 0x0000bfad, version 0x01 byte from raw block
After reindex:
```
07f788d0 88 ac 00 00 00 00 f9 be b4 d9 ad bf 00 00 f9 be |................|
07f788e0 b4 d9 61 bf 00 00 01 00 00 00 c3 70 ca 79 eb ed |..a........p.y..|
```
Note magic at offset 0x07f788d6, length of 0x0000bfad as before, but now followed by another magic and a length 0x0000bf61 before getting to the version 0x01.
**Scenario 2 part 2**
1) Save a copy of the block files resulting from the end of the previous scenario.
2) Start another reindex using those files. Again, wait until new block downloads resume, then shut down.
In the debug.log, you should find the following where the corrupted block file was processed:
2021-03-06T22:19:55Z LoadExternalBlockFile: Deserialize or I/O error - ReadCompactSize(): size too large: iostream error
Depending on exactly how things go off the rails, the error could appear as:
2021-03-06T23:07:48Z LoadExternalBlockFile: Deserialize or I/O error - Read attempted past buffer limit: iostream error
If you inspect your last block file from the first reindex and compare it to its state after the second reindex, you should find a second instance of the spurious magic+length bytes.
If you perform another reindex with the block files as they stand now, you'll get two deserialize errors in the debug log. Each additional reindex will add another instance.
| https://github.com/bitcoin/bitcoin/issues/21379 | https://github.com/bitcoin/bitcoin/pull/24858 | 1d277f42236d6074ea84c407ae0863ae943f27e4 | cc12b8947b6d3f6c4b9cd4d147543dce693c6758 | 2021-03-07T03:55:03Z | c++ | 2022-10-12T18:13:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,369 | ["src/test/fuzz/util.h"] | FuzzedSock compiler warnings when building current master | ```
CXX test/fuzz/fuzz-addition_overflow.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/addition_overflow.cpp:7:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/addition_overflow.cpp:7:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-addrdb.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/addrdb.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/addrdb.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-addrman.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/addrman.cpp:11:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/addrman.cpp:11:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-asmap.o
CXX test/fuzz/fuzz-asmap_direct.o
CXX test/fuzz/fuzz-autofile.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/autofile.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/autofile.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-banman.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/banman.cpp:10:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/banman.cpp:10:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-base_encode_decode.o
CXX test/fuzz/fuzz-bech32.o
CXX test/fuzz/fuzz-block.o
CXX test/fuzz/fuzz-block_header.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/block_header.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/block_header.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-blockfilter.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/blockfilter.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/blockfilter.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-bloom_filter.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/bloom_filter.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/bloom_filter.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-buffered_file.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/buffered_file.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/buffered_file.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-chain.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/chain.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/chain.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-checkqueue.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/checkqueue.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/checkqueue.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-coins_view.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/coins_view.cpp:18:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/coins_view.cpp:18:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-connman.o
In file included from ./i2p.h:13,
from ./net.h:17,
from test/fuzz/connman.cpp:7:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/connman.cpp:12:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-crypto.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/crypto.cpp:15:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/crypto.cpp:15:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-crypto_aes256.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/crypto_aes256.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/crypto_aes256.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-crypto_aes256cbc.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/crypto_aes256cbc.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/crypto_aes256cbc.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-crypto_chacha20.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/crypto_chacha20.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/crypto_chacha20.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-crypto_chacha20_poly1305_aead.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/crypto_chacha20_poly1305_aead.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/crypto_chacha20_poly1305_aead.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-crypto_common.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/crypto_common.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/crypto_common.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-crypto_hkdf_hmac_sha256_l32.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/crypto_hkdf_hmac_sha256_l32.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/crypto_hkdf_hmac_sha256_l32.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-crypto_poly1305.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/crypto_poly1305.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/crypto_poly1305.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-cuckoocache.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/cuckoocache.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/cuckoocache.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-data_stream.o
In file included from ./i2p.h:13,
from ./net.h:17,
from test/fuzz/data_stream.cpp:6:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/data_stream.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-decode_tx.o
CXX test/fuzz/fuzz-descriptor_parse.o
CXX test/fuzz/fuzz-deserialize.o
CXX test/fuzz/fuzz-eval_script.o
CXX test/fuzz/fuzz-fee_rate.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/fee_rate.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/fee_rate.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-fees.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/fees.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/fees.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-flatfile.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/flatfile.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/flatfile.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-float.o
CXX test/fuzz/fuzz-golomb_rice.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/golomb_rice.cpp:10:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/golomb_rice.cpp:10:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-hex.o
CXX test/fuzz/fuzz-http_request.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/http_request.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/http_request.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-integer.o
In file included from ./netbase.h:15,
from test/fuzz/integer.cpp:14:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/integer.cpp:26:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-key.o
CXX test/fuzz/fuzz-key_io.o
CXX test/fuzz/fuzz-kitchen_sink.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/kitchen_sink.cpp:10:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/kitchen_sink.cpp:10:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-load_external_block_file.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/load_external_block_file.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/load_external_block_file.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-locale.o
CXX test/fuzz/fuzz-merkleblock.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/merkleblock.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/merkleblock.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-message.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/message.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/message.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-muhash.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/muhash.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/muhash.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-multiplication_overflow.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/multiplication_overflow.cpp:7:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/multiplication_overflow.cpp:7:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-net.o
In file included from ./i2p.h:13,
from ./net.h:17,
from test/fuzz/net.cpp:7:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/net.cpp:15:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-net_permissions.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/net_permissions.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/net_permissions.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-netaddress.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/netaddress.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/netaddress.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-node_eviction.o
In file included from ./i2p.h:13,
from ./net.h:17,
from test/fuzz/node_eviction.cpp:5:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/node_eviction.cpp:10:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-p2p_transport_deserializer.o
CXX test/fuzz/fuzz-parse_hd_keypath.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/parse_hd_keypath.cpp:7:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/parse_hd_keypath.cpp:7:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-parse_iso8601.o
CXX test/fuzz/fuzz-parse_numbers.o
CXX test/fuzz/fuzz-parse_script.o
CXX test/fuzz/fuzz-parse_univalue.o
CXX test/fuzz/fuzz-policy_estimator.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/policy_estimator.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/policy_estimator.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-policy_estimator_io.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/policy_estimator_io.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/policy_estimator_io.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-pow.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/pow.cpp:11:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/pow.cpp:11:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-prevector.o
CXX test/fuzz/fuzz-primitives_transaction.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/primitives_transaction.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/primitives_transaction.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-process_message.o
In file included from ./i2p.h:13,
from ./net.h:17,
from test/fuzz/process_message.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/process_message.cpp:16:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-process_messages.o
In file included from ./i2p.h:13,
from ./net.h:17,
from test/fuzz/process_messages.cpp:6:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/process_messages.cpp:11:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-protocol.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/protocol.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/protocol.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-psbt.o
CXX test/fuzz/fuzz-random.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/random.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/random.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-rbf.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/rbf.cpp:10:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/rbf.cpp:10:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-rolling_bloom_filter.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/rolling_bloom_filter.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/rolling_bloom_filter.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-script.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/script.cpp:21:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/script.cpp:21:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-script_assets_test_minimizer.o
CXX test/fuzz/fuzz-script_bitcoin_consensus.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/script_bitcoin_consensus.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/script_bitcoin_consensus.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-script_descriptor_cache.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/script_descriptor_cache.cpp:10:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/script_descriptor_cache.cpp:10:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-script_flags.o
CXX test/fuzz/fuzz-script_interpreter.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/script_interpreter.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/script_interpreter.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-script_ops.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/script_ops.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/script_ops.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-script_sigcache.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/script_sigcache.cpp:12:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/script_sigcache.cpp:12:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-script_sign.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/script_sign.cpp:15:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/script_sign.cpp:15:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-scriptnum_ops.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/scriptnum_ops.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/scriptnum_ops.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-secp256k1_ec_seckey_import_export_der.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/secp256k1_ec_seckey_import_export_der.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/secp256k1_ec_seckey_import_export_der.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-secp256k1_ecdsa_signature_parse_der_lax.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/secp256k1_ecdsa_signature_parse_der_lax.cpp:9:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/secp256k1_ecdsa_signature_parse_der_lax.cpp:9:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-signature_checker.o
CXX test/fuzz/fuzz-signet.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/signet.cpp:12:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/signet.cpp:12:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-socks5.o
In file included from ./netbase.h:15,
from test/fuzz/socks5.cpp:5:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/socks5.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-span.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/span.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/span.cpp:8:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-spanparsing.o
CXX test/fuzz/fuzz-string.o
In file included from ./netbase.h:15,
from test/fuzz/string.cpp:8:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/string.cpp:20:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-strprintf.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/strprintf.cpp:7:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/strprintf.cpp:7:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-system.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/system.cpp:7:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/system.cpp:7:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-timedata.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/timedata.cpp:7:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/timedata.cpp:7:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-torcontrol.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/torcontrol.cpp:7:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/torcontrol.cpp:7:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
CXX test/fuzz/fuzz-transaction.o
CXX test/fuzz/fuzz-tx_in.o
CXX test/fuzz/fuzz-tx_out.o
CXX test/fuzz/fuzz-txrequest.o
CXX test/fuzz/libtest_fuzz_a-fuzz.o
CXX test/fuzz/libtest_fuzz_a-util.o
In file included from ./i2p.h:13,
from ./net.h:17,
from ./test/fuzz/util.h:16,
from test/fuzz/util.cpp:5:
./util/sock.h:61:19: warning: ‘virtual Sock& Sock::operator=(Sock&&)’ was hidden [-Woverloaded-virtual]
61 | virtual Sock& operator=(Sock&& other);
| ^~~~~~~~
In file included from test/fuzz/util.cpp:5:
./test/fuzz/util.h:533:7: warning: by ‘FuzzedSock& FuzzedSock::operator=(const FuzzedSock&)’ [-Woverloaded-virtual]
533 | class FuzzedSock : public Sock
| ^~~~~~~~~~
AR libtest_fuzz.a
```
```
$ gcc --version
gcc (Gentoo 9.3.0-r1 p3) 9.3.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
```
```
$ git log | head -n 1
commit ed25cb58f605ba583c735f330482df0bf9348f3a
``` | https://github.com/bitcoin/bitcoin/issues/21369 | https://github.com/bitcoin/bitcoin/pull/21371 | e797388f8b91235c06a9589e3258c476c837f897 | a22653a636e8dfc1b898ef8dd18a77f2d31082a5 | 2021-03-05T10:07:53Z | c++ | 2021-03-08T07:23:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,368 | ["doc/release-notes-23113.md", "src/rpc/misc.cpp", "src/wallet/rpc/addresses.cpp", "test/functional/rpc_createmultisig.py"] | createmultisig with uncompressed pubkeys ignores value of addr_type enum | Tested in v0.21.0
```
createmultisig 1 '["04ceba29da1af96a0f2ef7cda6950b8be2baeb1adf12c0d5efebb70dbcaa086ba029cd82a0cfb8dedf65b8760cf271f2b8a50466bbf0b9339c5ffefbe2a4165326"]' p2sh-segwit
{
"address": "3LfGXVPHtrC9A99JNiAPnygnQuPdpASvN3",
"redeemScript": "514104ceba29da1af96a0f2ef7cda6950b8be2baeb1adf12c0d5efebb70dbcaa086ba029cd82a0cfb8dedf65b8760cf271f2b8a50466bbf0b9339c5ffefbe2a416532651ae",
"descriptor": "sh(multi(1,04ceba29da1af96a0f2ef7cda6950b8be2baeb1adf12c0d5efebb70dbcaa086ba029cd82a0cfb8dedf65b8760cf271f2b8a50466bbf0b9339c5ffefbe2a4165326))#dyera70q"
}
```
same result for:
```
createmultisig 1 '["04ceba29da1af96a0f2ef7cda6950b8be2baeb1adf12c0d5efebb70dbcaa086ba029cd82a0cfb8dedf65b8760cf271f2b8a50466bbf0b9339c5ffefbe2a4165326"]' bech32
```
Best if this throws an error telling the user it won't make a nonstandard address.
| https://github.com/bitcoin/bitcoin/issues/21368 | https://github.com/bitcoin/bitcoin/pull/23113 | 90deb9f980d02b9ca4000a78baa2beb15a5f1bbd | ac92ab6da58e34993d0641b98eef5b5f55b6cbf9 | 2021-03-05T07:56:23Z | c++ | 2021-12-11T08:41:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,356 | ["test/functional/mining_basic.py", "test/functional/rpc_blockchain.py"] | Year 2038 time bug | In 2038 the epoch time run out of bits and that makes it need more bits to represent the correct datetime.
https://en.wikipedia.org/wiki/Year_2038_problem
| https://github.com/bitcoin/bitcoin/issues/21356 | https://github.com/bitcoin/bitcoin/pull/26259 | 085f83940d4e73ee9827edc09a2a1a4d3a74418c | 6da45649c2730f180a6629aec7c8a4ad5c1a7450 | 2021-03-04T04:03:21Z | c++ | 2022-10-21T08:29:52Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,355 | ["src/test/fuzz/util.h"] | windows: new -Wreturn-type warnings after #19203 | We now get lots of compile time output like:
```bash
In file included from test/fuzz/addition_overflow.cpp:7:
./test/fuzz/util.h: In member function 'virtual SOCKET FuzzedSock::Get() const':
./test/fuzz/util.h:563:5: warning: no return statement in function returning non-void [-Wreturn-type]
563 | }
| ^
./test/fuzz/util.h: In member function 'virtual SOCKET FuzzedSock::Release()':
./test/fuzz/util.h:568:5: warning: no return statement in function returning non-void [-Wreturn-type]
568 | }
| ^
...
```
anywhere `test/fuzz/util.h` is included. Would be great to not have build logs filled with this spam.
This was all present in the CI. i.e https://cirrus-ci.com/task/5500626558779392?command=ci#L4283.
cc @practicalswift @vasild | https://github.com/bitcoin/bitcoin/issues/21355 | https://github.com/bitcoin/bitcoin/pull/21364 | fbf5d16238d67f901a1f151ddd7e68a17088eeee | da8c7edffe0c9efe99d56ec9e8b96b3b4e3e275f | 2021-03-04T03:19:53Z | c++ | 2021-03-05T02:42:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,351 | ["contrib/seeds/generate-seeds.py", "contrib/seeds/nodes_main.txt", "contrib/seeds/nodes_test.txt", "src/chainparams.cpp", "src/chainparams.h", "src/chainparamsseeds.h", "src/net.cpp"] | net: No more v2 onion support in upstream Tor master | One of my nodes using `onlynet=tor` nodes is completely broken with current master as of 97a35f3ae5bff7f4a25d37d8961191fdbc8c5b67.
Tor is manually configured. Relevant `bitcoin.conf`:
```
onlynet=onion
proxy=127.0.0.1:9050
onion=127.0.0.1:9050
```
It does not manage to make any outgoing connections. The log has an endless stream of:
```
2021-03-03T13:42:13Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:13Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:14Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:14Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:15Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:15Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:16Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:16Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:17Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:17Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:18Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:18Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:19Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:19Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:20Z Socks5() connect to […].onion:8333 failed: general failure
2021-03-03T13:42:20Z Socks5() connect to […].onion:8333 failed: general failure
…
```
(multiple messages per second, all `[…]` are short v2 onion addresses)
```
$ systemctl status tor
● tor.service - Anonymizing overlay network for TCP
Loaded: loaded (/etc/systemd/system/tor.service; enabled; vendor preset: enabled)
Active: active (running) since Wed 2021-03-03 14:45:24 CET; 3min 0s ago
Process: 158931 ExecStartPre=/opt/tor/bin/tor -f /opt/tor/etc/tor/torrc --verify-config (code=exited, status=0/SUCCESS)
Main PID: 158962 (tor)
Tasks: 1 (limit: 9367)
Memory: 38.4M
CGroup: /system.slice/tor.service
└─158962 /opt/tor/bin/tor -f /opt/tor/etc/tor/torrc
Mar 03 14:48:20 tor[158962]: Mar 03 14:48:20.000 [warn] Invalid hostname [scrubbed]; rejecting
Mar 03 14:48:20 tor[158962]: Mar 03 14:48:20.000 [warn] Invalid hostname [scrubbed]; rejecting
Mar 03 14:48:21 tor[158962]: Mar 03 14:48:21.000 [warn] Invalid hostname [scrubbed]; rejecting
Mar 03 14:48:21 tor[158962]: Mar 03 14:48:21.000 [warn] Invalid hostname [scrubbed]; rejecting
Mar 03 14:48:22 tor[158962]: Mar 03 14:48:22.000 [warn] Invalid hostname [scrubbed]; rejecting
Mar 03 14:48:22 tor[158962]: Mar 03 14:48:22.000 [warn] Invalid hostname [scrubbed]; rejecting
Mar 03 14:48:23 tor[158962]: Mar 03 14:48:23.000 [warn] Invalid hostname [scrubbed]; rejecting
Mar 03 14:48:23 tor[158962]: Mar 03 14:48:23.000 [warn] Invalid hostname [scrubbed]; rejecting
Mar 03 14:48:24 tor[158962]: Mar 03 14:48:24.000 [warn] Invalid hostname [scrubbed]; rejecting
Mar 03 14:48:24 tor[158962]: Mar 03 14:48:24.000 [warn] Invalid hostname [scrubbed]; rejecting
```
I'll try to see if I can figure out what it's sending. Tor (current master) is otherwise successfully able to connect to hidden services, at least v3 ones.
Did Tor completely remove v2 support?
```
$ /opt/tor/bin/tor --version
Tor version 0.4.6.0-alpha-dev (git-8020ae02abb105db).
Tor is running on Linux with Libevent 2.1.11-stable, OpenSSL 1.1.1f, Zlib 1.2.11, Liblzma 5.2.4, Libzstd N/A and Glibc 2.31 as libc.
Tor compiled with GCC version 9.3.0
``` | https://github.com/bitcoin/bitcoin/issues/21351 | https://github.com/bitcoin/bitcoin/pull/21560 | 1a7dec77f610607b1f0c5113bd5b6939b04717df | 9be7fe4849310884294669b019dd8300f69bc334 | 2021-03-03T13:54:44Z | c++ | 2021-04-06T08:47:51Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,348 | ["src/test/fuzz/cuckoocache.cpp"] | build: compile failure in fuzz-cuckoocache & DEBUG=1 | Testing @ 4f223e93e9c097c96a1655f9125aec463892da9c
```bash
make -C depends/ HOST=x86_64-w64-mingw32 -j8 NO_QT=1 NO_UPNP=1 NO_ZMQ=1 NO_NATPMP=1 DEBUG=1 NO_WALLET=1
./autogen.sh
./configure --prefix=/home/ubuntu/bitcoin/depends/x86_64-w64-mingw32 --enable-fuzz
make -j10
```
```bash
make[3]: Leaving directory '/home/ubuntu/bitcoin'
CXX test/fuzz/fuzz-cuckoocache.o
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h: In instantiation of ‘void CuckooCache::cache<Element, Hash>::insert(Element) [with Element = bool; Hash = {anonymous}::RandomHasher]’:
test/fuzz/cuckoocache.cpp:42:67: required from here
./cuckoocache.h:431:22: error: no matching function for call to ‘swap(std::__debug::vector<bool>::reference, bool&)’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/stl_pair.h:59,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/utility:70,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:60,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/move.h:182:5: note: candidate: ‘template<class _Tp> typename std::enable_if<std::__and_<std::__not_<std::__is_tuple_like<_Tp> >, std::is_move_constructible<_Tp>, std::is_move_assignable<_Tp> >::value>::type std::swap(_Tp&, _Tp&)’
182 | swap(_Tp& __a, _Tp& __b)
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/move.h:182:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: deduced conflicting types for parameter ‘_Tp’ (‘std::__cxx1998::_Bit_reference’ and ‘bool’)
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/stl_pair.h:59,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/utility:70,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:60,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/move.h:205:5: note: candidate: ‘template<class _Tp, long long unsigned int _Nm> typename std::enable_if<std::__is_swappable<_Tp>::value>::type std::swap(_Tp (&)[_Nm], _Tp (&)[_Nm])’
205 | swap(_Tp (&__a)[_Nm], _Tp (&__b)[_Nm])
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/move.h:205:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: mismatched types ‘_Tp [_Nm]’ and ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’}
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/utility:70,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:60,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/stl_pair.h:495:5: note: candidate: ‘template<class _T1, class _T2> typename std::enable_if<std::__and_<std::__is_swappable<_T1>, std::__is_swappable<_T2> >::value>::type std::swap(std::pair<_T1, _T2>&, std::pair<_T1, _T2>&)’
495 | swap(pair<_T1, _T2>& __x, pair<_T1, _T2>& __y)
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/stl_pair.h:495:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::pair<_T1, _T2>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/utility:70,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:60,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/stl_pair.h:503:5: note: candidate: ‘template<class _T1, class _T2> typename std::enable_if<(! std::__and_<std::__is_swappable<_T1>, std::__is_swappable<_T2> >::value)>::type std::swap(std::pair<_T1, _T2>&, std::pair<_T1, _T2>&)’ <deleted>
503 | swap(pair<_T1, _T2>&, pair<_T1, _T2>&) = delete;
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/stl_pair.h:503:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::pair<_T1, _T2>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/string:55,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/stdexcept:39,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/array:39,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/tuple:39,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/functional:54,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/pstl/glue_algorithm_defs.h:13,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:71,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/basic_string.h:6378:5: note: candidate: ‘template<class _CharT, class _Traits, class _Alloc> void std::swap(std::__cxx11::basic_string<_CharT, _Traits, _Allocator>&, std::__cxx11::basic_string<_CharT, _Traits, _Allocator>&)’
6378 | swap(basic_string<_CharT, _Traits, _Alloc>& __lhs,
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/basic_string.h:6378:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::__cxx11::basic_string<_CharT, _Traits, _Allocator>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/functional:54,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/pstl/glue_algorithm_defs.h:13,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:71,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/tuple:1624:5: note: candidate: ‘template<class ... _Elements> typename std::enable_if<std::__and_<std::__is_swappable<_Elements>...>::value>::type std::swap(std::tuple<_Tps ...>&, std::tuple<_Tps ...>&)’
1624 | swap(tuple<_Elements...>& __x, tuple<_Elements...>& __y)
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/tuple:1624:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::tuple<_Tps ...>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/functional:54,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/pstl/glue_algorithm_defs.h:13,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:71,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/tuple:1631:5: note: candidate: ‘template<class ... _Elements> typename std::enable_if<(! std::__and_<std::__is_swappable<_Elements>...>::value)>::type std::swap(std::tuple<_Tps ...>&, std::tuple<_Tps ...>&)’ <deleted>
1631 | swap(tuple<_Elements...>&, tuple<_Elements...>&) = delete;
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/tuple:1631:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::tuple<_Tps ...>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/functional:59,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/pstl/glue_algorithm_defs.h:13,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:71,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/std_function.h:785:5: note: candidate: ‘template<class _Res, class ... _Args> void std::swap(std::function<_Res(_ArgTypes ...)>&, std::function<_Res(_ArgTypes ...)>&)’
785 | swap(function<_Res(_Args...)>& __x, function<_Res(_Args...)>& __y) noexcept
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/std_function.h:785:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::function<_Res(_ArgTypes ...)>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/node_handle.h:39,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/hashtable.h:37,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/unordered_map:46,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/functional:61,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/pstl/glue_algorithm_defs.h:13,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:71,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/optional:1171:5: note: candidate: ‘template<class _Tp> std::enable_if_t<(is_move_constructible_v<_Tp> && is_swappable_v<_Tp>)> std::swap(std::optional<_Tp>&, std::optional<_Tp>&)’
1171 | swap(optional<_Tp>& __lhs, optional<_Tp>& __rhs)
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/optional:1171:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::optional<_Tp>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/node_handle.h:39,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/hashtable.h:37,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/unordered_map:46,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/functional:61,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/pstl/glue_algorithm_defs.h:13,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:71,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/optional:1177:5: note: candidate: ‘template<class _Tp> std::enable_if_t<(!(is_move_constructible_v<_Tp> && is_swappable_v<_Tp>))> std::swap(std::optional<_Tp>&, std::optional<_Tp>&)’ <deleted>
1177 | swap(optional<_Tp>&, optional<_Tp>&) = delete;
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/optional:1177:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::optional<_Tp>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/memory:80,
from ./cuckoocache.h:13,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/unique_ptr.h:701:5: note: candidate: ‘template<class _Tp, class _Dp> typename std::enable_if<std::__is_swappable<_T2>::value>::type std::swap(std::unique_ptr<_Tp, _Dp>&, std::unique_ptr<_Tp, _Dp>&)’
701 | swap(unique_ptr<_Tp, _Dp>& __x,
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/unique_ptr.h:701:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::unique_ptr<_Tp, _Dp>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/memory:80,
from ./cuckoocache.h:13,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/unique_ptr.h:708:5: note: candidate: ‘template<class _Tp, class _Dp> typename std::enable_if<(! std::__is_swappable<_T2>::value)>::type std::swap(std::unique_ptr<_Tp, _Dp>&, std::unique_ptr<_Tp, _Dp>&)’ <deleted>
708 | swap(unique_ptr<_Tp, _Dp>&,
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/unique_ptr.h:708:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::unique_ptr<_Tp, _Dp>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/shared_ptr.h:52,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/memory:81,
from ./cuckoocache.h:13,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/shared_ptr_base.h:1520:5: note: candidate: ‘template<class _Tp, __gnu_cxx::_Lock_policy _Lp> void std::swap(std::__shared_ptr<_Tp, _Lp>&, std::__shared_ptr<_Tp, _Lp>&)’
1520 | swap(__shared_ptr<_Tp, _Lp>& __a, __shared_ptr<_Tp, _Lp>& __b) noexcept
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/shared_ptr_base.h:1520:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::__shared_ptr<_Tp, _Lp>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/shared_ptr.h:52,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/memory:81,
from ./cuckoocache.h:13,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/shared_ptr_base.h:1728:5: note: candidate: ‘template<class _Tp, __gnu_cxx::_Lock_policy _Lp> void std::swap(std::__weak_ptr<_Tp, _Lp>&, std::__weak_ptr<_Tp, _Lp>&)’
1728 | swap(__weak_ptr<_Tp, _Lp>& __a, __weak_ptr<_Tp, _Lp>& __b) noexcept
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/shared_ptr_base.h:1728:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::__weak_ptr<_Tp, _Lp>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/memory:81,
from ./cuckoocache.h:13,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/shared_ptr.h:485:5: note: candidate: ‘template<class _Tp> void std::swap(std::shared_ptr<_Tp>&, std::shared_ptr<_Tp>&)’
485 | swap(shared_ptr<_Tp>& __a, shared_ptr<_Tp>& __b) noexcept
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/shared_ptr.h:485:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::shared_ptr<_Tp>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/memory:81,
from ./cuckoocache.h:13,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/shared_ptr.h:606:5: note: candidate: ‘template<class _Tp> void std::swap(std::weak_ptr<_Tp>&, std::weak_ptr<_Tp>&)’
606 | swap(weak_ptr<_Tp>& __a, weak_ptr<_Tp>& __b) noexcept
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/bits/shared_ptr.h:606:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::weak_ptr<_Tp>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/array:377,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/tuple:39,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/functional:54,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/pstl/glue_algorithm_defs.h:13,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:71,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/debug/array:275:5: note: candidate: ‘template<class _Tp, long long unsigned int _Nm> typename std::enable_if<(! typename std::__cxx1998::__array_traits<_Tp, _Nm>::_Is_swappable::value)>::type std::__debug::swap(std::__debug::array<_Tp, _Nm>&, std::__debug::array<_Tp, _Nm>&)’ <deleted>
275 | swap(array<_Tp, _Nm>&, array<_Tp, _Nm>&) = delete;
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/debug/array:275:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::__debug::array<_Tp, _Nm>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/array:377,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/tuple:39,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/functional:54,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/pstl/glue_algorithm_defs.h:13,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:71,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/debug/array:280:5: note: candidate: ‘template<class _Tp, long long unsigned int _Nm> void std::__debug::swap(std::__debug::array<_Tp, _Nm>&, std::__debug::array<_Tp, _Nm>&)’
280 | swap(array<_Tp, _Nm>& __one, array<_Tp, _Nm>& __two)
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/debug/array:280:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::__debug::array<_Tp, _Nm>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/unordered_map:52,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/functional:61,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/pstl/glue_algorithm_defs.h:13,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:71,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/debug/unordered_map:732:5: note: candidate: ‘template<class _Key, class _Tp, class _Hash, class _Pred, class _Alloc> void std::__debug::swap(std::__debug::unordered_map<_Key, _Tp, _Hash, _Pred, _Allocator>&, std::__debug::unordered_map<_Key, _Tp, _Hash, _Pred, _Allocator>&)’
732 | swap(unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>& __x,
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/debug/unordered_map:732:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::__debug::unordered_map<_Key, _Tp, _Hash, _Pred, _Allocator>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/unordered_map:52,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/functional:61,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/pstl/glue_algorithm_defs.h:13,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:71,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/debug/unordered_map:1338:5: note: candidate: ‘template<class _Key, class _Tp, class _Hash, class _Pred, class _Alloc> void std::__debug::swap(std::__debug::unordered_multimap<_Key, _Tp, _Hash, _Pred, _Allocator>&, std::__debug::unordered_multimap<_Key, _Tp, _Hash, _Pred, _Allocator>&)’
1338 | swap(unordered_multimap<_Key, _Tp, _Hash, _Pred, _Alloc>& __x,
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/debug/unordered_map:1338:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::__debug::unordered_multimap<_Key, _Tp, _Hash, _Pred, _Allocator>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/vector:76,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/functional:62,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/pstl/glue_algorithm_defs.h:13,
from /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/algorithm:71,
from ./cuckoocache.h:8,
from test/fuzz/cuckoocache.cpp:5:
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/debug/vector:766:5: note: candidate: ‘template<class _Tp, class _Alloc> void std::__debug::swap(std::__debug::vector<_Tp, _Alloc>&, std::__debug::vector<_Tp, _Alloc>&)’
766 | swap(vector<_Tp, _Alloc>& __lhs, vector<_Tp, _Alloc>& __rhs)
| ^~~~
/usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/include/c++/debug/vector:766:5: note: template argument deduction/substitution failed:
In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:22: note: ‘std::__debug::vector<bool>::reference’ {aka ‘std::__cxx1998::_Bit_reference’} is not derived from ‘std::__debug::vector<_Tp, _Alloc>’
431 | std::swap(table[last_loc], e);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:12854: test/fuzz/fuzz-cuckoocache.o] Error 1
``` | https://github.com/bitcoin/bitcoin/issues/21348 | https://github.com/bitcoin/bitcoin/pull/21349 | 4132193617a31394933c748bbdc1f441a21a39b4 | 9dbec0560054ba35d7df166f0fc75def70245e34 | 2021-03-03T08:23:11Z | c++ | 2021-03-21T07:05:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,322 | ["contrib/init/bitcoind.service"] | contrib: Current systemd usage doesn't allow for dependencies | The current [systemd service](https://github.com/bitcoin/bitcoin/blob/master/contrib/init/bitcoind.service) does not allow gracefully for services to depend on `bitcoind`. All dependent units will be launched immediately, regardless of current status. So if it is to work at all, they need an inefficient polling loop.
In the service file the service type is specified as `Type=forking` but we don't heed the behavior specified. From the `systemd.service(5)` man page:
> If set to forking, it is expected that the process configured with ExecStart= will call fork() as part of its start-up. The parent process is expected to exit when start-up is complete and all communication channels are set up.
A possible solution is #21007, which adds `-daemonwait` so that the control is only returned to the parent process when startup is complete. In combination with `Type=forking`, I think this achieves the proper functionality: to start dependent units only when RPC functionality is working.
With that the only change to the service file needed would be to use `-daemonwait` instead of `-daemon`.
An alternative would be to implement support for `Type=notify` and do readyness notification through `sd_notify`. But I opted for daemonwait because it seems more generally useful. The advantage of using a native notification mechanism, however, would be that it is still possible to have logging through stdout to the journal. The drawback that it introduces an optional dependency on `libsystemd`. | https://github.com/bitcoin/bitcoin/issues/21322 | https://github.com/bitcoin/bitcoin/pull/21418 | 1e4a3c057a9bf8d64aa414d783dc9aa37bd67536 | c46f1ce75196860c8b036d2965faac7db3aa4414 | 2021-03-01T08:37:11Z | c++ | 2021-03-22T14:15:14Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,309 | ["src/test/fuzz/FuzzedDataProvider.h"] | Compiling on stock Fedora 35 | While compiling for Fedora 35 stock machine, I kept having failures due to code in the fuzz tests, I found that adding:
#include <stdexcept>
#include <limits>
to the top of ./src/test/fuzz/FuzzedDataProvider.h fixed the issue. | https://github.com/bitcoin/bitcoin/issues/21309 | https://github.com/bitcoin/bitcoin/pull/21397 | e175ca9c6563772714cc52787f305cbf4735c48b | ee0dc02c6f93de2a366bbff490eb4d37bca6a24f | 2021-02-27T18:13:34Z | c++ | 2021-03-09T12:53:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,299 | ["doc/release-notes.md", "src/wallet/coincontrol.h", "src/wallet/coinselection.h", "src/wallet/rpcwallet.cpp", "src/wallet/wallet.cpp", "test/functional/rpc_fundrawtransaction.py", "test/functional/rpc_psbt.py", "test/functional/wallet_send.py"] | Add `include_unsafe` option to `fundrawtransaction` | Would it be completely unreasonable to allow `fundrawtransaction` to use unsafe outputs?
I understand this means the resulting transaction may be invalidated whenever the unsafe output I'm relying one disappears (e.g. because the transaction that produced it was RBF-ed) but in my case that's ok, I'll react to that and re-publish the tree of child transactions accordingly.
But let me know if you think that's too much of a footgun for users, in that case I'll architect my solution differently. | https://github.com/bitcoin/bitcoin/issues/21299 | https://github.com/bitcoin/bitcoin/pull/21359 | 8bed1706eac45a90a016471275e4857a22984289 | 32692d26813ba099c1451ae5941d38923bec761c | 2021-02-25T14:55:56Z | c++ | 2021-05-10T14:05:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,294 | ["build-aux/m4/bitcoin_runtime_lib.m4", "configure.ac", "src/Makefile.test.include", "src/test/fuzz/multiplication_overflow.cpp"] | v0.21.0 fails to compile on raspbian with clang | Getting these errors:-
make[3]: Leaving directory '/home/pi/src/bitcoin-core-v0.21'
/bin/bash ../libtool --tag=CXX --preserve-dup-deps --mode=link clang++ -std=c++11 -O0 -g3 -ftrapv -Wstack-protector -fstack-protector-all -Wall -Wextra -Wgnu -Wformat -Wformat-security -Wvla -Wshadow-field -Wswitch -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunused-variable -Wdate-time -Wconditional-uninitialized -Wsign-compare -Woverloaded-virtual -Wunreachable-code-loop-increment -Wno-unused-parameter -Wno-self-assign -Wno-unused-local-typedef -Wno-deprecated-register -Wno-implicit-fallthrough -fPIE -Wl,-z,relro -Wl,-z,now -Wl,-z,separate-code -pie -pthread -lpthread -o bitcoind bitcoind-bitcoind.o libbitcoin_server.a libbitcoin_wallet.a libbitcoin_common.a libbitcoin_util.a univalue/libunivalue.la libbitcoin_consensus.a crypto/libbitcoin_crypto_base.a leveldb/libleveldb.a crc32c/libcrc32c.a leveldb/libmemenv.a secp256k1/libsecp256k1.la -L/usr/lib/arm-linux-gnueabihf -lboost_system -lboost_filesystem -lboost_thread -lpthread -ldb_cxx -lminiupnpc -levent_pthreads -levent -levent -lsqlite3
libtool: link: clang++ -std=c++11 -O0 -g3 -ftrapv -Wstack-protector -fstack-protector-all -Wall -Wextra -Wgnu -Wformat -Wformat-security -Wvla -Wshadow-field -Wswitch -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunused-variable -Wdate-time -Wconditional-uninitialized -Wsign-compare -Woverloaded-virtual -Wunreachable-code-loop-increment -Wno-unused-parameter -Wno-self-assign -Wno-unused-local-typedef -Wno-deprecated-register -Wno-implicit-fallthrough -fPIE -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,-z -Wl,separate-code -pie -pthread -o bitcoind bitcoind-bitcoind.o -lpthread libbitcoin_server.a libbitcoin_wallet.a libbitcoin_common.a libbitcoin_util.a univalue/.libs/libunivalue.a libbitcoin_consensus.a crypto/libbitcoin_crypto_base.a leveldb/libleveldb.a crc32c/libcrc32c.a leveldb/libmemenv.a secp256k1/.libs/libsecp256k1.a -L/usr/lib/arm-linux-gnueabihf -lboost_system -lboost_filesystem -lboost_thread -lpthread -ldb_cxx -lminiupnpc -levent_pthreads -levent -levent /usr/lib/arm-linux-gnueabihf/libsqlite3.so -pthread
/usr/bin/ld: bitcoind-bitcoind.o: in function `std::chrono::duration<long long, std::ratio<1ll, 1000000ll> > std::chrono::__duration_cast_impl<std::chrono::duration<long long, std::ratio<1ll, 1000000ll> >, std::ratio<1000ll, 1ll>, long long, false, true>::__cast<long long, std::ratio<1ll, 1000ll> >(std::chrono::duration<long long, std::ratio<1ll, 1000ll> > const&)':
/usr/bin/../lib/gcc/arm-linux-gnueabihf/8/../../../../include/c++/8/chrono:168: undefined reference to `__mulodi4'
/usr/bin/ld: libbitcoin_server.a(libbitcoin_server_a-init.o): in function `AppInitParameterInteraction(ArgsManager const&)':
/home/pi/src/bitcoin-core-v0.21/src/init.cpp:1102: undefined reference to `__mulodi4'
/usr/bin/ld: /home/pi/src/bitcoin-core-v0.21/src/init.cpp:1103: undefined reference to `__mulodi4'
/usr/bin/ld: /home/pi/src/bitcoin-core-v0.21/src/init.cpp:1103: undefined reference to `__mulodi4'
/usr/bin/ld: libbitcoin_server.a(libbitcoin_server_a-init.o): in function `AppInitMain(util::Ref const&, NodeContext&, interfaces::BlockAndHeaderTipInfo*)':
/home/pi/src/bitcoin-core-v0.21/src/init.cpp:1532: undefined reference to `__mulodi4'
/usr/bin/ld: libbitcoin_server.a(libbitcoin_server_a-init.o):/home/pi/src/bitcoin-core-v0.21/src/init.cpp:1532: more undefined references to `__mulodi4' follow
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Makefile:8343: bitcoind] Error 1
make[2]: Leaving directory '/home/pi/src/bitcoin-core-v0.21/src'
make[1]: *** [Makefile:19347: all-recursive] Error 1
make[1]: Leaving directory '/home/pi/src/bitcoin-core-v0.21/src'
make: *** [Makefile:801: all-recursive] Error 1
Seems similar to this issue, so I'm assuming it has something to do with the choice to use clang - https://github.com/android/ndk/issues/506
| https://github.com/bitcoin/bitcoin/issues/21294 | https://github.com/bitcoin/bitcoin/pull/21882 | 19434fa22aad9d85e8b05cff717f4f33b5141fa0 | d23570098cd161fe4d2fbedcd25f563a4ca1dbd8 | 2021-02-24T13:15:41Z | c++ | 2021-07-29T12:53:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,278 | ["doc/descriptors.md", "doc/psbt.md", "test/functional/test_runner.py", "test/functional/wallet_multisig_descriptor_psbt.py"] | wallet: Multi-sig flow with descriptor wallets | It would be nice to have documentation on how to set up a basic M-of-N multisig between multiple people using descriptor wallets and PSBTs, as well as a signing flow.
E.g. (borrowed some steps from @jonasschnelli)
- First phase: generate and exchange `xpub`s:
- Every participant generates an `xpub`: most straightforward is to create a new wallet, I guess, but how to get the `xpub` to share for a specific BIP32 path?
- Maybe #21277 helps here *but* it might be putting the cart before the horse: do we want the default non-multisig descriptors at all here? I don't think so.
- Share it with the other participants.
- Second phase: Every participant imports the following descriptors using `importdescriptors`:
- Receiving (`internal: false`) addresses are `wsh(sortedmulti(<M>,xpubA/0/*,xpubB/0/*,xpubC/0/*,…))`
- Change (`internal: true`) addresses are `wsh(sortedmulti(<M>,xpubA/1/*,xpubB/1/*,xpubC/1/*,…))`
- Send funds to the resulting address (every participant should get the same addresses).
- When making a sending transaction create one using `walletcreatefundedpsbt` (everyone can initiate this)
- Send the resulting PSBT to other users
- At least M users checks it with `decodepsbt` then (if ok) signs it with `walletprocesspsbt`
- Collect the signed PSBTs with `joinpsbts` then broadcast the resulting transaction
| https://github.com/bitcoin/bitcoin/issues/21278 | https://github.com/bitcoin/bitcoin/pull/22067 | 2e82af46e237299246b53cb69c101ddba0175838 | ff65b696f3c6f6e17a790c6646249163ddb39eda | 2021-02-23T09:37:14Z | c++ | 2021-10-18T14:17:45Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,242 | ["depends/Makefile", "depends/funcs.mk", "depends/gen_id"] | guix: Prints "g++: not found" when building depends | Steps to reproduce: Start a guix build on a system without gcc.
```
/bin/sh: 1: gcc: not found
/bin/sh: 1: gcc: not found
/bin/sh: 1: g++: not found
/bin/sh: 1: g++: not found
env: '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends/x86_64-apple-darwin18/native/bin/clang': No such file or directory
env: '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends/x86_64-apple-darwin18/native/bin/clang': No such file or directory
env: '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends/x86_64-apple-darwin18/native/bin/clang++': No such file or directory
env: '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends/x86_64-apple-darwin18/native/bin/clang++': No such file or directory
Found macOS SDK at '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends/SDKs/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers', using...
make: Entering directory '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends'
/bin/sh: 1: gcc: not found
/bin/sh: 1: gcc: not found
/bin/sh: 1: g++: not found
/bin/sh: 1: g++: not found
/bin/sh: 1: gcc: not found
/bin/sh: 1: gcc: not found
/bin/sh: 1: g++: not found
/bin/sh: 1: g++: not found
make[1]: Entering directory '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends'
/bin/sh: 1: gcc: not found
/bin/sh: 1: gcc: not found
/bin/sh: 1: g++: not found
/bin/sh: 1: g++: not found
env: '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends/x86_64-apple-darwin/native/bin/clang': No such file or directory
env: '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends/x86_64-apple-darwin/native/bin/clang': No such file or directory
env: '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends/x86_64-apple-darwin/native/bin/clang++': No such file or directory
env: '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends/x86_64-apple-darwin/native/bin/clang++': No such file or directory
make[1]: Leaving directory '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends'
make[1]: Entering directory '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends'
/bin/sh: 1: gcc: not found
/bin/sh: 1: gcc: not found
/bin/sh: 1: g++: not found
/bin/sh: 1: g++: not found
/bin/sh: 1: gcc: not found
/bin/sh: 1: gcc: not found
/bin/sh: 1: g++: not found
/bin/sh: 1: g++: not found
make[1]: Leaving directory '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends'
make[1]: Entering directory '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends'
/bin/sh: 1: gcc: not found
/bin/sh: 1: gcc: not found
/bin/sh: 1: g++: not found
/bin/sh: 1: g++: not found
/bin/sh: 1: x86_64-w64-mingw32-gcc: not found
/bin/sh: 1: x86_64-w64-mingw32-gcc: not found
/bin/sh: 1: x86_64-w64-mingw32-g++: not found
/bin/sh: 1: x86_64-w64-mingw32-g++: not found
make[1]: Leaving directory '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends'
make: Leaving directory '/home/micap/temp/scratch/guix/bitcoin/bitcoin/depends'
INFO: Building commit a4903f747ccd for platform triple x86_64-linux-gnu: | https://github.com/bitcoin/bitcoin/issues/21242 | https://github.com/bitcoin/bitcoin/pull/21427 | cdcf82622d49d10ee339e471e511cd973772e9ff | df21e500d6bcfe70318bad2b75a9d7898c92dcfb | 2021-02-20T06:14:36Z | c++ | 2021-05-05T12:32:12Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,227 | ["test/functional/feature_blockfilterindex_prune.py"] | feature_blockfilterindex_prune.py is consistently failing on master for macOS CI | https://github.com/bitcoin/bitcoin/issues/21227 | https://github.com/bitcoin/bitcoin/pull/21230 | 3a2d5bfeb38e7a5fca88f9b185d58266589d0452 | 9f3ffa29389aa59ea87b5aa974a2da17ccfd31a4 | 2021-02-18T19:15:35Z | c++ | 2021-02-19T07:38:01Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.