status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,015 | ["src/Makefile.test.include", "src/wallet/test/walletload_tests.cpp", "src/wallet/wallet.cpp", "src/wallet/walletdb.cpp", "src/wallet/walletdb.h"] | Unknown descriptor in wallet crashes | Attempting to load a wallet with an unknown descriptor causes a fatal error:
```
2022-09-06T01:51:06Z init message: Loading wallet…
2022-09-06T01:51:06Z [descriptor] Invalid descriptor: Can only have tr at top level: iostream error
2022-09-06T01:51:06Z [descriptor] Invalid descriptor: Can only have tr at top level: iostream error
2022-09-06T01:51:06Z [descriptor] Setting spkMan to active: id = 50e6032b4d1d62c020ebb6a4d0c8fafc6f01ea80f4d2a41c1a256086611636e9, type = legacy, internal = false
2022-09-06T01:51:06Z [descriptor] Setting spkMan to active: id = 7f709abbde61e8c253798375692bf41202e625ed74a65f9474d464be34fb2870, type = p2sh-segwit, internal = false
2022-09-06T01:51:06Z [descriptor] Setting spkMan to active: id = 2dc6c34099e0ca1235fc990a51042967ecbc8c8ac57062f964739cba2f451be8, type = bech32, internal = false
2022-09-06T01:51:06Z [descriptor] Setting spkMan to active: id = 8d3c63ea1ac9936e789713dc8bae857d328ff029ab9392e67c716752e9b11b0c, type = bech32m, internal = false
2022-09-06T01:51:06Z [descriptor] Releasing wallet
2022-09-06T01:51:06Z
************************
EXCEPTION: St12out_of_range
map::at
bitcoin in Runaway exception
************************
EXCEPTION: St12out_of_range
map::at
bitcoin in Runaway exception
bitcoin-qt: ./checkqueue.h:204: CCheckQueue<CScriptCheck>::~CCheckQueue() [T = CScriptCheck]: Assertion `m_worker_threads.empty()' failed.
Aborted
```
> A fatal error occurred. Bitcoin Core can no longer continue safely and will quit.
To reproduce, a quick hack:
```c++
--- a/src/script/descriptor.cpp
+++ b/src/script/descriptor.cpp
@@ -1408,7 +1408,7 @@ std::unique_ptr<DescriptorImpl> ParseScript(uint32_t& key_exp_index, Span<const
error = "Can only have addr() at top level";
return nullptr;
}
- if (ctx == ParseScriptContext::TOP && Func("tr", expr)) {
+ if (ctx == ParseScriptContext::TOP && Func("trx", expr)) {
auto arg = Expr(expr);
auto internal_key = ParsePubkey(key_exp_index, arg, ParseScriptContext::P2TR, out, error);
if (!internal_key) {
``` | https://github.com/bitcoin/bitcoin/issues/26015 | https://github.com/bitcoin/bitcoin/pull/26021 | 3a7e0a210c86e3c1750c7e04e3d1d689cf92ddaa | c85688347eac1a79099ae61dfc37e69e3fa3b220 | 2022-09-06T01:54:02Z | c++ | 2022-09-13T15:51:51Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,014 | ["test/functional/test_framework/test_framework.py"] | test: failure in wallet_reorgsrestore.py | https://cirrus-ci.com/task/6737091563356160?logs=ci#L561
```bash
2022-08-24T18:39:37.362000Z TestFramework (INFO): Initializing test directory /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20220824_183515/wallet_reorgsrestore_169
2022-08-24T19:19:42.206000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
self.wait_until(lambda: sum(peer['version'] != 0 for peer in to_connection.getpeerinfo()) == to_num_peers)
'''
2022-08-24T19:19:42.206000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 133, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/wallet_reorgsrestore.py", line 40, in run_test
self.connect_nodes(0, 2)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 594, in connect_nodes
self.wait_until(lambda: sum(peer['version'] != 0 for peer in to_connection.getpeerinfo()) == to_num_peers)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 717, in wait_until
return wait_until_helper(test_function, timeout=timeout, timeout_factor=self.options.timeout_factor)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 281, in wait_until_helper
raise AssertionError("Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
self.wait_until(lambda: sum(peer['version'] != 0 for peer in to_connection.getpeerinfo()) == to_num_peers)
''' not true after 2400.0 seconds
2022-08-24T19:19:42.257000Z TestFramework (INFO): Stopping nodes
``` | https://github.com/bitcoin/bitcoin/issues/26014 | https://github.com/bitcoin/bitcoin/pull/26138 | 9fcdb9f3a044330d3d7515fa35709102c98534d2 | b2da6dd943292b9e08e95fc81577b9fc99d16134 | 2022-09-05T16:52:54Z | c++ | 2022-09-28T15:21:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,011 | ["src/wallet/rpc/spend.cpp", "test/functional/wallet_sendall.py"] | sendall creates tx that fails tx-size mempool check | Steps to reproduce:
* Create many inputs
* Call `sendall`
Error: `2022-09-05T09:07:57Z [httpworker.1] [wallet/wallet.h:827] [WalletLogPrintf] [default wallet] CommitTransaction(): Transaction cannot be broadcast immediately, tx-size` | https://github.com/bitcoin/bitcoin/issues/26011 | https://github.com/bitcoin/bitcoin/pull/26024 | 96f1b2d34fd5a5f0ab0628caa20df6d5cc989dfd | a56876e6b9dab4e0080cb8d7e9d0b4dd117f79a8 | 2022-09-05T09:11:57Z | c++ | 2022-09-15T17:26:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 26,006 | ["src/fs.cpp"] | fs: `_OVERLAPPED` missing initializers | ```bash
fs.cpp: In member function ‘bool fsbridge::FileLock::TryLock()’:
fs.cpp:129:32: error: missing initializer for member ‘_OVERLAPPED::InternalHigh’ [-Werror=missing-field-initializers]
129 | _OVERLAPPED overlapped = {0};
| ^
fs.cpp:129:32: error: missing initializer for member ‘_OVERLAPPED::<anonymous>’ [-Werror=missing-field-initializers]
fs.cpp:129:32: error: missing initializer for member ‘_OVERLAPPED::hEvent’ [-Werror=missing-field-initializers]
```
https://github.com/bitcoin/bitcoin/pull/25972/checks?check_run_id=8137548993 | https://github.com/bitcoin/bitcoin/issues/26006 | https://github.com/bitcoin/bitcoin/pull/26090 | 20f03a5aedc2de39453d196c9b1ce2a537367bb9 | f332c4f64d52e82211c1199bbd5bab2c6bfc57f4 | 2022-09-04T21:48:10Z | c++ | 2022-09-15T14:32:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,994 | ["configure.ac"] | ./configure error with --experimental-kernel-lib | The new, experimental `bitcoin-chainstate` is default configured off (https://github.com/bitcoin/bitcoin/pull/24304). Explicitly turning it off works properly on master:
`./configure --disable-experimental-util-chainstate`
> checking whether to build experimental bitcoin-chainstate... no
However, when I add `--without-experimental-kernel-lib` (which is superfluous, since default is to build if we're building libraries and the experimental bitcoin-chainstate executable - it is default to build libraries, but default not to build bitcoin-chainstate, which we've redundantly stated explicitly).
`./configure --disable-experimental-util-chainstate --without-experimental-kernel-lib`
> checking whether to build experimental bitcoin-chainstate... configure: error: experimental bitcoin-chainstate cannot be built without the experimental bitcoinkernel library. Use --with-experimental-kernel-lib
It seems like it is trying to build the bitcoin-chainstate executable for some reason? I would expect the same output as before:
> checking whether to build experimental bitcoin-chainstate... no
This is easy to reproduce on master. | https://github.com/bitcoin/bitcoin/issues/25994 | https://github.com/bitcoin/bitcoin/pull/26003 | bb378b6ccdd3804fe38640356e8a27de549c50af | 2e34374bf3e12b37b0c66824a6c998073cdfab01 | 2022-09-03T22:50:46Z | c++ | 2022-09-10T09:24:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,965 | ["test/functional/rpc_packages.py", "test/functional/test_framework/wallet.py"] | remove create_child_with_parents, make_chain, and create_raw_chain from test_framework/wallet | These 3 functions create packages of transactions without broadcasting: https://github.com/bitcoin/bitcoin/blob/01e1627e25bc5477c40f51da03c3c31b609a85c9/test/functional/test_framework/wallet.py#L393
They were introduced in #20833 and #21800 to avoid using the wallet in non-wallet functional tests.
Since then, wonderful people have created the same functionality in `MiniWallet`, so these are now redundant. I'm rewriting my branches to avoid using them. It would be a good cleanup to (1) refactor the call sites in rpc_packages.py to use MiniWallet instead, and (2) remove these 3 functions from wallet.py.
This is very similar to #20078.
#### Useful skills:
* Familiarity with our functional test suite
* Good python3 skills
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request. | https://github.com/bitcoin/bitcoin/issues/25965 | https://github.com/bitcoin/bitcoin/pull/25986 | a79b720092b6ce4134d386e95b3473a290f3c127 | 00c323610a30572ff15420d68f5432a3cb9757e5 | 2022-08-31T12:27:04Z | c++ | 2022-11-28T11:54:52Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,954 | ["contrib/message-capture/message-capture-parser.py"] | Error when parsing captured p2p messages using message-capture-parser.py | I am unable to read the p2p messages saved in `msgs_sent.dat` and `msgs_recv.dat` files.
Steps to reproduce:
1. Run `bitcoind` with `capturemessages=1`
2. Wait for a few minutes, ensure there are some peers and corresponding directories created in `~/.bitcoin/message_capture`
3. Run message capture python script with: `python message-capture-parser.py -o out.json ~/.bitcoin/message_capture/<IP_ADDRESS>_<PORT>/msgs_sent.dat`
I am getting this error for sent/recv dat files of all peers:
```
python message-capture-parser.py -o out.json /home/test/.bitcoin/signet/message_capture/95.217.184.148_38333/msgs_sent.dat
[ ###################################################################################################################### ] 92%Traceback (most recent call last):
File "/home/test/Downloads/bitcoin/contrib/message-capture/message-capture-parser.py", line 215, in <module>
main()
File "/home/test/Downloads/bitcoin/contrib/message-capture/message-capture-parser.py", line 200, in main
process_file(str(capture), messages, "recv" in capture.stem, progress_bar)
File "/home/test/Downloads/bitcoin/contrib/message-capture/message-capture-parser.py", line 160, in process_file
msg_dict["body"] = to_jsonable(msg)
File "/home/test/Downloads/bitcoin/contrib/message-capture/message-capture-parser.py", line 83, in to_jsonable
assert all(isinstance(a, int) for a in val)
AssertionError
```
---
Message parsing script: https://github.com/bitcoin/bitcoin/blob/master/contrib/message-capture/message-capture-parser.py
Doc: https://github.com/bitcoin/bitcoin/blob/master/contrib/message-capture/message-capture-docs.md
| https://github.com/bitcoin/bitcoin/issues/25954 | https://github.com/bitcoin/bitcoin/pull/26007 | dd3ada6ec483befcc2233844ebcde26793299064 | 3c5fb9691b7b49042160cb161daa07ab2827c064 | 2022-08-29T18:02:47Z | c++ | 2022-09-09T08:38:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,947 | ["src/Makefile.am", "src/Makefile.bench.include", "src/Makefile.qt.include", "src/Makefile.qttest.include", "src/Makefile.test.include", "src/Makefile.test_fuzz.include", "src/Makefile.test_util.include"] | MacOS Build Error: Qt 5 and 6 Simultaneously Installed. | This error seems to appear when `brew install qt@5` is installed at the same time as: `brew install qt`. (ie, qt version 6):
``` bash
% brew list --version | grep qt
qt 6.3.1_1
qt@5 5.15.5_1
```
```
Making all in src
CXX qt/libbitcoinqt_a-bantablemodel.o
In file included from qt/bantablemodel.cpp:14:
In file included from /usr/local/Cellar/qt@5/5.15.5_1/lib/QtCore.framework/Headers/QLocale:1:
/usr/local/Cellar/qt@5/5.15.5_1/lib/QtCore.framework/Headers/qlocale.h:1028:25: error: unknown type name 'QStringRef'; did you mean 'CFStringRef'?
short toShort(const QStringRef &s, bool *ok = nullptr) const;
^~~~~~~~~~
CFStringRef
/usr/local/include/QtCore/qdebug.h:531:1: note: 'CFStringRef' declared here
Q_FORWARD_DECLARE_CF_TYPE(CFString);
^
/usr/local/include/QtCore/qglobal.h:802:77: note: expanded from macro 'Q_FORWARD_DECLARE_CF_TYPE'
# define Q_FORWARD_DECLARE_CF_TYPE(type) typedef const struct __ ## type * type ## Ref
^
<scratch space>:112:1: note: expanded from here
CFStringRef
^
```
```bash
% git clean -ffxd
% git rev-parse HEAD
e191fac4f3c37820f0618f72f0a8e8b524531ab8
% ./autogen.sh
% ./configure
% make
```
output: https://gist.github.com/da2ce7/c697259e204c961876ad7f7057e95b34
config.log: https://gist.github.com/da2ce7/ec7276de7d0284681cd73b0cdcb90f3b
brew list --version --formulae: https://gist.github.com/da2ce7/25d6473224a1d69a28cf24e44abb55b7
_Originally posted by @da2ce7 in https://github.com/bitcoin/bitcoin/issues/21901#issuecomment-1229561087_ | https://github.com/bitcoin/bitcoin/issues/25947 | https://github.com/bitcoin/bitcoin/pull/26056 | 29d540b7ada890dd588c4825d40c27c5e6f20061 | 13fd9ee5c2d747e9f74d3fd8e33a4f0c9eaa769c | 2022-08-28T22:08:21Z | c++ | 2022-09-14T07:59:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,940 | ["test/functional/wallet_groups.py"] | Intermittent failure in `wallet_groups.py` | https://cirrus-ci.com/task/6569439897321472?logs=functional_tests#L2462 :
```
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\wallet_groups.py", line 150, in run_test
txid6 = self.nodes[4].sendtoaddress(self.nodes[0].getnewaddress(), 2.95)
(...)
AssertionError: [node 4] Expected messages "['Fee non-grouped = 5520, grouped = 8240, using grouped']" does not partially match log | https://github.com/bitcoin/bitcoin/issues/25940 | https://github.com/bitcoin/bitcoin/pull/25990 | 013924aa6dc91dd8be93c1eaab6546710ed7fde2 | dd3ada6ec483befcc2233844ebcde26793299064 | 2022-08-26T20:12:09Z | c++ | 2022-09-09T08:35:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,921 | ["src/chainparams.cpp"] | Update chainparams pre 24.0 branch-off | This should be done before the branch-off, and can be done by anyone, as the steps are easily reproducible and reviewable.
#### Useful skills:
* Building Bitcoin Core
* Follow the documentation: https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#before-branch-off
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/25921 | https://github.com/bitcoin/bitcoin/pull/25946 | 5291933fedceb9df16eb9e4627b1d7386b53ba07 | 447f50e4aed9a8b1d80e1891cda85801aeb80b4e | 2022-08-24T17:23:27Z | c++ | 2022-09-06T15:46:45Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,899 | ["doc/release-notes-25943.md", "src/rpc/client.cpp", "src/rpc/mempool.cpp", "src/util/error.cpp", "src/util/error.h", "test/functional/feature_coinstatsindex.py", "test/functional/rpc_rawtransaction.py"] | rpc: prevent non-zero value OP_RETURN outputs in sendrawtransaction | While some protocols require value attached to OP_RETURN outputs, this otherwise seems like a mistake.
Setting the value to 0 should really be done by the wallet/script creating the transaction (like createrawtransaction does for `data` outputs). However, as an additional check, similar to the high-fee check, sendrawtransaction could also check for non-zero value OP_RETURN outputs.
This should be configurable by a new RPC argument.
See also https://transactionfee.info/charts/output-opreturn-amount/
#### Useful skills:
* Bitcoin Core RPC code
* Transaction output types
* Bitcoin Core functional tests
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/25899 | https://github.com/bitcoin/bitcoin/pull/25943 | 32f9ce0f52b7bb211de02f2c6ec9ecc65a625b79 | b7702bd546eda7d713d3aa5696af98102728113f | 2022-08-22T09:24:10Z | c++ | 2023-02-23T18:57:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,793 | ["test/functional/interface_usdt_validation.py"] | Spurious CI failure of `interface_usdt_validation.py` | ```
82/244 - interface_usdt_validation.py failed, Duration: 1 s
stdout:
2022-08-04T10:06:05.298000Z TestFramework (INFO): Initializing test directory /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20220804_095558/interface_usdt_validation_159
2022-08-04T10:06:05.849000Z TestFramework (INFO): hook into the validation:block_connected tracepoint
2022-08-04T10:06:06.358000Z TestFramework (INFO): mine 2 blocks
2022-08-04T10:06:06.374000Z TestFramework (INFO): handle_blockconnected(): ConnectedBlock(hash=740e218334005cfc4c988053083a3d3ba5ba59cd8530030e42a87a4080fbffe8 height=202, transactions=1, inputs=1, sigops=0, duration=319)
2022-08-04T10:06:06.375000Z TestFramework (INFO): handle_blockconnected(): ConnectedBlock(hash=524a502fb9f972c220da42f2658ee2c4e63238a58b2b470505fabbae4482279b height=201, transactions=1, inputs=1, sigops=0, duration=298)
2022-08-04T10:06:06.394000Z TestFramework (INFO): check that we traced 2 blocks
2022-08-04T10:06:06.394000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 133, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/interface_usdt_validation.py", line 131, in run_test
assert_equal(BLOCKS_EXPECTED, blocks_checked)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 52, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(2 == 0)
2022-08-04T10:06:06.445000Z TestFramework (INFO): Stopping nodes
2022-08-04T10:06:06.598000Z TestFramework (WARNING): Not cleaning up dir /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20220804_095558/interface_usdt_validation_159
2022-08-04T10:06:06.598000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20220804_095558/interface_usdt_validation_159/test_framework.log
2022-08-04T10:06:06.599000Z TestFramework (ERROR):
2022-08-04T10:06:06.599000Z TestFramework (ERROR): Hint: Call /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/combine_logs.py '/tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20220804_095558/interface_usdt_validation_159' to consolidate all logs
2022-08-04T10:06:06.599000Z TestFramework (ERROR):
2022-08-04T10:06:06.599000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-04T10:06:06.599000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues
2022-08-04T10:06:06.599000Z TestFramework (ERROR):
stderr:
Exception ignored on calling ctypes callback function: <function PerfEventArray._open_perf_buffer.<locals>.raw_cb_ at 0x7f9753218430>
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/bcc/table.py", line 982, in raw_cb_
callback(cpu, data, size)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/interface_usdt_validation.py", line 108, in handle_blockconnected
assert_equal(block["hash"], bytes(event.hash[::-1]).hex())
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 52, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(524a502fb9f972c220da42f2658ee2c4e63238a58b2b470505fabbae4482279b == 740e218334005cfc4c988053083a3d3ba5ba59cd8530030e42a87a4080fbffe8)
Exception ignored on calling ctypes callback function: <function PerfEventArray._open_perf_buffer.<locals>.raw_cb_ at 0x7f97532184c0>
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/bcc/table.py", line 982, in raw_cb_
callback(cpu, data, size)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/interface_usdt_validation.py", line 108, in handle_blockconnected
assert_equal(block["hash"], bytes(event.hash[::-1]).hex())
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 52, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(740e218334005cfc4c988053083a3d3ba5ba59cd8530030e42a87a4080fbffe8 == 524a502fb9f972c220da42f2658ee2c4e63238a58b2b470505fabbae4482279b)
```
Happened on unrelated https://github.com/bitcoin/bitcoin/pull/25642. [Logs](https://cirrus-ci.com/task/5521993490497536). | https://github.com/bitcoin/bitcoin/issues/25793 | https://github.com/bitcoin/bitcoin/pull/25794 | ebf094ff3af80c28b80383f94292143533d5ed49 | aac200801b66f1300e618c115a6e3df9b01c9ec3 | 2022-08-06T08:26:49Z | c++ | 2022-08-10T12:04:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,787 | ["test/functional/mempool_datacarrier.py", "test/functional/test_framework/messages.py", "test/functional/test_runner.py"] | no test coverage for -datacarrier and -datacarriersize | The `-datacarrier` and `-datacarriersize` options were added in #3715 and #5077. Seems like those PRs did not add tests and we still don't have tests for them...? It should be easier to test things like this now with functional tests. I see `-datacarriersize` used in some places to create large transactions by stuffing outputs with lots of data but that's not very thorough. We should probably add a functional test that checks these options do what they're supposed to. | https://github.com/bitcoin/bitcoin/issues/25787 | https://github.com/bitcoin/bitcoin/pull/25792 | 243d7bde7859777ebe9442477da1b77419bd3f32 | 29c195cf6a2c9d6a3fee6cbe889480875efdd8e8 | 2022-08-05T14:22:34Z | c++ | 2022-08-11T16:04:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,764 | ["test/functional/interface_usdt_validation.py"] | test: failure in interface_usdt_validation.py | ERROR: type should be string, got "https://cirrus-ci.com/task/5553601580892160?logs=ci#L4244:\r\n```bash\r\n test 2022-08-01T12:14:24.104000Z TestFramework (INFO): handle_blockconnected(): ConnectedBlock(hash=2f97f65fda63aba081bf2867f7f99657c39436306c4aed3c899264b8bde7c5ab height=202, transactions=1, inputs=1, sigops=0, duration=517) \r\n test 2022-08-01T12:14:24.104000Z TestFramework (INFO): handle_blockconnected(): ConnectedBlock(hash=54d4bd414e5de85cee4dc5f1e7bcf4e358cf6e7ce556647debe2e9d007459ec7 height=201, transactions=1, inputs=1, sigops=0, duration=338) \r\n test 2022-08-01T12:14:24.148000Z TestFramework (INFO): check that we traced 2 blocks \r\n test 2022-08-01T12:14:24.149000Z TestFramework (ERROR): Assertion failed \r\n Traceback (most recent call last):\r\n File \"/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py\", line 133, in main\r\n self.run_test()\r\n File \"/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/interface_usdt_validation.py\", line 131, in run_test\r\n assert_equal(BLOCKS_EXPECTED, blocks_checked)\r\n File \"/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py\", line 52, in assert_equal\r\n raise AssertionError(\"not(%s)\" % \" == \".join(str(arg) for arg in (thing1, thing2) + args))\r\n AssertionError: not(2 == 0)\r\n```" | https://github.com/bitcoin/bitcoin/issues/25764 | https://github.com/bitcoin/bitcoin/pull/25794 | ebf094ff3af80c28b80383f94292143533d5ed49 | aac200801b66f1300e618c115a6e3df9b01c9ec3 | 2022-08-01T12:19:06Z | c++ | 2022-08-10T12:04:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,751 | ["src/key.cpp", "src/key.h", "src/pubkey.cpp", "src/pubkey.h", "src/script/descriptor.cpp", "src/test/bip32_tests.cpp", "src/test/descriptor_tests.cpp", "src/wallet/scriptpubkeyman.cpp"] | pubkey.cpp:368:18: runtime error: implicit conversion from type 'int' of value 256 (32-bit, signed) to type 'unsigned char' changed the value to 0 (8-bit, unsigned) | Steps to reproduce:
* Build with `integer` sanitizer
* Start: `UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1" ./src/qt/bitcoin-qt -chain=main`
* Enter `getdescriptorinfo "sh(multi(1,xprv9uPDJpEQgRQfDcW7BkF7eTya6RPxXeJCqCJGHuCJ4GiRVLzkTXBAJMu2qaMWPrS7AANYqdq6vcBcBUdJCVVFceUvJFjaPdGZ2y9WACViL4L/5/5/5/2/8/5/8/8/8/2/2/5/8/5/2/5/85/58/5/2/5/5/5/5/2/58/2/5/8/0000/00/8/5/2/001/1/246/8/501/46/8/5/8/5/000/8/52/5/8/5/2/8/2/5/8/5/246/8/5/2/8/2/5/8/5/2/5/8/8/2/5/5/5/58/88/2/6/8/5/2/8/2/5/8/2/588/5/2/5/8/5/2/8/5/1/5/4/5/5/5/2/6/8/5/2/8/2/5/8/5/2/5/58/58/2/5/8/58/588/2/52/5/5/5/58/8/2/6/8/5/2/8/2/5/8/2/588/5/2/5/8/5/2/8/5/15/58/58/2/6/8/5/2/8/2/5/8/5/2/5/8/58/2/5/58/58/588/2/5/2/8/5/8/5/4/5/58/588/2/6/8/5/2/8/2/5/8/2/8/5/2/8/2/5/8/5/2/5/58/58/2/5/5/5/58/588/2/6/8/5/2/8/2/5/8/2/8/588/2/6/8/5/2/8/2/5/5/8/5/2/0/8/5/2/00/4/5/5/588/2/6/8/5/2/8/25/5/8/2/5/58/58/8/4/1,[00000000]xprv9uPDJpEQgRQfDcW7BkF7eTya6RPxXeJCqCJGHuCJ4GiRVLzkTXBAJMu2qaMWPrS7AANYqdq6vcBcBUdJCVVFceUvJFjaPdGZ2y9WACViL4L/58)0)"` into the console | https://github.com/bitcoin/bitcoin/issues/25751 | https://github.com/bitcoin/bitcoin/pull/25642 | 251c535800c492b10332ea0774453e02bd9a24aa | 93999a5fbe317852307455b6a42d137cc08a0edc | 2022-07-30T14:56:44Z | c++ | 2022-08-10T18:25:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,749 | ["src/psbt.h", "test/functional/data/rpc_psbt.json", "test/functional/rpc_psbt.py"] | psbt.h:644:51: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'unsigned long' | Steps to reproduce:
* Build with `integer` sanitizer
* `UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1" ./src/qt/bitcoin-qt`
* Enter into the RPC debug console: `decodepsbt "cHNidP8BAKOro2MDAwMDA5ggCAAA////CQAtAAD+///1AAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAJAAAAAAAAAAAAAAAAAAAAAAAAAD+///1Zm9ybmV3nWx1Y2vmelLmegAAAAAAAAAAAAAAAAAAAAMKAwMDAwMDAwMDAwMACvMBA3FkAAAAAAAAAAAABAAlAAAAAAAAACEWDQ0zDQ0NDQ0NDQ0NCwEAAH9/f39/fwMAAABNo6P///kAAA=="` | https://github.com/bitcoin/bitcoin/issues/25749 | https://github.com/bitcoin/bitcoin/pull/25812 | cd230f3281fb6ffe5ae9d6243fa931aec57547a2 | 0094ff3947be9cb43a19c812b893392197de0987 | 2022-07-30T13:49:15Z | c++ | 2022-08-11T09:12:20Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,741 | ["test/functional/rpc_net.py"] | test: failure in rpc_net.py | https://cirrus-ci.com/task/5789129014247424
```bash
test 2022-07-29T10:31:54.510000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
self.wait_until(lambda: sum(peer['version'] != 0 for peer in to_connection.getpeerinfo()) == to_num_peers)
'''
test 2022-07-29T10:31:54.511000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 133, in main
self.run_test()
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/rpc_net.py", line 68, in run_test
self.test_getnetworkinfo()
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/rpc_net.py", line 144, in test_getnetworkinfo
self.connect_nodes(0, 1)
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 594, in connect_nodes
self.wait_until(lambda: sum(peer['version'] != 0 for peer in to_connection.getpeerinfo()) == to_num_peers)
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 717, in wait_until
return wait_until_helper(test_function, timeout=timeout, timeout_factor=self.options.timeout_factor)
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 277, in wait_until_helper
raise AssertionError("Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
self.wait_until(lambda: sum(peer['version'] != 0 for peer in to_connection.getpeerinfo()) == to_num_peers)
''' not true after 2400.0 seconds
``` | https://github.com/bitcoin/bitcoin/issues/25741 | https://github.com/bitcoin/bitcoin/pull/26630 | cac29f5cd66f005ce65edd697990d495a904a1f1 | fe8d15c907d0ca170ce171e7655f9c7cd4a0194f | 2022-07-29T15:18:04Z | c++ | 2022-12-04T15:04:20Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,726 | ["contrib/guix/manifest.scm", "contrib/guix/patches/nsis-disable-installer-reloc.patch"] | Bitcoin Core 0.23 installer incompatible with Windows mandatory ASLR | <!-- Describe the issue -->
Try downloading the current version 0.23 of Bitcoin Core for Windows from the official site : the installer (EXE) is corrupted (won't run, corrupted EXE format)
Only the ZIP file is correct.
Workaround: you can use the 0.22 installer, then download the 0.23 zip and extract the executables from there to overwrite the existing EXE files (qt.exe in the main Program Files\Bitcoin folder, other executables in the ZIP go to the "daemon" subfolder)
So the EXE package was incorrectly built, or was incorrectly transfered/truncated on the download site on bitcoin.org.
| https://github.com/bitcoin/bitcoin/issues/25726 | https://github.com/bitcoin/bitcoin/pull/25788 | 59bd6b6d37184b5af0d35adc9b3b52a27e1c1f7c | b1a2021f78099c17360dc2179cbcb948059b5969 | 2022-07-28T01:40:02Z | c++ | 2022-08-05T19:32:26Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,724 | ["configure.ac"] | MacOS: `importdescriptors` RPC call very slow with release and source-built binaries, but fast for homebrew binaries | I'm working on a project on MacOS that makes RPC calls using the Rust [bitcoincore-rpc crate](https://crates.io/crates/bitcoincore-rpc), against the bitcoind prebuilt binary available [here](https://bitcoincore.org/bin/bitcoin-core-23.0/bitcoin-23.0-x86_64-apple-darwin.tar.gz).
Some RPC calls succeed, but some fail with this error:
```
Error: Rpc(JsonRpc(Transport(SocketError(Os { code: 35, kind: WouldBlock, message: "Resource temporarily unavailable" }))))
```
After much debugging, we found that when we used the version of `bitcoind` provided by [homebrew](https://brew.sh/), the exact same sequence of RPC calls would succeed. We were able to reproduce this on both an x86 mac and an ARM mac.
We haven't been able to figure out what the disparity is, but looking at the homebrew [bitcoind formula defiinition](https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/bitcoin.rb) might provide some clues.
In particular:
```
def install
system "./autogen.sh"
system "./configure", *std_configure_args,
"--disable-dependency-tracking",
"--disable-silent-rules",
"--with-boost-libdir=#{Formula["[email protected]"].opt_lib}"
system "make", "install"
pkgshare.install "share/rpcauth"
end
```
It looks like homebrew is passing additional arguments to `configure`, `std_configure_args`, and is using a version of boost built by homebrew. I tried using `brew install -s [email protected] bitcoind`, to see if this also produced a binary that worked, and it did. The logs from that build are available [here](https://github.com/casey/homebrew-bitcoind-build-logs).
I've run into similar problems like this one a few times before, i.e., RPC calls to bitcoind failing on MacOS due to inscrutable I/O errors. One time, I was able to fix it by increasing the open file limit using `ulimit -n BIG_NUMBER`, but that doesn't seem to work here.
My best guess is that the homebrew poeople have gotten pretty good at configuring packages on MacOS, and they're passing some flag, or using a patched version of boost, or linking it differently, such that the binary they produce isn't affected by this issue. | https://github.com/bitcoin/bitcoin/issues/25724 | https://github.com/bitcoin/bitcoin/pull/25985 | c35b91afdc401696f4b1ee65a876328fd462aec9 | a52ff619a45c760f657413cbd40e1e2226068541 | 2022-07-27T21:30:51Z | c++ | 2022-10-17T14:29:41Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,702 | ["src/wallet/rpc/backup.cpp", "src/wallet/rpc/encrypt.cpp", "src/wallet/rpc/transactions.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h", "test/functional/wallet_importdescriptors.py", "test/functional/wallet_transactiontime_rescan.py"] | Add EnsureWalletIsUnlocked to rescanblockchain RPC? | It seems that it would otherwise silently skip the rescan for pre-backup used keys that are still waiting to be generated into the keypool?
See also #11249 | https://github.com/bitcoin/bitcoin/issues/25702 | https://github.com/bitcoin/bitcoin/pull/26347 | ad461416025eb1581e8b20a95a4f316107b9431b | 80f4979322b574be29c684b2e106804432420ebf | 2022-07-26T06:40:36Z | c++ | 2023-02-21T19:02:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,692 | ["src/psbt.h"] | psbt.h:896:51: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'unsigned long' | This needs a code change or suppression added:
```
$ UBSAN_OPTIONS="suppressions=$(pwd)/scratch/fuzz_gen/code/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1" FUZZ=partially_signed_transaction_deserialize /root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz /tmp/crash-e4a4fe6f63596cd582f208eea9be69b716f61165
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 3574901271
INFO: Loaded 1 modules (322037 inline 8-bit counters): 322037 [0x555887da9f40, 0x555887df8935),
INFO: Loaded 1 PC tables (322037 PCs): 322037 [0x555887df8938,0x5558882e2888),
/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz: Running 1 inputs 1 time(s) each.
Running: /tmp/crash-e4a4fe6f63596cd582f208eea9be69b716f61165
psbt.h:896:51: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'unsigned long'
#0 0x555885271598 in void PSBTOutput::Unserialize<CDataStream>(CDataStream&) src/./psbt.h:896:51
#1 0x555885233a4e in void Unserialize<CDataStream, PSBTOutput&>(CDataStream&, PSBTOutput&) src/./serialize.h:682:7
#2 0x555885233a4e in CDataStream& CDataStream::operator>><PSBTOutput&>(PSBTOutput&) src/./streams.h:339:9
#3 0x55588523024f in void PartiallySignedTransaction::Unserialize<CDataStream>(CDataStream&) src/./psbt.h:1191:15
#4 0x55588522edee in void Unserialize<CDataStream, PartiallySignedTransaction&>(CDataStream&, PartiallySignedTransaction&) src/./serialize.h:682:7
#5 0x55588522edee in CDataStream& CDataStream::operator>><PartiallySignedTransaction&>(PartiallySignedTransaction&) src/./streams.h:339:9
#6 0x5558852067f5 in void (anonymous namespace)::DeserializeFromFuzzingInput<PartiallySignedTransaction>(Span<unsigned char const>, PartiallySignedTransaction&, std::optional<int>, int) src/./src/test/fuzz/deserialize.cpp:100:12
#7 0x5558852067f5 in partially_signed_transaction_deserialize_fuzz_target(Span<unsigned char const>) src/./src/test/fuzz/deserialize.cpp:173:1
#8 0x555885106682 in std::_Function_handler<void (Span<unsigned char const>), void (*)(Span<unsigned char const>)>::_M_invoke(std::_Any_data const&, Span<unsigned char const>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:300:2
#9 0x55588549ae5a in std::function<void (Span<unsigned char const>)>::operator()(Span<unsigned char const>) const /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/std_function.h:688:14
#10 0x55588549aad6 in LLVMFuzzerTestOneInput src/./src/test/fuzz/fuzz.cpp:154:5
#11 0x555885029372 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x141a372) (BuildId: 8e23fc37575bb16be5b418c47853b5da4e548abb)
#12 0x5558850138d0 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x14048d0) (BuildId: 8e23fc37575bb16be5b418c47853b5da4e548abb)
#13 0x555885019587 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x140a587) (BuildId: 8e23fc37575bb16be5b418c47853b5da4e548abb)
#14 0x555885042342 in main (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x1433342) (BuildId: 8e23fc37575bb16be5b418c47853b5da4e548abb)
#15 0x7fa7994a3082 in __libc_start_main /build/glibc-SzIz7B/glibc-2.31/csu/../csu/libc-start.c:308:16
#16 0x55588500e1cd in _start (/root/fuzz_dir/scratch/fuzz_gen/code/src/test/fuzz/fuzz+0x13ff1cd) (BuildId: 8e23fc37575bb16be5b418c47853b5da4e548abb)
SUMMARY: UndefinedBehaviorSanitizer: unsigned-integer-overflow psbt.h:896:51 in
```
```
$ base64 /tmp/crash-e4a4fe6f63596cd582f208eea9be69b716f61165
rPcKGHBzYnT/AQA9AAAAAAF6AAGDEwEA+8QAAP9glCALb/ITYCf/BwABAR4AAAAAWAAAAAAAGHBz
YgEBTEtAIxPsMAEAAAn8/wABKwAH/ACOCcgAAAAF/AAAAPwEAAAAAAb8AAAAAWQAA/wAAAf8AI4J
yCQuAAf8AAIA/wgBAAf8AAAJyAAAACEH/AAAjQFkygAG/AAACSEAASsBKwAH/ACOCcgAAAAF/AAA
APwEAAAAAAb8AAAAAAAG/AArAAFkAAP8AAAH/ACOCQAAIQAG/AAA/wgBAAf8AAAJwgAAAAf8AAAw
AWTKAAb8AAABQA8AB/wAAAAJASsAB/wAjgnIAAAABfwAAAD8BAAAAAAG/AAAAAAAAAEG/ABkAAP8
AAAH/AAACcgAAAAH/AAANQFkygAG/AAAAUAPAAf8AAkhAAErAAf8AAAACfz/AAErAAf8jgkAAMgA
AAX8AAAA/AQAAAAABvwAAAAAAAb8AAABZAAD/AAAB/wAjgnIJi4AB/wAAgAAAAAG/AAA/wgAB/wA
ADABZMoABvwAAAFADwAH/AAJIQABKwAH/AAAAAn8/wABKwAH/ACOCcgAAAAF/AAAAPwEAAAAAAb8
AAAAAWQAA/wAAAf8AI4JyCYuAAf8AAIA/wgBAAf8AAAJyAAAAAf8AACNAWTKAAb8AAAJIQABKwEr
AAf8AI4JyAAAAAX8AAAA/AQAAAAABvwAAAAAAAb8AAABZAAD/AAAB/wAjgnIJi4AB/wAAgAAACEA
BvwAAP8IAQAH/AAACcIAAAAH/AAAMAFkygAG/AAAAUAPAAf8AAkhAPwAAAD8AAQAAAAG/AAAAAFk
AAP8AAAH/ACOCcgkLgAH/AACAP8IAQAH/AAACcgAAAAH/AAAjQFk/AAACcIAAAAH/AAAMAFkygAG
/AAAAUAPAAf8AAAACQErAAf8AI4JyAAAAAX8AAAA/AQAAAAABvwAAAAAAAABBvwAZAAD/AAAB/wA
AAnIAAAAB/wAADUBZMoABvwAAAFADwAH/AAJIQABKwAH/AAAAAn8/wABKwAH/ACOCcgAAAAF/AAA
APwEAAAAAAb8AAAAAAAG/AAAAWQAA/wAAAf8AI4JyCYuAAf8AAIAAAAABvwAAAAAAAAAAAAAAAAA
AAD/CAAH/AAAMAFkygAG/AAAAUAPAAf8AAkhAAErAAf8AAAACfz/AAErAAf8AI4JyAAAAAX8AAAA
/AQAAAAABvwAAAABZAAD/AAAB/wAjgnIJi4AA/wAAAf8AI4JyCQuAAf8AAIA/wgBAAf8AAAJyAAA
AAf8AACNQGTKAAb8AAAJIQABKwErAAf8AI4JyAAAAAX8AAAA/AQAAAAABvwAAAAAAAb8ACsAAWQA
A/wAAAf8AI4JAAAhAAb8AAD/CAEAB/wAAAnCAAAAB/wAADABZMoABvwAAAFADwAH/AAAAAkBKwAH
/ACOCcgAAAAF/AAAAPwEAAAAAAb8AAAAAAAAAQb8AGQAA/wAAAf8E2An/wcAAQEeAv0AAHAkA/kV
YI4A/wTEAAD/YJ4iIiIiIq4AAAAAAAA=
| https://github.com/bitcoin/bitcoin/issues/25692 | https://github.com/bitcoin/bitcoin/pull/25700 | 5057adf22fc4c3593e1e633defeda96be508f198 | aa22009887eba6b6afdc530cfbcbe98e8aa34434 | 2022-07-25T06:44:42Z | c++ | 2022-07-25T19:07:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,682 | ["src/script/script.h"] | Redundant code or latent bug | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
Looking at the code below I can't understand how it is possible for the IF statement conditional expression to become true. cnt is already incremented before the IF statement. Is this not redundant? https://github.com/bitcoin/bitcoin/blob/master/src/script/script.h#L594
I have opened a ticket, https://stackoverflow.com/questions/73088518/reduntant-code-possibly-in-bitcoin-script-h
**Expected behavior**
Possibly doesn't change the behavior.
<!--- What behavior did you expect? -->
Not Applicable
**Actual behavior**
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
**To reproduce**
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
It is source code issue
**System information**
Not applicable
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
Main branch ..https://github.com/bitcoin/bitcoin
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
Not Applicable
<!-- GUI-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell? -->
Not Applicable
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/25682 | https://github.com/bitcoin/bitcoin/pull/25709 | 8e37afcb132599f59c887162279b4e76003c66d8 | 5215c80edcd031acf3911e8d824a843f817c6900 | 2022-07-23T06:59:34Z | c++ | 2022-07-30T15:49:02Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,652 | ["test/functional/wallet_backup.py"] | wallet_backup.py fails with AssertionError: not(50 == 0) [assert_equal(self.nodes[2].getbalance(), 0)] | From https://cirrus-ci.com/task/5098379825905664?logs=ci#L3267
```
node2 2022-07-20T16:54:37.082831Z [httpworker.0] [wallet/wallet.h:818] [WalletLogPrintf] [default wallet] Wallet file version = 10500, last client version = 239900
node2 2022-07-20T16:54:37.082858Z [httpworker.0] [wallet/wallet.h:818] [WalletLogPrintf] [default wallet] Keys: 0 plaintext, 0 encrypted, 0 w/ metadata, 0 total. Unknown wallet records: 0
node2 2022-07-20T16:54:37.363230Z [httpworker.0] [wallet/scriptpubkeyman.h:248] [WalletLogPrintf] [default wallet] keypool added 200 keys (100 internal), size=200 (100 internal)
node2 2022-07-20T16:54:37.372743Z [httpworker.0] [wallet/scriptpubkeyman.h:248] [WalletLogPrintf] [default wallet] LegacyScriptPubKeyMan::NewKeyPool rewrote keypool
node2 2022-07-20T16:54:37.374228Z [httpworker.0] [wallet/wallet.h:818] [WalletLogPrintf] [default wallet] Wallet completed loading in 301ms
node2 2022-07-20T16:54:37.374283Z [httpworker.0] [wallet/wallet.h:818] [WalletLogPrintf] [default wallet] setKeyPool.size() = 200
node2 2022-07-20T16:54:37.374293Z [httpworker.0] [wallet/wallet.h:818] [WalletLogPrintf] [default wallet] mapWallet.size() = 0
node2 2022-07-20T16:54:37.374302Z [httpworker.0] [wallet/wallet.h:818] [WalletLogPrintf] [default wallet] m_address_book.size() = 0
node2 2022-07-20T16:54:37.375129Z [http] [httpserver.cpp:241] [http_request_cb] [http] Received a POST request for / from 127.0.0.1:43832
node2 2022-07-20T16:54:37.375178Z [httpworker.2] [rpc/request.cpp:179] [parse] [rpc] ThreadRPCServer method=getwalletinfo user=__cookie__
node2 2022-07-20T16:54:37.375852Z [http] [httpserver.cpp:241] [http_request_cb] [http] Received a POST request for / from 127.0.0.1:43832
node2 2022-07-20T16:54:37.375896Z [httpworker.3] [rpc/request.cpp:179] [parse] [rpc] ThreadRPCServer method=importprivkey user=__cookie__
node2 2022-07-20T16:54:37.384691Z [httpworker.3] [wallet/scriptpubkeyman.h:248] [WalletLogPrintf] [default wallet] Already have script 00144ff785b8221dc206314ca12e65773a876dff30ff, skipping
node2 2022-07-20T16:54:37.385674Z [httpworker.3] [wallet/wallet.h:818] [WalletLogPrintf] [default wallet] RescanFromTime: Rescanning last 215 blocks
node2 2022-07-20T16:54:37.385688Z [httpworker.3] [wallet/wallet.h:818] [WalletLogPrintf] [default wallet] Rescan started from block 0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206...
node2 2022-07-20T16:54:37.386000Z [httpworker.3] [wallet/wallet.h:818] [WalletLogPrintf] [default wallet] AddToWallet 4cddeee95a635bbf1efa02cd90f11f3385981ba1461309d7e4787e8f3c95d2df new
node2 2022-07-20T16:54:37.391170Z [httpworker.3] [wallet/wallet.h:818] [WalletLogPrintf] [default wallet] Scanning current mempool transactions.
node2 2022-07-20T16:54:37.391187Z [httpworker.3] [wallet/wallet.h:818] [WalletLogPrintf] [default wallet] Rescan completed in 5ms
node0 2022-07-20T16:54:37.391944Z [http] [httpserver.cpp:241] [http_request_cb] [http] Received a POST request for / from 127.0.0.1:42220
node0 2022-07-20T16:54:37.391992Z [httpworker.1] [rpc/request.cpp:179] [parse] [rpc] ThreadRPCServer method=getbalance user=__cookie__
node1 2022-07-20T16:54:37.392518Z [http] [httpserver.cpp:241] [http_request_cb] [http] Received a POST request for / from 127.0.0.1:34582
node1 2022-07-20T16:54:37.392564Z [httpworker.2] [rpc/request.cpp:179] [parse] [rpc] ThreadRPCServer method=getbalance user=__cookie__
test 2022-07-20T16:54:37.393000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 133, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/wallet_backup.py", line 234, in run_test
assert_equal(self.nodes[2].getbalance(), 0)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 51, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(50.00000000 == 0) | https://github.com/bitcoin/bitcoin/issues/25652 | https://github.com/bitcoin/bitcoin/pull/28325 | 94af164e5eb285822f9b9817a09a265fd885c1ae | e8989f295d18b8e14a28da68913d2c400045ba52 | 2022-07-20T16:58:45Z | c++ | 2023-08-24T09:30:58Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,640 | ["src/coins.cpp"] | Tracing: coins.cpp:102:22: error: 'coin' used after it was moved [bugprone-use-after-move] | This may be fine because `int` values aren't touched by a `std::move`, but it seems brittle and confusing:
```
coins.cpp:102:22: error: 'coin' used after it was moved [bugprone-use-after-move,-warnings-as-errors]
(uint32_t)coin.nHeight,
^
coins.cpp:96:21: note: move occurred here
it->second.coin = std::move(coin);
^
```
| https://github.com/bitcoin/bitcoin/issues/25640 | https://github.com/bitcoin/bitcoin/pull/25663 | c5ba1d92b633e703c25121c0d73dc0e04baae01b | f5eadcb148713add9a183a31b011ce86ecf7fa20 | 2022-07-19T09:18:50Z | c++ | 2022-08-01T09:05:02Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,606 | ["doc/release-notes-27037.md", "src/core_io.h", "src/core_write.cpp", "src/rpc/rawtransaction.cpp", "test/functional/data/rpc_decodescript.json", "test/functional/rpc_decodescript.py"] | Miniscript support for decodescript | Current behavior:
```
src/bitcoin-cli -signet decodescript 2103d3b9c8cc852f3b4a06bad1711fd1a1761a592bf1475edc0a5f97b31759eba330ac736476a914b6e87320e876a740fc1365aeb1f4b6ab2fe4210b88ad53b268
```
```json
{
"asm": "03d3b9c8cc852f3b4a06bad1711fd1a1761a592bf1475edc0a5f97b31759eba330 OP_CHECKSIG OP_IFDUP OP_NOTIF OP_DUP OP_HASH160 b6e87320e876a740fc1365aeb1f4b6ab2fe4210b OP_EQUALVERIFY OP_CHECKSIGVERIFY 3 OP_CHECKSEQUENCEVERIFY OP_ENDIF",
"desc": "raw(2103d3b9c8cc852f3b4a06bad1711fd1a1761a592bf1475edc0a5f97b31759eba330ac736476a914b6e87320e876a740fc1365aeb1f4b6ab2fe4210b88ad53b268)#uul8nd2t",
"type": "nonstandard",
"p2sh": "2N62ryy2gBC2QBSdsm832Tv6qCW5py53wJn",
"segwit": {
"asm": "0 43c1d0387e91045591f19ff6d60af2bc0d91473b79dc3238aa9d0430f89741bc",
"desc": "addr(tb1qg0qaqwr7jyz9ty03nlmdvzhjhsxez3em08wryw92n5zrp7yhgx7qj56vra)#ugngfnm5",
"hex": "002043c1d0387e91045591f19ff6d60af2bc0d91473b79dc3238aa9d0430f89741bc",
"address": "tb1qg0qaqwr7jyz9ty03nlmdvzhjhsxez3em08wryw92n5zrp7yhgx7qj56vra",
"type": "witness_v0_scripthash",
"p2sh-segwit": "2N9diLEHbASsz1oAeDQJPg5mb4LaAju9175"
}
}
```
It would be nice if this (also) returned miniscript.
Perhaps `getaddressinfo` could do this as well (after #24148).
cc @sipa, @darosior | https://github.com/bitcoin/bitcoin/issues/25606 | https://github.com/bitcoin/bitcoin/pull/27037 | 2ccd7be26f0e10b034e4b13703af24ec3d217a79 | e2ae5c349cd9c0e1db090ca3df3160f26d5c105d | 2022-07-13T15:02:11Z | c++ | 2023-02-03T20:34:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,563 | ["src/validation.cpp"] | verifychain 4 111000 aborts with assertion "hashPrevBlock == view.GetBestBlock()" failed | Providing a low number of blocks works, however, it just crashed for me with 111000 blocks.
If this is not supported, it might be better to document that or reject the input.
Commit 691a08718beff31d1b821b192609ea3bfdb24d41
Output:
```
bitcoin-qt: validation.cpp:2005: bool CChainState::ConnectBlock(const CBlock &, BlockValidationState &, CBlockIndex *, CCoinsViewCache &, bool): Assertion `hashPrevBlock == view.GetBestBlock()' failed.
| https://github.com/bitcoin/bitcoin/issues/25563 | https://github.com/bitcoin/bitcoin/pull/27009 | d71b0e78eb0f24e8b147657c8561d74e441c2503 | 8f4ae658187425b09a9003678e730b0daeb9459d | 2022-07-07T09:47:07Z | c++ | 2023-02-05T13:28:05Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,501 | ["src/Makefile.am", "src/Makefile.bench.include", "src/Makefile.test.include"] | build: autoconf 2.71 warns that `%.raw.h` was already defined | The master branch (cc22bd7f708fc3f5e793bf0138cd340f71c0feb9) on Ubuntu 22.04:
```
$ ./autogen.sh
...
src/Makefile.bench.include:97: warning: %.raw.h was already defined in condition TRUE, which includes condition ENABLE_BENCH ...
src/Makefile.am:1065: 'src/Makefile.bench.include' included from here
src/Makefile.test.include:420: ... '%.raw.h' previously defined here
src/Makefile.am:1062: 'src/Makefile.test.include' included from here
...
``` | https://github.com/bitcoin/bitcoin/issues/25501 | https://github.com/bitcoin/bitcoin/pull/25813 | f5e96ecef5f6e06a06c3dde8796311a5eb8d7f4f | deb7ad35e687e1ff0e5578d389c6617d93bef296 | 2022-06-29T15:29:50Z | c++ | 2022-08-10T17:20:03Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,482 | ["test/functional/wallet_encryption.py"] | qa: Intermittent failure in `wallet_encryption.py --descriptors` | ERROR: type should be string, got "https://cirrus-ci.com/task/4615142003441664\r\n\r\n<details><summary>log excerpt</summary>\r\n<p>\r\n\r\n```\r\n177/244 - wallet_encryption.py --descriptors failed, Duration: 6 s\r\n\r\nstdout:\r\n2022-06-27T07:50:03.095000Z TestFramework (INFO): Initializing test directory C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\test_runner_₿_🏃_20220627_071202\\wallet_encryption_65\r\n\r\n2022-06-27T07:50:08.820000Z TestFramework (INFO): Check a timeout less than the limit\r\n\r\n2022-06-27T07:50:09.007000Z TestFramework (ERROR): Assertion failed\r\n\r\nTraceback (most recent call last):\r\n\r\n File \"C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\cirrus-ci-build\\test\\functional\\test_framework\\test_framework.py\", line 133, in main\r\n\r\n self.run_test()\r\n\r\n File \"C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\cirrus-ci-build\\test\\functional\\wallet_encryption.py\", line 85, in run_test\r\n\r\n assert_greater_than(expected_time_with_buffer, actual_time)\r\n\r\n File \"C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\cirrus-ci-build\\test\\functional\\test_framework\\util.py\", line 56, in assert_greater_than\r\n\r\n raise AssertionError(\"%s <= %s\" % (str(thing1), str(thing2)))\r\n\r\nAssertionError: 1756315608.992383 <= 1756315609\r\n\r\n2022-06-27T07:50:09.070000Z TestFramework (INFO): Stopping nodes\r\n\r\n2022-06-27T07:50:09.211000Z TestFramework (WARNING): Not cleaning up dir C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\test_runner_₿_🏃_20220627_071202\\wallet_encryption_65\r\n\r\n2022-06-27T07:50:09.211000Z TestFramework (ERROR): Test failed. Test logging available at C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\test_runner_₿_🏃_20220627_071202\\wallet_encryption_65/test_framework.log\r\n\r\n2022-06-27T07:50:09.211000Z TestFramework (ERROR): \r\n\r\n2022-06-27T07:50:09.211000Z TestFramework (ERROR): Hint: Call C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\cirrus-ci-build\\test\\functional\\combine_logs.py 'C:\\Users\\ContainerAdministrator\\AppData\\Local\\Temp\\test_runner_₿_🏃_20220627_071202\\wallet_encryption_65' to consolidate all logs\r\n\r\n2022-06-27T07:50:09.211000Z TestFramework (ERROR): \r\n\r\n2022-06-27T07:50:09.211000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.\r\n\r\n2022-06-27T07:50:09.211000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues\r\n\r\n2022-06-27T07:50:09.211000Z TestFramework (ERROR): \r\n```\r\n\r\n</p>\r\n</details>" | https://github.com/bitcoin/bitcoin/issues/25482 | https://github.com/bitcoin/bitcoin/pull/25878 | 6b56873b41974ced7aad87a4b38abe360c34eed3 | c73c8d53fe27956faacb3e8ca0e94adf071de6ec | 2022-06-27T08:19:26Z | c++ | 2022-08-20T06:50:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,475 | ["ci/test/06_script_a.sh"] | ci: Handle `ccache` in the proper way in "ARM64 Android APK" task | On the master branch, there are some flaws when using `ccache` in the "ARM64 Android APK" CI task:
- no `ccache` statistics printed
- no our custom cache size [limit](https://github.com/bitcoin/bitcoin/blob/0dd34773334c7f4db7b05df30ee61b011795b46d/.cirrus.yml#L6) applied (it has grown up to `ccache cache size is 4243Mb.` for [now](https://api.cirrus-ci.com/v1/task/5827307548966912/logs/Upload%20'ccache'%20cache.log))
<!-- Needs the label "good first issue" assigned manually before or after opening -->
<!-- A good first issue is an uncontroversial issue, that has a relatively unique and obvious solution -->
<!-- Motivate the issue and explain the solution briefly -->
#### Useful skills:
- basic Bash skills
- basic understanding of [Cirrus CI](https://cirrus-ci.org/guide/quick-start/)
<!-- (For example, “C++11 std::thread”, “Qt5 GUI and async GUI design” or “basic understanding of Bitcoin mining and the Bitcoin Core RPC interface”.) -->
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
Probably, only a few modifications in [`ci/test/06_script_a.sh`](https://github.com/bitcoin/bitcoin/blob/master/ci/test/06_script_a.sh) are required. | https://github.com/bitcoin/bitcoin/issues/25475 | https://github.com/bitcoin/bitcoin/pull/25530 | 9c55091be261e58f1daaf045dffd0487d1b9d1eb | f0e44492d38d2f26dc95f29e4a11bb0c6836ff4e | 2022-06-26T10:57:27Z | c++ | 2022-07-04T14:22:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,365 | ["src/test/coinstatsindex_tests.cpp", "src/test/txindex_tests.cpp"] | ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) in BaseIndex | https://cirrus-ci.com/task/6564394053140480?logs=ci#L3875:
```bash
WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) (pid=24158)
Write of size 8 at 0x7ffe0efae9f8 by main thread:
#0 BaseIndex::~BaseIndex() src/index/base.cpp:53:1 (test_bitcoin+0xcc6b69)
#1 CoinStatsIndex::~CoinStatsIndex() src/./index/coinstatsindex.h:17:7 (test_bitcoin+0x3b9b21)
#2 coinstatsindex_tests::coinstatsindex_initial_sync::test_method() src/test/coinstatsindex_tests.cpp:84:1 (test_bitcoin+0x3b9b21)
#3 coinstatsindex_tests::coinstatsindex_initial_sync_invoker() src/test/coinstatsindex_tests.cpp:32:1 (test_bitcoin+0x3b814b)
#4 boost::detail::function::void_function_invoker0<void (*)(), void>::invoke(boost::detail::function::function_buffer&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/function/function_template.hpp:117:11 (test_bitcoin+0x2bbf1d)
#5 boost::function0<void>::operator()() const /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/function/function_template.hpp:763:14 (test_bitcoin+0x220877)
#6 boost::detail::forward::operator()() /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/execution_monitor.ipp:1388:32 (test_bitcoin+0x220877)
#7 boost::detail::function::function_obj_invoker0<boost::detail::forward, int>::invoke(boost::detail::function::function_buffer&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/function/function_template.hpp:137:18 (test_bitcoin+0x220877)
#8 boost::function0<int>::operator()() const /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/function/function_template.hpp:763:14 (test_bitcoin+0x1ae59e)
#9 int boost::detail::do_invoke<boost::shared_ptr<boost::detail::translator_holder_base>, boost::function<int ()> >(boost::shared_ptr<boost::detail::translator_holder_base> const&, boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/execution_monitor.ipp:301:30 (test_bitcoin+0x1ae59e)
#10 boost::execution_monitor::catch_signals(boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/execution_monitor.ipp:903:16 (test_bitcoin+0x1ae59e)
#11 boost::execution_monitor::execute(boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/execution_monitor.ipp:1301:16 (test_bitcoin+0x1ae8c0)
#12 boost::execution_monitor::vexecute(boost::function<void ()> const&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/execution_monitor.ipp:1397:5 (test_bitcoin+0x1aa21b)
#13 boost::unit_test::unit_test_monitor_t::execute_and_translate(boost::function<void ()> const&, unsigned long) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/unit_test_monitor.ipp:49:9 (test_bitcoin+0x1aa21b)
#14 boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/framework.ipp:815:44 (test_bitcoin+0x1ddb63)
#15 boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/framework.ipp:784:58 (test_bitcoin+0x1de1d8)
#16 boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/framework.ipp:784:58 (test_bitcoin+0x1de1d8)
#17 boost::unit_test::framework::run(unsigned long, bool) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/framework.ipp:1721:29 (test_bitcoin+0x1a8e66)
#18 boost::unit_test::unit_test_main(boost::unit_test::test_suite* (*)(int, char**), int, char**) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/unit_test_main.ipp:250:9 (test_bitcoin+0x1c19c6)
#19 main /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/unit_test_main.ipp:306:12 (test_bitcoin+0x1c1ff6)
Previous read of size 8 at 0x7ffe0efae9f8 by thread T1 (mutexes: write M603):
#0 BaseIndex::SetBestBlockIndex(CBlockIndex const*)::$_1::operator()() const src/index/base.cpp:388:9 (test_bitcoin+0xcc74e6)
#1 BaseIndex::SetBestBlockIndex(CBlockIndex const*) src/index/base.cpp:388:9 (test_bitcoin+0xcc74e6)
#2 BaseIndex::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*) src/index/base.cpp:273:9 (test_bitcoin+0xcc9759)
#3 CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_8::operator()() const::'lambda'(CValidationInterface&)::operator()(CValidationInterface&) const src/validationinterface.cpp:225:79 (test_bitcoin+0x10223a4)
#4 void MainSignalsImpl::Iterate<CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_8::operator()() const::'lambda'(CValidationInterface&)>(CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_8::operator()() const::'lambda'(CValidationInterface&)&&) src/validationinterface.cpp:86:17 (test_bitcoin+0x10223a4)
#5 CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_8::operator()() const src/validationinterface.cpp:225:22 (test_bitcoin+0x10223a4)
#6 CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_9::operator()() const src/validationinterface.cpp:227:5 (test_bitcoin+0x10223a4)
#7 decltype(static_cast<CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_9&>(fp)()) std::__1::__invoke<CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_9&>(CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_9&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3918:1 (test_bitcoin+0x10223a4)
#8 void std::__1::__invoke_void_return_wrapper<void, true>::__call<CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_9&>(CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_9&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/invoke.h:61:9 (test_bitcoin+0x10223a4)
#9 std::__1::__function::__alloc_func<CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_9, std::__1::allocator<CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_9>, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:171:16 (test_bitcoin+0x10223a4)
#10 std::__1::__function::__func<CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_9, std::__1::allocator<CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_9>, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:345:12 (test_bitcoin+0x10223a4)
#11 std::__1::__function::__value_func<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:498:16 (test_bitcoin+0x10b6b71)
#12 std::__1::function<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:1175:12 (test_bitcoin+0x10b6b71)
#13 SingleThreadedSchedulerClient::ProcessQueue() src/scheduler.cpp:175:5 (test_bitcoin+0x10b6b71)
#14 SingleThreadedSchedulerClient::MaybeScheduleProcessQueue()::$_1::operator()() const src/scheduler.cpp:144:41 (test_bitcoin+0x10b8875)
#15 decltype(static_cast<SingleThreadedSchedulerClient::MaybeScheduleProcessQueue()::$_1&>(fp)()) std::__1::__invoke<SingleThreadedSchedulerClient::MaybeScheduleProcessQueue()::$_1&>(SingleThreadedSchedulerClient::MaybeScheduleProcessQueue()::$_1&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3918:1 (test_bitcoin+0x10b8875)
#16 void std::__1::__invoke_void_return_wrapper<void, true>::__call<SingleThreadedSchedulerClient::MaybeScheduleProcessQueue()::$_1&>(SingleThreadedSchedulerClient::MaybeScheduleProcessQueue()::$_1&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/invoke.h:61:9 (test_bitcoin+0x10b8875)
#17 std::__1::__function::__alloc_func<SingleThreadedSchedulerClient::MaybeScheduleProcessQueue()::$_1, std::__1::allocator<SingleThreadedSchedulerClient::MaybeScheduleProcessQueue()::$_1>, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:171:16 (test_bitcoin+0x10b8875)
#18 std::__1::__function::__func<SingleThreadedSchedulerClient::MaybeScheduleProcessQueue()::$_1, std::__1::allocator<SingleThreadedSchedulerClient::MaybeScheduleProcessQueue()::$_1>, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:345:12 (test_bitcoin+0x10b8875)
#19 std::__1::__function::__value_func<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:498:16 (test_bitcoin+0x10b5b5c)
#20 std::__1::function<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:1175:12 (test_bitcoin+0x10b5b5c)
#21 CScheduler::serviceQueue() src/scheduler.cpp:62:17 (test_bitcoin+0x10b5b5c)
#22 ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0::operator()() const src/test/util/setup_common.cpp:160:110 (test_bitcoin+0xa4e7b8)
#23 decltype(static_cast<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&>(fp)()) std::__1::__invoke<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&>(ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3918:1 (test_bitcoin+0xa4e7b8)
#24 void std::__1::__invoke_void_return_wrapper<void, true>::__call<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&>(ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&) /usr/lib/llvm-13/bin/../include/c++/v1/__functional/invoke.h:61:9 (test_bitcoin+0xa4e7b8)
#25 std::__1::__function::__alloc_func<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0, std::__1::allocator<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:171:16 (test_bitcoin+0xa4e7b8)
#26 std::__1::__function::__func<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0, std::__1::allocator<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>, void ()>::operator()() /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:345:12 (test_bitcoin+0xa4e7b8)
#27 std::__1::__function::__value_func<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:498:16 (test_bitcoin+0x115760f)
#28 std::__1::function<void ()>::operator()() const /usr/lib/llvm-13/bin/../include/c++/v1/__functional/function.h:1175:12 (test_bitcoin+0x115760f)
#29 util::TraceThread(char const*, std::__1::function<void ()>) src/util/thread.cpp:18:9 (test_bitcoin+0x115760f)
#30 decltype(static_cast<void (*>(fp)(static_cast<char const*>(fp0), static_cast<ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>(fp0))) std::__1::__invoke<void (*)(char const*, std::__1::function<void ()>), char const*, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>(void (*&&)(char const*, std::__1::function<void ()>), char const*&&, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&&) /usr/lib/llvm-13/bin/../include/c++/v1/type_traits:3918:1 (test_bitcoin+0xa4e3b1)
#31 void std::__1::__thread_execute<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(char const*, std::__1::function<void ()>), char const*, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0, 2ul, 3ul>(std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(char const*, std::__1::function<void ()>), char const*, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0>&, std::__1::__tuple_indices<2ul, 3ul>) /usr/lib/llvm-13/bin/../include/c++/v1/thread:280:5 (test_bitcoin+0xa4e3b1)
#32 void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(char const*, std::__1::function<void ()>), char const*, ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0> >(void*) /usr/lib/llvm-13/bin/../include/c++/v1/thread:291:5 (test_bitcoin+0xa4e3b1)
Location is stack of main thread.
Location is global '??' at 0x7ffe0ef91000 ([stack]+0x00000001d9f8)
Mutex M603 (0x558df2c934a0) created at:
#0 pthread_mutex_init <null> (test_bitcoin+0x11cf6f)
#1 std::__1::recursive_mutex::recursive_mutex() <null> (libc++.so.1+0x49fb3)
#2 __libc_start_main <null> (libc.so.6+0x29eba)
Thread T1 'b-scheduler' (tid=24216, running) created by main thread at:
#0 pthread_create <null> (test_bitcoin+0x11b7fd)
#1 std::__1::__libcpp_thread_create(unsigned long*, void* (*)(void*), void*) /usr/lib/llvm-13/bin/../include/c++/v1/__threading_support:443:10 (test_bitcoin+0xa47a76)
#2 std::__1::thread::thread<void (&)(char const*, std::__1::function<void ()>), char const (&) [10], ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0, void>(void (&)(char const*, std::__1::function<void ()>), char const (&) [10], ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&)::$_0&&) /usr/lib/llvm-13/bin/../include/c++/v1/thread:307:16 (test_bitcoin+0xa47a76)
#3 ChainTestingSetup::ChainTestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&) src/test/util/setup_common.cpp:160:42 (test_bitcoin+0xa47a76)
#4 TestingSetup::TestingSetup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&) src/test/util/setup_common.cpp:198:7 (test_bitcoin+0xa47ed9)
#5 TestChain100Setup::TestChain100Setup(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::vector<char const*, std::__1::allocator<char const*> > const&) src/test/util/setup_common.cpp:246:7 (test_bitcoin+0xa48be3)
#6 coinstatsindex_tests::coinstatsindex_initial_sync::coinstatsindex_initial_sync() src/test/coinstatsindex_tests.cpp:32:1 (test_bitcoin+0x3b7c8b)
#7 coinstatsindex_tests::coinstatsindex_initial_sync_invoker() src/test/coinstatsindex_tests.cpp:32:1 (test_bitcoin+0x3b7c8b)
#8 boost::detail::function::void_function_invoker0<void (*)(), void>::invoke(boost::detail::function::function_buffer&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/function/function_template.hpp:117:11 (test_bitcoin+0x2bbf1d)
#9 boost::function0<void>::operator()() const /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/function/function_template.hpp:763:14 (test_bitcoin+0x220877)
#10 boost::detail::forward::operator()() /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/execution_monitor.ipp:1388:32 (test_bitcoin+0x220877)
#11 boost::detail::function::function_obj_invoker0<boost::detail::forward, int>::invoke(boost::detail::function::function_buffer&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/function/function_template.hpp:137:18 (test_bitcoin+0x220877)
#12 boost::function0<int>::operator()() const /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/function/function_template.hpp:763:14 (test_bitcoin+0x1ae59e)
#13 int boost::detail::do_invoke<boost::shared_ptr<boost::detail::translator_holder_base>, boost::function<int ()> >(boost::shared_ptr<boost::detail::translator_holder_base> const&, boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/execution_monitor.ipp:301:30 (test_bitcoin+0x1ae59e)
#14 boost::execution_monitor::catch_signals(boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/execution_monitor.ipp:903:16 (test_bitcoin+0x1ae59e)
#15 boost::execution_monitor::execute(boost::function<int ()> const&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/execution_monitor.ipp:1301:16 (test_bitcoin+0x1ae8c0)
#16 boost::execution_monitor::vexecute(boost::function<void ()> const&) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/execution_monitor.ipp:1397:5 (test_bitcoin+0x1aa21b)
#17 boost::unit_test::unit_test_monitor_t::execute_and_translate(boost::function<void ()> const&, unsigned long) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/unit_test_monitor.ipp:49:9 (test_bitcoin+0x1aa21b)
#18 boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/framework.ipp:815:44 (test_bitcoin+0x1ddb63)
#19 boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/framework.ipp:784:58 (test_bitcoin+0x1de1d8)
#20 boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/framework.ipp:784:58 (test_bitcoin+0x1de1d8)
#21 boost::unit_test::framework::run(unsigned long, bool) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/framework.ipp:1721:29 (test_bitcoin+0x1a8e66)
#22 boost::unit_test::unit_test_main(boost::unit_test::test_suite* (*)(int, char**), int, char**) /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/unit_test_main.ipp:250:9 (test_bitcoin+0x1c19c6)
#23 main /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/test/impl/unit_test_main.ipp:306:12 (test_bitcoin+0x1c1ff6)
SUMMARY: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) src/index/base.cpp:53:1 in BaseIndex::~BaseIndex()
==================
Exit status: 2
``` | https://github.com/bitcoin/bitcoin/issues/25365 | https://github.com/bitcoin/bitcoin/pull/26188 | 7e1007a3c6c9a921c2b60919b84a60eaabfe1c5d | 422efcad36e31891faddc24d3bc05a825baaa4d9 | 2022-06-13T18:11:10Z | c++ | 2022-10-13T03:42:27Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,211 | ["depends/packages/bdb.mk"] | depends bdb -Werror=format-security "format not a string literal and no format arguments" | Running `make -C depends` on nixos with gcc 10.3.0 results in
```c++
libtool: compile: gcc -c -I. -I../dist/./.. -I/home/russ/work/bitcoin/depends/x86_64-pc-linux-gnu/include -D_GNU_SOURCE -D_REENTRANT -pipe -O2 -Wno-error=implicit-function-declaration ../dist/./../txn/txn.c -fPIC -DPIC -o txn.o
../dist/./../txn/txn.c: In function ‘__txn_begin’:
../dist/./../txn/txn.c:171:3: error: format not a string literal and no format arguments [-Werror=format-security]
171 | __db_errx(env, TxnAlloc);
| ^~~~~~~~~
../dist/./../txn/txn.c: In function ‘__txn_compensate_begin’:
../dist/./../txn/txn.c:318:3: error: format not a string literal and no format arguments [-Werror=format-security]
318 | __db_errx(env, TxnAlloc);
| ^~~~~~~~~
cc1: some warnings being treated as errors
make[1]: *** [Makefile:1980: txn.o] Error 1
make[1]: Leaving directory '/home/russ/work/bitcoin/depends/work/build/x86_64-pc-linux-gnu/bdb/4.8.30-1205703c56a/build_unix'
make: *** [funcs.mk:288: /home/russ/work/bitcoin/depends/work/build/x86_64-pc-linux-gnu/bdb/4.8.30-1205703c56a/build_unix/.stamp_built] Error 2
make: Leaving directory '/home/russ/work/bitcoin/depends'
```
I could work around it with
```diff
diff --git a/depends/packages/bdb.mk b/depends/packages/bdb.mk
index dc536fd3991..b69276cb154 100644
--- a/depends/packages/bdb.mk
+++ b/depends/packages/bdb.mk
@@ -14,7 +14,7 @@ $(package)_config_opts_freebsd=--with-pic
$(package)_config_opts_netbsd=--with-pic
$(package)_config_opts_openbsd=--with-pic
$(package)_config_opts_android=--with-pic
-$(package)_cflags+=-Wno-error=implicit-function-declaration
+$(package)_cflags+=-Wno-error=implicit-function-declaration -Wno-error=format-security
$(package)_cxxflags+=-std=c++17
$(package)_cppflags_mingw32=-DUNICODE -D_UNICODE
endef
```
But I don't know if this is the right fix or if there possibly is a real bug in the code causing the warning. | https://github.com/bitcoin/bitcoin/issues/25211 | https://github.com/bitcoin/bitcoin/pull/25763 | 816ca01650f4cc66a61ac2f9b0f8b74cd9cd0cf8 | eb72f6323d8605126eb01cd8990feb71417c60ed | 2022-05-25T15:10:36Z | c++ | 2022-08-02T10:52:33Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,130 | ["doc/release-notes-25158.md", "src/wallet/rpc/transactions.cpp", "test/functional/wallet_bumpfee.py"] | gettransaction does not contain the field "abandoned" for abandoned receiving tx | In specter https://github.com/cryptoadvance/specter-desktop/issues/1491#issuecomment-1126145011 a user can abandon an **receiving** tx that was evicted from the mempool (for example because it was double spent). The tx is marked via [abandontransaction](https://github.com/bitcoin-dot-org/developer.bitcoin.org/blob/master/reference/rpc/abandontransaction.rst) as abandoned in bitcoin core.
However [gettransaction](https://github.com/bitcoin-dot-org/developer.bitcoin.org/blob/master/reference/rpc/gettransaction.rst) and [listtransactions](https://github.com/bitcoin-dot-org/developer.bitcoin.org/blob/master/reference/rpc/listtransactions.rst) do not return the field `abandoned`, even though this is visible in the GUI:
**Consequence**: Specter cannot get the `abandoned` information from bitcoin rpc, and will fetch the abandoned tx back again via [listtransactions](https://github.com/bitcoin-dot-org/developer.bitcoin.org/blob/master/reference/rpc/listtransactions.rst) after it was deleted in specter.
**Describe the solution you'd like**
Always return the `abandoned` field in https://github.com/bitcoin/bitcoin/blob/225e5b57b2ee2bc1acd7f09c89ccccc15ef8c85f/src/wallet/rpc/transactions.cpp#L345 and not only in this special case https://github.com/bitcoin/bitcoin/blob/225e5b57b2ee2bc1acd7f09c89ccccc15ef8c85f/src/wallet/rpc/transactions.cpp#L375
That should then automatically solve [gettransaction](https://github.com/bitcoin-dot-org/developer.bitcoin.org/blob/master/reference/rpc/gettransaction.rst) via https://github.com/bitcoin/bitcoin/blob/225e5b57b2ee2bc1acd7f09c89ccccc15ef8c85f/src/wallet/rpc/transactions.cpp#L795
**Describe alternatives you've considered**
If specter can't get the information about abandoned tx from bitcoin, it would have to keep an internal list. That is possible, but redundant and can lead to many edge cases.
**Steps to reproduce**
- Wallet A: Send 1 BTC to Wallet B (rbf)
- Wallet A: Replace tx with rbf to send all funds to wallet A
- Wallet B: Abandon tx (because no longer in mempool)
- Wallet B: [gettransaction](https://github.com/bitcoin-dot-org/developer.bitcoin.org/blob/master/reference/rpc/gettransaction.rst) will not show the `abandoned` field | https://github.com/bitcoin/bitcoin/issues/25130 | https://github.com/bitcoin/bitcoin/pull/25158 | bdfe27c9d2f2e28239b361d9f0b78501054fe41e | 91ccb62faab21b2b52b089cc04f3a5c1bf6989cc | 2022-05-13T15:40:59Z | c++ | 2023-04-26T12:50:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,129 | ["test/functional/wallet_taproot.py"] | subtractfeefromamount=true fails with insufficient funds | Was: https://github.com/bitcoin/bitcoin/issues/25030
Steps to reproduce:
```
wget https://github.com/bitcoin/bitcoin/files/8688722/datadir_node0.tar.gz
tar -xvf datadir_node0.tar.gz
export DD='-datadir=./node0/'
bitcoin-qt $DD &
bitcoin-cli $DD loadwallet rpc_online
bitcoin-cli $DD -named sendtoaddress address=bcrt1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq3xueyj amount=1966.66779818 subtractfeefromamount=true | https://github.com/bitcoin/bitcoin/issues/25129 | https://github.com/bitcoin/bitcoin/pull/25159 | d5d40d59f8d12cf53c5ad1ce9710f3f108cec386 | f7a1e676d536115aba649672ba1e68755a1c90dc | 2022-05-13T14:54:25Z | c++ | 2022-05-17T23:51:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,127 | ["src/rpc/output_script.cpp", "src/wallet/rpc/addresses.cpp", "test/functional/rpc_createmultisig.py"] | rpc: createmultisig adds incorrect warning for address type p2sh-segwit | The `createmultisig` RPC adds a spurious warning message when creating for address type p2sh-segwit.
```
createmultisig 2 '["0279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798", "0279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798"]' 'p2sh-segwit'
{
"address": "3QfZQY7wQrBGEUB7E5vVLggeeAUVZ1Bbg9",
"redeemScript": "52210279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798210279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f8179852ae",
"descriptor": "sh(wsh(multi(2,0279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798,0279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798)))#m8ww0c9m",
"warnings": [
"Unable to make chosen address type, please ensure no uncompressed public keys are present."
]
}
```
I think this traces back to https://github.com/bitcoin/bitcoin/pull/23113
In the code, the comparison at https://github.com/bitcoin/bitcoin/blob/225e5b57b2ee2bc1acd7f09c89ccccc15ef8c85f/src/rpc/output_script.cpp#L166 fails since `output_type` is `OutputType::P2SH_SEGWIT` and https://github.com/bitcoin/bitcoin/blob/225e5b57b2ee2bc1acd7f09c89ccccc15ef8c85f/src/outputtype.cpp#L112 returns `OutputType::LEGACY`
**Expected behavior**
No warning message. For example:
```
createmultisig 2 '["0279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798", "0279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798"]' 'p2sh-segwit'
{
"address": "3QfZQY7wQrBGEUB7E5vVLggeeAUVZ1Bbg9",
"redeemScript": "52210279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798210279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f8179852ae",
"descriptor": "sh(wsh(multi(2,0279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798,0279be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798)))#m8ww0c9m"
}
``` | https://github.com/bitcoin/bitcoin/issues/25127 | https://github.com/bitcoin/bitcoin/pull/25220 | e82d8069bcd0b05c3c12bfc2e1e63a82a8ca6290 | 06ea2783a2c11e7b171e2809c3211bb3091d894d | 2022-05-13T12:33:52Z | c++ | 2022-06-06T15:13:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,082 | ["contrib/guix/libexec/prelude.bash"] | Guix build w/o substitutes failing at libgit2 check | This is an upstream Guix issue ([55273](https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55273)), but they seem to be planning to resolve it with a version bump, and either way we have versions pinned I think.
```
building /gnu/store/myai2xf4f0z2nr331mx2y4xr4jv1lwid-libgit2-1.3.0.drv...
| 'unpack' phaseild-log 356 178
`/gnu/store/xa8yg9nvawhfvk6hv8lhif9z5pybzan5-libgit2-1.3.0-checkout/tests/resources/status/staged_delete_modified_file' -> `./tests/resources/status/staged_delete_modified_file'
17% [######################## ]ild-log 356 189
/tmp/guix-build-libgit2-1.3.0.drv-0/source/src/regexp.c:148:5: warning: ?error? may be used uninitialized in this function [-Wmaybe-uninitialized]
148 | if (error < 0)
| ^
17% [######################## ]ild-log 356 72
[ 18%] Building C object src/CMakeFiles/git2internal.dir/repository.c.o
| 'check' phasenote: keeping build directory `/tmp/guix-build-libgit2-1.3.0.drv-0'
builder for `/gnu/store/myai2xf4f0z2nr331mx2y4xr4jv1lwid-libgit2-1.3.0.drv' failed with exit code 1
build of /gnu/store/myai2xf4f0z2nr331mx2y4xr4jv1lwid-libgit2-1.3.0.drv failed
```
```
refs::revparse.................F
1) Failure:
refs::revparse::date [/tmp/guix-build-libgit2-1.3.0.drv-0/source/tests/refs/revparse.c:31]
Function call succeeded: error
no error, expected non-zero return
```
| https://github.com/bitcoin/bitcoin/issues/25082 | https://github.com/bitcoin/bitcoin/pull/25099 | a2a8e919ee07506083f45426874cd2edf82d9f9f | e3bab43329e78e93e13b8f55330b183c3a3c954e | 2022-05-07T21:38:45Z | c++ | 2022-05-12T07:20:41Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,031 | ["test/functional/feature_index_prune.py"] | Intermittent win64 CI failure in feature_index_prune.py | https://cirrus-ci.com/task/6532449864777728
Win64 native [msvc] task
```
test 2022-04-29T14:22:15.843000Z TestFramework (WARNING): Not cleaning up dir C:\Users\ContainerAdministrator\AppData\Local\Temp\test_runner_₿_🏃_20220429_140215\feature_index_prune_242
test 2022-04-29T14:22:15.843000Z TestFramework (ERROR): Test failed. Test logging available at C:\Users\ContainerAdministrator\AppData\Local\Temp\test_runner_₿_🏃_20220429_140215\feature_index_prune_242/test_framework.log
test 2022-04-29T14:22:15.843000Z TestFramework (ERROR):
node0 stderr Error: basic block filter index best block of the index goes beyond pruned data. Please disable the index or reindex (which will download the whole blockchain again)
node1 stderr Error: coinstatsindex best block of the index goes beyond pruned data. Please disable the index or reindex (which will download the whole blockchain again)
node2 stderr Error: basic block filter index best block of the index goes beyond pruned data. Please disable the index or reindex (which will download the whole blockchain again)
| https://github.com/bitcoin/bitcoin/issues/25031 | https://github.com/bitcoin/bitcoin/pull/25123 | 225e5b57b2ee2bc1acd7f09c89ccccc15ef8c85f | b74a6dde8cf50703a8814d402333580e4cdfea59 | 2022-04-29T15:30:33Z | c++ | 2022-05-15T07:19:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,010 | ["src/interfaces/chain.h", "src/node/interfaces.cpp", "src/qt/test/wallettests.cpp", "src/wallet/rpc/transactions.cpp", "src/wallet/test/util.cpp", "src/wallet/test/wallet_tests.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h"] | wallet: Sync progress not saved if interrupted | _Originally posted by @S3RK in https://github.com/bitcoin/bitcoin/pull/24984#pullrequestreview-952900468_
> With current implementation we don't save the rescan progress and on the next load we will have to start from scratch. Is it possible to save the last processed blocked at shutdown?
It would be nice if wallet code would call `WriteBestBlock` and save the last scan position if it is interrupted during a sync. This could be implemented by trying to save the scan position during the shutdown, or by just periodically saving the scan position after an interval, similar to indexing code which saves sync position once every 30 seconds:
https://github.com/bitcoin/bitcoin/blob/f0a834e2f10a0aa60c7cc76e9f3eb090168a32e5/src/index/base.cpp#L170-L175 | https://github.com/bitcoin/bitcoin/issues/25010 | https://github.com/bitcoin/bitcoin/pull/25036 | c92eb6cda0f402b83263c9a9ee129d5d0763fd3f | 7ba0850c491921852c2766501ab73594477b789a | 2022-04-27T18:11:10Z | c++ | 2022-07-12T06:02:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,008 | ["configure.ac", "src/Makefile.am"] | `libbitcoinkernel`: Building `mingw-w64` dll's broken | We're unable to build a `dll` for `libbitcoinkernel` right now because of unique problems arising out of the combination of `mingw-w64` + `winpthread` + `libtool` + `dll's`
https://github.com/bitcoin/bitcoin/blob/466c6161505f0c9c68e4c4f41e3e40b8660d3a7a/src/Makefile.am#L816-L822
Various methods have been proposed and we should discuss here. | https://github.com/bitcoin/bitcoin/issues/25008 | https://github.com/bitcoin/bitcoin/pull/27146 | a2877f7ad3a58327215f782003a85a6f46486e4c | 82793f1984911774b111117f2e81d5f3b0bbec68 | 2022-04-27T15:58:36Z | c++ | 2023-02-27T14:41:47Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 25,007 | ["test/functional/wallet_createwallet.py"] | wallet_createwallet.py --legacy-wallet fails on a system with only bdb installed |
```
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/test_framework/test_framework.py", line 133, in main
self.run_test()
File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/wallet_createwallet.py", line 31, in run_test
assert_raises_rpc_error(-4, "Passphrase provided but private keys are disabled. A passphrase is only used to encrypt private keys, so cannot be used for wallets with private keys disabled.",
File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/test_framework/util.py", line 125, in assert_raises_rpc_error
assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
File "/tmp/cirrus-ci-build/bitcoin-core/test/functional/test_framework/util.py", line 140, in try_rpc
raise AssertionError(
AssertionError: Expected substring not found in error message:
substring: 'Passphrase provided but private keys are disabled. A passphrase is only used to encrypt private keys, so cannot be used for wallets with private keys disabled.'
error message: 'Compiled without sqlite support (required for descriptor wallets)'. | https://github.com/bitcoin/bitcoin/issues/25007 | https://github.com/bitcoin/bitcoin/pull/25011 | f0a834e2f10a0aa60c7cc76e9f3eb090168a32e5 | 4381681e554d9bf10ef1ac43cede9cfa10bfb439 | 2022-04-27T15:36:53Z | c++ | 2022-04-28T05:41:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,980 | ["src/init.cpp", "test/functional/feature_proxy.py"] | -onlynet=onion plus -onlynet=ipv4/etc, without -onion=, in spite of -torcontrol= specified, incorrectly kills startup | In v22, using the options: -onlynet=onion -onlynet=ipv4 -onlynet=ipv6, combined with the options -torcontrol= (etc) functioned and bitcoind correctly pulled the onion socks address via a probe to tor. In v23, that combination of options no longer functions and -onion= is required.
** expected **
Using -onlynet=onion (and ipv4 and ipv6) if -torcontrol= is specified should still work.
**Actual behavior**
bitcoind refuses to start up due to commitid e53a8505db preventing it from doing so in init.cpp.
**To reproduce**
Run as per above.
**System information**
Sources built from fcf6c8f4eb217763545ede1766831a6b93f583bd (tag v23.0 as of this writing I .. think?)
Error message in debug.log is:
Error: Outbound connections restricted to Tor (-onlynet=onion) but the proxy for reaching the Tor network is not provided
(no -proxy= and no -onion= given) or it is explicitly forbidden (-onion=0)
Shutdown: In progress...
scheduler thread exit
Shutdown: done
| https://github.com/bitcoin/bitcoin/issues/24980 | https://github.com/bitcoin/bitcoin/pull/24991 | a361c6cae766fd73cbc8b06ad5dbef729ca8c86d | 94d17845d04e71e189c59d65b8bbc3df1efbc59a | 2022-04-25T18:12:35Z | c++ | 2022-09-13T11:36:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,947 | ["contrib/macdeploy/README.md", "contrib/macdeploy/gen-sdk"] | Permissions corrupted in gen-sdk macosx headers | I think #24534 broke the MacOS SDK:
```
guest@gnu /tmp/Xcode-12.2-12B45b-extracted-SDK-with-libcxx-headers$ ls -al
total 32
drwxr-xr-x 4 guest users 4096 Apr 22 18:58 ./
drwxrwxrwt 4 root root 4096 Apr 22 18:58 ../
---x---r-- 1 guest users 127 Jan 1 1970 Entitlements.plist
---x---r-- 1 guest users 4307 Jan 1 1970 SDKSettings.json
---x---r-- 1 guest users 3597 Jan 1 1970 SDKSettings.plist
drwxr-xr-x 4 guest users 4096 Jan 1 1970 System/
drwxr-xr-x 7 guest users 4096 Jan 1 1970 usr/
```
Causing the guix build to fail with:
```
checking for x86_64-apple-darwin-gcc... env -u C_INCLUDE_PATH -u CPLUS_INCLUDE_PATH -u OBJC_INCLUDE_PATH -u OBJCPLUS_INCLUDE_PATH -u CPATH -u LIBRARY_PATH /home/kvaciral/.guix-profile/bin/clang --target=x86_64-apple-darwin -mmacosx-version-min=10.15 -B/bitcoin/depends/x86_64-apple-darwin/native/bin -mlinker-version=609 -isysroot/bitcoin/depends/SDKs/Xcode-12.2-12B45b-extracted-SDK-with-libcxx-headers -Xclang -internal-externc-isystem/gnu/store/v770rvqs8q21mbzwb3gkihr2glgn80am-clang-10.0.1/lib/clang/10.0.1/include -Xclang -internal-externc-isystem/bitcoin/depends/SDKs/Xcode-12.2-12B45b-extracted-SDK-with-libcxx-headers/usr/include
checking whether the C compiler works... no
configure: error: in `/bitcoin/depends/work/build/x86_64-apple-darwin/libevent/2.1.12-stable-6395cab7fb6':
configure: error: C compiler cannot create executables
See `config.log' for more details
make: *** [[funcs.mk:283](http://funcs.mk:283/): /bitcoin/depends/work/build/x86_64-apple-darwin/libevent/2.1.12-stable-6395cab7fb6/./.stamp_configured] Error 77
make: Leaving directory '/bitcoin/depends'
kvaciral@penumbra:~/projects/bitcoin$
```
Reported by @kvaciral. | https://github.com/bitcoin/bitcoin/issues/24947 | https://github.com/bitcoin/bitcoin/pull/24948 | b1c5991eebb916755be188f355ad36fe01a3f529 | b31ba3abf81c0770fd12ae59e25ba1e92ef45f05 | 2022-04-22T19:07:10Z | c++ | 2022-04-25T08:45:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,828 | ["test/functional/feature_csv_activation.py", "test/functional/test_framework/wallet.py"] | Intermittent failure in feature_fee_estimation.py | Observed in #24827 (https://cirrus-ci.com/task/6466255107391488) but very likely unrelated.
Looks to me that a testmempoolaccept RPC call issued by the mini-wallet timed out - so it seems that it occurs after the #24817 rework but has a root cause in bitcoind?
```
node1 2022-04-11T17:04:58.456117Z [httpworker.3] [rpc/request.cpp:179] [parse] ThreadRPCServer method=testmempoolaccept user=__cookie__
node1 2022-04-11T17:05:25.635870Z [msghand] [net.cpp:3041] [PushMessage] sending ping (8 bytes) peer=0
node1 2022-04-11T17:06:50.669591Z [scheduler] [random.cpp:520] [SeedPeriodic] Feeding 32422 bytes of dynamic environment data into RNG
node0 2022-04-11T17:06:50.669699Z [net] [net.cpp:1651] [SocketHandlerConnected] socket closed for peer=1
node0 2022-04-11T17:06:50.671075Z [net] [net.cpp:567] [CloseSocketDisconnect] disconnecting peer=1
``` | https://github.com/bitcoin/bitcoin/issues/24828 | https://github.com/bitcoin/bitcoin/pull/24941 | 2c56404088f7b17ee9cea05ae43315ade35718bc | d24318a40cad4440363db9137bc0ace28a89c2c0 | 2022-04-11T18:59:21Z | c++ | 2022-05-03T07:59:52Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,791 | ["test/functional/test_runner.py"] | tests: change the color of skipped functional tests | The dark gray color used to mark skipped functional tests is somewhat unfortunate. I don't see skipped tests at all with my terminal settings unless I mark the text. For others, dark gray/black is hard to read on a gray background.
My terminal:
And @jacobpfickes terminal from [twitter](https://twitter.com/cryptocowboy__/status/1511505046378266627) which reminded me to open this good first issue.
For example, during review it's important to see which tests were skipped. It could happen that you think you've run the tests for something, but you in fact haven't and the tests were skipped, but you just don't notice.
A solution would be to use a yellow/orange color to mark skipped tests. Green for pass, red for fail and yellow/orange for skipped. Another easy solution would be for me to change my terminal settings, however I think the gray text on gray background could affect more devs than just me.
For reference, the colored functional tests output was introduced in https://github.com/bitcoin/bitcoin/pull/10159.
#### Useful skills:
Python and running the functional tests.
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/24791 | https://github.com/bitcoin/bitcoin/pull/24793 | fb7c12c26f57784c6db589939103237173adb533 | ed4eeafbb6e2e73ff9fb9c03bd66bbb049b8aacd | 2022-04-06T20:04:36Z | c++ | 2022-05-10T11:12:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,782 | [".cirrus.yml", "ci/test/00_setup_env_native_asan.sh", "ci/test/00_setup_env_native_tidy.sh", "ci/test/04_install.sh", "test/functional/interface_usdt_net.py", "test/functional/interface_usdt_utxocache.py", "test/functional/interface_usdt_validation.py"] | CI, tracing: run tracepoint interface tests in the CI | The first tracepoint tests were merged in #24358. However, they are skipped in the CI. I've already done some experiments running them in the CI in https://github.com/bitcoin/bitcoin/issues/23296, however I haven't been successful with it yet. The main issue was the limited capabilities inside the CirrusCI docker container.
An option would be to ask CirrusCI for help, another would be to run this part in a VM, if it's not to much overhead. | https://github.com/bitcoin/bitcoin/issues/24782 | https://github.com/bitcoin/bitcoin/pull/25528 | da2332099873977873402227c6e69239cbb2235a | eeb5a94e275fdf02a4af5a9284bcf2515c54aa1f | 2022-04-06T11:23:47Z | c++ | 2022-08-01T09:27:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,747 | [".cirrus.yml", "ci/test/00_setup_env.sh", "ci/test/00_setup_env_native_tidy.sh", "ci/test/06_script_a.sh", "ci/test/06_script_b.sh", "configure.ac"] | ci: add lint job to run clang-tidy check for named args | <!-- Motivate the issue and explain the solution briefly -->
After #24661, we should be able to enable [`clang-tidy`](https://clang.llvm.org/extra/clang-tidy/) named argument checking in the CI lint job. The simplest way to invoke this checking, is something like `./autogen.sh && ./configure CC=clang-12 CXX=clang++-12 && make clean && bear make -j9 && ( cd ./src/ && run-clang-tidy-12 -j9 )`, which invokes clang-tidy using our [`.clang-tidy` config](https://github.com/bitcoin/bitcoin/blob/master/src/.clang-tidy).
Dependencies, like `clang-tidy` would need to be installed in the [linting container](https://github.com/bitcoin/bitcoin/blob/master/ci/lint/04_install.sh), and a linting job could be added to https://github.com/bitcoin/bitcoin/tree/master/test/lint.
It is possible to work on this now, by just basing your changes on the #24661 branch.
#### Useful skills:
* Bash
* CI
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/24747 | https://github.com/bitcoin/bitcoin/pull/24753 | 27cfaeed1ea975f52c2307153f7295d43bc84b64 | 372f1a3c25813cc79b5484599f0b26f857b99857 | 2022-04-03T12:16:16Z | c++ | 2022-04-06T09:10:41Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,726 | ["contrib/guix/manifest.scm", "contrib/guix/patches/vmov-alignment.patch"] | Cross-compiled `bitcoind -signet` silently fails on Windows | The issue was [discovered](https://github.com/bitcoin/bitcoin/issues/24501#issuecomment-1079738588) during 23.0rc2 testing.
MSVC build works flawlessly.
`bitcoind -testnet` also works flawlessly. | https://github.com/bitcoin/bitcoin/issues/24726 | https://github.com/bitcoin/bitcoin/pull/24736 | 52f0f7a1bb5d8bcebd94ed7786539752c5f22fcb | 83b26cb97cb46516aa4fdee3bcbfa751d28c1233 | 2022-03-31T18:18:33Z | c++ | 2022-04-04T09:42:35Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,703 | ["ci/test/00_setup_env_native_fuzz_with_msan.sh", "ci/test/00_setup_env_native_msan.sh"] | fuzz: enable BDB in the MSAN CI jobs | Currently, our [MSAN](https://clang.llvm.org/docs/MemorySanitizer.html) and MSAN fuzz CI jobs [build depends without BDB](https://github.com/bitcoin/bitcoin/blob/2a3e8fb3592e42300ec96c9f6724e15346e30ea7/ci/test/00_setup_env_native_msan.sh#L17) (i.e `NO_BDB=1`). Ideally, these jobs would be building Bitcoin Core with BDB enabled (via depends). Previously BDB was being compiled in one of the jobs, [but not actually used](https://github.com/bitcoin/bitcoin/pull/24522).
Re-enabling BDB may require using newer (clang) tools; see #23008.
Testing / debugging is possible by [running the CI locally](https://github.com/bitcoin/bitcoin/tree/master/ci#readme). i.e `FILE_ENV="./ci/test/00_setup_env_native_msan.sh" ./ci/test_run_all.sh`.
If BDB is re-enabled in our MSAN CI, it may also be possible to use it in our OSS-FUZZ job, see: https://github.com/google/oss-fuzz/blob/1abbd8bf089660da96367b0370855f99e3aa2df6/projects/bitcoin-core/build.sh#L32.
#### Useful skills:
* CI
* Sanitizers / Fuzzing
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/24703 | https://github.com/bitcoin/bitcoin/pull/24705 | 7c72eabb57bde83abfc4bd5af70b884390ef847d | 565aac2e6fe7f87e99967dc15d81ee7d6023e400 | 2022-03-29T09:15:14Z | c++ | 2022-03-29T11:27:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,701 | ["contrib/guix/manifest.scm", "contrib/guix/patches/glibc-2.24-fcommon.patch", "contrib/guix/patches/glibc-2.27-dont-redefine-nss-database.patch", "contrib/guix/patches/glibc-2.27-riscv64-Use-__has_include-to-include-asm-syscalls.h.patch"] | guix: migrate to native GCC 10 toolchain for Linux builds | Currently, our Linux Guix builds differ from macOS and Windows, in that they use a native [GCC 7 toolchain](https://github.com/bitcoin/bitcoin/blob/2a3e8fb3592e42300ec96c9f6724e15346e30ea7/contrib/guix/manifest.scm#L150) (i.e to build glibc) and then GCC 10 to build depends and Bitcoin Core. Migrating the Linux builds to a native GCC 10 toolchain will unify us on a single native compiler.
The main issue with performing this migration is building older glibcs (2.24, 2.27) with GCC 10. When I last tried, it was apparent that either warnings produced by the newer GCC would need to be suppressed (as glibc is built -Werror), or patches to glibc would need to be backported to address any issues. For example:
```bash
x86_64-linux-gnu-gcc ../sysdeps/unix/sysv/linux/x86_64/sysdep.S -c -I../include -I/tmp/guix-build-glibc-cross-x86_64-linux-gnu-2.24.drv-0/build/csu -I/tmp/guix-build-glibc-cross-x86_64-linux-gnu-2.24.drv-0/build -I../sysdeps/unix/sysv/linux/x86_64/64 -I../sysdeps/unix/sysv/linux/x86_64 -I../sysdeps/unix/sysv/linux/x86 -I../sysdeps/unix/sysv/linux/wordsize-64 -I../sysdeps/x86_64/nptl -I../sysdeps/unix/sysv/linux/include -I../sysdeps/unix/sysv/linux -I../sysdeps/nptl -I../sysdeps/pthread -I../sysdeps/gnu -I../sysdeps/unix/inet -I../sysdeps/unix/sysv -I../sysdeps/unix/x86_64 -I../sysdeps/unix -I../sysdeps/posix -I../sysdeps/x86_64/64 -I../sysdeps/x86_64/fpu/multiarch -I../sysdeps/x86_64/fpu -I../sysdeps/x86/fpu/include -I../sysdeps/x86/fpu -I../sysdeps/x86_64/multiarch -I../sysdeps/x86_64 -I../sysdeps/x86 -I../sysdeps/ieee754/ldbl-96 -I../sysdeps/ieee754/dbl-64/wordsize-64 -I../sysdeps/ieee754/dbl-64 -I../sysdeps/ieee754/flt-32 -I../sysdeps/wordsize-64 -I../sysdeps/ieee754 -I../sysdeps/generic -I.. -I../libio -I. -nostdinc -isystem /gnu/store/r2h1g2vg7j36rqwyraf5wghm10ykq055-gcc-cross-sans-libc-x86_64-linux-gnu-10.3.0-lib/lib/gcc/x86_64-linux-gnu/10.3.0/include -isystem /gnu/store/r2h1g2vg7j36rqwyraf5wghm10ykq055-gcc-cross-sans-libc-x86_64-linux-gnu-10.3.0-lib/lib/gcc/x86_64-linux-gnu/10.3.0/include-fixed -isystem /gnu/store/5fhhr33nilcyi1k3s1xwcmibdhc1l39c-linux-libre-headers-cross-x86_64-linux-gnu-4.9.306/include -D_LIBC_REENTRANT -include /tmp/guix-build-glibc-cross-x86_64-linux-gnu-2.24.drv-0/build/libc-modules.h -DMODULE_NAME=libc -include ../include/libc-symbols.h -DPIC -DSHARED -DASSEMBLER -I/tmp/guix-build-glibc-cross-x86_64-linux-gnu-2.24.drv-0/build/csu/. -g -Werror=undef -Wa,--noexecstack -o /tmp/guix-build-glibc-cross-x86_64-linux-gnu-2.24.drv-0/build/csu/sysdep.os -MD -MP -MF /tmp/guix-build-glibc-cross-x86_64-linux-gnu-2.24.drv-0/build/csu/sysdep.os.dt -MT /tmp/guix-build-glibc-cross-x86_64-linux-gnu-2.24.drv-0/build/csu/sysdep.os
libc-tls.c: In function ‘__libc_setup_tls’:
libc-tls.c:208:30: error: array subscript 1 is outside the bounds of an interior zero-length array ‘struct dtv_slotinfo[0]’ [-Werror=zero-length-bounds]
208 | static_slotinfo.si.slotinfo[1].map = main_map;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
In file included from ../sysdeps/x86_64/ldsodefs.h:54,
from ../sysdeps/gnu/ldsodefs.h:46,
from ../sysdeps/unix/sysv/linux/ldsodefs.h:25,
from libc-tls.c:20:
../sysdeps/generic/ldsodefs.h:398:7: note: while referencing ‘slotinfo’
398 | } slotinfo[0];
| ^~~~~~~~
cc1: all warnings being treated as errors
```
This branch could be used as a starting point: https://github.com/fanquake/bitcoin/tree/native_gcc_10_linux (3974ac565ad575d8d4216bcac39b46a6dcd254d5). Builds for `x86_64-w64-mingw32 x86_64-apple-darwin x86_64-apple-darwin` will all work as expected. A Linux build, i.e `HOSTS="x86_64-linux-gnu" ./contrib/guix/guix-build` will not, and will fail with the error displayed above.
#### Useful skills:
* Guix
* Build system
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/24701 | https://github.com/bitcoin/bitcoin/pull/25076 | f7a1e676d536115aba649672ba1e68755a1c90dc | 84bf31f8e9842cb5f613151dc4c5a0ffa67a3a03 | 2022-03-29T08:34:54Z | c++ | 2022-05-18T08:57:03Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,695 | ["src/init.cpp", "src/rpc/util.cpp", "src/rpc/util.h", "test/functional/test_framework/util.py"] | Put undocumented JSON failure mode behind a runtime flag | Following the merge of https://github.com/bitcoin/bitcoin/pull/23083, we'll throw a non-fatal error at runtime if the documentation for an RPC is incorrect. This behaviour has found numerous issues over a very short period (of the PR being opened). However, this is not something that we want in production / release builds, instead, we want the ability to have it enabled in the CI and when running tests. A runtime option could be added, which controls this behaviour (disabled by default).
#### Useful skills:
- C++
- Understanding of Bitcoin Core's initialization sequence
- Understanding of Bitcoin Core's RPC interface
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/24695 | https://github.com/bitcoin/bitcoin/pull/25161 | 7b3343f3009d38abe2de10e9fdc7f702d6a2cf1b | bb83aba6c98b948c1715b26237980a4ddc87a547 | 2022-03-28T12:43:04Z | c++ | 2022-05-19T04:44:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,682 | ["build_msvc/common.init.vcxproj.in", "src/fs.h"] | u8path<std::string> deprecation with libc++ and c++20 | When trying to compile with c++20 support (added in #24169) on macOS 12.3 on master I get inundated with the below warning.
```
./configure --enable-c++20 --enable-suppress-external-warnings
```
```
In file included from bitcoin-cli.cpp:19:
In file included from ./util/system.h:20:
./fs.h:71:29: warning: 'u8path<std::string>' is deprecated [-Wdeprecated-declarations]
return std::filesystem::u8path(utf8_str);
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/filesystem:1570:27: note: 'u8path<std::string>' has been explicitly marked deprecated here
_LIBCPP_INLINE_VISIBILITY _LIBCPP_DEPRECATED_WITH_CHAR8_T
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__config:1078:43: note: expanded from macro '_LIBCPP_DEPRECATED_WITH_CHAR8_T'
# define _LIBCPP_DEPRECATED_WITH_CHAR8_T _LIBCPP_DEPRECATED
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__config:1043:48: note: expanded from macro '_LIBCPP_DEPRECATED'
# define _LIBCPP_DEPRECATED __attribute__ ((deprecated))
^
1 warning generated.
```
| https://github.com/bitcoin/bitcoin/issues/24682 | https://github.com/bitcoin/bitcoin/pull/25808 | 02aefa169a9e6ed12c7bd8f3392adcd073d8d56b | d480586ecb1d4c265ffec278f10c46500d89382f | 2022-03-26T09:25:18Z | c++ | 2022-08-19T11:50:24Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,654 | ["src/Makefile.am", "src/test/util_tests.cpp", "src/util/check.cpp", "src/util/check.h", "src/wallet/test/wallet_test_fixture.cpp", "src/wallet/test/wallet_test_fixture.h"] | util/check.h Assert/Assume: namespacing issues | The `Assert`/`Assume` macros are implemented via lambda functions to allow the result of the assertion to both be evaluated (and trigger an abort) and be returned without having the expression be evaluated twice.
This causes some ugly namespacing issues though. Because there's a function call, clang's thread safety annotations don't get passed through (as the lambda is unannotated), possibly causing an unnecessary compiler error because the compiler loses track that a mutex is held when a guarded variable is accessed.
It also seems that gcc (but not clang) gets confused about member functions (but not member variables), eg:
```c++
class TestAssert
{
public:
int variable = 3;
int test_1(void) { return variable; }
int test_2(void) {
auto x = [&]() {
Assert(test_1() == 3);
};
x();
return ++variable;
}
};
```
results in:
```
test/util_tests.cpp:91:26: error: cannot call member function ‘int util_tests::TestAssert::test_1()’ without object
91 | Assert(test_1() == 3);
```
requiring you to write `Assert(this->test_1() == 3)` instead. | https://github.com/bitcoin/bitcoin/issues/24654 | https://github.com/bitcoin/bitcoin/pull/24714 | 74b011bbfa3b607606cc7c0ce6e2d22cfd07605a | 87dc1dc55ffaffd782a16c7b50e188433912a617 | 2022-03-24T02:45:10Z | c++ | 2022-03-31T06:18:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,634 | ["src/bench/mempool_stress.cpp", "src/test/txvalidationcache_tests.cpp", "src/test/util/setup_common.cpp", "src/test/util/setup_common.h"] | bench: `MempoolCheck` actually runs with `check_ratio = 0` | For `MempoolCheck`, it seems that the intention was to have a mempool with `check_ratio = 1` (see `-checkmempool=1`):
https://github.com/bitcoin/bitcoin/blob/e66630cc87c017f40ec29f6c1edf2ed5a286e49d/src/bench/mempool_stress.cpp#L102-L116
However in the subsequent line in the above snippet, a `CTxMemPool` gets constructed with no arguments, which means that `check_ratio` will default to 0:
https://github.com/bitcoin/bitcoin/blob/e66630cc87c017f40ec29f6c1edf2ed5a286e49d/src/txmempool.h#L571
Manually specifying `check_ratio` to 1 (according to the original intention) and running the `MempoolCheck` benchmark results in an assertion error:
```
diff --git a/src/bench/mempool_stress.cpp b/src/bench/mempool_stress.cpp
index afa4618e1b..32cdb70539 100644
--- a/src/bench/mempool_stress.cpp
+++ b/src/bench/mempool_stress.cpp
@@ -105,7 +105,7 @@ static void MempoolCheck(benchmark::Bench& bench)
const int childTxs = bench.complexityN() > 1 ? static_cast<int>(bench.complexityN()) : 2000;
const std::vector<CTransactionRef> ordered_coins = CreateOrderedCoins(det_rand, childTxs, /* min_ancestors */ 5);
const auto testing_setup = MakeNoLogFileContext<const TestingSetup>(CBaseChainParams::MAIN, {"-checkmempool=1"});
- CTxMemPool pool;
+ CTxMemPool pool{nullptr, 1};
LOCK2(cs_main, pool.cs);
const CCoinsViewCache& coins_tip = testing_setup.get()->m_node.chainman->ActiveChainstate().CoinsTip();
for (auto& tx : ordered_coins) AddTx(tx, pool);
```
```sh
$ ./src/bench/bench_bitcoin -filter='MempoolCheck'
...
bench_bitcoin: txmempool.cpp:759: void CTxMemPool::check(const CCoinsViewCache &, int64_t) const: Assertion `mempoolDuplicate.HaveCoin(txin.prevout)' failed.
```
Aside from this problem, we should also probably just re-use the `CTxMemPool` in `TestingSetup`.
Ping @glozow | https://github.com/bitcoin/bitcoin/issues/24634 | https://github.com/bitcoin/bitcoin/pull/24927 | 636991d0c0f969968c790d490c82c1d2fa4e8047 | a100c42a136da5ddfd09aa442543ec2190f24faf | 2022-03-22T02:40:05Z | c++ | 2022-06-02T17:08:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,590 | ["test/functional/feature_segwit.py"] | qa: Intermittent failure in feature_segwit.py --descriptors | https://api.cirrus-ci.com/v1/task/5763159330914304/logs/ci.log
```
5/238 - feature_segwit.py --descriptors failed, Duration: 11 s
stdout:
2022-03-16T18:38:33.242000Z TestFramework (INFO): Initializing test directory /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20220316_183814/feature_segwit_225
2022-03-16T18:38:39.177000Z TestFramework (INFO): Verify sigops are counted in GBT with pre-BIP141 rules before the fork
2022-03-16T18:38:43.168000Z TestFramework (INFO): Verify witness txs cannot be mined before the fork
2022-03-16T18:38:43.200000Z TestFramework (INFO): Verify unsigned p2sh witness txs without a redeem script are invalid
2022-03-16T18:38:43.630000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_segwit.py", line 210, in run_test
self.generate(self.nodes[0], 4) # blocks 428-431
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 639, in generate
blocks = generator.generate(*args, invalid_call=False, **kwargs)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_node.py", line 303, in generate
return self.generatetoaddress(nblocks=nblocks, address=self.get_deterministic_priv_key().address, maxtries=maxtries, **kwargs)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_node.py", line 311, in generatetoaddress
return self.__getattr__('generatetoaddress')(*args, **kwargs)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/coverage.py", line 49, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/authproxy.py", line 144, in __call__
raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: CreateNewBlock: TestBlockValidity failed: unexpected-witness, ContextualCheckBlock : unexpected witness data found (-1)
2022-03-16T18:38:43.682000Z TestFramework (INFO): Stopping nodes
2022-03-16T18:38:43.856000Z TestFramework (WARNING): Not cleaning up dir /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20220316_183814/feature_segwit_225
2022-03-16T18:38:43.856000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20220316_183814/feature_segwit_225/test_framework.log
2022-03-16T18:38:43.866000Z TestFramework (ERROR):
2022-03-16T18:38:43.866000Z TestFramework (ERROR): Hint: Call /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/combine_logs.py '/tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20220316_183814/feature_segwit_225' to consolidate all logs
2022-03-16T18:38:43.866000Z TestFramework (ERROR):
2022-03-16T18:38:43.866000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-03-16T18:38:43.867000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues
2022-03-16T18:38:43.867000Z TestFramework (ERROR):
``` | https://github.com/bitcoin/bitcoin/issues/24590 | https://github.com/bitcoin/bitcoin/pull/24578 | a7b3123feadbbd3447d102f1c4e84631f7434092 | 66e2d21ef203e422eea8f0a3c7029ac59b210668 | 2022-03-16T18:44:23Z | c++ | 2022-03-18T13:14:06Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,575 | ["test/functional/feature_init.py", "test/functional/test_framework/test_node.py"] | feature_init intermittent issue: UnicodeDecodeError: 'utf-8' codec can't decode bytes in position 1215-1217: unexpected end of data | Presumably because a Unicode character was only written partially.
```
test 2022-03-15T19:13:39.817000Z TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_init.py", line 79, in run_test
node.start(extra_args=['-txindex=1', '-blockfilterindex=1', '-coinstatsindex=1'])
File "/usr/lib/python3.8/contextlib.py", line 120, in __exit__
next(self.gen)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_node.py", line 442, in wait_for_debug_log
log = dl.read()
File "/usr/lib/python3.8/codecs.py", line 322, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode bytes in position 1215-1217: unexpected end of data
```
https://cirrus-ci.com/task/5773197005029376?logs=ci#L5215 | https://github.com/bitcoin/bitcoin/issues/24575 | https://github.com/bitcoin/bitcoin/pull/25294 | 2e079c86aefd3b7a1a4ad54bb38cc3f53fca8c1a | 455780b1aebae21ebd5d83d2f0ff6a2264ac9608 | 2022-03-15T19:16:20Z | c++ | 2022-06-08T15:53:06Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,536 | ["src/util/syscall_sandbox.cpp"] | Syscall Sandbox Termination | I was testing v23.0rc2 compiled.
`./configure --without-miniupnpc --without-natpmp --enable-hardening --without-bdb --with-qrencode --with-zmq --with-sqlite=yes --disable-external-signer`
bitcoin.conf:
> assumevalid=0
> blockfilterindex=1
> coinstatsindex=1
> dbcache=1000
> prune=0
> sandbox=log-and-abort
> txindex=1
> cjdnsreachable=1
> discover=1
> i2psam=127.0.0.1:7656
> listen=1
> listenonion=1
> networkactive=1
> peerblockfilters=1
> proxy=127.0.0.1:9050
> addresstype=bech32m
> avoidpartialspends=1
> changetype=bech32m
> maxapsfee=0.001
> walletrbf=1
> shrinkdebugfile=1
I deleted my data directory (/home/user/.bitcoin) to start a fresh download of the blockchain to test any errors. Ran out of space, and after deleting more and trying to start bitcoin-qt again:
> ERROR: The syscall "linkat" (syscall number 265) is not allowed by the syscall sandbox in thread "main". Please report.
> terminate called without an active exception
> Aborted
and in debug.log:
> 2022-03-11T13:00:02Z init message: Verifying blocks…
> 2022-03-11T13:00:02Z Verifying last 6 blocks at level 3
> 2022-03-11T13:00:02Z [0%]...[16%]...[33%]...[50%]...[66%]...[83%]...[99%]...[DONE].
> 2022-03-11T13:00:02Z No coin database inconsistencies in last 6 blocks (2938 transactions)
> 2022-03-11T13:00:02Z block index 4963ms
> 2022-03-11T13:00:02Z Opening LevelDB in /home/user/.bitcoin/indexes/txindex
> 2022-03-11T13:00:02Z Opened LevelDB successfully
> 2022-03-11T13:00:02Z Using obfuscation key for /home/user/.bitcoin/indexes/txindex: 0000000000000000
> 2022-03-11T13:00:02Z Opening LevelDB in /home/user/.bitcoin/indexes/blockfilter/basic/db
> 2022-03-11T13:00:02Z txindex thread start
> 2022-03-11T13:00:02Z txindex is enabled at height 326934
> 2022-03-11T13:00:02Z txindex thread exit
> 2022-03-11T13:00:02Z Opened LevelDB successfully
> 2022-03-11T13:00:02Z Using obfuscation key for /home/user/.bitcoin/indexes/blockfilter/basic/db: 0000000000000000
> 2022-03-11T13:00:02Z Opening LevelDB in /home/user/.bitcoin/indexes/coinstats/db
> 2022-03-11T13:00:02Z basic block filter index thread start
> 2022-03-11T13:00:02Z basic block filter index is enabled at height 326934
> 2022-03-11T13:00:02Z basic block filter index thread exit
> 2022-03-11T13:00:02Z Opened LevelDB successfully
> 2022-03-11T13:00:02Z Using obfuscation key for /home/user/.bitcoin/indexes/coinstats/db: 0000000000000000
> 2022-03-11T13:00:02Z ERROR: Init: Cannot read current coinstatsindex state; index may be corrupted
> 2022-03-11T13:00:02Z Shutdown: In progress...
> 2022-03-11T13:00:02Z scheduler thread exit
> 2022-03-11T13:00:02Z Shutdown: done
> 2022-03-11T13:00:02Z ERROR: The syscall "linkat" (syscall number 265) is not allowed by the syscall sandbox in thread "main". Please report.
This was done on a Qubes 4.0 machine in a Debian 11 VM. | https://github.com/bitcoin/bitcoin/issues/24536 | https://github.com/bitcoin/bitcoin/pull/24659 | 88709e9dc522f895496589caf1757a76e3734634 | dc0ba8ce9f6cca3688853882c1a5c607db2c070b | 2022-03-11T16:49:15Z | c++ | 2022-03-28T07:04:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,487 | ["src/wallet/wallet.cpp", "src/wallet/wallet.h"] | Automatic wallet rescan skipped after abort | I ran bitcoin-qt with an old wallet, causing it to rescan, then stopped it with a SIGINT signal, resulting in the following log. Nothing unexpected, so far:
```
2022-03-05T16:01:03Z init message: Loading wallet…
2022-03-05T16:01:03Z BerkeleyEnvironment::Open: LogDir=…/.bitcoin/database ErrorFile=…/.bitcoin/db.log
2022-03-05T15:57:18Z [walletname.dat] Wallet File Version = 159900
2022-03-05T15:57:18Z [walletname.dat] Keys: 2397 plaintext, 0 encrypted, 2397 w/ metadata, 2397 total. Unknown wallet records: 0
2022-03-05T15:57:18Z [walletname.dat] Wallet completed loading in 65ms
2022-03-05T15:57:18Z init message: Rescanning…
2022-03-05T15:57:18Z [walletname.dat] Rescanning last 134072 blocks (from block 591711)...
2022-03-05T15:57:18Z [walletname.dat] Rescan started from block 000000000000000000075fcc1872da61f45bcfd0e0bb36b7c8cb45e7a328ad41...
2022-03-05T15:58:18Z [walletname.dat] Still rescanning. At block 593552. Progress=0.632716
2022-03-05T15:59:18Z [walletname.dat] Still rescanning. At block 595458. Progress=0.638084
2022-03-05T15:59:37Z [walletname.dat] Rescan interrupted by shutdown request at block 596080. Progress=0.639932
2022-03-05T15:59:37Z Error: Failed to rescan the wallet during initialization
2022-03-05T15:59:41Z GUI: initializeResult : Initialization result: false
2022-03-05T15:59:41Z GUI: requestShutdown : Requesting shutdown
2022-03-05T15:59:41Z GUI: Running Shutdown in thread
2022-03-05T15:59:41Z Shutdown: In progress...
2022-03-05T15:59:41Z scheduler thread exit
2022-03-05T15:59:42Z Shutdown: done
2022-03-05T15:59:42Z GUI: Shutdown finished
2022-03-05T15:59:42Z GUI: ~InitExecutor : Stopping thread
2022-03-05T15:59:42Z GUI: ~InitExecutor : Stopped thread
```
However, the next time it was launched, the rescan didn't continue, nor did it start over. It seems to have been skipped?
```
2022-03-05T16:01:03Z init message: Loading wallet…
2022-03-05T16:01:03Z BerkeleyEnvironment::Open: LogDir=…/.bitcoin/database ErrorFile=…/.bitcoin/db.log
2022-03-05T16:01:03Z [walletname.dat] Wallet File Version = 159900
2022-03-05T16:01:03Z [walletname.dat] Keys: 2397 plaintext, 0 encrypted, 2397 w/ metadata, 2397 total. Unknown wallet records: 0
2022-03-05T16:01:03Z [walletname.dat] Wallet completed loading in 91ms
2022-03-05T16:01:03Z [walletname.dat] setKeyPool.size() = 2000
2022-03-05T16:01:03Z [walletname.dat] mapWallet.size() = 378
2022-03-05T16:01:03Z [walletname.dat] m_address_book.size() = 183
2022-03-05T16:01:03Z Loaded 2 addresses from "anchors.dat"
```
I didn't investigate deeply, but could it be that despite the failed rescan, the new tip block was stored in the wallet? if so, this would be confusing. | https://github.com/bitcoin/bitcoin/issues/24487 | https://github.com/bitcoin/bitcoin/pull/24984 | dabec990135cc32584e822126ec49f8b31350837 | 4cf9fa0b662a3532ae97e3acf9624327dcc9862a | 2022-03-06T19:53:52Z | c++ | 2022-04-28T18:54:17Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,458 | ["doc/release-notes-24494.md", "src/bench/coin_selection.cpp", "src/qt/coincontroldialog.cpp", "src/wallet/coinselection.cpp", "src/wallet/coinselection.h", "src/wallet/spend.cpp", "src/wallet/test/coinselector_tests.cpp", "test/functional/wallet_bumpfee.py"] | wallet: Rethinking MIN_CHANGE | MIN_CHANGE is a privacy leak, since it is an easily observable wallet behaviour. Any output almost equal, but minimally larger than MIN_CHANGE is highly likely the change output of a tx.
Also, MIN_CHANGE is quite high, considering the value of bitcoin.
An easy fix for the second issue would be to just lower the value, but maybe some randomization can be done to also fix the first issue? | https://github.com/bitcoin/bitcoin/issues/24458 | https://github.com/bitcoin/bitcoin/pull/24494 | f66c827c2d7dcce2021a7913caf5f14dca37e35a | 6d5771ba07780ac67d5e30108ae6b860f3878e7d | 2022-03-02T09:02:33Z | c++ | 2022-03-25T21:03:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,457 | ["build_msvc/test_bitcoin-qt/test_bitcoin-qt.vcxproj", "src/Makefile.qttest.include", "src/qt/test/optiontests.cpp", "src/qt/test/optiontests.h", "src/qt/test/test_main.cpp", "src/test/getarg_tests.cpp", "src/util/system.cpp"] | Application Aborted | I receive this error when trying to open `bitcoin-qt` when compiling from `master`:
> terminate called after throwing an instance of 'std::runtime_error'
> what(): JSON value is not a string as expected
> Aborted
No debug info is generated since the application isn't started.
I am running Qubes 4.0 fully updated, in a Debian-11 VM with normal networking. Intel x86_64 | https://github.com/bitcoin/bitcoin/issues/24457 | https://github.com/bitcoin/bitcoin/pull/24498 | 7003b6ab24f6adfffd71d7b7d4182afde52ff859 | 47bbd3ff4f5e0c04da4731c5d26d23d97cfa0bf1 | 2022-03-02T04:42:57Z | c++ | 2022-03-09T15:54:48Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,413 | ["configure.ac", "src/test/system_tests.cpp", "src/util/system.cpp"] | Homebrew Boost 1.78 breaks external signer configure | Test on macOS 12.2.1 against the master branch. #24397 doesn't fix it.
```
brew info boost
boost: stable 1.78.0 (bottled), HEAD
...
./configure --enable-external-signer
...
checking for boostlib >= 1.64.0 (106400)... yes
checking whether Boost.Process can be used... no
configure: error: External signing is not supported for this Boost version
```
It does work with boost 1.76 (there was no 1.77 release in home-brew):
```
brew install [email protected]
...
LDFLAGS="-L/usr/local/opt/[email protected]/lib" CPPFLAGS="-I/usr/local/opt/[email protected]/include" ./configure --enable-external-signer
...
checking for boostlib >= 1.64.0 (106400)... yes
checking whether Boost.Process can be used... yes
...
Options used to compile and link:
external signer = yes
```
There's nothing in the release notes about Boost.Process for either [1.77](https://www.boost.org/users/history/version_1_77_0.html) or [1.78](https://www.boost.org/users/history/version_1_78_0.html).
The Homebrew [formula changes](https://github.com/Homebrew/homebrew-core/commits/master/Formula/boost.rb) are nothing but a trivial version and hash bump. | https://github.com/bitcoin/bitcoin/issues/24413 | https://github.com/bitcoin/bitcoin/pull/24523 | 565aac2e6fe7f87e99967dc15d81ee7d6023e400 | 9e32adbb5c543885b2c01a984bf1e4b80e8cec16 | 2022-02-22T09:46:10Z | c++ | 2022-03-29T11:36:45Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,400 | ["test/functional/feature_backwards_compatibility.py"] | ci: failure in feature_backwards_compatibility.py --descriptors | Seen in https://cirrus-ci.com/task/4695237263097856?logs=ci#L1143:
```bash
147/236 - feature_backwards_compatibility.py --descriptors failed, Duration: 49 s
stdout:
2022-02-20T12:49:35.179000Z TestFramework (INFO): Initializing test directory /tmp/cirrus-build/ci/scratch/test_runner/test_runner_₿_🏃_20220220_124152/feature_backwards_compatibility_111
2022-02-20T12:49:41.126000Z TestFramework (INFO): Test wallet backwards compatibility...
2022-02-20T12:50:23.374000Z TestFramework (INFO): Test wallet upgrade path...
2022-02-20T12:50:24.053000Z TestFramework (INFO): Stopping nodes
stderr:
Traceback (most recent call last):
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_backwards_compatibility.py", line 424, in <module>
BackwardsCompatibilityTest().main()
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 155, in main
exit_code = self.shutdown()
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 304, in shutdown
self.stop_nodes()
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 559, in stop_nodes
node.wait_until_stopped()
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_node.py", line 382, in wait_until_stopped
wait_until_helper(self.is_node_stopped, timeout=timeout, timeout_factor=self.timeout_factor)
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 265, in wait_until_helper
if predicate():
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_node.py", line 373, in is_node_stopped
"Node returned non-zero exit code (%d) when stopping" % return_code)
AssertionError: [node 5] Node returned non-zero exit code (-6) when stopping
```
```bash
node2 2022-02-20T12:50:24.275854Z [] Shutdown: done
test 2022-02-20T12:50:24.313000Z TestFramework.node2 (DEBUG): Node stopped
test 2022-02-20T12:50:24.313000Z TestFramework.node3 (DEBUG): Node stopped
test 2022-02-20T12:50:24.313000Z TestFramework.node4 (DEBUG): Node stopped
node4 stderr Error: Error loading w3_v18: Wallet requires newer version of Bitcoin Core
node4 stderr Error: wallet.dat corrupt, salvage failed
node4 stderr Error: wallet.dat corrupt, salvage failed
node4 stderr Error: wallet.dat corrupt, salvage failed
node5 stderr terminate called after throwing an instance of 'std::runtime_error'
what(): CDB: Error -30974, can't open database u1_v16
``` | https://github.com/bitcoin/bitcoin/issues/24400 | https://github.com/bitcoin/bitcoin/pull/26658 | 3eaf7be6ade22c99f3c0000122e49b94de868d74 | 6d11f19cf5b02c2d1de412a270c6f51690e8d21c | 2022-02-20T18:00:59Z | c++ | 2022-12-09T08:21:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,389 | ["depends/hosts/mingw32.mk"] | build: Fail to build `libmultiprocess` for the `x86_64-w64-mingw32` target | On master (https://github.com/bitcoin/bitcoin/commit/a6c3da131c855650e8888a9403776cfda0d0ee2e), building of `libmultiprocess` fails for the `x86_64-w64-mingw32` target:
```
$ make -C depends libmultiprocess MULTIPROCESS=1 HOST=x86_64-w64-mingw32
...
Configuring libmultiprocess...
CMake Warning:
No source or binary directory provided. Both will be assumed to be the
same as the current working directory, but note that this warning will
become a fatal error in future CMake releases.
-- The CXX compiler identification is GNU 9.3.0
-- Check for working CXX compiler: /usr/bin/x86_64-w64-mingw32-g++-posix
-- Check for working CXX compiler: /usr/bin/x86_64-w64-mingw32-g++-posix -- broken
CMake Error at /usr/share/cmake-3.16/Modules/CMakeTestCXXCompiler.cmake:53 (message):
The C++ compiler
"/usr/bin/x86_64-w64-mingw32-g++-posix"
is not able to compile a simple test program.
It fails with the following output:
Change Dir: /home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-w64-mingw32/libmultiprocess/d576d975debdc9090bd2582f83f49c76c0061698-7e18b85317d/CMakeFiles/CMakeTmp
Run Build Command(s):/usr/bin/make cmTC_14f5f/fast && make[1]: Entering directory '/home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-w64-mingw32/libmultiprocess/d576d975debdc9090bd2582f83f49c76c0061698-7e18b85317d/CMakeFiles/CMakeTmp'
/usr/bin/make -f CMakeFiles/cmTC_14f5f.dir/build.make CMakeFiles/cmTC_14f5f.dir/build
make[2]: Entering directory '/home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-w64-mingw32/libmultiprocess/d576d975debdc9090bd2582f83f49c76c0061698-7e18b85317d/CMakeFiles/CMakeTmp'
Building CXX object CMakeFiles/cmTC_14f5f.dir/testCXXCompiler.cxx.o
/usr/bin/x86_64-w64-mingw32-g++-posix -I/home/hebasto/GitHub/bitcoin/depends/x86_64-w64-mingw32/include -pipe -O2 -o CMakeFiles/cmTC_14f5f.dir/testCXXCompiler.cxx.o -c /home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-w64-mingw32/libmultiprocess/d576d975debdc9090bd2582f83f49c76c0061698-7e18b85317d/CMakeFiles/CMakeTmp/testCXXCompiler.cxx
Linking CXX executable cmTC_14f5f
/usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_14f5f.dir/link.txt --verbose=1
/usr/bin/x86_64-w64-mingw32-g++-posix -I/home/hebasto/GitHub/bitcoin/depends/x86_64-w64-mingw32/include -pipe -O2 -L/home/hebasto/GitHub/bitcoin/depends/x86_64-w64-mingw32/lib -rdynamic CMakeFiles/cmTC_14f5f.dir/testCXXCompiler.cxx.o -o cmTC_14f5f
x86_64-w64-mingw32-g++-posix: error: unrecognized command line option ‘-rdynamic’
make[2]: *** [CMakeFiles/cmTC_14f5f.dir/build.make:87: cmTC_14f5f] Error 1
make[2]: Leaving directory '/home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-w64-mingw32/libmultiprocess/d576d975debdc9090bd2582f83f49c76c0061698-7e18b85317d/CMakeFiles/CMakeTmp'
make[1]: *** [Makefile:121: cmTC_14f5f/fast] Error 2
make[1]: Leaving directory '/home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-w64-mingw32/libmultiprocess/d576d975debdc9090bd2582f83f49c76c0061698-7e18b85317d/CMakeFiles/CMakeTmp'
CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
CMakeLists.txt:6 (project)
-- Configuring incomplete, errors occurred!
``` | https://github.com/bitcoin/bitcoin/issues/24389 | https://github.com/bitcoin/bitcoin/pull/24392 | f4005af3ec455a7fcfb94aa1a6673e821ac3d743 | f654cdb89cc4be8b68ca07021acdf1ff62c76f86 | 2022-02-19T10:26:21Z | c++ | 2022-04-26T14:44:12Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,387 | ["depends/funcs.mk", "depends/packages/libmultiprocess.mk"] | build: Fail to build `libmultiprocess` for the `arm-linux-gnueabihf` target | On master (a6c3da131c855650e8888a9403776cfda0d0ee2e), building of `libmultiprocess` fails for the `arm-linux-gnueabihf` target:
```
$ make -C depends libmultiprocess MULTIPROCESS=1 HOST=arm-linux-gnueabihf
make: Entering directory '/home/hebasto/GitHub/bitcoin/depends'
Building libmultiprocess...
make[1]: Entering directory '/home/hebasto/GitHub/bitcoin/depends/work/build/arm-linux-gnueabihf/libmultiprocess/d576d975debdc9090bd2582f83f49c76c0061698-e5741e5a04d'
make[2]: Entering directory '/home/hebasto/GitHub/bitcoin/depends/work/build/arm-linux-gnueabihf/libmultiprocess/d576d975debdc9090bd2582f83f49c76c0061698-e5741e5a04d'
make[3]: Entering directory '/home/hebasto/GitHub/bitcoin/depends/work/build/arm-linux-gnueabihf/libmultiprocess/d576d975debdc9090bd2582f83f49c76c0061698-e5741e5a04d'
[ 14%] Compiling Cap'n Proto schema include/mp/proxy.capnp
/lib/ld-linux-armhf.so.3: No such file or directory
make[3]: *** [CMakeFiles/multiprocess.dir/build.make:62: include/mp/proxy.capnp.c++] Error 255
make[3]: Leaving directory '/home/hebasto/GitHub/bitcoin/depends/work/build/arm-linux-gnueabihf/libmultiprocess/d576d975debdc9090bd2582f83f49c76c0061698-e5741e5a04d'
make[2]: *** [CMakeFiles/Makefile2:153: CMakeFiles/multiprocess.dir/all] Error 2
make[2]: Leaving directory '/home/hebasto/GitHub/bitcoin/depends/work/build/arm-linux-gnueabihf/libmultiprocess/d576d975debdc9090bd2582f83f49c76c0061698-e5741e5a04d'
make[1]: *** [Makefile:130: all] Error 2
make[1]: Leaving directory '/home/hebasto/GitHub/bitcoin/depends/work/build/arm-linux-gnueabihf/libmultiprocess/d576d975debdc9090bd2582f83f49c76c0061698-e5741e5a04d'
make: *** [funcs.mk:282: /home/hebasto/GitHub/bitcoin/depends/work/build/arm-linux-gnueabihf/libmultiprocess/d576d975debdc9090bd2582f83f49c76c0061698-e5741e5a04d/./.stamp_built] Error 2
make: Leaving directory '/home/hebasto/GitHub/bitcoin/depends'
``` | https://github.com/bitcoin/bitcoin/issues/24387 | https://github.com/bitcoin/bitcoin/pull/25046 | d17bbc3c484edae2552a28471d8879fca9664bcc | 9183c66cc6ae173e0f2efe52b09cb9a8e64d5550 | 2022-02-19T09:36:58Z | c++ | 2022-05-04T15:34:57Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,373 | ["src/test/util/setup_common.cpp"] | Test-only UB in fuzz tests | This line:
```c++
ConnmanTestMsg& connman = *static_cast<ConnmanTestMsg*>(g_setup->m_node.connman.get());
```
in src/test/fuzz/process_message.cpp:37, is constructing a reference to a ConnmanTestMsg, which actually refers to an object of type Connman. Even though ConnmanTestMsg inherits from Connman, and adds no fields, I am pretty sure this is undefined behavior.
It isn't detected by the sanitizer because they're not polymorphic types for which runtime type information is tracked, but if you make `Connman::~Connman()` `virtual`, it does get detected:
```
test/fuzz/util.cpp:265:23: runtime error: member call on address 0x619000034380 which does not point to an object of type 'ConnmanTestMsg'
0x619000034380: note: object is of type 'CConnman'
00 00 00 00 90 8e a0 29 19 56 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00
^~~~~~~~~~~~~~~~~~~~~~~
vptr for 'CConnman'
```
I don't know how to quickly solve this myself, as I'm unfamiliar with this part of the code, so I'm opening an issue to discuss it. | https://github.com/bitcoin/bitcoin/issues/24373 | https://github.com/bitcoin/bitcoin/pull/24841 | f3e0ace8ecd84009a23da6b0de47f01d79c45772 | 6be319beb8d6281cd82be8132dc4b765978122ba | 2022-02-17T20:49:56Z | c++ | 2022-04-16T07:10:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,368 | ["src/util/syscall_sandbox.cpp"] | Syscall sandbox fails on Ubuntu 22.04 | It doesn't even specify which "invalid syscall".
```
$ src/bitcoind -sandbox=log-and-abort
2022-02-17T13:45:57Z Bitcoin Core version v22.99.0-b223c3c21e89 (release build)
2022-02-17T13:45:57Z Assuming ancestors of block 00000000000000000008a89e854d57e5667df88f1cdef6fde2fbca1de5b639ad have valid signatures.
2022-02-17T13:45:57Z Setting nMinimumChainWork=00000000000000000000000000000000000000001fa4663bbbe19f82de910280
2022-02-17T13:45:57Z Experimental syscall sandbox enabled (-sandbox=log-and-abort): bitcoind will terminate if an unexpected (not allowlisted) syscall is invoked.
2022-02-17T13:45:57Z Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
2022-02-17T13:45:57Z Default data directory /…/.bitcoin
2022-02-17T13:45:57Z Using data directory /…/.bitcoin
2022-02-17T13:45:57Z Config file: /…/.bitcoin/bitcoin.conf (not found, skipping)
2022-02-17T13:45:57Z Command-line arg: sandbox="log-and-abort"
2022-02-17T13:45:57Z Using at most 125 automatic connections (1024 file descriptors available)
2022-02-17T13:45:57Z Using 16 MiB out of 32/2 requested for signature cache, able to store 524288 elements
2022-02-17T13:45:57Z Using 16 MiB out of 32/2 requested for script execution cache, able to store 524288 elements
2022-02-17T13:45:57Z Script verification uses 1 additional threads
Bad system call (core dumped)
```
Nothing in `dmesg` either. | https://github.com/bitcoin/bitcoin/issues/24368 | https://github.com/bitcoin/bitcoin/pull/24369 | 2b0735d183111a4e40c0d188bc91d0539faca5b7 | ffcbaf569eaad68049852fcb349e2e5021412616 | 2022-02-17T13:49:19Z | c++ | 2022-02-20T11:29:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,346 | ["contrib/guix/guix-attest"] | guix-attest should support custom GPG executable names | **Is your feature request related to a problem? Please describe.**
In Qubes OS, the "Split-GPG" feature allows keeping the private key in a separate VM from the application (in this case guix-attest). This prevents a compromised VM (in which Bitcoin Core was built) from stealing the private signing key. Qubes provides a `qubes-gpg-client-wrapper` executable that has the same API as `gpg`. Unfortunately, there is currently no way to make `guix-attest` use that executable instead of plain `gpg`.
**Describe the solution you'd like**
Support an optional environment variable in `guix-attest`, which allows specifying an arbitrary command name that replaces `gpg`.
**Describe alternatives you've considered**
I considered a command-line parameter, but it seems that environment variables are the convention in `guix-attest`.
**Additional context**
I believe OpenTimestamps provides a wrapper with `gpg`'s API as well, so maybe this would also be helpful for facilitating OpenTimestamps with Guix.
| https://github.com/bitcoin/bitcoin/issues/24346 | https://github.com/bitcoin/bitcoin/pull/24552 | 696d39410fc3372d120a6e89695c1543ac2fc052 | b3072799248fae8fc16f910b642edb9c5acf8bac | 2022-02-15T02:04:10Z | c++ | 2022-04-06T10:41:15Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,329 | ["doc/release-process.md"] | Release process: "does not appear to be a git repository" | The `release-process.md` docs erroneously omit the remote name from `git fetch`.
**Expected behavior**
`git fetch` should complete without errors.
**Actual behavior**
~~~
fatal: 'v22.0' does not appear to be a git repository
fatal: Could not read from remote repository.
~~~
**To reproduce**
Follow steps in `release-process.md` through this line:
`git fetch "v${VERSION}"`
**System information**
Bitcoin Core b6b7815ddcff53177bb1f6318b39a4134cf42cb1, self-compiled.
Whonix 16 inside Qubes 4.1, Intel Haswell, HDD.
git v2.30.2.
Replacing the offending line with `git fetch origin "v${VERSION}"` works fine.
| https://github.com/bitcoin/bitcoin/issues/24329 | https://github.com/bitcoin/bitcoin/pull/24330 | b6b7815ddcff53177bb1f6318b39a4134cf42cb1 | b1aa3b1959cab1ad8bb6d0a6a5d05c87c1271cdb | 2022-02-13T05:51:29Z | c++ | 2022-02-13T07:58:09Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,314 | ["configure.ac"] | Bionic with system libs doesn't link | Steps to reproduce on a fresh install of Ubuntu Bionic:
```
export DEBIAN_FRONTEND=noninteractive && apt update && apt install curl wget htop git vim ccache -y && git clone https://github.com/bitcoin/bitcoin.git ./bitcoin-core && cd bitcoin-core && apt install build-essential libtool autotools-dev automake pkg-config bsdmainutils python3-zmq libevent-dev libboost-system-dev libboost-filesystem-dev libboost-test-dev libboost-thread-dev libsqlite3-dev libdb++-dev gcc-8 g++-8 -y && ./autogen.sh && CXX=g++-8 CC=gcc-8 ./configure --without-incompatible-bdb && make -j $(nproc)
```
Output:
```
CXXLD bitcoind
libbitcoin_util.a(libbitcoin_util_a-system.o): In function `boost::system::error_category::std_category::equivalent(std::error_code const&, int) const':
/usr/include/boost/system/error_code.hpp:686: undefined reference to `boost::system::generic_category()'
/usr/include/boost/system/error_code.hpp:689: undefined reference to `boost::system::generic_category()'
/usr/include/boost/system/error_code.hpp:701: undefined reference to `boost::system::generic_category()'
libbitcoin_util.a(libbitcoin_util_a-system.o): In function `boost::system::error_category::std_category::equivalent(int, std::error_condition const&) const':
/usr/include/boost/system/error_code.hpp:656: undefined reference to `boost::system::generic_category()'
/usr/include/boost/system/error_code.hpp:659: undefined reference to `boost::system::generic_category()'
libbitcoin_util.a(libbitcoin_util_a-system.o):/usr/include/boost/system/error_code.hpp:206: more undefined references to `boost::system::generic_category()' follow
libbitcoin_util.a(libbitcoin_util_a-system.o): In function `__static_initialization_and_destruction_0':
/usr/include/boost/system/error_code.hpp:210: undefined reference to `boost::system::system_category()'
libbitcoin_util.a(libbitcoin_util_a-system.o): In function `_GLOBAL__sub_I_BITCOIN_CONF_FILENAME':
/usr/include/boost/asio/error.hpp:230: undefined reference to `boost::system::system_category()'
collect2: error: ld returned 1 exit status
Makefile:5708: recipe for target 'bitcoind' failed
make[2]: *** [bitcoind] Error 1
make[2]: Leaving directory '/bitcoin-core/src'
Makefile:16758: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/bitcoin-core/src'
Makefile:814: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
```
Initial report by @hebasto in https://github.com/bitcoin/bitcoin/pull/20744#issuecomment-1029406510 | https://github.com/bitcoin/bitcoin/issues/24314 | https://github.com/bitcoin/bitcoin/pull/24254 | 9011d4d8ae610d75f12a36aabf6c5ea6f97a8840 | 988058defbb654c256c0e48d7489e19975060c5f | 2022-02-10T20:45:29Z | c++ | 2022-02-14T20:21:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,257 | ["src/util/system.cpp"] | bitcoind and bitcoin-cli does not supports symbolic link anymore | I just pulled latest master at https://github.com/bitcoin/bitcoin/commit/3ace3a17c9bce606cea05192f0da3ac62ac69dda and I cannot run bitcoind or bitcoin-cli without providing a full path for data directory using `-datadir` option. It was working fine couple of days ago (while running https://github.com/bitcoin/bitcoin/commit/807169e10b4a18324356ed6ee4d69587b96a7c70). I suspect it may be related to latest switch to the standard std::filesystem library https://github.com/bitcoin/bitcoin/pull/20744
**Expected behavior**
I use a symbolic link to point my /home/me/.bitcoin to an external hard drive. When running `bitcoind` from command line, or executing `bitcoin-cli` commands, without using the `-datadir` option, it should not terminate or crash unexpectedly. Those commands should be able to follow the symbolic link and be able to read/write into the final folder.
**Actual behavior**
`bitcoind` and `bitcoin-cli` are not able to follow the symbolic link. `bitcoin-qt` runs fine, even when running it from command line. See below commands examples.
```
# Create a symbolic link
$~/btc-things/bitcoin$ ln -s /media/DATA/Bitcoin /home/me/.bitcoin
# Try to run bitcoind - Crashes
$~/btc-things/bitcoin$ ./bitcoind
************************
EXCEPTION: NSt10filesystem7__cxx1116filesystem_errorE
filesystem error: cannot create directories: Not a directory [/home/me/.bitcoin]
bitcoin in AppInit()
bitcoind: chainparamsbase.cpp:35: const CBaseChainParams& BaseParams(): Assertion `globalChainBaseParams' failed.
Aborted (core dumped)
# Run bitcoin-qt, it works fine, the node runs
$~/btc-things/bitcoin$ ./bitcoin-qt
qt5ct: using qt5ct plugin
# Try to run a bitcoin-cli command to interact with the running node, does not work
$~/btc-things/bitcoin$ ./bitcoin-cli getblockhash 501726
************************
EXCEPTION: NSt10filesystem7__cxx1116filesystem_errorE
filesystem error: cannot create directories: Not a directory [/home/me/.bitcoin]
bitcoin in AppInitRPC()
# Try the same previous command but give an absolute path for -datadir, works fine
$~/btc-things/bitcoin$ ./bitcoin-cli -datadir=/media/DATA/Bitcoin getblockhash 501726
0000000000000000004b27f9ee7ba33d6f048f684aaeb0eea4befd80f1701126
```
**To reproduce**
Steps are indicated previously.
**System information**
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
Running `Bitcoin Core version v22.99.0-3ace3a17c9bc`. Self compiled from `master` branch.
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
I'm using Linux Mint with the following kernel `Linux 5.4.0-96-generic x86_64`.
I'm using an additional hard drive to store the full blockchain (SSD).
<!-- Any extra information that might be useful in the debugging process. -->
I had no prior issues before pulling latest changes. I was previously running at https://github.com/bitcoin/bitcoin/commit/807169e10b4a18324356ed6ee4d69587b96a7c70 | https://github.com/bitcoin/bitcoin/issues/24257 | https://github.com/bitcoin/bitcoin/pull/24266 | 8afcc89a8f96692dd880b6102c9a85fac18b9021 | 8edb0416dd4a13f6fae0c7f2f2061dd6f9365a0e | 2022-02-04T02:44:51Z | c++ | 2022-02-08T14:46:34Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,242 | ["src/init.cpp", "test/functional/feature_pruning.py"] | -reindex-chainstate with -prune hangs | Steps to reproduce:
* Create a datadir that is pruned
* Start with `-prune=550 -reindex-chainstate`
* Hangs with idle CPU
(`-reindex` works) | https://github.com/bitcoin/bitcoin/issues/24242 | https://github.com/bitcoin/bitcoin/pull/24626 | 7d0e42abce9dd7c0f192928e909a98278a70dd3d | 4a0ab355b3e7e7a3fae218fb5d9894fb7f3636a5 | 2022-02-02T20:14:05Z | c++ | 2022-03-24T13:27:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,211 | ["contrib/guix/manifest.scm"] | guix: building for `arm64-apple-darwin` fails on arm64-apple (M1) | Similar but different to #22458. The build fails in depends while building libdmg-hfsplus:
```bash
time BASE_CACHE="/base_cache" SOURCES_PATH="/sources" SDK_PATH="/SDKs" HOSTS="arm64-apple-darwin" ./contrib/guix/guix-build
< snipped >
[ 48%] Building C object hfs/CMakeFiles/hfs.dir/hfscompress.c.o
[ 51%] Linking C static library libhfs.a
make[3]: Leaving directory '/bitcoin/depends/work/build/arm64-apple-darwin/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-9689ef82609/build'
[ 51%] Built target hfs
make[3]: Entering directory '/bitcoin/depends/work/build/arm64-apple-darwin/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-9689ef82609/build'
make[3]: Leaving directory '/bitcoin/depends/work/build/arm64-apple-darwin/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-9689ef82609/build'
make[3]: Entering directory '/bitcoin/depends/work/build/arm64-apple-darwin/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-9689ef82609/build'
[ 55%] Building C object dmg/CMakeFiles/dmg.dir/adc.c.o
[ 59%] Building C object dmg/CMakeFiles/dmg.dir/base64.c.o
[ 62%] Building C object dmg/CMakeFiles/dmg.dir/checksum.c.o
[ 66%] Building C object dmg/CMakeFiles/dmg.dir/dmgfile.c.o
[ 70%] Building C object dmg/CMakeFiles/dmg.dir/filevault.c.o
[ 74%] Building C object dmg/CMakeFiles/dmg.dir/dmglib.c.o
[ 77%] Building C object dmg/CMakeFiles/dmg.dir/io.c.o
[ 81%] Building C object dmg/CMakeFiles/dmg.dir/resources.c.o
[ 85%] Building C object dmg/CMakeFiles/dmg.dir/partition.c.o
[ 88%] Building C object dmg/CMakeFiles/dmg.dir/udif.c.o
[ 92%] Linking C static library libdmg.a
make[3]: Leaving directory '/bitcoin/depends/work/build/arm64-apple-darwin/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-9689ef82609/build'
[ 92%] Built target dmg
make[3]: Entering directory '/bitcoin/depends/work/build/arm64-apple-darwin/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-9689ef82609/build'
make[3]: Leaving directory '/bitcoin/depends/work/build/arm64-apple-darwin/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-9689ef82609/build'
make[3]: Entering directory '/bitcoin/depends/work/build/arm64-apple-darwin/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-9689ef82609/build'
[ 96%] Building C object dmg/CMakeFiles/dmg-bin.dir/dmg.c.o
[100%] Linking C executable dmg
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(abort.o): in function `abort':
(.text.unlikely+0x34): undefined reference to `__aarch64_cas4_acq'
ld: (.text.unlikely+0xa0): undefined reference to `__aarch64_swp4_rel'
ld: (.text.unlikely+0xe4): undefined reference to `__aarch64_cas4_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(libc-start.o): in function `__libc_start_main':
(.text+0x330): undefined reference to `__aarch64_ldadd4_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(assert.o): in function `__assert_fail_base':
(.text+0x114): undefined reference to `__aarch64_swp8_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(dcigettext.o): in function `_nl_find_msg':
(.text+0x7d8): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x8c8): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x90c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x928): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x994): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x9e4): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(loadmsgcat.o): in function `_nl_load_domain':
(.text+0x44): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x438): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(localealias.o): in function `_nl_expand_alias':
(.text+0x3f8): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x490): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x554): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(exit.o): in function `__run_exit_handlers':
(.text+0x5c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x84): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xb4): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x100): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x17c): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x1b8): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(cxa_atexit.o): in function `__internal_atexit':
(.text+0x150): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x188): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x1c4): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(vfscanf-internal.o): in function `__vfscanf_internal':
(.text+0x1ec): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xa48): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(vfprintf-internal.o): in function `__vfprintf_internal':
(.text+0x2528): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x26a0): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x4628): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x46a8): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(fxprintf.o): in function `__vfxprintf':
(.text+0x224): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x2a4): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(fxprintf.o): in function `__fxprintf_nocancel':
(.text+0x3f4): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x480): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(iofclose.o): in function `_IO_new_fclose':
(.text+0x48): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xe4): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x104): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x1b0): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x23c): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(iofflush.o): in function `_IO_fflush':
(.text+0x44): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xd0): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x138): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(iofread.o): in function `_IO_fread':
(.text+0x5c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xf8): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x154): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(iofwrite.o): in function `_IO_fwrite':
(.text+0x5c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x160): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x17c): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x1f8): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(ioputs.o): in function `_IO_puts':
(.text+0x54): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x148): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x1d0): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(putchar.o): in function `putchar':
(.text+0x4c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xf0): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x154): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(wfileops.o): in function `_IO_wfile_underflow':
(.text+0xb4): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x59c): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x654): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(fseeko.o): in function `__fseeko':
(.text+0x4c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xc0): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x11c): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(ftello.o): in function `__ftello':
(.text+0x40): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xb8): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x154): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x1cc): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(libc_fatal.o): in function `__libc_message':
(.text+0x234): undefined reference to `__aarch64_swp8_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(fileops.o): in function `_IO_new_file_underflow':
(.text+0x28c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x2f8): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x508): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(genops.o):(.text+0x5c): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(genops.o):(.text+0x90): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(genops.o):(.text+0x2d4): undefined reference to `__aarch64_cas4_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(genops.o):(.text+0x318): undefined reference to `__aarch64_cas4_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(genops.o):(.text+0x3f8): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(genops.o):(.text+0x46c): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(genops.o): in function `_IO_link_in':
(.text+0x554): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x594): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x5e0): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x680): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(genops.o): in function `_IO_flush_all_lockp':
(.text+0x1618): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x167c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x178c): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x17c0): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(genops.o): in function `_IO_cleanup':
(.text+0x188c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x1904): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x19a4): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x1a18): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x1ab0): undefined reference to `__aarch64_cas4_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(genops.o): in function `_IO_flush_all_linebuffered':
(.text+0x1b60): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x1bb0): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x1c5c): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x1cd4): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(genops.o): in function `_IO_list_lock':
(.text+0x2180): undefined reference to `__aarch64_cas4_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(genops.o): in function `_IO_list_unlock':
(.text+0x21e8): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(libc-lowlevellock.o): in function `__lll_lock_wait_private':
(.text+0x24): undefined reference to `__aarch64_swp4_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(malloc.o): in function `_dl_tunable_set_mxfast':
(.text+0x824): undefined reference to `__aarch64_ldadd4_acq'
ld: (.text+0x830): undefined reference to `__aarch64_ldadd8_acq'
ld: (.text+0x96c): undefined reference to `__aarch64_ldadd8_acq'
ld: (.text+0x98c): undefined reference to `__aarch64_cas8_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(malloc.o): in function `_dl_tunable_set_mallopt_check':
(.text+0xb58): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xc0c): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x1114): undefined reference to `__aarch64_swp8_acq'
ld: (.text+0x14c4): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x1584): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x15a0): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x15f0): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x164c): undefined reference to `__aarch64_cas8_rel'
ld: (.text+0x19a8): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x1e3c): undefined reference to `__aarch64_ldadd4_acq'
ld: (.text+0x1e5c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x1e74): undefined reference to `__aarch64_ldadd8_acq'
ld: (.text+0x1e94): undefined reference to `__aarch64_cas8_acq'
ld: (.text+0x2374): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x23a4): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x23e8): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x24c8): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x24f4): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x255c): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x25d0): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x25fc): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x2628): undefined reference to `__aarch64_cas8_acq'
ld: (.text+0x2750): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x2778): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x2794): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x27bc): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x27d4): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x2844): undefined reference to `__aarch64_cas8_acq'
ld: (.text+0x28d8): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x291c): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x2934): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x2964): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x2b80): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x2b9c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x2bc4): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x2f88): undefined reference to `__aarch64_cas8_acq'
ld: (.text+0x3460): undefined reference to `__aarch64_cas8_acq'
ld: (.text+0x3b04): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x3b2c): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x3e60): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x3e8c): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x4204): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x4228): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x4268): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x42dc): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x4428): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x444c): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(malloc.o): in function `__malloc_fork_lock_parent':
(.text+0x454c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x456c): undefined reference to `__aarch64_cas4_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(malloc.o): in function `__malloc_fork_unlock_parent':
(.text+0x45d8): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x4604): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(malloc.o): in function `__libc_malloc':
(.text+0x48dc): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x4900): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x4b78): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x4ba0): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(malloc.o): in function `__malloc_arena_thread_freeres':
(.text+0x4ee0): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x4f14): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(malloc.o): in function `__libc_realloc':
(.text+0x51cc): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x51f4): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(malloc.o): in function `__libc_calloc':
(.text+0x5618): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x5694): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x56c8): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(malloc.o): in function `__malloc_trim':
(.text+0x57c4): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x58d4): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x593c): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(malloc.o): in function `__libc_mallinfo2':
(.text+0x5afc): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x5b18): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(malloc.o): in function `__malloc_stats':
(.text+0x5c90): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x5cec): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(malloc.o): in function `__libc_mallopt':
(.text+0x5e00): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x5e54): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x5f00): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x5f50): undefined reference to `__aarch64_cas4_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(wcsmbsload.o): in function `__wcsmbs_clone_conv':
(.text+0x318): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x368): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(tzset.o): in function `__tzset':
(.text+0xe64): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xea4): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(tzset.o): in function `__tz_convert':
(.text+0xf28): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xf78): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x102c): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(gconv_db.o): in function `__gconv_find_transform':
(.text+0xa98): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xb4c): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0xb90): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0xbec): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0xc6c): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(gconv_db.o): in function `__gconv_close_transform':
(.text+0xcd4): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xd98): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(setenv.o): in function `__add_to_environ':
(.text+0x4c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xf8): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x184): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x2e0): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(setenv.o): in function `__unsetenv':
(.text+0x3fc): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x44c): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(setenv.o): in function `__clearenv':
(.text+0x500): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x52c): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x55c): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(random.o): in function `__srandom':
(.text+0x24): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x44): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(random.o): in function `__initstate':
(.text+0xc0): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xf4): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(random.o): in function `__setstate':
(.text+0x178): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x1a8): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(random.o): in function `__random':
(.text+0x220): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x240): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(reg-printf.o): in function `__register_printf_specifier':
(.text+0x3c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x68): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(reg-modifier.o): in function `__register_printf_modifier':
(.text+0x88): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x104): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(reg-type.o): in function `__register_printf_type':
(.text+0x28): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x6c): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(funlockfile.o): in function `__funlockfile':
(.text+0x34): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(vfwprintf-internal.o): in function `__vfwprintf_internal':
(.text+0x26b0): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x2808): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x48b4): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x4928): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(iofputs.o): in function `_IO_fputs':
(.text+0x50): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x10c): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x170): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(iogetdelim.o): in function `_IO_getdelim':
(.text+0x1a0): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x224): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x2cc): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(ioseekoff.o): in function `_IO_seekoff':
(.text+0x168): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x1dc): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x238): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(fseek.o): in function `fseek':
(.text+0x4c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xc0): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x11c): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(libc-cancellation.o): in function `__libc_enable_asynccancel':
(.text+0x38): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x90): undefined reference to `__aarch64_cas4_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(libc-cancellation.o): in function `__libc_disable_asynccancel':
(.text+0xd8): undefined reference to `__aarch64_cas4_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(rewinddir.o): in function `__rewinddir':
(.text+0x20): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x4c): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(readdir64.o): in function `__readdir64':
(.text+0x3c): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0xc4): undefined reference to `__aarch64_swp4_rel'
ld: (.text+0x110): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(dl-lookup.o): in function `_dl_lookup_symbol_x':
(.text+0x1130): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(dl-profile.o): in function `_dl_mcount':
(.text+0x7e8): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x850): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x8ac): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x918): undefined reference to `__aarch64_cas4_acq'
ld: (.text+0x990): undefined reference to `__aarch64_cas4_acq'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(dl-profile.o):(.text+0x9e4): more undefined references to `__aarch64_cas4_acq' follow
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(dl-thread_gscope_wait.o): in function `__thread_gscope_wait':
(.text+0x1a4): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(dl-runtime.o): in function `_dl_fixup':
(.text+0x16c): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(dl-runtime.o): in function `_dl_profile_fixup':
(.text+0x438): undefined reference to `__aarch64_swp4_rel'
ld: /gnu/store/pm2ghr2rjc93q5r0l79jfzz0bmw38q6n-gcc-toolchain-7.5.0-static/lib/libc.a(dl-sym.o):(.text+0x240): undefined reference to `__aarch64_swp4_rel'
collect2: error: ld returned 1 exit status
make[3]: *** [dmg/CMakeFiles/dmg-bin.dir/build.make:100: dmg/dmg] Error 1
make[3]: Leaving directory '/bitcoin/depends/work/build/arm64-apple-darwin/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-9689ef82609/build'
make[2]: *** [CMakeFiles/Makefile2:184: dmg/CMakeFiles/dmg-bin.dir/all] Error 2
make[2]: Leaving directory '/bitcoin/depends/work/build/arm64-apple-darwin/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-9689ef82609/build'
make[1]: *** [Makefile:136: all] Error 2
make[1]: Leaving directory '/bitcoin/depends/work/build/arm64-apple-darwin/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-9689ef82609/build/dmg'
make: *** [funcs.mk:282: /bitcoin/depends/work/build/arm64-apple-darwin/native_libdmg-hfsplus/7ac55ec64c96f7800d9818ce64c79670e7f02b67-9689ef82609/build/.stamp_built] Error 2
make: Leaving directory '/bitcoin/depends'
``` | https://github.com/bitcoin/bitcoin/issues/24211 | https://github.com/bitcoin/bitcoin/pull/24495 | 05e5af5a6c884d2ade3d7acc766ad5380cb85b64 | fe5fdbd687db610aa004f0a7299fe326a5a2794a | 2022-01-31T08:08:57Z | c++ | 2022-03-09T10:24:53Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,188 | ["src/addrdb.cpp", "src/addrman.cpp", "src/addrman.h", "test/functional/feature_addrman.py"] | Avoid InitError when downgrading peers.dat | See https://github.com/bitcoin/bitcoin/pull/22762#issuecomment-951063826
This can be fixed by creating a new exception type and catching it in the right place.
#### Useful skills:
* C++ exceptions
* Addrman serialization
* Functional tests
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/24188 | https://github.com/bitcoin/bitcoin/pull/24201 | f1ce67f09fbaba4013443bce416e46e5b2d37c19 | b00b60ed4f27066656e45635f1386e6b1550c6ed | 2022-01-28T07:58:27Z | c++ | 2022-02-25T07:45:11Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,151 | ["test/functional/rpc_psbt.py", "test/functional/wallet_send.py"] | "Fee too high" CI error in wallet_send.py | `wallet_send.py --legacy-wallet` line 332
https://cirrus-ci.com/task/6260771733635072
```
2022-01-25T13:05:06.243000Z TestFramework (INFO): Test setting explicit fee rate
2022-01-25T13:05:06.666000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/wallet_send.py", line 332, in run_test
assert_fee_amount(fee, Decimal(len(res["hex"]) / 2), Decimal("0.00004531"))
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 45, in assert_fee_amount
raise AssertionError("Fee of %s BTC too high! (Should be %s BTC)" % (str(fee), str(target_fee)))
AssertionError: Fee of 0.00000993 BTC too high! (Should be 0.00000983 BTC)
```
Haven't seen it fail yet locally on the same branch while running:
```
(for i in {1..1000}; do test/functional/wallet_send.py --legacy-wallet --pdbonfailure ; done)
```
This test assertion was added in October 2020 (603c0050837) and the `get_fee()` test utility helper in October 2021 (80dc829be7f), so if the error is new then it might stem from a more recent change. | https://github.com/bitcoin/bitcoin/issues/24151 | https://github.com/bitcoin/bitcoin/pull/24454 | b31ba3abf81c0770fd12ae59e25ba1e92ef45f05 | aa54132bac3b604035dfc46823e3367c218f8510 | 2022-01-25T13:39:11Z | c++ | 2022-04-25T08:54:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,119 | ["contrib/signet/getcoins.py"] | Improve `getcoins.py` | There were few improvements discussed in https://github.com/bitcoin/bitcoin/pull/23162#issuecomment-934338007
> Sanitize any strings coming from the faucet.
Require the captcha to be in a specific image format (this is currently left open), by making the input -:svg. This is a compromise as it would limit flexibility to change image formats in the future.
Limit the size/complexity of the SVG, limit dimensions—don't know if ImageMagick has introspection into this before actually rendering the thing, you might need a sifferent SVG parser.
I could also find one recommendation in https://lgtm.com/projects/g/bitcoin/bitcoin/rev/a6d9675d604827892e31a47994af3b64440f66db:
> Except block directly handles BaseException. Handling 'BaseException' means that system exits and keyboard interrupts may be mis-handled.
I am not sure what is the best way to handle exceptions in python however improving other things related to captcha and security are important.
#### Useful skills:
- Python
- Secure Coding
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/24119 | https://github.com/bitcoin/bitcoin/pull/24180 | 25a91a571a4f3453f7e0e9299ee7a40a61d04f19 | 3eec29ed3aa1c8eb293a7a7a6be356fc014f8813 | 2022-01-20T23:25:17Z | c++ | 2022-02-14T08:12:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,076 | ["src/index/coinstatsindex.cpp", "src/index/coinstatsindex.h", "src/test/coinstatsindex_tests.cpp", "src/test/util/validation.cpp", "src/test/util/validation.h", "src/validationinterface.h"] | coinstatsindex way more fragile than any other data w.r.t. power loss |
<!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
**Two times since a fresh 22.0 installation I've had a power loss event (artifically produced to test system behavior), and each time I've started getting incorrect muhash values for block heights since approximately that moment**
"Approximately", as in I've not taken care to record the exact time of events because I've expecting nothing of interest from bitcoind in particular; "incorrect", as in compared to my another long-running nodes running with coinstatsindex without power outages, **and** to its own muhash for the current tip calculated without using the index, `gettxoutsetinfo muhash null false`.
**Expected behavior**
As usual when testing power outage behavior, I've expected pretty much anything **except** silently returning incorrect data. Most desirable would be checking several recent block muhashes on restart and auto-correcting the problem.
**To reproduce**
Unsure if it can be reproduced reliably, but 2/2 times are rather good indicator that it may not be uncommon
**System information**
Ubuntu Linux 20.04, `~/.bitcoin` on /dev/md raid1 over two HDDs, ext4 fs with default mount options
Running bitcoind 22.0 prebuilt binaries from bitcoincore (amd64).
Here's debug.log from a typical restart (I see nothing interesting there, just in case if some configured or autodetected parameters are relevant):
```
2022-01-14T17:10:34Z Bitcoin Core version v22.0.0 (release build)
2022-01-14T17:10:34Z Assuming ancestors of block 00000000000000000008a89e854d57e5667df88f1cdef6fde2fbca1de5b639ad have valid signatures.
2022-01-14T17:10:34Z Setting nMinimumChainWork=00000000000000000000000000000000000000001fa4663bbbe19f82de910280
2022-01-14T17:10:34Z Using the 'shani(1way,2way)' SHA256 implementation
2022-01-14T17:10:34Z Using RdSeed as additional entropy source
2022-01-14T17:10:34Z Using RdRand as an additional entropy source
2022-01-14T17:10:34Z Default data directory /home/bitnode/.bitcoin
2022-01-14T17:10:34Z Using data directory /srv/slow/dot-bitcoin
2022-01-14T17:10:34Z Config file: /etc/bitcoin/bitcoin.conf
2022-01-14T17:10:34Z Config file arg: blockfilterindex="1"
2022-01-14T17:10:34Z Config file arg: coinstatsindex="1"
2022-01-14T17:10:34Z Config file arg: dbcache="2000"
2022-01-14T17:10:34Z Config file arg: listen="1"
2022-01-14T17:10:34Z Config file arg: maxuploadtarget="450"
2022-01-14T17:10:34Z Config file arg: peerblockfilters="1"
2022-01-14T17:10:34Z Config file arg: server="1"
2022-01-14T17:10:34Z Config file arg: txindex="1"
2022-01-14T17:10:34Z Config file arg: upnp="0"
2022-01-14T17:10:34Z Config file arg: whitelist="[email protected]"
2022-01-14T17:10:34Z Config file arg: whitelist="[email protected]/24"
2022-01-14T17:10:34Z Config file arg: zmqpubrawblock="tcp://127.0.0.1:28332"
2022-01-14T17:10:34Z Config file arg: zmqpubrawtx="tcp://127.0.0.1:28333"
2022-01-14T17:10:34Z Command-line arg: conf="/etc/bitcoin/bitcoin.conf"
2022-01-14T17:10:34Z Command-line arg: daemonwait=""
2022-01-14T17:10:34Z Command-line arg: datadir="/srv/slow/dot-bitcoin/"
2022-01-14T17:10:34Z Command-line arg: pid="/run/bitcoind/bitcoind.pid"
2022-01-14T17:10:34Z Using at most 125 automatic connections (1024 file descriptors available)
2022-01-14T17:10:34Z Using 16 MiB out of 32/2 requested for signature cache, able to store 524288 elements
2022-01-14T17:10:34Z Using 16 MiB out of 32/2 requested for script execution cache, able to store 524288 elements
2022-01-14T17:10:34Z Script verification uses 15 additional threads
2022-01-14T17:10:34Z scheduler thread start
2022-01-14T17:10:34Z HTTP: creating work queue of depth 16
2022-01-14T17:10:34Z Using random cookie authentication.
2022-01-14T17:10:34Z Generated RPC authentication cookie /srv/slow/dot-bitcoin/.cookie
2022-01-14T17:10:34Z HTTP: starting 4 worker threads
2022-01-14T17:10:34Z Using wallet directory /srv/slow/dot-bitcoin/wallets
2022-01-14T17:10:34Z init message: Verifying wallet(s)…
2022-01-14T17:10:34Z init message: Loading banlist…
2022-01-14T17:10:34Z SetNetworkActive: true
2022-01-14T17:10:34Z Using /16 prefix for IP bucketing
2022-01-14T17:10:34Z Cache configuration:
2022-01-14T17:10:34Z * Using 2.0 MiB for block index database
2022-01-14T17:10:34Z * Using 249.8 MiB for transaction index database
2022-01-14T17:10:34Z * Using 218.5 MiB for basic block filter index database
2022-01-14T17:10:34Z * Using 8.0 MiB for chain state database
2022-01-14T17:10:34Z * Using 1521.7 MiB for in-memory UTXO set (plus up to 286.1 MiB of unused mempool space)
2022-01-14T17:10:34Z init message: Loading block index…
2022-01-14T17:10:34Z Switching active chainstate to Chainstate [ibd] @ height -1 (null)
2022-01-14T17:10:34Z Opening LevelDB in /srv/slow/dot-bitcoin/blocks/index
2022-01-14T17:10:34Z Opened LevelDB successfully
2022-01-14T17:10:34Z Using obfuscation key for /srv/slow/dot-bitcoin/blocks/index: 0000000000000000
2022-01-14T17:10:38Z LoadBlockIndexDB: last block file = 2883
2022-01-14T17:10:38Z LoadBlockIndexDB: last block file info: CBlockFileInfo(blocks=17, size=20113255, heights=718645...718661, time=2022-01-14...2022-01-14)
2022-01-14T17:10:38Z Checking all blk files are present...
2022-01-14T17:10:38Z Opening LevelDB in /srv/slow/dot-bitcoin/chainstate
2022-01-14T17:10:39Z Opened LevelDB successfully
2022-01-14T17:10:39Z Using obfuscation key for /srv/slow/dot-bitcoin/chainstate: d57f45de91bd35fa
2022-01-14T17:10:39Z Loaded best chain: hashBestChain=000000000000000000001cab1821f8b5ce71faccfde4d9ae11ab444c0dff979f height=718643 date=2022-01-14T14:19:04Z progress=0.999964
2022-01-14T17:10:39Z init message: Verifying blocks…
2022-01-14T17:10:39Z Verifying last 6 blocks at level 3
2022-01-14T17:10:39Z [0%]...[16%]...[33%]...[50%]...[66%]...[83%]...[99%]...[DONE].
2022-01-14T17:12:34Z No coin database inconsistencies in last 6 blocks (9259 transactions)
2022-01-14T17:12:34Z block index 120309ms
2022-01-14T17:12:34Z Opening LevelDB in /srv/slow/dot-bitcoin/indexes/txindex
2022-01-14T17:12:35Z Opened LevelDB successfully
2022-01-14T17:12:35Z Using obfuscation key for /srv/slow/dot-bitcoin/indexes/txindex: 0000000000000000
2022-01-14T17:12:35Z txindex thread start
2022-01-14T17:12:35Z txindex is enabled at height 718643
2022-01-14T17:12:35Z txindex thread exit
2022-01-14T17:12:35Z Opening LevelDB in /srv/slow/dot-bitcoin/indexes/blockfilter/basic/db
2022-01-14T17:12:35Z Opened LevelDB successfully
2022-01-14T17:12:35Z Using obfuscation key for /srv/slow/dot-bitcoin/indexes/blockfilter/basic/db: 0000000000000000
2022-01-14T17:12:35Z basic block filter index thread start
2022-01-14T17:12:35Z basic block filter index is enabled at height 718643
2022-01-14T17:12:35Z basic block filter index thread exit
2022-01-14T17:12:35Z Opening LevelDB in /srv/slow/dot-bitcoin/indexes/coinstats/db
2022-01-14T17:12:36Z Opened LevelDB successfully
2022-01-14T17:12:36Z Using obfuscation key for /srv/slow/dot-bitcoin/indexes/coinstats/db: 0000000000000000
2022-01-14T17:12:36Z coinstatsindex thread start
2022-01-14T17:12:36Z coinstatsindex is enabled at height 718643
2022-01-14T17:12:36Z coinstatsindex thread exit
2022-01-14T17:12:36Z block tree size = 718667
2022-01-14T17:12:36Z nBestHeight = 718643
2022-01-14T17:12:36Z loadblk thread start
....
```
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- GUI-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/24076 | https://github.com/bitcoin/bitcoin/pull/24138 | aa83bbb1fe4807e3cd018ca3185f14ae2fd5120f | 7003b6ab24f6adfffd71d7b7d4182afde52ff859 | 2022-01-15T12:06:05Z | c++ | 2022-03-09T10:43:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,060 | ["test/functional/feature_init.py", "test/functional/test_framework/test_node.py"] | feature_init.py loadblk thread start']" does not partially match log: | https://cirrus-ci.com/task/6559642787512320?logs=ci#L5346
```
test 2022-01-13T11:41:43.569000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_init.py", line 81, in run_test
num_total_logs = node.wait_for_debug_log([terminate_line], ignore_case=True)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_node.py", line 458, in wait_for_debug_log
str(expected_msgs), print_log))
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_node.py", line 167, in _raise_assertion_error
raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected messages "['loadblk thread start']" does not partially match log:
- 2022-01-13T11:35:03.562576Z [txindex] [util/thread.cpp:17] [TraceThread] txindex thread start
- 2022-01-13T11:35:03.597525Z [txindex] [index/base.cpp:196] [ThreadSync] txindex is enabled at height 200
- 2022-01-13T11:35:03.657927Z [txindex] [util/thread.cpp:19] [TraceThread] txindex thread exit
- 2022-01-13T11:35:03.658008Z [addcon] [util/thread.cpp:17] [TraceThread] addcon thread start
- 2022-01-13T11:35:03.658038Z [net] [util/thread.cpp:17] [TraceThread] net thread start
- 2022-01-13T11:35:48.557835Z [scheduler] [net.h:866] [StartExtraBlockRelayPeers] net: enabling extra block-relay-only peers
- 2022-01-13T11:36:03.527809Z [scheduler] [random.cpp:523] [SeedPeriodic] Feeding 33048 bytes of dynamic environment data into RNG
- 2022-01-13T11:37:03.539139Z [scheduler] [random.cpp:523] [SeedPeriodic] Feeding 33046 bytes of dynamic environment data into RNG
- 2022-01-13T11:38:03.550191Z [scheduler] [random.cpp:523] [SeedPeriodic] Feeding 33056 bytes of dynamic environment data into RNG
- 2022-01-13T11:39:03.561817Z [scheduler] [random.cpp:523] [SeedPeriodic] Feeding 33042 bytes of dynamic environment data into RNG
- 2022-01-13T11:39:59.700827Z [net] [logging/timer.h:57] [Log] Enter: lock contention m_nodes_mutex, net.cpp:1256 started
- 2022-01-13T11:39:59.700882Z [net] [logging/timer.h:57] [Log] Enter: lock contention m_nodes_mutex, net.cpp:1256 completed (2μs)
- 2022-01-13T11:40:03.573567Z [scheduler] [random.cpp:523] [SeedPeriodic] Feeding 33036 bytes of dynamic environment data into RNG
- 2022-01-13T11:41:03.588927Z [scheduler] [random.cpp:523] [SeedPeriodic] Feeding 33036 bytes of dynamic environment data into RNG
test 2022-01-13T11:41:43.570000Z TestFramework (DEBUG): Closing down network thread
test 2022-01-13T11:41:43.621000Z TestFramework (INFO): Stopping nodes
test 2022-01-13T11:41:43.655000Z TestFramework.node0 (DEBUG): Stopping node
| https://github.com/bitcoin/bitcoin/issues/24060 | https://github.com/bitcoin/bitcoin/pull/24192 | 0ff13913287b3874e305535c78bc43b190217168 | 8f137e69caeb2a2ffe1aa930bd6fbc49cee4087c | 2022-01-13T16:20:24Z | c++ | 2022-01-31T17:05:01Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,056 | ["depends/hosts/mingw32.mk"] | build: Harmless "which: no x86_64-w64-mingw32-g++-posix…" message during depends download | Probably introduced in #22093.
```
Found macOS SDK at '/home/guest/sdk-path/Xcode-12.1-12A7403-extracted-SDK-with-libcxx-headers', using...
Checking that we can connect to the guix-daemon...
Hint: If this hangs, you may want to try turning your guix-daemon off and on
again.
make: Entering directory '/home/guest/bitcoin/depends'
make[1]: Entering directory '/home/guest/bitcoin/depends'
make[1]: Leaving directory '/home/guest/bitcoin/depends'
make: Leaving directory '/home/guest/bitcoin/depends'
make: Entering directory '/home/guest/bitcoin/depends'
make[1]: Entering directory '/home/guest/bitcoin/depends'
make[1]: Leaving directory '/home/guest/bitcoin/depends'
make: Leaving directory '/home/guest/bitcoin/depends'
make: Entering directory '/home/guest/bitcoin/depends'
make[1]: Entering directory '/home/guest/bitcoin/depends'
make[1]: Leaving directory '/home/guest/bitcoin/depends'
make: Leaving directory '/home/guest/bitcoin/depends'
make: Entering directory '/home/guest/bitcoin/depends'
make[1]: Entering directory '/home/guest/bitcoin/depends'
make[1]: Leaving directory '/home/guest/bitcoin/depends'
make: Leaving directory '/home/guest/bitcoin/depends'
make: Entering directory '/home/guest/bitcoin/depends'
make[1]: Entering directory '/home/guest/bitcoin/depends'
make[1]: Leaving directory '/home/guest/bitcoin/depends'
make: Leaving directory '/home/guest/bitcoin/depends'
make: Entering directory '/home/guest/bitcoin/depends'
make[1]: Entering directory '/home/guest/bitcoin/depends'
make[1]: Leaving directory '/home/guest/bitcoin/depends'
make: Leaving directory '/home/guest/bitcoin/depends'
make: Entering directory '/home/guest/bitcoin/depends'
make[1]: Entering directory '/home/guest/bitcoin/depends'
which: no x86_64-w64-mingw32-g++-posix in (/run/setuid-programs:/home/guest/.config/guix/current/bin:/home/guest/.guix-profile/bin:/home/guest/.guix-profile/sbin:/run/current-system/profile/bin:/run/current-system/profile/sbin)
make[1]: Leaving directory '/home/guest/bitcoin/depends'
make: Leaving directory '/home/guest/bitcoin/depends'
make: Entering directory '/home/guest/bitcoin/depends'
make[1]: Entering directory '/home/guest/bitcoin/depends'
make[1]: Leaving directory '/home/guest/bitcoin/depends'
make: Leaving directory '/home/guest/bitcoin/depends'
```
I think it's harmless (the `which` command tends to be noisy), but it did make me wonder. Clearly the cross-compiler is unnecessary when fetching the tarballs. | https://github.com/bitcoin/bitcoin/issues/24056 | https://github.com/bitcoin/bitcoin/pull/24156 | 219d728fcbde8c313940788838afa46c2fb88762 | 56a0fbf8365343d73cdff2b0a0e16542294d7577 | 2022-01-13T11:19:55Z | c++ | 2022-02-02T18:24:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,055 | ["contrib/guix/guix-build", "contrib/guix/manifest.scm"] | build: mingw GUIX build is failing on current master | Current HEAD commit `290ff5ef6d3886409e5e8688f7d28a4c8246c617` fails to build on guix (on a GUIX VM) here:
Build command
```bash
time ( SOURCES_PATH="${HOME}/sources" BASE_CACHE="${HOME}/base-cache" SDK_PATH="${HOME}/sdk-path" contrib/guix/guix-build ) 2>&1 | tee "${HOME}/build.log"
```
Last output:
```
INFO: Building 290ff5ef6d38 for platform triple x86_64-linux-gnu:
...using reference timestamp: 1642008478
...running at most 8 jobs
...from worktree directory: '/home/guest/bitcoin'
...bind-mounted in container to: '/bitcoin'
...in build directory: '/home/guest/bitcoin/guix-build-290ff5ef6d38/distsrc-290ff5ef6d38-x86_64-linux-gnu'
...bind-mounted in container to: '/distsrc-base/distsrc-290ff5ef6d38-x86_64-linux-gnu'
...outputting in: '/home/guest/bitcoin/guix-build-290ff5ef6d38/output/x86_64-linux-gnu'
...bind-mounted in container to: '/outdir-base/x86_64-linux-gnu'
Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
Computing Guix derivation for 'x86_64-linux'...
substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
substitute: updating substitutes from 'https://bordeaux.guix.gnu.org'... 100.0%
The following derivation will be built:
/gnu/store/cscw4gwah43lagqlljb19s26dhvlr6m6-profile.drv
building package cache...
builder for `/gnu/store/ni374dsml56hdgsqdg2zpa5qvl1mban4-guix-package-cache.drv' failed to produce output path `/gnu/store/bd7zd6fx23k3z18c73zb288yz8v6f5lb-guix-package-cache'
build of /gnu/store/ni374dsml56hdgsqdg2zpa5qvl1mban4-guix-package-cache.drv failed
View build log at '/var/log/guix/drvs/ni/374dsml56hdgsqdg2zpa5qvl1mban4-guix-package-cache.drv.bz2'.
note: keeping build directory `/tmp/guix-build-guix-package-cache.drv-1'
cannot build derivation `/gnu/store/cscw4gwah43lagqlljb19s26dhvlr6m6-profile.drv': 1 dependencies couldn't be built
guix time-machine: error: build of `/gnu/store/cscw4gwah43lagqlljb19s26dhvlr6m6-profile.drv' failed
```
Looking in the mentioned log:
```
$ bunzip2 < /var/log/guix/drvs/ni/374dsml56hdgsqdg2zpa5qvl1mban4-guix-package-cache.drv.bz2
(repl-version 0 1 1)
Generating package cache for '/gnu/store/h9app05jj4bc45fjp1hgld86ij6n8bv4-profile'...
(exception unbound-variable (value #f) (value "Unbound variable: ~S") (value (gnupg-2.2.32)) (value #f))
``` | https://github.com/bitcoin/bitcoin/issues/24055 | https://github.com/bitcoin/bitcoin/pull/24348 | 03c8c6937ee03787c36ce374c50201f85a0a6c61 | 97611921bed83ff4779cf4827bd0e51a321df4b5 | 2022-01-13T11:08:42Z | c++ | 2022-02-17T10:51:08Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,040 | ["contrib/guix/guix-build"] | guix time-machine: error: Git error: object not found - no match for id (fa17abf1af09570708daa28dd40ffbc932ebe25c) | https://github.com/bitcoin/bitcoin/pull/23778 pointed guix time machine to commit fa17abf1af09570708daa28dd40ffbc932ebe25c, which was working initially, but that commit seems to have disappeared upstream generating the following error
```
Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
guix time-machine: error: Git error: object not found - no match for id (fa17abf1af09570708daa28dd40ffbc932ebe25c)
```
| https://github.com/bitcoin/bitcoin/issues/24040 | https://github.com/bitcoin/bitcoin/pull/24042 | 1f7acfdcca3525edf3eba23535240d23ff0c4fc9 | 318c79e8096ce477561ef099835954b95a687685 | 2022-01-11T16:51:49Z | c++ | 2022-01-12T11:46:14Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,037 | ["configure.ac"] | Unclear error when pkg-config is not installed | While running `autogen.sh` on a newly intalled debian 11.2 system, I got the following error:
```
libtoolize: copying file 'build-aux/m4/lt~obsolete.m4'
configure.ac:16: error: possibly undefined macro: AC_MSG_ERROR
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
configure.ac:261: error: possibly undefined macro: AC_DEFINE
configure.ac:662: error: possibly undefined macro: AC_MSG_WARN
autoreconf: /usr/bin/autoconf failed with exit status: 1
```
The problem turned out to be that the `pkg-config` package was missing (`autoconf automake libtool` were installed). I could not guess this from the error message. It might make sense to add an explicit check to give a more specific error. | https://github.com/bitcoin/bitcoin/issues/24037 | https://github.com/bitcoin/bitcoin/pull/24048 | 290ff5ef6d3886409e5e8688f7d28a4c8246c617 | 31db3dd874dfbba88616c96a5767e2c9861d9a7a | 2022-01-11T15:17:49Z | c++ | 2022-01-13T10:23:39Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 24,036 | ["ci/test/00_setup_env_win64.sh", "configure.ac", "src/util/system.cpp"] | RFC: Boost Process requires boost::filesystem when compiling with mingw | Working on "Use std::filesystem. Remove Boost Filesystem & System" #20744, I found an unfortunate [pitfall](https://github.com/bitcoin/bitcoin/pull/20744#issuecomment-946046666) -- `boost/process.hpp` depends on `boost::filesystem` when cross-compiling for Windows. It happens in Guix environment as well.
The goal of this issue is to discuss and find a solution to get rid of `boost::filesystem`. | https://github.com/bitcoin/bitcoin/issues/24036 | https://github.com/bitcoin/bitcoin/pull/24065 | a541e5d5198893c3af0d2d1164a15082fb87e006 | 63fc2f5cce6a73bf845e6f1b51f786c4f860e65f | 2022-01-11T15:14:33Z | c++ | 2022-01-20T05:13:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,991 | ["test/functional/rpc_rawtransaction.py"] | rpc_rawtransaction.py issue | https://github.com/bitcoin/bitcoin/pull/22437/files#r779593489 | https://github.com/bitcoin/bitcoin/issues/23991 | https://github.com/bitcoin/bitcoin/pull/24113 | dd405add6ecff44bde3924ff7bfa4719b36f3596 | 2935bd9d67e5a60171e570bde54a212a81d034e9 | 2022-01-06T14:52:54Z | c++ | 2022-01-26T10:04:17Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,990 | ["test/functional/test_runner.py"] | test_runner.py issue | https://github.com/bitcoin/bitcoin/pull/23799/files?w=1#r779568858 | https://github.com/bitcoin/bitcoin/issues/23990 | https://github.com/bitcoin/bitcoin/pull/24195 | f7a36477a61b3719859ee4bb0795821c2aa6bd16 | 9392e1350cd8091677d728c72dd2ea842604227b | 2022-01-06T14:25:00Z | c++ | 2022-02-07T15:57:50Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,989 | ["test/functional/feature_init.py"] | feature_init.py issue | https://github.com/bitcoin/bitcoin/pull/23737#discussion_r779576100 | https://github.com/bitcoin/bitcoin/issues/23989 | https://github.com/bitcoin/bitcoin/pull/24039 | c561f2f06ed25f08f7776ac41aeb2999ebe79550 | db1f04fa8cdc6795f9e57b28724f694fb4466dde | 2022-01-06T14:24:27Z | c++ | 2022-01-12T08:29:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,988 | ["test/functional/p2p_disconnect_ban.py"] | p2p_disconnect_ban.py issue | https://github.com/bitcoin/bitcoin/pull/23879/files#r779577366 | https://github.com/bitcoin/bitcoin/issues/23988 | https://github.com/bitcoin/bitcoin/pull/23996 | 95833c012e14a747135fde584b1040f2dc0ae605 | be72ae25a81823d84e67a3abd5b3b773c92d3253 | 2022-01-06T14:23:46Z | c++ | 2022-01-06T23:49:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,967 | ["test/functional/feature_startupnotify.py"] | ci: failure in feature_startupnotify.py | Seen in https://cirrus-ci.com/task/6190790023053312?logs=functional_tests#L381 in the Win64 job:
```bash
node0 2022-01-03T17:55:20.863953Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\util\thread.cpp:17] [TraceThread] msghand thread start
test 2022-01-03T17:55:20.870000Z TestFramework.node0 (DEBUG): RPC successfully started
test 2022-01-03T17:55:20.870000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\test_framework\test_framework.py", line 132, in main
self.run_test()
File "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\test\functional\feature_startupnotify.py", line 29, in run_test
assert os.path.exists(tmpdir_file)
AssertionError
test 2022-01-03T17:55:20.870000Z TestFramework (DEBUG): Closing down network thread
``` | https://github.com/bitcoin/bitcoin/issues/23967 | https://github.com/bitcoin/bitcoin/pull/23979 | 3e5dd94c423bedfa8b70a1e00df632a22dbd4574 | 45ed459f95d33a83f0c31c0c29dd585a70ab79ed | 2022-01-04T01:36:56Z | c++ | 2022-01-05T08:16:41Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,852 | ["src/validation.cpp"] | -prune doesn't work during import | It appears that `-prune` is ignored during import (`-reindex`, or `-loadblock`).
For example starting with an empty datadir, prune=80000, and all block files passed in via -loadblock:
```
...
2021-12-23T12:49:44Z [loadblk] [node/blockstorage.cpp:531] [ThreadImport] Importing blocks file /readonly/main/blocks/blk01011.dat...
2021-12-23T12:49:44Z [loadblk] [node/blockstorage.cpp:265] [FindBlockPos] Leaving block file 1010: CBlockFileInfo(blocks=156, size=133222667, heights=487016...487360, time=2017-09-26...2017-09-28)
2021-12-23T12:49:45Z [loadblk] [flatfile.cpp:69] [Allocate] Pre-allocating up to position 0x1000000 in blk01011.dat
2021-12-23T12:49:45Z [loadblk] [logging/timer.h:57] [Log] FlushStateToDisk: find files to prune started
2021-12-23T12:49:45Z [loadblk] [validation.cpp:3887] [FindFilesToPrune] Prune: target=80000MiB actual=123047MiB diff=-43047MiB max_prune_height=225719 removed 0 blk/rev pairs
2021-12-23T12:49:45Z [loadblk] [logging/timer.h:57] [Log] FlushStateToDisk: find files to prune completed (0.05ms)
...
```
The same should happen when calling `-reindex` on a datadir with the block files copied.
So prune only works with IBD from the network? | https://github.com/bitcoin/bitcoin/issues/23852 | https://github.com/bitcoin/bitcoin/pull/24957 | 1d7f1ada48083d27adda47e04fd0311cc3cd6816 | aebcd18c654a1706954a9e2c9cbfe97dfe531357 | 2021-12-23T12:56:05Z | c++ | 2023-05-03T21:49:57Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,847 | ["test/functional/rpc_scantxoutset.py"] | ci: failure in rpc_scantxoutset.py | Seen in #23842. https://cirrus-ci.com/task/6388867203858432:
```bash
node0 2021-12-22T19:23:59.527668Z [http] [httpserver.cpp:238] [http_request_cb] Received a POST request for / from 127.0.0.1:47384
node0 2021-12-22T19:23:59.527720Z [httpworker.1] [rpc/request.cpp:174] [parse] ThreadRPCServer method=scantxoutset user=__cookie__
node0 2021-12-22T19:23:59.527890Z [httpworker.1] [logging/timer.h:57] [Log] FlushStateToDisk: write block and undo data to disk started
node0 2021-12-22T19:23:59.529826Z [httpworker.1] [logging/timer.h:57] [Log] FlushStateToDisk: write block and undo data to disk completed (1.92ms)
node0 2021-12-22T19:23:59.529841Z [httpworker.1] [logging/timer.h:57] [Log] FlushStateToDisk: write block index to disk started
node0 2021-12-22T19:23:59.530512Z [httpworker.1] [logging/timer.h:57] [Log] FlushStateToDisk: write block index to disk completed (0.66ms)
node0 2021-12-22T19:23:59.530530Z [httpworker.1] [logging/timer.h:57] [Log] FlushStateToDisk: write coins cache to disk (0 coins, 0kB) started
node0 2021-12-22T19:23:59.530557Z [httpworker.1] [txdb.cpp:161] [BatchWrite] Writing final batch of 0.00 MiB
node0 2021-12-22T19:23:59.530569Z [httpworker.1] [txdb.cpp:163] [BatchWrite] Committed 0 changed transaction outputs (out of 0) to coin database...
node0 2021-12-22T19:23:59.530578Z [httpworker.1] [logging/timer.h:57] [Log] FlushStateToDisk: write coins cache to disk (0 coins, 0kB) completed (0.04ms)
node0 2021-12-22T19:23:59.530591Z [httpworker.1] [validationinterface.cpp:244] [ChainStateFlushed] Enqueuing ChainStateFlushed: block hash=1da9728920712f0193810f287cb3b9ce59171e90d13b6dfe87094be9a6810176
test 2021-12-22T19:23:59.531000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/rpc_scantxoutset.py", line 72, in run_test
assert_equal(self.nodes[0].scantxoutset("start", [ "wpkh(" + pubk1 + ")", "wpkh(" + pubk2 + ")", "wpkh(" + pubk3 + ")"])['total_amount'], Decimal("0.004"))
File "/tmp/cirrus-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 50, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(0E-8 == 0.004)
node0 2021-12-22T19:23:59.531303Z [scheduler] [validationinterface.cpp:244] [operator()] ChainStateFlushed: block hash=1da9728920712f0193810f287cb3b9ce59171e90d13b6dfe87094be9a6810176
test 2021-12-22T19:23:59.532000Z TestFramework (DEBUG): Closing down network thread
test 2021-12-22T19:23:59.583000Z TestFramework (INFO): Stopping nodes
test 2021-12-22T19:23:59.583000Z TestFramework.node0 (DEBUG): Stopping node
``` | https://github.com/bitcoin/bitcoin/issues/23847 | https://github.com/bitcoin/bitcoin/pull/23858 | 010686198322c865fe78160e34d2e0ff43c73deb | 9bec5b80a0f3b134246497b06017bce790ec4444 | 2021-12-23T06:01:32Z | c++ | 2021-12-26T10:07:27Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,846 | ["src/fs.h", "src/wallet/load.cpp", "test/functional/wallet_multiwallet.py"] | No match for fs::path operator+= when compiling with Boost 1.78 | With Boost 1.78 (installed on my system), I get a compiler error:
```
./fs.h: In function ‘fs::path fs::operator+(fs::path, fs::path)’:
./fs.h:91:8: error: no match for ‘operator+=’ (operand types are ‘fs::path’ and ‘std::remove_reference<fs::path&>::type’ {aka ‘fs::path’})
91 | p1 += std::move(p2);
| ~~~^~~~~~~~~~~~~~~~
```
It appears that in Boost 1.78, `operator+=` became a template function, and our `path` class which subclasses `boost::filesystem::path::path` no longer has an `operator+=` which will work with it.
I also opened an issue with boost: https://github.com/boostorg/filesystem/issues/223 | https://github.com/bitcoin/bitcoin/issues/23846 | https://github.com/bitcoin/bitcoin/pull/24104 | 7102f7d6f3c4a3d08e22ae34a0b3460503a919cf | a541e5d5198893c3af0d2d1164a15082fb87e006 | 2021-12-23T05:48:48Z | c++ | 2022-01-20T05:06:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,800 | ["test/functional/p2p_timeouts.py"] | ci, error: p2p_timeouts.py failed | Cirrus CI threw the following error in https://github.com/bitcoin-core/gui/pull/471 .
The error is not reproducible on my machine, where the same test (p2p_timeouts.py ) runs successfully.
This test is very fast, but it took 40 seconds in the CI execution.
Link: https://cirrus-ci.com/task/5600553806856192?logs=ci#L7239
```
18/232 - p2p_timeouts.py failed, Duration: 41 s
stdout:
2021-12-16T22:09:14.936000Z TestFramework (INFO): Initializing test directory /tmp/cirrus-build-177014723/ci/scratch/test_runner/test_runner_₿_🏃_20211216_220356/p2p_timeouts_212
2021-12-16T22:09:55.666000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
def test_function():
if check_connected:
assert self.is_connected
return test_function_in()
'''
2021-12-16T22:09:55.666000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-build-177014723/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "/tmp/cirrus-build-177014723/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/p2p_timeouts.py", line 92, in run_test
no_send_node.wait_for_disconnect(timeout=1)
File "/tmp/cirrus-build-177014723/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/p2p.py", line 461, in wait_for_disconnect
self.wait_until(test_function, timeout=timeout, check_connected=False)
File "/tmp/cirrus-build-177014723/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/p2p.py", line 453, in wait_until
wait_until_helper(test_function, timeout=timeout, lock=p2p_lock, timeout_factor=self.timeout_factor)
File "/tmp/cirrus-build-177014723/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 269, in wait_until_helper
raise AssertionError("Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
def test_function():
if check_connected:
assert self.is_connected
return test_function_in()
''' not true after 40.0 seconds
``` | https://github.com/bitcoin/bitcoin/issues/23800 | https://github.com/bitcoin/bitcoin/pull/23812 | 70d6a09f5ccdc18f251bc07e5884bc85004057a1 | 1c41fb918155930a27807a09fd93168e214e8169 | 2021-12-16T23:45:45Z | c++ | 2021-12-20T08:13:20Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,775 | ["src/test/system_tests.cpp"] | Fatal Error: test_bitcoin.exe --run_test=system_tests Built in Visual Studio Community 2019 | OS: Microsoft Windows 10 Pro
Version: 10.0.19042 Build 19042
Compiler: Microsoft Visual Studio Community 2019
Version 16.11.7
VisualStudio.16.Release/16.11.7+31911.196
Microsoft .NET Framework
Version 4.8.04084
Running into a fatal error while launching test_bitcoin.exe from the “x64 Native Tools Command Prompt for VS 2019”. All unit tests pass except system_tests.cpp
Followed the work around found [here](https://bitcoin.stackexchange.com/questions/105167/bitcoin-core-unit-test-failure-system-tests-cpp-line-48-boost-auto-testrun-c) however it did work for me
**Expected behavior**
*** No errors detected
**Actual behavior**
Unit Test failure:
Using test_bitcoin.exe –run_test=system_tests
Running 2 test cases...
unknown location(0): fatal error: in "system_tests/run_command": struct boost::process::process_error: CreateProcess failed: The system cannot find the file specified.
C:\Users\Admin\Documents\GitHub\bitcoin\src\test\system_tests.cpp(57): last checkpoint
*** 1 failure is detected in the test module "Bitcoin Core Test Suite"
**To reproduce**
After successfully building bitcoin, using the Visual Studio [instructions](https://github.com/bitcoin/bitcoin/blob/master/build_msvc/README.md), and using the recommended qt installation found [here](https://github.com/sipsorcery/qt_win_binary).
Launch test_bitcoin.exe from the command prompt it said “Running 480 test cases…”
It gets to about 70% progress and then raises the following error:
unknown location(0): fatal error: in "system_tests/run_command": struct boost::process::process_error: CreateProcess failed: The system cannot find the file specified.
C:\Users\Admin\Documents\GitHub\bitcoin\src\test\system_tests.cpp(57): last checkpoint
**System information**
Bitcoin Core version v22.99.0-unk (release build)
Microsoft Windows 10 Pro
Version: 10.0.19042 Build 19042
Processor Intel(R) Core(TM) i9-10980HK CPU @ 2.40GHz 3.10 GHz
Installed RAM 32.0 GB (31.8 GB usable)
System type 64-bit operating system, x64-based processor
Got the following log using test_bitcoin.exe --log_level=all --run_test=system_tests -- DEBUG_LOG_OUT
C:\Users\Admin\Documents\GitHub\bitcoin\src\test\system_tests.cpp(20): Entering test suite "system_tests"
C:\Users\Admin\Documents\GitHub\bitcoin\src\test\system_tests.cpp(24): Entering test case "dummy"
2021-12-14T18:15:23Z Seed: Setting random seed for current tests to RANDOM_CTX_SEED=6dc868e8ff757d5e7085cea6f6549936c30016d1bb4d5103f4a9996ae8422ba4
2021-12-14T18:15:23.779590Z [C:\Users\Admin\Documents\GitHub\bitcoin\src\init\common.cpp:165] [LogPackageVersion] Bitcoin Core version v22.99.0-unk (release build)
2021-12-14T18:15:23.780011Z [C:\Users\Admin\Documents\GitHub\bitcoin\src\init.cpp:908] [AppInitParameterInteraction] Assuming ancestors of block 00000000000000000008a89e854d57e5667df88f1cdef6fde2fbca1de5b639ad have valid signatures.
2021-12-14T18:15:23.780033Z [C:\Users\Admin\Documents\GitHub\bitcoin\src\init.cpp:921] [AppInitParameterInteraction] Setting nMinimumChainWork=00000000000000000000000000000000000000001fa4663bbbe19f82de910280
2021-12-14T18:15:23.793752Z [C:\Users\Admin\Documents\GitHub\bitcoin\src\script\sigcache.cpp:102] [InitSignatureCache] Using 16 MiB out of 32/2 requested for signature cache, able to store 524288 elements
2021-12-14T18:15:23.802791Z [C:\Users\Admin\Documents\GitHub\bitcoin\src\validation.cpp:1336] [InitScriptExecutionCache] Using 16 MiB out of 32/2 requested for script execution cache, able to store 524288 elements
C:/Users/Luis/Documents/GitHub/bitcoin/src/test/system_tests.cpp(26): info: check true has passed
C:\Users\Admin\Documents\GitHub\bitcoin\src\test\system_tests.cpp(24): Leaving test case "dummy"; testing time: 27542us
C:\Users\Admin\Documents\GitHub\bitcoin\src\test\system_tests.cpp(53): Entering test case "run_command"
2021-12-14T18:15:23.807676Z [C:\Users\Admin\Documents\GitHub\bitcoin\src\test\util\setup_common.cpp:68] [Seed] Seed: Setting random seed for current tests to RANDOM_CTX_SEED=6dc868e8ff757d5e7085cea6f6549936c30016d1bb4d5103f4a9996ae8422ba4
2021-12-14T18:15:23.807847Z [C:\Users\Admin\Documents\GitHub\bitcoin\src\init\common.cpp:165] [LogPackageVersion] Bitcoin Core version v22.99.0-unk (release build)
2021-12-14T18:15:23.808225Z [C:\Users\Admin\Documents\GitHub\bitcoin\src\init.cpp:908] [AppInitParameterInteraction] Assuming ancestors of block 00000000000000000008a89e854d57e5667df88f1cdef6fde2fbca1de5b639ad have valid signatures.
2021-12-14T18:15:23.808246Z [C:\Users\Admin\Documents\GitHub\bitcoin\src\init.cpp:921] [AppInitParameterInteraction] Setting nMinimumChainWork=00000000000000000000000000000000000000001fa4663bbbe19f82de910280
2021-12-14T18:15:23.813864Z [C:\Users\Admin\Documents\GitHub\bitcoin\src\script\sigcache.cpp:102] [InitSignatureCache] Using 16 MiB out of 32/2 requested for signature cache, able to store 524288 elements
2021-12-14T18:15:23.814885Z [C:\Users\Admin\Documents\GitHub\bitcoin\src\validation.cpp:1336] [InitScriptExecutionCache] Using 16 MiB out of 32/2 requested for script execution cache, able to store 524288 elements
C:/Users/Luis/Documents/GitHub/bitcoin/src/test/system_tests.cpp(57): info: check result.isNull() has passed
unknown location(0): fatal error: in "system_tests/run_command": struct boost::process::process_error: CreateProcess failed: The system cannot find the file specified.
C:\Users\Admin\Documents\GitHub\bitcoin\src\test\system_tests.cpp(57): last checkpoint
C:\Users\Admin\Documents\GitHub\bitcoin\src\test\system_tests.cpp(53): Leaving test case "run_command"; testing time: 15247us
C:\Users\Admin\Documents\GitHub\bitcoin\src\test\system_tests.cpp(20): Leaving test suite "system_tests"; testing time: 45447us | https://github.com/bitcoin/bitcoin/issues/23775 | https://github.com/bitcoin/bitcoin/pull/23781 | 98a2ddcd6ed01a38cd0dad7c1abc7023a60d3fd0 | 1220af5e6d1072ea306f6ecaaa7effe3d386c379 | 2021-12-14T19:00:15Z | c++ | 2021-12-18T12:54:59Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,739 | ["test/functional/p2p_timeouts.py"] | Issue in p2p_timeouts: no_send_node.wait_for_disconnect(timeout=1) | CI
https://cirrus-ci.com/task/5687505285545984
Locally
```
$ test/functional/p2p_timeouts.py
2021-12-10T23:40:36.399000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_hpui5kz3
2021-12-10T23:40:38.232000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
def test_function():
if check_connected:
assert self.is_connected
return test_function_in()
'''
2021-12-10T23:40:38.232000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/home/jon/projects/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "/home/jon/projects/bitcoin/bitcoin/test/functional/p2p_timeouts.py", line 92, in run_test
no_send_node.wait_for_disconnect(timeout=1)
File "/home/jon/projects/bitcoin/bitcoin/test/functional/test_framework/p2p.py", line 461, in wait_for_disconnect
self.wait_until(test_function, timeout=timeout, check_connected=False)
File "/home/jon/projects/bitcoin/bitcoin/test/functional/test_framework/p2p.py", line 453, in wait_until
wait_until_helper(test_function, timeout=timeout, lock=p2p_lock, timeout_factor=self.timeout_factor)
File "/home/jon/projects/bitcoin/bitcoin/test/functional/test_framework/util.py", line 269, in wait_until_helper
raise AssertionError("Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
def test_function():
if check_connected:
assert self.is_connected
return test_function_in()
''' not true after 1.0 seconds
```
Appears to be related to the merge of #19499. Relevant diff:
```diff
--- a/test/functional/p2p_timeouts.py
+++ b/test/functional/p2p_timeouts.py
with self.nodes[0].assert_debug_log(expected_msgs=expected_timeout_logs):
- sleep(3)
- # By now, we waited a total of 5 seconds. Off-by-two for two
- # reasons:
- # * The internal precision is one second
- # * Account for network delay
- assert not no_verack_node.is_connected
- assert not no_version_node.is_connectedZ
- assert not no_send_node.is_connected
+ self.mock_forward(2)
+ no_verack_node.wait_for_disconnect(timeout=1)
+ no_version_node.wait_for_disconnect(timeout=1)
+ no_send_node.wait_for_disconnect(timeout=1)
``` | https://github.com/bitcoin/bitcoin/issues/23739 | https://github.com/bitcoin/bitcoin/pull/23740 | faea4c9d2b7162422d1598a7f489ba4cdf9c6919 | 90deb9f980d02b9ca4000a78baa2beb15a5f1bbd | 2021-12-11T00:22:09Z | c++ | 2021-12-11T08:33:17Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,710 | ["test/functional/test_framework/ripemd160.py", "test/functional/test_framework/script.py"] | test: Openssl removed ripemd160 | Openssl removed ripemd160, see https://github.com/openssl/openssl/issues/16994
Thus, our tests fail. See below for excerpt.
Not sure how to fix this, so leaving an issue here.
```
Running Unit Tests for Test Framework Modules
..........
----------------------------------------------------------------------
Ran 10 tests in 0.812s
OK
4/225 - feature_block.py failed, Duration: 0 s
stdout:
stderr:
Traceback (most recent call last):
File "/usr/lib/python3.9/hashlib.py", line 160, in __hash_new
return _hashlib.new(name, data, **kwargs)
ValueError: [digital envelope routines] initialization error
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_block.py", line 54, in <module>
from data import invalid_txs
File "/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/data/invalid_txs.py", line 57, in <module>
basic_p2sh = script_to_p2sh_script(CScript([OP_0]))
File "/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/script_util.py", line 74, in script_to_p2sh_script
return scripthash_to_p2sh_script(hash160(script))
File "/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/script.py", line 35, in hash160
return hashlib.new('ripemd160', sha256(s)).digest()
File "/usr/lib/python3.9/hashlib.py", line 166, in __hash_new
return __get_builtin_constructor(name)(data)
File "/usr/lib/python3.9/hashlib.py", line 123, in __get_builtin_constructor
raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type ripemd160
TEST | STATUS | DURATION
wallet_backup.py --descriptors | ✓ Passed | 109 s
wallet_hd.py --descriptors | ✓ Passed | 92 s
wallet_hd.py --legacy-wallet | ✓ Passed | 125 s
feature_block.py | ✖ Failed | 0 s
ALL | ✖ Failed | 326 s (accumulated)
Runtime: 125 s
| https://github.com/bitcoin/bitcoin/issues/23710 | https://github.com/bitcoin/bitcoin/pull/23716 | 1b76b18f8a0dfe5d0d5d69791b51d78672c1d0d2 | 68ca8677e039a60b9f51938987d784cb58a3c995 | 2021-12-08T16:28:46Z | c++ | 2021-12-09T08:18:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,684 | ["test/functional/interface_bitcoin_cli.py", "test/functional/test_runner.py"] | test: AssertionError: not(59.99992540 == 59.999928) in interface_bitcoin_cli | ERROR: type should be string, got "https://cirrus-ci.com/task/4605959170424832?logs=ci#L3654\r\n\r\n```\r\n test 2021-12-06T12:29:34.522000Z TestFramework (ERROR): Assertion failed \r\n Traceback (most recent call last):\r\n File \"/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/test_framework/test_framework.py\", line 132, in main\r\n self.run_test()\r\n File \"/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/interface_bitcoin_cli.py\", line 176, in run_test\r\n assert_equal(Decimal(cli_get_info['Balance']), amounts[i])\r\n File \"/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-apple-darwin19/test/functional/test_framework/util.py\", line 50, in assert_equal\r\n raise AssertionError(\"not(%s)\" % \" == \".join(str(arg) for arg in (thing1, thing2) + args))\r\n AssertionError: not(59.99992540 == 59.999928)" | https://github.com/bitcoin/bitcoin/issues/23684 | https://github.com/bitcoin/bitcoin/pull/23686 | 6223e550c5566c97e3e7a8e305890a38c7b8e444 | 877f3aa85c392d50bdbf35ca0e2cc29eaf9f94b2 | 2021-12-06T12:37:16Z | c++ | 2021-12-07T07:51:05Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,655 | ["ci/test/00_setup_env_i686_multiprocess.sh", "contrib/devtools/security-check.py", "contrib/devtools/symbol-check.py", "contrib/guix/manifest.scm"] | "UNDEFINED is not supported!" output of `symbol-check.py` for riscv64-linux-gnu | On master (26a1147ce56083d7aa820ac115c16b01e47d911c):
```
$ env HOSTS=riscv64-linux-gnu ./contrib/guix/guix-build
...
Running symbol and dynamic library checks...
UNDEFINED is not supported!
UNDEFINED is not supported!
UNDEFINED is not supported!
UNDEFINED is not supported!
UNDEFINED is not supported!
UNDEFINED is not supported!
UNDEFINED is not supported!
...
```
Build is successful, but messages quoted above are unclear. | https://github.com/bitcoin/bitcoin/issues/23655 | https://github.com/bitcoin/bitcoin/pull/24561 | 896beca831d944610a9fd9610cca9191a34d5953 | bdbabc50ba6c87ded97ea2bbacd3605c59cd12d0 | 2021-12-02T18:17:47Z | c++ | 2022-03-30T09:10:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,646 | ["test/functional/feature_init.py", "test/functional/test_framework/test_node.py"] | test: timeouts in feature_init.py | Seen this multiple times this on master:
https://cirrus-ci.com/task/5568647696482304?logs=ci#L4671
https://cirrus-ci.com/task/5005697743060992?logs=ci#L4821
https://cirrus-ci.com/task/4507850702585856?logs=ci#L4968
```bash
node0 2021-12-01T19:22:13.787335Z [scheduler] [random.cpp:523] [SeedPeriodic] Feeding 31922 bytes of dynamic environment data into RNG
node0 2021-12-01T19:23:13.801695Z [scheduler] [random.cpp:523] [SeedPeriodic] Feeding 31928 bytes of dynamic environment data into RNG
test 2021-12-01T19:24:12.774000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_node.py", line 512, in assert_start_raises_init_error
ret = self.process.wait(timeout=self.rpc_timeout)
File "/usr/lib/python3.8/subprocess.py", line 1083, in wait
return self._wait(timeout=timeout)
File "/usr/lib/python3.8/subprocess.py", line 1798, in _wait
raise TimeoutExpired(self.args, timeout)
subprocess.TimeoutExpired: Command '['bitcoin-node', '-datadir=/tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20211201_182901/feature_init_38/node0', '-logtimemicros', '-debug', '-debugexclude=libevent', '-debugexclude=leveldb', '-uacomment=testnode0', '-logthreadnames', '-logsourcelocations']' timed out after 2400 seconds
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_init.py", line 168, in run_test
node.assert_start_raises_init_error(
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_node.py", line 542, in assert_start_raises_init_error
self._raise_assertion_error(assert_msg)
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_node.py", line 167, in _raise_assertion_error
raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] bitcoind should have exited within 2400s with expected error Error opening block database.
``` | https://github.com/bitcoin/bitcoin/issues/23646 | https://github.com/bitcoin/bitcoin/pull/23737 | 31f385c1380bef5079ad4161bbad8dadf578b4d0 | d69af93223c4008c3255f7e4848ff05d78c514fa | 2021-12-02T01:17:38Z | c++ | 2022-01-03T07:51:09Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,645 | ["src/wallet/rpc/coins.cpp"] | getreceivedby[address, label] rpc performance proposal | Hi,
**Problem**
The refactoring done in #17579 introduced some performance degradation for the rpc commands `getreceivedbyaddress` and `getreceivedbylabel`, which prevented an upgrade to versions >=0.21.0 for us without custom patches that revert this PR. The requests take notably longer to complete. This is especially painful when using big wallet files or issuing a large number of requests in a short period of time.
I know that the foremost goal of Bitcoin Core may not be performance, but given that these rpc commands are some of the most prominent ones needed when interacting with wallets via rpc, I propose to do some changes here.
**Analysis**
Currently, a set of search address is generated from the scriptpubkeys and then these addresses are compared against all addresses in the wallet, which means for each transaction in the wallet, the time consuming conversion from scriptpubkey to address needs to happen (in `ExtractDestination(...)`).
**Solution Proposal**
Given that the majority of use cases comprises searching for a small set of addresses in a large set of addresses (the wallet), it makes more sense to rather create a set of scriptpubkeys from the search addresses and then compare each scriptpubkey in the wallet against this set. This is similar to how it was done before #17579, except that we now use a set, which means a search for multiple addresses (corresponding to a single label) stays possible and the refactoring can be more or less kept as is.
I may not have time soon to implement this properly, but what do you think (conceptually)? | https://github.com/bitcoin/bitcoin/issues/23645 | https://github.com/bitcoin/bitcoin/pull/23662 | 07cb4dee5d12657e9cf33c442678e9a1cd2cec4a | 187504b038cc1151e5813ac56b79c603439d352c | 2021-12-01T19:33:32Z | c++ | 2022-05-16T18:35:42Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,641 | ["test/functional/data/rpc_decodescript.json", "test/functional/rpc_decodescript.py"] | Write more decodescript tests | There are some test cases mentioned in https://github.com/bitcoin/bitcoin/pull/23486#issue-1051148887
Currently they need to be manually executed with bitcoin-cli. It would be nice to integrate them into the existing decodescript functional test.
I recommend to check the full response as opposed to just a partial response, as it is being done currently in the functional test.
#### Useful skills:
* Python3
* Background in our functional tests
* Basic background in our RPC interface
* Basic bitcoin script background
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/23641 | https://github.com/bitcoin/bitcoin/pull/23672 | 42b35f17d5473cdcfbdac5fc8d7d4867ac3d41f4 | d20d6ac545159fb98bd9ac828678ddf20f5d016d | 2021-12-01T09:14:01Z | c++ | 2021-12-06T09:09:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,610 | ["src/wallet/scriptpubkeyman.cpp", "test/functional/wallet_upgradewallet.py"] | Calling `upgradewallet` on a legacy wallet causes Bitcoin Core to crash | I have 2 legacy wallets and on both if I run `upgradewallet` it will cause bitcoin core to crash. This should just return me an error string
Currenl result from `getwalletinfo`:
```
{
"walletname": "Wallet",
"walletversion": 169900,
"format": "bdb",
"balance": 0.00000000,
"unconfirmed_balance": 0.00000000,
"immature_balance": 0.00000000,
"txcount": 80,
"keypoololdest": 1613078825,
"keypoolsize": 941,
"keypoolsize_hd_internal": 941,
"paytxfee": 0.00000000,
"private_keys_enabled": false,
"avoid_reuse": true,
"scanning": false,
"descriptors": false
}
``` | https://github.com/bitcoin/bitcoin/issues/23610 | https://github.com/bitcoin/bitcoin/pull/24365 | c7da61dcc37411f7d6dc848cef1ae997703bd37b | 159f89c118645c0f9e23e453f01cede84abac795 | 2021-11-26T23:40:05Z | c++ | 2022-02-28T12:15:11Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,563 | ["test/functional/test_framework/test_framework.py", "test/functional/test_runner.py"] | test: failure in test/functional/feature_rbf.py with `--without-bdb` | master @ cf06c9b35c30512ede8f7dc323340bd9cfb2d0b9
```bash
./autogen.sh
./configure --without-bdb
make -j9
./test/functional/feature_rbf.py
2021-11-21T09:25:15.472000Z TestFramework (INFO): Initializing test directory /var/folders/z2/cn877pxd3czdfh47mfkmbwgm0000gn/T/bitcoin_func_test_dzacmtp6
2021-11-21T09:25:16.098000Z TestFramework (INFO): Running test simple doublespend...
2021-11-21T09:25:16.104000Z TestFramework (INFO): Running test doublespend chain...
2021-11-21T09:25:16.152000Z TestFramework (INFO): Running test doublespend tree...
2021-11-21T09:25:16.770000Z TestFramework (INFO): Running test replacement feeperkb...
2021-11-21T09:25:16.841000Z TestFramework (INFO): Running test spends of conflicting outputs...
2021-11-21T09:25:16.860000Z TestFramework (INFO): Running test new unconfirmed inputs...
2021-11-21T09:25:16.869000Z TestFramework (INFO): Running test too many replacements...
2021-11-21T09:25:16.959000Z TestFramework (INFO): Running test opt-in...
2021-11-21T09:25:16.978000Z TestFramework (INFO): Running test RPC...
2021-11-21T09:25:16.999000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
File "/Users/michael/github/fanquake-bitcoin/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "./test/functional/feature_rbf.py", line 79, in run_test
self.test_rpc()
File "./test/functional/feature_rbf.py", line 544, in test_rpc
frawtx2a = self.nodes[0].fundrawtransaction(rawtx2, {"replaceable": True})
File "/Users/michael/github/fanquake-bitcoin/test/functional/test_framework/coverage.py", line 49, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/Users/michael/github/fanquake-bitcoin/test/functional/test_framework/authproxy.py", line 144, in __call__
raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Insufficient funds (-4)
2021-11-21T09:25:17.056000Z TestFramework (INFO): Stopping nodes
2021-11-21T09:25:17.216000Z TestFramework (WARNING): Not cleaning up dir /var/folders/z2/cn877pxd3czdfh47mfkmbwgm0000gn/T/bitcoin_func_test_dzacmtp6
2021-11-21T09:25:17.216000Z TestFramework (ERROR): Test failed. Test logging available at /var/folders/z2/cn877pxd3czdfh47mfkmbwgm0000gn/T/bitcoin_func_test_dzacmtp6/test_framework.log
``` | https://github.com/bitcoin/bitcoin/issues/23563 | https://github.com/bitcoin/bitcoin/pull/23608 | 4aa06f944768bd81022ef29096a1021433cfa482 | 4f8b1f8759301d2553183e14f72444a0f1d80725 | 2021-11-21T09:27:25Z | c++ | 2021-11-28T01:51:45Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 23,562 | ["test/functional/test_runner.py", "test/functional/wallet_transactiontime_rescan.py"] | test: wallet_transactiontime_rescan.py failure with `--without-bdb` | master @ cf06c9b35c30512ede8f7dc323340bd9cfb2d0b9
```bash
./autogen.sh
./configure --without-bdb
make -j9
./test/functional/wallet_transactiontime_rescan.py
2021-11-21T09:09:22.057000Z TestFramework (INFO): Initializing test directory /var/folders/z2/cn877pxd3czdfh47mfkmbwgm0000gn/T/bitcoin_func_test_vilmgmza
2021-11-21T09:09:22.950000Z TestFramework (INFO): Prepare nodes and wallet
2021-11-21T09:09:23.018000Z TestFramework (INFO): Start transactions
2021-11-21T09:09:24.212000Z TestFramework (INFO): Send 10 btc to user
2021-11-21T09:09:24.472000Z TestFramework (INFO): Send 5 btc to user
2021-11-21T09:09:25.834000Z TestFramework (INFO): Send 1 btc to user
2021-11-21T09:09:27.166000Z TestFramework (INFO): Check user's final balance and transaction count
2021-11-21T09:09:27.168000Z TestFramework (INFO): Check transaction times
2021-11-21T09:09:27.168000Z TestFramework (INFO): Restore user wallet on another node without rescan
2021-11-21T09:09:27.191000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/Users/michael/github/fanquake-bitcoin/test/functional/test_framework/test_framework.py", line 132, in main
self.run_test()
File "./test/functional/wallet_transactiontime_rescan.py", line 134, in run_test
assert_equal(restorewo_wallet.getbalance(), 0)
File "/Users/michael/github/fanquake-bitcoin/test/functional/test_framework/util.py", line 50, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(1.00000000 == 0)
2021-11-21T09:09:27.246000Z TestFramework (INFO): Stopping nodes
2021-11-21T09:09:27.454000Z TestFramework (WARNING): Not cleaning up dir /var/folders/z2/cn877pxd3czdfh47mfkmbwgm0000gn/T/bitcoin_func_test_vilmgmza
``` | https://github.com/bitcoin/bitcoin/issues/23562 | https://github.com/bitcoin/bitcoin/pull/23596 | 22feb7fee9accf1c9f11b896dbfbbe828a1bd056 | 32d9f3770add88339fdd125f7671351de506b1af | 2021-11-21T09:24:56Z | c++ | 2021-12-06T11:28:25Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.