status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,216 | ["test/functional/interface_zmq.py"] | Failure in test/functional/interface_zmq.py | I don't think this can be my bug, as I pushed a comment only change to my PR and then got a test failure:
https://cirrus-ci.com/task/5869686954917888?command=ci#L5219
```
test 2021-02-16T19:08:03.550000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 127, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/interface_zmq.py", line 82, in run_test
self.test_sequence()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/interface_zmq.py", line 277, in test_sequence
assert_equal((self.nodes[0].getbestblockhash(), "C", None), seq.receive_sequence())
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 50, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(('5d2daef0df4c3f8af7d33f350253d3c5b3eab0154803f0f9dff228512ce6ced3', 'C', None) == ('3bd98765bf07cc72a921a5c6fad95b13dac7c80100f0b295f29681e0e3c6e856', 'C', None))
```
The PR in question needs a rebase anyway now, so I'll try that and see if this goes away. | https://github.com/bitcoin/bitcoin/issues/21216 | https://github.com/bitcoin/bitcoin/pull/21310 | 72e6979b31baa48b82e713b63a896aebf75ae8c8 | cfce346508f1f7513a0cfa2cea7d7f8336d01c6b | 2021-02-17T13:37:34Z | c++ | 2021-03-02T10:30:17Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,212 | ["ci/test/00_setup_env_win64.sh", "src/test/fuzz/fuzz.cpp"] | build: Windows fuzz binary fails to link when cross compiling | I've seen this mentioned twice, but we don't have an issue open to track. When fixed, `--disable-fuzz-binary` should be remove from the [Windows CI config](https://github.com/bitcoin/bitcoin/blob/master/ci/test/00_setup_env_win64.sh#L16).
To reproduce:
```bash
make -C depends/ HOST=x86_64-w64-mingw32 NO_QT=1 NO_WALLET=1 NO_UPNP=1 NO_ZMQ=1 -j8
./autogen.sh
./configure --prefix=/home/ubuntu/bitcoin/depends/x86_64-w64-mingw32 --disable-wallet --with-gui=no --disable-bench --with-utils=no --with-daemon=no
make -j8
....
/usr/bin/x86_64-w64-mingw32-ld: /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/../../../../x86_64-w64-mingw32/lib/libmingw32.a(lib64_libmingw32_a-crt0_c.o): in function `main':
./build/x86_64-w64-mingw32-x86_64-w64-mingw32-crt/./mingw-w64-crt/crt/crt0_c.c:18: undefined reference to `WinMain'
collect2: error: ld returned 1 exit status
```
Verbose link output:
```bash
/bin/bash ../libtool --tag=CXX --preserve-dup-deps --mode=link x86_64-w64-mingw32-g++ -std=c++17 -fstack-reuse=none -Wstack-protector -fstack-protector-all -fcf-protection=full -fPIE -pipe -O2 -fno-extended-identifiers -Wl,--dynamicbase -Wl,--nxcompat -Wl,--high-entropy-va -pie -all-static -pthread -lpthread -L/home/ubuntu/bitcoin/depends/x86_64-w64-mingw32/lib -Wl,--major-subsystem-version -Wl,6 -Wl,--minor-subsystem-version -Wl,1 -o test/fuzz/fuzz.exe test/fuzz/fuzz-addition_overflow.o test/fuzz/fuzz-addrdb.o test/fuzz/fuzz-addrman.o test/fuzz/fuzz-asmap.o test/fuzz/fuzz-asmap_direct.o test/fuzz/fuzz-autofile.o test/fuzz/fuzz-banman.o test/fuzz/fuzz-base_encode_decode.o test/fuzz/fuzz-bech32.o test/fuzz/fuzz-block.o test/fuzz/fuzz-block_header.o test/fuzz/fuzz-blockfilter.o test/fuzz/fuzz-bloom_filter.o test/fuzz/fuzz-buffered_file.o test/fuzz/fuzz-chain.o test/fuzz/fuzz-checkqueue.o test/fuzz/fuzz-coins_view.o test/fuzz/fuzz-connman.o test/fuzz/fuzz-crypto.o test/fuzz/fuzz-crypto_aes256.o test/fuzz/fuzz-crypto_aes256cbc.o test/fuzz/fuzz-crypto_chacha20.o test/fuzz/fuzz-crypto_chacha20_poly1305_aead.o test/fuzz/fuzz-crypto_common.o test/fuzz/fuzz-crypto_hkdf_hmac_sha256_l32.o test/fuzz/fuzz-crypto_poly1305.o test/fuzz/fuzz-cuckoocache.o test/fuzz/fuzz-data_stream.o test/fuzz/fuzz-decode_tx.o test/fuzz/fuzz-descriptor_parse.o test/fuzz/fuzz-deserialize.o test/fuzz/fuzz-eval_script.o test/fuzz/fuzz-fee_rate.o test/fuzz/fuzz-fees.o test/fuzz/fuzz-flatfile.o test/fuzz/fuzz-float.o test/fuzz/fuzz-golomb_rice.o test/fuzz/fuzz-hex.o test/fuzz/fuzz-http_request.o test/fuzz/fuzz-integer.o test/fuzz/fuzz-key.o test/fuzz/fuzz-key_io.o test/fuzz/fuzz-kitchen_sink.o test/fuzz/fuzz-load_external_block_file.o test/fuzz/fuzz-locale.o test/fuzz/fuzz-merkleblock.o test/fuzz/fuzz-message.o test/fuzz/fuzz-muhash.o test/fuzz/fuzz-multiplication_overflow.o test/fuzz/fuzz-net.o test/fuzz/fuzz-net_permissions.o test/fuzz/fuzz-netaddress.o test/fuzz/fuzz-node_eviction.o test/fuzz/fuzz-p2p_transport_deserializer.o test/fuzz/fuzz-parse_hd_keypath.o test/fuzz/fuzz-parse_iso8601.o test/fuzz/fuzz-parse_numbers.o test/fuzz/fuzz-parse_script.o test/fuzz/fuzz-parse_univalue.o test/fuzz/fuzz-policy_estimator.o test/fuzz/fuzz-policy_estimator_io.o test/fuzz/fuzz-pow.o test/fuzz/fuzz-prevector.o test/fuzz/fuzz-primitives_transaction.o test/fuzz/fuzz-process_message.o test/fuzz/fuzz-process_messages.o test/fuzz/fuzz-protocol.o test/fuzz/fuzz-psbt.o test/fuzz/fuzz-random.o test/fuzz/fuzz-rbf.o test/fuzz/fuzz-rolling_bloom_filter.o test/fuzz/fuzz-script.o test/fuzz/fuzz-script_assets_test_minimizer.o test/fuzz/fuzz-script_bitcoin_consensus.o test/fuzz/fuzz-script_descriptor_cache.o test/fuzz/fuzz-script_flags.o test/fuzz/fuzz-script_interpreter.o test/fuzz/fuzz-script_ops.o test/fuzz/fuzz-script_sigcache.o test/fuzz/fuzz-script_sign.o test/fuzz/fuzz-scriptnum_ops.o test/fuzz/fuzz-secp256k1_ec_seckey_import_export_der.o test/fuzz/fuzz-secp256k1_ecdsa_signature_parse_der_lax.o test/fuzz/fuzz-signature_checker.o test/fuzz/fuzz-signet.o test/fuzz/fuzz-span.o test/fuzz/fuzz-spanparsing.o test/fuzz/fuzz-string.o test/fuzz/fuzz-strprintf.o test/fuzz/fuzz-system.o test/fuzz/fuzz-timedata.o test/fuzz/fuzz-transaction.o test/fuzz/fuzz-tx_in.o test/fuzz/fuzz-tx_out.o test/fuzz/fuzz-txrequest.o libbitcoin_server.a libbitcoin_common.a libbitcoin_util.a libtest_util.a libbitcoin_server.a libbitcoin_common.a libbitcoin_util.a crypto/libbitcoin_crypto_base.a libtest_fuzz.a libbitcoin_server.a libbitcoin_common.a libbitcoin_util.a crypto/libbitcoin_crypto_base.a libbitcoin_consensus.a crypto/libbitcoin_crypto_base.a crypto/libbitcoin_crypto_sse41.a crypto/libbitcoin_crypto_avx2.a crypto/libbitcoin_crypto_shani.a libbitcoin_cli.a univalue/libunivalue.la leveldb/libleveldb.a crc32c/libcrc32c.a crc32c/libcrc32c_sse42.a -L/home/ubuntu/bitcoin/depends/x86_64-w64-mingw32/lib -lboost_system-mt-s-x64 -lboost_filesystem-mt-s-x64 leveldb/libmemenv.a secp256k1/libsecp256k1.la -L/home/ubuntu/bitcoin/depends/x86_64-w64-mingw32/lib -levent -lws2_32 -lminiupnpc libbitcoin_wallet.a -L/home/ubuntu/bitcoin/depends/x86_64-w64-mingw32/lib -lsqlite3 -lpthread -ldb_cxx-4.8 libbitcoin_zmq.a -L/home/ubuntu/bitcoin/depends/x86_64-w64-mingw32/lib -lzmq -liphlpapi -lpthread -lssp -liphlpapi -lshlwapi -lws2_32 -ladvapi32 -luuid -loleaut32 -lole32 -lcomctl32 -lshell32 -lwinmm -lcomdlg32 -lgdi32 -luser32 -lkernel32
libtool: link: x86_64-w64-mingw32-g++ -std=c++17 -fstack-reuse=none -Wstack-protector -fstack-protector-all -fcf-protection=full -fPIE -pipe -O2 -fno-extended-identifiers -Wl,--dynamicbase -Wl,--nxcompat -Wl,--high-entropy-va -pie -static -pthread -Wl,--major-subsystem-version -Wl,6 -Wl,--minor-subsystem-version -Wl,1 -o test/fuzz/fuzz.exe test/fuzz/fuzz-addition_overflow.o test/fuzz/fuzz-addrdb.o test/fuzz/fuzz-addrman.o test/fuzz/fuzz-asmap.o test/fuzz/fuzz-asmap_direct.o test/fuzz/fuzz-autofile.o test/fuzz/fuzz-banman.o test/fuzz/fuzz-base_encode_decode.o test/fuzz/fuzz-bech32.o test/fuzz/fuzz-block.o test/fuzz/fuzz-block_header.o test/fuzz/fuzz-blockfilter.o test/fuzz/fuzz-bloom_filter.o test/fuzz/fuzz-buffered_file.o test/fuzz/fuzz-chain.o test/fuzz/fuzz-checkqueue.o test/fuzz/fuzz-coins_view.o test/fuzz/fuzz-connman.o test/fuzz/fuzz-crypto.o test/fuzz/fuzz-crypto_aes256.o test/fuzz/fuzz-crypto_aes256cbc.o test/fuzz/fuzz-crypto_chacha20.o test/fuzz/fuzz-crypto_chacha20_poly1305_aead.o test/fuzz/fuzz-crypto_common.o test/fuzz/fuzz-crypto_hkdf_hmac_sha256_l32.o test/fuzz/fuzz-crypto_poly1305.o test/fuzz/fuzz-cuckoocache.o test/fuzz/fuzz-data_stream.o test/fuzz/fuzz-decode_tx.o test/fuzz/fuzz-descriptor_parse.o test/fuzz/fuzz-deserialize.o test/fuzz/fuzz-eval_script.o test/fuzz/fuzz-fee_rate.o test/fuzz/fuzz-fees.o test/fuzz/fuzz-flatfile.o test/fuzz/fuzz-float.o test/fuzz/fuzz-golomb_rice.o test/fuzz/fuzz-hex.o test/fuzz/fuzz-http_request.o test/fuzz/fuzz-integer.o test/fuzz/fuzz-key.o test/fuzz/fuzz-key_io.o test/fuzz/fuzz-kitchen_sink.o test/fuzz/fuzz-load_external_block_file.o test/fuzz/fuzz-locale.o test/fuzz/fuzz-merkleblock.o test/fuzz/fuzz-message.o test/fuzz/fuzz-muhash.o test/fuzz/fuzz-multiplication_overflow.o test/fuzz/fuzz-net.o test/fuzz/fuzz-net_permissions.o test/fuzz/fuzz-netaddress.o test/fuzz/fuzz-node_eviction.o test/fuzz/fuzz-p2p_transport_deserializer.o test/fuzz/fuzz-parse_hd_keypath.o test/fuzz/fuzz-parse_iso8601.o test/fuzz/fuzz-parse_numbers.o test/fuzz/fuzz-parse_script.o test/fuzz/fuzz-parse_univalue.o test/fuzz/fuzz-policy_estimator.o test/fuzz/fuzz-policy_estimator_io.o test/fuzz/fuzz-pow.o test/fuzz/fuzz-prevector.o test/fuzz/fuzz-primitives_transaction.o test/fuzz/fuzz-process_message.o test/fuzz/fuzz-process_messages.o test/fuzz/fuzz-protocol.o test/fuzz/fuzz-psbt.o test/fuzz/fuzz-random.o test/fuzz/fuzz-rbf.o test/fuzz/fuzz-rolling_bloom_filter.o test/fuzz/fuzz-script.o test/fuzz/fuzz-script_assets_test_minimizer.o test/fuzz/fuzz-script_bitcoin_consensus.o test/fuzz/fuzz-script_descriptor_cache.o test/fuzz/fuzz-script_flags.o test/fuzz/fuzz-script_interpreter.o test/fuzz/fuzz-script_ops.o test/fuzz/fuzz-script_sigcache.o test/fuzz/fuzz-script_sign.o test/fuzz/fuzz-scriptnum_ops.o test/fuzz/fuzz-secp256k1_ec_seckey_import_export_der.o test/fuzz/fuzz-secp256k1_ecdsa_signature_parse_der_lax.o test/fuzz/fuzz-signature_checker.o test/fuzz/fuzz-signet.o test/fuzz/fuzz-span.o test/fuzz/fuzz-spanparsing.o test/fuzz/fuzz-string.o test/fuzz/fuzz-strprintf.o test/fuzz/fuzz-system.o test/fuzz/fuzz-timedata.o test/fuzz/fuzz-transaction.o test/fuzz/fuzz-tx_in.o test/fuzz/fuzz-tx_out.o test/fuzz/fuzz-txrequest.o -lpthread -L/home/ubuntu/bitcoin/depends/x86_64-w64-mingw32/lib libbitcoin_server.a libbitcoin_common.a libbitcoin_util.a libtest_util.a libbitcoin_server.a libbitcoin_common.a libbitcoin_util.a crypto/libbitcoin_crypto_base.a libtest_fuzz.a libbitcoin_server.a libbitcoin_common.a libbitcoin_util.a crypto/libbitcoin_crypto_base.a libbitcoin_consensus.a crypto/libbitcoin_crypto_base.a crypto/libbitcoin_crypto_sse41.a crypto/libbitcoin_crypto_avx2.a crypto/libbitcoin_crypto_shani.a libbitcoin_cli.a univalue/.libs/libunivalue.a leveldb/libleveldb.a crc32c/libcrc32c.a crc32c/libcrc32c_sse42.a -lboost_system-mt-s-x64 -lboost_filesystem-mt-s-x64 leveldb/libmemenv.a secp256k1/.libs/libsecp256k1.a -levent -lws2_32 -lminiupnpc libbitcoin_wallet.a -lsqlite3 -lpthread -ldb_cxx-4.8 libbitcoin_zmq.a -lzmq -liphlpapi -lpthread -lssp -liphlpapi -lshlwapi -lws2_32 -ladvapi32 -luuid -loleaut32 -lole32 -lcomctl32 -lshell32 -lwinmm -lcomdlg32 -lgdi32 -luser32 -lkernel32 -pthread
/usr/bin/x86_64-w64-mingw32-ld: /usr/lib/gcc/x86_64-w64-mingw32/9.3-posix/../../../../x86_64-w64-mingw32/lib/libmingw32.a(lib64_libmingw32_a-crt0_c.o): in function `main':
./build/x86_64-w64-mingw32-x86_64-w64-mingw32-crt/./mingw-w64-crt/crt/crt0_c.c:18: undefined reference to `WinMain'
collect2: error: ld returned 1 exit status
``` | https://github.com/bitcoin/bitcoin/issues/21212 | https://github.com/bitcoin/bitcoin/pull/21226 | f1c2f619a68733ad79658288cc9a3b866679bf08 | 6a680a6236e07c93f28514fe05fbb64a29cb2ec8 | 2021-02-17T12:00:57Z | c++ | 2021-02-19T10:30:41Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,194 | ["depends/packages/qt.mk"] | guix: Make it arch agnostic | It would be nice if guix was arch agnostic, so different archs can be used to get the same binary.
I tried running guix on amd64 and arm64, for the target `bitcoin-62cc2180afc1-powerpc64le-linux-gnu.tar.gz` and only got a few bits difference:
```diff
--- ./bitcoin-arm64/bin/bitcoin-cli
+++ ./bitcoin-amd64/bin/bitcoin-cli
├── readelf --wide --decompress --hex-dump=.gnu_debuglink {}
│ @@ -1,5 +1,5 @@
│
│ Hex dump of section '.gnu_debuglink':
│ 0x00000000 62697463 6f696e2d 636c692e 64626700 bitcoin-cli.dbg.
│ - 0x00000010 13a837f9 ..7.
│ + 0x00000010 08b973c6 ..s.
| https://github.com/bitcoin/bitcoin/issues/21194 | https://github.com/bitcoin/bitcoin/pull/25817 | bf3f05f41d27a6be3730432aaa7e22e443f7cafa | aca0200e9408d802ce68c323ee6edeb93699ecb3 | 2021-02-16T11:25:56Z | c++ | 2022-08-13T12:41:18Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,151 | ["src/script/interpreter.h", "src/script/sign.cpp", "test/functional/rpc_signrawtransaction.py"] | signrawtransactionwithwallet fails with signed non-wallet inputs with many witness stack elements | I'm seeing a very strange behavior with `signrawtransactionwithwallet` when I provide signed non-wallet inputs.
The following sample transaction (regtest) is a lightning HTLC transaction with added `bitcoind` wallet inputs/outputs to bump the fee:
```
020000000001027697c418d3c56138f1ea0469026d081705290bd0317ad9a133319fa7b4ac59b10200000000010000001cd5376d42e12bad24911ae73b13c40b530a18c3da34de8d16fcf356bf2e32180000000000fdffffff02bb080000000000002200209357506c5a4a2df7c685481aad0302a3ccfe44c4e41122e33818861a37e2e6cccdfbea020000000016001487c7624537496328484f590d04a805f0c2a213e30500483045022100aef712b8d806077872e894343f917473497841b6d859bb7cf20473597353e7d8022030c39a0dc43b742ad0b746e8968b763e3053ec1001bbae4f5368d15d20d1152683483045022100a71dba3a0ed7d005c5e99b3a3e603026e60cd2708e7590162892bae9391965ba0220179d15465950863401956d0d4bbad0f413ce465b111dc71fe511d9bbf4200d0f0120b27cf03ab42eb16a475e289df7878d8c36d9465ba6b4f22ce1d21ef217e4f3d88d76a914c333ee02e6633f9bce0281ae0dc09e29b1b2761f8763ac672103bcdf028d4e53f7fbddb817091a60118b1d2fb7ab8cbab4b14ebeb981450d6ff77c8201208763a91487520d9fc7939063f7244ce842e4a5d2507d93d188527c21036df69837ccd9b8b353bdd37a8c616e3ea094ffee4c9512fec902ae8250ffb9f952ae6775022701b175ac6851b275680000000000
{
"txid": "d922b3e02d77e7c522fcf46a308996df764dc61ef708a5702dc3dce6c2f58882",
"hash": "1f558b7fd77d1339c48772f6ef12a0bf6cdbc05e371c6871d885afc89e6a5e3c",
"version": 2,
"size": 492,
"vsize": 248,
"weight": 990,
"locktime": 0,
"vin": [
{
"txid": "b159acb4a79f3133a1d97a31d00b290517086d026904eaf13861c5d318c49776",
"vout": 2,
"scriptSig": {
"asm": "",
"hex": ""
},
"txinwitness": [
"",
"3045022100aef712b8d806077872e894343f917473497841b6d859bb7cf20473597353e7d8022030c39a0dc43b742ad0b746e8968b763e3053ec1001bbae4f5368d15d20d1152683",
"3045022100a71dba3a0ed7d005c5e99b3a3e603026e60cd2708e7590162892bae9391965ba0220179d15465950863401956d0d4bbad0f413ce465b111dc71fe511d9bbf4200d0f01",
"b27cf03ab42eb16a475e289df7878d8c36d9465ba6b4f22ce1d21ef217e4f3d8",
"76a914c333ee02e6633f9bce0281ae0dc09e29b1b2761f8763ac672103bcdf028d4e53f7fbddb817091a60118b1d2fb7ab8cbab4b14ebeb981450d6ff77c8201208763a91487520d9fc7939063f7244ce842e4a5d2507d93d188527c21036df69837ccd9b8b353bdd37a8c616e3ea094ffee4c9512fec902ae8250ffb9f952ae6775022701b175ac6851b27568"
],
"sequence": 1
},
{
"txid": "18322ebf56f3fc168dde34dac3180a530bc4133be71a9124ad2be1426d37d51c",
"vout": 0,
"scriptSig": {
"asm": "",
"hex": ""
},
"sequence": 4294967293
}
],
"vout": [
{
"value": 0.00002235,
"n": 0,
"scriptPubKey": {
"asm": "0 9357506c5a4a2df7c685481aad0302a3ccfe44c4e41122e33818861a37e2e6cc",
"hex": "00209357506c5a4a2df7c685481aad0302a3ccfe44c4e41122e33818861a37e2e6cc",
"reqSigs": 1,
"type": "witness_v0_scripthash",
"addresses": [
"bcrt1qjdt4qmz6fgkl0359fqd26qcz50x0u3xyusgj9cecrzrp5dlzumxq6sxuyz"
]
}
},
{
"value": 0.48954317,
"n": 1,
"scriptPubKey": {
"asm": "0 87c7624537496328484f590d04a805f0c2a213e3",
"hex": "001487c7624537496328484f590d04a805f0c2a213e3",
"reqSigs": 1,
"type": "witness_v0_keyhash",
"addresses": [
"bcrt1qslrky3fhf93jsjz0tyxsf2q97rp2yylr3fd72n"
]
}
}
]
}
```
Notice that the first input (the non-wallet one) has a stack with 5 elements (the first of which is empty). It is correctly signed and passes script validation.
When I send this transaction to `signrawtransactionwithwallet`, `bitcoind` returns the following error: `Unable to sign input, invalid stack size (possibly missing key) (code: -1)` referencing the non-wallet input.
But it does correctly sign the wallet input and returns the following transaction:
```
020000000001027697c418d3c56138f1ea0469026d081705290bd0317ad9a133319fa7b4ac59b10200000000010000001cd5376d42e12bad24911ae73b13c40b530a18c3da34de8d16fcf356bf2e32180000000000fdffffff02bb080000000000002200209357506c5a4a2df7c685481aad0302a3ccfe44c4e41122e33818861a37e2e6cccdfbea020000000016001487c7624537496328484f590d04a805f0c2a213e3018d76a914c333ee02e6633f9bce0281ae0dc09e29b1b2761f8763ac672103bcdf028d4e53f7fbddb817091a60118b1d2fb7ab8cbab4b14ebeb981450d6ff77c8201208763a91487520d9fc7939063f7244ce842e4a5d2507d93d188527c21036df69837ccd9b8b353bdd37a8c616e3ea094ffee4c9512fec902ae8250ffb9f952ae6775022701b175ac6851b275680247304402201566b009b4e392ca16d0e5658e7fd2257e511e8974f198fb8ac265473d492949022001c9b41d261f8eacc19c41f179aa36a449200fe66abb8f3aab45c5d49e280f2901210271f8ed45eddce4cb9f990998f1d28f91fe4f747a7d67900b5382484276ae4bfd00000000
{
"txid": "d922b3e02d77e7c522fcf46a308996df764dc61ef708a5702dc3dce6c2f58882",
"hash": "06722d22306472337f1229ad9642c3530f161b7ef3d54e061acf7ca09fb8ed76",
"version": 2,
"size": 418,
"vsize": 229,
"weight": 916,
"locktime": 0,
"vin": [
{
"txid": "b159acb4a79f3133a1d97a31d00b290517086d026904eaf13861c5d318c49776",
"vout": 2,
"scriptSig": {
"asm": "",
"hex": ""
},
"txinwitness": [
"76a914c333ee02e6633f9bce0281ae0dc09e29b1b2761f8763ac672103bcdf028d4e53f7fbddb817091a60118b1d2fb7ab8cbab4b14ebeb981450d6ff77c8201208763a91487520d9fc7939063f7244ce842e4a5d2507d93d188527c21036df69837ccd9b8b353bdd37a8c616e3ea094ffee4c9512fec902ae8250ffb9f952ae6775022701b175ac6851b27568"
],
"sequence": 1
},
{
"txid": "18322ebf56f3fc168dde34dac3180a530bc4133be71a9124ad2be1426d37d51c",
"vout": 0,
"scriptSig": {
"asm": "",
"hex": ""
},
"txinwitness": [
"304402201566b009b4e392ca16d0e5658e7fd2257e511e8974f198fb8ac265473d492949022001c9b41d261f8eacc19c41f179aa36a449200fe66abb8f3aab45c5d49e280f2901",
"0271f8ed45eddce4cb9f990998f1d28f91fe4f747a7d67900b5382484276ae4bfd"
],
"sequence": 4294967293
}
],
"vout": [
{
"value": 0.00002235,
"n": 0,
"scriptPubKey": {
"asm": "0 9357506c5a4a2df7c685481aad0302a3ccfe44c4e41122e33818861a37e2e6cc",
"hex": "00209357506c5a4a2df7c685481aad0302a3ccfe44c4e41122e33818861a37e2e6cc",
"reqSigs": 1,
"type": "witness_v0_scripthash",
"addresses": [
"bcrt1qjdt4qmz6fgkl0359fqd26qcz50x0u3xyusgj9cecrzrp5dlzumxq6sxuyz"
]
}
},
{
"value": 0.48954317,
"n": 1,
"scriptPubKey": {
"asm": "0 87c7624537496328484f590d04a805f0c2a213e3",
"hex": "001487c7624537496328484f590d04a805f0c2a213e3",
"reqSigs": 1,
"type": "witness_v0_keyhash",
"addresses": [
"bcrt1qslrky3fhf93jsjz0tyxsf2q97rp2yylr3fd72n"
]
}
}
]
}
```
**Notice how it drops all witness stack elements from the non-wallet input except the last one**: this seems to be the culprit. If I ignore `bitcoind`'s error and restore the witness stack of the non-wallet input, the transaction becomes valid and can be correctly published.
I tested this with Bitcoin Core 0.20.1 and 0.21.0, let me know if you want me to test against other versions. | https://github.com/bitcoin/bitcoin/issues/21151 | https://github.com/bitcoin/bitcoin/pull/21166 | 9be7fe4849310884294669b019dd8300f69bc334 | 245a5cd5604a869776e5e274d554295ff1890ccb | 2021-02-11T08:26:21Z | c++ | 2021-04-07T04:47:41Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,136 | ["src/wallet/db.cpp"] | UI Hangs when running as std user | <!-- Describe the issue -->
When accessing the Open Wallet from the File Menu, the UI hangs. Looking at the debug.log in the data directory, there are thousands of ListWalletDir: ACcess is Denied E:\$Recycle.bin\s-1-5-18 events.
The data directory is set to be the root of a USB drive mapped to the E: letter.
Client is started as std user.
**Expected behavior**
Expected behaviour is for the client UI to handle the access issue and continue, possibly noting the requirement to have further permissions. Even when the client is started as administrator, the same hang occurs. It appears the client data directory should be set to a folder and not the root of a drive.
**Actual behavior**
Any attempt to access the open wallet menu gets stuck.
**To reproduce**
Install bitcoin core 0.21.0 x64
Set data directory to the root of a drive in Windows
Let sync or not, hover over the Open Wallet menu
Program UI hangs
**System information**
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
bitcoin core 0.21.0 x64
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
Windows 10 x64 PC, SSD drive, Core i9 9980xe
<!-- GUI-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell? -->
Windows 10 20H2 Build 19042.789
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
thousands of lines of the below. The debug.log is 370MB.
05:32:18Z ListWalletDir: Access is denied E:\System Volume Information
2021-02-10T05:32:18Z ListWalletDir: Access is denied E:\System Volume Information
2021-02-10T05:32:18Z ListWalletDir: Access is denied E:\System Volume Information | https://github.com/bitcoin/bitcoin/issues/21136 | https://github.com/bitcoin/bitcoin/pull/21907 | 386ba92e836387302eb2005b816dd9f972cdb5bc | a31a1ceec721c8b7fb78e657e572c7a621d4d37e | 2021-02-10T05:48:46Z | c++ | 2021-05-13T09:09:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,133 | ["doc/release-notes-123.md", "doc/shared-libraries.md", "src/script/bitcoinconsensus.cpp", "src/script/bitcoinconsensus.h", "src/test/fuzz/script_bitcoin_consensus.cpp", "src/test/script_tests.cpp"] | Add Taproot support to libconsensus | In preparation for the potential Taproot soft fork, libconsensus should be updated to support verifying Taproot scripts.
There are two changes I see as necessary:
- Add a VERIFY_TAPROOT flag
- Change the API to support passing in spent outputs (bitcoinconsensus_verify_script_with_spent_outputs?) | https://github.com/bitcoin/bitcoin/issues/21133 | https://github.com/bitcoin/bitcoin/pull/28539 | 08ea835220baa88a0e226eff90f66bbae3eb7a0f | 90f7d8a7f904ded464b4c03da139ac876e58fbc5 | 2021-02-10T00:52:41Z | c++ | 2023-10-16T16:59:39Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,122 | [".cirrus.yml", "ci/test/00_setup_env_win64.sh", "ci/test/wrap-wine.sh"] | ci: migrate Windows cross compile to Ubuntu Focal | We'd like to move the Windows cross compile in the CI to use Ubuntu Focal, to match the gitian descriptors that were just migrated to Focal.
I failed to do this as part of #21112. One issue seems to be using `wine64`, see logs [here](https://github.com/bitcoin/bitcoin/pull/21112#issuecomment-775638717). | https://github.com/bitcoin/bitcoin/issues/21122 | https://github.com/bitcoin/bitcoin/pull/21126 | d202054675c91b353d832c9c038247384a39030f | 09530b0255aba083bf168322a95b89cc387e616f | 2021-02-09T07:10:13Z | c++ | 2021-02-10T01:40:44Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,104 | ["src/wallet/rpcwallet.cpp", "test/functional/wallet_watchonly.py"] | Watchonly descriptor wallets classifying funds as `mine`, are "spendable" | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
**Expected behavior**
I'd expect funds in a watchonly wallet to be shown as "watchonly", be unspendable.
**Actual behavior**
Funds are shown as "mine" in getbalances, can be "spent" (sendtoaddress completes without error, however transaction is unspent and fails to enter mempool. Balance is incorrectly decremented)
**To reproduce**
Make a watchonly descriptor wallet.
```
bitcoin-cli createwallet w2 true true "" true true false
```
Load up a descriptor that's got some funds on it.
```
$ bitcoin-cli -rpcwallet=w2 importdescriptors '[{"desc":"wpkh(tpubD6NzVbkrYhZ4Wh1z2cvkzQsM12k9kvyMMrGXi7rdk5eyUYUFND1qhB1zEZ3pJwSSSGLYsKfZLKNvs4L7oqNb8vJj3zJTvxMRCKWsNhX9JXQ/*)#86kup682", "timestamp":"now","active":true,"range":100}]'
```
See the balance.
```
$ bitcoin-cli -rpcwallet=w2 getbalances
{
"mine": {
"trusted": 3.00000000,
"untrusted_pending": 3.00000000,
"immature": 0.00000000,
"used": 0.00000000
}
}
```
Spend the balance.
```
$ bitcoin-cli -rpcwallet=w2 sendtoaddress bcrt1qnk09yy5ayyhwvfydg2x58zwy443pjx5uesg9gw 3.0 "" "" true
90bce182f476376e6cf3552e234c686ce5bfee4d47739081f5cba90de374156b
```
See the balance update.
```
$ bitcoin-cli -rpcwallet=w2 getbalances
{
"mine": {
"trusted": 0.00000000,
"untrusted_pending": 0.00000000,
"immature": 0.00000000,
"used": 3.00000000
}
}
```
Not in the mempool though
```
$ bitcoin-cli getmempoolentry 90bce182f476376e6cf3552e234c686ce5bfee4d47739081f5cba90de374156b
error code: -5
error message:
Transaction not in mempool
```
**System information**
Bitcoin Core version v0.21.0
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- GUI-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/21104 | https://github.com/bitcoin/bitcoin/pull/21201 | b805dbb0b9c90dadef0424e5b3bf86ac308e103e | 3a2d5bfeb38e7a5fca88f9b185d58266589d0452 | 2021-02-07T19:30:27Z | c++ | 2021-02-19T01:00:48Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,092 | [".editorconfig"] | Feature: Add EditorConfig | ### Motivation
Developers are supposed to follow [Coding style](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#coding-style-general). However, [from time to time](https://github.com/bitcoin/bitcoin/pull/21075#discussion_r570125634) a PR is created and then its author is asked to change tabs to spaces, for example.
Introducing an `.editorconfig` file can mitigate these formatting issues:
### User story
A contributor wants to create a new PR. She clones Bitcoin Core repo, opens her editor, the editor loads `.editorconfig` rules and writes her patch with correct formatting rules. Less Coding Style issues is then discovered in the PR review process and thus less CI runs are needed.
### What is EditorConfig file?
https://editorconfig.org provides very well and concise explanation:
> What is EditorConfig?
> EditorConfig helps maintain consistent coding styles for multiple developers working on the same project across various editors and IDEs. The EditorConfig project consists of a file format for defining coding styles and a collection of text editor plugins that enable editors to read the file format and adhere to defined styles. EditorConfig files are easily readable and they work nicely with version control systems.
### Support
`.editorconfig` is supported in many IDEs and text editors. Sometimes, the support is out-of-box and sometimes a plugin is needed. However, for example, VS Code detects `.editorconfig` presence and automatically offers you to install the missing plugin.
See https://editorconfig.org/#pre-installed for details on support. Visual Studio is supported, VS Code and IntelliJ IDEA are supported and many others.
### My editor does not support `.editorconfig`
Then nothing really changes for you.
### `.editorconfig` vs `.clang-format`
As explained [here](https://devblogs.microsoft.com/cppblog/clangformat-support-in-visual-studio-2017-15-7-preview-1/):
> Note that Visual Studio also supports EditorConfig, which works in a similar way. ClangFormat, however, has a [much larger variety of style options](https://clang.llvm.org/docs/ClangFormatStyleOptions.html) than EditorConfig, including some very C++ specific rules that can be set, and it is already used by C++ developers today.
Having both `.editorconfig` and `.clang-format` in a project, may not always work correctly though, I think. As some editors may have a plugin for `.editorconfig` and a plugin for `clang-formatter` which may not work correctly in unison.
### Proposed `.editorconfig`
This proposal is based on [Developer Notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#coding-style-general):
```yaml
# This is the top-most EditorConfig file.
root = true
# For all files.
[*]
charset = utf-8
end_of_line = lf
insert_final_newline = false
# Shell scripts
[*.sh]
indent_size = 4
indent_style = space
trim_trailing_whitespace = true
# C++ files
[*.{h,cpp}]
indent_size = 4
indent_style = space
trim_trailing_whitespace = true
# Python files
[*.py]
indent_size = 4
indent_style = space
trim_trailing_whitespace = true
# Makefiles
[Makefile,*.am]
indent_style = tab
trim_trailing_whitespace = true
# Markdown files
[*.md]
trim_trailing_whitespace = true
# .cirrus.yml, .appveyor.yml, .fuzzbuzz.yml, etc.
[*.yml]
indent_style = space
indent_size = 2
trim_trailing_whitespace = true
```
Note that the syntax can be much shorter but it is not my goal here, I prefer clarity at this point.
So what is this specifying:
* `charset`: Use `UTF-8` in all files.
* `end_of_line`: Line endings should be `LF` by default in all files.
* `insert_final_newline`: Do not add a blank line at the end of a file by default.
And then there are rules for various types of files.
The rules does not cover everything. One can see that there actually many different file types (meaning, unique file extensions) using this simple PowerShell script:
```powershell
Get-ChildItem -Recurse | % {$_.Extension.ToLower()} | sort | unique
```
with the following output:
```
.1
.ac
.adoc
.am
.bash-completion
.bat
.bmp
.c
.cc
.cert
.cfg
.clang_complete
.clang-format
.cmake
.cmd
.cnf
.com
.conf
.cpp
.css
.csv
.doxyfile
.dtd
.empty
.exe
.exp
.gci
.gitattributes
.github
.gitignore
.gitmodules
.guess
.h
.hex
.hpp
.html
.icns
.ico
.idb
.ilk
.in
.include
.ini
.init
.ipp
.jam
.js
.json
.lastbuildstate
.lib
.list
.log
.m
.m4
.md
.mk
.mm
.moc
.obj
.openrc
.openrcconf
.patch
.pc
.pdb
.pl
.plist
.png
.po
.pro
.py
.python-version
.qbk
.qm
.qml
.qrc
.raw
.rb
.rc
.recipe
.res
.s
.sage
.sass
.scm
.scss
.service
.sgml
.sh
.sln
.spec
.sub
.supp
.svg
.targets
.td
.tlog
.ts
.tx
.txt
.ui
.user
.v2
.vcxproj
.verbatim
.vscode
.xml
.xpm
.xsl
.y
.yapf
.yml
.yy
```
What do you think? | https://github.com/bitcoin/bitcoin/issues/21092 | https://github.com/bitcoin/bitcoin/pull/21123 | cda914228a56d614ceba090e222d7a7d81970c12 | b3dda0af0ea0e63edea7a8ffebadf7602cf79359 | 2021-02-06T12:57:07Z | c++ | 2021-02-10T13:30:58Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 21,070 | ["src/init.cpp"] | RPC: conf var rpcallowip=::/0 stopped working when upgrading to 0.21 | **TL;DR**: When upgrading from `Bitcoin Core 0.20.1` to `Bitcoin Core 0.21.0`, a downstream application using the HTTP JSON-RPC API started getting HTTP 403 "Forbidden".
Turns out it is because I have `rpcallowip=::/0` in `bitcoin.conf` which used to work but does not anymore.
As a workaround, `rpcallowip=0.0.0.0/0` works.
-----
I run bitcoind in docker container1, and some application using the HTTP JSON-RPC API of bitcoind is in docker container2. They are on the same "docker network".
In `bitcoin.conf` I have:
```
rpcauth=<...>
rpcbind=0.0.0.0:8332
rpcallowip=::/0
```
(bitcoind RPC is not actually exposed to the public internet; it is up to the docker layer and above to ensure this.)
The application in container2 is connecting through HTTP accessing an URL such as `http://user:[email protected]:8332/`.
This setup used to work when running `Bitcoin Core 0.20.1` in container1.
It no longer works with `Bitcoin Core 0.21.0`.
-----
If I change my `bitcoin.conf` as below, it starts working again using 0.21:
```
rpcauth=<...>
rpcbind=0.0.0.0:8332
rpcallowip=0.0.0.0/0
```
So `rpcallowip=::/0` used to work but does not anymore; `rpcallowip=0.0.0.0/0` works.
-----
Easy way to test:
`curl --data-binary '{"jsonrpc":"1.0","id":"curltext","method":"getblockchaininfo","params":[]}' -H 'content-type:text/plain;' http://user:[email protected]:8332/` | https://github.com/bitcoin/bitcoin/issues/21070 | https://github.com/bitcoin/bitcoin/pull/27480 | 74d66359dabd21f9e6ffc48c47f3588000171712 | 5ce200dda23752cf8bf6dccb23aea4b23f1653ae | 2021-02-03T03:03:35Z | c++ | 2023-08-24T20:31:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,982 | ["build_msvc/libbitcoin_qt/libbitcoin_qt.vcxproj"] | appveyor is failing | The appveyor windows build is failing on master https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/37382340
Failing tests can be ignored for now. Resetting them won't help.
The issue slipped in because appveyor was accidentally disabled in the gui repo (now enabled).
```
libbitcoin_qt.lib(overviewpage.obj) : error LNK2001: unresolved external symbol "public: virtual struct QMetaObject const * __cdecl TransactionOverviewWidget::metaObject(void)const " (?metaObject@TransactionOverviewWidget@@UEBAPEBUQMetaObject@@XZ) [C:\projects\bitcoin\build_msvc\test_bitcoin-qt\test_bitcoin-qt.vcxproj]
libbitcoin_qt.lib(overviewpage.obj) : error LNK2001: unresolved external symbol "public: virtual void * __cdecl TransactionOverviewWidget::qt_metacast(char const *)" (?qt_metacast@TransactionOverviewWidget@@UEAAPEAXPEBD@Z) [C:\projects\bitcoin\build_msvc\test_bitcoin-qt\test_bitcoin-qt.vcxproj]
libbitcoin_qt.lib(overviewpage.obj) : error LNK2001: unresolved external symbol "public: virtual int __cdecl TransactionOverviewWidget::qt_metacall(enum QMetaObject::Call,int,void * *)" (?qt_metacall@TransactionOverviewWidget@@UEAAHW4Call@QMetaObject@@HPEAPEAX@Z) [C:\projects\bitcoin\build_msvc\test_bitcoin-qt\test_bitcoin-qt.vcxproj]
C:\projects\bitcoin\build_msvc\x64\Release\test_bitcoin-qt.exe : fatal error LNK1120: 3 unresolved externals [C:\projects\bitcoin\build_msvc\test_bitcoin-qt\test_bitcoin-qt.vcxproj]
libbitcoin_qt.lib(overviewpage.obj) : error LNK2001: unresolved external symbol "public: virtual struct QMetaObject const * __cdecl TransactionOverviewWidget::metaObject(void)const " (?metaObject@TransactionOverviewWidget@@UEBAPEBUQMetaObject@@XZ) [C:\projects\bitcoin\build_msvc\bitcoin-qt\bitcoin-qt.vcxproj]
libbitcoin_qt.lib(overviewpage.obj) : error LNK2001: unresolved external symbol "public: virtual void * __cdecl TransactionOverviewWidget::qt_metacast(char const *)" (?qt_metacast@TransactionOverviewWidget@@UEAAPEAXPEBD@Z) [C:\projects\bitcoin\build_msvc\bitcoin-qt\bitcoin-qt.vcxproj]
libbitcoin_qt.lib(overviewpage.obj) : error LNK2001: unresolved external symbol "public: virtual int __cdecl TransactionOverviewWidget::qt_metacall(enum QMetaObject::Call,int,void * *)" (?qt_metacall@TransactionOverviewWidget@@UEAAHW4Call@QMetaObject@@HPEAPEAX@Z) [C:\projects\bitcoin\build_msvc\bitcoin-qt\bitcoin-qt.vcxproj]
C:\projects\bitcoin\build_msvc\x64\Release\bitcoin-qt.exe : fatal error LNK1120: 3 unresolved externals [C:\projects\bitcoin\build_msvc\bitcoin-qt\bitcoin-qt.vcxproj] | https://github.com/bitcoin/bitcoin/issues/20982 | https://github.com/bitcoin/bitcoin/pull/20983 | 7f653c3b22f0a5267822eec017aea6a16752c597 | d6c3c43ef8d933367e650ab7086c6f5a6df22415 | 2021-01-21T20:09:25Z | c++ | 2021-01-22T03:26:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,975 | ["src/wallet/rpcwallet.cpp", "test/functional/test_framework/blocktools.py"] | Intermittent issue in create_raw_transaction assert_equal(final_psbt["complete"], True) fails | ERROR: type should be string, got "https://cirrus-ci.com/task/4904241892425728?command=ci#L5098\r\n\r\n\r\n```\r\n test 2021-01-20T23:39:58.801000Z TestFramework (ERROR): Assertion failed \r\n Traceback (most recent call last):\r\n File \"/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py\", line 126, in main\r\n self.run_test()\r\n File \"/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_nulldummy.py\", line 94, in run_test\r\n test4tx = create_transaction(self.nodes[0], test2tx.hash, self.address, amount=46)\r\n File \"/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/blocktools.py\", line 164, in create_transaction\r\n raw_tx = create_raw_transaction(node, txid, to_address, amount=amount)\r\n File \"/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/blocktools.py\", line 180, in create_raw_transaction\r\n assert_equal(final_psbt[\"complete\"], True)\r\n File \"/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py\", line 50, in assert_equal\r\n raise AssertionError(\"not(%s)\" % \" == \".join(str(arg) for arg in (thing1, thing2) + args))\r\n AssertionError: not(False == True)" | https://github.com/bitcoin/bitcoin/issues/20975 | https://github.com/bitcoin/bitcoin/pull/22308 | 327e2691f6e0498aa868af965bb4a951c5be17c5 | c93e123dc72bfc1bd2c637fdcd032e570d53a7bd | 2021-01-21T08:24:48Z | c++ | 2021-06-22T21:08:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,934 | ["test/functional/interface_zmq.py"] | Fix zmq test flakiness | There are many reports of the test being flaky: https://github.com/bitcoin/bitcoin/issues/20672#issuecomment-746260431
Thus, it should be made more robust, as described in https://github.com/bitcoin/bitcoin/issues/20538#issuecomment-738791868
#### Useful skills:
* Background in our functional test suite (python3)
* Background in zmq
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/20934 | https://github.com/bitcoin/bitcoin/pull/21008 | 9bbf08bf98487eeb75f143c120cfd544ea3135fb | 3c9d9d21e195ccfb28353c14a9f38f5366c98c8e | 2021-01-14T15:26:03Z | c++ | 2021-02-16T17:56:20Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,914 | ["src/validation.cpp"] | Null pointer derefence in CBlockIndexWorkComparator::operator() reachable via RPC call invalidateblock | While fuzzing the RPC interface I stumbled upon a null pointer dereference in `CBlockIndexWorkComparator::operator()` which is reachable via the `invalidateblock` RPC call:
```
$ ./autogen.sh
$ CC=clang CXX=clang++ ./configure --with-sanitizers=address,undefined
$ make
$ src/bitcoind -regtest &
$ src/bitcoin-cli -regtest generatetodescriptor 1 'addr(bcrt1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq3xueyj)#juyq9d97'
2021-01-12T14:27:41Z CreateNewBlock(): block weight: 932 txs: 0 fees: 0 sigops 400
2021-01-12T14:27:41Z Pre-allocating up to position 0x100000 in rev00000.dat
2021-01-12T14:27:41Z Leaving InitialBlockDownload (latching to false)
2021-01-12T14:27:41Z UpdateTip: new best=60c56626f298548305381979897bc2ac4ced1c1f6b3b7b6ba7dfaa83c428eb92 height=1 version=0x20000000 log2_work=2.000000 tx=2 date='2021-01-12T14:27:41Z' progress=1.000000 cache=0.0MiB(1txo)
[
"60c56626f298548305381979897bc2ac4ced1c1f6b3b7b6ba7dfaa83c428eb92"
]
$ src/bitcoin-cli -regtest invalidateblock 0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206
2021-01-12T14:28:01Z UpdateTip: new best=0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206 height=0 version=0x00000001 log2_work=1.000000 tx=1 date='2011-02-02T23:16:42Z' progress=1.000000 cache=0.0MiB(1txo)
2021-01-12T14:28:01Z ERROR: UndoReadFromDisk: no undo data available
2021-01-12T14:28:01Z ERROR: DisconnectBlock(): failure reading undo data
2021-01-12T14:28:01Z ERROR: DisconnectTip(): DisconnectBlock 0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206 failed
$ src/bitcoin-cli -regtest invalidateblock 0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206
validation.cpp:87:30: runtime error: member access within null pointer of type 'const CBlockIndex'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior validation.cpp:87:30 in
AddressSanitizer:DEADLYSIGNAL
=================================================================
==7489==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000044 (pc 0x559ffc210c43 bp 0x60d0000e7301 sp 0x7f83af6b6890 T16)
==7489==The signal is caused by a READ memory access.
==7489==Hint: address points to the zero page.
#0 0x559ffc210c42 in base_uint<256u>::CompareTo(base_uint<256u> const&) const src/arith_uint256.cpp
#1 0x559ffbc96c55 in operator>(base_uint<256u> const&, base_uint<256u> const&) src/./arith_uint256.h:219:85
#2 0x559ffbc96c55 in CBlockIndexWorkComparator::operator()(CBlockIndex const*, CBlockIndex const*) const src/validation.cpp:87:24
#3 0x559ffbcc3363 in CChainState::InvalidateBlock(BlockValidationState&, CChainParams const&, CBlockIndex*) src/validation.cpp:2954:22
#4 0x559ffbcc50d3 in InvalidateBlock(BlockValidationState&, CChainParams const&, CBlockIndex*) src/validation.cpp:3061:33
#5 0x559ffb9a6eb7 in invalidateblock()::$_22::operator()(RPCHelpMan const&, JSONRPCRequest const&) const src/rpc/blockchain.cpp:1603:5
…
[1]+ Exit 1 src/bitcoind -regtest
```
Nothing high priority of course, but still worth fixing :) | https://github.com/bitcoin/bitcoin/issues/20914 | https://github.com/bitcoin/bitcoin/pull/20921 | 3530d5d2d851d025b013b2ea79ed39a57cbbafcd | 63952f73b3041468fe3b25fa54858db7899273fa | 2021-01-12T14:40:53Z | c++ | 2021-03-20T11:46:11Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,902 | ["src/bitcoin-wallet.cpp", "src/test/fuzz/system.cpp", "src/util/system.cpp", "src/util/system.h", "src/wallet/wallettool.cpp", "src/wallet/wallettool.h", "test/functional/tool_wallet.py"] | wallet tool silently ignores trailing options | Steps to reproduce:
```
$ ./src/bitcoin-wallet -datadir=/tmp info -wallet=asdf
Wallet info
===========
Name:
Format: bdb
Descriptors: no
Encrypted: no
HD (hd seed available): yes
Keypool Size: 2000
Transactions: 0
Address Book: 0
```
(See the mismatching wallet name!)
Compare to:
```
$ ./src/bitcoin-wallet -datadir=/tmp -wallet=asdf info
Wallet info
===========
Name: asdf
Format: bdb
Descriptors: no
Encrypted: no
HD (hd seed available): yes
Keypool Size: 2000
Transactions: 0
Address Book: 0
| https://github.com/bitcoin/bitcoin/issues/20902 | https://github.com/bitcoin/bitcoin/pull/20715 | 5a429d3d0fecbe3809f8cb405070631b785694c9 | 4e946ebcf111a5af11e6434d2fe217aca1cff22f | 2021-01-11T14:09:55Z | c++ | 2021-02-04T08:12:05Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,878 | ["doc/build-osx.md"] | build: `make deploy` fails on macOS Big Sur 11.1 | ```
% make deploy
Making all in src
Making all in doc/man
make[1]: Nothing to be done for `all'.
make[1]: Nothing to be done for `all-am'.
build-aux/install-sh -c -d Bitcoin-Qt.app/Contents/MacOS
STRIPPROG="/usr/bin/strip" /bin/sh /Users/hebasto1/bitcoin/build-aux/install-sh -c -s ./src/qt/bitcoin-qt Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
/usr/local/bin/python3.9 ./contrib/macdeploy/macdeployqtplus Bitcoin-Qt.app Bitcoin-Core -translations-dir= -dmg
Traceback (most recent call last):
File "/Users/hebasto1/bitcoin/./contrib/macdeploy/macdeployqtplus", line 22, in <module>
from ds_store import DSStore
ModuleNotFoundError: No module named 'ds_store'
make: *** [Bitcoin-Core.dmg] Error 1
``` | https://github.com/bitcoin/bitcoin/issues/20878 | https://github.com/bitcoin/bitcoin/pull/20890 | 5574e489631bb20c4566df916b79863f31dc6f0c | 708ef4424a65b645440e8f724db653f0f5f8f42b | 2021-01-07T19:41:07Z | c++ | 2021-01-10T07:03:05Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,795 | ["src/rpc/client.cpp", "src/wallet/feebumper.cpp", "src/wallet/feebumper.h", "src/wallet/rpc/spend.cpp", "test/functional/wallet_bumpfee.py"] | Privacy Issue - Increase Fee with Custom Change Address grabs new UTXO | I am relaying a privacy issue for Bitcoin Core that was [reported on r/Bitcoin](https://reddit.com/r/Bitcoin/comments/klk2wh) (Reddit).
The [message](https://pastebin.com/raw/ptFQityt) was:
- _Using coin control_
- _Custom change address_
_When one clicks the increase transaction fee button, it adds another input rather than increasing the fee by reducing the change output. Major privacy leak since you have no control of the input used._
From that it sounds like the observed behavior is that the replacement transaction includes an additional UTXO that was not chosen by the user, even though the transaction was composed as a Coin Control transaction.
So I'm assuming the expected behavior would be for Bitcoin Core to remember that this OUTPUT was actually a Custom Change Address and to then lower the amount of that OUTPUT by the amount needed for the fee bump.
And, now that I am thinking of this, isn't there the expectation that if my initial transaction was done using Coin Control, and then if my fee bump (RBF) needs another UTXO input to cover the increase in fee, that Coin Selection for that will occur (regardless of whether or not the change address was a Custom Change Address)? | https://github.com/bitcoin/bitcoin/issues/20795 | https://github.com/bitcoin/bitcoin/pull/26467 | 5608e1d3b4ba3a23c05937918046e428be890505 | 04afe55e29002a1d46d1cd9ed117229874840ae6 | 2020-12-29T07:31:49Z | c++ | 2023-07-20T08:55:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,725 | ["src/policy/fees.cpp"] | EstimateMedianVal returns higher fee for higher confTarget | Running on recent master, commit f1dbf92ff0475a01d20170ea422c1d086acbbc57
If I run:
```
test/functional/feature_fee_estimation.py --randomseed 108574360997204915
```
I get:
```
2020-12-19T20:14:06.175000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_bcwexp78
2020-12-19T20:14:07.738000Z TestFramework (INFO): This test is time consuming, please be patient
2020-12-19T20:14:07.738000Z TestFramework (INFO): Splitting inputs so we can generate tx's
2020-12-19T20:14:10.870000Z TestFramework (INFO): Finished splitting
2020-12-19T20:14:12.104000Z TestFramework (INFO): Will output estimates for 1/2/3/6/15/25 blocks
2020-12-19T20:14:12.104000Z TestFramework (INFO): Creating transactions and mining them with a block size that can't keep up
2020-12-19T20:14:15.879000Z TestFramework (INFO): Creating transactions and mining them at a block size that is just big enough
2020-12-19T20:14:21.104000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/home/sdaftuar/ccl-bitcoin/2020-12-latest-master/test/functional/test_framework/test_framework.py", line 126, in main
self.run_test()
File "test/functional/feature_fee_estimation.py", line 256, in run_test
check_estimates(self.nodes[1], self.fees_per_kb)
File "test/functional/feature_fee_estimation.py", line 140, in check_estimates
check_smart_estimates(node, fees_seen)
File "test/functional/feature_fee_estimation.py", line 130, in check_smart_estimates
% (feerate, last_feerate))
AssertionError: Estimated fee (0.000565) larger than last fee (0.000479) for lower number of confirms
``` | https://github.com/bitcoin/bitcoin/issues/20725 | https://github.com/bitcoin/bitcoin/pull/21161 | 023418a140b05b788b45fcb66bdd4832c08db751 | 2e9454a633462604cfafdf685cc9b3ad7d0e56ef | 2020-12-19T20:16:36Z | c++ | 2023-11-02T11:25:50Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,722 | ["contrib/install_db4.sh"] | contrib/install_db4.sh fetching a patch from gist.githubusercontent.com | Berkeley DB installer in contrib makes a call over the internet to https://gist.githubusercontent.com to fetch a 141 line patch.
https://github.com/bitcoin/bitcoin/blob/f1dbf92ff0475a01d20170ea422c1d086acbbc57/contrib/install_db4.sh#L71
The gist has [multiple revisions](
https://gist.github.com/LnL7/5153b251fd525fe15de69b67e63a6075/revisions)
**Expected behavior**
One less call over the internet during the build process. One less website to depend on.
**To reproduce**
```
./contrib/install_db4.sh
```
`install_db4.sh` is recommended by the `doc/build-*.md` for example https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#berkeley-db
CC: @laanwj
| https://github.com/bitcoin/bitcoin/issues/20722 | https://github.com/bitcoin/bitcoin/pull/20906 | 43f3ada27b835e6b198f9a669e4955d06f5c4d08 | dd545c53a5c7d96e0db7dcf4ebdcc2e9863c0db8 | 2020-12-19T13:32:48Z | c++ | 2021-01-19T16:30:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,626 | ["src/txmempool.cpp", "src/txmempool.h", "test/sanitizer_suppressions/ubsan"] | Signed integer overflow in CTxMemPool::PrioritiseTransaction(…) reachable via RPC call prioritisetransaction | While fuzzing the RPC interface I stumbled upon a signed integer overflow in `CTxMemPool::PrioritiseTransaction(…)` which is reachable via the following two `prioritisetransaction` RPC calls:
```
$ ./autogen.sh
$ CC=clang CXX=clang++ ./configure --with-sanitizers=address,undefined
$ make
$ UBSAN_OPTIONS="print_stacktrace=1" src/bitcoind &
$ src/bitcoin-cli prioritisetransaction cafebabecafebabecafebabecafebabecafebabecafebabecafebabecafebabe 0 -9123456789123456789
$ src/bitcoin-cli prioritisetransaction cafebabecafebabecafebabecafebabecafebabecafebabecafebabecafebabe 0 -9123456789123456789
txmempool.cpp:832:15: runtime error: signed integer overflow: -9123456789123456789 + -9123456789123456789 cannot be represented in type 'long'
#0 0x5581f3e69c3c in CTxMemPool::PrioritiseTransaction(uint256 const&, long const&) src/txmempool.cpp:832:15
#1 0x5581f3c93852 in prioritisetransaction()::$_6::operator()(RPCHelpMan const&, JSONRPCRequest const&) const src/rpc/mining.cpp:470:36
…
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior txmempool.cpp:832:15
```
Nothing high priority of course, but still worth fixing :) | https://github.com/bitcoin/bitcoin/issues/20626 | https://github.com/bitcoin/bitcoin/pull/23418 | aaeb315ff0f7956449a92736160795f0140369e3 | dde7205c576352a6052c1411d0fa8017e83d3ef4 | 2020-12-11T16:06:11Z | c++ | 2022-06-27T06:25:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,620 | ["doc/release-notes-20867.md", "src/rpc/util.cpp", "src/script/descriptor.cpp", "src/script/interpreter.cpp", "src/script/interpreter.h", "src/script/standard.cpp", "src/test/descriptor_tests.cpp", "test/functional/wallet_importdescriptors.py"] | Multi and Sortedmulti descriptors should support up to 20 keys instead of 16 inside P2WSH context | Currently, the multisig descriptor constructions are limited to 16 keys only possibly because of template parsing reasons. Under p2sh context, such scripts would be invalid anyway because of 520-byte rule, but we can support up to 20 keys for CHECKMULTISIG in witness script context.
| https://github.com/bitcoin/bitcoin/issues/20620 | https://github.com/bitcoin/bitcoin/pull/20867 | 2448457cca1858c2fcf3dfcb53de3f388ea72079 | 60132382a74506f34d3c7b0b162799772505608c | 2020-12-11T04:34:37Z | c++ | 2021-05-03T04:44:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,618 | ["test/sanitizer_suppressions/tsan"] | Data race in interface_zmq.py | https://cirrus-ci.com/task/5979351982276608?command=ci#L4621
```
==================
WARNING: ThreadSanitizer: data race (pid=114265)
Read of size 8 at 0x7b1400025170 by thread T4:
#0 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > >::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*>*) /usr/lib/llvm-10/bin/../include/c++/v1/__tree:1833:51 (bitcoind+0x3ae331)
#1 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > >::~__tree() <null> (bitcoind+0x998157)
#2 CZMQAbstractPublishNotifier::SendZmqMessage(char const*, void const*, unsigned long) /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/zmq/zmqpublishnotifier.cpp:170:14 (bitcoind+0x787f06)
#3 CZMQPublishHashTransactionNotifier::NotifyTransaction(CTransaction const&) /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/zmq/zmqpublishnotifier.cpp:197:12 (bitcoind+0x787f06)
#4 CZMQNotificationInterface::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_1::operator()(CZMQAbstractNotifier*) const /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/zmq/zmqnotificationinterface.cpp:147:26 (bitcoind+0x7855c6)
#5 void (anonymous namespace)::TryForEachAndRemoveFailed<CZMQNotificationInterface::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_1>(std::__1::list<std::__1::unique_ptr<CZMQAbstractNotifier, std::__1::default_delete<CZMQAbstractNotifier> >, std::__1::allocator<std::__1::unique_ptr<CZMQAbstractNotifier, std::__1::default_delete<CZMQAbstractNotifier> > > >&, CZMQNotificationInterface::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_1 const&) /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/zmq/zmqnotificationinterface.cpp:121:13 (bitcoind+0x7855c6)
#6 CZMQNotificationInterface::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long) /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/zmq/zmqnotificationinterface.cpp:146:5 (bitcoind+0x7855c6)
#7 CMainSignals::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_4::operator()() const::'lambda'(CValidationInterface&)::operator()(CValidationInterface&) const /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/validationinterface.cpp:204:79 (bitcoind+0x443db6)
#8 void MainSignalsInstance::Iterate<CMainSignals::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_4::operator()() const::'lambda'(CValidationInterface&)>(CMainSignals::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_4::operator()() const::'lambda'(CValidationInterface&)&&) /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/validationinterface.cpp:83:17 (bitcoind+0x443db6)
#9 CMainSignals::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_4::operator()() const /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/validationinterface.cpp:204:22 (bitcoind+0x443db6)
#10 CMainSignals::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_5::operator()() const /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/validationinterface.cpp:206:5 (bitcoind+0x443db6)
#11 decltype(std::__1::forward<CMainSignals::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_5&>(fp)()) std::__1::__invoke<CMainSignals::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_5&>(CMainSignals::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_5&) /usr/lib/llvm-10/bin/../include/c++/v1/type_traits:3539:1 (bitcoind+0x443db6)
#12 void std::__1::__invoke_void_return_wrapper<void>::__call<CMainSignals::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_5&>(CMainSignals::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_5&) /usr/lib/llvm-10/bin/../include/c++/v1/__functional_base:348:9 (bitcoind+0x443db6)
#13 std::__1::__function::__alloc_func<CMainSignals::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_5, std::__1::allocator<CMainSignals::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_5>, void ()>::operator()() /usr/lib/llvm-10/bin/../include/c++/v1/functional:1540:16 (bitcoind+0x443db6)
#14 std::__1::__function::__func<CMainSignals::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_5, std::__1::allocator<CMainSignals::TransactionAddedToMempool(std::__1::shared_ptr<CTransaction const> const&, unsigned long)::$_5>, void ()>::operator()() /usr/lib/llvm-10/bin/../include/c++/v1/functional:1714:12 (bitcoind+0x443db6)
#15 std::__1::__function::__value_func<void ()>::operator()() const /usr/lib/llvm-10/bin/../include/c++/v1/functional:1867:16 (bitcoind+0x6ee1ba)
#16 std::__1::function<void ()>::operator()() const /usr/lib/llvm-10/bin/../include/c++/v1/functional:2473:12 (bitcoind+0x6ee1ba)
#17 SingleThreadedSchedulerClient::ProcessQueue() /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/scheduler.cpp:173:5 (bitcoind+0x6ee1ba)
#18 decltype(*(std::__1::forward<SingleThreadedSchedulerClient*&>(fp0)).*fp()) std::__1::__invoke<void (SingleThreadedSchedulerClient::*&)(), SingleThreadedSchedulerClient*&, void>(void (SingleThreadedSchedulerClient::*&)(), SingleThreadedSchedulerClient*&) /usr/lib/llvm-10/bin/../include/c++/v1/type_traits:3480:1 (bitcoind+0x6f016a)
#19 std::__1::__bind_return<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, std::__1::tuple<>, __is_valid_bind_return<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, std::__1::tuple<> >::value>::type std::__1::__apply_functor<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, 0ul, std::__1::tuple<> >(void (SingleThreadedSchedulerClient::*&)(), std::__1::tuple<SingleThreadedSchedulerClient*>&, std::__1::__tuple_indices<0ul>, std::__1::tuple<>&&) /usr/lib/llvm-10/bin/../include/c++/v1/functional:2770:12 (bitcoind+0x6f016a)
#20 std::__1::__bind_return<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, std::__1::tuple<>, __is_valid_bind_return<void (SingleThreadedSchedulerClient::*)(), std::__1::tuple<SingleThreadedSchedulerClient*>, std::__1::tuple<> >::value>::type std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>::operator()<>() /usr/lib/llvm-10/bin/../include/c++/v1/functional:2803:20 (bitcoind+0x6f016a)
#21 decltype(std::__1::forward<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&>(fp)()) std::__1::__invoke<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&>(std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&) /usr/lib/llvm-10/bin/../include/c++/v1/type_traits:3539:1 (bitcoind+0x6f016a)
#22 void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&>(std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>&) /usr/lib/llvm-10/bin/../include/c++/v1/__functional_base:348:9 (bitcoind+0x6f016a)
#23 std::__1::__function::__alloc_func<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>, std::__1::allocator<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*> >, void ()>::operator()() /usr/lib/llvm-10/bin/../include/c++/v1/functional:1540:16 (bitcoind+0x6f016a)
#24 std::__1::__function::__func<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>, std::__1::allocator<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*> >, void ()>::operator()() /usr/lib/llvm-10/bin/../include/c++/v1/functional:1714:12 (bitcoind+0x6f016a)
#25 std::__1::__function::__value_func<void ()>::operator()() const /usr/lib/llvm-10/bin/../include/c++/v1/functional:1867:16 (bitcoind+0x6ed175)
#26 std::__1::function<void ()>::operator()() const /usr/lib/llvm-10/bin/../include/c++/v1/functional:2473:12 (bitcoind+0x6ed175)
#27 CScheduler::serviceQueue() /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/scheduler.cpp:60:17 (bitcoind+0x6ed175)
#28 AppInitMain(util::Ref const&, NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_6::operator()() const::'lambda'()::operator()() const /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/init.cpp:1344:84 (bitcoind+0x1403c1)
#29 void TraceThread<AppInitMain(util::Ref const&, NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_6::operator()() const::'lambda'()>(char const*, AppInitMain(util::Ref const&, NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_6::operator()() const::'lambda'()) /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/./util/system.h:438:9 (bitcoind+0x1403c1)
#30 AppInitMain(util::Ref const&, NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_6::operator()() const /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/init.cpp:1344:37 (bitcoind+0x1403c1)
#31 boost::detail::thread_data<AppInitMain(util::Ref const&, NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_6>::run() /tmp/cirrus-ci-build/depends/x86_64-pc-linux-gnu/include/boost/thread/detail/thread.hpp:120:17 (bitcoind+0x1403c1)
#32 boost::(anonymous namespace)::thread_proxy(void*) <null> (bitcoind+0x87b28e)
Previous write of size 8 at 0x7b1400025170 by thread T11:
#0 operator new(unsigned long) <null> (bitcoind+0x11626b)
#1 std::__1::__libcpp_allocate(unsigned long, unsigned long) /usr/lib/llvm-10/bin/../include/c++/v1/new:253:10 (bitcoind+0x585eed)
#2 std::__1::allocator<std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*> >::allocate(unsigned long, void const*) /usr/lib/llvm-10/bin/../include/c++/v1/memory:1864:37 (bitcoind+0x585eed)
#3 std::__1::allocator_traits<std::__1::allocator<std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*> > >::allocate(std::__1::allocator<std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*> >&, unsigned long) /usr/lib/llvm-10/bin/../include/c++/v1/memory:1581:21 (bitcoind+0x585eed)
#4 std::__1::unique_ptr<std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*>, std::__1::__tree_node_destructor<std::__1::allocator<std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*> > > > std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > >::__construct_node<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&>(std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&) /usr/lib/llvm-10/bin/../include/c++/v1/__tree:2193:23 (bitcoind+0x585eed)
#5 std::__1::__tree_iterator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*>*, long> std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > >::__emplace_hint_unique_key_args<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&>(std::__1::__tree_const_iterator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*>*, long>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&) /usr/lib/llvm-10/bin/../include/c++/v1/__tree:2172:29 (bitcoind+0x585eed)
#6 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > >::__insert_unique(std::__1::__tree_const_iterator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*>*, long>, std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&) <null> (bitcoind+0x99ce13)
Location is heap block of size 80 at 0x7b1400025170 allocated by thread T11:
#0 operator new(unsigned long) <null> (bitcoind+0x11626b)
#1 std::__1::__libcpp_allocate(unsigned long, unsigned long) /usr/lib/llvm-10/bin/../include/c++/v1/new:253:10 (bitcoind+0x585eed)
#2 std::__1::allocator<std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*> >::allocate(unsigned long, void const*) /usr/lib/llvm-10/bin/../include/c++/v1/memory:1864:37 (bitcoind+0x585eed)
#3 std::__1::allocator_traits<std::__1::allocator<std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*> > >::allocate(std::__1::allocator<std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*> >&, unsigned long) /usr/lib/llvm-10/bin/../include/c++/v1/memory:1581:21 (bitcoind+0x585eed)
#4 std::__1::unique_ptr<std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*>, std::__1::__tree_node_destructor<std::__1::allocator<std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*> > > > std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > >::__construct_node<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&>(std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&) /usr/lib/llvm-10/bin/../include/c++/v1/__tree:2193:23 (bitcoind+0x585eed)
#5 std::__1::__tree_iterator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*>*, long> std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > >::__emplace_hint_unique_key_args<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&>(std::__1::__tree_const_iterator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*>*, long>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&) /usr/lib/llvm-10/bin/../include/c++/v1/__tree:2172:29 (bitcoind+0x585eed)
#6 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > >::__insert_unique(std::__1::__tree_const_iterator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, void*>*, long>, std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > const&) <null> (bitcoind+0x99ce13)
Thread T4 'b-scheduler' (tid=114305, running) created by main thread at:
#0 pthread_create <null> (bitcoind+0x8935b)
#1 boost::thread::start_thread_noexcept() <null> (bitcoind+0x87b18d)
#2 AppInit(int, char**) /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/bitcoind.cpp:142:43 (bitcoind+0x1191a3)
#3 main /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/bitcoind.cpp:172:13 (bitcoind+0x1191a3)
Thread T11 'ZMQbg/1' (tid=114340, running) created by main thread at:
#0 pthread_create <null> (bitcoind+0x8935b)
#1 zmq::thread_t::start(void (*)(void*), void*) <null> (bitcoind+0x9d2918)
#2 CZMQNotificationInterface::Initialize() /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/zmq/zmqnotificationinterface.cpp:87:23 (bitcoind+0x78475c)
#3 CZMQNotificationInterface::Create() /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/zmq/zmqnotificationinterface.cpp:60:36 (bitcoind+0x784225)
#4 AppInitMain(util::Ref const&, NodeContext&, interfaces::BlockAndHeaderTipInfo*) /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/init.cpp:1522:36 (bitcoind+0x13448a)
#5 AppInit(int, char**) /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/bitcoind.cpp:142:43 (bitcoind+0x1191a3)
#6 main /tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/bitcoind.cpp:172:13 (bitcoind+0x1191a3)
SUMMARY: ThreadSanitizer: data race /usr/lib/llvm-10/bin/../include/c++/v1/__tree:1833:51 in std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > >::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::b
==================
``` | https://github.com/bitcoin/bitcoin/issues/20618 | https://github.com/bitcoin/bitcoin/pull/20748 | 98de9eb1aa84e712c3f4add0cf5602444dfa6dfd | e669c3156ff88627a9478be8a6cac12723c2614a | 2020-12-10T21:01:17Z | c++ | 2020-12-23T11:32:33Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,579 | ["src/core_read.cpp", "test/functional/rpc_rawtransaction.py"] | invalid transaction decoding | <!-- Describe the issue -->
using: bitcoin-tx -json 020000000001010000000000000000000000000000000000000000000000000000000000000000ffffffff4b03c68708046ff8415c622f4254432e434f4d2ffabe6d6de1965d02c68f928e5b244ab1965115a36f56eb997633c7f690124bbf43644e23080000000ca3d3af6d005a65ff0200fd00000000ffffffff03f4c1fb4b0000000016001497cfc76442fe717f2a3f0cc9c175f7561b6619970000000000000000266a24aa21a9ed957d1036a80343e0d1b659497e1b48a38ebe876a056d45965fac4a85cda84e1900000000000000002952534b424c4f434b3a8e092581ab01986cbadc84f4b43f4fa4bb9e7a2e2a0caf9b7cf64d939028e22c0120000000000000000000000000000000000000000000000000000000000000000000000000
gives an error: invalid transaction encoding
<!--- What behavior did you expect? -->
Decode the transaction into a JSON block
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
error: invalid transaction encoding
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
All the time under a debug build x86 or release build x86 or debug Release Build x64
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
Downloaded the entire source code on 30/11/2020 19:21:00 UTC from Github
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
Windows 10 Pro, Intel Cor I7-5500 [email protected] GHz, 512 GB SSD
PS same error on windows server 2019 48 cores, and various other windows systems
<!-- GUI-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell? -->
No, not GUI related
<!-- Any extra information that might be useful in the debugging process. -->
Compiled the source code using Visual Studio 2019 ver. 16.8.2
Compiles Successfully
P.S. Downloaded pre compiled bitcoin-tx.exe File Version 0.20.1.0 31/07/2020 and tested it. It decodes the transaction successfully
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/20579 | https://github.com/bitcoin/bitcoin/pull/20595 | c8fdbb46bd921575be84cf87e2966a455c3f5274 | eb53c03b3680358e2f3c702b7a6b221887ef4762 | 2020-12-05T19:06:04Z | c++ | 2020-12-10T10:22:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,538 | ["test/functional/interface_zmq.py"] | intermittent issue in interface_zmq "assert_equal(struct.unpack('<I', seq)[-1], self.sequence)" | ```
Traceback (most recent call last):
File "./test/functional/test_framework/test_framework.py", line 126, in main
self.run_test()
File "./test/functional/interface_zmq.py", line 73, in run_test
self.test_basic()
File "./test/functional/interface_zmq.py", line 119, in test_basic
txid = hashtx.receive()
File "./test/functional/interface_zmq.py", line 41, in receive
assert_equal(struct.unpack('<I', seq)[-1], self.sequence)
File "./test/functional/test_framework/util.py", line 50, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(1 == 0)
```
* https://cirrus-ci.com/task/4797090746335232?command=ci#L4841
* https://cirrus-ci.com/task/5508595028590592?command=ci#L4902 | https://github.com/bitcoin/bitcoin/issues/20538 | https://github.com/bitcoin/bitcoin/pull/21008 | 9bbf08bf98487eeb75f143c120cfd544ea3135fb | 3c9d9d21e195ccfb28353c14a9f38f5366c98c8e | 2020-12-01T08:13:16Z | c++ | 2021-02-16T17:56:20Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,534 | ["src/rpc/util.cpp", "src/rpc/util.h", "src/test/util_tests.cpp", "src/wallet/rpcwallet.cpp", "test/functional/rpc_fundrawtransaction.py", "test/functional/rpc_psbt.py", "test/functional/wallet_basic.py", "test/functional/wallet_bumpfee.py", "test/functional/wallet_send.py"] | sat/b values aren't validated to be in-range | values smaller than 0.001 sat/B can't be represented by CFeeRate, but they are not rejected.
```
./src/bitcoin-cli -named sendtoaddress address=bcrt1qwkmhqum095zau5rf2velq55cq938vrd7uw8m4r amount=1.23 fee_rate=0.0009
error code: -6
error message:
Fee rate (0.000 sat/vB) is lower than the minimum fee rate setting (1.000 sat/vB)
```
```
./src/bitcoin-cli -named sendtoaddress address=bcrt1qwkmhqum095zau5rf2velq55cq938vrd7uw8m4r amount=1.23 fee_rate=0.000000000009
error code: -3
error message:
Invalid amount
| https://github.com/bitcoin/bitcoin/issues/20534 | https://github.com/bitcoin/bitcoin/pull/21786 | 2a22d903f3da54b31d21e74c3e084f5113f13789 | adf78434100204f2eb799bbb96a28b734fb084f0 | 2020-11-30T15:55:56Z | c++ | 2021-05-10T07:02:48Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,498 | ["configure.ac", "doc/build-osx.md"] | Q: Compiling with SQLite on macOS | On macOS 10.15.7 I've removed the previously installed sqlite
```
brew uninstall sqlite
```
and `brew list` does not show it.
BUT I still able to run `configure` that prints `with sqlite = yes`, and to compile binaries with sqlite functionality.
I'm not a macOS expert, so the question is "Has macOS its own SQLite? If so, is this documented somewhere?" | https://github.com/bitcoin/bitcoin/issues/20498 | https://github.com/bitcoin/bitcoin/pull/20527 | 8e1f9d62731cae288750a3ea5be0b76182f4dd41 | 86f20071931b803b5f26ed8f685d98d4919fb7a7 | 2020-11-25T20:23:55Z | c++ | 2020-12-10T12:18:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,423 | ["ci/test/00_setup_env_i686_centos.sh", "depends/packages/qt.mk"] | build: Re-enable i686 qt build on centos 8 | We no longer provide i686 release binaries, but building from source should still be supported. However, in #20413 the i686 qt build has been disabled to silence a compile error. The qt build should be enabled and the compile error be fixed. Here is the diff to enable the qt build again:
```diff
diff --git a/ci/test/00_setup_env_i686_centos.sh b/ci/test/00_setup_env_i686_centos.sh
index 52cdb75a0c..f634fabd92 100644
--- a/ci/test/00_setup_env_i686_centos.sh
+++ b/ci/test/00_setup_env_i686_centos.sh
@@ -11,6 +11,5 @@ export CONTAINER_NAME=ci_i686_centos_8
export DOCKER_NAME_TAG=centos:8
export DOCKER_PACKAGES="gcc-c++ glibc-devel.x86_64 libstdc++-devel.x86_64 glibc-devel.i686 libstdc++-devel.i686 ccache libtool make git python3 python3-zmq which patch lbzip2 dash rsync coreutils"
export GOAL="install"
-export DEP_OPTS="NO_QT=1" # Gui disabled for now to avoid build failures
-export BITCOIN_CONFIG="--enable-zmq --with-gui=no --enable-reduce-exports --with-boost-process"
+export BITCOIN_CONFIG="--enable-zmq --with-gui=qt5 --enable-reduce-exports --with-boost-process"
export CONFIG_SHELL="/bin/dash"
```
#### Useful skills:
Strong background in:
* build systems
* qt5 build system
* centos 8
* Our ci system
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/20423 | https://github.com/bitcoin/bitcoin/pull/20520 | 681ce59d0eac005203af1ff5bd64a1e6f2fa53e7 | a3186b6da60e1f76d0b097644241720783cd38a1 | 2020-11-19T06:43:58Z | c++ | 2020-12-03T12:23:09Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,402 | ["src/core_io.h", "src/core_write.cpp", "src/test/fuzz/integer.cpp", "src/test/fuzz/transaction.cpp", "src/test/rpc_tests.cpp", "src/test/util_tests.cpp", "src/util/moneystr.cpp", "src/util/moneystr.h"] | Invalid integer negation in FormatMoney(CAmount n) and ValueFromAmount (CAmount n) when n = std::numeric_limits<CAmount>::min() | `FormatMoney(CAmount n)` is not being properly defined for `n = std::numeric_limits<CAmount>::min()`. This is due to an invalid integer negation: the negation of `-9223372036854775808` cannot be represented in type `CAmount` (which has a max value of `9223372036854775807`):
https://github.com/bitcoin/bitcoin/blob/54f812d9d29893c690ae06b84aaeab128186aa36/src/util/moneystr.cpp#L12-L31
FWIW `FormatMoney(-9223372036854775808)` returns `--92233720368.-54775808` when compiled with UBSan (LLVM/Clang, `-fsanitize=undefined`).
Context: https://github.com/bitcoin/bitcoin/pull/20383#discussion_r523250890
It would be nice if `FormatMoney(CAmount n)` was properly defined for all `CAmount n` :)
These are the "expectations of least surprise":
```
BOOST_CHECK_EQUAL(FormatMoney(std::numeric_limits<CAmount>::max()), "92233720368.54775807"); // 9223372036854775807
BOOST_CHECK_EQUAL(FormatMoney(std::numeric_limits<CAmount>::max() - 1), "92233720368.54775806"); // 9223372036854775806
BOOST_CHECK_EQUAL(FormatMoney(std::numeric_limits<CAmount>::max() - 2), "92233720368.54775805"); // 9223372036854775805
BOOST_CHECK_EQUAL(FormatMoney(std::numeric_limits<CAmount>::max() - 3), "92233720368.54775804"); // 9223372036854775804
BOOST_CHECK_EQUAL(FormatMoney(std::numeric_limits<CAmount>::min() + 3), "-92233720368.54775805"); // -9223372036854775805
BOOST_CHECK_EQUAL(FormatMoney(std::numeric_limits<CAmount>::min() + 2), "-92233720368.54775806"); // -9223372036854775806
BOOST_CHECK_EQUAL(FormatMoney(std::numeric_limits<CAmount>::min() + 1), "-92233720368.54775807"); // -9223372036854775807
BOOST_CHECK_EQUAL(FormatMoney(std::numeric_limits<CAmount>::min()), "-92233720368.54775808"); // -9223372036854775808
```
These assertions are _guaranteed_ to hold for all cases above _except_ for the last one. | https://github.com/bitcoin/bitcoin/issues/20402 | https://github.com/bitcoin/bitcoin/pull/20406 | cabe63759ce890a7d39d72f7b8046195b0edb421 | 47b99ab1a9e918022ea13f54765f5b4e6aad6140 | 2020-11-16T15:32:17Z | c++ | 2021-03-03T18:04:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,381 | ["src/wallet/rpcwallet.cpp"] | "may be used uninitialized" warning in wallet/rpcwallet.cpp | Have this warning while building current master (0bd4929cd00e91bf4137f43b097cd62f72f503e4) on one test machine.
```
wallet/rpcwallet.cpp: In function 'rescanblockchain()::<lambda(const RPCHelpMan&, const JSONRPCRequest&)>':
wallet/rpcwallet.cpp:3596:19: warning: '*((void*)& stop_height +4)' may be used uninitialized in this function [-Wmaybe-uninitialized]
3596 | Optional<int> stop_height;
| ^~~~~~~~~~~
```
```
$ gcc --version
gcc (Gentoo 9.2.0-r2 p3) 9.2.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ uname -a
Linux red-box 4.19.72-gentoo #2 SMP Sun Sep 22 03:00:01 EEST 2019 x86_64 Intel(R) Pentium(R) CPU N3710 @ 1.60GHz GenuineIntel GNU/Linux
``` | https://github.com/bitcoin/bitcoin/issues/20381 | https://github.com/bitcoin/bitcoin/pull/20386 | fb7726e56d0f0617076c89cbc279547cc9d07341 | 0ede354367c478cbbed0ec40a9d3cf1efe74cf33 | 2020-11-13T05:17:58Z | c++ | 2020-11-15T17:33:59Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,338 | ["contrib/devtools/security-check.py", "test/lint/lint-python.sh"] | security-check.py is using wrong comparison operators | ```
./contrib/devtools/security-check.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
if splitline[ofs_flags + 1] is 'E':
./contrib/devtools/security-check.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
if splitline[ofs_flags + 1] is 'E':
./contrib/devtools/security-check.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
if splitline[ofs_flags + 1] is 'E':
./contrib/devtools/security-check.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
if splitline[ofs_flags + 1] is 'E':
./contrib/devtools/security-check.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
if splitline[ofs_flags + 1] is 'E':
./contrib/devtools/security-check.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
if splitline[ofs_flags + 1] is 'E':
```
See also:
```
>>> 'asdf'[:2] == 'as'
True
>>> 'asdf'[:2] is 'as'
<stdin>:1: SyntaxWarning: "is" with a literal. Did you mean "=="?
False
| https://github.com/bitcoin/bitcoin/issues/20338 | https://github.com/bitcoin/bitcoin/pull/20346 | 7c0d412a74ba8d791e6b83b6aca82406f2158fc3 | 3457054c61d5b74800797e2c26a8126a21352382 | 2020-11-08T09:52:36Z | c++ | 2020-11-17T05:57:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,297 | ["src/wallet/wallet.cpp", "test/sanitizer_suppressions/ubsan"] | Invalid json from getwalletinfo when scanning is in progress | I'm sometimes getting an invalid json reply from `getwalletinfo` when rescanning is in progress.
The invalid part is this: `"scanning":{"duration":19,"progress":}}` (no value for `progress`).
I can't reliably reproduce this, but I did manage to run into this 3 times now (once every 10-20 attempts or so).
I'm running v0.20.0 and testing against a regtest instance. This happens while doing a batched `importmulti` of 2000 addresses (none of which have history). | https://github.com/bitcoin/bitcoin/issues/20297 | https://github.com/bitcoin/bitcoin/pull/20344 | 179ece42734a126ee0b9b7b62feedb4011995eff | d9f5132736f34f31f6e7d009015f917c9dcfec00 | 2020-11-04T07:00:38Z | c++ | 2020-11-11T15:11:01Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,293 | ["src/wallet/rpcdump.cpp", "src/wallet/rpcwallet.cpp", "src/wallet/scriptpubkeyman.cpp", "src/wallet/scriptpubkeyman.h", "src/wallet/test/wallet_tests.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h", "test/functional/wallet_listtransactions.py"] | The listtransactions command does not display transactions when restoring a wallet from a backup | In March, I made a backup of the wallet and continued using the node. In October, I restored my old backup. After restoring the backup, I found that the listtransactions command stopped displaying some transactions made during the period from March to October.
**Expected behavior**
The listtransactions command displays all transactions in the restored wallet.
**Actual behavior**
The listtransactions command in the restored wallet does not display some transactions since the backup.
**To reproduce**
1. Run bitcoin core in regtest mode
2. Create a new address A and generate 101 blocks with sending a reward to the created address A
3. Create a wallet backup
4. Create new address B
5. Send transaction to address B, write TXID
6. Generate 1 block with sending a reward to address A
7. View getaddressinfo B. Verify labels are not an empty list
8. View listtransactions. Make sure there is a TXID transaction present
9. Stop bitcoin core
10. Restore backup
11. Run bitcoin core
12. View getaddressinfo B and listtransactions. Detect that the address does not have a label set and that listtransactions does not contain a TXID transaction.
**System information**
Bitcoin Core 0.20.1 on Debian GNU / Linux.
| https://github.com/bitcoin/bitcoin/issues/20293 | https://github.com/bitcoin/bitcoin/pull/22929 | 26a1147ce56083d7aa820ac115c16b01e47d911c | bce58bbb3d7b7351acd4c988748ba73908c60119 | 2020-11-03T11:41:23Z | c++ | 2021-12-02T18:37:33Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,249 | ["test/functional/p2p_segwit.py"] | Intermittent failure in p2p_segwit.py "AssertionError: No exception raised" | https://travis-ci.org/github/bitcoin/bitcoin/jobs/738951476#L3128:
```
2020-10-26T12:45:49.099000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/home/travis/build/bitcoin/bitcoin/ci/scratch/build/bitcoin-s390x-linux-gnu/test/functional/test_framework/test_framework.py", line 125, in main
self.run_test()
File "/home/travis/build/bitcoin/bitcoin/ci/scratch/build/bitcoin-s390x-linux-gnu/test/functional/p2p_segwit.py", line 308, in run_test
self.test_superfluous_witness()
File "/home/travis/build/bitcoin/bitcoin/ci/scratch/build/bitcoin-s390x-linux-gnu/test/functional/p2p_segwit.py", line 319, in func_wrapper
func(self, *args, **kwargs)
File "/home/travis/build/bitcoin/bitcoin/ci/scratch/build/bitcoin-s390x-linux-gnu/test/functional/p2p_segwit.py", line 2107, in test_superfluous_witness
assert_raises_rpc_error(-22, "TX decode failed", self.nodes[0].decoderawtransaction, serialize_with_bogus_witness(tx).hex())
File "/home/travis/build/bitcoin/bitcoin/ci/scratch/build/bitcoin-s390x-linux-gnu/test/functional/test_framework/util.py", line 123, in assert_raises_rpc_error
assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
AssertionError: No exception raised
``` | https://github.com/bitcoin/bitcoin/issues/20249 | https://github.com/bitcoin/bitcoin/pull/20283 | 83650e4df5caac2dbe734f9021430e525d5cc6a5 | 6954e4d16c1c14142c400e561224fcc98bf6a519 | 2020-10-26T20:45:25Z | c++ | 2020-11-05T06:56:02Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,246 | ["doc/JSON-RPC-interface.md"] | Document JSON-RPC wallet endpoints | It appears we don't have any documentation of the /wallet/<walletname> JSON-RPC endpoint. Maybe JSON-RPC-interface.md is a good place to put it. | https://github.com/bitcoin/bitcoin/issues/20246 | https://github.com/bitcoin/bitcoin/pull/27225 | 436c185b05200e28696ef6ff64e679c3148f72bb | e43fdfd9adf253d94d1d428d3d177101fd56eb19 | 2020-10-26T14:06:03Z | c++ | 2023-06-02T15:27:27Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,239 | ["contrib/seeds/generate-seeds.py", "contrib/seeds/nodes_main.txt", "contrib/seeds/nodes_test.txt", "src/chainparams.cpp", "src/chainparams.h", "src/chainparamsseeds.h", "src/net.cpp"] | Hardcoded seeds for Torv3 addresses | For the 0.22 release we'll want to start hardcoding Torv3 addresses instead of (or in addition to) Torv2.
The biggest challenge here is not how to hardcode them, although that will require a few minor script and code changes, but how to collect them. The release process is to get the addresses from DNS seeders, however these currently don't support the `addrv2` message nor Torv3 addresses in the first place. Nor do they really have a need to. | https://github.com/bitcoin/bitcoin/issues/20239 | https://github.com/bitcoin/bitcoin/pull/21560 | 1a7dec77f610607b1f0c5113bd5b6939b04717df | 9be7fe4849310884294669b019dd8300f69bc334 | 2020-10-25T19:41:27Z | c++ | 2021-04-06T08:47:51Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,219 | ["src/rpc/util.cpp", "src/wallet/rpcwallet.cpp", "test/functional/rpc_fundrawtransaction.py", "test/functional/rpc_psbt.py", "test/functional/wallet_basic.py", "test/functional/wallet_bumpfee.py", "test/functional/wallet_send.py"] | RPC bumpfee error with explicit feerate | RPC bumpfee with an explicit feerate using `conf_target` and `estimate_mode` errors with `JSONRPCException: JSON integer out of range (-1)`. | https://github.com/bitcoin/bitcoin/issues/20219 | https://github.com/bitcoin/bitcoin/pull/20220 | 17c6fb176a07d86f96f7cf41164c4b71cd1b3765 | 5d32009f1a3b091299ff4a9345195b2359125f98 | 2020-10-22T16:44:01Z | c++ | 2020-11-04T03:35:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,181 | ["src/wallet/wallet.cpp", "src/wallet/wallet.h", "test/functional/test_runner.py", "test/functional/wallet_transactiontime_rescan.py"] | Wrong `time` when importing transactions with `rescanblockchain ` RPC command | When using the `rescanblockchain` wallet RPC command, it seems like sometimes (though not always, and I couldn't find a specific pattern for when this does and doesn't happen) the `time` field of all transactions found is being set to the time of the most recent transaction detected. Besides that field, all data (including block and blocktime) return correctly. What's more, even in a node with `txindex=1` this happens, despite that when calling the (non-wallet-specific) `getrawtransaction` command, it returns the correct time.
Here's an example of a testnet transaction where I experienced this behaviour, and the output of Core where the same `txid` has. 2 different `time`s - a correct one using `getrawtransaction` and an incorrect one using `gettransaction`:
```
bitcoin-cli --testnet -rpcwallet=wallet getrawtransaction 8bacfc9c63d181e9d303f57f550fe72870afd640c961466829c6212bb23a72fe 1
{
"txid": "8bacfc9c63d181e9d303f57f550fe72870afd640c961466829c6212bb23a72fe",
"hash": "3de22064b8fec52fb183a8ad46fd011e6c6cab9906a008afa3d649d11bd250f1",
"version": 2,
"size": 222,
"vsize": 141,
"weight": 561,
"locktime": 0,
"vin": [
{
"txid": "685571776adce2ac3332faf6ed125235366cc3cb464604c9234bf371f1ab4e02",
"vout": 0,
"scriptSig": {
"asm": "",
"hex": ""
},
"txinwitness": [
"30440220516d0b313aae44f639a111dac8f27bc1fac446345aaad51852a784620ac62c690220433cb7fdeb78cd84574ec0ddd08789a248fe19b71759e1b3b448ff9c3f980be401",
"03eca8ceb44c4d930ab89fb5d721d02a745e4aeb0f75993fa535e98fb6c7f6e16e"
],
"sequence": 4294967294
}
],
"vout": [
{
"value": 0.53891045,
"n": 0,
"scriptPubKey": {
"asm": "0 f3020d45a9ccf870ddf4176fde4420931ffd9af6",
"hex": "0014f3020d45a9ccf870ddf4176fde4420931ffd9af6",
"reqSigs": 1,
"type": "witness_v0_keyhash",
"addresses": [
"tb1q7vpq63dfenu8ph05zahau3pqjv0lmxhk73dsjm"
]
}
},
{
"value": 0.10000000,
"n": 1,
"scriptPubKey": {
"asm": "0 bf702bf755da860153e7b1043fea160c6dcd9f1a",
"hex": "0014bf702bf755da860153e7b1043fea160c6dcd9f1a",
"reqSigs": 1,
"type": "witness_v0_keyhash",
"addresses": [
"tb1qhaczha64m2rqz5l8kyzrl6skp3kum8c6m0c2h4"
]
}
}
],
"hex": "02000000000101024eabf171f34b23c9044646cbc36c36355212edf6fa3233ace2dc6a777155680000000000feffffff02e54f360300000000160014f3020d45a9ccf870ddf4176fde4420931ffd9af68096980000000000160014bf702bf755da860153e7b1043fea160c6dcd9f1a024730440220516d0b313aae44f639a111dac8f27bc1fac446345aaad51852a784620ac62c690220433cb7fdeb78cd84574ec0ddd08789a248fe19b71759e1b3b448ff9c3f980be4012103eca8ceb44c4d930ab89fb5d721d02a745e4aeb0f75993fa535e98fb6c7f6e16e00000000",
"blockhash": "00000000000000bc3b97cbe323c4695f39a65cc1d73060dca8ad084fb0ce61b5",
"confirmations": 27528,
"time": 1600623861,
"blocktime": 1600623861
}
```
```
bitcoin-cli --testnet -rpcwallet=wallet gettransaction 8bacfc9c63d181e9d303f57f550fe72870afd640c961466829c6212bb23a72fe
{
"amount": -0.10000000,
"fee": -0.00000142,
"confirmations": 27528,
"blockhash": "00000000000000bc3b97cbe323c4695f39a65cc1d73060dca8ad084fb0ce61b5",
"blockheight": 1835261,
"blockindex": 24,
"blocktime": 1600623861,
"txid": "8bacfc9c63d181e9d303f57f550fe72870afd640c961466829c6212bb23a72fe",
"walletconflicts": [
],
"time": 1601486746,
"timereceived": 1602570577,
"bip125-replaceable": "no",
"details": [
{
"involvesWatchonly": true,
"address": "tb1q7vpq63dfenu8ph05zahau3pqjv0lmxhk73dsjm",
"category": "send",
"amount": -0.53891045,
"label": "Change #5",
"vout": 0,
"fee": -0.00000142,
"abandoned": false
},
{
"involvesWatchonly": true,
"address": "tb1qhaczha64m2rqz5l8kyzrl6skp3kum8c6m0c2h4",
"category": "send",
"amount": -0.10000000,
"vout": 1,
"fee": -0.00000142,
"abandoned": false
},
{
"involvesWatchonly": true,
"address": "tb1q7vpq63dfenu8ph05zahau3pqjv0lmxhk73dsjm",
"category": "receive",
"amount": 0.53891045,
"label": "Change #5",
"vout": 0
}
],
"hex": "02000000000101024eabf171f34b23c9044646cbc36c36355212edf6fa3233ace2dc6a777155680000000000feffffff02e54f360300000000160014f3020d45a9ccf870ddf4176fde4420931ffd9af68096980000000000160014bf702bf755da860153e7b1043fea160c6dcd9f1a024730440220516d0b313aae44f639a111dac8f27bc1fac446345aaad51852a784620ac62c690220433cb7fdeb78cd84574ec0ddd08789a248fe19b71759e1b3b448ff9c3f980be4012103eca8ceb44c4d930ab89fb5d721d02a745e4aeb0f75993fa535e98fb6c7f6e16e00000000"
}
``` | https://github.com/bitcoin/bitcoin/issues/20181 | https://github.com/bitcoin/bitcoin/pull/20591 | b55232a337fae4200085cf6229712549488656fa | 6a5381a06b0b9b4490394e42a8e3bc284601a4af | 2020-10-18T18:02:04Z | c++ | 2021-09-28T22:18:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,143 | ["test/functional/wallet_resendwallettransactions.py"] | qa: Intermittent error in wallet_resendwallettransactions.py | https://travis-ci.org/github/hebasto/bitcoin/jobs/735078189#L5109:
```
AssertionError: Predicate ''''
def test_function():
if check_connected:
assert self.is_connected
return test_function_in()
''' not true after 240.0 seconds
``` | https://github.com/bitcoin/bitcoin/issues/20143 | https://github.com/bitcoin/bitcoin/pull/20112 | 7012db2a6bcd38cc820771fc9fd7fef13772ea32 | 88271184e82222f556d67511cc64230b0532f40d | 2020-10-13T11:34:09Z | c++ | 2020-10-22T12:18:06Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,135 | ["src/timedata.cpp"] | UBSan warning when fuzzing abs64(...) | When extending the `test/fuzz/integer` fuzzer I noticed the following UBSan warning when fuzzing `abs64(...)`:
```
runtime error: negation of -9223372036854775808 cannot be represented in type 'int64_t' (aka 'long'); cast to an unsigned type to negate this value to itself
```
Fuzzing harness:
```diff
diff --git a/src/test/fuzz/integer.cpp b/src/test/fuzz/integer.cpp
index 35d6804d4..bc158e5a2 100644
--- a/src/test/fuzz/integer.cpp
+++ b/src/test/fuzz/integer.cpp
@@ -40,6 +40,8 @@
#include <set>
#include <vector>
void initialize()
{
SelectParams(CBaseChainParams::REGTEST);
@@ -82,6 +84,7 @@ void test_one_input(const std::vector<uint8_t>& buffer)
(void)ComputeMerkleRoot(v256);
(void)CountBits(u64);
(void)DecompressAmount(u64);
+ (void)abs64(i64);
(void)FormatISO8601Date(i64);
(void)FormatISO8601DateTime(i64);
// FormatMoney(i) not defined when i == std::numeric_limits<int64_t>::min()
```
Typically `abs(I n)` type functions are not defined when `n == std::numeric_limits<I>::min()` so it could be argued that this is expected, but perhaps the function could be rewritten in a way which guarantees that it gives the same behaviour across systems (instead of UB).
| https://github.com/bitcoin/bitcoin/issues/20135 | https://github.com/bitcoin/bitcoin/pull/20141 | f79a4a895279ba4efa43494270633f94f7d18342 | ad90dd9f313aa4a2f87675b4392b85c0b06a5a83 | 2020-10-12T19:10:54Z | c++ | 2020-10-13T12:00:39Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,127 | ["src/test/netbase_tests.cpp"] | Gitian build is broken after #19954 | Comment from Marco [here](https://github.com/bitcoin/bitcoin/pull/19954#discussion_r503075378):
> + make -C src --jobs=1 check-security V=1
make: Entering directory '/bitcoin/distsrc-x86_64-linux-gnu/src'
Checking binary security...
READELF=/gnu/store/pzq9s5ldl90h72p26jkdakyccdg9ib3k-profile/bin/x86_64-linux-gnu-readelf OBJDUMP=x86_64-linux-gnu-objdump OTOOL= /gnu/store/pzq9s5ldl90h72p26jkdakyccdg9ib3k-profile/bin/python3.7 ../contrib/devtools/security-check.py bitcoind bitcoin-cli bitcoin-tx bitcoin-wallet test/test_bitcoin bench/bench_bitcoin qt/bitcoin-qt
make: Leaving directory '/bitcoin/distsrc-x86_64-linux-gnu/src'
> + case "$HOST" in
> + make -C src --jobs=1 check-symbols V=1
make: Entering directory '/bitcoin/distsrc-x86_64-linux-gnu/src'
Checking glibc back compat...
READELF=/gnu/store/pzq9s5ldl90h72p26jkdakyccdg9ib3k-profile/bin/x86_64-linux-gnu-readelf CPPFILT=/gnu/store/pzq9s5ldl90h72p26jkdakyccdg9ib3k-profile/bin/x86_64-linux-gnu-c++filt /gnu/store/pzq9s5ldl90h72p26jkdakyccdg9ib3k-profile/bin/python3.7 ../contrib/devtools/symbol-check.py bitcoind bitcoin-cli bitcoin-tx bitcoin-wallet test/test_bitcoin bench/bench_bitcoin qt/bitcoin-qt
test/test_bitcoin: export of symbol in6addr_loopback not allowed
test/test_bitcoin: failed EXPORTED_SYMBOLS
make: *** [Makefile:20952: check-symbols] Error 1
make: Leaving directory '/bitcoin/distsrc-x86_64-linux-gnu/src'
**test/test_bitcoin: export of symbol in6addr_loopback not allowed** | https://github.com/bitcoin/bitcoin/issues/20127 | https://github.com/bitcoin/bitcoin/pull/20129 | e21b824386bf9befdab44a60c9f58a450147739e | 3750f664b349c759e715ba0b9e1a64e1ea07c782 | 2020-10-12T07:02:59Z | c++ | 2020-10-14T08:33:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,104 | ["configure.ac", "doc/dependencies.md", "src/qt/bitcoin.cpp"] | [RFC] qt: Minimum required Qt5 | As branching `0.21.0` off is [approaching](https://github.com/bitcoin/bitcoin/issues/18947) it seems a good time to discuss a possible bumping of the minimum required Qt5 version.
The current minimum required Qt is 5.5.1. Set in #15393. Recent discussion in #13478.
Distro support:
- stretch -- [5.7.1](https://packages.debian.org/stretch/libqt5core5a)
- buster -- [5.11.3](https://packages.debian.org/buster/libqt5core5a)
- bionic -- [5.9.5](https://packages.ubuntu.com/bionic/libqt5core5a)
- focal -- [5.12.8](https://packages.ubuntu.com/focal/libqt5core5a)
- centos 7 -- [5.9.7](http://mirror.centos.org/centos/7/os/x86_64/Packages/qt5-qtbase-5.9.7-2.el7.x86_64.rpm)
- centos 8 -- [5.12.5](http://mirror.centos.org/centos/8/AppStream/x86_64/os/Packages/qt5-qtbase-5.12.5-4.el8.x86_64.rpm)
Bumping to 5.9 (LTS) is possible, but it won't be of much benefit to us. Also, its support [ended](https://www.qt.io/blog/2017/06/07/renewed-qt-support-services) on 2020-05-31.
5.10 could bring much more benefits to us, e.g.:
- functor-parameter overload of [`QMetaObject::invokeMethod`](https://doc.qt.io/qt-5/qmetaobject.html#invokeMethod-4)
- fixed https://bugreports.qt.io/browse/QTBUG-10907 | https://github.com/bitcoin/bitcoin/issues/20104 | https://github.com/bitcoin/bitcoin/pull/21286 | fb67caebe26f49a1edfff20c754b8217ef4f23ad | e52ce9f2b312b3cf3b0837918e07d7603e241d63 | 2020-10-08T10:24:11Z | c++ | 2021-02-28T05:14:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,093 | [".cirrus.yml"] | Cirrus CI - unknown spurious failure | https://cirrus-ci.com/task/4642327564124160
I can't tell what happened, but re-running the job worked, so this seems like a spurious failure. Opening this issue in case others see the same. | https://github.com/bitcoin/bitcoin/issues/20093 | https://github.com/bitcoin/bitcoin/pull/20106 | d9de00b3e067d26cde0ea349b911d082acc8801a | 380705ef4f007463dc7951376c7bedef1f01a169 | 2020-10-06T14:18:18Z | c++ | 2020-10-09T06:44:35Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,081 | ["src/wallet/db.cpp"] | wallet: Can't Access System Volume Information | I have the C:\Users\username\AppData\Roaming\Bitcoin folder as a soft link to a separate internal drive. This apparently caused an issue when trying to access another wallet. NTFS has created a hidden folder called System Volume Information on the root of the drive where the data directory is. When I try to open another wallet inside of Bitcoin-QT, it freezes up. The error I get in the log is ListWalletDir: Access is denied C:\Users\Linrono\AppData\Roaming\Bitcoin\System Volume Information. This shows up in the logs over and over until I force close Bitcoin-QT. It took up my entire 10MB log file at one point. I also tested this using bitcoind.exe and the same thing happens when running bitcoin-cli.exe getwalletdir. An easy fix for me would be to just create a folder in the volume and move my soft link to point there. I just wanted to bring this to your attention.
**Expected behavior**
I thought I would get a list of wallets I have created in the directory with the createwallet command.
**Actual behavior**
This caused a freeze that required the program to be force closed.
**To reproduce**
Just store the Bitcoin Data Directory in the root of a Windows Volume, and then try to find local wallets. This has happened to me every time I go to File and then mouse over Open Wallet or use the listwalletdir bitcoin-cli command.
**System information**
I am using Bitcoin Core v.20.1 from the BitcoinCore.org website.
Windows 10, Ryzen 5, Hard Drive
I believe this issue is related to the NTFS system folder on the root of volumes.
ListWalletDir: Access is denied C:\Users\Linrono\AppData\Roaming\Bitcoin\System Volume Information | https://github.com/bitcoin/bitcoin/issues/20081 | https://github.com/bitcoin/bitcoin/pull/21907 | 386ba92e836387302eb2005b816dd9f972cdb5bc | a31a1ceec721c8b7fb78e657e572c7a621d4d37e | 2020-10-05T00:08:51Z | c++ | 2021-05-13T09:09:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,070 | ["src/qt/bitcoin.cpp", "src/util/system.cpp", "src/util/system.h"] | bitcoin-cli needlessly creates empty ~/.bitcoin/wallets directory | When `bitcoin-cli` is run, **it, not bitcoind** creates an empty `~/.bitcoin/wallets` direcctory with `~` bring home of currently running user. This is weird and leads to user confusion because it happens even in cases when `bitcoin-cli` connects to a `bitcoind` running under a different user or probably on other machine.
**Expected behavior**
`bitcoin-cli` never modifies filesystem, especially not things that the daemon should take care of.
**Actual behavior**
`bitcoin-cli creates empty directory`
**To reproduce**
0. make sure `~/.bitcoin` does **not** exist under user A
1. install `bitcoind` and run it under a user B
2. run `bitcoin-cli getblockchaininfo` under user A
3. `ls ~/.bitcoin` under user A
For quick setup, you can try to use [my project](https://deb.ln-ask.me) in a Debian VM or using provided Docker file. Just `apt install bitcoin-regtest bitcoin-cli`, it's already pre-configured to run under a different user, so then just running `sudo bitcoin-cli getblockchaininfo && sudo ls /root/.bitcoin` should reproduce the issue.
**System information**
0.20 official release downloaded from `https://bitcoin.org/bin/bitcoin-core-...`, verified GPG signature from Wladimir.
OS: Linux Debian Buster
CPU: Intel x86_64
Disk: NVMe SSD
FS: ext4
I don't think configuration is relevant since `bitcoin-cli` is **not** informed where to find it (via parameters or otherwise) and thus it can **not** access it. I also added `-rpcport` and `-rpccookiefile` parameters explicitly but I don't think it's relevant.
Loosely related to #16220, but not a duplicate. | https://github.com/bitcoin/bitcoin/issues/20070 | https://github.com/bitcoin/bitcoin/pull/27073 | c033720b2bc7aabf703a686e0fc024c2d25681c6 | 1258af40c0d396dd922cc8dc1b4c1719b39a4026 | 2020-10-03T13:32:00Z | c++ | 2023-02-23T21:41:14Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,066 | [".appveyor.yml"] | CI: Appveyor builds failing | Appveyor builds started failing about 20 hours ago for no reason I can discern.
I cannot replicate the failures on my Windows 10 machine. I am able to install the vcpkg dependencies from scratch and successfully build Bitcoin Core using the `msvc` build config.
I am attempting to replicate the issue in the appveyor job on my Bitcoin Core fork but as yet have not been able to narrow it down.
If anyone reads this with admin privileges for appveyor could you use the **RE-BUILD COMMIT** option on the [last successful](https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/35532413) appveyor job. If that job now also fails it would point to something changing in the appveyor environment. | https://github.com/bitcoin/bitcoin/issues/20066 | https://github.com/bitcoin/bitcoin/pull/20095 | 875e1ccc9fe01e026e564dfd39a64d9a4b332a89 | d8cd7b137fb075616f31d2b43b85fa2e27ea7477 | 2020-10-03T09:21:24Z | c++ | 2020-10-06T19:00:24Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 20,062 | ["doc/man/bitcoin-cli.1", "doc/man/bitcoin-qt.1", "doc/man/bitcoin-tx.1", "doc/man/bitcoin-wallet.1", "doc/man/bitcoind.1"] | doc: manpages include version number are outdated in master branch | https://github.com/bitcoin/bitcoin/blob/60ec57b3d73e5cef71ebf3c4cdf54a4474bf492b/doc/man/bitcoin-cli.1#L2
https://github.com/bitcoin/bitcoin/blob/60ec57b3d73e5cef71ebf3c4cdf54a4474bf492b/doc/man/bitcoin-qt.1#L2
https://github.com/bitcoin/bitcoin/blob/60ec57b3d73e5cef71ebf3c4cdf54a4474bf492b/doc/man/bitcoin-tx.1#L2
https://github.com/bitcoin/bitcoin/blob/60ec57b3d73e5cef71ebf3c4cdf54a4474bf492b/doc/man/bitcoin-wallet.1#L2
https://github.com/bitcoin/bitcoin/blob/60ec57b3d73e5cef71ebf3c4cdf54a4474bf492b/doc/man/bitcoind.1#L2
need to up to date?
but tagged version 0.20.1 looks fine.
https://github.com/bitcoin/bitcoin/blob/7ff64311bee570874c4f0dfa18f518552188df08/doc/man/bitcoind.1#L2
| https://github.com/bitcoin/bitcoin/issues/20062 | https://github.com/bitcoin/bitcoin/pull/20414 | d020e8839fa590f5c3553458de2f979af7663084 | 50e019a97a5b49caee867ec7d630fca908caed9d | 2020-10-02T09:33:07Z | c++ | 2020-11-18T13:42:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,981 | ["depends/funcs.mk"] | Issue with mpgen and RUNPATH | Pointed out by @ryanofsky in [#19685](https://github.com/bitcoin/bitcoin/pull/19685#issuecomment-692861142):
> Still confirming but it seems like this PR might be causing an error on travis: "/home/travis/build/bitcoin/bitcoin/depends/x86_64-pc-linux-gnu/share/../native/bin/mpgen: error while loading shared libraries: libcapnpc-0.7.0.so: cannot open shared object file: No such file or directory" error in https://travis-ci.org/github/bitcoin/bitcoin/jobs/726983595#L2545
> Running CI scripts locally, I'm able to reproduce the error. But if I revert the changes in this PR the error goes away. The difference seems to be caused by cmake no longer setting RUNPATH after this PR. With this PR, RUNPATH is empty, but if this PR is reverted, readelf shows:
```bash
$ readelf -d depends/x86_64-pc-linux-gnu/native/bin/mpgen | grep RUNPATH
0x000000000000001d (RUNPATH) Library runpath: [/home/russ/src/bitcoin/depends/x86_64-pc-linux-gnu/native/lib]
```
> I need to dig in more but two questions I have are:
> 1. Why did travis not catch this problem when this PR was being worked on or after this PR was merged. Is there a cache that we failed to clear? Is there a cache we should be clearing when we update depends scripts in the future? (The travis error above started happening after I pushed a PR update that bumped the `depends/packages/native_libmultiprocess.mk` package, so I think that accounts for why a cache might have been avoided in the failing run above).
> 2. What change in this PR might be clobbering the cmake RUNPATH? If I had to guess it might be happening because the LDFLAGS environment variable was unset previously, but now it is set | https://github.com/bitcoin/bitcoin/issues/19981 | https://github.com/bitcoin/bitcoin/pull/20046 | 0038ce97584f28b0718a4c9f4faa8c0c42c5fe80 | 17918a987aee4ed380758a5b2b1b0782b587d59f | 2020-09-20T04:58:01Z | c++ | 2020-12-10T03:11:50Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,966 | ["src/net.cpp", "src/net.h", "src/test/net_tests.cpp"] | Add unit tests for eviction logic | The eviction logic is one of the most important parts in our code base: a bug in the eviction logic could allow for attacker triggered network partitioning.
Unfortunately the eviction logic is currently not tested properly.
The unit tests and fuzz tests don't cover the eviction logic at all.
The functional tests cover some parts of the eviction logic but the coverage is spotty/incomplete.
Unfortunately `CConnman::AttemptToEvictConnection` is currently somewhat tricky to test.
To solve this I suggest simplifying `CConnman::AttemptToEvictConnection()` by introducing a new function ...
```
[[nodiscard]] Optional<NodeEvictionCandidate> SelectNodeToEvict(std::vector<NodeEvictionCandidate> vEvictionCandidates)
```
... which would be called from the now much simplified `CConnman::AttemptToEvictConnection`.
`SelectNodeToEvict` would contain all eviction selection logic and could thus be tested trivially.
| https://github.com/bitcoin/bitcoin/issues/19966 | https://github.com/bitcoin/bitcoin/pull/20477 | dff0f6f753eafd932d7d65fbfa33585f620e8e54 | b440c33179e777bfebb8c12840e06ea691a4868f | 2020-09-17T05:13:55Z | c++ | 2020-12-16T12:30:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,930 | ["src/crypto/siphash.cpp", "src/crypto/siphash.h"] | Signed integer overflow when SipHasher processes inputs >= 2 GB | Signed integer overflow when SipHasher processes inputs >= 2 GB.
Live demo:
```
$ src/test/fuzz/simplest_possible_siphash_fuzzer -rss_limit_mb=8000 crash-061a172add013c03beedf57eb2a121a8289696af
crypto/siphash.cpp:56:10: runtime error: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int'
$ cat src/test/fuzz/simplest_possible_siphash_fuzzer.cpp
#include <cstdint>
#include <vector>
#include <crypto/siphash.h>
void test_one_input(const std::vector<uint8_t>& buffer)
{
CSipHasher(0, 0).Write(buffer.data(), buffer.size()).Finalize();
}
```
Credits to @elichai who submitted a differential SipHasher fuzzer in #19920 and @guidovranken who first spotted the issue. Thanks!
**Remember: don't trust -- fuzz! :)** | https://github.com/bitcoin/bitcoin/issues/19930 | https://github.com/bitcoin/bitcoin/pull/19931 | ba4b3fbcf21317a9410f3be913e4437d58968091 | 06dbbe76dd027e924eb95ffc4b409daffaefe61b | 2020-09-10T05:54:05Z | c++ | 2020-09-14T08:30:17Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,928 | ["src/test/util_tests.cpp", "src/util/system.cpp"] | Sometimes wallet filenames can get their first character stripped off | https://twitter.com/2btc10000pizzas/status/1303768424133398528
No idea what could be going on here :/ | https://github.com/bitcoin/bitcoin/issues/19928 | https://github.com/bitcoin/bitcoin/pull/20080 | 42b66a6b814bca130a9ccf0a3f747cf33d628232 | 5a6f3c5a01eaf904c42bd77dbed931b49a8fec74 | 2020-09-09T18:57:00Z | c++ | 2020-11-01T22:41:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,924 | ["doc/tor.md"] | Onion address in Bitcoin Core Wallet | **Is your feature request related to a problem? Please describe.**
I am not sure if there is a RPC method available to directly get the onion address used so I checked it in `localaddresses` returned by `getnetworkinfo` https://developer.bitcoin.org/reference/rpc/getnetworkinfo.html
It was also mentioned in debug.log file:
**Describe the solution you'd like**
I would love to see an onion address and maybe qr code in the wallet if it is listening on Tor similar to [ABCore](https://github.com/greenaddress/abcore/blob/cc629a854f3083cf4bd1a743de80a254c72aa8ea/app/src/main/java/com/greenaddress/abcore/RPCIntentService.java#L134):
**Describe alternatives you've considered**
Check the onion address in debug.log or `localaddresses` returned for `getnetworkinfo`
**Additional context**
Linked to https://github.com/bitcoin/bitcoin/issues/19923 because if we add such option to check the onion address, it will have to be added in the [Tor documentation](https://github.com/bitcoin/bitcoin/blob/master/doc/tor.md).
| https://github.com/bitcoin/bitcoin/issues/19924 | https://github.com/bitcoin/bitcoin/pull/19961 | d0e76b5050a2f4af94022b7a1dc137a54ab801ce | 7ef6b1c51d4a00511a74f6d08abb942a7e433f0b | 2020-09-09T09:26:44Z | c++ | 2020-12-17T10:40:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,912 | ["src/wallet/scriptpubkeyman.cpp"] | -Wlogical-op warning in wallet/scriptpubkeyman.cpp when building current master | ```
wallet/scriptpubkeyman.cpp: In member function ‘virtual bool LegacyScriptPubKeyMan::Upgrade(int, bilingual_str&)’:
wallet/scriptpubkeyman.cpp:455:55: warning: logical ‘and’ applied to non-boolean constant [-Wlogical-op]
455 | if (m_storage.CanSupportFeature(FEATURE_HD_SPLIT) && CHDChain::VERSION_HD_CHAIN_SPLIT) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CXX wallet/libbitcoin_wallet_a-wallet.o
```
```
$ gcc --version
gcc (Gentoo 9.2.0-r2 p3) 9.2.0
```
Related - #19015. | https://github.com/bitcoin/bitcoin/issues/19912 | https://github.com/bitcoin/bitcoin/pull/19986 | c92aa8357c36a63b7a97d8a1bc09036a0d2661b3 | a1e0359618e3a66d0156d2b0a4702bc55f957a3f | 2020-09-07T20:54:36Z | c++ | 2020-10-19T03:07:11Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,885 | ["src/index/coinstatsindex.cpp", "src/rpc/blockchain.cpp", "src/validation.cpp", "src/validation.h", "test/functional/data/rpc_getblockstats.json", "test/functional/rpc_getblockstats.py"] | getblockstats RPC command has issues | the command "bitcoin-cli getblockstats 0000000000000000000c61ff8f761ce509fc8901d3c22d61fec89637042ea2ba" does not work.
It displays "error: Error parsing JSON:0000000000000000000c61ff8f761ce509fc8901d3c22d61fec89637042ea2ba"
but it should display the block stats like the documentation says.
also bitcoin-cli getblockstats 0 does not work. block number must be at least 1 to work. But blocks start at 0.
tested with 0.20.1 on freebsd, another user on IRC acknowledged the problem. | https://github.com/bitcoin/bitcoin/issues/19885 | https://github.com/bitcoin/bitcoin/pull/19888 | 2ce3d26757ed08f2e580120af9bc5e26881302a0 | 5d9b5305af4aaf9d4903d9d2996c5eea613b51a1 | 2020-09-05T17:38:59Z | c++ | 2022-12-05T22:46:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,864 | [".cirrus.yml"] | Spurious CI failure: cirrus CI timeout | Not sure if this is the right place to report it, but I saw this job failure today:
https://cirrus-ci.com/task/6078479919742976
I'll try re-running but opening this issue in case others see this kind of thing too. | https://github.com/bitcoin/bitcoin/issues/19864 | https://github.com/bitcoin/bitcoin/pull/19881 | 3ba25e3bdde3464eed5d2743d68546e48b005544 | 03689317021a72431762c1974530f2a980a7fffa | 2020-09-03T22:42:24Z | c++ | 2020-09-06T05:50:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,863 | ["src/net_processing.cpp"] | Clarify eviction protection scope of outbound block-relay-only peers | AFAICT, as of commit a0a422c, we have 2 different logics to evict outbound peers : lagging-chain (`ConsiderEviction`) and (`CheckForStaleTipAndEvictPeers`). The former to sanitize out lazy/buggy peers who have never sent us a valid header and are always staying behind our tip, the latter triggered in case of stale tip due to block variance to seek a better chain by rotating our outbound peers if we already reach an outbound limit (`EvictExtraOutboundPeers`).
Block-relay-only peers were introduced by #15719. Contrary to outbound full-relay peers who provided us at least a useful header, they're not protected by lagging-chain eviction.
We actually have a comment inside `ProcessHeadersMessage` indicating the contrary behavior. We should either document cleanly that block-relay-only aren't protected or effectively extend the scope of protection to them.
Hinted during #19724 review, see https://github.com/bitcoin/bitcoin/pull/19724#discussion_r475144532 | https://github.com/bitcoin/bitcoin/issues/19863 | https://github.com/bitcoin/bitcoin/pull/19871 | df2129a2349b1877049f250551f49a4592e73765 | 597488d37c9c358837616516d88f861f5c25f827 | 2020-09-03T21:47:53Z | c++ | 2020-10-02T14:42:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,856 | ["src/wallet/rpcdump.cpp", "src/wallet/rpcwallet.cpp", "src/wallet/scriptpubkeyman.cpp", "src/wallet/scriptpubkeyman.h", "src/wallet/test/wallet_tests.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h", "test/functional/wallet_listtransactions.py"] | Some transactions are not shown in listtransactions output |
I have two bitcoin core full nodes. I have one wallet.dat file on both nodes. One node is a master and second node is a reserve. Master signs and sends transactions. Reserve node only receives updates from network. I create new addresses on the master node only and the reserve node derives the same addresses.
I don’t use any other commands on the reserve node. The reserve node creates addresses automatically after receiving a transaction to a new address. This process is possible due to using BIP32 key derivation from one master key.
So, I have constantly synchronized master and reserve nodes. If there are problems with the master, then I switch to the reserve.
I see some strange behavior appear during this process. Some transactions are not shown in the `listtransactions` output. I did a research an found that only "in-wallet" transactions are not shown in the `listransactions`. The "in-wallet" transactions are transactions that were sent with sender’s and receiver’s keys, which are stored in my wallet. I also found that new addresses on the reserve node are created whithout a label.
After adding a label to the address the problem is gone. But adding a label requires additional steps I want to avoid.
**Expected Behavior**
Results of `listtransactions` also shown "in-wallet" transactions to addresses without labels
**Current Behavior**
Results of `listtransactions` doesn’t shown "in-wallet" transactions to addresses without labels
**Possible Solution**
- Automatic adding of a default label to the addresses, derived to the reserve node.
- Print transactions sent to addresses without labels in `listtransactions`.
**Steps to Reproduce**
1. Run and sync full nodes A and B.
2. Stop nodes A and B.
3. Copy wallet.dat from node A to node B.
4. Run nodes A and B
5. Use `getnewaddress` method on node A 10 times. Let’s assume the 10-th address is `$ADDRESS`.
6. Use `sendtoaddress` method on node A. Send 0.001 coins from another address to the `$ADDRESS`. `bitcoin-cli sendtoaddress $ADDRESS 0.001`. Let’s assume the result txid is `$TXID`.
7. Use `listtransaction "*"` method on node B. You don’t see the `$TXID` transaction in list.
8. Use `gettransactions`, or `listunspent` methods on node B. You can see the transaction details. Wallet balance changed on node B and is equal to node A.
9. Use `getaddressinfo $ADDRESS` method on node A. You can see that address had the default label (`""`).
10. Use `getaddressinfo $ADDRESS` method on node B. You can see that the address doesn’t have any label.
**Context (Environment)**
The problem is occured on any version of bitcoin core testnet and mainnet. The problem is also occured on litecoin and any bitcoin-based coins.
| https://github.com/bitcoin/bitcoin/issues/19856 | https://github.com/bitcoin/bitcoin/pull/22929 | 26a1147ce56083d7aa820ac115c16b01e47d911c | bce58bbb3d7b7351acd4c988748ba73908c60119 | 2020-09-01T13:57:24Z | c++ | 2021-12-02T18:37:33Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,853 | ["test/functional/wallet_basic.py"] | random wallet_basic failure | https://travis-ci.org/github/bitcoin/bitcoin/jobs/722945532#L2583
Probably can be avoided fairly easily. | https://github.com/bitcoin/bitcoin/issues/19853 | https://github.com/bitcoin/bitcoin/pull/19887 | 03689317021a72431762c1974530f2a980a7fffa | c91f955f44903df559ee8dfce1aa86cb89457b6e | 2020-09-01T03:27:20Z | c++ | 2020-09-06T11:03:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,812 | ["ci/test/00_setup_env_native_qt5.sh", "ci/test/05_before_script.sh", "test/functional/feature_backwards_compatibility.py", "test/functional/mempool_compatibility.py", "test/functional/wallet_upgradewallet.py", "test/get_previous_releases.py"] | ci: previous_release.py fails for C++17 Travis job on forked repo | https://travis-ci.org/github/hebasto/bitcoin/jobs/721269536 | https://github.com/bitcoin/bitcoin/issues/19812 | https://github.com/bitcoin/bitcoin/pull/19813 | f98872f1279e73419bb415a07b919f88db7976f0 | c1e0c2ad3b6cd9e7ef55287fb572cfcf10a0e660 | 2020-08-26T08:58:35Z | c++ | 2020-08-31T14:18:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,799 | ["depends/funcs.mk"] | build: Error when bulding a package in depends for HOST=x86_64-apple-darwin16 | On master (8e0f341779e1d2754432765ec09deb7488f5b093):
```
$ make -C depends qt HOST=x86_64-apple-darwin16
make: Entering directory '/home/hebasto/guix/GitHub/bitcoin/depends'
Fetching zlib-1.2.11.tar.gz from https://www.zlib.net
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 593k 100 593k 0 0 411k 0 0:00:01 0:00:01 --:--:-- 411k
/home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/zlib-1.2.11.tar.gz.temp: OK
Extracting zlib...
/home/hebasto/guix/GitHub/bitcoin/depends/sources/zlib-1.2.11.tar.gz: OK
Preprocessing zlib...
Configuring zlib...
tar: /home/hebasto/guix/GitHub/bitcoin/depends/built/x86_64-apple-darwin16/native_cctools/native_cctools-55562e4073dea0fbfd0b20e0bf69ffe6390c7f97-ee52008b72b.tar.gz: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
make: *** [funcs.mk:261: /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/zlib/1.2.11-56aa350339c/./.stamp_configured] Error 2
make: Leaving directory '/home/hebasto/guix/GitHub/bitcoin/depends
``` | https://github.com/bitcoin/bitcoin/issues/19799 | https://github.com/bitcoin/bitcoin/pull/19868 | 5e14fafb316ebd718370847aeb74b63ed5c17a59 | 43305e9810e4dd3e1305e4f0e2f4016b7dd9e907 | 2020-08-25T11:48:40Z | c++ | 2020-09-23T18:29:52Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,795 | ["src/init.cpp", "src/net.cpp", "src/net.h", "test/functional/feature_config_args.py"] | Bitcoin Core does not immediately use the fixed seed nodes if DNS seeding is disabled (-dnsseed=0) | **Expected behavior**: Disabling DNS seeding (`-dnsseed=0`) should make Bitcoin Core use the fixed seed nodes immediately on startup (assuming an empty `peers.dat`).
**Actual behavior**: The fixed seed nodes are used but only after an unnecessary 60 second timeout, and a somewhat misleading log message ("Adding fixed seed nodes as DNS doesn't seem to be available.").
**To reproduce**: `rm ~/.bitcoin/peers.dat && src/bitcoind -dnsseed=0` and wait... 💤
This issue is probably a "good first issue" :) | https://github.com/bitcoin/bitcoin/issues/19795 | https://github.com/bitcoin/bitcoin/pull/19884 | 9996b1806a189a9632c9f5023489eb47bf87ca05 | e9c037ba64dd5b073fccf059ef75db1c97abd0bd | 2020-08-24T22:03:13Z | c++ | 2021-02-12T10:49:34Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,772 | ["configure.ac", "src/Makefile.am"] | build: Cross-compiling libbitcoinconsensus for Windows fails with DEBUG=1 | ```
$ make -C depends HOST=x86_64-w64-mingw32 DEBUG=1 NO_QT=1 NO_QR=1 NO_ZMQ=1 NO_WALLET=1 NO_UPNP=1
$ ./autogen.sh
$ CONFIG_SITE=$PWD/depends/x86_64-w64-mingw32/share/config.site ./configure --disable-wallet --disable-tests --disable-bench --without-utils --without-daemon --without-gui
$ make
Making all in src
make[1]: Entering directory '/home/hebasto/guix/GitHub/bitcoin/src'
make[2]: Entering directory '/home/hebasto/guix/GitHub/bitcoin/src'
CXX support/libbitcoinconsensus_la-cleanse.lo
CXX crypto/libbitcoinconsensus_la-aes.lo
CXX crypto/libbitcoinconsensus_la-chacha_poly_aead.lo
make[3]: Entering directory '/home/hebasto/guix/GitHub/bitcoin'
make[3]: Leaving directory '/home/hebasto/guix/GitHub/bitcoin'
CXX crypto/libbitcoinconsensus_la-hkdf_sha256_32.lo
CXX crypto/libbitcoinconsensus_la-hmac_sha256.lo
CXX crypto/libbitcoinconsensus_la-hmac_sha512.lo
CXX crypto/libbitcoinconsensus_la-poly1305.lo
CXX crypto/libbitcoinconsensus_la-ripemd160.lo
CXX crypto/libbitcoinconsensus_la-sha1.lo
CXX crypto/libbitcoinconsensus_la-sha256.lo
CXX crypto/libbitcoinconsensus_la-sha512.lo
CXX crypto/libbitcoinconsensus_la-siphash.lo
CXX crypto/libbitcoinconsensus_la-sha256_sse4.lo
CXX libbitcoinconsensus_la-arith_uint256.lo
CXX consensus/libbitcoinconsensus_la-merkle.lo
CXX consensus/libbitcoinconsensus_la-tx_check.lo
CXX libbitcoinconsensus_la-hash.lo
CXX primitives/libbitcoinconsensus_la-block.lo
CXX primitives/libbitcoinconsensus_la-transaction.lo
CXX libbitcoinconsensus_la-pubkey.lo
CXX script/libbitcoinconsensus_la-bitcoinconsensus.lo
CXX script/libbitcoinconsensus_la-interpreter.lo
CXX script/libbitcoinconsensus_la-script.lo
CXX script/libbitcoinconsensus_la-script_error.lo
CXX libbitcoinconsensus_la-uint256.lo
CXX util/libbitcoinconsensus_la-strencodings.lo
make[3]: Entering directory '/home/hebasto/guix/GitHub/bitcoin/src/secp256k1'
gcc -I. -I./src -Wall -Wextra -Wno-unused-function -g -O2 -c src/gen_context.c -o gen_context.o
CXX crypto/libbitcoinconsensus_la-chacha20.lo
gcc -Wall -Wextra -Wno-unused-function -g -O2 gen_context.o -o gen_context
./gen_context
CC src/libsecp256k1_la-secp256k1.lo
CCLD libsecp256k1.la
libtool: warning: undefined symbols not allowed in x86_64-w64-mingw32 shared libraries; building static only
make[3]: Leaving directory '/home/hebasto/guix/GitHub/bitcoin/src/secp256k1'
CXXLD libbitcoinconsensus.la
/usr/bin/x86_64-w64-mingw32-ld: consensus/.libs/libbitcoinconsensus_la-merkle.o:merkle.cpp:(.text$_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorI7uint256SaIS3_EEEE16_M_invalidate_ifINS_15_After_nth_fromIN9__gnu_cxx17__normal_iteratorIPKS3_NSt9__cxx19986vectorIS3_S4_EEEEEEEEvT_[_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorI7uint256SaIS3_EEEE16_M_invalidate_ifINS_15_After_nth_fromIN9__gnu_cxx17__normal_iteratorIPKS3_NSt9__cxx19986vectorIS3_S4_EEEEEEEEvT_]+0x34): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: consensus/.libs/libbitcoinconsensus_la-merkle.o:merkle.cpp:(.text$_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorI7uint256SaIS3_EEEE16_M_invalidate_ifINS_15_After_nth_fromIN9__gnu_cxx17__normal_iteratorIPKS3_NSt9__cxx19986vectorIS3_S4_EEEEEEEEvT_[_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorI7uint256SaIS3_EEEE16_M_invalidate_ifINS_15_After_nth_fromIN9__gnu_cxx17__normal_iteratorIPKS3_NSt9__cxx19986vectorIS3_S4_EEEEEEEEvT_]+0x53): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: consensus/.libs/libbitcoinconsensus_la-tx_check.o:tx_check.cpp:(.text+0x44d): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: consensus/.libs/libbitcoinconsensus_la-tx_check.o:tx_check.cpp:(.text+0x464): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: consensus/.libs/libbitcoinconsensus_la-tx_check.o:tx_check.cpp:(.text+0x1189): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: consensus/.libs/libbitcoinconsensus_la-tx_check.o:tx_check.cpp:(.text+0x11a6): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: consensus/.libs/libbitcoinconsensus_la-tx_check.o:tx_check.cpp:(.text+0x179a): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: consensus/.libs/libbitcoinconsensus_la-tx_check.o:tx_check.cpp:(.text+0x17a1): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: consensus/.libs/libbitcoinconsensus_la-tx_check.o:tx_check.cpp:(.text$_Z14Serialize_implI13CSizeComputerNSt7__debug6vectorIhSaIhEEESaIS4_ES4_EvRT_RKNS2_IT0_T1_EERKT2_[_Z14Serialize_implI13CSizeComputerNSt7__debug6vectorIhSaIhEEESaIS4_ES4_EvRT_RKNS2_IT0_T1_EERKT2_]+0x200): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: consensus/.libs/libbitcoinconsensus_la-tx_check.o:tx_check.cpp:(.text$_Z14Serialize_implI13CSizeComputerNSt7__debug6vectorIhSaIhEEESaIS4_ES4_EvRT_RKNS2_IT0_T1_EERKT2_[_Z14Serialize_implI13CSizeComputerNSt7__debug6vectorIhSaIhEEESaIS4_ES4_EvRT_RKNS2_IT0_T1_EERKT2_]+0x217): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: consensus/.libs/libbitcoinconsensus_la-tx_check.o:tx_check.cpp:(.text$_Z14Serialize_implI13CSizeComputer5CTxInSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_[_Z14Serialize_implI13CSizeComputer5CTxInSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_]+0x1be): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: consensus/.libs/libbitcoinconsensus_la-tx_check.o:tx_check.cpp:(.text$_Z14Serialize_implI13CSizeComputer5CTxInSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_[_Z14Serialize_implI13CSizeComputer5CTxInSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_]+0x1d8): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: consensus/.libs/libbitcoinconsensus_la-tx_check.o:tx_check.cpp:(.text$_Z14Serialize_implI13CSizeComputer6CTxOutSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_[_Z14Serialize_implI13CSizeComputer6CTxOutSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_]+0x1ba): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: consensus/.libs/libbitcoinconsensus_la-tx_check.o:tx_check.cpp:(.text$_Z14Serialize_implI13CSizeComputer6CTxOutSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_[_Z14Serialize_implI13CSizeComputer6CTxOutSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_]+0x1d1): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-block.o:block.cpp:(.text+0xd09): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-block.o:block.cpp:(.text+0xd23): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-transaction.o:transaction.cpp:(.text+0x87b): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-transaction.o:transaction.cpp:(.text+0x892): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-transaction.o:transaction.cpp:(.text+0x1df3): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-transaction.o:transaction.cpp:(.text+0x1e0d): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-transaction.o:transaction.cpp:(.text+0x26f0): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-transaction.o:transaction.cpp:(.text+0x270d): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-transaction.o:transaction.cpp:(.text+0x29d1): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-transaction.o:transaction.cpp:(.text+0x3009): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-transaction.o:transaction.cpp:(.text$_Z14Serialize_implI11CHashWriterNSt7__debug6vectorIhSaIhEEESaIS4_ES4_EvRT_RKNS2_IT0_T1_EERKT2_[_Z14Serialize_implI11CHashWriterNSt7__debug6vectorIhSaIhEEESaIS4_ES4_EvRT_RKNS2_IT0_T1_EERKT2_]+0x669): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-transaction.o:transaction.cpp:(.text$_Z14Serialize_implI11CHashWriterNSt7__debug6vectorIhSaIhEEESaIS4_ES4_EvRT_RKNS2_IT0_T1_EERKT2_[_Z14Serialize_implI11CHashWriterNSt7__debug6vectorIhSaIhEEESaIS4_ES4_EvRT_RKNS2_IT0_T1_EERKT2_]+0x680): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-transaction.o:transaction.cpp:(.text$_Z14Serialize_implI11CHashWriter5CTxInSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_[_Z14Serialize_implI11CHashWriter5CTxInSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_]+0x69b): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-transaction.o:transaction.cpp:(.text$_Z14Serialize_implI11CHashWriter5CTxInSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_[_Z14Serialize_implI11CHashWriter5CTxInSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_]+0x6b5): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-transaction.o:transaction.cpp:(.text$_Z14Serialize_implI11CHashWriter6CTxOutSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_[_Z14Serialize_implI11CHashWriter6CTxOutSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_]+0x671): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: primitives/.libs/libbitcoinconsensus_la-transaction.o:transaction.cpp:(.text$_Z14Serialize_implI11CHashWriter6CTxOutSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_[_Z14Serialize_implI11CHashWriter6CTxOutSaIS1_ES1_EvRT_RKNSt7__debug6vectorIT0_T1_EERKT2_]+0x688): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-bitcoinconsensus.o:bitcoinconsensus.cpp:(.text$_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorIhSaIhEEEE16_M_invalidate_ifINS_15_After_nth_fromIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhS3_EEEEEEEEvT_[_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorIhSaIhEEEE16_M_invalidate_ifINS_15_After_nth_fromIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhS3_EEEEEEEEvT_]+0x34): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-bitcoinconsensus.o:bitcoinconsensus.cpp:(.text$_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorIhSaIhEEEE16_M_invalidate_ifINS_15_After_nth_fromIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhS3_EEEEEEEEvT_[_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorIhSaIhEEEE16_M_invalidate_ifINS_15_After_nth_fromIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhS3_EEEEEEEEvT_]+0x53): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text+0x5c60): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text+0x5c77): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text+0x6560): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text+0x657a): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text+0x6c3f): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text+0x6c59): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text+0x7dbe): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text+0x7dd8): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text+0x848f): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text+0x84a9): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text+0x8b65): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text+0x8b7c): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text+0x9239): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text+0x9250): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text$_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorINS2_IhSaIhEEESaIS4_EEEE16_M_invalidate_ifINS_9_Equal_toIN9__gnu_cxx17__normal_iteratorIPKS4_NSt9__cxx19986vectorIS4_S5_EEEEEEEEvT_[_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorINS2_IhSaIhEEESaIS4_EEEE16_M_invalidate_ifINS_9_Equal_toIN9__gnu_cxx17__normal_iteratorIPKS4_NSt9__cxx19986vectorIS4_S5_EEEEEEEEvT_]+0x2e): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text$_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorINS2_IhSaIhEEESaIS4_EEEE16_M_invalidate_ifINS_9_Equal_toIN9__gnu_cxx17__normal_iteratorIPKS4_NSt9__cxx19986vectorIS4_S5_EEEEEEEEvT_[_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorINS2_IhSaIhEEESaIS4_EEEE16_M_invalidate_ifINS_9_Equal_toIN9__gnu_cxx17__normal_iteratorIPKS4_NSt9__cxx19986vectorIS4_S5_EEEEEEEEvT_]+0x4e): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text$_ZN7CScriptC1EN11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhSaIhEEEEENSt7__debug6vectorIhS8_EESt26random_access_iterator_tagEESF_[_ZN7CScriptC1EN11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhSaIhEEEEENSt7__debug6vectorIhS8_EESt26random_access_iterator_tagEESF_]+0x328): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text$_ZN7CScriptC1EN11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhSaIhEEEEENSt7__debug6vectorIhS8_EESt26random_access_iterator_tagEESF_[_ZN7CScriptC1EN11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhSaIhEEEEENSt7__debug6vectorIhS8_EESt26random_access_iterator_tagEESF_]+0x342): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text$_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorINS2_IhSaIhEEESaIS4_EEEE16_M_invalidate_ifINS_15_After_nth_fromIN9__gnu_cxx17__normal_iteratorIPKS4_NSt9__cxx19986vectorIS4_S5_EEEEEEEEvT_[_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorINS2_IhSaIhEEESaIS4_EEEE16_M_invalidate_ifINS_15_After_nth_fromIN9__gnu_cxx17__normal_iteratorIPKS4_NSt9__cxx19986vectorIS4_S5_EEEEEEEEvT_]+0x36): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text$_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorINS2_IhSaIhEEESaIS4_EEEE16_M_invalidate_ifINS_15_After_nth_fromIN9__gnu_cxx17__normal_iteratorIPKS4_NSt9__cxx19986vectorIS4_S5_EEEEEEEEvT_[_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorINS2_IhSaIhEEESaIS4_EEEE16_M_invalidate_ifINS_15_After_nth_fromIN9__gnu_cxx17__normal_iteratorIPKS4_NSt9__cxx19986vectorIS4_S5_EEEEEEEEvT_]+0x69): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text$_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorIhSaIhEEEE16_M_invalidate_ifINS_9_Equal_toIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhS3_EEEEEEEEvT_[_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorIhSaIhEEEE16_M_invalidate_ifINS_9_Equal_toIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhS3_EEEEEEEEvT_]+0x2e): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text$_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorIhSaIhEEEE16_M_invalidate_ifINS_9_Equal_toIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhS3_EEEEEEEEvT_[_ZN11__gnu_debug14_Safe_sequenceINSt7__debug6vectorIhSaIhEEEE16_M_invalidate_ifINS_9_Equal_toIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhS3_EEEEEEEEvT_]+0x4e): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text$_ZN7CScriptlsERKNSt7__debug6vectorIhSaIhEEE[_ZN7CScriptlsERKNSt7__debug6vectorIhSaIhEEE]+0x4ec): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-interpreter.o:interpreter.cpp:(.text$_ZN7CScriptlsERKNSt7__debug6vectorIhSaIhEEE[_ZN7CScriptlsERKNSt7__debug6vectorIhSaIhEEE]+0x506): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-script.o:script.cpp:(.text+0x27f1): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-script.o:script.cpp:(.text+0x280b): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-script.o:script.cpp:(.text$_Z6HexStrIN11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhSaIhEEEEENSt7__debug6vectorIhS8_EESt26random_access_iterator_tagEEENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEET_SM_[_Z6HexStrIN11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhSaIhEEEEENSt7__debug6vectorIhS8_EESt26random_access_iterator_tagEEENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEET_SM_]+0x6fa): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: script/.libs/libbitcoinconsensus_la-script.o:script.cpp:(.text$_Z6HexStrIN11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhSaIhEEEEENSt7__debug6vectorIhS8_EESt26random_access_iterator_tagEEENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEET_SM_[_Z6HexStrIN11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPKhNSt9__cxx19986vectorIhSaIhEEEEENSt7__debug6vectorIhS8_EESt26random_access_iterator_tagEEENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEET_SM_]+0x714): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: util/.libs/libbitcoinconsensus_la-strencodings.o:strencodings.cpp:(.text+0x3465): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: util/.libs/libbitcoinconsensus_la-strencodings.o:strencodings.cpp:(.text+0x347c): undefined reference to `__imp_pthread_mutex_unlock'
/usr/bin/x86_64-w64-mingw32-ld: util/.libs/libbitcoinconsensus_la-strencodings.o:strencodings.cpp:(.text+0x4263): undefined reference to `__imp_pthread_mutex_lock'
/usr/bin/x86_64-w64-mingw32-ld: util/.libs/libbitcoinconsensus_la-strencodings.o:strencodings.cpp:(.text+0x427a): undefined reference to `__imp_pthread_mutex_unlock'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:7975: libbitcoinconsensus.la] Error 1
make[2]: Leaving directory '/home/hebasto/guix/GitHub/bitcoin/src'
make[1]: *** [Makefile:18819: all-recursive] Error 1
make[1]: Leaving directory '/home/hebasto/guix/GitHub/bitcoin/src'
make: *** [Makefile:794: all-recursive] Error 1
``` | https://github.com/bitcoin/bitcoin/issues/19772 | https://github.com/bitcoin/bitcoin/pull/27146 | a2877f7ad3a58327215f782003a85a6f46486e4c | 82793f1984911774b111117f2e81d5f3b0bbec68 | 2020-08-20T21:00:33Z | c++ | 2023-02-27T14:41:47Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,749 | ["test/functional/wallet_groups.py"] | Intermittent CI failure: wallet_groups.py | Intermittent CI failure: `wallet_groups.py`
Details:
* https://github.com/bitcoin/bitcoin/pull/19739/checks?check_run_id=993306684
* https://cirrus-ci.com/task/5395389866049536 | https://github.com/bitcoin/bitcoin/issues/19749 | https://github.com/bitcoin/bitcoin/pull/19756 | 772cb03a281638079051a4e5068559a4d9b1fda8 | e6e277f9ed4da7aff9b7b39a7838bada0c3e572a | 2020-08-17T14:40:36Z | c++ | 2020-08-18T06:18:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,748 | ["doc/files.md", "src/addrdb.cpp", "src/addrdb.h", "src/banman.cpp", "src/banman.h", "src/init.cpp", "src/test/denialofservice_tests.cpp", "src/test/fuzz/banman.cpp", "src/test/util/setup_common.cpp", "test/functional/rpc_setban.py"] | Deprecate banlist.dat | `banlist.dat` was introduced in https://github.com/bitcoin/bitcoin/pull/6310, storing nodes that were automatically banned (due to exceeding the misbehavior threshold) and manually banned (through the `setban` RPC).
Automatic bans were removed in https://github.com/bitcoin/bitcoin/pull/19219 and replaced with a discouragement filter. That filter is not saved to disk/persisted over shutdown/startup. The `banlist.dat` therefore now only contains addresses that have been banned through the `setban` rpc.
Since https://github.com/bitcoin/bitcoin/pull/15935, we have a specific file for configuration that is updated through the RPC and persisted over shutdown/startup, namely `settings.json`. We should therefore move the manual ban configuration from `banlist.dat` to `settings.json`. Doing so has a couple of benefits:
- `settings.json` is human readable and easily analyzable by any json parser.
- we wouldn't need to maintain custom [de]serialization code for the `banlist.dat` file.
`banlist.dat` is expected to be fairly small and infrequently updated, so disk space/performance are not huge concerns. | https://github.com/bitcoin/bitcoin/issues/19748 | https://github.com/bitcoin/bitcoin/pull/20966 | 03aa59a4e58f6cf98bc803699ea4e117bdc2a9f1 | d6e0d78c31557660274ef53cac912c468eecbe2d | 2020-08-17T14:21:43Z | c++ | 2021-06-23T08:01:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,744 | [".cirrus.yml", ".travis.yml"] | Intermittent CI failure: rpc_psbt.py --descriptors | Intermittent CI failure: `rpc_psbt.py --descriptors`
The PR in question ("tests: Add fuzzing harness for TorController", #19288) is not touching anything PSBT related :)
Details:
* https://github.com/bitcoin/bitcoin/pull/19288/checks?check_run_id=985814534
* https://cirrus-ci.com/task/5558273334050816
| https://github.com/bitcoin/bitcoin/issues/19744 | https://github.com/bitcoin/bitcoin/pull/19746 | a2a250c7d07bcb80cefca9dd4a7ce57f41291334 | c6532fa6c14d3cea5941cff9411937db9a8d5f1a | 2020-08-17T07:59:39Z | c++ | 2020-08-19T08:12:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,729 | ["ci/test/00_setup_env.sh", "ci/test/00_setup_env_native_asan.sh", "ci/test/00_setup_env_native_tsan.sh", "ci/test/00_setup_env_native_valgrind.sh", "ci/test/06_script_b.sh", "test/functional/wallet_basic.py"] | test: Intermittent "no RPC connection" in wallet_basic.py --descriptors | https://cirrus-ci.com/task/4981335074799616?command=ci#L2022 | https://github.com/bitcoin/bitcoin/issues/19729 | https://github.com/bitcoin/bitcoin/pull/19730 | 4cde97374d5c7fc22cc0a13f2f74ca45af33279d | 3ab2582c7fe76d2839ab493512758d5601903c86 | 2020-08-15T06:11:46Z | c++ | 2020-08-15T13:39:02Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,712 | ["test/sanitizer_suppressions/tsan"] | test: Data race detected when running rpc_blockchain.py | https://cirrus-ci.com/task/6068765160898560?command=ci#L5518 | https://github.com/bitcoin/bitcoin/issues/19712 | https://github.com/bitcoin/bitcoin/pull/19830 | 6eb97fb82382e8be7166e293887afbca3d4af40a | f89b4f895fc6f116db85ae73afb882d3c21bfd35 | 2020-08-13T16:59:13Z | c++ | 2020-08-31T01:59:21Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,702 | ["configure.ac", "src/index/blockfilterindex.cpp", "src/script/bitcoinconsensus.cpp", "src/test/util_tests.cpp"] | Enable unused member function diagnostic by default | Enable unused member function diagnostic by default.
Clang has a nice compiler diagnostic `-Wunused-member-function` which is good at catching accidentally dead/unreachable code.
While dead/unreachable code is most often harmless from a security/robustness perspective there are instances where dead/unreachable code may be an indication of more serious issues. Enabling this diagnostic allows us to find such cases and reason about which is which.
See concept ACKs for enabling this diagnostic in #19015.
Current warnings in `master` that would need to be addressed when enabling this diagnostic:
```
index/blockfilterindex.cpp:54:5: warning: unused member function 'DBHeightKey' [-Wunused-member-function]
script/bitcoinconsensus.cpp:50:9: warning: unused member function 'GetType' [-Wunused-member-function]
```
#### Useful skills:
Basic understanding of C++. See #19015 for an example on how to enable a compiler diagnostic by editing `configure.ac`.
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/19702 | https://github.com/bitcoin/bitcoin/pull/19846 | 34322b7f5cbdf05d625dff671b6c2f34749cd2b1 | fafd725a7c6cfc64f37af5074a8cf660db93e0ea | 2020-08-12T09:25:30Z | c++ | 2021-01-05T11:06:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,676 | ["doc/release-notes-19776.md", "src/net.cpp", "src/net.h", "src/net_processing.cpp", "src/rpc/net.cpp", "test/functional/p2p_compactblocks.py"] | Expose compact blocks high-bandwidth mode state through getpeerinfo | For every peer expose through `getpeerinfo` RPC whether or not we selected them as HB peers, and whether or not they selected us as HB peers.
Suggestion by @gmaxwell. | https://github.com/bitcoin/bitcoin/issues/19676 | https://github.com/bitcoin/bitcoin/pull/19776 | f5b2ea3e591822c9cb132106f47a209f88c605d1 | 22f13c1e088e0e39b4ad17fdef302c22f672ea16 | 2020-08-06T22:26:26Z | c++ | 2020-12-10T07:21:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,625 | ["src/rpc/mining.cpp"] | rpc: Missing/wrong fields in getblocktemplate Result example | Invoking ```bitcoin-cli help getblocktemplate``` shows the following as example result:
```
{ (json object)
"version" : n, (numeric) The preferred block version
"rules" : [ (json array) specific block rules that are to be enforced
"str", (string) rulename
...
],
"vbavailable" : { (json object) set of pending, supported versionbit (BIP 9) softfork deployments
"rulename" : n, (numeric) identifies the bit number as indicating acceptance and readiness for the named softfork rule
...
},
"vbrequired" : n, (numeric) bit mask of versionbits the server requires set in submissions
"previousblockhash" : "str", (string) The hash of current highest block
"" : [ (json array) contents of non-coinbase transactions that should be included in the next block
{ (json object)
"data" : "hex", (string) transaction data encoded in hexadecimal (byte-for-byte)
"txid" : "hex", (string) transaction id encoded in little-endian hexadecimal
"hash" : "hex", (string) hash encoded in little-endian hexadecimal (including witness data)
"depends" : [ (json array) array of numbers
n, (numeric) transactions before this one (by 1-based index in 'transactions' list) that must be present in the final block if this one is
...
],
"fee" : n, (numeric) difference in value between transaction inputs and outputs (in satoshis); for coinbase transactions, this is a negative Number of the total collected block fees (ie, not including the block subsidy); if key is not present, fee is unknown and clients MUST NOT assume there isn't one
"sigops" : n, (numeric) total SigOps cost, as counted for purposes of block limits; if key is not present, sigop cost is unknown and clients MUST NOT assume it is zero
"weight" : n (numeric) total transaction weight, as counted for purposes of block limits
},
...
],
"coinbaseaux" : { (json object) data that should be included in the coinbase's scriptSig content
...
},
"coinbasevalue" : n, (numeric) maximum allowable input to coinbase transaction, including the generation award and transaction fees (in satoshis)
"coinbasetxn" : { (json object) information for coinbase transaction
...
},
"target" : "str", (string) The hash target
"mintime" : xxx, (numeric) The minimum timestamp appropriate for the next block time, expressed in UNIX epoch time
"mutable" : [ (json array) list of ways the block template may be changed
"str", (string) A way the block template may be changed, e.g. 'time', 'transactions', 'prevblock'
...
],
"noncerange" : "hex", (string) A range of valid nonces
"sigoplimit" : n, (numeric) limit of sigops in blocks
"sizelimit" : n, (numeric) limit of block size
"weightlimit" : n, (numeric) limit of block weight
"curtime" : xxx, (numeric) current timestamp in UNIX epoch time
"bits" : "str", (string) compressed target of next block
"height" : n (numeric) The height of the next block
}
```
actual result has more fields (**capabilities**, **transactions**(probably the field without a name), **default_witness_commitment**, **longpollid**) one field is missing (**coinbasetxn**):
```
{
"capabilities": [
"proposal"
],
"version": 536870912,
"rules": [
"csv",
"!segwit"
],
"vbavailable": {
},
"vbrequired": 0,
"previousblockhash": "000000005b00d9476d756947955556e6db801c676e6650118d633e66e800b940",
"transactions": [
{
"data": "02000000000106a84cea3a37cfe6a38c12fbf64761ac926c2f4ab05bbdac5b187e438f40860cc00000000017160014422b977c6a28f69359e2f0dfb6aa5197e466e5b8fdffffff33d588cec09c12f009fa9663a3db4390a4e8ddafe7d9a31092b3d$
"txid": "9493cb4f621a1f95a264526f216914f741e6f01bff3dfdab5ab9ec81c3ce16a5",
"hash": "543794756b046709b40c22ed9d0aa9492ef64e1f28d193a00efd6fd06e419f0a",
"depends": [
],
"fee": 133272,
"sigops": 6,
"weight": 2467
},
...
],
"coinbaseaux": {
},
"coinbasevalue": 19864212,
"longpollid": "000000005b00d9476d756947955556e6db801c676e6650118d633e66e800b940529",
"target": "000000000000000e7e1000000000000000000000000000000000000000000000",
"mintime": 1596097882,
"mutable": [
"time",
"transactions",
"prevblock"
],
"noncerange": "00000000ffffffff",
"sigoplimit": 80000,
"sizelimit": 4000000,
"weightlimit": 4000000,
"curtime": 1596104418,
"bits": "190e7e10",
"height": 1781942,
"default_witness_commitment": "6a24aa21a9ed167e62a901109d5cbbc8d3892c8e12f66c2b52a8675df9bbb0b30fa2c033ae30"
}
``` | https://github.com/bitcoin/bitcoin/issues/19625 | https://github.com/bitcoin/bitcoin/pull/19646 | 1dac4dcf088f4ffc4129f2f4ffbf09561f5afcc8 | 22acd36d5365932bedd9d6ef23fbd616105383c9 | 2020-07-30T10:29:51Z | c++ | 2020-08-28T13:24:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,603 | ["src/validation.cpp"] | Show the "<n> of the last 100 blocks have unexpected version" warning only when running -debug=validation? | [Google search results](https://www.google.com/search?q=of+the+last+100+blocks+have+unexpected+version) suggest that our users are more confused than helped by the `<n> of the last 100 blocks
have unexpected version` warning we're printing.
As developers we know the unfortunate reason behind this warning and how "unexpected" should be interpreted in this context, and thus why it is safe to disregard this warning. However, I don't think it reasonable to expect our users to know the historical context here.
In order to not desensitize our users to potentially critical "real" warnings, would it make sense to move this message to the `-debug=validation` log category? | https://github.com/bitcoin/bitcoin/issues/19603 | https://github.com/bitcoin/bitcoin/pull/19898 | ec9b4492eba5d32ab833d511984756601d3f39b0 | d82b2c6e65ff1ade508e2e8abeb07d0ff37e09c4 | 2020-07-27T23:59:30Z | c++ | 2020-09-29T12:41:11Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,579 | ["src/rpc/blockchain.cpp"] | Output formatting for: bitcoin-cli help getrawmempool | When invoking the help command ```bitcoin-cli help getrawmempool``` for getrawmempool the output is as follows:
```
getrawmempool ( verbose )
Returns all transaction ids in memory pool as a json array of string transaction ids.
Hint: use getmempoolentry to fetch a specific transaction from the mempool.
Arguments:
1. verbose (boolean, optional, default=false) True for a json object, false for array of transaction ids
Result (for verbose = false):
[ (json array)
"hex", (string) The transaction id
...
]
Result (for verbose = true):
{ (json object)
"transactionid" : { (json object)
"vsize" : n, (numeric) virtual transaction size as defined in BIP 141. This is different from actual serialized size for witness transactions as witness data is discounted.
"weight" : n, (numeric) transaction weight as defined in BIP 141.
"fee" : n, (numeric) transaction fee in BTC (DEPRECATED)
"modifiedfee" : n, (numeric) transaction fee with fee deltas used for mining priority (DEPRECATED)
"time" : xxx, (numeric) local time transaction entered pool in seconds since 1 Jan 1970 GMT
"height" : n, (numeric) block height when transaction entered pool
"descendantcount" : n, (numeric) number of in-mempool descendant transactions (including this one)
"descendantsize" : n, (numeric) virtual transaction size of in-mempool descendants (including this one)
"descendantfees" : n, (numeric) modified fees (see above) of in-mempool descendants (including this one) (DEPRECATED)
"ancestorcount" : n, (numeric) number of in-mempool ancestor transactions (including this one)
"ancestorsize" : n, (numeric) virtual transaction size of in-mempool ancestors (including this one)
"ancestorfees" : n, (numeric) modified fees (see above) of in-mempool ancestors (including this one) (DEPRECATED)
"wtxid" : "hex", (string) hash of serialized transaction, including witness data
"fees" : { (json object)
"base" : n, (numeric) transaction fee in BTC
"modified" : n, (numeric) transaction fee with fee deltas used for mining priority in BTC
"ancestor" : n, (numeric) modified fees (see above) of in-mempool ancestors (including this one) in BTC
"descendant" : n (numeric) modified fees (see above) of in-mempool descendants (including this one) in BTC
},
"depends" : [ (json array) unconfirmed transactions used as inputs for this transaction
"hex", (string) parent transaction id
...
],
"spentby" : [ (json array) unconfirmed transactions spending outputs from this transaction
"hex", (string) child transaction id
...
],
"bip125-replaceable" : true|false, (boolean) Whether this transaction could be replaced due to BIP125 (replace-by-fee)
"unbroadcast" : true|false, (boolean) Whether this transaction is currently unbroadcast (initial broadcast not yet acknowledged by any peers)
...
}
}
Examples:
> bitcoin-cli getrawmempool true
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id": "curltest", "method": "getrawmempool", "params": [true]}' -H 'content-type: text/plain;' http://127.0.0.1:8332/
```
The "transactionid" block for the verbose output has **...** as the last entry, I think the elipsis should be in the next line (after the end of the object), indicating that there might be more objects of the same form instead of indicating that the transactionid object might have more, not documented values.
Thus the output should be like this:
```
getrawmempool ( verbose )
Returns all transaction ids in memory pool as a json array of string transaction ids.
Hint: use getmempoolentry to fetch a specific transaction from the mempool.
Arguments:
1. verbose (boolean, optional, default=false) True for a json object, false for array of transaction ids
Result (for verbose = false):
[ (json array)
"hex", (string) The transaction id
...
]
Result (for verbose = true):
{ (json object)
"transactionid" : { (json object)
"vsize" : n, (numeric) virtual transaction size as defined in BIP 141. This is different from actual serialized size for witness transactions as witness data is discounted.
"weight" : n, (numeric) transaction weight as defined in BIP 141.
"fee" : n, (numeric) transaction fee in BTC (DEPRECATED)
"modifiedfee" : n, (numeric) transaction fee with fee deltas used for mining priority (DEPRECATED)
"time" : xxx, (numeric) local time transaction entered pool in seconds since 1 Jan 1970 GMT
"height" : n, (numeric) block height when transaction entered pool
"descendantcount" : n, (numeric) number of in-mempool descendant transactions (including this one)
"descendantsize" : n, (numeric) virtual transaction size of in-mempool descendants (including this one)
"descendantfees" : n, (numeric) modified fees (see above) of in-mempool descendants (including this one) (DEPRECATED)
"ancestorcount" : n, (numeric) number of in-mempool ancestor transactions (including this one)
"ancestorsize" : n, (numeric) virtual transaction size of in-mempool ancestors (including this one)
"ancestorfees" : n, (numeric) modified fees (see above) of in-mempool ancestors (including this one) (DEPRECATED)
"wtxid" : "hex", (string) hash of serialized transaction, including witness data
"fees" : { (json object)
"base" : n, (numeric) transaction fee in BTC
"modified" : n, (numeric) transaction fee with fee deltas used for mining priority in BTC
"ancestor" : n, (numeric) modified fees (see above) of in-mempool ancestors (including this one) in BTC
"descendant" : n (numeric) modified fees (see above) of in-mempool descendants (including this one) in BTC
},
"depends" : [ (json array) unconfirmed transactions used as inputs for this transaction
"hex", (string) parent transaction id
...
],
"spentby" : [ (json array) unconfirmed transactions spending outputs from this transaction
"hex", (string) child transaction id
...
],
"bip125-replaceable" : true|false, (boolean) Whether this transaction could be replaced due to BIP125 (replace-by-fee)
"unbroadcast" : true|false (boolean) Whether this transaction is currently unbroadcast (initial broadcast not yet acknowledged by any peers)
},
...
}
Examples:
> bitcoin-cli getrawmempool true
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id": "curltest", "method": "getrawmempool", "params": [true]}' -H 'content-type: text/plain;' http://127.0.0.1:8332/
```
Happy to submit a PR. | https://github.com/bitcoin/bitcoin/issues/19579 | https://github.com/bitcoin/bitcoin/pull/19585 | a4a279b4f368661ea7d2507dd963469f432f916c | a63a26f042134fa80356860c109edb25ac567552 | 2020-07-24T12:00:56Z | c++ | 2020-07-31T05:52:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,559 | ["doc/build-openbsd.md"] | build: cannot compile on OpenBSD since libsecp256k1 subtree update | Since the secp256k1 subtree update in #19228 (8c97780db8c9dd33efed134385573ba97e9cd165), it hasn't been possible to compile on OpenBSD.
Building fails with (cc is Clang 8.0.1):
```bash
./autogen.sh
./configure --disable-wallet --with-gui=no CC=cc CXX=c++ MAKE=gmake
gmake -j6 V=1
...
gmake[3]: Entering directory '/home/vagrant/bitcoin/src/secp256k1'
gcc -I. -I./src -Wall -Wextra -Wno-unused-function -g -O2 -c src/gen_context.c -o gen_context.o
In file included from src/gen_context.c:16:
src/util.h:179: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'uint128_t'
gmake[3]: *** [Makefile:1689: gen_context.o] Error 1
gmake[3]: Leaving directory '/home/vagrant/bitcoin/src/secp256k1'
```
The issue is that libsecp does some native compiler detection in configure, and then uses that compiler specifically for the ecmult precomputation. See here, (the call settings `CC_FOR_BUILD` is earlier):
https://github.com/bitcoin/bitcoin/blob/476436b2dec254bb988f8c7a6cbec1d7bb7cecfd/src/secp256k1/configure.ac#L186-L188
and then here where it's used:
https://github.com/bitcoin/bitcoin/blob/476436b2dec254bb988f8c7a6cbec1d7bb7cecfd/src/secp256k1/Makefile.am#L129-L130
The problem is that this ends up picking up and using OpenBSDs ancient GCC 4.2.1, which barfs when it gets to util.h:
https://github.com/bitcoin/bitcoin/blob/476436b2dec254bb988f8c7a6cbec1d7bb7cecfd/src/secp256k1/src/util.h#L179
If anyone does happen to run into this issue, the immediate workaround is to just pass `CC_FOR_BUILD` to configure, i.e: `./configure --disable-wallet --with-gui=no CC=cc CXX=c++ MAKE=gmake CC_FOR_BUILD=cc`.
However before we update any docs etc, I'm going to take the issue upstream. | https://github.com/bitcoin/bitcoin/issues/19559 | https://github.com/bitcoin/bitcoin/pull/19605 | 04a0676b3fbf435067831a5c2f512f181e276fed | 6d5a9fec2d576bdb17ff612e421a8c94dc362fbe | 2020-07-20T13:16:53Z | c++ | 2020-08-10T14:39:11Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,557 | ["src/test/fuzz/util.h"] | test: recently merged fuzzers don't compile on macOS | The fuzzing harnesses from #19143 don't compile on macOS. i.e building at 476436b2dec254bb988f8c7a6cbec1d7bb7cecfd:
```bash
In file included from test/fuzz/addition_overflow.cpp:7:
./test/fuzz/util.h:335:13: error: no matching function for call to 'AdditionOverflow'
if (AdditionOverflow((uint64_t)fuzzed_file->m_offset, random_bytes.size())) {
^~~~~~~~~~~~~~~~
./test/fuzz/util.h:201:16: note: candidate template ignored: deduced conflicting types for parameter 'T' ('unsigned long long' vs. 'unsigned long')
NODISCARD bool AdditionOverflow(const T i, const T j) noexcept
^
./test/fuzz/util.h:346:13: error: no matching function for call to 'AdditionOverflow'
if (AdditionOverflow(fuzzed_file->m_offset, n)) {
^~~~~~~~~~~~~~~~
./test/fuzz/util.h:201:16: note: candidate template ignored: deduced conflicting types for parameter 'T' ('long long' vs. 'long')
NODISCARD bool AdditionOverflow(const T i, const T j) noexcept
^
2 errors generated.
In file included from test/fuzz/buffered_file.cpp:9:
./test/fuzz/util.h:335:13: error: no matching function for call to 'AdditionOverflow'
if (AdditionOverflow((uint64_t)fuzzed_file->m_offset, random_bytes.size())) {
^~~~~~~~~~~~~~~~
./test/fuzz/util.h:201:16: note: candidate template ignored: deduced conflicting types for parameter 'T' ('unsigned long long' vs. 'unsigned long')
NODISCARD bool AdditionOverflow(const T i, const T j) noexcept
^
./test/fuzz/util.h:346:13: error: no matching function for call to 'AdditionOverflow'
if (AdditionOverflow(fuzzed_file->m_offset, n)) {
^~~~~~~~~~~~~~~~
./test/fuzz/util.h:201:16: note: candidate template ignored: deduced conflicting types for parameter 'T' ('long long' vs. 'long')
NODISCARD bool AdditionOverflow(const T i, const T j) noexcept
^
2 errors generated.
``` | https://github.com/bitcoin/bitcoin/issues/19557 | https://github.com/bitcoin/bitcoin/pull/19562 | 597d2f905ecab4fe2c64bba13f8e76e0075b2f9f | 2031aa92a32d0613dcc912ff438521e32cea9977 | 2020-07-20T03:48:02Z | c++ | 2020-07-22T10:03:41Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,549 | ["src/test/fuzz/addrdb.cpp"] | Build warning in `test/fuzz/addrdb.cpp`: unused variable | Seen both locally and in the Travis fuzz build:
```cpp
test/fuzz/addrdb.cpp:20:21: warning: unused variable 'ban_entry' [-Wunused-variable]
const CBanEntry ban_entry = [&] {
^
1 warning generated.
```
| https://github.com/bitcoin/bitcoin/issues/19549 | https://github.com/bitcoin/bitcoin/pull/19551 | 090d87716074434bdc6c7656ec44d049197a793a | 476436b2dec254bb988f8c7a6cbec1d7bb7cecfd | 2020-07-18T19:28:54Z | c++ | 2020-07-19T11:25:44Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,546 | ["depends/README.md"] | build: Fail to cross-compile depends for HOST=x86_64-apple-darwin16 on Focal | System: Linux Mint 20 (focal codebase, x86_64).
```
$ make -C depends HOST=x86_64-apple-darwin16
...
Extracting native_cctools...
/home/hebasto/GitHub/bitcoin/depends/sources/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4.tar.gz: OK
/home/hebasto/GitHub/bitcoin/depends/sources/clang-llvm-8.0.0-x86_64-linux-gnu-ubuntu-14.04.tar.xz: OK
/home/hebasto/GitHub/bitcoin/depends/sources/3efb201881e7a76a21e0554906cf306432539cef.tar.gz: OK
Preprocessing native_cctools...
CMake Deprecation Warning at CMakeLists.txt:14 (cmake_policy):
The OLD behavior for policy CMP0051 will be removed from a future version
of CMake.
The cmake-policies(7) manual explains that the OLD behaviors of all
policies are deprecated and that a policy should be set to OLD only under
specific short-term circumstances. Projects should be ported to the NEW
behavior and not rely on setting a policy to OLD.
-- The C compiler identification is unknown
-- The CXX compiler identification is unknown
-- The ASM compiler identification is unknown
-- Found assembler: /home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/toolchain/bin/clang
-- Check for working C compiler: /home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/toolchain/bin/clang
-- Check for working C compiler: /home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/toolchain/bin/clang -- broken
CMake Error at /usr/share/cmake-3.16/Modules/CMakeTestCCompiler.cmake:60 (message):
The C compiler
"/home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/toolchain/bin/clang"
is not able to compile a simple test program.
It fails with the following output:
Change Dir: /home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/libtapi/build/CMakeFiles/CMakeTmp
Run Build Command(s):/usr/bin/make cmTC_6d157/fast && make[1]: Entering directory '/home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/libtapi/build/CMakeFiles/CMakeTmp'
/usr/bin/make -f CMakeFiles/cmTC_6d157.dir/build.make CMakeFiles/cmTC_6d157.dir/build
make[2]: Entering directory '/home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/libtapi/build/CMakeFiles/CMakeTmp'
Building C object CMakeFiles/cmTC_6d157.dir/testCCompiler.c.o
/home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/toolchain/bin/clang -o CMakeFiles/cmTC_6d157.dir/testCCompiler.c.o -c /home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/libtapi/build/CMakeFiles/CMakeTmp/testCCompiler.c
/home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/toolchain/bin/clang: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directory
make[2]: *** [CMakeFiles/cmTC_6d157.dir/build.make:66: CMakeFiles/cmTC_6d157.dir/testCCompiler.c.o] Error 127
make[2]: Leaving directory '/home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/libtapi/build/CMakeFiles/CMakeTmp'
make[1]: *** [Makefile:121: cmTC_6d157/fast] Error 2
make[1]: Leaving directory '/home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/libtapi/build/CMakeFiles/CMakeTmp'
CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
CMakeLists.txt:45 (project)
-- Configuring incomplete, errors occurred!
See also "/home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/libtapi/build/CMakeFiles/CMakeOutput.log".
See also "/home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/libtapi/build/CMakeFiles/CMakeError.log".
make: *** [funcs.mk:263: /home/hebasto/GitHub/bitcoin/depends/work/build/x86_64-apple-darwin16/native_cctools/4da2f3b485bcf4cef526f30c0b8c0bcda99cdbb4-cc2135bcaca/.stamp_preprocessed] Error 1
make: Leaving directory '/home/hebasto/GitHub/bitcoin/depends'
``` | https://github.com/bitcoin/bitcoin/issues/19546 | https://github.com/bitcoin/bitcoin/pull/19547 | f5000ae66c4042514f6404ee957fce8f5820600e | caf1766daf2f6a849d0303bb3f101f5855cbca83 | 2020-07-18T14:42:09Z | c++ | 2020-07-21T06:02:42Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,523 | ["test/functional/rpc_psbt.py"] | test: add a test for decodepsbt fee behaviour | As requested in #19517. @bitcoinhodler may also have some suggestions given they opened the original issue (#19516), after it was flagged by some of their own tests.
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/19523 | https://github.com/bitcoin/bitcoin/pull/19597 | 149eca433d8060d8ea5bf207322573c037750d92 | 2a784723f0c0e642353dc74ec6aef4d5f8345044 | 2020-07-15T04:05:47Z | c++ | 2020-07-30T07:46:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,516 | ["src/rpc/rawtransaction.cpp"] | `decodepsbt` fee overstated since #19215 |
<!-- Describe the issue -->
Following commit 46004790588c24174a0bec49b540d158ce163ffd (@achow101), `decodepsbt` overstates the fee, apparently including both the `witness_utxo` and `non_witness_utxo` amounts in the inputs.
**Expected behavior**
The decoded fee should be the sum of the inputs, minus the sum of the outputs.
**Actual behavior**
The decoded fee is exactly twice the amount of the inputs, minus the sum of the outputs.
**To reproduce**
Build any PSBT using `createpsbt`, `walletprocesspsbt`, then decode it with `decodepsbt`. See the `fee` field in the JSON.
**System information**
I compiled myself from 5550fa5983ea59e7ccef6540b7ec49a1770fb3ca on Whonix 14.
Then I did `git revert 46004790588c24174a0bec49b540d158ce163ffd ` and the problem went away.
| https://github.com/bitcoin/bitcoin/issues/19516 | https://github.com/bitcoin/bitcoin/pull/19517 | f4de89edfa8be4501534fec0c662c650a4ce7ef2 | 032cfdc9a24a603de4e746d199f69263cb3028d1 | 2020-07-14T15:53:19Z | c++ | 2020-07-15T04:01:06Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,506 | ["configure.ac", "doc/dependencies.md"] | Can no longer compile with boost 1.55/1.53 | See https://github.com/bitcoin/bitcoin/pull/19256/files#r453840068 | https://github.com/bitcoin/bitcoin/issues/19506 | https://github.com/bitcoin/bitcoin/pull/19667 | 19f812c57b420ae3e9ab5a95335e2adb5f54faf0 | 82127d27c9001eee3eb28df67ce2e6eace620423 | 2020-07-13T18:45:18Z | c++ | 2020-08-06T11:29:09Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,418 | ["test/functional/test_framework/util.py"] | Intermittent CI failure: "AssertionError: Fee of 0.00011000 BTC too low!" when running wallet_basic.py | Intermittent CI failure: "AssertionError: Fee of 0.00011000 BTC too low!" when running `wallet_basic.py`.
See [Travis log](https://travis-ci.org/github/bitcoin/bitcoin/jobs/703334035) for details.
```
…
2020-06-29T22:58:08.433000Z TestFramework (INFO): Initializing test directory /home/travis/build/bitcoin/bitcoin/ci/scratch/test_runner/test_runner_₿_🏃_20200629_225700/wallet_basic_150
2020-06-29T22:58:10.175000Z TestFramework (INFO): Mining blocks...
2020-06-29T22:58:11.456000Z TestFramework (INFO): test gettxout
2020-06-29T22:58:11.751000Z TestFramework (INFO): test gettxout (second part)
2020-06-29T22:58:13.291000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/home/travis/build/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 117, in main
self.run_test()
File "/home/travis/build/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/wallet_basic.py", line 204, in run_test
node_0_bal = self.check_fee_amount(self.nodes[0].getbalance(), Decimal('20'), fee_per_byte, self.get_vsize(self.nodes[2].gettransaction(txid)['hex']))
File "/home/travis/build/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/wallet_basic.py", line 44, in check_fee_amount
assert_fee_amount(fee, tx_size, fee_per_byte * 1000)
File "/home/travis/build/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 41, in assert_fee_amount
raise AssertionError("Fee of %s BTC too low! (Should be %s BTC)" % (str(fee), str(target_fee)))
AssertionError: Fee of 0.00011000 BTC too low! (Should be 0.00019100 BTC)
``` | https://github.com/bitcoin/bitcoin/issues/19418 | https://github.com/bitcoin/bitcoin/pull/23136 | 46b4937bc16cbccabaf27ca9c1d605646bdea67e | 35a31d5f7e9cd71a210c1ed10abc9d772ff36049 | 2020-06-30T06:40:50Z | c++ | 2021-10-01T08:54:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,417 | ["test/sanitizer_suppressions/tsan"] | Intermittent CI failure: ThreadSanitizer failure (data race) when running wallet_multiwallet.py --usecli | Intermittent CI failure: ThreadSanitizer failure (data race) when running `wallet_multiwallet.py --usecli`.
See [Travis log](https://travis-ci.org/github/bitcoin/bitcoin/jobs/703334033) for details.
```
…
wallet_multiwallet.py --usecli | ✖ Failed | 241 s
ALL | ✖ Failed | 3896 s (accumulated)
Runtime: 994 s
==================
WARNING: ThreadSanitizer: data race (pid=30325)
Write of size 8 at 0x7ba0000001e0 by thread T4 (mutexes: write M214):
#0 closedir <null> (bitcoind+0x75bf6)
#1 __os_dirlist <null> (bitcoind+0x80992c)
#2 BerkeleyBatch::VerifyEnvironment(boost::filesystem::path const&, bilingual_str&) <null> (bitcoind+0x45b342)
#3 WalletBatch::VerifyEnvironment(boost::filesystem::path const&, bilingual_str&) <null> (bitcoind+0x58e2bb)
#4 CWallet::Verify(interfaces::Chain&, WalletLocation const&, bilingual_str&, std::__1::vector<bilingual_str, std::__1::allocator<bilingual_str> >&) <null> (bitcoind+0x52a6b9)
#5 LoadWallet(interfaces::Chain&, WalletLocation const&, bilingual_str&, std::__1::vector<bilingual_str, std::__1::allocator<bilingual_str> >&) <null> (bitcoind+0x527901)
#6 loadwallet(JSONRPCRequest const&) <null> (bitcoind+0x4d2f0f)
#7 std::__1::__function::__func<CRPCCommand::CRPCCommand(char const*, char const*, UniValue (*)(JSONRPCRequest const&), std::initializer_list<char const*>)::'lambda'(JSONRPCRequest const&, UniValue&, bool), std::__1::allocator<CRPCCommand::CRPCCommand(char const*, char const*, UniValue (*)(JSONRPCRequest const&), std::initializer_list<char const*>)::'lambda'(JSONRPCRequest const&, UniValue&, bool)>, bool (JSONRPCRequest const&, UniValue&, bool)>::operator()(JSONRPCRequest const&, UniValue&, bool&&) <null> (bitcoind+0x243b6d)
#8 std::__1::__function::__func<interfaces::(anonymous namespace)::WalletClientImpl::registerRpcs()::'lambda'(JSONRPCRequest const&, UniValue&, bool), std::__1::allocator<interfaces::(anonymous namespace)::WalletClientImpl::registerRpcs()::'lambda'(JSONRPCRequest const&, UniValue&, bool)>, bool (JSONRPCRequest const&, UniValue&, bool)>::operator()(JSONRPCRequest const&, UniValue&, bool&&) <null> (bitcoind+0x43ec6e)
#9 std::__1::__function::__func<interfaces::(anonymous namespace)::RpcHandlerImpl::RpcHandlerImpl(CRPCCommand const&)::'lambda'(JSONRPCRequest const&, UniValue&, bool), std::__1::allocator<interfaces::(anonymous namespace)::RpcHandlerImpl::RpcHandlerImpl(CRPCCommand const&)::'lambda'(JSONRPCRequest const&, UniValue&, bool)>, bool (JSONRPCRequest const&, UniValue&, bool)>::operator()(JSONRPCRequest const&, UniValue&, bool&&) <null> (bitcoind+0x108e42)
#10 CRPCTable::execute(JSONRPCRequest const&) const <null> (bitcoind+0x2ec756)
#11 std::__1::__function::__func<StartHTTPRPC(util::Ref const&)::$_0, std::__1::allocator<StartHTTPRPC(util::Ref const&)::$_0>, bool (HTTPRequest*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)>::operator()(HTTPRequest*&&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) <null> (bitcoind+0x403cea)
#12 HTTPWorkItem::operator()() <null> (bitcoind+0x40e3f2)
#13 WorkQueue<HTTPClosure>::Run() <null> (bitcoind+0x4104f5)
#14 HTTPWorkQueueRun(WorkQueue<HTTPClosure>*, int) <null> (bitcoind+0x40a5fc)
#15 void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(WorkQueue<HTTPClosure>*, int), WorkQueue<HTTPClosure>*, int> >(void*) <null> (bitcoind+0x410fb8)
Previous read of size 8 at 0x7ba0000001e0 by thread T3 (mutexes: write M131465):
#0 epoll_ctl <null> (bitcoind+0x75fa2)
#1 epoll_apply_one_change <null> (bitcoind+0x8af70e)
#2 void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, bool (*)(event_base*), event_base*> >(void*) <null> (bitcoind+0x410648)
Location is file descriptor 30 created by main thread at:
[failed to restore the stack]
Mutex M214 (0x55ae4f8baba8) created at:
#0 pthread_mutex_init <null> (bitcoind+0x7172d)
#1 std::__1::recursive_mutex::recursive_mutex() <null> (libc++.so.1+0x83583)
#2 __libc_csu_init <null> (bitcoind+0x9501dc)
Mutex M131465 (0x7b0c00004740) created at:
#0 pthread_mutex_init <null> (bitcoind+0x7172d)
#1 evthread_posix_lock_alloc <null> (bitcoind+0x897aaf)
#2 AppInitMain(util::Ref const&, NodeContext&) <null> (bitcoind+0x11cd57)
#3 main <null> (bitcoind+0x10000c)
Thread T4 'b-httpworker.0' (tid=30350, running) created by main thread at:
#0 pthread_create <null> (bitcoind+0x701ab)
#1 std::__1::thread::thread<void (&)(WorkQueue<HTTPClosure>*, int), WorkQueue<HTTPClosure>*&, int&, void>(void (&)(WorkQueue<HTTPClosure>*, int), WorkQueue<HTTPClosure>*&, int&) <null> (bitcoind+0x410e90)
#2 void std::__1::vector<std::__1::thread, std::__1::allocator<std::__1::thread> >::__emplace_back_slow_path<void (&)(WorkQueue<HTTPClosure>*, int), WorkQueue<HTTPClosure>*&, int&>(void (&)(WorkQueue<HTTPClosure>*, int), WorkQueue<HTTPClosure>*&, int&) <null> (bitcoind+0x4107f2)
#3 StartHTTPServer() <null> (bitcoind+0x40a3b8)
#4 AppInitMain(util::Ref const&, NodeContext&) <null> (bitcoind+0x11cde1)
#5 main <null> (bitcoind+0x10000c)
Thread T3 'b-http' (tid=30349, running) created by main thread at:
#0 pthread_create <null> (bitcoind+0x701ab)
#1 std::__1::thread::thread<bool (&)(event_base*), event_base*&, void>(bool (&)(event_base*), event_base*&) <null> (bitcoind+0x40dc87)
#2 StartHTTPServer() <null> (bitcoind+0x40a31c)
#3 AppInitMain(util::Ref const&, NodeContext&) <null> (bitcoind+0x11cde1)
#4 main <null> (bitcoind+0x10000c)
SUMMARY: ThreadSanitizer: data race (/home/travis/build/bitcoin/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/bitcoind+0x75bf6) in closedir
``` | https://github.com/bitcoin/bitcoin/issues/19417 | https://github.com/bitcoin/bitcoin/pull/19422 | 7173a3c73ba939b8eb59b01cca604fe67e25ebb5 | d77170d52687c3d708daffb7976c3e0d345ff7dc | 2020-06-30T06:36:33Z | c++ | 2020-07-02T14:21:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,411 | ["depends/packages/bdb.mk"] | Unable to build BDB 4.8 on macOS Big Sur beta or Xcode 12.0 | _Update 22-9-2020:_ this happens on macOS Catalina as well with Xcode 12.0
_Update 9-10-2020_; workaround suggested by @willcl-ark:
```sh
brew install llvm
export LLVM_PREFIX=$(brew --prefix llvm)
CC=$LLVM_PREFIX/bin/clang CXX=$LLVM_PREFIX/bin/clang++ LDFLAGS="-L$LLVM_PREFIX/opt/llvm/lib -Wl,-rpath,$LLVM_PREFIX/opt/llvm/lib" ./contrib/install_db4.sh .
```
_Update 20-10-2020_: better workaround suggested by @fanquake:
```
CFLAGS="-Wno-error=implicit-function-declaration" ./contrib/install_db4.sh .
```
For more problems with macOS Big Sur (beta) see #19406.
I'm unable to build Berkeley DB 4.8. When using depends as when using `contrib/install_db4.sh`:
```
checking for mutexes... UNIX/fcntl
configure: WARNING: NO SHARED LATCH IMPLEMENTATION FOUND FOR THIS PLATFORM.
configure: error: Unable to find a mutex implementation
```
[configure.log](https://github.com/bitcoin/bitcoin/files/4845856/configure.log) `stdout` from Big Sur beta
[config.log](https://gist.github.com/Sjors/fafcaf701e8c9e9a57486310a5ed6b98) on Catalina with Xcode 12.0
I got the same error when compiling for iOs in #12557.
On macOS Catalina it finds the following:
```
checking for mutexes... POSIX/pthreads/library/x86_64/gcc-assembly
```
So perhaps something moved or was removed...
Looking at `dist/configure` I think I narrowed it down to this check:
```cpp
#include <pthread.h>
main() {
pthread_cond_t cond;
pthread_mutex_t mutex;
pthread_condattr_t condattr;
pthread_mutexattr_t mutexattr;
exit (
pthread_condattr_init(&condattr) ||
pthread_condattr_setpshared(&condattr, PTHREAD_PROCESS_SHARED) ||
pthread_mutexattr_init(&mutexattr) ||
pthread_mutexattr_setpshared(&mutexattr, PTHREAD_PROCESS_SHARED) ||
pthread_cond_init(&cond, &condattr) ||
pthread_mutex_init(&mutex, &mutexattr) ||
pthread_mutex_lock(&mutex) ||
pthread_mutex_unlock(&mutex) ||
pthread_mutex_destroy(&mutex) ||
pthread_cond_destroy(&cond) ||
pthread_condattr_destroy(&condattr) ||
pthread_mutexattr_destroy(&mutexattr));
}
_ACEOF
if ac_fn_c_try_run "$LINENO"; then :
db_cv_mutex="POSIX/pthreads/library"
fi
```
If I replace the `main()` function body with `exit(0);` it still fails, but it's "happy" when why I use `return 0;`. I initially assumed this was a `-Werror=return-type` problem, but something like `exit(0); return 0;` doesn't work either. I don't know how to inspect the compilation output.
I can replace `exit` with `return` in the above function and it compiles, `bitcoind` builds and wallet tests pass.
This suggests an obvious patch, but also a bit of a mystery. | https://github.com/bitcoin/bitcoin/issues/19411 | https://github.com/bitcoin/bitcoin/pull/20195 | 2e24197117027c927a45d3c1832326e5bd9b10d0 | 5b82f253b69f3b3d7b5bafb9089ec36c14d1162c | 2020-06-29T13:44:59Z | c++ | 2020-10-29T11:31:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,402 | ["build_msvc/bitcoin_config.h", "configure.ac", "src/crypto/common.h"] | __builtin_clz[l[l]] not detected using clang | See this arbitrary macOS Travis job: https://travis-ci.org/github/bitcoin/bitcoin/jobs/702283632#L521
Somehow `AC_CHECK_DECLS` doesn't work for builtins for clang (it does work for GCC).
However, `__builtin_prefetch` (which is detected using `AC_COMPILE_IFELSE`) does work. | https://github.com/bitcoin/bitcoin/issues/19402 | https://github.com/bitcoin/bitcoin/pull/19403 | 8edfc1715a02cbaf52420d3c4e71f67ff9af0b41 | 1269cab21a9ac32f9ee8adfb9041950756eff3e4 | 2020-06-28T20:42:59Z | c++ | 2020-06-29T13:49:08Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,388 | ["ci/test/00_setup_env_native_qt5.sh", "ci/test/00_setup_env_win64.sh", "configure.ac", "src/Makefile.test.include"] | Build fuzz tests by default | Similar to all other tests (unit tests, bench tests, gui unit tests, ...), the fuzz tests should also be built by default.
So, `--enable-fuzz` should be changed to `--disable-fuzz`.
See https://github.com/bitcoin/bitcoin/pull/19366#issuecomment-648763070
#### Useful skills:
build system background
#### Want to work on this issue?
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/19388 | https://github.com/bitcoin/bitcoin/pull/20936 | 8636288db130145cb9db54959cb75a8744e61328 | e51f6c4dee3d42b2707c31fa1c93a337b6bf5ba7 | 2020-06-26T18:42:12Z | c++ | 2021-02-08T09:07:15Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,369 | ["ci/test/00_setup_env_native_asan.sh", "ci/test/00_setup_env_native_tsan.sh", "ci/test/00_setup_env_native_valgrind.sh"] | Intermittent CI failure: wallet_basic.py --descriptors | `wallet_basic.py --descriptors` seems to fail intermittently.
Details at https://github.com/bitcoin/bitcoin/pull/19366/checks?check_run_id=801164678. | https://github.com/bitcoin/bitcoin/issues/19369 | https://github.com/bitcoin/bitcoin/pull/19371 | b80ae6b4c04b2b9f8a4181acf450bcd513f27788 | 19612ca2eb2e335c8ccc9c0f33421df22f1cc3b6 | 2020-06-24T05:51:58Z | c++ | 2020-06-29T06:35:20Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,361 | ["src/rpc/blockchain.cpp"] | RPC: scantxoutset progress reports 100% while deriving keys | When I run `scantxoutset` via RPC using big range (e.g. 10000) on XPUB, the progress report indicator (`scantxoutset status`) reports 100% at start (while the keys are being derived). This is most probably the result of the previous operation. The progress is only reset to zero when the actual scan starts. I would expect the progress is set to zero before the keys are being derived.
Output of periodic calls to `scantxoutset status` while performing long operation.
```
{ progress: 100 }
{ progress: 100 }
{ progress: 100 }
{ progress: 100 }
{ progress: 100 }
{ progress: 100 }
{ progress: 100 }
{ progress: 100 }
{ progress: 100 }
{ progress: 0 }
{ progress: 3 }
{ progress: 6 }
{ progress: 9 }
{ progress: 12 }
{ progress: 15 }
{ progress: 17 }
{ progress: 20 }
{ progress: 23 }
{ progress: 26 }
{ progress: 29 }
{ progress: 32 }
{ progress: 35 }
{ progress: 37 }
{ progress: 40 }
{ progress: 43 }
{ progress: 46 }
{ progress: 49 }
{ progress: 51 }
{ progress: 54 }
{ progress: 57 }
{ progress: 60 }
{ progress: 63 }
{ progress: 66 }
{ progress: 68 }
{ progress: 71 }
{ progress: 74 }
{ progress: 77 }
{ progress: 80 }
{ progress: 82 }
{ progress: 85 }
{ progress: 88 }
{ progress: 91 }
{ progress: 94 }
{ progress: 97 }
{ progress: 100 }
``` | https://github.com/bitcoin/bitcoin/issues/19361 | https://github.com/bitcoin/bitcoin/pull/19362 | 246daf1f537d4b7a39774b22db86ed1931b7819b | 3e306ee1d5c79eda64eb991fb2696bf530f0b30d | 2020-06-23T11:49:06Z | c++ | 2021-06-25T09:21:33Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,359 | ["depends/hosts/darwin.mk"] | build: follow up with ld64 versioning for macOS toolchain | Follow up with linker related comments from [#19240](https://github.com/bitcoin/bitcoin/pull/19240#issuecomment-647764049):
> Actually, after digging through @fanquake's recommendation some more, it looks like the LD64_VERSION_NUM does not end up being passed through correctly.
> ....
> I suggest we take theuni@7181800 as part of this PR as well. Then maybe we can send @fanquake down the rabbit hole to see why clang can't find this on its own (or if it's even supposed to). | https://github.com/bitcoin/bitcoin/issues/19359 | https://github.com/bitcoin/bitcoin/pull/19407 | 7d9008f43e50db6a44cf5cac9456fce99e1aac12 | f61019f5a2c63d0a293e2ba2e57352d834f2c8d6 | 2020-06-23T08:24:15Z | c++ | 2020-07-03T09:38:27Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,341 | ["src/httpserver.cpp"] | rpc: pathHandlers is not protected by any locks (data race) | It is accessed by at least two threads:
* `[shutoff]` in `UnregisterHTTPHandler`
* `[http]` in `http_request_cb` | https://github.com/bitcoin/bitcoin/issues/19341 | https://github.com/bitcoin/bitcoin/pull/25983 | 124e75a41ea0f3f0e90b63b0c41813184ddce2ab | fc44d1796e4df5824423d7d13de3082fe204db7d | 2020-06-20T23:30:01Z | c++ | 2022-09-07T09:27:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,266 | ["build-aux/m4/bitcoin_qt.m4", "depends/config.site.in"] | build: mingw32 issues with Qt if depends is built with DEBUG=1 | On master (8c97780db8c9dd33efed134385573ba97e9cd165):
```
$ make -C depends HOST=x86_64-w64-mingw32 DEBUG=1
$ ./autogen.sh
$ CONFIG_SITE=$PWD/depends/x86_64-w64-mingw32/share/config.site ./configure
...
Options used to compile and link:
multiprocess = no
with wallet = yes
with gui / qt = no
...
```
Should be fixed by #18298. | https://github.com/bitcoin/bitcoin/issues/19266 | https://github.com/bitcoin/bitcoin/pull/18298 | 4f223e93e9c097c96a1655f9125aec463892da9c | fca3e98f64f0c89674414a18943591a04d61ccbf | 2020-06-13T11:52:23Z | c++ | 2021-03-03T07:48:11Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,255 | ["src/init.cpp", "src/node/context.h", "src/rpc/blockchain.cpp"] | gui: calling txoutset commands broken in console | Calling `*txoutset` calls in the console has been broken since #19056. The addition of the `RpcInterruptionPoint()` calls means that any user running the GUI without passing `-server`, will just see ["Shutting down"](https://github.com/bitcoin/bitcoin/blob/b33136b6ba9887f7db651c4c5264ca7f2f601df7/src/rpc/server.cpp#L325) printed to the console:
cc @MarcoFalke | https://github.com/bitcoin/bitcoin/issues/19255 | https://github.com/bitcoin/bitcoin/pull/19323 | a924f61caea8833b2afd3d4105fc7cd6f424d6c6 | 834ac4c0f50c0795b55f5586ecc4b1db251be58d | 2020-06-12T03:46:53Z | c++ | 2020-07-14T14:33:01Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,254 | ["src/policy/fees.h"] | static FeeFilterRounder in net_processing needs a mutex (or documentation that concurrent access is not allowed) | The class uses a fast random context. The context is documented to be not thread-safe.
Currently, SendMessages is only called in a single thread, but in the future or in unit tests, this might change. | https://github.com/bitcoin/bitcoin/issues/19254 | https://github.com/bitcoin/bitcoin/pull/19268 | 90b5fc9ce41117b3a85170e6fc129e87bbd15f48 | 07c83ce0399a2811bdd764b0cce347ba3bdbe37c | 2020-06-11T18:50:56Z | c++ | 2020-07-14T07:30:02Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,248 | ["doc/Doxyfile.in"] | doc: Enable doxygen on the test directory | While it makes sense to exclude third party libraries in subtrees from doxygen, is there any reason to also exclude the fuzz and unit tests?
They both have frameworks and utility functions that I need to look up repeatedly.
Doxygen is meant to be developer documentation and not Bitcoin Core user documentation, so I see no downside of enabling the test directory in doxygen. Am I missing something? | https://github.com/bitcoin/bitcoin/issues/19248 | https://github.com/bitcoin/bitcoin/pull/22001 | efd6f904c78769ad2e93c1f1de43014d284e7561 | dcd116950fed0890020bc7283c5fa753f866047f | 2020-06-11T13:58:35Z | c++ | 2021-08-02T11:52:46Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,235 | ["src/pubkey.h", "src/test/key_tests.cpp"] | Use of uninitialized memory when validating successfully deserialized CPubKey | [Travis errors](https://travis-ci.org/github/bitcoin/bitcoin/jobs/689667275#L4121) on #18912 (PR adding Valgrind checking) due to the following `CPubKey` deserialization issue. [See Travis log for details](https://travis-ci.org/github/bitcoin/bitcoin/jobs/689667275#L4121).
Issue:
It is possible to successfully deserialize a public key (`CPubKey`) which when used -- such as checking for validity using `IsFullyValid()` -- leads to use of uninitialized memory (UUM):
Example:
```c++
const std::vector<uint8_t> serialized_pub_key{4, 4, 0, 0, 0};
CDataStream data_stream{serialized_pub_key, SER_NETWORK, INIT_PROTO_VERSION};
CPubKey pub_key;
data_stream >> pub_key;
if (pub_key.IsValid()) {
(void)pub_key.IsFullyValid();
}
```
The example code leads to the following use of uninitialized memory (UUM) (in `IsFullyValid()`) ...
```
==6417== Conditional jump or move depends on uninitialised value(s)
==6417== at 0x1077684: secp256k1_fe_set_b32 (field_5x52_impl.h:320)
==6417== by 0x1056B82: secp256k1_eckey_pubkey_parse (eckey_impl.h:23)
==6417== by 0x1056B82: secp256k1_ec_pubkey_parse (secp256k1.c:178)
==6417== by 0xF4A6A3: CPubKey::IsFullyValid() const (pubkey.cpp:213)
```
... instead of the expected `std::ios_base::failure` when deserializing (on `data_stream >> pub_key`).
---
Uses of uninitialized memory (UUM) is unfortunately a quite common type of bug, but luckily MemorySanitizer and Valgrind can help us guard against such issues entering our code base. Travis MSan checking and Valgrind checking is provided in the following two PRs which should be ready for merge pending final code review (they have multiple "Concept ACKs"):
* #18288 -- "build: Add MemorySanitizer (MSan) in Travis to detect use of uninitialized memory"
* #18912 -- "ci: Run fuzz testing test cases (bitcoin-core/qa-assets) under valgrind to catch memory errors"
Hopefully uses of uninitialized memory will soon be a thing of the past when we have the proper UUM detection in place :) | https://github.com/bitcoin/bitcoin/issues/19235 | https://github.com/bitcoin/bitcoin/pull/19237 | 67881de0e3b1cef1d0f978582765a8aeeb09c21a | c9d1040d254eedac98ec4a2038742d7b3d45f9ab | 2020-06-10T11:27:45Z | c++ | 2020-06-25T12:07:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,232 | ["src/wallet/wallet.cpp", "test/functional/wallet_multiwallet.py"] | Regular crash+autorestart after loading/unloading many wallets | <!-- Describe the issue -->
Hi everyone,
We use bitcoin core with hundreds of wallets. The only efficient way we have found to do so is :
1. wait for any bitcoin-cli command to terminate before issuing another one
2. never issue any bitcoin-cli command unless tip update is 1
3. always unload a wallet after loading and using it
Now, we observ that bitcoin core systematically crashes every 20-30 minutes, then automatically restarts. And the problem is, it has to re-sync from about 0.997, which easily takes 15-20 minutes. During that time, the daemon cannot be used.
If we don't load/unload wallets, the daemon is stable and keeps to 1, no issue.
**System information**
Bitcoin Core RPC client version v0.20.0.0-ga62f0ed64f8bbbdfe6467ac5ce92ef5b5222d1bd
Compiled and run on Debian 9, on a VM with 16 mo memory. Launched that way : /bitcoind -daemon -walletrbf -conf=/root/.bitcoin/bitcoin.conf -fallbackfee=0.00001 -rpcworkqueue=128 -txindex=1
**bitcoin.conf :**
server=1
dbcache=16384
par=1
blocksonly=1
maxuploadtarget=137
maxconnections=16
rpcuser=bitcoinrpc
rpcpassword=xxxxxx
rpcallowip=127.0.0.1
testnet=0
txindex=1
walletbroadcast=1
txconfirmtarget=1
Please note that the same behaviour was happening with older releases (from 0.17.x).
Thanks for any help. Please ask for any needed information / testing.
Regards, | https://github.com/bitcoin/bitcoin/issues/19232 | https://github.com/bitcoin/bitcoin/pull/19300 | dbadf746e26840b68cb3b01a690aa46256ae2191 | 5c3c7cc50c5f70bbd2946c65c6fe0d50b380a076 | 2020-06-10T09:05:26Z | c++ | 2020-06-29T15:14:26Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,229 | ["src/bench/coin_selection.cpp", "src/wallet/test/coinselector_tests.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h"] | Transaction fee and change calculation failed... using v0.21.0 binary | After upgrade of binary bitcoind from 0.19.1 to 0.20.0 could not process transactions. Did not see anything in release notes that would be breaking. Any idea what could be the issue? I cant find any documentation on this error message.
**Expected behavior**
Process transaction without error using "sendtoaddress"
**Actual behavior**
error code -4 "Transaction fee and change calculation failed"
**To reproduce**
All we did was upgrade binary bitcoind from 0.19.1 to v0.20.0. Nothing else changed.
**System information**
Using binary from https://bitcoincore.org/bin/bitcoin-core-0.20.0/bitcoin-0.20.0-x86_64-linux-gnu.tar.gz
On Linux Ubuntu 18.04.3 LTS on a SSD
No ERRORs exist in debug.log. Node syncs fine on v0.20.0... The following seems relevant but we saw same logs on v0.19.1.
**v0.19.1...**
2020-06-09T07:51:36Z [default wallet] Fee Calculation: Fee:2871 Bytes:136 Needed:2871 Tgt:6 (requested 6) Reason:"Conservative Double Target longer horizon" Decay 0.99931: Estimation: (20593.8 - 21623.5) 97.20% 37504.3/(38582.5 0 mem 3.0 out) Fail: (19613.1 - 20593.8) 92.07% 24792.5/(26908.8 0 mem 19.2 out)
2020-06-09T07:54:32Z [default wallet] Fee Calculation: Fee:13110 Bytes:621 Needed:13110 Tgt:6 (requested 6) Reason:"Conservative Double Target longer horizon" Decay 0.99931: Estimation: (20593.8 - 21623.5) 97.20% 37504.3/(38582.5 0 mem 3.0 out) Fail: (19613.1 - 20593.8) 92.07% 24792.5/(26908.8 0 mem 19.2 out)
2020-06-09T09:58:09Z [default wallet] Fee Calculation: Fee:7326 Bytes:347 Needed:7326 Tgt:6 (requested 6) Reason:"Conservative Double Target longer horizon" Decay 0.99931: Estimation: (20593.8 - 21623.5) 97.39% 40008.9/(41076.7 0 mem 3.0 out) Fail: (19613.1 - 20593.8) 92.28% 25270.9/(27366.8 0 mem 19.0 out)
2020-06-09T13:22:31Z [default wallet] Fee Calculation: Fee:16956 Bytes:803 Needed:16956 Tgt:6 (requested 6) Reason:"Conservative Double Target longer horizon" Decay 0.99931: Estimation: (20593.8 - 21623.5) 97.64% 43671.2/(44725.9 0 mem 3.0 out) Fail: (19613.1 - 20593.8) 92.48% 25689.0/(27759.1 0 mem 18.8 out)
2020-06-09T14:36:45Z [default wallet] Fee Calculation: Fee:54877 Bytes:2255 Needed:54877 Tgt:6 (requested 6) Reason:"Target 85% Threshold" Decay 0.96200: Estimation: (23839.9 - 25031.9) 98.23% 3643.5/(3709.2 0 mem 0.0 out) Fail: (22704.7 - 23839.9) 81.84% 2485.0/(3036.6 0 mem 0.0 out)
2020-06-09T15:33:30Z [default wallet] Fee Calculation: Fee:5709 Bytes:258 Needed:5709 Tgt:6 (requested 6) Reason:"Target 85% Threshold" Decay 0.96200: Estimation: (21623.5 - 22704.7) 88.84% 3368.3/(3791.3 0 mem 0.0 out) Fail: (20593.8 - 21623.5) 77.45% 3045.0/(3928.4 0 mem 3.2 out)
2020-06-09T16:06:13Z [default wallet] Fee Calculation: Fee:90020 Bytes:4068 Needed:90020 Tgt:6 (requested 6) Reason:"Target 85% Threshold" Decay 0.96200: Estimation: (21623.5 - 22704.7) 88.87% 3127.1/(3518.6 0 mem 0.0 out) Fail: (20593.8 - 21623.5) 77.48% 2822.9/(3640.5 0 mem 2.9 out)
2020-06-09T18:16:54Z [default wallet] Fee Calculation: Fee:7683 Bytes:347 Needed:7683 Tgt:6 (requested 6) Reason:"Target 85% Threshold" Decay 0.96200: Estimation: (21623.5 - 22704.7) 92.06% 3166.4/(3439.3 0 mem 0.0 out) Fail: (20593.8 - 21623.5) 82.08% 2307.7/(2809.5 0 mem 2.1 out)
2020-06-09T18:28:31Z [default wallet] Fee Calculation: Fee:11759 Bytes:531 Needed:11759 Tgt:6 (requested 6) Reason:"Target 85% Threshold" Decay 0.96200: Estimation: (21623.5 - 22704.7) 92.58% 3152.3/(3404.9 0 mem 0.0 out) Fail: (20593.8 - 21623.5) 82.64% 2219.5/(2683.9 0 mem 2.0 out)
2020-06-09T18:53:50Z [default wallet] Fee Calculation: Fee:11716 Bytes:529 Needed:11716 Tgt:6 (requested 6) Reason:"Target 85% Threshold" Decay 0.96200: Estimation: (21623.5 - 22704.7) 93.28% 3003.3/(3219.7 0 mem 0.0 out) Fail: (20593.8 - 21623.5) 83.47% 2016.6/(2414.3 0 mem 1.7 out)
2020-06-09T19:18:43Z [default wallet] Fee Calculation: Fee:4962 Bytes:224 Needed:4962 Tgt:6 (requested 6) Reason:"Target 85% Threshold" Decay 0.96200: Estimation: (21623.5 - 22704.7) 93.59% 2925.7/(3126.0 0 mem 0.0 out) Fail: (20593.8 - 21623.5) 83.74% 1903.9/(2272.0 0 mem 1.6 out)
**v0.20.0 ...**
2020-06-09T20:18:06Z [default wallet] Fee Calculation: Fee:2829 Bytes:134 Needed:2829 Tgt:6 (requested 6) Reason:"Conservative Double Target longer horizon" Decay 0.99931: Estimation: (20593.8 - 21623.5) 97.79% 45111.8/(46130.7 0 mem 2.9 out) Fail: (19613.1 - 20593.8) 93.00% 26822.9/(28822.8 0 mem 18.2 out)
**v0.19.1...**
2020-06-09T21:44:39Z [default wallet] Fee Calculation: Fee:7372 Bytes:349 Needed:7372 Tgt:6 (requested 6) Reason:"Target 85% Threshold" Decay 0.96200: Estimation: (20593.8 - 21623.5) 91.12% 2121.8/(2327.6 0 mem 0.9 out) Fail: (19613.1 - 20593.8) 83.14% 777.5/(935.0 0 mem 0.1 out)
2020-06-09T21:45:57Z [default wallet] Fee Calculation: Fee:7330 Bytes:347 Needed:7330 Tgt:6 (requested 6) Reason:"Target 85% Threshold" Decay 0.96200: Estimation: (20593.8 - 21623.5) 91.12% 2121.8/(2327.6 0 mem 0.9 out) Fail: (19613.1 - 20593.8) 83.14% 777.5/(935.0 0 mem 0.1 out)
2020-06-09T21:50:48Z [default wallet] Fee Calculation: Fee:36125 Bytes:1710 Needed:36125 Tgt:6 (requested 6) Reason:"Target 85% Threshold" Decay 0.96200: Estimation: (20593.8 - 21623.5) 91.12% 2121.8/(2327.6 0 mem 0.9 out) Fail: (19613.1 - 20593.8) 83.14% 777.5/(935.0 0 mem 0.1 out)
2020-06-09T22:04:02Z [default wallet] Fee Calculation: Fee:4775 Bytes:226 Needed:4775 Tgt:6 (requested 6) Reason:"Target 85% Threshold" Decay 0.96200: Estimation: (20593.8 - 21623.5) 92.53% 2369.9/(2560.4 0 mem 0.8 out) Fail: (19613.1 - 20593.8) 84.30% 783.4/(929.1 0 mem 0.1 out)
| https://github.com/bitcoin/bitcoin/issues/19229 | https://github.com/bitcoin/bitcoin/pull/21083 | 5ef16038a1a8adc25438d77f60d83b2c01738fcf | d25e28c20b0987c15c55e106de39cd46d32a802b | 2020-06-09T22:31:56Z | c++ | 2021-03-17T00:14:48Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,223 | ["src/validation.cpp"] | [code review] Isn't this check redundant? | https://github.com/bitcoin/bitcoin/blob/9ad6f14175c19b5d47267c3dd5840c14bad43c83/src/validation.cpp#L3711
If i'm following right the flow of the code, when we hit this lane `pindex` should be always equal to nullptr thus this check may be omitted | https://github.com/bitcoin/bitcoin/issues/19223 | https://github.com/bitcoin/bitcoin/pull/20868 | 7dc4807691b96e53c04ef779501618325a7fafc0 | 87394b6741df7068eb55d012a8169400c68b34ed | 2020-06-09T13:30:48Z | c++ | 2021-02-01T09:56:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,211 | ["test/sanitizer_suppressions/tsan"] | feature_reindex.py triggers data race | Our friend ThreadSanitizer intermittently reports the following data race when `feature_reindex.py` is run:
```
WARNING: ThreadSanitizer: data race (pid=27557)
Read of size 8 at 0x7b0400000ea0 by thread T2 (mutexes: write M131641, write M135):
#0 std::__1::pair<std::__1::__hash_iterator<std::__1::__hash_node<std::__1::__hash_value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, WalletDatabaseFileId>, void*>*>, bool> std::__1::__hash_table<std::__1::__hash_value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, WalletDatabaseFileId>, std::__1::__unordered_map_hasher<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__hash_value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, WalletDatabaseFileId>, std::__1::hash<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, true>, std::__1::__unordered_map_equal<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__hash_value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, WalletDatabaseFileId>, std::__1::equal_to<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, true>, std::__1::allocator<std::__1::__hash_value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, WalletDatabaseFileId> > >::__emplace_unique_key_args<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::piecewise_construct_t const&, std::__1::tuple<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&>, std::__1::tuple<> >(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::piecewise_construct_t const&, std::__1::tuple<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&>&&, std::__1::tuple<>&&) <null> (bitcoind+0x45e9c6)
#1 BerkeleyBatch::BerkeleyBatch(BerkeleyDatabase&, char const*, bool) <null> (bitcoind+0x457fc7)
#2 CWallet::AddToWallet(std::__1::shared_ptr<CTransaction const>, CWalletTx::Confirmation const&, std::__1::function<bool (CWalletTx&, bool)> const&, bool) <null> (bitcoind+0x531c62)
#3 CWallet::AddToWalletIfInvolvingMe(std::__1::shared_ptr<CTransaction const> const&, CWalletTx::Confirmation, bool) <null> (bitcoind+0x5346b4)
#4 CWallet::blockConnected(CBlock const&, int) <null> (bitcoind+0x535d83)
#5 non-virtual thunk to CWallet::blockConnected(CBlock const&, int) <null> (bitcoind+0x535eba)
#6 interfaces::(anonymous namespace)::NotificationsProxy::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*) <null> (bitcoind+0x105df1)
#7 std::__1::__function::__func<CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_9, std::__1::allocator<CMainSignals::BlockConnected(std::__1::shared_ptr<CBlock const> const&, CBlockIndex const*)::$_9>, void ()>::operator()() <null> (bitcoind+0x3d3392)
#8 SingleThreadedSchedulerClient::ProcessQueue() <null> (bitcoind+0x630fb6)
#9 std::__1::__function::__func<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*>, std::__1::allocator<std::__1::__bind<void (SingleThreadedSchedulerClient::*)(), SingleThreadedSchedulerClient*> >, void ()>::operator()() <null> (bitcoind+0x632ed6)
#10 CScheduler::serviceQueue() <null> (bitcoind+0x62fe74)
#11 std::__1::__function::__func<AppInitMain(util::Ref const&, NodeContext&)::$_4, std::__1::allocator<AppInitMain(util::Ref const&, NodeContext&)::$_4>, void ()>::operator()() <null> (bitcoind+0x12699e)
#12 void TraceThread<std::__1::function<void ()> >(char const*, std::__1::function<void ()>) <null> (bitcoind+0x12b8fa)
#13 boost::detail::thread_data<std::__1::__bind<void (*)(char const*, std::__1::function<void ()>), char const (&) [10], std::__1::function<void ()>&> >::run() <null> (bitcoind+0x14412d)
#14 boost::(anonymous namespace)::thread_proxy(void*) <null> (bitcoind+0x7af31e)
```
See https://travis-ci.org/github/bitcoin/bitcoin/jobs/695761665 for details. | https://github.com/bitcoin/bitcoin/issues/19211 | https://github.com/bitcoin/bitcoin/pull/19226 | 20e95313790c75631e44f9572a2f8767685c52d6 | bc933aeaf04420218b46318e316ee5eaa772823c | 2020-06-08T14:41:37Z | c++ | 2020-06-10T13:25:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,171 | [".travis.yml", "ci/test/05_before_script.sh", "ci/test/06_script_b.sh"] | travis arm64 errors: sudo: unable to resolve host travis-job-bitcoin-bitcoin-694885469 | Seeing "sudo: unable to resolve host travis-job-bitcoin-bitcoin-" errors two different PRs in the travis ARM build followed by timeouts:
https://travis-ci.org/github/bitcoin/bitcoin/jobs/694723263
https://travis-ci.org/github/bitcoin/bitcoin/jobs/694879056
https://travis-ci.org/github/bitcoin/bitcoin/jobs/694885469
I tried restarting the first job repeatedly (maybe 5 times) but it kept failing in the same way. Then I rebased and it happened again, and it happened again on another PR. It doesn't seem to happen on all PRs, even other PRs with the same base, but once it happens it seems to stick.
| https://github.com/bitcoin/bitcoin/issues/19171 | https://github.com/bitcoin/bitcoin/pull/19276 | 75edf2cf0255224141c709e89d02f253d7945f6b | 1c86ed41483471929840eec09b93d7de3a4aeacf | 2020-06-05T04:51:47Z | c++ | 2020-06-15T10:25:06Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,091 | ["test/lint/lint-git-commit-check.sh"] | Write linter to check that commit messages have a new line before the body (or no body) | This comes up really often: https://github.com/bitcoin/bitcoin/pull/19082#issuecomment-635404401
This can be based on the other lint scripts in `./test/lint`.
#### Want to work on this issue?
The purpose of the `good first issue` label is to highlight which issues are suitable for a new contributor without a deep understanding of the codebase.
You do not need to request permission to start working on this. You are encouraged to comment on the issue if you are planning to work on it. This will help other contributors monitor which issues are actively being addressed and is also an effective way to request assistance if and when you need it.
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/19091 | https://github.com/bitcoin/bitcoin/pull/19439 | ad2952d17a2af419a04256b10b53c7377f826a27 | edec7f7c254294cd5c46ae5cf304353d458bb852 | 2020-05-28T15:06:19Z | c++ | 2020-07-30T15:32:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,081 | ["contrib/guix/libexec/build.sh", "share/setup.nsi.in"] | Build/Docs: -help text references rpcauth script not present in binary release | The help text says "a canonical python script is included in `share/rpcauth`":
$ bitcoind -help | grep -A3 rpcauth
-rpcauth=<userpw>
Username and HMAC-SHA-256 hashed password for JSON-RPC connections. The
field <userpw> comes in the format: <USERNAME>:<SALT>$<HASH>. A
canonical python script is included in share/rpcauth. The client
then connects normally using the
rpcuser=<USERNAME>/rpcpassword=<PASSWORD> pair of arguments. This
option can be specified multiple times
This is true of the git repository and the source release, but that file is not available in the binary releases:
$ wget https://bitcoincore.org/bin/bitcoin-core-0.19.1/bitcoin-0.19.1-x86_64-linux-gnu.tar.gz
$ tar tzf bitcoin-0.19.1-x86_64-linux-gnu.tar.gz | grep -i rpcauth || echo FILE NOT FOUND
FILE NOT FOUND
IMO, this file should either be included with the binary releases or it should not be mentioned in the help text. I think this issue needs a decision from experienced contributors about which approach to take, and then can be tagged as a *good first issue* for possible implementation by a less experienced contributor.
Note: this issue is a deliberate duplicate of #14292 (by [request](https://github.com/bitcoin/bitcoin/issues/14292#issuecomment-634733333)). | https://github.com/bitcoin/bitcoin/issues/19081 | https://github.com/bitcoin/bitcoin/pull/25829 | 0ae0aa251b9c0401e4318756ca8b7a41193fac7e | aa774f3e11b073f98e6855e5c0d5e53ddf167dd5 | 2020-05-27T15:37:20Z | c++ | 2022-08-17T13:51:15Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 19,057 | ["doc/release-notes.md", "src/rpc/rawtransaction.cpp", "src/validation.cpp", "src/validation.h", "test/functional/mempool_accept.py", "test/functional/p2p_segwit.py", "test/functional/test_framework/messages.py"] | testmempoolaccept should return the fee | When testing a transaction for mempool acceptance, the fee must be calculated anyway. Thus, with minimal complexity overhead, the testmempoolaccept RPC could return the fee to the user.
#### Useful skills:
Basic understanding of the mempool, the Bitcoin Core RPC interface, and the functional test framework.
#### Want to work on this issue?
The purpose of the `good first issue` label is to highlight which issues are suitable for a new contributor without a deep understanding of the codebase.
You do not need to request permission to start working on this. You are encouraged to comment on the issue if you are planning to work on it. This will help other contributors monitor which issues are actively being addressed and is also an effective way to request assistance if and when you need it.
For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.
| https://github.com/bitcoin/bitcoin/issues/19057 | https://github.com/bitcoin/bitcoin/pull/19940 | 967be53aeec9f02b90f132e0482d27af4c85dd95 | c30f79d418e2e001f1f804a2370db47e5d9ea587 | 2020-05-22T20:54:28Z | c++ | 2020-09-19T07:04:03Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.