status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 17,171 | ["Makefile.am", "configure.ac", "share/setup.nsi.in"] | windows: Files installed by installer *-setup.exe | The installer [`bitcoin-0.19.0rc1-win64-setup.exe`](https://bitcoincore.org/bin/bitcoin-core-0.19.0/test.rc1/bitcoin-0.19.0rc1-win64-setup.exe):
- lacks `test_bitcoin.exe` (is present in `zip`)
- bloats system with _full_ `doc` folder content:
| https://github.com/bitcoin/bitcoin/issues/17171 | https://github.com/bitcoin/bitcoin/pull/25809 | 0f90b586863f68aa01e089e48a06802405e2b83b | b63c24a509adc1672176c0e3700f25eb1f369f20 | 2019-10-17T08:04:29Z | c++ | 2022-08-16T08:14:42Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 17,170 | ["share/setup.nsi.in"] | Windows installer properties and signing | Downloaded [`bitcoin-0.19.0rc1-win64-setup.exe`](https://bitcoincore.org/bin/bitcoin-core-0.19.0/test.rc1/bitcoin-0.19.0rc1-win64-setup.exe).
The Properties - Details tab lacks "File description" and "Copyright" values:
Also, the note that this `exe` file is signed by _Bitcoin Core Code Signing Association_ could be mentioned somewhere in our docs.
| https://github.com/bitcoin/bitcoin/issues/17170 | https://github.com/bitcoin/bitcoin/pull/18059 | 651e34388832149402fea0d26f3dc13bbe197f5a | 6c223152238d2e818e38357b03f38a4dbe9de016 | 2019-10-17T06:56:38Z | c++ | 2020-02-04T02:46:47Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 17,149 | ["src/node/psbt.cpp", "src/psbt.cpp", "src/rpc/rawtransaction.cpp", "src/wallet/psbtwallet.cpp", "src/wallet/test/psbt_wallet_tests.cpp", "test/functional/rpc_psbt.py"] | Potential PSBT issues found by the PSBT fuzzer | Potential PSBT issues found by the PSBT fuzzer (#17136):
```
$ src/test/fuzz/psbt
…
==8112==ERROR: AddressSanitizer: heap-use-after-free on address 0x6070001083f0 at pc 0x55a5d650f41b bp 0x7ffe03cc3c90 sp 0x7ffe03cc3c88
READ of size 8 at 0x6070001083f0 thread T0
#0 0x55a5d650f41a in CTxOut::operator=(CTxOut const&) src/./primitives/transaction.h:133:7
#1 0x55a5d8362e8d in PartiallySignedTransaction::GetInputUTXO(CTxOut&, int) const src/psbt.cpp:72:14
#2 0x55a5d6dae419 in AnalyzePSBT(PartiallySignedTransaction) src/node/psbt.cpp:32:19
#3 0x55a5d64b27d7 in test_one_input(std::vector<unsigned char, std::allocator<unsigned char> > const&) src/test/fuzz/psbt.cpp:28:35
…
$ src/test/fuzz/psbt
…
AddressSanitizer:DEADLYSIGNAL
=================================================================
==22238==ERROR: AddressSanitizer: SEGV on unknown address 0x6098001079e0 (pc 0x55880d55c50f bp 0x7fff8d03d8f0 sp 0x7fff8d03d860 T0)
==22238==The signal is caused by a READ memory access.
#0 0x55880d55c50e in CTxOut::operator=(CTxOut const&) src/./primitives/transaction.h:133:7
#1 0x55880f3b6a83 in SignPSBTInput(SigningProvider const&, PartiallySignedTransaction&, int, int, SignatureData*, bool) src/psbt.cpp:262:14
#2 0x55880f3b81ff in FinalizePSBT(PartiallySignedTransaction&) src/psbt.cpp:311:21
#3 0x55880d500ee9 in test_one_input(std::vector<unsigned char, std::allocator<unsigned char> > const&) src/test/fuzz/psbt.cpp:62:11
…
$ src/test/fuzz/psbt
…
node/psbt.cpp:82:26: runtime error: signed integer overflow: 7857790368227518552 + 6582955728264977243 cannot be represented in type 'long'
#0 0x55a8b66b13ee in AnalyzePSBT(PartiallySignedTransaction)::$_0::operator()(long, CTxOut const&) const src/node/psbt.cpp:82:26
#1 0x55a8b66b1043 in long std::accumulate<__gnu_cxx::__normal_iterator<CTxOut*, std::vector<CTxOut, std::allocator<CTxOut> > >, long, AnalyzePSBT(PartiallySignedTransaction)::$_0>(__gnu_cxx::__normal_iterator<CTxOut*, std::vector<CTxOut, std::allocator<CTxOut> > >, __gnu_cxx::__normal_iterator<CTxOut*, std::vector<CTxOut, std::allocator<CTxOut> > >, long, AnalyzePSBT(PartiallySignedTransaction)::$_0) /usr/bin/../lib/gcc/x86_64-linux-gnu/7.4.0/../../../../include/c++/7.4.0/bits/stl_numeric.h:154:11
#2 0x55a8b66aeecf in AnalyzePSBT(PartiallySignedTransaction) src/node/psbt.cpp:80:27
#3 0x55a8b5db1a17 in test_one_input(std::vector<unsigned char, std::allocator<unsigned char> > const&) src/test/fuzz/psbt.cpp:28:35
…
$ src/test/fuzz/psbt
…
policy/feerate.cpp:18:34: runtime error: signed integer overflow: -7497025602362688435 * 1000 cannot be represented in type 'long'
#0 0x5587f480b863 in CFeeRate::CFeeRate(long const&, unsigned long) src/policy/feerate.cpp:18:34
#1 0x5587f327051f in AnalyzePSBT(PartiallySignedTransaction) src/node/psbt.cpp:116:22
#2 0x5587f2971ac7 in test_one_input(std::vector<unsigned char, std::allocator<unsigned char> > const&) src/test/fuzz/psbt.cpp:28:35
…
``` | https://github.com/bitcoin/bitcoin/issues/17149 | https://github.com/bitcoin/bitcoin/pull/17156 | f1ef7f0aa46338f4cd8de79696027a1bf868f359 | deaa6dd144f5650b385658a0c4f9a014aff8dde2 | 2019-10-15T10:37:14Z | c++ | 2020-01-06T17:57:21Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 17,139 | ["src/init.cpp"] | log, doc: Confusing log message | ```
bitcoind -par=1
```
Excerpt from the `debug.log`:
```
Using 0 threads for script verification
```
Zero? I guess not ;) | https://github.com/bitcoin/bitcoin/issues/17139 | https://github.com/bitcoin/bitcoin/pull/17325 | 08e29473126d5cc4df6d2b3f368c6f6f641c0bd8 | 8a0ca5e9de021ce2f722b321f27208a7bc7110f7 | 2019-10-14T19:50:30Z | c++ | 2019-10-31T16:57:46Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 17,117 | ["src/bitcoin-cli.cpp"] | doc, rpc: -rpcclienttimeout help string is wrong | ```
$ bitcoin-cli --help
Bitcoin Core RPC client version v0.19.0rc1
...
-rpcclienttimeout=<n>
Timeout in seconds during HTTP requests, or 0 for no timeout. (default:
900)
```
The _"0 for no timeout"_ part, added in #9903, is wrong:
```
$ time bitcoin-cli -rpcclienttimeout=0 gettxoutsetinfo
error: Could not connect to the server 127.0.0.1:8332 (error code 0 - "timeout reached")
Make sure the bitcoind server is running and that you are connecting to the correct RPC port.
real 0m51.279s
user 0m0.005s
sys 0m0.019s
```
Both 0.18.0 and 0.19.0rc1 are affected. | https://github.com/bitcoin/bitcoin/issues/17117 | https://github.com/bitcoin/bitcoin/pull/17131 | 561a7d30478b82f5d46dcf0f16e864a9608004f4 | b3b26e149c34fee9c7ae8548c6e547ec6254b441 | 2019-10-12T13:07:19Z | c++ | 2019-10-15T16:01:59Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 17,082 | ["src/qt/bitcoingui.cpp", "src/qt/forms/debugwindow.ui"] | GUI: rename "debug window" | The term "Debug Window" is not accurate IMO and we should consider renaming it to a more user-friendly term (only visible in the window title as well as from the tray menu). | https://github.com/bitcoin/bitcoin/issues/17082 | https://github.com/bitcoin/bitcoin/pull/17096 | 5cb1d938a1c929b861243fa25747355f40bf3399 | 44f15cfdcfc64d5a0c36fded39e4aef49415b11b | 2019-10-09T09:32:38Z | c++ | 2020-01-06T19:29:45Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 17,036 | ["src/bitcoind.cpp", "src/qt/bitcoin.cpp", "src/util/threadnames.cpp", "src/util/threadnames.h"] | Renaming main thread causes issues with UNIX utilities | Renaming the main thread (e.g., the one the program spawns with) causes the name of the daemon in utilities such as "top" to show as "b-init" instead of bitcoind. This is surprising, as it doesn't show the other thread names (by default), you'd expect it to show program names.
This doesn't only affect top: killall does no longer recognize the program name
```
$ killall bitcoind
bitcoind: no process found
$ killall b-init
(no output, succesful)
```
~~In contrast to `bitcoin-qt`, which doesn't suffer from this problem because it has a separate init thread~~, initialization happens in the main thread in `bitcoind`, and it's renamed due to `util::ThreadRename("init");` in `AppInit`. If we want to name the init thread, this should only be done in `bitcoin-qt`.
(not sure when this was introduced, but #16984 made the issue more visible because ther's no bitcoin in the name anymore) | https://github.com/bitcoin/bitcoin/issues/17036 | https://github.com/bitcoin/bitcoin/pull/17038 | f4a0d27e85754d60804ffa36e415b67c263180b9 | 07e4bdba3bd46c3a15dedb0a2660453c300643dc | 2019-10-03T03:05:42Z | c++ | 2019-10-03T04:58:47Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 17,027 | ["contrib/gitian-descriptors/gitian-linux.yml", "contrib/gitian-descriptors/gitian-osx.yml", "contrib/gitian-descriptors/gitian-win.yml"] | the translations of Traditional Chinese in bitcoin_zh_TW.ts got clobbered to Simplified Chinese | ```
commit 977dd23e4023ac2f6cbbe86eb769db079b8018be
Author: Wladimir J. van der Laan <[email protected]>
Date: Mon Sep 30 09:41:11 2019 +0200
qt: Periodic translations update
Pull new translations from Transifex and run `make translate`.
diff --git a/src/qt/locale/bitcoin_zh_TW.ts b/src/qt/locale/bitcoin_zh_TW.ts
index 635151bcc..0a6e5d605 100644
--- a/src/qt/locale/bitcoin_zh_TW.ts
+++ b/src/qt/locale/bitcoin_zh_TW.ts
@@ -3,487 +3,451 @@
<name>AddressBookPage</name>
<message>
<source>Right-click to edit address or label</source>
- <translation>右鍵點一下來修改位址或標記</translation>
+ <translation>鼠标右击编辑地址或标签</translation>
</message>
<message>
<source>Create a new address</source>
- <translation>產生一個新位址</translation>
+ <translation>创建新地址</translation>
</message>
<message>
``` | https://github.com/bitcoin/bitcoin/issues/17027 | https://github.com/bitcoin/bitcoin/pull/17049 | 94e6e9f38deeba61655fee432afe42e66ff72ea3 | fa1ad8f06eba5e120c30f07263250bc382891179 | 2019-10-02T19:34:55Z | c++ | 2019-10-04T13:17:57Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 17,025 | ["src/qt/paymentserver.cpp"] | Duplicate send entries when opening URI from command line | Opening a URI like `bitcoin:bcrt1qu7nl0nxfqwhrrf6v0t60asvq3dympgqdhg03rn?amount=0.00010000` from Chrome on macOS still works as it should.
But opening it through the console, e.g. `/Applications/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt bitcoin:bcrt1qu7nl0nxfqwhrrf6v0t60asvq3dympgqdhg03rn?amount=0.00010000` leads to a duplicate entry on the send screen.
So on macOS it's annoying when debugging the send screen, but otherwise harmless. But we should test the URI handler on different platforms.
Introduced by #16578. | https://github.com/bitcoin/bitcoin/issues/17025 | https://github.com/bitcoin/bitcoin/pull/17031 | f4a0d27e85754d60804ffa36e415b67c263180b9 | 3f89e1eb237efcbd6415ca2cd0acddb6596153d7 | 2019-10-02T16:12:44Z | c++ | 2019-10-02T20:55:52Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 17,019 | ["Makefile.am", "test/functional/feature_loadblock.py", "test/functional/test_runner.py"] | contrib/linearize scripts need tests | The scripts under `contrib/linearize` do not have any tests.
It would be good to have functional tests for them, to assure that they keep working, and so that changes to them are not necessarily held up on manual testing.
| https://github.com/bitcoin/bitcoin/issues/17019 | https://github.com/bitcoin/bitcoin/pull/17091 | a689c119076c7b8dc5b4dea4539e4cbf5adfb72f | 89339d14607434b33cfa343dc75877b62b1dfe0e | 2019-10-02T08:28:07Z | c++ | 2019-10-13T11:09:35Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 17,013 | ["src/qt/test/addressbooktests.cpp", "src/qt/test/apptests.cpp", "src/qt/test/test_main.cpp", "src/qt/test/wallettests.cpp"] | macOs: "test_bitcoin-qt -platform cocoa" no longer works | As of v0.18.1 I can use `test_bitcoin-qt -platform cocoa` to run GUI tests; this opens and closes a regtest GUI a bunch of times.
As of master (6e4f6553913978fcdddba30e0bb6f97edcb12e80) it seems to ignore the `-platform cocoa` and just run the test as with `minimal`.
As seen on macOS 10.14.6. Git bisect blames a2714a5c69f0b0506689af04c3e785f71ee0915d in #16578 `Do not pass in command line arguments to QApplication` (@achow101, @ryanofsky) | https://github.com/bitcoin/bitcoin/issues/17013 | https://github.com/bitcoin/bitcoin/pull/17015 | faccf5f9c899c40d4da5792629d0714249a4616b | fa06bb607da2d3e35723661156d873c8eac1fa50 | 2019-10-01T17:05:51Z | c++ | 2019-10-01T21:00:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 17,010 | ["build-aux/m4/ax_boost_base.m4"] | Missing Boost::System on ARM Ubuntu 18.04 | Following the Ubuntu [instructions](https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#ubuntu--debian) on an Orange Pi Plus 2e running Ubuntu Bionic (Armbian):
```
sudo apt-get install build-essential libtool autotools-dev automake pkg-config bsdmainutils python3 ccache
sudo apt-get install libssl-dev libevent-dev libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-test-dev libboost-thread-dev
./autogen.sh
./configure --disable-wallet --without-gui --disable-tests --disable-bench
...
checking for boostlib >= 1.47.0 (104700)... yes
checking whether the Boost::System library is available... yes
configure: error: Could not find a version of the Boost::System library!
```
```
Linux orangepiplus2e 4.19.57-sunxi #5.90 SMP Fri Jul 5 17:58:43 CEST 2019 armv7l armv7l armv7l GNU/Linux
```
As suggested on [Stack Overflow](https://stackoverflow.com/a/44691993), adding `--with-boost-libdir=/usr/lib/arm-linux-gnueabihf` works around the issue. But ideally `./configure` should figure this out.
I've installed Bitcoin Core on the same type of device before, also using Armbian, though this was over a year ago. I did not need the workaround back then. | https://github.com/bitcoin/bitcoin/issues/17010 | https://github.com/bitcoin/bitcoin/pull/18558 | 1f70185a809362117a8158e386fdead85728794f | b3c3d9a518f8cc51c0b73c5e4ee6bd567be441d2 | 2019-10-01T10:24:29Z | c++ | 2020-04-08T14:28:50Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,992 | ["src/interfaces/chain.cpp", "src/protocol.cpp", "src/protocol.h"] | Compilation warnings with g++ 9.1.1 | I just compiled with a new g++ version for the first time, and noticed some warnings. I don't know how serious these are. I don't think they're very bad (concerning deprecations mostly):
- "specified bound 12 equals destination size"
```
In file included from /usr/include/string.h:494,
from ./serialize.h:20,
from ./netaddress.h:13,
from ./protocol.h:13,
from protocol.cpp:6:
In function ‘char* strncpy(char*, const char*, size_t)’,
inlined from ‘CMessageHeader::CMessageHeader(const unsigned char (&)[4], const char*, unsigned int)’ at protocol.cpp:91:12:
/usr/include/bits/string_fortified.h:106:34: warning: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ specified bound 12 equals destination size [-Wstringop-truncation]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
- implicitly-declared ‘PartiallySignedTransaction& PartiallySignedTransaction::operator=(const PartiallySignedTransaction&)’ is deprecated [-Wdeprecated-copy]
```
psbt.cpp: In function ‘TransactionError CombinePSBTs(PartiallySignedTransaction&, const std::vector<PartiallySignedTransaction>&)’:
psbt.cpp:335:19: warning: implicitly-declared ‘PartiallySignedTransaction& PartiallySignedTransaction::operator=(const PartiallySignedTransaction&)’ is deprecated [-Wdeprecated-copy]
335 | out = psbtxs[0]; // Copy the first one
| ^
In file included from psbt.cpp:5:
./psbt.h:398:5: note: because ‘PartiallySignedTransaction’ has user-provided ‘PartiallySignedTransaction::PartiallySignedTransaction(const PartiallySignedTransaction&)’
398 | PartiallySignedTransaction(const PartiallySignedTransaction& psbt_in) : tx(psbt_in.tx), inputs(psbt_in.inputs), outputs(psbt_in.outputs), unknown(psbt_in.unknown) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
- warning: redundant move in return statement
```
interfaces/chain.cpp: In member function ‘virtual std::unique_ptr<interfaces::Chain::Lock> interfaces::{anonymous}::ChainImpl::lock(bool)’:
interfaces/chain.cpp:249:25: warning: redundant move in return statement [-Wredundant-move]
249 | return std::move(result);
| ~~~~~~~~~^~~~~~~~
interfaces/chain.cpp:249:25: note: remove ‘std::move’ call
``` | https://github.com/bitcoin/bitcoin/issues/16992 | https://github.com/bitcoin/bitcoin/pull/16995 | 210b533a114462473024c92a20a0765001abd45d | f2c416bcf5f898dd996106871dbbd7051851ccac | 2019-09-30T10:05:24Z | c++ | 2020-03-27T19:04:46Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,989 | ["build-aux/m4/bitcoin_qt.m4"] | Don't show 'no (Qt5)' in configure when GUI is disabled | Printing "(Qt5)" in the first place is a holdover from when both Qt4 and Qt5 were supported, and might be useful in the future again when multiple GUI backends are supported. However, printing a specific GUI toolkit name when the GUI is disabled is never useful. Just "no" will do.
```
configure: WARNING: Qt dependencies not found; bitcoin-qt frontend will not be built
checking whether to build Bitcoin Core GUI... no (Qt5)
``` | https://github.com/bitcoin/bitcoin/issues/16989 | https://github.com/bitcoin/bitcoin/pull/17005 | 6b2210f1016c9ed96ce470e588e4cb12fa36a900 | 57b0cd4db9ec26d5a00714016639e218cfa1ccda | 2019-09-30T09:09:07Z | c++ | 2019-09-30T23:03:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,976 | [".appveyor.yml", "ci/test/00_setup_env_native_qt5.sh", "ci/test/06_script_b.sh"] | appveyor should print boost test_suite log on failure | See https://github.com/bitcoin/bitcoin/blob/a6c8aed1f140bef942b32af8aea78f0d5458cd17/.appveyor.yml#L63
However, it should use the `-l test_suite` log level and show the whole output on failure, similar to https://github.com/bitcoin/bitcoin/blob/a6c8aed1f140bef942b32af8aea78f0d5458cd17/src/Makefile.test.include#L371 | https://github.com/bitcoin/bitcoin/issues/16976 | https://github.com/bitcoin/bitcoin/pull/18562 | 661bd5dea3d080cd79f15c7703fc6ab577a1aa0c | dcef5ad6ec10bfea1ea00acf44d0182409c731f2 | 2019-09-27T15:05:20Z | c++ | 2020-04-09T12:07:09Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,950 | ["src/wallet/wallet.cpp"] | gui: crash trying to access info of a removed transaction | A call to `removeprunedfunds` does not update the transaction list in the GUI, and trying to access the info of a deleted transaction will result in a segfault.
```bash
(lldb) run
Process 4859 launched: '/Users/michael/github/bitcoin/src/qt/bitcoin-qt' (x86_64)
2019-09-24 15:41:53.763094+0800 bitcoin-qt[4859:390268] MessageTracer: Falling back to default whitelist
Process 4859 stopped
* thread #1, name = 'bitcoin-main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x34)
frame #0: 0x00000001001c9bf6 bitcoin-qt`TransactionDesc::FormatTxStatus(wtx=0x00007ffeefbfc0e0, status=0x00007ffeefbfc0c0, inMempool=false, numBlocks=1) at transactiondesc.cpp:33:31
30 {
31 if (!status.is_final)
32 {
-> 33 if (wtx.tx->nLockTime < LOCKTIME_THRESHOLD)
34 return tr("Open for %n more block(s)", "", wtx.tx->nLockTime - numBlocks);
35 else
36 return tr("Open until %1").arg(GUIUtil::dateTimeStr(wtx.tx->nLockTime));
Target 0: (bitcoin-qt) stopped.
``` | https://github.com/bitcoin/bitcoin/issues/16950 | https://github.com/bitcoin/bitcoin/pull/16952 | 3ce829888861a6dc6a29da669584ada961d965fa | addaf8af8268d918973883a304025d40af5a33c1 | 2019-09-24T07:51:10Z | c++ | 2019-09-24T09:15:15Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,942 | ["src/script/descriptor.h"] | doc: Make descriptor doc doxygen compatible | The current doxygen documentation for descriptors looks messy, because the source is not in the right format. See e.g. https://dev.visucore.com/bitcoin/doxygen/struct_descriptor.html#a25c23845f9f3178c5de4aa404222ff51
It shouldn't be too hard to properly reformat the docs, so that they are correctly displayed. | https://github.com/bitcoin/bitcoin/issues/16942 | https://github.com/bitcoin/bitcoin/pull/16947 | 3ce829888861a6dc6a29da669584ada961d965fa | 15ac916642f20918f66e32729bb6b0b674e3bc24 | 2019-09-23T17:29:30Z | c++ | 2019-09-24T05:14:20Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,925 | ["depends/patches/zeromq/0002-disable-pthread_set_name_np.patch"] | Alpine Linux 3.10 (latest stable) has some build issues w/dependencies | On the latest Alpine Linux release (3.10), there are build issues which prevent compilation for two packages:
- [ ] openssl (known issue w/`termio` which is fixed in later versions)
- [ ] zeromq (4.3.1 patch is too fuzzy for Alpine `patch`)
To reproduce this issue and the fix, clone this repo on Alpine 3.10, `cd depends && make NO_QT=1`. By solving these 2 items, the depends system builds without issue on Alpine and I've been able to compile the Bitcoin binaries without issue as well.
**Expected behavior**
Dependencies should build without an issue.
**Actual behavior**
OpenSSL termio header not found:
```
gcc -m64 -I.. -I../.. -I../modes -I../asn1 -I../evp -I../../include -DOPENSSL_THREADS -D_REENTRANT -pipe -O2 -I/home/alpine/bitcoin/depends/x86_64-pc-linux-gnu/include -fPIC -Wa,--noexecstack -m64 -DL_ENDIAN -DTERMIO -O3 -Wall -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DMD5_ASM -DAES_ASM -DVPAES_ASM -DBSAES_ASM -DGHASH_ASM -c -o ui_openssl.o ui_openssl.c
ui_openssl.c:232:11: fatal error: termio.h: No such file or directory
# include <termio.h>
^~~~~~~~~~
compilation terminated.
```
ZeroMQ patch won't apply:
```
make zeromq
Preprocessing zeromq...
patching file src/windows.hpp
Possibly reversed hunk 1 at 105
Hunk 1 FAILED 58/58.
#include <winsock2.h>
#include <windows.h>
#include <mswsock.h>
+
+#if defined __MINGW64_VERSION_MAJOR && __MINGW64_VERSION_MAJOR < 4
+// Workaround for mingw-w64 < v4.0 which did not include ws2ipdef.h in iphlpapi.h.
+// Fixed in mingw-w64 by 9bd8fe9148924840d315b4c915dd099955ea89d1.
+#include <ws2def.h>
+#include <ws2ipdef.h>
+#endif
#include <iphlpapi.h>
#if !defined __MINGW32__
make: *** [funcs.mk:254: /home/alpine/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zeromq/4.3.1-41472d87c95/.stamp_preprocessed] Error 1
```
**To reproduce**
*In Alpine Linux 3.10*:
```sh
apk update
apk add git cmake make curl gcc g++ perl automake autoconf libtool pkgconfig python3
git clone https://github.com/bitcoin/bitcoin.git && cd bitcoin
cd depends
make NO_QT=1
```
**System information**
This is on the `master` branch as of commit f8b0b190a.
### Machine specs:
- OS: Alpine Linux 3.10
- CPU/RAM: AWS m5.8xlarge
- Disk size: 80 GB
- Disk Type (HD/SDD): EBS volume
```
cat /etc/alpine-release
3.10.2
``` | https://github.com/bitcoin/bitcoin/issues/16925 | https://github.com/bitcoin/bitcoin/pull/16927 | f8b0b190aa9d13e93ebfe34b5655dbe8ed8df3d3 | 463a1d5244337915de36db36de573eb8782bc430 | 2019-09-20T17:41:39Z | c++ | 2019-09-20T17:44:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,924 | ["src/qt/forms/receivecoinsdialog.ui", "src/qt/locale/bitcoin_en.ts", "src/qt/receivecoinsdialog.cpp"] | Misleading description of useLegacyAddress checkbox | I see that `legacy` means `P2PKH` in both command line options and RPC help info:
```
-addresstype
What type of addresses to use ("legacy", "p2sh-segwit", or "bech32", default: "p2sh-segwit")
```
```
getnewaddress ( "label" "address_type" )
...
2. address_type (string, optional, default=set by -addresstype) The address type to use. Options are "legacy", "p2sh-segwit", and "bech32".
...
```
The useLegacyAddress checkbox describes itself as “Generate legacy address” - however, it actually makes the wallet GUI generate “p2sh-segwit” address for the user if it's checked. | https://github.com/bitcoin/bitcoin/issues/16924 | https://github.com/bitcoin/bitcoin/pull/16928 | 04321494aea6e18027d156d4bc8aff02d3347028 | fa7847d99b7084f1de5dc61506069e32de43a498 | 2019-09-20T17:37:14Z | c++ | 2019-09-21T12:25:58Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,909 | ["contrib/macdeploy/README.md"] | build: make deploy on MacOS creates multiple products | On MacOS 10.15 Beta, I ran `make deploy`, expecting to have an output of `Bitcoin-Core.dmg` per `contrib/macdeploy/README`, but instead get 3 other products -
- `Bitcoin Core.app`
- `Bitcoin-Qt.dmg`
- `dist/Bitcoin Core.app`
Should the `.dmg` be renamed? | https://github.com/bitcoin/bitcoin/issues/16909 | https://github.com/bitcoin/bitcoin/pull/17142 | b33c03b0cb82e57eb862542c9d331b7ceb8f3a62 | 4441e58497513cc55cfebfdcaaeee340f62f8062 | 2019-09-18T21:06:19Z | c++ | 2019-10-15T10:30:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,906 | ["ci/lint/04_install.sh", "test/lint/lint-python-dead-code-whitelist"] | False positive (?) in lint-python-dead-code.sh | Travis reports a false positive on master at the moment:
```
test/functional/data/invalid_txs.py:217: unused variable 'DisabledOpcodeTemplates' (60% confidence)
^---- failure generated from test/lint/lint-python-dead-code.sh
```
I have to agree with the linter that it's slightly confusing code, as `DisabledOpcodeTemplates` (introduced in 0c62e3aa73839e97e65a3155e06a98d84b700a1e, #14696) is not used directly, but the objects created here are definitely used in `iter_all_templates` by iterating over the subclasses.
e.g.
```
…
$ test/functional/p2p_invalid_tx.py
2019-09-18T15:28:40.922000Z TestFramework (INFO): Testing invalid transaction: DisabledOpcode_OP_CAT
2019-09-18T15:28:41.026000Z TestFramework (INFO): Reconnecting to peer
2019-09-18T15:28:41.078000Z TestFramework (INFO): Testing invalid transaction: DisabledOpcode_OP_SUBSTR
2019-09-18T15:28:41.182000Z TestFramework (INFO): Reconnecting to peer
2019-09-18T15:28:41.233000Z TestFramework (INFO): Testing invalid transaction: DisabledOpcode_OP_LEFT
2019-09-18T15:28:41.338000Z TestFramework (INFO): Reconnecting to peer
2019-09-18T15:28:41.389000Z TestFramework (INFO): Testing invalid transaction: DisabledOpcode_OP_RIGHT
2019-09-18T15:28:41.494000Z TestFramework (INFO): Reconnecting to peer
2019-09-18T15:28:41.545000Z TestFramework (INFO): Testing invalid transaction: DisabledOpcode_OP_INVERT
2019-09-18T15:28:41.649000Z TestFramework (INFO): Reconnecting to peer
2019-09-18T15:28:41.701000Z TestFramework (INFO): Testing invalid transaction: DisabledOpcode_OP_AND
2019-09-18T15:28:41.805000Z TestFramework (INFO): Reconnecting to peer
2019-09-18T15:28:41.856000Z TestFramework (INFO): Testing invalid transaction: DisabledOpcode_OP_OR
2019-09-18T15:28:41.960000Z TestFramework (INFO): Reconnecting to peer
2019-09-18T15:28:42.012000Z TestFramework (INFO): Testing invalid transaction: DisabledOpcode_OP_XOR
2019-09-18T15:28:42.116000Z TestFramework (INFO): Reconnecting to peer
2019-09-18T15:28:42.167000Z TestFramework (INFO): Testing invalid transaction: DisabledOpcode_OP_2MUL
2019-09-18T15:28:42.271000Z TestFramework (INFO): Reconnecting to peer
2019-09-18T15:28:42.322000Z TestFramework (INFO): Testing invalid transaction: DisabledOpcode_OP_2DIV
2019-09-18T15:28:42.427000Z TestFramework (INFO): Reconnecting to peer
2019-09-18T15:28:42.479000Z TestFramework (INFO): Testing invalid transaction: DisabledOpcode_OP_MUL
2019-09-18T15:28:42.583000Z TestFramework (INFO): Reconnecting to peer
…
``` | https://github.com/bitcoin/bitcoin/issues/16906 | https://github.com/bitcoin/bitcoin/pull/16907 | 99beda47f56a39e789639a069910763a4af0647e | fac35b21e2c2d798face7e289dcff4c1cce0e1a6 | 2019-09-18T15:14:38Z | c++ | 2019-09-18T15:38:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,894 | ["test/functional/combine_logs.py"] | AppVeyor CI: combine_logs.py fails to fetch debug logs | In case of failures of a functional test, the logs are not combined in the AppVeyor build, examples are
https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/27454958
https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/26931920
This makes it harder to investigate the root cause of the failures of the functional tests.
Some months ago it was still working (see linked logs in #14446).
Error message from AppVeyor Log:
```
python test\functional\test_runner.py --ci --quiet --combinedlogslen=4000 --failfast
Traceback (most recent call last):
File "C:\projects\bitcoin/test/functional/combine_logs.py", line 198, in <module>
main()
File "C:\projects\bitcoin/test/functional/combine_logs.py", line 65, in main
log_events = read_logs(testdir)
File "C:\projects\bitcoin/test/functional/combine_logs.py", line 84, in read_logs
chain = re.search(r'node0/(.+?)/debug\.log$', chain).group(1) # extract the chain name
AttributeError: 'NoneType' object has no attribute 'group'
``` | https://github.com/bitcoin/bitcoin/issues/16894 | https://github.com/bitcoin/bitcoin/pull/16973 | 6288f15f50ab98b336ab86804c4cbea3807dc1d3 | d478a472eb0d666e8a762ed8d24fafbabc5f94f3 | 2019-09-17T10:19:51Z | c++ | 2019-09-27T10:40:20Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,891 | ["src/Makefile.qt.include"] | build: make translate not working correctly on macOS | While reviewing #16882 I noticed that `make translate` doesn't seem to be working completely correctly on macOS. It doesn't generate the changes to `src/qt/bitcoinstrings.cpp`. `xgettext` is available and picked up by `./configure`.
I tested on a Debian system instead, and everything work fine there (reproduces the changes in #16882), so I assume it's some macOS quirk. | https://github.com/bitcoin/bitcoin/issues/16891 | https://github.com/bitcoin/bitcoin/pull/17068 | 7b701fef58f627956d597817a1f9422edd890cdc | c640ca24f9d94f468ec6de023bf885813ac6c9a9 | 2019-09-17T04:12:04Z | c++ | 2019-10-07T04:38:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,872 | ["doc/release-notes-16185.md", "src/wallet/rpcwallet.cpp", "test/functional/wallet_basic.py"] | RPC gettransaction regression | PR #16866 renamed the `decode` argument in gettransaction to `verbose` to make it more consistent with other RPC calls like getrawtransaction.
However, if I understand correctly, it inadvertently overloaded the "details" fields when `verbose` is passed.
The result is that the original "details" field is no longer returned correctly, which seems to be a breaking API change. | https://github.com/bitcoin/bitcoin/issues/16872 | https://github.com/bitcoin/bitcoin/pull/16873 | 0f34f54888f680bfbe7a29ac278636d7178a99bb | 1b41c2c8a126ef4be183e1d800a17d85cab8837b | 2019-09-14T18:38:21Z | c++ | 2019-09-15T16:53:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,844 | ["test/functional/rpc_net.py", "test/functional/test_framework/messages.py"] | test: Add smoke test for getpeerinfo['servicesnames'] | https://github.com/bitcoin/bitcoin/pull/16787#issuecomment-529801457 | https://github.com/bitcoin/bitcoin/issues/16844 | https://github.com/bitcoin/bitcoin/pull/16850 | 07a8f65031c448971ee665f3db0fbf883a34465b | 1d524c62ea679aa89770f9fdcd72b84f013639cb | 2019-09-10T11:32:37Z | c++ | 2019-09-11T15:26:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,838 | ["depends/packages/libxcb.mk", "depends/patches/libxcb/remove_pthread_stubs.patch"] | depends: `sed` robustness | As seen in https://github.com/bitcoin/bitcoin/pull/16837, the `sed` calls in `depends` fail silently, and can result in silent, unwanted regressions when packages are updated.
It seems that a possible solution might be something like the following: https://askubuntu.com/a/1036918 | https://github.com/bitcoin/bitcoin/issues/16838 | https://github.com/bitcoin/bitcoin/pull/25738 | ab3db34836b157fe9a2196989a4d290c714bddc3 | 6745e3693e2b73f6ccb2651c7dab436dcd2a9bfd | 2019-09-09T19:17:16Z | c++ | 2022-07-30T08:34:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,820 | ["src/qt/bitcoingui.cpp", "src/qt/sendcoinsdialog.cpp", "src/qt/walletcontroller.cpp", "src/qt/walletview.cpp"] | Follow ups from #15450 | There's a few small issues left over from #15450:
* [Focusing](https://github.com/bitcoin/bitcoin/pull/15450#pullrequestreview-282297760) on the `Encrypt Wallet` dialog after clicking `Create Wallet`.
> ```cpp
> m_passphrase_dialog->setWindowModality(Qt::ApplicationModal);
> m_passphrase_dialog->show();
> ```
* Wallet [name escaping issue](https://github.com/bitcoin/bitcoin/pull/15450#pullrequestreview-282297760):
> This is at least one inconsistency where if you create a wallet with a HTML escaped character in the name, i.e Alice & Bob, then the & will not be shown in some menus / dialogs.
* Nits from this [review](https://github.com/bitcoin/bitcoin/pull/15450#pullrequestreview-284450044). | https://github.com/bitcoin/bitcoin/issues/16820 | https://github.com/bitcoin/bitcoin/pull/16826 | 2c530ea2ada71ca23fa17bab5023b855515463ef | ad52f054f67374dc46e0096d1e2f593d6372a2df | 2019-09-07T06:58:46Z | c++ | 2019-09-08T20:40:53Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,803 | ["build-aux/m4/ax_boost_base.m4", "build-aux/m4/ax_boost_chrono.m4", "build-aux/m4/ax_boost_filesystem.m4", "build-aux/m4/ax_boost_system.m4", "build-aux/m4/ax_boost_thread.m4", "build-aux/m4/ax_boost_unit_test_framework.m4"] | Recent update to boost m4 lost error reporting improvements | Back in 2014 I made some error reporting changes in 25333a26197b55c23debb38740ed875999aa795a (#3986), to do with reporting the exact boost library that was not being found. These were recently (unintentionally, I assume) removed in aa85dcf47288e86f283f38fe47c022ffcfa53d8b (#13095) by @fanquake.
I'm not sure how much of a problem this is, but wanted to create an issue nevertheless because these this error still gets reported all the time and for troubleshooting it was useful: https://github.com/bitcoin/bitcoin/issues/3219#issuecomment-527771749 .
If people feel this is worth it it'd be trivial to re-do the change.
| https://github.com/bitcoin/bitcoin/issues/16803 | https://github.com/bitcoin/bitcoin/pull/16870 | fb4f5beb6ede4aadeaff779cd67a0f6665419488 | bb99c4e684bbd3053ecf7a789049b11b29260189 | 2019-09-04T08:51:45Z | c++ | 2019-09-13T23:32:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,794 | ["test/functional/feature_assumevalid.py", "test/functional/feature_block.py", "test/functional/feature_dbcrash.py", "test/functional/feature_pruning.py", "test/functional/p2p_invalid_messages.py", "test/functional/tool_wallet.py", "test/functional/wallet_backup.py"] | feature_block and p2p_permissions time out | Current master, on travis:
https://travis-ci.org/bitcoin/bitcoin/builds/578612449
https://travis-ci.org/bitcoin/bitcoin/builds/578444718
https://travis-ci.org/bitcoin/bitcoin/builds/577975853
Reported by @mzumsande in https://github.com/bitcoin/bitcoin/pull/16756#issuecomment-526748925 | https://github.com/bitcoin/bitcoin/issues/16794 | https://github.com/bitcoin/bitcoin/pull/16888 | cd737214ced756898883c8d940d353f0a1c4f4b9 | fa502cb6f07f9a0c170185b760e3e349c6dac5f8 | 2019-09-03T15:50:12Z | c++ | 2019-09-16T17:32:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,780 | ["doc/release-notes-16787.md", "src/rpc/net.cpp", "src/rpc/util.cpp", "src/rpc/util.h"] | Human readable localservices for getnetworkinfo | Currently the `getnetworkinfo` returns something like:
```
"localservices": "0000000000000449",
```
Manually parsing this consistently gives me a headache (see also https://github.com/sipa/bitcoin-seeder/pull/77).
It would be useful to parse this and show the right combination of `NODE_NETWORK`, `NODE_GETUTXO`, `NODE_BLOOM`, `NODE_WITNESS`, `NODE_NETWORK_LIMITED` and `NODE_COMPACT_FILTERS`. In addition the help text for `getnetworkinfo` could be expanded to mention the right BIP numbers for known flags.
There is some ad hoc parsing to populate e.g. `localrelay`, etc (?). Their help text could also refer back to `NODE_GETUTXO`.
See also: https://en.bitcoin.it/wiki/Protocol_documentation#Network_address | https://github.com/bitcoin/bitcoin/issues/16780 | https://github.com/bitcoin/bitcoin/pull/16787 | 6564f58c87a84c88d07629e9d86e15f07d0ed837 | 66740f460af5f9d8c61eb5b154863bffb20d94b5 | 2019-09-01T11:06:43Z | c++ | 2019-09-05T13:12:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,776 | ["src/qt/walletcontroller.cpp", "src/qt/walletcontroller.h", "src/wallet/load.cpp", "src/wallet/wallet.cpp", "test/functional/wallet_multiwallet.py"] | wallet: Duplicate wallets crash bitcoin core | Opening two of the same wallet (tested in v0.18.0 of bitcoin-qt 64 bit) will cause a database collision, and will crash the program.
`[marshall@likon] {21:21} [~] $ bitcoin-0.18.0/bin/bitcoin-qt `
`terminate called after throwing an instance of 'std::runtime_error' what(): BerkeleyBatch: Can't open database 8204388-wallet.dat (duplicates fileid 8b1c090000000800e25686350000000000000000 from 1352491-wallet.dat)`
`Aborted (core dumped)`
I have been able to reproduce the issue by importing two of the same wallet (with different filenames). | https://github.com/bitcoin/bitcoin/issues/16776 | https://github.com/bitcoin/bitcoin/pull/16923 | 5c1ba3a10a18c6edee20f27f3609ffbbbaa2e8f3 | 6bdd515ccf1b0d3ec5990467db87b9f7963b9b51 | 2019-09-01T01:43:18Z | c++ | 2020-04-02T13:07:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,773 | ["src/validation.cpp"] | spurious `Synchronizing blockheaders` log messages on node catching up | I get a lot of spurious messages like this in the log:
```
2019-08-31T18:07:53Z Synchronizing blockheaders, height: 592633 (~100.00%)
2019-08-31T18:09:40Z Synchronizing blockheaders, height: 592634 (~100.00%)
2019-08-31T18:09:40Z Synchronizing blockheaders, height: 592634 (~100.00%)
2019-08-31T18:09:40Z Synchronizing blockheaders, height: 592634 (~100.00%)
2019-08-31T18:09:40Z Synchronizing blockheaders, height: 592634 (~100.00%)
2019-08-31T18:09:40Z Synchronizing blockheaders, height: 592634 (~100.00%)
2019-08-31T18:10:28Z Synchronizing blockheaders, height: 592635 (~100.00%)
2019-08-31T18:10:28Z Synchronizing blockheaders, height: 592635 (~100.00%)
2019-08-31T18:10:28Z Synchronizing blockheaders, height: 592635 (~100.00%)
2019-08-31T18:10:28Z Synchronizing blockheaders, height: 592635 (~100.00%)
2019-08-31T18:10:28Z Synchronizing blockheaders, height: 592635 (~100.00%)
2019-08-31T18:11:01Z Synchronizing blockheaders, height: 592636 (~100.00%)
2019-08-31T18:11:01Z Synchronizing blockheaders, height: 592636 (~100.00%)
2019-08-31T18:11:01Z Synchronizing blockheaders, height: 592636 (~100.00%)
2019-08-31T18:11:01Z Synchronizing blockheaders, height: 592636 (~100.00%)
2019-08-31T18:11:01Z Synchronizing blockheaders, height: 592636 (~100.00%)
```
also
```
2019-08-31T18:19:47Z New outbound peer connected: version: 70015, blocks=592636, peer=0
2019-08-31T18:19:47Z Synchronizing blockheaders, height: 592636 (~100.00%)
2019-08-31T18:19:47Z New outbound peer connected: version: 70015, blocks=592636, peer=1
2019-08-31T18:19:48Z Synchronizing blockheaders, height: 592636 (~100.00%)
2019-08-31T18:19:48Z New outbound peer connected: version: 70015, blocks=592636, peer=2
2019-08-31T18:19:49Z Synchronizing blockheaders, height: 592636 (~100.00%)
```
This log message was introduced in #15615 by @jonasschnelli..
From what I understand, it's supposed to only be shown once per 2000 blocks, not multiple times for the same block.
| https://github.com/bitcoin/bitcoin/issues/16773 | https://github.com/bitcoin/bitcoin/pull/16774 | 495db72ee7d8c8302d357cb10d2bc2df18b9a5e0 | dcc448e3d2b97f7e4e23f5ed174762cec3530306 | 2019-08-31T18:18:45Z | c++ | 2019-08-31T20:00:35Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,734 | ["Makefile.am", "contrib/gitian-descriptors/gitian-linux.yml", "contrib/gitian-descriptors/gitian-osx.yml", "contrib/gitian-descriptors/gitian-win.yml"] | Generate release tarball with git archive | A lot of files are missing from the release tarball (see #6753), so it would probably be easier and more consistnet to just replace it with a simple call to `git archive` than to enumerate every single file and add it to the dist target in the Makefile. | https://github.com/bitcoin/bitcoin/issues/16734 | https://github.com/bitcoin/bitcoin/pull/18331 | 3f5107d008e15efa364c53bd3ed4e819cd2c6712 | baa72cd9a2fd1c7213f726e5354f87591ddd895f | 2019-08-27T17:09:31Z | c++ | 2020-03-25T13:48:44Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,700 | ["src/Makefile.test.include"] | test: boost unit tests don't handle assert very well | When running into an assert failure, the boost unit test framework does not shut down cleanly. It does not call the `BasicTestingSetup` destructor. Thus, the test process will never shut down. As a result of that, the failure is never passed back to the caller.
On travis, this will result in frustrating and hard-to-debug timeouts: E.g. https://travis-ci.org/bitcoin/bitcoin/jobs/575909995#L3584
I see two ways to fix this:
* Use exceptions instead of assertions, especially in non-validation debug code
* Teach the boost unit test framework how to handle `asserts`
| https://github.com/bitcoin/bitcoin/issues/16700 | https://github.com/bitcoin/bitcoin/pull/18183 | 9dd7bd47be2f046ea4b114ab86a099ec483d9f3a | 36e507227ed6b7006227eabb13475177359cbc04 | 2019-08-23T18:06:23Z | c++ | 2020-02-21T23:00:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,693 | ["doc/tor.md", "src/chainparamsbase.cpp", "src/chainparamsbase.h", "src/init.cpp", "src/net.cpp", "src/net.h", "src/torcontrol.cpp", "src/torcontrol.h"] | ADD_ONION assumes bitcoind to reside in hardcoded 127.0.0.1 | https://github.com/bitcoin/bitcoin/blob/d72758c3f6c34cd835f5de3efc230964f3b1ea56/src/torcontrol.cpp#L539
If a user is running Tor proxy outside localhost (perhaps on other host inside LAN or in containerised environment) , the automatic creation of onion services ends up creating an onion service listening to hardcored 127.0.0.1 address on the Tor proxy's host instead of the private address of the bitcoind – effectively running an empty onion service listening the Tor proxy's localhost. | https://github.com/bitcoin/bitcoin/issues/16693 | https://github.com/bitcoin/bitcoin/pull/19991 | 60ec57b3d73e5cef71ebf3c4cdf54a4474bf492b | df2129a2349b1877049f250551f49a4592e73765 | 2019-08-23T09:54:03Z | c++ | 2020-10-02T11:37:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,668 | ["src/wallet/wallet.cpp"] | Lifetime issue in ReleaseWallet(CWallet* wallet) | While checking #16661 I stumbled upon what seems to be a lifetime issue in `ReleaseWallet(CWallet* wallet)` (`wallet.cpp`).
https://github.com/bitcoin/bitcoin/blob/fa6431055abfacea4f72ef11d061c7c755de327a/src/wallet/wallet.cpp#L107-L111
After `delete wallet;` the pointer is invalid and shouldn't be used like in the call `g_unloading_wallet_set.erase(wallet)`.
The code was introduced in #14941 which was merged into `master` on January 15, 2019.
In addition to fixing this specific instance it might be worth thinking about how we can use static analysis to automatically catch this class of issues going forward :-) | https://github.com/bitcoin/bitcoin/issues/16668 | https://github.com/bitcoin/bitcoin/pull/16716 | 3ca514ddb77253042877d1a72dfd3021c3de2812 | d9d8984270dbb004ec94f8dbb289be2bc9e4dbc3 | 2019-08-20T10:39:30Z | c++ | 2019-08-25T01:07:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,660 | ["test/functional/p2p_eviction.py", "test/functional/test_runner.py"] | Connection eviction logic (AttemptToEvictConnection) is not covered by our test suite | From what I can tell the connection eviction logic is not covered by our test suite (functional and unit tests).
More specifically the following is never executed with `nInbound >= nMaxInbound`:
https://github.com/bitcoin/bitcoin/blob/ed9a2a37c1878ba6b75c39b7cb263dc16c52a295/src/net.cpp#L962-L970
Context:
https://github.com/bitcoin/bitcoin/blob/ed9a2a37c1878ba6b75c39b7cb263dc16c52a295/src/net.cpp#L800-L808
A test would be nice here :-)
Due to `AttemptToEvictConnection` not being tested the following `net.cpp` functions -- which are only called directly or indirectly via `AttemptToEvictConnection` -- are currently untested:
```
static bool ReverseCompareNodeMinPingTime(const NodeEvictionCandidate& a, const NodeEvictionCandidate& b)
static bool ReverseCompareNodeTimeConnected(const NodeEvictionCandidate& a, const NodeEvictionCandidate& b)
static bool CompareNetGroupKeyed(const NodeEvictionCandidate& a, const NodeEvictionCandidate& b)
static bool CompareNodeBlockTime(const NodeEvictionCandidate& a, const NodeEvictionCandidate& b)
static bool CompareNodeTXTime(const NodeEvictionCandidate& a, const NodeEvictionCandidate& b)
static void EraseLastKElements(std::vector<T>& elements, Comparator comparator, size_t k)
``` | https://github.com/bitcoin/bitcoin/issues/16660 | https://github.com/bitcoin/bitcoin/pull/16756 | 19e919217e6d62e3640525e4149de1a4ae04e74f | 5af16a4db76f8c00b6c9598147ab49d79be1f149 | 2019-08-19T20:14:19Z | c++ | 2020-06-12T18:48:20Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,627 | [".github/ISSUE_TEMPLATE.md", ".github/ISSUE_TEMPLATE/bug_report.md", ".github/ISSUE_TEMPLATE/feature_request.md"] | doc: Move to new GitHub issue templates | Apparently we're using the old version of the GitHub issue templates. Not sure if there are any advantages to switching to the new form or not. Info here: https://help.github.com/en/articles/about-issue-and-pull-request-templates.
| https://github.com/bitcoin/bitcoin/issues/16627 | https://github.com/bitcoin/bitcoin/pull/16806 | 189c19e012427a0068fc51b9fcb1428dc28aa681 | fabca7756d6908ad581f3a699f1be6ecc9f62e03 | 2019-08-16T02:25:30Z | c++ | 2019-09-08T13:39:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,576 | [".travis.yml", "ci/test/00_setup_env_arm.sh", "ci/test/06_script_b.sh"] | [help needed] Add notes on how to run unit and functional tests in QEMU | QEMU allows to emulate a processor (even of different architecture). We cross-compile to aarch64 and arm64, among others. Even though developers run tests on those architectures sporadically, it would be nice if there was documentation or a script in our repo on how to do that in QEMU. | https://github.com/bitcoin/bitcoin/issues/16576 | https://github.com/bitcoin/bitcoin/pull/17041 | e173d587e1c2391f774d08f28b7337cbe4ffcbe5 | fa79dff624110992ca85c4abf6950e3ac0df72ef | 2019-08-09T15:06:30Z | c++ | 2019-10-09T13:33:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,537 | ["test/functional/feature_pruning.py"] | test: feature_pruning fails with AssertionError (intermittent) | Current master.
Excerpt:
```
node0 2019-08-02T18:17:40.159357Z [http] Received a POST request for / from 127.0.0.1:41390
node0 2019-08-02T18:17:40.206391Z [httpworker.3] ThreadRPCServer method=submitblock user=__cookie__
node0 2019-08-02T18:17:40.365855Z [httpworker.3] PeerLogicValidation::NewPoWValidBlock sending header-and-ids 6db3371c4f0ad084a24c512bb7a3c0de35280a5feb1037b6ba4ceae5bf579114 to peer=27
node0 2019-08-02T18:17:40.367280Z [httpworker.3] sending cmpctblock (950159 bytes) peer=27
node0 2019-08-02T18:17:40.381896Z [httpworker.3] PeerLogicValidation::NewPoWValidBlock sending header-and-ids 6db3371c4f0ad084a24c512bb7a3c0de35280a5feb1037b6ba4ceae5bf579114 to peer=28
node0 2019-08-02T18:17:40.383189Z [httpworker.3] sending cmpctblock (950159 bytes) peer=28
node0 2019-08-02T18:17:40.406853Z [httpworker.3] - Load block from disk: 0.00ms [0.05s]
node0 2019-08-02T18:17:40.407052Z [httpworker.3] - Sanity checks: 0.01ms [0.03s (0.01ms/blk)]
node0 2019-08-02T18:17:40.407149Z [httpworker.3] - Fork checks: 0.11ms [0.19s (0.09ms/blk)]
node1 2019-08-02T18:17:40.417969Z [msghand] received: cmpctblock (950159 bytes) peer=14
node1 2019-08-02T18:17:40.437712Z [msghand] Initialized PartiallyDownloadedBlock for block 6db3371c4f0ad084a24c512bb7a3c0de35280a5feb1037b6ba4ceae5bf579114 using a cmpctblock of size 950159
node1 2019-08-02T18:17:40.437830Z [msghand] received: blocktxn (33 bytes) peer=14
node0 2019-08-02T18:17:40.461279Z [httpworker.3] - Connect 1 transactions: 54.05ms (54.045ms/tx, 0.000ms/txin) [71.60s (35.98ms/blk)]
node0 2019-08-02T18:17:40.461408Z [httpworker.3] - Verify 0 txins: 54.25ms (0.000ms/txin) [71.94s (36.15ms/blk)]
node0 2019-08-02T18:17:40.461652Z [httpworker.3] - Index writing: 0.25ms [0.50s (0.25ms/blk)]
node0 2019-08-02T18:17:40.461701Z [httpworker.3] - Callbacks: 0.05ms [0.10s (0.05ms/blk)]
node0 2019-08-02T18:17:40.461781Z [httpworker.3] - Connect total: 54.98ms [73.14s (36.75ms/blk)]
node0 2019-08-02T18:17:40.461831Z [httpworker.3] - Flush: 0.04ms [0.11s (0.06ms/blk)]
node0 2019-08-02T18:17:40.461903Z [httpworker.3] - Writing chainstate: 0.08ms [0.16s (0.08ms/blk)]
node0 2019-08-02T18:17:40.463359Z [httpworker.3] Blockpolicy estimates updated by 0 of 0 block txs, since last block 0 of 0 tracked, mempool map size 0, max target 0 from current
node0 2019-08-02T18:17:40.463950Z [httpworker.3] UpdateTip: new best=6db3371c4f0ad084a24c512bb7a3c0de35280a5feb1037b6ba4ceae5bf579114 height=1552 version=0x20000000 log2_work=11.600842 tx=1553 date='2019-08-02T18:19:52Z' progress=1.000000 cache=0.1MiB(650txo)
node0 2019-08-02T18:17:40.464006Z [httpworker.3] - Connect postprocess: 2.10ms [3.91s (1.96ms/blk)]
node0 2019-08-02T18:17:40.464046Z [httpworker.3] - Connect block: 57.22ms [77.36s (38.88ms/blk)]
node0 2019-08-02T18:17:40.464129Z [httpworker.3] Checking mempool with 0 transactions and 0 inputs
test 2019-08-02T18:17:40.472000Z TestFramework (INFO): Usage should be below target: 560
node1 2019-08-02T18:17:40.486452Z [msghand] Successfully reconstructed block 6db3371c4f0ad084a24c512bb7a3c0de35280a5feb1037b6ba4ceae5bf579114 with 1 txn prefilled, 0 txn from mempool (incl at least 0 from extra pool) and 0 txn requested
node1 2019-08-02T18:17:40.492254Z [msghand] PeerLogicValidation::NewPoWValidBlock sending header-and-ids 6db3371c4f0ad084a24c512bb7a3c0de35280a5feb1037b6ba4ceae5bf579114 to peer=15
node1 2019-08-02T18:17:40.493497Z [msghand] sending cmpctblock (950159 bytes) peer=15
node1 2019-08-02T18:17:40.516284Z [msghand] - Load block from disk: 0.01ms [0.01s]
node1 2019-08-02T18:17:40.516417Z [msghand] - Sanity checks: 0.01ms [0.02s (0.01ms/blk)]
node1 2019-08-02T18:17:40.516502Z [msghand] - Fork checks: 0.09ms [0.25s (0.11ms/blk)]
node1 2019-08-02T18:17:40.568948Z [msghand] - Connect 1 transactions: 52.38ms (52.379ms/tx, 0.000ms/txin) [69.38s (29.65ms/blk)]
node1 2019-08-02T18:17:40.569060Z [msghand] - Verify 0 txins: 52.55ms (0.000ms/txin) [69.83s (29.84ms/blk)]
node1 2019-08-02T18:17:40.569290Z [msghand] - Index writing: 0.23ms [0.44s (0.19ms/blk)]
node1 2019-08-02T18:17:40.569332Z [msghand] - Callbacks: 0.05ms [0.12s (0.05ms/blk)]
node1 2019-08-02T18:17:40.569409Z [msghand] - Connect total: 53.17ms [70.93s (30.31ms/blk)]
node1 2019-08-02T18:17:40.569454Z [msghand] - Flush: 0.04ms [0.10s (0.04ms/blk)]
node1 2019-08-02T18:17:40.569527Z [msghand] - Writing chainstate: 0.07ms [0.14s (0.06ms/blk)]
node1 2019-08-02T18:17:40.570938Z [msghand] Blockpolicy estimates updated by 0 of 0 block txs, since last block 0 of 0 tracked, mempool map size 0, max target 0 from current
node1 2019-08-02T18:17:40.571506Z [msghand] UpdateTip: new best=6db3371c4f0ad084a24c512bb7a3c0de35280a5feb1037b6ba4ceae5bf579114 height=1552 version=0x20000000 log2_work=11.600842 tx=1553 date='2019-08-02T18:19:52Z' progress=1.000000 cache=0.1MiB(650txo)
node1 2019-08-02T18:17:40.571560Z [msghand] - Connect postprocess: 2.03ms [3.66s (1.57ms/blk)]
node1 2019-08-02T18:17:40.571599Z [msghand] - Connect block: 55.33ms [74.84s (31.98ms/blk)]
node1 2019-08-02T18:17:40.571675Z [msghand] Checking mempool with 0 transactions and 0 inputs
test 2019-08-02T18:17:43.227000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/root/workspace/bitcoin-core/test/functional/test_framework/test_framework.py", line 193, in main
self.run_test()
File "/root/workspace/bitcoin-core/test/functional/feature_pruning.py", line 396, in run_test
self.reorg_test() # (1033, )
File "/root/workspace/bitcoin-core/test/functional/feature_pruning.py", line 210, in reorg_test
assert_greater_than(550, usage)
File "/root/workspace/bitcoin-core/test/functional/test_framework/util.py", line 44, in assert_greater_than
raise AssertionError("%s <= %s" % (str(thing1), str(thing2)))
AssertionError: 550 <= 560.1718864440918
node2 2019-08-02T18:17:44.476610Z [msghand] Prune: UnlinkPrunedFiles deleted blk/rev (00004)
node2 2019-08-02T18:17:44.476787Z [msghand] Writing final batch of 0.00 MiB
node2 2019-08-02T18:17:44.477697Z [msghand] Committed 0 changed transaction outputs (out of 0) to coin database...
node2 2019-08-02T18:17:44.484856Z [msghand] - Load block from disk: 0.01ms [0.04s]
node2 2019-08-02T18:17:44.485366Z [msghand] - Sanity checks: 0.11ms [0.02s (0.01ms/blk)]
node2 2019-08-02T18:17:44.485479Z [msghand] - Fork checks: 0.14ms [0.18s (0.10ms/blk)]
test 2019-08-02T18:17:44.522000Z TestFramework (DEBUG): Closing down network thread
node2 2019-08-02T18:17:44.544340Z [msghand] - Connect 1 transactions: 58.78ms (58.779ms/tx, 0.000ms/txin) [70.18s (38.69ms/blk)]
node2 2019-08-02T18:17:44.544504Z [msghand] - Verify 0 txins: 59.02ms (0.000ms/txin) [70.48s (38.86ms/blk)]
node2 2019-08-02T18:17:44.544743Z [msghand] - Index writing: 0.24ms [0.45s (0.25ms/blk)]
node2 2019-08-02T18:17:44.544786Z [msghand] - Callbacks: 0.05ms [0.09s (0.05ms/blk)]
node2 2019-08-02T18:17:44.544871Z [msghand] - Connect total: 60.10ms [71.70s (39.52ms/blk)]
node2 2019-08-02T18:17:44.544915Z [msghand] - Flush: 0.05ms [0.09s (0.05ms/blk)]
node2 2019-08-02T18:17:44.544985Z [msghand] - Writing chainstate: 0.07ms [0.14s (0.08ms/blk)]
node2 2019-08-02T18:17:44.546402Z [msghand] Blockpolicy estimates updated by 0 of 0 block txs, since last block 0 of 0 tracked, mempool map size 0, max target 0 from current
node2 2019-08-02T18:17:44.546973Z [msghand] UpdateTip: new best=3fa2e1b6704dc4c0ea7238313abe4242915ce18351455222a8510ad0fbefd19f height=1526 version=0x20000000 log2_work=11.576484 tx=1527 date='2019-08-02T18:19:26Z' progress=1.000000 cache=0.0MiB(0txo)
node2 2019-08-02T18:17:44.547032Z [msghand] - Connect postprocess: 2.04ms [3.64s (2.01ms/blk)]
node2 2019-08-02T18:17:44.547072Z [msghand] - Connect block: 62.27ms [75.61s (41.68ms/blk)]
node2 2019-08-02T18:17:44.547154Z [msghand] Checking mempool with 0 transactions and 0 inputs
node2 2019-08-02T18:17:44.554409Z [msghand] received: cmpctblock (950159 bytes) peer=14
node2 2019-08-02T18:17:44.575317Z [msghand] sending ping (8 bytes) peer=14
node1 2019-08-02T18:17:44.575900Z [msghand] received: ping (8 bytes) peer=15
node2 2019-08-02T18:17:44.576024Z [msghand] received: cmpctblock (950159 bytes) peer=13
node1 2019-08-02T18:17:44.576117Z [msghand] sending pong (8 bytes) peer=15
test 2019-08-02T18:17:44.587000Z TestFramework (INFO): Stopping nodes
| https://github.com/bitcoin/bitcoin/issues/16537 | https://github.com/bitcoin/bitcoin/pull/16538 | 3a3d8b83571205b8329d4ee25537e3cc4397c3b8 | fa566b2601ee5a40bf814e529d7db253dacd28e7 | 2019-08-02T19:24:17Z | c++ | 2019-08-02T19:36:06Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,520 | ["test/functional/feature_pruning.py"] | test: feature_pruning fails with "invalid header received" (intermittent) | Current master.
excerpt from log:
```
node0 2019-07-30T22:06:01.182801Z [httpworker.1] UpdateTip: new best=7ab45b35f902d9c29b48424b452e715bd2cc82fe1c3fe906f35e6487770c64af height=1528 version=0x20000000 log2_work=11.578373 tx=1529 date='2019-07-30T22:07:39Z' progress=1.000000 cache=0.1MiB(858txo)
node0 2019-07-30T22:06:01.182860Z [httpworker.1] - Connect postprocess: 0.61ms [4.21s (1.56ms/blk)]
node0 2019-07-30T22:06:01.182899Z [httpworker.1] - Connect block: 1.84ms [115.73s (42.96ms/blk)]
node0 2019-07-30T22:06:01.182970Z [httpworker.1] Checking mempool with 0 transactions and 0 inputs
node0 2019-07-30T22:06:01.190272Z [scheduler] [default wallet] AddToWallet 17ecd52d2c177743bb26c9a400aaf6cfd8b902211e955da654b3cc6282c3addd new
node0 2019-07-30T22:06:01.190843Z [msghand] SendMessages: sending inv peer=28 hash=7ab45b35f902d9c29b48424b452e715bd2cc82fe1c3fe906f35e6487770c64af
node0 2019-07-30T22:06:01.190958Z [msghand] sending inv (37 bytes) peer=28
node1 2019-07-30T22:06:01.191437Z [msghand] received: inv (37 bytes) peer=14
node1 2019-07-30T22:06:01.191565Z [msghand] got inv: block 7ab45b35f902d9c29b48424b452e715bd2cc82fe1c3fe906f35e6487770c64af new peer=14
node1 2019-07-30T22:06:01.191638Z [msghand] sending getheaders (741 bytes) peer=14
node1 2019-07-30T22:06:01.191796Z [msghand] getheaders (1552) 7ab45b35f902d9c29b48424b452e715bd2cc82fe1c3fe906f35e6487770c64af to peer=14
node0 2019-07-30T22:06:01.192116Z [msghand] received: getheaders (741 bytes) peer=28
node0 2019-07-30T22:06:01.192227Z [msghand] getheaders 1032 to 7ab45b35f902d9c29b48424b452e715bd2cc82fe1c3fe906f35e6487770c64af from peer=28
node0 2019-07-30T22:06:01.193508Z [msghand] sending headers (40260 bytes) peer=28
node1 2019-07-30T22:06:01.195532Z [msghand] received: headers (40260 bytes) peer=14
test 2019-07-30T22:06:01.197000Z TestFramework (INFO): Verify node 2 reorged back to the main chain, some blocks of which it had to redownload
node2 2019-07-30T22:06:01.204025Z [http] Received a POST request for / from 127.0.0.1:57753
node2 2019-07-30T22:06:01.204272Z [httpworker.1] ThreadRPCServer method=getblockcount user=__cookie__
node1 2019-07-30T22:06:01.205540Z [msghand] ERROR: AcceptBlockHeader: block 7ae135ed9c9ee74d2070a1f438cfcf24fcef27e6c60915bfccb17b249f3411b4 is marked invalid
node1 2019-07-30T22:06:01.210958Z [msghand] peer=14: invalid header received
node1 2019-07-30T22:06:01.211261Z [msghand] ProcessMessages(headers, 40260 bytes) FAILED peer=14
node2 2019-07-30T22:06:01.257383Z [http] Received a POST request for / from 127.0.0.1:57753
node2 2019-07-30T22:06:01.257592Z [httpworker.0] ThreadRPCServer method=getblockcount user=__cookie__
...
...
...
node2 2019-07-30T22:21:01.184799Z [httpworker.0] ThreadRPCServer method=getblockcount user=__cookie__
test 2019-07-30T22:21:01.603000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
wait_until(lambda: self.nodes[2].getblockcount() >= goalbestheight, timeout=900)
'''
test 2019-07-30T22:21:01.607000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/root/workspace/bitcoin-core/test/functional/test_framework/test_framework.py", line 193, in main
self.run_test()
File "/root/workspace/bitcoin-core/test/functional/feature_pruning.py", line 429, in run_test
self.reorg_back()
File "/root/workspace/bitcoin-core/test/functional/feature_pruning.py", line 250, in reorg_back
wait_until(lambda: self.nodes[2].getblockcount() >= goalbestheight, timeout=900)
File "/root/workspace/bitcoin-core/test/functional/test_framework/util.py", line 225, in wait_until
raise AssertionError("Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
wait_until(lambda: self.nodes[2].getblockcount() >= goalbestheight, timeout=900)
''' not true after 900 seconds
| https://github.com/bitcoin/bitcoin/issues/16520 | https://github.com/bitcoin/bitcoin/pull/16538 | 3a3d8b83571205b8329d4ee25537e3cc4397c3b8 | fa566b2601ee5a40bf814e529d7db253dacd28e7 | 2019-08-01T17:30:36Z | c++ | 2019-08-02T19:36:06Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,518 | ["test/functional/feature_dbcrash.py", "test/functional/feature_fee_estimation.py"] | feature_fee_estimation.py test fails randomly | See log https://bitcoinbuilds.org/index.php?ansilog=44accd13-eea0-4aab-a6a4-f0694f12a68f.log#l7024 (`feature_fee_estimation.py` failed on master).
There is a dust detection exception during `sendrawtransaction` (https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_fee_estimation.py#L66). | https://github.com/bitcoin/bitcoin/issues/16518 | https://github.com/bitcoin/bitcoin/pull/16493 | fa1bb53b0d76b1bfdc0f0669e260df4768d3be29 | fa36aa4922582fadf1aa8cbf89c33feeae80ac44 | 2019-08-01T08:49:29Z | c++ | 2019-08-01T14:36:52Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,499 | ["src/net_processing.cpp", "src/policy/feerate.h", "src/txmempool.cpp", "src/txmempool.h", "src/wallet/rpcwallet.cpp", "test/functional/p2p_feefilter.py"] | Fee(rate) mismatch between min relay and fee filter | I was messing around with min relay policies and found that under certain circumstances the mempool will accept things, then not relay to any peers.
Example made using wallet:
Transaction of size 6195, fee of 619 satoshis, minrelay of 100 satoshis per kvB. Mempool logic allows it:
```
// No transactions are allowed below minRelayTxFee except from disconnected blocks
if (!bypass_limits && nModifiedFees < ::minRelayTxFee.GetFee(nSize)) {
return state.DoS(0, false, REJECT_INSUFFICIENTFEE, "min relay fee not met", false, strprintf("%d < %d", nModifiedFees, ::minRelayTxFee.GetFee(nSize)));
}
```
and lets it into mempool
but in net_processing.cpp:
```
if (filterrate && txinfo.feeRate.GetFeePerK() < filterrate) {
continue;
}
```
this gets hit because the computed feerate is insufficient(printing I added):
```
0.00000099 BTC/kB
```
I'm not super at arithmetic so I'm opening this up in case someone has an easy fix.
let me also get a reproducible test failure with this... | https://github.com/bitcoin/bitcoin/issues/16499 | https://github.com/bitcoin/bitcoin/pull/16507 | 6a51f7951716d6d6fc0f9b56028f3a0dd02b61c8 | eb7b78165966f2c79da71b993c4c4d793e37297f | 2019-07-30T20:16:55Z | c++ | 2019-10-03T18:03:27Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,498 | ["test/functional/feature_dbcrash.py", "test/functional/feature_fee_estimation.py"] | feature_dbcrash fails on sendrawtransaction [JSONRPCException: dust (code 64) (-26)] | Current master
```
node3 2019-07-30T17:10:17.042876Z [httpworker.0] ThreadRPCServer method=listunspent user=__cookie__
test 2019-07-30T17:10:17.304000Z TestFramework (DEBUG): Node3 utxo count: 88
test 2019-07-30T17:10:17.305000Z TestFramework (INFO): Iteration 18, generating 2500 transactions [4, 1, 0]
node3 2019-07-30T17:10:17.308014Z [http] Received a POST request for / from 127.0.0.1:36933
node3 2019-07-30T17:10:17.308240Z [httpworker.3] ThreadRPCServer method=signrawtransactionwithwallet user=__cookie__
node3 2019-07-30T17:10:17.316277Z [http] Received a POST request for / from 127.0.0.1:36933
node3 2019-07-30T17:10:17.316528Z [httpworker.1] ThreadRPCServer method=sendrawtransaction user=__cookie__
test 2019-07-30T17:10:17.318000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
File "/root/workspace/bitcoin-core/test/functional/test_framework/test_framework.py", line 193, in main
self.run_test()
File "/root/workspace/bitcoin-core/test/functional/feature_dbcrash.py", line 241, in run_test
self.generate_small_transactions(self.nodes[3], 2500, utxo_list)
File "/root/workspace/bitcoin-core/test/functional/feature_dbcrash.py", line 211, in generate_small_transactions
node.sendrawtransaction(tx_signed_hex)
File "/root/workspace/bitcoin-core/test/functional/test_framework/coverage.py", line 47, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/root/workspace/bitcoin-core/test/functional/test_framework/authproxy.py", line 141, in __call__
raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: dust (code 64) (-26)
| https://github.com/bitcoin/bitcoin/issues/16498 | https://github.com/bitcoin/bitcoin/pull/16493 | fa1bb53b0d76b1bfdc0f0669e260df4768d3be29 | fa36aa4922582fadf1aa8cbf89c33feeae80ac44 | 2019-07-30T18:35:59Z | c++ | 2019-08-01T14:36:52Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,488 | ["test/functional/feature_dbcrash.py", "test/functional/feature_fee_estimation.py"] | test: feature_dbcrash listunspent times out | On current master
```
2019-07-29T16:43:20.074000Z TestFramework (INFO): Iteration 31, generating 2500 transactions [15, 3, 0]
2019-07-29T16:45:53.858000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
File "/root/workspace/bitcoin-core/test/functional/test_framework/authproxy.py", line 163, in _get_response
http_response = self.__conn.getresponse()
File "/usr/lib/python3.6/http/client.py", line 1331, in getresponse
response.begin()
File "/usr/lib/python3.6/http/client.py", line 297, in begin
version, status, reason = self._read_status()
File "/usr/lib/python3.6/http/client.py", line 258, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/usr/lib/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
socket.timeout: timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/root/workspace/bitcoin-core/test/functional/test_framework/test_framework.py", line 193, in main
self.run_test()
File "./test/functional/feature_dbcrash.py", line 250, in run_test
utxo_list = self.nodes[3].listunspent()
File "/root/workspace/bitcoin-core/test/functional/test_framework/coverage.py", line 47, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/root/workspace/bitcoin-core/test/functional/test_framework/authproxy.py", line 139, in __call__
response, status = self._request('POST', self.__url.path, postdata.encode('utf-8'))
File "/root/workspace/bitcoin-core/test/functional/test_framework/authproxy.py", line 107, in _request
return self._get_response()
File "/root/workspace/bitcoin-core/test/functional/test_framework/authproxy.py", line 170, in _get_response
self.__conn.timeout)})
test_framework.authproxy.JSONRPCException: 'listunspent' RPC took longer than 90.000000 seconds. Consider using larger timeout for calls that take longer to return. (-344)
2019-07-29T16:45:54.033000Z TestFramework (INFO): Stopping nodes
2019-07-29T16:45:54.060000Z TestFramework.node3 (ERROR): Unable to stop node.
Traceback (most recent call last):
File "/root/workspace/bitcoin-core/test/functional/test_framework/test_node.py", line 264, in stop_node
self.stop(wait=wait)
File "/root/workspace/bitcoin-core/test/functional/test_framework/coverage.py", line 47, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/root/workspace/bitcoin-core/test/functional/test_framework/authproxy.py", line 139, in __call__
response, status = self._request('POST', self.__url.path, postdata.encode('utf-8'))
File "/root/workspace/bitcoin-core/test/functional/test_framework/authproxy.py", line 106, in _request
self.__conn.request(method, path, postdata, headers)
File "/usr/lib/python3.6/http/client.py", line 1239, in request
self._send_request(method, url, body, headers, encode_chunked)
File "/usr/lib/python3.6/http/client.py", line 1250, in _send_request
self.putrequest(method, url, **skips)
File "/usr/lib/python3.6/http/client.py", line 1108, in putrequest
raise CannotSendRequest(self.__state)
http.client.CannotSendRequest: Request-sent
2019-07-29T16:46:55.268000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
def is_node_stopped(self):
"""Checks whether the node has stopped.
Returns True if the node has stopped. False otherwise.
This method is responsible for freeing resources (self.process)."""
if not self.running:
return True
return_code = self.process.poll()
if return_code is None:
return False
# process has stopped. Assert that it didn't return an error code.
assert return_code == 0, self._node_msg(
"Node returned non-zero exit code (%d) when stopping" % return_code)
self.running = False
self.process = None
self.rpc_connected = False
self.rpc = None
self.log.debug("Node stopped")
return True
'''
Traceback (most recent call last):
File "./test/functional/feature_dbcrash.py", line 273, in <module>
ChainstateWriteCrashTest().main()
File "/root/workspace/bitcoin-core/test/functional/test_framework/test_framework.py", line 218, in main
self.stop_nodes()
File "/root/workspace/bitcoin-core/test/functional/test_framework/test_framework.py", line 401, in stop_nodes
node.wait_until_stopped()
File "/root/workspace/bitcoin-core/test/functional/test_framework/test_node.py", line 305, in wait_until_stopped
wait_until(self.is_node_stopped, timeout=timeout)
File "/root/workspace/bitcoin-core/test/functional/test_framework/util.py", line 225, in wait_until
raise AssertionError("Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
def is_node_stopped(self):
"""Checks whether the node has stopped.
Returns True if the node has stopped. False otherwise.
This method is responsible for freeing resources (self.process)."""
if not self.running:
return True
return_code = self.process.poll()
if return_code is None:
return False
# process has stopped. Assert that it didn't return an error code.
assert return_code == 0, self._node_msg(
"Node returned non-zero exit code (%d) when stopping" % return_code)
self.running = False
self.process = None
self.rpc_connected = False
self.rpc = None
self.log.debug("Node stopped")
return True
''' not true after 60 seconds
[node 3] Cleaning up leftover process
| https://github.com/bitcoin/bitcoin/issues/16488 | https://github.com/bitcoin/bitcoin/pull/16493 | fa1bb53b0d76b1bfdc0f0669e260df4768d3be29 | fa36aa4922582fadf1aa8cbf89c33feeae80ac44 | 2019-07-29T18:02:14Z | c++ | 2019-08-01T14:36:52Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,447 | ["depends/packages/libxcb.mk"] | build: Investigate building default lib XCB extensions | As pointed out [here](https://github.com/bitcoin/bitcoin/pull/16370/files#r306442184):
> It seems that we build all of the default XCB Extensions, but the -qt-xcb option we supply to QT might cause it to build them as well. (source: https://doc.qt.io/qt-5.9/linux-requirements.html)
Investigate if there is build duplicate, if we should stop building them etc. | https://github.com/bitcoin/bitcoin/issues/16447 | https://github.com/bitcoin/bitcoin/pull/16533 | fbe4b7665b971aec3cf7448309d59d2661e513bd | 3303124960d3d857d9ce29a88a589e00b1d0f8fa | 2019-07-24T06:06:52Z | c++ | 2019-08-06T08:53:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,391 | ["build-aux/m4/bitcoin_qt.m4", "depends/config.site.in"] | build: configure doesn't pickup Qt if depends is built with DEBUG=1 | Using `master` (536590f358dc3d3e5821eba7f1009452ea93b205) and building depends using `DEBUG=1 make -j8`.
Configuring with `./autogen.sh && ./configure --prefix=/Users/michael/github/bitcoin/depends/x86_64-apple-darwin18.6.0` I'm seeing:
```bash
Options used to compile and link:
with wallet = yes
with gui / qt = no
with zmq = yes
with test = yes
with fuzz = no
with bench = yes
with upnp = yes
use asm = yes
sanitizers =
debug enabled = no
gprof enabled = no
werror = no
target os = darwin
build os = darwin
```
In `config.log`:
```bash
configure:27984: checking for static Qt plugins: -lqcocoa
ld: library not found for -lqcocoa
configure:27813: checking for static Qt plugins: -lqminimal
ld: library not found for -lqminimal
configure:27839: WARNING: Could not resolve: -lqminimal; bitcoin-qt frontend will not be built
```
Building depends without `DEBUG=1` works as expected. | https://github.com/bitcoin/bitcoin/issues/16391 | https://github.com/bitcoin/bitcoin/pull/18298 | 4f223e93e9c097c96a1655f9125aec463892da9c | fca3e98f64f0c89674414a18943591a04d61ccbf | 2019-07-15T03:38:18Z | c++ | 2021-03-03T07:48:11Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,382 | ["src/rpc/rawtransaction.cpp", "test/functional/feature_segwit.py", "test/functional/mempool_accept.py", "test/functional/rpc_rawtransaction.py", "test/functional/wallet_basic.py"] | sendrawtransaction maxfeerate is interpreted as absolute fee by default | When the newly introduced `"maxfeerate"` option is not passed, the default fee rate is interpreted as an absolute amount. However, when it is passed, it is interpreted as a fee rate. Thus, the rpc will return different results when the value is explicitly set to the default.
See
https://github.com/bitcoin/bitcoin/blob/536590f358dc3d3e5821eba7f1009452ea93b205/src/rpc/rawtransaction.cpp#L797-L807
I think we should change it back to an absolute value in BTC (not a feerate)
This was changed to a feerate by @kallewoof, so ping him to see if there was a specific reason to switch. | https://github.com/bitcoin/bitcoin/issues/16382 | https://github.com/bitcoin/bitcoin/pull/16521 | 261843e4bef96ab296a9775819a99bfa60cad743 | 2dfd6834ef8737e16e4b96df0c459f30a0721d6c | 2019-07-13T15:12:56Z | c++ | 2019-08-18T13:58:05Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,376 | ["src/torcontrol.cpp"] | Early shutdown results in freeze (torControlThread not stopping) | Using Ubuntu 18.04.2 LTS, with up-to-date, self-compiled master.
When I run
`./bitcoind -regtest -whitebind=bla`
I expect a clean shutdown with `Error: Cannot resolve -whitebind address: 'bla'`.
However sometimes my node doesn't stop and freezes (shutdown never finishes).
This happens ~30% of the time for me, both on testnet and regtest.
I believe that this is because `torControlThread.join();` never returns if it the thread is stopped right after its creation - it is started right before the whitebind part in `AppInitMain()`. If I insert a sleep before whitebind parameters are processed in Step 12 of `AppInitMain()` (or if I just disable the TorControl thread) the error does not occur.
Could someone try to reproduce? I encountered this testing #16248, but it is not restricted to this branch.
| https://github.com/bitcoin/bitcoin/issues/16376 | https://github.com/bitcoin/bitcoin/pull/16405 | 459baa1756b7f2d10d261daa0d0f5f4b91cef21f | a981e749e6553487cd48eda28e590f769e81c85c | 2019-07-12T00:54:31Z | c++ | 2019-07-17T14:32:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,368 | ["ci/test/05_before_script.sh", "depends/Makefile", "depends/README.md", "depends/funcs.mk"] | depends: File-based logging for individual packages | We should have file-based logging for each depends package so that:
1. We can diff logs to spot regressions when changing our build script / updating packages.
2. Travis has a line limit for output, so when running on Travis, we could withhold logs until we notice a non-zero exit code, then print `stdout`/`stderr`. | https://github.com/bitcoin/bitcoin/issues/16368 | https://github.com/bitcoin/bitcoin/pull/19952 | cf0a8b9c4870cc88254a757286140d9632e7b70c | e14f0fa6a346afecbb1d5470aef5226a8cc33e57 | 2019-07-10T20:46:39Z | c++ | 2022-04-14T17:38:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,354 | ["depends/packages/xcb_proto.mk"] | build: Review of depends tree configure flags | While doing depends builds, I noticed that there are many configure flags that weren't recognized by our packages. This leads to things like: https://github.com/bitcoin/bitcoin/pull/16183. This is most likely caused by either overzealous configure flag adding, or updating depends packages without looking at changes to accepted configure flags.
I propose that we:
1. Prune configure flags from depends that packages don't understand.
2. Add documentation on updating packages (namely that new configure flags should be checked).
3. (stretch-goal) Find out what `--without-` and `--disable-` configure flags we can supply to speed up depends builds.
CC @fanquake @theuni | https://github.com/bitcoin/bitcoin/issues/16354 | https://github.com/bitcoin/bitcoin/pull/17698 | bb03765e2d554da9dad5b9b314844a2ecb5c62e2 | e97f5c18238835bc3a3aee2e9e65b287f1c8b938 | 2019-07-08T14:56:11Z | c++ | 2019-12-08T22:55:11Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,346 | ["doc/init.md"] | systemd docs correctness | It seems this part of [doc/init.md](https://github.com/bitcoin/bitcoin/blob/master/doc/init.md):
> At a bare minimum, bitcoind requires that the rpcpassword setting be set when running as a daemon. If the configuration file does not exist or this setting is not set, **bitcoind will shut down promptly after startup**.
is no longer the true. Or did I miss something? | https://github.com/bitcoin/bitcoin/issues/16346 | https://github.com/bitcoin/bitcoin/pull/18157 | d1aa0ae1ad64618765601011bb23e9986ae79aba | 7812889849eb936afadc7267b51ad3768b2adf94 | 2019-07-05T20:10:35Z | c++ | 2020-04-24T18:22:14Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,296 | ["src/qt/walletcontroller.cpp", "src/qt/walletmodel.cpp", "src/qt/walletmodel.h"] | gui: crash with loadwallet & QT_FATAL_WARNINGS | Pretty sure this should be low priority, just keeping a record because there's been some discussion around using `QT_FATAL_WARNINGS=1` during debugging.
```log
2019-06-27T07:23:13Z init message: Done loading
2019-06-27T07:23:13Z GUI: Platform customization: "macosx"
2019-06-27T07:23:17Z Using BerkeleyDB version Berkeley DB 4.8.30: (April 9, 2010)
2019-06-27T07:23:17Z Using wallet /Users/michael/Library/Application Support/Bitcoin/testing
2019-06-27T07:23:17Z BerkeleyEnvironment::Open: LogDir=/Users/michael/Library/Application Support/Bitcoin/testing/database ErrorFile=/Users/michael/Library/Application Support/Bitcoin/testing/db.log
2019-06-27T07:23:17Z init message: Loading wallet...
2019-06-27T07:23:17Z BerkeleyEnvironment::Open: LogDir=/Users/michael/Library/Application Support/Bitcoin/testing/database ErrorFile=/Users/michael/Library/Application Support/Bitcoin/testing/db.log
2019-06-27T07:23:17Z [testing] nFileVersion = 189900
2019-06-27T07:23:17Z [testing] Keys: 0 plaintext, 2001 encrypted, 2001 w/ metadata, 2001 total. Unknown wallet records: 0
2019-06-27T07:23:17Z [testing] Wallet completed loading in 113ms
2019-06-27T07:23:17Z GUI: QObject::startTimer: Timers can only be used with threads started with QThread
```
```bash
src/bitcoin-cli loadwallet testing
```
```bash
lldb src/qt/bitcoin-qt
(lldb) target create "src/qt/bitcoin-qt"
Current executable set to 'src/qt/bitcoin-qt' (x86_64).
(lldb) env QT_FATAL_WARNINGS=1
(lldb) run
Process 19523 launched: '/Users/michael/github/bitcoin/src/qt/bitcoin-qt' (x86_64)
2019-06-27 15:23:04.327755+0800 bitcoin-qt[19523:550417] MessageTracer: Falling back to default whitelist
Process 19523 stopped
* thread #21, name = 'bitcoin-httpworker.0', stop reason = signal SIGABRT
frame #0: 0x00007fff593ec2c6 libsystem_kernel.dylib`__pthread_kill + 10
libsystem_kernel.dylib`__pthread_kill:
-> 0x7fff593ec2c6 <+10>: jae 0x7fff593ec2d0 ; <+20>
0x7fff593ec2c8 <+12>: movq %rax, %rdi
0x7fff593ec2cb <+15>: jmp 0x7fff593e6457 ; cerror_nocancel
0x7fff593ec2d0 <+20>: retq
Target 0: (bitcoin-qt) stopped.
``` | https://github.com/bitcoin/bitcoin/issues/16296 | https://github.com/bitcoin/bitcoin/pull/17120 | 561a7d30478b82f5d46dcf0f16e864a9608004f4 | a8f5026d6d992fd8d72908c848c5028f0f9a8cd1 | 2019-06-27T07:30:25Z | c++ | 2019-10-14T09:53:33Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,288 | ["src/qt/test/rpcnestedtests.cpp"] | tests: make check currently broken on macOS | ```bash
git checkout master && git clean -fxd && ./autogen.sh && ./configure && make check -j8
.....
Running tests: torcontrol_tests from test/torcontrol_tests.cpp
Running tests: transaction_tests from test/transaction_tests.cpp
Running tests: txindex_tests from test/txindex_tests.cpp
../build-aux/test-driver: line 107: 85583 Abort trap: 6 "$@" > $log_file 2>&1
FAIL: qt/test/test_bitcoin-qt
cat src/test-suite.log
==============================================
Bitcoin Core 0.18.99: src/test-suite.log
==============================================
# TOTAL: 1
# PASS: 0
# SKIP: 0
# XFAIL: 0
# FAIL: 1
# XPASS: 0
# ERROR: 0
.. contents:: :depth: 2
FAIL: qt/test/test_bitcoin-qt
=============================
********* Start testing of AppTests *********
Config: Using QtTest library 5.12.3, Qt 5.12.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 10.0.1 (clang-1001.0.46.4) (Apple))
PASS : AppTests::initTestCase()
WARNING: AppTests::appTests() Skipping AppTests on mac build with 'minimal' platform set due to Qt bugs. To run AppTests, invoke with 'test_bitcoin-qt -platform cocoa' on mac, or else use a linux or windows build.
Loc: [qt/test/apptests.cpp(61)]
PASS : AppTests::appTests()
PASS : AppTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 1ms
********* Finished testing of AppTests *********
********* Start testing of URITests *********
Config: Using QtTest library 5.12.3, Qt 5.12.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 10.0.1 (clang-1001.0.46.4) (Apple))
PASS : URITests::initTestCase()
PASS : URITests::uriTests()
PASS : URITests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 0ms
********* Finished testing of URITests *********
********* Start testing of RPCNestedTests *********
Config: Using QtTest library 5.12.3, Qt 5.12.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 10.0.1 (clang-1001.0.46.4) (Apple))
PASS : RPCNestedTests::initTestCase()
Assertion failed: (secp256k1_context_sign == nullptr), function ECC_Start, file key.cpp, line 349.
FAIL qt/test/test_bitcoin-qt (exit status: 134)
```
Looks like it's been failing since #16252, cc @MarcoFalke.
```bash
git checkout bc948d4cfd6da2effa8c2ae619e11e83207c6fbc && git clean -fxd && ./autogen.sh && ./configure && make check -j8
....
Running tests: db_tests from wallet/test/db_tests.cpp
PASS: qt/test/test_bitcoin-qt
Running tests: psbt_wallet_tests from wallet/test/psbt_wallet_tests.cpp
============================================================================
Testsuite summary for Bitcoin Core 0.18.99
============================================================================
# TOTAL: 1
# PASS: 1
```
| https://github.com/bitcoin/bitcoin/issues/16288 | https://github.com/bitcoin/bitcoin/pull/16289 | ca80fec973f0895b3d150b5af472d778102c315d | f466c4ce846000b2f984b4759f89f3f793fa0100 | 2019-06-26T03:47:20Z | c++ | 2019-06-26T09:28:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,249 | ["src/rpc/rawtransaction_util.cpp", "test/functional/rpc_createmultisig.py"] | signrawtransactionwithkey gives confusing error when missing redeemScript | Forgetting to include the redeemscript when invoking signrawtransactionwithkey used to give a useful error:
$ bitcoin-cli -regtest signrawtransactionwithkey "02000000018a24833c36be23272080d6be8a53e36586b81e0ac447e1298ee58e18cc96bdee0100000000ffffffff0118246bee0000000017a914e139e3904e9e69ecbce87b0fcfb73b1b0e3b9e818700000000" '["cUJ7bUweEgENv4ixezsSyZa2uBJxR37iFLtCt18gSvkjpkj7CmMr"]' '[{"txid":"eebd96cc188ee58e29e147c40a1eb88665e3538abed680202723be363c83248a","vout":1,"scriptPubKey":"0020f89f2138a58a2042310f297259ca8050bcaecd3a0f3c936edffb7e38e31d775a","amount":"40.00000000"}]'
With 0.17:
error code: -3
error message:
Missing redeemScript
With master/0.18:
{
"hex": "02000000018a24833c36be23272080d6be8a53e36586b81e0ac447e1298ee58e18cc96bdee0100000000ffffffff0118246bee0000000017a914e139e3904e9e69ecbce87b0fcfb73b1b0e3b9e818700000000",
"complete": false,
"errors": [
{
"txid": "eebd96cc188ee58e29e147c40a1eb88665e3538abed680202723be363c83248a",
"vout": 1,
"witness": [
],
"scriptSig": "",
"sequence": 4294967295,
"error": "Witness program was passed an empty witness"
}
]
}
<!--- What behavior did you expect? -->
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- For the GUI-related issue on Linux provide names and versions of a distro, a desktop environment and a graphical shell (if relevant). -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/16249 | https://github.com/bitcoin/bitcoin/pull/16250 | 413e438ea9767710d4810c4400fd1242ca52cd1c | 01174596e69568c434198a86f54cb9ea6740e6c2 | 2019-06-20T11:30:57Z | c++ | 2019-06-25T02:37:08Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,245 | ["build_msvc/common.init.vcxproj"] | [msvc] number of sections exceeded object file format limit: compile with /bigobj | Only happening in Debug mode
```
"C:\Sources\bitcoin\build_msvc\bitcoin.sln" (default target) (1) ->
"C:\Sources\bitcoin\build_msvc\libbitcoinconsensus\libbitcoinconsensus.vcxproj" (default target) (2) ->
(Lib target) ->
sha256_sse4.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation
that consumes this library [C:\Sources\bitcoin\build_msvc\libbitcoinconsensus\libbitcoinconsensus.vcxproj]
"C:\Sources\bitcoin\build_msvc\bitcoin.sln" (default target) (1) ->
"C:\Sources\bitcoin\build_msvc\testconsensus\testconsensus.vcxproj" (default target) (3) ->
"C:\Sources\bitcoin\build_msvc\libbitcoin_util\libbitcoin_util.vcxproj" (default target) (4) ->
sync.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that c
onsumes this library [C:\Sources\bitcoin\build_msvc\libbitcoin_util\libbitcoin_util.vcxproj]
compat_strnlen.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operat
ion that consumes this library [C:\Sources\bitcoin\build_msvc\libbitcoin_util\libbitcoin_util.vcxproj]
"C:\Sources\bitcoin\build_msvc\bitcoin.sln" (default target) (1) ->
"C:\Sources\bitcoin\build_msvc\bitcoind\bitcoind.vcxproj" (default target) (6) ->
"C:\Sources\bitcoin\build_msvc\libbitcoin_wallet\libbitcoin_wallet.vcxproj" (default target) (10) ->
(ClCompile target) ->
C:\Sources\bitcoin\src\wallet\wallet.cpp : fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj [C:\Sources\bitc
oin\build_msvc\libbitcoin_wallet\libbitcoin_wallet.vcxproj]
3 Warning(s)
1 Error(s)
```
Probably easy to fix, will check later. | https://github.com/bitcoin/bitcoin/issues/16245 | https://github.com/bitcoin/bitcoin/pull/16246 | 413e438ea9767710d4810c4400fd1242ca52cd1c | eb832cd3b46a0f9abff238dfa780e4e9df05fdb7 | 2019-06-20T03:22:49Z | c++ | 2019-06-20T03:45:57Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,230 | ["src/qt/bitcoingui.cpp", "src/qt/bitcoingui.h"] | gui: Open Wallet does not list available wallets | Using master (98958c81f5065a5de13699d46995d278ecb6709e) with Qt `5.12.3` (also tested with depends) with multiple wallets available. None are shown in the `Open Wallet ->` menu in the gui. The wallets can be loaded from the console, bitcoin-cli etc. | https://github.com/bitcoin/bitcoin/issues/16230 | https://github.com/bitcoin/bitcoin/pull/16231 | 22b6c4ed7562a23e4363e8f0fd889b92c7653d5f | 5224be5a3354e1a22ea4d7f0e40aadfccdf67064 | 2019-06-18T10:10:00Z | c++ | 2019-06-18T13:13:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,200 | ["contrib/devtools/github-merge.py"] | github-merge: fetch ACKS and show them before signing off | Currently it happens that I add a ACK comment while doing local testing before merge (so in the shell that it invokes) and this gets missed in the merge commit message.
This is because it fetches the comments from github immediately after invoking the command. I think it'd be better if it did so later.
Ideally, I'd like `github-merge.py` to fetch the ACKs and display them before confirming sign-off on the merge. | https://github.com/bitcoin/bitcoin/issues/16200 | https://github.com/bitcoin/bitcoin/pull/16223 | f6f924811d5b4ae2a6c77105403747cd31d3e49d | 0e01e4522e0f9e2e994f80fc61f40d61a4a70d79 | 2019-06-13T08:16:03Z | c++ | 2019-06-17T12:54:35Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,181 | ["doc/release-notes-16185.md", "src/rpc/client.cpp", "src/wallet/rpcwallet.cpp", "test/functional/wallet_basic.py"] | wallet: decode raw transaction in gettransaction | Does it make sense to decode the raw transaction in the wallet-rpc `gettransaction` call (or add an optional parameter to do so)?
See discussion in https://github.com/bitcoin/bitcoin/pull/15159#issuecomment-499051813 | https://github.com/bitcoin/bitcoin/issues/16181 | https://github.com/bitcoin/bitcoin/pull/16185 | b8b3f0435a2837d3897e9e232ef6ca839ce74eb8 | 9965940e35c445ccded55510348af228ff22f0e9 | 2019-06-10T07:13:41Z | c++ | 2019-08-30T09:40:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,142 | ["src/rpc/rawtransaction.cpp"] | `getrawtransaction` fails (0.18.0) | <!-- Describe the issue -->
`getrawtransaction` fails
<!--- What behavior did you expect? -->
Return decoded raw tx
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
* `bitcoin-qt -prune=8192 -server -rpcuser=rpc -rpcpassword=rpc -onlynet=ipv4 -rpcbind=127.0.0.1:18332 -testnet`
* BTC 0.18.0
* `getrawtransaction b423b2b22d6d74376de2887c07f7c84ae890a93d541fcc6dbf3686f2923b2753 1`
* BTC 0.17.1
* `getrawtransaction b423b2b22d6d74376de2887c07f7c84ae890a93d541fcc6dbf3686f2923b2753 1`
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
Request `getrawtransaction`.
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
Official from site.
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
`Linux pentagon 4.9.0-9-amd64 #1 SMP Debian 4.9.168-1+deb9u2 (2019-05-13) x86_64 GNU/Linux`, u5200, 2x8Gb, SSD
<!-- For the GUI-related issue on Linux provide names and versions of a distro, a desktop environment and a graphical shell (if relevant). -->
QT
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/16142 | https://github.com/bitcoin/bitcoin/pull/16217 | 8a503a6c6dd419921373f45d7aa6f1787c9b8884 | c59e3a32614e627ba2834b032d4799eb69672155 | 2019-06-03T23:35:07Z | c++ | 2019-06-14T21:02:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,119 | ["src/qt/forms/debugwindow.ui", "src/qt/rpcconsole.cpp"] | gui: crash when running console commands during startup | Using master. During startup, if you open `Window` -> `Console` and try and execute any command (can be garbage) `bitcoin-qt` will crash:
```bash
On branch pull/16118/local-merge
Process 89287 launched: '/Users/michael/github/bitcoin/src/qt/bitcoin-qt' (x86_64)
2019-05-29 09:57:56.276746-0400 bitcoin-qt[89287:939924] MessageTracer: Falling back to default whitelist
Process 89287 stopped
* thread #1, name = 'bitcoin-main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x8)
frame #0: 0x00000001015158ba QtWidgets`QCompleter::popup() const + 10
QtWidgets`QCompleter::popup:
-> 0x1015158ba <+10>: movq 0x8(%rdi), %rbx
0x1015158be <+14>: movq 0x88(%rbx), %rax
0x1015158c5 <+21>: testq %rax, %rax
0x1015158c8 <+24>: jne 0x101515942 ; <+146>
Target 0: (bitcoin-qt) stopped.
```
Not sure if just disabling the menu, like in #16118 would be ok, as a user might actually want to be able to run a command. | https://github.com/bitcoin/bitcoin/issues/16119 | https://github.com/bitcoin/bitcoin/pull/16122 | 76e2cded477bc483ec610212bdadf21fe35292d4 | 2d8ad2f99710a8981e33fe2d6ce834b0076c4e80 | 2019-05-29T14:22:21Z | c++ | 2019-05-30T22:26:18Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,109 | ["contrib/gitian-build.py"] | gitian-build.py --setup should install curl | # Describe the issue
`gitian-build.py --setup` doesn't install `curl`, which is required by `make download` (which is run by `gitian-build.py --build`). Since some OS's like Debian Buster don't have `curl` installed by default, this causes a build error.
# What behavior did you expect?
Bitcoin Core should build without errors in Gitian.
# What was the actual behavior (provide screenshots if the issue is GUI-related)?
The following error shows up while trying to fetch Boost:
`/bin/sh: 1: curl: not found`
# How reliably can you reproduce the issue, what are the steps to do so?
1. Install a fresh Debian Buster VM with KDE.
2. Clone Bitcoin Core.
3. `../bitcoin/contrib/gitian-build.py --commit --setup JeremyRand master`
4. `../bitcoin/contrib/gitian-build.py --commit --build JeremyRand master`
# What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)?
72634244580dc2e3c630ee27e47587080d064b68 , self-compiled.
# What type of machine are you observing the error on (OS/CPU and disk type)?
Debian Buster VM inside Qubes OS; Haswell i7, HDD.
# Any extra information that might be useful in the debugging process.
It looks like adding `'curl'` to the `programs` list in `gitian-build.py`'s `setup` function would be sufficient to solve the problem. `'wget'` is already there. | https://github.com/bitcoin/bitcoin/issues/16109 | https://github.com/bitcoin/bitcoin/pull/16114 | 76e2cded477bc483ec610212bdadf21fe35292d4 | 97dce7226194d5d8a06787afef7df08cebb66bd6 | 2019-05-28T01:16:40Z | c++ | 2019-05-28T16:51:53Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,101 | ["src/qt/forms/coincontroldialog.ui"] | Coin Selector UI is Showing The OK Button on the Left Side. | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
BitcoinQT's Input selector is showing the `OK` button on the left side instead of the right side.
<!--- What behavior did you expect? -->
All the buttons in the app show on the right side, so they should be there, especially the `OK` button.
Ok button on the right.
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
Ok button on the left.
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
I'm using `0.18.0`. On a x86_64 GNU/Linux Ubuntu 19.04 Gnome 3.32.1.
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- For the GUI-related issue on Linux provide names and versions of a distro, a desktop environment and a graphical shell (if relevant). -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/16101 | https://github.com/bitcoin/bitcoin/pull/16113 | 76e2cded477bc483ec610212bdadf21fe35292d4 | d595b4aae9d6eca7094ed5612f4773d98e422057 | 2019-05-27T13:57:01Z | c++ | 2019-05-28T15:16:39Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,098 | ["src/init.cpp", "src/logging.cpp", "src/logging.h", "test/functional/feature_config_args.py"] | LogPrintf() fails due to premature call before InitLogging() | These pieces of code:
https://github.com/bitcoin/bitcoin/blob/8ab4f282c06d67074b872dbda0be37636fdd5186/src/util/system.cpp#L302
and
https://github.com/bitcoin/bitcoin/blob/8ab4f282c06d67074b872dbda0be37636fdd5186/src/util/system.cpp#L864
do not work as expected because they are called before the `InitLogging()` call.
| https://github.com/bitcoin/bitcoin/issues/16098 | https://github.com/bitcoin/bitcoin/pull/16112 | 0b282f9b00da08734e2381477aad32d64b933745 | faa2a47cd7bcdbd187035c76f8dbd0442f6818dc | 2019-05-26T21:25:46Z | c++ | 2019-05-28T18:27:08Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,094 | [".travis.yml", "configure.ac", "doc/fuzzing.md"] | --enable-fuzz fails in combination with --enable-wallet, --with-miniupnpc or --enable-zmq | `--enable-fuzz` fails in combination with `--enable-wallet`, `--with-miniupnpc` or `--enable-zmq`.
```
$ git clone https://github.com/bitcoin/bitcoin
$ cd bitcoin
$ ./autogen.sh
$ ./configure --disable-wallet --without-miniupnpc --disable-zmq --enable-fuzz
$ make
$ echo $?
0
$ make clean
$ ./configure --with-incompatible-bdb --without-miniupnpc --disable-zmq --enable-fuzz
$ make
…
CXXLD test/fuzz/address_deserialize
libbitcoin_server.a(libbitcoin_server_a-init.o): In function `WalletInit::Construct(InitInterfaces&) const':
/…/src/wallet/init.cpp:139: undefined reference to `interfaces::MakeWalletClient(interfaces::Chain&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Makefile:4862: recipe for target 'test/fuzz/address_deserialize' failed
$ make clean
$ ./configure --disable-wallet --with-miniupnpc --disable-zmq --enable-fuzz
$ make
…
CXXLD test/fuzz/address_deserialize
libbitcoin_server.a(libbitcoin_server_a-net.o): In function `ThreadMapPort()':
/…/src/net.cpp:1412: undefined reference to `upnpDiscover'
/…/src/net.cpp:1423: undefined reference to `UPNP_GetValidIGD'
/…/src/net.cpp:1428: undefined reference to `UPNP_GetExternalIPAddress'
/…/src/net.cpp:1473: undefined reference to `freeUPNPDevlist'
/…/src/net.cpp:1475: undefined reference to `FreeUPNPUrls'
/…/src/net.cpp:1455: undefined reference to `UPNP_AddPortMapping'
/…/src/net.cpp:1461: undefined reference to `strupnperror'
/…/src/net.cpp:1467: undefined reference to `UPNP_DeletePortMapping'
/…/src/net.cpp:1469: undefined reference to `freeUPNPDevlist'
/…/src/net.cpp:1470: undefined reference to `FreeUPNPUrls'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
$ make clean
$ ./configure --disable-wallet --without-miniupnpc --enable-zmq --enable-fuzz
$ make
…
CXXLD test/fuzz/address_deserialize
libbitcoin_server.a(libbitcoin_server_a-init.o): In function `Shutdown(InitInterfaces&)':
/…/src/init.cpp:290: undefined reference to `g_zmq_notification_interface'
libbitcoin_server.a(libbitcoin_server_a-init.o): In function `SetupServerArgs()':
/…/src/init.cpp:469: undefined reference to `CZMQAbstractNotifier::DEFAULT_ZMQ_SNDHWM'
/…/src/init.cpp:470: undefined reference to `CZMQAbstractNotifier::DEFAULT_ZMQ_SNDHWM'
/…/src/init.cpp:471: undefined reference to `CZMQAbstractNotifier::DEFAULT_ZMQ_SNDHWM'
/…/src/init.cpp:472: undefined reference to `CZMQAbstractNotifier::DEFAULT_ZMQ_SNDHWM'
libbitcoin_server.a(libbitcoin_server_a-init.o): In function `AppInitMain(InitInterfaces&)':
/…/src/init.cpp:1317: undefined reference to `RegisterZMQRPCCommands(CRPCTable&)'
/…/src/init.cpp:1440: undefined reference to `CZMQNotificationInterface::Create()'
/…/src/init.cpp:1440: undefined reference to `g_zmq_notification_interface'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
| https://github.com/bitcoin/bitcoin/issues/16094 | https://github.com/bitcoin/bitcoin/pull/16338 | 48bcb2ac249e0e666ce638bb29124558b3283c16 | 84edfc72e5eba3dde824ebd0626e97929a0b1bca | 2019-05-26T14:38:10Z | c++ | 2019-07-09T00:28:58Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,087 | ["src/qt/bitcoingui.cpp"] | gui: app crashed while rescanning Mac | While rescanning wenn i click File>open wallet in time wenn mouse cursor touch "open wallet" item app just immediately crashed.
V0.18.0 | https://github.com/bitcoin/bitcoin/issues/16087 | https://github.com/bitcoin/bitcoin/pull/16118 | 76e2cded477bc483ec610212bdadf21fe35292d4 | 75485ef0962a53946f17b761c4445627b07e6eff | 2019-05-24T22:20:03Z | c++ | 2019-05-29T13:20:59Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,064 | ["contrib/install_db4.sh"] | install_db4.sh configure cannot guess build type on ppc64le | # Describe the issue
The configure script called by `install_db4.sh` fails to detect the build arch on ppc64le systems, producing an error.
# What behavior did you expect?
db4 should build properly without errors.
# What was the actual behavior (provide screenshots if the issue is GUI-related)?
~~~
checking build system type... /home/user/Downloads/bitcoin/db4/db-4.8.30.NC/dist/config.guess: unable to guess system type
This script, last modified 2009-02-03, has failed to recognize
the operating system you are using. It is advised that you
download the most up to date version of the config scripts from
http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD
and
http://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub;hb=HEAD
If the version you run (/home/user/Downloads/bitcoin/db4/db-4.8.30.NC/dist/config.guess) is already up to date, please
send the following data and any information you think might be
pertinent to <[email protected]> in order to provide the needed
information to handle your system.
config.guess timestamp = 2009-02-03
uname -m = ppc64le
uname -r = 4.19.0-5-powerpc64le
uname -s = Linux
uname -v = #1 SMP Debian 4.19.37-3 (2019-05-15)
/usr/bin/uname -p =
/bin/uname -X =
hostinfo =
/bin/universe =
/usr/bin/arch -k =
/bin/arch =
/usr/bin/oslevel =
/usr/convex/getsysinfo =
UNAME_MACHINE = ppc64le
UNAME_RELEASE = 4.19.0-5-powerpc64le
UNAME_SYSTEM = Linux
UNAME_VERSION = #1 SMP Debian 4.19.37-3 (2019-05-15)
configure: error: cannot guess build type; you must specify one
~~~
# How reliably can you reproduce the issue, what are the steps to do so?
1. ``./contrib/install_db4.sh `pwd` ``
# What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)?
2d1583ee6aff4b68dc46bcb87eb7a85f90b465c3 , self-compiled.
# What type of machine are you observing the error on (OS/CPU and disk type)?
In a VM running Whonix 15 (based on Debian Buster); host is Debian Buster. ppc64le / POWER9. HDD.
# Any extra information that might be useful in the debugging process.
The following does work: ``./contrib/install_db4.sh `pwd` --build=powerpc64le``
While it would be nice to fix the configure script to properly detect powerpc64le, I'd settle for a note in `build-unix.md` that specifies the above workaround so that newbies don't have to figure out the configure flag on their own. | https://github.com/bitcoin/bitcoin/issues/16064 | https://github.com/bitcoin/bitcoin/pull/16086 | 65c4bbe629bbb6eb4347d35a12b0b1c90eeabce9 | 00fade007c8c0aba82a2a8c40129ae0b6e530d33 | 2019-05-21T11:55:47Z | c++ | 2019-05-24T19:48:34Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,062 | ["depends/packages/rapidcheck.mk"] | depends: rapidcheck fails to compile with GCC 9.1 | When building depends with GCC `9.1` (Fedora 30), `rapidcheck` fails to build with:
```
[ 2%] Building CXX object CMakeFiles/rapidcheck.dir/src/gen/Numeric.cpp.o
In file included from /bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/include/rapidcheck/detail/BitStream.h:52,
from /bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/include/rapidcheck/gen/Numeric.hpp:3,
from /bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/include/rapidcheck/gen/Numeric.h:18,
from /bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/src/gen/Numeric.cpp:1:
/bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/include/rapidcheck/detail/BitStream.hpp: In instantiation of ‘T rc::detail::BitStream<Source>::next(int, std::false_type) [with T = long int; Source = rc::Random; std::false_type = std::integral_constant<bool, false>]’:
/bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/include/rapidcheck/detail/BitStream.hpp:30:48: required from ‘T rc::detail::BitStream<Source>::next(int) [with T = long int; Source = rc::Random]’
/bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/include/rapidcheck/detail/BitStream.hpp:86:75: required from ‘T rc::detail::BitStream<Source>::nextWithSize(int) [with T = long int; Source = rc::Random]’
/bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/include/rapidcheck/gen/Numeric.hpp:44:68: required from ‘rc::Shrinkable<T> rc::gen::detail::real(const rc::Random&, int) [with T = long double]’
/bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/include/rapidcheck/gen/Numeric.hpp:80:48: required from here
/bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/include/rapidcheck/detail/BitStream.hpp:63:36: error: comparison of integer expressions of different signedness: ‘SourceType’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare]
63 | if (static_cast<SourceType>(n) < numBits<SourceType>()) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
/bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/include/rapidcheck/detail/BitStream.hpp: In instantiation of ‘T rc::detail::BitStream<Source>::next(int, std::false_type) [with T = long unsigned int; Source = rc::Random; std::false_type = std::integral_constant<bool, false>]’:
/bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/include/rapidcheck/detail/BitStream.hpp:30:48: required from ‘T rc::detail::BitStream<Source>::next(int) [with T = long unsigned int; Source = rc::Random]’
/bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/include/rapidcheck/detail/BitStream.hpp:24:30: required from ‘T rc::detail::BitStream<Source>::next() [with T = long unsigned int; Source = rc::Random]’
/bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/include/rapidcheck/gen/Numeric.hpp:46:29: required from ‘rc::Shrinkable<T> rc::gen::detail::real(const rc::Random&, int) [with T = long double]’
/bitcoin/depends/work/build/x86_64-pc-linux-gnu/rapidcheck/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3-087dffe9a0a/include/rapidcheck/gen/Numeric.hpp:80:48: required from here
<... snip a bunch of similar output ...>
cc1plus: error: unrecognized command line option ‘-Wno-unused-command-line-argument’ [-Werror]
cc1plus: all warnings being treated as errors
```
`rapidcheck` is [compiled with `Wall`](https://github.com/emil-e/rapidcheck/blob/3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3/CMakeLists.txt#L23):
```shell
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Werror -Wno-missing-braces -Wno-unused-command-line-argument")
```
Upstream issue is https://github.com/emil-e/rapidcheck/issues/232. | https://github.com/bitcoin/bitcoin/issues/16062 | https://github.com/bitcoin/bitcoin/pull/16271 | 2cbcc55ba6aea26d64eae3981b83dac04f70240f | 63d0a079e04dad42c6f63793505a0af59d085a7f | 2019-05-21T09:28:10Z | c++ | 2019-06-23T14:40:50Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,055 | ["configure.ac"] | bitcoind on freebsd prints "__cxa_thread_call_dtors: dtr 0x801a85a40 from unloaded dso, skipping" | Caused by ae5f2b6a6cc7b2260e9dff99c1bf378922e0e988 from Thread names in logs and deadlock debug tools #15849
On master (with that commit):
```
$ gmake clean && gmake -j 17 && src/bench/bench_bitcoin -evals=1 -scaling=0 --filter=FastR.*
...
# Benchmark, evals, iterations, total, min, max, median
...
__cxa_thread_call_dtors: dtr 0x801a85a40 from unloaded dso, skipping
FastRandom_1bit, 1, 1, 6.146e-06, 6.146e-06, 6.146e-06, 6.146e-06
| https://github.com/bitcoin/bitcoin/issues/16055 | https://github.com/bitcoin/bitcoin/pull/16059 | 149b3477ecff4ff9c50cd38724c86cb6ae4d3276 | 480e3415d738a4e0e2ad9774c43f29937178ecae | 2019-05-20T14:11:28Z | c++ | 2019-05-23T19:15:46Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,052 | ["ci/test/00_setup_env_mac.sh", "contrib/gitian-build.py", "contrib/gitian-descriptors/gitian-osx.yml", "contrib/macdeploy/README.md", "depends/hosts/darwin.mk", "depends/packages/native_cctools.mk", "depends/packages/qt.mk", "depends/patches/qt/mac-qmake.conf", "doc/build-osx.md"] | depends: Issue cross compiling for macOS on Debian Buster | Using a `debian:buster-slim` Docker container, [available here](https://github.com/fanquake/core-review/blob/master/docker/debian.dockerfile), doing a depends build for `x86_64-apple-darwin14`, `cctools` bombs out with the following in `config.log`:
```bash
configure:3616: checking for x86_64-pc-linux-gnu-gcc
configure:3643: result: /bitcoin/depends/work/build/x86_64-apple-darwin14/native_cctools/807d6fd1be5d2224872e381870c0a75387fe05e6-3e0a7ea9e07/toolchain/bin/clang
configure:3912: checking for C compiler version
configure:3921: /bitcoin/depends/work/build/x86_64-apple-darwin14/native_cctools/807d6fd1be5d2224872e381870c0a75387fe05e6-3e0a7ea9e07/toolchain/bin/clang --version >&5
clang version 3.7.1 (tags/RELEASE_371/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix
configure:3932: $? = 0
configure:3921: /bitcoin/depends/work/build/x86_64-apple-darwin14/native_cctools/807d6fd1be5d2224872e381870c0a75387fe05e6-3e0a7ea9e07/toolchain/bin/clang -v >&5
clang version 3.7.1 (tags/RELEASE_371/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix
configure:3932: $? = 0
configure:3921: /bitcoin/depends/work/build/x86_64-apple-darwin14/native_cctools/807d6fd1be5d2224872e381870c0a75387fe05e6-3e0a7ea9e07/toolchain/bin/clang -V >&5
clang-3.7: error: argument to '-V' is missing (expected 1 value)
clang-3.7: error: no input files
configure:3932: $? = 1
configure:3921: /bitcoin/depends/work/build/x86_64-apple-darwin14/native_cctools/807d6fd1be5d2224872e381870c0a75387fe05e6-3e0a7ea9e07/toolchain/bin/clang -qversion >&5
clang-3.7: error: unknown argument: '-qversion'
clang-3.7: error: no input files
configure:3932: $? = 1
configure:3952: checking whether the C compiler works
configure:3974: /bitcoin/depends/work/build/x86_64-apple-darwin14/native_cctools/807d6fd1be5d2224872e381870c0a75387fe05e6-3e0a7ea9e07/toolchain/bin/clang -O3 -I/bitcoin/depends/x86_64-apple-darwin14/native/include -L/bitcoin/depends/x86_64-apple-darwin14/native/lib -Wl,-rpath=\$$ORIGIN/../lib conftest.c >&5
/usr/bin/ld: cannot find crtbegin.o: No such file or directory
/usr/bin/ld: cannot find -lgcc
/usr/bin/ld: cannot find -lgcc_s
clang-3.7: error: linker command failed with exit code 1 (use -v to see invocation)
configure:3978: $? = 1
configure:4016: result: no
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "cctools"
| #define PACKAGE_TARNAME "cctools"
| #define PACKAGE_VERSION "877.8"
| #define PACKAGE_STRING "cctools 877.8"
| #define PACKAGE_BUGREPORT "[email protected]"
| #define PACKAGE_URL ""
| /* end confdefs.h. */
|
| int
| main ()
| {
|
| ;
| return 0;
| }
configure:4021: error: in `/bitcoin/depends/work/build/x86_64-apple-darwin14/native_cctools/807d6fd1be5d2224872e381870c0a75387fe05e6-3e0a7ea9e07/cctools':
configure:4023: error: C compiler cannot create executables
See `config.log' for more details
```
Cross-compiling with a `debian:stretch-slim` container works file, so my assumption is a change in Busters newer GCC (`8.3.0`) has broken our older Clang (`3.7.1`).
A a similar issue [appeared in Clang previously](https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=754963), which produced similar output, and was resolved in LLVM [here](https://reviews.llvm.org/rL213388). | https://github.com/bitcoin/bitcoin/issues/16052 | https://github.com/bitcoin/bitcoin/pull/16392 | ca5055a5aa07aba81a87cf12f6f0526a63c423b5 | 7e2104433cd0905ccf94632511b3ca0ce5b0463b | 2019-05-20T06:43:07Z | c++ | 2020-02-03T11:49:46Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,028 | ["src/interfaces/chain.cpp", "src/interfaces/chain.h", "src/wallet/test/wallet_tests.cpp", "src/wallet/wallet.cpp"] | getTipLocator() reads chainActive without holding cs_main despite LockAnnotation lock(::cs_main) guarantee | `LockAnnotation lock(::cs_main)` is a guarantee to the compiler thread analysis that `::cs_main` is locked (when it couldn't be determined otherwise).
Despite being annotated with the locking guarantee ...
https://github.com/bitcoin/bitcoin/blob/65526fc8666fef35ef908dbc225f706bef642c7e/src/interfaces/chain.cpp#L134-L138
... `getTipLocator()` reads `chainActive` (via `::ChainActive()`) without holding `cs_main`.
This can be verified by adding the following `AssertLockHeld(cs_main)`:
```
$ git diff
diff --git a/src/interfaces/chain.cpp b/src/interfaces/chain.cpp
index 59623284d..9fc693a0f 100644
--- a/src/interfaces/chain.cpp
+++ b/src/interfaces/chain.cpp
@@ -134,6 +134,7 @@ class LockImpl : public Chain::Lock
CBlockLocator getTipLocator() override
{
LockAnnotation lock(::cs_main);
+ AssertLockHeld(::cs_main);
return ::ChainActive().GetLocator();
}
Optional<int> findLocatorFork(const CBlockLocator& locator) override
$ make check
../build-aux/test-driver: line 107: 12881 Aborted "$@" > $log_file 2>&1
FAIL: qt/test/test_bitcoin-qt
``` | https://github.com/bitcoin/bitcoin/issues/16028 | https://github.com/bitcoin/bitcoin/pull/16033 | 593a8e8a2ce177c41a7809479c0086ae0fee4b4e | 9402ef0739fdcd8e989c07c0595095e9608b243c | 2019-05-15T13:15:21Z | c++ | 2019-05-16T19:43:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,020 | ["test/functional/wallet_balance.py"] | Failure in wallet_balance.py | Failure observed in #14047, output:
```
82/119 - wallet_balance.py failed, Duration: 13 s
stdout:
2019-05-11T08:00:06.629000Z TestFramework (INFO): Initializing test directory /tmp/test_runner_₿_🏃_20190511_074808/wallet_balance_37
2019-05-11T08:00:07.651000Z TestFramework (INFO): Check that only node 0 is watching an address
2019-05-11T08:00:07.658000Z TestFramework (INFO): Mining blocks ...
2019-05-11T08:00:11.525000Z TestFramework (INFO): Test getbalance with different arguments
2019-05-11T08:00:11.708000Z TestFramework (INFO): Test getbalance and getunconfirmedbalance with unconfirmed inputs
2019-05-11T08:00:11.787000Z TestFramework (INFO): Test getbalance and getunconfirmedbalance with conflicted unconfirmed inputs
2019-05-11T08:00:15.377000Z TestFramework (INFO): Check that wallet txs not in the mempool are untrusted
2019-05-11T08:00:15.388000Z TestFramework (INFO): Test replacement and reorg of non-mempool tx
2019-05-11T08:00:18.538000Z TestFramework (INFO): Put txs back into mempool of node 1 (not node 0)
2019-05-11T08:00:18.604000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/test_framework.py", line 175, in main
self.run_test()
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/wallet_balance.py", line 203, in run_test
assert_equal(self.nodes[0].getbalance(minconf=0), 0) # wallet txs not in the mempool are untrusted
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/util.py", line 39, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(98.85979500 == 0)
2019-05-11T08:00:18.612000Z TestFramework (INFO): Stopping nodes
``` | https://github.com/bitcoin/bitcoin/issues/16020 | https://github.com/bitcoin/bitcoin/pull/16302 | 7400135b7918df9c34206bead744c496e07b0e78 | fa815255c70d32809aac640db4a8762c7d71e8db | 2019-05-13T18:14:46Z | c++ | 2019-06-28T15:19:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,011 | ["src/rpc/misc.cpp", "src/rpc/util.cpp", "src/rpc/util.h", "src/wallet/rpcwallet.cpp", "test/functional/rpc_createmultisig.py"] | addmultisigaddress does not fallback to legacy when there are uncompressed public keys in the parameters | Following a discussion that I started firstly on the Bitcoin dev's mailing list, and then on StackExchange and Reddit, regarding some weird inconsistencies I noticed when I was working on a function to derive the p2sh from a multisig script, I'm here now to report what seems to be a bug in `addmultisigaddress` method.
Reference of the discussions:
https://bitcoin.stackexchange.com/questions/87579/multisig-scripts-hashing-p2sh-difference-between-legacy-and-segwit
https://www.reddit.com/r/Bitcoin/comments/bmiuk5/multisig_scripts_hashing_p2sh_difference_between/
## Example:
```bash
bitcoin-cli addmultisigaddress 1 '["045897fee25bd7c5692510b2f50fcae9aa20fbc4d49d59814f4c7fdb5c4bc6eb1c0ce382458f9588e922e0d509ed8d34856787380075b00418b02e0bf7c652ef9d","02ac46c6d74d15e60f4f1035ff07ef740aca1d68d55ba0b8d336a73d7a35858831","0224a4dc5620714a9ecf67a09583d1e4c04f5bedb8ecea99028da05bb15a2a7e07"]'
{
"address": "36ULucjWUTrDvaJzCyhFoVbDoNS6Zum2Du",
"redeemScript": "5141045897fee25bd7c5692510b2f50fcae9aa20fbc4d49d59814f4c7fdb5c4bc6eb1c0ce382458f9588e922e0d509ed8d34856787380075b00418b02e0bf7c652ef9d2102ac46c6d74d15e60f4f1035ff07ef740aca1d68d55ba0b8d336a73d7a35858831210224a4dc5620714a9ecf67a09583d1e4c04f5bedb8ecea99028da05bb15a2a7e0753ae"
}
bitcoin-cli createmultisig 1 '["045897fee25bd7c5692510b2f50fcae9aa20fbc4d49d59814f4c7fdb5c4bc6eb1c0ce382458f9588e922e0d509ed8d34856787380075b00418b02e0bf7c652ef9d","02ac46c6d74d15e60f4f1035ff07ef740aca1d68d55ba0b8d336a73d7a35858831","0224a4dc5620714a9ecf67a09583d1e4c04f5bedb8ecea99028da05bb15a2a7e07"]'
{
"address": "3GiimyxF1R5VixfBFAbQZbuy9EesD2r6n1",
"redeemScript": "5141045897fee25bd7c5692510b2f50fcae9aa20fbc4d49d59814f4c7fdb5c4bc6eb1c0ce382458f9588e922e0d509ed8d34856787380075b00418b02e0bf7c652ef9d2102ac46c6d74d15e60f4f1035ff07ef740aca1d68d55ba0b8d336a73d7a35858831210224a4dc5620714a9ecf67a09583d1e4c04f5bedb8ecea99028da05bb15a2a7e0753ae"
}
```
## Expected behaviour:
Both the two calls should return the same legacy address, because `addmultisigaddress` uses p2sh-segwit which is the default address type for the wallet, but segwit does not support uncompressed keys, so the first call should fallback to legacy.
## Actual behaviour:
The first call is returning an invalid segwit address.
@achow101 answered to my email to the dev list and also to my question on StackExchange and he believes that this is a bug and it could be related to the fact that the uncompressed pubkey is not part of my wallet.
---
Another interesting thing is that, as user @ugamkamat pointed out on StackExchange, changing the position of the uncompressed public key from the first to the last, the first call returns a legacy address:
```bash
./bitcoin-cli addmultisigaddress 1 '["02ac46c6d74d15e60f4f1035ff07ef740aca1d68d55ba0b8d336a73d7a35858831","0224a4dc5620714a9ecf67a09583d1e4c04f5bedb8ecea99028da05bb15a2a7e07","045897fee25bd7c5692510b2f50fcae9aa20fbc4d49d59814f4c7fdb5c4bc6eb1c0ce382458f9588e922e0d509ed8d34856787380075b00418b02e0bf7c652ef9d"]'
{
"address": "35RZ8AHKWGGbNcRDaCUtznSVnPRWGqVPJu",
"redeemScript": "512102ac46c6d74d15e60f4f1035ff07ef740aca1d68d55ba0b8d336a73d7a35858831210224a4dc5620714a9ecf67a09583d1e4c04f5bedb8ecea99028da05bb15a2a7e0741045897fee25bd7c5692510b2f50fcae9aa20fbc4d49d59814f4c7fdb5c4bc6eb1c0ce382458f9588e922e0d509ed8d34856787380075b00418b02e0bf7c652ef9d53ae"
}
```
I'd really like to try to contribute to the project, so I'm trying to figure out where the problem could be in the code. Any suggestion is welcome. | https://github.com/bitcoin/bitcoin/issues/16011 | https://github.com/bitcoin/bitcoin/pull/16026 | 65526fc8666fef35ef908dbc225f706bef642c7e | a49503402b6bc21e3878e151c07529941d36aed0 | 2019-05-12T11:07:32Z | c++ | 2019-06-20T15:02:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 16,004 | ["src/netbase.cpp"] | Unusual CPU usage on Bitcoin daemon over Tor (addcon, opencon) | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
I am experiencing a boost in CPU usage once I used a the Bitcoin daemon over Tor&clearnet with a hidden service. The CPU usage was very low when my Bitcoin node was only on clearnet but rigth now is always using one or two core at 100%, out of 8 cores nearly all the time.
<!--- What behavior did you expect? -->
I was expecting a similar or at least slightly higher CPU usage over Tor compared to a clearnet node.
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
The issue is continuous. I have usually 12 outbound connections (over Tor or Clearnet) and 3-5 inbound connections over Tor.
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
My bitcoin version is the v0.18.0
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
My sistem is an Odroid HC1 with an SSD.
The OS is Ubuntu 16.04.6 LTS XENIAL.
I am using a lightning node over LND within the same system.
<!-- For the GUI-related issue on Linux provide names and versions of a distro, a desktop environment and a graphical shell (if relevant). -->
<!-- Any extra information that might be useful in the debugging process. -->
I don't see anything strange other than a lot of refused connections on debug.log. I attach the last lines of the debug.log file.
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
```
2019-05-09T23:26:22Z UpdateTip: new best=0000000000000000000afe04af305f885d67b6d666cea19fcb431c9b1b04a519 height=575340 version=0x20000000 log2_work=90.62208 tx=411607669 date='2019-05-09T23:26:11Z' progress=1.000000 cache=29.2MiB(256898txo) warning='37 of last 100 blocks have unexpected version'
2019-05-09T23:26:57Z UpdateTip: new best=0000000000000000000553864f70dd499354f6ee46e1dcfdd5fa169135d69a67 height=575341 version=0x20800000 log2_work=90.622101 tx=411609206 date='2019-05-09T23:26:32Z' progress=1.000000 cache=29.7MiB(262016txo) warning='37 of last 100 blocks have unexpected version'
2019-05-09T23:31:38Z UpdateTip: new best=00000000000000000013113b6bae51edcdb774450d85f6395f2fc2ddea497800 height=575342 version=0x20400000 log2_work=90.622123 tx=411611238 date='2019-05-09T23:31:04Z' progress=1.000000 cache=30.2MiB(266063txo) warning='37 of last 100 blocks have unexpected version'
2019-05-09T23:35:59Z Socks5() connect to 2a02:8071:82cd:e100:778d:dc56:e57c:b1ce:8333 failed: host unreachable
2019-05-09T23:38:59Z Socks5() connect to 146.52.89.93:8333 failed: host unreachable
2019-05-09T23:39:31Z Pre-allocating up to position 0x700000 in rev01631.dat
2019-05-09T23:39:31Z UpdateTip: new best=000000000000000000277e7a28795bafd466fe13ef7397e2c59994c9946eae9f height=575343 version=0x20c00000 log2_work=90.622145 tx=411613970 date='2019-05-09T23:39:13Z' progress=1.000000 cache=30.7MiB(271159txo) warning='37 of last 100 blocks have unexpected version'
2019-05-09T23:44:34Z Socks5() connect to 92.76.174.124:8333 failed: general failure
2019-05-09T23:45:41Z UpdateTip: new best=000000000000000000024fff922c2e823385d6669c31f99ad19b503659e8f0e6 height=575344 version=0x20000000 log2_work=90.622167 tx=411616160 date='2019-05-09T23:45:10Z' progress=1.000000 cache=31.1MiB(274652txo) warning='37 of last 100 blocks have unexpected version'
2019-05-09T23:48:16Z Socks5() connect to 184.75.208.74:8333 failed: connection refused
2019-05-09T23:50:06Z Socks5() connect to 195.95.232.166:8333 failed: host unreachable
2019-05-09T23:55:03Z Socks5() connect to 2601:345:4202:e9a::d411:8333 failed: general failure
2019-05-09T23:56:56Z New outbound peer connected: version: 70015, blocks=575344, peer=150
2019-05-10T00:04:17Z Socks5() connect to 103.225.124.94:8333 failed: host unreachable
2019-05-10T00:06:30Z New outbound peer connected: version: 70015, blocks=575344, peer=154
2019-05-10T00:07:23Z Socks5() connect to 61.74.181.139:8333 failed: connection refused
2019-05-10T00:16:10Z New outbound peer connected: version: 70015, blocks=575344, peer=158
2019-05-10T00:17:18Z UpdateTip: new best=00000000000000000024ece831f33fbb489adb40bf921e4027fb7d035f7228c2 height=575345 version=0x20400000 log2_work=90.622188 tx=411619340 date='2019-05-10T00:16:40Z' progress=1.000000 cache=32.3MiB(286409txo) warning='37 of last 100 blocks have unexpected version'
2019-05-10T00:19:56Z Socks5() connect to 2001:4dd4:1bfc:0:7f66:f8cf:d29:ecd2:8333 failed: connection refused
2019-05-10T00:21:09Z Socks5() connect to 46.0.68.2:8333 failed: connection refused
2019-05-10T00:21:46Z Socks5() connect to 165.165.166.154:8333 failed: connection refused
2019-05-10T00:23:43Z Socks5() connect to 220.240.30.5:8333 failed: general failure
2019-05-10T00:29:02Z Socks5() connect to 178.45.197.88:8333 failed: connection refused
2019-05-10T00:31:01Z Socks5() connect to 74.202.83.27:8333 failed: connection refused
2019-05-10T00:32:04Z Socks5() connect to 2604:2d80:cc11:8ae1:7430:57dc:36bc:e6d5:8333 failed: host unreachable
2019-05-10T00:33:45Z Socks5() connect to 101.51.154.239:8333 failed: connection refused
2019-05-10T00:37:21Z Socks5() connect to 185.117.215.9:8333 failed: connection refused
2019-05-10T00:43:10Z Pre-allocating up to position 0x4000000 in blk01631.dat
2019-05-10T00:43:11Z UpdateTip: new best=0000000000000000001261f67440b680e53418264e5f488bbb16a9f2941aaad2 height=575346 version=0x20000000 log2_work=90.62221 tx=411622641 date='2019-05-10T00:42:49Z' progress=1.000000 cache=33.2MiB(294217txo) warning='37 of last 100 blocks have unexpected version'
2019-05-10T00:50:00Z Socks5() connect to 194.44.53.2:8333 failed: connection refused
2019-05-10T00:51:54Z Socks5() connect to 2604:6000:1012:c633::285:8333 failed: general failure
2019-05-10T00:54:11Z Socks5() connect to 2001:1b60:3:221:3132:102:0:1:8333 failed: connection refused
2019-05-10T01:06:41Z UpdateTip: new best=000000000000000000020349af1964eb3a47451b51f172b768e377a6842194dd height=575347 version=0x20000000 log2_work=90.622232 tx=411625634 date='2019-05-10T01:06:35Z' progress=1.000000 cache=34.0MiB(302312txo) warning='37 of last 100 blocks have unexpected version'
2019-05-10T01:08:20Z Socks5() connect to 162.156.84.221:8333 failed: connection refused
2019-05-10T01:19:51Z UpdateTip: new best=0000000000000000000bd90f53dcc5b8813a96d6df5304e73558d73f578073de height=575348 version=0x20400000 log2_work=90.622254 tx=411627496 date='2019-05-10T01:19:36Z' progress=1.000000 cache=35.7MiB(318270txo) warning='38 of last 100 blocks have unexpected version'
2019-05-10T01:21:07Z Socks5() connect to 2001:16b8:48f:6300:31af:469:ed12:be91:8333 failed: connection refused
2019-05-10T01:22:47Z Socks5() connect to 2607:fa18:3a01::50:8333 failed: general failure
2019-05-10T01:37:55Z UpdateTip: new best=00000000000000000015d88c1c77d8cd4e340e610e04be9dec57482fdd735847 height=575349 version=0x20000000 log2_work=90.622276 tx=411630311 date='2019-05-10T01:37:43Z' progress=1.000000 cache=36.7MiB(327420txo) warning='38 of last 100 blocks have unexpected version'
2019-05-10T01:44:54Z Pre-allocating up to position 0x800000 in rev01631.dat
2019-05-10T01:44:54Z UpdateTip: new best=0000000000000000001debdb1474501b68123a0979a175d388dbe27f508f2a49 height=575350 version=0x20000000 log2_work=90.622297 tx=411632622 date='2019-05-10T01:44:45Z' progress=1.000000 cache=37.6MiB(335786txo) warning='38 of last 100 blocks have unexpected version'
2019-05-10T01:48:16Z Socks5() connect to 179.83.249.217:8333 failed: connection refused
2019-05-10T01:50:49Z Socks5() connect to 2001:470:6f:14b:5091:2641:33aa:f6b:8333 failed: host unreachable
2019-05-10T01:59:38Z Socks5() connect to 188.167.251.17:8333 failed: connection refused
2019-05-10T02:03:51Z UpdateTip: new best=00000000000000000001af4445650c03f7812f9bd6e5c6bd1d09b19e32f6ecba height=575351 version=0x20800000 log2_work=90.622319 tx=411634960 date='2019-05-10T02:03:15Z' progress=1.000000 cache=38.8MiB(346742txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T02:06:57Z Socks5() connect to 2001:1bc0:cc::a001:8333 failed: general failure
2019-05-10T02:07:21Z UpdateTip: new best=0000000000000000001025947f4f7e07a4e7478fe54a1c75ddfc24aa3d02d107 height=575352 version=0x20000000 log2_work=90.622341 tx=411636487 date='2019-05-10T02:06:50Z' progress=1.000000 cache=39.7MiB(355465txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T02:08:21Z Socks5() connect to 83.251.255.201:8333 failed: connection refused
2019-05-10T02:10:36Z New outbound peer connected: version: 70015, blocks=575352, peer=202
2019-05-10T02:18:21Z Socks5() connect to 2600:8801:db00:8a3::3d05:8333 failed: general failure
2019-05-10T02:20:10Z New outbound peer connected: version: 70015, blocks=575352, peer=207
2019-05-10T02:21:34Z Socks5() connect to 46.38.44.125:8333 failed: connection refused
2019-05-10T02:23:58Z Socks5() connect to 66.254.234.20:8333 failed: connection refused
2019-05-10T02:29:44Z New outbound peer connected: version: 70015, blocks=575352, peer=212
2019-05-10T02:30:43Z Socks5() connect to 212.92.123.25:8333 failed: connection refused
2019-05-10T02:30:44Z UpdateTip: new best=000000000000000000295cf01850067c2ca6bca5b0c1eeaabf520433d88bee54 height=575353 version=0x20000000 log2_work=90.622363 tx=411638239 date='2019-05-10T02:30:18Z' progress=1.000000 cache=41.2MiB(369382txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T02:34:04Z Socks5() connect to 5.12.251.236:8333 failed: connection refused
2019-05-10T02:35:54Z New outbound peer connected: version: 70015, blocks=575353, peer=216
2019-05-10T02:39:21Z New outbound peer connected: version: 70015, blocks=575353, peer=218
2019-05-10T02:43:00Z Socks5() connect to 195.201.71.60:8333 failed: connection refused
2019-05-10T02:44:40Z Socks5() connect to 94.134.40.42:8333 failed: host unreachable
2019-05-10T02:48:07Z Socks5() connect to 5.63.46.78:8333 failed: general failure
2019-05-10T02:48:55Z New outbound peer connected: version: 70015, blocks=575353, peer=222
2019-05-10T02:56:57Z UpdateTip: new best=0000000000000000001f221f95ab5ef4fcd3bd5daef93c0733f8fbfc79d427d2 height=575354 version=0x20000000 log2_work=90.622385 tx=411640557 date='2019-05-10T02:56:57Z' progress=1.000000 cache=42.2MiB(378722txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T02:58:29Z New outbound peer connected: version: 70015, blocks=575354, peer=227
2019-05-10T03:02:34Z Socks5() connect to 78.55.173.143:8333 failed: host unreachable
2019-05-10T03:04:11Z Socks5() connect to 82.207.200.54:8333 failed: connection refused
2019-05-10T03:16:55Z UpdateTip: new best=000000000000000000254a5c0bc74e13f30a05e845933cd9edf8f343ea68c0f1 height=575355 version=0x20000000 log2_work=90.622406 tx=411642951 date='2019-05-10T03:16:08Z' progress=1.000000 cache=42.7MiB(382888txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T03:17:05Z Socks5() connect to 79.238.94.191:8333 failed: host unreachable
2019-05-10T03:17:36Z New outbound peer connected: version: 70015, blocks=575355, peer=232
2019-05-10T03:19:41Z UpdateTip: new best=0000000000000000002236af2a588d3afcb3a161c168e882b9cc37a2e90652fc height=575356 version=0x20c00000 log2_work=90.622428 tx=411645219 date='2019-05-10T03:19:15Z' progress=1.000000 cache=43.1MiB(386955txo) warning='40 of last 100 blocks have unexpected version'
2019-05-10T03:21:57Z Socks5() connect to 104.254.90.87:8333 failed: connection refused
2019-05-10T03:26:19Z Socks5() connect to 24.85.181.241:8333 failed: general failure
2019-05-10T03:28:53Z Socks5() connect to 78.94.232.189:8333 failed: connection refused
2019-05-10T03:30:32Z Pre-allocating up to position 0x900000 in rev01631.dat
2019-05-10T03:30:32Z UpdateTip: new best=000000000000000000007d00d8514b5dad5773a202bfd6ef6b970e53a56109d9 height=575357 version=0x20c00000 log2_work=90.62245 tx=411647204 date='2019-05-10T03:29:51Z' progress=1.000000 cache=43.9MiB(394314txo) warning='40 of last 100 blocks have unexpected version'
2019-05-10T03:35:50Z Socks5() connect to 2a01:4f9:2b:fa2::2:8333 failed: general failure
2019-05-10T03:36:42Z New outbound peer connected: version: 70015, blocks=575357, peer=238
2019-05-10T03:46:16Z New outbound peer connected: version: 70015, blocks=575357, peer=241
2019-05-10T03:48:20Z Pre-allocating up to position 0x5000000 in blk01631.dat
2019-05-10T03:48:20Z UpdateTip: new best=0000000000000000001e91f514c47e9014893ac1418ec5b9a6590c38f71585e9 height=575358 version=0x20800000 log2_work=90.622472 tx=411649826 date='2019-05-10T03:48:04Z' progress=1.000000 cache=44.5MiB(399663txo) warning='40 of last 100 blocks have unexpected version'
2019-05-10T03:49:02Z UpdateTip: new best=0000000000000000002841e341db47a5c7ab84c416fea4dc9b600953e6095193 height=575359 version=0x20c00000 log2_work=90.622494 tx=411651867 date='2019-05-10T03:48:51Z' progress=1.000000 cache=45.2MiB(406977txo) warning='40 of last 100 blocks have unexpected version'
2019-05-10T03:51:40Z Socks5() connect to 2a00:23c5:fd07:8b00:411:2ece:f640:db46:8333 failed: host unreachable
2019-05-10T03:52:54Z Socks5() connect to 103.254.153.113:8333 failed: connection refused
2019-05-10T03:55:50Z New outbound peer connected: version: 70015, blocks=575359, peer=245
2019-05-10T04:07:17Z UpdateTip: new best=0000000000000000000c50a7eb416230eee9da618c5b15e4a09c83d906c4f1bb height=575360 version=0x20000000 log2_work=90.622515 tx=411653904 date='2019-05-10T04:06:53Z' progress=1.000000 cache=45.8MiB(412046txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T04:07:20Z Socks5() connect to 5.63.46.78:8333 failed: host unreachable
2019-05-10T04:10:37Z UpdateTip: new best=0000000000000000001ce8354135997c8f6a64b3b004bb5f17cbdba7181dfed4 height=575361 version=0x20000000 log2_work=90.622537 tx=411656853 date='2019-05-10T04:09:48Z' progress=1.000000 cache=46.2MiB(415954txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T04:14:56Z New outbound peer connected: version: 70015, blocks=575361, peer=252
2019-05-10T04:19:59Z Socks5() connect to 2a03:4000:6:8009::1:8333 failed: general failure
2019-05-10T04:21:52Z UpdateTip: new best=000000000000000000114778e9b3160f764b2dfca2a197e750dc0796037712b6 height=575362 version=0x20400000 log2_work=90.622559 tx=411659249 date='2019-05-10T04:21:34Z' progress=1.000000 cache=46.8MiB(421325txo) warning='40 of last 100 blocks have unexpected version'
2019-05-10T04:24:31Z New outbound peer connected: version: 70015, blocks=575362, peer=257
2019-05-10T04:35:47Z Socks5() connect to 24.218.181.99:8333 failed: connection refused
2019-05-10T04:43:16Z Pre-allocating up to position 0xa00000 in rev01631.dat
2019-05-10T04:43:16Z UpdateTip: new best=00000000000000000013db6fe1d96cdee876db82939bdc61445b6b5115ad81d1 height=575363 version=0x20000000 log2_work=90.622581 tx=411661926 date='2019-05-10T04:43:10Z' progress=1.000000 cache=47.4MiB(427196txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T04:50:23Z UpdateTip: new best=00000000000000000014017ec0f7a9b039905d074c406acdd0c8b154cc33d38c height=575364 version=0x20800000 log2_work=90.622603 tx=411664243 date='2019-05-10T04:50:02Z' progress=1.000000 cache=48.0MiB(433000txo) warning='40 of last 100 blocks have unexpected version'
2019-05-10T04:52:54Z Socks5() connect to 3.83.172.33:8333 failed: connection refused
2019-05-10T04:53:09Z New outbound peer connected: version: 70015, blocks=575364, peer=267
2019-05-10T05:01:50Z UpdateTip: new best=00000000000000000018074c18e3177e6c304a96fe18c46f7bb8f26633a20871 height=575365 version=0x20000000 log2_work=90.622624 tx=411666638 date='2019-05-10T05:01:46Z' progress=1.000000 cache=48.7MiB(439049txo) warning='40 of last 100 blocks have unexpected version'
2019-05-10T05:02:43Z New outbound peer connected: version: 70015, blocks=575365, peer=272
2019-05-10T05:12:18Z New outbound peer connected: version: 70015, blocks=575365, peer=277
2019-05-10T05:21:51Z New outbound peer connected: version: 70015, blocks=575365, peer=282
2019-05-10T05:24:42Z UpdateTip: new best=00000000000000000029cab7ff4ce891126e010be5d6dd8b02a11c7a3bb221a4 height=575366 version=0x20000000 log2_work=90.622646 tx=411669168 date='2019-05-10T05:24:21Z' progress=1.000000 cache=51.5MiB(449504txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T05:26:25Z UpdateTip: new best=00000000000000000001908a10f469b3dfd6d44a1bccbd51a2e567fd7eb67b53 height=575367 version=0x20000000 log2_work=90.622668 tx=411671593 date='2019-05-10T05:26:23Z' progress=1.000000 cache=51.9MiB(453376txo) warning='38 of last 100 blocks have unexpected version'
2019-05-10T05:28:12Z Socks5() connect to 186.90.243.233:8333 failed: host unreachable
2019-05-10T05:29:22Z UpdateTip: new best=0000000000000000001ba7b93749701300daa4a53319d3162222dd36e75201f0 height=575368 version=0x3fffe000 log2_work=90.62269 tx=411673946 date='2019-05-10T05:29:22Z' progress=1.000000 cache=52.5MiB(458790txo) warning='38 of last 100 blocks have unexpected version'
2019-05-10T05:29:40Z UpdateTip: new best=00000000000000000023cbed8eddf35ca23bca74d46ea1a9e9d38199a4c46c61 height=575369 version=0x20800000 log2_work=90.622711 tx=411675834 date='2019-05-10T05:29:21Z' progress=1.000000 cache=53.1MiB(464350txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T05:37:58Z Pre-allocating up to position 0xb00000 in rev01631.dat
2019-05-10T05:37:58Z UpdateTip: new best=000000000000000000241e5a3f4275e90a7c70782e1d2499159bbfeaea0397ee height=575370 version=0x20400000 log2_work=90.622733 tx=411677867 date='2019-05-10T05:37:30Z' progress=1.000000 cache=53.4MiB(466827txo) warning='40 of last 100 blocks have unexpected version'
2019-05-10T05:38:12Z UpdateTip: new best=000000000000000000011c85ae7e66e7a81cea0caa3af06a9b355012dd5ebe3d height=575371 version=0x20400000 log2_work=90.622755 tx=411681219 date='2019-05-10T05:37:58Z' progress=1.000000 cache=53.8MiB(470546txo) warning='40 of last 100 blocks have unexpected version'
2019-05-10T05:41:04Z Pre-allocating up to position 0x6000000 in blk01631.dat
2019-05-10T05:41:05Z UpdateTip: new best=0000000000000000000f06b6e4d7f4ebbf62c5b9dabcfd5f78c698362dd1e49e height=575372 version=0x3fffe000 log2_work=90.622777 tx=411683288 date='2019-05-10T05:40:45Z' progress=1.000000 cache=54.3MiB(475068txo) warning='40 of last 100 blocks have unexpected version'
2019-05-10T05:46:23Z Socks5() connect to 2601:19c:4802:6930::b56b:8333 failed: general failure
2019-05-10T05:47:18Z Socks5() connect to 2001:5b0:48e0:a9b8:4031:5983:7f7c:da84:8333 failed: host unreachable
2019-05-10T05:49:16Z UpdateTip: new best=000000000000000000265af46c5330d911d45ef24d20f1b545fbb37869dac6ea height=575373 version=0x20000000 log2_work=90.622799 tx=411685741 date='2019-05-10T05:48:32Z' progress=1.000000 cache=54.6MiB(478098txo) warning='40 of last 100 blocks have unexpected version'
2019-05-10T05:50:34Z New outbound peer connected: version: 70015, blocks=575373, peer=294
2019-05-10T06:00:08Z New outbound peer connected: version: 70015, blocks=575373, peer=298
2019-05-10T06:01:02Z UpdateTip: new best=000000000000000000131a324b39b490ada693f0a3b63ff9761d61d0efe64635 height=575374 version=0x20000000 log2_work=90.62282 tx=411688241 date='2019-05-10T06:00:59Z' progress=1.000000 cache=55.1MiB(482572txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T06:05:34Z Socks5() connect to 2a01:4f9:c010:2cee::1:8333 failed: general failure
2019-05-10T06:08:05Z UpdateTip: new best=00000000000000000009b1a4e061071faa9ed8e4738756d124688ddd6400f1d0 height=575375 version=0x20000000 log2_work=90.622842 tx=411690516 date='2019-05-10T06:08:13Z' progress=1.000000 cache=55.4MiB(485928txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T06:08:47Z UpdateTip: new best=0000000000000000000e9b400e2dc58a008f461b3668a908f97321e85e9536d6 height=575376 version=0x20000000 log2_work=90.622864 tx=411692775 date='2019-05-10T06:08:49Z' progress=1.000000 cache=55.7MiB(488460txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T06:09:41Z New outbound peer connected: version: 70015, blocks=575376, peer=302
2019-05-10T06:10:03Z Socks5() connect to 188.172.198.43:8333 failed: connection refused
2019-05-10T06:12:29Z Pre-allocating up to position 0xc00000 in rev01631.dat
2019-05-10T06:12:30Z UpdateTip: new best=0000000000000000000f692c5a3853940eec49e45fe9179980e308a1d6e0e1e2 height=575377 version=0x2000e000 log2_work=90.622886 tx=411695356 date='2019-05-10T06:12:35Z' progress=1.000000 cache=56.0MiB(490820txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T06:16:42Z Socks5() connect to 88.149.180.187:8333 failed: host unreachable
2019-05-10T06:19:16Z New outbound peer connected: version: 70015, blocks=575377, peer=307
2019-05-10T06:25:31Z Socks5() connect to 2a03:b0c0:3:d0::23f7:b001:8333 failed: general failure
2019-05-10T06:28:50Z New outbound peer connected: version: 70015, blocks=575377, peer=313
2019-05-10T06:35:50Z UpdateTip: new best=0000000000000000000f8c6760212fd07b668324133e30418442fcb712e6732f height=575378 version=0x20000000 log2_work=90.622908 tx=411698267 date='2019-05-10T06:35:27Z' progress=1.000000 cache=56.7MiB(497893txo) warning='39 of last 100 blocks have unexpected version'
2019-05-10T06:38:24Z New outbound peer connected: version: 70015, blocks=575378, peer=319
2019-05-10T06:39:52Z UpdateTip: new best=0000000000000000000604e1f98e0791fce79bb6bb6322aab83bffecb73b6de3 height=575379 version=0x20000000 log2_work=90.622929 tx=411700940 date='2019-05-10T06:39:23Z' progress=1.000000 cache=57.0MiB(500432txo) warning='38 of last 100 blocks have unexpected version'
2019-05-10T06:43:22Z Socks5() connect to 173.255.139.144:8333 failed: connection refused
2019-05-10T06:46:33Z UpdateTip: new best=0000000000000000000904294acafe54bf1383233007a95f1aede347a1149bce height=575380 version=0x20000000 log2_work=90.622951 tx=411703491 date='2019-05-10T06:46:25Z' progress=1.000000 cache=57.3MiB(503392txo) warning='38 of last 100 blocks have unexpected version'
2019-05-10T06:48:52Z UpdateTip: new best=000000000000000000047296d09074b23b6e7d9fc07cc67960884f2dfddaaae9 height=575381 version=0x20000000 log2_work=90.622973 tx=411705029 date='2019-05-10T06:48:48Z' progress=1.000000 cache=57.4MiB(504597txo) warning='37 of last 100 blocks have unexpected version'
2019-05-10T06:49:48Z UpdateTip: new best=000000000000000000107000cda51a31343520e15ba5843a88dbdf6924df1852 height=575382 version=0x20000000 log2_work=90.622995 tx=411706987 date='2019-05-10T06:49:23Z' progress=1.000000 cache=57.6MiB(506046txo) warning='37 of last 100 blocks have unexpected version'
2019-05-10T06:51:30Z Socks5() connect to 65.204.58.114:8333 failed: connection refused
2019-05-10T06:57:31Z New outbound peer connected: version: 70015, blocks=575382, peer=330
2019-05-10T07:07:06Z New outbound peer connected: version: 70015, blocks=575382, peer=334
2019-05-10T07:11:31Z Pre-allocating up to position 0xd00000 in rev01631.dat
2019-05-10T07:11:31Z UpdateTip: new best=00000000000000000011e2a5b9b270479740ddb9623cc0da9e5a327bd996d777 height=575383 version=0x3fff0000 log2_work=90.623016 tx=411709930 date='2019-05-10T07:11:25Z' progress=1.000000 cache=58.4MiB(513719txo) warning='38 of last 100 blocks have unexpected version'
2019-05-10T07:12:51Z UpdateTip: new best=000000000000000000037a0e7053b2b6c677857c2ef0487f841decfe9c3761f2 height=575384 version=0x20000000 log2_work=90.623038 tx=411712411 date='2019-05-10T07:12:13Z' progress=1.000000 cache=59.1MiB(520649txo) warning='37 of last 100 blocks have unexpected version'
2019-05-10T07:14:26Z Socks5() connect to 87.178.226.188:8333 failed: connection refused
2019-05-10T07:19:57Z UpdateTip: new best=0000000000000000000fe96e43513887191bade5585f843cfdc3163a641b9b1d height=575385 version=0x2000e000 log2_work=90.62306 tx=411714975 date='2019-05-10T07:20:08Z' progress=1.000000 cache=59.5MiB(524146txo) warning='37 of last 100 blocks have unexpected version'
2019-05-10T07:32:19Z Pre-allocating up to position 0x7000000 in blk01631.dat
2019-05-10T07:32:19Z UpdateTip: new best=0000000000000000000a0935a536f098984bfed20748553a47384d42069bebb6 height=575386 version=0x20000000 log2_work=90.623082 tx=411717525 date='2019-05-10T07:32:11Z' progress=1.000000 cache=61.6MiB(543121txo) warning='37 of last 100 blocks have unexpected version'
2019-05-10T07:33:28Z UpdateTip: new best=0000000000000000000ca88bb299f7f462f1c46fd463d57e987f48e034818fee height=575387 version=0x20000000 log2_work=90.623104 tx=411718273 date='2019-05-10T07:32:55Z' progress=1.000000 cache=61.6MiB(543781txo) warning='37 of last 100 blocks have unexpected version'
2019-05-10T07:49:46Z UpdateTip: new best=00000000000000000015c064d4870c99888ea95f1d94637fcb3bee2d7b7a8323 height=575388 version=0x20000000 log2_work=90.623125 tx=411721477 date='2019-05-10T07:49:18Z' progress=1.000000 cache=62.5MiB(551787txo) warning='37 of last 100 blocks have unexpected version'
2019-05-10T08:03:10Z UpdateTip: new best=00000000000000000009ae5e1f0e473f0c4f72b54138262bc742b8148ba109c9 height=575389 version=0x20000000 log2_work=90.623147 tx=411724151 date='2019-05-10T08:02:56Z' progress=1.000000 cache=63.3MiB(559335txo) warning='37 of last 100 blocks have unexpected version'
2019-05-10T08:18:28Z Socks5() connect to 159.69.68.214:8333 failed: connection refused
2019-05-10T08:30:09Z Pre-allocating up to position 0xe00000 in rev01631.dat
2019-05-10T08:30:09Z UpdateTip: new best=0000000000000000000e148dfa1b8919a327d3cb310dc7e84610793f8092628d height=575390 version=0x20000000 log2_work=90.623169 tx=411726929 date='2019-05-10T08:29:43Z' progress=1.000000 cache=65.1MiB(576398txo) warning='37 of last 100 blocks have unexpected version'
2019-05-10T08:36:01Z UpdateTip: new best=000000000000000000214b742af9a1c57049a64bf0214e217a6b8a11c88e1951 height=575391 version=0x20000000 log2_work=90.623191 tx=411729753 date='2019-05-10T08:35:46Z' progress=1.000000 cache=65.7MiB(582381txo) warning='36 of last 100 blocks have unexpected version'
2019-05-10T08:56:01Z Socks5() connect to 2001:56a:f317:4e00:526f:e70d:4a25:e22:8333 failed: host unreachable
2019-05-10T08:59:02Z Socks5() connect to 2604:3d08:6b7f:e7e0::203e:8333 failed: general failure
2019-05-10T09:01:18Z Socks5() connect to 196.52.84.22:8333 failed: connection refused
2019-05-10T09:01:36Z UpdateTip: new best=00000000000000000014c2a4d1e29cb32cca2731b6b286b40b55173f4938c667 height=575392 version=0x20000000 log2_work=90.623213 tx=411732531 date='2019-05-10T09:01:01Z' progress=1.000000 cache=66.9MiB(592708txo) warning='36 of last 100 blocks have unexpected version'
2019-05-10T09:08:52Z Socks5() connect to 87.101.95.115:8333 failed: connection refused
2019-05-10T09:10:34Z Socks5() connect to 95.90.248.39:8333 failed: connection refused
2019-05-10T09:11:10Z New outbound peer connected: version: 70015, blocks=575392, peer=384
```
| https://github.com/bitcoin/bitcoin/issues/16004 | https://github.com/bitcoin/bitcoin/pull/16412 | 0515406acb5d0c60e743822853b80e122285a82c | a52818cc5633494992da7d1dc8fdb04b4a1b7c29 | 2019-05-10T09:26:39Z | c++ | 2019-07-18T11:04:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,980 | ["src/validation.cpp"] | RewindBlockIndex reads chainActive (via ChainActive()) without holding cs_main | `RewindBlockIndex` reads `chainActive` (via `ChainActive()`) without holding `cs_main`:
https://github.com/bitcoin/bitcoin/blob/b2a6b0216192b6e8428f1a80b47f5178fccb961a/src/validation.cpp#L4314-L4331
(Please note that callers of `RewindBlockIndex` are _not_ allowed to hold `cs_main` since `RewindBlockIndex` indirectly calls `LimitValidationInterfaceQueue`.) | https://github.com/bitcoin/bitcoin/issues/15980 | https://github.com/bitcoin/bitcoin/pull/16015 | e79bbb73e08e3f191e97d3b67a2fbb510c5545ff | 1609809fb2a4c2ec15b7c26dc328e2e666bd5d57 | 2019-05-08T08:26:11Z | c++ | 2019-05-15T12:58:15Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,967 | ["src/validation.cpp"] | Inconsistent locking behavior in LoadChainTip | LoadChainTip requires cs_main to be locked. Under some conditions, it may call ActivateBestChain. However, ActivateBestChain requires cs_main NOT to be taken when called. | https://github.com/bitcoin/bitcoin/issues/15967 | https://github.com/bitcoin/bitcoin/pull/15999 | c459c5f70176928adcee4935813a2dbe7f4dbd51 | fa86c8aec611a9b9d2f53960c92419cf2a8bb92d | 2019-05-06T22:28:23Z | c++ | 2019-05-13T15:53:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,958 | ["configure.ac"] | 32 bit linux gitian build fails with "symbol __cxa_thread_atexit_impl from unsupported version GLIBC_2.18" | On current master with gitian:
```
....
CXXLD qt/bitcoin-qt
make[2]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-i686-pc-linux-gnu/src'
make[1]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-i686-pc-linux-gnu/src'
Making all in doc/man
make[1]: Entering directory '/home/ubuntu/build/bitcoin/distsrc-i686-pc-linux-gnu/doc/man'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-i686-pc-linux-gnu/doc/man'
make[1]: Entering directory '/home/ubuntu/build/bitcoin/distsrc-i686-pc-linux-gnu'
make[1]: Nothing to be done for 'all-am'.
make[1]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-i686-pc-linux-gnu'
+ make -j1 -C src check-security
make: Entering directory '/home/ubuntu/build/bitcoin/distsrc-i686-pc-linux-gnu/src'
Checking binary security...
make: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-i686-pc-linux-gnu/src'
+ make -j1 -C src check-symbols
make: Entering directory '/home/ubuntu/build/bitcoin/distsrc-i686-pc-linux-gnu/src'
Checking glibc back compat...
bitcoin-cli: symbol __cxa_thread_atexit_impl from unsupported version GLIBC_2.18
bitcoin-tx: symbol __cxa_thread_atexit_impl from unsupported version GLIBC_2.18
bitcoin-wallet: symbol __cxa_thread_atexit_impl from unsupported version GLIBC_2.18
test/test_bitcoin: symbol __cxa_thread_atexit_impl from unsupported version GLIBC_2.18
qt/bitcoin-qt: symbol __cxa_thread_atexit_impl from unsupported version GLIBC_2.18
Makefile:13425: recipe for target 'check-symbols' failed
make: *** [check-symbols] Error 1
make: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-i686-pc-linux-gnu/src' | https://github.com/bitcoin/bitcoin/issues/15958 | https://github.com/bitcoin/bitcoin/pull/16059 | 149b3477ecff4ff9c50cd38724c86cb6ae4d3276 | 480e3415d738a4e0e2ad9774c43f29937178ecae | 2019-05-06T13:29:08Z | c++ | 2019-05-23T19:15:46Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,952 | ["src/qt/bitcoingui.cpp"] | Can't open wallet | <!-- Describe the issue -->
Hello evryone, I get nothing when I click in open wallet, I am new to bitcoin and expect to show something.
I'am using Bitcoin Core (both in testnet and mainnet, didn't work) 0.18 on window 10.
| https://github.com/bitcoin/bitcoin/issues/15952 | https://github.com/bitcoin/bitcoin/pull/15957 | c5ffe8d5155b21d0099259416436d09fc20d7017 | c3ef63a52f304a600fff1f9c7caa5cb804d41d43 | 2019-05-04T13:27:59Z | c++ | 2019-05-08T11:54:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,944 | ["src/noui.cpp", "src/noui.h", "src/wallet/test/init_tests.cpp"] | Path error messages while executing test_bitcoin | Compiled bitcoin-0.18.0.tar.gz from https://bitcoin.org/bin/bitcoin-core-0.18.0/ on Ubuntu 18.04.2 LTS (using [this](http://Bitkoins.nl/maken.txt) (simple) bash script). The compilation went well (had to add doxygen to suppress a warning message). When running the test: `test_bitcoin` in `bitcoin-0.18.0/src/test/`, I get the following error messages (multiple times):
`Error: Specified -walletdir "/tmp/test_bitcoin/1556861148_943311758/tempdir/path_does_not_exist" does not exist`
and
`Error: Specified -walletdir "/tmp/test_bitcoin/1556861730_643733972/tempdir/not_a_directory.dat" is not a directory`
and
`Error: Specified -walletdir "wallets" is a relative path`
Note that at the end it still says: `*** No errors detected`
| https://github.com/bitcoin/bitcoin/issues/15944 | https://github.com/bitcoin/bitcoin/pull/16277 | c8fee6769a106bb5fbcdd3674fd0444b01d3391c | 7a0c2242890549b6dddac4cc6f1840a528469f2a | 2019-05-03T05:58:19Z | c++ | 2019-07-03T12:03:21Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,940 | ["src/init.cpp", "src/util/error.cpp", "src/util/error.h", "src/wallet/wallet.cpp"] | Release schedule for 0.19.0 | Here is a proposed release schedule for 0.19.0, the next major release of Bitcoin Core. Like for previous major releases I've aimed for a release 6 months after the last ( #14438).
2019-09-01 :heavy_check_mark:
---------------
- Open Transifex translations for 0.19
- Soft translation string freeze (no large or unnecessary string changes until release)
- Finalize and close translations for 0.17
2019-09-15 :heavy_check_mark:
---------------
- Feature freeze (bug fixes only until release)
- Translation string freeze (no more source language changes until release)
2019-10-01 :heavy_check_mark:
---------------
- Split off `0.19` branch from `master`
- Start RC cycle, tag and release `0.19.0rc1`
- Start merging for 0.20 on master branch
2019-11-03 :heavy_check_mark:
---------------
- Release 0.19.0 final (aim)
If any specific dates or timeframes are a problem for you, let me know.
**Edit:** schedule was moved two months back on 2019-05-07, for reference, the old schedule was:
```
2019-11-01 Soft translation string freeze
2019-11-15 Feature freeze
2019-12-01 Split off 0.19 branch from master
2020-01-03 Release 0.19.0 final (aim)
``` | https://github.com/bitcoin/bitcoin/issues/15940 | https://github.com/bitcoin/bitcoin/pull/16745 | fa70d199d0c2182d76b2a1cfa21f9ada4bb12913 | fa61365a1368f9970fa22fb96f89f4ecc08e69f0 | 2019-05-02T14:05:12Z | c++ | 2019-08-28T19:52:31Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,925 | ["src/rpc/blockchain.cpp", "src/rpc/blockchain.h"] | getblock performance issue on verbosity | `getblock` is slow on verbosity, it's happened because `LOCK(cs_main)` applied for whole function including JSON generation
https://github.com/bitcoin/bitcoin/blob/ef70f9b52b851c7997a9f1a0834714e3eebc1fd8/src/rpc/blockchain.cpp#L810
I added few lines which print spent time:
```cpp
LOCK(cs_main);
auto t1 = std::chrono::high_resolution_clock::now();
...
auto t2 = std::chrono::high_resolution_clock::now();
auto ret = blockToJSON(block, pblockindex, verbosity >= 2);
auto t3 = std::chrono::high_resolution_clock::now();
std::cout << "blockToJSON " << pblockindex->nHeight << ": " << std::chrono::duration_cast<std::chrono::microseconds>(t2 - t1).count() << " " << std::chrono::duration_cast<std::chrono::microseconds>(t3 - t1).count() << std::endl;
return ret;
```
and numbers looks like:
```
blockToJSON 570019: 14727 201870
blockToJSON 570022: 16049 225224
blockToJSON 570021: 33776 217398
blockToJSON 570020: 21754 191669
blockToJSON 570023: 30949 236941
blockToJSON 570025: 23346 223673
blockToJSON 570024: 18732 203002
blockToJSON 570026: 17467 216213
blockToJSON 570027: 16658 217395
blockToJSON 570028: 19015 219183
```
i.e. everything before JSON generation takes 15-30ms, while JSON takes minimum 190ms and lock `cs_main` for all this time. As result it's possible extract only ~5 blocks per second.
Looking on the code I think it's possible copy data from `CBlockIndex` to extra structure, so in this case `cs_main` can be unlocked right after `GetBlockChecked`.
https://github.com/bitcoin/bitcoin/blob/ef70f9b52b851c7997a9f1a0834714e3eebc1fd8/src/rpc/blockchain.cpp#L828
As result `getblock` in verbosity mode should be much faster (in case if `-rpcthreads` will be adjusted too).
Does this make sense? | https://github.com/bitcoin/bitcoin/issues/15925 | https://github.com/bitcoin/bitcoin/pull/15932 | fab00a5cb90053e9671627af6a35e57610a44e89 | faea56400d5578023133cf4d1c761cdeb0c3e3da | 2019-04-30T05:59:39Z | c++ | 2019-05-02T18:33:26Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,918 | ["depends/Makefile", "depends/README.md", "depends/config.site.in", "depends/packages/packages.mk"] | Feature request: make depends NO_ZEROMQ=1 | In addition to `NO_QT=1`, `NO_UPNP=1` and `NO_WALLET=1` it would be nice to have `NO_ZEROMQ=1` to opt out of building the optional dependency zeromq :-) | https://github.com/bitcoin/bitcoin/issues/15918 | https://github.com/bitcoin/bitcoin/pull/16089 | 65c4bbe629bbb6eb4347d35a12b0b1c90eeabce9 | c995c870aa4cc9b9ddf0a84ce15c544757a43a18 | 2019-04-29T10:10:51Z | c++ | 2019-05-25T16:06:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,912 | ["src/wallet/walletutil.cpp"] | [macOS] [GUI] log entries when hovering on / over File->Open Wallet | Was wondering where those millions of log entries `IsBerkeleyBtree: No such file or directory <walletdir/wallet>` come from. Figured out, whenever hovering over the menu, such an entry is made for each and every wallet in the wallet dir.
That's not very helpful when frequently used...
apparently #15583 didn't fix that | https://github.com/bitcoin/bitcoin/issues/15912 | https://github.com/bitcoin/bitcoin/pull/15917 | bdd7217f2c03007ce1df85cd9a750d1893d88cdc | 70c1cf8c1c07091544d060191715027282e87b57 | 2019-04-27T18:11:05Z | c++ | 2019-04-28T23:07:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,902 | ["doc/init.md", "src/i2p.cpp", "src/init.cpp", "src/rpc/request.cpp", "src/util/system.cpp", "src/wallet/init.cpp", "test/functional/feature_posix_fs_permissions.py", "test/functional/test_framework/test_framework.py", "test/functional/test_runner.py"] | Wrong permissions for datadir and walletdir | On my Linux Mint 19.1:
```bash
$ umask
0022
```
After the first run of `bitcoin-qt -sysperm=false` the `0700` permissions are expected for both the datadir (`~/.bitcoin`) and the walletdir (`~/.bitcoin/wallets`).
Actually, the directories are created with such access permissions:
```bash
$ stat ~/.bitcoin | grep Uid
Access: (0755/drwxr-xr-x) Uid: ( 1000/ hebasto) Gid: ( 1000/ hebasto)
$ stat ~/.bitcoin/wallets | grep Uid
Access: (0755/drwxr-xr-x) Uid: ( 1000/ hebasto) Gid: ( 1000/ hebasto)
```
Refs:
- #4286
- #13371
- #13389
NOTE: reading through the initial PR #4286 makes me think it was controversial. Is it a better and simpler way to just get rid of `-sysperm` option? I believe a user who needs this option can easily run `chown` command. | https://github.com/bitcoin/bitcoin/issues/15902 | https://github.com/bitcoin/bitcoin/pull/17127 | 5a80086ec2c15d1cd269e8e354f48ee11e4531eb | 6e08e5cb5cca57cef9e7a6b557e359ef911dbfaa | 2019-04-26T16:44:31Z | c++ | 2023-02-07T10:44:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,872 | ["src/rpc/rawtransaction.cpp", "src/wallet/rpcwallet.cpp", "test/functional/rpc_psbt.py"] | getrawtransaction(verbose) and decoderawtransaction of a same transaction returns different txid | <!-- Describe the issue -->
For transaction **f4dedd64c9841d53bbda8beeda52235ec986f1400606812d9c033ac34105532c**, the call of [getrawtransaction(verbose)] and [getrawtransaction(hex) + decoderawtransaction] has totally different result,including txid.
Step of reproducing the issue:
* Use **getrawtransaction(hex) + decoderawtransaction**
```
curl --user yourAuth --data-binary '{"jsonrpc": "1.0","id":"curltest","method":"getrawtransaction", "params": ["f4dedd64c9841d53bbda8beeda52235ec986f1400606812d9c033ac34105532c"] }' -H 'content-type: text/plain;' http://yourEndPoint
```
Returns:
```
{
"result": "0100000000010115a16270d3ee7ccc58a0757c1d8e1763790f223d4e4c3823948fb3dfdf9865180100000000ffffffff023f3256000000000017a9142915a7db6c6df171fd0436c7cec0042195dad01c8738ee4647000000001600140aad95e932ba045c2daf31a04c36683d39efe91002473044022002537539ac9586fdd8b5947fa0a47dc002ebe57502608433e103efe2740f93d4022023b1ade7bdf0f002a8fdc4ec6d534588d2132ab88850ac426ea413b4adb465260121031ef964af6923a2111e4916afcc87c73a8980322cc761dd3648714dfda99e72c400000000",
"error": null,
"id": null
}
```
**Decode with decoderawtransaction**:
```
curl --user yourAuth --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "decoderawtransaction", "params": ["0100000000010115a16270d3ee7ccc58a0757c1d8e1763790f223d4e4c3823948fb3dfdf9865180100000000ffffffff023f3256000000000017a9142915a7db6c6df171fd0436c7cec0042195dad01c8738ee4647000000001600140aad95e932ba045c2daf31a04c36683d39efe91002473044022002537539ac9586fdd8b5947fa0a47dc002ebe57502608433e103efe2740f93d4022023b1ade7bdf0f002a8fdc4ec6d534588d2132ab88850ac426ea413b4adb465260121031ef964af6923a2111e4916afcc87c73a8980322cc761dd3648714dfda99e72c400000000"] }' -H 'content-type: text/plain;' http://yourEndPoint
```
Returns:
```
{
"result": {
"txid": "0b637b18840d8fc978a657a3422df3c246c86e4c4046d90e63bf0f86b179b403",
"hash": "0b637b18840d8fc978a657a3422df3c246c86e4c4046d90e63bf0f86b179b403",
"version": 1,
"size": 223,
"vsize": 223,
"locktime": 0,
"vin": [
],
"vout": [
{
"value": 90023651848.04721921,
"n": 0,
"scriptPubKey": {
"asm": "8 OP_GREATERTHAN OP_DROP OP_SWAP 8e1763790f223d4e4c3823948fb3dfdf9865180100000000ffffffff02 3256000000000017a9142915a7db6c6df171fd0436c7cec0042195dad01c8738ee4647000000001600140aad95e932ba045c2daf31a04c36683d39efe91002 3044022002537539ac9586fdd8b5947fa0a47dc002ebe57502608433e103efe2740f93d4022023b1ade7bdf0f002a8fdc4ec6d534588d2132ab88850ac426ea413b4adb4652601 031ef964af6923a2111e4916afcc87c73a8980322cc761dd3648714dfda99e72c4",
"hex": "58a0757c1d8e1763790f223d4e4c3823948fb3dfdf9865180100000000ffffffff023f3256000000000017a9142915a7db6c6df171fd0436c7cec0042195dad01c8738ee4647000000001600140aad95e932ba045c2daf31a04c36683d39efe91002473044022002537539ac9586fdd8b5947fa0a47dc002ebe57502608433e103efe2740f93d4022023b1ade7bdf0f002a8fdc4ec6d534588d2132ab88850ac426ea413b4adb465260121031ef964af6923a2111e4916afcc87c73a8980322cc761dd3648714dfda99e72c4",
"type": "nonstandard"
}
}
]
},
"error": null,
"id": null
}
```
None of the "txid" or "hash" equals the hash I gave it at first(**f4dedd64c9841d53bbda8beeda52235ec986f1400606812d9c033ac34105532c**) .
* Use **getrawtransaction**(verbose):
```
curl --user yourAuth --data-binary '{"jsonrpc": "1.0","id":"curltest","method":"getrawtransaction", "params": ["f4dedd64c9841d53bbda8beeda52235ec986f1400606812d9c033ac34105532c",true] }' -H 'content-type: text/plain;' http://yourEndPoint
```
This returns :
```
{
"result": {
"txid": "f4dedd64c9841d53bbda8beeda52235ec986f1400606812d9c033ac34105532c",
"hash": "0b637b18840d8fc978a657a3422df3c246c86e4c4046d90e63bf0f86b179b403",
"version": 1,
"size": 223,
"vsize": 142,
"locktime": 0,
"vin": [
{
"txid": "186598dfdfb38f9423384c4e3d220f7963178e1d7c75a058cc7ceed37062a115",
"vout": 1,
"scriptSig": {
"asm": "",
"hex": ""
},
"txinwitness": [
"3044022002537539ac9586fdd8b5947fa0a47dc002ebe57502608433e103efe2740f93d4022023b1ade7bdf0f002a8fdc4ec6d534588d2132ab88850ac426ea413b4adb4652601",
"031ef964af6923a2111e4916afcc87c73a8980322cc761dd3648714dfda99e72c4"
],
"sequence": 4294967295
}
],
"vout": [
{
"value": 0.05648959,
"n": 0,
"scriptPubKey": {
"asm": "OP_HASH160 2915a7db6c6df171fd0436c7cec0042195dad01c OP_EQUAL",
"hex": "a9142915a7db6c6df171fd0436c7cec0042195dad01c87",
"reqSigs": 1,
"type": "scripthash",
"addresses": [
"35SFa5Aev3bjP7gfvfY959GSdWUrSdzoJn"
]
}
},
{
"value": 11.95830840,
"n": 1,
"scriptPubKey": {
"asm": "0 0aad95e932ba045c2daf31a04c36683d39efe910",
"hex": "00140aad95e932ba045c2daf31a04c36683d39efe910",
"reqSigs": 1,
"type": "witness_v0_keyhash",
"addresses": [
"bc1qp2ket6fjhgz9ctd0xxsycdng85u7l6gs2x4dgh"
]
}
}
],
"hex": "0100000000010115a16270d3ee7ccc58a0757c1d8e1763790f223d4e4c3823948fb3dfdf9865180100000000ffffffff023f3256000000000017a9142915a7db6c6df171fd0436c7cec0042195dad01c8738ee4647000000001600140aad95e932ba045c2daf31a04c36683d39efe91002473044022002537539ac9586fdd8b5947fa0a47dc002ebe57502608433e103efe2740f93d4022023b1ade7bdf0f002a8fdc4ec6d534588d2132ab88850ac426ea413b4adb465260121031ef964af6923a2111e4916afcc87c73a8980322cc761dd3648714dfda99e72c400000000",
"blockhash": "00000000000000000011ca3164ee629216de2e5dae09ffb099815319f6e35a71",
"confirmations": 1459,
"time": 1555100160,
"blocktime": 1555100160
},
"error": null,
"id": null
}
```
which has the right transaction Id(txid).
**They were supposed to return the same transaction,at least returns the same txid. Which result is more correct?**
My node info:
```
{
"result": {
"version": 170100,
"subversion": "/Satoshi:0.17.1/",
"protocolversion": 70015,
"localservices": "000000000000040d",
"localrelay": true,
"timeoffset": 10,
"networkactive": true,
"connections": 8,
"networks": [
{
"name": "ipv4",
"limited": false,
"reachable": true,
"proxy": "",
"proxy_randomize_credentials": false
},
{
"name": "ipv6",
"limited": false,
"reachable": true,
"proxy": "",
"proxy_randomize_credentials": false
},
{
"name": "onion",
"limited": true,
"reachable": false,
"proxy": "",
"proxy_randomize_credentials": false
}
],
"relayfee": 0.00001000,
"incrementalfee": 0.00001000,
"localaddresses": [
],
"warnings": ""
},
"error": null,
"id": "curltest"
}
``` | https://github.com/bitcoin/bitcoin/issues/15872 | https://github.com/bitcoin/bitcoin/pull/15899 | fa5c5cd141f0265a5693234690ac757b811157d8 | fa499b5f027f77c0bf13699852c8c06f78e27bef | 2019-04-23T04:09:36Z | c++ | 2019-05-16T19:56:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,865 | ["test/functional/wallet_import_rescan.py"] | Failure in wallet_import_rescan.py | Appveyor build failed for #15849 in https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/23959262:
```
test 2019-04-19T01:01:12.401000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "C:\projects\bitcoin\test\functional\test_framework\test_framework.py", line 175, in main
self.run_test()
File "C:\projects\bitcoin/test/functional/wallet_import_rescan.py", line 185, in run_test
variant.check()
File "C:\projects\bitcoin/test/functional/wallet_import_rescan.py", line 78, in check
assert_equal(len(txs), self.expected_txs)
File "C:\projects\bitcoin\test\functional\test_framework\util.py", line 39, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(1 == 0)
test 2019-04-19T01:01:12.405000Z TestFramework (DEBUG): Closing down network thread
test 2019-04-19T01:01:12.455000Z TestFramework (INFO): Stopping nodes
test 2019-04-19T01:01:12.455000Z TestFramework.node0 (DEBUG): Stopping node
``` | https://github.com/bitcoin/bitcoin/issues/15865 | https://github.com/bitcoin/bitcoin/pull/15866 | 56376f336548b53cf31e98a58dfb4db22cede6e5 | fa465e4da4c7242d7edd6339747572d23a39ff98 | 2019-04-21T23:34:30Z | c++ | 2019-04-22T13:01:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,813 | ["src/init.cpp", "test/functional/p2p_dos_header_tree.py", "test/functional/wallet_crosschain.py"] | Should we check free disk size before syncing blocks | This happens to me that my computer forces qt to exit because my disk is running out of memory
Should we skip syncing or check and show warning beforehand when disk size available is enough for syncing all blocks?
Also wondering how large free disks should I prepare for syncing all the blocks? | https://github.com/bitcoin/bitcoin/issues/15813 | https://github.com/bitcoin/bitcoin/pull/25315 | 256120d2da76e43c53a9fcc4e3a2333fd608a48b | aeb395dcdbfe2b1a6c77ff218939a18afde3add9 | 2019-04-13T22:38:23Z | c++ | 2022-11-18T16:33:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,745 | ["src/bitcoin-cli.cpp", "src/bitcoin-wallet.cpp", "src/bitcoind.cpp", "src/qt/bitcoin.cpp", "src/util/system.cpp", "src/util/system.h", "test/functional/feature_config_args.py"] | unexpected behavior when specify datadir in config file | ## issue sumary
I specificed `datadir` in conf file and run bitcoind with `-conf` option, but data is writing to default `~/.bitcoin` dir , not the dir I want
## steps to reproduce
**bitcoind version 0.17.1**
```
root@MNG-BC ➜ .bitcoin bitcoind --version
Bitcoin Core Daemon version v0.17.1.0-gef70f9b52b851c7997a9f1a0834714e3eebc1fd8
```
### step1: configrations
**bitcoind conf file path `/root/.bitcoin/bitcoin.conf`**
datadir for testnet : **datadir=/mnt/data/bitcoin**
```
# [core]
# Specify the location of the configuration file. To use non-default location, create a default location config file containing this setting.
conf=/root/.bitcoin/bitcoin.conf
# [debug]
# Enable debug logging for all categories.
#debug=1
# Log IP Addresses in debug output.
#logips=1
# Run this node on the Bitcoin Test Network.
#testnet=1
# [rpc]
# Accept command line and JSON-RPC commands.
server=1
# Accept public REST requests.
rest=1
# RPC user
rpcuser=rpcuser
# RPC password
rpcpassword=rpcpass
# RPC allow ip (allow all)
rpcallowip=0.0.0.0/0
# RPC bind
#rpcbind=127.0.0.1
# get all transaction
txindex=1
# [Sections]
# Most options automatically apply to mainnet, testnet, and regtest networks.
# If you want to confine an option to just one network, you should add it in the relevant section.
# EXCEPTIONS: The options addnode, connect, port, bind, rpcport, rpcbind and wallet
# only apply to mainnet unless they appear in the appropriate section below.
# Options only for mainnet
[main]
# datadir
datadir=/mnt/data/bitcoin/mainnet
# Listen for incoming connections on non-default port.(default: 8333 or testnet: 18333)
port=8333
# RPC port(default:8332 or testnet:18332)
rpcport=8332
# Options only for testnet
[test]
# datadir
datadir=/mnt/data/bitcoin
# Listen for incoming connections on non-default port.(default: 8333 or testnet: 18333)
port=18333
# RPC port(default:8332 or testnet:18332)
rpcport=18332
# Options only for regtest
[regtest]
```
### step2 : run bitcoind
run bitcoind with below command
```
bitcoind -conf=/root/.bitcoin/bitcoin.conf -testnet=1
```
### step3 : check the data
expected all the data write to /mnt/data/bitcoin/testnet3
but actually block data is been wroted to /root/.bitcoin/
```
drwx------ 2 root root 4096 Apr 4 16:51 blocks
drwx------ 3 root root 4096 Apr 4 16:51 testnet3
```
more info about the contents in /root/.bitcoin
```
root@MNG-BC ➜ .bitcoin du --max-depth=1 -h
1.1G ./testnet3
4.0K ./blocks
1.1G .
root@MNG-BC ➜ .bitcoin cd testnet3
root@MNG-BC ➜ testnet3 ls
blocks
root@MNG-BC ➜ testnet3 cd blocks
root@MNG-BC ➜ blocks ls
blk00000.dat blk00001.dat blk00002.dat blk00003.dat blk00004.dat blk00005.dat blk00006.dat blk00007.dat index rev00000.dat rev00001.dat rev00002.dat rev00003.dat rev00004.dat rev00005.dat rev00006.dat rev00007.dat
```
## question
Why datadir is not taken effect in conf? Is it a bug or my conf is wrong? Should I specific `-datadir` option in the command line?
| https://github.com/bitcoin/bitcoin/issues/15745 | https://github.com/bitcoin/bitcoin/pull/15864 | 66f5c17f8a3fe06fc65191e379ffc04e43cbbc86 | ffea41f5301d5582665cf10ba5c2b9547a1443de | 2019-04-04T09:18:18Z | c++ | 2019-07-24T16:15:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,743 | ["src/script/descriptor.cpp", "src/script/sign.cpp", "src/script/sign.h", "src/test/descriptor_tests.cpp", "src/wallet/rpcdump.cpp", "test/functional/wallet_importmulti.py"] | getaddressinfo missing key origin information for multisig | When I call
`deriveaddresses "sh(wsh(multi(2,[aeee1e6a/49h/1h/0h]tpubDC5bVdaveQYxGFztMShFAjU637kKjrs9FD8ne1oHR7z8tLeQJExsaxWRVeSpcCcYMdp5ecf2LQhuVaeYFZ7YEpvWTJr4nDGUJrmuvLuTSsp/1/*,[f04973fd/49h/1h/0h]tpubDDSx3fQ8QyVN21PqRwobfAeDnjesTRMG3U6MPs2aUW5tYg9Arhz4tBRiUWTc9VrJBxRVXJqSrULfGs5HJZTqMJC7PBtDGT7cVtsySf76wmS/1/*,[149b5aca/49h/1h/0h]tpubDCCrKqf5e4eiXxRsma3QkcoKbd6MS8zxK5NTfsvNerTPVZcZqFMbn12D3qtWNLUBdxFkRhw2ZToRCMCNQzxG1T8dCVNMRuLwCmUngyf3CbB/1/*)))" 0 1`
I get back the following descriptors from getaddressinfo for the two addresses generated:
`sh(wsh(multi(2,[aeee1e6a/49'/1'/0'/1/0]021387edfa7024c6bced022d8ab95733e38f8fbe4151e28532feb29f8906a4fb5e,[80a9880b]039116115d10440ec1ba2f634e9b7f3b2a3f54dee5b9699501fc58394ddebd62c6,[4f4c39da]03539160098ca953042302cb577ae6103f44f58bd2d093819d3f3c8e267329f99c)))`
`sh(wsh(multi(2,[aeee1e6a/49'/1'/0'/1/1]03789212b1eeae74ea7d2729bedbe72f41e295543c0b8641ed8b883556dddef55f,[6e6574dc]028b4ec07462a0dd937b8d608b5951e8d2f7494145180e0265b17cf02b280d2629,[80b02878]0212a0f24ccc397b5bef557a3270b6c2cfb148fd726e4cdb417ef5c7655dd31838)))`
It looks like all three "*" path elements are incrementing together, correctly, but the key origin information is lost for the second and third ones. | https://github.com/bitcoin/bitcoin/issues/15743 | https://github.com/bitcoin/bitcoin/pull/15749 | 6e597001a4fc1ba837f3f23cfd7f2d65c3d58104 | b5d39877242504160a7f2c24c60c07a845d7a064 | 2019-04-04T01:35:53Z | c++ | 2019-04-06T16:14:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,742 | ["src/script/descriptor.cpp", "src/script/sign.cpp", "src/script/sign.h", "src/test/descriptor_tests.cpp", "src/wallet/rpcdump.cpp", "test/functional/wallet_importmulti.py"] | importmulti falsely warns private keys present when importing descriptor | Command:
`importmulti '[{"desc": "sh(wsh(multi(2,[aeee1e6a/49h/1h/0h]tpubDC5bVdaveQYxGFztMShFAjU637kKjrs9FD8ne1oHR7z8tLeQJExsaxWRVeSpcCcYMdp5ecf2LQhuVaeYFZ7YEpvWTJr4nDGUJrmuvLuTSsp/1/*,[f04973fd/49h/1h/0h]tpubDDSx3fQ8QyVN21PqRwobfAeDnjesTRMG3U6MPs2aUW5tYg9Arhz4tBRiUWTc9VrJBxRVXJqSrULfGs5HJZTqMJC7PBtDGT7cVtsySf76wmS/1/*,[149b5aca/49h/1h/0h]tpubDCCrKqf5e4eiXxRsma3QkcoKbd6MS8zxK5NTfsvNerTPVZcZqFMbn12D3qtWNLUBdxFkRhw2ZToRCMCNQzxG1T8dCVNMRuLwCmUngyf3CbB/1/*)))", "keypool": true, "timestamp": "now", "watchonly": true, "internal": true, "range": {"end": 100}}]' '{"rescan": false}'`
Result:
```
[
{
"success": true,
"warnings": [
"All private keys are provided, outputs will be considered spendable. If this is intentional, do not specify the watchonly flag."
]
}
]
```
And according to getdescriptoinfo:
`getdescriptorinfo "sh(wsh(multi(2,[aeee1e6a/49h/1h/0h]tpubDC5bVdaveQYxGFztMShFAjU637kKjrs9FD8ne1oHR7z8tLeQJExsaxWRVeSpcCcYMdp5ecf2LQhuVaeYFZ7YEpvWTJr4nDGUJrmuvLuTSsp/1/*,[f04973fd/49h/1h/0h]tpubDDSx3fQ8QyVN21PqRwobfAeDnjesTRMG3U6MPs2aUW5tYg9Arhz4tBRiUWTc9VrJBxRVXJqSrULfGs5HJZTqMJC7PBtDGT7cVtsySf76wmS/1/*,[149b5aca/49h/1h/0h]tpubDCCrKqf5e4eiXxRsma3QkcoKbd6MS8zxK5NTfsvNerTPVZcZqFMbn12D3qtWNLUBdxFkRhw2ZToRCMCNQzxG1T8dCVNMRuLwCmUngyf3CbB/1/*)))"`
```
{
"descriptor": "sh(wsh(multi(2,[aeee1e6a/49'/1'/0']tpubDC5bVdaveQYxGFztMShFAjU637kKjrs9FD8ne1oHR7z8tLeQJExsaxWRVeSpcCcYMdp5ecf2LQhuVaeYFZ7YEpvWTJr4nDGUJrmuvLuTSsp/1/*,[f04973fd/49'/1'/0']tpubDDSx3fQ8QyVN21PqRwobfAeDnjesTRMG3U6MPs2aUW5tYg9Arhz4tBRiUWTc9VrJBxRVXJqSrULfGs5HJZTqMJC7PBtDGT7cVtsySf76wmS/1/*,[149b5aca/49'/1'/0']tpubDCCrKqf5e4eiXxRsma3QkcoKbd6MS8zxK5NTfsvNerTPVZcZqFMbn12D3qtWNLUBdxFkRhw2ZToRCMCNQzxG1T8dCVNMRuLwCmUngyf3CbB/1/*)))#sddrjdjm",
"isrange": true,
"issolvable": true,
"hasprivatekeys": false
}
``` | https://github.com/bitcoin/bitcoin/issues/15742 | https://github.com/bitcoin/bitcoin/pull/15749 | 6e597001a4fc1ba837f3f23cfd7f2d65c3d58104 | b5d39877242504160a7f2c24c60c07a845d7a064 | 2019-04-04T01:28:11Z | c++ | 2019-04-06T16:14:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,739 | ["src/wallet/db.cpp", "src/wallet/rpcdump.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h", "src/wallet/walletdb.h"] | large ranged descriptor imports are sloooooooooow. | Performing the following (note the range of 10,000):
`importmulti '[{"desc": "sh(wpkh([aeee1e6a/49h/1h/0h]tpubDC5bVdaveQYxGFztMShFAjU637kKjrs9FD8ne1oHR7z8tLeQJExsaxWRVeSpcCcYMdp5ecf2LQhuVaeYFZ7YEpvWTJr4nDGUJrmuvLuTSsp/1/*))", "keypool": true, "timestamp": "now", "watchonly": true, "internal": true, "range": {"end": 1000}}]' '{"rescan": false}'`
takes many minutes. @achow101 reports a similar import taking 6 minutes on his machine. | https://github.com/bitcoin/bitcoin/issues/15739 | https://github.com/bitcoin/bitcoin/pull/15741 | 6cb888b37d7022fbcf5b9c88a8d4f19454f32699 | 0db94e55dcbbfc741df463c404818d9033b4fff1 | 2019-04-03T22:32:48Z | c++ | 2019-05-28T15:03:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,738 | [".travis.yml", ".travis/lint_06_script.sh", "doc/README.md", "doc/travis-ci.md"] | "Travis early exit to cache current state" message unclear | It's unclear what "Travis early exit to cache current state" errors in travis output signify. They seem to be triggered when something times out, but it's unclear if this is an error, or an expected condition or has something to do with a cache?
I think we can probably change the message to make it more clear and obvious, whatever it means. | https://github.com/bitcoin/bitcoin/issues/15738 | https://github.com/bitcoin/bitcoin/pull/15693 | fa36a333eedc0116b88f0dcf62be923e8da98782 | fa2056af1c71aded3a821a07ec4de71c4be0bca3 | 2019-04-03T22:15:33Z | c++ | 2019-04-05T17:35:27Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,737 | ["src/rpc/util.cpp"] | importtmulti help text typo | The importmulti help text reads, in part:
```
{ (json object) If a ranged descriptor is used, this specifies the start and end of the range to import
"start": n, (numeric, optional, default=0) Start of the range to import
"end": n, (numeric, required) End of the range to import (inclusive)
},
```
This is a value for which a key is missing; it should be "range": { ... | https://github.com/bitcoin/bitcoin/issues/15737 | https://github.com/bitcoin/bitcoin/pull/15746 | fa652b229eeb22ed742f8790fac5e41302e6012d | fa26eb5e8f3b0843739d404630913006385505ae | 2019-04-03T22:14:55Z | c++ | 2019-04-04T14:49:09Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,733 | ["test/functional/test_framework/util.py"] | test failed with ".cookie" not found | Error thrown once:
```
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/test_runner_\u20bf_🏃_20190403_152618/wallet_multiwallet_75/node0/regtest/.cookie'
```
In https://travis-ci.org/bitcoin/bitcoin/jobs/515252355#L4924 | https://github.com/bitcoin/bitcoin/issues/15733 | https://github.com/bitcoin/bitcoin/pull/15771 | a238fccce84bcd5544e88bdc37bf5b9b387d2164 | 90bce24576a52c9f3aacfa59f44443eb5328dda0 | 2019-04-03T21:04:36Z | c++ | 2019-04-09T13:28:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,731 | ["src/rpc/server.cpp"] | Add getrpcinfo doc | https://github.com/bitcoin/bitcoin/issues/15555#issuecomment-479346264 | https://github.com/bitcoin/bitcoin/issues/15731 | https://github.com/bitcoin/bitcoin/pull/15754 | c83442e17412b96f00bc29d30763b28184c95f1e | f4b7a2f2055fa52d5e02c37bed7b46599b960e2e | 2019-04-03T17:18:21Z | c++ | 2019-04-05T07:04:34Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,724 | ["doc/release-notes-15730.md", "src/wallet/rpcwallet.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h"] | [feature] getrpcinfo should report rescan progress | The new `getrpcinfo` shows a list of the active commands and the duration each command has been running. This sounds like a good place to report a completion percentage for any command doing a blockchain rescan, to solve [this problem](https://bitcoin.stackexchange.com/q/83236/90721). | https://github.com/bitcoin/bitcoin/issues/15724 | https://github.com/bitcoin/bitcoin/pull/15730 | d3e8458365ab29017241bc43204fe81cb7fd8530 | b6c748f84909212dce73e4b77aa125ed1e108a10 | 2019-04-03T05:44:21Z | c++ | 2019-05-02T10:39:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,701 | ["src/rpc/rawtransaction.cpp", "src/wallet/rpcwallet.cpp", "test/functional/rpc_psbt.py"] | converttopsbt succeeds for tx with signatures | Steps to reproduce on regtest:
```
converttopsbt 02000000000101ab73dba46508bacdb49a988ddd74bc9d39c9cb7e057af060ca8c6b6861e28e3c0300000000feffffff02b828d0b20000000017a914d1954862afd728fbb055149002958e1d1b9e1f0b8700ca9a3b0000000017a91442170ccb3441cff1723af9afab6f2553103e1d578702473044022077380c6e16496d9905aef120694c329be51522847cb5d53fa74b94698c95678d02202d32c46e0e17420a83dee830fefda7d40529182f5d82be47c2b49a7b83214ab50121026d483d6628dcc3ef6e3ab9ed4937c452c263c7e0ac80eb4be97426d5da8f640500000000
```
or
```
converttopsbt 02000000000101ab73dba46508bacdb49a988ddd74bc9d39c9cb7e057af060ca8c6b6861e28e3c0300000000feffffff02b828d0b20000000017a914d1954862afd728fbb055149002958e1d1b9e1f0b8700ca9a3b0000000017a91442170ccb3441cff1723af9afab6f2553103e1d578702473044022077380c6e16496d9905aef120694c329be51522847cb5d53fa74b94698c95678d02202d32c46e0e17420a83dee830fefda7d40529182f5d82be47c2b49a7b83214ab50121026d483d6628dcc3ef6e3ab9ed4937c452c263c7e0ac80eb4be97426d5da8f640500000000 false
```
Further reading: #13738 | https://github.com/bitcoin/bitcoin/issues/15701 | https://github.com/bitcoin/bitcoin/pull/15899 | fa5c5cd141f0265a5693234690ac757b811157d8 | fa499b5f027f77c0bf13699852c8c06f78e27bef | 2019-03-29T21:23:45Z | c++ | 2019-05-16T19:56:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,698 | ["src/init.cpp", "src/ui_interface.cpp", "src/ui_interface.h"] | CClientUIInterface::[signal_name]_disconnect is a no-op | From what I can tell `CClientUIInterface::[signal_name]_disconnect` is a no-op.
In other words calling it does *not* disconnect the slot:
For example `uiInterface.NotifyBlockTip_disconnect(BlockNotifyGenesisWait);` in `AppInitMain(...)` does not disconnect `BlockNotifyGenesisWait` as one would expect. The result being that `BlockNotifyGenesisWait` is invoked for every new block :-)
Running `bitcoind` with some debug printing added shows the issue:
```
[signals] CClientUIInterface::ThreadSafeMessageBox_connect(...) entered with 0 connected slots.
[signals] CClientUIInterface::ThreadSafeMessageBox_connect(...) exited with 1 connected slots.
[signals] CClientUIInterface::ThreadSafeQuestion_connect(...) entered with 0 connected slots.
[signals] CClientUIInterface::ThreadSafeQuestion_connect(...) exited with 1 connected slots.
[signals] CClientUIInterface::InitMessage_connect(...) entered with 0 connected slots.
[signals] CClientUIInterface::InitMessage_connect(...) exited with 1 connected slots.
[signals] CClientUIInterface::InitMessage_connect(...) entered with 1 connected slots.
[signals] CClientUIInterface::InitMessage_connect(...) exited with 2 connected slots.
[signals] Calling uiInterface.NotifyBlockTip_connect(&RPCNotifyBlockChange) in OnRPCStarted()
[signals] CClientUIInterface::NotifyBlockTip_connect(...) entered with 0 connected slots.
[signals] CClientUIInterface::NotifyBlockTip_connect(...) exited with 1 connected slots.
[signals] Calling uiInterface.NotifyBlockTip_connect(BlockNotifyGenesisWait) in AppInitMain(...)
[signals] CClientUIInterface::NotifyBlockTip_connect(...) entered with 1 connected slots.
[signals] CClientUIInterface::NotifyBlockTip_connect(...) exited with 2 connected slots.
[signals] RPCNotifyBlockChange(...) was invoked.
[signals] BlockNotifyGenesisWait(...) was invoked.
[signals] Calling uiInterface.NotifyBlockTip_disconnect(BlockNotifyGenesisWait) in AppInitMain(...)
[signals] CClientUIInterface::NotifyBlockTip_disconnect(...) entered with 2 connected slots.
[signals] CClientUIInterface::NotifyBlockTip_disconnect(...) exited with 2 connected slots.
[signals] RPCNotifyBlockChange(...) was invoked.
[signals] BlockNotifyGenesisWait(...) was invoked.
[signals] RPCNotifyBlockChange(...) was invoked.
[signals] BlockNotifyGenesisWait(...) was invoked.
[signals] RPCNotifyBlockChange(...) was invoked.
[signals] BlockNotifyGenesisWait(...) was invoked.
... and so on ...
```
Note how `BlockNotifyGenesisWait(...)` is called also after `uiInterface.NotifyBlockTip_disconnect(BlockNotifyGenesisWait)`.
I think the problem is that the `disconnect(...)` member function of `boost::signals2::signal` expects a function pointer to be passed in (the same that was passed to `.connect(...)`), but we're doing:
```
void CClientUIInterface::signal_name##_disconnect(std::function<signal_name##Sig> fn)
{
return g_ui_signals.signal_name.disconnect(&fn);
}
``` | https://github.com/bitcoin/bitcoin/issues/15698 | https://github.com/bitcoin/bitcoin/pull/15699 | 0baf4b1f96635cdf5f26b36753321fe3ea40d4a8 | 6dd469a3bea60d8857ec0be625c2ef8a7716c148 | 2019-03-29T18:02:50Z | c++ | 2019-03-29T18:34:53Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,688 | ["build-aux/m4/bitcoin_qt.m4", "configure.ac"] | Configure should return an error with not supported versions of QT libraries | While configuring with a non-supported version of QT libraries, configure should exit with an error.
Environment:
```
$ git log --oneline -1
9e7dc68 Merge #15616: rpc: Clarify decodescript RPCResult doc
$ ls /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.3.2
/usr/lib/x86_64-linux-gnu/libQt5Gui.so.5.3.2
$ /usr/lib/x86_64-linux-gnu/qt5/bin/moc --version
moc 5.3.2
$ uname -srv
Linux 4.9.0-0.bpo.7-amd64 #1 SMP Debian 4.9.110-3+deb9u2~deb8u1 (2018-08-14)
```
Steps to replicate:
```
$ ./autogen.sh
$ ./configure --with-incompatible-bdb >/dev/null 2>/dev/null && echo OK
OK
```
Expected behavior: configure should exit with an error due to version of QT libraries not supported.
Details:
```
$ ./configure --with-incompatible-bdb | grep -i qt
configure: WARNING: Found Berkeley DB other than 4.8; wallets opened by this build will not be portable!
checking for QT5... yes
checking for QT_TEST... yes
checking for QT_DBUS... yes
checking for static Qt... no
checking whether -fPIE can be used with this Qt config... no
checking for moc-qt5... no
checking for moc... /usr/lib/x86_64-linux-gnu/qt5/bin/moc
checking for uic-qt5... no
checking for uic... /usr/lib/x86_64-linux-gnu/qt5/bin/uic
checking for rcc-qt5... no
checking for rcc... /usr/lib/x86_64-linux-gnu/qt5/bin/rcc
checking for lrelease-qt5... no
checking for lrelease... /usr/lib/x86_64-linux-gnu/qt5/bin/lrelease
checking for lupdate-qt5... no
checking for lupdate... /usr/lib/x86_64-linux-gnu/qt5/bin/lupdate
checking whether to build Bitcoin Core GUI... yes (Qt5)
configure: WARNING: libzmq version 4.x or greater not found, disabling
checking whether to build test_bitcoin-qt... yes
config.status: creating share/qt/Info.plist
with gui / qt = yes
``` | https://github.com/bitcoin/bitcoin/issues/15688 | https://github.com/bitcoin/bitcoin/pull/19689 | 197450f80868fe752c6107955e5da80704212b34 | 38c13a4a6055c0e5af37475fbaae8e41ae26b64f | 2019-03-28T18:02:04Z | c++ | 2020-08-24T04:14:18Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,667 | ["src/qt/sendcoinsdialog.cpp", "src/qt/sendcoinsdialog.h"] | Transaction confirmation prompt too big - buttons not clickable | _Second try - first issue got deleted suddenly..._
When confirming too big transactions, depending on screen resolution with each output the buttons move lower and lower until they are not visible anymore on the screen.
Additionally randomly after a couple transactions the client starts to repeat its content in the confirmation prompt making even the smalest 1:1 transaction unusable as the buttons are not visible, again. (See screenshot)
I (A) would expect that the buttons are visible no matter how big the transaction content is (for example by making the content scrollable) and (B) don't understand why the content is repeating suddenly.
Using Bitcoin Knots 17 but have been directed by the developers that the issue belongs to bitcoin/bitcoin
Windows 10
1920x1080
Intel i7 | https://github.com/bitcoin/bitcoin/issues/15667 | https://github.com/bitcoin/bitcoin/pull/15886 | 2ee756f0411c467fc638373ea68d6cb5ced46974 | 78f9b5160fea32f85c6ced16b3b0cccda6d3b181 | 2019-03-26T14:32:39Z | c++ | 2019-05-18T19:22:05Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.