status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,635 | ["src/wallet/rpcwallet.cpp", "test/functional/wallet_createwallet.py"] | [wallet] encryptwallet should fail for watch-only wallet | Create a wallet as follows:
```sh
$ bitcoin-cli createwallet "watchonly" true
$ bitcoin-cli -rpcwallet=watchonly getwalletinfo
{
...
"private_keys_enabled": false
}
```
The following should fail, but doesn't:
```sh
$ bitcoin-cli -rpcwallet=watchonly encryptwallet 1234
wallet encrypted; The keypool has been flushed and a new HD seed was generated (if you are using HD). You need to make a new backup.
```
It partially fails silently, because it doesn't actually add a seed. But it does ask for a password when calling `dumpwallet`, which doesn't make sense because we currently don't encrypt anything other than private keys. | https://github.com/bitcoin/bitcoin/issues/15635 | https://github.com/bitcoin/bitcoin/pull/16144 | d3a1c2502bb19d667c692937784fe027fd8d32da | 7860c98bd59cd8f56e9b2b4ae45265c046e7cfd9 | 2019-03-21T16:21:00Z | c++ | 2019-06-04T13:39:34Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,630 | ["src/wallet/init.cpp"] | -wallet is a "network-only" option but -walletdir is not | Any reason for this?
https://github.com/bitcoin/bitcoin/blob/2d46f1be0c3c8b7287aa1f62bb1f5b4a8d00ff6e/src/util/system.cpp#L316-L326 | https://github.com/bitcoin/bitcoin/issues/15630 | https://github.com/bitcoin/bitcoin/pull/17447 | 80fdb6fad132166b10fbeb8615e3c5c591209e0b | 3c2c439dcd8797019ac6d6614775d5c20ee41c36 | 2019-03-20T20:48:47Z | c++ | 2019-11-12T00:16:17Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,624 | ["src/util/system.cpp"] | flatfile_tests fail on alpine linux | File size checks fails and I haven't figured out why, but next I'd look into how `posix_fallocate` works on alpine linux.
Log:
```
$ cat /etc/alpine-release
3.9.2
$ git log --oneline -1
e45b7f20e Merge #15618: refactor: Remove unused function
$ ./src/test/test_bitcoin -t flatfile_tests
Running 4 test cases...
Version using posix_fallocate
test/flatfile_tests.cpp(94): error: in "flatfile_tests/flatfile_allocate": check fs::file_size(seq.FileName(FlatFilePos(0, 0))) == 100 has failed [0 != 100]
test/flatfile_tests.cpp(98): error: in "flatfile_tests/flatfile_allocate": check fs::file_size(seq.FileName(FlatFilePos(0, 99))) == 100 has failed [0 != 100]
Version using posix_fallocate
test/flatfile_tests.cpp(102): error: in "flatfile_tests/flatfile_allocate": check fs::file_size(seq.FileName(FlatFilePos(0, 99))) == 200 has failed [0 != 200]
Version using posix_fallocate
test/flatfile_tests.cpp(116): error: in "flatfile_tests/flatfile_flush": check fs::file_size(seq.FileName(FlatFilePos(0, 1))) == 100 has failed [0 != 100]
*** 4 failures are detected in the test module "Bitcoin Core Test Suite"
``` | https://github.com/bitcoin/bitcoin/issues/15624 | https://github.com/bitcoin/bitcoin/pull/15650 | 7b13c646457980f44599412f243694fa682a1abf | 5d35ae3326624da3fe5dcb4047c9a7cec6665cab | 2019-03-20T01:59:01Z | c++ | 2019-03-23T20:35:24Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,619 | ["src/interfaces/chain.cpp", "src/interfaces/chain.h", "src/net_processing.cpp", "src/validationinterface.cpp", "src/validationinterface.h", "src/wallet/init.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h", "test/functional/wallet_resendwallettransactions.py"] | Remove `Broadcast`/`ResendWalletTransactions` from validation interface | The `Broadcast`/`ResendWalletTransactions` interface is strange:
- it's the node saying to the wallet "Try to submit your unconfirmed transactions to the mempool again"
- it's called in one place by the node, in `SendMessages()` here: https://github.com/bitcoin/bitcoin/blob/c033c4b5cef89a654e4d9d5c5f9bd823871b068b/src/net_processing.cpp#L3515. `SendMessages()` is called on the message handling thread on a loop.
- the actual scheduling of when the wallet sends messages is handled in the `ResendWalletTransactions()` function itself, using the `nNextResend` and `nLastResend` wallet globals (which could as easily be static variables in `ResendWalletTransactions()`).
Therefore the only use of `Broadcast()` is to periodically prod the wallet. The wallet itself decides whether it's time to resend transactions. This could be done by scheduling regular calls to `ResendWalletTransactions()`, in the same way that we schedule regular wallet flushes here: https://github.com/bitcoin/bitcoin/blob/c033c4b5cef89a654e4d9d5c5f9bd823871b068b/src/wallet/init.cpp#L215.
A couple of minor implementation details:
- the call to `Broadcast()` in `SendMessages()` is protected by an if statement `if (!fReindex && !fImporting && !IsInitialBlockDownload()) {`. Those tests could be moved into `ResendWalletTransactions()` (through the `Chain` interface).
- The `Broadcast` notification passes in the `nTimeBestReceived` time of the best block. That could be fetched by `ResendWalletTransactions()` through the `Chain` interface. | https://github.com/bitcoin/bitcoin/issues/15619 | https://github.com/bitcoin/bitcoin/pull/15632 | 52b760fc6a9b26e405a0553ee8285b0f03ca1604 | 833d98ae073daf0f25f786f043f2ffa85155c8ff | 2019-03-18T17:58:16Z | c++ | 2019-04-09T14:38:28Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,612 | ["src/httpserver.cpp", "src/init.cpp", "src/warnings.cpp"] | Reduce the number of global symbols used | The `bitcoind` binary contains more than 79 global symbols as reported by `nm` (in the BSS data section and initialized data section, somewhat filtered - see oneliner below):
```
$ for SYMBOL in $(nm src/bitcoind | grep -E ' [BD] ' | c++filt | cut -f3- -d' ' | grep -v @ | grep -v : | sort | grep '[a-z]' | sort -u | grep -vE '^_'); do
REFERENCES=$(git grep -lE "([^a-zA-Z]|^)${SYMBOL}([^a-zA-Z]|\$)" -- "*.cpp" "*.h")
N_REFERENCES=$(wc -l <<< "${REFERENCES}")
echo -n "Found ${N_REFERENCES} use(s) of ${SYMBOL}: "
sort -u <<< "${REFERENCES}" | tr "\n" " "
echo
done
Found 1 use(s) of boundSockets: src/httpserver.cpp
Found 25 use(s) of chainActive: src/bench/block_assemble.cpp src/bench/duplicate_inputs.cpp src/index/base.cpp src/index/txindex.cpp src/init.cpp src/interfaces/chain.cpp src/interfaces/node.cpp src/miner.cpp src/net_processing.cpp src/policy/fees.cpp src/qt/test/wallettests.cpp src/rest.cpp src/rpc/blockchain.cpp src/rpc/mining.cpp src/rpc/rawtransaction.cpp src/test/denialofservice_tests.cpp src/test/miner_tests.cpp src/test/test_bitcoin.cpp src/test/txvalidationcache_tests.cpp src/test/validation_block_tests.cpp src/txmempool.h src/validation.cpp src/validation.h src/wallet/test/wallet_tests.cpp src/wallet/wallet.cpp
Found 43 use(s) of cs_main: src/bench/block_assemble.cpp src/bench/duplicate_inputs.cpp src/bench/mempool_eviction.cpp src/bench/rpc_mempool.cpp src/index/base.cpp src/index/txindex.cpp src/init.cpp src/interfaces/chain.cpp src/interfaces/node.cpp src/interfaces/wallet.cpp src/miner.cpp src/net.h src/net_processing.cpp src/net_processing.h src/node/transaction.cpp src/qt/clientmodel.cpp src/qt/peertablemodel.cpp src/rest.cpp src/rpc/blockchain.cpp src/rpc/mining.cpp src/rpc/misc.cpp src/rpc/net.cpp src/rpc/rawtransaction.cpp src/test/blockencodings_tests.cpp src/test/denialofservice_tests.cpp src/test/mempool_tests.cpp src/test/miner_tests.cpp src/test/policyestimator_tests.cpp src/test/script_p2sh_tests.cpp src/test/test_bitcoin.cpp src/test/transaction_tests.cpp src/test/txvalidationcache_tests.cpp src/test/txvalidation_tests.cpp src/test/validation_block_tests.cpp src/txmempool.h src/validation.cpp src/validation.h src/validationinterface.cpp src/validationinterface.h src/wallet/test/wallet_tests.cpp src/wallet/wallet.cpp src/wallet/wallet.h src/zmq/zmqpublishnotifier.cpp
Found 4 use(s) of cs_mapLocalHost: src/net.cpp src/net.h src/rpc/net.cpp src/test/net_tests.cpp
Found 1 use(s) of cs_warnings: src/warnings.cpp
Found 7 use(s) of dustRelayFee: src/init.cpp src/interfaces/node.cpp src/policy/policy.cpp src/policy/policy.h src/test/transaction_tests.cpp src/wallet/fees.cpp src/wallet/wallet.cpp
Found 1 use(s) of eventHTTP: src/httpserver.cpp
Found 4 use(s) of fAcceptDatacarrier: src/init.cpp src/policy/policy.cpp src/script/standard.cpp src/script/standard.h
Found 4 use(s) of fCheckBlockIndex: src/init.cpp src/test/test_bitcoin.cpp src/validation.cpp src/validation.h
Found 4 use(s) of fCheckpointsEnabled: src/init.cpp src/test/miner_tests.cpp src/validation.cpp src/validation.h
Found 3 use(s) of fDiscover: src/init.cpp src/net.cpp src/net.h
Found 6 use(s) of feeEstimator: src/init.cpp src/interfaces/chain.cpp src/interfaces/node.cpp src/rpc/mining.cpp src/validation.cpp src/validation.h
Found 3 use(s) of fEnableReplacement: src/init.cpp src/validation.cpp src/validation.h
Found 1 use(s) of fFeeEstimatesInitialized: src/init.cpp
Found 3 use(s) of fHavePruned: src/init.cpp src/validation.cpp src/validation.h
Found 5 use(s) of fImporting: src/init.cpp src/interfaces/node.cpp src/net_processing.cpp src/validation.cpp src/validation.h
Found 4 use(s) of fIsBareMultisigStd: src/init.cpp src/policy/policy.cpp src/validation.cpp src/validation.h
Found 1 use(s) of fLargeWorkForkFound: src/warnings.cpp
Found 1 use(s) of fLargeWorkInvalidChainFound: src/warnings.cpp
Found 5 use(s) of fListen: src/init.cpp src/net.cpp src/net.h src/net_processing.cpp src/qt/optionsmodel.cpp
Found 6 use(s) of fLogIPs: src/init.cpp src/logging.cpp src/logging.h src/net.cpp src/net_processing.cpp src/rpc/server.cpp
Found 4 use(s) of fNameLookup: src/init.cpp src/netbase.cpp src/netbase.h src/net.cpp
Found 6 use(s) of fPruneMode: src/init.cpp src/interfaces/chain.cpp src/net_processing.cpp src/rpc/blockchain.cpp src/validation.cpp src/validation.h
Found 5 use(s) of fReindex: src/init.cpp src/interfaces/node.cpp src/net_processing.cpp src/validation.cpp src/validation.h
Found 5 use(s) of fRelayTxes: src/init.cpp src/net.cpp src/net.h src/net_processing.cpp src/rpc/net.cpp
Found 5 use(s) of fRequireStandard: src/chainparams.cpp src/chainparams.h src/init.cpp src/validation.cpp src/validation.h
Found 51 use(s) of gArgs: src/bench/bench_bitcoin.cpp src/bitcoin-cli.cpp src/bitcoind.cpp src/bitcoin-tx.cpp src/bitcoin-wallet.cpp src/chainparamsbase.cpp src/chainparams.cpp src/dbwrapper.cpp src/dummywallet.cpp src/httprpc.cpp src/httpserver.cpp src/init.cpp src/init.h src/interfaces/chain.cpp src/interfaces/node.cpp src/miner.cpp src/net.cpp src/net_processing.cpp src/qt/bitcoin.cpp src/qt/guiutil.cpp src/qt/intro.cpp src/qt/optionsmodel.cpp src/qt/paymentrequestplus.cpp src/qt/paymentserver.cpp src/qt/test/test_main.cpp src/qt/utilitydialog.cpp src/qt/walletmodel.cpp src/rpc/blockchain.cpp src/rpc/protocol.cpp src/rpc/server.cpp src/script/sigcache.cpp src/test/denialofservice_tests.cpp src/test/getarg_tests.cpp src/test/net_tests.cpp src/test/test_bitcoin.cpp src/timedata.cpp src/torcontrol.cpp src/txdb.cpp src/util/system.cpp src/util/system.h src/validation.cpp src/wallet/coincontrol.cpp src/wallet/db.cpp src/wallet/feebumper.cpp src/wallet/init.cpp src/wallet/test/init_test_fixture.cpp src/wallet/test/init_tests.cpp src/wallet/wallet.cpp src/wallet/walletdb.cpp src/wallet/walletutil.cpp src/zmq/zmqnotificationinterface.cpp
Found 6 use(s) of g_banman: src/banman.h src/init.cpp src/interfaces/node.cpp src/net.h src/rpc/net.cpp src/test/test_bitcoin.cpp
Found 4 use(s) of g_best_block: src/init.cpp src/rpc/mining.cpp src/validation.cpp src/validation.h
Found 4 use(s) of g_best_block_cv: src/init.cpp src/rpc/mining.cpp src/validation.cpp src/validation.h
Found 3 use(s) of g_best_block_mutex: src/rpc/mining.cpp src/validation.cpp src/validation.h
Found 1 use(s) of g_chainstate: src/validation.cpp
Found 8 use(s) of g_connman: src/init.cpp src/interfaces/chain.cpp src/interfaces/node.cpp src/net.h src/node/transaction.cpp src/rpc/mining.cpp src/rpc/net.cpp src/test/test_bitcoin.cpp
Found 3 use(s) of g_cs_orphans: src/net.h src/net_processing.cpp src/test/denialofservice_tests.cpp
Found 4 use(s) of g_is_mempool_loaded: src/init.cpp src/rpc/blockchain.cpp src/validation.cpp src/validation.h
Found 4 use(s) of g_mock_deterministic_tests: src/random.cpp src/test/bloom_tests.cpp src/test/random_tests.cpp src/test/test_bitcoin.h
Found 6 use(s) of g_rpc_interfaces: src/init.cpp src/rpc/rawtransaction.cpp src/rpc/util.cpp src/rpc/util.h src/test/rpc_tests.cpp src/wallet/rpcwallet.cpp
Found 7 use(s) of g_txindex: src/index/txindex.cpp src/index/txindex.h src/init.cpp src/rest.cpp src/rpc/blockchain.cpp src/rpc/rawtransaction.cpp src/validation.cpp
Found 1 use(s) of g_ui_signals: src/ui_interface.cpp
Found 5 use(s) of g_wallet_init_interface: src/dummywallet.cpp src/httprpc.cpp src/init.cpp src/wallet/init.cpp src/walletinitinterface.h
Found 4 use(s) of g_zmq_notification_interface: src/init.cpp src/zmq/zmqnotificationinterface.cpp src/zmq/zmqnotificationinterface.h src/zmq/zmqrpc.cpp
Found 3 use(s) of hashAssumeValid: src/init.cpp src/validation.cpp src/validation.h
Found 8 use(s) of incrementalRelayFee: src/init.cpp src/policy/policy.cpp src/policy/policy.h src/rpc/net.cpp src/txmempool.cpp src/txmempool.h src/validation.cpp src/wallet/feebumper.cpp
Found 1 use(s) of instance_of_cmaincleanup: src/validation.cpp
Found 1 use(s) of instance_of_cnetcleanup: src/net.cpp
Found 1 use(s) of instance_of_cnetprocessingcleanup: src/net_processing.cpp
Found 8 use(s) of mapBlockIndex: src/init.cpp src/interfaces/wallet.cpp src/net_processing.cpp src/rpc/blockchain.cpp src/txdb.cpp src/validation.cpp src/validation.h src/wallet/test/wallet_tests.cpp
Found 4 use(s) of mapLocalHost: src/net.cpp src/net.h src/rpc/net.cpp src/test/net_tests.cpp
Found 2 use(s) of mapOrphanTransactions: src/net_processing.cpp src/test/denialofservice_tests.cpp
Found 11 use(s) of maxTxFee: src/init.cpp src/interfaces/chain.cpp src/interfaces/chain.h src/interfaces/node.cpp src/qt/walletmodel.cpp src/rpc/rawtransaction.cpp src/validation.cpp src/validation.h src/wallet/feebumper.cpp src/wallet/fees.cpp src/wallet/wallet.cpp
Found 55 use(s) of mempool: src/bench/block_assemble.cpp src/bench/mempool_eviction.cpp src/blockencodings.cpp src/blockencodings.h src/init.cpp src/interfaces/chain.cpp src/interfaces/chain.h src/interfaces/node.cpp src/interfaces/node.h src/interfaces/wallet.cpp src/interfaces/wallet.h src/logging.cpp src/miner.cpp src/miner.h src/net.h src/net_processing.cpp src/node/transaction.cpp src/policy/fees.cpp src/policy/fees.h src/policy/policy.h src/policy/rbf.cpp src/policy/rbf.h src/protocol.cpp src/protocol.h src/qt/bitcoinstrings.cpp src/qt/coincontroldialog.cpp src/qt/rpcconsole.h src/qt/test/rpcnestedtests.cpp src/qt/transactionrecord.h src/rest.cpp src/rpc/blockchain.cpp src/rpc/client.cpp src/rpc/mining.cpp src/rpc/misc.cpp src/rpc/net.cpp src/rpc/rawtransaction.cpp src/test/blockencodings_tests.cpp src/test/mempool_tests.cpp src/test/miner_tests.cpp src/test/policyestimator_tests.cpp src/test/test_bitcoin.cpp src/test/txvalidationcache_tests.cpp src/test/txvalidation_tests.cpp src/txmempool.cpp src/txmempool.h src/validation.cpp src/validation.h src/validationinterface.h src/wallet/feebumper.cpp src/wallet/feebumper.h src/wallet/fees.cpp src/wallet/init.cpp src/wallet/rpcwallet.cpp src/wallet/wallet.cpp src/wallet/wallet.h
Found 11 use(s) of minRelayTxFee: src/init.cpp src/net_processing.cpp src/policy/policy.h src/rpc/blockchain.cpp src/rpc/net.cpp src/validation.cpp src/validation.h src/wallet/fees.cpp src/wallet/init.cpp src/wallet/rpcwallet.cpp src/wallet/wallet.cpp
Found 3 use(s) of nBytesPerSigOp: src/init.cpp src/policy/policy.cpp src/policy/policy.h
Found 3 use(s) of nCoinCacheUsage: src/init.cpp src/validation.cpp src/validation.h
Found 4 use(s) of nConnectTimeout: src/init.cpp src/netbase.cpp src/netbase.h src/net.cpp
Found 4 use(s) of nMaxDatacarrierBytes: src/init.cpp src/policy/policy.cpp src/script/standard.cpp src/script/standard.h
Found 3 use(s) of nMaxTipAge: src/init.cpp src/validation.cpp src/validation.h
Found 6 use(s) of nMinimumChainWork: src/chainparams.cpp src/consensus/params.h src/init.cpp src/net_processing.cpp src/validation.cpp src/validation.h
Found 4 use(s) of nPruneTarget: src/init.cpp src/rpc/blockchain.cpp src/validation.cpp src/validation.h
Found 5 use(s) of nScriptCheckThreads: src/init.cpp src/test/checkqueue_tests.cpp src/test/test_bitcoin.cpp src/validation.cpp src/validation.h
Found 13 use(s) of NullUniValue: src/bitcoin-cli.cpp src/httprpc.cpp src/rpc/blockchain.cpp src/rpc/mining.cpp src/rpc/misc.cpp src/rpc/net.cpp src/rpc/protocol.cpp src/rpc/server.cpp src/rpc/server.h src/univalue/include/univalue.h src/univalue/lib/univalue.cpp src/wallet/rpcdump.cpp src/wallet/rpcwallet.cpp
Found 1 use(s) of pathHandlers: src/httpserver.cpp
Found 7 use(s) of pblocktree: src/bench/block_assemble.cpp src/bench/duplicate_inputs.cpp src/index/txindex.cpp src/init.cpp src/test/test_bitcoin.cpp src/validation.cpp src/validation.h
Found 7 use(s) of pcoinsdbview: src/bench/block_assemble.cpp src/bench/duplicate_inputs.cpp src/init.cpp src/rpc/blockchain.cpp src/test/test_bitcoin.cpp src/validation.cpp src/validation.h
Found 15 use(s) of pcoinsTip: src/bench/block_assemble.cpp src/bench/duplicate_inputs.cpp src/init.cpp src/interfaces/node.cpp src/net_processing.cpp src/node/transaction.cpp src/rest.cpp src/rpc/blockchain.cpp src/rpc/rawtransaction.cpp src/test/miner_tests.cpp src/test/test_bitcoin.cpp src/test/txvalidationcache_tests.cpp src/txmempool.h src/validation.cpp src/validation.h
Found 2 use(s) of peerLogic: src/init.cpp src/test/denialofservice_tests.cpp
Found 1 use(s) of pindexBestForkBase: src/validation.cpp
Found 1 use(s) of pindexBestForkTip: src/validation.cpp
Found 5 use(s) of pindexBestHeader: src/interfaces/node.cpp src/net_processing.cpp src/rpc/blockchain.cpp src/validation.cpp src/validation.h
Found 3 use(s) of secp256k1_nonce_function_default: src/secp256k1/include/secp256k1.h src/secp256k1/include/secp256k1_recovery.h src/secp256k1/src/modules/recovery/main_impl.h
Found 2 use(s) of secp256k1_nonce_function_rfc6979: src/key.cpp src/secp256k1/include/secp256k1.h
Found 11 use(s) of tableRPC: src/httprpc.cpp src/init.cpp src/interfaces/node.cpp src/interfaces/wallet.cpp src/qt/test/rpcnestedtests.cpp src/rpc/register.h src/rpc/server.cpp src/rpc/server.h src/test/rpc_tests.cpp src/test/test_bitcoin.cpp src/wallet/test/wallet_test_fixture.cpp
Found 1 use(s) of threadHTTP: src/httpserver.cpp
Found 17 use(s) of uiInterface: src/httprpc.cpp src/httpserver.cpp src/index/base.cpp src/index/txindex.cpp src/init.cpp src/interfaces/chain.cpp src/interfaces/node.cpp src/net.cpp src/net.h src/noui.cpp src/timedata.cpp src/txdb.cpp src/ui_interface.cpp src/ui_interface.h src/validation.cpp src/wallet/init.cpp src/wallet/rpcdump.cpp
Found 3 use(s) of versionbitscache: src/rpc/mining.cpp src/validation.cpp src/validation.h
Found 6 use(s) of VersionBitsDeploymentInfo: src/chainparams.cpp src/consensus/params.h src/rpc/blockchain.cpp src/rpc/mining.cpp src/versionbitsinfo.cpp src/versionbitsinfo.h
$ for SYMBOL in $(nm src/bitcoind | c++filt | grep -E ' B .*[a-z]\[abi:cxx11\]' | cut -f3- -d' ' | cut -f1 -d'[' | sort -u); do
REFERENCES=$(git grep -lE "([^a-zA-Z]|^)${SYMBOL}([^a-zA-Z]|\$)" -- "*.cpp" "*.h")
N_REFERENCES=$(wc -l <<< "${REFERENCES}")
echo -n "Found ${N_REFERENCES} use(s) of ${SYMBOL}: "
sort -u <<< "${REFERENCES}" | tr "\n" " "
echo
done
Found 5 use(s) of strMessageMagic: src/qt/signverifymessagedialog.cpp src/rpc/misc.cpp src/validation.cpp src/validation.h src/wallet/rpcwallet.cpp
Found 1 use(s) of strMiscWarning: src/warnings.cpp
Found 6 use(s) of strSubVersion: src/init.cpp src/net.cpp src/net.h src/net_processing.cpp src/qt/clientmodel.cpp src/rpc/net.cpp
```
Most of these symbols are global (external) for good reasons.
However, judging from the output above the following 16 symbols do not have to be global (external):
```
Found 1 use(s) of boundSockets: src/httpserver.cpp
Found 1 use(s) of cs_warnings: src/warnings.cpp
Found 1 use(s) of eventHTTP: src/httpserver.cpp
Found 1 use(s) of fFeeEstimatesInitialized: src/init.cpp
Found 1 use(s) of fLargeWorkForkFound: src/warnings.cpp
Found 1 use(s) of fLargeWorkInvalidChainFound: src/warnings.cpp
Found 1 use(s) of g_chainstate: src/validation.cpp
Found 1 use(s) of g_ui_signals: src/ui_interface.cpp
Found 1 use(s) of instance_of_cmaincleanup: src/validation.cpp
Found 1 use(s) of instance_of_cnetcleanup: src/net.cpp
Found 1 use(s) of instance_of_cnetprocessingcleanup: src/net_processing.cpp
Found 1 use(s) of pathHandlers: src/httpserver.cpp
Found 1 use(s) of pindexBestForkBase: src/validation.cpp
Found 1 use(s) of pindexBestForkTip: src/validation.cpp
Found 1 use(s) of strMiscWarning: src/warnings.cpp
Found 1 use(s) of threadHTTP: src/httpserver.cpp
``` | https://github.com/bitcoin/bitcoin/issues/15612 | https://github.com/bitcoin/bitcoin/pull/15622 | 63b9efa73d6bec280241fe0fa06abf7e5b4dde8d | fb434159d18e8077ae2d31e1a54c2f8248a6366a | 2019-03-17T16:05:52Z | c++ | 2019-05-25T21:23:11Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,591 | ["src/interfaces/chain.cpp", "src/interfaces/chain.h", "src/wallet/rpcdump.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h", "test/functional/wallet_balance.py"] | balance wrong after unloading wallet and loading it again | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
Have two wallets used by this instance of bitcoind. The default wallet has balance 0.02861762.
Initially reported balance is correct but after unloading the wallet and then loading it again, the balance is wrong. Neither of the wallets have the reported balance.
<!--- What behavior did you expect? -->
I expected the balance to be the same as initially reported.
```
btc@ubuntu:~$ bitcoin-cli -getinfo
{
"version": 170100,
"protocolversion": 70015,
"walletversion": 159900,
"balance": 0.02861762,
...
btc@ubuntu:~$ bitcoin-cli loadwallet wallet2
btc@ubuntu:~$ bitcoin-cli unloadwallet ""
btc@ubuntu:~$ bitcoin-cli loadwallet ""
btc@ubuntu:~$ bitcoin-cli unloadwallet wallet2
btc@ubuntu:~$ bitcoin-cli -getinfo
{
"version": 170100,
"protocolversion": 70015,
"walletversion": 159900,
"balance": 0.01012607,
...
```
The balance 0.01012607 is wrong and I have no idea where that number came from.
Restarting the process results in correct balance again.
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
ubuntu package for bionic
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- For the GUI-related issue on Linux provide names and versions of a distro, a desktop environment and a graphical shell (if relevant). -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/15591 | https://github.com/bitcoin/bitcoin/pull/15652 | 2ebf650b2eb7a078ab60c8c4d5c726823686f549 | 4bf1b1cefa9723bf2cfa8b1a938757abc99bb17b | 2019-03-13T12:34:27Z | c++ | 2019-03-31T10:37:41Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,546 | ["share/setup.nsi.in"] | gitian: Windows installer EXE filenames lack "rcN" suffix | gitian builds now add the "rcN" suffix to most filenames, but the Windows installer EXEs are lacking them. | https://github.com/bitcoin/bitcoin/issues/15546 | https://github.com/bitcoin/bitcoin/pull/15548 | 12a910c9435c1e5437984061e11c7d00523e37c5 | fa55104cb8e73c709e90fc5f81c9cb6a8a0713a6 | 2019-03-06T12:56:58Z | c++ | 2019-03-07T20:14:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,460 | ["src/fs.cpp", "src/wallet/walletutil.cpp"] | Some functional tests fail on native windows when tempdir has unicode chars in the path | The following tests are not emoji-safe:
```
TEST | STATUS | DURATION
feature_config_args.py | ✖ Failed | 17 s
feature_includeconf.py | ✖ Failed | 11 s
interface_bitcoin_cli.py | ✖ Failed | 8 s
wallet_multiwallet.py | ✖ Failed | 6 s
ALL | ✖ Failed | 42 s (accumulated)
Runtime: 17 s
``` | https://github.com/bitcoin/bitcoin/issues/15460 | https://github.com/bitcoin/bitcoin/pull/15468 | f3f9c1de19e6d254e0c3a26ce7a3d8cd57fb7641 | 6ad79cbd562d04ebbcb61c774fb3389e70fedb7c | 2019-02-21T18:55:01Z | c++ | 2019-02-23T15:44:28Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,455 | ["src/qt/bitcoingui.cpp", "src/qt/walletcontroller.cpp"] | gui: Opening wallet dialog doesn't close for certain wallet names | When you open wallets with exotic names, i.e `🦹🏿♂️` (Emoji Version 11), via the "Open Wallet" menu, the opening wallet dialog never closes, even after the wallet has finished loading.
| https://github.com/bitcoin/bitcoin/issues/15455 | https://github.com/bitcoin/bitcoin/pull/15462 | a094b543324267e6d956bb0df2ede990b90118cb | a720a983015c9ef8cc814c16a5b9ef6379695817 | 2019-02-21T06:32:39Z | c++ | 2019-02-23T09:29:59Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,453 | ["src/qt/walletcontroller.cpp", "src/qt/walletcontroller.h"] | Starting bitcoin-qt with -nowallet and then opening a wallet does not show the wallet | When starting bitcoin-qt with `-nowallet` to explicitly not load any wallets initially, attempting to load a wallet using the Open Wallet menu option results in the wallet being loaded but the GUI does not change. The wallet is reachable via the RPC interface but the GUI still says that no wallets are loaded. | https://github.com/bitcoin/bitcoin/issues/15453 | https://github.com/bitcoin/bitcoin/pull/16349 | 8046a3e0befeea641b6309bc0c742b7481e681d9 | 6285a318d77dbfdf50f893963ebfb2973746f757 | 2019-02-20T22:26:37Z | c++ | 2019-07-09T13:30:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,447 | ["src/wallet/rpcwallet.cpp"] | getaddressesbylabel API spends much time | The `getaddressesbylabel` API spends a lot more time than the `getaddressesbyaccount` API.
I generated addresses by the `getnewaddress` API, then, I measured time that the `getaddressesby*` API spends. It seems the algorithm of the `getaddressesbylabel` API takes **O(N ^ 2)** time! The results of my survey are as follows.
### getaddressesbylabel
bitcoind v0.17.1 on Ubuntu 16.04 (AWS EC2 t3.large)
#### 11,001 addresses
```sh
time sudo /usr/local/bin/bitcoin-cli -conf=/etc/bitcoin/bitcoin.conf getaddressesbylabel ""
# (omitted)
real 0m1.230s # 1.2s
user 0m0.044s
sys 0m0.048s
```
#### 111,001 addresses
```sh
time sudo /usr/local/bin/bitcoin-cli -conf=/etc/bitcoin/bitcoin.conf getaddressesbylabel ""
# (omitted)
real 1m37.027s # 97.0s
user 0m0.408s
sys 0m0.544s
```
#### 211,001 addresses
```sh
time sudo /usr/local/bin/bitcoin-cli -conf=/etc/bitcoin/bitcoin.conf getaddressesbylabel ""
# (omitted)
real 6m3.727s # 363.7s
user 0m0.800s
sys 0m0.900s
```
### getaddressesbyaccount
bitcoind v0.16.3 on Ubuntu 16.04 (AWS EC2 t3.large)
#### 11,001 addresses
```sh
time sudo /usr/local/bin/bitcoin-cli -conf=/etc/bitcoin/bitcoin.conf getaddressesbyaccount ""
# (omitted)
real 0m0.500s # 0.5s
user 0m0.092s
sys 0m0.160s
```
#### 111,001 addresses
```sh
time sudo /usr/local/bin/bitcoin-cli -conf=/etc/bitcoin/bitcoin.conf getaddressesbyaccount ""
# (omitted)
real 0m1.361s # 1.4s
user 0m0.168s
sys 0m0.348s
```
#### 211,001 addresses
```sh
time sudo /usr/local/bin/bitcoin-cli -conf=/etc/bitcoin/bitcoin.conf getaddressesbyaccount ""
# (omitted)
real 0m2.220s # 2.2s
user 0m0.384s
sys 0m0.532s
```
| https://github.com/bitcoin/bitcoin/issues/15447 | https://github.com/bitcoin/bitcoin/pull/15463 | a094b543324267e6d956bb0df2ede990b90118cb | 710a7136f93133bf256d37dc8c8faf5a6b9ba89d | 2019-02-20T09:40:00Z | c++ | 2019-04-22T09:00:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,409 | ["src/qt/guiutil.cpp"] | The configuration file could not be opened. | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
Describe the issue
`The configuration file could not be opened.` when clicking on `Open Configuration File`
What behavior did you expect?
Expected to open bitcoin.conf
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
How reliably can you reproduce the issue, what are the steps to do so?
Lanuch Bitcoin Core
What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)?
https://bitcoin.org/en/download
v0.17.1
What type of machine are you observing the error on (OS/CPU and disk type)?
OSX
<!-- For the GUI-related issue on Linux provide names and versions of a distro, a desktop environment and a graphical shell (if relevant). -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/15409 | https://github.com/bitcoin/bitcoin/pull/16044 | 387eb5b34307448f16d3769ac0245c4e3d996a38 | 6e6494b3fb345848025494cb7a79c5bf8f35e417 | 2019-02-14T18:18:00Z | c++ | 2019-06-03T02:32:15Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,372 | [".travis.yml", ".travis/lint_06_script.sh", "doc/README.md", "doc/travis-ci.md"] | travis builds without cache are timing out | travis builds are getting more expensive, as the executables are built with more instrumentation (memory-, or address-sanitizers, ...) and the number of functional tests increases. Thus, a vanilla build (without depends cache and compile cache) would time out. Since depends is only touched rarely, a workaround was to quit travis early in case of a vanilla build, store the cache and mark the build as failed. The next run would take the cache and continue from there. C.f. https://github.com/bitcoin/bitcoin/blob/2945492424934fa360f86b116184ee8e34f19d0a/.travis.yml#L35
I tried to do the same for the regular compilation of Bitcoin Core, but it would run into issues in the mac build: https://travis-ci.org/bitcoin/bitcoin/builds/490661548
To solve my oversight, someone could set a flag to not run any later scripts after the first one timed out.
However, I am creating this issue to see if anyone has other ideas to solve the issue more cleanly. | https://github.com/bitcoin/bitcoin/issues/15372 | https://github.com/bitcoin/bitcoin/pull/15693 | fa36a333eedc0116b88f0dcf62be923e8da98782 | fa2056af1c71aded3a821a07ec4de71c4be0bca3 | 2019-02-08T20:11:43Z | c++ | 2019-04-05T17:35:27Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,355 | ["src/init.cpp", "src/wallet/init.cpp"] | `-maxtxfee` should not be used by both node and wallet | EDITED 2019-02-08
`maxTxFee` is a global variable, used by both the raw transaction and wallet RPCs. It's set from `-maxtxfee`.
~listed in the global help text in init.cpp, but is only set in `WalletInit::ParameterInteraction()`. If the wallet is disabled, then `-maxtxfee` is ignored and the default is used.~
~This behaviour has existed since the mempool was changed to limit acceptance based on `maxTxFee` in https://github.com/bitcoin/bitcoin/commit/fa331db68bcc68e4c93fb45aaa30f911b0ecfe1a.~
~Short-term fix is to move the `-maxtxfee` handling to `InitParameterInteraction()` in init.cpp.~
EDIT: `maxTxFee` initiation bug fixed in #15357
I don't think we should share this setting between the node and wallet. | https://github.com/bitcoin/bitcoin/issues/15355 | https://github.com/bitcoin/bitcoin/pull/15357 | 1a6036978e9d7fabafcd7a113a221d68bc1bd8db | dfbf117bbb82c76c8cb60dba73ae7d653e3b8348 | 2019-02-06T16:28:37Z | c++ | 2019-02-08T14:06:44Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,333 | ["src/wallet/db.cpp"] | Confusing "Using wallet wallet.dat" log message | `bitcoin.conf`:
```
...
testnet=1
# [wallets]
test.wallet=test_alpha
test.wallet=alpha_wallet
test.wallet=none
...
```
Run bitcoin client.
`debug.log`:
```
...
2019-02-03T13:09:23Z Using wallet directory /home/hebasto/.bitcoin/testnet3/wallets
2019-02-03T13:09:23Z init message: Verifying wallet(s)...
2019-02-03T13:09:23Z Using BerkeleyDB version Berkeley DB 4.8.30: (April 9, 2010)
2019-02-03T13:09:23Z Using wallet wallet.dat
2019-02-03T13:09:23Z BerkeleyEnvironment::Open: LogDir=/home/hebasto/.bitcoin/testnet3/wallets/test_alpha/database ErrorFile=/home/hebasto/.bitcoin/testnet3/wallets/test_alpha/db.log
2019-02-03T13:09:23Z Using BerkeleyDB version Berkeley DB 4.8.30: (April 9, 2010)
2019-02-03T13:09:23Z Using wallet wallet.dat
2019-02-03T13:09:23Z BerkeleyEnvironment::Open: LogDir=/home/hebasto/.bitcoin/testnet3/wallets/alpha_wallet/database ErrorFile=/home/hebasto/.bitcoin/testnet3/wallets/alpha_wallet/db.log
2019-02-03T13:09:23Z Using BerkeleyDB version Berkeley DB 4.8.30: (April 9, 2010)
2019-02-03T13:09:23Z Using wallet wallet.dat
2019-02-03T13:09:23Z BerkeleyEnvironment::Open: LogDir=/home/hebasto/.bitcoin/testnet3/wallets/none/database ErrorFile=/home/hebasto/.bitcoin/testnet3/wallets/none/db.log9
...
```
In multi-wallet environment a wallet database file reference (`wallet.dat`) without a wallet name (e.g., `test_alpha`) could be confusing. | https://github.com/bitcoin/bitcoin/issues/15333 | https://github.com/bitcoin/bitcoin/pull/15334 | b3a715301a0fd972fb2f3bd36e2680b3cdbbab26 | a4b92e467dd182621497deda1e80a9737629c75f | 2019-02-03T13:35:41Z | c++ | 2019-02-12T22:47:45Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,310 | ["src/qt/walletcontroller.cpp"] | gui: crash if encrypt / change passphrase window is open and wallet is unloaded | Using master @ cb35f1d305d88934df64c2e7fb80700b673360e6
Run `bitcoin-qt`, and open either the `Encrypt Wallet` or `Change Passphrase` window.
Unload the wallet. ie `src/bitcoin-cli unloadwallet`
```
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
* frame #0: 0x00007fff5ba9523e libsystem_kernel.dylib`__pthread_kill + 10
frame #1: 0x00007fff5bb4bc1c libsystem_pthread.dylib`pthread_kill + 285
frame #2: 0x00007fff5b9fe1c9 libsystem_c.dylib`abort + 127
frame #3: 0x00007fff5bb0d6e2 libsystem_malloc.dylib`malloc_vreport + 545
frame #4: 0x00007fff5bb0d4a3 libsystem_malloc.dylib`malloc_report + 152
frame #5: 0x0000000101ef9e90 QtCore`QObjectPrivate::deleteChildren() + 224
frame #6: 0x00000001012439e2 QtWidgets`QWidget::~QWidget() + 1058
frame #7: 0x00000001000ddc8c bitcoin-qt`WalletView::~WalletView() [inlined] WalletView::~WalletView(this=0x0000000159d976e0) at walletview.cpp:87 [opt]
frame #8: 0x00000001000ddc87 bitcoin-qt`WalletView::~WalletView() [inlined] WalletView::~WalletView(this=0x0000000159d976e0) at walletview.cpp:86 [opt]
frame #9: 0x00000001000ddc87 bitcoin-qt`WalletView::~WalletView(this=0x0000000159d976e0) at walletview.cpp:86 [opt]
frame #10: 0x00000001000d42f8 bitcoin-qt`WalletFrame::removeWallet(this=0x000000010eaa4130, wallet_model=<unavailable>) at walletframe.cpp:98 [opt]
frame #11: 0x000000010001f5b6 bitcoin-qt`BitcoinGUI::removeWallet(this=0x0000000108dc8bb0, walletModel=<unavailable>) at bitcoingui.cpp:611 [opt]
frame #12: 0x0000000101f01d7b QtCore`QMetaObject::activate(QObject*, int, int, void**) + 2219
frame #13: 0x00000001000ef3ff bitcoin-qt`WalletController::walletRemoved(this=<unavailable>, _t1=<unavailable>) at moc_walletcontroller.cpp:206 [opt]
frame #14: 0x00000001000d2f46 bitcoin-qt`WalletController::removeAndDeleteWallet(this=0x0000000159d31a00, wallet_model=0x0000000122f44f80) at walletcontroller.cpp:91 [opt]
frame #15: 0x0000000101f01d7b QtCore`QMetaObject::activate(QObject*, int, int, void**) + 2219
frame #16: 0x0000000101efa801 QtCore`QObject::event(QEvent*) + 753
frame #17: 0x0000000101218f8d QtWidgets`QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269
frame #18: 0x000000010121a392 QtWidgets`QApplication::notify(QObject*, QEvent*) + 594
``` | https://github.com/bitcoin/bitcoin/issues/15310 | https://github.com/bitcoin/bitcoin/pull/15614 | 717fd58c4ba5c64778fa9a8bf6bbf5ae1164df3f | a10972bc03e1ebbe79c3edc929c91ed53b391c9a | 2019-02-01T07:21:36Z | c++ | 2019-03-22T09:51:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,300 | ["src/rpc/rawtransaction.cpp", "test/functional/rpc_psbt.py"] | rpc: segfault if combinepsbt called with empty inputs | Running master 4d661ba:
```
src/bitcoin-cli combinepsbt [""] or src/bitcoin-cli combinepsbt []
```
```
* frame #0: 0x000000010016054a bitcoind`PartiallySignedTransaction::PartiallySignedTransaction(PartiallySignedTransaction const&) [inlined] boost::optional_detail::optional_base<CMutableTransaction>::is_initialized(this=0x0000000000000000) const at optional.hpp:394 [opt]
frame #1: 0x000000010016054a bitcoind`PartiallySignedTransaction::PartiallySignedTransaction(PartiallySignedTransaction const&) [inlined] boost::optional_detail::optional_base<CMutableTransaction>::optional_base(this=<unavailable>, rhs=0x0000000000000000) at optional.hpp:196 [opt]
frame #2: 0x0000000100160542 bitcoind`PartiallySignedTransaction::PartiallySignedTransaction(PartiallySignedTransaction const&) [inlined] boost::optional<CMutableTransaction>::optional(this=0x000070000b9fe7c0, (null)=0x0000000000000000) at optional.hpp:958 [opt]
frame #3: 0x0000000100160542 bitcoind`PartiallySignedTransaction::PartiallySignedTransaction(PartiallySignedTransaction const&) [inlined] boost::optional<CMutableTransaction>::optional(this=0x000070000b9fe7c0, (null)=0x0000000000000000) at optional.hpp:958 [opt]
frame #4: 0x0000000100160542 bitcoind`PartiallySignedTransaction::PartiallySignedTransaction(this=0x000070000b9fe7c0, psbt_in=0x0000000000000000) at sign.h:576 [opt]
frame #5: 0x0000000100142ae5 bitcoind`combinepsbt(JSONRPCRequest const&) [inlined] PartiallySignedTransaction::PartiallySignedTransaction(this=0x000070000b9fe700, psbt_in=<unavailable>) at sign.h:576 [opt]
frame #6: 0x0000000100142ae0 bitcoind`combinepsbt(request=<unavailable>) at rawtransaction.cpp:1526 [opt]
frame #7: 0x0000000100170f0a bitcoind`CRPCTable::execute(this=<unavailable>, request=0x000070000b9fead0) const at server.cpp:557 [opt]
``` | https://github.com/bitcoin/bitcoin/issues/15300 | https://github.com/bitcoin/bitcoin/pull/15337 | e50853501b79378597edbcd6dd217819c057de4b | 30d0f7be6e6bd45fed7195ddf31187438b02227a | 2019-01-31T15:36:44Z | c++ | 2019-02-05T03:26:52Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,291 | ["src/util/system.cpp", "src/util/system.h", "src/wallet/db.cpp", "test/functional/wallet_multiwallet.py"] | Bitcoin-core multiwallets limited to about 300 loads | Hi,
Using Bitcoin Core RPC client version v0.17.0.1-g1476554d3b1db5352c0de1de7524864d4bce3aac
I'm using bitcoin-cli loadwallet and unloadwallet commands. They both seem to work fine.
Unfortunately, memory is getting higher and higher, and no wallet can be loaded after 300 have been.
The problem may be related to BerkeleyDB rather than to Bitcoin Core itself. Fact is that lsof shows handles not cleared off after the unloadwallet command is issued. Files still handled are .walletlock, db.log and database/log.0000000001 .
When 300 different wallets have been loaded/unloaded, used RAM is over 8 GB, and bitcoind will finally become unstable and fail.
Any help would be appreciated.
Regards, | https://github.com/bitcoin/bitcoin/issues/15291 | https://github.com/bitcoin/bitcoin/pull/15297 | 2f8b8f479bb43729ca2ff40929e8463347b0b7b4 | d3bf3b930d34da7d121ae35b4fb75865ed73208c | 2019-01-30T10:32:09Z | c++ | 2019-02-04T18:50:21Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,286 | ["src/key.cpp"] | Incorrect or duplicate assertion in key.cpp signing code | The following assertion seems redundant. Is it a mistake? Two lines prior the same assertion is made, and the value being asserted doesn't appear to change in-between. However the next line asserts a condition on a different variable which differs by only one letter. Is the referenced line a duplicate assertion of `ret` and therefore redundant, or is it supposed to be `assert(rec)`?
https://github.com/bitcoin/bitcoin/blob/7275365c9bc7e7ebd6bbf7dcb251946aac44b5de/src/key.cpp#L247-L251 | https://github.com/bitcoin/bitcoin/issues/15286 | https://github.com/bitcoin/bitcoin/pull/15299 | 4d661baf1aca4226d1c4ec89fe7e44c1f93f04da | 3617f117394285c87c395a0ccc92941977f97019 | 2019-01-29T19:49:52Z | c++ | 2019-01-31T15:00:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,240 | ["src/bitcoin-cli.cpp", "src/bitcoin-wallet.cpp", "src/bitcoind.cpp", "src/qt/bitcoin.cpp", "src/util/system.cpp", "src/util/system.h", "test/functional/feature_config_args.py"] | bitcoind wont start with datadir specified in conf file and no home dir | bitcoind won't start if datadir is specified in the conf file and the user running it has no home dir
tested with debian stretch and bitcoin 0.17.1
```
# sudo -u bitcoin bitcoind -daemon -conf=/usr/local/etc/bitcoin/bitcoin.conf -pid=/run/bitcoind/bitcoind.pid
************************
EXCEPTION: N5boost10filesystem16filesystem_errorE
boost::filesystem::create_directories: Permission denied: "/home/bitcoin"
bitcoin in AppInit()
bitcoind: chainparamsbase.cpp:29: const CBaseChainParams& BaseParams(): Assertion `globalChainBaseParams' failed.
Aborted
# mkhomedir_helper bitcoin
# sudo -u bitcoin bitcoind -daemon -conf=/usr/local/etc/bitcoin/bitcoin.conf -pid=/run/bitcoind/bitcoind.pid
Bitcoin server starting
```
| https://github.com/bitcoin/bitcoin/issues/15240 | https://github.com/bitcoin/bitcoin/pull/15864 | 66f5c17f8a3fe06fc65191e379ffc04e43cbbc86 | ffea41f5301d5582665cf10ba5c2b9547a1443de | 2019-01-24T04:04:11Z | c++ | 2019-07-24T16:15:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,227 | ["src/sync.cpp"] | bitcoind terminated with uncaught exception if configure --debug-enabled | After #14955 was merged, bitcoind terminate with uncaught exception if build with **```configure --debug-enabled```** on my mac.
Actual output is following:
```
$ ./src/bitcoind
libc++abi.dylib: terminating with uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument
Abort trap: 6
```
Backtrace is following:
```
$ lldb ./src/bitcoind
(lldb) target create "./src/bitcoind"
Current executable set to './src/bitcoind' (x86_64).
(lldb) run
Process 73375 launched: './src/bitcoind' (x86_64)
libc++abi.dylib: terminating with uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument
Process 73375 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
frame #0: 0x00007fff6588423e libsystem_kernel.dylib`__pthread_kill + 10
libsystem_kernel.dylib`__pthread_kill:
-> 0x7fff6588423e <+10>: jae 0x7fff65884248 ; <+20>
0x7fff65884240 <+12>: movq %rax, %rdi
0x7fff65884243 <+15>: jmp 0x7fff6587e3b7 ; cerror_nocancel
0x7fff65884248 <+20>: retq
Target 0: (bitcoind) stopped.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
* frame #0: 0x00007fff6588423e libsystem_kernel.dylib`__pthread_kill + 10
frame #1: 0x00007fff6593ac1c libsystem_pthread.dylib`pthread_kill + 285
frame #2: 0x00007fff657ed1c9 libsystem_c.dylib`abort + 127
frame #3: 0x00007fff62e6e231 libc++abi.dylib`abort_message + 231
frame #4: 0x00007fff62e6e3b5 libc++abi.dylib`default_terminate_handler() + 241
frame #5: 0x00007fff64678c8f libobjc.A.dylib`_objc_terminate() + 105
frame #6: 0x00007fff62e79dfe libc++abi.dylib`std::__terminate(void (*)()) + 8
frame #7: 0x00007fff62e79e73 libc++abi.dylib`std::terminate() + 51
frame #8: 0x0000000100003efb bitcoind`__clang_call_terminate + 11
frame #9: 0x0000000100344803 bitcoind`(anonymous namespace)::RNGState::MixExtract(this=<unavailable>, out="", num=32, hasher=0x00007ffeefbfe3f8, strong_seed=<unavailable>) at random.cpp:355 [opt]
frame #10: 0x0000000100343fbd bitcoind`ProcRand(out="", num=32, level=FAST) at random.cpp:497 [opt]
frame #11: 0x0000000100343efd bitcoind`GetRandBytes(buf=<unavailable>, num=<unavailable>) at random.cpp:513 [opt]
frame #12: 0x000000010015a38b bitcoind`::__cxx_global_var_init.3() at sigcache.cpp:68 [opt]
frame #13: 0x0000000100d8dcc8 dyld`ImageLoaderMachO::doModInitFunctions(ImageLoader::LinkContext const&) + 518
frame #14: 0x0000000100d8dec6 dyld`ImageLoaderMachO::doInitialization(ImageLoader::LinkContext const&) + 40
frame #15: 0x0000000100d890da dyld`ImageLoader::recursiveInitialization(ImageLoader::LinkContext const&, unsigned int, char const*, ImageLoader::InitializerTimingList&, ImageLoader::UninitedUpwards&) + 358
frame #16: 0x0000000100d88254 dyld`ImageLoader::processInitializers(ImageLoader::LinkContext const&, unsigned int, ImageLoader::InitializerTimingList&, ImageLoader::UninitedUpwards&) + 134
frame #17: 0x0000000100d882e8 dyld`ImageLoader::runInitializers(ImageLoader::LinkContext const&, ImageLoader::InitializerTimingList&) + 74
frame #18: 0x0000000100d77774 dyld`dyld::initializeMainExecutable() + 199
frame #19: 0x0000000100d7c78f dyld`dyld::_main(macho_header const*, unsigned long, int, char const**, char const**, char const**, unsigned long*) + 6237
frame #20: 0x0000000100d764f6 dyld`dyldbootstrap::start(macho_header const*, int, char const**, long, macho_header const*, unsigned long*) + 1154
frame #21: 0x0000000100d76036 dyld`_dyld_start + 54
(lldb) quit
```
[how to reproduce the issue]
```
cd (path_to bitcoin_repo)
git reset --hard 6e6b3b944d12a252a0fd9a1d68fec9843dd5b4f8
make clean ; make distclean ; ./autogen.sh && ./configure --enable-debug && make -j9
./src/bitcoind
```
[Bitcoin Core version]
- commit 6e6b3b944d12a252a0fd9a1d68fec9843dd5b4f8
[machine]
- MacBook Pro
(macOS Mojave 10.14.2/Intel Core i7 2.2GHz/memory 16GB/SSD 256GB)
[extra information]
- bitcoin-qt, test_bitcoin and bench_bitcoin have also same problem.
- There is no problem until #14970 (commit ace87ea2b00a84b7a76e75f1ec93d1a4dce83f6f) was merged.
| https://github.com/bitcoin/bitcoin/issues/15227 | https://github.com/bitcoin/bitcoin/pull/15233 | 94167e2b5b7b6cb3cb1465ee67dd50676c5c8a14 | b09dab0f2de37be3c96f5087ee7bd61d7262aa76 | 2019-01-22T05:45:44Z | c++ | 2019-01-25T04:21:59Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,172 | ["src/rpc/server.cpp"] | Error compiling Bitcoin Core on Centos 7.5 (with default gcc 4.8) | ***Description***
Compiling bitcoind (cf0c67b62c2037dc9e70ea84ffee3b205a9b1bef, master branch) fails with:
```
/usr/include/c++/4.8.2/bits/stl_list.h:1149:9: note: template argument deduction/substitution failed:
rpc/server.cpp:54:122: note: cannot convert ‘g_rpc_server_info.RPCServerInfo::active_commands.std::list<_Tp, _Alloc>::cend<RPCCommandExecutionInfo, std::allocator<RPCCommandExecutionInfo> >()’ (type ‘std::list<RPCCommandExecutionInfo>::const_iterator {aka std::_List_const_iterator<RPCCommandExecutionInfo>}’) to type ‘std::list<RPCCommandExecutionInfo>::iterator {aka std::_List_iterator<RPCCommandExecutionInfo>}’
it = g_rpc_server_info.active_commands.insert(g_rpc_server_info.active_commands.cend(), {method, GetTimeMicros()});
```
***Steps to replicate***
Replicable on two different VM's:
(- git checkout master)
- git pull
- make clean && ./autogen.sh && ./configure --disable-wallet --without-gui --with-zmq --enable-zmq && make
***Expected behavior***
Compilation should be successful.
***Current behavior***
Compilation was not successful.
***Bitcoin Core Version***
```
[user@localhost bitcoin]$ git branch
* master
[user@localhost bitcoin]$ git log
commit cf0c67b62c2037dc9e70ea84ffee3b205a9b1bef
```
***Environment Info***
```
[user@localhost bitcoin]$ cat /etc/centos-release
CentOS Linux release 7.5.1804 (Core)
```
```
[user@localhost bitcoin]$ cat /proc/cpuinfo
processor : 0
vendor_id : GenuineIntel
cpu family : 6
model : 42
model name : Intel Xeon E312xx (Sandy Bridge)
stepping : 1
microcode : 0x1
cpu MHz : 3092.972
cache size : 16384 KB
physical id : 0
siblings : 1
core id : 0
cpu cores : 1
apicid : 0
initial apicid : 0
fpu : yes
fpu_exception : yes
cpuid level : 13
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss syscall nx rdtscp lm constant_tsc rep_good nopl xtopology eagerfpu pni pclmulqdq ssse3 cx16 pcid sse4_1 sse4_2 x2apic popcnt tsc_deadline_timer aes xsave avx hypervisor lahf_lm xsaveopt arat
bogomips : 6185.94
clflush size : 64
cache_alignment : 64
address sizes : 40 bits physical, 48 bits virtual
power management:
```
```
[user@localhost bitcoin]$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper
Target: x86_64-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-linker-hash-style=gnu --enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto --enable-plugin --enable-initfini-array --disable-libgcj --with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install --with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install --enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64 --build=x86_64-redhat-linux
Thread model: posix
gcc version 4.8.5 20150623 (Red Hat 4.8.5-28) (GCC)
```
| https://github.com/bitcoin/bitcoin/issues/15172 | https://github.com/bitcoin/bitcoin/pull/15248 | 003a47f804b1c66661fbe9a3ccef431d5e300282 | fa5f890aeb90a4d2a88b3b126530a1358651369a | 2019-01-15T10:07:00Z | c++ | 2019-01-27T17:33:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,142 | ["doc/release-notes.md", "src/qt/guiutil.cpp", "src/qt/optionsdialog.cpp"] | gui: crash on macOS when unchecking "start Bitcoin Core on system login" | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
# Describe the issue
Unchecking the "Start Bitcoin Core on System login" causes 0.17.1 to crash on Mac OS.
# What behavior did you expect?
To continue running and not start on reboot.
# What was the actual behavior (provide screenshots if the issue is GUI-related)?
See video:
https://twitter.com/_drgo/status/1083409084655665152?s=21
# How reliably can you reproduce the issue, what are the steps to do so?
Reliably. See above.
# What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)?
0.17.1; downloaded from link on Bitcoin.org; shasum -a 256 matched.
# What type of machine are you observing the error on (OS/CPU and disk type)?
Mac Mini 2.6 ghz dual core i5, Mac OS Mojave 10.14.2
<!-- For the GUI-related issue on Linux provide names and versions of a distro, a desktop environment and a graphical shell (if relevant). -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
# Debug.log
Doesn't seem to informative...
https://pastebin.com/qckAe3J1 | https://github.com/bitcoin/bitcoin/issues/15142 | https://github.com/bitcoin/bitcoin/pull/15208 | 516437a1b70b6df87faadfd38c3d84e6dfb5eae8 | da6011826a730837b59aef5664f3feab4787c9bc | 2019-01-10T17:20:58Z | c++ | 2019-01-22T08:43:03Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,106 | ["src/init.cpp", "src/qt/forms/optionsdialog.ui", "src/qt/guiconstants.h", "src/qt/intro.cpp", "src/qt/optionsdialog.cpp", "src/qt/optionsmodel.cpp", "src/validation.h", "test/functional/feature_pruning.py"] | Information units consistency | There is a plenty diversity in information units through the code, command-line options, GUI and logs. Here are some examples:
`-dbcache`
**megabytes** in CL and GUI _vs_ **MiB** in logs and code (constants in [txdb.h](https://github.com/bitcoin/bitcoin/blob/master/src/txdb.h))
`-prune`
**MiB** in CL _vs_ **GB** in GUI. Also, setting prune = 1 GB in GUI gives _incorrect_ prune target = 1000 MiB.
Which prefix type -- binary (a power of 2) or SI (a power of 10) -- is preferable in the Bitcoin Core project? | https://github.com/bitcoin/bitcoin/issues/15106 | https://github.com/bitcoin/bitcoin/pull/15163 | 84d0fdce11709c8e26b9c450d47727ab36641437 | 6f6514a08090b37b5e8c086015ee4881813ef867 | 2019-01-04T21:38:03Z | c++ | 2019-01-30T05:17:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,079 | ["src/qt/guiconstants.h", "src/qt/networkstyle.cpp"] | gui: Incorrect application name when passing -regtest | On Fedora 29.1-2, when running `bitcoin-qt -regtest`, the name of the application in the menu bar is shown as `Bitcoin-Qt-testnet` (the icon is the correct blue colour). i.e:
Noticed while testing #15000 (confirmed unrelated by testing master). When running just `bitcoin-qt`, or passing `-testnet` the menu name and icon are both correct. | https://github.com/bitcoin/bitcoin/issues/15079 | https://github.com/bitcoin/bitcoin/pull/15085 | fb52d0684e0f03bca5d7ddcf3fc5b0657859ac2c | cc341adbbb7584d3110a5151baf1ba4053aa2ed1 | 2019-01-02T14:49:08Z | c++ | 2019-01-03T07:04:26Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,075 | ["src/util/system.cpp", "test/functional/feature_config_args.py"] | Expected error not printed if rpcpassword contains hash character but is in a [section] | <!-- Describe the issue -->
<!--- What behavior did you expect? -->
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
I'm writing a quick release note for #14494 (Error if # is used in rpcpassword in conf) and it doesn't work the way I expect with the optional new configuration file style. For example, this configuration file aborts startup as expected:
```text
$ cat .bitcoin/bitcoin.conf ; bitcoind -testnet | tee /dev/null | head -n 5
rpcpassword=foo#bar
Error reading configuration file: parse error on line 1, using # in rpcpassword can be ambiguous and should be avoided
```
However, this does not:
```text
harding@redspot:~$ cat .bitcoin/bitcoin.conf ; bitcoind -testnet | tee /dev/null | head -n 5
[test]
rpcpassword=foo#bar
2019-01-01T20:24:25Z Bitcoin Core version v0.17.99.0-f5a70d1462 (release build)
2019-01-01T20:24:25Z InitParameterInteraction: parameter interaction: -whitelistforcerelay=1 -> setting -whitelistrelay=1
2019-01-01T20:24:25Z Assuming ancestors of block 0000000000000037a8cd3e06cd5edbfe9dd1dbcc5dacab279376ef7cfc2b4c75 have valid signatures.
2019-01-01T20:24:25Z Setting nMinimumChainWork=00000000000000000000000000000000000000000000007dbe94253893cbd463
2019-01-01T20:24:25Z Using the 'sse4(1way),sse41(4way)' SHA256 implementation
```
The same problem with rpcpassword applies to the `[main]` section. I can confirm that options specified in sections are otherwise working correctly here, and that rpcpassword also otherwise works as expected---I only fail to get the expected error when putting it in a section.
I'm running commit f5a70d1462592a23bbad4aa150e6b2beaeec7c42 (master from 2019-01-01) on Debian Stable on x86_64.
CC: @MeshCollider (author of #14494) | https://github.com/bitcoin/bitcoin/issues/15075 | https://github.com/bitcoin/bitcoin/pull/15087 | 031e3a32b2453211af0b651af1e01c1b9c31be2f | 8cff83124bcac936ecc6add6dca72b125a79a08f | 2019-01-01T20:38:56Z | c++ | 2019-01-09T04:32:35Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,049 | ["build_msvc/libbitcoin_server/libbitcoin_server.vcxproj.in"] | The project "libbitcoin_server" can not load successfully in VS2017 | ==============================================
How to reproduce
==============================================
1. execute "python msvc-autogen.py"
2. open "bitcoin.sln" with VS2017
3. The project "libbitcoin_server" can not load successfully.
==============================================
The reason of the problem
==============================================
The file "build_msvc\libbitcoin_server\libbitcoin_server.vcxproj" has an error.
==============================================
How to fix the bug
==============================================
Remove the section in file "libbitcoin_server.vcxproj.in" can reslove the issue:
-----------------------------------------
<ClCompile Include="..\..\src\rpc\net.cpp">
<ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">$(IntDir)\netrpc.obj</ObjectFileName>
<ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">$(IntDir)\netrpc.obj</ObjectFileName>
<ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">$(IntDir)\netrpc.obj</ObjectFileName>
<ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Release|x64'">$(IntDir)\netrpc.obj</ObjectFileName>
</ClCompile>
-----------------------------------------
==============================================
possible reason
==============================================
I think the reason:
There are two files with the same name "net.cpp", one is "src\net.cpp", the other is "src\rpc\net.cpp".
There was a special section in file "libbitcoin_server.vcxproj.in" in order to produce the different obj files before.
But the file "msvc-autogen.py" updated so as to process such scenario. finally, a conflict arises. | https://github.com/bitcoin/bitcoin/issues/15049 | https://github.com/bitcoin/bitcoin/pull/15110 | d71d0d7b7f3f1452ec59c68f9e57f62f60d6dbb3 | c98f8866fedc6f223746674cc1ecad1c2afaca17 | 2018-12-28T09:00:03Z | c++ | 2019-01-05T12:16:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 15,016 | ["src/qt/bitcoingui.cpp", "src/qt/guiutil.cpp", "src/qt/guiutil.h", "src/qt/walletview.cpp"] | [GUI] progress window size | Information in the progress window (example: rescan) is displayed capped to fixed size instead of contents.
<img width="209" alt="screenshot 2018-12-21 at 14 58 20" src="https://user-images.githubusercontent.com/26601261/50345943-0bbd4300-0531-11e9-9c6c-e277ac69eb0c.png">
| https://github.com/bitcoin/bitcoin/issues/15016 | https://github.com/bitcoin/bitcoin/pull/15040 | 035f349371a5b67922ce92c11ad9aa7178fa04f7 | 7c572c488dcf84438d64da4ca920a48810044a72 | 2018-12-21T14:00:10Z | c++ | 2019-01-14T23:28:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,995 | ["src/wallet/rpcwallet.cpp"] | possible deadlock with walletpassphrase | When i used the encrypted wallet to test transfer parallelly,i frequently got the trouble: The rpc server is not responding.My test script is like below:
#!/bin/sh
while [ 1 ]
do
./bitcoin-cli listaddressgroupings>null
./bitcoin-cli walletpassphrase "!@#$%^&*" 2
./bitcoin sendtoaddress "mhAW6mzs5DeCbzBUHXBi4U446Fdnr1z8U7" 0.01
done
When i open the dead lock trace macro and check the debug log,i found the last print is as below:
2018-12-17 08:27:58 ThreadRPCServer method=walletpassphrase
2018-12-17 08:27:58 LOCKCONTENTION: cs_main
2018-12-17 08:27:58 Locker: wallet/rpcwallet.cpp:2642
2018-12-17 08:27:58 LOCKCONTENTION: pWallet->cs_wallet
2018-12-17 08:27:58 Locker: wallet/rpcwallet.cpp:2607
The line no 2642 is walletpassphrase and 2607 is LockWallet. I checked the code,i found there is no log printed for this line in function "walletpassphrase":
"LogPrint(BCLog::RPC, "queue run of timer %s in %i seconds (using %s)\n", name, nSeconds, timerInterface->Name());" So i guess the reason may be:
When "walletpassphrase" is running and lock the cs_wallet,the last relock timer triggered and call "LockWallet"."LockWallet" want to lock the cs_wallet but it has been locked by "walletpassphrase",so "LockWallet" is blocked.When "walletpassphrase" run to call "RPCRunLater",the function will erase the timer from the std::map "deadlineTimers",but the timer's timeout call is blocked,so the dead lock take place.
Is my guess right?
How to reslove the issue?
Any help will be appreciative！ | https://github.com/bitcoin/bitcoin/issues/14995 | https://github.com/bitcoin/bitcoin/pull/18487 | 54d5ba3d9cb45d8417ecca0f09c68d865d0c423c | 75021e80ee4439dddadbe8c586cee04b85ac110c | 2018-12-18T14:26:46Z | c++ | 2020-04-06T18:29:35Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,994 | ["src/qt/bitcoingui.cpp"] | bitcoin-qt: segmentation fault on Fedora 29 | I can reproduce an issue with master; v0.17.1rc1 works fine.
Steps to reproduce:
- `bitcoin-qt -regtest`
- open Console window
- repeat `generatetoaddress 1 AN_ADDRESS` some times until crash
Crash occurs both on wayland and x11.
[debug.log](https://github.com/bitcoin/bitcoin/files/2690776/debug.log)
[wallets.zip](https://github.com/bitcoin/bitcoin/files/2690781/wallets.zip) | https://github.com/bitcoin/bitcoin/issues/14994 | https://github.com/bitcoin/bitcoin/pull/15000 | f080c65a09a8f3b223c9b5d8e3562320bf258fcd | c8d9d9093b7050cd24cdb9eb1d1e05c16bedd9fd | 2018-12-18T14:05:43Z | c++ | 2018-12-19T18:43:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,983 | [".travis.yml", "src/interfaces/wallet.cpp", "src/validationinterface.cpp", "src/wallet/rpcdump.cpp", "src/wallet/wallet.cpp"] | One Travis instance should run minimum supported QT version | @jonasschnelli wrote in #14979:
> #14573 broke < Qt5.6 compatibility due to calling the lambda version of `addAction` that was added in Qt5.6.
We currently [support](https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md) QT >=5.2, but hardly anyone tests with that. If we make one of the Travis machines use it, we should have a better change of catching this.
See also discussion about minimum QT version in #13478 | https://github.com/bitcoin/bitcoin/issues/14983 | https://github.com/bitcoin/bitcoin/pull/15308 | 64f28545e373defca8ed3d0b6f2856d8433b6dba | 119d360aabfac893cb95def9d20aae7493c933ab | 2018-12-17T14:47:31Z | c++ | 2019-02-01T06:13:45Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,967 | ["src/test/checkqueue_tests.cpp", "src/test/cuckoocache_tests.cpp"] | TSAN issue in cuckoocache_erase_parallel_ok test after 14935 | After #14935, the [TSAN Travis job](https://travis-ci.org/bitcoin/bitcoin/jobs/468142290) is consistently failing when running the `cuckoocache_erase_parallel_ok` test:
```
Leaving test case "test_cuckoocache_no_fakes"; testing time: 1096188mks
Entering test case "cuckoocache_erase_parallel_ok"
==================
WARNING: ThreadSanitizer: data race (pid=25684)
Write of size 8 at 0x7d340000ce60 by thread T2:
#0 memcpy <null> (test_bitcoin+0x000000490510)
#1 std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_replace(unsigned long, unsigned long, char const*, unsigned long) <null> (libstdc++.so.6+0x00000011ff2c)
#2 std::this_thread::__sleep_for(std::chrono::duration<long, std::ratio<1l, 1l> >, std::chrono::duration<long, std::ratio<1l, 1000000000l> >) <null> (libstdc++.so.6+0x0000000b8c7f)
Previous write of size 8 at 0x7d340000ce60 by thread T1:
#0 memcpy <null> (test_bitcoin+0x000000490510)
#1 std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_replace(unsigned long, unsigned long, char const*, unsigned long) <null> (libstdc++.so.6+0x00000011ff2c)
#2 std::this_thread::__sleep_for(std::chrono::duration<long, std::ratio<1l, 1l> >, std::chrono::duration<long, std::ratio<1l, 1000000000l> >) <null> (libstdc++.so.6+0x0000000b8c7f)
Location is heap block of size 201 at 0x7d340000ce60 allocated by main thread:
#0 operator new(unsigned long) <null> (test_bitcoin+0x000000510853)
#1 std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::reserve(unsigned long) <null> (libstdc++.so.6+0x00000011f87c)
#2 __libc_start_main <null> (libc.so.6+0x00000002082f)
Thread T2 (tid=25687, running) created by main thread at:
#0 pthread_create <null> (test_bitcoin+0x000000490b06)
#1 std::thread::_M_start_thread(std::shared_ptr<std::thread::_Impl_base>, void (*)()) <null> (libstdc++.so.6+0x0000000b8dc2)
#2 void std::vector<std::thread, std::allocator<std::thread> >::_M_emplace_back_aux<void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}>(void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/vector.tcc:416 (test_bitcoin+0x0000006139d1)
#3 void std::vector<std::thread, std::allocator<std::thread> >::emplace_back<void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}>(void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/vector.tcc:101 (test_bitcoin+0x0000006139d1)
#4 void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long) /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/test/cuckoocache_tests.cpp:218 (test_bitcoin+0x0000006139d1)
#5 cuckoocache_tests::cuckoocache_erase_parallel_ok::test_method() /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/test/cuckoocache_tests.cpp:264 (test_bitcoin+0x0000006139d1)
#6 cuckoocache_tests::cuckoocache_erase_parallel_ok_invoker() /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/test/cuckoocache_tests.cpp:261 (test_bitcoin+0x00000061329f)
#7 boost::unit_test::ut_detail::unused boost::unit_test::ut_detail::invoker<boost::unit_test::ut_detail::unused>::invoke<void (*)()>(void (*&)()) /usr/include/boost/test/utils/callback.hpp:56 (test_bitcoin+0x000000564e39)
#8 boost::unit_test::ut_detail::callback0_impl_t<boost::unit_test::ut_detail::unused, void (*)()>::invoke() /usr/include/boost/test/utils/callback.hpp:89 (test_bitcoin+0x000000564e39)
#9 boost::unit_test::test_case_filter::test_case_filter(boost::unit_test::basic_cstring<char const>) <null> (libboost_unit_test_framework.so.1.58.0+0x00000006acb0)
#10 __libc_start_main <null> (libc.so.6+0x00000002082f)
Thread T1 (tid=25686, running) created by main thread at:
#0 pthread_create <null> (test_bitcoin+0x000000490b06)
#1 std::thread::_M_start_thread(std::shared_ptr<std::thread::_Impl_base>, void (*)()) <null> (libstdc++.so.6+0x0000000b8dc2)
#2 void std::vector<std::thread, std::allocator<std::thread> >::_M_emplace_back_aux<void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}>(void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/vector.tcc:416 (test_bitcoin+0x0000006139d1)
#3 void std::vector<std::thread, std::allocator<std::thread> >::emplace_back<void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}>(void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/vector.tcc:101 (test_bitcoin+0x0000006139d1)
#4 void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long) /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/test/cuckoocache_tests.cpp:218 (test_bitcoin+0x0000006139d1)
#5 cuckoocache_tests::cuckoocache_erase_parallel_ok::test_method() /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/test/cuckoocache_tests.cpp:264 (test_bitcoin+0x0000006139d1)
#6 cuckoocache_tests::cuckoocache_erase_parallel_ok_invoker() /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/test/cuckoocache_tests.cpp:261 (test_bitcoin+0x00000061329f)
#7 boost::unit_test::ut_detail::unused boost::unit_test::ut_detail::invoker<boost::unit_test::ut_detail::unused>::invoke<void (*)()>(void (*&)()) /usr/include/boost/test/utils/callback.hpp:56 (test_bitcoin+0x000000564e39)
#8 boost::unit_test::ut_detail::callback0_impl_t<boost::unit_test::ut_detail::unused, void (*)()>::invoke() /usr/include/boost/test/utils/callback.hpp:89 (test_bitcoin+0x000000564e39)
#9 boost::unit_test::test_case_filter::test_case_filter(boost::unit_test::basic_cstring<char const>) <null> (libboost_unit_test_framework.so.1.58.0+0x00000006acb0)
#10 __libc_start_main <null> (libc.so.6+0x00000002082f)
SUMMARY: ThreadSanitizer: data race (/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/test/test_bitcoin+0x490510) in memcpy
==================
==================
WARNING: ThreadSanitizer: data race (pid=25684)
Write of size 8 at 0x7d340000ce68 by thread T2:
#0 memcpy <null> (test_bitcoin+0x000000490510)
#1 std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_replace(unsigned long, unsigned long, char const*, unsigned long) <null> (libstdc++.so.6+0x00000011ff2c)
#2 std::this_thread::__sleep_for(std::chrono::duration<long, std::ratio<1l, 1l> >, std::chrono::duration<long, std::ratio<1l, 1000000000l> >) <null> (libstdc++.so.6+0x0000000b8c7f)
Previous write of size 8 at 0x7d340000ce68 by thread T1:
[failed to restore the stack]
Location is heap block of size 201 at 0x7d340000ce60 allocated by main thread:
#0 operator new(unsigned long) <null> (test_bitcoin+0x000000510853)
#1 std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::reserve(unsigned long) <null> (libstdc++.so.6+0x00000011f87c)
#2 __libc_start_main <null> (libc.so.6+0x00000002082f)
Thread T2 (tid=25687, running) created by main thread at:
#0 pthread_create <null> (test_bitcoin+0x000000490b06)
#1 std::thread::_M_start_thread(std::shared_ptr<std::thread::_Impl_base>, void (*)()) <null> (libstdc++.so.6+0x0000000b8dc2)
#2 void std::vector<std::thread, std::allocator<std::thread> >::_M_emplace_back_aux<void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}>(void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/vector.tcc:416 (test_bitcoin+0x0000006139d1)
#3 void std::vector<std::thread, std::allocator<std::thread> >::emplace_back<void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}>(void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/vector.tcc:101 (test_bitcoin+0x0000006139d1)
#4 void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long) /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/test/cuckoocache_tests.cpp:218 (test_bitcoin+0x0000006139d1)
#5 cuckoocache_tests::cuckoocache_erase_parallel_ok::test_method() /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/test/cuckoocache_tests.cpp:264 (test_bitcoin+0x0000006139d1)
#6 cuckoocache_tests::cuckoocache_erase_parallel_ok_invoker() /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/test/cuckoocache_tests.cpp:261 (test_bitcoin+0x00000061329f)
#7 boost::unit_test::ut_detail::unused boost::unit_test::ut_detail::invoker<boost::unit_test::ut_detail::unused>::invoke<void (*)()>(void (*&)()) /usr/include/boost/test/utils/callback.hpp:56 (test_bitcoin+0x000000564e39)
#8 boost::unit_test::ut_detail::callback0_impl_t<boost::unit_test::ut_detail::unused, void (*)()>::invoke() /usr/include/boost/test/utils/callback.hpp:89 (test_bitcoin+0x000000564e39)
#9 boost::unit_test::test_case_filter::test_case_filter(boost::unit_test::basic_cstring<char const>) <null> (libboost_unit_test_framework.so.1.58.0+0x00000006acb0)
#10 __libc_start_main <null> (libc.so.6+0x00000002082f)
Thread T1 (tid=25686, finished) created by main thread at:
#0 pthread_create <null> (test_bitcoin+0x000000490b06)
#1 std::thread::_M_start_thread(std::shared_ptr<std::thread::_Impl_base>, void (*)()) <null> (libstdc++.so.6+0x0000000b8dc2)
#2 void std::vector<std::thread, std::allocator<std::thread> >::_M_emplace_back_aux<void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}>(void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/vector.tcc:416 (test_bitcoin+0x0000006139d1)
#3 void std::vector<std::thread, std::allocator<std::thread> >::emplace_back<void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}>(void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long)::{lambda()#1}&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/vector.tcc:101 (test_bitcoin+0x0000006139d1)
#4 void cuckoocache_tests::test_cache_erase_parallel<CuckooCache::cache<uint256, SignatureCacheHasher> >(unsigned long) /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/test/cuckoocache_tests.cpp:218 (test_bitcoin+0x0000006139d1)
#5 cuckoocache_tests::cuckoocache_erase_parallel_ok::test_method() /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/test/cuckoocache_tests.cpp:264 (test_bitcoin+0x0000006139d1)
#6 cuckoocache_tests::cuckoocache_erase_parallel_ok_invoker() /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/test/cuckoocache_tests.cpp:261 (test_bitcoin+0x00000061329f)
#7 boost::unit_test::ut_detail::unused boost::unit_test::ut_detail::invoker<boost::unit_test::ut_detail::unused>::invoke<void (*)()>(void (*&)()) /usr/include/boost/test/utils/callback.hpp:56 (test_bitcoin+0x000000564e39)
#8 boost::unit_test::ut_detail::callback0_impl_t<boost::unit_test::ut_detail::unused, void (*)()>::invoke() /usr/include/boost/test/utils/callback.hpp:89 (test_bitcoin+0x000000564e39)
#9 boost::unit_test::test_case_filter::test_case_filter(boost::unit_test::basic_cstring<char const>) <null> (libboost_unit_test_framework.so.1.58.0+0x00000006acb0)
#10 __libc_start_main <null> (libc.so.6+0x00000002082f)
SUMMARY: ThreadSanitizer: data race (/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/test/test_bitcoin+0x490510) in memcpy
``` | https://github.com/bitcoin/bitcoin/issues/14967 | https://github.com/bitcoin/bitcoin/pull/14969 | 9133227298ad97bbb10c44ac038f614c0bd7f7c7 | d98a29ec408590e54f405a7f8d232cd9dc5b14da | 2018-12-15T06:45:35Z | c++ | 2018-12-15T15:14:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,917 | ["doc/release-notes-14941.md", "src/init.cpp", "src/wallet/init.cpp", "src/wallet/rpcwallet.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h"] | wallet_multiwallet --usecli fails with "Duplicate -wallet filename specified" | On master, reported on IRC, appveyor and travis (macos):
Example backtrace:
```
wallet_multiwallet.py --usecli failed, Duration: 56 s
stdout:
2018-12-10T19:52:57.293000Z TestFramework (INFO): Initializing test directory C:\Users\appveyor\AppData\Local\Temp\1\test_runner_20181210_194416\wallet_multiwallet_70
2018-12-10T19:53:18.569000Z TestFramework (INFO): Do not allow -zapwallettxes with multiwallet
2018-12-10T19:53:19.332000Z TestFramework (INFO): Do not allow -salvagewallet with multiwallet
2018-12-10T19:53:19.839000Z TestFramework (INFO): Do not allow -upgradewallet with multiwallet
2018-12-10T19:53:32.857000Z TestFramework (INFO): Check for per-wallet settxfee call
2018-12-10T19:53:33.296000Z TestFramework (INFO): Test dynamic wallet loading
2018-12-10T19:53:36.907000Z TestFramework (INFO): Load first wallet
2018-12-10T19:53:37.476000Z TestFramework (INFO): Load second wallet
2018-12-10T19:53:38.049000Z TestFramework (INFO): Load remaining wallets
2018-12-10T19:53:41.485000Z TestFramework (INFO): Test dynamic wallet creation.
2018-12-10T19:53:43.012000Z TestFramework (INFO): Test dynamic wallet unloading
2018-12-10T19:53:47.773000Z TestFramework (INFO): Test wallet backup
2018-12-10T19:53:52.517000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
File "C:\projects\bitcoin\test\functional\test_framework\test_framework.py", line 173, in main
self.run_test()
File "C:\projects\bitcoin/test/functional/wallet_multiwallet.py", line 315, in run_test
self.nodes[0].loadwallet(wallet_name)
File "C:\projects\bitcoin\test\functional\test_framework\test_node.py", line 400, in __call__
return self.cli.send_cli(self.command, *args, **kwargs)
File "C:\projects\bitcoin\test\functional\test_framework\test_node.py", line 453, in send_cli
raise JSONRPCException(dict(code=int(code), message=message))
test_framework.authproxy.JSONRPCException: Wallet file verification failed: Error loading wallet w2. Duplicate -wallet filename specified. (-4) | https://github.com/bitcoin/bitcoin/issues/14917 | https://github.com/bitcoin/bitcoin/pull/14941 | c37851de5752f107c16e19317f28038b6b7ca2dc | 645e905c327411555073fa7964b36f652998059f | 2018-12-10T20:37:33Z | c++ | 2019-01-15T00:01:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,868 | ["src/rpc/rawtransaction.cpp", "src/test/rpc_tests.cpp", "src/wallet/rpcwallet.cpp", "test/functional/rpc_rawtransaction.py"] | Wrong transaction using bitcoin-cli and multiple op_return |
Using bitcoin-cli in order to generate a transaction with two op_return generate a wrong transaction.
```
bitcoin-cli createrawtransaction "[]" "{\"data\":\"ee\", \"data\":\"ff\"}"
0200000000020000000000000000036a01ee0000000000000000036a01ee00000000
```
Decoding the hex I obtain the following transaction with two op_return with the same value.
```
bitcoin-cli decoderawtransaction "0200000000020000000000000000036a01ee0000000000000000036a01ee00000000"
{
"txid": "ed4b691958a573c8569177606c77905ecd07c36eb5eec443f17a45427bb9f5fc",
"hash": "ed4b691958a573c8569177606c77905ecd07c36eb5eec443f17a45427bb9f5fc",
"version": 2,
"size": 34,
"vsize": 34,
"weight": 136,
"locktime": 0,
"vin": [
],
"vout": [
{
"value": 0.00000000,
"n": 0,
"scriptPubKey": {
"asm": "OP_RETURN -110",
"hex": "6a01ee",
"type": "nulldata"
}
},
{
"value": 0.00000000,
"n": 1,
"scriptPubKey": {
"asm": "OP_RETURN -110",
"hex": "6a01ee",
"type": "nulldata"
}
}
]
}
```
This incorrect behavior is related to the duplicate key "data" in the JSON passed to the "createrawtransaction" command.
The problem is related to the use of `outputs[name_].getValStr()` in an JSON with duplicated keys https://github.com/bitcoin/bitcoin/blob/master/src/rpc/rawtransaction.cpp#L432
Although this kind of transaction wouldn't be relayed, I thought about two possible solutions:
* raise an error as it happens for the use of two identical addresses, maybe calling `JSONRPCError(RPC_INVALID_PARAMETER ...` if more than one "data" field is recognized - easier to implement,
* creation of the transaction correctly containing the two different op_returns, maybe need to pass one array in the data field of the passed JSON (like `"data": ["ee", "ff"]`) - maybe require API change. | https://github.com/bitcoin/bitcoin/issues/14868 | https://github.com/bitcoin/bitcoin/pull/14890 | f8456256c8cb68562c6392c6f715b64fcdfa3fe7 | fa4c8679ed94f215ce895938f7c3c169a2ce101e | 2018-12-04T12:35:05Z | c++ | 2018-12-06T21:56:58Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,830 | ["configure.ac"] | --enable-debug default flags much less useful for introspection of variables | https://github.com/bitcoin/bitcoin/pull/13005 changed the flags from `O0` to `Og` when it can. For reasonable debugging experience I change this back, otherwise half the time I'm debugging something it's optimized out.
Would people be open to `--enable-debug-slow` or something that simply preferred `O0`? | https://github.com/bitcoin/bitcoin/issues/14830 | https://github.com/bitcoin/bitcoin/pull/16435 | 51a6e2c4192913c9c18507d8dfb3302500b26cc3 | d6ac25bdd96589a71006e3ab3f303b091ffaa9e4 | 2018-11-28T20:41:55Z | c++ | 2019-07-30T19:58:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,823 | ["src/rpc/rawtransaction_util.cpp", "test/functional/rpc_createmultisig.py"] | Confusing output when partial signing multisig transaction | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
Unexpected output during multisig signing. See the following example when signing a 2/2 key.
```
bc signrawtransactionwithkey 0200000001b8a7873d892de2930cdb00a6c69dadbe8d553e2bef0688186a71009fd82062460100000000ffffffff028093dc140000000017a914a732060d1955ab93c50c1096597e2ea466b9937d8780d6e34c0000000017a9142d2aad185524b244ef2b2f6a0507d6f187d02fbe8700000000 '["cU3C1Uu4oN8ZPXrCz55GyjmrsaeoF8UhmBai2d9jzq9iw7ty9EMc"]' '[{"txid":"466220d89f00716a188806ef2b3e558dbead9dc6a600db0c93e22d893d87a7b8", "vout":1,"scriptPubKey":"a9142d2aad185524b244ef2b2f6a0507d6f187d02fbe87","redeemScript":"5221032559b7054ff5468aa9508579379b62c5f6b31145e5bfe743fc66c0ec72608dab21030eaf6ea71e09bd6f6b10a3ee42cc1a445d9020627a4569f17b7fbf1d5801959a52ae"}]'
```
```
{
"hex": "0200000001b8a7873d892de2930cdb00a6c69dadbe8d553e2bef0688186a71009fd820624601000000920047304402202d3ccf2360f990235e2e0ce17f5f28f4313f413301869b554c4e79905de93508022009a4acd673571d7924e8c0cd192386972a72316e8195338ebb8577a2a2941ed70100475221032559b7054ff5468aa9508579379b62c5f6b31145e5bfe743fc66c0ec72608dab21030eaf6ea71e09bd6f6b10a3ee42cc1a445d9020627a4569f17b7fbf1d5801959a52aeffffffff028093dc140000000017a914a732060d1955ab93c50c1096597e2ea466b9937d8780d6e34c0000000017a9142d2aad185524b244ef2b2f6a0507d6f187d02fbe8700000000",
"complete": false,
"errors": [
{
"txid": "466220d89f00716a188806ef2b3e558dbead9dc6a600db0c93e22d893d87a7b8",
"vout": 1,
"witness": [
],
"scriptSig": "0047304402202d3ccf2360f990235e2e0ce17f5f28f4313f413301869b554c4e79905de93508022009a4acd673571d7924e8c0cd192386972a72316e8195338ebb8577a2a2941ed70100475221032559b7054ff5468aa9508579379b62c5f6b31145e5bfe743fc66c0ec72608dab21030eaf6ea71e09bd6f6b10a3ee42cc1a445d9020627a4569f17b7fbf1d5801959a52ae",
"sequence": 4294967295,
"error": "Signature must be zero for failed CHECK(MULTI)SIG operation"
}
]
}
```
```
bc signrawtransactionwithkey 0200000001b8a7873d892de2930cdb00a6c69dadbe8d553e2bef0688186a71009fd820624601000000920047304402202d3ccf2360f990235e2e0ce17f5f28f4313f413301869b554c4e79905de93508022009a4acd673571d7924e8c0cd192386972a72316e8195338ebb8577a2a2941ed70100475221032559b7054ff5468aa9508579379b62c5f6b31145e5bfe743fc66c0ec72608dab21030eaf6ea71e09bd6f6b10a3ee42cc1a445d9020627a4569f17b7fbf1d5801959a52aeffffffff028093dc140000000017a914a732060d1955ab93c50c1096597e2ea466b9937d8780d6e34c0000000017a9142d2aad185524b244ef2b2f6a0507d6f187d02fbe8700000000 '["cSB1o7v1QBZDHJropQqBYfuiUA4Js1o24uzkgB2vYeND1st5uGqV"]'
```
```
{
"hex": "0200000001b8a7873d892de2930cdb00a6c69dadbe8d553e2bef0688186a71009fd820624601000000d90047304402202d3ccf2360f990235e2e0ce17f5f28f4313f413301869b554c4e79905de93508022009a4acd673571d7924e8c0cd192386972a72316e8195338ebb8577a2a2941ed70147304402206fe3aa79e02894ec40d3f6e9df7d7056c5b50cd7a39e1cde3aa3dd097c76798f0220464cd0a39690cbf28687b3b695eb0dc59ca73aef624b16b9586ade31a0761b3101475221032559b7054ff5468aa9508579379b62c5f6b31145e5bfe743fc66c0ec72608dab21030eaf6ea71e09bd6f6b10a3ee42cc1a445d9020627a4569f17b7fbf1d5801959a52aeffffffff028093dc140000000017a914a732060d1955ab93c50c1096597e2ea466b9937d8780d6e34c0000000017a9142d2aad185524b244ef2b2f6a0507d6f187d02fbe8700000000",
"complete": true
}
```
<!--- What behavior did you expect? -->
When dealing with the RPC calls alone, it was difficult to realize that the partial signing was actually working. This is due to the this specific portion of the response:
```
"errors": [
{
"txid": "466220d89f00716a188806ef2b3e558dbead9dc6a600db0c93e22d893d87a7b8",
"vout": 1,
"witness": [
],
"scriptSig": "0047304402202d3ccf2360f990235e2e0ce17f5f28f4313f413301869b554c4e79905de93508022009a4acd673571d7924e8c0cd192386972a72316e8195338ebb8577a2a2941ed70100475221032559b7054ff5468aa9508579379b62c5f6b31145e5bfe743fc66c0ec72608dab21030eaf6ea71e09bd6f6b10a3ee42cc1a445d9020627a4569f17b7fbf1d5801959a52ae",
"sequence": 4294967295,
"error": "Signature must be zero for failed CHECK(MULTI)SIG operation"
}
```
Based on the RPC respons on here: https://bitcoin.org/en/developer-examples#p2sh-multisig
I expected the successful partial signature to be as follows:
```
{
"hex" : "010000000175e1769813db8418fea17576694af1ff31cb2b512\
b7333e6eb42f030d0d7787200000000b5004830450221008d5e\
c57d362ff6ef6602e4e756ef1bdeee12bd5c5c72697ef1455b3\
79c90531002202ef3ea04dfbeda043395e5bc701e4878c15baa\
b9c6ba5808eb3d04c91f641a0c014c69522103310188e911026\
cf18c3ce274e0ebb5f95b007f230d8cb7d09879d96dbeab1aff\
210243930746e6ed6552e03359db521b088134652905bd2d154\
1fa9124303a41e95621029e03a901b85534ff1e92c43c74431f\
7ce72046060fcf7a95c37e148f78c7725553aeffffffff01c0b\
c973b000000001976a914b6f64f5bf3e38f25ead28817df7929\
c06fe847ee88ac00000000",
"complete" : false
}
```
I'm using `Bitcoin Core RPC client version v0.17.0`
I suspect the issue is related to this: https://github.com/bitcoin/bitcoin/issues/9988, however they're using a different RPC call. | https://github.com/bitcoin/bitcoin/issues/14823 | https://github.com/bitcoin/bitcoin/pull/16251 | 3c481f8921bbc587cf287329f39243abe703b868 | ec4c79326bb670c2cc1757ecfb1900f8460c5257 | 2018-11-27T23:36:51Z | c++ | 2019-09-10T05:41:50Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,797 | ["ci/test/00_setup_env_mac.sh", "contrib/gitian-build.py", "contrib/gitian-descriptors/gitian-osx.yml", "contrib/macdeploy/README.md", "depends/hosts/darwin.mk", "depends/packages/native_cctools.mk", "depends/packages/qt.mk", "depends/patches/qt/mac-qmake.conf", "doc/build-osx.md"] | Bump macOS SDK version to 10.13 for gitian builds | http://doc-snapshots.qt.io/qt5-5.12/macos.html#supported-versions
It seems we must have 10.13+ SDK to build for macOS 10.14 . | https://github.com/bitcoin/bitcoin/issues/14797 | https://github.com/bitcoin/bitcoin/pull/16392 | ca5055a5aa07aba81a87cf12f6f0526a63c423b5 | 7e2104433cd0905ccf94632511b3ca0ce5b0463b | 2018-11-24T15:08:52Z | c++ | 2020-02-03T11:49:46Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,792 | ["test/functional/rpc_bind.py"] | rpc_bind tests failing locally for ipv6 and nonloopback | The following tests are failing locally here:
```
rpc_bind.py --ipv6 | ✖ Failed | 2 s
rpc_bind.py --nonloopback | ✖ Failed | 1 s
```
I haven't yet been able to investigate in depth, but I think this is caused by the changes in #14532. | https://github.com/bitcoin/bitcoin/issues/14792 | https://github.com/bitcoin/bitcoin/pull/14861 | c62b15118997030b007f04618cbca02d7abb1332 | f3cf95ffdfda935f28260eb34bf20c1449a200c5 | 2018-11-23T08:40:10Z | c++ | 2018-12-03T18:30:50Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,791 | ["test/functional/test_runner.py"] | `test_runner` command line doesn't allow running scripts with parameters | The following code is in `test_runner.py`:
```
# Individual tests have been specified. Run specified tests that exist
# in the ALL_SCRIPTS list. Accept the name with or without .py extension.
tests = [re.sub("\.py$", "", test) + ".py" for test in tests]
```
This adds `.py` to the end of the test name, making it impossible to run, say `rpc_bind.py --ipv6`. This test was failing here locally so I wanted to run it separately.
I think this step should be skipped if `.py` is already given.
Or alternatively, only applied to the first part of the test name and not arguments.
| https://github.com/bitcoin/bitcoin/issues/14791 | https://github.com/bitcoin/bitcoin/pull/14795 | 2607c38fc5170409dd13f3061ba5e5fa2de6438d | 5c40e7b91a642d93d49f2b81ff9550a9138f18ac | 2018-11-23T08:34:18Z | c++ | 2018-11-23T17:02:24Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,765 | ["src/rpc/blockchain.cpp"] | getrawmempool true RPC call is O(n^2) | When the mempool fills the verbose `getrawmempool` RPC call gets really slow. It can take minutes for >100k transactions in the mempool.
The culprit is the univalue library. Objects are implemented as a big list, but the library checks for duplicate keys. So inserting n key-value pairs into an object takes O(n^2).
Possible fixes:
- Improve univalue library by using linked hash maps.
- change the RPC output format of getrawmempool to use a list of objects, instead of an object of objects. But this breaks existing code.
- hack the library to be able to skip the duplicate check.
| https://github.com/bitcoin/bitcoin/issues/14765 | https://github.com/bitcoin/bitcoin/pull/14984 | efed9809b4fab34e33c3012aa3cf4b7a75d98ead | 2d5cf4c41d86f2bdd1df99edc130ade1d093258f | 2018-11-19T21:20:28Z | c++ | 2019-03-08T15:50:18Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,758 | ["test/functional/rpc_users.py"] | Integration tests that use rpcauth.py | We have unit tests from https://github.com/bitcoin/bitcoin/pull/13056, but no integration tests. Could be done with @jnewbery's second method in https://github.com/bitcoin/bitcoin/issues/12995#issuecomment-383416452 | https://github.com/bitcoin/bitcoin/issues/14758 | https://github.com/bitcoin/bitcoin/pull/16334 | 830dc2dd0fccb7f3ec49ff7233a188d92c541e7e | e263a343d4b6a2622df6bb734cd9d51a0d20a663 | 2018-11-19T15:56:22Z | c++ | 2019-07-08T20:13:35Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,732 | ["test/functional/test_framework/test_framework.py", "test/functional/wallet_listtransactions.py"] | test/functional/test_runner.py wallet_listtransactions.py fails when run individually | When I run complete functional tests using `test/functional/test_runner.py`, all tests pass. Also, when I run `test/functional/wallet_listtransactions.py` individually, it is successfull.
```
$ test/functional/wallet_listtransactions.py
2018-11-15T22:08:25.288000Z TestFramework (INFO): Initializing test directory /tmp/test60gysa60
2018-11-15T22:08:51.034000Z TestFramework (INFO): Stopping nodes
2018-11-15T22:08:51.998000Z TestFramework (INFO): Cleaning up /tmp/test60gysa60 on exit
2018-11-15T22:08:51.998000Z TestFramework (INFO): Tests successful
```
But when I run `test/functional/test_runner.py wallet_listtransactions.py`, it always fails with the "AssertionError: Mempool sync timed out".
```
$ LC_ALL=lv_LV.UTF-8 test/functional/test_runner.py wallet_listtransactions.py
Temporary test directory at /tmp/test_runner_₿_🏃_20181116_001822
WARNING! There is already a bitcoind process running on this system. Tests may fail unexpectedly due to resource contention!
1/1 - wallet_listtransactions.py failed, Duration: 84 s
stdout:
2018-11-15T22:18:22.640000Z TestFramework (INFO): Initializing test directory /tmp/test_runner_₿_🏃_20181116_001822/wallet_listtransactions_0
2018-11-15T22:19:45.625000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "XXX/bitcoin/test/functional/test_framework/test_framework.py", line 171, in main
self.run_test()
File "XXX/bitcoin/test/functional/wallet_listtransactions.py", line 36, in run_test
self.sync_all()
File "XXX/bitcoin/test/functional/test_framework/test_framework.py", line 372, in sync_all
sync_mempools(group)
File "XXX/bitcoin/test/functional/test_framework/util.py", line 408, in sync_mempools
raise AssertionError("Mempool sync timed out:{}".format("".join("\n {!r}".format(m) for m in pool)))
AssertionError: Mempool sync timed out:
{'88a5f9e47a8617c29eb2330d06cb8af84e30dbcf8276c018b522af9d2cfbf297'}
set()
2018-11-15T22:19:45.682000Z TestFramework (INFO): Stopping nodes
2018-11-15T22:19:46.646000Z TestFramework (WARNING): Not cleaning up dir /tmp/test_runner_₿_🏃_20181116_001822/wallet_listtransactions_0
2018-11-15T22:19:46.646000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/test_runner_₿_🏃_20181116_001822/wallet_listtransactions_0/test_framework.log
2018-11-15T22:19:46.648000Z TestFramework (ERROR): Hint: Call XXX/bitcoin/test/functional/combine_logs.py '/tmp/test_runner_₿_🏃_20181116_001822/wallet_listtransactions_0' to consolidate all logs
stderr:
TEST | STATUS | DURATION
wallet_listtransactions.py | ✖ Failed | 84 s
ALL | ✖ Failed | 84 s (accumulated)
Runtime: 84 s
```
Looked at logs mentioned in output, but could not find anything suspicous there.
Is it a bug or feature? :) Any ideas?
It is with current master. | https://github.com/bitcoin/bitcoin/issues/14732 | https://github.com/bitcoin/bitcoin/pull/14738 | 35739976c1d9ad250ece573980c57e7e7976ae23 | 2474de02650b97e14c4f3330dd04add1b84347b6 | 2018-11-15T22:27:25Z | c++ | 2018-11-16T20:26:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,702 | ["src/init.cpp", "src/util/system.cpp", "src/util/system.h", "test/functional/feature_config_args.py"] | Warn if unrecognised sections are present in bitcoin.conf | Suggested by @MarcoFalke after #14627 and possibly #14420. We should warn if an unrecognised/incorrect section is present in bitcoin.conf. i.e `[testnet]` is present instead of `[test]`. | https://github.com/bitcoin/bitcoin/issues/14702 | https://github.com/bitcoin/bitcoin/pull/14708 | 1b99d153d0713ec62b3bde7adbe78c271b5a36ea | 3fb09b9889665a24b34f25e9d1385a05058a28b7 | 2018-11-10T09:59:09Z | c++ | 2018-11-20T09:28:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,699 | ["doc/build-windows.md"] | docs: Windows build docs are missing `make deploy` | When building for Windows (using `doc/build-windows.md`), I discovered the following steps were necessary but undocumented, in order to generate the installer:
```
sudo apt install nsis
make deploy
makensis share/setup.nsi
``` | https://github.com/bitcoin/bitcoin/issues/14699 | https://github.com/bitcoin/bitcoin/pull/14950 | 20c54eef6e41216a99b16bab2b5a7c0fb701f46e | 82687b5034921b7906915bd0a33e84abb5825fb2 | 2018-11-09T19:35:31Z | c++ | 2018-12-13T14:52:17Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,677 | ["src/Makefile.qt.include"] | Build Windows wallet issue | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
<!--- What behavior did you expect? -->
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
When I tried to build windows wallet on WSL as written on build-windows.md, I am getting these errors, and failure on this.
Please help me how to fix these issues.
> OBJCXXLD qt/bitcoin-qt.exe
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x4e1): undefined reference to `SSL_accept'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x4f1): undefined reference to `SSL_clear'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x501): undefined reference to `SSL_CIPHER_description'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x511): undefined reference to `SSL_CIPHER_get_bits'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x521): undefined reference to `SSL_connect'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x531): undefined reference to `SSL_CTX_check_private_key'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x541): undefined reference to `SSL_CTX_ctrl'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x551): undefined reference to `SSL_CTX_free'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x561): undefined reference to `SSL_CTX_new'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x571): undefined reference to `SSL_CTX_set_cipher_list'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x581): undefined reference to `SSL_CTX_set_default_verify_paths'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x591): undefined reference to `SSL_CTX_set_verify'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x5a1): undefined reference to `SSL_CTX_set_verify_depth'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x5b1): undefined reference to `SSL_CTX_use_certificate'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x5c1): undefined reference to `SSL_CTX_use_certificate_file'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x5d1): undefined reference to `SSL_CTX_use_PrivateKey'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x5e1): undefined reference to `SSL_CTX_use_RSAPrivateKey'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x5f1): undefined reference to `SSL_CTX_use_PrivateKey_file'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x601): undefined reference to `SSL_CTX_get_cert_store'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x611): undefined reference to `SSL_free'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x621): undefined reference to `SSL_get_ciphers'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x631): undefined reference to `SSL_get_current_cipher'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x641): undefined reference to `SSL_version'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x651): undefined reference to `SSL_get_error'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x661): undefined reference to `SSL_get_peer_cert_chain'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x671): undefined reference to `SSL_get_peer_certificate'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x681): undefined reference to `SSL_get_verify_result'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x691): undefined reference to `SSL_library_init'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x6a1): undefined reference to `SSL_load_error_strings'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x6b1): undefined reference to `SSL_new'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x6c1): undefined reference to `SSL_ctrl'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x6d1): undefined reference to `SSL_read'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x6e1): undefined reference to `SSL_set_bio'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x6f1): undefined reference to `SSL_set_accept_state'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x701): undefined reference to `SSL_set_connect_state'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x711): undefined reference to `SSL_shutdown'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x721): undefined reference to `SSL_set_session'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x731): undefined reference to `SSL_SESSION_free'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x741): undefined reference to `SSL_get1_session'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x751): undefined reference to `SSL_get_session'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x761): undefined reference to `SSL_get_ex_new_index'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x771): undefined reference to `SSL_set_ex_data'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x781): undefined reference to `SSL_get_ex_data'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x791): undefined reference to `SSL_set_psk_client_callback'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x7a1): undefined reference to `SSL_set_psk_server_callback'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x7b1): undefined reference to `SSL_CTX_use_psk_identity_hint'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x7c1): undefined reference to `SSLv3_client_method'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x7d1): undefined reference to `SSLv23_client_method'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x7e1): undefined reference to `TLSv1_client_method'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x7f1): undefined reference to `TLSv1_1_client_method'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x801): undefined reference to `TLSv1_2_client_method'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x811): undefined reference to `SSLv3_server_method'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x821): undefined reference to `SSLv23_server_method'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x831): undefined reference to `TLSv1_server_method'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x841): undefined reference to `TLSv1_1_server_method'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x851): undefined reference to `TLSv1_2_server_method'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0x861): undefined reference to `SSL_write'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0xac1): undefined reference to `SSL_CTX_load_verify_locations'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0xaf1): undefined reference to `i2d_SSL_SESSION'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0xb01): undefined reference to `d2i_SSL_SESSION'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0xb11): undefined reference to `SSL_select_next_proto'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0xb21): undefined reference to `SSL_CTX_set_next_proto_select_cb'
> /home/god/bitcoin/depends/x86_64-w64-mingw32/share/../lib/libQt5Network.a(qsslsocket_openssl_symbols.o):qsslsocket_openssl_symbols.cpp:(.text+0xb31): undefined reference to `SSL_get0_next_proto_negotiated'
> collect2: error: ld returned 1 exit status
> Makefile:3927: recipe for target 'qt/bitcoin-qt.exe' failed
> make[2]: *** [qt/bitcoin-qt.exe] Error 1
> make[2]: Leaving directory '/home/god/bitcoin/src'
> Makefile:10249: recipe for target 'all-recursive' failed
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory '/home/god/bitcoin/src'
> Makefile:774: recipe for target 'all-recursive' failed
> make: *** [all-recursive] Error 1 | https://github.com/bitcoin/bitcoin/issues/14677 | https://github.com/bitcoin/bitcoin/pull/14686 | 11e1ac3ae08535cefbd8235a8deb6cd100bcb2b1 | 7a90b1b9d8d3297959c2d339192d8c90fb632db6 | 2018-11-07T10:33:40Z | c++ | 2018-11-07T21:03:14Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,662 | ["src/wallet/rpcdump.cpp", "test/functional/wallet_importmulti.py"] | [wallet] importmulti doesn't honor `internal` flag | Specifically, it adds an address into the wallet.
Easy to test now thanks to https://github.com/bitcoin/bitcoin/pull/14410
```
diff --git a/test/functional/wallet_importmulti.py b/test/functional/wallet_importmulti.py
index 9ba6860..bff37b2 100755
--- a/test/functional/wallet_importmulti.py
+++ b/test/functional/wallet_importmulti.py
@@ -95,6 +95,7 @@ class ImportMultiTest(BitcoinTestFramework):
assert_equal(address_assert['iswatchonly'], True)
assert_equal(address_assert['ismine'], False)
assert_equal(address_assert['timestamp'], timestamp)
+ assert_equal(address_assert['ischange'], True)
# ScriptPubKey + internal + label
self.log.info("Should not allow a label to be specified when internal is true")
```
| https://github.com/bitcoin/bitcoin/issues/14662 | https://github.com/bitcoin/bitcoin/pull/14679 | 6b8d0a2164b30eab76e7bccb1ffb056a10fba406 | 7afddfa8cefd01249ad59cf2370e7cec90b34f6f | 2018-11-05T17:27:40Z | c++ | 2018-11-07T19:43:14Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,661 | ["test/functional/feature_block.py", "test/functional/p2p_invalid_block.py"] | p2p_invalid_block occasionally fails "bad-txns-inputs-duplicate" | Short log:
```
p2p_invalid_block.py failed, Duration: 1 s
stdout:
2018-11-05T15:27:36.459000Z TestFramework (INFO): Initializing test directory /tmp/test_runner_₿_🏃_20181105_152228/p2p_invalid_block_46
2018-11-05T15:27:36.778000Z TestFramework (INFO): Create a new block with an anyone-can-spend coinbase
2018-11-05T15:27:36.890000Z TestFramework (INFO): Mature the block.
2018-11-05T15:27:37.238000Z TestFramework (INFO): Test merkle root malleability.
2018-11-05T15:27:37.301000Z TestFramework (INFO): Test duplicate input block.
2018-11-05T15:27:37.354000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/test_framework.py", line 171, in main
self.run_test()
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/p2p_invalid_block.py", line 92, in run_test
node.p2p.send_blocks_and_test([block2_orig], node, success=False, request_block=False, reject_reason='bad-txns-inputs-duplicate')
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/mininode.py", line 543, in send_blocks_and_test
assert node.getbestblockhash() != blocks[-1].hash
File "/usr/lib/python3.5/contextlib.py", line 66, in __exit__
next(self.gen)
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/test_node.py", line 272, in assert_debug_log
self._raise_assertion_error('Expected message "{}" does not partially match log:\n\n{}\n\n'.format(expected_msg, print_log))
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/test_node.py", line 124, in _raise_assertion_error
raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected message "bad-txns-inputs-duplicate" does not partially match log:
- 2018-11-05T15:27:37.312967Z received: headers (82 bytes) peer=0
- 2018-11-05T15:27:37.313141Z Requesting block 0b1e6087126df7c86349cec8019ee7134f485c79ad89e9ed180325c5b73cd878 from peer=0
- 2018-11-05T15:27:37.313156Z sending getdata (37 bytes) peer=0
- 2018-11-05T15:27:37.316649Z received: ping (8 bytes) peer=0
- 2018-11-05T15:27:37.316675Z sending pong (8 bytes) peer=0
- 2018-11-05T15:27:37.318279Z received: block (327 bytes) peer=0
- 2018-11-05T15:27:37.318321Z received block 0b4699cec0641f2d47013551446930cf165dfbcde6ff4440695e0678dd417068 peer=0
- 2018-11-05T15:27:37.318358Z Misbehaving: 127.0.0.1:51816 peer=0 (3100 -> 3200)
- 2018-11-05T15:27:37.318372Z ERROR: ProcessNewBlock: AcceptBlock FAILED (bad-txns-duplicate, duplicate transaction (code 16))
- 2018-11-05T15:27:37.353006Z Received a POST request for / from 127.0.0.1:34964
- 2018-11-05T15:27:37.353084Z ThreadRPCServer method=getbestblockhash user=__cookie__
```
Full log: https://travis-ci.org/bitcoin/bitcoin/jobs/450901528 | https://github.com/bitcoin/bitcoin/issues/14661 | https://github.com/bitcoin/bitcoin/pull/14700 | 6c787d340cdb67bbdc508b562283750c7ed5dfa8 | fa2156820877caf70fc09c7e6244b7cde6ebaf29 | 2018-11-05T16:15:24Z | c++ | 2018-11-09T20:46:58Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,654 | ["doc/release-notes-14707.md", "src/rpc/client.cpp", "src/wallet/rpcwallet.cpp", "test/functional/wallet_listreceivedby.py"] | received wallet rpc calls do not include coinbase outputs | `getreceivedbyaddress` and `listreceivedbyaddress` do not add amounts received from coinbase transactions. They are explicitly filtered out. Is there a reason for them not being included? | https://github.com/bitcoin/bitcoin/issues/14654 | https://github.com/bitcoin/bitcoin/pull/14707 | eaf1c56502455006962ee50390d7485befde0869 | 63c63b5533e8d1c682aae3ae6d35b76836ab8341 | 2018-11-05T02:17:56Z | c++ | 2021-12-07T19:52:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,591 | ["src/qt/bitcoingui.cpp", "src/qt/bitcoingui.h"] | Minimized window bug on Linux | If the main window has been minimized to the taskbar (iconified) calling "Show/Hide", "Send" or "Receive" actions from the tray icon menu has no effect: the main window still minimized.
It seems like a Qt bug similar to that old [one](https://bugreports.qt.io/browse/QTBUG-31117).
Tested platform: Linux Mint 19, Qt 5.9.5 / 5.9.6 | https://github.com/bitcoin/bitcoin/issues/14591 | https://github.com/bitcoin/bitcoin/pull/14594 | c651265c934c84c683aa054f2a456b12acc41590 | a88640e123ca0c00d81719f9a009699c26e85b90 | 2018-10-28T11:32:12Z | c++ | 2019-01-04T18:01:20Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,542 | ["doc/release-notes-25375.md", "src/wallet/rpc/spend.cpp", "test/functional/rpc_psbt.py", "test/functional/wallet_fundrawtransaction.py", "test/functional/wallet_send.py", "test/functional/wallet_sendall.py"] | fundrawtransaction - select input transaction with minimum confirmations | when using to fundrawtransaction, how to select input transaction with minimum confirmations option ? @jonasschnelli what's default option for funded when select inputs ? | https://github.com/bitcoin/bitcoin/issues/14542 | https://github.com/bitcoin/bitcoin/pull/25375 | 599e941c194749dab35d81a4e898fd79dd2ed129 | b55b11f92a4717bfbe9214d134b1941effcb391a | 2018-10-22T17:44:06Z | c++ | 2023-01-16T22:23:51Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,538 | ["src/wallet/db.cpp", "src/wallet/db.h", "src/wallet/wallet.cpp", "test/functional/wallet_multiwallet.py"] | loadwallet command crashes bitcoind | `bitcoin-cli loadwallet "wallet.dat"` command causes bitcoind crash
log info:
```
bitcoind: wallet/db.cpp:236: BerkeleyEnvironment::VerifyResult BerkeleyEnvironment::Verify(const string&, BerkeleyEnvironment::recoverFunc_type, std::__cxx11::string&): Assertion `mapFileUseCount.count(strFile) == 0' failed.
Aborted (core dumped)
```
Bitcoin Core Daemon version `v0.17.0.0-ge1ed37edaedc85b8c3468bd9a726046344036243`
| https://github.com/bitcoin/bitcoin/issues/14538 | https://github.com/bitcoin/bitcoin/pull/14552 | 15c93f075a881deb3ad7b1dd8a4516a9b06e5e11 | 591203149f1700f594f781862e88cbbfe83d8d37 | 2018-10-21T18:54:09Z | c++ | 2018-11-08T03:54:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,503 | ["doc/release-notes-14477.md", "src/rpc/blockchain.cpp", "src/script/descriptor.cpp", "src/script/descriptor.h", "src/script/sign.h", "src/test/descriptor_tests.cpp", "src/wallet/rpcwallet.cpp", "test/functional/rpc_scantxoutset.py", "test/functional/wallet_address_types.py"] | scantxoutset does not identify UTXO origins | This is related to #14150 and possibly others, but it's actually a separate issue.
For instance, when using the following query:
`bitcoin-cli scantxoutset start '[{"desc":"wpkh(xpubABCDEF/0/*)", "range":100}]'`
I can get a list of UTXOs, but no way to get back the index which derived that particular UTXO. So it's not much better than deriving on the user side and specifying addresses one by one, so that I already have a cache of addresses to match.
Not sure what the solution looks like. One way is to repeat the full descriptor in the utxo. That might get verbose though. | https://github.com/bitcoin/bitcoin/issues/14503 | https://github.com/bitcoin/bitcoin/pull/14477 | b65326b562cde20aab709a953e396997a6cacbd6 | 109699dd33c72539fc33619f7836b8088f63182c | 2018-10-17T15:21:43Z | c++ | 2018-11-14T22:21:42Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,499 | ["src/rpc/blockchain.cpp", "test/functional/rpc_getblockstats.py"] | getblockstats run with no special aguments either works or doesn't work without txindex enabled, based on what block you call it on | [gmaxwell@argonaut src]$ ./bitcoin-cli getblockstats 101
{
"avgfee": 0,
"avgfeerate": 0,
"avgtxsize": 0,
"blockhash": "00000000b69bd8e4dc60580117617a466d5c76ada85fb7b87e9baea01f9d9984",
"feerate_percentiles": [
0,
0,
0,
0,
0
],
"height": 101,
"ins": 0,
"maxfee": 0,
"maxfeerate": 0,
"maxtxsize": 0,
"medianfee": 0,
"mediantime": 1231657185,
"mediantxsize": 0,
"minfee": 0,
"minfeerate": 0,
"mintxsize": 0,
"outs": 1,
"subsidy": 5000000000,
"swtotal_size": 0,
"swtotal_weight": 0,
"swtxs": 0,
"time": 1231661741,
"total_out": 0,
"total_size": 0,
"total_weight": 0,
"totalfee": 0,
"txs": 1,
"utxo_increase": 1,
"utxo_size_inc": 117
}
[gmaxwell@argonaut src]$ ./bitcoin-cli getblockstats 100000
error code: -8
error message:
One or more of the selected stats requires -txindex enabled
Stats that require txindex should always fail if txindex isn't enabled and the stat is requested, and those stats should not be offered by default.
Also, although the help says it will accept a '1. "hash_or_height" (string or numeric, required) The block hash or height of the target block', that doesn't seem to work regardless of how I quote it.
[gmaxwell@argonaut src]$ ./bitcoin-cli getblockstats "0000000000000000001b98c07fca289e1ca3358aeabdcca9b7f7ba704d83a3d4"
error: Error parsing JSON:0000000000000000001b98c07fca289e1ca3358aeabdcca9b7f7ba704d83a3d4
| https://github.com/bitcoin/bitcoin/issues/14499 | https://github.com/bitcoin/bitcoin/pull/14518 | d387507aeca652a5569825af65243536f2ce26ea | 3be209d103297aaf2fe4711e237a65046488ea19 | 2018-10-16T23:26:26Z | c++ | 2018-10-19T14:28:41Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,473 | ["src/rpc/rawtransaction.cpp", "src/script/sign.cpp", "src/script/sign.h", "src/wallet/rpcwallet.cpp", "src/wallet/rpcwallet.h", "src/wallet/test/psbt_wallet_tests.cpp", "test/functional/rpc_psbt.py"] | walletprocesspsbt can generate unparseable PSBT | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
Starting with the following unsigned transaction:
```
cHNidP8BAHMCAAAAAXg6mTOjO3d9K0RiVOr87oYRYhYB/Bpomi66nXc85ebsAAAAAAD9////Avs+EQAAAAAAF6kU4lwd88Ejsg5sG0iVOiL2/c05MHKHoIYBAAAAAAAXqRSxG32ZtPml0iJQGDVxp82wjHBD+4cs7RUAAAEBIHZOFQAAAAAAF6kUP2yi0rx2ke1Lmdk5gsR+WIvukb+HAQQWABSL8jhHTVLizeYj0cS1ClE18i8jbCIGAnwLKYOB2pXhdmi+i21xj17Np67DQdv7RPiIVKqOrp++ENZSlGkAAACAAQAAgAAAAIAAAQAWABSLPsswJus4oRP6Zq1BmWcxI5hNQiICAgi7iTon5Hy59yU96uKT12AU4/bhxQy7CeEdkfg5sZLoENZSlGkAAACAAQAAgAEAAIAAAQAWABQ6Ram/bbw29IPN92ylIqYKhU1ThyICA3oH7xQc22oDM2dG6g/VZ05JLscr/hEQKUI4fTMKvUjRENZSlGkAAACAAAAAgAAAAIAA
```
I first call:
```
walletprocesspsbt "cHNidP8BAHMCAAAAAXg6mTOjO3d9K0RiVOr87oYRYhYB/Bpomi66nXc85ebsAAAAAAD9////Avs+EQAAAAAAF6kU4lwd88Ejsg5sG0iVOiL2/c05MHKHoIYBAAAAAAAXqRSxG32ZtPml0iJQGDVxp82wjHBD+4cs7RUAAAEBIHZOFQAAAAAAF6kUP2yi0rx2ke1Lmdk5gsR+WIvukb+HAQQWABSL8jhHTVLizeYj0cS1ClE18i8jbCIGAnwLKYOB2pXhdmi+i21xj17Np67DQdv7RPiIVKqOrp++ENZSlGkAAACAAQAAgAAAAIAAAQAWABSLPsswJus4oRP6Zq1BmWcxI5hNQiICAgi7iTon5Hy59yU96uKT12AU4/bhxQy7CeEdkfg5sZLoENZSlGkAAACAAQAAgAEAAIAAAQAWABQ6Ram/bbw29IPN92ylIqYKhU1ThyICA3oH7xQc22oDM2dG6g/VZ05JLscr/hEQKUI4fTMKvUjRENZSlGkAAACAAAAAgAAAAIAA" true ALL true
```
Which generates:
```
cHNidP8BAHMCAAAAAXg6mTOjO3d9K0RiVOr87oYRYhYB/Bpomi66nXc85ebsAAAAAAD9////Avs+EQAAAAAAF6kU4lwd88Ejsg5sG0iVOiL2/c05MHKHoIYBAAAAAAAXqRSxG32ZtPml0iJQGDVxp82wjHBD+4cs7RUAAAEBIHZOFQAAAAAAF6kUP2yi0rx2ke1Lmdk5gsR+WIvukb+HAQcXFgAUi/I4R01S4s3mI9HEtQpRNfIvI2wBCGsCRzBEAiBRE2oCVM2cMWAjt9c17fFUkhcDQmc4aQVDGHp1wnvHbwIgGrV1hMs6ZAbOQL1Dqn06rWOFV3LKzVDglS3v2BQswsABIQJ8CymDgdqV4XZovottcY9ezaeuw0Hb+0T4iFSqjq6fvgABABYAFIs+yzAm6zihE/pmrUGZZzEjmE1CIgICCLuJOifkfLn3JT3q4pPXYBTj9uHFDLsJ4R2R+DmxkugQ1lKUaQAAAIABAACAAQAAgAABABYAFDpFqb9tvDb0g833bKUipgqFTVOHIgIDegfvFBzbagMzZ0bqD9VnTkkuxyv+ERApQjh9Mwq9SNEQ1lKUaQAAAIAAAACAAAAAgAA=
```
Which is "complete: true" and parses fine. But then if I run `walletprocesspsbt` on the result AGAIN (don't ask why ... or do, but this should be idempotent):
```
walletprocesspsbt "cHNidP8BAHMCAAAAAXg6mTOjO3d9K0RiVOr87oYRYhYB/Bpomi66nXc85ebsAAAAAAD9////Avs+EQAAAAAAF6kU4lwd88Ejsg5sG0iVOiL2/c05MHKHoIYBAAAAAAAXqRSxG32ZtPml0iJQGDVxp82wjHBD+4cs7RUAAAEBIHZOFQAAAAAAF6kUP2yi0rx2ke1Lmdk5gsR+WIvukb+HAQcXFgAUi/I4R01S4s3mI9HEtQpRNfIvI2wBCGsCRzBEAiBRE2oCVM2cMWAjt9c17fFUkhcDQmc4aQVDGHp1wnvHbwIgGrV1hMs6ZAbOQL1Dqn06rWOFV3LKzVDglS3v2BQswsABIQJ8CymDgdqV4XZovottcY9ezaeuw0Hb+0T4iFSqjq6fvgABABYAFIs+yzAm6zihE/pmrUGZZzEjmE1CIgICCLuJOifkfLn3JT3q4pPXYBTj9uHFDLsJ4R2R+DmxkugQ1lKUaQAAAIABAACAAQAAgAABABYAFDpFqb9tvDb0g833bKUipgqFTVOHIgIDegfvFBzbagMzZ0bqD9VnTkkuxyv+ERApQjh9Mwq9SNEQ1lKUaQAAAIAAAACAAAAAgAA=" true ALL true
```
I get the following:
```
cHNidP8BAHMCAAAAAXg6mTOjO3d9K0RiVOr87oYRYhYB/Bpomi66nXc85ebsAAAAAAD9////Avs+EQAAAAAAF6kU4lwd88Ejsg5sG0iVOiL2/c05MHKHoIYBAAAAAAAXqRSxG32ZtPml0iJQGDVxp82wjHBD+4cs7RUAAAEAigIAAAABLi4h8ViD8SvykywwbO+Tv4GCnfVXwX8TIvfUV85wZgkAAAAAFxYAFNiGEusp8/GHaPxQSib0noXXSyxe/f///wJ2ThUAAAAAABepFD9sotK8dpHtS5nZOYLEfliL7pG/h6CGAQAAAAAAF6kUsRt9mbT5pdIiUBg1cafNsIxwQ/uHF5gVAAEHFxYAFIvyOEdNUuLN5iPRxLUKUTXyLyNsAQhrAkcwRAIgURNqAlTNnDFgI7fXNe3xVJIXA0JnOGkFQxh6dcJ7x28CIBq1dYTLOmQGzkC9Q6p9Oq1jhVdyys1Q4JUt79gULMLAASECfAspg4HaleF2aL6LbXGPXs2nrsNB2/tE+IhUqo6un74AAQAWABSLPsswJus4oRP6Zq1BmWcxI5hNQiICAgi7iTon5Hy59yU96uKT12AU4/bhxQy7CeEdkfg5sZLoENZSlGkAAACAAQAAgAEAAIAAAQAWABQ6Ram/bbw29IPN92ylIqYKhU1ThyICA3oH7xQc22oDM2dG6g/VZ05JLscr/hEQKUI4fTMKvUjRENZSlGkAAACAAAAAgAAAAIAA
```
Which is still reported as "complete: true", but when I try to decode or finalize it:
```TX decode failed PSBT is not sane.: unspecified iostream_category error (code -22)```
I would expect `walletprocesspsbt [foo] true ALL true` to be idempotent, or at least produce output that's parseable.
This is all testnet and I have attached the wallet.dat in case it's useful (it only has two UTXOs and very few keys.).
I am going to continue trying to debug this, but I figured since I haven't gotten it yet I should document it. Please let me know if someone else starts looking into it.
| https://github.com/bitcoin/bitcoin/issues/14473 | https://github.com/bitcoin/bitcoin/pull/14588 | 565500508aa5df0011109ebf375ba71b693fc7de | e13fea975d5e4ae961faba36379a1cdaf9e50c1c | 2018-10-13T08:31:03Z | c++ | 2018-11-01T19:14:21Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,452 | ["src/wallet/rpcwallet.cpp", "test/functional/wallet_multiwallet.py"] | Unloading a wallet with in timeframe that is unlocked for crashes RPC server without any log/trace | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
Describe the issue
For example, you unlock a wallet with "walletpassphrase" command for next 10 seconds, but for some reason unload wallet command is called before the wallet is locked again, it causes RPC server to crash and I didn't find any relevant help from debug.log file
This is important because whole idea of dynamically loading/unloading wallet is to help build applications that can work with multiple wallets more effectively, while its easy for an application to load all and every wallet but in our case we want to unload wallet right after necessary commands have passed (i.e. in PHP OOP I have registered a shutdown function for all wallets instances to automatically unload)
What behavior did you expect?
unload command to return an error message in such circumstances
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
How reliably can you reproduce the issue, what are the steps to do so?
1. Call "walletpassphrase" to unlock wallet for next N seconds
2. Issue "unloadwallet" command before those N seconds have passed
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/14452 | https://github.com/bitcoin/bitcoin/pull/14453 | 321decffa1fbf213462d97e5372bd0c4eeb99635 | 8907df9e02ec47ef249a7422faa766f06aa01e94 | 2018-10-09T22:31:27Z | c++ | 2018-10-20T10:02:35Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,446 | ["test/functional/feature_proxy.py", "test/functional/mempool_accept.py", "test/functional/rpc_blockchain.py", "test/functional/test_framework/test_framework.py", "test/functional/test_framework/test_node.py", "test/functional/wallet_create_tx.py", "test/functional/wallet_txn_doublespend.py"] | tests: Some issue about running functional tests on Windows | Since #14007, the functional tests would run on Appveyor CI. However the tests would fail occassionally due to several reasons. Here is the list:
- [x] `ConnectionAbortedError: [WinError 10053]` might be a race condition
***Maybe fixed by #14670***
For reference:
https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/19366470
https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/19344806
- [x] `PermissionError: [WinError 32]`: found in `feature_notifications`. The test script delete the files before the notification command close the file.
***Maybe fixed by #14465***
For reference:
https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/19363071
https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/19342222
- [ ] `OSError: [WinError 10022] An invalid argument was supplied`: Unknown reason.
***One-off?***
For reference:
https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/19365696
- [x] ` AssertionError: Block sync timed out`: Unknown reason. Found in `wallet_txn_doublespend`
For reference:
***Maybe fixed by #15419***
https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/19360284
https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/19334394
https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/20031316
- [x] `PermissionError: [Errno 13] Permission denied`: Unknown reason. Found in `get_auth_cookie` function
***Maybe fixed by #14788***
For reference:
https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/19324004
https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/19393533
If you find any fail that is not listed here. Please comment below. | https://github.com/bitcoin/bitcoin/issues/14446 | https://github.com/bitcoin/bitcoin/pull/15419 | fa25210d6266d50a6c2bfd6d96062bacb2ae393b | fa2cdc9ac2672301591cafceb8ff230b95425ad0 | 2018-10-09T16:34:50Z | c++ | 2019-02-25T16:18:24Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,415 | ["src/script/sign.cpp"] | watch only multisig scripts require pubkeys to be imported to flag them solvable | Use case: **decouple keys from the wallet** (via importing scripts and fundrawtransaction with watch-only).
**Problem:** multisig inputs are flagged as non-spendable even if importing both the multisig P2SH `scriptPubKey` and the `redeemScript` (via importmulti).
The current `isSolveable()` logic calls `GetPubKey()` and only flags them as solvable if the pubkeys are **in the wallet**.
**Expected behaviour:**
* multisig Inputs should be flagged as solvable (and therefore usable via fundrawtransaction) when importing the P2(W)SH `scriptPubKey` and the `redeemScripts`
Current workaround:
* Call importpubkey for all pubkeys used in the multisig (redeemScript). importpubkey derives all coming scripts (including a raw P2PK script). The P2PK scripts make the wallet store the pubkey and flag the multisig script solvable. | https://github.com/bitcoin/bitcoin/issues/14415 | https://github.com/bitcoin/bitcoin/pull/14424 | f504a1402afd0760e9d348ecc8bad0094aa7d705 | 2f6b466aeb6d4c88ab2e0e8b2a402be0743608b5 | 2018-10-06T10:27:59Z | c++ | 2018-10-08T05:15:27Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,407 | ["doc/release-notes-14454.md", "src/wallet/rpcdump.cpp", "src/wallet/rpcwallet.cpp", "test/functional/test_framework/blocktools.py", "test/functional/wallet_importmulti.py"] | importmulti P2WPKH issue | Importing a native P2WPKH script & pubkey via `importmulti` fails:
Since the pubkey is required due to issue #14405, I tried to import a native P2WPKH script together with its pubkey. It looks like importmulti assumes legacy P2PKH?
But maybe I'm doing something wrong.
Input...
* address `bcrt1qlqx4gx4qftlfe94n48ttchsptxqwt7je7tddna`
* pubkey `027dbe32bdf80ef2312f8280bd37bf69c31322745af5ebded6294969ff19c20da3`
* scriptPubKey: `0014f80d541aa04afe9c96b3a9d6bc5e015980e5fa59`
Call: `importmulti '[{"scriptPubKey": "0014f80d541aa04afe9c96b3a9d6bc5e015980e5fa59", "pubkeys": ["027dbe32bdf80ef2312f8280bd37bf69c31322745af5ebded6294969ff19c20da3"], "timestamp": "now", "watchonly": true}]' '{"rescan": false}'`
Call fails with:
```json
[
{
"success": false,
"error": {
"code": -5,
"message": "Consistency check failed"
}
}
]
``` | https://github.com/bitcoin/bitcoin/issues/14407 | https://github.com/bitcoin/bitcoin/pull/14454 | 201451b1ca3c6db3b13f9491a81db5b120b864bb | c11875c5908a17314bb38caa911507dc6401ec49 | 2018-10-05T12:50:28Z | c++ | 2018-10-24T20:30:57Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,382 | ["src/wallet/rpcwallet.cpp", "test/functional/wallet_import_rescan.py", "test/functional/wallet_listtransactions.py"] | Label support seems insufficient to replace accounts | While most of the additional functionality the old account system had over the label system were irrelevant, there is one critical functionality that no longer seems to be possible with labels - specifically, the ability to request a list of transactions (TXID + amount) that pay to addresses with a given account/label. As per the release notes for 0.17.0. the _listtransaction_ method was changed as follows;
> The account named parameter has been renamed to dummy. If provided, the dummy parameter must be set to the string *, unless running with the -deprecatedrpc=accounts argument (in which case functionality is unchanged).
_getreceivedbylabel_ and _getreceivedbyaddress_ only returns the balance, while _listreceivedbylabel_ and _listreceivedbyaddress_ do not actually filter; additionally, the former does not list transactions at all, while the latter does not include the amounts per TXID. While you could use _getaddressesbylabel_ to iterate over addresses, there is no corresponding method to get the TXIDs and amounts from this list of addresses. None of these can therefore be used as a direct replacement for this method.
The only way I can see to get anything resembling the old functionality with the API changes is to dump the entire transaction history with _listreceivedbyaddress_, filter the result by label manually, then use _gettransaction_ on each listed TXID. This is both very fiddly and very inefficient, and likely impossible when you go past a certain number of lifetime transactions.
Am I missing something here, or will it really no longer possible be to iterate over transactions received by account/label? If so, this basically means that many applications will no longer be usable with releases starting from Bitcoin Core 0.18. | https://github.com/bitcoin/bitcoin/issues/14382 | https://github.com/bitcoin/bitcoin/pull/14411 | 65b740f92be73de0612e892d61c2feb6e4a81ad1 | da427dbd48ae8d12a2a79a7514a813e78064fe52 | 2018-10-03T14:05:36Z | c++ | 2018-11-13T21:49:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,367 | ["depends/packages/freetype.mk", "depends/packages/qt.mk"] | [depends] freetype 2.7.1 requires specific harfbuzz version | To reproduce:
```
cd depends
make
cd ..
./configure --prefix=`pwd`/depends/x86_64-pc-linux-gnu
```
Problem:
```
checking for static Qt plugins: -lqminimal... no
configure: WARNING: Could not resolve: -lqminimal; bitcoin-qt frontend will not be built
checking for static Qt plugins: -lqxcb -lxcb-static... no
checking whether to build Bitcoin Core GUI... no (Qt5)
```
The actual problem is a linking issue when running the configuration check. From `config.log`:
```
/usr/bin/ld: /usr/lib/gcc/x86_64-pc-linux-gnu/8.2.1/../../../../lib/libharfbuzz.so: undefined reference to `FT_Done_MM_Var'
```
[(Full snippet of relevant section in config.log)](https://github.com/bitcoin/bitcoin/files/2437677/config-log-snippet.txt)
I run Arch Linux, which currently uses harfbuzz 1.9.0. Downgrading harfbuzz to to 1.7.4 makes `configure` happy again (1.7.5 is the first version that fails) but that defeats the purpose of the `depends` build. Our `depends` system includes freetype 2.7.1 which however requires a specific version (range) of harfbuzz.
It seems that one naive way to resolve that issue is to include harfbuzz in `depends` but actually I don't know about all the magic and trade-offs going on the build system.
This may be related to #13001. | https://github.com/bitcoin/bitcoin/issues/14367 | https://github.com/bitcoin/bitcoin/pull/14385 | 1e8f88e071019907785b260477bd359bef6f9a8f | f149e31ea2f28b72dbc3e7d7a8fe31466eabef85 | 2018-10-02T12:02:31Z | c++ | 2018-10-03T20:50:42Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,359 | ["src/qt/bitcoin.cpp"] | bitcoin-qt hangs in futex() / __cxa_guard_acquire() | When I run bitcoin-qt it does not properly start up and hangs in futex():
The last calls shown in strace are:
```
futex(0x7f3f7bfd77e4, FUTEX_WAKE_PRIVATE, 2147483647) = 0
futex(0x7f3f7d812c60, FUTEX_WAIT, 65792, NULL
```
gdb shows:
```
(gdb) bt
#0 syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
#1 0x00007ffff5e26d2f in __cxa_guard_acquire () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#2 0x00007ffff7e06dcc in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Network.so.5
#3 0x00007ffff7e0b706 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Network.so.5
#4 0x00007ffff7e2af21 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Network.so.5
#5 0x00007ffff7e32080 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Network.so.5
#6 0x00007ffff7df1c67 in QSslCertificate::QSslCertificate(QByteArray const&, QSsl::EncodingFormat) ()
from /usr/lib/x86_64-linux-gnu/libQt5Network.so.5
#7 0x00007ffff7e07fe6 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Network.so.5
#8 0x00007ffff7dfb09d in QSslConfiguration::defaultConfiguration() () from /usr/lib/x86_64-linux-gnu/libQt5Network.so.5
#9 0x000055555564841f in main () at qt/bitcoin.cpp:579
#10 0x00007ffff5a49b17 in __libc_start_main (main=0x555555648380 <main>, argc=1, argv=0x7fffffffdcc8, init=<optimized out>, fini=<optimized out>,
rtld_fini=<optimized out>, stack_end=0x7fffffffdcb8) at ../csu/libc-start.c:310
#11 0x0000555555657dca in _start () at /usr/include/c++/8/ext/new_allocator.h:116
```
I understand that this might also be a problem in Qt rather than bitcoin-qt.
But other Qt applications do not show this problem. So I'd be happy to get any hint to debug this further.
Thanks!
| https://github.com/bitcoin/bitcoin/issues/14359 | https://github.com/bitcoin/bitcoin/pull/14403 | f504a1402afd0760e9d348ecc8bad0094aa7d705 | 7d173c4cd1885ff5bcf9e5f8f7f712138dd8a445 | 2018-09-30T16:42:32Z | c++ | 2018-10-09T09:54:05Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,355 | ["src/rpc/rawtransaction.cpp", "test/functional/rpc_psbt.py"] | has anyone tested converttopsbt? | I kind of suck at boolean algebra, but:
https://github.com/bitcoin/bitcoin/blob/37612099ec7314b15a07d8bac55161ed4e8e7491/src/rpc/rawtransaction.cpp#L1672
Unless I'm mistaken (which is highly likely) the whole thing can't work (except the edge case where `permitsigdata=true` and you have no sig data) | https://github.com/bitcoin/bitcoin/issues/14355 | https://github.com/bitcoin/bitcoin/pull/14356 | c9327306b580bb161d1732c0a0260b46c0df015c | 88a79cb436b30b39d37d139da723f5a31e9d161b | 2018-09-30T01:57:33Z | c++ | 2018-09-30T02:09:15Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,341 | ["src/validation.cpp", "test/functional/feature_abortnode.py", "test/functional/test_runner.py"] | Failing to disconnect a block should result in node shutdown | I think that if a reorg fails due to an error while disconnecting blocks, the node should shut down.
My thought is that if we are trying to switch to a more work chain and something goes wrong before we can even try to validate that more-work chain, then we have a problem that is not related to the chain we're trying to switch to but instead related to our own hardware or software; shutting down and having the user deal with the issue is better than continuing on, when we know there's a more work chain that we're unable to try validating.
This has recently come up on testnet, where unpatched nodes are unable to reorg from the invalid chain containing the duplicate-input-in-a-transaction block, but rather than crash or shutdown they are continuing on the invalid chain, with messages like this in the debug log:
```
ERROR: DisconnectTip(): DisconnectBlock 00000000210004840364b52bc5e455d888f164e4264a4fec06a514b67e9d5722 failed
``` | https://github.com/bitcoin/bitcoin/issues/14341 | https://github.com/bitcoin/bitcoin/pull/15305 | 4433ed0f730cfd60eeba3694ff3c283ce2c0c8ee | a47df13471e3168e2e02023fb20cdf2414141b36 | 2018-09-27T17:04:11Z | c++ | 2019-06-05T09:05:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,339 | ["depends/packages/qt.mk"] | Qt 0.17.0rc4 (and master) not running on Ubuntu 14.04.5 LTS | Not sure if this is a problem.
Qt 0.16.3 runs successful on Ubuntu Trusty (14.04.5).
However, Qt 0.17.0rc4 (and master) gives me `undefined symbol: FT_Get_Font_Format`:
0.17.0rc4:
```
user@ubuntu:~/Desktop$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 14.04.5 LTS
Release: 14.04
Codename: trusty
user@ubuntu:~/Desktop$ ./bitcoin-qt --regtest
./bitcoin-qt: symbol lookup error: ./bitcoin-qt: undefined symbol: FT_Get_Font_Format
``` | https://github.com/bitcoin/bitcoin/issues/14339 | https://github.com/bitcoin/bitcoin/pull/14348 | d799efe21432ad55c41d5315f24c002bc8b3d119 | 430bf6c7a1a24a59050e7c9dac56b64b820edb43 | 2018-09-27T08:36:32Z | c++ | 2018-09-28T13:04:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,304 | ["src/wallet/db.cpp", "src/wallet/db.h", "test/functional/wallet_multiwallet.py"] | wallet: copied wallet detection problem | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
<!--- What behavior did you expect? -->
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
```
src/bitcoind -daemon -regtest
src/bitcoin-cli -regtest stop
cp ~/.bitcoin/wallet/wallet.dat ~/.bitcoin/wallet/wallet2.dat
src/bitcoind -daemon -regtest
src/bitcoin-cli -regtest loadwallet wallet2.dat # The first time it would fail to load wallet
src/bitcoin-cli -regtest loadwallet wallet2.dat # The second time it would succeed to load wallet, but this would cause error because of duplicate fileid
```
It would flush `wallet.dat` and close `Db*` in` mapDb['wallet.dat'].second`, so `mapDb['wallet.dat'].second` would be `nullptr`. Then there is no available `Db*` to detect if the wallet fileid is duplicated.
I'm not sure if the issue is related to #14163, but I found this while debugging it.
https://github.com/bitcoin/bitcoin/blob/920c090f63f4990bf0f3b3d1a6d3d8a8bcd14ba0/src/wallet/db.cpp#L32-L53 | https://github.com/bitcoin/bitcoin/issues/14304 | https://github.com/bitcoin/bitcoin/pull/14320 | 2d796faf62095e83f74337c26e7e1a8c3957cf3c | 4ea77320c5f0b275876be41ff530bb328ba0cb87 | 2018-09-24T01:00:56Z | c++ | 2018-10-24T15:08:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,299 | ["doc/release-notes-14468.md", "src/rpc/mining.cpp", "src/wallet/rpcwallet.cpp", "test/functional/rpc_deprecated.py", "test/functional/test_framework/test_node.py", "test/functional/wallet_basic.py", "test/functional/wallet_keypool.py", "test/functional/wallet_labels.py", "test/functional/wallet_multiwallet.py"] | Deprecate wallet `generate` RPC method | The `generate` RPC method:
- was introduced in 2010
- is now only used for testing
- reaches across multiple components (wallet, mining)
I propose we remove the wallet `generate` RPC method and update all tests to use the `generatetoaddress` RPC method. We can do this non-invasively in the test framework by adding a `generate` method to `TestNode` so that the individual tests do not need to be updated. We could also add a `generate` alias to the `generatetoaddress` RPC method.
Doing this removes a wallet->server dependency and simplifies the wallet->server interface (#10973).
I'm opening this issue before implementing in case anyone has objections. | https://github.com/bitcoin/bitcoin/issues/14299 | https://github.com/bitcoin/bitcoin/pull/14468 | c9f02955b2e9062808a9455c4ee7d52cf401eef5 | ab9aca2bdfe68fcd512955ed2c4d706933088528 | 2018-09-23T13:42:30Z | c++ | 2018-10-23T12:32:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,173 | ["src/rpc/client.cpp", "test/functional/wallet_listreceivedby.py"] | rpc method listreceivedbyaddress doesn't take address as a string | ```
bitcoin-cli listreceivedbyaddress 0 true true 2NABbUr9yeRCp1oUCtVmgJF8HGRCo3ifpTT
```
gives an error: `error: Error parsing JSON:2NABbUr9yeRCp1oUCtVmgJF8HGRCo3ifpTT`
as it's trying to parse the address as json. so you'd have to write:
```
bitcoin-cli listreceivedbyaddress 0 true true '"2NABbUr9yeRCp1oUCtVmgJF8HGRCo3ifpTT"'
```
which is clumsy and inconsistent with other RPC methods as well as the help file | https://github.com/bitcoin/bitcoin/issues/14173 | https://github.com/bitcoin/bitcoin/pull/14417 | f504a1402afd0760e9d348ecc8bad0094aa7d705 | d4d70eda339f6f74390b56edd4021e928bb588a7 | 2018-09-09T00:52:53Z | c++ | 2018-10-14T16:48:06Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,163 | [".travis.yml", ".travis/test_06_script_a.sh", ".travis/test_06_script_b.sh"] | wallet: heap-use-after-free on multiwallet shutdown | Steps to reproduce on current master adf27b531a7fcd7066ab6649e8073bd1895a823a:
```
./configure --with-sanitizers=address CC=clang CXX=clang++ && make -j 16
ASAN_OPTIONS=detect_leaks=0 ./test/functional/wallet_multiwallet.py
# Look in the leftover tempdir: cat ./node0/stderr/tmp*
# Addresses can be converted with addr2line -e ... | https://github.com/bitcoin/bitcoin/issues/14163 | https://github.com/bitcoin/bitcoin/pull/15303 | faee6c9cacde79e905aaf3c137d0295f4c6ddea2 | facaae4cc4b3a44fb0332a40865eed8f2bbd6864 | 2018-09-06T21:33:49Z | c++ | 2019-02-01T20:20:00Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,148 | ["src/wallet/transaction.h", "src/wallet/wallet.cpp", "test/functional/wallet_orphanedreward.py"] | abandontransaction needed after spending orphaned block reward | When a block reward is spent together with other outputs in the wallet and that block reward is later orphaned, the wallet does not show the other funds as available anymore. Even a `-rescan` is not enough - only `-zapwallettxes` or an explicit `abandontransaction` "recovers" the funds. I prepared a [test case](https://github.com/domob1812/bitcoin/blob/wallet-bug-invalidated-block-rewards/test/functional/wallet_bug.py) that shows this behaviour.
Is this a known issue or the expected behaviour? While this situation is something that will presumably not occur in practice (as it requires a long reorg), I wonder if that transaction should be automatically abandoned as it seems clear it won't be able to be confirmed anymore. | https://github.com/bitcoin/bitcoin/issues/14148 | https://github.com/bitcoin/bitcoin/pull/26499 | 37fea41bbf851ddda571af98c2a555ed2ecb676c | b1329b7523ede407ba48c67644c199c8257f852a | 2018-09-04T16:19:19Z | c++ | 2023-01-30T10:09:41Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,130 | ["configure.ac", "src/logging/timer.h", "src/prevector.h", "src/validation.cpp"] | Clang: "anonymous structs are a GNU extension" | https://github.com/bitcoin/bitcoin/blob/68f3c7eb080e461cfeac37f8db7034fe507241d0/src/prevector.h#L152-L158
I'm opening an issue as its fix is too tiny to become a pull request.
Can be solved by renaming the struct to
```c
struct indirect_contents {
size_type capacity;
char* indirect;
};
``` | https://github.com/bitcoin/bitcoin/issues/14130 | https://github.com/bitcoin/bitcoin/pull/18088 | b549cb1bd2cc4c6d7daeccdd06915bec590e90ca | e727c2bdcab3660297f452c76c6f877038015c02 | 2018-09-02T08:52:23Z | c++ | 2020-05-04T23:44:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,082 | ["src/wallet/rpcwallet.cpp", "test/functional/rpc_signrawtransaction.py"] | signrawtransaction RPC outputs different kinds of errors for locked wallets in 0.16 and 0.17 | <!-- Describe the issue -->
When trying to sign a transaction in a encrypted wallet that is locked, version 0.16 would return the following error:
```"Please enter the wallet passphrase with walletpassphrase first."```
While doing exactly the same procedure against 0.17, the response is something like:
```json
"hex": "020000000183ac9cc1137c444f32356fb070ecba194c87a05e43674c06a55f5b1d0561eabc0000000000ffffffff0180626a94000000001600141875aa6ab19c2551c11759cf3e9f4dd7aa40bcf500000000",
"complete": false,
"errors": [
{
"txid": "bcea61051d5b5fa5064c67435ea0874c19baec70b06f35324f447c13c19cac83",
"vout": 0,
"witness": [
],
"scriptSig": "",
"sequence": 4294967295,
"error": "Unable to sign input, invalid stack size (possibly missing key)"
}
]
```
<!--- What behavior did you expect? -->
v0.17 should check if the wallet is locked before trying to sign the tx and return the same error as v0.16 for consistency reasons. | https://github.com/bitcoin/bitcoin/issues/14082 | https://github.com/bitcoin/bitcoin/pull/14310 | db15805668e923c3493d77122d20926496cf6a1a | 20442f617f7f86cbdde1c41c1165e2b750f756c7 | 2018-08-27T15:29:14Z | c++ | 2018-09-25T06:00:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 14,058 | ["src/test/scheduler_tests.cpp"] | unit tests fail --with-sanitizers=thread | On master and 0.17 steps to reproduce:
```sh
git checkout bitcoin/master && make distclean
./configure --with-sanitizers=thread CC=clang CXX=clang++
make -j 16 check
| https://github.com/bitcoin/bitcoin/issues/14058 | https://github.com/bitcoin/bitcoin/pull/14069 | 683838b7e4ea561ee386d8ba7760bcb09b2d8465 | 737670c036e802e0fd8b51efffb41131d08f0204 | 2018-08-24T22:58:50Z | c++ | 2018-08-26T13:41:57Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,958 | ["src/script/sign.h", "src/streams.h", "test/functional/data/rpc_psbt.json"] | decodepsbt fails for PSBT with no inputs | Reported by @kallewoof here: https://github.com/bitcoin/bitcoin/pull/13917#issuecomment-412459298
```
$ ./bitcoin-cli createpsbt "[]" "[{\"$(./bitcoin-cli getnewaddress)\":0.01}]"
cHNidP8BACoCAAAAAAFAQg8AAAAAABepFG6Rty1Vk+fUOR4v9E6R6YXDFkHwhwAAAAAAAA==
$ ./bitcoin-cli decodepsbt cHNidP8BACoCAAAAAAFAQg8AAAAAABepFG6Rty1Vk+fUOR4v9E6R6YXDFkHwhwAAAAAAAA==
error code: -22
error message:
TX decode failed CDataStream::read(): end of data: unspecified iostream_category error
```
| https://github.com/bitcoin/bitcoin/issues/13958 | https://github.com/bitcoin/bitcoin/pull/13960 | 43811e63380d803e037de69dc0567aae590fa109 | bd19cc78cfc455cf06e120adb0d12c2f96ba8fca | 2018-08-13T16:15:24Z | c++ | 2018-08-13T22:00:06Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,873 | ["src/qt/transactionview.cpp"] | GUI: Filtering by amount problem in tx list if decimal separator is not a point | In my system, decimal separator is comma. In transaction list in a GUI for all mounts decimal separator is point. But in amount filter field I can't enter point, only comma (which is decimal separator in my system), and, most likely because of that, filtering by amount does not work.
It's bitcoin-qt v0.16.0 with qt 5.9.4 on Gentoo Linux.
| https://github.com/bitcoin/bitcoin/issues/13873 | https://github.com/bitcoin/bitcoin/pull/14177 | d799efe21432ad55c41d5315f24c002bc8b3d119 | b0510d78aedde864756199fe71ca98f8e95dd44f | 2018-08-04T12:53:01Z | c++ | 2018-09-26T19:28:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,829 | ["src/qt/bitcoingui.cpp", "src/qt/bitcoingui.h", "src/qt/guiutil.cpp", "src/qt/guiutil.h", "src/qt/macdockiconhandler.h", "src/qt/macdockiconhandler.mm", "src/qt/walletview.cpp"] | Unhide QT window doesn't work when hidden with ⌘ + H | Noticed this while reviewing #13529, but it's also in master @ 5ba77df. On macOS 10.13.6:
<img width="209" alt="schermafbeelding 2018-08-01 om 16 22 09" src="https://user-images.githubusercontent.com/10217/43527498-0f571db4-95a7-11e8-8d90-7863947a7689.png">
<img width="178" alt="schermafbeelding 2018-08-01 om 16 12 51" src="https://user-images.githubusercontent.com/10217/43526994-c9a515ec-95a5-11e8-96b8-9e2513e9aac5.png">
* `Show` in the action menu doesn't work if the app was hidden by `Command + H`, it does work when hidden through this menu
* send and receive don't unhide the window when opened for the action menu. It does navigate to the right tab. The other actions do work (sign, verify & debug window)
Clicking "Toon" (= macOS native show) does work, suggesting the GUI uses some non-native method of hiding. | https://github.com/bitcoin/bitcoin/issues/13829 | https://github.com/bitcoin/bitcoin/pull/14123 | 6fc21aca6d5e16c3ece104fec8e5b3df116893b4 | 0a656f85a9c694f25b06c6464d6e986816eecd58 | 2018-08-01T14:22:54Z | c++ | 2018-11-05T11:21:50Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,828 | ["src/qt/bitcoingui.cpp", "src/qt/modaloverlay.cpp", "src/qt/modaloverlay.h"] | Missing and unaccesible sync modal when using QT without wallet | Noticed this while reviewing #13529, but it's also in master @ 5ba77df15. On macOS 10.13.6:
```
bitcoin-qt -disablewallet
```
<img width="1354" alt="schermafbeelding 2018-08-01 om 16 03 41" src="https://user-images.githubusercontent.com/10217/43526506-b23264d8-95a4-11e8-81a0-5debcad838ae.png">
The usual progress modal doesn't appear when QT starts, and clicking on the progress bar has no effect. It works fine when there's a wallet present. | https://github.com/bitcoin/bitcoin/issues/13828 | https://github.com/bitcoin/bitcoin/pull/15084 | 1d73636fdf1ef85c1f62841953e1cf01a6c3bfd0 | b3b6b6f62fcabea9818e8049dba714d0d0ef8ab6 | 2018-08-01T14:07:29Z | c++ | 2019-10-13T15:31:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,819 | ["src/qt/guiutil.cpp", "src/util.cpp", "test/lint/lint-includes.sh"] | Windows: Can not create startup link if the username is a_ä_α_Б | When selecting "Start Bitcoin Core on system login" in the settings, it will unselect itself after closing the dialog.
Tested with current master (e8ffec6) on Windows 7.
| https://github.com/bitcoin/bitcoin/issues/13819 | https://github.com/bitcoin/bitcoin/pull/13734 | 1c5d22585384c8bb05a27a04eab5c57b31d623fb | bb6ca65f9890e8280ace32de5a37774e14705859 | 2018-07-31T14:24:33Z | c++ | 2018-08-03T18:47:58Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,817 | ["share/setup.nsi.in"] | NSIS: Error launching the installer when login name contains some non-ascii characters | Steps to reproduce:
* Install Windows 7
* Create user `a_ä_α_Б`
* Launch installer (Tested for 0.16.2 and current master)
| https://github.com/bitcoin/bitcoin/issues/13817 | https://github.com/bitcoin/bitcoin/pull/21333 | 0459e7abbac51af28e3b01e6ca0d9826b26a13ff | 3a8fc51a560bcf9ad2d6ed188c41e894df910ebc | 2018-07-31T14:06:37Z | c++ | 2021-03-03T01:57:52Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,813 | ["src/bench/coin_selection.cpp"] | bench_bitcoin hits assert in coin selection | Output with current master:
```
bench_bitcoin: bench/coin_selection.cpp:53: void CoinSelection(benchmark::State&): Assertion `success' failed. | https://github.com/bitcoin/bitcoin/issues/13813 | https://github.com/bitcoin/bitcoin/pull/13822 | 230652cafc51a087b25a5e6fbc0114e63b3be0aa | 494634a052aa760f04273af48a6475a7956d29ee | 2018-07-30T19:46:12Z | c++ | 2018-07-31T18:31:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,810 | [".travis.yml"] | qa: Travis should run the bench_bitcoin in one of the jobs | Just to confirm the binary is not crashing or hitting an assert. | https://github.com/bitcoin/bitcoin/issues/13810 | https://github.com/bitcoin/bitcoin/pull/13811 | d25079ac7169b119021a06c93a0086aa3c7afc5b | fa7a3a1783cd81907779392f626bdcca5e10efb1 | 2018-07-30T18:38:41Z | c++ | 2018-08-01T14:25:24Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,762 | ["contrib/gitian-descriptors/gitian-win-signer.yml"] | gitian-win-signer.yml steps fail to compile osslsigncode-1.7.1 | osslsigncode-1.7.1 fails to compile under bionic(does not support openssl 1.1.1) unless you downgrade to xenial versions manually :
openssl_1.0.2g-1ubuntu4.13_amd64.deb
libssl1.0.0_1.0.2g-1ubuntu4.13_amd64.deb
zlib1g_1.2.8.dfsg-2ubuntu4.1_amd64.deb
zlib1g-dev_1.2.8.dfsg-2ubuntu4.1_amd64.deb
libssl-dev_1.0.2g-1ubuntu4.13_amd64.deb
| https://github.com/bitcoin/bitcoin/issues/13762 | https://github.com/bitcoin/bitcoin/pull/13782 | 89a116dc0b446de0d18a981699a279eeaf6c9ea9 | 284f424d5abbc157b8392faece3b205974dc92d5 | 2018-07-26T04:12:24Z | c++ | 2018-07-30T14:43:24Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,759 | ["configure.ac"] | Assembly optimisations are compiled even with --disable-asm | `--disable-asm` doesn't seem to actually disable the new assembly optimisations. | https://github.com/bitcoin/bitcoin/issues/13759 | https://github.com/bitcoin/bitcoin/pull/13788 | afe087557747f640af90eaca8de8786dc226e56a | 4207c1b35c2e2ee1c9217cc7db3290a24c3b4b52 | 2018-07-25T16:18:11Z | c++ | 2018-07-28T19:34:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,754 | ["src/wallet/wallet.cpp"] | Windows crashes for -wallet=你好 | Invalid characters for a wallet name, e.g. `bitcoin-qt -wallet=你好` used to result in an error like this
<img width="494" alt="schermafbeelding 2018-07-24 om 17 46 37" src="https://user-images.githubusercontent.com/10217/43150553-7bdf598a-8f6a-11e8-8972-44c311a57e56.png">
But now it just crashes:
<img width="509" alt="schermafbeelding 2018-07-24 om 17 43 26" src="https://user-images.githubusercontent.com/10217/43150605-9cf32192-8f6a-11e8-9333-87d074c8dd35.png">
I didn't do a `git bisect`, but it broke somewhere this year :-) | https://github.com/bitcoin/bitcoin/issues/13754 | https://github.com/bitcoin/bitcoin/pull/13876 | 1ef57a96b8b7255bd1f1ea0583846f18305419bf | fa8527ffeced3f898e8f205483ef0ea7c51a9178 | 2018-07-24T15:55:03Z | c++ | 2018-08-04T16:04:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,748 | [".travis.yml"] | travis job x86_64 Linux with qt5 dev packages takes always 40 minutes (missing cache?) | The travis job
https://github.com/bitcoin/bitcoin/blob/7ebd8c6385253bfa30175169a22f93474d8ddfaf/.travis.yml#L36
always takes about 40 minutes on master and pull requests, whereas it should take about 15 minutes with a hot cache. | https://github.com/bitcoin/bitcoin/issues/13748 | https://github.com/bitcoin/bitcoin/pull/13650 | dcb154e5aad80e49ff41a7851604ac46f38cb167 | 14788fbadac3aa352eb51da81ecdfa01208ca33c | 2018-07-23T18:24:28Z | c++ | 2018-07-19T18:49:05Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,745 | ["test/functional/test_framework/mininode.py"] | mininode tests broken with Python 3.4.2 (Debian Jessie) | The recent change in #13715 broke mininode tests on systems with Python 3.4.2 (as included in Debian Jessie aka oldstable). This is because the method [`is_closing`](https://docs.python.org/3.4/library/asyncio-protocol.html#asyncio.BaseTransport.is_closing) is only introduced in Python 3.4.4.
A workaround would be to add a `hasattr` condition that only checks `is_closing` if it is actually available - keeping the benefits of #13715 for newer systems while not breaking old systems (basically falling back to the behaviour before #13715 for them). If that's a desired fix, I'm happy to create a PR for it. | https://github.com/bitcoin/bitcoin/issues/13745 | https://github.com/bitcoin/bitcoin/pull/13747 | c0a47da7250586dd2a6b7ba368a876ba8c6a15f2 | 64b9f27e0e46142d01ed5070c544ca7a98183d56 | 2018-07-23T09:10:55Z | c++ | 2018-07-23T13:44:58Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,738 | ["src/rpc/rawtransaction.cpp", "src/wallet/rpcwallet.cpp", "test/functional/rpc_psbt.py"] | qa: Intermittent failure in rpc_psbt | travis run: https://travis-ci.org/bitcoin/bitcoin/jobs/406813397
```
rpc_psbt.py failed, Duration: 4 s
stdout:
2018-07-22T13:28:57.765000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_test_runner_20180722_132530/rpc_psbt_49
2018-07-22T13:29:00.531000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/test_framework.py", line 160, in main
self.run_test()
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/rpc_psbt.py", line 101, in run_test
assert_raises_rpc_error(-22, "TX decode failed", self.nodes[0].converttopsbt, signedtx['hex'])
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/util.py", line 105, in assert_raises_rpc_error
assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
AssertionError: No exception raised | https://github.com/bitcoin/bitcoin/issues/13738 | https://github.com/bitcoin/bitcoin/pull/15899 | fa5c5cd141f0265a5693234690ac757b811157d8 | fa499b5f027f77c0bf13699852c8c06f78e27bef | 2018-07-22T13:44:10Z | c++ | 2019-05-16T19:56:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,731 | ["contrib/gitian-descriptors/gitian-linux.yml", "contrib/gitian-descriptors/gitian-osx.yml", "contrib/gitian-descriptors/gitian-win.yml", "depends/packages/qt.mk", "depends/patches/qt/fix_rcc_determinism.patch"] | Gitian builds no longer deterministic | After the merge of #12971, gitian builds are no longer producing deterministic binaries/packages for any build that includes the Qt GUI front-end.
This is due to a semi-recent change to Qt's `rcc` tool that embeds any input file's last modified time into it's resulting output (`src/qt/qrc_bitcoin_locale.cpp` in this case). Since the build system dynamically generates the translation locale `.qm` files at build time, the resulting `qt_libbitcoinqt_a-qrc_bitcoin_locale.o` is never deterministic.
Here is a comparison of some recent `master` branch gitian builds:
Run 1:
```
c7270b97ec1457acc5802ad60e8b9a2319b462d2109ec4191c83e0871d2b8322 bitcoin-0.16.99-aarch64-linux-gnu-debug.tar.gz
227f958ce4e68f72ecc950c186f88cf53561be640ab6def5f48bdcb48e3d42db bitcoin-0.16.99-aarch64-linux-gnu.tar.gz
a8de05932cba825f66a9390bd029b852e8a5d4b77712f3b1612a61c619abdfc3 bitcoin-0.16.99-arm-linux-gnueabihf-debug.tar.gz
4c4a8064ab99b3ff9c1eba9302239f2d88847467bdcdb789adbd4154414f034b bitcoin-0.16.99-arm-linux-gnueabihf.tar.gz
aec0618497ff5f6d34f3c3e0d652e46dda6371b1186a800fb89156a6c5c00d96 bitcoin-0.16.99-i686-pc-linux-gnu-debug.tar.gz
d6b664b35dd0e77e16f65545e5a690e56b3fb381804edb516e747c7eb17f5a27 bitcoin-0.16.99-i686-pc-linux-gnu.tar.gz
80bd22bdc4f0dc8f72f09cb17cece23484957e31a7a7dc8a070497a36700b6ad bitcoin-0.16.99-x86_64-linux-gnu-debug.tar.gz
d288019698fa2fb027c808f27f3f9a63aaef9aff353da74eb09be1c614d8a880 bitcoin-0.16.99-x86_64-linux-gnu.tar.gz
4e2a441838213ecae35db1824e05a23e7f026f0b3fbf144460c4735d6ab41c21 src/bitcoin-0.16.99.tar.gz
543193a2ca8dadf582dc1f3af47bae52ba8f2a8604f3b64140fe40853e1c0063 bitcoin-linux-0.17-res.yml
cc27376dd3c55b0a2596b5d7d85c352ebf572bdfdeec6b3d33be8e4e4b77df09 bitcoin-0.16.99-win-unsigned.tar.gz
9dafad0dad4d4a77ad60f0c1f545aeabf88fa7a3a5c73cc6b849ef474af9a888 bitcoin-0.16.99-win32-debug.zip
9f7ffb4caedcf2015dede00f1f8c74e2c0949b55869597807738736d2858d31b bitcoin-0.16.99-win32-setup-unsigned.exe
528292fc66ef2aa2944de9b89af669029141671ef6d823b8a485b5bc7a159881 bitcoin-0.16.99-win32.zip
18f7169d56a798df9a117eed001b73d25dbdcf3a9c0e2611eabb324c50cb4edc bitcoin-0.16.99-win64-debug.zip
702edd07ef957bfb316cf80ca5ef0d9fcd22dfc3ae15dd615522ace6a2d13266 bitcoin-0.16.99-win64-setup-unsigned.exe
e2f0a004773c2745f7289f7f2afb33a1bd1d1d47d0fc3a69c38bed1686597fb6 bitcoin-0.16.99-win64.zip
0bf23ac04ca0b4866293306bdd2639d23947ca333a0ffa14625aa33ab718f9a3 src/bitcoin-0.16.99.tar.gz
982efe98d1221572201cae35008f8cac4163e7a3b896249b89e4449abce192bc bitcoin-win-0.17-res.yml
0efe1c0e036678732f7b8d4c2829587f338663d68b1a5eedac6d3601e3f386d8 bitcoin-0.16.99-osx-unsigned.dmg
86881a72a3795149fb94ebe7bc28caa8979ed33b470b8a36a1cda315de8e7fe8 bitcoin-0.16.99-osx-unsigned.tar.gz
4d7cca92ec8ee4bdbaafffe4c182bbff81070d1a8b575741cb805118035c9301 bitcoin-0.16.99-osx64.tar.gz
4e2a441838213ecae35db1824e05a23e7f026f0b3fbf144460c4735d6ab41c21 src/bitcoin-0.16.99.tar.gz
df18dba7e9c8803ea8d803114a86dcab36f3fe6de27afe56ae4280e58ccb772a bitcoin-osx-0.17-res.yml
```
Run 2:
```
c7270b97ec1457acc5802ad60e8b9a2319b462d2109ec4191c83e0871d2b8322 bitcoin-0.16.99-aarch64-linux-gnu-debug.tar.gz
227f958ce4e68f72ecc950c186f88cf53561be640ab6def5f48bdcb48e3d42db bitcoin-0.16.99-aarch64-linux-gnu.tar.gz
3dce6a11640462d1dd6eb4fd81cce72f039624402d6bc87a52ff04e88013dee1 bitcoin-0.16.99-arm-linux-gnueabihf-debug.tar.gz
049e59a8d01add4686752f66c926f0b99da86a09240250c4aa794d3a112c665c bitcoin-0.16.99-arm-linux-gnueabihf.tar.gz
4d80143e06882292da6d8cf6f36c430fcabbc0bf78a8134f57dfd570dbe3817f bitcoin-0.16.99-i686-pc-linux-gnu-debug.tar.gz
475702c7fe1c9aa93b25e91e85c25ee5151c70886f3ebae7dab48b846393cad6 bitcoin-0.16.99-i686-pc-linux-gnu.tar.gz
54027c60d704cfaa078f60115aecb5b733e102260a643c87c2bd671d5fceefda bitcoin-0.16.99-x86_64-linux-gnu-debug.tar.gz
56df0a3bd628bed319faac3131290642ba16edae78b82c5a635ba74cf6eb2b72 bitcoin-0.16.99-x86_64-linux-gnu.tar.gz
4e2a441838213ecae35db1824e05a23e7f026f0b3fbf144460c4735d6ab41c21 src/bitcoin-0.16.99.tar.gz
868847616c91849bd8fb3e22ffbee3296756d9333315ae5804769e6334ef8dc0 bitcoin-linux-0.17-res.yml
9fa81924675890294072d8ef82339ebd9b759f9f8a243c5ba34edabb462e99ac bitcoin-0.16.99-win-unsigned.tar.gz
9dafad0dad4d4a77ad60f0c1f545aeabf88fa7a3a5c73cc6b849ef474af9a888 bitcoin-0.16.99-win32-debug.zip
9ded631625b6efddb779a5bd4ba5fd64ebc5d424251d180d36f25992defbb777 bitcoin-0.16.99-win32-setup-unsigned.exe
e2483927f3303c07f3dbe446b9228bf6d10dccbeb28df762ddbf74df5bb99245 bitcoin-0.16.99-win32.zip
18f7169d56a798df9a117eed001b73d25dbdcf3a9c0e2611eabb324c50cb4edc bitcoin-0.16.99-win64-debug.zip
88d9a6e40d60fe96a601b304634f70bfd1c3792e73ac88019bbfc0fd56971423 bitcoin-0.16.99-win64-setup-unsigned.exe
3774aae37404866ebfe628bec65d3bae8ab5e26d1396383083d493a16cd7e6ab bitcoin-0.16.99-win64.zip
0bf23ac04ca0b4866293306bdd2639d23947ca333a0ffa14625aa33ab718f9a3 src/bitcoin-0.16.99.tar.gz
138d69f87962902a125426c6a3eb38e91f27cdd7e721bc96809adb87b0a64280 bitcoin-win-0.17-res.yml
0efe1c0e036678732f7b8d4c2829587f338663d68b1a5eedac6d3601e3f386d8 bitcoin-0.16.99-osx-unsigned.dmg
86881a72a3795149fb94ebe7bc28caa8979ed33b470b8a36a1cda315de8e7fe8 bitcoin-0.16.99-osx-unsigned.tar.gz
4d7cca92ec8ee4bdbaafffe4c182bbff81070d1a8b575741cb805118035c9301 bitcoin-0.16.99-osx64.tar.gz
4e2a441838213ecae35db1824e05a23e7f026f0b3fbf144460c4735d6ab41c21 src/bitcoin-0.16.99.tar.gz
df18dba7e9c8803ea8d803114a86dcab36f3fe6de27afe56ae4280e58ccb772a bitcoin-osx-0.17-res.yml
```
Between the two runs, the only resulting binary package with the same `sha256sum` is the aarch64 tarballs...which do not currently bundle `bitcoin-qt` in them. | https://github.com/bitcoin/bitcoin/issues/13731 | https://github.com/bitcoin/bitcoin/pull/13732 | 07ce278455757fb46dab95fb9b97a3f6b1b84faf | 6b5506a28632b57c0c75c7cc66c0bc35d419b682 | 2018-07-21T13:50:12Z | c++ | 2018-07-25T20:53:53Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,620 | ["contrib/gitian-build.py", "contrib/gitian-build.sh"] | Rewrite gitian-build.sh in Python | Re-writing the [gitian-build.sh](https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-build.sh) has come up multiple times, most recently in [here](https://github.com/bitcoin/bitcoin/pull/13609#issuecomment-403470887).
Opening a "good first issue" so someone can find it. | https://github.com/bitcoin/bitcoin/issues/13620 | https://github.com/bitcoin/bitcoin/pull/13623 | 17943f77bda22d515e29662d31c8ac936b85f470 | 78f06e4af76b6e4550b8eed5a521684140a4fc5f | 2018-07-10T02:26:40Z | c++ | 2018-07-16T13:01:09Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,599 | ["src/bitcoin-tx.cpp", "test/util/data/bitcoin-util-test.json"] | bitcoin-tx accepts non-numeral input/output indices | Some commands of `bitcoin-tx` accept an index of an existing input/output, e.g. `delin` or `delout`. And while the index is checked for being out-of-bounds, garbage (non-numeral characters) are happily accepted. All of the following are fine:
$ bitcoin-tx -create outaddr=1:1M72Sfpbz1BPpXFHz9m3CdqATR44Jvaydd delout=
$ bitcoin-tx -create outaddr=1:1M72Sfpbz1BPpXFHz9m3CdqATR44Jvaydd delout=foobar
$ bitcoin-tx -create outaddr=1:1M72Sfpbz1BPpXFHz9m3CdqATR44Jvaydd delout=0bla
I think all of them should throw an error instead of silently treating the index as zero.
The reason for this is that internally, `atoi` is called - and that by design discards anything after the first non-numeric character (and may just return zero if there are no numerals at all).
A possible fix would be to use `strtol` instead and to verify that the returned `endptr` is actually the end of the input string. Alternatively, one could convert the integer back to a string and require that it matches the input string exactly. | https://github.com/bitcoin/bitcoin/issues/13599 | https://github.com/bitcoin/bitcoin/pull/13603 | 0212187fc624ea4a02fc99bc57ebd413499a9ee1 | 57889e688dd0987a1e087cd48d216a413127601e | 2018-07-05T14:36:19Z | c++ | 2018-07-07T12:25:09Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,585 | ["configure.ac"] | Can't compile bitcoin for SmartOS - recipe for target 'leveldb/util/leveldb_libleveldb_a-env_posix.o' failed | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
<!--- What behavior did you expect? -->
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
After fixing #13581 my build still fails with...
```
leveldb/util/env_posix.cc: In member function 'virtual leveldb::Status leveldb::{anonymous}::PosixSequentialFile::Read(std::size_t, leveldb::Slice*, char*)':
leveldb/util/env_posix.cc:105:51: error: 'fread_unlocked' was not declared in this scope
size_t r = fread_unlocked(scratch, 1, n, file_);
^
leveldb/util/env_posix.cc: In member function 'virtual leveldb::Status leveldb::{anonymous}::PosixWritableFile::Append(const leveldb::Slice&)':
leveldb/util/env_posix.cc:234:66: error: 'fwrite_unlocked' was not declared in this scope
size_t r = fwrite_unlocked(data.data(), 1, data.size(), file_);
^
leveldb/util/env_posix.cc: In member function 'virtual leveldb::Status leveldb::{anonymous}::PosixWritableFile::Flush()':
leveldb/util/env_posix.cc:251:30: error: 'fflush_unlocked' was not declared in this scope
if (fflush_unlocked(file_) != 0) {
^
leveldb/util/env_posix.cc: In member function 'virtual leveldb::Status leveldb::{anonymous}::PosixWritableFile::Sync()':
leveldb/util/env_posix.cc:290:30: error: 'fflush_unlocked' was not declared in this scope
if (fflush_unlocked(file_) != 0 ||
^
Makefile:5044: recipe for target 'leveldb/util/leveldb_libleveldb_a-env_posix.o' failed
make[2]: *** [leveldb/util/leveldb_libleveldb_a-env_posix.o] Error 1
make[2]: Leaving directory '/opt/local/src/bitcoin/src'
Makefile:9824: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/opt/local/src/bitcoin/src'
Makefile:757: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
``` | https://github.com/bitcoin/bitcoin/issues/13585 | https://github.com/bitcoin/bitcoin/pull/13659 | 619cd29393b68426f3d9c0d7467509fadfa9f933 | 768981c93d8115d9515edd35e3c793b44f6192b4 | 2018-07-02T00:56:45Z | c++ | 2018-07-13T20:47:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,581 | ["configure.ac", "src/Makefile.am", "src/compat/glibc_sanity.cpp", "src/compat/glibc_sanity_fdelt.cpp"] | Can't compile bitcoin for SmartOS - recipe for target 'compat/libbitcoin_util_a-glibc_sanity.o' failed | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
<!--- What behavior did you expect? -->
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
After fixing #13580 my build still fails with...
```
CXX compat/libbitcoin_util_a-glibc_sanity.o
In file included from compat/glibc_sanity.cpp:12:0:
compat/glibc_sanity.cpp: In function 'bool {anonymous}::sanity_test_fdelt()':
compat/glibc_sanity.cpp:53:5: error: 'memset' was not declared in this scope
FD_ZERO(&fds);
^
Makefile:6248: recipe for target 'compat/libbitcoin_util_a-glibc_sanity.o' failed
make[2]: *** [compat/libbitcoin_util_a-glibc_sanity.o] Error 1
make[2]: Leaving directory '/opt/local/src/bitcoin/src'
Makefile:9824: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/opt/local/src/bitcoin/src'
Makefile:757: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
```
I have attached
[config.log](https://github.com/bitcoin/bitcoin/files/2152954/config.log) for your review.
| https://github.com/bitcoin/bitcoin/issues/13581 | https://github.com/bitcoin/bitcoin/pull/15146 | 7fb886b1b1110de4c79478ac094e64cdcb81f3c8 | b4fd0ca9be14c81023db759c405c0f67cfa78166 | 2018-07-01T16:37:17Z | c++ | 2019-04-14T03:21:02Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,579 | ["test/functional/test_framework/mininode.py"] | test_runner sometimes fail due to "socket.send() raised exception" in stderr | Some tests that use `P2PConnection` might fail after the switch to `asyncio`. The test itself is successful, but the stderr is non-empty. I believe this is an internal race in `asyncio`, where the remote node disconnected from our `P2PConnection`, but asyncio didn't realize it and is still sending (potentially buffered) bytes.
One solution would be to just strip the stderr of "socket.send() raised exception".
One example on osx, but can probably reproduced locally with `./test/functional/test_runner.py -j 16 --extended`:
```
feature_assumevalid.py failed, Duration: 13 s
stdout:
2018-06-30T17:10:31.246000Z TestFramework (INFO): Initializing test directory /var/folders/bb/n7t3rs157850byt_jfdcq9k80000gn/T/bitcoin_test_runner_20180630_170848/feature_assumevalid_87
2018-06-30T17:10:43.682000Z TestFramework.mininode (WARNING): Connection lost to 127.0.0.1:11698 due to [Errno 32] Broken pipe
2018-06-30T17:10:43.994000Z TestFramework (INFO): Stopping nodes
2018-06-30T17:10:44.370000Z TestFramework (INFO): Cleaning up /var/folders/bb/n7t3rs157850byt_jfdcq9k80000gn/T/bitcoin_test_runner_20180630_170848/feature_assumevalid_87 on exit
2018-06-30T17:10:44.370000Z TestFramework (INFO): Tests successful
stderr:
socket.send() raised exception.
socket.send() raised exception.
socket.send() raised exception.
socket.send() raised exception. | https://github.com/bitcoin/bitcoin/issues/13579 | https://github.com/bitcoin/bitcoin/pull/13715 | 4a3e8c5aa6a5d8dda15a76d644b2a9f0f40cdec7 | ea5340c9d24b5b59b178c06e7cb25495a282fdd0 | 2018-07-01T09:05:00Z | c++ | 2018-07-19T11:24:31Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,576 | ["configure.ac", "src/serialize.h"] | Can't compile bitcoin for SmartOS - recipe for target 'consensus/libbitcoinconsensus_la-merkle.lo' failed | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
<!--- What behavior did you expect? -->
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
I am trying to compile the latest bitcoin source from GitHub on the latest SmartOS and do not know how to solve the following compile error...
```
/opt/local/src/bitcoin]# uname -a
SunOS a36dbe40-5628-e6ea-f7b8-8d89982fe9bf 5.11 joyent_20180525T172343Z i86pc i386 i86pc Solaris
/opt/local/src/bitcoin]# gcc -v
Using built-in specs.
COLLECT_GCC=/opt/local/gcc49/bin/gcc
COLLECT_LTO_WRAPPER=/opt/local/gcc49/libexec/gcc/x86_64-sun-solaris2.11/4.9.3/lto-wrapper
Target: x86_64-sun-solaris2.11
Configured with: ../gcc-4.9.3/configure --enable-languages='c obj-c++ objc go fortran c++' --enable-shared --enable-long-long --with-local-prefix=/opt/local --enable-libssp --enable-threads=posix --with-boot-ldflags='-static-libstdc++ -static-libgcc -Wl,-R/opt/local/lib ' --disable-nls --with-gxx-include-dir=/opt/local/gcc49/include/c++/ --without-gnu-ld --with-ld=/usr/bin/ld --with-gnu-as --with-as=/opt/local/bin/gas --prefix=/opt/local/gcc49 --build=x86_64-sun-solaris2.11 --host=x86_64-sun-solaris2.11 --infodir=/opt/local/gcc49/info --mandir=/opt/local/gcc49/man
Thread model: posix
gcc version 4.9.3 (GCC)
/opt/local/src/bitcoin]# ./configure --with-gui=no --disable-tests --enable-cxx --disable-shared --with-pic --prefix=/usr/local --with-incompatible-bdb --target=x86_64-sun-solaris2.11
...
Options used to compile and link:
with wallet = yes
with gui / qt = no
with zmq = no
with test = no
with bench = yes
with upnp = auto
use asm = yes
sanitizers =
debug enabled = no
gprof enabled = no
werror = no
target os =
build os =
CC = gcc
CFLAGS = -g -O2
CPPFLAGS = -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS
CXX = g++ -std=c++11
CXXFLAGS = -Wstack-protector -fstack-protector-all -Wall -Wextra -Wformat -Wvla -Wno-unused-parameter -g -O2
LDFLAGS = -D_POSIX_PTHREAD_SEMANTICS -pthread -Wl,-z,now -pie
ARFLAGS = cr
/opt/local/src/bitcoin]# make
Making all in src
make[1]: Entering directory '/opt/local/src/bitcoin/src'
make[2]: Entering directory '/opt/local/src/bitcoin/src'
make[3]: Entering directory '/opt/local/src/bitcoin'
make[3]: Leaving directory '/opt/local/src/bitcoin'
CXX crypto/libbitcoinconsensus_la-aes.lo
CXX crypto/libbitcoinconsensus_la-chacha20.lo
CXX crypto/libbitcoinconsensus_la-hmac_sha256.lo
CXX crypto/libbitcoinconsensus_la-hmac_sha512.lo
CXX crypto/libbitcoinconsensus_la-ripemd160.lo
CXX crypto/libbitcoinconsensus_la-sha1.lo
CXX crypto/libbitcoinconsensus_la-sha256.lo
CXX crypto/libbitcoinconsensus_la-sha512.lo
CXX crypto/libbitcoinconsensus_la-sha256_sse4.lo
CXX libbitcoinconsensus_la-arith_uint256.lo
CXX consensus/libbitcoinconsensus_la-merkle.lo
In file included from ./script/script.h:11:0,
from ./primitives/transaction.h:11,
from ./consensus/merkle.h:11,
from consensus/merkle.cpp:5:
./serialize.h:193:39: error: redefinition of 'template<class Stream> void Serialize(Stream&, int8_t)'
template<typename Stream> inline void Serialize(Stream& s, int8_t a ) { ser_wr
^
./serialize.h:192:39: note: 'template<class Stream> void Serialize(Stream&, char)' previously declared here
template<typename Stream> inline void Serialize(Stream& s, char a ) { ser_wr
^
In file included from ./script/script.h:11:0,
from ./primitives/transaction.h:11,
from ./consensus/merkle.h:11,
from consensus/merkle.cpp:5:
./serialize.h:209:39: error: redefinition of 'template<class Stream> void Unserialize(Stream&, int8_t&)'
template<typename Stream> inline void Unserialize(Stream& s, int8_t& a ) { a =
^
./serialize.h:208:39: note: 'template<class Stream> void Unserialize(Stream&, char&)' previously declared here
template<typename Stream> inline void Unserialize(Stream& s, char& a ) { a =
^
Makefile:8138: recipe for target 'consensus/libbitcoinconsensus_la-merkle.lo' failed
make[2]: *** [consensus/libbitcoinconsensus_la-merkle.lo] Error 1
make[2]: Leaving directory '/opt/local/src/bitcoin/src'
Makefile:9824: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/opt/local/src/bitcoin/src'
Makefile:756: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
``` | https://github.com/bitcoin/bitcoin/issues/13576 | https://github.com/bitcoin/bitcoin/pull/13580 | 686e97a0c7358291d628213447cf33e99cde7ce8 | 49d1f4cdde6d3289cb8c18ad35fc739371e25388 | 2018-06-30T09:50:46Z | c++ | 2018-07-01T15:37:28Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,538 | ["src/crypto/sha256.cpp"] | Linux gitian build fails in SHA256AutoDetect: inconsistent operand constraints in an ‘asm’ | Full log: https://bitcoin.jonasschnelli.ch/builds/667/build_linux.log
Excerpt:
```
crypto/sha256.cpp: In function ‘std::string SHA256AutoDetect()’:
crypto/sha256.cpp:537:83: error: inconsistent operand constraints in an ‘asm’
__asm__ ("cpuid" : "=a"(a), "=b"(b), "=c"(c), "=d"(d) : "0"(leaf), "2"(subleaf));
^
crypto/sha256.cpp:537:83: error: inconsistent operand constraints in an ‘asm’
__asm__ ("cpuid" : "=a"(a), "=b"(b), "=c"(c), "=d"(d) : "0"(leaf), "2"(subleaf));
^
make[2]: *** [crypto/crypto_libbitcoin_crypto_base_a-sha256.o] Error 1
make[2]: *** Waiting for unfinished jobs....
CXXLD libunivalue.la
make[3]: Leaving directory `/home/ubuntu/build/bitcoin/distsrc-i686-pc-linux-gnu/src/univalue'
make[2]: Leaving directory `/home/ubuntu/build/bitcoin/distsrc-i686-pc-linux-gnu/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/ubuntu/build/bitcoin/distsrc-i686-pc-linux-gnu/src'
make: *** [all-recursive] Error 1 | https://github.com/bitcoin/bitcoin/issues/13538 | https://github.com/bitcoin/bitcoin/pull/13611 | 0212187fc624ea4a02fc99bc57ebd413499a9ee1 | 63c16ed50770bc3d4f0ecd2ffa971fcfa0688494 | 2018-06-25T22:50:22Z | c++ | 2018-07-07T16:01:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,495 | ["depends/packages/packages.mk", "depends/packages/qt.mk", "depends/packages/xextproto.mk"] | QT cross compile to ARM | There are ARM devices out there with HDMI and full desktop linux support. I was able to compile and use QT on an Orange Pi Plus2E running Lubuntu 16.04. Compilation on the device itself takes several hours and QT spends a few minutes loading stuff, but otherwise the UI is pretty snappy.
Gitian builds currently don't include binaries for ARM. Cross compilation (for Gitian) was added in #8188, but QT was intentionally left out. Does anyone remember why?
I've been trying to get this to work on Ubuntu Bionic, but no success so far.
The first step to enabling this (for 32 bit) is to add `qt_arm_linux_packages:=$(qt_x86_64_linux_packages)` to `depends/packages.mk`. That prevents it from skipping QT. This however will result in an error:
```
make HOST=arm-linux-gnueabihf
Configuring qt...
[...]
The specified system/compiler is not supported:
[...]/bitcoin/depends/work/build/arm-linux-gnueabihf/qt/5.7.1-c292d7b0435/qtbase/mkspecs/arm-linux-gnueabihf
Please see the README file for a complete list.
funcs.mk:242: recipe for target '[...]/bitcoin/depends/work/build/arm-linux-gnueabihf/qt/5.7.1-c292d7b0435/qtbase/.stamp_con
```
I tried replacing `$(package)_config_opts_arm_linux = $(host)` with ` = -platform linux-g++ -xplatform linux-arm-gnueabi-g++`, which seems to result in something being built. But configure isn't happy:
```sh
./configure --prefix=$PWD/depends/arm-linux-gnueabihf --enable-glibc-back-compat --enable-reduce-exports LDFLAGS=-static-libstdc++ --disable-tests --disable-bench --with-qrencode --with-gui=qt5
[...]
checking for QT5... yes
checking for QT_TEST... yes
checking for QT_DBUS... yes
checking for static Qt... yes
checking for QTPLATFORM... yes
checking for X11XCB... yes
checking for QTXCBQPA... yes
checking for Qt < 5.4... no
checking for static Qt plugins: -lqminimal... no
configure: error: Could not resolve: -lqminimal
```
I tried building the depends with #12971 with `QT_59=1`, but this fails with:
```
Note: Disabling X11 Accessibility Bridge: D-Bus or AT-SPI is missing.
ERROR: Feature 'system-zlib' was enabled, but the pre-condition 'libs.zlib' failed.
funcs.mk:242: recipe for target '[...]/bitcoin/depends/work/build/arm-linux-gnueabihf/qt/5.9.5-28b90c3bee9/qtbase/.stamp_configured' failed
make: *** [[...]/bitcoin/depends/work/build/arm-linux-gnueabihf/qt/5.9.5-28b90c3bee9/qtbase/.stamp_configured] Error 3
```
Hopefully someone who actually understands the depends system and cross compilation has more luck... | https://github.com/bitcoin/bitcoin/issues/13495 | https://github.com/bitcoin/bitcoin/pull/13696 | e8ffec69f773e67ae82535afc87164eb8102f05e | 00db418176043226bcc337398ec514a973fa6da5 | 2018-06-18T13:34:27Z | c++ | 2018-07-29T13:59:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,478 | ["build-aux/m4/bitcoin_qt.m4", "doc/dependencies.md", "doc/release-notes-15393.md", "src/qt/bitcoin.cpp", "src/qt/test/apptests.cpp", "src/qt/test/rpcnestedtests.cpp"] | [RFC] gui: Minimum required Qt5 | ~~With removal of support for Qt4 [not far away](https://github.com/bitcoin/bitcoin/pull/13458), opening this for any thoughts on setting a minimum required qt5 version. It could be quite possible for us to support Qt 5.0+.~~
Qt4 support was removed in #13458.
The current minimum required Qt is `5.2`. Set in #14725.
#### [Qt Versions](https://download.qt.io/official_releases/qt):
[5.12 (LTS)](https://doc.qt.io/qt-5.12/supported-platforms.html) Supported for 3 years post release.
[5.11](https://doc.qt.io/qt-5.11/supported-platforms.html) Supported until May 2019
[5.10](https://doc.qt.io/archives/qt-5.10/supported-platforms.html) Supported until Dec 2018 (Archived).
[5.9 (LTS)](https://doc.qt.io/qt-5.9/supported-platforms.html) Supported until May 31, 2020.
[5.6 (LTS)](https://doc.qt.io/qt-5.6/supported-platforms.html) Supported until Mar. 16, 2019 (will end around the same time as the `v0.18.0` release).
Any other releases older than 5.10 are no longer supported (by Qt).
Qt releases seem to be getting more frequent, and in some cases more aggressive about dropping support for OS versions. i.e macOS >`10.12` is required for Qt `5.12`.
#### Qt Feature Usage:
There are the following usages of `QT_VERSION` (excluding bitcoin_qt.m4) in the code:
* [QT_VERSION >= 0x050600](https://github.com/bitcoin/bitcoin/blob/master/src/qt/bitcoin.cpp#L446) - 5.6+ Enables high-DPI scaling on supported platforms.
* ~~[QT_VERSION >= 0x050500](https://github.com/bitcoin/bitcoin/blob/master/src/qt/bitcoin.cpp#L595) - 5.5+ Disable SSL and use TLS 1.0+.~~
* [QT_VERSION < 0x050400](https://github.com/bitcoin/bitcoin/blob/master/src/qt/bitcoin.cpp#L58) // Import AccessibleFactory plugin.
* [QT_VERSION >= 0x050300](https://github.com/bitcoin/bitcoin/blob/master/src/qt/test/rpcnestedtests.cpp#L123) - 5.3+ tests using QVERIFY_EXCEPTION_THROWN.
* ~~[QT_VERSION >= 0x050200](https://github.com/bitcoin/bitcoin/blob/master/src/qt/guiutil.cpp#L64), [QT_VERSION >= 0x050200](https://github.com/bitcoin/bitcoin/blob/master/src/qt/guiutil.cpp#L94) - 5.2+ Returns the most appropriate system font.~~
* ~~[QT_VERSION >= 0x050200](https://github.com/bitcoin/bitcoin/blob/master/src/qt/macdockiconhandler.mm#L59) - Set this menu to be the dock menu available by option-clicking on the application dock icon. macOS only.~~
* ~~[QT_VERSION > 0x050100](https://github.com/bitcoin/bitcoin/blob/master/src/qt/bitcoin.cpp#L585) - 5.1+ Support for high-dpi pixmaps.~~
* ~~[QT_VERSION > 0x050100](https://github.com/bitcoin/bitcoin/blob/master/src/qt/splashscreen.cpp#L39), [QT_VERSION > 0x050100](https://github.com/bitcoin/bitcoin/blob/master/src/qt/splashscreen.cpp#L55) - Sets the device pixel ratio for the splash-screen.~~
* ~~[QT_VERSION >= 0x050000](https://github.com/bitcoin/bitcoin/blob/master/src/qt/paymentrequestplus.cpp#L100) - Determine if a certificate is blacklisted.~~ Removed in #13458. | https://github.com/bitcoin/bitcoin/issues/13478 | https://github.com/bitcoin/bitcoin/pull/15393 | 7d3f255316fc0d45272a38e3fea206105f67dc45 | fd46c4c0018c41d36cd892ccb47485b572d65837 | 2018-06-15T15:36:32Z | c++ | 2019-02-14T10:12:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,469 | ["Makefile.am"] | Intermittent Mac CI failure | Occasional mac build failures, with logs ending as follows, perhaps related to "Warning: Could not detect Qt's path, skipping plugin deployment!"
```
make[1]: Entering directory '/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-apple-darwin11'
make[1]: Nothing to be done for 'all-am'.
make[1]: Leaving directory '/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-apple-darwin11'
make -C src qt/bitcoin-qt
make[1]: Entering directory '/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-apple-darwin11/src'
make[1]: Leaving directory '/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-apple-darwin11/src'
/bin/mkdir -p Bitcoin-Qt.app/Contents/MacOS
STRIPPROG="/home/travis/build/bitcoin/bitcoin/depends/x86_64-apple-darwin11/share/../native/bin/x86_64-apple-darwin11-strip" /bin/bash /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-apple-darwin11/build-aux/install-sh -c -s src/qt/bitcoin-qt Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
INSTALLNAMETOOL=/home/travis/build/bitcoin/bitcoin/depends/x86_64-apple-darwin11/share/../native/bin/x86_64-apple-darwin11-install_name_tool OTOOL=/home/travis/build/bitcoin/bitcoin/depends/x86_64-apple-darwin11/share/../native/bin/x86_64-apple-darwin11-otool STRIP=/home/travis/build/bitcoin/bitcoin/depends/x86_64-apple-darwin11/share/../native/bin/x86_64-apple-darwin11-strip /usr/bin/python3.6 ./contrib/macdeploy/macdeployqtplus Bitcoin-Qt.app -translations-dir=/home/travis/build/bitcoin/bitcoin/depends/x86_64-apple-darwin11/share/../translations -add-qt-tr da,de,es,hu,ru,uk,zh_CN,zh_TW -verbose 2
+ Copying source bundle +
+ Deploying frameworks +
Warning: Could not find any external frameworks to deploy in dist/Bitcoin-Qt.app.
+ Installing qt.conf +
+ Adding Qt translations +
+ Done +
Warning: Could not detect Qt's path, skipping plugin deployment!
/bin/mkdir -p dist/.background
/usr/bin/tiffcp -c none dpi36.background.tiff dpi72.background.tiff dist/.background/background.tiff
/usr/bin/python3.6 contrib/macdeploy/custom_dsstore.py "dist/.DS_Store" "Bitcoin-Core"
/home/travis/build/bitcoin/bitcoin/depends/x86_64-apple-darwin11/share/../native/bin/genisoimage -no-cache-inodes -D -l -probe -V "Bitcoin-Core" -no-pad -r -dir-mode 0755 -apple -o Bitcoin-Core.dmg dist
/home/travis/build/bitcoin/bitcoin/depends/x86_64-apple-darwin11/share/../native/bin/genisoimage: Warning: assuming PC Exchange cluster size of 512 bytes
30.79% done, estimate finish Thu Jun 14 09:33:16 2018
61.60% done, estimate finish Thu Jun 14 09:33:16 2018
92.30% done, estimate finish Thu Jun 14 09:33:16 2018
Total translation table size: 0
Total rockridge attributes bytes: 3197
Total directory bytes: 13084
Path table size(bytes): 118
Max brk space used 0
16257 extents written (31 MB)
The command "DOCKER_EXEC make $MAKEJOBS $GOAL || ( echo "Build failure. Verbose build follows." && DOCKER_EXEC make $GOAL V=1 ; false )" exited with 1.
[...]
Done. Your build exited with 1.
```
E.g:
https://travis-ci.org/bitcoin/bitcoin/jobs/392160315 #13235
https://travis-ci.org/bitcoin/bitcoin/jobs/392060921
https://travis-ci.org/bitcoin/bitcoin/jobs/392041383 #13467
https://travis-ci.org/bitcoin/bitcoin/jobs/391907335 #13460
Also hit https://github.com/bitcoin/bitcoin/pull/13461#issuecomment-397132232 | https://github.com/bitcoin/bitcoin/issues/13469 | https://github.com/bitcoin/bitcoin/pull/13465 | 4a7e64fc85461a205f2b51da52d1455795d43b91 | cf01fd6f9c1a31d16884cd1a1a686602b4b47027 | 2018-06-14T10:49:59Z | c++ | 2018-06-14T19:43:12Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,456 | ["src/test/mempool_tests.cpp"] | Variadic macro in mempool_tests.cpp breaking MSVC build | The use of three macros with variadic arguments was added to src/test/mempool_test.cpp in https://github.com/bitcoin/bitcoin/commit/f77e1d34fd5f17304ce319b5f962b8005592501a.
The three macros below generate a compiler error with MSVC.
`#define MK_OUTPUTS(amounts...) std::vector<CAmount>{amounts}`
`#define MK_INPUTS(txs...) std::vector<CTransactionRef>{txs}`
`#define MK_INPUT_IDX(idxes...) std::vector<uint32_t>{idxes}`
The easy fix is to add a ',' after the named argument as per:
`#define MK_OUTPUTS(amounts,...) std::vector<CAmount>{amounts}`
`#define MK_INPUTS(txs,...) std::vector<CTransactionRef>{txs}`
`#define MK_INPUT_IDX(idxes,...) std::vector<uint32_t>{idxes}`
I don't know if that will break any other compilers.
If I had a spare 198 Swiss Francs I'd buy the C standard and check which is the correct approach, https://www.iso.org/standard/57853.html, but I don't.
| https://github.com/bitcoin/bitcoin/issues/13456 | https://github.com/bitcoin/bitcoin/pull/13457 | a607d23ae82ee374799d21d02932d945c1ce9616 | faf52f953b47aac6a39892b037eaa3f08d46b655 | 2018-06-13T11:44:18Z | c++ | 2018-06-13T13:58:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,401 | ["configure.ac", "src/Makefile.am", "src/crypto/sha256.cpp", "src/crypto/sha256_arm_shani.cpp", "src/crypto/sha256_x86_shani.cpp"] | ARMv8 sha2 support | I assume #13191 make this less hard, although benefits may be small. Brief [chat on IRC](https://botbot.me/freenode/bitcoin-core-dev/2018-06-05/?msg=100812298&page=2):
Me
> While trying to get bitcoind to run on one the many *-pi's out there, I wondered: has anyone ever tried to design a system on chip that's optimal for this?
@laanwj:
> provoostenator: you mean secp256k1 specific instructions? people have been thingking about it, could be done on a FPGA, but I don't think it's ever been done
Me:
> echeveria seems to believe sha256 is the bottleneck (see #bitcoin), but also that anything outside the CPU would be too slow I/O to be worh it.
echeveria:
> I looked at the Zynq combination FPGA / ARM devices a long time ago and came to the conclusion that the copy time even on the shared memory bus between the two chips would make it non viable. I'd enjoy being proved wrong though.
laanwj:
> provoostenator: well sha256 extension instructions exist for ARM (supported on newer SoCs), I intend to add support for them at some point. But I would be surprised if that is the biggest bottleneck in validation.
echeveria:
> yes, if there is high-bandwidth communication between two chpis that tends to dominate. I was > thinking of, say, RiscV extensions for secp256k1 validation so it's in-core.
> for ARM it's somewhat unlikely at this time
I have (at least) three devices to test this on, which all have 4 to 8 ARM Cortex-A53 cores, and 1- 4 GB RAM: an Android Xiaomi A1 ([ABCore](https://github.com/greenaddress/abcore) syncs the whole chain in less than a month), a NanoPi Neo Plus and a Khadas VIM2 Max.
Maybe this c++ code is useful: https://github.com/randombit/botan/issues/841 | https://github.com/bitcoin/bitcoin/issues/13401 | https://github.com/bitcoin/bitcoin/pull/24115 | 3ce40e64d4ae9419658555fd1fb250b93f52684a | c23bf06492dddacfc0eece3d4dd12cce81496dd0 | 2018-06-05T20:13:14Z | c++ | 2022-02-14T20:12:39Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,363 | ["contrib/devtools/update-translations.py"] | Make update-translations.py script check for bitcoin addresses | Someone on the Russian translation added a bitcoin address into the translation, with the idea of confusing people to send coins there. Luckily no one fell for it, but this could have been different.
(was reverted in https://github.com/bitcoin/bitcoin/commit/4ea3e8ef070417ccc22007407d78fa0a41949bee#diff-77c4348ab69f5c434e7b9eda0a655549R66)
To avoid this, an idea would be to add a check to the `contrib/devtools/update-translations.py` script that checks each message for valid bitcoin addresses, and warn, as well as drop the message if it encounters one.
(edit: the "valid" check is not even necessary, I think it would be enough to reject things that look like addresses with a regexp) | https://github.com/bitcoin/bitcoin/issues/13363 | https://github.com/bitcoin/bitcoin/pull/13374 | e24bf1ce184bc8d5bba70a3f3e9c43c2df07f4d3 | 85f0135eaefe3d9f696689a7e83606c579da40a8 | 2018-06-01T09:38:57Z | c++ | 2018-06-05T11:49:21Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.