status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,293 | ["src/wallet/wallet.cpp", "test/functional/fundrawtransaction.py"] | SEGV in segwit fundrawtransaction | The following will crash bitcoind 0.14.1:
```
bitcoin-cli -regtest fundrawtransaction 01000000000106220000000000001600149bf98693c5892c3e7b6d991cfeebf146285f59bd00000000 '{"changePosition": 1}'
```
I've uploaded the corresponding regtest chainstate here: https://github.com/VidaID/bitcoin/blob/fund_segwit_segv/regtest.tar.bz2
Just untar that into ~/.bitcoin, start `bitcoind -regtest -daemon=0` and run the above `fundrawtransaction`.
Stack trace with debug output is:
```
0x00005555556bde23 in prevector<28u, unsigned char, unsigned int, int>::prevector (this=0x7fff580201f0, other=...)
at prevector.h:252
252 new(static_cast<void*>(item_ptr(size() - 1))) T(*it);
(gdb) where
#0 0x00005555556bde23 in prevector<28u, unsigned char, unsigned int, int>::prevector (this=0x7fff580201f0, other=...)
at prevector.h:252
#1 0x00005555556ba8c2 in CScript::CScript (this=0x7fff580201f0) at ./script/script.h:376
#2 0x00005555556f63cc in CTxOut::CTxOut (this=0x7fff580201e8) at ./primitives/transaction.h:132
#3 0x00005555557c600f in __gnu_cxx::new_allocator<CTxOut>::construct<CTxOut, CTxOut const&> (this=0x7fffb8ff7ea0,
__p=0x7fff580201e8, __args#0=...) at /usr/include/c++/6/ext/new_allocator.h:120
#4 0x00005555557c32a6 in std::allocator_traits<std::allocator<CTxOut> >::construct<CTxOut, CTxOut const&> (__a=...,
__p=0x7fff580201e8, __args#0=...) at /usr/include/c++/6/bits/alloc_traits.h:455
#5 0x0000555555a87044 in std::vector<CTxOut, std::allocator<CTxOut> >::_M_insert_aux<CTxOut const&> (
this=0x7fffb8ff7ea0, __position=..., __args#0=...) at /usr/include/c++/6/bits/vector.tcc:361
#6 0x0000555555a7bd69 in std::vector<CTxOut, std::allocator<CTxOut> >::insert (this=0x7fffb8ff7ea0, __position=...,
__x=...) at /usr/include/c++/6/bits/vector.tcc:131
#7 0x0000555555a628de in CWallet::FundTransaction (this=0x555556766150, tx=..., nFeeRet=@0x7fffb8ff7e10: 11760,
overrideEstimatedFeeRate=false, specificFeeRate=..., nChangePosInOut=@0x7fffb8ff7db8: 1, strFailReason="",
includeWatching=false, lockUnspents=false, setSubtractFeeFromOutputs=std::set with 0 elements, keepReserveKey=true,
destChange=...) at wallet/wallet.cpp:2344
#8 0x0000555555a27562 in fundrawtransaction (request=...) at wallet/rpcwallet.cpp:2659
#9 0x00005555557d5338 in CRPCTable::execute (this=0x55555611ed00 <tableRPC>, request=...) at rpc/server.cpp:491
#10 0x00005555559476c0 in HTTPReq_JSONRPC (req=0x7fff84001670) at httprpc.cpp:193
#11 0x000055555574c747 in std::_Function_handler<bool (HTTPRequest*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&), bool (*)(HTTPRequest*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)>::_M_invoke(std::_Any_data const&, HTTPRequest*&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (__functor=...,
__args#0=<unknown type in /usr/local/bin/bitcoind, CU 0x571560, DIE 0x5c6e84>, __args#1="")
at /usr/include/c++/6/functional:1726
#12 0x0000555555950b7a in std::function<bool (HTTPRequest*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)>::operator()(HTTPRequest*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const (this=0x7fff84001780, __args#0=0x7fff84001670, __args#1="") at /usr/include/c++/6/functional:2136
#13 0x000055555594ea71 in HTTPWorkItem::operator() (this=0x7fff84001750) at httpserver.cpp:51
#14 0x0000555555951d65 in WorkQueue<HTTPClosure>::Run (this=0x5555561a0050) at httpserver.cpp:132
#15 0x000055555594bb01 in HTTPWorkQueueRun (queue=0x5555561a0050) at httpserver.cpp:361
#16 0x00005555559618f8 in std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)>::_M_invoke<0ul>(std::_Index_tuple<0ul>) (this=0x5555561a0248) at /usr/include/c++/6/functional:1400
#17 0x000055555596108c in std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)>::operator()() (
this=0x5555561a0248) at /usr/include/c++/6/functional:1389
#18 0x0000555555960a91 in std::thread::_State_impl<std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)> >::_M_run() (this=0x5555561a0240) at /usr/include/c++/6/thread:196
#19 0x00007ffff615f50f in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#20 0x00007ffff596d6ca in start_thread (arg=0x7fffb8ff9700) at pthread_create.c:333
#21 0x00007ffff56a70af in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:105
```
It looks like the crash is in dereferencing the iterator `*it`. `other.begin()` seems to be pointing to a low memory value 0x06. I'm guessing this is an implementation error in the `prevector` class.
Dropping the restriction on changeposition or letting it be 0 will not crash. | https://github.com/bitcoin/bitcoin/issues/10293 | https://github.com/bitcoin/bitcoin/pull/10294 | 4c924011f535c46b3bc02bef8b7e2a8ad559d78d | 7c588637d467bfa18f48a7ca71c0700f90833ea1 | 2017-04-28T19:37:12Z | c++ | 2017-05-01T12:07:09Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,291 | ["src/qt/modaloverlay.cpp"] | crazy 'estimated time left until synced' estimate | Running "Bitcoin version v0.14.0.0-b0c9b33" when it first started up I saw this:
1. The estimated time is way too high. It will only take a few hours to sync the remaining blocks.
2. The estimation is shown as a huge number of seconds instead of converting it to "48 years". Later, the estimation changed to "3 hours", so the code is capable of doing such conversions, but in this case it didn't. | https://github.com/bitcoin/bitcoin/issues/10291 | https://github.com/bitcoin/bitcoin/pull/11237 | 3b69a08c53c2ef738f32c270fdacf1e4ed5a4c97 | c8d38abd65d920ec28c68020bf910cfa79216bd5 | 2017-04-27T22:28:10Z | c++ | 2017-09-05T22:50:05Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,268 | ["test/functional/test_framework/test_framework.py", "test/functional/test_runner.py", "test/functional/zmq_test.py"] | zmq_test.py fails with out-of-tree builds | `zmq_test.py`, when run from `test/functional/test_runner.py`, fails when running it with an out-of-tree build:
```
zmq_test.py failed, Duration: 0 s
stdout:
2017-04-24 13:26:51.336000 TestFramework (INFO): Initializing test directory /tmp/testvfbalauk/558
2017-04-24 13:26:51.460000 TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
File "/store/orion/projects/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 150, in main
self.setup_network()
File "/store/orion/projects/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 62, in setup_n
etwork
self.nodes = self.setup_nodes()
File "/home/orion/projects/bitcoin/bitcoin/test/functional/zmq_test.py", line 32, in setup_nodes
config.read_file(open(os.path.dirname(__file__) + "/config.ini"))
FileNotFoundError: [Errno 2] No such file or directory: '/home/orion/projects/bitcoin/bitcoin/test/functional/config.ini'
2017-04-24 13:26:51.477000 TestFramework (INFO): Stopping nodes
stderr:
Traceback (most recent call last):
File "/home/orion/projects/bitcoin/bitcoin/test/functional/zmq_test.py", line 110, in <module>
ZMQTest ().main ()
File "/store/orion/projects/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 166, in main
stop_nodes(self.nodes)
File "/store/orion/projects/bitcoin/bitcoin/test/functional/test_framework/util.py", line 380, in stop_nodes
for i, node in enumerate(nodes):
TypeError: 'NoneType' object is not iterable
```
I think the problem was introduced in 6803e09e6eeb2dbc820bb1025475a50a4352e30d. This added `config.read_file(open(os.path.dirname(__file__) + "/config.ini"))` to `test/functional/zmq_test.py`.
Note that with out-of-tree builds, only `test/functional/test_runner.py` is symlinked, not all of the tests. The rest is simply executed in-place in the source directory. So individual tests won't find a `config.ini`. A potential solution would be to allow overriding the `config.ini` location through an environment variable or command line argument.
Same happens when launching the test manually:
```bash
BITCOIND=$BUILDDIR/src/bitcoind $SRCDIR/bitcoin/test/functional/zmq_test.py
```
In a pinch it can be worked around by adding a link in the source directory (ugly!)
```bash
ln -s $BUILDDIR/test/functional/config.ini $SRCDIR/test/functional/config.ini
``` | https://github.com/bitcoin/bitcoin/issues/10268 | https://github.com/bitcoin/bitcoin/pull/10307 | e2b99b13131b5d0fd6fae6d55892c2ebb327d438 | b8251f63373ed58a05d104f9c1637d2c07b3569e | 2017-04-24T13:33:44Z | c++ | 2017-05-01T19:12:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,209 | ["Makefile.am", "src/Makefile.am"] | Stalled shutdown | Not sure if this is a real issue but just had a stalled shutdown on a node:
The node is running the master at `c7e73eafa139c29a38f73ab697e2e967a386908d` from Wed Apr 5 11:29:19 2017.
As you can see, it took > 7 mins from a requested shutdown to a net thread exit.
Debug log:
```shell
2017-04-14 07:34:12 Shutdown: In progress...
2017-04-14 07:41:47 net thread exit
2017-04-14 07:41:47 sending version (103 bytes) peer=193
2017-04-14 07:41:47 msghand thread exit
2017-04-14 07:41:47 send version message: version 70015, blocks=461809, us=[::]:0, peer=193
2017-04-14 07:41:47 opencon thread exit
2017-04-14 07:41:47 Flushed 69008 addresses to peers.dat 109ms
2017-04-14 07:41:47 disconnecting peer=0
2017-04-14 07:41:47 disconnecting peer=1
2017-04-14 07:41:47 disconnecting peer=5
2017-04-14 07:41:47 disconnecting peer=7
2017-04-14 07:41:47 disconnecting peer=19
2017-04-14 07:41:47 disconnecting peer=24
2017-04-14 07:41:47 disconnecting peer=25
2017-04-14 07:41:47 disconnecting peer=38
2017-04-14 07:41:47 disconnecting peer=58
2017-04-14 07:41:47 disconnecting peer=137
2017-04-14 07:41:47 disconnecting peer=169
2017-04-14 07:41:47 disconnecting peer=178
2017-04-14 07:41:47 disconnecting peer=183
2017-04-14 07:41:47 disconnecting peer=185
2017-04-14 07:41:47 disconnecting peer=190
2017-04-14 07:41:47 disconnecting peer=193
2017-04-14 07:41:48 Dumped mempool: 0.046245s to copy, 0.174033s to dump
2017-04-14 07:41:48 Shutdown: done
```
The backtraces during the stalling are:
```cpp
(gdb) thread apply all bt
Thread 5 (Thread 0x7f777ffff700 (LWP 2034)):
#0 pthread_cond_wait@@GLIBC_2.3.2 () at ../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1 0x00007f77b76419eb in BGThread (this=0x7f77b8dd94b0) at leveldb/util/env_posix.cc:574
#2 leveldb::(anonymous namespace)::PosixEnv::BGThreadWrapper (arg=0x7f77b8dd94b0) at leveldb/util/env_posix.cc:521
#3 0x00007f77b4a93064 in start_thread (arg=0x7f777ffff700) at pthread_create.c:309
#4 0x00007f77b47c862d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
Thread 4 (Thread 0x7f7767fff700 (LWP 2038)):
#0 __lll_lock_wait () at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
#1 0x00007f77b4a95494 in _L_lock_952 () from /lib/x86_64-linux-gnu/libpthread.so.0
#2 0x00007f77b4a952f6 in __GI___pthread_mutex_lock (mutex=0x7f775c1d12e8) at ../nptl/pthread_mutex_lock.c:114
#3 0x00007f77b730fd2d in lock (this=<optimized out>) at /usr/include/boost/thread/pthread/recursive_mutex.hpp:110
#4 lock (this=<optimized out>) at sync.h:60
#5 lock (this=0x7f7767feeb50) at /usr/include/boost/thread/lock_types.hpp:346
#6 Enter (pszName=<optimized out>, pszFile=<optimized out>, nLine=<optimized out>, this=0x7f7767feeb50) at sync.h:124
#7 CMutexLock<CCriticalSection>::CMutexLock (this=0x7f7767feeb50, mutexIn=..., pszName=<optimized out>, pszFile=<optimized out>, nLine=<optimized out>, fTry=<optimized out>) at sync.h:145
#8 0x00007f77b733bcfa in CConnman::ThreadSocketHandler (this=0x7f77b8ddc010) at net.cpp:1293
#9 0x00007f77b730c68d in operator() (this=0x7f7767ffeeb0) at /usr/include/c++/4.9/functional:2439
#10 TraceThread<std::function<void ()> >(char const*, std::function<void ()>) (name=0x7f77b76c9cfc "net", func=...) at util.h:266
#11 0x00007f77b733f95b in _M_invoke<0ul, 1ul> (this=<optimized out>) at /usr/include/c++/4.9/functional:1700
#12 operator() (this=<optimized out>) at /usr/include/c++/4.9/functional:1688
#13 std::thread::_Impl<std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)> >::_M_run() (this=<optimized out>) at /usr/include/c++/4.9/thread:115
#14 0x00007f77b5275970 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#15 0x00007f77b4a93064 in start_thread (arg=0x7f7767fff700) at pthread_create.c:309
#16 0x00007f77b47c862d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
Thread 3 (Thread 0x7f77667fc700 (LWP 2041)):
#0 __lll_lock_wait () at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
#1 0x00007f77b4a95494 in _L_lock_952 () from /lib/x86_64-linux-gnu/libpthread.so.0
#2 0x00007f77b4a952f6 in __GI___pthread_mutex_lock (mutex=0x7f77b7a73880 <cs_main>) at ../nptl/pthread_mutex_lock.c:114
#3 0x00007f77b730fd2d in lock (this=<optimized out>) at /usr/include/boost/thread/pthread/recursive_mutex.hpp:110
#4 lock (this=<optimized out>) at sync.h:60
---Type <return> to continue, or q <return> to quit---
#5 lock (this=0x7f77667fb690) at /usr/include/boost/thread/lock_types.hpp:346
#6 Enter (pszName=<optimized out>, pszFile=<optimized out>, nLine=<optimized out>, this=0x7f77667fb690) at sync.h:124
#7 CMutexLock<CCriticalSection>::CMutexLock (this=0x7f77667fb690, mutexIn=..., pszName=<optimized out>, pszFile=<optimized out>, nLine=<optimized out>, fTry=<optimized out>) at sync.h:145
#8 0x00007f77b735e512 in (anonymous namespace)::InitializeNode (pnode=0x7f774c2ba150, connman=...) at net_processing.cpp:271
#9 0x00007f77b7353e36 in operator() (a1=..., a0=<optimized out>, this=<optimized out>) at /usr/include/boost/function/function_template.hpp:767
#10 m_invoke<boost::function<void(CNode*, CConnman&)>, 0u, 1u, CNode*&, CConnman&> (args=..., func=..., this=<optimized out>) at /usr/include/boost/signals2/detail/variadic_slot_invoker.hpp:92
#11 operator()<boost::function<void(CNode*, CConnman&)>, CNode*&, CConnman&, 2ul> (args=..., func=..., this=<optimized out>) at /usr/include/boost/signals2/detail/variadic_slot_invoker.hpp:81
#12 m_invoke<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<void(CNode*, CConnman&), boost::function<void(CNode*, CConnman&)> >, boost::signals2::mutex> > > (connectionBody=..., this=<optimized out>) at /usr/include/boost/signals2/detail/variadic_slot_invoker.hpp:117
#13 operator()<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<void(CNode*, CConnman&), boost::function<void(CNode*, CConnman&)> >, boost::signals2::mutex> > > (connectionBody=..., this=<optimized out>) at /usr/include/boost/signals2/detail/variadic_slot_invoker.hpp:110
#14 dereference (this=0x7f77667fb7d0) at /usr/include/boost/signals2/detail/slot_call_iterator.hpp:82
#15 dereference<boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<boost::signals2::detail::void_type, CNode*, CConnman&>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<void(CNode*, CConnman&), boost::function<void(CNode*, CConnman&)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<void(CNode*, CConnman&), boost::function<void(CNode*, CConnman&)> >, boost::signals2::mutex> > > (f=...) at /usr/include/boost/iterator/iterator_facade.hpp:514
#16 operator* (this=0x7f77667fb7d0) at /usr/include/boost/iterator/iterator_facade.hpp:639
#17 operator()<boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<boost::signals2::detail::void_type, CNode*, CConnman&>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<void(CNode*, CConnman&), boost::function<void(CNode*, CConnman&)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<void(CNode*, CConnman&), boost::function<void(CNode*, CConnman&)> >, boost::signals2::mutex> > > (last=..., first=..., this=<optimized out>) at /usr/include/boost/signals2/optional_last_value.hpp:55
#18 operator()<boost::signals2::optional_last_value<void>, boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<boost::signals2::detail::void_type, CNode*, CConnman&>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<void(CNode*, CConnman&), boost::function<void(CNode*, CConnman&)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<void(CNode*, CConnman&), boost::function<void(CNode*, CConnman&)> >, boost::signals2::mutex> > > (last=..., first=..., combiner=..., this=<optimized out>) at /usr/include/boost/signals2/detail/result_type_wrapper.hpp:64
#19 boost::signals2::detail::signal_impl<void (CNode*, CConnman&), boost::signals2::optional_last_value<void>, int, std::less<int>, boost::function<void (CNode*, CConnman&)>, boost::function<void (boost::signals2::connection const&, CNode*, CConnman&)>, boost::signals2::mutex>::operator()(CNode*, CConnman&) (this=<optimized out>, args#0=0x7f774c2ba150, args#1=...) at /usr/include/boost/signals2/detail/signal_template.hpp:246
#20 0x00007f77b7334d2d in operator() (args#1=..., args#0=<optimized out>, this=0x7f77b7a718f0 <g_signals+48>) at /usr/include/boost/signals2/detail/signal_template.hpp:695
#21 CConnman::OpenNetworkConnection (this=this@entry=0x7f77b8ddc010, addrConnect=..., fCountFailure=<optimized out>, grantOutbound=grantOutbound@entry=0x7f77667fbbb0, pszDest=pszDest@entry=0x0,
fOneShot=fOneShot@entry=false, fFeeler=false, fAddnode=false) at net.cpp:1940
#22 0x00007f77b7335b1b in CConnman::ThreadOpenConnections (this=<optimized out>) at net.cpp:1814
#23 0x00007f77b730c68d in operator() (this=0x7f77667fbeb0) at /usr/include/c++/4.9/functional:2439
#24 TraceThread<std::function<void ()> >(char const*, std::function<void ()>) (name=0x7f77b768222c "opencon", func=...) at util.h:266
---Type <return> to continue, or q <return> to quit---
#25 0x00007f77b733f95b in _M_invoke<0ul, 1ul> (this=<optimized out>) at /usr/include/c++/4.9/functional:1700
#26 operator() (this=<optimized out>) at /usr/include/c++/4.9/functional:1688
#27 std::thread::_Impl<std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)> >::_M_run() (this=<optimized out>) at /usr/include/c++/4.9/thread:115
#28 0x00007f77b5275970 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#29 0x00007f77b4a93064 in start_thread (arg=0x7f77667fc700) at pthread_create.c:309
#30 0x00007f77b47c862d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
Thread 2 (Thread 0x7f7765ffb700 (LWP 2042)):
#0 0x00007f77b4a99f0b in __libc_send (fd=43, buf=0x7f77508b89b0, n=998120, flags=-1) at ../sysdeps/unix/sysv/linux/x86_64/send.c:31
#1 0x00007f77b732d728 in CConnman::SocketSendData (this=this@entry=0x7f77b8ddc010, pnode=pnode@entry=0x7f775c1d1240) at net.cpp:844
#2 0x00007f77b7331b64 in CConnman::PushMessage(CNode*, CSerializedNetMsg&&) (this=this@entry=0x7f77b8ddc010, pnode=pnode@entry=0x7f775c1d1240,
msg=msg@entry=<unknown type in /home/jonasschnelli/bitcoin/bitcoin/src/bitcoind, CU 0x31d41a, DIE 0x4c1e2c>) at net.cpp:2770
#3 0x00007f77b7367b54 in ProcessGetData (pfrom=0x7f775c1d1240, pfrom@entry=0x7f7765ff9470, consensusParams=..., connman=..., interruptMsgProc=...) at net_processing.cpp:1045
#4 0x00007f77b736cef6 in ProcessMessage (pfrom=0x7f7765ff9470, pfrom@entry=0x7f775c1d1240, strCommand="", vRecv=..., nTimeReceived=<optimized out>, chainparams=..., connman=..., interruptMsgProc=...)
at net_processing.cpp:1600
#5 0x00007f77b737fe29 in ProcessMessages (pfrom=0x7f775c1d1240, connman=..., interruptMsgProc=...) at net_processing.cpp:2717
#6 0x00007f77b7354c54 in operator() (a2=..., a1=..., a0=<optimized out>, this=<optimized out>) at /usr/include/boost/function/function_template.hpp:767
#7 m_invoke<bool, boost::function<bool(CNode*, CConnman&, std::atomic<bool>&)>, 0u, 1u, 2u, CNode*&, CConnman&, std::atomic<bool>&> (args=..., func=..., this=<optimized out>)
at /usr/include/boost/signals2/detail/variadic_slot_invoker.hpp:87
#8 operator()<boost::function<bool(CNode*, CConnman&, std::atomic<bool>&)>, CNode*&, CConnman&, std::atomic<bool>&, 3ul> (args=..., func=..., this=<optimized out>)
at /usr/include/boost/signals2/detail/variadic_slot_invoker.hpp:81
#9 m_invoke<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool(CNode*, CConnman&, std::atomic<bool>&), boost::function<bool(CNode*, CConnman&, std::atomic<bool>&)> >, boost::signals2::mutex> > > (connectionBody=..., this=<optimized out>) at /usr/include/boost/signals2/detail/variadic_slot_invoker.hpp:123
#10 operator()<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool(CNode*, CConnman&, std::atomic<bool>&), boost::function<bool(CNode*, CConnman&, std::atomic<bool>&)> >, boost::signals2::mutex> > > (connectionBody=..., this=<optimized out>) at /usr/include/boost/signals2/detail/variadic_slot_invoker.hpp:110
#11 dereference (this=0x7f7765ffab20) at /usr/include/boost/signals2/detail/slot_call_iterator.hpp:82
#12 dereference<boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<bool, CNode*, CConnman&, std::atomic<bool>&>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool(CNode*, CConnman&, std::atomic<bool>&), boost::function<bool(CNode*, CConnman&, std::atomic<bool>&)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool(CNode*, CConnman&, std::atomic<bool>&), boost::function<bool(CNode*, CConnman&, std::atomic<bool>&)> >, boost::signals2::mutex> > > (f=...) at /usr/include/boost/iterator/iterator_facade.hpp:514
#13 operator* (this=0x7f7765ffab20) at /usr/include/boost/iterator/iterator_facade.hpp:639
#14 operator()<boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<bool, CNode*, CConnman&, std::atomic<bool>&>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool(CNode*, CConnman&, std::atomic<bool>&), boost::function<bool(CNode*, CConnman&, std::atomic<bool>&---Type <return> to continue, or q <return> to quit---
)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool(CNode*, CConnman&, std::atomic<bool>&), boost::function<bool(CNode*, CConnman&, std::atomic<bool>&)> >, boost::signals2::mutex> > > (last=..., first=..., this=<optimized out>) at net.h:419
#15 operator()<CombinerAll, boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<bool, CNode*, CConnman&, std::atomic<bool>&>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool(CNode*, CConnman&, std::atomic<bool>&), boost::function<bool(CNode*, CConnman&, std::atomic<bool>&)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool(CNode*, CConnman&, std::atomic<bool>&), boost::function<bool(CNode*, CConnman&, std::atomic<bool>&)> >, boost::signals2::mutex> > > (last=..., first=..., combiner=..., this=<optimized out>)
at /usr/include/boost/signals2/detail/result_type_wrapper.hpp:53
#16 boost::signals2::detail::signal_impl<bool (CNode*, CConnman&, std::atomic<bool>&), CombinerAll, int, std::less<int>, boost::function<bool (CNode*, CConnman&, std::atomic<bool>&)>, boost::function<bool (boost::signals2::connection const&, CNode*, CConnman&, std::atomic<bool>&)>, boost::signals2::mutex>::operator()(CNode*, CConnman&, std::atomic<bool>&) (this=<optimized out>, args#0=args#0@entry=0x7f775c1d1240, args#1=...,
args#2=...) at /usr/include/boost/signals2/detail/signal_template.hpp:246
#17 0x00007f77b7336cd8 in operator() (args#2=..., args#1=..., args#0=0x7f775c1d1240, this=0x7f77b7a718c0 <g_signals>) at /usr/include/boost/signals2/detail/signal_template.hpp:695
#18 CConnman::ThreadMessageHandler (this=0x7f77b8ddc010) at net.cpp:1970
#19 0x00007f77b730c68d in operator() (this=0x7f7765ffaeb0) at /usr/include/c++/4.9/functional:2439
#20 TraceThread<std::function<void ()> >(char const*, std::function<void ()>) (name=0x7f77b7682234 "msghand", func=...) at util.h:266
#21 0x00007f77b733f95b in _M_invoke<0ul, 1ul> (this=<optimized out>) at /usr/include/c++/4.9/functional:1700
#22 operator() (this=<optimized out>) at /usr/include/c++/4.9/functional:1688
#23 std::thread::_Impl<std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)> >::_M_run() (this=<optimized out>) at /usr/include/c++/4.9/thread:115
#24 0x00007f77b5275970 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#25 0x00007f77b4a93064 in start_thread (arg=0x7f7765ffb700) at pthread_create.c:309
#26 0x00007f77b47c862d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
Thread 1 (Thread 0x7f77b7a41740 (LWP 2018)):
#0 0x00007f77b4a9449b in pthread_join (threadid=140150789093120, thread_return=0x0) at pthread_join.c:92
#1 0x00007f77b5275837 in std::thread::join() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#2 0x00007f77b733dc4f in CConnman::Stop (this=this@entry=0x7f77b8ddc010) at net.cpp:2342
#3 0x00007f77b733e2ac in CConnman::~CConnman (this=0x7f77b8ddc010, __in_chrg=<optimized out>) at net.cpp:2395
#4 0x00007f77b72e8ec1 in operator() (this=<optimized out>, __ptr=0x7f77b8ddc010) at /usr/include/c++/4.9/bits/unique_ptr.h:76
#5 reset (__p=0x7f77b8ddc010, this=0x7f77b7a715d0 <g_connman>) at /usr/include/c++/4.9/bits/unique_ptr.h:344
#6 Shutdown () at init.cpp:206
#7 0x00007f77b72d8073 in AppInit (argc=<optimized out>, argv=<optimized out>) at bitcoind.cpp:184
#8 0x00007f77b72cac1f in main (argc=3, argv=0x7ffdf20c7978) at bitcoind.cpp:196
``` | https://github.com/bitcoin/bitcoin/issues/10209 | https://github.com/bitcoin/bitcoin/pull/10228 | 3577603701938f8d23fd30c147fa47a2a5dc2242 | 91ab8f5a997dd1c838e2216fe1e676471bf680a3 | 2017-04-14T07:46:50Z | c++ | 2017-04-18T23:14:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,140 | ["Makefile.am", "src/Makefile.am"] | UI Hangs | ### Describe the issue
The UI frequently hangs for me, either requiring me to wait a very long time for it to become responsive again, or killing bitcoin-qt and restarting it.
### Can you reliably reproduce the issue?
#### If so, please list the steps to reproduce below:
1. Start Bitcoin Core
2. Wait a few minutes
3. Minimize to the taskbar
4. Open the main window by clicking the icon in the taskbar and clicking "Show / Hide"
5. Attempt to do anything with the UI. I have found that opening the debug window and attempting to change tabs will usually cause it to hang.
### Expected behaviour
It shouldn't hang, and I shouldn't need to kill it.
### Actual behaviour
It hangs, and usually requires force killing in order make the node come back online (it seems to go offline when it hangs). I am unable to do anything with the GUI.
### What version of bitcoin-core are you using?
v0.14.99.0-f34cdcb
### Machine specs:
- OS: Ubuntu 16.04
- CPU: i7-6800k
- RAM: 32 GB | https://github.com/bitcoin/bitcoin/issues/10140 | https://github.com/bitcoin/bitcoin/pull/10228 | 3577603701938f8d23fd30c147fa47a2a5dc2242 | 91ab8f5a997dd1c838e2216fe1e676471bf680a3 | 2017-04-02T15:56:47Z | c++ | 2017-04-18T23:14:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,110 | ["build-aux/m4/bitcoin_qt.m4", "src/qt/test/test_main.cpp", "src/qt/test/wallettests.cpp"] | make check fails if building qt on a system with no display | eg if you build in a vm that doesnt have a display and intend to run bitcoin-qt on another host (or just intend to build bitcoind, but have qt installed and so build bitcoin-qt), make check raise()s in test_bitcoin-qt. This should likely be a warning instead. | https://github.com/bitcoin/bitcoin/issues/10110 | https://github.com/bitcoin/bitcoin/pull/10142 | cb598cfba1cbd23b153584e2454aa49d055ba10a | bf1026412da73b13ada3b4543e88938057362eb7 | 2017-03-28T19:49:45Z | c++ | 2017-04-03T15:07:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,103 | ["contrib/linearize/README.md", "contrib/linearize/example-linearize.cfg", "contrib/linearize/linearize-hashes.py"] | Linearize script does not use rpc cookie | It should | https://github.com/bitcoin/bitcoin/issues/10103 | https://github.com/bitcoin/bitcoin/pull/10104 | 5114f8113627791b871c88998bd5a3d36961c241 | bd41d9831fbd6a612ab7713bee00d0468be5f51a | 2017-03-28T00:56:49Z | c++ | 2017-03-30T00:12:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,079 | ["src/rpc/client.cpp", "src/rpc/rawtransaction.cpp"] | [rpc] Createrawtransaction doc does not match named args | According to the help text of createrawtransaction, the following args are accepted:
```
Arguments:
1. "inputs" (string, required) A json array of json objects
2. "outputs" (string, required) a json object with outputs
3. locktime (numeric, optional, default=0) Raw locktime. Non-0 value also locktime-activates inputs
```
however, this does not match the named args ( https://github.com/bitcoin/bitcoin/blob/8152d3fe57a991e9088d0b9d261d2b10936f45a9/src/rpc/client.cpp#L84 )
Imo, backporting a breaking change to 0.14.1 is reasonable. Though, I'd like to hear other opinions. | https://github.com/bitcoin/bitcoin/issues/10079 | https://github.com/bitcoin/bitcoin/pull/10084 | 803e6a35037e7371f767585fec36ba17bdd36f4a | fa558532192ca0bb519f811ee14df6037413b89f | 2017-03-25T16:25:01Z | c++ | 2017-03-26T10:08:44Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,004 | ["src/wallet/wallet.h", "test/functional/wallet_balance.py", "test/functional/wallet_basic.py"] | After max chain of unconfirmed change transactions, last tx is missing from memory until rescan | ## Summary:
https://github.com/bitcoin/bitcoin/blob/57b34599b2deb179ff1bd97ffeab91ec9f904d85/doc/release-notes/release-notes-0.12.0.md
_"Bitcoin Core 0.12 also introduces new default policy limits on the length and size of unconfirmed transaction chains that are allowed in the mempool (generally limiting the length of unconfirmed chains to 25 transactions, with a total size of 101 KB)."_
1) Generate a chain of transactions with unconfirmed change outputs until this maximum is hit.
2) The last tx in this chain does is not accessible from `gettransaction`, does not appear in `listunspent` and will not be mined into a block until the node is restarted with `-rescan` (luckily 0.14.0 saves mempool to disk so the tx is "found" on rescan)
## Demonstration:
Start node, generate 101 blocks so only a single 50 BTC output is mature enough to spend:
```
$ ./bitcoind -daemon -regtest
Bitcoin server starting
$ ./bitcoin-cli -regtest getinfo
{
"version": 140000,
"protocolversion": 70015,
"walletversion": 130000,
"balance": 0.00000000,
...
}
$ ./bitcoin-cli -regtest generate 101
[
"271d2c725a2279976bee7650bf20f0a16ccbbc626e07150fcb5e8e8429909b09",
...
"13e07e2376aa2ce1d161497e05156632262571a17bb6e1cbd333392e23b973cc"
]
$ ./bitcoin-cli -regtest getinfo
{
"version": 140000,
"protocolversion": 70015,
"walletversion": 130000,
"balance": 50.00000000,
...
}
```
Now attempt to create 30 x 0.5 BTC transactions, forcing bitcoind to spend unconfirmed change outputs in a chain until the limit is hit:
```
$ for n in {1..30}; do ./bitcoin-cli -regtest sendtoaddress 2NCY1Q1Mu6V5uha7fDzGNYYPUs5F1zSdXCL 0.5; done
fb15572accafe0b6d2b7b2806f31bda16280c7d97a91d99ca929d4236e5099c1
c7cea6a964ab01f20bfc54e647fc2ea9b86f1a73f64ae547dcb5fb77a9071180
1cca3556fa953a0826d34d5096353a6809df1479996caff9e47954b1f6f81dce
2ae2141d550c8d290fdc0f0313684eac0c5813836b051ab275cc3663059ce3ef
b660559b13939d4d77e2ee01907841008b09b473ed6c215388f319692312ba4b
e79a92d89b027c064c0c24df438c795b3595627ee823e532ab7c18ea87f98434
7383970de305e47f781de8451303ebe84469e31f75308f72672dd52dcdd3886b
2355d572f3cfd28f6ecae42c6ec04a739283087091512aae1360880a4b4056fe
873cb3977698284a118ef29be6ed307badab9da635049ab5a6b0c9a253bf35a3
bf66983fe782efbc6ba9ce36c5e6bfba691f8721e35a16bfcb4b35505903ebf5
f80c7d4863bb9f14175f8915ced763176b7f6d4f18680793a5929ed2671d8e5b
21fa4a20a41be5f64156ec9df037077611269fabd7de0703fa11c660014c0aa9
6aad90127ab5e3fe67fa8b9b1a13eb03892a0f0b73798ecd7cf8af53f3a59e2c
e68af2ecb142efb3b5885b5fc885905c3e08a3ebd5cbeff9ace73893aeb9451f
18980ff65d020f6e333d7562bb0cf77aa2a8dca7d3f3f53f5b3f5986cc5b43f5
8de3f866aa42c71836927d3db6e764fadb462c61c82f398a22c035104a7d5dee
a9d139b2763c5ae4000cdfe78521d41c8c4647b50de3c86e2e2d0e7daa8cc97f
0ee976f345a5805e1a260a2f2d570edf3354cf0c434bdcf42ce16752ae6cc96f
6b5327eafcd979c3f63ecd8de1139b73651b21525157f2c681b81dfdd43acf9b
acd5a269a60dc43622c30a0ecaa8b1e393f074efb61f00e225cac0c028e7809f
52204cba5012dceb2f0bdc0b1dbec771d728cf1345da5545704c0ef004523d46
824b8ab2bef5a742f0ca3fad8b58f7a226daf3c5565b0b364fdfe7013d98e8f5
fbd88cdff1a7b648b5103699321c8d035698c867a39aa1a7b0c49c1a087ab879
4fa4e846deb03bbc7a7e07364c0087d6f43cd339792a220892c53e50eb60a463
c3d33580c52cd4eee88a0d76b5df2c77653f92537a10c3d04d27c063b543d2d9
3a8b99ed748f3418a8bf9ef9ea3b167df2bfabb28d660c0027405769e1d67174
error code: -6
error message:
Insufficient funds
error code: -6
error message:
Insufficient funds
error code: -6
error message:
Insufficient funds
error code: -6
error message:
Insufficient funds
```
Ok looks like 26 transactions were generated. The first one spends from a coinbase and the next 25 spend unconfirmed change outputs until bitcoind errors out with "Insufficient funds". That's ok, I should still have some change left in my wallet balance right?
```
$ ./bitcoin-cli -regtest listunspent 0
[
]
$ ./bitcoin-cli -regtest getbalance
0.00000000
$ ./bitcoin-cli -regtest getbalance "*" 0
36.99884200
```
**Unexpected behavior 1:** Unconfirmed change is not reflected in unspent output list, but unconfirmed balance seems correct. Let's mine a block and see what happens to my transaction chain:
```
$ ./bitcoin-cli -regtest generate 1
[
"5d2e7dd5bb7366fecfc36acfc6ca33346114f05d040ebb020b84465db2401e9f"
]
$ ./bitcoin-cli -regtest getblock 5d2e7dd5bb7366fecfc36acfc6ca33346114f05d040ebb020b84465db2401e9f
{
"hash": "5d2e7dd5bb7366fecfc36acfc6ca33346114f05d040ebb020b84465db2401e9f",
"confirmations": 1,
"strippedsize": 5783,
"size": 5783,
"weight": 23132,
"height": 102,
"version": 536870912,
"versionHex": "20000000",
"merkleroot": "f7692c07ffc26637b3f1df3dcbf9077f0a6292f8e445289fc7ce817ce4c3ae82",
"tx": [
"d2d05cc73f95abad38c8fa59af38629f04da8dc40d638ef46852aeb0604a20ed",
"fb15572accafe0b6d2b7b2806f31bda16280c7d97a91d99ca929d4236e5099c1",
"c7cea6a964ab01f20bfc54e647fc2ea9b86f1a73f64ae547dcb5fb77a9071180",
"1cca3556fa953a0826d34d5096353a6809df1479996caff9e47954b1f6f81dce",
"2ae2141d550c8d290fdc0f0313684eac0c5813836b051ab275cc3663059ce3ef",
"b660559b13939d4d77e2ee01907841008b09b473ed6c215388f319692312ba4b",
"e79a92d89b027c064c0c24df438c795b3595627ee823e532ab7c18ea87f98434",
"7383970de305e47f781de8451303ebe84469e31f75308f72672dd52dcdd3886b",
"2355d572f3cfd28f6ecae42c6ec04a739283087091512aae1360880a4b4056fe",
"873cb3977698284a118ef29be6ed307badab9da635049ab5a6b0c9a253bf35a3",
"bf66983fe782efbc6ba9ce36c5e6bfba691f8721e35a16bfcb4b35505903ebf5",
"f80c7d4863bb9f14175f8915ced763176b7f6d4f18680793a5929ed2671d8e5b",
"21fa4a20a41be5f64156ec9df037077611269fabd7de0703fa11c660014c0aa9",
"6aad90127ab5e3fe67fa8b9b1a13eb03892a0f0b73798ecd7cf8af53f3a59e2c",
"e68af2ecb142efb3b5885b5fc885905c3e08a3ebd5cbeff9ace73893aeb9451f",
"18980ff65d020f6e333d7562bb0cf77aa2a8dca7d3f3f53f5b3f5986cc5b43f5",
"8de3f866aa42c71836927d3db6e764fadb462c61c82f398a22c035104a7d5dee",
"a9d139b2763c5ae4000cdfe78521d41c8c4647b50de3c86e2e2d0e7daa8cc97f",
"0ee976f345a5805e1a260a2f2d570edf3354cf0c434bdcf42ce16752ae6cc96f",
"6b5327eafcd979c3f63ecd8de1139b73651b21525157f2c681b81dfdd43acf9b",
"acd5a269a60dc43622c30a0ecaa8b1e393f074efb61f00e225cac0c028e7809f",
"52204cba5012dceb2f0bdc0b1dbec771d728cf1345da5545704c0ef004523d46",
"824b8ab2bef5a742f0ca3fad8b58f7a226daf3c5565b0b364fdfe7013d98e8f5",
"fbd88cdff1a7b648b5103699321c8d035698c867a39aa1a7b0c49c1a087ab879",
"4fa4e846deb03bbc7a7e07364c0087d6f43cd339792a220892c53e50eb60a463",
"c3d33580c52cd4eee88a0d76b5df2c77653f92537a10c3d04d27c063b543d2d9"
],
"time": 1489607281,
"mediantime": 1489607020,
"nonce": 0,
"bits": "207fffff",
"difficulty": 4.656542373906925e-10,
"chainwork": "00000000000000000000000000000000000000000000000000000000000000ce",
"previousblockhash": "13e07e2376aa2ce1d161497e05156632262571a17bb6e1cbd333392e23b973cc"
}
```
**Unexpected behavior 2:** There is a transaction missing! The last one I generated in my unspent-change chain (3a8b99ed748f3418a8bf9ef9ea3b167df2bfabb28d660c0027405769e1d67174) did not make it into the block. Hm, ok maybe that is correct miner policy, let's see if it gets into the _next_ block:
```
$ ./bitcoin-cli -regtest generate 1
[
"2b842bed9f8e8d17b3026b8772416c6f015cfe434c0dc0ea24d8e4bfab6bc0fc"
]
$ ./bitcoin-cli -regtest getblock 2b842bed9f8e8d17b3026b8772416c6f015cfe434c0dc0ea24d8e4bfab6bc0fc
{
"hash": "2b842bed9f8e8d17b3026b8772416c6f015cfe434c0dc0ea24d8e4bfab6bc0fc",
"confirmations": 1,
"strippedsize": 227,
"size": 227,
"weight": 908,
"height": 103,
"version": 536870912,
"versionHex": "20000000",
"merkleroot": "6efa911037aae4e7b809374ab0f812894e9db446b5fd02da3606fc9f80bacf31",
"tx": [
"6efa911037aae4e7b809374ab0f812894e9db446b5fd02da3606fc9f80bacf31"
],
"time": 1489607296,
"mediantime": 1489607021,
"nonce": 1,
"bits": "207fffff",
"difficulty": 4.656542373906925e-10,
"chainwork": "00000000000000000000000000000000000000000000000000000000000000d0",
"previousblockhash": "5d2e7dd5bb7366fecfc36acfc6ca33346114f05d040ebb020b84465db2401e9f"
}
```
Nope, that tx is still not getting mined. Any luck with my balance or unspent output list?
```
$ ./bitcoin-cli -regtest listunspent 0
[
{
"txid": "e0aafa4fa10960b32a506d42777c48be646caa88aac223a5d3f4bee353a7187e",
"vout": 0,
"address": "myuKG99nWAVXUdePtE5V66jA4DQRkshUdY",
"scriptPubKey": "2103bc5af0d827a5f6b9ae4911f343ef864f4040f078dad86059dce2a7a12e376b5eac",
"amount": 50.00000000,
"confirmations": 101,
"spendable": true,
"solvable": true
},
{
"txid": "69274f8265b50907bb486a28a782562a41f2f1fc71e531e4806b9d16e3cc9ac5",
"vout": 0,
"address": "myuKG99nWAVXUdePtE5V66jA4DQRkshUdY",
"scriptPubKey": "2103bc5af0d827a5f6b9ae4911f343ef864f4040f078dad86059dce2a7a12e376b5eac",
"amount": 50.00000000,
"confirmations": 102,
"spendable": true,
"solvable": true
}
]
$ ./bitcoin-cli -regtest getbalance
100.00000000
$ ./bitcoin-cli -regtest getbalance "*" 0
136.99884200
```
No! I am still missing coins! Where is the leftover change from my transaction chain? Ok, let's restart the node, rescan, and then check my balance:
```
$ ./bitcoin-cli -regtest stop
Bitcoin server stopping
$ ./bitcoind -daemon -regtest -rescan
Bitcoin server starting
$ ./bitcoin-cli -regtest listunspent 0
[
{
"txid": "3a8b99ed748f3418a8bf9ef9ea3b167df2bfabb28d660c0027405769e1d67174",
"vout": 1,
"address": "mpNrtzsAU2eEeKk9NMjwMmKvvrkTBFwL8Q",
"scriptPubKey": "76a91461314c7a9c7e4481797b9be3a2754313a45314f888ac",
"amount": 36.99884200,
"confirmations": 0,
"spendable": true,
"solvable": true
},
{
"txid": "e0aafa4fa10960b32a506d42777c48be646caa88aac223a5d3f4bee353a7187e",
"vout": 0,
"address": "myuKG99nWAVXUdePtE5V66jA4DQRkshUdY",
"scriptPubKey": "2103bc5af0d827a5f6b9ae4911f343ef864f4040f078dad86059dce2a7a12e376b5eac",
"amount": 50.00000000,
"confirmations": 101,
"spendable": true,
"solvable": true
},
{
"txid": "69274f8265b50907bb486a28a782562a41f2f1fc71e531e4806b9d16e3cc9ac5",
"vout": 0,
"address": "myuKG99nWAVXUdePtE5V66jA4DQRkshUdY",
"scriptPubKey": "2103bc5af0d827a5f6b9ae4911f343ef864f4040f078dad86059dce2a7a12e376b5eac",
"amount": 50.00000000,
"confirmations": 102,
"spendable": true,
"solvable": true
}
]
```
There it is! The missing tx and my chain's final change output. Now can we mine it?
```
$ ./bitcoin-cli -regtest generate 1
[
"01b49edd77e4c1a6eb19860013c8b93ea79cc4cb7c2f8f4739dc8f2478db41ba"
]
$ ./bitcoin-cli -regtest getblock 01b49edd77e4c1a6eb19860013c8b93ea79cc4cb7c2f8f4739dc8f2478db41ba
{
"hash": "01b49edd77e4c1a6eb19860013c8b93ea79cc4cb7c2f8f4739dc8f2478db41ba",
"confirmations": 1,
"strippedsize": 450,
"size": 450,
"weight": 1800,
"height": 104,
"version": 536870912,
"versionHex": "20000000",
"merkleroot": "810e3b7be253da6114b8d6e3b644f7dcfc467e0809bc3387d23a672234901b92",
"tx": [
"502876265ef9c5238331c1635d2c949de9d64f2bd880ede4660dd756cb2e6f71",
"3a8b99ed748f3418a8bf9ef9ea3b167df2bfabb28d660c0027405769e1d67174"
],
"time": 1489607415,
"mediantime": 1489607021,
"nonce": 0,
"bits": "207fffff",
"difficulty": 4.656542373906925e-10,
"chainwork": "00000000000000000000000000000000000000000000000000000000000000d2",
"previousblockhash": "2b842bed9f8e8d17b3026b8772416c6f015cfe434c0dc0ea24d8e4bfab6bc0fc"
}
```
Yes we can! | https://github.com/bitcoin/bitcoin/issues/10004 | https://github.com/bitcoin/bitcoin/pull/24502 | 9745e180515077f10499f425f9ce49a5c02231ef | f66c827c2d7dcce2021a7913caf5f14dca37e35a | 2017-03-15T20:28:31Z | c++ | 2022-03-25T16:16:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,988 | ["src/rpc/rawtransaction.cpp"] | signrawtransaction shows errors after partially signing a multisig transaction | ### Describe the issue
### Can you reliably reproduce the issue?
#### If so, please list the steps to reproduce below:
1. Follow the steps in https://gist.github.com/gavinandresen/3966071
### Expected behaviour
The first `signrawtransaction` command should be successful and return a partially signed transaction that can be sent to the other cosigners for signing.
### Actual behaviour
Instead `signrawtransaction` fails and does not return a partially signed transaction.
### What version of bitcoin-core are you using?
This was reported for 0.14.0. However we have determined that it affects 0.11.1 and later, and likely 0.11.0. It does not affect 0.10.3.
It appears that the bug is caused by [this `VerifyScript` call](https://github.com/bitcoin/bitcoin/blob/master/src/rpc/rawtransaction.cpp#L849) which was introduced in 8ac2a4e1788426329b842eea7121b8eac7875c76 which has been a part of all versions since 0.11.0rc1.
See also: https://bitcointalk.org/index.php?topic=1823847.msg18164848#msg18164848 | https://github.com/bitcoin/bitcoin/issues/9988 | https://github.com/bitcoin/bitcoin/pull/11288 | c22a53cd6351b3f0e96de971b001ad712b83fc47 | df10edfd03fe4c9d1eca43a17ac4c54a14ac4832 | 2017-03-14T02:48:49Z | c++ | 2017-09-11T10:15:44Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,934 | ["doc/release-notes.md", "src/wallet/rpcdump.cpp", "test/functional/wallet-dump.py"] | dumpwallet walletfile overwrite footgun | 19:02 < $user> gmaxwell: I have the new version. I opened the console. I ran dumpwallet, and it's not giving anything back to me. I passed wallet.dat and /Users/pawn/Library/Application\ Support/Bitcoin/wallet.dat as an argument.
| https://github.com/bitcoin/bitcoin/issues/9934 | https://github.com/bitcoin/bitcoin/pull/9937 | 94c9015bca861085f76ca3c045e17d0591aa6c8b | 0cd9273fd959c6742574259d026039f7da0309a2 | 2017-03-07T03:05:44Z | c++ | 2017-09-26T14:12:47Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,841 | ["qa/rpc-tests/segwit.py"] | getblocktemplate fails for old clients after segwit activation | segwit.py is supposed to test that "non-segwit miners get a valid GBT response after the fork":
```py
print("Verify non-segwit miners get a valid GBT response after the fork")
send_to_witness(1, self.nodes[0], find_unspent(self.nodes[0], 50), self.pubkey[0], False, Decimal("49.998"))
try:
tmpl = self.nodes[0].getblocktemplate({})
assert(len(tmpl['transactions']) == 1) # Doesn't include witness tx
assert(tmpl['sigoplimit'] == 20000)
assert(tmpl['transactions'][0]['hash'] == txid)
assert(tmpl['transactions'][0]['sigops'] == 2)
assert(('!segwit' in tmpl['rules']) or ('segwit' not in tmpl['rules']))
except JSONRPCException:
# This is an acceptable outcome
pass
```
in fact what happens is that bitcoind returns a "Support for 'segwit' rule requires explicit client support" error to the getblocktemplate RPC. We always catch that error in the except: block and continue the test. None of the asserts in the try: branch are ever tested.
I don't know what the intent here is. I would expect non-segwit miners to continue to be able to use getblocktemplate after segwit activation. If that's true, then there's a bug in getblocktemplate(). If miners *aren't* supposed to be able use getblocktemplate() after segwit activation without setting the rules:['segwit'] option, then we should explicitly test that as follows:
```py
assert_raises_jsonrpc(-8, "Support for 'segwit' rule requires explicit client support", self.nodes[0].getblocktemplate, {})
```
and remove all the test code that isn't being used. | https://github.com/bitcoin/bitcoin/issues/9841 | https://github.com/bitcoin/bitcoin/pull/9843 | 692c9eddba67d5a7ceb85fa4b2632f664c68f418 | b23dcd2bf98d7b4b672c3ea3782ca5c5b9c64d7b | 2017-02-23T19:05:22Z | c++ | 2017-02-23T23:01:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,826 | ["qa/rpc-tests/import-rescan.py"] | Intermittent failure of `import-rescan.py` | On master, the `import-rescan.py` test fails intermittently. See for example: https://travis-ci.org/bitcoin/bitcoin/jobs/203878010
```
import-rescan.py:
Initializing test directory /tmp/testzpotg5c7/46
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC successfully started
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC successfully started
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC successfully started
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC successfully started
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC successfully started
Assertion failed: not(False == True)
Stopping nodes
Not cleaning up dir /tmp/testzpotg5c7/46
...
Shutdown: done
Failed
stderr:
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/qa/rpc-tests/test_framework/test_framework.py", line 145, in main
self.run_test()
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/qa/rpc-tests/import-rescan.py", line 172, in run_test
variant.check(variant.sent_txid, variant.sent_amount, 1)
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/qa/rpc-tests/import-rescan.py", line 87, in check
assert_equal("involvesWatchonly" not in tx, True)
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/qa/rpc-tests/test_framework/util.py", line 529, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
Pass: False, Duration: 9 s
``` | https://github.com/bitcoin/bitcoin/issues/9826 | https://github.com/bitcoin/bitcoin/pull/9839 | bed5b30a5622782b35d0d28fccde979e188901f1 | 864890adf5fefcf969f82f70949199b68b36f165 | 2017-02-22T15:28:58Z | c++ | 2017-02-23T19:09:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,816 | ["src/qt/bitcoingui.cpp"] | Running with --disablewallet gives a segfault | Run `src/qt/bitcoin-qt --disablewallet=1`.
Quitting after any amount of time will result in `Segmentation fault: 11`
0.14.0 branch at 861cb0c83db0571c2863f6b6276314e115c266ee , osx 10.12.3, Qt5.8 | https://github.com/bitcoin/bitcoin/issues/9816 | https://github.com/bitcoin/bitcoin/pull/9817 | 8ad31f9aa3111e079dd5024e8f6b069abb564b81 | 312c4f10574ccf6dfe0d4ecb3ce928733d3a1e52 | 2017-02-21T09:30:50Z | c++ | 2017-02-21T13:37:20Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,810 | ["src/validation.cpp"] | 0.14 not loading mempool.dat? | ### Describe the issue
Restarting bitcoin, mempool starts filling from scratch.
### Can you reliably reproduce the issue?
#### If so, please list the steps to reproduce below:
1. Wait for mempool to reach for example 3000 transactions
2. Restart bitcoin
3. Watch mempool filling slowly from scratch
### Expected behaviour
Mempool would already contain ~3000 TX on startup
### Actual behaviour
It starts at 0 and fills up slowly with a few per second.
### Screenshots.
http://imgur.com/a/or82d
### What version of bitcoin-core are you using?
Windows x64 0.14rc1 binary from https://bitcoin.org/bin/bitcoin-core-0.14.0/test.rc1/
### Any extra information that might be useful in the debugging process.
I may not be aware of how the mempool.dat thing works and there could just be a misunderstanding.
| https://github.com/bitcoin/bitcoin/issues/9810 | https://github.com/bitcoin/bitcoin/pull/9813 | 7639d38f14b1517c56856a2be4bd13f9d51ddf79 | 171fc91f061d4a980eedfa522e302b8598408cc5 | 2017-02-20T14:55:06Z | c++ | 2017-02-20T17:14:06Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,796 | ["depends/packages/zlib.mk"] | [depends] zlib fails to build on OS X | ```
Building zlib...
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ar -o libz.a adler32.o crc32.o deflate.o infback.o inffast.o inflate.o inftrees.o trees.o zutil.o compress.o uncompr.o gzclose.o gzlib.o gzread.o gzwrite.o
ar: one of options -dmpqrtsx is required
usage: ar -d [-TLsv] archive file ...
ar -m [-TLsv] archive file ...
ar -m [-abiTLsv] position archive file ...
ar -p [-TLsv] archive [file ...]
ar -q [-cTLsv] archive file ...
ar -r [-cuTLsv] archive file ...
ar -r [-abciuTLsv] position archive file ...
ar -t [-TLsv] archive [file ...]
ar -x [-ouTLsv] archive [file ...]
make[1]: *** [libz.a] Error 1
``` | https://github.com/bitcoin/bitcoin/issues/9796 | https://github.com/bitcoin/bitcoin/pull/9973 | 8910b4717e5bb946ee6988f7fe9fd461f53a5935 | c62475329e5e4c4c3f9570546e2b843288f48c61 | 2017-02-19T02:36:21Z | c++ | 2017-03-10T21:53:05Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,775 | ["src/util.cpp"] | Check returned value of fopen() | [util.cpp#L216](https://github.com/bitcoin/bitcoin/blob/master/src/util.cpp#L216)
if `fopen `failed, a null file pointer could be passed to `FileWriteStr(vMsgsBeforeOpenLog->front(), fileout);` | https://github.com/bitcoin/bitcoin/issues/9775 | https://github.com/bitcoin/bitcoin/pull/9798 | 7ff4a538a8682cdf02a4bcd6f15499c841001b73 | 40f11f8872c3e9f380f8278f984dfdabffe77539 | 2017-02-16T10:52:29Z | c++ | 2017-02-20T18:23:18Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,752 | ["src/wallet/wallet.h", "test/functional/wallet_balance.py", "test/functional/wallet_basic.py"] | Max unconfirmed chainlength | ### Describe the issue
Because transaction malleability isn't that much of an issue lately, we've decided to let the wallet spend zero conf change. It has happened that we create a transaction just moments before a significant increase in (higher paying) transactions. Because of #9645, there is a chance that you end up with an unconfirmed chain of 24 child transactions. If you let the wallet produce a 25th child, it will return an error because the mempool won't accept it. This is also problematic in the case we would like to cpfp the whole chain, because other nodes won't relay the transaction to the miners.
### Can you reliably reproduce the issue?
#### If so, please list the steps to reproduce below:
1. Predict an increase in transactions. (You need a crystal ball)
2. Create transaction
3. Create more transactions
4. ?
5. Profit
### Expected behaviour
Ideally it would stop if the chain is 24 transactions long, so one could try a cpfp transaction to compensate for the fees.
### Actual behaviour
It will create a transaction chain of 25 transaction, making it hard to have the whole chain confirmed in a certain time.
### What version of bitcoin-core are you using?
Official binary: 0.13.1 | https://github.com/bitcoin/bitcoin/issues/9752 | https://github.com/bitcoin/bitcoin/pull/24502 | 9745e180515077f10499f425f9ce49a5c02231ef | f66c827c2d7dcce2021a7913caf5f14dca37e35a | 2017-02-13T13:06:13Z | c++ | 2022-03-25T16:16:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,710 | ["src/init.cpp", "src/validation.h", "test/functional/mempool_persist.py", "test/functional/test_runner.py"] | How should -zapwallettxes interact with persistent mempool? | the `zapwallettxes.py` qa test is currently broken due to a syntax error:
```python
assert_raises(JSONRPCException, self.nodes[0].gettransaction, [txid3])
#there must be a expection because the unconfirmed wallettx0 must be gone by now
```
This doesn't actually test that the transaction is not in the wallet, because `gettransaction()` is being called incorrectly (with an array instead of a string).
Changing the test to `assert_raises(JSONRPCException, self.nodes[0].gettransaction, txid3)` causes the rpc to succeed and the test script to fail because `txid3` is still in the wallet.
This is because the mempool is now persistent and is saved to disk when bitcoind shuts down. zapwallettxes removes the unconfirmed transaction from the wallet but bitcoind will rescan the mempool.dat file on startup and add the unconfirmed transaction back into the wallet.
I've 'fixed' zapwallettxes.py in https://github.com/jnewbery/bitcoin/tree/zapwallettxes , but the question remains: how *should* -zapwallettxes interact with persistent mempool? The use case for zapwallettxes is explained here: https://github.com/bitcoin/bitcoin/pull/3659#issuecomment-34878999 . My view is that even with zapwallettxes, bitcoind should rescan the mempool, but there should be better documentation or a warning that unconfirmed transaction in your mempool will be re-added to the wallet even if zapwallettxes is used. If you really want to remove all unconfirmed transactions from your wallet, you can delete your mempool.dat file and then restart with zapwallettxes. | https://github.com/bitcoin/bitcoin/issues/9710 | https://github.com/bitcoin/bitcoin/pull/9966 | 91c91e140aeea291d95fb1028e7e4aa1e4381939 | a750d77b950175115fcab528fa0d3a2e0ffab96d | 2017-02-07T16:10:55Z | c++ | 2017-03-22T15:55:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,631 | ["src/qt/transactionrecord.cpp"] | Qt: Incorrect output index reported | In the transactions list, if you right click a transaction and choose "view transaction details", the "Output index" listed in the resulting window is usually wrong.
With outgoing transactions, if you have a transaction with outputs like:
vout 0: AddrA
vout 1: AddrB, which belongs to sender
vout 2: AddrC
vout 3: <change>
vout 4: AddrD
Then the output index as reported by the GUI will be:
tx to AddrA: 0
tx to AddrB: <transaction not listed>
tx to AddrC: 1
tx to AddrD: 2
With received transactions, the output index always seems to be reported as 0 in transactions I've checked.
I'd guess that rather than the actual vout index, some internal wallet index is being reported.
This is 0.13.2. I don't know when the bug was introduced. | https://github.com/bitcoin/bitcoin/issues/9631 | https://github.com/bitcoin/bitcoin/pull/9637 | 9b4d2673b7757fd242b13c972c73897c92a90ce1 | 04b877361be8a457b4d4f7fd2277d73f00e2e61c | 2017-01-25T21:04:13Z | c++ | 2017-01-26T12:22:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,586 | ["src/net.cpp", "src/qt/rpcconsole.cpp", "src/rpc/misc.cpp", "src/utiltime.cpp", "src/utiltime.h"] | bip68-sequence.py failing on master after recent net changes, due to mocktime interaction | Since 60befa399 in #9441, `bip68-sequence.py` (one of the extended rpc tests, not run by travis) has been failing:
```
Initializing test directory /var/folders/pw/k25spdv971g8xhccyx5t3yyr0000gn/T/test5y497icn/9191
Running test disable flag
Running test sequence-lock-confirmed-inputs
Running test sequence-lock-unconfirmed-inputs
Running test BIP68 not consensus before versionbits activation
Verifying nVersion=2 transactions aren't standard
Activating BIP68 (and 112/113)
Assertion failed: Block sync to height 432 timed out:
{'hash': '05c02af44675851560cb13b1b59f2a7f08ff3bef4e3db19f6a08e79cb51cce62', 'height': 432}
{'hash': '30f24ff219ac23291d1489710ad467726b7ab202f70923d4bd5707dacfb05051', 'height': 328}
File "/Users/sdaftuar/projects/ccl-bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 145, in main
self.run_test()
File "./bip68-sequence.py", line 58, in run_test
self.activateCSV()
File "./bip68-sequence.py", line 409, in activateCSV
sync_blocks(self.nodes)
File "/Users/sdaftuar/projects/ccl-bitcoin/qa/rpc-tests/test_framework/util.py", line 147, in sync_blocks
maxheight, "".join("\n {!r}".format(tip) for tip in tips)))
Stopping nodes
Not cleaning up dir /var/folders/pw/k25spdv971g8xhccyx5t3yyr0000gn/T/test5y497icn/9191
Failed
```
I git bisected the problem back to the above commit; the issue seems to be that the inactivity checking at https://github.com/theuni/bitcoin/blob/60befa3997b98d3f913010f2621bec734f643526/src/net.cpp#L1298 is comparing times that are coming from two different places: `GetTime()` which can use mocktime, and `GetTimeMicros()` which does not, and the `bip68-sequence.py` test uses mocktime. (Using `GetTimeMicros()` for `nLastRecv` is newly introduced in the commit above.)
Really, it's sort of remarkable/lucky that we didn't have test failures relating to how mocktime interacts with the networking code before. I'm not sure what the right way to fix this is -- I started by trying to narrowly just fix this issue by changing `nTimeConnected`, `nLastSend`, and the starting `nTime` used in the inactivity check to all be based off system clock (eg `GetTimeMicros()/1000000`), but then that broke some of our other tests that I think must have been relying on mocktime having an effect on some of these things (`maxuploadtarget.py`, `receivedby.py`, and `listtransactions.py` all failed -- I didn't investigate exactly what happened so it's possible my fix just had a simple mistake).
Anyway I think we need a thoughtful approach to how to use `GetTime()` vs. `GetTimeMicros()` for the various times we have, especially in `net.cpp`/`net_processing.cpp`, and this is a bug that I think we need to fix for 0.14 so we're not shipping broken tests.
| https://github.com/bitcoin/bitcoin/issues/9586 | https://github.com/bitcoin/bitcoin/pull/9606 | 054d664215ca8d5f17d8aadbfc5b78a8dcd5115c | 99464bc38e9575ff47f8e33223b252dcea2055e3 | 2017-01-19T18:59:32Z | c++ | 2017-01-25T14:48:14Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,585 | ["build-aux/m4/bitcoin_qt.m4", "depends/packages/packages.mk", "depends/packages/qt.mk", "depends/packages/zlib.mk", "depends/patches/qt/mac-qmake.conf"] | Can't build qt 5.7.1 for windows | ### Describe the issue
After the qt 5.7.1 update i haven't been able to build gui for windows. Im using ubuntu 14.04 vm and I had no issues building qt 5.6.1.
### Can you reliably reproduce the issue? yes
#### If so, please list the steps to reproduce below:
1. I follow the windows build notes.
```
checking for main in -lQt5Core ... yes
checking for main in -lQt5Gui ... yes
checking for main in -lQt5Network... yes
checking for main in -lQt5Widgets... yes
checking for main in -lQt5Test... yes
checking QTest usability... yes
checking QTest presence... yes
checking for QTest... yes
checking for main in -lQt5DBus... yes
checking QtDBus usability... yes
checking QtDBus presence... yes
checking for QtDBus... yes
checking for static Qt... yes
checking for Qt >= 5.6... yes
checking for main in -lQt5PlatformSupport... yes
checking for Qt < 5.4... no
checking for static Qt plugins: -lqwindows... no
configure: WARNING: Could not resolve: -lqwindows; bitcoin-qt frontend will not be built
checking whether to build Bitcoin Core GUI... no (Qt5)
```
Is there some extra package you now have to install? I have installed these: libqt5gui5 libqt5core5a libqt5dbus5 qttools5-dev qttools5-dev-tools libprotobuf-dev protobuf-compiler
- OS: Windows 10 x64 | https://github.com/bitcoin/bitcoin/issues/9585 | https://github.com/bitcoin/bitcoin/pull/9646 | 8efa34fb772bb320e657d18751f1751a4ee48731 | b5f374fef71ba2ba99e3d9629b66fd1491fd7c90 | 2017-01-19T18:27:39Z | c++ | 2017-01-28T06:54:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,526 | ["doc/reduce-memory.md", "doc/release-notes-26471.md", "src/init.cpp", "src/kernel/mempool_options.h"] | -blocksonly should disable sharing of mempool with dbcache | Whenever -blocksonly is specified, there is implicitly a zero size mempool. However, there is still a non-zero value for -maxmempool which will be shared with dbcache, leading to 300 MB extra usage. Fix this. | https://github.com/bitcoin/bitcoin/issues/9526 | https://github.com/bitcoin/bitcoin/pull/26471 | bf9361d3757656c75775e5b243b4d11980117d04 | ad09b762757a293ff970113c15bd9dee3057e556 | 2017-01-12T13:00:34Z | c++ | 2023-01-22T14:57:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,493 | ["src/test/raii_event_tests.cpp"] | event_set_mem_functions is not available on all libevents | #9387 added a new test that uses libevent's event_set_mem_functions which is sometimes not included with libevent. In particular, Gentoo only enables this when libevent is installed with the "debug" option.
Currently, this causes the build to simply fail on tests:
```
test/raii_event_tests.cpp: In member function ‘void raii_event_tests::raii_event_creation::test_method()’:
test/raii_event_tests.cpp:39:58: error: ‘event_set_mem_functions’ was not declared in this scope
event_set_mem_functions(tag_malloc, realloc, tag_free);
^
test/raii_event_tests.cpp: In member function ‘void raii_event_tests::raii_event_order::test_method()’:
test/raii_event_tests.cpp:68:58: error: ‘event_set_mem_functions’ was not declared in this scope
event_set_mem_functions(tag_malloc, realloc, tag_free);
^
Makefile:8355: recipe for target 'test/test_test_bitcoin-raii_event_tests.o' failed
```
Probably we should skip this test if libevent doesn't support overriding memory functions.
(event.h defines EVENT_SET_MEM_FUNCTIONS_IMPLEMENTED if it is available.) | https://github.com/bitcoin/bitcoin/issues/9493 | https://github.com/bitcoin/bitcoin/pull/16564 | dec067f5a019fbeea0403efcfc501238a114d095 | 091cc4b94e009f7140493cd37798d447c6881e5e | 2017-01-08T21:40:36Z | c++ | 2020-05-31T21:55:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,492 | ["doc/README.md", "doc/offline-signing-tutorial.md"] | Write instructions on offline signing. | The only instructions I'm aware of for offline signing are https://people.xiph.org/~greg/signdemo.txt which is really out of date, doesn't cover watching wallets, or fundrawtransaction. | https://github.com/bitcoin/bitcoin/issues/9492 | https://github.com/bitcoin/bitcoin/pull/28363 | 21d985784f01280ec28429288e36397fcc842af8 | 4cebad4833804189bade4fa694b413ce47872ce7 | 2017-01-08T20:45:27Z | c++ | 2023-11-06T15:54:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,491 | ["qa/rpc-tests/import-rescan.py", "qa/rpc-tests/importmulti.py", "src/rpc/misc.cpp", "src/wallet/rpcdump.cpp"] | Importmulti api is confusing in a way that could lead to funds loss. | Our normal import interfaces introduce keys with an effective timestamp of 0.
Importmulti introduces keys with a default effective timestamp of 'now'.
While documented it is highly surprising, especially because it contradicts the default on the rescan argument:
> "rescan": <false>, (boolean, optional, default: true) Stating if should rescan the blockchain after all imports
This means you can import a key and reasonably expect that it was rescanned ("I even set rescan true!") but have it not be rescanned, causing you to think the key had been unused and then you give it away and or destroy it and lose funds.
There are a number of other bugs in importmulti (mishandles pruning, needlessly forces the wallet to be unlocked when not importing private keys, etc.) which I am fixing, but I need feedback on this API issue.
Should the default become zero, with -1 special cased as 'now' or make timestamp mandatory? default it to the prune depth??
Should the result also tell us what it rescanned? | https://github.com/bitcoin/bitcoin/issues/9491 | https://github.com/bitcoin/bitcoin/pull/9682 | 3cf991756cf357b651c6415e3d950e5aa9d355ab | 266a8114cbe2a87a6c84d7690a7716a18d782c56 | 2017-01-08T08:09:11Z | c++ | 2017-02-10T20:40:28Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,479 | ["src/txmempool.cpp", "src/txmempool.h", "src/validation.cpp", "src/validationinterface.h", "src/wallet/wallet.cpp"] | -walletnotify isn't fired on transactions that were in the mempool and then evicted due to a tx in a new block conflicting them. | This is to track the regression introduced in master, which needs fixing for 0.14. See #9240, #9371, etc. | https://github.com/bitcoin/bitcoin/issues/9479 | https://github.com/bitcoin/bitcoin/pull/9371 | 4afbde6028708541c4da8732a1bd12fb8735fdae | 094e4b33839404d9c18200fc30d9a993a3dc106f | 2017-01-05T18:45:11Z | c++ | 2017-01-23T20:43:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,466 | ["src/wallet/wallet.cpp", "src/wallet/wallet.h"] | Prevent fee overpayment when nFeeNeeded decreases in CreateTransaction iterations | When a pass of CreateTransaction fails to select enough bitcoin to meet the nFeeNeeded the next pass through may select a far smaller collection of inputs. Currently it will continue to use the old fee amount based on the larger set of inputs, which can cause a non-trivial over-payment.
This may be the cause of the behavior reported here: https://www.reddit.com/r/Bitcoin/comments/5ltw5n/bitcoin_core_v0131_sends_enormously_high_fee/
Long ago fixing this was tricky due to a catch-22 between signing the transaction and knowing how much fee was required. But after #9465 the whole algorithm will run using a dummy signature, so when there is already a change output fixing up the fee after finding a sufficient transaction should be a matter of a ~2 line change.
| https://github.com/bitcoin/bitcoin/issues/9466 | https://github.com/bitcoin/bitcoin/pull/9404 | 42f5ce40931402aaa395ef2959deb64e9a9fff02 | 20449ef09edf8f4f51a3e531d947dd89973c2a31 | 2017-01-04T09:03:14Z | c++ | 2017-01-06T15:18:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,448 | ["src/chainparams.cpp", "src/chainparams.h", "src/checkpoints.cpp", "src/checkpoints.h", "src/qt/clientmodel.cpp", "src/rpc/blockchain.cpp", "src/validation.cpp", "src/validation.h", "src/wallet/wallet.cpp"] | Update estimated transaction count | The total transaction count (for progress estimation) is counted as the known count at the last checkpoint, plus an estimated number per day.
The last checkpoint is now 996 days ago, and its estimated 60000 transactions per day leads to a total estimate of 96M transactions, while the real number is around 183M.
Fix this by updating the count, timestamp, and rate of transactions... with or without adding a new checkpoint. | https://github.com/bitcoin/bitcoin/issues/9448 | https://github.com/bitcoin/bitcoin/pull/9472 | e356d9a758fff44841c0a630ef6b048de05e53f0 | df3637177a5988261e6ce704018e14140401e1e1 | 2016-12-30T16:51:59Z | c++ | 2017-01-11T16:21:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,362 | ["doc/release-notes.md", "qa/rpc-tests/fundrawtransaction.py", "src/wallet/rpcwallet.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h"] | fundrawtransaction doesn't keep change address pool key | If one calls `fundrawtransaction`, the change address will be retrieved from the keypool, though, this key/address will always be returned to the pool, leading to the problem that the next `getnewaddress()` call will restult in the same key/address.
Either we remove the auto-change-address (users would need to call `getrawchangeaddress` first [current best practice anyway]) or we add a call to keep/mark a specific key/address as change (after one have sent the funded raw transaction).
Reported by @NicolasDorier on IRC. | https://github.com/bitcoin/bitcoin/issues/9362 | https://github.com/bitcoin/bitcoin/pull/9377 | 9eb325d079c7bbce749abe79d0bbac34d8ef5806 | c9f3062d551823f006d400dddb54c12620cd29c4 | 2016-12-16T08:28:01Z | c++ | 2017-01-19T19:45:34Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,272 | ["share/examples/bitcoin.conf"] | Default behavior of binding to all interfaces for RPC server not working | ### Describe the issue
The `--help` for `rpcbind` suggests that the default behavior is to bind to all interfaces. However, in Core 0.13.1, I noticed that if rpcbind is left out of the config, the RPC server is either only bound to the loopback interface or only bound to the IPv6 port.
### Can you reliably reproduce the issue?
Yes. It fails differently, depending on whether or not you've supplied `rpcallowip`
#### Reproduction Scenario 1
Fails silently, only binds to loopback interface.
```
server=1
rpcuser=something
rpcpassword=somethingelse
```
* Binds to 127.0.0.1:8332
* Binds to [fe80::1%lo0]:8332
#### Reproduction Scenario 2
Error message in log, only binds to all interfaces for IPv6.
```
server=1
rpcuser=something
rpcpassword=somethingelse
rpcallowip=0.0.0.0/0
rpcallowip=::/0
```
* `Binding RPC on address 0.0.0.0 port 8332 failed.` reported in _debug.log_.
* Binds to [::]:8332
### What version of bitcoin-core are you using?
0.13.1
### Machine specs:
- OS: Apple OS X 10.11.6 (15G1108)
- CPU: 2.7 GHz 12-Core Intel Xeon E5
- RAM: 64 GB 1866 MHz DDR3 ECC
- Disk size: 1TB
- Disk Type (HD/SDD): SSD | https://github.com/bitcoin/bitcoin/issues/9272 | https://github.com/bitcoin/bitcoin/pull/16634 | aed15edf179d75f4835da499de8c97a76120bcb4 | fa0119af226255ce1e0e573a575ab37539ff8693 | 2016-12-04T06:12:14Z | c++ | 2019-08-16T14:51:59Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,213 | ["src/net_processing.cpp", "test/functional/p2p_ibd_stalling.py", "test/functional/test_runner.py"] | [P2P] Staller logic might need revisiting? | ### Describe the issue
I need to investigate a bit more, but I just completed a fresh sync from scratch using master, and I noticed some odd behavior with the stalling logic.
I was initially connected to 8 outbound peers (and no others), and then to speed up the sync, I decided to addnode an instance on my local network that was caught up. So in particular, block transfer times to this new node were very quick.
What was unusual was that even though this machine fast, it was getting disconnected repeatedly during IBD for stalling (it would then get readded, since addnode'd it). I started to look through my debug log to see what was going on, and it appears to me that it may have been something like this:
- Some other peer X is stalling, gets disconnected.
- Connect to some new peer Y.
- X's blocks get assigned to other peers, maybe the local one.
- If we're near the end of the download window, then because Y is available not downloading any blocks, the peer that was reassigned X's block has 1 second (?) to provide the block, or else that peer is stalling.
So it looked to me like I'd go through periods of time where everyone was getting disconnected for stalling, such as this particularly egregious example:
```
2016-11-22 13:08:52 UpdateTip: new best=00000000000000003085d45701cef706396618d68bea4b9551b7442b031d1863 height=313019 version=0x00000002 log2_work=79.946856 tx=43453816 date='2014-07-29 15:40:42' progress=0.218633 cache
=1581.8MiB(3793192tx)
2016-11-22 13:08:54 Peer=290 is stalling block download, disconnecting
2016-11-22 13:08:56 Peer=282 is stalling block download, disconnecting
2016-11-22 13:08:58 Peer=291 is stalling block download, disconnecting
2016-11-22 13:09:06 Peer=292 is stalling block download, disconnecting
2016-11-22 13:09:08 Peer=286 is stalling block download, disconnecting
2016-11-22 13:09:11 Peer=293 is stalling block download, disconnecting
2016-11-22 13:09:15 Peer=294 is stalling block download, disconnecting
2016-11-22 13:09:17 Peer=295 is stalling block download, disconnecting
2016-11-22 13:09:19 Peer=296 is stalling block download, disconnecting
2016-11-22 13:09:21 Peer=297 is stalling block download, disconnecting
2016-11-22 13:09:23 Peer=298 is stalling block download, disconnecting
2016-11-22 13:09:28 Peer=299 is stalling block download, disconnecting
2016-11-22 13:09:30 Peer=300 is stalling block download, disconnecting
2016-11-22 13:09:32 Peer=301 is stalling block download, disconnecting
2016-11-22 13:09:35 Peer=302 is stalling block download, disconnecting
2016-11-22 13:09:37 Peer=303 is stalling block download, disconnecting
2016-11-22 13:09:39 Peer=304 is stalling block download, disconnecting
2016-11-22 13:09:41 Peer=305 is stalling block download, disconnecting
2016-11-22 13:09:43 Peer=306 is stalling block download, disconnecting
2016-11-22 13:09:45 Peer=307 is stalling block download, disconnecting
2016-11-22 13:09:48 Peer=309 is stalling block download, disconnecting
2016-11-22 13:09:51 Peer=310 is stalling block download, disconnecting
2016-11-22 13:09:53 Peer=311 is stalling block download, disconnecting
2016-11-22 13:09:55 Peer=312 is stalling block download, disconnecting
2016-11-22 13:09:57 Peer=313 is stalling block download, disconnecting
2016-11-22 13:09:59 UpdateTip: new best=00000000000000001291028bceab2639c12c762be3988017cba99fa792b460c4 height=313020 version=0x00000002 log2_work=79.946955 tx=43454953 date='2014-07-29 15:45:18' progress=0.218647 cache=1581.8MiB(3793020tx)
```
EDIT: forgot to mention that the above snippet is from me grepping for "stalling|UpdateTip" in my debug.log, so the new connections that happened in between those stalling messages aren't shown. | https://github.com/bitcoin/bitcoin/issues/9213 | https://github.com/bitcoin/bitcoin/pull/25880 | ffc22b7d42c6360223508293b8c1f88b1a1a468b | 835212cd1d8f8fc7f19775f5ff8cc21c099122b2 | 2016-11-23T17:37:13Z | c++ | 2023-01-27T06:53:21Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,210 | ["src/qt/rpcconsole.cpp", "src/qt/test/rpcnestedtests.cpp"] | sendmany no longer works over the GUI | 0.13.1 gitian binaries:
```json
>> sendmany "" '{"ad1":0.1, "ad2":0.1}'
<< "14af4b0aa9a792f32e55d3c9c73b2c6356033825d955ae71313f7dc4008234e1"
```
current master self compiled:
```json
>> sendmany "" '{"ad1":0.1, "ad2":0.1}'
<< "sendmany help text"
```
| https://github.com/bitcoin/bitcoin/issues/9210 | https://github.com/bitcoin/bitcoin/pull/9329 | 6a32c0f69de1d9caf1af26e192efbb80f7534fdd | 390bd14684a4f1a974014a31c71d44acd3d94d6a | 2016-11-23T11:08:03Z | c++ | 2016-12-14T08:00:09Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,195 | ["src/qt/rpcconsole.cpp"] | Debug console needs a little documentation on usage | It would be nice if the debug console had a little help page of itself, to describe the syntax to issue commands (also the nested ones), and a disclaimer that usage can be dangerous.
Maybe add a debug-console-only command like help that shows how to use nested commands and potentially other advanced tricks, and add 'for more information on using this console type XXX'.
See also:
- https://github.com/bitcoin/bitcoin/pull/7783#issuecomment-248274853
- https://github.com/bitcoin/bitcoin/issues/8544#issuecomment-240970925
- #8912 Console command paths cannot be specified correctly with backslashes | https://github.com/bitcoin/bitcoin/issues/9195 | https://github.com/bitcoin/bitcoin/pull/11698 | f0c1f8abb0182da557d07372b938f3a0a4bb906f | c3055bbea1255cd791564b855b6951a9f4c510f9 | 2016-11-21T09:39:00Z | c++ | 2017-11-18T05:28:11Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,192 | ["src/qt/guiutil.cpp", "src/qt/guiutil.h", "src/qt/transactionview.cpp", "src/qt/transactionview.h"] | Context menu options that are not available should be disabled (in transactions tab) | ### Describe the issue
In Bitcoin QT, under the Transactions tab when right clicking on the transaction the context menu shows more option then it can always handle.
### Can you reliably reproduce the issue?
Yes.
#### If so, please list the steps to reproduce below:
0. Open QT.
1. Make an incoming transaction without label.
2. Go to the Transactions tab.
3. Rigth click on a transaction and select "Copy label".
### Actual behaviour
The clipboard will be empty.
### Expected behaviour
Copies the label. (What does not exist, of course.)
### What version of bitcoin-core are you using?
v0.13.1, Ubuntu PPA.
### Any extra information that might be useful in the debugging process.
This behaviour is more problematic in edge cases.
Like when you send funds with JoinMarket. In this case for example the "Copy address" option does not work.
### Suggestion
I think when something cannot be copied that should not be present in the context menu in the first place.
 | https://github.com/bitcoin/bitcoin/issues/9192 | https://github.com/bitcoin/bitcoin/pull/17956 | a9024a42fcece274c094cc537275ab0c55bbce15 | 0d5c18204b73ccb0d7c07f90c52de31edc25e28e | 2016-11-20T10:31:37Z | c++ | 2020-05-29T08:29:14Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,182 | ["src/main.cpp"] | Orphan-triggered tx fetch does not ask for witness data | Reported by @roasbeef and @chjj on IRC.
### Describe the issue
When we receive a transaction with an unknown input, since 0.13.0 we send a getdata for that transaction in response, to quickly learn the dependency. Unfortunately, we always ask for it as MSG_TX instead of MSG_WITNESS_TX.
### Can you reliably reproduce the issue?
```
18:20:33 < roasbeef> hmm, chjj and I seem to be encountering some odd behavior with segwit enabled core nodes on testnet: they aren't including witness_tx inv's in their getdata's when
fetching transactions, so they fetch witness output spending transactions without the witness data (though the service bit is set). this should cause an immediate
rejecvt due to the clean-stack rules, but they keep accepting the txns, sending a delayed reject minutes afterwards
18:26:52 < sipa> roasbeef: they send MSG_TX getdatas instead of MSG_WITNESS_TX ?
18:27:11 < roasbeef> sipa: yeh
```
### Expected behaviour
Don't see any MSG_TX getdatas between witness-enabled peers.
### Actual behaviour
See some MSG_TX getdatas.
### What version of bitcoin-core are you using?
```
18:28:08 < chjj> sipa: seems to be both 13.0 and 13.1 nodes
```
| https://github.com/bitcoin/bitcoin/issues/9182 | https://github.com/bitcoin/bitcoin/pull/9188 | 9346f8429957e356d21c665bab59fe45bcf1f74e | 5b0150a060208faf436c09b0ca9463407a869c72 | 2016-11-18T02:40:07Z | c++ | 2016-11-18T19:11:08Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,163 | ["src/main.cpp"] | inundated with cmpctblocks |
[debug.log.txt](https://github.com/bitcoin/bitcoin/files/592002/debug.log.txt)
My node is being swamped with cmpctblocks from nodes, when as far as I understood it, only 3 nodes at a time were supposed to be announcing via cmpctblocks. Not only this, but many of the cmpctblocks arrive quite a while after I have received the block from other nodes, so surely my node should be requesting the announcement via cmpctblocks stops, or disconnecting the nodes that continue to announce via cmpctblocks after they've been requested not to.
As a bolt-on question: why is the contents of every cmpctblock received different? | https://github.com/bitcoin/bitcoin/issues/9163 | https://github.com/bitcoin/bitcoin/pull/9199 | 0c577f2638b7f701e4b4b96c4c8df39dc097cf2f | ca8549d2bd32f17f8b69d1edbe3f2976fba504b4 | 2016-11-15T12:59:52Z | c++ | 2016-11-22T02:54:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,126 | ["depends/packages/qt.mk", "depends/patches/qt/mac-qmake.conf"] | Depends built QT isn't being properly picked up on OS X | If you do a depends build on OS X (10.12), and plug the result into configure
```./configure --prefix=/Users/xxx/Github/bitcoin/depends/x86_64-apple-darwin16.1.0```
no bitcoin-qt is built.
```
checking for QT... yes
checking for QT_TEST... yes
checking for QT_DBUS... yes
checking for static Qt... yes
checking for QTPLATFORM... yes
checking for QTPRINT... yes
checking for Qt < 5.4... no
checking whether the linker accepts -framework IOKit... yes
checking for static Qt plugins: -lqcocoa... no
configure: WARNING: Could not resolve: -lqcocoa; bitcoin-qt frontend will not be built
checking whether to build Bitcoin Core GUI... no (Qt5)
```
QT parts from config.log are below.
[config.txt](https://github.com/bitcoin/bitcoin/files/585064/config.txt)
| https://github.com/bitcoin/bitcoin/issues/9126 | https://github.com/bitcoin/bitcoin/pull/9574 | 6012967c4746095e6f66a142cb9f639544c17377 | c36ec715f06d212381e0edfa4344514f1a575701 | 2016-11-11T05:30:41Z | c++ | 2017-01-19T07:31:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,110 | ["src/protocol.cpp"] | CInv::GetCommand(): type=1373179482 unknown type | It seems that bitcoin{d,-qt} can be crashed by being sent an inv of an unknown type. At least, it caused mine to:-
```
2016-11-08 00:45:36.470 ProcessMessages(getdata, 397 bytes): CHECKSUM ERROR expected=6d9dbcdf was=a1046737 peer=39585
2016-11-08 00:45:36.481
************************
EXCEPTION: St12out_of_range
CInv::GetCommand(): type=1373179482 unknown type
bitcoin in ProcessMessages()
2016-11-08 00:45:36.482 ProcessMessages(getdata, 397 bytes) FAILED peer=39585
2016-11-08 00:45:36.487
************************
EXCEPTION: St12out_of_range
CInv::GetCommand(): type=1373179482 unknown type
bitcoin in msghand
```
If the `throw std::out_of_range(strprintf("CInv::GetCommand(): type=%d unknown type", type));` in protocol.cpp supposed to cause the program to end? | https://github.com/bitcoin/bitcoin/issues/9110 | https://github.com/bitcoin/bitcoin/pull/9112 | e9847303e708ab71b4d2c22ceb7d65c89615e18a | e9f25ddd0063f7ea65595178d04370d27344305c | 2016-11-09T08:41:28Z | c++ | 2016-11-09T10:16:39Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,089 | ["src/qt/clientmodel.cpp", "src/qt/paymentserver.cpp"] | Datadir field displays incorrectly | <!--- Remove sections that do not apply -->
### Issue description
The datadir field on the debug window displays incorrectly if the profile folder name is accented.
### How to reproduce
1. Create a profile with accented profile folder name (àèìòùáéíóú)
2. Run bitcoin core with the default datadir
3. Go to the debug window and look at the datadir field
### Expected behaviour
The datadir folder path should display correctly.
### Actual behaviour
Accented characters display as a unknown character question mark.
### Screenshots
### Confirmed affected versions
The bug has been tested on the following implementations:
- v0.13.1 from source cross-compiled for Windows x64 on a Ubuntu 14.04 enviroment
- 0.13.0 official Windows x64 binary
### Additional debug info
Copying and pasting the text into a program that is known to support accented characters (Such as Notepad++) still displays unknown character symbols. | https://github.com/bitcoin/bitcoin/issues/9089 | https://github.com/bitcoin/bitcoin/pull/9094 | 5fa7b07565d2c7c1edfb9a2f8c1af42d039d99ee | e760b307f6210bee293796d606bcca87f86be200 | 2016-11-05T11:33:05Z | c++ | 2016-11-07T11:57:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,079 | ["src/qt/forms/modaloverlay.ui"] | ambiguous message: "spending bitcoins may not be possible" | There is a warning message that says "spending bitcoins may not be possible" which leaves the user unsure whether spending bitcoins will be possible or not. It would be better if it was clear whether the user can or cannot spend bitcoins and what this is dependent upon. | https://github.com/bitcoin/bitcoin/issues/9079 | https://github.com/bitcoin/bitcoin/pull/9088 | 273bde37d867d1f6ab67e22a65097b7adfc4831a | 77cbbd9ecffaeadd42b86a37bc83921be8b7dee5 | 2016-11-04T02:53:14Z | c++ | 2016-11-06T07:49:03Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,034 | ["qa/rpc-tests/import-rescan.py", "qa/rpc-tests/importmulti.py", "src/rpc/misc.cpp", "src/wallet/rpcdump.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h", "src/wallet/walletdb.cpp", "src/wallet/walletdb.h"] | importmulti does not respect the given timestamp | When importing a watch-only address over `importmulti` with a specific timestamp, the wallet's `nTimeFirstKey` will be set to 1.
I think we should add a optional timestamp to `CWallet::AddWatchOnly()` and use it when importing addresses or pubkeys.
| https://github.com/bitcoin/bitcoin/issues/9034 | https://github.com/bitcoin/bitcoin/pull/9108 | a58370e6a2d4dce50eefbcab5bde9f14facef8fc | a80f98b1c7a49432dc53d18d0fb51ac334de96be | 2016-10-27T14:13:37Z | c++ | 2017-02-10T21:11:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 9,007 | ["src/net.cpp"] | Assertion failed: (nMaxInbound > 0), function AcceptConnection, file net.cpp, line 973. | Current bitcoin-master on testnet, `maxconnections=8` in the config file. Running in VM that doesn't have public IP and is not reachable from the Internet.
Wait until you have 8 peers.
```
telnet localhost 18333
```
It will result in:
```
Assertion failed: (nMaxInbound > 0), function AcceptConnection, file net.cpp, line 973.
```
First found in https://github.com/bitcoin/bitcoin/pull/8996, but can be reproduced on master.
| https://github.com/bitcoin/bitcoin/issues/9007 | https://github.com/bitcoin/bitcoin/pull/9008 | ced22d035ac0f769c9c7cc21ad24d2caafb4b4e9 | fa1c3c2eb0a1853ed0e0662fc2bdbca51e05ccf5 | 2016-10-24T16:36:33Z | c++ | 2016-10-24T20:12:48Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,984 | ["src/main.cpp", "src/qt/bitcoingui.cpp", "src/qt/forms/modaloverlay.ui", "src/qt/modaloverlay.cpp"] | GUI hangs during sync | I suspect one of the recent changes added a lock that blocks the GUI thread waiting for some information. Traceback:
```
#0 __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
#1 0x00007fe28be3be82 in __GI___pthread_mutex_lock (mutex=0x56115c542220 <cs_main>) at ../nptl/pthread_mutex_lock.c:115
#2 0x000056115ba3d07f in boost::recursive_mutex::lock (this=<optimized out>) at /usr/include/boost/thread/pthread/recursive_mutex.hpp:113
#3 AnnotatedMixin<boost::recursive_mutex>::lock (this=<optimized out>) at /home/orion/projects/bitcoin/bitcoin/src/sync.h:60
#4 boost::unique_lock<CCriticalSection>::lock (this=0x7ffcedb5c5d8) at /usr/include/boost/thread/lock_types.hpp:346
#5 0x000056115ba3b5ce in CMutexLock<CCriticalSection>::Enter (this=0x56115c542220 <cs_main>, nLine=75, pszName=<optimized out>, pszFile=<optimized out>)
at /home/orion/projects/bitcoin/bitcoin/src/sync.h:125
#6 CMutexLock<CCriticalSection>::CMutexLock (this=0x56115c542220 <cs_main>, nLine=75, fTry=<error reading variable: access outside bounds of object referenced via synthetic pointer>, mutexIn=...,
pszName=<optimized out>, pszFile=<optimized out>) at /home/orion/projects/bitcoin/bitcoin/src/sync.h:146
#7 ClientModel::getHeaderTipHeight (this=<optimized out>) at /home/orion/projects/bitcoin/bitcoin/src/qt/clientmodel.cpp:75
#8 0x000056115ba2de74 in BitcoinGUI::setNumBlocks (this=0x56115d3d68c0, count=434832, blockDate=..., nVerificationProgress=0.99899780751543388, header=true)
at /home/orion/projects/bitcoin/bitcoin/src/qt/bitcoingui.cpp:722
#9 0x000056115babf86d in BitcoinGUI::qt_static_metacall (_o=_o@entry=0x56115d3d68c0, _c=<optimized out>, _id=<optimized out>, _a=_a@entry=0x7ffcedb5c860) at qt/moc_bitcoingui.cpp:206
#10 0x00007fe28c82dfca in QMetaObject::activate (sender=0x56115d6e3bc0, signalOffset=<optimized out>, local_signal_index=<optimized out>, argv=<optimized out>) at kernel/qobject.cpp:3713
#11 0x000056115bac0a46 in ClientModel::numBlocksChanged (_t1=<optimized out>, this=<optimized out>, _t2=..., _t3=<optimized out>, _t4=<optimized out>) at qt/moc_clientmodel.cpp:231
#12 ClientModel::qt_static_metacall (_o=0x56115c542220 <cs_main>, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at qt/moc_clientmodel.cpp:124
#13 0x00007fe28c82eea1 in QObject::event (this=0x56115d6e3bc0, e=<optimized out>) at kernel/qobject.cpp:1239
#14 0x00007fe28d17005c in QApplicationPrivate::notify_helper (this=this@entry=0x56115cf9ad60, receiver=receiver@entry=0x56115d6e3bc0, e=e@entry=0x7fe202a51310) at kernel/qapplication.cpp:3716
#15 0x00007fe28d175516 in QApplication::notify (this=0x7ffcedb5cea0, receiver=0x56115d6e3bc0, e=0x7fe202a51310) at kernel/qapplication.cpp:3499
#16 0x00007fe28c7ff62b in QCoreApplication::notifyInternal (this=0x7ffcedb5cea0, receiver=0x56115d6e3bc0, event=event@entry=0x7fe202a51310) at kernel/qcoreapplication.cpp:965
#17 0x00007fe28c801a26 in QCoreApplication::sendEvent (event=0x7fe202a51310, receiver=<optimized out>) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:224
#18 QCoreApplicationPrivate::sendPostedEvents (receiver=receiver@entry=0x0, event_type=event_type@entry=0, data=0x56115cf9e6e0) at kernel/qcoreapplication.cpp:1593
#19 0x00007fe28c801f08 in QCoreApplication::sendPostedEvents (receiver=receiver@entry=0x0, event_type=event_type@entry=0) at kernel/qcoreapplication.cpp:1451
#20 0x00007fe28c855673 in postEventSourceDispatch (s=0x56115d07e930) at kernel/qeventdispatcher_glib.cpp:271
#21 0x00007fe28957a1a7 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#22 0x00007fe2780016f0 in ?? ()
#23 0x0000000000000000 in ?? ()
```
| https://github.com/bitcoin/bitcoin/issues/8984 | https://github.com/bitcoin/bitcoin/pull/8985 | 0a261b63fd4f1b07431f8a65762ef9f1ef1c11c8 | 3154d6e3a207812578cb37a505f140b46b17c945 | 2016-10-20T16:23:04Z | c++ | 2016-10-20T17:02:59Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,973 | ["doc/tor.md", "src/chainparamsbase.cpp", "src/chainparamsbase.h", "src/init.cpp", "src/net.cpp", "src/net.h", "src/torcontrol.cpp", "src/torcontrol.h"] | Incoming tor connections should use alternative port | To be able to label incoming tor connections as different from normal localhost connections in e.g. `getpeerinfo` and the peers list in the GUI it'd be useful to have them connect on an alternative local-only port. Or even better, a UNIX socket.
For manually set-up hidden services this would have to be configured manually and could add a `hsport` option or such. The external port would still appear as `XXXXXXXXX.onion:8333`, however internally it would redirect to a that port.
In the case of `torcontrol` this would be easy to set up automatically. It could add a new (localhost) binding port automatically and this code would have to be changed:
- https://github.com/bitcoin/bitcoin/blob/master/src/torcontrol.cpp#L441
- https://github.com/bitcoin/bitcoin/blob/master/src/torcontrol.cpp#L477
| https://github.com/bitcoin/bitcoin/issues/8973 | https://github.com/bitcoin/bitcoin/pull/19991 | 60ec57b3d73e5cef71ebf3c4cdf54a4474bf492b | df2129a2349b1877049f250551f49a4592e73765 | 2016-10-19T10:40:29Z | c++ | 2020-10-02T11:37:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,970 | ["src/qt/forms/overviewpage.ui"] | Qt: Warning messages are not selectable | When a warning message is displayed in Bitcoin-QT, it is not possible to select it with the cursor (for copying or cutting).
| https://github.com/bitcoin/bitcoin/issues/8970 | https://github.com/bitcoin/bitcoin/pull/8972 | eb7741605b32c25893f687e19820dab114d04fe1 | ef0c9ee2960fda58b2fe5b0c3b4c672231b30322 | 2016-10-19T05:28:46Z | c++ | 2016-10-19T08:51:59Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,953 | ["src/rpc/blockchain.cpp", "test/functional/mempool_limit.py", "test/functional/wallet.py"] | 'minrelaytxfee' option not covered by tests, listed in Debugging/Testing options | The 'minrelaytxfee' option is described in the 'Fee filtering' section of the 0.13.0 release notes
(https://bitcoincore.org/en/2016/08/23/release-0.13.0) as
> For several years now, Bitcoin Core nodes have used a minimum relay fee rate to help determine what unconfirmed transactions they’ll process, relay, and store in their individual memory pools. Each node gets to decide its own minimum relay fee rate, and if they receive a transaction whose fee rate is below that limit, they don’t add it to their memory pools or relay it to their other peers (although another mechanism called transaction priority historically allowed some transactions that pay a low fee to be accepted into mempools and relayed).
This makes it appear as a fully supported feature, however, it is listed under 'Debugging/Testing options' when the `--help` option is used, and there seems to be no dedicated regression test for it.
From what I can tell it is used in abandonconflict.py, but its functionality is not specifically covered by any unit or regression tests.
### Can you reliably reproduce the issue?
Yes, this applies to 0.13.0 release and 0.13.1 development (current 0.13 branch)
#### Steps to reproduce:
1. run `bitcoind --help`
2. observe where the option 'minrelaytxfee' is listed
3. inspect the tests under 'qa' and 'src/test'
### Expected behaviour
- existence of at least a 'qa' test specifically covering the option (range of values, checking that it works as described)
- listing of the option under some non-'Debugging/Testing' group such as 'Node relay options', 'Wallet options' or general 'Options'
### Actual behaviour
- 'minrelaytxfee' option is listed under 'Debugging/Testing options', suggesting it is experimental
- 'minrelaytxfee' is used for a side effect in abandonconflict.py
### What version of bitcoin-core are you using?
Official 0.13.0 binary, as well as verified in source code of v0.13.0 tag (commit a402396dce64c42ea73535b7dde4a9164d430438) and current 0.13 branch commit 907c314057b09f1565840237b29a1bd607623ccd .
| https://github.com/bitcoin/bitcoin/issues/8953 | https://github.com/bitcoin/bitcoin/pull/12001 | d9fdac130a5ed1d96fcac6bb87c10bec9d596b17 | aad309065d38613a7e98aba39d947ca215b7c2f7 | 2016-10-18T11:40:53Z | c++ | 2017-12-29T14:56:44Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,945 | ["src/rpc/mining.cpp"] | getblocktemplate help text should report BIP9 'rules' | ### Describe the issue
The `getblocktemplate` RPC output does not list the 'rules' field in the template request object, as described in BIP9.
### What version of bitcoin-core are you using?
0.13.1rc1
| https://github.com/bitcoin/bitcoin/issues/8945 | https://github.com/bitcoin/bitcoin/pull/8951 | 2c06bae39edfaa9c0855d83377ad8fda09e4fa08 | 59daa58d6a17bb1170c724f2d01d43c2ec21a9b4 | 2016-10-17T20:53:59Z | c++ | 2016-10-19T08:47:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,910 | ["src/bench/bench.cpp", "src/bench/bench.h"] | bench_bitcoin crashes on FreeBSD and OpenBSD | `bench_bitcoin` crashes at startup, even before getting to main. It seems to have to do with the registration system:
``` c++
// BENCHMARK(foo) expands to: benchmark::BenchRunner bench_11foo("foo", foo);
#define BENCHMARK(n) \
benchmark::BenchRunner BOOST_PP_CAT(bench_, BOOST_PP_CAT(__LINE__, n))(BOOST_PP_STRINGIZE(n), n);
```
I don't know how the BOOST_PP_CAT stuff is working internally. This is likely an upstream issue with boost, to do with initialization order.
(FreeBSD 10.3, Boost 1.55)
| https://github.com/bitcoin/bitcoin/issues/8910 | https://github.com/bitcoin/bitcoin/pull/9712 | b709fe7ffc44ae14bbd2403cdfbfa4fcf94cef6b | 29c53289a9e6bb34a098ea87d923968e3ac6d75d | 2016-10-11T10:59:51Z | c++ | 2017-02-07T18:07:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,878 | [".github/ISSUE_TEMPLATE.md"] | Needing an FAQ | I am noticing a fair number of github issues which are being closed quite quickly, either because they are being identified as "questions", or because they are deemed to be not appropriate issues for github. I think an FAQ that could form part of the bitcoin core distrubution needs to be created so that github stops being used for out-of-scope issues - and the scope is documented, ideally along with links to where are the correct areas for asking questions. Raising this issue to hopefully kickstart that process.
| https://github.com/bitcoin/bitcoin/issues/8878 | https://github.com/bitcoin/bitcoin/pull/8887 | d7615af34e8e19920ed12bfdafb09e0e4b57c7c5 | 7d8afb4cde168659ec8363ff3b99611dd88557a5 | 2016-10-04T05:28:19Z | c++ | 2016-10-06T03:26:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,876 | ["src/net.cpp", "src/net.h", "src/qt/rpcconsole.cpp"] | Commit 6423116 broke ban node list functionality in bitcoin-qt debug window | ### Describe the issue
bitcoin-qt: Debug pop-up window, Peers tab, right-click ban node for 1 hour, day, week, year does nothing. Disconnect node still works.
### Is the issue reproducible?
Yes.
#### List steps to reproduce below:
1. build master branch after commit https://github.com/bitcoin/bitcoin/commit/6423116741de2144872389cf63a621539ae79aaa
2. launch bitcoin-qt (on testnet is advisable)
3. test ban node list right-click functionality on Menu->Help->Debug pop-up window, Peers tab.
| https://github.com/bitcoin/bitcoin/issues/8876 | https://github.com/bitcoin/bitcoin/pull/8885 | d7615af34e8e19920ed12bfdafb09e0e4b57c7c5 | cb78c60534e5be205f9190cb0cde700f9e9fa38d | 2016-10-04T04:21:05Z | c++ | 2016-10-04T23:43:53Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,867 | ["depends/packages/libevent.mk", "depends/patches/libevent/libevent-2-fixes.patch", "depends/patches/libevent/reuseaddr.patch"] | Move to Libevent 2.1.x | Libevent 2.1.6-beta was released in July this year.
The current stable build (2.0.22) was released in Jan 2015, the same time as the previous beta.
Not using 2.1.x is affecting atleast
- [WIP] rest: Stream entire utxo set #7759
- bitcoin-cli: More detailed error reporting #8722
- Compatibility logic in [bitcoin-cli.cpp](https://github.com/bitcoin/bitcoin/blob/master/src/bitcoin-cli.cpp#L129)
There are also compatibility issues with 2.0.22 and recent mingw-w64 gcc versions, see #8730
Optimistically tagged this as something for 0.14.0
| https://github.com/bitcoin/bitcoin/issues/8867 | https://github.com/bitcoin/bitcoin/pull/9471 | 5bc3b6cede8dabdf3f4f27ddb03723cbb7cde51a | 8217bd1d4cb9415dd507739b9040714677f9e8e8 | 2016-10-03T09:51:03Z | c++ | 2017-01-04T14:00:26Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,864 | ["src/qt/guiutil.cpp", "src/qt/guiutil.h", "src/qt/rpcconsole.cpp", "src/qt/rpcconsole.h"] | Multiple peer operations via GUI | Currently if somebody wants to do some peer operations (for whatever reason) via the GUI, they have to select 1-by-1 and do them individually. This is just very inefficient when the same operation has to be carried out on multiple peers. It would be nice to be able to select multiple peer at once and e.g. ban them all.
| https://github.com/bitcoin/bitcoin/issues/8864 | https://github.com/bitcoin/bitcoin/pull/8874 | addfdebe1a2ec45f718638f39a9ae3afb531805f | 1077577546334bc26daa3ab8580f24063a0b67c6 | 2016-10-02T14:27:42Z | c++ | 2016-11-08T20:11:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,842 | ["qa/rpc-tests/p2p-compactblocks.py", "src/main.cpp"] | p2p-compactblocks.py fails randomly | It seems p2p-compactblocks.py fails randomly
From: https://travis-ci.org/bitcoin/bitcoin/jobs/163788152 from #8841
The PR is trivial and totally unrelated to compact block
```
p2p-compactblocks.py:
Initializing test directory /tmp/test3yd_2q3h/2
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC succesfully started
MiniNode: Connecting to Bitcoin Node IP # 127.0.0.1:11016
Testing SENDCMPCT p2p message...
Testing compactblock headers and shortIDs are correct...
Assertion failed:
Stopping nodes
Not cleaning up dir /tmp/test3yd_2q3h/2
Failed
stderr:
File "/home/travis/build/bitcoin/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 151, in main
self.run_test()
File "/home/travis/build/bitcoin/bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 614, in run_test
self.test_compactblock_construction()
File "/home/travis/build/bitcoin/bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 264, in test_compactblock_construction
assert(self.test_node.last_cmpctblock is not None)
Pass: False, Duration: 7 s
```
| https://github.com/bitcoin/bitcoin/issues/8842 | https://github.com/bitcoin/bitcoin/pull/9058 | 55bfddcabbf9e8a3743f77167ba4a43aaba9f948 | dac53b58b555183ccc0d5e64c428528267cd98b3 | 2016-09-29T18:46:36Z | c++ | 2016-11-07T19:35:11Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,782 | ["src/Makefile.qt.include", "src/qt/bitcoinstrings.cpp", "src/qt/locale/bitcoin_en.ts"] | qt: Missing translations | It seems the strings in `qt/bitcoin.cpp` are not translated.
E.g. `qt/bitcoin-qt -lang=cz -datadir=/tmp/a2` gives me a warning in English that the datadir does not exist.
| https://github.com/bitcoin/bitcoin/issues/8782 | https://github.com/bitcoin/bitcoin/pull/9457 | fae26e8dfc083679d33c57bf5166b83b6783b00a | facf3e76086133f5013a7b174bbb0fccb8d670f5 | 2016-09-21T21:50:32Z | c++ | 2017-01-04T11:13:03Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,758 | ["src/wallet/rpcwallet.cpp"] | Fix documentations of rpc `listsinceblock` | ## The second param of listsinceblock
From [issue 8752](https://github.com/bitcoin/bitcoin/issues/8752#issuecomment-247988691)
> The second parameter (target confirmation) is quite strange and should probably be better > documented in the RPC help of listsinceblock (check original comment: #199 (comment))
From the actual docs here is it is:
> target-confirmations: (numeric, optional) The confirmations required, must be 1 or more
However, that's misleading at best. I've seen at least one project thinking that `target-confirmations` means "filter to only show transactions of n target-confirmations". It's a weird param but I'd document it as
> target-confirmations: (numeric, optional) Return the hash of the block that has target-confirmations of confirmations, for use in a further call to listsinceblock
## Transactions confirmations
Says:
> "confirmations": n, (numeric) The number of confirmations for the transaction. Available for 'send' and 'receive' category of transactions.
It should also say when it's < 0, it means the transaction conflicted that many blocks ago
## bip125-replaceable
There's an undocumented field of transactions "bip125-replaceable" which I believe has three possibilities "yes" "no" and "unknown" (under what circumstances it says unknown, should also be documented)
| https://github.com/bitcoin/bitcoin/issues/8758 | https://github.com/bitcoin/bitcoin/pull/9396 | 5a70572049d0e8a2e9228e7acf0e07d61996c33c | 3f67972654748a2f24e4aa95b6f3df5d4574ed55 | 2016-09-19T13:28:55Z | c++ | 2016-12-22T17:28:03Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,752 | ["src/wallet/rpcwallet.cpp", "test/functional/wallet_listsinceblock.py"] | rpc `listsinceblock hash` is not correctly filtering double-spends | ### Describe the issue
Testing in bitcoin 0.13.0, calling `bitcoin-cli listsinceblock x` is outputting all double-spent transactions that are in the wallet, even those that were double-spent well and truly before x.
### Is the issue reproducible?
Yes
#### List steps to reproduce below:
1. Create a double-spend send to your wallet (easiest using bip125)
2. Wait until one confirms, and then wait a few more blocks
3. Run `bitcoin-cli listsinceblock $(bitcoin-cli getbestblockhash)` and it will output the double spent transaction
### Expected behavior
The double-spent transaction that was conflicted before the block hash should be filtered
| https://github.com/bitcoin/bitcoin/issues/8752 | https://github.com/bitcoin/bitcoin/pull/17258 | 693e40090ae7af52585ce1a6136a4bd56318fac7 | 436ad436434b94982bcb7dc1d13a21949263ef73 | 2016-09-17T23:28:01Z | c++ | 2019-10-28T14:26:46Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,647 | ["qa/rpc-tests/test_framework/test_framework.py", "qa/rpc-tests/wallet-hd.py"] | [qa] Cleanup doesn't get top level directory | I think after #8098, the cleanup that happens at the end of an rpc test no longer deletes the temp datadir created by default. (I have a whole bunch of directories in /tmp/ now that I didn't use to have, so I think that's the cause...)
Would be nice for cleanup to work as it used to, at least in the situation where no datadir is being passed in as an argument.
| https://github.com/bitcoin/bitcoin/issues/8647 | https://github.com/bitcoin/bitcoin/pull/8652 | 438e94dc330a37600ec1d86f2ba8502385b5262d | c62cc4ec759a8487373f158b3cbb888efcdd753a | 2016-09-02T00:42:37Z | c++ | 2016-09-04T23:06:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,605 | ["qa/rpc-tests/test_framework/blockstore.py"] | p2p-fullblocktest fails on BSD derivates | On OpenBSD:
```
Initializing test directory /tmp/test8vty0436/25006
MiniNode: Connecting to Bitcoin Node IP # 127.0.0.1:11408
...
Unexpected exception caught during testing: error('cannot add item to database',)
File "/home/user/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 150, in main
self.run_test()
File "qa/rpc-tests/p2p-fullblocktest.py", line 73, in run_test
self.test.run()
File "/home/user/bitcoin/qa/rpc-tests/test_framework/comptool.py", line 336, in run
self.block_store.add_block(block)
File "/home/user/bitcoin/qa/rpc-tests/test_framework/blockstore.py", line 80, in add_block
self.blockDB[repr(block.sha256)] = bytes(block.serialize())
Stopping nodes
```
Could be a difference between ndb back-end libraries used on OpenBSD and Ubuntu. I vaguely remember some ndb variants can only handle fairly small databases.
On Ubuntu:
``` python
>>> import _dbm
>>> _dbm.library
'Berkeley DB'
```
On OpenBSD:
``` python
>>> import _dbm
>>> _dbm.library
'GNU gdbm'
```
I believe even that is misreporting: OpenBSD does not install gdbm by default. This must be some ancient dbm variant. Just checked: It's taking the symbol from the libc(!) off all places: https://github.com/robertbachmann/openbsd-libc/tree/master/db
> 4.4BSD (and its derivatives such as NetBSD) contains Berkeley DB 1 in libc.
Ugh.
Anyhow, seems to work if I swap `dbm.ndbm` with `dbm.dumb` in `test_framework/blockstore.py` (**be sure to replace all three occurences**). This is not a good idea by default, as the performance of the dumb database is rumored to be abysmal (I haven't benchmarked though), but we could add a workaround specifically for OpenBSD.
``` patch
diff --git a/qa/rpc-tests/test_framework/blockstore.py b/qa/rpc-tests/test_framework/blockstore.py
index 1e2bbb2..74cf125 100644
--- a/qa/rpc-tests/test_framework/blockstore.py
+++ b/qa/rpc-tests/test_framework/blockstore.py
@@ -9,11 +9,11 @@
from .mininode import *
from io import BytesIO
-import dbm.ndbm
+import dbm.dumb
class BlockStore(object):
def __init__(self, datadir):
- self.blockDB = dbm.ndbm.open(datadir + "/blocks", 'c')
+ self.blockDB = dbm.dumb.open(datadir + "/blocks", 'c')
self.currentBlock = 0
self.headers_map = dict()
@@ -123,7 +123,7 @@ class BlockStore(object):
class TxStore(object):
def __init__(self, datadir):
- self.txDB = dbm.ndbm.open(datadir + "/transactions", 'c')
+ self.txDB = dbm.dumb.open(datadir + "/transactions", 'c')
def close(self):
self.txDB.close()
```
| https://github.com/bitcoin/bitcoin/issues/8605 | https://github.com/bitcoin/bitcoin/pull/8834 | 8ca69a2a88a77eb06149fa049ab1a7e6de38b321 | fa9cd25ed0587078e3218965606c79ebf8138d53 | 2016-08-26T15:06:25Z | c++ | 2016-09-29T09:18:31Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,599 | ["src/main.cpp"] | Possible Deadlock | Just updated a node to current master (+https://github.com/bitcoin/bitcoin/pull/7685), the node ran successfully for a couple of weeks, shortly after updating to current master, I ran in a deadlock assertion:
I think the possible deadlock is not related to the PR which I'm running on top.
```
2016-08-26 07:50:29 POTENTIAL DEADLOCK DETECTED
2016-08-26 07:50:29 Previous lock order was:
2016-08-26 07:50:29 pnode->cs_vRecvMsg net.cpp:1885 (TRY)
2016-08-26 07:50:29 cs_main main.cpp:4726
2016-08-26 07:50:29 (1) pfrom->cs_filter main.cpp:4784
2016-08-26 07:50:29 (2) cs_vSend net.cpp:2683
2016-08-26 07:50:29 Current lock order is:
2016-08-26 07:50:29 (2) pnode->cs_vSend net.cpp:1904 (TRY)
2016-08-26 07:50:29 cs_main main.cpp:6343 (TRY)
2016-08-26 07:50:29 pto->cs_inventory main.cpp:6563
2016-08-26 07:50:29 (1) pto->cs_filter main.cpp:6586
```
| https://github.com/bitcoin/bitcoin/issues/8599 | https://github.com/bitcoin/bitcoin/pull/8606 | bb566761fbe1631b5a7205ec1e93d9484c9c7ee8 | 144ed76ea0b38b7c21b224501964f8a2c65c4bb6 | 2016-08-26T09:24:06Z | c++ | 2016-08-26T19:11:57Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,518 | ["src/main.cpp"] | testnet: 0.13 peers are disconnected due to "stalling" | As segwit is active on testnet, blocks will only be downloaded from NODE_WITNESS peers. Though, exactly those peers are disconnected after `BLOCK_STALLING_TIMEOUT = 2` seconds. I am running master (6e6ab2c)
This behavior is consistent across restarts. Sample [debug.log](http://pastebin.ubuntu.com/23058327/) and [getchaintips](http://pastebin.ubuntu.com/23058325/).
It is possible that I shot my own foot at some point, but it seemed smelly enough to create an issue.
| https://github.com/bitcoin/bitcoin/issues/8518 | https://github.com/bitcoin/bitcoin/pull/8612 | c072b8fd95cd4fa84f08189a0cd8b173ea2dbb8e | 887919c7b7120ab0ca12703ea1cdfc18a5085aa2 | 2016-08-15T19:23:31Z | c++ | 2016-08-26T19:44:44Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,433 | ["doc/files.md", "src/init.cpp", "src/main.cpp", "src/main.h", "src/txmempool.cpp", "src/txmempool.h"] | Persist mempool, arrival times, and prioritisetransaction across restarts | Currently the mempool isn't persisted across restarts. The historical argument against doing this is that it would make transactions immortal. Expiration now addresses that issue.
Without preserving the mempool node behavior changes drastically across restarts which complicates production use (e.g. mining overly small/low fee blocks) as well as development testing. The lack of retention also causes the loss of txn priority modifications made with prioritisetransaction which makes the API less reliable.
| https://github.com/bitcoin/bitcoin/issues/8433 | https://github.com/bitcoin/bitcoin/pull/8448 | 3f78562df5e86a2a0a21812047fc3a7db8cee988 | 582068aa907127c12db53fbd65667dc7810d42b0 | 2016-07-31T05:52:13Z | c++ | 2016-10-31T07:10:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,399 | ["src/rpc/protocol.cpp"] | Cookie auth picks passwords which are incompatible with some URL parsers | Looks like the python bitcoinrpc authproxy stuff uses python "urlparse" that chokes on "/" in passwords.
AFAICT (?) it's python that is in the wrong here, but broken httpauth handling is common.
I used base58 encoding for the old code that would provide a suggested rpcpassword when you tried to run the daemon without one. I think base58 is free of any characters that will screw up url handling... and there are no compatibility issues with just changing what cookieauth uses.
| https://github.com/bitcoin/bitcoin/issues/8399 | https://github.com/bitcoin/bitcoin/pull/8858 | 6faffb8a83db3f209a303a4464dbdd597faad5a4 | 1c80386bceb216ca5b5da657e03a29f9c779d58b | 2016-07-24T22:07:18Z | c++ | 2016-10-01T14:57:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,292 | ["configure.ac"] | bench_bitcoin: Build system updates needed | bench_bitcoin isn't checked for in at least one important point: determining boost necessity.
Symptom is that a lib+bench build will fail due to not having a boost sleep implementation.
| https://github.com/bitcoin/bitcoin/issues/8292 | https://github.com/bitcoin/bitcoin/pull/8310 | 91abb77970f47b1f6166e564bc695ed30c75bb63 | cf2ef786a1ef78edefd7c1029feb46d1a9061b75 | 2016-06-29T23:36:43Z | c++ | 2016-07-06T21:31:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,290 | ["src/util.cpp"] | [qt] Splash screen shows copyright string twice | When using qt in a different language than english, it shows the copyright string twice:
ar:
en:
| https://github.com/bitcoin/bitcoin/issues/8290 | https://github.com/bitcoin/bitcoin/pull/8291 | 3685e0c1da296be533fef4abcf1b1734ed7d85e7 | 33336e1aacb36607d0950d681d8e24821e64f8df | 2016-06-29T20:39:59Z | c++ | 2016-07-02T08:46:26Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,279 | ["qa/rpc-tests/p2p-segwit.py", "src/main.cpp"] | Mempool DoS risk in segwit due to malleated transactions | Noticed this in my code review: https://petertodd.org/2016/segwit-consensus-critical-code-review#peer-to-peer-networking
Basically it looks like an attacker may be able to send nodes transactions with malleated witness data, which we don't consistently mark as possibly corrupted in AcceptToMemoryPool(). Result would be those txids being added to recentRejects, messing up propagation.
That said, I haven't actually tested this yet; about to go off to a conference, so if someone else wants to confirm for me that'd be much appreciated! Or if I'm wrong you're welcome to all laugh at my expense. :)
CC: @sdaftuar @sipa
| https://github.com/bitcoin/bitcoin/issues/8279 | https://github.com/bitcoin/bitcoin/pull/8312 | bb66a11396335b5f4e5914806fcb2dc6165edf6f | 46c9620f11acfd2b528959d6cbab324105c3adef | 2016-06-28T14:06:09Z | c++ | 2016-07-08T01:18:34Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,255 | ["src/init.cpp", "src/noui.cpp", "src/qt/bitcoingui.cpp", "src/ui_interface.h"] | Tx index option | Starting with txindex option produces a bug continually printing "y".
```
sudo apt-add-repository ppa:bitcoin/bitcoin
sudo apt-get update
bitcoind -daemon -txindex=1 -server=1 &
root@btc:~# Bitcoin server starting
: You need to rebuild the database using -reindex to change -txindex.
Do you want to rebuild the block database now?
yes
y
y
y
y
y
```
| https://github.com/bitcoin/bitcoin/issues/8255 | https://github.com/bitcoin/bitcoin/pull/8257 | 08338942b50f915add72156e02a2131310d56e45 | 1acf1db76fc3e07deb8f0f837934ea90383fedb5 | 2016-06-24T08:17:26Z | c++ | 2016-06-24T14:45:12Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,237 | ["configure.ac"] | [GUI] QT 5.7 | Opening an issue to track potential QT5.7 improvements, so that comments don't get lost on closed PRs.
QT 5.7 has been [released](https://blog.qt.io/blog/2016/06/16/qt-5-7-released/).
```
Starting with Qt 5.7, we will require a C++11 compliant compiler to build and use Qt.
This allows us to use many of the new features in Qt itself, and renew our codebase
using features such as constexpr, move semantics, range-for and auto. These efforts
are well under way and will continue throughout the next versions.
#### Qt Core
- Qt uses poll() instead of select() in it’s event loop allowing for more than 1024 file
descriptors
- Qt now uses std::atomic for it’s atomic classes
```
https://github.com/bitcoin/bitcoin/pull/8053#issuecomment-226714893
```
Though it's worth noting for a future pr: 5.7 improves a few build-related
things for us:
- allows for split native tools build.
- passes flags (like -D and -B only to the host toolchain)
(I'm on mobile so those are from memory, may not be 100% accurate. I also
haven't tested that those work as intended.)
The first should allow us to split up the build into more reasonable chunks
(native_qttools and qtlibs).
The second should allow us to drop the xcb patch in favor of using more
detailed flags. It should also allow us to drop the hackish env vars we use.
```
| https://github.com/bitcoin/bitcoin/issues/8237 | https://github.com/bitcoin/bitcoin/pull/9169 | 6eeac6e30d65f9a972067c1ea8c49978c8e631ac | 70266e98292bf9c8f019ca4b11d681b575f71448 | 2016-06-22T07:38:31Z | c++ | 2016-11-15T21:12:17Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,228 | ["build-aux/m4/bitcoin_qt.m4", "configure.ac"] | No error reporting when pkg-config missing in depends build | I was building on a fresh Ubuntu 14.04 VM. Apparently I forgot to install PKG_CONFIG.
```
cd depends
make HOST=x86_64-w64-mingw32 NO_QT=1 NO_UPNP=1 -j6
cd ..
./automake.sh
./configure --enable-reduce-exports --prefix=`pwd`/depends/x86_64-w64-mingw32
make -j10
```
The linking step subsequently failed with an error about missing symbols. The immediate cause was trivial: `-levent -lopenssl` wasn't being passed to the linker.
After investigating somewhat deeper it appears this is a result from missing `pkg-config`.
AFAIK the only indication of an error was during configure:
```
./configure: line 17775: PKG_PROG_PKG_CONFIG: command not found
```
However, this was not fatal so I missed it the first time around. It should be a fatal error.
After installing the `pkg-config` package and re-running `autogen.sh` and `configure`, everything is working as expected.
| https://github.com/bitcoin/bitcoin/issues/8228 | https://github.com/bitcoin/bitcoin/pull/8314 | 0c928cb13cc9146bb2c0f39d1d3b6e1e660a375d | b556beda264308e040f8d88aca4f2f386a0183d9 | 2016-06-20T10:10:03Z | c++ | 2016-07-07T18:18:12Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,150 | ["src/init.cpp"] | "Tell other nodes to filter invs to us by our mempool min fee" message is too technical | `-feefilter` should either be turned a debug option (whose help is not translated), or we should come up with a (translation) friendlier help message for the option:
https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L322
Reported on transifex by yahoe.001.
| https://github.com/bitcoin/bitcoin/issues/8150 | https://github.com/bitcoin/bitcoin/pull/8151 | 52c3f348bec33fab5ae0a9f1b9f14b9a74c0083f | fa51a1d2b73580e240a4750144ceb14022deeae2 | 2016-06-06T13:51:27Z | c++ | 2016-06-07T06:47:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,131 | ["doc/bips.md"] | Post CSV softfork trigger TODOs | - [x] Update bips.md
- [x] #7540: Rename OP_NOP3 to OP_CHECKSEQUENCEVERIFY
| https://github.com/bitcoin/bitcoin/issues/8131 | https://github.com/bitcoin/bitcoin/pull/8303 | 115735d547fdeade822f547eb3e8c8f9961a9b07 | ab0c35a290b8cb05b9bed0c24627bcc98bb22b2b | 2016-06-01T06:06:05Z | c++ | 2016-07-05T02:27:01Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,125 | ["src/primitives/transaction.cpp", "src/primitives/transaction.h", "src/qt/transactiondesc.cpp"] | [GUI] Show transction size in transaction window. | The user of-course can already implicitly work out this information from comparing the fee-rate with the actual fee.
I think that it would be useful for people not wanting to do this arithmetic in their head.
| https://github.com/bitcoin/bitcoin/issues/8125 | https://github.com/bitcoin/bitcoin/pull/8672 | fdf82fba3105c3c824e594db8cd7c55c4f692744 | c015634400f112f8b7f037c82690f1332d7971a3 | 2016-05-30T14:31:38Z | c++ | 2016-09-06T20:31:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,117 | ["src/init.cpp", "src/main.cpp", "src/net.cpp", "src/test/test_bitcoin.cpp"] | Initialization reports "Loading banlist..." while doing something else | While starting up a node (commit 6fc6325), it was apparently taking curiously long to load the ban list. RPC (in warmup mode) kept returning `Loading banlist...`. When I checked the log I happened upon the following:
```
2016-05-30 07:35:00 init message: Loading banlist...
2016-05-30 07:35:26 UpdateTip: new best=0000000000000000045614e4901f822a86e4015543acc6a68653cc9450f0f330 height=410222 version=0x20000000 log2_work=84.600836 tx=126776938 date='2016-05-04 18:0
1:59' progress=0.984518 cache=8.8MiB(5488tx)
...
2016-05-30 07:39:43 DNS seeding disabled
2016-05-30 07:39:43 opencon thread start
2016-05-30 07:39:43 msghand thread start
2016-05-30 07:39:43 addcon thread start
2016-05-30 07:39:43 init message: Done loading
2016-05-30 07:39:43 net thread start
```
I think it's a matter of the init message not being updated for a new initialization phase after loading the banlist.
| https://github.com/bitcoin/bitcoin/issues/8117 | https://github.com/bitcoin/bitcoin/pull/8392 | aa59f2ed3f378c02159e41ff3ae2df76ef850577 | 9d4eb9ad99f7c3abf7abaeaf7ea51f98f9445e75 | 2016-05-30T09:40:11Z | c++ | 2016-07-30T00:17:51Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,089 | ["contrib/verify-commits/verify-commits.sh"] | verify-commits should also check for malicious code in merge commits | Assuming that the machine of a maintainer is compromised, it is possible to have the merge commit modified before sign and push.
As we already have the requirement that "everyone without exception contributes patch proposals using pull requests." [[1]](https://github.com/bitcoin/bitcoin/blob/37f9a1f627c0995d89b62923e75cd092600894f9/CONTRIBUTING.md#contributor-workflow), I'd propose that we add the requirement that a pull request can only be merged when there is no merge conflict to be solved. Thus, verify-commits could not only check the signature of every merge commit but also fail when the merge commit modifies more code than the branch did that is about to be merged.
| https://github.com/bitcoin/bitcoin/issues/8089 | https://github.com/bitcoin/bitcoin/pull/12708 | 7be9a9a570c1140048f8781ced1111e1d930e517 | 577f11141c5155345c68809aac8511b018cc4050 | 2016-05-23T07:51:54Z | c++ | 2018-03-16T17:24:59Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,079 | ["src/init.cpp", "src/main.cpp", "src/main.h", "src/policy/policy.cpp", "src/policy/policy.h", "src/txmempool.cpp"] | bytespersigop prevents bare multisig in v0.12 | in v0.12 https://github.com/bitcoin/bitcoin/pull/7081 (by @luke-jr) was merged adding `-bytespersigop` (with default of 20).
this is preventing simple bare multisig transactions from being accepted into mempool when the size is < 400 bytes.
eg; https://gist.github.com/rubensayshi/ac4f617207f7a50559e85d61c05800be
from 1-of-7 and onwards they are accepted because the ratio of bytes:sigops is high enough.
also having 2 or more inputs will work because it again tips the ratio of bytes:sigops over.
the reason mainly being that `GetLegacySigOpCount` calls `GetSigOpCount` with `fAccurate=false`.
It looks like changing `GetLegacySigOpCount` to use `fAccurate=true` would cause side effects in the few other places (`ConnectBlock`, `CheckBlock`, `CreateNewBlock`) and simply adding `fAccurate` as arg to `GetLegacySigOpCount` would affect the value stored in `CTxMemPoolEntry.sigOpCount` which in turn affects a bunch of other things.
| https://github.com/bitcoin/bitcoin/issues/8079 | https://github.com/bitcoin/bitcoin/pull/8365 | 045106b4f13c1d6f3a4f65d6dddc6ac1e15003bb | ab942c15bd3854650afa810d7c22d7fd30d346c1 | 2016-05-20T16:46:47Z | c++ | 2016-07-19T10:31:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,071 | [".travis.yml"] | test_bitcoin failing in travis without log output | Travis no-wallet build of master fails unit tests, it is unclear why:
```
FAIL: test/test_bitcoin
PASS: qt/test/test_bitcoin-qt
```
https://travis-ci.org/bitcoin/bitcoin/jobs/131336729
For some reason there is no detailed output.
| https://github.com/bitcoin/bitcoin/issues/8071 | https://github.com/bitcoin/bitcoin/pull/8072 | e2bf830bb6c1bfa038c943dd6f5d92a406bd723f | 401ae654b247d80e29e76ebd094e9e37409941bd | 2016-05-19T07:53:43Z | c++ | 2016-05-19T09:15:12Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,040 | ["src/qt/bitcoingui.cpp", "src/qt/bitcoingui.h"] | bitcoin core 0.12.1.0-g9779e1e crashing when opening debug window during startup | MacPorts-installed Bitcoin Core's version v0.12.1.0g9779e1e crashes on OSX when trying to open the debug window while the app is verifying the blocks at startup.
| https://github.com/bitcoin/bitcoin/issues/8040 | https://github.com/bitcoin/bitcoin/pull/8042 | 423ca302a3ee87000530da3c105f269b8fabece7 | 276ce84fd3a9561a11ae4c5a00c71ff44d3a59a9 | 2016-05-10T18:10:31Z | c++ | 2016-05-12T08:45:03Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,032 | ["CONTRIBUTING.md"] | Add 'how to squash several fixup commits' to our coding guideline | Adding this to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md helps to not have it copy paste in every comment: https://github.com/bitcoin/bitcoin/pull/8004#issuecomment-217810102
| https://github.com/bitcoin/bitcoin/issues/8032 | https://github.com/bitcoin/bitcoin/pull/8034 | 4e14afe42fdd468d5de11df8cc13defdcb8e83f8 | 90963e53707cf244e6a2a804341e9280628b0c34 | 2016-05-09T13:25:39Z | c++ | 2016-05-10T08:14:21Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 8,010 | ["src/compat.h", "src/net.cpp", "src/util.cpp", "src/util.h"] | Priority inversion? | During some lock debugging on a dual-core Linux system I noticed that threads are blocked acquiring `cs_vNodes` and `cs_main` for long periods when the system is under moderate load from unrelated processes -- the unlucky lock acquirer is waiting for single-digit seconds once every 10 minutes or so (not coinciding with new blocks) up to around a 30 second wait every few hours. It looks like `ThreadMessageHandler` is taking locks and then due to being set to `THREAD_PRIORITY_BELOW_NORMAL`, it's being descheduled (even in trivial lock-holding regions like `GetHeight`) and holding up for arbitrarily long periods other threads that use these core locks.
So I'm wondering, what are the benefits of running the message handler at low priority?
| https://github.com/bitcoin/bitcoin/issues/8010 | https://github.com/bitcoin/bitcoin/pull/8011 | 3b9a0bf41f2336b09e854522ab1ce6dcfc7a3050 | e53e7c54736b98098553ba1a5191e093684f9114 | 2016-05-05T18:49:02Z | c++ | 2016-05-05T20:25:35Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,998 | ["depends/builders/darwin.mk"] | [depends] Boost fails to build on OSX 10.11, Xcode 7.3.1 | ```
clang: warning: optimization flag '-finline-functions' is not supported
In file included from libs/thread/src/pthread/once.cpp:8:
In file included from libs/thread/src/pthread/./once_atomic.cpp:9:
In file included from ./boost/thread/once.hpp:20:
In file included from ./boost/thread/pthread/once_atomic.hpp:16:
./boost/thread/detail/move.hpp:31:10: fatal error: 'type_traits' file not found
#include <type_traits>
```
It seems adding `-stdlib=libc++` to the cxxflags fixes the issue
This also occurs with the `x86_64-apple-darwin11` prefix
| https://github.com/bitcoin/bitcoin/issues/7998 | https://github.com/bitcoin/bitcoin/pull/8002 | 559fbae8c658c779a423201df6d5850fce3cd3b1 | 47eda2d8820b8161b6ef550af6575cbe4f1a3207 | 2016-05-04T02:06:49Z | c++ | 2016-05-04T11:03:59Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,990 | ["share/setup.nsi.in"] | Windows installer launches GUI as Admin | When installing the GUI with the Windows installer, there's a checkbox at the end of the process that launches the software. However, when the installer launches a process, it runs at the same Integrity Level (privilege) as the installer. As the installer is, well, installing software, it needs to run at the High (elevated/admin) privilege/Integrity Level, and hence the node/GUI will be launched at that same level. I've confirmed this using [Sysinternals Process Explorer](https://technet.microsoft.com/en-us/sysinternals/processexplorer.aspx) -- launching Bitcoin Core from the Start menu results in an Integrity Level of Medium, as expected, while closing the installer without deselecting the checkbox results in the process being started at the High level.
A quick search does turn up ways to work around the issue (such as [this plugin](http://nsis.sourceforge.net/ShellExecAsUser_plug-in) in combination with [this trick](http://nsis.sourceforge.net/Run_an_application_shortcut_after_an_install)), but I wonder if we really need that checkbox there at all. I know nothing about NSIS and how easy that is (what a plugin is, what would be involved in using it, or what other ways there are to do the same thing, etc.), but it seems to me that if it's not trivial to fix this we may as well just drop the box altogether.
| https://github.com/bitcoin/bitcoin/issues/7990 | https://github.com/bitcoin/bitcoin/pull/12985 | 5f2a39946fd42535038e0143cbd289d3070b9f07 | 7d8a8cc25ffd756e42d478908f14d9adf8eceed8 | 2016-05-02T17:40:22Z | c++ | 2018-04-14T07:51:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,963 | ["qa/rpc-tests/fundrawtransaction.py", "src/coincontrol.h", "src/wallet/rpcwallet.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h"] | Optional feerate option for `fundrawtransaction` | (from discussion on IRC. Currently a global `settxfee` has to be changed to override the fee rate, it would make sense to be able to specify it on a per-transaction basis. This would continue #7518)
```
-*- jonasschnelli thinks we should probably add a optional feerate parameter to fundrawtransaction
<wumpus> jonasschnelli: there isn't one yet?
-*- jonasschnelli looking..
<wumpus> I'm surprised, would be so much better than changing a global
<jonasschnelli> no.. i don't think so. Maybe there is a PR.
<sipa> there is a pr
<jonasschnelli> Hard to keep track of everything. :)
<wumpus> no, the PR does it wrong
```
Regarding implementation:
```
<jonasschnelli> The ugly thing is, that CreateTransaction uses the static DEFAULT_TARGET
<wumpus> passing in an optional feerate would be the obvious thing to do
<jonasschnelli> So, this would require some refactoring.
<sipa> just add a confirmation target to coincontrol
<jonasschnelli> Yes. This sounds good.
<wumpus> right, just slap it into coincontrol
<sipa> wasn't there a PR that added a bunch of options to fundrawtransaction?
<sipa> including that
<jonasschnelli> Not the feerate.
<jonasschnelli> But the rest is merged.
```
| https://github.com/bitcoin/bitcoin/issues/7963 | https://github.com/bitcoin/bitcoin/pull/7967 | 3b35e4896b5b8be9ffd6dacddb081f69a5b77903 | 04eaa9095813b854c4299027c595fb9ebaf6f934 | 2016-04-28T09:53:22Z | c++ | 2016-05-06T09:01:50Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,943 | ["configure.ac", "depends/packages/packages.mk", "depends/packages/zeromq.mk", "depends/patches/zeromq/9114d3957725acd34aa8b8d011585812f3369411.patch", "depends/patches/zeromq/9e6745c12e0b100cd38acecc16ce7db02905e27c.patch"] | No ZMQ on windows | I'm trying to use ZMQ notifications on windows but they don't seem to work. Even with using the zmq_sub.py script, it still doesn't work. I noticed that the help message doesn't contain the zmq stuff. Is this intentional?
| https://github.com/bitcoin/bitcoin/issues/7943 | https://github.com/bitcoin/bitcoin/pull/8238 | 8e048f40cc25b6ad3f49d2828c8562b657d91ced | a615386552f9981dc024cc4a0df758f8b0fda4d8 | 2016-04-26T02:14:14Z | c++ | 2016-07-21T08:20:17Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,901 | ["src/keystore.cpp"] | Keystore.cpp: Is locking correctly implemented here? | What happens when we interleave two threads, one calling GetPubKey() and the other RemoveWatchKey()? GetPubKey() has no locks, so if we call RemoveWatchKey() after `if (it != mapWatchKeys.end()) //line23` and before `vchPubKeyOut = it->second; //line24` there is going to be a problem.
| https://github.com/bitcoin/bitcoin/issues/7901 | https://github.com/bitcoin/bitcoin/pull/7913 | 04a29373571d44be36bd099c3b3ec3cda89e99d1 | 220f950ab1302f8f8c0bb5b9c818f3d6569796bd | 2016-04-17T12:17:14Z | c++ | 2016-04-20T13:04:28Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,890 | ["src/txdb.cpp"] | master: `gettxoutsetinfo` -> crash | Current master (73fc922ed64333d45f18d8a448f30cfa2ae0281e) crashes at the end of processing RPC `gettxoutsetinfo` on OS X:
```
$ ./bitcoind
Assertion failed: (ok), function Next, file txdb.cpp, line 139.
Abort trap: 6
$
```
| https://github.com/bitcoin/bitcoin/issues/7890 | https://github.com/bitcoin/bitcoin/pull/7904 | 73fc922ed64333d45f18d8a448f30cfa2ae0281e | a3310b4d485b1510c240f1db882530590b6fd7c9 | 2016-04-16T10:46:30Z | c++ | 2016-04-18T10:05:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,837 | ["src/rpc/net.cpp"] | `getpeerinfo` should report minping differently if there never was a ping | See discussion in #6636.
Currently, an implementation detail leaks here:
> "minping": 9223372036854.775,
This is `std::numeric_limits<int64_t>::max()` milliseconds, or approximately 300,000 years. What we really want to communicate here is that the information is missing. So it would be better to report it as `null`.
> "minping": null,
| https://github.com/bitcoin/bitcoin/issues/7837 | https://github.com/bitcoin/bitcoin/pull/7842 | 30c2dd8d0598afac9319d3a813a89a682b9c0d34 | 62a64860580253d9c733f3b8826908bba40eab1d | 2016-04-08T07:53:13Z | c++ | 2016-04-09T07:51:57Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,771 | ["src/init.cpp", "src/main.cpp", "src/net.cpp", "src/net.h", "src/rpc/net.cpp"] | Expose information on whether transaction relayed is enabled in getnetworkinfo | For software that interfaces with Bitcoin Core via RPC, it can be useful to know whether the fRelayTxes flag is set. It could be added to `getnetworkinfo`.
| https://github.com/bitcoin/bitcoin/issues/7771 | https://github.com/bitcoin/bitcoin/pull/8049 | 581ddff05c92eb835a20c2be9ccf5d2d37b94883 | 1ab1dc3140ff521df42f1f396a49a50e91bf2740 | 2016-03-30T14:10:03Z | c++ | 2016-05-12T12:26:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,745 | ["qa/rpc-tests/wallet.py"] | test: wallet reindex test has a race | It doesn't actually wait for the reindex to complete - so sometimes one gets this error, where there's no balance yet:
```
check -reindex
Assertion failed: [Decimal('33.99911100'), Decimal('5649.99796160'), Decimal('59.99974800')] != [Decimal('33.99911100'), Decimal('5649.99796160'), Decimal('0E-8')]
File "/data/src/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 135, in main
self.run_test()
File "./wallet.py", line 296, in run_test
assert_equal(balance_nodes, [self.nodes[i].getbalance() for i in range(3)])
File "/data/src/bitcoin/qa/rpc-tests/test_framework/util.py", line 428, in assert_equal
raise AssertionError("%s != %s"%(str(thing1),str(thing2)))
Stopping nodes
Cleaning up
Failed
```
The error is kind of rare as reindexing of the regtest chain is very fast.
It does seem to happen more after #7744, as it has less delay in the startup.
| https://github.com/bitcoin/bitcoin/issues/7745 | https://github.com/bitcoin/bitcoin/pull/7757 | 84370d58ffc6d5ea22efa0e579dea00f860ad369 | fa3fafc96076afb15fa77e01d5f6aff88a333a7e | 2016-03-25T15:05:23Z | c++ | 2016-03-28T19:47:42Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,718 | ["src/qt/splashscreen.cpp"] | Verifying blocks window stays open after the main GUI appears | OSX 10.11.3 running an official 0.12.0 binary.
If you minimise the 'Verifying blocks' window and wait until the GUI has fully loaded, the minimised window is still available, and it will display the same % verified as when you minimised it.
| https://github.com/bitcoin/bitcoin/issues/7718 | https://github.com/bitcoin/bitcoin/pull/8231 | 2759597bc8617039a7ffa6210f4d49a985a20093 | b3e1348c46573630e5899b53f77236fd51f78d13 | 2016-03-19T06:22:16Z | c++ | 2016-06-21T09:35:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,690 | ["qa/rpc-tests/abandonconflict.py", "src/wallet/wallet.cpp"] | unconfirmedbalance shows fake amount (50.xxxxx btcs) | Hi,
I run a bitcoin server which have acting strange the latest 3-4 days. For some reason the unconfirmed balance when running bitcoin-cli getunconfirmedbalance shows up as 50.589243 BTC which of course isn't true.
How do I reset this? Why did this occur? Tried both v0.12 and v0.12.99, same problem.
Thanks in advance,
Nori
| https://github.com/bitcoin/bitcoin/issues/7690 | https://github.com/bitcoin/bitcoin/pull/7715 | f034bced269c4859809d320dcfbdc4b008191b85 | 68d4282774d6a60c609301cddad0b652f16df4d9 | 2016-03-15T01:14:51Z | c++ | 2016-03-18T13:56:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,681 | ["doc/release-notes.md"] | End support for Windows XP and older | Drop support for Windows XP and older - at some point.
Microsoft support for Windows XP ended April 8th, 2014 (https://www.microsoft.com/en-us/WindowsForBusiness/end-of-xp-support). This means that not even critical security updates are being released anymore. This makes it dangerous to run a wallet on this OS.
There are also some strange, apparently random crashes on WinXP with 0.12, see #7674 and #7639.
I haven't heard of any reports of this happening on other versions of windows.
I hope it is possible to debug and fix this, but if not, and it turns out to be truly a WinXP only issue, we'll have to announce this through the appropriate channels.
| https://github.com/bitcoin/bitcoin/issues/7681 | https://github.com/bitcoin/bitcoin/pull/8240 | 9f1807af2422e3ac2d3702242b4a47c8df0be262 | b0be3a0186114c8f566292fc9001debcbe79a663 | 2016-03-14T12:28:06Z | c++ | 2016-06-24T16:15:01Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,678 | ["doc/release-notes.md"] | TODO for release notes 0.13.0 | Post things here that need explicit mention in 0.13 release notes
I'd strongly prefer for pulls to just update `doc/release-notes.md` directly, but if they somehow slip by, mention them here.
Summary:
- [ ] New options:
- [ ] `-maxtimeadjustment`: #7573
- [x] `-reindex-chainstate` ( Optimize reindex #7917 ) (done in #8465)
- [x] New RPC call:
- [x] `generatetoaddress`: #7671
- [x] `importprunedfunds` `removeprunedfunds`: #7558
- [x] `signmessagewithprivkey` (introduced in #7953)
- [x] Removed RPC calls:
- [x] `setgenerate` Removal of internal miner: #7663, #7507
- [x] Changed RPC calls
- [x] Output of RPC call `getrawmempool` has changed sort order (#7840)
- [x] `fundrawtransaction`: #7518 Add multiple options to fundrawtransaction
- [x] `fundrawtransaction`: #7967/#8153 add feerate option to fundrawtransaction
- [x] ARM executables have been added in #8188: need to update the release notes, as well as possibly the release process #8233
- [x] disabled mempool command when remove NODE_BLOOM support
- [x] End support for Windows XP and older #7681
| https://github.com/bitcoin/bitcoin/issues/7678 | https://github.com/bitcoin/bitcoin/pull/8240 | 9f1807af2422e3ac2d3702242b4a47c8df0be262 | b0be3a0186114c8f566292fc9001debcbe79a663 | 2016-03-14T10:44:37Z | c++ | 2016-06-24T16:15:01Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,627 | ["depends/Makefile", "depends/README.md", "depends/funcs.mk", "depends/packages/native_cctools.mk", "depends/packages/qt.mk"] | depends: Fallback mechanism may not be working properly | Today there was an issue with a corrupted boost download:
```
<MarcoFalke> of which: Fetching boost...
<MarcoFalke> % Total % Received % Xferd Average Speed Time Time Time Current
<MarcoFalke> Dload Upload Total Spent Left Speed
<MarcoFalke> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
<MarcoFalke> 100 639 100 639 0 0 2017 0 --:--:-- --:--:-- --:--:-- 2017
<MarcoFalke> sha256sum: WARNING: 1 computed checksum did NOT match
```
No indication of even trying the fallback download.
I already suspected this before with the fukushi.org certificate issue with libqrcode. The download was failing due to a certificate issue and it wasn't even trying our fallback. At least it didn't break with the `wget` -> `curl` change :-)
| https://github.com/bitcoin/bitcoin/issues/7627 | https://github.com/bitcoin/bitcoin/pull/7809 | bb717f43756cf2754b6ed6fc54d52b535ed25fb2 | 11d9f6b8b82df04e9cf0ba7d8434eaa3fe394ee5 | 2016-03-01T16:26:47Z | c++ | 2016-04-04T23:26:45Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,595 | ["contrib/README.md", "contrib/verifybinaries/README.md", "contrib/verifybinaries/verify.sh", "doc/release-notes.md", "doc/release-process.md"] | Should release-process.md still mention verify.sh? | As far as I can tell, verify.sh hasn't been updated for new Bitcoin releases in quite some time. https://github.com/bitcoin/bitcoin/issues/2504 states that verify.sh isn't supposed to guess what version to download anyway; I'm not sure if that's the current situation. However, release-process.md lists verify.sh under "Bitcoin maintainers/release engineers, update (commit) version in sources". Is that still part of the release process? If not, should release-process.md be amended to not mention verify.sh?
| https://github.com/bitcoin/bitcoin/issues/7595 | https://github.com/bitcoin/bitcoin/pull/7881 | 182bec427946d4ce951e8572130c903f0131447e | f1544700703a442191ac1dfaae7f31b04ba7b12b | 2016-02-25T01:10:06Z | c++ | 2016-04-25T11:29:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,473 | ["doc/build-unix.md"] | Depends system needs to figure more prominently in build docs | Some people have spent a lot of time figuring out how to build dependencies, or even how to cross-compile them, before realizing that the depends system makes this trivial.
This is because the documentation is a bit hidden, it is not linked from build-unix.md for example.
Also needs an example of cross-compiling, see here :https://github.com/bitcoin/bitcoin/issues/7471#issuecomment-180261245
| https://github.com/bitcoin/bitcoin/issues/7473 | https://github.com/bitcoin/bitcoin/pull/7747 | 0b98dd7939674b61c28252d14b3fbd0f51d3912b | 3e55b3a00450279522900ca96e5cf79162169019 | 2016-02-05T10:16:42Z | c++ | 2016-03-30T14:29:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,433 | ["src/init.cpp", "src/util.cpp", "src/util.h"] | Fix signal handler | The variables "[fReopenDebugLog](https://github.com/bitcoin/bitcoin/blob/fa24439ff3d8ab5b9efaf66ef4dae6713b88cb35/src/util.h#L53)" and "[fRequestShutdown](https://github.com/bitcoin/bitcoin/blob/fae78fa81802b5387054715c339f286ef436408e/src/init.cpp#L128)" should [use the data type "sig_atomic_t"](https://www.securecoding.cert.org/confluence/display/c/SIG31-C.+Do+not+access+shared+objects+in+signal+handlers) (instead of "bool").
I reported this issue for [another evolving software](https://github.com/Electric-Coin-Company/zcash/issues/678) before.
| https://github.com/bitcoin/bitcoin/issues/7433 | https://github.com/bitcoin/bitcoin/pull/8004 | 88b77c7da0a672c89e24df37ea6e9085b4e2a05c | 326231611bda6808b579ab7286e471c36f62e98c | 2016-01-28T07:24:19Z | c++ | 2016-05-09T15:20:58Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,344 | ["src/rpc/blockchain.cpp"] | gettxoutsetinfo returns empty dict on Raspberry Pi 2 | It takes from 5 (shortest) to almost 40 (longest) minutes for `bitcoin-cli gettxoutsetinfo` to return an _empty_ dict. I noticed this first whilst configuring the Statoshi branch of Bitcoin Core, but went back to install Bitcoin Core (git clone -b v0.11.2 https://github.com/bitcoin/bitcoin.git) to find the same results.
```
20:10 pi@raspinode:~/bin/bitcoin.orig $ bitcoin-cli gettxoutsetinfo
{
}
20:12 pi@raspinode:~/bin/bitcoin.orig $ bitcoin-cli getinfo
{
"version" : 110200,
"protocolversion" : 70002,
"blocks" : 393193,
"timeoffset" : 0,
"connections" : 12,
"proxy" : "",
"difficulty" : 113354299801.47113037,
"testnet" : false,
"relayfee" : 0.00005000,
"errors" : ""
}
20:17 pi@raspinode:~/bin/bitcoin.orig $
```
Raspberry Pi 2 - 1GB memory - 4 core CPU 900MHz - Blockchain on SanDisk Ultra Android microSDXC 128GB up to 80 MB/Sec Class 10
All other RPC calls through bitcoin-cli are answered promptly and correctly.
See also issue on jlopp/statoshi https://github.com/jlopp/statoshi/issues/19#issuecomment-171350739
| https://github.com/bitcoin/bitcoin/issues/7344 | https://github.com/bitcoin/bitcoin/pull/8832 | 14e8f9916bebf01d3cd6fc89c704bd870bf50760 | fa05cfdf256f3bc13b89ea80231e342f4302d204 | 2016-01-14T17:18:09Z | c++ | 2016-09-28T19:00:58Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,315 | ["src/wallet/wallet.cpp", "src/wallet/wallet.h", "test/functional/test_runner.py", "test/functional/wallet_abandonconflict.py", "test/functional/wallet_conflicts.py"] | Minor wallet issue with conflicted txs | In 0.12, a wallet tx thats not in the mempool does not free up its inputs. So if a tx spends the same inputs as a conflict tx included in a new block, its inputs are explicitly marked dirty so they will be recalculated as spendable again due to having no non-conflicted spends. However if the in-block conflict is reorged out, the wallet txs inputs should now be market spent again according to the 0.12 regime, but they are not marked dirty as the tx itself is not notified it is no longer conflicted.
This has the odd effect that the cached value is incorrect and so randomly they will be spendable or not depending on whether they have been recalculated.
This is easy enough to fix by marking all inputs of all txs in SyncTransaction dirty regardless of whether AddToWalletIfInvolvingMe returns true or false. But I'm not sure the performance impact this will have, so I'm not proposing that change now.
It's a minor issue, but I just thought I'd document that that the cached credit available in wallet txs may not always be correct.
For reference, in 0.11, whenever a tx left the mempool it's inputs were respendable. So if a tx was removed due to a conflict in a block, any remaining inputs would be spendable again. If the in-block conflict was later reorged out, the wallet txs inputs would remain spendable unless and until the wallet tx reentered the mempool.
| https://github.com/bitcoin/bitcoin/issues/7315 | https://github.com/bitcoin/bitcoin/pull/27145 | 927b001502a74a7224f04cfe6ffddc9a59409ba1 | 7d33ae755de2bff806fe600bdaebedbd7fa67aba | 2016-01-08T04:45:58Z | c++ | 2023-05-27T17:07:09Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,265 | ["Makefile.am", "configure.ac", "share/setup.nsi.in"] | setup.nsi.in has "bitcoin" and "Bitcoin Core" hardcoded a lot | https://github.com/bitcoin/bitcoin/blob/master/share/setup.nsi.in has the strings "bitcoin" and "Bitcoin Core" hardcoded in many places, even though those strings are available via autoconf. This makes it slightly more bothersome to change the name of the project, because changing the AC_INIT line in configure.ac isn't sufficient.
I don't know if this is something you want to fix in your repo, since it mostly only affects downstream projects like Namecoin. If you are interested in fixing this, I'd be happy to submit a PR.
| https://github.com/bitcoin/bitcoin/issues/7265 | https://github.com/bitcoin/bitcoin/pull/7603 | 26880c34cd3e0837724487f6b14cc3cdd7bc8a4f | 0528e30a4551d1437e049103624fd461229aced1 | 2015-12-30T19:59:08Z | c++ | 2016-04-11T04:06:59Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 7,160 | ["src/qt/bitcoingui.cpp", "src/qt/bitcoingui.h", "src/qt/forms/optionsdialog.ui", "src/qt/optionsdialog.cpp", "src/qt/optionsdialog.h", "src/qt/optionsmodel.cpp", "src/qt/optionsmodel.h"] | Option for disabling the system tray | It would be cool if there was an option in Bitcoin Core for disabling the system tray entirely.
| https://github.com/bitcoin/bitcoin/issues/7160 | https://github.com/bitcoin/bitcoin/pull/8006 | 42a67533828fe419f021d586495f8266db71b659 | 8b0e4970281de15472a93a529302f3de15163943 | 2015-12-03T10:11:28Z | c++ | 2016-05-12T02:28:02Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.