status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,337 | ["src/Makefile.test.include"] | OpenBSD 6.3 build: test/arith_uint256_tests.cpp complains about missing argument | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
<!-- Describe the issue -->
When running `gmake check`, test/arith_uint256_tests.cpp complains about missing argument.
<!--- What behavior did you expect? -->
Expected successful `gmake check` results.
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
Output from bitcoin/src/test/arith_uint256_tests.cpp.log:
```
Missing an argument value for the parameter run_test in the argument
Parameter: run_test
Filters, which test units to include or exclude from test module execution.
Command line formats:
--run_test=<test unit filter>
-t <test unit filter>
Environment variable: BOOST_TEST_RUN_FILTERS
For detailed help on Boost.Test parameters use:
test_bitcoin --help
or
test_bitcoin --help=<parameter name>
```
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
This issue occurs when running `gmake check`.
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
This issue occurs with bitcoin master version 610f4dd7
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
This issue occurs with OpenBSD 6.3 AMD64.
File [config.log](https://github.com/bitcoin/bitcoin/files/2045192/config.log) attached.
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/13337 | https://github.com/bitcoin/bitcoin/pull/13355 | 472fe8a2ce9f08f0311e4a04eef996eba19ff985 | db56755ca4a0e53785b5bf322d3b65ffe328b60a | 2018-05-28T13:18:27Z | c++ | 2018-05-31T08:30:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,303 | ["src/validation.cpp"] | GUI: ShowProgress is missing during ReplayBlocks() | During rolling forward in `ReplayBlocks()` the UI progress starts with 0 then, once sync up again, jumps to 100%. This process can take pretty long and it would be good to show some progress steps within the RollingForwardBlock loop (`for (int nHeight = nForkHeight + 1; nHeight <= pindexNew->nHeight; ++nHeight) {`) | https://github.com/bitcoin/bitcoin/issues/13303 | https://github.com/bitcoin/bitcoin/pull/13310 | 6916024768ec57a00f54224640ab4e4871d2a30a | b16ab9af07f802cc769c2443df1c637e8e12ab80 | 2018-05-22T19:27:26Z | c++ | 2018-05-23T10:53:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,299 | ["src/chain.h", "src/interfaces/wallet.cpp", "src/interfaces/wallet.h", "src/qt/bitcoingui.cpp", "src/qt/transactionrecord.cpp", "src/qt/transactionrecord.h", "src/qt/transactiontablemodel.cpp"] | wallet / qt: confirmed transaction labeled "open" | <!-- Describe the issue -->
When syncing after a period of being offline, a transaction that the wallet received during the offline period was seen in a block, and the transactions tab in the QT ui showed the transaction. However the transactions was not shown as "confirmed" but instead "open". Also, the number of confirmations seems to be incorrect.
<!--- What behavior did you expect? -->
I expected the clock icon that fills in as it downloads more blocks, followed by a check mark once it sees 6 confirmations.
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
Instead there was no icon, and a mouse-over showed "open for next 130 blocks". This confused me as the transaction wasn't a coinbase tx, didn't use op_csv or anything like that. The transaction did have a locktime, but the bitcoind wallet has been setting that for a while.
Eventually the icon switched directly to a check-mark, and a mouse-over showed the number of confirmations. However, the number of confirmations is too low by about 30 (a bit of a guess as I get tx details and then check the block height the UI reports it's synced to).
The receiving address was a bech32 native segwit v0 address, which may be related. I asked @theuni and he pointed out code around here: https://github.com/bitcoin/bitcoin/blob/048ac8326b6952244f6e4453f4f8f6ab423eb926/src/qt/transactionrecord.cpp#L177
which looks related; the ui may not be updating finality properly.
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
system:
0.16.0, linux, downloaded from bitcoincore.org, checked gpg sig.
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
Ubuntu 16.04, laptop hard drive.
This is not a huge issue but I think it could be confusing to users as it indicates that the transaction is not confirmed even though it really is. The UI eventually displays confirmed though.
| https://github.com/bitcoin/bitcoin/issues/13299 | https://github.com/bitcoin/bitcoin/pull/14556 | bfd7e5409720445b8439de20a5695b220f79f53d | fb3ce75807c50055a97f573fc72bf44d997ea218 | 2018-05-21T23:17:15Z | c++ | 2019-01-02T22:10:24Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,274 | ["src/rpc/mining.cpp"] | getblocktemplate fails in regtest mode even when it is connected to the other node | I have created two nodes and connected the 1st node with the 2nd node in regtest mode . Now when I make the getblocktemplate command using bitcoin-cli . It fails with bitcoin is downloading the block.
Bitcoin core vs v0.16
_admin1@root:~/Projects/bitcoin$ ./src/bitcoin-cli -regtest -port=8333 -rpcport=8332 -rpcuser=test -rpcpassword=test getconnectioncount_
**1**
_admin1@root:~/Projects/bitcoin$ ./src/bitcoin-cli -regtest -port=8333 -rpcport=8332 -rpcuser=test -rpcpassword=test getblocktemplate_
**error code: -10
error message:
Bitcoin is downloading blocks.** | https://github.com/bitcoin/bitcoin/issues/13274 | https://github.com/bitcoin/bitcoin/pull/15685 | 656a15e5394d8d841619b5b186fa0f9c8be0322b | fa292adce95fd5b87f76d98059c3c6e74f1dde3a | 2018-05-18T12:00:47Z | c++ | 2019-03-28T13:35:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,237 | ["src/util/system.cpp", "src/util/system.h", "src/wallet/init.cpp", "src/wallet/wallet.cpp", "test/functional/feature_notifications.py"] | [Wallet Feature Request]: Multiwallet-compatible walletnotify | Different wallets may be used for different purposes. When a notification is triggered, we get the TXID but don't know which wallet is involved. It would be useful to have different walletnotify actions depending on which wallet is involved by the transaction.
It could be used like (bitcoin.conf):
`walletnotify.walletname=action %s`
Or maybe a more simple and flexible (dynamic-wallets compatible) way:
`walletnotify=action %s %w`
where %w is the name of the wallet. This way, notify action (and not Bitcoin Core) is responsible for choosing the right action depending on the wallet and it is easier to RPC query the good wallet (ie gettransaction).
| https://github.com/bitcoin/bitcoin/issues/13237 | https://github.com/bitcoin/bitcoin/pull/13339 | 9a5b5ee81f15b1d89cb25ff3e137a672536cdc46 | 4e9efac678a9c0ea4e4c7dd956ea036ae6cf17ec | 2018-05-15T14:31:55Z | c++ | 2020-01-31T22:43:26Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,231 | ["src/qt/bitcoinamountfield.cpp"] | [gui] visual "overflow" of amount input | There is at least an annoyance in the way amount input is presented when sending coins or creating payment requests. I don't really use the GUI so I'm not sure if this happens in other places.
Here is the screenshot of both boxes when inputting the number `15`:
**note: just in case somebody wonders, the global dark theme doesn't make a differente on this; same behavior with light/default patterns.*
My **expected behavior** is that, at least, I can see the most significant digits in the amount and, at best, I can see it all when space allows it.
**What is happening is** that I input `15` and unnecessarily end up seeing `5.00000000`.
The number is complete inside the input as `15.00000000` so it is not really a functionality problem but it can be both annoying and misleading in some cases.
I can reliably reproduce this on **v0.16.0 (and master)** running on a **Fedora 27** using **GNOME 3** and **qt5**.
Tried it on an colleague's OSX and could not reproduce the issue; the input seemed fine.
I'm opening this in case it is an issue for more users. | https://github.com/bitcoin/bitcoin/issues/13231 | https://github.com/bitcoin/bitcoin/pull/13284 | d792e47421fcb9ce3b381c1e6d8902777ae3f9f3 | 5f3cbde9de842a8d565b6580c6050310d897065b | 2018-05-14T09:52:19Z | c++ | 2018-05-20T05:09:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,218 | ["src/rpc/rawtransaction_util.cpp", "test/functional/rpc_createmultisig.py"] | signrawtransactionwithkey get me confusing error message even when hash160(redeemScript) != scriptPubKey. |
signrawtransactionwithkey get me confusing error message even when hash160(redeemScript) != scriptPubKey.
Obviously `hash 160 (redeemScript)! = ScriptPubKey`
If so, why do not give me a better message?
```
signrawtransactionwithkey "0200000001cfe62b9f1c52bc2998f9a0e6d6ee35430c93ec653d5691935178147a43090fee0000000000ffffffff01f0afd320766191d4c5c088ac00000000" "[\"cSXHtKRXWnCLWhuie8WC13cKF3qdnKL8vG3BiRpxgCXZkK2CHe9u\"]" "[{\"txid\":\"ee0f09437a1478519391563d65ec930c4335eed6e6a0f99829bc521c9f2be6cf\",\"vout\":0,\"scriptPubKey\":\"a914111111111111111111111111111111111111111187\",\"redeemScript\":\"5221033d9aecbced8e776c03d283f6c0d64c6a301ad142d74d500fe8860c9b362fa4932102a4df3cb4e5286e180b7c68e323c778e32350a604d4f4a74c290d1c60c721687a52ae\"}]"
{
"hex": "0200000001cfe62b9f1c52bc2998f9a0e6d6ee35430c93ec653d5691935178147a43090fee0000000000ffffffff01f0a29a3b000000001976a9146eeff5b6a0960be69ad0941fd320766191d4c5c088ac00000000",
"complete": false,
"errors": [
{
"txid": "ee0f09437a1478519391563d65ec930c4335eed6e6a0f99829bc521c9f2be6cf",
"vout": 0,
"witness": [
],
"scriptSig": "",
"sequence": 4294967295,
**"error": "Unable to sign input, invalid stack size (possibly missing key)"**
}
]
}
signrawtransactionwithkey "0200000001cfe62b9f1c52bc2998f9a0e6d6ee35430c93ec653d5691935178147a43090fee0000000000ffffffff01f0afd320766191d4c5c088ac00000000" "[\"cSXHtKRXWnCLWhuie8WC13cKF3qdnKL8vG3BiRpxgCXZkK2CHe9u\"]" "[{\"txid\":\"ee0f09437a1478519391563d65ec930c4335eed6e6a0f99829bc521c9f2be6cf\",\"vout\":0,\"scriptPubKey\":\"a914648a73e6a0db686b547a66b7b38f3f7af61f50ae87\",\"redeemScript\":\"52211111111111111111111111111111111111111111111111111111111111111111112102a4df3cb4e5286e180b7c68e323c778e32350a604d4f4a74c290d1c60c721687a52ae\"}]"
{
"hex": "0200000001cfe62b9f1c52bc2998f9a0e6d6ee35430c93ec653d5691935178147a43090fee0000000000ffffffff01f0a29a3b000000001976a9146eeff5b6a0960be69ad0941fd320766191d4c5c088ac00000000",
"complete": false,
"errors": [
{
"txid": "ee0f09437a1478519391563d65ec930c4335eed6e6a0f99829bc521c9f2be6cf",
"vout": 0,
"witness": [
],
"scriptSig": "",
"sequence": 4294967295,
**"error": "Unable to sign input, invalid stack size (possibly missing key)"**
}
]
}
signrawtransactionwithkey "0200000001cfe62b9f1c52bc2998f9a0e6d6ee35430c93ec653d5691935178147a43090fee0000000000ffffffff01f0afd320766191d4c5c088ac00000000" "[\"cSXHtKRXWnCLWhuie8WC13cKF3qdnKL8vG3BiRpxgCXZkK2CHe9u\"]" "[{\"txid\":\"ee0f09437a1478519391563d65ec930c4335eed6e6a0f99829bc521c9f2be6cf\",\"vout\":0,\"scriptPubKey\":\"a914648a73e6a0db686b547a66b7b38f3f7af61f50ae87\",\"redeemScript\":\"5221033d9aecbced8e776c03d283f6c0d64c6a301ad142d74d500fe8860c9b362fa4932111111111111111111111111111111111111111111111111111111111111111111152ae\"}]"
{
"hex": "0200000001cfe62b9f1c52bc2998f9a0e6d6ee35430c93ec653d5691935178147a43090fee0000000000ffffffff01f0a29a3b000000001976a9146eeff5b6a0960be69ad0941fd320766191d4c5c088ac00000000",
"complete": false,
"errors": [
{
"txid": "ee0f09437a1478519391563d65ec930c4335eed6e6a0f99829bc521c9f2be6cf",
"vout": 0,
"witness": [
],
"scriptSig": "",
"sequence": 4294967295,
"error": "Unable to sign input, invalid stack size (possibly missing key)"
}
]
}
```
<What behavior did you expect?>
"error": "Unable to sign input, the scriptPubKey does not match redeemScript”
<What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? >
```
./bitcoind --version
Bitcoin Core Daemon version v0.16.99.0-81d0d565a
Copyright (C) 2009-2018 The Bitcoin Core developers
``` | https://github.com/bitcoin/bitcoin/issues/13218 | https://github.com/bitcoin/bitcoin/pull/16251 | 3c481f8921bbc587cf287329f39243abe703b868 | ec4c79326bb670c2cc1757ecfb1900f8460c5257 | 2018-05-11T16:35:44Z | c++ | 2019-09-10T05:41:50Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,213 | ["doc/release-process.md", "src/chainparams.cpp", "src/chainparams.h", "src/interfaces/node.cpp", "src/interfaces/node.h", "src/qt/intro.cpp", "src/qt/intro.h"] | [gui] MainNet and TestNet wallet shows same disk space usage | Using a Bitcoin-Qt v0.16.0 ([downloaded from bitcoin page](https://bitcoin.org/bin/bitcoin-core-0.16.0/bitcoin-0.16.0-osx.dmg)) in an macOS High Sierra 10.13.4
When I start after a fresh install Bitcoin-Qt as a mainnet node and wallet, the wallet prompt that about 203gb is going to be used in my disk
When I start the node and wallet as testnet, shows the same message about the 203gb disk usage
It seems that the second time the message is wrong, due that the testnet database uses about 14gb. | https://github.com/bitcoin/bitcoin/issues/13213 | https://github.com/bitcoin/bitcoin/pull/13216 | f504a1402afd0760e9d348ecc8bad0094aa7d705 | 9d0e52834bbd38e7c7410bcb09ef85d157968b04 | 2018-05-11T00:07:35Z | c++ | 2018-10-07T12:11:36Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,143 | ["src/util/system.cpp", "test/functional/feature_config_args.py"] | `#` cannot be used rpcpassword (or bitcoin.conf in general) | I spent hours trying to solve this bug and the solution was so simple.
My rpcpassword in my bitcoin.conf file contained a '#' character.
Prevent this from happening, by outputting this an error or warning when users run bitcoind.
Right now, you can have a # character as a password and it will work on the command line but will fail when you JSON-RPC. | https://github.com/bitcoin/bitcoin/issues/13143 | https://github.com/bitcoin/bitcoin/pull/14494 | 13fe258e91e7a92326aedf151c571994166a06d4 | 0385109444646561a718f34ae437b7e0e4d4d5bc | 2018-05-01T22:04:27Z | c++ | 2018-11-05T23:35:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,110 | ["src/wallet/wallet.cpp"] | 0.16.0 bitcoin-qt: "Assertion `copyFrom' failed" during launch | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
During startup of bitcoint-qt version 0.16.0
```
$ ./bitcoin-qt
```
the following assertion is triggered:
```
bitcoin-qt: wallet/wallet.cpp:542: void CWallet::SyncMetaData(std::pair<std::_Rb_tree_iterator<std::pair<const COutPoint, uint256> >, std::_Rb_tree_iterator<std::pair<const COutPoint, uint256> > >): Assertion `copyFrom' failed.
```
The issue reliably reproduces with 0.16.0 when using the same `~/.bitcoin` directory that was used without problems in 0.15.1. Relaunching 0.15.1 instead of 0.16.0 gives no assertion failure and still works without any issue.
A (stripped down) [debug.log](https://github.com/bitcoin/bitcoin/files/1958057/debug.log) is attached here. The log really ends at `2018-04-28 17:21:47 init message: Loading wallet...` (which seems consistent with the assertion failure).
`bitcoin.conf` is an empty, zero byte file.
This machine runs (K)Ubuntu 17.04. CPU is an AMD A6-7400K Radeon R5, 6 Compute Cores 2C+4G. Disk is an Intel 512 GB 545s SSD.
Bitcoin Core 0.15.1 was downloaded from [https://bitcoin.org/bin/bitcoin-core-0.15.1/bitcoin-0.15.1-x86_64-linux-gnu.tar.gz](https://bitcoin.org/bin/bitcoin-core-0.15.1/bitcoin-0.15.1-x86_64-linux-gnu.tar.gz) if I recall correctly.
Bitcoin Core 0.16.0 was downloaded from [https://bitcoincore.org/bin/bitcoin-core-0.16.0/bitcoin-0.16.0-x86_64-linux-gnu.tar.gz](https://bitcoincore.org/bin/bitcoin-core-0.16.0/bitcoin-0.16.0-x86_64-linux-gnu.tar.gz).
Note that those are *not* versions from the Ubuntu repositories/the Ubuntu specific downloads.
<!--- What behavior did you expect? -->
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/13110 | https://github.com/bitcoin/bitcoin/pull/13265 | 1b53e4f67c6dbefadbfda7e40948840fe2b9da48 | b0d2ca9fb66d793e3c0f2e6ede811f1b16c33a9f | 2018-04-28T19:01:50Z | c++ | 2018-05-17T20:07:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,087 | ["doc/release-notes-pr13381.md", "src/wallet/rpcdump.cpp", "test/functional/test_runner.py", "test/functional/wallet_import_with_label.py"] | importprivkey unsets labels set with importaddress and importpubkey | ### Expected behavior:
1. `importaddress` or `importpubkey` a watching-only address or pubkey with a label
2. Receive a transaction to that address; observe that the label has been applied to that transaction
3. `importprivkey` the private key for that address without specifying any change to the label
4. Have the previous label still applied to the transaction after the import.
### Observed behavior on 0.15 and current master:
Steps 1-3 the same.
4. Previous label is replaced with the default empty label ("")
Problem seems to have occurred on 0.15 and affects the latest master (see subsequent details). I'd suspect all versions are affected, i.e. it's not a regression.
### Steps to reproduce
```bash
## For testing
ADDRESS=2N6Y2wdhd91mQnZ8qCeH6hT5aZZygXFnNjP
PRIVKEY=cQriWp98xU9ghRvDKbzkRcgcecQLezjYwtPUjLNN5kzT8GbdnxQt
## Starting a fresh regtest (i.e. ~/.bitcoin/regtest/ previously deleted)
$ bitcoind -daemon -regtest
Bitcoin server starting
## Import the address with a label and no rescan
$ bitcoin-cli -regtest importaddress $ADDRESS "Watch-only test" false
## Mine a generation tx to the address (regular spending works too)
$ bitcoin-cli -regtest generatetoaddress 1 $ADDRESS > /dev/null
## Bury the generation tx so it shows up in the wallet
$ bitcoin-cli -regtest generate 100 > /dev/null
## See that the address label was applied to the tx
$ bitcoin-cli -regtest listunspent | jq .[].label
"Watch-only test"
## Import the private key. Note the 'label' parameter is not explicitly passed
$ bitcoin-cli -regtest importprivkey $PRIVKEY
## See that the address label has been set to empty :-(
$ bitcoin-cli -regtest listunspent | jq .[].label
```
Same thing happens if `importpubkey` is substituted for `importaddress`. I haven't tested `importmulti` for either address/pubkey or privkey import, nor have I tested using named parameters.
### Use case
I was watching-only addresses from my cold wallet, then moved my coins to new addresses and (after some confirmations) imported the old private keys so that I could sell fork coins. I didn't realize until now when I was trying to do some bookkeeping that all my old cold wallet labels were reset (happily, I have backups, so nothing is lost but time).
### Possibly related issues
- #12698 looks related but the poster there says that it works on mainnet. I discovered my problem from actual use on mainnet and reproduced on regtest. | https://github.com/bitcoin/bitcoin/issues/13087 | https://github.com/bitcoin/bitcoin/pull/13381 | f504a1402afd0760e9d348ecc8bad0094aa7d705 | a6b5ec18ff39ef3ccd19ec0e6db9ae00602d8938 | 2018-04-26T09:58:31Z | c++ | 2018-10-05T12:33:21Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,038 | ["src/net.cpp"] | faulty network activity disable | The network activity disable feature does not disable network activity. After clicking the tray icon to disable network activity, network connections establish and are used to transfer data as normal. I have only verified this with bitcoin-qt on Ubuntu 16.04.4 LTS and Tails (multiple versions). I've witnessed this happen for clearnet and onion peers.
I have verified that this affects versions Bitcoin Core version v0.16.0 (release build) and the latest commit 8b262eb2d80bfa27ae8501078ce47bc1407e9c55 on master (IIRC, I saw this in earlier release builds too).
To reproduce:
Note: the first two steps may not be strictly necessary, but they definitely seem to help reproduce.
1. use slow storage attached via usb (e.g.- 7200 RPM drive inside a 2.5" SATA external case attached via USB 3)
1. let node fall behind (only a day at most, less likely works) and then attempt to resync
1. start node with: `$ /path/to/bitcoin-0.16.0/bin/bitcoin-qt -datadir=/path/to/bitcoin-unpruned-txindex-datadir -txindex &`
1. wait until you see some established peers on the peers tab in the GUI
1. click the icon in the tray of the main GUI window to disable network activity
1. go back to the peers tab and witness peers establish and transfer data. sometimes this happens immediately, sometimes it takes a few seconds. usually around a minute at most.
relevant debug.log data from 3 separate runs:
```
2018-04-20 09:17:34 Bitcoin Core version v0.16.0 (release build)
...
2018-04-20 09:17:40 Loaded best chain: hashBestChain=0000000000000000000fff915fac685a3fae643481b9f6c31e3f78b1078b45c3 height=518957 date=2018-04-19 13:41:01 progress=0.999206
...
2018-04-20 09:17:45 Leaving InitialBlockDownload (latching to false)
2018-04-20 09:17:46 New outbound peer connected: version: 70015, blocks=519094, peer=1
2018-04-20 09:17:46 New outbound peer connected: version: 70015, blocks=519094, peer=2
2018-04-20 09:17:55 P2P peers available. Skipped DNS seeding.
2018-04-20 09:17:55 dnsseed thread exit
<I CLICK THE NETWORK ACTIVITY DISABLE ICON IN THE TRAY OF THE GUI A THE EXISTING CONNECTIONS DROP>
2018-04-20 09:18:04 GUI: QAccessibleTable::child: Invalid index at: 1 0
2018-04-20 09:18:04 GUI: Cannot creat accessible child interface for object: QTableView(0x5581864bb410, name = "peerWidget") index: 15
2018-04-20 09:18:04 GUI: QAccessibleTable::child: Invalid index at: 1 0
2018-04-20 09:18:04 GUI: Cannot creat accessible child interface for object: QTableView(0x5581864bb410, name = "peerWidget") index: 15
2018-04-20 09:18:04 GUI: QAccessibleTable::child: Invalid index at: 1 0
2018-04-20 09:18:04 GUI: Cannot creat accessible child interface for object: QTableView(0x5581864bb410, name = "peerWidget") index: 15
2018-04-20 09:18:12 Pre-allocating up to position 0x900000 in rev01238.dat
2018-04-20 09:18:13 UpdateTip: new best=0000000000000000004782f61ebc39c514c61298efbdc720e440e3dd060352f0 height=518958 version=0x20000000 log2_work=88.623783 tx=311123210 date='2018-04-19 13:44:25' progress=0.999208 cache=0.8MiB(6207txo)
<A NEW OUTBOUND CONNECTION APPEARS WHILE NETWORK ACTIVITY IS DISABLED>
2018-04-20 09:18:13 New outbound peer connected: version: 70015, blocks=519094, peer=3
2018-04-20 09:18:29 UpdateTip: new best=0000000000000000002cc47e2cf4a8a89934c53a02dc1af3b60cbaea609014a2 height=518959 version=0x20000000 log2_work=88.623833 tx=311126085 date='2018-04-19 13:48:14' progress=0.999211 cache=2.3MiB(16786txo)
...
-------------------------------------------------------------------------------
build of latest master commit 8b262eb2d80bfa27ae8501078ce47bc1407e9c55
2018-04-20T09:27:30Z Bitcoin Core version v0.16.99.0-8b262eb (debug build)
...
2018-04-20T09:27:50Z Loaded best chain: hashBestChain=0000000000000000002fd17d46ed1edaae01f8fc5178e4c0496de19683e005cf height=518970 date=2018-04-19T14:52:28Z progress=0.999248
...
2018-04-20T09:29:38Z Leaving InitialBlockDownload (latching to false)
2018-04-20T09:29:39Z New outbound peer connected: version: 70015, blocks=519095, peer=2
<I CLICK THE NETWORK ACTIVITY DISABLE ICON IN THE TRAY OF THE GUI A THE EXISTING CONNECTIONS DROP>
2018-04-20T09:29:42Z GUI: QAccessibleTable::child: Invalid index at: 0 0
2018-04-20T09:29:42Z GUI: Cannot creat accessible child interface for object: QTableView(0x55ab174e0430, name = "peerWidget") index: 8
2018-04-20T09:29:42Z GUI: QAccessibleTable::child: Invalid index at: 0 0
2018-04-20T09:29:42Z GUI: Cannot creat accessible child interface for object: QTableView(0x55ab174e0430, name = "peerWidget") index: 8
2018-04-20T09:29:42Z UpdateTip: new best=0000000000000000000479596f8cfc32e69aca978bde18c0b9f8488175c88e3e height=518985 version=0x20000000 log2_work=88.625129 tx=311166856 date='2018-04-19T17:25:26Z' progress=0.999350 cache=11.9MiB(89599txo)
<A NEW OUTBOUND CONNECTION APPEARS WHILE NETWORK ACTIVITY IS DISABLED>
2018-04-20T09:29:42Z New outbound peer connected: version: 70014, blocks=519095, peer=3
2018-04-20T09:29:45Z UpdateTip: new best=000000000000000000096f1f7ffadf6c6659e2d19e560620a9fa239eed24e709 height=518986 version=0x20000000 log2_work=88.625179 tx=311167660 date='2018-04-19T17:30:02Z' progress=0.999353 cache=12.1MiB(91409txo)
...
-------------------------------------------------------------------------------
2018-04-20T09:37:01Z Bitcoin Core version v0.16.99.0-8b262eb (debug build)
...
2018-04-20T09:37:18Z Loaded best chain: hashBestChain=000000000000000000168d1a7a70cbbf09be99e34a1a6130288841e9af22eaf5 height=519006 date=2018-04-19T20:37:24Z progress=0.999474
...
2018-04-20T09:37:25Z Leaving InitialBlockDownload (latching to false)
...
<I CLICK THE NETWORK ACTIVITY DISABLE ICON IN THE TRAY OF THE GUI A THE EXISTING CONNECTIONS DROP>
2018-04-20T09:38:46Z GUI: QAccessibleTable::child: Invalid index at: 0 0
2018-04-20T09:38:46Z GUI: Cannot creat accessible child interface for object: QTableView(0x555adccbe010, name = "peerWidget") index: 8
2018-04-20T09:38:46Z GUI: QAccessibleTable::child: Invalid index at: 0 0
2018-04-20T09:38:46Z GUI: Cannot creat accessible child interface for object: QTableView(0x555adccbe010, name = "peerWidget") index: 8
2018-04-20T09:38:46Z UpdateTip: new best=0000000000000000003a72ecf9917c77dcac8fe801d80d06441b741f78ceaeca height=519076 version=0x20000000 log2_work=88.629657 tx=311270831 date='2018-04-20T05:40:59Z' progress=0.999840 cache=28.2MiB(214661txo)
2018-04-20T09:38:47Z UpdateTip: new best=000000000000000000320678c480f530b0e9557b5a294f336c11f652f7324c35 height=519077 version=0x20000000 log2_work=88.629707 tx=311271189 date='2018-04-20T05:44:03Z' progress=0.999842 cache=28.3MiB(215532txo)
<A NEW OUTBOUND CONNECTION APPEARS WHILE NETWORK ACTIVITY IS DISABLED>
2018-04-20T09:39:58Z New outbound peer connected: version: 70016, blocks=517884, peer=8
2018-04-20T09:39:59Z ERROR: AcceptBlockHeader: Consensus::ContextualCheckBlockHeader: 0000000000009c1b89b75b834c923e3c0302f0d79aeac29681e820f977ddd0d6, bad-diffbits, incorrect proof of work (code 16)
``` | https://github.com/bitcoin/bitcoin/issues/13038 | https://github.com/bitcoin/bitcoin/pull/13212 | 1c582503507b72306be1355738f1d853e499bd15 | 793290f940a9af18d4f0292a263d976a066dff65 | 2018-04-20T10:08:58Z | c++ | 2018-06-21T17:24:48Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 13,006 | ["test/functional/p2p_invalid_tx.py", "test/functional/test_framework/test_node.py"] | RFC: assert_debug_log | This idea came up in conversation last night and two people told me it was terrible, so I was curious to try a wider audience. Idea would be to have an `assert_debug_log(node, regex)` function in python.
Example use:
```python
self.nodes[0].p2p.send_txs([tx_orphan_invalid])
with assert_debug_log(self.nodes[0], "invalid orphan tx %s" % txid(tx_orphan_invalid)):
self.nodes[0].p2p.send_txs([tx_orphan_parent])
```
Possible implementation:
```python
@contextmanager
def assert_debug_log(node, pattern, **other_options):
prev_size = node.rpc.flush_debug_log()
try:
yield
finally:
new_size = node.rpc.flush_debug_log()
with open(node.datadir_path("debug.log")) as log:
log.seek(prev_size)
if not re.match(pattern, log.read(new_size - prev_size)):
raise AssertionError
```
Advantages:
- Log asserts could make existing tests simpler, more robust, and more readable because they would allow tests to check conditions they care about directly instead of reverse engineering node behaviour with counters and flags and inferences from p2p messages and disconnects.
- Log asserts could improve test coverage. Lots of PRs are currently created that fix bugs and change behavior and have 0 accompanying tests because they would be difficult to write in the c++ test framework, and unreliable in the python framework.
Disadvantages:
- Log asserts could be overused to check conditions that would be better to interrogate more directly.
- Log asserts could be overused to check behaviours that shouldn't be checked at all because they are implementation specific.
- Log asserts could be overused to check trivial things not worth checking given the relative expense (performance, code verbosity, cost of maintaining fragile string comparisons).
- Log asserts could encourage writing integration tests when unit tests would be more appropriate.
- Log asserts could encourage writing white box tests when black box tests would be more appropriate.
- Log asserts could encourage using the python test framework instead of the c++ framework.
Conclusion:
I think `assert_debug_log` could simplify existing tests, fill a gap in the testing framework, and help move closer to a world where PRs that change internal bitcoin behaviour more typically come with tests. I think `assert_debug_log` could be overused, but in practice this could be avoided with code review and documentation. More abstract concerns like white box vs black box, unit vs functional, and python vs c++ testing tend to come off a bit superstitious and cargo-culty to me so I'm not the best person to respond to them, but I wouldn't discourage other discussion in such terms. | https://github.com/bitcoin/bitcoin/issues/13006 | https://github.com/bitcoin/bitcoin/pull/14024 | 17d644901bbd770578619545bbd8bc930fe6f2d9 | fa3e9f7627784ee00980590e5bf044a0e1249999 | 2018-04-17T11:32:27Z | c++ | 2018-08-24T16:30:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,995 | ["test/config.ini.in", "test/functional/rpc_users.py"] | Need test for rpcauth.py | There is no test for the `share/rpcauth/rpcauth.py` script, there should be one, and it should be part of travis.
| https://github.com/bitcoin/bitcoin/issues/12995 | https://github.com/bitcoin/bitcoin/pull/13024 | 615f7c288414a89cd1dec1d67e0f84abe2fb4c6d | 8b8032e283ae1dff00de71e2d9d28c0df626fc23 | 2018-04-16T14:31:35Z | c++ | 2018-04-22T22:32:58Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,989 | ["src/rpc/rawtransaction.cpp", "src/wallet/rpcwallet.cpp", "test/functional/rpc_psbt.py"] | Problem with decoding transaction | <!-- Describe the issue -->
I have a problem with decoding transaction on testnet.
I call method getrawtransaction for txhash f0a1d41cb2d1cea36b334c77f90f1a88b0f01332fffefaac3be9bb77f5b5f5b6
But then I call the decoderawtransaction it returns another txid in decoded transaction data: 22519827b1dc985ed4d0115e58c3f327a60e44015c8499ff3c5bc7fe5a8ce3f0
<!--- What behavior did you expect? -->
I expect that txid in both cases should be the same
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
It occurs everytime, on two different machines
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
Bitcoin Core RPC client version v0.16.0.0-g4b4d7eb255
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
Ubuntu linux 16.04, i7-2600 CPU
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
```
genosse@local:~$ bitcoin-cli -testnet getrawtransaction f0a1d41cb2d1cea36b334c77f90f1a88b0f01332fffefaac3be9bb77f5b5f5b6
02000000000101c79161617adc1cad419254fd0194193dd6786a7faf1f65df9b3a369e8e600a3c0000000000ffffffff017b134c000000000016001443aac20a116e09ea4f7914be1c55e4c17aa600b70248304502210087116858148c7f4e33c05881103444ae5d67b1b5fd922ca18c00127c9683c4a502206ede2a47953942365a01fb772d2644dcfa59968fcece1caa305d8235557b0456012103335134d7414e1d1a154600b124a96f5ef2c6ca21434d2622469a96bd5262fd5600000000
genosse@local:~$ bitcoin-cli -testnet decoderawtransaction 02000000000101c79161617adc1cad419254fd0194193dd6786a7faf1f65df9b3a369e8e600a3c0000000000ffffffff017b134c000000000016001443aac20a116e09ea4f7914be1c55e4c17aa600b70248304502210087116858148c7f4e33c05881103444ae5d67b1b5fd922ca18c00127c9683c4a502206ede2a47953942365a01fb772d2644dcfa59968fcece1caa305d8235557b0456012103335134d7414e1d1a154600b124a96f5ef2c6ca21434d2622469a96bd5262fd5600000000
{
"txid": "22519827b1dc985ed4d0115e58c3f327a60e44015c8499ff3c5bc7fe5a8ce3f0",
"hash": "22519827b1dc985ed4d0115e58c3f327a60e44015c8499ff3c5bc7fe5a8ce3f0",
"version": 2,
"size": 192,
"vsize": 192,
"locktime": 0,
"vin": [
],
"vout": [
{
"value": 20796716866.05686529,
"n": 0,
"scriptPubKey": {
"asm": "9254fd0194193dd6786a7faf1f65df9b3a369e8e600a3c0000000000ffffffff017b134c000000000016001443aac20a116e09ea4f7914be1c55e4c17aa600b702 304502210087116858148c7f4e33c05881103444ae5d67b1b5fd922ca18c00127c9683c4a502206ede2a47953942365a01fb772d2644dcfa59968fcece1caa305d8235557b045601 03335134d7414e1d1a154600b124a96f5ef2c6ca21434d2622469a96bd5262fd56",
"hex": "419254fd0194193dd6786a7faf1f65df9b3a369e8e600a3c0000000000ffffffff017b134c000000000016001443aac20a116e09ea4f7914be1c55e4c17aa600b70248304502210087116858148c7f4e33c05881103444ae5d67b1b5fd922ca18c00127c9683c4a502206ede2a47953942365a01fb772d2644dcfa59968fcece1caa305d8235557b0456012103335134d7414e1d1a154600b124a96f5ef2c6ca21434d2622469a96bd5262fd56",
"type": "nonstandard"
}
}
]
}
```
```
genosse@local:~$ bitcoin-cli -testnet getrawtransaction d259c4573cffb992df4c864c8fb172fb934e83ce3fa58e5fabb16bccfc59e273
02000000000101d3171d300fefb4ada940a7e6b4411391909908838db0532db8cd90b36367407a0000000000ffffffff0106ea4b000000000016001435600b44f82d414e451a4d5ed2e23e7f38a0de3502483045022100da76f404dfe7d29e8283f715509a2bbec14a4fbb13603d374f760c1da6b67705022017c15cad3e1420369e6734bbdc158f58cf07f4e4afe4f854ce9a11dfaefe6d00012102192a09100e62eefcf1b6b6ed4d6c81e3b95d29f6c2f8cb39841a8158e41d0d6600000000
genosse@local:~$ raw=02000000000101d3171d300fefb4ada940a7e6b4411391909908838db0532db8cd90b36367407a0000000000ffffffff0106ea4b000000000016001435600b44f82d414e451a4d5ed2e23e7f38a0de3502483045022100da76f404dfe7d29e8283f715509a2bbec14a4fbb13603d374f760c1da6b67705022017c15cad3e1420369e6734bbdc158f58cf07f4e4afe4f854ce9a11dfaefe6d00012102192a09100e62eefcf1b6b6ed4d6c81e3b95d29f6c2f8cb39841a8158e41d0d6600000000
genosse@local:~$ bitcoin-cli -testnet decoderawtransaction $raw
{
"txid": "a4d7ce0d0df329bc697a85c9f1108a4466d765a123b8a35e4ba835fd57346649",
"hash": "a4d7ce0d0df329bc697a85c9f1108a4466d765a123b8a35e4ba835fd57346649",
"version": 2,
"size": 192,
"vsize": 192,
"locktime": 0,
"vin": [
],
"vout": [
{
"value": -54090879281.27728895,
"n": 0,
"scriptPubKey": {
"asm": "OP_HASH160 a7e6b4411391909908838db0532db8cd90b36367407a0000000000ffffffff0106ea4b000000000016001435600b44f82d414e451a4d5ed2e23e7f38a0de3502 3045022100da76f404dfe7d29e8283f715509a2bbec14a4fbb13603d374f760c1da6b67705022017c15cad3e1420369e6734bbdc158f58cf07f4e4afe4f854ce9a11dfaefe6d0001 02192a09100e62eefcf1b6b6ed4d6c81e3b95d29f6c2f8cb39841a8158e41d0d66",
"hex": "a940a7e6b4411391909908838db0532db8cd90b36367407a0000000000ffffffff0106ea4b000000000016001435600b44f82d414e451a4d5ed2e23e7f38a0de3502483045022100da76f404dfe7d29e8283f715509a2bbec14a4fbb13603d374f760c1da6b67705022017c15cad3e1420369e6734bbdc158f58cf07f4e4afe4f854ce9a11dfaefe6d00012102192a09100e62eefcf1b6b6ed4d6c81e3b95d29f6c2f8cb39841a8158e41d0d66",
"type": "nonstandard"
}
}
]
}
``` | https://github.com/bitcoin/bitcoin/issues/12989 | https://github.com/bitcoin/bitcoin/pull/15899 | fa5c5cd141f0265a5693234690ac757b811157d8 | fa499b5f027f77c0bf13699852c8c06f78e27bef | 2018-04-15T15:52:08Z | c++ | 2019-05-16T19:56:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,978 | ["src/validation.cpp", "src/validationinterface.cpp"] | p2p_compactblocks.py failing occasionally on master | Reported here https://github.com/bitcoin/bitcoin/pull/12629#issuecomment-381095603 by @Empact. I've seen it now in a few different travis jobs, including:
https://travis-ci.org/bitcoin/bitcoin/jobs/366157920
https://travis-ci.org/bitcoin/bitcoin/jobs/366139851
From my initial investigation it seems like there may be an actual bug in block announcement, so I'm opening this issue to track. | https://github.com/bitcoin/bitcoin/issues/12978 | https://github.com/bitcoin/bitcoin/pull/12988 | 5f2a39946fd42535038e0143cbd289d3070b9f07 | d86edd3d3093be4c00d2c6a6fde6dfa77e2f4855 | 2018-04-13T15:47:11Z | c++ | 2018-04-16T22:03:21Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,961 | ["src/rpc/mining.cpp", "src/test/util_tests.cpp", "src/wallet/test/coinselector_tests.cpp"] | 979f598: Clang Static Analyzer Report | BRANCH: master
COMMIT: 979f59850c72624137d25f80be4188c3ba6b5fa0
ISSUE COUNT: 16 [11 unconfirmed, 5 pending fix]
EXCLUDED: nothing
SUPERCEDES: #9573
ANALYZER BUILD: checker-279 (2016-11-14 15:34:09)
This report includes upstream repositories (leveldb, secp256k1). We may not want to fix them, but we should at least know about them, in case they cause issues. I can provide detailed reports for any of these, on request (see example of such a report for the `rpc/mining.cpp` error below).
DISCLAIMER: These results have not been thoroughly confirmed, and may be improbable or flat out invalid, but it's worth having a list of these somewhere.
# BITCOIN CORE [4 issues]
## LOGIC ERRORS [1 present, 1 confirmed]:
* [src/rpc/mining.cpp:652:39](https://github.com/bitcoin/bitcoin/blob/master/src/rpc/mining.cpp#L652): Called C++ object pointer is null ([see report](https://bc-2.jp/paths/report-1056de.html)) (RESOLVED BY #12963)
```C++
result.pushKV("mintime", (int64_t)pindexPrev->GetMedianTimePast()+1);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
## DEAD STORE [2 present, 2 confirmed]:
* [src/test/util_tests.cpp:952:13](https://github.com/bitcoin/bitcoin/blob/master/src/test/util_tests.cpp#L952): Value stored to 'rv' is never read (RESOLVED BY #12963)
```C++
rv = write(fd, &ch, 1);
^ ~~~~~~~~~~~~~~~~~
```
* [src/wallet/test/coinselector_tests.cpp:550:9](https://github.com/bitcoin/bitcoin/blob/master/src/wallet/test/coinselector_tests.cpp#L550): Value stored to 'target' is never read (RESOLVED BY #12963)
```C++
target = 0;
^ ~
```
## MEMORY ERROR [1 present, 0 confirmed]:
* [src/httpserver.cpp:606:15](https://github.com/bitcoin/bitcoin/blob/master/src/httpserver.cpp#L606): Potential leak of memory pointed to by 'ev'
```C++
replySent = true;
~~~~~~~~~~^~~~~~
```
# LEVELDB [4 issues]
## LOGIC ERRORS [1 present, 1 confirmed]:
* [src/leveldb/port/port_posix.cc:60:15](https://github.com/bitcoin/bitcoin/blob/master/src/leveldb/port/port_posix.cc#L60): The left operand of '&' is a garbage value (RESOLVED BY https://github.com/bitcoin-core/leveldb/pull/16)
```C++
return (ecx & (1 << 20)) != 0;
~~~ ^
```
## DEAD STORE [3 present, 0 confirmed]:
* [src/leveldb/db/log_reader.cc:42:5](https://github.com/bitcoin/bitcoin/blob/master/src/leveldb/db/log_reader.cc#L42): Value stored to 'offset_in_block' is never read
```C++
offset_in_block = 0;
^ ~
```
* [src/leveldb/db/log_reader.cc:103:13](https://github.com/bitcoin/bitcoin/blob/master/src/leveldb/db/log_reader.cc#L103): Value stored to 'in_fragmented_record' is never read
```C++
in_fragmented_record = false;
^ ~~~~~
```
* [src/leveldb/db/log_reader.cc:121:13](https://github.com/bitcoin/bitcoin/blob/master/src/leveldb/db/log_reader.cc#L121): Value stored to 'in_fragmented_record' is never read
```C++
in_fragmented_record = false;
^ ~~~~~
```
# SECP256K1 [8 issues]
## LOGIC ERRORS [7 present, 0 confirmed]:
* [src/field_5x52_impl.h:406:13](https://github.com/bitcoin/bitcoin/blob/master/src/secp256k1/src/field_5x52_impl.h#L406): Assigned value is garbage or undefined
```C
r->n[0] += a->n[0];
^ ~~~~~~~
```
* [src/field_5x52_impl.h:390:13](https://github.com/bitcoin/bitcoin/blob/master/src/secp256k1/src/field_5x52_impl.h#L390): The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage
```C
r->n[0] *= a;
~~~~~~~ ^
```
* [src/field_5x52_impl.h:406:13](https://github.com/bitcoin/bitcoin/blob/master/src/secp256k1/src/field_5x52_impl.h#L406): The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage
```C
r->n[0] += a->n[0];
~~~~~~~ ^
```
* [src/util.h:24:5](https://github.com/bitcoin/bitcoin/blob/master/src/secp256k1/src/util.h#L24): Access to field 'fn' results in a dereference of a null pointer (loaded from variable 'cb')
```C
cb->fn(text, (void*)cb->data);
^~~~~~
```
* [src/scalar_4x64_impl.h:60:20](https://github.com/bitcoin/bitcoin/blob/master/src/secp256k1/src/scalar_4x64_impl.h#L60): The left operand of '<' is a garbage value
```C
no |= (a->d[3] < SECP256K1_N_3); /* No need for a > check. */
~~~~~~~ ^
```
* [src/ecmult_impl.h:217:12](https://github.com/bitcoin/bitcoin/blob/master/src/secp256k1/src/ecmult_impl.h#L217): Access to field 'pre_g' results in a dereference of a null pointer (loaded from variable 'ctx')
```C
return ctx->pre_g != NULL;
^~~~~~~~~~
```
* [src/ecmult_gen_impl.h:95:12](https://github.com/bitcoin/bitcoin/blob/master/src/secp256k1/src/ecmult_gen_impl.h#L95): Access to field 'prec' results in a dereference of a null pointer (loaded from variable 'ctx')
```C
return ctx->prec != NULL;
^~~~~~~~~
```
## DEAD STORE [1 present, 1 confirmed]
* [src/ecmult_gen_impl.h:153:5](https://github.com/bitcoin/bitcoin/blob/master/src/secp256k1/src/ecmult_gen_impl.h#L153): Value stored to 'bits' is never read (RESOLVED BY https://github.com/bitcoin-core/secp256k1/pull/485)
```C
bits = 0;
^ ~
```
| https://github.com/bitcoin/bitcoin/issues/12961 | https://github.com/bitcoin/bitcoin/pull/12963 | fd447a6efea84d7215ab471bf04284f060e9e3c3 | 159c32d1f111e6bad490bd23ae215462e8ba4374 | 2018-04-12T02:25:24Z | c++ | 2018-04-12T12:37:53Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,915 | ["src/util.cpp"] | Segmentation fault in util: ScheduleBatchPriority | Steps to reproduce:
```
git checkout 7e23972d1f715f596e61e6e3775a3ada75604497
./configure --with-sanitizers=address --disable-wallet
make
./test/functional/wallet_disable.py
2018-04-08T14:57:23.371000Z TestFramework (INFO): Initializing test directory /tmp/testuzxdpst_
ASAN:DEADLYSIGNAL
=================================================================
==5106==ERROR: AddressSanitizer: SEGV on unknown address 0x0000000002d0 (pc 0x7f72043a1d38 bp 0x7f71f1578cd0 sp 0x7f71f1578c70 T14)
==5106==The signal is caused by a READ memory access.
==5106==Hint: address points to the zero page.
#0 0x7f72043a1d37 in __pthread_setschedparam (/lib64/libpthread.so.0+0x8d37)
#1 0x555fc43c5577 in ScheduleBatchPriority() /home/marco/workspace/bitcoin/src/util.cpp:1048
#2 0x555fc3a2cca1 in ThreadImport(std::vector<boost::filesystem::path, std::allocator<boost::filesystem::path> >) /home/marco/workspace/bitcoin/src/init.cpp:635
#3 0x555fc3a9fd50 in void boost::_bi::list1<boost::_bi::value<std::vector<boost::filesystem::path, std::allocator<boost::filesystem::path> > > >::operator()<void (*)(std::vector<boost::filesystem::path, std::allocator<boost::filesystem::path> >), boost::_bi::list0>(boost::_bi::type<void>, void (*&)(std::vector<boost::filesystem::path, std::allocator<boost::filesystem::path> >), boost::_bi::list0&, int) /usr/include/boost/bind/bind.hpp:259
#4 0x555fc3a9fd50 in boost::_bi::bind_t<void, void (*)(std::vector<boost::filesystem::path, std::allocator<boost::filesystem::path> >), boost::_bi::list1<boost::_bi::value<std::vector<boost::filesystem::path, std::allocator<boost::filesystem::path> > > > >::operator()() /usr/include/boost/bind/bind.hpp:1294
#5 0x555fc3a9fd50 in boost::detail::thread_data<boost::_bi::bind_t<void, void (*)(std::vector<boost::filesystem::path, std::allocator<boost::filesystem::path> >), boost::_bi::list1<boost::_bi::value<std::vector<boost::filesystem::path, std::allocator<boost::filesystem::path> > > > > >::run() /usr/include/boost/thread/detail/thread.hpp:116
#6 0x7f7205bf730c (/lib64/libboost_thread.so.1.64.0+0x1330c)
#7 0x7f72043a050a in start_thread (/lib64/libpthread.so.0+0x750a)
#8 0x7f72040d816e in clone (/lib64/libc.so.6+0xf516e)
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV (/lib64/libpthread.so.0+0x8d37) in __pthread_setschedparam
Thread T14 (bitcoin-loadblk) created by T0 here:
#0 0x7f72064d9a2f in pthread_create (/lib64/libasan.so.4+0x37a2f)
#1 0x7f7205bf5fd9 in boost::thread::start_thread_noexcept() (/lib64/libboost_thread.so.1.64.0+0x11fd9)
==5106==ABORTING
| https://github.com/bitcoin/bitcoin/issues/12915 | https://github.com/bitcoin/bitcoin/pull/12923 | cff66e6a29d700188f6ecebeaacc8bcaa1fc1095 | b86730a4d74471378fbafb2bac9839110f520b76 | 2018-04-08T15:32:16Z | c++ | 2018-04-09T15:02:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,903 | ["src/crypto/sha256.cpp"] | Check for AVX | https://github.com/bitcoin/bitcoin/blob/5f0c6a7b0e47e03f848dc992d37fe209dd9c6975/src/crypto/sha256.cpp#L183
This checks whether the CPU supports SSE4. It should also check if the OS supports SSE4. See this [StackOverflow answer](https://stackoverflow.com/a/22521619/6557621). | https://github.com/bitcoin/bitcoin/issues/12903 | https://github.com/bitcoin/bitcoin/pull/13471 | 4a7e64fc85461a205f2b51da52d1455795d43b91 | 32d153fa360f73b4999701b97d55b12318fd2659 | 2018-04-06T14:45:11Z | c++ | 2018-06-18T21:55:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,863 | ["doc/REST-interface.md", "src/init.cpp", "src/rpc/blockchain.cpp", "src/txmempool.cpp", "src/txmempool.h", "src/validation.cpp", "src/validation.h", "test/functional/mempool_persist.py"] | mempool_persist.py failing in travis | Reported here: https://github.com/bitcoin/bitcoin/pull/10244#issuecomment-378035305
Travis log here: https://travis-ci.org/bitcoin/bitcoin/jobs/361243719#L2810
Note the JSON exception:
```
test_framework.authproxy.JSONRPCException: The mempool was not loaded yet (-1)
```
That exception was introduced here: https://github.com/bitcoin/bitcoin/commit/cb1e319fe9e198c9c5cf5236fe9af5a3d748b9e8#diff-a0c8f511d90e83aa9b5857e819ced344R1617
cc @jtimon | https://github.com/bitcoin/bitcoin/issues/12863 | https://github.com/bitcoin/bitcoin/pull/15323 | bb8ae2c41941d0776968f75cec0de89247e952dc | effe81f7503d2ca3c88cfdea687f9f997f353e0d | 2018-04-02T20:47:03Z | c++ | 2019-03-22T09:31:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,838 | ["src/qt/bitcoingui.cpp"] | QT: double click bitcoin icon on the task bar with setting 'minimize to the tray' cause a blank window | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
double click bitcoin icon on the task bar with setting 'minimize to the tray' cause a blank window
<!--- What behavior did you expect? -->
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/12838 | https://github.com/bitcoin/bitcoin/pull/12999 | 0d6992168c2bda85b18fda8f6dea08da433a0dc9 | 67bf2aa68eaa4502c8c11541e3f39b0372e95bf8 | 2018-03-30T09:30:24Z | c++ | 2018-04-16T18:38:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,835 | ["test/functional/test_framework/test_framework.py"] | Metaclass for BitcoinTestFramework | I'm new to bitcoin coming from a Python background. Wrapping my head around your test suite, I noticed that the base framework test class makes comments about how subclasses **should** override `set_test_params` and `run_test` but **should not** override `__init__` or `main`:
https://github.com/bitcoin/bitcoin/blob/3b62a913865777426c11992bae622fb48aa72a40/test/functional/test_framework/test_framework.py#L44
To make that more explicit, have we considered a meta class to actually check that those assumptions are valid instead of leaving it to the user to read the docstring and follow the rules?
I've provided a sample implementation in the details below, where the commented methods would raise an error if included in any module. Happy to submit a PR if you think it is worth pursuing.
<details>
```python
class BitcoinTestMetaclass(type):
def __new__(cls, clsname, bases, dct):
if not ('run_test' in dct and 'set_test_params' in dct):
raise TypeError("BitcoinTestFramework subclasses must override "
"'run_test' and 'set_test_params'")
if '__init__' in dct or 'main' in dct:
raise TypeError("BitcoinTestFramework subclasses may not override "
"'__init__' or 'main'")
return super().__new__(cls, clsname, bases, dct)
class BitcoinTestFramework(metaclass=BitcoinTestMetaclass):
def set_test_params(self):
...
def run_test(self):
...
'''
class BadSubclass1(BitcoinTestFramework):
"""Doesn't subclass run_test"""
def set_test_params(self):
pass
'''
'''
class BadSubclass2(BitcoinTestFramework):
"""Overrides set_test_params and run_test, but also overrides __init__"""
def __init__(self):
super().__init__()
def set_test_params(self):
pass
def run_test(self):
pass
'''
class GoodSubclass(BitcoinTestFramework):
def set_test_params(self):
pass
def run_test(self):
pass
```
| https://github.com/bitcoin/bitcoin/issues/12835 | https://github.com/bitcoin/bitcoin/pull/12856 | 9a2db3b3d511b34489c3cda78d8b80f39e5ade0f | c9cce0a7f66e5abe6a94704eb478e0dc52a29f13 | 2018-03-30T07:37:54Z | c++ | 2018-04-05T01:09:05Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,828 | ["src/init.cpp"] | Strange -blocksdir behavior | A bit late to the party, but I just tried #12653 and noticed some non-intuitive behavior (on macOS), that's probably worth explaining release notes and help.
Before this new feature I kept the entire datadir on an SSD drive, so I launch with: `bitcoind -datadir=/Volumes/SSD/Bitcoin`.
Initially I naively moved `/Volumes/SSD/Bitcoin/blocks` to `/Users/bitcoin/blocks` and added a line to `/Volumes/SSD/Bitcoin/bitcoin.conf`: `blocksdir=/Users/bitcoin/blocks`.
I then realized that I shouldn't have moved the `index` subdirectory, so I moved that back to `/Volumes/SSD/Bitcoin/blocks/index`. Having an empty `blocks` dir with just and `index` subdir is a bit weird. Perhaps after @jimpo's #11857 is merged, we could just move / assume all indexes to be there (if `-blocksdir` is set)?
Worse, it created a directory `/Users/bitcoin/blocks/blocks`, which seems like a bug. I had to set `blocksdir=/Users/bitcoin` instead. | https://github.com/bitcoin/bitcoin/issues/12828 | https://github.com/bitcoin/bitcoin/pull/14364 | 011c39c2969420d7ca8b40fbf6f3364fe72da2d0 | ccc27bdcd2d91fe2c023ad004019d5b970f21dbf | 2018-03-29T12:52:58Z | c++ | 2019-01-18T04:44:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,794 | ["src/qt/walletmodel.cpp"] | multiwallet in GUI `.dat` gets dropped, leads to bug and ambiguity | relayed here and copied below: https://github.com/bitcoin/bitcoin/pull/12610#issuecomment-376278677
this logic here means that anytime we do a wallet match on rpc debug console, it will not find the wallet unless it has no `.dat` extension: 3dba3c3#diff-8c9d79ba40bf702f01685008550ac100R491
This also means you can load two wallets(eg `wallet.dat` and `wallet`), and they will look the same in the drop down selector.
imo if we're supporting arbitrary filename extensions we should just display the entire name | https://github.com/bitcoin/bitcoin/issues/12794 | https://github.com/bitcoin/bitcoin/pull/12795 | c948dc8f4285e27d8c0f3553d9d427b2a7b01b77 | fc7c32fc68f2c2618644f9bea6176c63940706b3 | 2018-03-26T19:17:28Z | c++ | 2018-03-26T19:25:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,768 | ["test/functional/feature_fee_estimation.py", "test/functional/feature_pruning.py"] | [tests] Fix block size config in feature_fee_estimation.py, feature_maxuploadtarget.py and feature_pruning.py | #11100 broke the `-blockmaxsize` config, which these tests use.
Fix the tests by adding the appropriate `-blockmaxweight` config to the nodes in those tests.
(Note that #12756 removes the ignored `-blockmaxsize` config) | https://github.com/bitcoin/bitcoin/issues/12768 | https://github.com/bitcoin/bitcoin/pull/12790 | ec7dbaa37c233599e9fc68f8284ee85c1261652b | b466f6be959b25f3a07cede9f03563ed0bbda0fa | 2018-03-23T13:37:49Z | c++ | 2018-03-26T15:53:58Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,703 | ["doc/release-notes-14454.md", "src/wallet/rpcdump.cpp", "src/wallet/rpcwallet.cpp", "test/functional/test_framework/blocktools.py", "test/functional/wallet_importmulti.py"] | rpc: importmulti improvements | Some comments from @sipa in #12702.
___
Yes, I think `importmulti` is superior in every way, except:
* Slightly less convenient to use (it requires redundant information, as you have to explicitly state what you want to import, and then give the keys/... to enable that).
* ~Doesn't support P2SH-P2WPKH yet~. Added in #14454
The latter can be fixed by just adding support for that case. The former can be improved by adding 'default' cases (e.g. if you prove a WIF private key, it can permit omitting the address, ...).
| https://github.com/bitcoin/bitcoin/issues/12703 | https://github.com/bitcoin/bitcoin/pull/14454 | 201451b1ca3c6db3b13f9491a81db5b120b864bb | c11875c5908a17314bb38caa911507dc6401ec49 | 2018-03-16T01:50:55Z | c++ | 2018-10-24T20:30:57Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,688 | ["src/qt/transactionrecord.cpp", "src/qt/transactiontablemodel.cpp"] | Transactions GUI list does not show a transaction from self to self+foreign | For a certain transaction structure the GUI does not show all transactions that occurred.
Perform the following transaction structure to reproduce the bug:
Input: Any owned coins
Output 1: Address not owned by the wallet
Output 2: Address owned by the wallet (generated using the receive payment feature, so it's not a change address)
So there is a payment to someone else and a payment to self. The payment to self is missing in the GUI. Normally, the GUI does list payments to self.
`listtransactions` lists 3 transactions here: The send to the foreign address and a send/receive pair for the payment to self. I don't know if this is correct. I'm mentioning this so that the devs can make sure this is intended.
See transaction `5299f198919d6bd5b9f6d7a5f256b23417cb49ea663828f51cfc1b4d7e69822d` on testnet.
| https://github.com/bitcoin/bitcoin/issues/12688 | https://github.com/bitcoin/bitcoin/pull/15098 | 1d73636fdf1ef85c1f62841953e1cf01a6c3bfd0 | 11fdfcf7f940fab48625d102e825a59c16ad4fbc | 2018-03-14T17:35:41Z | c++ | 2019-01-06T09:52:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,640 | ["doc/release-notes.md", "src/init.cpp", "src/miner.cpp", "test/functional/feature_fee_estimation.py", "test/functional/feature_maxuploadtarget.py", "test/functional/feature_pruning.py"] | blockmaxsize parameter has no effect | Since #11100, in init.cpp `-blockmaxsize` is translated to `-blockmaxweight` with the code:
```
unsigned int max_size = gArgs.GetArg("-blockmaxsize", 0);
if (gArgs.SoftSetArg("blockmaxweight", strprintf("%d", max_size * WITNESS_SCALE_FACTOR))) {
```
However SoftSetArg requires the argument to be specified with the leading dash (ie, as `SoftSetArg("-blockmaxweight")`) without the dash the value will not be looked up later (because the later lookups specify it with a dash).
Obvious fix is just to add the dash (`SoftSetArg("-blockmaxweight", ...)`), but if there haven't been any complaints, just removing the option entirely might be better, since current behaviour is the same as if the option is just removed.
I believe this applies to master, 0.16 and 0.15 (due to backport via #11592).
Test case to demonstrate:
```
#!/usr/bin/env python3
"""Test limiting maxblocksize"""
from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import *
class MaxBlockSizeTest(BitcoinTestFramework):
def set_test_params(self):
self.num_nodes = 2
self.extra_args = [["-blockmaxweight=40000"], ["-blockmaxsize=10000"]]
def run_test(self):
chain_height = self.nodes[0].getblockcount()
assert_equal(chain_height, 200)
self.nodes[0].generate(100)
self.nodes[1].generate(100)
self.nodes[0].generate(100) # unspendable
blk = [None,None]
for n in [0,1]:
vsize = 0
address = self.nodes[n].getnewaddress()
txes = 0
while vsize*4 < 84000:
txid = self.nodes[n].sendtoaddress(address, 0.25)
tx = self.nodes[n].getrawtransaction(txid, 1)
vsize += tx["vsize"]
txes += 1
self.nodes[n].generate(1)
blk[n] = self.nodes[n].getblock(self.nodes[n].getbestblockhash())
self.sync_all()
assert blk[0]["weight"] <= 40000, "blockmaxweight greater than 40000"
assert blk[1]["size"] <= 10000 or blk[1]["weight"] <= 40000, "blockmaxsize is greater than 10000"
if __name__ == '__main__':
MaxBlockSizeTest().main()
```
Cc @jnewbery (who picked this up via an assertion failure in #11862) @TheBlueMatt (who did the original PR) | https://github.com/bitcoin/bitcoin/issues/12640 | https://github.com/bitcoin/bitcoin/pull/12756 | a6926b065d654a448937f9f1e2999ac48d50a984 | 4757c04cb98df2ab3a54c7e33ff9af3b1f7dc78b | 2018-03-07T21:54:12Z | c++ | 2018-03-22T14:28:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,623 | ["src/qt/optionsmodel.cpp"] | gui: default port not shown correctly in settings dialog | 
Using 20e3b9a485fd6b23785c5caa49d01ea49fdc8bcf. Should obviously be 9050, not %2. | https://github.com/bitcoin/bitcoin/issues/12623 | https://github.com/bitcoin/bitcoin/pull/12650 | 048ac8326b6952244f6e4453f4f8f6ab423eb926 | 40c58866c7e7af3582cefb9b1810a20902e44167 | 2018-03-06T21:14:17Z | c++ | 2018-04-10T20:22:55Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,602 | [".gitignore", "Makefile.am", "configure.ac"] | lcov usage fails with clang | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
<!--- What behavior did you expect? -->
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
When attempting to generate coverage information with `make cov` after configuring and building with clang, lcov/gcov (for the versions I'm using) are unable to parse the generated gcda files:
```
/home/james/tmp/bitcoin/src/libbitcoin_server_a-miner.gcno:version '402*', prefer 'A72*'
geninfo: ERROR: GCOV failed for /home/james/tmp/bitcoin/src/libbitcoin_server_a-miner.gcda!
Makefile:1269: recipe for target 'test_bitcoin.info' failed
```
We may need to special-case the effects of `--enable-lcov` when building with clang to use flags and commands mentioned [here](http://logan.tw/posts/2015/04/28/check-code-coverage-with-clang-and-lcov/).
### Configure output
```
Options used to compile and link:
with wallet = yes
with gui / qt = yes
qt version = 5
with qr = auto
with zmq = yes
with test = yes
with bench = yes
with upnp = auto
use asm = yes
debug enabled = no
werror = no
target os = linux
build os =
CC = /usr/bin/clang-4.0
CFLAGS = -g -O2
CPPFLAGS = -I/home/james/tmp/bitcoin/db4/include/ -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS
CXX = /usr/bin/clang++-4.0 -std=c++11
CXXFLAGS = -std=c++11 -std=c++11 --coverage -Og
LDFLAGS = -L/home/james/tmp/bitcoin/db4/lib/ --coverage
ARFLAGS = cr
```
### Versions
```
$ clang++-4.0 --version
clang version 4.0.1-6 (tags/RELEASE_401/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
$ lcov --version
lcov: LCOV version 1.13
$ gcov --version
gcov (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or
FITNESS FOR A PARTICULAR PURPOSE.
```
### `make cov` failure
```
$ make cov
...
/usr/bin/lcov --gcov-tool=/usr/bin/gcov -c -d /home/james/tmp/bitcoin/src -t test_bitcoin -o test_bitcoin.info
Capturing coverage data from /home/james/tmp/bitcoin/src
Found gcov version: 7.2.0
Scanning /home/james/tmp/bitcoin/src for .gcda files ...
Found 290 data files in /home/james/tmp/bitcoin/src
Processing src/libbitcoin_server_a-miner.gcda
/home/james/tmp/bitcoin/src/libbitcoin_server_a-miner.gcno:version '402*', prefer 'A72*'
geninfo: ERROR: GCOV failed for /home/james/tmp/bitcoin/src/libbitcoin_server_a-miner.gcda!
Makefile:1269: recipe for target 'test_bitcoin.info' failed
make: *** [test_bitcoin.info] Error 29
rm test_bitcoin.info baseline_filtered.info baseline.info
```
| https://github.com/bitcoin/bitcoin/issues/12602 | https://github.com/bitcoin/bitcoin/pull/19688 | 13c4635a3ecfbc6759301fb3c94bd5293c49388c | 038a04eb80a5d3c731ffdbc7d855aced50270eed | 2018-03-05T15:32:38Z | c++ | 2020-08-12T20:21:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,511 | ["contrib/gitian-build.sh", "contrib/gitian-descriptors/gitian-linux.yml", "contrib/gitian-descriptors/gitian-osx-signer.yml", "contrib/gitian-descriptors/gitian-osx.yml", "contrib/gitian-descriptors/gitian-win-signer.yml", "contrib/gitian-descriptors/gitian-win.yml"] | Switch to Ubuntu 18.04 for gitian building | For 0.17 we should aim to use Ubuntu 18.04 for building. This will be the new LTS release of Ubuntu.
We skipped 16.04 because of problems with the windows binary (#8732) but this was solved in 16.10, so ruling out new issues, the way should be clear.
This means finally building with a new C++ compiler, binutils, etc. Also this will solve a known security issue with the NSIS windows installer. | https://github.com/bitcoin/bitcoin/issues/12511 | https://github.com/bitcoin/bitcoin/pull/13171 | c0f1569557eccf4e3be6a13aaf1ad1810c98e598 | c1afe3232fa10e290fb355cf37ea4c7bc1084065 | 2018-02-22T19:35:15Z | c++ | 2018-07-16T10:42:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,505 | ["src/wallet/init.cpp", "test/functional/wallet_multiwallet.py"] | Bad interaction of -zapwallettxes and pruning / multiwallet | After some googling, I recently ran `bitcoin-qt -zapwallettxes` on a 0.15.1 pruned multiwallet node in order to remove a stuck transaction from the transaction list, without fully understanding what I was doing. After running the command and realizing what I'd done, I was surprised to learn
1. The operation succeeded without warning despite the fact I was running a multiwallet configuration
2. The operation succeeded without warning even though I was running a pruned node. Meaning I now had to re-download and verify the full blockchain to get my wallets' transactions back
3. The software made no wallet backups despite the destructive nature of the operation
After some poking around in the code a bit it appears there are safeguards against 1 and 2, but they didn't trigger in this case. Maybe because my pruning and wallet options were being set via bitcoin.conf instead of the command line?
<!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
<!--- What behavior did you expect? -->
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
<!-- Any extra information that might be useful in the debugging process. -->
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
| https://github.com/bitcoin/bitcoin/issues/12505 | https://github.com/bitcoin/bitcoin/pull/13030 | 3476e3c48b34034cefb7058b3f8ea9d13296f5f0 | 1f838394bfd87cc9b28229824568b1d767e8ed6f | 2018-02-21T20:41:33Z | c++ | 2018-04-19T15:13:47Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,502 | ["src/Makefile.am", "src/outputtype.cpp", "src/outputtype.h", "src/rpc/misc.cpp", "src/wallet/init.cpp", "src/wallet/rpcwallet.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h", "test/functional/rpc_createmultisig.py", "test/functional/test_runner.py"] | [RPC] createmultisig does not respect `-addresstype` | addmultisigaddress creates an address respecting the setting, being unable to generate a specific type of address without also adding it to the wallet seems wrong.
I suppose in the future `addresstype` may be refactored to be wallet-specific, which would leave this non-wallet rpc call without an argument. Perhaps there should just be an optional parameter to set it. | https://github.com/bitcoin/bitcoin/issues/12502 | https://github.com/bitcoin/bitcoin/pull/13072 | b9024fdda33e5c7a2e61705822ded034dd4f8e3b | f40b3b82dfe873dd55ee24f4d6dec5d43756260a | 2018-02-21T16:04:04Z | c++ | 2018-07-09T14:09:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,488 | ["src/qt/guiutil.cpp"] | bitcoin-qt opens the wrong conf file. | v0.15.1 release.
`bitcoin-qt` opens the wrong conf file when a conf file is specified with `-conf={file}`
Key:
>bitcoin-qt -conf=altconf.conf
Go to: Settings --> Options --> Open Configuration File --> OK
Editor opens with `default.conf` instead. Should open specified conf, also using `-datadir={folder path}` parameter which I have not checked. | https://github.com/bitcoin/bitcoin/issues/12488 | https://github.com/bitcoin/bitcoin/pull/12489 | 8a98dfeebf58b8fc9b7c966ae0f99ad0760d7800 | a6e6e39a8baf0756240427cc5dc5fce5aea51f0d | 2018-02-20T09:56:37Z | c++ | 2018-02-20T10:05:03Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,462 | ["test/functional/test_framework/util.py"] | rpc_bind.py is broken | Broken in #12200. Dropping that commit fixes it.
Full details in the PR. | https://github.com/bitcoin/bitcoin/issues/12462 | https://github.com/bitcoin/bitcoin/pull/12464 | 59e032b43cea835cf06f83a5a72685dc02033c48 | df47afb60070defaaee519ee39e82bd3d1c73491 | 2018-02-16T20:47:41Z | c++ | 2018-02-16T20:59:34Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,423 | ["src/wallet/scriptpubkeyman.cpp", "src/wallet/scriptpubkeyman.h", "src/wallet/walletdb.cpp"] | initial walletpassphrase slow and freezing | When running walletpassphrase on a large wallet.dat (ie about 300,000 segwit P2SH addresses) the command sometimes takes a very long time, and if command is run multiple times at once (while running slow) it causes bitcoin core to freeze (stops syncing and requires kill -9 to stop/restart)
During the locked up walletpassphrase commands being run the following messages start to appear in the debug.log:
`018-01-24 01:01:04 socket sending timeout: 1201s`
Note that this problem is intermittent, so sometimes the command runs instantly, other times it takes a few minutes, and other times it completely freezes the node. | https://github.com/bitcoin/bitcoin/issues/12423 | https://github.com/bitcoin/bitcoin/pull/16946 | 4479eb04d92806633aa3ad3e413f6a7166863638 | 9abed46871a7f44277a0a59c645a8593ce9e5628 | 2018-02-13T12:36:59Z | c++ | 2020-05-21T18:50:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,418 | ["src/rpc/rawtransaction.cpp"] | signrawtransaction unable to sign p2sh-segwit multisig transaction | I'm working on a [paper multisig system](https://glacierprotocol.org), improving it to use p2sh-segwit instead of legacy p2sh. I'm using my own Linux build of Bitcoin Core tag v0.16.0rc3 and using bitcoin-cli to build transactions.
I used `addmultisigaddress` to create a 2-of-4 p2sh-segwit address and funded it on testnet. I created a transaction to spend those coins using `createrawtransaction` and I'm attempting to sign it.
# Actual behavior
If I provide no keys to `signrawtransaction` and let it use the wallet keys, everything works. But if I provide the keys explicitly, I get the error: "Unable to sign input, invalid stack size (possibly missing key)".
# Expected behavior
I expect `signrawtransaction` to be able to sign the transaction using the explicltly-provided keys. (For a paper wallet, the bitcoind wallet will not know the keys or the multisig address.)
This flow works as expected when I use type 'legacy' for the `addmultisigaddress`. It fails when I use type 'p2sh-segwit'.
My guess is that it assumes it's legacy p2sh and therefore the signature fails. Shouldn't bitcoind be able to figure out (based on the scriptPubKey and the redeemScript) that this is p2sh-segwit, and construct the appropriate signatures? Or is there a different/better way to use the CLI to accomplish this?
# To recreate
[This script](https://pastebin.com/2KLHkV9Y) shows the problem. The final `signrawtransaction` step should succeed. [[output]](https://pastebin.com/k5wwERLG)
# Ugly workaround
I could use `addmultisigaddress` to teach the wallet about the p2sh-segwit address, and `importprivkey` to teach it 2-of-4 keys, then use `signrawtransaction` without providing any keys. [This](https://pastebin.com/MMJhWCfP) seems to work [[output]](https://pastebin.com/M5gw7FkG) but is very ugly because at the time of signing, I only have 2 of 4 keys, so in order to run `addmultisigaddress` I have to decode the redeemScript and parse its "asm" field to find the 4 pubkeys.
# Related
Somewhat related issue, never merged: issue #11693 and its associated PR #11708
| https://github.com/bitcoin/bitcoin/issues/12418 | https://github.com/bitcoin/bitcoin/pull/12427 | 252ae7111cbff09a4cbc5caee9e02b6ed3580476 | 5f605e172baee35421eb20736601befdd8cad796 | 2018-02-12T23:25:28Z | c++ | 2018-02-14T01:37:47Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,413 | ["src/test/util_tests.cpp", "src/util.cpp", "src/util.h"] | Bitcoin fails to build on OpenBSD 6.2 | <!-- This issue tracker is only for technical issues related to Bitcoin Core.
General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->
<!-- Describe the issue -->
gmake fails to compile bitcoin from source for commits 8470e6472 or newer on OpenBSD 6.2.
<!--- What behavior did you expect? -->
Expected successful gmake exit.
<!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->
gmake exits with 3 errors:
```
3 errors generated.
gmake[2]: *** [Makefile:6149: libbitcoin_util_a-util.o] Error 1
gmake[2]: Leaving directory '/home/bitcoin/bitcoin/src'
gmake[1]: *** [Makefile:9417: all-recursive] Error 1
gmake[1]: Leaving directory '/home/bitcoin/bitcoin/src'
gmake: *** [Makefile:745: all-recursive] Error 1
```
Full output is given below.
<!--- How reliably can you reproduce the issue, what are the steps to do so? -->
This error always occurs when following the instructions in /doc/build-openbsd.md using bitcoin sources from commits 8470e6472 and newer.
However, when compiling bitcoin source using commit 7f81250 on the same system, gmake successfully completes.
<!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->
This error occurs using bitcoin sources from commits 8470e6472 and newer.
<!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->
OpenBSD 6.2 amd64
<!-- Any extra information that might be useful in the debugging process. -->
gmake-4.2.1
autoconf-2.69.p2
automake-1.15.1
boost-1.58.0p8
Bitcoin source information for the attached output:
```
commit fe53d5f3636aed064823bc220d828c7ff08d1d52 (HEAD -> master, origin/master, origin/HEAD)
Merge: 948c29cc0 464015f6f
Author: MarcoFalke <[email protected]>
Date: Sat Feb 10 09:47:21 2018 -0500
```
Configured using:
```
./configure --with-gui=no CC=cc CXX=c++ \
BDB_LIBS="-L${BDB_PREFIX}/lib -ldb_cxx-4.8" \
BDB_CFLAGS="-I${BDB_PREFIX}/include"
```
```
Options used to compile and link:
with wallet = yes
with gui / qt = no
with zmq = no
with test = yes
with bench = yes
with upnp = auto
use asm = yes
debug enabled = no
werror = no
target os =
build os =
CC = cc
CFLAGS = -g -O2
CPPFLAGS = -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS
CXX = c++ -std=c++11
CXXFLAGS = -g -O2 -Wall -Wextra -Wformat -Wvla -Wformat-security -Wthread-safety-analysis -Wno-unused-parameter -Wno-self-assign -Wno-unused-local-typedef -Wno-deprecated-register -Wno-implicit-fallthrough
LDFLAGS =
ARFLAGS = cr
```
<!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->
gmake output:
```
$ Making all in src
gmake[1]: Entering directory '/home/bitcoin/bitcoin/src'
gmake[2]: Entering directory '/home/bitcoin/bitcoin/src'
CXX crypto/libbitcoinconsensus_la-aes.lo
CXX crypto/libbitcoinconsensus_la-chacha20.lo
CXX crypto/libbitcoinconsensus_la-hmac_sha256.lo
CXX crypto/libbitcoinconsensus_la-hmac_sha512.lo
CXX crypto/libbitcoinconsensus_la-ripemd160.lo
CXX crypto/libbitcoinconsensus_la-sha1.lo
CXX crypto/libbitcoinconsensus_la-sha256.lo
CXX crypto/libbitcoinconsensus_la-sha512.lo
CXX crypto/libbitcoinconsensus_la-sha256_sse4.lo
CXX libbitcoinconsensus_la-arith_uint256.lo
CXX consensus/libbitcoinconsensus_la-merkle.lo
CXX libbitcoinconsensus_la-hash.lo
CXX primitives/libbitcoinconsensus_la-block.lo
CXX primitives/libbitcoinconsensus_la-transaction.lo
CXX libbitcoinconsensus_la-pubkey.lo
CXX script/libbitcoinconsensus_la-bitcoinconsensus.lo
CXX script/libbitcoinconsensus_la-interpreter.lo
CXX script/libbitcoinconsensus_la-script.lo
CXX script/libbitcoinconsensus_la-script_error.lo
CXX libbitcoinconsensus_la-uint256.lo
CXX libbitcoinconsensus_la-utilstrencodings.lo
gmake[3]: Entering directory '/home/bitcoin/bitcoin/src/secp256k1'
gcc -I. -g -O2 -Wall -Wextra -Wno-unused-function -c src/gen_context.c -o gen_context.o
gcc gen_context.o -o gen_context
./gen_context
CC src/libsecp256k1_la-secp256k1.lo
CCLD libsecp256k1.la
gmake[3]: Leaving directory '/home/bitcoin/bitcoin/src/secp256k1'
CXXLD libbitcoinconsensus.la
*** Warning: This system can not link to static lib archive secp256k1/libsecp256k1.la.
*** I have the capability to make that library automatically link in when
*** you link to this library. But I can only do this if you have a
*** shared version of the library, which you do not appear to have.
CXX bitcoind-bitcoind.o
CXX libbitcoin_server_a-addrdb.o
CXX libbitcoin_server_a-addrman.o
CXX libbitcoin_server_a-bloom.o
CXX libbitcoin_server_a-blockencodings.o
CXX libbitcoin_server_a-chain.o
CXX libbitcoin_server_a-checkpoints.o
CXX consensus/libbitcoin_server_a-tx_verify.o
CXX libbitcoin_server_a-httprpc.o
CXX libbitcoin_server_a-httpserver.o
CXX libbitcoin_server_a-init.o
CXX libbitcoin_server_a-dbwrapper.o
CXX libbitcoin_server_a-merkleblock.o
CXX libbitcoin_server_a-miner.o
CXX libbitcoin_server_a-net.o
CXX libbitcoin_server_a-net_processing.o
CXX libbitcoin_server_a-noui.o
CXX policy/libbitcoin_server_a-fees.o
CXX policy/libbitcoin_server_a-policy.o
CXX policy/libbitcoin_server_a-rbf.o
CXX libbitcoin_server_a-pow.o
CXX libbitcoin_server_a-rest.o
CXX rpc/libbitcoin_server_a-blockchain.o
CXX rpc/libbitcoin_server_a-mining.o
CXX rpc/libbitcoin_server_a-misc.o
CXX rpc/libbitcoin_server_a-net.o
CXX rpc/libbitcoin_server_a-rawtransaction.o
CXX rpc/libbitcoin_server_a-safemode.o
CXX rpc/libbitcoin_server_a-server.o
CXX script/libbitcoin_server_a-sigcache.o
CXX script/libbitcoin_server_a-ismine.o
CXX libbitcoin_server_a-timedata.o
CXX libbitcoin_server_a-torcontrol.o
CXX libbitcoin_server_a-txdb.o
CXX libbitcoin_server_a-txmempool.o
CXX libbitcoin_server_a-ui_interface.o
CXX libbitcoin_server_a-validation.o
CXX libbitcoin_server_a-validationinterface.o
CXX libbitcoin_server_a-versionbits.o
AR libbitcoin_server.a
CXX libbitcoin_common_a-base58.o
CXX libbitcoin_common_a-bech32.o
CXX libbitcoin_common_a-chainparams.o
CXX libbitcoin_common_a-coins.o
CXX libbitcoin_common_a-compressor.o
CXX libbitcoin_common_a-core_read.o
CXX libbitcoin_common_a-core_write.o
CXX libbitcoin_common_a-key.o
key.cpp:51:23: warning: comparison of integers of different signs: 'long' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
if (end - privkey < lenb) {
~~~~~~~~~~~~~ ^ ~~~~
key.cpp:57:23: warning: comparison of integers of different signs: 'long' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
if (end - privkey < len) {
~~~~~~~~~~~~~ ^ ~~~
key.cpp:71:37: warning: comparison of integers of different signs: 'long' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
if (oslen > 32 || end - privkey < oslen) {
~~~~~~~~~~~~~ ^ ~~~~~
3 warnings generated.
CXX libbitcoin_common_a-keystore.o
CXX libbitcoin_common_a-netaddress.o
CXX libbitcoin_common_a-netbase.o
CXX policy/libbitcoin_common_a-feerate.o
CXX libbitcoin_common_a-protocol.o
CXX libbitcoin_common_a-scheduler.o
CXX script/libbitcoin_common_a-sign.o
CXX script/libbitcoin_common_a-standard.o
CXX libbitcoin_common_a-warnings.o
AR libbitcoin_common.a
gmake[3]: Entering directory '/home/bitcoin/bitcoin/src/univalue'
CXX lib/libunivalue_la-univalue.lo
CXX lib/libunivalue_la-univalue_get.lo
CXX lib/libunivalue_la-univalue_read.lo
CXX lib/libunivalue_la-univalue_write.lo
CXXLD libunivalue.la
gmake[3]: Leaving directory '/home/bitcoin/bitcoin/src/univalue'
CXX support/libbitcoin_util_a-lockedpool.o
CXX libbitcoin_util_a-chainparamsbase.o
CXX libbitcoin_util_a-clientversion.o
CXX compat/libbitcoin_util_a-glibc_sanity.o
CXX compat/libbitcoin_util_a-glibcxx_sanity.o
CXX compat/libbitcoin_util_a-strnlen.o
CXX libbitcoin_util_a-fs.o
CXX libbitcoin_util_a-random.o
CXX rpc/libbitcoin_util_a-protocol.o
CXX rpc/libbitcoin_util_a-util.o
CXX support/libbitcoin_util_a-cleanse.o
CXX libbitcoin_util_a-sync.o
CXX libbitcoin_util_a-threadinterrupt.o
CXX libbitcoin_util_a-util.o
In file included from util.cpp:6:
In file included from ./util.h:18:
In file included from ./fs.h:9:
In file included from /usr/include/c++/v1/string:442:
In file included from /usr/include/c++/v1/algorithm:633:
/usr/include/c++/v1/utility:330:5: error: the parameter for this explicitly-defaulted copy constructor is const, but a member or base requires it to be non-const
pair(pair const&) = default;
^
util.cpp:384:121: note: in instantiation of template class 'std::__1::pair<const std::__1::basic_string<char>, boost::interprocess::file_lock>' requested here
boost::interprocess::file_lock& lock = locks.emplace(pathLockFile.string(), pathLockFile.string().c_str()).first->second;
^
In file included from util.cpp:6:
In file included from ./util.h:18:
In file included from ./fs.h:9:
In file included from /usr/include/c++/v1/string:442:
In file included from /usr/include/c++/v1/algorithm:633:
/usr/include/c++/v1/utility:330:5: error: the parameter for this explicitly-defaulted copy constructor is const, but a member or base requires it to be non-const
pair(pair const&) = default;
^
/usr/include/c++/v1/map:627:21: note: in instantiation of template class 'std::__1::pair<std::__1::basic_string<char>, boost::interprocess::file_lock>' requested here
__nc_value_type __nc;
^
/usr/include/c++/v1/__tree:754:23: note: in instantiation of template class 'std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock>' requested here
__node_value_type __value_;
^
/usr/include/c++/v1/__tree:1789:49: note: in instantiation of template class 'std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock>, void *>' requested here
destroy(static_cast<__node_pointer>(__nd->__left_));
^
/usr/include/c++/v1/__tree:1780:5: note: in instantiation of member function 'std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock>,
std::__1::__map_value_compare<std::__1::basic_string<char>, std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock>, std::__1::less<std::__1::basic_string<char> >, true>,
std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock> > >::destroy' requested here
destroy(__root());
^
/usr/include/c++/v1/map:738:78: note: in instantiation of member function 'std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock>,
std::__1::__map_value_compare<std::__1::basic_string<char>, std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock>, std::__1::less<std::__1::basic_string<char> >, true>,
std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock> > >::~__tree' requested here
template <class, class, class, class> friend class _LIBCPP_TYPE_VIS_ONLY map;
^
In file included from util.cpp:6:
In file included from ./util.h:18:
In file included from ./fs.h:9:
In file included from /usr/include/c++/v1/string:442:
In file included from /usr/include/c++/v1/algorithm:633:
/usr/include/c++/v1/utility:298:23: error: no matching constructor for initialization of 'boost::interprocess::file_lock'
: first(__x), second(__y) {}
^ ~~~
/usr/include/c++/v1/memory:1747:31: note: in instantiation of member function 'std::__1::pair<const std::__1::basic_string<char>, boost::interprocess::file_lock>::pair' requested here
::new((void*)__p) _Up(_VSTD::forward<_Args>(__args)...);
^
/usr/include/c++/v1/memory:1658:18: note: in instantiation of function template specialization 'std::__1::allocator<std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>,
boost::interprocess::file_lock>, void *> >::construct<std::__1::pair<const std::__1::basic_string<char>, boost::interprocess::file_lock>, const std::__1::basic_string<char> &, const char *>' requested here
{__a.construct(__p, _VSTD::forward<_Args>(__args)...);}
^
/usr/include/c++/v1/memory:1504:14: note: in instantiation of function template specialization
'std::__1::allocator_traits<std::__1::allocator<std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock>, void *> > >::__construct<std::__1::pair<const
std::__1::basic_string<char>, boost::interprocess::file_lock>, const std::__1::basic_string<char> &, const char *>' requested here
{__construct(__has_construct<allocator_type, _Tp*, _Args...>(),
^
/usr/include/c++/v1/__tree:2149:20: note: in instantiation of function template specialization
'std::__1::allocator_traits<std::__1::allocator<std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock>, void *> > >::construct<std::__1::pair<const
std::__1::basic_string<char>, boost::interprocess::file_lock>, const std::__1::basic_string<char> &, const char *>' requested here
__node_traits::construct(__na, _NodeTypes::__get_ptr(__h->__value_), _VSTD::forward<_Args>(__args)...);
^
/usr/include/c++/v1/__tree:2094:29: note: in instantiation of function template specialization 'std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock>,
std::__1::__map_value_compare<std::__1::basic_string<char>, std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock>, std::__1::less<std::__1::basic_string<char> >, true>,
std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock> > >::__construct_node<const std::__1::basic_string<char> &, const char *>' requested here
__node_holder __h = __construct_node(_VSTD::forward<_Args>(__args)...);
^
/usr/include/c++/v1/__tree:1156:16: note: in instantiation of function template specialization 'std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock>,
std::__1::__map_value_compare<std::__1::basic_string<char>, std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock>, std::__1::less<std::__1::basic_string<char> >, true>,
std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock> > >::__emplace_unique_key_args<std::__1::basic_string<char>, const std::__1::basic_string<char> &,
const char *>' requested here
return __emplace_unique_key_args(__f, _VSTD::forward<_First>(__f),
^
/usr/include/c++/v1/map:1047:24: note: in instantiation of function template specialization 'std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock>,
std::__1::__map_value_compare<std::__1::basic_string<char>, std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock>, std::__1::less<std::__1::basic_string<char> >, true>,
std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char>, boost::interprocess::file_lock> > >::__emplace_unique<const std::__1::basic_string<char> &, const char *>' requested here
return __tree_.__emplace_unique(_VSTD::forward<_Args>(__args)...);
^
util.cpp:384:54: note: in instantiation of function template specialization 'std::__1::map<std::__1::basic_string<char>, boost::interprocess::file_lock, std::__1::less<std::__1::basic_string<char> >,
std::__1::allocator<std::__1::pair<const std::__1::basic_string<char>, boost::interprocess::file_lock> > >::emplace<const std::__1::basic_string<char> &, const char *>' requested here
boost::interprocess::file_lock& lock = locks.emplace(pathLockFile.string(), pathLockFile.string().c_str()).first->second;
^
/usr/local/include/boost/interprocess/sync/file_lock.hpp:48:35: note: candidate constructor not viable: 1st argument ('const boost::interprocess::file_lock') would lose const qualifier
BOOST_MOVABLE_BUT_NOT_COPYABLE(file_lock)
^
/usr/local/include/boost/move/core.hpp:216:46: note: expanded from macro 'BOOST_MOVABLE_BUT_NOT_COPYABLE'
BOOST_MOVE_IMPL_NO_COPY_CTOR_OR_ASSIGN(TYPE)\
^
/usr/local/include/boost/move/core.hpp:35:7: note: expanded from macro 'BOOST_MOVE_IMPL_NO_COPY_CTOR_OR_ASSIGN'
TYPE(TYPE &);\
^
/usr/local/include/boost/interprocess/sync/file_lock.hpp:65:4: note: candidate constructor not viable: no known conversion from 'const boost::interprocess::file_lock' to '::boost::rv<file_lock> &' for 1st
argument
file_lock(BOOST_RV_REF(file_lock) moved)
^
/usr/local/include/boost/interprocess/sync/file_lock.hpp:153:19: note: candidate constructor not viable: no known conversion from 'const boost::interprocess::file_lock' to 'const char *' for 1st argument
inline file_lock::file_lock(const char *name)
^
/usr/local/include/boost/interprocess/sync/file_lock.hpp:54:4: note: candidate constructor not viable: requires 0 arguments, but 1 was provided
file_lock()
^
3 errors generated.
gmake[2]: *** [Makefile:6149: libbitcoin_util_a-util.o] Error 1
gmake[2]: Leaving directory '/home/bitcoin/bitcoin/src'
gmake[1]: *** [Makefile:9417: all-recursive] Error 1
gmake[1]: Leaving directory '/home/bitcoin/bitcoin/src'
gmake: *** [Makefile:745: all-recursive] Error 1
``` | https://github.com/bitcoin/bitcoin/issues/12413 | https://github.com/bitcoin/bitcoin/pull/12422 | fc888bfcacb875c45bc8f9d7ca1357ab70a30490 | 1d4cbd26e4220982f7f2f60e447199d6f62ae254 | 2018-02-12T00:15:41Z | c++ | 2018-02-15T15:25:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,388 | [".travis.yml"] | travis failure on rc3: "src/crypto/ctaes is not a subtree" | Travis on the 0.16 branch is failing on the subtree check.
```
0.04s$ if [ "$CHECK_DOC" = 1 ]; then contrib/devtools/git-subtree-check.sh src/crypto/ctaes; fi
ERROR: src/crypto/ctaes is not a subtree
The command "if [ "$CHECK_DOC" = 1 ]; then contrib/devtools/git-subtree-check.sh src/crypto/ctaes; fi" failed and exited with 2 during .
```
The reason for this is that it makes a shallow clone, and the last change to that subtree is deeper than the oldest commit fetched.
The obvious solution would be to clone deeper, but that would be kicking the can down the road and make things slower. I'd say to be robust the check needs to generate a warning in this case but continue. If nothing changed to it in the last 50 commits, then the subtree can be assumed to be fine, otherwise we would have intervened by then.
Ping @MarcoFalke @sipa | https://github.com/bitcoin/bitcoin/issues/12388 | https://github.com/bitcoin/bitcoin/pull/12405 | 67447ba06057b8e83f962c82491d2fe6c5211f50 | fa44af5cd2152a21da9ef3e48c073a668bf2df27 | 2018-02-08T12:47:15Z | c++ | 2018-02-15T22:06:50Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,386 | ["src/qt/bitcoin.cpp", "src/qt/winshutdownmonitor.cpp"] | Windows Build Error | <pre><code>
GEN qt/forms/ui_transactiondescdialog.h
GEN qt/paymentrequest.pb.h
GEN qt/bitcoin.moc
GEN qt/bitcoinamountfield.moc
GEN qt/intro.moc
GEN qt/overviewpage.moc
GEN qt/rpcconsole.moc
CXX qt/qt_bitcoin_qt-bitcoin.o
qt/bitcoin.cpp: In function ‘int main(int, char**)’:
qt/bitcoin.cpp:709:173: error: invalid static_cast from type ‘WId {aka long long unsigned int}’ to type ‘HWND {aka HWND__*}’
WinShutdownMonitor::registerShutdownBlockReason(QObject::tr("%1 didn't yet exit safely...").arg(QObject::tr(PACKAGE_NAME)), static_cast<HWND>(app.getMainWinId()));
^
make[2]: *** [qt/qt_bitcoin_qt-bitcoin.o] Error 1
Makefile:8181: recipe for target 'qt/qt_bitcoin_qt-bitcoin.o' failed
make[2]: Leaving directory '/usr/src/bitcoin/src'
make[1]: *** [all-recursive] Error 1
Makefile:9419: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
make[1]: Leaving directory '/usr/src/bitcoin/src'
Makefile:747: recipe for target 'all-recursive' failed
</code></pre>
build on WSL | https://github.com/bitcoin/bitcoin/issues/12386 | https://github.com/bitcoin/bitcoin/pull/12416 | 5dc00f68c49c46a380a98d06233f90528b8e2557 | f40df29d96a29197f9949b63da80f9ba3152fc79 | 2018-02-08T10:15:38Z | c++ | 2018-02-12T14:48:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,372 | ["src/qt/bitcoin.cpp"] | Qt Splash Screen is deleted (and accesses wallet) after Shutdown() (and wallets are deleted). | In trying to debug #12337 I added a sleep at the end of AppInitMain() to simulate being able to close the application late in the AppInitMain() process. If I close the splash screen at this point, I get a reliable crash when the splashs screen is deleted as it tries to disconnect itself from the wallet ShowProgress signal after Shutdown() has been called and the wallet has been deleted. | https://github.com/bitcoin/bitcoin/issues/12372 | https://github.com/bitcoin/bitcoin/pull/12374 | f5a4c3ddf48db2119b2b1a438b9462a6236565cd | 1e5d14b3f7db814505279d346f0b819443753e66 | 2018-02-06T22:55:29Z | c++ | 2018-02-07T09:37:45Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,362 | ["src/httpserver.cpp"] | bitcoind hits corrupted double-linked list error when running multiple wallet_multiwallet.py tests in parallel | I'm still debugging this, but I'm sharing what I've got so far.
If I run several instances of the `wallet_multiwallet.py` test in parallel, then bitcoind hits an error, but the test still passes:
```
./test_runner.py wallet_multiwallet.py wallet_multiwallet.py wallet_multiwallet.py wallet_multiwallet.py wallet_multiwallet.py wallet_multiwallet.py wallet_multiwallet.py wallet_multiwallet.py
...*** Error in `/home/ubuntu/bitcoin/src/bitcoind': corrupted double-linked list: 0x0000562c19b928a0 ***
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(+0x777e5)[0x7f750c3547e5]
/lib/x86_64-linux-gnu/libc.so.6(+0x82970)[0x7f750c35f970]
/lib/x86_64-linux-gnu/libc.so.6(__libc_malloc+0x54)[0x7f750c361184]
/usr/lib/x86_64-linux-gnu/libstdc++.so.6(_Znwm+0x18)[0x7f750cc53e78]
/home/ubuntu/bitcoin/src/bitcoind(+0x772b9)[0x562c179e92b9]
/home/ubuntu/bitcoin/src/bitcoind(+0x2b8187)[0x562c17c2a187]
/home/ubuntu/bitcoin/src/bitcoind(+0x2aeb36)[0x562c17c20b36]
/home/ubuntu/bitcoin/src/bitcoind(+0x68b2c)[0x562c179dab2c]
/home/ubuntu/bitcoin/src/bitcoind(+0x3f2db)[0x562c179b12db]
/home/ubuntu/bitcoin/src/bitcoind(+0x3222f)[0x562c179a422f]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7f750c2fd830]
/home/ubuntu/bitcoin/src/bitcoind(+0x3def9)[0x562c179afef9]
======= Memory map: ========
562c17972000-562c17f23000 r-xp 00000000 08:01 516003 /home/ubuntu/bitcoin/src/bitcoind
562c18123000-562c1812e000 r--p 005b1000 08:01 516003 /home/ubuntu/bitcoin/src/bitcoind
562c1812e000-562c18136000 rw-p 005bc000 08:01 516003 /home/ubuntu/bitcoin/src/bitcoind
562c18136000-562c1813c000 rw-p 00000000 00:00 0
562c19a1d000-562c19baf000 rw-p 00000000 00:00 0 [heap]
7f74f8000000-7f74f8023000 rw-p 00000000 00:00 0
7f74f8023000-7f74fc000000 ---p 00000000 00:00 0
7f7500000000-7f7500021000 rw-p 00000000 00:00 0
7f7500021000-7f7504000000 ---p 00000000 00:00 0
7f750613f000-7f7506140000 ---p 00000000 00:00 0
7f7506140000-7f7506940000 rw-p 00000000 00:00 0
7f7506940000-7f7506941000 ---p 00000000 00:00 0
7f7506941000-7f7507141000 rw-p 00000000 00:00 0
7f7507141000-7f7507142000 ---p 00000000 00:00 0
7f7507142000-7f7507942000 rw-p 00000000 00:00 0
7f7507942000-7f7507943000 ---p 00000000 00:00 0
7f7507943000-7f7508143000 rw-p 00000000 00:00 0
7f7508143000-7f7508144000 ---p 00000000 00:00 0
7f7508144000-7f7508944000 rw-p 00000000 00:00 0
7f7508944000-7f7508945000 ---p 00000000 00:00 0
7f7508945000-7f7509145000 rw-p 00000000 00:00 0
7f7509145000-7f7509146000 ---p 00000000 00:00 0
7f7509146000-7f750b948000 rw-p 00000000 00:00 0
7f750ba49000-7f750baa6000 r-xp 00000000 08:01 61325 /usr/lib/x86_64-linux-gnu/libsodium.so.18.0.1
7f750baa6000-7f750bca5000 ---p 0005d000 08:01 61325 /usr/lib/x86_64-linux-gnu/libsodium.so.18.0.1
7f750bca5000-7f750bca6000 r--p 0005c000 08:01 61325 /usr/lib/x86_64-linux-gnu/libsodium.so.18.0.1
7f750bca6000-7f750bca7000 rw-p 0005d000 08:01 61325 /usr/lib/x86_64-linux-gnu/libsodium.so.18.0.1
7f750bca7000-7f750bcd0000 r-xp 00000000 08:01 61253 /usr/lib/x86_64-linux-gnu/libevent_core-2.0.so.5.1.9
7f750bcd0000-7f750becf000 ---p 00029000 08:01 61253 /usr/lib/x86_64-linux-gnu/libevent_core-2.0.so.5.1.9
7f750becf000-7f750bed0000 r--p 00028000 08:01 61253 /usr/lib/x86_64-linux-gnu/libevent_core-2.0.so.5.1.9
7f750bed0000-7f750bed1000 rw-p 00029000 08:01 61253 /usr/lib/x86_64-linux-gnu/libevent_core-2.0.so.5.1.9
7f750bed1000-7f750bed4000 r-xp 00000000 08:01 63277 /lib/x86_64-linux-gnu/libdl-2.23.so
7f750bed4000-7f750c0d3000 ---p 00003000 08:01 63277 /lib/x86_64-linux-gnu/libdl-2.23.so
7f750c0d3000-7f750c0d4000 r--p 00002000 08:01 63277 /lib/x86_64-linux-gnu/libdl-2.23.so
7f750c0d4000-7f750c0d5000 rw-p 00003000 08:01 63277 /lib/x86_64-linux-gnu/libdl-2.23.so
7f750c0d5000-7f750c0dc000 r-xp 00000000 08:01 63311 /lib/x86_64-linux-gnu/librt-2.23.so
7f750c0dc000-7f750c2db000 ---p 00007000 08:01 63311 /lib/x86_64-linux-gnu/librt-2.23.so
7f750c2db000-7f750c2dc000 r--p 00006000 08:01 63311 /lib/x86_64-linux-gnu/librt-2.23.so
7f750c2dc000-7f750c2dd000 rw-p 00007000 08:01 63311 /lib/x86_64-linux-gnu/librt-2.23.so
7f750c2dd000-7f750c49d000 r-xp 00000000 08:01 63272 /lib/x86_64-linux-gnu/libc-2.23.so
7f750c49d000-7f750c69d000 ---p 001c0000 08:01 63272 /lib/x86_64-linux-gnu/libc-2.23.so
7f750c69d000-7f750c6a1000 r--p 001c0000 08:01 63272 /lib/x86_64-linux-gnu/libc-2.23.so
7f750c6a1000-7f750c6a3000 rw-p 001c4000 08:01 63272 /lib/x86_64-linux-gnu/libc-2.23.so
7f750c6a3000-7f750c6a7000 rw-p 00000000 00:00 0
7f750c6a7000-7f750c6bd000 r-xp 00000000 08:01 2039 /lib/x86_64-linux-gnu/libgcc_s.so.1
7f750c6bd000-7f750c8bc000 ---p 00016000 08:01 2039 /lib/x86_64-linux-gnu/libgcc_s.so.1
7f750c8bc000-7f750c8bd000 rw-p 00015000 08:01 2039 /lib/x86_64-linux-gnu/libgcc_s.so.1
7f750c8bd000-7f750c9c5000 r-xp 00000000 08:01 18864 /lib/x86_64-linux-gnu/libm-2.23.so
7f750c9c5000-7f750cbc4000 ---p 00108000 08:01 18864 /lib/x86_64-linux-gnu/libm-2.23.so
7f750cbc4000-7f750cbc5000 r--p 00107000 08:01 18864 /lib/x86_64-linux-gnu/libm-2.23.so
7f750cbc5000-7f750cbc6000 rw-p 00108000 08:01 18864 /lib/x86_64-linux-gnu/libm-2.23.so
7f750cbc6000-7f750cd38000 r-xp 00000000 08:01 8173 /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.21
7f750cd38000-7f750cf38000 ---p 00172000 08:01 8173 /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.21
7f750cf38000-7f750cf42000 r--p 00172000 08:01 8173 /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.21
7f750cf42000-7f750cf44000 rw-p 0017c000 08:01 8173 /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.21
7f750cf44000-7f750cf48000 rw-p 00000000 00:00 0
7f750cf48000-7f750cfaa000 r-xp 00000000 08:01 62885 /usr/lib/x86_64-linux-gnu/libzmq.so.5.0.0
7f750cfaa000-7f750d1a9000 ---p 00062000 08:01 62885 /usr/lib/x86_64-linux-gnu/libzmq.so.5.0.0
7f750d1a9000-7f750d1ad000 r--p 00061000 08:01 62885 /usr/lib/x86_64-linux-gnu/libzmq.so.5.0.0
7f750d1ad000-7f750d1ae000 rw-p 00065000 08:01 62885 /usr/lib/x86_64-linux-gnu/libzmq.so.5.0.0
7f750d1ae000-7f750d1f2000 r-xp 00000000 08:01 26071 /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5.1.9
7f750d1f2000-7f750d3f2000 ---p 00044000 08:01 26071 /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5.1.9
7f750d3f2000-7f750d3f3000 r--p 00044000 08:01 26071 /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5.1.9
7f750d3f3000-7f750d3f4000 rw-p 00045000 08:01 26071 /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5.1.9
7f750d3f4000-7f750d3f6000 r-xp 00000000 08:01 61265 /usr/lib/x86_64-linux-gnu/libevent_pthreads-2.0.so.5.1.9
7f750d3f6000-7f750d5f5000 ---p 00002000 08:01 61265 /usr/lib/x86_64-linux-gnu/libevent_pthreads-2.0.so.5.1.9
7f750d5f5000-7f750d5f6000 r--p 00001000 08:01 61265 /usr/lib/x86_64-linux-gnu/libevent_pthreads-2.0.so.5.1.9
7f750d5f6000-7f750d5f7000 rw-p 00002000 08:01 61265 /usr/lib/x86_64-linux-gnu/libevent_pthreads-2.0.so.5.1.9
7f750d5f7000-7f750d811000 r-xp 00000000 08:01 28216 /lib/x86_64-linux-gnu/libcrypto.so.1.0.0
7f750d811000-7f750da10000 ---p 0021a000 08:01 28216 /lib/x86_64-linux-gnu/libcrypto.so.1.0.0
7f750da10000-7f750da2c000 r--p 00219000 08:01 28216 /lib/x86_64-linux-gnu/libcrypto.so.1.0.0
7f750da2c000-7f750da38000 rw-p 00235000 08:01 28216 /lib/x86_64-linux-gnu/libcrypto.so.1.0.0
7f750da38000-7f750da3b000 rw-p 00000000 00:00 0
7f750da3b000-7f750da53000 r-xp 00000000 08:01 63271 /lib/x86_64-linux-gnu/libpthread-2.23.so
7f750da53000-7f750dc52000 ---p 00018000 08:01 63271 /lib/x86_64-linux-gnu/libpthread-2.23.so
7f750dc52000-7f750dc53000 r--p 00017000 08:01 63271 /lib/x86_64-linux-gnu/libpthread-2.23.so
7f750dc53000-7f750dc54000 rw-p 00018000 08:01 63271 /lib/x86_64-linux-gnu/libpthread-2.23.so
7f750dc54000-7f750dc58000 rw-p 00000000 00:00 0
7f750dc58000-7f750ddf2000 r-xp 00000000 08:01 552553 /usr/local/BerkeleyDB.4.8/lib/libdb_cxx-4.8.so
7f750ddf2000-7f750dff2000 ---p 0019a000 08:01 552553 /usr/local/BerkeleyDB.4.8/lib/libdb_cxx-4.8.so
7f750dff2000-7f750dff5000 r--p 0019a000 08:01 552553 /usr/local/BerkeleyDB.4.8/lib/libdb_cxx-4.8.so
7f750dff5000-7f750dff8000 rw-p 0019d000 08:01 552553 /usr/local/BerkeleyDB.4.8/lib/libdb_cxx-4.8.so
7f750dff8000-7f750dffe000 r-xp 00000000 08:01 60749 /usr/lib/x86_64-linux-gnu/libboost_chrono.so.1.58.0
7f750dffe000-7f750e1fe000 ---p 00006000 08:01 60749 /usr/lib/x86_64-linux-gnu/libboost_chrono.so.1.58.0
7f750e1fe000-7f750e1ff000 r--p 00006000 08:01 60749 /usr/lib/x86_64-linux-gnu/libboost_chrono.so.1.58.0
7f750e1ff000-7f750e200000 rw-p 00007000 08:01 60749 /usr/lib/x86_64-linux-gnu/libboost_chrono.so.1.58.0
7f750e200000-7f750e224000 r-xp 00000000 08:01 60765 /usr/lib/x86_64-linux-gnu/libboost_thread.so.1.58.0
7f750e224000-7f750e423000 ---p 00024000 08:01 60765 /usr/lib/x86_64-linux-gnu/libboost_thread.so.1.58.0
7f750e423000-7f750e425000 r--p 00023000 08:01 60765 /usr/lib/x86_64-linux-gnu/libboost_thread.so.1.58.0
7f750e425000-7f750e426000 rw-p 00025000 08:01 60765 /usr/lib/x86_64-linux-gnu/libboost_thread.so.1.58.0
7f750e426000-7f750e4a0000 r-xp 00000000 08:01 60742 /usr/lib/x86_64-linux-gnu/libboost_program_options.so.1.58.0
7f750e4a0000-7f750e6a0000 ---p 0007a000 08:01 60742 /usr/lib/x86_64-linux-gnu/libboost_program_options.so.1.58.0
7f750e6a0000-7f750e6a3000 r--p 0007a000 08:01 60742 /usr/lib/x86_64-linux-gnu/libboost_program_options.so.1.58.0
7f750e6a3000-7f750e6a4000 rw-p 0007d000 08:01 60742 /usr/lib/x86_64-linux-gnu/libboost_program_options.so.1.58.0
7f750e6a4000-7f750e6bb000 r-xp 00000000 08:01 60843 /usr/lib/x86_64-linux-gnu/libboost_filesystem.so.1.58.0
7f750e6bb000-7f750e8ba000 ---p 00017000 08:01 60843 /usr/lib/x86_64-linux-gnu/libboost_filesystem.so.1.58.0
7f750e8ba000-7f750e8bb000 r--p 00016000 08:01 60843 /usr/lib/x86_64-linux-gnu/libboost_filesystem.so.1.58.0
7f750e8bb000-7f750e8bc000 rw-p 00017000 08:01 60843 /usr/lib/x86_64-linux-gnu/libboost_filesystem.so.1.58.0
7f750e8bc000-7f750e8bf000 r-xp 00000000 08:01 60743 /usr/lib/x86_64-linux-gnu/libboost_system.so.1.58.0
7f750e8bf000-7f750eabe000 ---p 00003000 08:01 60743 /usr/lib/x86_64-linux-gnu/libboost_system.so.1.58.0
7f750eabe000-7f750eabf000 r--p 00002000 08:01 60743 /usr/lib/x86_64-linux-gnu/libboost_system.so.1.58.0
7f750eabf000-7f750eac0000 rw-p 00003000 08:01 60743 /usr/lib/x86_64-linux-gnu/libboost_system.so.1.58.0
7f750eac0000-7f750eae6000 r-xp 00000000 08:01 19651 /lib/x86_64-linux-gnu/ld-2.23.so
7f750eb1f000-7f750eb2f000 rw-p 00000000 00:00 0
7f750eb2f000-7f750ecc7000 r--p 00000000 08:01 7864 /usr/lib/locale/locale-archive
7f750ecc7000-7f750ecd6000 rw-p 00000000 00:00 0
7f750ecdd000-7f750ecde000 rw-p 00000000 00:00 0
7f750ecde000-7f750ece5000 r--s 00000000 08:01 63406 /usr/lib/x86_64-linux-gnu/gconv/gconv-modules.cache
7f750ece5000-7f750ece6000 r--p 00025000 08:01 19651 /lib/x86_64-linux-gnu/ld-2.23.so
7f750ece6000-7f750ece7000 rw-p 00026000 08:01 19651 /lib/x86_64-linux-gnu/ld-2.23.so
7f750ece7000-7f750ece8000 rw-p 00000000 00:00 0
7ffd2c413000-7ffd2c434000 rw-p 00000000 00:00 0 [stack]
7ffd2c475000-7ffd2c477000 r--p 00000000 00:00 0 [vvar]
7ffd2c477000-7ffd2c479000 r-xp 00000000 00:00 0 [vdso]
ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0 [vsyscall]
wallet_multiwallet.py passed, Duration: 5 s
[...]
```
I can only see this output if I run through the test_runner, not if I run the test directly (this might just be something to do with where the test_framework is sending stderr).
I've bisected this to somewhere between commit 886a92f25f2e47a7ec9097d7c5a8d8a6173ef998 and 9bb59cf7baea0b33d97ef0c0eeee88a8b104be3a . Note that prior to 90600bc, this test was called `multiwallet.py`.
This test is testing a lot of cases of bitcoind failing to start because of bad `-wallet` parameters being passed in, so the test is expecting the process to exit. However, we obviously shouldn't be hitting memory corruption like I see in the output above.
No-one else here has been able to reproduce this yet, but I can hit it reliably on master and v0.16.0rc2. One guess of somewhere to look is bdb since this is being tickled by the wallet code. | https://github.com/bitcoin/bitcoin/issues/12362 | https://github.com/bitcoin/bitcoin/pull/12366 | f94665466ed50e868c98b1a1c708ad5767727bb6 | 11e01515fe0fbc7823d4111ad6e016a02c485a78 | 2018-02-06T03:52:13Z | c++ | 2018-02-07T08:53:46Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,344 | ["src/init.cpp", "src/net.cpp", "test/functional/feature_config_args.py"] | Setting `onlynet=onion` still makes some IPv4 connections. | Using Bitcoin Core v0.15.1
I have just set `onlynet=onion` in my `bitcoin.conf` file and have the following in my logs after node restart:
2018-02-03 12:40:52 receive version message: /Satoshi:0.15.1/: version 70015, blocks=507429, us={IPv4}:{port), peer=0
2018-02-03 12:41:15 receive version message: /Satoshi:0.14.2/: version 70015, blocks=507429, us={IPv4}:{port), peer=2
2018-02-03 12:41:22 receive version message: /Satoshi:0.14.2/: version 70015, blocks=507429, us={IPv4}:{port), peer=3
2018-02-03 12:41:28 receive version message: /Satoshi:0.15.0/: version 70015, blocks=507429, us={IPv4}:{port), peer=4
2018-02-03 12:41:57 receive version message: /Satoshi:0.15.99/: version 70015, blocks=526679, us={IPv4}:{port), peer=5
...
2018-02-03 12:44:11 receive version message: /Satoshi:0.15.1/: version 70015, blocks=507429, us=[::]:0, peer=6
The peer 6 was an onion.
My `bitcoin.conf` file is as follows:
uacomment={redacted}
prune=10239
banscore=10
bantime=31536000
maxmempool=900
mempoolexpiry=2160
proxy=127.0.0.1:9050
listen=1
bind=127.0.0.1
onlynet=onion
All the `Used for reaching peers via` tick boxes are still ticked but disabled when I look in Options>Newtork.
Bitcoin Core should not initiate IPv4 (or IPv6) connections when `onlynet=onion`. These connections should not be seed nodes due to low addresses:
2018-02-03 12:40:30 Loaded 66198 addresses from peers.dat 254ms
I get some IPv4 version messages each time I restart the node.
Note: added both `dns=0` and `dnsseed=0` at the same time and this *seems* to resolve the issue with limited testing. These entries should not be necessary to limit IPv4 outgoing connect.
If people need to setup Tor for testing, the setup I have used is here on [Bitcoin.SE](https://bitcoin.stackexchange.com/a/70070/75001) | https://github.com/bitcoin/bitcoin/issues/12344 | https://github.com/bitcoin/bitcoin/pull/25678 | fc44d1796e4df5824423d7d13de3082fe204db7d | 37095c7dc4a85155c35e2473b6a20a53ae413cea | 2018-02-03T13:16:38Z | c++ | 2022-09-07T17:28:42Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,312 | ["src/qt/coincontroldialog.cpp", "src/qt/coincontroldialog.h", "src/qt/sendcoinsdialog.cpp"] | QT ignores -changetype=bech32 when coin control features are enabled | Steps to reproduce:
1. put `changetype=bech32` in bitcoin.conf or launch QT with `-changetype=bech32`
2. send money to any legacy address
3. use `decoderawtransaction` to see that the change address is `bech32`, as expected since #12119
4. enable Coin Control in settings menu
5. send money to any legacy address
6. use `decoderawtransaction` to see that the change address is now `p2sh-segwit` | https://github.com/bitcoin/bitcoin/issues/12312 | https://github.com/bitcoin/bitcoin/pull/12327 | 895fbd768f0c89cea3f78acac58b233d4e3a145e | 6558f8acc363e1141f2864ee9be2bc7e980842a3 | 2018-01-31T15:35:18Z | c++ | 2018-02-01T19:40:20Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,259 | ["test/functional/feature_versionbits_warning.py"] | [qa] p2p-versionbits-warning.py fails occasionally | To keep track of p2p-versionbits-warning.py intermittent travis failure logs:
* https://travis-ci.org/bitcoin/bitcoin/jobs/332755035
Example backtrace:
```
2018-01-24 12:50:32.849000 TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/test_framework.py", line 123, in main
self.run_test()
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/p2p-versionbits-warning.py", line 112, in run_test
assert(WARN_UNKNOWN_RULES_ACTIVE in self.nodes[0].getmininginfo()["warnings"])
AssertionError | https://github.com/bitcoin/bitcoin/issues/12259 | https://github.com/bitcoin/bitcoin/pull/12264 | 3bbd8437089bfd3c7fe336a1f685894a314ea98e | 1e2e09e2f6382ed239d974720126c642c3e3690c | 2018-01-24T14:36:48Z | c++ | 2018-01-25T12:34:58Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,253 | ["doc/release-notes-14454.md", "src/wallet/rpcdump.cpp", "src/wallet/rpcwallet.cpp", "test/functional/test_framework/blocktools.py", "test/functional/wallet_importmulti.py"] | SegWit support for importmulti | It's currently not possible to import (solvable) SegWit addresses (P2SH and native) using `importmulti`. I believe that's a shortcoming we should address before release.
My suggestion would be for P2WPKH (P2SH and native) to be supported without any extra arguments. This means that a P2WPKH address/script with corresponding private or public key should work. For P2SH it means checking if the supplied P2SH address perhaps matches the supplied public key or private key when converted to P2WPKH first.
To support P2WSH, I think we need an extra field "witnessScript". When supplied, it would either be required to match a P2WSH address/script directly, or if the address is P2SH, indirectly. | https://github.com/bitcoin/bitcoin/issues/12253 | https://github.com/bitcoin/bitcoin/pull/14454 | 201451b1ca3c6db3b13f9491a81db5b120b864bb | c11875c5908a17314bb38caa911507dc6401ec49 | 2018-01-23T22:48:42Z | c++ | 2018-10-24T20:30:57Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,229 | ["src/bitcoind.cpp", "src/init.cpp", "src/init.h", "src/qt/bitcoin.cpp"] | Shutdown deadlock in SyncWithValidationInterfaceQueue | I'm hoping to take a look at this at some point in the next day or two, but logging here in case I forget. Ping @TheBlueMatt.
Trigger conditions: I was catching up after ~1week offline, and interrupted halfway through.
The backtrace is straightforward:
```
(gdb) thread apply all bt
Thread 3 (Thread 0x7fbb37fff700 (LWP 31792)):
#0 syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
#1 0x00007fbb75a9aa16 in std::__atomic_futex_unsigned_base::_M_futex_wait_until(unsigned int*, unsigned int, bool, std::chrono::duration<long, std::ratio<1l, 1l> >, std::chrono::duration<long, std::ratio<1l, 1000000000l> >) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#2 0x000055d498e501e0 in SyncWithValidationInterfaceQueue() ()
#3 0x000055d498e34965 in CChainState::ActivateBestChain(CValidationState&, CChainParams const&, std::shared_ptr<CBlock const>) ()
#4 0x000055d498e36847 in ProcessNewBlock(CChainParams const&, std::shared_ptr<CBlock const>, bool, bool*) ()
#5 0x000055d498d32464 in ProcessMessage(CNode*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, CDataStream&, long, CChainParams const&, CConnman*, std::atomic<bool> const&) [clone .constprop.1364] ()
#6 0x000055d498d3dd80 in PeerLogicValidation::ProcessMessages(CNode*, std::atomic<bool>&) ()
#7 0x000055d498cee7cd in CConnman::ThreadMessageHandler() ()
#8 0x000055d498cce47f in void TraceThread<std::function<void ()> >(char const*, std::function<void ()>) ()
#9 0x000055d498d065cb in std::thread::_Impl<std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)> >::_M_run() ()
#10 0x00007fbb75a9cc80 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#11 0x00007fbb75d6d6ba in start_thread (arg=0x7fbb37fff700) at pthread_create.c:333
#12 0x00007fbb7520241d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
Thread 2 (Thread 0x7fbb61e98700 (LWP 31778)):
#0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1 0x000055d499034a1b in leveldb::(anonymous namespace)::PosixEnv::BGThreadWrapper(void*) ()
#2 0x00007fbb75d6d6ba in start_thread (arg=0x7fbb61e98700) at pthread_create.c:333
#3 0x00007fbb7520241d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
Thread 1 (Thread 0x7fbb76384740 (LWP 31765)):
#0 0x00007fbb75d6e98d in pthread_join (threadid=140442075133696, thread_return=0x0) at pthread_join.c:90
#1 0x00007fbb75a9cb97 in std::thread::join() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#2 0x000055d498d037ab in CConnman::Stop() ()
#3 0x000055d498cc9630 in Shutdown() ()
#4 0x000055d498c9e2a3 in AppInit(int, char**) ()
#5 0x000055d498c9164f in main ()
``` | https://github.com/bitcoin/bitcoin/issues/12229 | https://github.com/bitcoin/bitcoin/pull/12266 | 6970b30c6f1d2be7947295fe18f2390649b17a4b | 082a61c69d7a539b5a48c4376a657f1c5aa92d81 | 2018-01-19T19:15:42Z | c++ | 2018-01-25T16:35:34Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,223 | ["src/httprpc.cpp", "src/rpc/server.cpp", "src/rpc/server.h"] | Log origin IP of RPC request | Currently when launching `bitcoind` with `-debug=rpc` the log is rather sparse, e.g. `ThreadRPCServer method=validateaddres`. If possible I'd like it to show the origin IP. | https://github.com/bitcoin/bitcoin/issues/12223 | https://github.com/bitcoin/bitcoin/pull/12778 | 7466a26cab5d66665991433947964a638f5b957e | 4d74c78c69123a3d97293f40337e2efa5dadbff0 | 2018-01-19T08:28:20Z | c++ | 2018-03-25T18:25:09Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,205 | ["src/rpc/blockchain.cpp", "test/functional/test_framework/util.py"] | Intermittent address_types.py test failures | address_types.py test seems to fail intermittently on travis
It was mentioned in https://github.com/bitcoin/bitcoin/pull/11991#issuecomment-357922664 that this could be due to sync_mempools failing. A failure I saw looked like:
```
address_types.py failed, Duration: 14 s
stdout:
2018-01-12 23:14:39.513000 TestFramework (INFO): Initializing test directory /tmp/bitcoin_test_runner_20180112_231145/address_types_178
2018-01-12 23:14:48.747000 TestFramework (INFO): Sending from node 0 (['-addresstype=legacy']) without multisig using default
2018-01-12 23:14:51.012000 TestFramework (INFO): Sending from node 1 (['-addresstype=p2sh-segwit']) without multisig using default
2018-01-12 23:14:53.263000 TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/test_framework.py", line 123, in main
self.run_test()
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/address_types.py", line 183, in run_test
assert_equal(unconf_balances[to_node], to_send * 10 * (2 + n))
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/util.py", line 38, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(0E-8 == 1176.25722960)
2018-01-12 23:14:53.263000 TestFramework (INFO): Stopping nodes
2018-01-12 23:14:53.577000 TestFramework (WARNING): Not cleaning up dir /tmp/bitcoin_test_runner_20180112_231145/address_types_178
2018-01-12 23:14:53.577000 TestFramework (ERROR): Test failed. Test logging available at /tmp/bitcoin_test_runner_20180112_231145/address_types_178/test_framework.log
2018-01-12 23:14:53.578000 TestFramework (ERROR): Hint: Call /home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/combine_logs.py '/tmp/bitcoin_test_runner_20180112_231145/address_types_178' to consolidate all logs
```
https://travis-ci.org/bitcoin/bitcoin/jobs/328318030 | https://github.com/bitcoin/bitcoin/issues/12205 | https://github.com/bitcoin/bitcoin/pull/12206 | 66e3af709dd444b2d85e15c56f4608c700ff82ee | fa1e69e52bf8de08b1ce7a774416aa7a8d20068b | 2018-01-16T20:47:22Z | c++ | 2018-01-17T21:44:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,191 | ["src/qt/guiutil.cpp"] | bech32-optimized QR codes | @sipa said in #11991:
> I haven't looked at the code, but inside QR codes it's advantageous to use uppercase Bech32 (it will result in a smaller QR encoding).
Is that still the case when rendered as URI?
Should amounts be added in a different way?
Would that involve amending BIP-21? | https://github.com/bitcoin/bitcoin/issues/12191 | https://github.com/bitcoin/bitcoin/pull/15371 | d5dbb45bdf7d62257cf73c452f7d43727e3ae72b | 3407b446cc5ec0725c0505e3b933f43d86286ad5 | 2018-01-15T13:52:32Z | c++ | 2019-02-09T18:33:26Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,171 | ["src/rpc/blockchain.cpp", "test/functional/test_framework/util.py"] | [qa] address_types.py failed | travis log: https://travis-ci.org/bitcoin/bitcoin/jobs/327785286
```
2018-01-11 17:49:08.016000 TestFramework (INFO): Sending from node 1 (['-addresstype=p2sh-segwit']) with multisig using default
2018-01-11 17:49:10.096000 TestFramework (INFO): Sending from node 2 (['-addresstype=p2sh-segwit', '-changetype=bech32']) with multisig using default
2018-01-11 17:49:12.492000 TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 118, in main
self.run_test()
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/address_types.py", line 183, in run_test
assert_equal(unconf_balances[to_node], to_send * 10 * (2 + n))
File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 38, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(0E-8 == 714.73999460) | https://github.com/bitcoin/bitcoin/issues/12171 | https://github.com/bitcoin/bitcoin/pull/12206 | 66e3af709dd444b2d85e15c56f4608c700ff82ee | fa1e69e52bf8de08b1ce7a774416aa7a8d20068b | 2018-01-12T12:57:27Z | c++ | 2018-01-17T21:44:32Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,142 | ["src/init.cpp", "src/rpc/blockchain.cpp", "src/validation.cpp", "src/validation.h"] | RPC: savemempool: Don't write mempool.dat while not having the previous one in memory | Currently it is possible to stupidly lose mempool data by calling the rpc "savemempool" before the previous stored mempool has been read and processed to the memory mempool.
I haven't looked at the code yet, but at minimum one ugly solution would be to have a global g_is_mempool_read_finished (or something of the short) that starts false and gets sets to true once the reading is reading processing of mempool.dat is successfully finished. The rpc savemempool checks this global on the start and returns a an error while it remains false.
| https://github.com/bitcoin/bitcoin/issues/12142 | https://github.com/bitcoin/bitcoin/pull/12172 | 624bee96597c1d59018e58131b8285c0b332700d | cb1e319fe9e198c9c5cf5236fe9af5a3d748b9e8 | 2018-01-11T00:57:44Z | c++ | 2018-03-29T04:24:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,100 | ["src/wallet/rpcwallet.cpp", "test/functional/wallet-encryption.py"] | unlocking an encrypted wallet for a very long time fails silently | If I unlock an encrypted wallet for 359711509437336256 or less seconds, I can sign transactions with it:
$ bitcoin-cli walletpassphrase "$x" 359711509437336256
$ echo $?
0
$ bitcoin-cli signrawtransaction $tx | grep complete
"complete": true
But if I unlock it for 359711509437336257 or more seconds, it appears to have unlocked but I can't sign any transactions:
$ bitcoin-cli walletpassphrase "$x" 359711509437336257
$ echo $?
0
$ bitcoin-cli signrawtransaction $tx | grep complete
error code: -13
error message:
Error: Please enter the wallet passphrase with walletpassphrase first.
I don't know the significance of that number. It's nowhere near a power of 2.
I was trying to unlock the wallet effectively "forever", so put a big number. If I use too big a number (2^63 or more) I get an error message `JSON integer out of range` but for numbers between 359711509437336257 and 2^63-1 inclusive I get no error, but no actual unlocking. | https://github.com/bitcoin/bitcoin/issues/12100 | https://github.com/bitcoin/bitcoin/pull/12101 | 0b63e3c7b20ea54930de3ec3955406e4d4737e3c | 134cdc7cee3da7c554e40ad947a9cdcbb3069f13 | 2018-01-06T05:18:12Z | c++ | 2018-01-12T04:58:54Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 12,015 | ["src/qt/sendcoinsdialog.cpp"] | Maybe A bug in qt/sendcoinsdialog.cpp:339 | ERROR: type should be string, got "https://github.com/bitcoin/bitcoin/blob/5180a86c96bc05d2a731f70f36aae28ab5a3fad4/src/qt/sendcoinsdialog.cpp#L339\r\n\r\nI think this is %1, not %2" | https://github.com/bitcoin/bitcoin/issues/12015 | https://github.com/bitcoin/bitcoin/pull/12092 | ddff3447f29b62d79a33f728791f42fa9436216e | 8a93543419300bd78e189429e003c8b17c1b983a | 2017-12-25T10:51:46Z | c++ | 2018-01-04T19:57:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,953 | ["test/functional/p2p-segwit.py"] | travis failure in p2p-segwit.py not(b'bad-txns-vout-negative' == b'bad-witness-nonstandard') | This keeps popping up from time to time on travis. The relevant log excerpt:
```
2017-12-19 17:52:57.940000 TestFramework (INFO): Testing detection of non-standard P2WSH witness
2017-12-19 17:52:58.710000 TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "./test/functional/test_framework/test_framework.py", line 118, in main
self.run_test()
File "./test/functional/p2p-segwit.py", line 1943, in run_test
self.test_non_standard_witness()
File "./test/functional/p2p-segwit.py", line 1827, in test_non_standard_witness
test_transaction_acceptance(self.nodes[1].rpc, self.std_node, p2wsh_txs[0], True, False, b'bad-witness-nonstandard')
File "./test/functional/p2p-segwit.py", line 48, in test_transaction_acceptance
assert_equal(p2p.last_message["reject"].reason, reason)
File "./test/functional/test_framework/util.py", line 38, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(b'bad-txns-vout-negative' == b'bad-witness-nonstandard')
```
Most recent example: https://travis-ci.org/bitcoin/bitcoin/jobs/318711688 | https://github.com/bitcoin/bitcoin/issues/11953 | https://github.com/bitcoin/bitcoin/pull/12133 | 56910285fa4a7a0f3b931e7613b9691cee9c13ff | 35c2b1fe3b1a046bbd1bfaf1c178e838d047277a | 2017-12-19T21:38:35Z | c++ | 2018-01-09T19:13:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,949 | ["Makefile.am", "configure.ac", "doc/developer-notes.md"] | "make docs" or such to build doxygen documentation | Would be nice to have a "make docs" that builds the developer documentation.
It is hosted on https://dev.visucore.com/bitcoin/doxygen/, but some users prefer an offline copy (and one up to date with their specific branch).
Essentially it would do:
```bash
doxygen doc/Doxyfile
```
(but taking into account build/source directories if separate)
It could also build other documentation in the future. | https://github.com/bitcoin/bitcoin/issues/11949 | https://github.com/bitcoin/bitcoin/pull/12029 | 2ae7cf8ef5be67e085abc1b1dc71bc44865a71b3 | a777244e48227db6d3fd06cd2500cc007dacfb10 | 2017-12-19T14:48:27Z | c++ | 2018-01-25T18:43:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,888 | ["src/init.cpp", "src/util.cpp", "src/util.h", "src/wallet/db.cpp", "src/wallet/db.h", "test/functional/multiwallet.py"] | Prevent Opening Wallets Simultaneously in Two Instances | As of #11466 we no longer have any logic to prevent a user from opening a wallet twice in two instances simultaneously. Not only could this break BDB (without the -privdb=false option, which I have really no idea why we even have a tuneable option for that), but we certainly don't have logic to handle such a case gracefully. It was noted in the original PR's description, but somehow was never followed up on before merge. | https://github.com/bitcoin/bitcoin/issues/11888 | https://github.com/bitcoin/bitcoin/pull/11904 | 5260a4aca1e6c11e1dbca9d3390c0dc739e81204 | 2f3bd47d44634cfc0a4261e64af178407ce2869c | 2017-12-13T20:13:23Z | c++ | 2018-01-16T06:05:46Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,861 | ["doc/release-notes/release-notes-0.15.0.md"] | Multi-wallet RPC URI parsing invalid when ending with a slash | Using the newer RPC access point for multi-wallet support as described https://bitcoincore.org/en/releases/0.15.0/#multi-wallet-support will __not__ work if the URI ends with a slash ( `/` ).
In other words, all RPCs for multi-wallet would only work if the URI does not end with a slash.
Expected behavior:
Any RPC command (or by using _curl_ ) __should work__ for URI like `http://username:[email protected]:8332/wallet/wallet.dat/` regardless of the ending slash.
Actual behavior:
An error will be return `{"result":null,"error":{"code":-18,"message":"Requested wallet does not exist or is not loaded"},"id":"curltext"}` even when the wallet name is valid.
- `http://username:[email protected]:8332/wallet/wallet.dat` will work.
Reproduction steps:
1. Run `curl --data-binary '{"jsonrpc":"1.1","id":"curltext","method":"listreceivedbyaddress","params":[]}' -H 'content-type:text/plain;' http://username:[email protected]:8332/wallet/wallet.dat/`
Found in Version: 0.15.1
OS: Windows 10 Pro with Ubuntu WSL _(if this info matters)_
| https://github.com/bitcoin/bitcoin/issues/11861 | https://github.com/bitcoin/bitcoin/pull/12112 | 5e468994fbb349e8eefc996954a31a67a34aaa15 | 2be2b5d58a972b0ae1a63ffaadd50f69ce65d831 | 2017-12-11T05:24:43Z | c++ | 2018-01-08T02:11:02Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,837 | ["src/miner.h", "src/txmempool.h"] | CompareModifiedEntry::operator() not const | `CompareModifiedEntry`, as used in
https://github.com/bitcoin/bitcoin/blob/3c098a8aa0780009c11b66b1a5d488a928629ebf/src/miner.h#L97-L112
will trigger a compile-time error in many `const` operations of index #1 of `indexed_modified_transaction_set` because `CompareModifiedEntry::operator()` is not `const`.
Most likely related to:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224129 | https://github.com/bitcoin/bitcoin/issues/11837 | https://github.com/bitcoin/bitcoin/pull/11847 | 7630a1fe9a4c9a38b47fe385afb8d8a1902870d6 | 1ec0c0a01c316146434642ab2f14a7367306dbec | 2017-12-06T15:07:26Z | c++ | 2017-12-07T15:06:38Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,819 | ["test/functional/conf_args.py", "test/functional/test_runner.py"] | Stricter validation for CLI options and syntax | Using 0.15.1 from BitcoinCore.org:
```
$ bitcoin-qt -rescan 1 -wallet otherWallet.dat
PaymentServer::ipcSendCommandLine: Payment request file does not exist: "1"
"PaymentServer::verifySize: Payment request too large (720896 bytes, allowed 50000 bytes)."
```
Maybe this pilot error could be handled better. For example, Bitcoin-Qt (or bitcoind) could refuse to start.
Note that in the above case Bitcoin-Qt silently ends up using a wrong (default) wallet.
| https://github.com/bitcoin/bitcoin/issues/11819 | https://github.com/bitcoin/bitcoin/pull/11883 | ef8ba7d73a480197b756fab00126914e49de4e7b | be9a13c8a0f149ac219934b515399cca60bf2123 | 2017-12-02T19:01:52Z | c++ | 2017-12-19T23:23:12Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,811 | ["src/qt/coincontroldialog.cpp", "src/qt/coincontroldialog.h", "src/qt/forms/coincontroldialog.ui"] | Bitcoin-Qt Coin Selection window has unnecessary columns "9" and "10" | Maybe they have some purpose, but it isn't immediately obvious. I tried Tree & List mode, they're never populated.
* Bitcoin-Qt 0.15.1 for Ubuntu 16.04 x64 (from http://ppa.launchpad.net/bitcoin/bitcoin/ubuntu xenial/main amd64)
Note: I just noticed I'm *not* seeing this on Ubuntu 17.10 x64 with 0.15.1 downloaded from bitcoincore.org.
| https://github.com/bitcoin/bitcoin/issues/11811 | https://github.com/bitcoin/bitcoin/pull/14828 | 600b85bb417295f4d9c7d5b9fd8502f3c8f113e3 | 1c28feb7d026bc18304149d96f81888059d52670 | 2017-12-01T15:14:46Z | c++ | 2018-11-29T07:58:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,778 | ["test/functional/rpc_net.py"] | [qa] Net.py fails occasionally | In net.py we compare the exact number of bytes transmitted or received of two subsequently called rpcs. This fails occasionally. I hypothesise that this might be caused by cross-traffic that happens in between those rpcs, which are obviously not called atomically.
If that is the case, we might be able to repeat the calls up to ${n} times and hope that cross-traffic does not happen in all ${n} cases.
Relevant example log:
* https://travis-ci.org/bitcoin/bitcoin/jobs/305878397 | https://github.com/bitcoin/bitcoin/issues/11778 | https://github.com/bitcoin/bitcoin/pull/12804 | ac898b689c660df8a79cc64997dda66d36eb59dd | 5a67c0524e5dc98d0e387f189545bc99863916d4 | 2017-11-27T21:29:46Z | c++ | 2018-03-28T19:35:35Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,715 | ["doc/release-notes.md", "src/keystore.cpp", "src/keystore.h", "src/wallet/rpcdump.cpp", "test/functional/wallet-dump.py"] | dumpwallet problem | I noticed there is a problem with dumpwallet option. It does not seem to dump segwit addresses ("3"), and dumps only the standard one ("1"). Is it a bug or work as intended? How can I perform full dump of an wallet then? | https://github.com/bitcoin/bitcoin/issues/11715 | https://github.com/bitcoin/bitcoin/pull/11667 | 1bab9b23af95986f9452d468257cc34d2c5017b2 | 656fde53a3a0d88a1e3c1aef7ae99083e4b06a7d | 2017-11-18T10:06:47Z | c++ | 2017-12-20T07:24:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,696 | ["test/functional/p2p_segwit.py"] | qa: failure in p2p_segwit | Saw this the first time and keeping track of it by filing an issue.
```
File "p2p-segwit.py", line 1006, in test_block_relay
assert_equal(wit_block.serialize(True), hex_str_to_bytes(rpc_block))
```
Commit: 927a1d7d088e52aa079682e1d4f514222c0a2069
Job: https://travis-ci.org/bitcoin/bitcoin/jobs/302552842 | https://github.com/bitcoin/bitcoin/issues/11696 | https://github.com/bitcoin/bitcoin/pull/18213 | 4c42a13205a1b75c9b4c171d4eae4716dca646e3 | 2737197ff39f98b0fbdf0fe913c1a7c8ee0f318c | 2017-11-15T18:20:42Z | c++ | 2020-03-12T13:15:43Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,673 | ["test/functional/sendheaders.py"] | Intermittent error in sendheaders.py (test_null_locators) | I'm locally experiencing an intermittent error in sendheaders.py. @MeshCollider mentioned on IRC he also encountered it.
- function: test_null_locators
- line: assert_equal(test_node.check_last_announcement(headers=[tip_hash]), True)
Output:
```
sendheaders.py failed, Duration: 1 s
stdout:
2017-11-13 07:21:38.682000 TestFramework (INFO): Initializing test directory /tmp/bitcoin_test_runner_20171113_082031/sendheaders_254
2017-11-13 07:21:39.168000 TestFramework.mininode (INFO): Connecting to Bitcoin Node: 127.0.0.1:13032
2017-11-13 07:21:39.168000 TestFramework.mininode (INFO): Connecting to Bitcoin Node: 127.0.0.1:13032
2017-11-13 07:21:39.326000 TestFramework (INFO): Verify getheaders with null locator and valid hashstop returns headers.
2017-11-13 07:21:39.377000 TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/data/src/bitcoin/test/functional/test_framework/test_framework.py", line 120, in main
self.run_test()
File "/home/user/src/bitcoin/test/functional/sendheaders.py", line 235, in run_test
self.test_null_locators(test_node)
File "/home/user/src/bitcoin/test/functional/sendheaders.py", line 245, in test_null_locators
assert_equal(test_node.check_last_announcement(headers=[tip_hash]), True)
File "/data/src/bitcoin/test/functional/test_framework/util.py", line 38, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(False == True)
2017-11-13 07:21:39.405000 TestFramework (INFO): Stopping nodes
2017-11-13 07:21:39.659000 TestFramework (WARNING): Not cleaning up dir /tmp/bitcoin_test_runner_20171113_082031/sendheaders_254
2017-11-13 07:21:39.659000 TestFramework (ERROR): Test failed. Test logging available at /tmp/bitcoin_test_runner_20171113_082031/sendheaders_254/test_framework.log
stderr:
``` | https://github.com/bitcoin/bitcoin/issues/11673 | https://github.com/bitcoin/bitcoin/pull/11707 | f0c4ab9a7034aca6be83fcb6cd8479cd19a196a2 | 9d42cc333139d7101a9223421d9eabcddfd0b025 | 2017-11-13T07:46:15Z | c++ | 2017-11-17T22:15:28Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,612 | ["src/net.cpp"] | Peer is still banned, allthough ban endtime has been reached | ### Peer is still banned, allthough ban endtime has been reached
Here the log line of the banned peer:
`2017-11-04 16:12:03 Misbehaving: 212.203.47.xxx:61681 peer=56085 (0 -> 100) BAN THRESHOLD EXCEEDED`
In the debug connection window, the peer shows up as banned, with the ban endtime of 2017-11-05 17:12:03 CET, see screenshot (marked blue peer).
Then today, 2017-11-05 around 10 o clock CET, I stopped bitcoind 0.15.0.1, replaced the binaries with 0.15.1rc1 and started bitcoind again.
Now, as the time of the screenshot is 17:40 CET, the ban endtime had been reached, but the peer does still show up as banned.
Edit: Situation unchanged at 20:46 CET.
### Expected behaviour
Peer disappears from the "Banned peers" list, when ban endtime has been reached.
### Actual behaviour
Peer does not disappear from the "Banned peers" list, allthough ban endtime has been reached and exceeded.
### Screenshots.
### What version of bitcoin-core are you using?
0.15.0.1 / 0.15.1rc1
### Machine specs:
Linux amd64
| https://github.com/bitcoin/bitcoin/issues/11612 | https://github.com/bitcoin/bitcoin/pull/11616 | c8538123a7618343056b8ca2bc7445de8f0620ec | 57ac471a294fc7039140eed91d217ad1af7fa7af | 2017-11-05T16:59:43Z | c++ | 2017-11-19T22:51:44Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,588 | ["src/wallet/rpcwallet.cpp"] | "bitcoin-cli help" does not show how to encrypt additional multi wallets | ### Describe the issue
I added a second new wallet2.dat. Now I wanted to encrypt it, but `bitcoin-cli help` does not show the command to do so, I need to use `bitcoin-cli -rpcwallet=wallet2.dat help`. This is very un-intuitive, and bad for a help function.
### Can you reliably reproduce the issue?
1. have an encrypted default wallet
2. add new multi wallet wallet2.dat via config file or cmd line options
3. naive `bitcoin-cli help` does not show command to encrypt second wallet.
### Expected behaviour
All wallet encryption, lock and unlock commands should be shown unconditionally in `bitcoin-cli help`.
The dynamic hiding of some lines is arguably worse than the benefit with multiple wallets.
### Actual behaviour
`bitcoin-cli help` shows only wallet encryption commands appropriate for the default wallet.
### What version of bitcoin-core are you using?
bitcoind 0.15.0.1~dfsg-1
deb http://ppa.launchpad.net/luke-jr/bitcoin-core-bip148-unofficial-builds/ubuntu zesty main
### Machine specs:
- OS: Debian 9.2
| https://github.com/bitcoin/bitcoin/issues/11588 | https://github.com/bitcoin/bitcoin/pull/11590 | 8335cb478183d800e274f6e96f9d7269ae584220 | 720d9e8fa1d1c7516e8278eaaf60789d2f2c8a53 | 2017-10-31T22:27:31Z | c++ | 2017-11-01T06:22:41Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,561 | ["test/functional/rpc_rawtransaction.py"] | Negative version of transaction using json-rpc | Hi!
I have to ask about the strange transaction version, I get this data using bitcoin json-rpc API.
If I posted this issue in another project, navigate me please certain url where I have to post my issue.
Bitcoin-core version:
bitcoind@machinename:/home/username$ bitcoin-cli -version
Bitcoin Core RPC client version v0.14.2.0-gfc61c83
OS version: Linux Ubuntu 16.04
Problem:
I try to get version of transaction with hash "c659729a7fea5071361c2c1a68551ca2bf77679b27086cc415adeeb03852e369"
See the curl output below:
root@machinename:/tmp# curl --data-binary '{"method":"getrawtransaction","id":"a2e8f6b0-5c03-4315-a067-050a9adb6dfc","params":["c659729a7fea5071361c2c1a68551ca2bf77679b27086cc415adeeb03852e369",1]}' "http://[email protected]:18833"
{"result":{"hex":"f0b47b9a01ecf5e5c3bbf2cf1f71ecdc7f708b0b222432e914b394e24aad1494a42990ddfc000000008b483045022100852744642305a99ad74354e9495bf43a1f96ded470c256cd32e129290f1fa191022030c11d294af6a61b3da6ed2c0c296251d21d113cfd71ec11126517034b0dcb70014104a0fe6e4a600f859a0932f701d3af8e0ecd4be886d91045f06a5a6b931b95873aea1df61da281ba29cadb560dad4fc047cf47b4f7f2570da4c0b810b3dfa7e500ffffffff0240420f00000000001976a9147eeacb8a9265cd68c92806611f704fc55a21e1f588ac05f00d00000000001976a914eb3bd8ccd3ba6f1570f844b59ba3e0a667024a6a88acff7f0000","txid":"c659729a7fea5071361c2c1a68551ca2bf77679b27086cc415adeeb03852e369","hash":"c659729a7fea5071361c2c1a68551ca2bf77679b27086cc415adeeb03852e369","size":258,"vsize":258,"version":-1703168784,"locktime":32767,"vin":[{"txid":"fcdd9029a49414ad4ae294b314e93224220b8b707fdcec711fcff2bbc3e5f5ec","vout":0,"scriptSig":{"asm":"3045022100852744642305a99ad74354e9495bf43a1f96ded470c256cd32e129290f1fa191022030c11d294af6a61b3da6ed2c0c296251d21d113cfd71ec11126517034b0dcb70[ALL] 04a0fe6e4a600f859a0932f701d3af8e0ecd4be886d91045f06a5a6b931b95873aea1df61da281ba29cadb560dad4fc047cf47b4f7f2570da4c0b810b3dfa7e500","hex":"483045022100852744642305a99ad74354e9495bf43a1f96ded470c256cd32e129290f1fa191022030c11d294af6a61b3da6ed2c0c296251d21d113cfd71ec11126517034b0dcb70014104a0fe6e4a600f859a0932f701d3af8e0ecd4be886d91045f06a5a6b931b95873aea1df61da281ba29cadb560dad4fc047cf47b4f7f2570da4c0b810b3dfa7e500"},"sequence":4294967295}],"vout":[{"value":0.01000000,"n":0,"scriptPubKey":{"asm":"OP_DUP OP_HASH160 7eeacb8a9265cd68c92806611f704fc55a21e1f5 OP_EQUALVERIFY OP_CHECKSIG","hex":"76a9147eeacb8a9265cd68c92806611f704fc55a21e1f588ac","reqSigs":1,"type":"pubkeyhash","addresses":["1Ca5R26xpiQCwjz3aFq1fuCR3fuEe8tmjE"]}},{"value":0.00913413,"n":1,"scriptPubKey":{"asm":"OP_DUP OP_HASH160 eb3bd8ccd3ba6f1570f844b59ba3e0a667024a6a OP_EQUALVERIFY OP_CHECKSIG","hex":"76a914eb3bd8ccd3ba6f1570f844b59ba3e0a667024a6a88ac","reqSigs":1,"type":"pubkeyhash","addresses":["1NSoVKD8ciGUUQE5rN4AMbKSg9SEXb34Q3"]}}],"blockhash":"0000000000000007bed1f8466a98c8bc483369ba611c59443895348a1f7ef8ce","confirmations":234887,"time":1378684263,"blocktime":1378684263},"error":null,"id":"a2e8f6b0-5c03-4315-a067-050a9adb6dfc"}
Notice: "version":-1703168784
negative version.
### Expected behaviour
positive version of transaction
### Actual behaviour
negative version of transaction
### What version of bitcoin-core are you using?
Bitcoin Core RPC client version v0.14.2.0-gfc61c83
### Machine specs:
- OS: Linux Ubuntu 16.04
- CPU: 8
- RAM: 8 GB
- Disk size: 800 gb
- Disk Type (HD/SDD): SSD | https://github.com/bitcoin/bitcoin/issues/11561 | https://github.com/bitcoin/bitcoin/pull/12436 | 5f0c6a7b0e47e03f848dc992d37fe209dd9c6975 | 09b30db2b02aef03d15c2def9181bce93db400bb | 2017-10-25T20:24:46Z | c++ | 2018-04-06T19:47:29Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,537 | ["src/Makefile.test.include", "src/net.cpp", "src/net.h", "src/test/fuzz/node_eviction.cpp", "src/test/net_peer_eviction_tests.cpp", "src/test/net_tests.cpp"] | Add an option for evenly connecting to nodes on different types of networks | ### FEATURE REQUEST
Currently, when a bitcoin node is set up with a connection to both TOR and normal IPv4/6 internet, the 8 outbound-only connection slots, almost always get filled with nodes connecting over IP.
Adding a config option, which would try to ballance these connections based on what kind of network they go through, would be benefficial in many ways:
1. It would add edges between bitcoin network on TOR and normal internet, reducing delays, and the risks associated with an attacker isolating a part of TOR-bitcoin-network from the rest of the world
(Or an ISP/government man-in-the-middling all the normal IP connections)
2. It would help hide/annonymise normal user's transactions from his/her ISP, by mixing them with TOR-outbound ones
3. It would reduce the stress on normal general purpose TOR exit nodes, as users would more likely/reliably connect to TOR-IPv4/6 bitcoin nodes instead of exiting into normal internet first, and then connecting to default IPv4/6-only bitcoin nodes
I understand it is possible to create such bridges already, by forcing connections to TOR-only nodes, or by just running a node with lots of inbound slots, but I think the proposed option, would greatly increase the number of such relays, and remove the need for user to maintain a TOR-node whitelist, by handing this work off to normal bitcoind connection finding algorithm.
This could be implemented as a minimum number of connections for each network, or just a simple evening boolean switch. (Which could be enabled by default for bitcoind installs with TOR connectivity)
In the future, if bitcoin was to support a new network type (for example cjdns/I2P/GNUnet), this option would help establish a presence on the new network faster
bitcoind: 0.15 | https://github.com/bitcoin/bitcoin/issues/11537 | https://github.com/bitcoin/bitcoin/pull/20197 | 1999baac30a1fc8328f3f175ad2a762c5114666d | dede9eb9247363aacc3816c7352494a3609fa28b | 2017-10-20T18:57:48Z | c++ | 2021-03-30T14:20:47Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,464 | ["src/qt/transactionrecord.cpp", "src/qt/transactiontablemodel.cpp"] | Payment to yourself shows no address in Qt client | ## Issue
When transacting unspent inputs to a new address in own wallet, the qt registers it as 'payment to yourself' without showing the receiving address. That can only be seen in the details or via 'listunspent' command
## Can you reliably reproduce the issue?
Yes
## If so, please list the steps to reproduce below:
1. create raw transaction to own address with multiple inputs
2. send the raw transaction with a miner fee
3. overall balance stays the same minus miner fee, in the transactions tab shows 'payment to yourself' without the receiving address
## Expected behaviour
I'd expect the payment to show up as a received payment with (my own) recipient address and 'payment to self' tag.
## Actual behaviour
Qt client only shows miner fee as 'transacted' and shows what seems to be an empty transaction without a receiving address in the transactions tab.
## Screenshots.
### What version of bitcoin-core are you using?
List the version number/commit ID, and if it is an official binary, self compiled or a distribution package such as PPA.
Core 14.02
### Machine specs:
- OS: Ubuntu 14.04
- CPU: amd
- RAM: 8G
- Disk size: 360Gb
- Disk Type (HD/SDD):Sata
### Any extra information that might be useful in the debugging process.
| https://github.com/bitcoin/bitcoin/issues/11464 | https://github.com/bitcoin/bitcoin/pull/15098 | 1d73636fdf1ef85c1f62841953e1cf01a6c3bfd0 | 11fdfcf7f940fab48625d102e825a59c16ad4fbc | 2017-10-08T21:15:51Z | c++ | 2019-01-06T09:52:37Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,461 | ["depends/packages/qt.mk", "depends/patches/qt/fix-cocoahelpers-macos.patch"] | [depends] Qt build broken with latest Xcode | Building Qt in depends is broken on macOS (10.12.6) with the latest Xcode.
```
compiling main.mm
compiling qcocoahelpers.mm
qcocoahelpers.mm:658:39: error: use of undeclared identifier 'InvalidContext'
require_action(inContext != NULL, InvalidContext, err = paramErr);
^
qcocoahelpers.mm:659:38: error: use of undeclared identifier 'InvalidBounds'
require_action(inBounds != NULL, InvalidBounds, err = paramErr);
^
qcocoahelpers.mm:660:37: error: use of undeclared identifier 'InvalidImage'
require_action(inImage != NULL, InvalidImage, err = paramErr);
^
qcocoahelpers.mm:702:20: warning: 'OpenDefaultComponent' is deprecated: first deprecated in macOS 10.8 [-Wdeprecated-declarations]
theComponent = OpenDefaultComponent(kOSAComponentType, typeAppleScript);
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Components.h:1004:1: note:
'OpenDefaultComponent' has been explicitly marked deprecated here
OpenDefaultComponent(
^
qcocoahelpers.mm:736:9: warning: 'CloseComponent' is deprecated: first deprecated in macOS 10.8 [-Wdeprecated-declarations]
CloseComponent(theComponent);
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Components.h:593:1: note:
'CloseComponent' has been explicitly marked deprecated here
CloseComponent(ComponentInstance aComponentInstance) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_0, __MAC_10_8, __IPHONE_NA, __IPHONE_NA);
^
2 warnings and 3 errors generated.
make[4]: *** [.obj/qcocoahelpers.o] Error 1
```
Upstream issues here:
[5.6 branch](https://bugreports.qt.io/browse/QTBUG-63401)
[5.9 branch](https://bugreports.qt.io/browse/QTBUG-62266) | https://github.com/bitcoin/bitcoin/issues/11461 | https://github.com/bitcoin/bitcoin/pull/11995 | 7f999643212d0e9de5296ded90909ece5a7a6ff1 | 2b1f7945747b59215b5f07573cf6cae4a269d3bf | 2017-10-07T06:08:36Z | c++ | 2018-03-05T18:51:14Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,450 | ["src/qt/test/wallettests.cpp", "src/test/test_bitcoin.h", "src/wallet/rpcwallet.cpp", "src/wallet/test/wallet_tests.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h"] | ScanForWalletTransactions return value is incorrectly documented | `ScanForWalletTransactions()` has the following comment about its return value:
```
* Returns null if scan was successful. Otherwise, if a complete rescan was not
* possible (due to pruning or corruption), returns pointer to the most recent
* block that could not be scanned.
```
This is not strictly true. If `abortrescan` is called, then `ScanForWalletTransactions()` will return `nullptr`, even though the scan wasn't successful to the tip.
This in turn causes a minor bug in `importmulti`, where the call doesn't return the correct error and warning about potentially not finding transactions if `abortrescan` was called.
I think the correct fix is for `ScanForWalletTransactions()` to inform the caller that the rescan was aborted. | https://github.com/bitcoin/bitcoin/issues/11450 | https://github.com/bitcoin/bitcoin/pull/13076 | 3002d6cf31821622e9f21d51e536cafc5cfb10ae | bd3b0361d840bff95988a048abf70ade94d80524 | 2017-10-04T14:22:04Z | c++ | 2018-11-13T17:51:16Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,375 | ["src/wallet/db.cpp", "test/functional/walletbackup.py"] | Backupwallet RPC call destroyed wallet if target equals the source wallet file | When the target for backupwallet is the source wallet file or directory, the wallet file is cleared to zero length
### Reproduce
bitcoin-cli backupwallet ~/.bitcoin/
### Expected behaviour
Command should fail
### Actual behaviour
Wallet is destroyed.
Reported here
https://www.reddit.com/r/btc/comments/719kz3/just_lost_4bch_backing_up_my_walletdat_file/
Fix proposed in #11376 | https://github.com/bitcoin/bitcoin/issues/11375 | https://github.com/bitcoin/bitcoin/pull/11376 | 5a9da37fb3f4b53f556e1d46509b94dc3c661d75 | 5d465e396249a0e2cc60b16984a2bdbe4c8993c3 | 2017-09-20T22:12:03Z | c++ | 2017-10-10T12:49:47Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,355 | ["src/dbwrapper.cpp"] | LevelDB read failure: Corruption: block checksum mismatch | Build against commit f197a4c515757262eda0accbe762e311335be11b, a small change from master branch 09627b1dd41d1151a709d5ead82a924bf59e3d38 - bitcoin-qt had been running for 12 hours or so without a problem, was fully synced, then suddenly I saw an error frame pop up with no content. Here's a screenshot:
The debug.log shows block 485584 was received, then 36 seconds later db corruption was found:
2017-09-16 15:21:03 UpdateTip: new best=000000000000000000f9dec71fb25bda22ba734ad133c24c8553fb66fee2f98e height=485584 version=0x20000000 log2_work=87.116783 tx=254942322 date='2017-09-16 15:20:14' progress=0.999999 cache=65.6MiB(504658txo) warning='5 of last 100 blocks have unexpected version'
2017-09-16 15:21:39 LevelDB read failure: Corruption: block checksum mismatch
2017-09-16 15:21:39 Corruption: block checksum mismatch
2017-09-16 15:22:02 connect() to [2001:0:9d38:90d7:1097:91ba:f1ff:5782]:8333 failed: Network is unreachable (101)
2017-09-16 15:41:38 socket sending timeout: 1201s
2017-09-16 15:41:38 socket sending timeout: 1201s
2017-09-16 15:41:38 socket sending timeout: 1201s
2017-09-16 15:41:39 socket sending timeout: 1201s
2017-09-16 15:41:39 socket sending timeout: 1201s
2017-09-16 15:41:39 socket sending timeout: 1201s
2017-09-16 15:41:39 socket sending timeout: 1201s
2017-09-16 15:41:40 socket sending timeout: 1201s
Nothing has been written to the log since then, and neither the main Bitcoin window nor the error popup has been painted since.
A few weeks ago I saw a similar error, but at that point I was attempting to track down a race condition on startup and so wasn't surprised when I saw some database corruption. But I fixed it by doing a `-reindex-chainstate` and hadn't had a problem since, until now.
I attached gdb to the frozen bitcoin-qt process to get the stack traces:
12:51:18 chris@chris:~/Programs/bitcoin.git/src$ ps -ef | grep bitcoin
chris 17648 31052 0 Sep15 pts/5 00:03:57 /home/chris/Programs/bitcoin.git/src/qt/bitcoin-qt -datadir=/home/chris/.bitcoin
chris 23785 31653 0 08:22 pts/7 00:00:00 tail -f /home/chris/.bitcoin/debug.log
chris 28346 14411 0 12:51 pts/0 00:00:00 grep bitcoin
12:51:53 chris@chris:~/Programs/bitcoin.git/src$ gdb /home/chris/Programs/bitcoin.git/src/qt/bitcoin-qt 17648
GNU gdb (Debian 7.12-6) 7.12.0.20161007-git
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /home/chris/Programs/bitcoin.git/src/qt/bitcoin-qt...done.
Attaching to program: /home/chris/Programs/bitcoin.git/src/qt/bitcoin-qt, process 17648
[New LWP 17649]
[New LWP 17650]
[New LWP 17651]
[New LWP 17652]
[New LWP 17653]
[New LWP 17654]
[New LWP 17655]
[New LWP 17656]
[New LWP 17657]
[New LWP 17658]
[New LWP 17659]
[New LWP 17660]
[New LWP 17664]
[New LWP 17671]
[New LWP 17673]
[New LWP 17674]
[New LWP 17675]
[New LWP 17676]
[New LWP 17677]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
__lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
135 ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S: No such file or directory.
(gdb) thread apply all where
Thread 20 (Thread 0x7ff63debb700 (LWP 17677)):
#0 0x00007ff692d586ad in poll () at ../sysdeps/unix/syscall-template.S:84
#1 0x00007ff69068f9f6 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007ff69068fb0c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x00007ff69532004f in QEventDispatcherGlib::processEvents (this=0x7ff6240008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:423
#4 0x00007ff6952c99ca in QEventLoop::exec (this=this@entry=0x7ff63debacc0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:212
#5 0x00007ff6950f70f3 in QThread::exec (this=<optimized out>) at thread/qthread.cpp:507
#6 0x00007ff6950fbda8 in QThreadPrivate::start (arg=0x56128c7f02a0) at thread/qthread_unix.cpp:368
#7 0x00007ff6947b9494 in start_thread (arg=0x7ff63debb700) at pthread_create.c:333
#8 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 19 (Thread 0x7ff63d245700 (LWP 17676)):
#0 0x00007ff692d586ad in poll () at ../sysdeps/unix/syscall-template.S:84
#1 0x00007ff69068f9f6 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007ff69068fb0c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x00007ff69532004f in QEventDispatcherGlib::processEvents (this=0x7ff6200008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:423
#4 0x00007ff6952c99ca in QEventLoop::exec (this=this@entry=0x7ff63d244cc0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:212
#5 0x00007ff6950f70f3 in QThread::exec (this=<optimized out>) at thread/qthread.cpp:507
#6 0x00007ff6950fbda8 in QThreadPrivate::start (arg=0x56128b923d40) at thread/qthread_unix.cpp:368
#7 0x00007ff6947b9494 in start_thread (arg=0x7ff63d245700) at pthread_create.c:333
#8 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 18 (Thread 0x7ff63e70c700 (LWP 17675)):
#0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1 0x00007ff6950fcc6b in QWaitConditionPrivate::wait (time=18446744073709551615, this=0x7ff633dd4480) at thread/qwaitcondition_unix.cpp:143
#2 QWaitCondition::wait (this=this@entry=0x7ff6154c9468, mutex=mutex@entry=0x7ff6154c9460, time=time@entry=18446744073709551615)
at thread/qwaitcondition_unix.cpp:215
#3 0x00007ff6950f5b33 in QSemaphore::acquire (this=this@entry=0x7ff63e702890, n=n@entry=1) at thread/qsemaphore.cpp:143
#4 0x00007ff6952d68cd in QMetaMethod::invoke (this=this@entry=0x7ff63e702af8, object=object@entry=0x56128b9167c0, connectionType=Qt::BlockingQueuedConnection,
connectionType@entry=1047538560, returnValue=..., val0=..., val1=..., val2=..., val3=..., val4=..., val5=..., val6=..., val7=..., val8=..., val9=...)
at kernel/qmetaobject.cpp:2279
#5 0x00007ff6952dc58a in QMetaObject::invokeMethod (obj=0x56128b9167c0, member=0x56128a8e58de "message", type=1047538560, ret=..., val0=..., val1=..., val2=...,
val3=..., val4=..., val5=..., val6=..., val7=..., val8=..., val9=...) at kernel/qmetaobject.cpp:1489
#6 0x000056128a01880c in QMetaObject::invokeMethod (member=0x80 <error: Cannot access memory at address 0x80>, type=Qt::BlockingQueuedConnection, val0=...,
obj=<optimized out>, val1=..., val2=..., val3=..., val4=..., val5=..., val6=..., val7=..., val8=..., val9=...)
at /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs.h:460
#7 ThreadSafeMessageBox (gui=0x56128b9167c0, message="Error reading from database, shutting down.", caption=..., style=<optimized out>) at qt/bitcoingui.cpp:1167
#8 0x000056128a01ccb7 in boost::_bi::list4<boost::_bi::value<BitcoinGUI*>, boost::arg<1>, boost::arg<2>, boost::arg<3> >::operator()<bool, bool (*)(BitcoinGUI*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::_bi::rrlist3<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int> > (f=<error reading variable>, this=<optimized out>, a=...)
at /usr/include/boost/bind/bind.hpp:453
#9 boost::_bi::bind_t<bool, bool (*)(BitcoinGUI*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::_bi::list4<boost::_bi::value<BitcoinGUI*>, boost::arg<1>, boost::arg<2>, boost::arg<3> > >::operator()<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int&&) (a1=<error reading variable: Cannot access memory at address 0x88>,
a2=<error reading variable: Cannot access memory at address 0x9>, this=<optimized out>, a3=<optimized out>) at /usr/include/boost/bind/bind.hpp:1330
#10 boost::detail::function::function_obj_invoker3<boost::_bi::bind_t<bool, bool (*)(BitcoinGUI*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::_bi::list4<boost::_bi::value<BitcoinGUI*>, boost::arg<1>, boost::arg<2>, boost::arg<3> > >, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int>::invoke (function_obj_ptr=...,
a0=<error reading variable: Cannot access memory at address 0x88>, a1=<error reading variable: Cannot access memory at address 0x9>, a2=2491150687)
at /usr/include/boost/function/function_template.hpp:138
#11 0x000056128a17b81e in boost::function3<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int>::operator() (a0=<error reading variable: Cannot access memory at address 0x88>,
a1=<error reading variable: Cannot access memory at address 0x9>, a2=2491150687, this=<optimized out>) at /usr/include/boost/function/function_template.hpp:770
#12 boost::signals2::detail::call_with_tuple_args<bool>::m_invoke<boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)>, 0u, 1u, 2u, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int&>(boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)>&, boost::signals2::detail::unsigned_meta_array<0u, 1u, 2u>, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int&> const&, boost::disable_if<boost::is_void<boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)>::result_type>, void>::type*) const (this=<optimized out>, func=..., args=...)
at /usr/include/boost/signals2/detail/variadic_slot_invoker.hpp:98
#13 boost::signals2::detail::call_with_tuple_args<bool>::operator()<boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int&, 3ul>(boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)>&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int&> const&, mpl_::size_t<3ul>) const (this=<optimized out>, func=..., args=...)
at /usr/include/boost/signals2/detail/variadic_slot_invoker.hpp:90
#14 boost::signals2::detail::variadic_slot_invoker<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int>::operator()<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > >(boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > const&) const (
this=<optimized out>, connectionBody=...) at /usr/include/boost/signals2/detail/variadic_slot_invoker.hpp:133
#15 boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> >::dereference() const (this=0x7ff63e703010) at /usr/include/boost/signals2/detail/slot_call_iterator.hpp:110
#16 0x000056128a17ac98 in boost::iterators::iterator_core_access::dereference<boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > >(boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > const&) (f=...) at /usr/include/boost/iterator/iterator_facade.hpp:549
#17 boost::iterators::detail::iterator_facade_base<boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> >, bool, boost::iterators::single_pass_traversal_tag, bool&, long, false, false>::operator*() const (
this=<optimized out>) at /usr/include/boost/iterator/iterator_facade.hpp:655
#18 boost::signals2::last_value<bool>::operator()<boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > >(boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> >, boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> >) const (this=<optimized out>, first=..., last=...) at /usr/include/boost/signals2/last_value.hpp:48
#19 0x000056128a17a930 in boost::signals2::detail::combiner_invoker<bool>::operator()<boost::signals2::last_value<bool>, boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > >(boost::signals2::last_value<bool>&, boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> >, boost::signals2::detail::slot_call_iterator_t<boost::signals2::detail::variadic_slot_invoker<bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int>, std::_List_iterator<boost::shared_ptr<boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> > >, boost::signals2::detail::connection_body<std::pair<boost::signals2::detail::slot_meta_group, boost::optional<int> >, boost::signals2::slot<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)> >, boost::signals2::mutex> >) const (combiner=..., this=<optimized out>, first=..., last=...) at /usr/include/boost/signals2/detail/result_type_wrapper.hpp:53
#20 boost::signals2::detail::signal_impl<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::signals2::last_value<bool>, int, std::less<int>, boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)>, boost::function<bool (boost::signals2::connection const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)>, boost::signals2::mutex>::operator()(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int) (
this=0x56128b705d20, args=<optimized out>, args=<optimized out>, args=<optimized out>) at /usr/include/boost/signals2/detail/signal_template.hpp:242
#21 0x000056128a17a13d in boost::signals2::signal<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int), boost::signals2::last_value<bool>, int, std::less<int>, boost::function<bool (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)>, boost::function<bool (boost::signals2::connection const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)>, boost::signals2::mutex>::operator()(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int) (args=..., args=..., this=<optimized out>, args=...) at /usr/include/boost/signals2/detail/signal_template.hpp:723
#22 CCoinsViewErrorCatcher::GetCoin (this=<optimized out>, outpoint=..., coin=...) at init.cpp:143
#23 0x000056128a46e462 in CCoinsViewCache::FetchCoin (this=0x7ff648ab9ee0, outpoint=...) at coins.cpp:48
#24 0x000056128a46e549 in CCoinsViewCache::GetCoin (this=0x7ff633dd44ac, outpoint=..., coin=...) at coins.cpp:61
#25 0x000056128a2c8414 in CCoinsViewMemPool::GetCoin (this=0x7ff63e7038a8, outpoint=..., coin=...) at txmempool.cpp:902
#26 0x000056128a46e462 in CCoinsViewCache::FetchCoin (this=0x7ff63e704530, outpoint=...) at coins.cpp:48
#27 0x000056128a46eb03 in CCoinsViewCache::HaveCoin (this=0x7ff633dd44ac, outpoint=...) at coins.cpp:129
#28 0x000056128a30c5cc in AcceptToMemoryPoolWorker (chainparams=..., pool=..., state=..., ptx=..., fLimitFree=<optimized out>, pfMissingInputs=<optimized out>,
nAcceptTime=140697029833055, plTxnReplaced=0x56128acc70f0 <pcoinsTip>, fOverrideMempoolLimit=false, nAbsurdFee=@0x7ff63e7044d0: -2962908112588391035,
coins_to_uncache=...) at validation.cpp:547
#29 0x000056128a2de858 in AcceptToMemoryPoolWithTime (chainparams=..., pool=..., state=...,
tx=<error reading variable: Cannot access memory at address 0x1be08247c8b50>, fLimitFree=<optimized out>, pfMissingInputs=0x0, nAcceptTime=1505575299,
plTxnReplaced=0x7ff63e7083a8, fOverrideMempoolLimit=<optimized out>, nAbsurdFee=0) at validation.cpp:886
#30 0x000056128a2de122 in AcceptToMemoryPool (pool=..., state=..., tx=<error reading variable: Cannot access memory at address 0x1be08247c8b50>, fLimitFree=true,
pfMissingInputs=0x0, plTxnReplaced=0x7ff63e7083a8, fOverrideMempoolLimit=<optimized out>, nAbsurdFee=<optimized out>) at validation.cpp:902
#31 0x000056128a1d7266 in ProcessMessage (pfrom=<optimized out>, strCommand=..., vRecv=..., nTimeReceived=<optimized out>, chainparams=...,
connman=<optimized out>, interruptMsgProc=...) at net_processing.cpp:1791
#32 0x000056128a1cbf12 in PeerLogicValidation::ProcessMessages (this=0x7ff664046440, pfrom=0x7ff62822f0f0, interruptMsgProc=...) at net_processing.cpp:2718
#33 0x000056128a1f8037 in non-virtual thunk to PeerLogicValidation::ProcessMessages(CNode*, std::atomic<bool>&) () at net_processing.cpp:2643
#34 0x000056128a1a767b in CConnman::ThreadMessageHandler (this=<optimized out>) at net.cpp:1995
#35 0x000056128a1c24ba in std::__invoke_impl<void, void (CConnman::* const&)(), CConnman*&> (__f=<optimized out>, __t=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:227
#36 std::__invoke<void (CConnman::* const&)(), CConnman*&> (__fn=<optimized out>, __args=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:250
#37 std::_Mem_fn_base<void (CConnman::*)(), true>::operator()<CConnman*&> (this=<optimized out>, __args=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:604
#38 std::_Bind<std::_Mem_fn<void (CConnman::*)()> (CConnman*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) (this=<optimized out>,
__args=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:933
#39 std::_Bind<std::_Mem_fn<void (CConnman::*)()> (CConnman*)>::operator()<, void>() (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:991
#40 std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (CConnman::*)()> (CConnman*)> >::_M_invoke(std::_Any_data const&) (__functor=...)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1731
#41 0x000056128a176e3d in std::function<void ()>::operator()() const (this=0x7ff63e70bd00)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:2127
#42 TraceThread<std::function<void ()> >(char const*, std::function<void ()>) (name=<optimized out>, func=...) at ./util.h:309
#43 0x000056128a1c267d in std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)>::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) (this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1390
#44 std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)>::operator()() (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1380
#45 std::thread::_State_impl<std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)> >::_M_run() (
this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/thread:197
#46 0x00007ff6935ece6f in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#47 0x00007ff6947b9494 in start_thread (arg=0x7ff63e70c700) at pthread_create.c:333
#48 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 17 (Thread 0x7ff63ef5d700 (LWP 17674)):
#0 __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
#1 0x00007ff6947bbc06 in __GI___pthread_mutex_lock (mutex=0x56128acc6b88 <cs_main>) at ../nptl/pthread_mutex_lock.c:115
#2 0x000056128a0259d5 in boost::recursive_mutex::lock (this=<optimized out>) at /usr/include/boost/thread/pthread/recursive_mutex.hpp:113
#3 AnnotatedMixin<boost::recursive_mutex>::lock (this=<optimized out>) at ./sync.h:59
#4 boost::unique_lock<CCriticalSection>::lock (this=0x7ff63ef5c250) at /usr/include/boost/thread/lock_types.hpp:346
#5 0x000056128a1c406a in CMutexLock<CCriticalSection>::Enter (this=0x56128acc6b88 <cs_main>, nLine=504, pszName=<optimized out>, pszFile=<optimized out>)
at ./sync.h:123
#6 CMutexLock<CCriticalSection>::CMutexLock (this=0x56128acc6b88 <cs_main>, nLine=504, fTry=false, mutexIn=..., pszName=<optimized out>, pszFile=<optimized out>)
at ./sync.h:144
#7 PeerLogicValidation::InitializeNode (this=0x7ff664046440, pnode=0x7ff6282bb0d0) at net_processing.cpp:504
#8 0x000056128a1c5657 in non-virtual thunk to PeerLogicValidation::InitializeNode(CNode*) () at net_processing.cpp:499
#9 0x000056128a1a4602 in CConnman::OpenNetworkConnection (this=0x7ff66456ad30, addrConnect=..., fCountFailure=<optimized out>, grantOutbound=<optimized out>,
pszDest=0x0, fOneShot=<optimized out>, fFeeler=<optimized out>, fAddnode=92) at net.cpp:1965
#10 0x000056128a1a5508 in CConnman::ThreadOpenConnections (this=<optimized out>, connect=...) at net.cpp:1840
#11 0x000056128a1c2887 in std::__invoke_impl<void, void (CConnman::* const&)(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >), CConnman*&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&> (
__f=<optimized out>, __t=<optimized out>, __args=<error reading variable: Cannot access memory at address 0x8>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:227
#12 0x000056128a1c270e in std::__invoke<void (CConnman::* const&)(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >), CConnman*&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&> (__fn=
@0x56128acc6b88: (void (CConnman::*)(CConnman * const, std::vector<std::__cxx11::basic_string<char>, std::allocator<std::__cxx11::basic_string<char> > >)) 0x100000002, this adjustment 4294984971, __args=..., __args=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:250
#13 std::_Mem_fn_base<void (CConnman::*)(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >), true>::operator()<CConnman*&, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&> (__args=..., __args=...,
this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:604
#14 std::_Bind<std::_Mem_fn<void (CConnman::*)(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >)> (CConnman*, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >)>::__call<void, , 0ul, 1ul>(std::tuple<>&&, std::_Index_tuple<0ul, 1ul>) (this=0x56128acc6b88 <cs_main>, __args=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:933
#15 std::_Bind<std::_Mem_fn<void (CConnman::*)(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >)> (CConnman*, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >)>::operator()<, void>() (
this=0x56128acc6b88 <cs_main>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:991
#16 std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (CConnman::*)(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >)> (CConnman*, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >)> >::_M_invoke(std::_Any_data const&) (__functor=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1731
#17 0x000056128a176e3d in std::function<void ()>::operator()() const (this=0x7ff63ef5cd00)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:2127
#18 TraceThread<std::function<void ()> >(char const*, std::function<void ()>) (name=<optimized out>, func=...) at ./util.h:309
#19 0x000056128a1c267d in std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)>::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) (this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1390
#20 std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)>::operator()() (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1380
#21 std::thread::_State_impl<std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)> >::_M_run() (
this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/thread:197
#22 0x00007ff6935ece6f in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#23 0x00007ff6947b9494 in start_thread (arg=0x7ff63ef5d700) at pthread_create.c:333
#24 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 16 (Thread 0x7ff63f7ae700 (LWP 17673)):
#0 pthread_cond_timedwait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_timedwait.S:225
#1 0x000056128a49b56e in __gthread_cond_timedwait (__cond=<optimized out>, __mutex=<optimized out>, __abs_timeout=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/x86_64-linux-gnu/c++/6.3.0/bits/gthr-default.h:871
#2 std::condition_variable::__wait_until_impl<std::chrono::duration<long, std::ratio<1l, 1000000000l> > > (this=<optimized out>, __lock=..., __atime=...)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/condition_variable:166
#3 std::condition_variable::wait_until<std::chrono::duration<long, std::ratio<1l, 1000000000l> > > (this=<optimized out>, __lock=..., __atime=...)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/condition_variable:106
#4 std::condition_variable::wait_until<std::chrono::_V2::system_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> >, CThreadInterrupt::sleep_for(std::chrono::duration<long, std::ratio<1l, 1000l> >)::$_0>(std::unique_lock<std::mutex>&, std::chrono::time_point<std::chrono::_V2::system_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > > const&, CThreadInterrupt::sleep_for(std::chrono::duration<long, std::ratio<1l, 1000l> >)::$_0) (this=<optimized out>,
__lock=..., __atime=..., __p=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/condition_variable:129
#5 std::condition_variable::wait_for<long, std::ratio<1l, 1000l>, CThreadInterrupt::sleep_for(std::chrono::duration<long, std::ratio<1l, 1000l> >)::$_0>(std::unique_lock<std::mutex>&, std::chrono::duration<long, std::ratio<1l, 1000l> > const&, CThreadInterrupt::sleep_for(std::chrono::duration<long, std::ratio<1l, 1000l> >)::$_0) (this=<optimized out>, __lock=..., __rtime=..., __p=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/condition_variable:145
#6 CThreadInterrupt::sleep_for (this=<optimized out>, rel_time=...) at threadinterrupt.cpp:30
#7 0x000056128a49b5fa in CThreadInterrupt::sleep_for (this=0x7ff6645bb1a4, rel_time=...) at threadinterrupt.cpp:35
#8 0x000056128a1a7316 in CConnman::ThreadOpenAddedConnections (this=<optimized out>) at net.cpp:1927
#9 0x000056128a1c24ba in std::__invoke_impl<void, void (CConnman::* const&)(), CConnman*&> (__f=<optimized out>, __t=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:227
#10 std::__invoke<void (CConnman::* const&)(), CConnman*&> (__fn=<optimized out>, __args=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:250
#11 std::_Mem_fn_base<void (CConnman::*)(), true>::operator()<CConnman*&> (this=<optimized out>, __args=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:604
#12 std::_Bind<std::_Mem_fn<void (CConnman::*)()> (CConnman*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) (this=<optimized out>,
__args=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:933
#13 std::_Bind<std::_Mem_fn<void (CConnman::*)()> (CConnman*)>::operator()<, void>() (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:991
#14 std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (CConnman::*)()> (CConnman*)> >::_M_invoke(std::_Any_data const&) (__functor=...)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1731
#15 0x000056128a176e3d in std::function<void ()>::operator()() const (this=0x7ff63f7add00)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:2127
#16 TraceThread<std::function<void ()> >(char const*, std::function<void ()>) (name=<optimized out>, func=...) at ./util.h:309
#17 0x000056128a1c267d in std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)>::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) (this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1390
#18 std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)>::operator()() (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1380
#19 std::thread::_State_impl<std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)> >::_M_run() (
this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/thread:197
#20 0x00007ff6935ece6f in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#21 0x00007ff6947b9494 in start_thread (arg=0x7ff63f7ae700) at pthread_create.c:333
#22 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 15 (Thread 0x7ff645ec7700 (LWP 17671)):
#0 0x00007ff692d5a3f3 in select () at ../sysdeps/unix/syscall-template.S:84
#1 0x000056128a19da64 in CConnman::ThreadSocketHandler (this=<optimized out>) at net.cpp:1251
#2 0x000056128a1c24ba in std::__invoke_impl<void, void (CConnman::* const&)(), CConnman*&> (__f=<optimized out>, __t=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:227
#3 std::__invoke<void (CConnman::* const&)(), CConnman*&> (__fn=<optimized out>, __args=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:250
#4 std::_Mem_fn_base<void (CConnman::*)(), true>::operator()<CConnman*&> (this=<optimized out>, __args=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:604
#5 std::_Bind<std::_Mem_fn<void (CConnman::*)()> (CConnman*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) (this=<optimized out>,
__args=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:933
#6 std::_Bind<std::_Mem_fn<void (CConnman::*)()> (CConnman*)>::operator()<, void>() (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:991
#7 std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (CConnman::*)()> (CConnman*)> >::_M_invoke(std::_Any_data const&) (__functor=...)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1731
#8 0x000056128a176e3d in std::function<void ()>::operator()() const (this=0x7ff645ec6d00)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:2127
#9 TraceThread<std::function<void ()> >(char const*, std::function<void ()>) (name=<optimized out>, func=...) at ./util.h:309
#10 0x000056128a1c267d in std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)>::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) (this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1390
#11 std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)>::operator()() (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1380
#12 std::thread::_State_impl<std::_Bind_simple<void (*(char const*, std::function<void ()>))(char const*, std::function<void ()>)> >::_M_run() (
this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/thread:197
#13 0x00007ff6935ece6f in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#14 0x00007ff6947b9494 in start_thread (arg=0x7ff645ec7700) at pthread_create.c:333
#15 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 14 (Thread 0x7ff658cf7700 (LWP 17664)):
#0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1 0x000056128a4f38ab in leveldb::(anonymous namespace)::PosixEnv::BGThread (this=<optimized out>) at leveldb/util/env_posix.cc:641
#2 leveldb::(anonymous namespace)::PosixEnv::BGThreadWrapper (arg=<optimized out>) at leveldb/util/env_posix.cc:556
#3 0x00007ff6947b9494 in start_thread (arg=0x7ff658cf7700) at pthread_create.c:333
#4 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 13 (Thread 0x7ff668e19700 (LWP 17660)):
#0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1 0x00007ff6935e750c in std::condition_variable::wait(std::unique_lock<std::mutex>&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#2 0x000056128a381c2a in WorkQueue<HTTPClosure>::Run (this=<optimized out>) at httpserver.cpp:127
#3 0x000056128a37baca in HTTPWorkQueueRun (queue=0x7ff664044c7c) at httpserver.cpp:351
#4 0x000056128a383508 in std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)>::_M_invoke<0ul>(std::_Index_tuple<0ul>) (
this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1390
#5 std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)>::operator()() (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1380
#6 std::thread::_State_impl<std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)> >::_M_run() (this=0xfffffffffffffe00)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/thread:197
#7 0x00007ff6935ece6f in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#8 0x00007ff6947b9494 in start_thread (arg=0x7ff668e19700) at pthread_create.c:333
#9 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 12 (Thread 0x7ff66966a700 (LWP 17659)):
#0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1 0x00007ff6935e750c in std::condition_variable::wait(std::unique_lock<std::mutex>&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#2 0x000056128a381c2a in WorkQueue<HTTPClosure>::Run (this=<optimized out>) at httpserver.cpp:127
#3 0x000056128a37baca in HTTPWorkQueueRun (queue=0x7ff664044c7c) at httpserver.cpp:351
#4 0x000056128a383508 in std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)>::_M_invoke<0ul>(std::_Index_tuple<0ul>) (
this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1390
#5 std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)>::operator()() (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1380
#6 std::thread::_State_impl<std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)> >::_M_run() (this=0xfffffffffffffe00)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/thread:197
#7 0x00007ff6935ece6f in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#8 0x00007ff6947b9494 in start_thread (arg=0x7ff66966a700) at pthread_create.c:333
#9 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 11 (Thread 0x7ff669ebb700 (LWP 17658)):
#0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1 0x00007ff6935e750c in std::condition_variable::wait(std::unique_lock<std::mutex>&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#2 0x000056128a381c2a in WorkQueue<HTTPClosure>::Run (this=<optimized out>) at httpserver.cpp:127
#3 0x000056128a37baca in HTTPWorkQueueRun (queue=0x7ff664044c7c) at httpserver.cpp:351
#4 0x000056128a383508 in std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)>::_M_invoke<0ul>(std::_Index_tuple<0ul>) (
this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1390
#5 std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)>::operator()() (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1380
#6 std::thread::_State_impl<std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)> >::_M_run() (this=0xfffffffffffffe00)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/thread:197
#7 0x00007ff6935ece6f in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#8 0x00007ff6947b9494 in start_thread (arg=0x7ff669ebb700) at pthread_create.c:333
#9 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 10 (Thread 0x7ff66a70c700 (LWP 17657)):
#0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1 0x00007ff6935e750c in std::condition_variable::wait(std::unique_lock<std::mutex>&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#2 0x000056128a381c2a in WorkQueue<HTTPClosure>::Run (this=<optimized out>) at httpserver.cpp:127
#3 0x000056128a37baca in HTTPWorkQueueRun (queue=0x7ff664044c7c) at httpserver.cpp:351
#4 0x000056128a383508 in std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)>::_M_invoke<0ul>(std::_Index_tuple<0ul>) (
this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1390
#5 std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)>::operator()() (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1380
#6 std::thread::_State_impl<std::_Bind_simple<void (*(WorkQueue<HTTPClosure>*))(WorkQueue<HTTPClosure>*)> >::_M_run() (this=0xfffffffffffffe00)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/thread:197
#7 0x00007ff6935ece6f in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#8 0x00007ff6947b9494 in start_thread (arg=0x7ff66a70c700) at pthread_create.c:333
#9 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 9 (Thread 0x7ff66af5d700 (LWP 17656)):
#0 0x00007ff692d620f3 in epoll_wait () at ../sysdeps/unix/syscall-template.S:84
#1 0x00007ff6938d9d98 in ?? () from /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5
#2 0x00007ff6938c407a in event_base_loop () from /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5
#3 0x000056128a37b03f in ThreadHTTP (base=0x7ff6640443d0, http=<optimized out>) at httpserver.cpp:303
#4 0x000056128a382c4d in std::__invoke_impl<bool, bool (*&)(event_base*, evhttp*), event_base*, evhttp*>(std::__invoke_other, bool (*&)(event_base*, evhttp*), event_base*&&, evhttp*&&) (__f=<optimized out>, __args=<optimized out>, __args=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:210
#5 std::__invoke<bool (*&)(event_base*, evhttp*), event_base*, evhttp*>(bool (*&)(event_base*, evhttp*), event_base*&&, evhttp*&&) (__fn=<optimized out>,
__args=<optimized out>, __args=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:250
#6 std::reference_wrapper<bool (*)(event_base*, evhttp*)>::operator()<event_base*, evhttp*>(event_base*&&, evhttp*&&) const (__args=<optimized out>,
this=<optimized out>, __args=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:465
#7 std::_Bind_simple<std::reference_wrapper<bool (*)(event_base*, evhttp*)> (event_base*, evhttp*)>::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) (
this=0x7ff692d620f3 <epoll_wait+51>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1390
#8 std::_Bind_simple<std::reference_wrapper<bool (*)(event_base*, evhttp*)> (event_base*, evhttp*)>::operator()() (this=0x7ff692d620f3 <epoll_wait+51>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1380
#9 std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result<bool>, std::__future_base::_Result_base::_Deleter>, std::_Bind_simple<std::reference_wrapper<bool (*)(event_base*, evhttp*)> (event_base*, evhttp*)>, bool>::operator()() const (this=0x7ff66af5ccd0)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/future:1325
#10 0x000056128a382b8f in std::_Function_handler<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> (), std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result<bool>, std::__future_base::_Result_base::_Deleter>, std::_Bind_simple<std::reference_wrapper<bool (*)(event_base*, evhttp*)> (event_base*, evhttp*)>, bool> >::_M_invoke(std::_Any_data const&) (__functor=...)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1716
#11 0x000056128a382aba in std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>::operator()() const (
this=0x7ff664044660) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:2127
#12 std::__future_base::_State_baseV2::_M_do_set(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*) (this=0x7ff664044e80, __f=0x7ff664044660, __did_set=0x7ff66af5cc8f) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/future:533
#13 0x000056128a382b56 in std::__invoke_impl<void, void (std::__future_base::_State_baseV2::*)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*>(std::__invoke_memfun_deref, void (std::__future_base::_State_baseV2::*&&)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*&&, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*&&, bool*&&) (__f=<optimized out>, __args=<optimized out>, __args=<optimized out>, __t=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:227
#14 std::__invoke<void (std::__future_base::_State_baseV2::*)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*>(void (std::__future_base::_State_baseV2::*&&)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*&&, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*&&, bool*&&) (__fn=<optimized out>, __args=<optimized out>, __args=<optimized out>, __args=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:250
#15 void std::call_once<void (std::__future_base::_State_baseV2::*)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*>(std::once_flag&, void (std::__future_base::_State_baseV2::*&&)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*&&, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*&&, bool*&&)::{lambda()#1}::operator()() const (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/mutex:602
#16 void std::call_once<void (std::__future_base::_State_baseV2::*)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*>(std::once_flag&, void (std::__future_base::_State_baseV2::*&&)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*&&, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*&&, bool*&&)::{lambda()#2}::operator()() const (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/mutex:607
#17 void std::call_once<void (std::__future_base::_State_baseV2::*)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*>(std::once_flag&, void (std::__future_base::_State_baseV2::*&&)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*&&, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*&&, bool*&&)::{lambda()#2}::__invoke() () at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/mutex:607
#18 0x00007ff6947c0739 in __pthread_once_slow (once_control=0x7ff664044e98, init_routine=0x7ff6935ec120 <__once_proxy>) at pthread_once.c:116
#19 0x000056128a382a39 in __gthread_once (__func=0x7ff664044660, __once=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/x86_64-linux-gnu/c++/6.3.0/bits/gthr-default.h:699
#20 std::call_once<void (std::__future_base::_State_baseV2::*)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*>(std::once_flag&, void (std::__future_base::_State_baseV2::*&&)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*&&, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*&&, bool*&&) (__args=<optimized out>, __args=<optimized out>, __args=<optimized out>, __once=..., __f=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/mutex:614
#21 std::__future_base::_State_baseV2::_M_set_result(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>, bool) (this=0x7ff664044e80, __res=..., __ignore_failure=false) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/future:392
#22 0x000056128a382491 in std::__future_base::_Task_state<bool (*)(event_base*, evhttp*), std::allocator<int>, bool (event_base*, evhttp*)>::_M_run(event_base*&&, evhttp*&&) (this=0x17, __args=<optimized out>, __args=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/future:1409
#23 0x000056128a38348b in std::packaged_task<bool (event_base*, evhttp*)>::operator()(event_base*, evhttp*) (
__args=<error reading variable: Cannot access memory at address 0x20>, __args=<error reading variable: Cannot access memory at address 0x20>,
this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/future:1553
#24 std::_Bind_simple<std::packaged_task<bool (event_base*, evhttp*)> (event_base*, evhttp*)>::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) (
this=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1390
#25 std::_Bind_simple<std::packaged_task<bool (event_base*, evhttp*)> (event_base*, evhttp*)>::operator()() (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1380
#26 std::thread::_State_impl<std::_Bind_simple<std::packaged_task<bool (event_base*, evhttp*)> (event_base*, evhttp*)> >::_M_run() (this=<optimized out>)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/thread:197
#27 0x00007ff6935ece6f in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#28 0x00007ff6947b9494 in start_thread (arg=0x7ff66af5d700) at pthread_create.c:333
#29 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 8 (Thread 0x7ff66b7ae700 (LWP 17655)):
#0 pthread_cond_timedwait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_timedwait.S:225
#1 0x000056128a257c82 in boost::condition_variable::do_wait_until (this=0x56128bfebea0, m=..., timeout=...)
at /usr/include/boost/thread/pthread/condition_variable.hpp:109
#2 0x000056128a489379 in boost::condition_variable::wait_until (this=<optimized out>, lk=..., tp=...)
at /usr/include/boost/thread/pthread/condition_variable_fwd.hpp:252
#3 boost::condition_variable::wait_until<boost::chrono::duration<long, boost::ratio<1l, 1000000000l> > > (this=<optimized out>, lock=..., t=...)
at /usr/include/boost/thread/pthread/condition_variable_fwd.hpp:209
#4 CScheduler::serviceQueue (this=<optimized out>) at scheduler.cpp:67
#5 0x000056128a18553a in boost::_mfi::mf0<void, CScheduler>::operator() (p=<optimized out>, this=<optimized out>) at /usr/include/boost/bind/mem_fn_template.hpp:49
#6 boost::_bi::list1<boost::_bi::value<CScheduler*> >::operator()<boost::_mfi::mf0<void, CScheduler>, boost::_bi::list0> (this=<optimized out>, f=..., a=...)
at /usr/include/boost/bind/bind.hpp:259
#7 boost::_bi::bind_t<void, boost::_mfi::mf0<void, CScheduler>, boost::_bi::list1<boost::_bi::value<CScheduler*> > >::operator() (this=<optimized out>)
at /usr/include/boost/bind/bind.hpp:1294
#8 std::_Function_handler<void (), boost::_bi::bind_t<void, boost::_mfi::mf0<void, CScheduler>, boost::_bi::list1<boost::_bi::value<CScheduler*> > > >::_M_invoke(std::_Any_data const&) (__functor=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:1731
#9 0x000056128a176e3d in std::function<void ()>::operator()() const (this=0x7ff66b7adcb8)
at /usr/bin/../lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/functional:2127
#10 TraceThread<std::function<void ()> >(char const*, std::function<void ()>) (name=<optimized out>, func=...) at ./util.h:309
#11 0x000056128a185ab6 in boost::_bi::list2<boost::_bi::value<char const*>, boost::_bi::value<std::function<void ()> > >::operator()<void (*)(char const*, std::function<void ()>), boost::_bi::list0>(boost::_bi::type<void>, void (*&)(char const*, std::function<void ()>), boost::_bi::list0&, int) (this=0x7ff664043100,
f=<optimized out>, a=...) at /usr/include/boost/bind/bind.hpp:319
#12 0x000056128a185a3f in boost::_bi::bind_t<void, void (*)(char const*, std::function<void ()>), boost::_bi::list2<boost::_bi::value<char const*>, boost::_bi::value<std::function<void ()> > > >::operator()() (this=<optimized out>) at /usr/include/boost/bind/bind.hpp:1294
#13 boost::detail::thread_data<boost::_bi::bind_t<void, void (*)(char const*, std::function<void ()>), boost::_bi::list2<boost::_bi::value<char const*>, boost::_bi::value<std::function<void ()> > > > >::run() (this=<optimized out>) at /usr/include/boost/thread/detail/thread.hpp:116
#14 0x00007ff69635d116 in ?? () from /usr/lib/x86_64-linux-gnu/libboost_thread.so.1.62.0
#15 0x00007ff6947b9494 in start_thread (arg=0x7ff66b7ae700) at pthread_create.c:333
#16 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 7 (Thread 0x7ff66bfff700 (LWP 17654)):
#0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1 0x000056128a0017eb in boost::condition_variable::wait (this=<optimized out>, m=...) at /usr/include/boost/thread/pthread/condition_variable.hpp:77
#2 0x000056128a3212f2 in CCheckQueue<CScriptCheck>::Loop (this=<optimized out>, fMaster=<optimized out>) at ./checkqueue.h:102
#3 0x000056128a2e12c8 in CCheckQueue<CScriptCheck>::Thread (this=0x56128acc71ec <scriptcheckqueue+84>) at ./checkqueue.h:139
#4 ThreadScriptCheck () at validation.cpp:1540
#5 0x000056128a185114 in boost::detail::thread_data<void (*)()>::run (this=0x56128acc71ec <scriptcheckqueue+84>) at /usr/include/boost/thread/detail/thread.hpp:116
#6 0x00007ff69635d116 in ?? () from /usr/lib/x86_64-linux-gnu/libboost_thread.so.1.62.0
#7 0x00007ff6947b9494 in start_thread (arg=0x7ff66bfff700) at pthread_create.c:333
#8 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 6 (Thread 0x7ff677398700 (LWP 17653)):
#0 0x00007ff692d586ad in poll () at ../sysdeps/unix/syscall-template.S:84
#1 0x00007ff69068f9f6 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007ff69068fb0c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x00007ff69532004f in QEventDispatcherGlib::processEvents (this=0x7ff6640008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:423
#4 0x00007ff6952c99ca in QEventLoop::exec (this=this@entry=0x7ff677397cc0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:212
#5 0x00007ff6950f70f3 in QThread::exec (this=<optimized out>) at thread/qthread.cpp:507
#6 0x00007ff6950fbda8 in QThreadPrivate::start (arg=0x56128bfe7de0) at thread/qthread_unix.cpp:368
#7 0x00007ff6947b9494 in start_thread (arg=0x7ff677398700) at pthread_create.c:333
#8 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 5 (Thread 0x7ff677be9700 (LWP 17652)):
#0 0x00007ff692d586ad in poll () at ../sysdeps/unix/syscall-template.S:84
#1 0x00007ff69068f9f6 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007ff69068fb0c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x00007ff69532004f in QEventDispatcherGlib::processEvents (this=0x7ff66c0008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:423
#4 0x00007ff6952c99ca in QEventLoop::exec (this=this@entry=0x7ff677be8c90, flags=..., flags@entry=...) at kernel/qeventloop.cpp:212
#5 0x00007ff6950f70f3 in QThread::exec (this=this@entry=0x7ff6955a6d60 <(anonymous namespace)::Q_QGS__q_manager::innerFunction()::holder>)
at thread/qthread.cpp:507
#6 0x00007ff6955316d5 in QDBusConnectionManager::run (this=0x7ff6955a6d60 <(anonymous namespace)::Q_QGS__q_manager::innerFunction()::holder>)
at qdbusconnection.cpp:178
#7 0x00007ff6950fbda8 in QThreadPrivate::start (arg=0x7ff6955a6d60 <(anonymous namespace)::Q_QGS__q_manager::innerFunction()::holder>)
at thread/qthread_unix.cpp:368
#8 0x00007ff6947b9494 in start_thread (arg=0x7ff677be9700) at pthread_create.c:333
#9 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 4 (Thread 0x7ff67df9e700 (LWP 17651)):
#0 0x00007ff692d586ad in poll () at ../sysdeps/unix/syscall-template.S:84
#1 0x00007ff69068f9f6 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007ff69068fd82 in g_main_loop_run () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x00007ff68473e656 in ?? () from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
#4 0x00007ff6906b73d5 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5 0x00007ff6947b9494 in start_thread (arg=0x7ff67df9e700) at pthread_create.c:333
#6 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 3 (Thread 0x7ff67e7ef700 (LWP 17650)):
#0 0x00007ff692d586ad in poll () at ../sysdeps/unix/syscall-template.S:84
#1 0x00007ff69068f9f6 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00007ff69068fb0c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3 0x00007ff69068fb51 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#4 0x00007ff6906b73d5 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#5 0x00007ff6947b9494 in start_thread (arg=0x7ff67e7ef700) at pthread_create.c:333
#6 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 2 (Thread 0x7ff688439700 (LWP 17649)):
#0 0x00007ff692d586ad in poll () at ../sysdeps/unix/syscall-template.S:84
#1 0x00007ff68e55c150 in ?? () from /usr/lib/x86_64-linux-gnu/libxcb.so.1
#2 0x00007ff68e55dee9 in xcb_wait_for_event () from /usr/lib/x86_64-linux-gnu/libxcb.so.1
#3 0x00007ff68ab9ab69 in QXcbEventReader::run (this=0x56128b83c900) at qxcbconnection.cpp:1343
#4 0x00007ff6950fbda8 in QThreadPrivate::start (arg=0x56128b83c900) at thread/qthread_unix.cpp:368
#5 0x00007ff6947b9494 in start_thread (arg=0x7ff688439700) at pthread_create.c:333
#6 0x00007ff692d61aff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Thread 1 (Thread 0x7ff696f01900 (LWP 17648)):
#0 __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
#1 0x00007ff6947bbc06 in __GI___pthread_mutex_lock (mutex=0x56128acc6df0 <mempool+56>) at ../nptl/pthread_mutex_lock.c:115
#2 0x000056128a0259d5 in boost::recursive_mutex::lock (this=<optimized out>) at /usr/include/boost/thread/pthread/recursive_mutex.hpp:113
#3 AnnotatedMixin<boost::recursive_mutex>::lock (this=<optimized out>) at ./sync.h:59
#4 boost::unique_lock<CCriticalSection>::lock (this=0x7fff8192c5e8) at /usr/include/boost/thread/lock_types.hpp:346
#5 0x000056128a02541e in CMutexLock<CCriticalSection>::Enter (this=0x56128acc6df0 <mempool+56>, nLine=602, pszName=<optimized out>, pszFile=<optimized out>)
at ./sync.h:123
#6 CMutexLock<CCriticalSection>::CMutexLock (this=0x56128acc6df0 <mempool+56>, mutexIn=..., nLine=602, fTry=false, pszName=<optimized out>,
pszFile=<optimized out>) at ./sync.h:144
#7 CTxMemPool::size (this=0x56128acc6db8 <mempool>) at ./txmempool.h:602
#8 0x000056128a0240b9 in ClientModel::getMempoolSize (this=<optimized out>) at qt/clientmodel.cpp:130
#9 ClientModel::updateTimer (this=0x56128b70d6e0) at qt/clientmodel.cpp:153
#10 0x000056128a0ba739 in ClientModel::qt_static_metacall (_o=0x56128acc6df0 <mempool+56>, _c=128, _id=<optimized out>, _a=0x7ff6947c1f5c <__lll_lock_wait+28>)
at qt/moc_clientmodel.cpp:140
#11 0x00007ff6952f75e9 in QMetaObject::activate (sender=sender@entry=0x56128b71a310, signalOffset=<optimized out>, local_signal_index=local_signal_index@entry=0,
argv=argv@entry=0x0) at kernel/qobject.cpp:3740
#12 0x00007ff6952f7f07 in QMetaObject::activate (sender=sender@entry=0x56128b71a310, m=m@entry=0x7ff695515760 <QTimer::staticMetaObject>,
local_signal_index=local_signal_index@entry=0, argv=argv@entry=0x0) at kernel/qobject.cpp:3602
#13 0x00007ff695371780 in QTimer::timeout (this=this@entry=0x56128b71a310) at .moc/moc_qtimer.cpp:198
#14 0x00007ff695303f78 in QTimer::timerEvent (this=0x56128b71a310, e=<optimized out>) at kernel/qtimer.cpp:254
#15 0x00007ff6952f8453 in QObject::event (this=0x56128b71a310, e=<optimized out>) at kernel/qobject.cpp:1285
#16 0x00007ff695c3ab8c in QApplicationPrivate::notify_helper (this=<optimized out>, receiver=0x56128b71a310, e=0x7fff8192ca80) at kernel/qapplication.cpp:3799
#17 0x00007ff695c42341 in QApplication::notify (this=0x7fff8192d6b0, receiver=0x56128b71a310, e=0x7fff8192ca80) at kernel/qapplication.cpp:3556
#18 0x00007ff6952cb9e0 in QCoreApplication::notifyInternal2 (receiver=0x56128b71a310, event=event@entry=0x7fff8192ca80) at kernel/qcoreapplication.cpp:988
#19 0x00007ff69531efee in QCoreApplication::sendEvent (event=0x7fff8192ca80, receiver=<optimized out>)
at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:231
#20 QTimerInfoList::activateTimers (this=0x56128b8c6940) at kernel/qtimerinfo_unix.cpp:644
#21 0x00007ff69531f511 in timerSourceDispatch (source=<optimized out>) at kernel/qeventdispatcher_glib.cpp:182
#22 0x00007ff69068f7f7 in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#23 0x00007ff69068fa60 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#24 0x00007ff69068fb0c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#25 0x00007ff69532004f in QEventDispatcherGlib::processEvents (this=0x56128b8c6720, flags=...) at kernel/qeventdispatcher_glib.cpp:423
#26 0x00007ff6952c99ca in QEventLoop::exec (this=this@entry=0x7fff8192ccd0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:212
#27 0x00007ff695e290e7 in QDialog::exec (this=0x7fff8192cd58) at dialogs/qdialog.cpp:552
#28 0x000056128a016d55 in BitcoinGUI::message (this=0x56128b9167c0, title=..., message=..., style=<optimized out>, ret=0x7ff63e702e8b) at qt/bitcoingui.cpp:925
#29 0x000056128a0b9403 in BitcoinGUI::qt_static_metacall (_o=0x56128b9167c0, _c=<optimized out>, _id=<optimized out>, _a=0x7ff63e702920)
at qt/moc_bitcoingui.cpp:216
#30 0x00007ff6952f8499 in QObject::event (this=this@entry=0x56128b9167c0, e=e@entry=0x7ff614534610) at kernel/qobject.cpp:1263
#31 0x00007ff695c8246b in QWidget::event (this=this@entry=0x56128b9167c0, event=event@entry=0x7ff614534610) at kernel/qwidget.cpp:9225
#32 0x00007ff695d8192b in QMainWindow::event (this=0x56128b9167c0, event=0x7ff614534610) at widgets/qmainwindow.cpp:1543
#33 0x00007ff695c3ab8c in QApplicationPrivate::notify_helper (this=<optimized out>, receiver=0x56128b9167c0, e=0x7ff614534610) at kernel/qapplication.cpp:3799
#34 0x00007ff695c42341 in QApplication::notify (this=0x7fff8192d6b0, receiver=0x56128b9167c0, e=0x7ff614534610) at kernel/qapplication.cpp:3556
#35 0x00007ff6952cb9e0 in QCoreApplication::notifyInternal2 (receiver=0x56128b9167c0, event=event@entry=0x7ff614534610) at kernel/qcoreapplication.cpp:988
#36 0x00007ff6952ce16d in QCoreApplication::sendEvent (event=0x7ff614534610, receiver=<optimized out>)
at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:231
#37 QCoreApplicationPrivate::sendPostedEvents (receiver=receiver@entry=0x0, event_type=event_type@entry=0, data=0x56128b821ce0) at kernel/qcoreapplication.cpp:1649
#38 0x00007ff6952ce5d8 in QCoreApplication::sendPostedEvents (receiver=receiver@entry=0x0, event_type=event_type@entry=0) at kernel/qcoreapplication.cpp:1503
#39 0x00007ff69531fc43 in postEventSourceDispatch (s=0x56128b8c67f0) at kernel/qeventdispatcher_glib.cpp:276
#40 0x00007ff69068f7f7 in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#41 0x00007ff69068fa60 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#42 0x00007ff69068fb0c in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#43 0x00007ff69532004f in QEventDispatcherGlib::processEvents (this=0x56128b8c6720, flags=...) at kernel/qeventdispatcher_glib.cpp:423
#44 0x00007ff6952c99ca in QEventLoop::exec (this=this@entry=0x7fff8192d4a0, flags=..., flags@entry=...) at kernel/qeventloop.cpp:212
#45 0x00007ff6952d213c in QCoreApplication::exec () at kernel/qcoreapplication.cpp:1261
#46 0x0000561289ffbb19 in main (argc=<optimized out>, argv=<optimized out>) at qt/bitcoin.cpp:714
(gdb)
I suppose it's possible that this is corruption in something other than the chainstate db, that I only fixed the chainstate db by reindexing and still have old corruption in another db.
Either way, bitcoin-qt shouldn't hang like this. It's not responding to requests to "bitcoin-cli stop" or any other RPC. | https://github.com/bitcoin/bitcoin/issues/11355 | https://github.com/bitcoin/bitcoin/pull/12659 | 29fad97c320c892ab6a480c81e2078ec22ab354b | f4b68b3f8f6bb8ad45a9c13c70be0e24404ecd54 | 2017-09-16T19:59:33Z | c++ | 2018-03-10T06:51:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,352 | ["src/Makefile.test.include", "test/util/bitcoin-util-test.py"] | Failed to make check on an old Linux: python3: no such file or directory | Running test/util/bitcoin-util-test.py...
../test/util/bitcoin-util-test.py
/usr/bin/env: python3: No such file or directory
make[3]: *** [check-local] Error 127 | https://github.com/bitcoin/bitcoin/issues/11352 | https://github.com/bitcoin/bitcoin/pull/11433 | c2704ec98a1b7b35b6a7c1b6b26a3f16d44e8880 | fafff1220cf798e25f02cdd8affb70506dd366cc | 2017-09-16T10:23:29Z | c++ | 2017-10-01T09:22:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,344 | ["src/qt/forms/sendcoinsdialog.ui", "src/qt/sendcoinsdialog.cpp"] | Better text for sending transaction option "Request Replace-By-Fee" | ### Howto replace a stuck transaction with another with higher fee ?
bitcoind 0.15.0
The marking option "Request Replace-By-Fee" in the sending transaction GUI page should have a better understandable text.
The sender does not "request" anything when creating the transaction. This is just a tag for a later possibility, as I understand as a rather normal user.
I would suggest something like
"Let me increase the fee of this transaction later, if it should not get confirmed in expected time ('Replace-By-Fee' feature)" | https://github.com/bitcoin/bitcoin/issues/11344 | https://github.com/bitcoin/bitcoin/pull/11556 | 938863965f14ce7ab0780dd9197c6e13f2093d87 | db0b7373fc990806a06b6ba8a27ba2d710ce23c8 | 2017-09-15T17:59:38Z | c++ | 2017-11-18T12:12:07Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,317 | ["src/wallet/feebumper.cpp", "src/wallet/rpcdump.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h", "src/wallet/walletdb.cpp"] | wallet debug messages could name wallet file | In the log I see things like:
2017-09-13 03:54:33 init message: Rescanning...
2017-09-13 03:54:33 Rescanning last 68616 blocks (from block 416339)...
2017-09-13 03:54:40 AddToWallet xxxxx update
2017-09-13 03:55:33 Still rescanning. At block 418849. Progress=0.549138
I would be interested to see the wallet file name on each of these log lines.
Would there be any interest in merging such a PR? | https://github.com/bitcoin/bitcoin/issues/11317 | https://github.com/bitcoin/bitcoin/pull/12992 | 1ef57a96b8b7255bd1f1ea0583846f18305419bf | 909f54c80abb7195c2e82c6e06c414f4526a339e | 2017-09-13T04:01:57Z | c++ | 2018-08-02T16:09:39Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,313 | ["src/wallet/wallet.cpp", "src/wallet/wallet.h", "test/functional/wallet-hd.py"] | Attempting to create new non-HD wallet ignores -usehd=0 without warning | Built against `master` branch 801dd40666d1e6009920ad3ff755c7bb993b2a62:
If I have no wallet.dat file and run:
bitcoind -usehd=0
A new wallet.dat file is created and an HD seed is assigned.
I see an error message in the source:
"Error loading %s: You can't disable HD on an already existing HD wallet or create new non-HD wallets."
but that doesn't get shown because `fFirstRun` is true, and so the code which checks for `-usehd` values doesn't run.
If it's no longer possible to create non-HD wallets, specifying -usehd=0 when creating a wallet should be an error, and not get silently ignored. | https://github.com/bitcoin/bitcoin/issues/11313 | https://github.com/bitcoin/bitcoin/pull/11307 | b9bceaf1c081a84d9fcc680372614e797b168a9e | fadf31ef02b35f438ce2cf7048830f6974cdb515 | 2017-09-12T21:52:36Z | c++ | 2017-09-12T10:40:41Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,312 | ["src/init.cpp"] | crash when specifying path for -wallet= | Built against master branch 801dd40666d1e6009920ad3ff755c7bb993b2a62:
$ ./bitcoind -wallet=/tmp/wallet.dat
Error: Error loading wallet /tmp/wallet.dat. -wallet parameter must only specify a filename (not a path).
Segmentation fault
$
It's crashing here:
Thread 1 "bitcoin-shutoff" received signal SIGSEGV, Segmentation fault.
CConnman::Stop (this=0x0) at net.cpp:2405
2405 if (threadMessageHandler.joinable())
(gdb) where
#0 CConnman::Stop (this=0x0) at net.cpp:2405
#1 0x00005555555a57fb in Shutdown () at init.cpp:197
#2 0x00005555555997fb in AppInit (argc=<optimized out>, argv=<optimized out>) at bitcoind.cpp:183
#3 0x0000555555599a39 in main (argc=0, argv=0x0) at bitcoind.cpp:195
(gdb) | https://github.com/bitcoin/bitcoin/issues/11312 | https://github.com/bitcoin/bitcoin/pull/11326 | 7fcd61b2613c211bb042a82a889655178be6a212 | 77939f27f7dc42640ebfb9fe52490a2ddacc3ad4 | 2017-09-12T21:31:55Z | c++ | 2017-09-14T04:47:10Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,302 | ["src/Makefile.qt.include"] | Issues in 'make distcheck' | ### Describe the issue
Encountered a couple of issues encountered running "make distcheck" on my machine:
1) During the build, getting a request to override read-only file attributes of qt/temp_bitcoin_locale.qrc
2) At the end of the build, there's an error because of a leftover ./src/bench/data/block413567.raw.h file.
### Can you reliably reproduce the issue?
Yes
#### If so, please list the steps to reproduce below:
1. Start with a clean master checkout
2. Run ./autogen.sh
3. Run ./configure
4. Run make distcheck
### Expected behaviour
No error at end and no request for manual confirmation of overriding read-only attributes during build
### Actual behaviour
As described above. Output pasted in https://pastebin.com/2YEpeB5y
### What version of bitcoin-core are you using?
ee50c9e48786dea0d9df2e45805c25565c100fe3
### Machine specs:
- OS: macOS 10.12.6
| https://github.com/bitcoin/bitcoin/issues/11302 | https://github.com/bitcoin/bitcoin/pull/11621 | 3bdf242fc68a8d767932c6214455d4d413effbc9 | a7c949f644d82a5b97617256fa5e8cc511b8aa5f | 2017-09-11T16:47:42Z | c++ | 2017-11-15T00:00:53Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,265 | ["src/qt/modaloverlay.cpp"] | unclear GUI message in sychronize screen if progress increase is negative (QT) | in the GUI, that dark synchronise screen, if "Progress increase per hour" goes negative, then "Estimated time left until synced" says "%n left", not integers, but '%n'. I was expecting a meaningful wording, like "unknown" or "infinity".
## can you reproduce the problem?
I get this behavour by suspending a non-synced node for a few hours and then restoring it.
### What version of bitcoin-core are you using?
0.15.99
## machine:
Atom 330, 2GB RAM, 5400 RPM HDD, GNU/Linux | https://github.com/bitcoin/bitcoin/issues/11265 | https://github.com/bitcoin/bitcoin/pull/11237 | 3b69a08c53c2ef738f32c270fdacf1e4ed5a4c97 | c8d38abd65d920ec28c68020bf910cfa79216bd5 | 2017-09-07T13:13:31Z | c++ | 2017-09-05T22:50:05Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,257 | ["src/httprpc.cpp", "src/rpc/server.cpp", "src/rpc/server.h", "test/functional/multiwallet.py", "test/functional/test_framework/authproxy.py", "test/functional/test_framework/coverage.py"] | [RPC] Bug: RPC Batching does not work with more than 1 multi wallet | ***UPDATE:***
Turns out the issue was caused not by testnet, but by having 2 wallets @ryanofsky found out !
----------
Step to reproduce:
This work on regtest just fine:
```
bitcoind -wallet=test -regtest -rpcpassword=abc -rpcuser=abc
```
Try to make a batch RPC request to /wallet/test:
```
[{"jsonrpc":"1.0","id":1,"method":"getbalance","params":["*"]}]
```
You get the expected result.
However; same things with testnet:
```
bitcoind -wallet=test -testnet -rpcpassword=abc -rpcuser=abc
```
Result:
"Wallet file not specified (must request wallet RPC through /wallet/<filename> uri-path)."
This problem is limited to batched RPC request on testnet as just making the exact same request without the '[' and ']' works fine. It works also fine on regtest, which is crazy. I will look into later. | https://github.com/bitcoin/bitcoin/issues/11257 | https://github.com/bitcoin/bitcoin/pull/11277 | 74182f235cd04dcac7a8b3e763bc9add549745e1 | 4526d21e52aa94f12121fcf01047c04f82c4990a | 2017-09-06T14:08:16Z | c++ | 2017-10-04T07:07:01Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,249 | ["src/wallet/rpc/backup.cpp", "src/wallet/rpc/encrypt.cpp", "src/wallet/rpc/transactions.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h", "test/functional/wallet_importdescriptors.py", "test/functional/wallet_transactiontime_rescan.py"] | Rescan for encrypted HDwallets | Right now to recover from a backup with an encrypted HD wallet the user must do something like unlock the wallet with a really long time out and manually trigger a rescan, otherwise they risk missing some keys when auto-topup cannot run. | https://github.com/bitcoin/bitcoin/issues/11249 | https://github.com/bitcoin/bitcoin/pull/26347 | ad461416025eb1581e8b20a95a4f316107b9431b | 80f4979322b574be29c684b2e106804432420ebf | 2017-09-05T22:36:31Z | c++ | 2023-02-21T19:02:49Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,243 | ["src/wallet/rpcdump.cpp", "src/wallet/rpcwallet.cpp"] | add* RPCs require backups | At a minimum, help text should note this. This is true for things like addwitnessaddress especially. | https://github.com/bitcoin/bitcoin/issues/11243 | https://github.com/bitcoin/bitcoin/pull/11289 | a38bfbc51d0b98fffd8d79457f31c6fb196ff580 | c098c581968fa23b2a1987c127c47e04d13fb5c8 | 2017-09-05T18:48:06Z | c++ | 2017-10-19T09:02:13Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,233 | ["src/rpc/client.cpp", "src/wallet/feebumper.cpp", "src/wallet/feebumper.h", "src/wallet/rpc/spend.cpp", "test/functional/wallet_bumpfee.py"] | bumpfee behavior with custom change address | If I create an RBF transaction using the Qt GUI but specify my own custom change address, bumpfee doesn't work because it claims it can't find the change address:
"Transaction does not have a change output"
This is because none of the outputs satisfy
pWallet->IsChange(...)
I see there's a "TODO" commented in `CWallet::IsChange()` in `src/wallet/wallet.cpp`:
// TODO: fix handling of 'change' outputs. The assumption is that any
// payment to a script that is ours, but is not in the address book
// is change.
I tend to put all my addresses in the address book whether I'm going to use them as change or not. I guess if the wallet was capable of creating its own SegWit change addresses I'd stop using custom change addresses, but currently it always seems to send change to a legacy address if I don't manually specify a change address. | https://github.com/bitcoin/bitcoin/issues/11233 | https://github.com/bitcoin/bitcoin/pull/26467 | 5608e1d3b4ba3a23c05937918046e428be890505 | 04afe55e29002a1d46d1cd9ed117229874840ae6 | 2017-09-05T04:05:52Z | c++ | 2023-07-20T08:55:04Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,209 | ["src/qt/optionsmodel.cpp"] | [GUI] Proxies in QSettings storage without a colon cause crashes when options dialog is opened | If `addrProxy` or `addrSeparateProxyTor` do not have a colon in the string somewhere in the QSettings storage, then attempting to open the options dialog will cause the entire program to crash.
I'm not sure if this is really a problem since it is impossible to make those strings not have colons in them from normal operation. In order to replicate this, you must modify what QSettings stores (a conf file in Linux and Registry in Windows). | https://github.com/bitcoin/bitcoin/issues/11209 | https://github.com/bitcoin/bitcoin/pull/11448 | dbc4ae03963014ab4b7957d62ba59dbd8f938c33 | ce2418fa4cef5514305cca82e74891b9d643c4c7 | 2017-09-01T02:24:55Z | c++ | 2017-10-03T22:09:12Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,192 | ["src/qt/test/rpcnestedtests.cpp", "src/qt/test/test_main.cpp"] | test: test_bitcoin-qt creates an empty `~/.bitcoin` | Ideally the tests wouldn't touch the default data directory. Both the core unit tests and the functional tests do this correctly. However, `src/qt/test/test_bitcoin-qt` seems to create an empty `~/.bitcoin` directory if it doesn't exist yet.
Instead, it should set up a temporary data directory like the other tests. | https://github.com/bitcoin/bitcoin/issues/11192 | https://github.com/bitcoin/bitcoin/pull/11210 | d81dccf191a48a6b59c3747d7b4ccbe3535dde40 | dea086f498097d19a2c9acbfc753c9c2d68dbb03 | 2017-08-29T12:45:27Z | c++ | 2017-09-01T11:19:23Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,168 | ["src/qt/bitcoingui.cpp"] | [GUI] Tabs Toolbar menu option makes tabs disappear for the session | In the GUI, if you right click on the tabs at the top, a menu appears with a checkbox item that says `Tabs Toolbar`. Clicking that makes the tabs at the top disappear. However there is no way for the tabs to be brought back except by restarting the software.
IMO it really isn't useful to hide the tabs and I'm not sure if there is an easy way to make a menu which brings them back. | https://github.com/bitcoin/bitcoin/issues/11168 | https://github.com/bitcoin/bitcoin/pull/11169 | 7fd49d01dc2ea444ba4d81d0cfa17486b03c8515 | e2548302f40ca73f990583848292965f42ecc576 | 2017-08-27T04:36:39Z | c++ | 2017-08-27T05:08:19Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,114 | ["src/script/script.h", "src/test/script_tests.cpp"] | CScript += operator double free if destination and operand are the same. | ### Describe the issue
### Can you reliably reproduce the issue?
#### If so, please list the steps to reproduce below:
```c
CScript cs;
cs << ParseHex("04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5f")
<< OP_CHECKSIG;
cs += cs;
```
### Expected behaviour
Safe behaviour: no double free.
### Actual behaviour
Insecure behaviour: double-free.
### Screenshots.
### What version of bitcoin-core are you using?
bitcoin-0.14.2, self-compiled
### Machine specs:
- OS: Linux
- CPU:
- RAM:
- Disk size:
- Disk Type (HD/SDD):
### Any extra information that might be useful in the debugging process.
AddressSanitizer backtrace:
```
=================================================================
==3429==ERROR: AddressSanitizer: heap-use-after-free on address
0x60b000000040 at pc 0x0000004f919c bp 0x7ffe66520c30 sp
0x7ffe66520c28
READ of size 1 at 0x60b000000040 thread T0
#0 0x4f919b in void prevector<28u, unsigned char, unsigned int,
int>::insert<prevector<28u, unsigned char, unsigned int,
int>::const_iterator>(prevector<28u, unsigned char, unsigned int,
int>::iterator, prevector<28u, unsigned char, unsigned int,
int>::const_iterator, prevector<28u, unsigned char, unsigned int,
int>::const_iterator)
/home/jhg/extrahd/bitcoin-fuzzer/bitcoin-0.14.2/fuzz-pr/../src/prevector.h:378:52
#1 0x4f919b in CScript::operator+=(CScript const&)
/home/jhg/extrahd/bitcoin-fuzzer/bitcoin-0.14.2/fuzz-pr/../src/script/script.h:403
#2 0x4f919b in main
/home/jhg/extrahd/bitcoin-fuzzer/bitcoin-0.14.2/fuzz-pr/cscript-test.cpp:11
#3 0x7f3667db3b44 in __libc_start_main
/build/glibc-6V9RKT/glibc-2.19/csu/libc-start.c:287
#4 0x420d1f in _start
(/home/jhg/extrahd/bitcoin-fuzzer/bitcoin-0.14.2/fuzz-pr/a.out+0x420d1f)
0x60b000000040 is located 0 bytes inside of 99-byte region
[0x60b000000040,0x60b0000000a3)
freed by thread T0 here:
#0 0x4c9015 in realloc
(/home/jhg/extrahd/bitcoin-fuzzer/bitcoin-0.14.2/fuzz-pr/a.out+0x4c9015)
#1 0x4fe2b9 in prevector<28u, unsigned char, unsigned int,
int>::change_capacity(unsigned int)
/home/jhg/extrahd/bitcoin-fuzzer/bitcoin-0.14.2/fuzz-pr/../src/prevector.h:177:54
#2 0x4f8a54 in void prevector<28u, unsigned char, unsigned int,
int>::insert<prevector<28u, unsigned char, unsigned int,
int>::const_iterator>(prevector<28u, unsigned char, unsigned int,
int>::iterator, prevector<28u, unsigned char, unsigned int,
int>::const_iterator, prevector<28u, unsigned char, unsigned int,
int>::const_iterator)
/home/jhg/extrahd/bitcoin-fuzzer/bitcoin-0.14.2/fuzz-pr/../src/prevector.h:373:13
#3 0x4f8a54 in CScript::operator+=(CScript const&)
/home/jhg/extrahd/bitcoin-fuzzer/bitcoin-0.14.2/fuzz-pr/../src/script/script.h:403
#4 0x4f8a54 in main
/home/jhg/extrahd/bitcoin-fuzzer/bitcoin-0.14.2/fuzz-pr/cscript-test.cpp:11
#5 0x7f3667db3b44 in __libc_start_main
/build/glibc-6V9RKT/glibc-2.19/csu/libc-start.c:287
previously allocated by thread T0 here:
#0 0x4c8c73 in __interceptor_malloc
(/home/jhg/extrahd/bitcoin-fuzzer/bitcoin-0.14.2/fuzz-pr/a.out+0x4c8c73)
#1 0x4fe0f1 in prevector<28u, unsigned char, unsigned int,
int>::change_capacity(unsigned int)
/home/jhg/extrahd/bitcoin-fuzzer/bitcoin-0.14.2/fuzz-pr/../src/prevector.h:181:57
#2 0x4fb16c in void prevector<28u, unsigned char, unsigned int,
int>::insert<__gnu_cxx::__normal_iterator<unsigned char const*,
std::vector<unsigned char, std::allocator<unsigned char> > >
>(prevector<28u, unsigned char, unsigned int, int>::iterator,
__gnu_cxx::__normal_iterator<unsigned char const*,
std::vector<unsigned char, std::allocator<unsigned char> > >,
__gnu_cxx::__normal_iterator<unsigned char const*,
std::vector<unsigned char, std::allocator<unsigned char> > >)
/home/jhg/extrahd/bitcoin-fuzzer/bitcoin-0.14.2/fuzz-pr/../src/prevector.h:373:13
#3 0x4fb16c in CScript::operator<<(std::vector<unsigned char,
std::allocator<unsigned char> > const&)
/home/jhg/extrahd/bitcoin-fuzzer/bitcoin-0.14.2/fuzz-pr/../src/script/script.h:462
#4 0x4f8503 in main
/home/jhg/extrahd/bitcoin-fuzzer/bitcoin-0.14.2/fuzz-pr/cscript-test.cpp:10:8
#5 0x7f3667db3b44 in __libc_start_main
/build/glibc-6V9RKT/glibc-2.19/csu/libc-start.c:287
``` | https://github.com/bitcoin/bitcoin/issues/11114 | https://github.com/bitcoin/bitcoin/pull/11284 | ee50c9e48786dea0d9df2e45805c25565c100fe3 | d601f16621e55c2f174afea2c5d7d1c9a0c0b969 | 2017-08-22T23:55:49Z | c++ | 2017-09-11T03:40:31Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,106 | ["src/init.cpp", "src/txdb.h", "src/validation.cpp", "src/validation.h", "src/wallet/crypter.h"] | Race in printing mapBlockIndex.size() in init | init.cpp:1635 prints mapBlockIndex.size() without cs_main. This is technically a race (though it is rather inconsequential). At some point someone should fix this so tsan stops complaining. | https://github.com/bitcoin/bitcoin/issues/11106 | https://github.com/bitcoin/bitcoin/pull/11107 | 731065b114452ff770320d09639448b3c9a74b0a | c626dcb50eed496462fd4ac3e05bf79164749ebe | 2017-08-21T15:25:00Z | c++ | 2017-09-09T23:29:08Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,016 | ["src/qt/forms/debugwindow.ui", "src/qt/overviewpage.cpp", "src/qt/rpcconsole.cpp", "src/qt/rpcconsole.h"] | [Qt] Warning messages are not displayed when running bitcoin-qt with -disablewallet | ### Describe the issue
Warning messages are not displayed when running bitcoin-qt 0.14.2 and 0.14.99 with -disablewallet.
It might be better to always display them.
E.g. on MainNet the "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications" is lost
On TestNet also the "Warning: unknown new rules activated (versionbit 28)" is missed
| https://github.com/bitcoin/bitcoin/issues/11016 | https://github.com/bitcoin/bitcoin/pull/14879 | bfd7e5409720445b8439de20a5695b220f79f53d | 593ba696fb32da558091ac02ad87c4893db4ce97 | 2017-08-09T07:39:54Z | c++ | 2019-01-25T12:50:30Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 11,004 | [".travis.yml"] | New Travis job for CHECK_DOCS steps | This is a request to change how the Travis job is configured for Bitcoin. I'd submit a PR to do this myself, but the change can only be made by someone who has Travis configuration permissions for the bitcoin repo.
## Background
Currently there are a number of static-analysis style checks that are run in Travis, guarded by the `CHECK_DOC` environment variable. This variable is only set for the first test runner (the arm-linux-gnueabihf host), so the checks are only run once. All of these checks run very fast, and do not require building Bitcoin or running the regular C++/Python tests.
## Request
Configure a new Travis job that runs against PRs, and only runs the `CHECK_DOC` tests. At the same time, the `CHECK_DOC` stuff in the existing job would be removed.
## Motivation
Creating a separate Travis job for these tests would be an improvement because:
* It would be more immediately obvious that a `CHECK_DOC` failure is related to one of the check scripts; currently it's confusing to new contributors (e.g. me) to see an ARM failure, when the failure is not actually related to any new architecture-specific code.
* The job would either pass quickly or fail quickly, giving faster feedback to developers who submit PRs.
* The main `.travis.yml` file in the repo could be cleaned up, by removing the `CHECK_DOC` guards in the `before_script` and `script` sections. | https://github.com/bitcoin/bitcoin/issues/11004 | https://github.com/bitcoin/bitcoin/pull/13183 | 66cc47be982aa431b72494f5d655c20eea17a0f5 | 18c0b8430820114d14a15fe19b7ae86e62be17d8 | 2017-08-07T23:23:14Z | c++ | 2018-05-09T01:47:05Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,993 | ["src/net_processing.cpp", "test/functional/p2p_leak.py", "test/functional/test_framework/messages.py"] | Return service bits 6 and 8 on Aug 1, 2018 | #10982 started disconnecting service bits 6 and 8 until aug 1, 2018, the code to do so should be removed on or after that date. | https://github.com/bitcoin/bitcoin/issues/10993 | https://github.com/bitcoin/bitcoin/pull/11637 | b05ded176466dde1cf06b21834afcc46824eabb3 | fa4bf92be9420919c74cdde9a973f7327d01ac88 | 2017-08-05T14:36:03Z | c++ | 2018-07-11T14:32:25Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,987 | ["src/wallet/wallet.cpp"] | Wallet rescan is non-interruptible at startup | When the wallet is rescanned at startup in `bitcoind`, there seems to be no way to interrupt that in a clean way (other than forcefully killing the process). | https://github.com/bitcoin/bitcoin/issues/10987 | https://github.com/bitcoin/bitcoin/pull/12507 | 0bc980b1f65f3739bb9667d58abab1137c0f942a | c4fda7672a975acc1a8c0faa559af0dcc223b95e | 2017-08-04T01:27:33Z | c++ | 2018-05-02T10:58:02Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,981 | ["src/wallet/rpcwallet.cpp", "src/wallet/wallet.cpp", "src/wallet/wallet.h"] | resendwallettransactions asserts if walletbroadcast=0 | There is an assert in `CWalletTx::RelayWalletTransaction` that gets hit. All other code paths check `fBroadcastTransactions` before getting to `CWallet::ResendWalletTransactionsBefore` except the rpc call `resendwalletransactions`.
It's an easy fix, but we just need to decide whether to throw an error or return an empty array of rebroadcasted transaction ids.
Should be fixed for 0.15. | https://github.com/bitcoin/bitcoin/issues/10981 | https://github.com/bitcoin/bitcoin/pull/10995 | a9dd11144152bf40fa797cc0b0c8857c03d3ad6a | 01699fb283485918478017331872c75817b81bdb | 2017-08-03T19:30:42Z | c++ | 2017-08-07T01:40:56Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,869 | [".cirrus.yml", "test/functional/test_framework/util.py"] | Travis: failed to bind to port 11211 | Looks like a spurious Travis failure in p2p-segwit.py here: https://travis-ci.org/bitcoin/bitcoin/jobs/254520908#L5356
```
2017-07-17 19:06:34.660901 Unable to bind to 0.0.0.0:11211 on this computer. Bitcoin Core is probably already running.
```
test_runner.py and test_framework.py are very careful to not re-use ports for p2p and rpc interfaces on different nodes/tests, so perhaps another process was bound to 11211. Googling for port 11211 shows that it's memcached's default port.
Should be easy to test whether port 11211 causes problems by pushing a branch with `port_seed()` changed.
| https://github.com/bitcoin/bitcoin/issues/10869 | https://github.com/bitcoin/bitcoin/pull/16918 | 7d4bc60f1fee785d355fe4d376c0a369fc64dd68 | fa69588537bc91c0aedbc89ef1760d89cbffad75 | 2017-07-18T17:16:56Z | c++ | 2019-09-19T16:03:40Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,828 | ["configure.ac"] | --disable-lcov complains there's no lcov | This is 0.14.2 being built on openBSD 6.1-current.
```
env AUTOCONF_VERSION=2.69 AUTOMAKE_VERSION=1.15 sh autogen.sh
./configure --prefix=$HOME --mandir=$HOME/man --disable-tests --disable-gui-tests --disable-wallet --with-gui=no --disable-lcov CC=egcc CXX=eg++
...
configure: error: "lcov testing requested but lcov not found"
```
| https://github.com/bitcoin/bitcoin/issues/10828 | https://github.com/bitcoin/bitcoin/pull/11611 | 2f959a58744d42859d74579220922e25ac3d2925 | 223a4aabd3681817f3ced5b2441a6b44fcf29c4e | 2017-07-14T17:49:04Z | c++ | 2017-11-05T06:10:33Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,826 | ["configure.ac"] | --with-boost=no requires boost | This is 0.14.2 being built on OpenBSD 6.1-current.
If I don't mention boost at all in ./configure, it gets detected and compiled in.
Strangely, `./configure --with-boost=no ` fails and complains boost was not found.
```
env AUTOCONF_VERSION=2.69 AUTOMAKE_VERSION=1.15 sh autogen.sh
./configure --prefix=$HOME --mandir=$HOME/man --disable-tests --disable-gui-tests --disable-wallet --with-gui=no --with-boost=no CC=egcc CXX=eg++
...
checking whether the Boost::System library is available... yes
configure: error: Could not find a version of the boost_system library!
```
Even more confusingly, it reports Boost::System as available,
only to complain it could not find it a line later.
| https://github.com/bitcoin/bitcoin/issues/10826 | https://github.com/bitcoin/bitcoin/pull/11936 | 62fdf9b07087b80d2142799bdd2324f61483359d | 3eb4d4595c69ac5885fb4a144e48e9a884f0186f | 2017-07-14T16:03:47Z | c++ | 2017-12-18T06:32:22Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,796 | ["doc/build-openbsd.md"] | please adjust URL in OpenBSD build instructions | in doc/build-openbsd.md
is download for boost_1_61_0.tar.bz2 referenced to a non working URL http://heanet.dl.sourceforge.net/project/boost/boost/1.61.0/boost_1_61_0.tar.bz2
I successfully downloaded and SHA256 checked boost_1_61_0.tar.bz2 from this URL
https://downloads.sf.net/project/boost/boost/1.61.0/boost_1_61_0.tar.bz2
(that URL is adjusted to some mirror, which is ok)
thank you | https://github.com/bitcoin/bitcoin/issues/10796 | https://github.com/bitcoin/bitcoin/pull/11080 | 22e301a3d56dc9e6878380ee92c7d19ca43119d2 | 5be6e9b4f9991a5f8ff74aa8aaa4962cb45728b6 | 2017-07-11T20:54:31Z | c++ | 2017-08-17T17:20:14Z |
closed | bitcoin/bitcoin | https://github.com/bitcoin/bitcoin | 10,611 | ["src/random.cpp"] | Gitian build (current master) crashes on OSX | Nighly build from 2017-06-15 crashes (https://bitcoin.jonasschnelli.ch/build/176)
Nighy build from 2017-06-14 works fine (https://bitcoin.jonasschnelli.ch/build/175)
Relevant commit must be between 228c319a and fbf5d3ba.
```shell
jonasschnelli@Jonass-MBP:~/Documents/bitcoin/bitcoin$ ~/Downloads/bitcoin-0.14.n/bin/bitcoind --regtest
Abort trap: 6
jonasschnelli@Jonass-MBP:~/Documents/bitcoin/bitcoin$ lldb ~/Downloads/bitcoin-0.14.n/bin/bitcoind
(lldb) target create "/Users/jonasschnelli/Downloads/bitcoin-0.14.n/bin/bitcoind"
Current executable set to '/Users/jonasschnelli/Downloads/bitcoin-0.14.n/bin/bitcoind' (x86_64).
(lldb) run --regtest
Process 29763 launched: '/Users/jonasschnelli/Downloads/bitcoin-0.14.n/bin/bitcoind' (x86_64)
Process 29763 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
frame #0: 0x00007fff94f74d42 libsystem_kernel.dylib`__pthread_kill + 10
libsystem_kernel.dylib`__pthread_kill:
-> 0x7fff94f74d42 <+10>: jae 0x7fff94f74d4c ; <+20>
0x7fff94f74d44 <+12>: movq %rax, %rdi
0x7fff94f74d47 <+15>: jmp 0x7fff94f6dcaf ; cerror_nocancel
0x7fff94f74d4c <+20>: retq
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
* frame #0: 0x00007fff94f74d42 libsystem_kernel.dylib`__pthread_kill + 10
frame #1: 0x00007fff950625bf libsystem_pthread.dylib`pthread_kill + 90
frame #2: 0x00007fff94eda4bb libsystem_c.dylib`__abort + 140
frame #3: 0x00007fff94edad7e libsystem_c.dylib`__stack_chk_fail + 205
frame #4: 0x0000000100270364 bitcoind`___lldb_unnamed_symbol4989$$bitcoind + 228
frame #5: 0x0000000100046660 bitcoind`___lldb_unnamed_symbol475$$bitcoind + 32
frame #6: 0x0000000100003be9 bitcoind`___lldb_unnamed_symbol1$$bitcoind + 2665
frame #7: 0x00000001000042a1 bitcoind`___lldb_unnamed_symbol2$$bitcoind + 49
frame #8: 0x00007fff94e46235 libdyld.dylib`start + 1
(lldb)
``` | https://github.com/bitcoin/bitcoin/issues/10611 | https://github.com/bitcoin/bitcoin/pull/10614 | c2ab38bdd57a16e6c708dcc633d9162331c9d311 | 9af207c810b5c4b09ccbdec75582b3e34e32e8cc | 2017-06-16T12:39:53Z | c++ | 2017-06-16T19:19:15Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.