commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
Use post-increment only in inffast.c.
An old inffast.c optimization turns out to not be optimal anymore
with modern compilers, and furthermore was not compliant with the
C standard, for which decrementing a pointer before its allocated
memory is undefined. Per the recommendation of a security audit of
the zlib code by Trail of Bits and TrustInSoft, in support of the
Mozilla Foundation, this "optimization" was removed, in order to
avoid the possibility of undefined behavior. | 9aaec95e82117c1cb0f9624264c3618fc380cecb | zlib | bigvul | 1 | null | null | null |
Remove offset pointer optimization in inftrees.c.
inftrees.c was subtracting an offset from a pointer to an array,
in order to provide a pointer that allowed indexing starting at
the offset. This is not compliant with the C standard, for which
the behavior of a pointer decremented before its allocated memory
is undefined. Per the recommendation of a security audit of the
zlib code by Trail of Bits and TrustInSoft, in support of the
Mozilla Foundation, this tiny optimization was removed, in order
to avoid the possibility of undefined behavior. | 6a043145ca6e9c55184013841a67b2fef87e44c0 | zlib | bigvul | 1 | null | null | null |
ring-buffer: Prevent overflow of size in ring_buffer_resize()
If the size passed to ring_buffer_resize() is greater than MAX_LONG - BUF_PAGE_SIZE
then the DIV_ROUND_UP() will return zero.
Here's the details:
# echo 18014398509481980 > /sys/kernel/debug/tracing/buffer_size_kb
tracing_entries_write() processes this and converts kb to bytes.
18014398509481980 << 10 = 18446744073709547520
and this is passed to ring_buffer_resize() as unsigned long size.
size = DIV_ROUND_UP(size, BUF_PAGE_SIZE);
Where DIV_ROUND_UP(a, b) is (a + b - 1)/b
BUF_PAGE_SIZE is 4080 and here
18446744073709547520 + 4080 - 1 = 18446744073709551599
where 18446744073709551599 is still smaller than 2^64
2^64 - 18446744073709551599 = 17
But now 18446744073709551599 / 4080 = 4521260802379792
and size = size * 4080 = 18446744073709551360
This is checked to make sure its still greater than 2 * 4080,
which it is.
Then we convert to the number of buffer pages needed.
nr_page = DIV_ROUND_UP(size, BUF_PAGE_SIZE)
but this time size is 18446744073709551360 and
2^64 - (18446744073709551360 + 4080 - 1) = -3823
Thus it overflows and the resulting number is less than 4080, which makes
3823 / 4080 = 0
an nr_pages is set to this. As we already checked against the minimum that
nr_pages may be, this causes the logic to fail as well, and we crash the
kernel.
There's no reason to have the two DIV_ROUND_UP() (that's just result of
historical code changes), clean up the code and fix this bug.
Cc: [email protected] # 3.5+
Fixes: 83f40318dab00 ("ring-buffer: Make removal of ring buffer pages atomic")
Signed-off-by: Steven Rostedt <[email protected]> | 59643d1535eb220668692a5359de22545af579f6 | linux | bigvul | 1 | null | null | null |
Fixed an array overflow problem in the JPC decoder. | 1abc2e5a401a4bf1d5ca4df91358ce5df111f495 | jasper | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/298 | b61d35eaccc0a7ddeff8a1c3abfcd0a43ccf210b | imagemagick | bigvul | 1 | null | null | null |
The generation of the configuration file jas_config.h has been completely
reworked in order to avoid pollution of the global namespace.
Some problematic types like uchar, ulong, and friends have been replaced
with names with a jas_ prefix.
An option max_samples has been added to the BMP and JPEG decoders to
restrict the maximum size of image that they can decode. This change
was made as a (possibly temporary) fix to address security concerns.
A max_samples command-line option has also been added to imginfo.
Whether an image component (for jas_image_t) is stored in memory or on
disk is now based on the component size (rather than the image size).
Some debug log message were added.
Some new integer overflow checks were added.
Some new safe integer add/multiply functions were added.
More pre-C99 cruft was removed. JasPer has numerous "hacks" to
handle pre-C99 compilers. JasPer now assumes C99 support. So, this
pre-C99 cruft is unnecessary and can be removed.
The regression jasper-doublefree-mem_close.jpg has been re-enabled.
Theoretically, it should work more predictably now. | d42b2388f7f8e0332c846675133acea151fc557a | jasper | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/301 | ce98a7acbcfca7f0a178f4b1e7b957e419e0cc99 | imagemagick | bigvul | 1 | null | null | null |
Fix uninitialised values for <i> and <dd>
Bug-Debian: https://github.com/tats/w3m/issues/16 | 33509cc81ec5f2ba44eb6fd98bd5c1b5873e46bd | w3m | bigvul | 1 | null | null | null |
added some checks to snap handling | ff254722a2683867fcb3e67569ffd36226c4bc62 | teeworlds | bigvul | 1 | null | null | null |
Added some missing sanity checks on the data in a SIZ marker segment. | f7038068550fba0e41e1d0c355787f1dcd5bf330 | jasper | bigvul | 1 | null | null | null |
Changed the JPC bitstream code to more gracefully handle a request
for a larger sized integer than what can be handled (i.e., return
with an error instead of failing an assert). | 1e84674d95353c64e5c4c0e7232ae86fd6ea813b | jasper | bigvul | 1 | null | null | null |
Ensure that not all tiles lie outside the image area. | ba2b9d000660313af7b692542afbd374c5685865 | jasper | bigvul | 1 | null | null | null |
The component domains must be the same for the ICT/RCT in the JPC codec.
This was previously enforced with an assertion.
Now, it is handled in a more graceful manner. | dee11ec440d7908d1daf69f40a3324b27cf213ba | jasper | bigvul | 1 | null | null | null |
Fixed a few bugs in the RAS encoder and decoder where errors were tested
with assertions instead of being gracefully handled. | 411a4068f8c464e883358bf403a3e25158863823 | jasper | bigvul | 1 | null | null | null |
Fixed another integer overflow problem. | d91198abd00fc435a397fe6bad906a4c1748e9cf | jasper | bigvul | 1 | null | null | null |
Fix #340: System frozen
gdImageCreate() doesn't check for oversized images and as such is prone
to DoS vulnerabilities. We fix that by applying the same overflow check
that is already in place for gdImageCreateTrueColor().
CVE-2016-9317 | 1846f48e5fcdde996e7c27a4bbac5d0aef183e4b | libgd | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/296 | 3cbfb163cff9e5b8cdeace8312e9bfee810ed02b | imagemagick | bigvul | 1 | null | null | null |
Made some changes to the I/O stream library for memory streams.
There were a number of potential problems due to the possibility
of integer overflow.
Changed some integral types to the larger types size_t or ssize_t.
For example, the function mem_resize now takes the buffer size parameter
as a size_t.
Added a new function jas_stream_memopen2, which takes a
buffer size specified as a size_t instead of an int.
This can be used in jas_image_cmpt_create to avoid potential
overflow problems.
Added a new function jas_deprecated to warn about reliance on
deprecated library behavior. | 634ce8e8a5accc0fa05dd2c20d42b4749d4b2735 | jasper | bigvul | 1 | null | null | null |
Fix BER decoder integer overflow | 987ad747db6d0d7e36f840398f3cf02e2fbfd90f | botan | bigvul | 1 | null | null | null |
Fixed a bug that resulted in the destruction of JP2 box data that had never
been constructed in the first place. | e24bdc716c3327b067c551bc6cfb97fd2370358d | jasper | bigvul | 1 | null | null | null |
Fixed a problem with a null pointer dereference in the BMP decoder. | 5d66894d2313e3f3469f19066e149e08ff076698 | jasper | bigvul | 1 | null | null | null |
Add a one-word sentinel value of 0x0 at the end of each buf_t chunk
This helps protect against bugs where any part of a buf_t's memory
is passed to a function that expects a NUL-terminated input.
It also closes TROVE-2016-10-001 (aka bug 20384). | 3cea86eb2fbb65949673eb4ba8ebb695c87a57ce | tor | bigvul | 1 | null | null | null |
The memory stream interface allows for a buffer size of zero.
The case of a zero-sized buffer was not handled correctly, as it could
lead to a double free.
This problem has now been fixed (hopefully).
One might ask whether a zero-sized buffer should be allowed at all,
but this is a question for another day. | 44a524e367597af58d6265ae2014468b334d0309 | jasper | bigvul | 1 | null | null | null |
Added range check on XRsiz and YRsiz fields of SIZ marker segment. | d8c2604cd438c41ec72aff52c16ebd8183068020 | jasper | bigvul | 1 | null | null | null |
Fixed a sanitizer failure in the BMP codec.
Also, added a --debug-level command line option to the imginfo command
for debugging purposes. | 8f62b4761711d036fd8964df256b938c809b7fca | jasper | bigvul | 1 | null | null | null |
Issue 761: Heap overflow reading corrupted 7Zip files
The sample file that demonstrated this had multiple 'EmptyStream'
attributes. The first one ended up being used to calculate
certain statistics, then was overwritten by the second which
was incompatible with those statistics.
The fix here is to reject any header with multiple EmptyStream
attributes. While here, also reject headers with multiple
EmptyFile, AntiFile, Name, or Attributes markers. | 7f17c791dcfd8c0416e2cd2485b19410e47ef126 | libarchive | bigvul | 1 | null | null | null |
Issue 747 (and others?): Avoid OOB read when parsing multiple long lines
The mtree bidder needs to look several lines ahead
in the input. It does this by extending the read-ahead
and parsing subsequent lines from the same growing buffer.
A bookkeeping error when extending the read-ahead would
sometimes lead it to significantly over-count the
size of the line being read. | eec077f52bfa2d3f7103b4b74d52572ba8a15aca | libarchive | bigvul | 1 | null | null | null |
Issue #767: Buffer overflow printing a filename
The safe_fprintf function attempts to ensure clean output for an
arbitrary sequence of bytes by doing a trial conversion of the
multibyte characters to wide characters -- if the resulting wide
character is printable then we pass through the corresponding bytes
unaltered, otherwise, we convert them to C-style ASCII escapes.
The stack trace in Issue #767 suggest that the 20-byte buffer
was getting overflowed trying to format a non-printable multibyte
character. This should only happen if there is a valid multibyte
character of more than 5 bytes that was unprintable. (Each byte
would get expanded to a four-charcter octal-style escape of the form
"\123" resulting in >20 characters for the >5 byte multibyte character.)
I've not been able to reproduce this, but have expanded the conversion
buffer to 128 bytes on the belief that no multibyte character set
has a single character of more than 32 bytes. | e37b620fe8f14535d737e89a4dcabaed4517bf1a | libarchive | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/268 | 6e48aa92ff4e6e95424300ecd52a9ea453c19c60 | imagemagick | bigvul | 1 | null | null | null |
m4vdec: Check for non-startcode 00 00 00 sequences in probe
This makes the m4v detection less trigger-happy.
Bug-Id: 949
Signed-off-by: Diego Biurrun <[email protected]> | e5b019725f53b79159931d3a7317107cbbfd0860 | libav | bigvul | 1 | null | null | null |
Avoid potentially dangerous signed to unsigned conversion
We make sure to never pass a negative `rlen` as size to memcpy(). See
also <https://bugs.php.net/bug.php?id=73280>.
Patch provided by Emmanuel Law. | 53110871935244816bbb9d131da0bccff734bfe9 | libgd | bigvul | 1 | null | null | null |
attach: do not send procfd to attached process
So far, we opened a file descriptor refering to proc on the host inside the
host namespace and handed that fd to the attached process in
attach_child_main(). This was done to ensure that LSM labels were correctly
setup. However, by exploiting a potential kernel bug, ptrace could be used to
prevent the file descriptor from being closed which in turn could be used by an
unprivileged container to gain access to the host namespace. Aside from this
needing an upstream kernel fix, we should make sure that we don't pass the fd
for proc itself to the attached process. However, we cannot completely prevent
this, as the attached process needs to be able to change its apparmor profile
by writing to /proc/self/attr/exec or /proc/self/attr/current. To minimize the
attack surface, we only send the fd for /proc/self/attr/exec or
/proc/self/attr/current to the attached process. To do this we introduce a
little more IPC between the child and parent:
* IPC mechanism: (X is receiver)
* initial process intermediate attached
* X <--- send pid of
* attached proc,
* then exit
* send 0 ------------------------------------> X
* [do initialization]
* X <------------------------------------ send 1
* [add to cgroup, ...]
* send 2 ------------------------------------> X
* [set LXC_ATTACH_NO_NEW_PRIVS]
* X <------------------------------------ send 3
* [open LSM label fd]
* send 4 ------------------------------------> X
* [set LSM label]
* close socket close socket
* run program
The attached child tells the parent when it is ready to have its LSM labels set
up. The parent then opens an approriate fd for the child PID to
/proc/<pid>/attr/exec or /proc/<pid>/attr/current and sends it via SCM_RIGHTS
to the child. The child can then set its LSM laben. Both sides then close the
socket fds and the child execs the requested process.
Signed-off-by: Christian Brauner <[email protected]> | 81f466d05f2a89cb4f122ef7f593ff3f279b165c | lxc | bigvul | 1 | null | null | null |
IB/rxe: Fix mem_check_range integer overflow
Update the range check to avoid integer-overflow in edge case.
Resolves CVE 2016-8636.
Signed-off-by: Eyal Itkin <[email protected]>
Signed-off-by: Dan Carpenter <[email protected]>
Reviewed-by: Leon Romanovsky <[email protected]>
Signed-off-by: Doug Ledford <[email protected]> | 647bf3d8a8e5777319da92af672289b2a6c4dc66 | linux | bigvul | 1 | null | null | null |
shaper: fix reallocation
Update the variable that tracks the allocated size. This potentially
improves performance and avoid some side effects, which lead to
undefined behavior in some cases.
Fixes fuzzer test case id:000051,sig:11,sync:fuzzer3,src:004221. | aa54e0b59200a994d50a346b5d7ac818ebcf2d4b | libass | bigvul | 1 | null | null | null |
Fix blur coefficient calculation buffer overflow
Found by fuzzer test case id:000082,sig:11,src:002579,op:havoc,rep:8.
Correctness should be checked, but this fixes the overflow for good. | 08e754612019ed84d1db0d1fc4f5798248decd75 | libass | bigvul | 1 | null | null | null |
Fix line wrapping mode 0/3 bugs
This fixes two separate bugs:
a) Don't move a linebreak into the first symbol. This results in a empty
line at the front, which does not help to equalize line lengths at all.
b) When moving a linebreak into a symbol that already is a break, the
number of lines must be decremented. Otherwise, uninitialized memory
is possibly used for later layout operations.
Found by fuzzer test case
id:000085,sig:11,src:003377+003350,op:splice,rep:8. | b72b283b936a600c730e00875d7d067bded3fc26 | libass | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/281 | d63a3c5729df59f183e9e110d5d8385d17caaad0 | imagemagick | bigvul | 1 | null | null | null |
Verify UpdateTempDir isn't maliciously modified
Don't just delete the stored updates temporary directory on launch, but
validate the registry key to ensure it is in an expected location and
follows WinSparkle's naming convention. This is to prevent malicious
users from modifying this registry key and forcing the host app to
delete arbitrary directories (a user being able to delete the key would
be able to delete the directory themselves, so it's not a serious issue,
but it nevertheless is bad behavior and shouldn't be possible). | bb454857348245a7397f9e4fbb3a902f4ac25913 | winsparkle | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/280 | a7bb158b7bedd1449a34432feb3a67c8f1873bfa | imagemagick | bigvul | 1 | null | null | null |
cipher: don't set dummy encryption key in Cipher#initialize
Remove the encryption key initialization from Cipher#initialize. This
is effectively a revert of r32723 ("Avoid possible SEGV from AES
encryption/decryption", 2011-07-28).
r32723, which added the key initialization, was a workaround for
Ruby Bug #2768. For some certain ciphers, calling EVP_CipherUpdate()
before setting an encryption key caused segfault. It was not a problem
until OpenSSL implemented GCM mode - the encryption key could be
overridden by repeated calls of EVP_CipherInit_ex(). But, it is not the
case for AES-GCM ciphers. Setting a key, an IV, a key, in this order
causes the IV to be reset to an all-zero IV.
The problem of Bug #2768 persists on the current versions of OpenSSL.
So, make Cipher#update raise an exception if a key is not yet set by the
user. Since encrypting or decrypting without key does not make any
sense, this should not break existing applications.
Users can still call Cipher#key= and Cipher#iv= multiple times with
their own responsibility.
Reference: https://bugs.ruby-lang.org/issues/2768
Reference: https://bugs.ruby-lang.org/issues/8221
Reference: https://github.com/ruby/openssl/issues/49 | 8108e0a6db133f3375608303fdd2083eb5115062 | openssl | bigvul | 1 | null | null | null |
Fix: remote: cl#5269 - Notify other clients of a new connection only if the handshake has completed (bsc#967388) | 5ec24a2642bd0854b884d1a9b51d12371373b410 | pacemaker | bigvul | 1 | null | null | null |
sandbox: create a new session for sandboxed processes
It helps to prevent sandboxed processes to inject arbitrary commands
into the parent.
Signed-off-by: Petr Lautrbach <[email protected]> | acca96a135a4d2a028ba9b636886af99c0915379 | selinux | bigvul | 1 | null | null | null |
Fix abort when writing to rgf format
The rgf format (LEGO MINDSTORMS EV3 images) caused a software abort because
exception == NULL. When WriteRGFImage is called from WriteImage, it is only
passed two parameters, not three. So, removed the extra parameter and use
image->exception instead as in other coders. | a0108a892f9ea3c2bb1e7a49b7d71376c2ecbff7 | imagemagick | bigvul | 1 | null | null | null |
http://www.imagemagick.org/discourse-server/viewtopic.php?f=2&t=28946 | 4e81ce8b07219c69a9aeccb0f7f7b927ca6db74c | imagemagick | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/148 | 53c1dcd34bed85181b901bfce1a2322f85a59472 | imagemagick | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/143 | 424d40ebfcde48bb872eba75179d3d73704fdf1f | imagemagick | bigvul | 1 | null | null | null |
Fixed SEGV reported in https://github.com/ImageMagick/ImageMagick/issues/130 | 478cce544fdf1de882d78381768458f397964453 | imagemagick | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/126 | 430403b0029b37decf216d57f810899cab2317dd | imagemagick | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/120 | bef1e4f637d8f665bc133a9c6d30df08d983bc3a | imagemagick | bigvul | 1 | null | null | null |
Added check for out of bounds read (https://github.com/ImageMagick/ImageMagick/issues/108). | 4f2c04ea6673863b87ac7f186cbb0d911f74085c | imagemagick | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/105 | c4e63ad30bc42da691f2b5f82a24516dd6b4dc70 | imagemagick | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/104 | a2e1064f288a353bc5fef7f79ccb7683759e775c | imagemagick | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/99 | ca0c886abd6d3ef335eb74150cd23b89ebd17135 | imagemagick | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/122 | a251039393f423c7858e63cab6aa98d17b8b7a41 | imagemagick | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/issues/102 | b6ae2f9e0ab13343c0281732d479757a8e8979c7 | imagemagick | bigvul | 1 | null | null | null |
Fixed head buffer overflow reported in: https://github.com/ImageMagick/ImageMagick/issues/98 | 5f16640725b1225e6337c62526e6577f0f88edb8 | imagemagick | bigvul | 1 | null | null | null |
Added extra check to fix https://github.com/ImageMagick/ImageMagick/issues/93 | 4b1b9c0522628887195bad3a6723f7000b0c9a58 | imagemagick | bigvul | 1 | null | null | null |
Moved check for https://github.com/ImageMagick/ImageMagick/issues/92. | 30eec879c8b446b0ea9a3bb0da1a441cc8482bc4 | imagemagick | bigvul | 1 | null | null | null |
https://bugs.launchpad.net/ubuntu/+source/imagemagick/+bug/1537213 | 14e606db148d6ebcaae20f1e1d6d71903ca4a556 | imagemagick | bigvul | 1 | null | null | null |
Fixed check for the number of pixels that will be allocated. | 2ad6d33493750a28a5a655d319a8e0b16c392de1 | imagemagick | bigvul | 1 | null | null | null |
Added missing call to ConstrainColormapIndex. | e14fd0a2801f73bdc123baf4fbab97dec55919eb | imagemagick | bigvul | 1 | null | null | null |
Fix bug #73257 and bug #73258 - SplObjectStorage unserialize allows use of non-object as key | 61cdd1255d5b9c8453be71aacbbf682796ac77d4 | php-src | bigvul | 1 | null | null | null |
Fix to prevent SASL security vulnerability | f50a84bad996d438e7b31b9e74c32a41e43f8be5 | nefarious2 | bigvul | 1 | null | null | null |
Fix AUTHENTICATE bug | f473e355e1dc422c4f019dbf86bc50ba1a34a766 | unrealircd | bigvul | 1 | null | null | null |
Prevent buffer overflow in BMP & SGI coders (bug report from pwchen&rayzhong of tencent) | 7afcf9f71043df15508e46f079387bd4689a738d | imagemagick | bigvul | 1 | null | null | null |
Fix double-free in gdImageWebPtr()
The issue is that gdImageWebpCtx() (which is called by gdImageWebpPtr() and
the other WebP output functions to do the real work) does not return whether
it succeeded or failed, so this is not checked in gdImageWebpPtr() and the
function wrongly assumes everything is okay, which is not, in this case,
because there is a size limitation for WebP, namely that the width and
height must by less than 16383.
We can't change the signature of gdImageWebpCtx() for API compatibility
reasons, so we introduce the static helper _gdImageWebpCtx() which returns
success respective failure, so gdImageWebpPtr() and gdImageWebpPtrEx() can
check the return value. We leave it solely to libwebp for now to report
warnings regarding the failing write.
This issue had been reported by Ibrahim El-Sayed to [email protected].
CVE-2016-6912 | a49feeae76d41959d85ee733925a4cf40bac61b2 | libgd | bigvul | 1 | null | null | null |
Fix invalid read in gdImageCreateFromTiffPtr()
tiff_invalid_read.tiff is corrupt, and causes an invalid read in
gdImageCreateFromTiffPtr(), but not in gdImageCreateFromTiff(). The culprit
is dynamicGetbuf(), which doesn't check for out-of-bound reads. In this case,
dynamicGetbuf() is called with a negative dp->pos, but also positive buffer
overflows have to be handled, in which case 0 has to be returned (cf. commit
75e29a9).
Fixing dynamicGetbuf() exhibits that the corrupt TIFF would still create
the image, because the return value of TIFFReadRGBAImage() is not checked.
We do that, and let createFromTiffRgba() fail if TIFFReadRGBAImage() fails.
This issue had been reported by Ibrahim El-Sayed to [email protected].
CVE-2016-6911 | 4859d69e07504d4b0a4bdf9bcb4d9e3769ca35ae | libgd | bigvul | 1 | null | null | null |
Fix OOB reads of the TGA decompression buffer
It is possible to craft TGA files which will overflow the decompression
buffer, but not the image's bitmap. Therefore we augment the check for the
bitmap's overflow with a check for the buffer's overflow.
This issue had been reported by Ibrahim El-Sayed to [email protected].
CVE-2016-6906 | fb0e0cce0b9f25389ab56604c3547351617e1415 | libgd | bigvul | 1 | null | null | null |
Fix infinite recursion in wddx
Summary:
It wasn't checking for infinite recursion due to references or self-referential
objects. As it turns out closures always return themselves when converted to an
array. Raising a warning and returning is how PHP-src deals with this problem,
nothing special is done for closures.
Reviewed By: alexmalyshev
Differential Revision: D3465655
fbshipit-source-id: a42bc34d30cf4825faf33596139c0c05f8e4f5f1 | 1888810e77b446a79a7674784d5f139fcfa605e2 | hhvm | bigvul | 1 | null | null | null |
Fix recursion checks in array_*_recursive
Summary:
array_merge_recursive and array_replace_recursive do recursion checks,
but use the fact that normal arrays can't contain cycles except
through references to avoid most of the checking.
Unfortunately the $GLOBALS array is special, and /can/ contain cycles
without references, and ProxyArrays could potentially do the same (via
an as-yet unimplemented extension).
Reviewed By: mxw
Differential Revision: D3622612
fbshipit-source-id: ed90b747096a05919a80c4793e2a2b7c57584d56 | 05e706d98f748f609b19d8697e490eaab5007d69 | hhvm | bigvul | 1 | null | null | null |
Fix self recursion in compact
Summary: There were no checks at all.
Reviewed By: alexmalyshev
Differential Revision: D3623763
fbshipit-source-id: 9d708deca05bbd121503e8f323b4f295fde8e835 | e264f04ae825a5d97758130cf8eec99862517e7e | hhvm | bigvul | 1 | null | null | null |
Fix integer overflow in StringUtil::implode
Reviewed By: ricklavoie
Differential Revision: D3623922
fbshipit-source-id: 136d124a850c07cc6c63535afc11d36499d576fc | 2c9a8fcc73a151608634d3e712973d192027c271 | hhvm | bigvul | 1 | null | null | null |
Fix buffer overrun due to integer overflow in bcmath
Summary: scale gets passed around as an int inside the library.
Reviewed By: mxw
Differential Revision: D3624520
fbshipit-source-id: d39927413cec24fda2e475a296ad5d9019ccef0a | c00fc9d3003eb06226b58b6a48555f1456ee2475 | hhvm | bigvul | 1 | null | null | null |
Use req::strndup in php_mb_parse_encoding_list to prevent oob memory write.
Summary:
Fix out of bounds write access in mb_detect_encoding. Using strndup in
php_mb_parse_encoding_list will cause strings with embedded nulls to be
unexpectedly shortened. The expected length of the string is tracked in
value_length but since strndup may copy fewer characters when there are
mbedded null this can lead to oob writes into tmpstr.
I've found a couple other places in this file that use strndup and replaced
them with req::strndup as well. The use of strndup in mb_send_mail also seemed
to be a leak.
This replaces uses of strndup with req::strndup which can handle embedded
nulls properly.
It looks like I also accidentally fixed t11337047 at the same time. Adding it to the list of tasks.
Reviewed By: paulbiss
Differential Revision: D3360065
fbshipit-source-id: 99776cf9105e3789883380bf30240009eec52cec | 365abe807cab2d60dc9ec307292a06181f77a9c2 | hhvm | bigvul | 1 | null | null | null |
Prevent buffer overflow in BMP coder (bug report from pwchen of tencent). | 4cc6ec8a4197d4c008577127736bf7985d632323 | imagemagick | bigvul | 1 | null | null | null |
7483 SMB flush on pipe triggers NULL pointer dereference in module smbsrv
Reviewed by: Gordon Ross <[email protected]>
Reviewed by: Matt Barden <[email protected]>
Reviewed by: Evan Layton <[email protected]>
Reviewed by: Dan McDonald <[email protected]>
Approved by: Gordon Ross <[email protected]> | 6d1c73b5858fefc6161c7d686345f0dc887ea799 | illumos-gate | bigvul | 1 | null | null | null |
7488 bcopy and bzero should mind signed bits
Reviewed by: Jerry Jelinek <[email protected]>
Reviewed by: Patrick Mooney <[email protected]>
Approved by: Richard Lowe <[email protected]> | 5aaab1a49679c26dbcb6fb6dc25799950d70cc71 | illumos-gate | bigvul | 1 | null | null | null |
Add ZRTP Commit packet hvi check on DHPart2 packet reception | bbb1e6e2f467ee4bd7b9a8c800e4f07343d7d99b | bzrtp | bigvul | 1 | null | null | null |
Don't allow unhandled POSTs to write to the filesystem by default
If there's no registered handler for a POST request, the default behaviour
is to write it to the filesystem. Several million deployed devices appear
to have this behaviour, making it possible to (at least) store arbitrary
data on them. Add a configure option that enables this behaviour, and change
the default to just drop POSTs that aren't directly handled. | be0a01bdb83395d9f3a5ea09c1308a4f1a972cbd | pupnp-code | bigvul | 1 | null | null | null |
rsa_verify_hash: fix possible bleichenbacher signature attack | 5eb9743410ce4657e9d54fef26a2ee31a1b5dd0 | libtomcrypt | bigvul | 1 | null | null | null |
fix bug #71719 (Buffer overflow in HTTP url parsing functions)
The parser's offset was not reset when we softfail in scheme
parsing and continue to parse a path.
Thanks to hlt99 at blinkenshell dot org for the report. | 3724cd76a28be1d6049b5537232e97ac | ext-http | bigvul | 1 | null | null | null |
Fix integer overflow in rwpng.h (CVE-2016-5735)
Reported by Choi Jaeseung
Found with Sparrow (http://ropas.snu.ac.kr/sparrow) | b7c217680cda02dddced245d237ebe8c383be285 | pngquant | bigvul | 1 | null | null | null |
Fix division by zero
Fix uclouvain/openjpeg#733 | 8f9cc62b3f9a1da9712329ddcedb9750d585505c | openjpeg | bigvul | 1 | null | null | null |
Fix Heap Buffer Overflow in function color_cmyk_to_rgb
Fix uclouvain/openjpeg#774 | 162f6199c0cd3ec1c6c6dc65e41b2faab92b2d91 | openjpeg | bigvul | 1 | null | null | null |
acpi: Disable APEI error injection if securelevel is set
ACPI provides an error injection mechanism, EINJ, for debugging and testing
the ACPI Platform Error Interface (APEI) and other RAS features. If
supported by the firmware, ACPI specification 5.0 and later provide for a
way to specify a physical memory address to which to inject the error.
Injecting errors through EINJ can produce errors which to the platform are
indistinguishable from real hardware errors. This can have undesirable
side-effects, such as causing the platform to mark hardware as needing
replacement.
While it does not provide a method to load unauthenticated privileged code,
the effect of these errors may persist across reboots and affect trust in
the underlying hardware, so disable error injection through EINJ if
securelevel is set.
Signed-off-by: Linn Crosetto <[email protected]> | d7a6be58edc01b1c66ecd8fcc91236bfbce0a420 | linux | bigvul | 1 | null | null | null |
Fix Out-Of-Bounds Read in sycc42x_to_rgb function (#745)
42x Images with an odd x0/y0 lead to subsampled component starting at the
2nd column/line.
That is offset = comp->dx * comp->x0 - image->x0 = 1
Fix #726 | 15f081c89650dccee4aa4ae66f614c3fdb268767 | openjpeg | bigvul | 1 | null | null | null |
minissdpd.c: Initialize pointers to NULL (fix) | 140ee8d2204b383279f854802b27bdb41c1d5d1a | miniupnp | bigvul | 1 | null | null | null |
minissdpd: Fix broken overflow test (p+l > buf+n) thanks to Salva Piero | b238cade9a173c6f751a34acf8ccff838a62aa47 | miniupnp | bigvul | 1 | null | null | null |
Fix integer underflow vulnerability in L3 decode.
Marcin 'Icewall' Noga of Cisco TALOS discovered that the level 3 header
decoding routines were vulnerable to an integer underflow, if the 32-bit
header length was less than the base level 3 header length. This could
lead to an exploitable heap corruption condition.
Thanks go to Marcin Noga and Regina Wilson of Cisco TALOS for reporting
this vulnerability. | 6fcdb8f1f538b9d63e63a5fa199c5514a15d4564 | lhasa | bigvul | 1 | null | null | null |
zebra: stack overrun in IPv6 RA receive code (CVE-2016-1245)
The IPv6 RA code also receives ICMPv6 RS and RA messages.
Unfortunately, by bad coding practice, the buffer size specified on
receiving such messages mixed up 2 constants that in fact have
different values.
The code itself has:
#define RTADV_MSG_SIZE 4096
While BUFSIZ is system-dependent, in my case (x86_64 glibc):
/usr/include/_G_config.h:#define _G_BUFSIZ 8192
/usr/include/libio.h:#define _IO_BUFSIZ _G_BUFSIZ
/usr/include/stdio.h:# define BUFSIZ _IO_BUFSIZ
FreeBSD, OpenBSD, NetBSD and Illumos are not affected, since all of them
have BUFSIZ == 1024.
As the latter is passed to the kernel on recvmsg(), it's possible to
overwrite 4kB of stack -- with ICMPv6 packets that can be globally sent
to any of the system's addresses (using fragmentation to get to 8k).
(The socket has filters installed limiting this to RS and RA packets,
but does not have a filter for source address or TTL.)
Issue discovered by trying to test other stuff, which randomly caused
the stack to be smaller than 8kB in that code location, which then
causes the kernel to report EFAULT (Bad address).
Signed-off-by: David Lamparter <[email protected]>
Reviewed-by: Donald Sharp <[email protected]> | cfb1fae25f8c092e0d17073eaf7bd428ce1cd546 | quagga | bigvul | 1 | null | null | null |
Do not use "/bin/sh" to run external commands.
Picocom no longer uses /bin/sh to run external commands for
file-transfer operations. Parsing the command line and spliting it into
arguments is now performed internally by picocom, using quoting rules
very similar to those of the Unix shell. Hopefully, this makes it
impossible to inject shell-commands when supplying filenames or
extra arguments to the send- and receive-file commands. | 1ebc60b20fbe9a02436d5cbbf8951714e749ddb1 | picocom | bigvul | 1 | null | null | null |
perf: Tighten (and fix) the grouping condition
The fix from 9fc81d87420d ("perf: Fix events installation during
moving group") was incomplete in that it failed to recognise that
creating a group with events for different CPUs is semantically
broken -- they cannot be co-scheduled.
Furthermore, it leads to real breakage where, when we create an event
for CPU Y and then migrate it to form a group on CPU X, the code gets
confused where the counter is programmed -- triggered in practice
as well by me via the perf fuzzer.
Fix this by tightening the rules for creating groups. Only allow
grouping of counters that can be co-scheduled in the same context.
This means for the same task and/or the same cpu.
Fixes: 9fc81d87420d ("perf: Fix events installation during moving group")
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Linus Torvalds <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]> | c3c87e770458aa004bd7ed3f29945ff436fd6511 | linux | bigvul | 1 | null | null | null |
http://www.imagemagick.org/discourse-server/viewtopic.php?f=3&t=26857 | b8f17d08b7418204bf8a05a5c24e87b2fc395b75 | imagemagick | bigvul | 1 | null | null | null |
http://www.imagemagick.org/discourse-server/viewtopic.php?f=3&t=26848 | bd96074b254c6607a0f7731e59f923ad19d5a46d | imagemagick | bigvul | 1 | null | null | null |
Fixed infinite loop and added checks for the sscanf result. | 97aa7d7cfd2027f6ba7ce42caf8b798541b9cdc6 | imagemagick | bigvul | 1 | null | null | null |
https://github.com/ImageMagick/ImageMagick/pull/34 | 5b4bebaa91849c592a8448bc353ab25a54ff8c44 | imagemagick | bigvul | 1 | null | null | null |
Fixed out of bounds error in SpliceImage. | 7b1cf5784b5bcd85aa9293ecf56769f68c037231 | imagemagick | bigvul | 1 | null | null | null |
https://bugs.launchpad.net/ubuntu/+source/imagemagick/+bug/1490362 | 4f68e9661518463fca523c9726bb5d940a2aa6d8 | imagemagick | bigvul | 1 | null | null | null |
A DWARF related section marked SHT_NOBITS (elf section type)
is an error in the elf object. Now detected.
dwarf_elf_access.c | 11750a2838e52953013e3114ef27b3c7b1780697 | libdwarf | bigvul | 1 | null | null | null |
Check sector and cluster size before use.
Otherwise malformed FS can cause heap corruption. | 2e86ae5f81da11f11673d0546efb525af02b7786 | exfat | bigvul | 1 | null | null | null |
Subsets and Splits